From nobody Wed Dec 17 15:41:29 2025 Received: from fllvem-ot03.ext.ti.com (fllvem-ot03.ext.ti.com [198.47.19.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 973161EFF8B; Tue, 13 May 2025 05:46:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.19.245 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747115184; cv=none; b=RrMTxxihTqLgITUwjw+yCFjKtvXSNwiaBKOYfl/Jv9hFB4BHyX1MliMyXZCcg+ZKi7KmCgMwU7HP3eRIG82TfqvaQ9U8m+tH+9mBsoBdYsK8IpZZTNtXTu5JGS1MQK0aXQFc0qLH5GjCkjjv3JN6OirPggZDbv1+jCzcYABz+b8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747115184; c=relaxed/simple; bh=ay9Ppfj0l5VqF+zejjVMMmKrRmSfzYMnC4pCANm9cKs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=n7StzWYhm1XtZn9tOymeRa7KsE+wjNDUj/uXETXqgr8G7F8R0qAhy/6X/chSgawPzfU5KvXKZgVVg/LR57LCwA2FH9+TG24+EUMnSa4UgMQs2CupIchLZqfckpOwt0SnXCZC0uon4TTmvJdsjY1UnYY3jcFKb1uRa7UINvTgQUQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=B9SDw++8; arc=none smtp.client-ip=198.47.19.245 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="B9SDw++8" Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllvem-ot03.ext.ti.com (8.15.2/8.15.2) with ESMTPS id 54D5kDax2210835 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 May 2025 00:46:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1747115173; bh=oACxMk87vRJHH2iEA+ZG18jdsUjes+8B7Pyy3bMFq0o=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=B9SDw++8xNu0rNVDB01H78XMRpVRx+fYWc654TcITJt2DAz02gaV2MiHJfczqm1f1 b4njWznemJ4qmsSVk4FJIv8qd4FXvrAHKy8sCYEjAtY29SDHVxQIcQOTe2dk3O/mSv +OXgpEbokUaJvMxhVaR83Qz+Y/Qf7u1VdtPuIEKI= Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 54D5kDJA088724 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 13 May 2025 00:46:13 -0500 Received: from DFLE102.ent.ti.com (10.64.6.23) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 13 May 2025 00:46:12 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 13 May 2025 00:46:13 -0500 Received: from uda0510294.dhcp.ti.com (uda0510294.dhcp.ti.com [172.24.227.151]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 54D5jAqN131001; Tue, 13 May 2025 00:46:09 -0500 From: Beleswar Padhi To: , CC: , , , , , , , , , , Subject: [PATCH v12 14/36] remoteproc: k3: Refactor .kick rproc ops into common driver Date: Tue, 13 May 2025 11:14:48 +0530 Message-ID: <20250513054510.3439842-15-b-padhi@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250513054510.3439842-1-b-padhi@ti.com> References: <20250513054510.3439842-1-b-padhi@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea Content-Type: text/plain; charset="utf-8" The .kick rproc ops implementations in TI K3 R5, DSP and M4 remoteproc drivers sends a mailbox message to the remote processor in the same way. Refactor the implementations into a common function 'k3_rproc_kick()' in the ti_k3_common.c driver. Signed-off-by: Beleswar Padhi Acked-by: Andrew Davis Tested-by: Judith Mendez Reviewed-by: Andrew Davis --- v12: Changelog: 1. Carried R/B tag. Link to v11: https://lore.kernel.org/all/20250425104135.830255-14-b-padhi@ti.com/ v11: Changelog: 1. Carried T/B and A/B tags. Link to v10: https://lore.kernel.org/all/20250417182001.3903905-14-b-padhi@ti.com/ v10: Changelog: None Link to v9: https://lore.kernel.org/all/20250317120622.1746415-12-b-padhi@ti.com/ drivers/remoteproc/ti_k3_common.c | 25 ++++++++++++++++++++++ drivers/remoteproc/ti_k3_common.h | 1 + drivers/remoteproc/ti_k3_dsp_remoteproc.c | 22 +------------------ drivers/remoteproc/ti_k3_m4_remoteproc.c | 26 +---------------------- drivers/remoteproc/ti_k3_r5_remoteproc.c | 17 +-------------- 5 files changed, 29 insertions(+), 62 deletions(-) diff --git a/drivers/remoteproc/ti_k3_common.c b/drivers/remoteproc/ti_k3_c= ommon.c index 6ec8c3af19918..c4a9e5df0ea59 100644 --- a/drivers/remoteproc/ti_k3_common.c +++ b/drivers/remoteproc/ti_k3_common.c @@ -84,5 +84,30 @@ void k3_rproc_mbox_callback(struct mbox_client *client, = void *data) } EXPORT_SYMBOL_GPL(k3_rproc_mbox_callback); =20 +/* + * Kick the remote processor to notify about pending unprocessed messages. + * The vqid usage is not used and is inconsequential, as the kick is perfo= rmed + * through a simulated GPIO (a bit in an IPC interrupt-triggering register= ), + * the remote processor is expected to process both its Tx and Rx virtqueu= es. + */ +void k3_rproc_kick(struct rproc *rproc, int vqid) +{ + struct k3_rproc *kproc =3D rproc->priv; + struct device *dev =3D kproc->dev; + u32 msg =3D (u32)vqid; + int ret; + + /* + * Send the index of the triggered virtqueue in the mailbox payload. + * NOTE: msg is cast to uintptr_t to prevent compiler warnings when + * void* is 64bit. It is safely cast back to u32 in the mailbox driver. + */ + ret =3D mbox_send_message(kproc->mbox, (void *)(uintptr_t)msg); + if (ret < 0) + dev_err(dev, "failed to send mailbox message, status =3D %d\n", + ret); +} +EXPORT_SYMBOL_GPL(k3_rproc_kick); + MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("TI K3 common Remoteproc code"); diff --git a/drivers/remoteproc/ti_k3_common.h b/drivers/remoteproc/ti_k3_c= ommon.h index 75c069f21756c..4d9640557c340 100644 --- a/drivers/remoteproc/ti_k3_common.h +++ b/drivers/remoteproc/ti_k3_common.h @@ -94,4 +94,5 @@ struct k3_rproc { }; =20 void k3_rproc_mbox_callback(struct mbox_client *client, void *data); +void k3_rproc_kick(struct rproc *rproc, int vqid); #endif /* REMOTEPROC_TI_K3_COMMON_H */ diff --git a/drivers/remoteproc/ti_k3_dsp_remoteproc.c b/drivers/remoteproc= /ti_k3_dsp_remoteproc.c index 7bd1d5a790cb2..476f4e69d2c11 100644 --- a/drivers/remoteproc/ti_k3_dsp_remoteproc.c +++ b/drivers/remoteproc/ti_k3_dsp_remoteproc.c @@ -24,26 +24,6 @@ =20 #define KEYSTONE_RPROC_LOCAL_ADDRESS_MASK (SZ_16M - 1) =20 -/* - * Kick the remote processor to notify about pending unprocessed messages. - * The vqid usage is not used and is inconsequential, as the kick is perfo= rmed - * through a simulated GPIO (a bit in an IPC interrupt-triggering register= ), - * the remote processor is expected to process both its Tx and Rx virtqueu= es. - */ -static void k3_dsp_rproc_kick(struct rproc *rproc, int vqid) -{ - struct k3_rproc *kproc =3D rproc->priv; - struct device *dev =3D rproc->dev.parent; - mbox_msg_t msg =3D (mbox_msg_t)vqid; - int ret; - - /* send the index of the triggered virtqueue in the mailbox payload */ - ret =3D mbox_send_message(kproc->mbox, (void *)msg); - if (ret < 0) - dev_err(dev, "failed to send mailbox message (%pe)\n", - ERR_PTR(ret)); -} - /* Put the DSP processor into reset */ static int k3_dsp_rproc_reset(struct k3_rproc *kproc) { @@ -342,7 +322,7 @@ static void *k3_dsp_rproc_da_to_va(struct rproc *rproc,= u64 da, size_t len, bool static const struct rproc_ops k3_dsp_rproc_ops =3D { .start =3D k3_dsp_rproc_start, .stop =3D k3_dsp_rproc_stop, - .kick =3D k3_dsp_rproc_kick, + .kick =3D k3_rproc_kick, .da_to_va =3D k3_dsp_rproc_da_to_va, }; =20 diff --git a/drivers/remoteproc/ti_k3_m4_remoteproc.c b/drivers/remoteproc/= ti_k3_m4_remoteproc.c index 30126f8d9ac70..9dcae94121930 100644 --- a/drivers/remoteproc/ti_k3_m4_remoteproc.c +++ b/drivers/remoteproc/ti_k3_m4_remoteproc.c @@ -21,30 +21,6 @@ #include "ti_sci_proc.h" #include "ti_k3_common.h" =20 -/* - * Kick the remote processor to notify about pending unprocessed messages. - * The vqid usage is not used and is inconsequential, as the kick is perfo= rmed - * through a simulated GPIO (a bit in an IPC interrupt-triggering register= ), - * the remote processor is expected to process both its Tx and Rx virtqueu= es. - */ -static void k3_m4_rproc_kick(struct rproc *rproc, int vqid) -{ - struct k3_rproc *kproc =3D rproc->priv; - struct device *dev =3D kproc->dev; - u32 msg =3D (u32)vqid; - int ret; - - /* - * Send the index of the triggered virtqueue in the mailbox payload. - * NOTE: msg is cast to uintptr_t to prevent compiler warnings when - * void* is 64bit. It is safely cast back to u32 in the mailbox driver. - */ - ret =3D mbox_send_message(kproc->mbox, (void *)(uintptr_t)msg); - if (ret < 0) - dev_err(dev, "failed to send mailbox message, status =3D %d\n", - ret); -} - static int k3_m4_rproc_ping_mbox(struct k3_rproc *kproc) { struct device *dev =3D kproc->dev; @@ -448,7 +424,7 @@ static const struct rproc_ops k3_m4_rproc_ops =3D { .stop =3D k3_m4_rproc_stop, .attach =3D k3_m4_rproc_attach, .detach =3D k3_m4_rproc_detach, - .kick =3D k3_m4_rproc_kick, + .kick =3D k3_rproc_kick, .da_to_va =3D k3_m4_rproc_da_to_va, .get_loaded_rsc_table =3D k3_m4_get_loaded_rsc_table, }; diff --git a/drivers/remoteproc/ti_k3_r5_remoteproc.c b/drivers/remoteproc/= ti_k3_r5_remoteproc.c index 5caedc9dad181..337e3711cb143 100644 --- a/drivers/remoteproc/ti_k3_r5_remoteproc.c +++ b/drivers/remoteproc/ti_k3_r5_remoteproc.c @@ -129,21 +129,6 @@ struct k3_r5_core { bool released_from_reset; }; =20 -/* kick a virtqueue */ -static void k3_r5_rproc_kick(struct rproc *rproc, int vqid) -{ - struct k3_rproc *kproc =3D rproc->priv; - struct device *dev =3D rproc->dev.parent; - mbox_msg_t msg =3D (mbox_msg_t)vqid; - int ret; - - /* send the index of the triggered virtqueue in the mailbox payload */ - ret =3D mbox_send_message(kproc->mbox, (void *)msg); - if (ret < 0) - dev_err(dev, "failed to send mailbox message, status =3D %d\n", - ret); -} - static int k3_r5_split_reset(struct k3_rproc *kproc) { int ret; @@ -735,7 +720,7 @@ static const struct rproc_ops k3_r5_rproc_ops =3D { .unprepare =3D k3_r5_rproc_unprepare, .start =3D k3_r5_rproc_start, .stop =3D k3_r5_rproc_stop, - .kick =3D k3_r5_rproc_kick, + .kick =3D k3_rproc_kick, .da_to_va =3D k3_r5_rproc_da_to_va, }; =20 --=20 2.34.1