From nobody Tue Feb 10 08:06:57 2026 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65E50242D77 for ; Tue, 13 May 2025 15:38:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.207.212.93 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747150700; cv=none; b=YAWRYK1xEcYC1pgpaBv7zgK9ltPhAInD1IFhYf7tzVnKBrp6089cMhStDzBAp3OZo5qnvByEs7obTVtvuIEcrj5hUIL0rW3zYGcoRqcNtsszADs32GUq+ep+7FXhOpEV/j9lXatXIH440OOZGI6Uvk0Jak9RwEC2u8VxB/H6PCE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747150700; c=relaxed/simple; bh=skG39v1xIReFqwyoMt3cIkLz1te5hylA+XNsvd74YW0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:To:CC; b=d5Iu3yvDEv6IfZFq0bxRJHviGZw9TH55AXP/8zGvj97Kf6Y+moJxUI9mfHfW5m31W82QE5QYaMDvk7zFgLNDKaKpKZ1xpqy+Sh5Q0v1V0JhzqGDss4u1SBlcPaDE/jWg0o/B5Icd/KaQPAZiY2/BIx0EAfl1KPz5bl03qAg/d94= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=p9JGB16a; arc=none smtp.client-ip=91.207.212.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="p9JGB16a" Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54DDx9qo003335; Tue, 13 May 2025 17:38:07 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=selector1; bh=S0lXHtXZiBNe2UA5zB9pQM WlV9t4LIkccdodCgquO/A=; b=p9JGB16a4j66mxFLU3vLFy8QHAp3DtF+cNhAk0 c4d3mHbEs6GyXdmRMHj08EkDk5LvYCYsONNUTmKdf6K34Hb7kS1RCXDERHkK8gCQ kCtd5/XcUnp9IJyAs+O7t5S1VpxZjV5Ngh/WKLicCvO7tE5htIBF71HSnb6F+pbj MRxtFmsWHSHV1urhK4yxFnaojJF+EWig7cJyKiLtFYbufdRP9MlBglWaBkOB3xUn Ugs66fKGuWDXzPZWHmrOpfYLWQOZmMu8e6azSrAHnGkDigH0xsxpBjGvayIT3+i5 V/fMiDsSRAoe7TA4u4qU18U8aWd4z0jVxcAOZRZg+lPnXCwA== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 46huxacqp5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 May 2025 17:38:07 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id E936C40045; Tue, 13 May 2025 17:36:52 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 66CE2A2A2E5; Tue, 13 May 2025 17:34:38 +0200 (CEST) Received: from localhost (10.48.87.62) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 13 May 2025 17:34:38 +0200 From: Patrice Chotard Date: Tue, 13 May 2025 17:34:31 +0200 Subject: [PATCH] memory: stm32_omm: Fix error handling in stm32_omm_disable_child() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250513-stm32_omm_fix_typo-v1-1-5b90ec8b52e7@foss.st.com> X-B4-Tracking: v=1; b=H4sIAIZmI2gC/x2MQQqAIBAAvyJ7TjDTQ30lQirX2oMaKlFEf086D sPMAxkTYYaBPZDwpEwxVGgbBus+hw052coghdRCtx3PxXfSRO+No8uU+4gcrVuUm1Vv0UINj4T V/dNxet8PcNgQXGQAAAA= X-Change-ID: 20250513-stm32_omm_fix_typo-edfb4fa49ded To: Krzysztof Kozlowski , Maxime Coquelin , Alexandre Torgue , Christophe Kerello CC: Krzysztof Kozlowski , , , , Patrice Chotard X-Mailer: b4 0.14.2 X-ClientProxiedBy: SHFCAS1NODE1.st.com (10.75.129.72) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-13_03,2025-05-09_01,2025-02-21_01 Fix stm32_omm_toggle_child_clock() return value test, we should exit only on non zero value. Fixes: 8181d061dcff ("memory: Add STM32 Octo Memory Manager driver") Signed-off-by: Patrice Chotard --- drivers/memory/stm32_omm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/memory/stm32_omm.c b/drivers/memory/stm32_omm.c index 8523d9601af20fc8fe74cceea84e63d253cafec1..79ceb1635698f6bc8bd4a39fdea= ced1ec318e1f6 100644 --- a/drivers/memory/stm32_omm.c +++ b/drivers/memory/stm32_omm.c @@ -164,7 +164,7 @@ static int stm32_omm_disable_child(struct device *dev) u8 i; =20 ret =3D stm32_omm_toggle_child_clock(dev, true); - if (!ret) + if (ret) return ret; =20 for (i =3D 0; i < omm->nb_child; i++) { --- base-commit: 0169a24036848cf18205301673259bb6879eef97 change-id: 20250513-stm32_omm_fix_typo-edfb4fa49ded Best regards, --=20 Patrice Chotard