From nobody Wed Dec 17 10:47:49 2025 Received: from trager.us (trager.us [52.5.81.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B08D27703A; Mon, 12 May 2025 19:04:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=52.5.81.116 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747076646; cv=none; b=Cyga9zXX0Y6UsTELkWO3UPSXgBu1iCh/WxvazC5PYj58G0poY6baCuBdrvHbrX/nQULtXyB1hib7U4SfvHBAOxVfrGDE2YBCvOZz7v6dtNEh5BQUn0EHjj7Xk0BupyBlj+Yp8SNbdsYU8dMm+L43a6NizvlbP1arSl2z0+pETiw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747076646; c=relaxed/simple; bh=14F66YazLZLOJatq0k1vXnXHl7IvfGSmvJtCa7EE1kY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RrITpvsIoGlFRVk03f+cghWYKSoQGa5w4M149+PaiMdTwvGx89fC2OKypca11R4LG97KitxIZz8gQCuJdxTcvPZs4y+t2GXSNYDGELTIj6jJG7niBsmlPrn2yaebD+bfG45uNnnsJauZECvUbPb3/ErmUfeKyKR3zIKzMKe7XuQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=trager.us; spf=pass smtp.mailfrom=trager.us; arc=none smtp.client-ip=52.5.81.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=trager.us Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=trager.us Received: from [163.114.132.130] (helo=localhost) by trager.us with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1uEYRQ-00071X-QL; Mon, 12 May 2025 19:03:57 +0000 From: Lee Trager To: Alexander Duyck , Jakub Kicinski , kernel-team@meta.com, "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Jonathan Corbet , Andrew Lunn , Jacob Keller , Mohsin Bashir , Sanman Pradhan , Su Hui , Lee Trager , Al Viro Cc: Andrew Lunn , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v5 1/5] pldmfw: Don't require send_package_data or send_component_table to be defined Date: Mon, 12 May 2025 11:53:57 -0700 Message-ID: <20250512190109.2475614-2-lee@trager.us> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250512190109.2475614-1-lee@trager.us> References: <20250512190109.2475614-1-lee@trager.us> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Not all drivers require send_package_data or send_component_table when updating firmware. Instead of forcing drivers to implement a stub allow these functions to go undefined. Signed-off-by: Lee Trager Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman Acked-by: Jacob Keller --- lib/pldmfw/pldmfw.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/pldmfw/pldmfw.c b/lib/pldmfw/pldmfw.c index 6264e2013f25..b45ceb725780 100644 --- a/lib/pldmfw/pldmfw.c +++ b/lib/pldmfw/pldmfw.c @@ -728,6 +728,9 @@ pldm_send_package_data(struct pldmfw_priv *data) struct pldmfw_record *record =3D data->matching_record; const struct pldmfw_ops *ops =3D data->context->ops; + if (!ops->send_package_data) + return 0; + return ops->send_package_data(data->context, record->package_data, record->package_data_len); } @@ -755,6 +758,9 @@ pldm_send_component_tables(struct pldmfw_priv *data) if (!test_bit(index, bitmap)) continue; + if (!data->context->ops->send_component_table) + continue; + /* determine whether this is the start, middle, end, or both * the start and end of the component tables */ -- 2.47.1