From nobody Wed Dec 17 10:47:34 2025 Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43AA51EE031; Mon, 12 May 2025 01:28:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747013296; cv=none; b=Q9l7Cx7il9eCwTXyvoduCXKzwAxYxKEt5VKcs1dLOcvJoCT867ddZndNJ40PBaoBq3x5huY0L0nJYTjMPBx8z+0FYWI0CEZY+9AmLMveLLOTD8moxjnpHQMpravx2/YEw0jIDF+Q8io1gCwjS/VrFLrhm97fbL/vNgYCvSraD70= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747013296; c=relaxed/simple; bh=jsIGs1zqdocllTHIIfn+pRw2YRn8Hm6j68XrsyidPSk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=S7ITWkIDl8kvPFnyx7zcwgJlTKSMj6yMI/fm0KGeQ5VhaimokCrn6LSW7ehyGWYC6b6cr82tG++MkfzkcqFC+5LQlbDLK2a8o9XKs7mnbPKmyEtOuUzxQXzuoYrR2WRHm25gn3WAoWjjTlXn3I8Akc5tWt5HEUHz7AWcU4nf2nA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.163.235]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTPS id 4ZwhnT26HhzKHMnN; Mon, 12 May 2025 09:28:13 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.128]) by mail.maildlp.com (Postfix) with ESMTP id F3ED61A108A; Mon, 12 May 2025 09:28:11 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.104.67]) by APP4 (Coremail) with SMTP id gCh0CgCnC2CdTiFoNFCWMA--.55093S21; Mon, 12 May 2025 09:28:11 +0800 (CST) From: Yu Kuai To: hch@lst.de, xni@redhat.com, colyli@kernel.org, agk@redhat.com, snitzer@kernel.org, mpatocka@redhat.com, song@kernel.org, yukuai3@huawei.com Cc: linux-kernel@vger.kernel.org, dm-devel@lists.linux.dev, linux-raid@vger.kernel.org, yukuai1@huaweicloud.com, yi.zhang@huawei.com, yangerkun@huawei.com, johnny.chenyi@huawei.com Subject: [PATCH RFC md-6.16 v3 17/19] md/md-llbitmap: implement all bitmap operations Date: Mon, 12 May 2025 09:19:25 +0800 Message-Id: <20250512011927.2809400-18-yukuai1@huaweicloud.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20250512011927.2809400-1-yukuai1@huaweicloud.com> References: <20250512011927.2809400-1-yukuai1@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: gCh0CgCnC2CdTiFoNFCWMA--.55093S21 X-Coremail-Antispam: 1UD129KBjvJXoWxuF15JFykZF1kKrWkAry5urg_yoWrCF1DpF 4aqFy5Gr45JFyfWw13Jr9rZF1Fyrs7tr9Fqr97C34rGF15CrZxKF48WFyUJ34DXryfJFn8 Aw45GF4rCrWrXF7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUmS14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2048vs2IY020E87I2jVAFwI0_JF0E3s1l82xGYI kIc2x26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2 z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j6F 4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oVCq 3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7 IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4U M4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02628vn2 kIc2xKxwCY1x0262kKe7AKxVWUtVW8ZwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkE bVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67 AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVW8JVW5JwCI 42IY6xIIjxv20xvEc7CjxVAFwI0_Gr1j6F4UJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF 4lIxAIcVC2z280aVAFwI0_Gr0_Cr1lIxAIcVC2z280aVCY1x0267AKxVW8Jr0_Cr1UYxBI daVFxhVjvjDU0xZFpf9x0JUQFxUUUUUU= X-CM-SenderInfo: 51xn3trlr6x35dzhxuhorxvhhfrp/ Content-Type: text/plain; charset="utf-8" From: Yu Kuai Include following left APIs - llbitmap_enabled - llbitmap_dirty_bits - llbitmap_update_sb And following APIs that are not needed: - llbitmap_write_all, used in old bitmap to mark all pages need writeback; - llbitmap_daemon_work, used in old bitmap, llbitmap use timer to trigger daemon; - llbitmap_cond_end_sync, use to end sync for completed sectors(TODO, don't affect functionality) And following APIs that are not supported: - llbitmap_start_behind_write - llbitmap_end_behind_write - llbitmap_wait_behind_writes - llbitmap_sync_with_cluster - llbitmap_get_from_slot - llbitmap_copy_from_slot - llbitmap_set_pages - llbitmap_free Signed-off-by: Yu Kuai --- drivers/md/md-llbitmap.c | 125 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 125 insertions(+) diff --git a/drivers/md/md-llbitmap.c b/drivers/md/md-llbitmap.c index 3169ae8b72be..e381859efcd7 100644 --- a/drivers/md/md-llbitmap.c +++ b/drivers/md/md-llbitmap.c @@ -1159,3 +1159,128 @@ static void llbitmap_close_sync(struct mddev *mddev) =20 llbitmap_state_machine(llbitmap, 0, llbitmap->chunks - 1, BitmapActionEnd= sync); } + +static bool llbitmap_enabled(void *data) +{ + struct llbitmap *llbitmap =3D data; + + return llbitmap && !test_bit(BITMAP_WRITE_ERROR, &llbitmap->flags); +} + +static void llbitmap_dirty_bits(struct mddev *mddev, unsigned long s, + unsigned long e) +{ + llbitmap_state_machine(mddev->bitmap, s, e, BitmapActionStartwrite); +} + +static void llbitmap_write_sb(struct llbitmap *llbitmap) +{ + int nr_bits =3D round_up(BITMAP_SB_SIZE, llbitmap->io_size) / llbitmap->i= o_size; + + bitmap_fill(llbitmap->barrier[0].dirty, nr_bits); + llbitmap_write_page(llbitmap, 0); + md_super_wait(llbitmap->mddev); +} + +static void llbitmap_update_sb(void *data) +{ + struct llbitmap *llbitmap =3D data; + struct mddev *mddev =3D llbitmap->mddev; + struct page *sb_page; + bitmap_super_t *sb; + + if (test_bit(BITMAP_WRITE_ERROR, &llbitmap->flags)) + return; + + sb_page =3D llbitmap_read_page(llbitmap, 0); + if (IS_ERR(sb_page)) { + pr_err("%s: %s: read super block failed", __func__, + mdname(mddev)); + set_bit(BITMAP_WRITE_ERROR, &llbitmap->flags); + return; + } + + if (mddev->events < llbitmap->events_cleared) + llbitmap->events_cleared =3D mddev->events; + + sb =3D kmap_local_page(sb_page); + sb->events =3D cpu_to_le64(mddev->events); + sb->state =3D cpu_to_le32(llbitmap->flags); + sb->chunksize =3D cpu_to_le32(llbitmap->chunksize); + sb->sync_size =3D cpu_to_le64(mddev->resync_max_sectors); + sb->events_cleared =3D cpu_to_le64(llbitmap->events_cleared); + sb->sectors_reserved =3D cpu_to_le32(mddev->bitmap_info.space); + sb->daemon_sleep =3D cpu_to_le32(mddev->bitmap_info.daemon_sleep); + + kunmap_local(sb); + llbitmap_write_sb(llbitmap); +} + +static int llbitmap_get_stats(void *data, struct md_bitmap_stats *stats) +{ + struct llbitmap *llbitmap =3D data; + + memset(stats, 0, sizeof(*stats)); + + stats->missing_pages =3D 0; + stats->pages =3D llbitmap->nr_pages; + stats->file_pages =3D llbitmap->nr_pages; + + return 0; +} + +static void llbitmap_write_all(struct mddev *mddev) +{ + +} + +static void llbitmap_daemon_work(struct mddev *mddev) +{ + +} + +static void llbitmap_start_behind_write(struct mddev *mddev) +{ + +} + +static void llbitmap_end_behind_write(struct mddev *mddev) +{ + +} + +static void llbitmap_wait_behind_writes(struct mddev *mddev) +{ + +} + +static void llbitmap_cond_end_sync(struct mddev *mddev, sector_t sector, + bool force) +{ +} + +static void llbitmap_sync_with_cluster(struct mddev *mddev, + sector_t old_lo, sector_t old_hi, + sector_t new_lo, sector_t new_hi) +{ + +} + +static void *llbitmap_get_from_slot(struct mddev *mddev, int slot) +{ + return ERR_PTR(-EOPNOTSUPP); +} + +static int llbitmap_copy_from_slot(struct mddev *mddev, int slot, sector_t= *low, + sector_t *high, bool clear_bits) +{ + return -EOPNOTSUPP; +} + +static void llbitmap_set_pages(void *data, unsigned long pages) +{ +} + +static void llbitmap_free(void *data) +{ +} --=20 2.39.2