From nobody Fri Sep 12 01:32:50 2025 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D84D267B6B; Sun, 11 May 2025 20:13:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746994422; cv=none; b=g3IpvIbTS7bOBiSnJxKcWpCH83M0dA0Lxbqlgilv5bUwDtTh6StIj4NXOn6gBR1ZA2/X+WoY0ElS1vxhnflH35h6eeuNlKi675Pix2mYE/eeJOanHTpOJi5fjj0zdmWtRYAkXbt8K2cFE4IFKujI/838dcRTK6FKhb71Ws3IOVU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746994422; c=relaxed/simple; bh=G4Mq4+iIJBI5HfiwtS9iw6HEiPumCZ82bnVQShbfq74=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aYUMRThGvRO2nvoK66i9++sPNrfD4V5ET6utjlncrMoDfgkapDXK5SMDG/CtK4muQq8jh5zEKmWglpjT8S9wTuPhZfXMUfJqVMCnJZ1Ut0RrIl7EZRTlbs5U7ySmuQTetSfkvRXt6F+WrE87q/7CVB7CnspCSQo4oOaED9JGLRc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iZ2/sGsU; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iZ2/sGsU" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-43ce70f9afbso40885505e9.0; Sun, 11 May 2025 13:13:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746994419; x=1747599219; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=E1ldMZzRY48MPhvy74auPiCjGXjOiQBSOuH+++XP3qw=; b=iZ2/sGsUCBPrG7GTiR+82NUe/gT7Q6YDBu2Rcv9vc8uj2Q7Z/4ZgttnMxV0ry2ad/t vYkCRy9cOqoquU67+lZ3c9PCGmi+bHd4nHGRwDAoafwxlW85zQNGftWy27gMDMzgNiWp XxTLVO4Whwdy0FptsIij8TeTH6LwjFdLBmG7bbMR7rpbcek6HKSzlZoEbEEjuGWaaXDK MhudDsYrWMAAgwwv+FKTe/cxDyiB0fr4UvEZNMzCDG2MrI3tP0B4ndUa+OQ/L7x/a5rB /aVWHyoDyab0TsfU6LO5Oq1VHqwQzOH8gOFTtYS6+sd0ktQjthnOrrOwijxaD6aSRuKo 9gvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746994419; x=1747599219; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E1ldMZzRY48MPhvy74auPiCjGXjOiQBSOuH+++XP3qw=; b=pvehmbCyFFy+47JiSd2uVVI/yTfNoMqjzwSKdKr083S/HhYegtEfVwgzpGiLw2md+T qNQeKR1Z/kldKrKuy0GW2DxvsxDL+m3pAxfOIoHhgqUmBQs1gERAhKRBa6yWhjaNV2Fp FFvUJUXOfLWrMQxk6KXpXcvmW8ffODoeySX1HQDrdLckuhecaqzBQTtDA2pH1lSyDmQP iT4I5yud2KnNNCRm/xR48B/Dguw1aGKQbV1pKnHg7YALIQM/owvR1rIqJrTMzaqaENqI nvCpvXSmVb/XesL2saHc1RGrEAvHpUQWJsqDtVCzVOrmuU9H3ljS1M2ptYyVW1axcoSs rRhQ== X-Forwarded-Encrypted: i=1; AJvYcCVVmH5injlrcM53Kr/5pWaIUo1GEscg2ZS2z65PKR8vqrzTiwKA25PMLJWwyBHwKJLXcFvubEdG@vger.kernel.org, AJvYcCVfP7jB9GtOd6PoqGkjs4yU4ApwJ4B5x3mwNgKeHMSZEe5l/4XgySV0sQ0Au6oPtzLPPtboqMjSONPx@vger.kernel.org, AJvYcCXTPD+I01pnlK67YmxKm0MQMsUsKwM1ry+hryueZrn6Ifdw7leeR/He2dpF8FggxM/Q5LBf922xH/WV12FN@vger.kernel.org X-Gm-Message-State: AOJu0YzPoeDztvasXZCWGVDmNSLBFqXRh+f9KlI6iyVBZ9PFYJciCwlS zMJ0RbrlfBVvRfUBcZ0Tq+QmjltTG8oVocAdt7Epb9lexvjB0NBa X-Gm-Gg: ASbGnct1kBVkenv8Ov0XSSgdWkxnNLfWy2AjMgPy8QVoMtMBFH5ienWPQnUKtutfK1T 57sGcpq1Nhh4k1AEvGDZ4Gw+xy2vZf+CQHdKnu9zlL7UpObNbjOGvilWPJTiqBTvfJmv6xXmO6G wN2ooZFEt9Mod2GWn5y526vhj49MGw3L0+3MBPkP9QXbRmUXGshQ85LVZ6VD0RZ55Og1oFC2Vk7 ud0JeQX7JOFuIZsmc/DUD6cPUOhmsz5rFygbyVg4/C8wukEgc/8hQ0lyX1SlQFaSuGPAhhn4OeG UMmRpVlU94E3IdZOqdVRs8Cff/FmsFwBdp7N1BfEbs3l5WRuwuZqTI4S3kU1M2DGFH2zUgUEmL1 N7uAzDKW30oj4lGwCeW0i X-Google-Smtp-Source: AGHT+IHNcYZefBBPiSyJBDsYxacaSeQ7MB6Qh8KUtGFVA2lBNgxp/pOIFsfBehA+M1uENnSRnn+R9A== X-Received: by 2002:a05:600c:3587:b0:43c:fdbe:43be with SMTP id 5b1f17b1804b1-442d6dd216fmr83241275e9.27.1746994418629; Sun, 11 May 2025 13:13:38 -0700 (PDT) Received: from localhost.localdomain (93-34-88-225.ip49.fastwebnet.it. [93.34.88.225]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-442d67ee275sm100615165e9.19.2025.05.11.13.13.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 May 2025 13:13:37 -0700 (PDT) From: Christian Marangi To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lorenzo Bianconi , Heiner Kallweit , Russell King , Philipp Zabel , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Christian Marangi , Daniel Golle , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, llvm@lists.linux.dev Subject: [net-next PATCH v4 11/11] net: airoha: add phylink support for GDM2/3/4 Date: Sun, 11 May 2025 22:12:37 +0200 Message-ID: <20250511201250.3789083-12-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250511201250.3789083-1-ansuelsmth@gmail.com> References: <20250511201250.3789083-1-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add phylink support for GDM2/3/4 port that require configuration of the PCS to make the external PHY or attached SFP cage work. These needs to be defined in the GDM port node using the pcs-handle property. Signed-off-by: Christian Marangi --- drivers/net/ethernet/airoha/airoha_eth.c | 155 +++++++++++++++++++++- drivers/net/ethernet/airoha/airoha_eth.h | 3 + drivers/net/ethernet/airoha/airoha_regs.h | 12 ++ 3 files changed, 169 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/airoha/airoha_eth.c b/drivers/net/etherne= t/airoha/airoha_eth.c index 16c7896f931f..3be1ae077a76 100644 --- a/drivers/net/ethernet/airoha/airoha_eth.c +++ b/drivers/net/ethernet/airoha/airoha_eth.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -79,6 +80,11 @@ static bool airhoa_is_lan_gdm_port(struct airoha_gdm_por= t *port) return port->id =3D=3D 1; } =20 +static bool airhoa_is_phy_external(struct airoha_gdm_port *port) +{ + return port->id !=3D 1; +} + static void airoha_set_macaddr(struct airoha_gdm_port *port, const u8 *add= r) { struct airoha_eth *eth =3D port->qdma->eth; @@ -1613,6 +1619,17 @@ static int airoha_dev_open(struct net_device *dev) struct airoha_gdm_port *port =3D netdev_priv(dev); struct airoha_qdma *qdma =3D port->qdma; =20 + if (airhoa_is_phy_external(port)) { + err =3D phylink_of_phy_connect(port->phylink, dev->dev.of_node, 0); + if (err) { + netdev_err(dev, "%s: could not attach PHY: %d\n", __func__, + err); + return err; + } + + phylink_start(port->phylink); + } + netif_tx_start_all_queues(dev); err =3D airoha_set_vip_for_gdm_port(port, true); if (err) @@ -1665,6 +1682,11 @@ static int airoha_dev_stop(struct net_device *dev) } } =20 + if (airhoa_is_phy_external(port)) { + phylink_stop(port->phylink); + phylink_disconnect_phy(port->phylink); + } + return 0; } =20 @@ -2795,6 +2817,115 @@ bool airoha_is_valid_gdm_port(struct airoha_eth *et= h, return false; } =20 +static void airoha_mac_link_up(struct phylink_config *config, struct phy_d= evice *phy, + unsigned int mode, phy_interface_t interface, + int speed, int duplex, bool tx_pause, bool rx_pause) +{ + struct airoha_gdm_port *port =3D container_of(config, struct airoha_gdm_p= ort, + phylink_config); + struct airoha_qdma *qdma =3D port->qdma; + struct airoha_eth *eth =3D qdma->eth; + u32 frag_size_tx, frag_size_rx; + + if (port->id !=3D 4) + return; + + switch (speed) { + case SPEED_10000: + case SPEED_5000: + frag_size_tx =3D 8; + frag_size_rx =3D 8; + break; + case SPEED_2500: + frag_size_tx =3D 2; + frag_size_rx =3D 1; + break; + default: + frag_size_tx =3D 1; + frag_size_rx =3D 0; + } + + /* Configure TX/RX frag based on speed */ + airoha_fe_rmw(eth, REG_GDMA4_TMBI_FRAG, + GDMA4_SGMII0_TX_FRAG_SIZE_MASK, + FIELD_PREP(GDMA4_SGMII0_TX_FRAG_SIZE_MASK, + frag_size_tx)); + + airoha_fe_rmw(eth, REG_GDMA4_RMBI_FRAG, + GDMA4_SGMII0_RX_FRAG_SIZE_MASK, + FIELD_PREP(GDMA4_SGMII0_RX_FRAG_SIZE_MASK, + frag_size_rx)); +} + +static const struct phylink_mac_ops airoha_phylink_ops =3D { + .mac_link_up =3D airoha_mac_link_up, +}; + +static int airoha_setup_phylink(struct net_device *dev) +{ + struct airoha_gdm_port *port =3D netdev_priv(dev); + struct device_node *np =3D dev->dev.of_node; + struct phylink_pcs **available_pcs; + phy_interface_t phy_mode; + struct phylink *phylink; + unsigned int num_pcs; + int err; + + err =3D of_get_phy_mode(np, &phy_mode); + if (err) { + dev_err(&dev->dev, "incorrect phy-mode\n"); + return err; + } + + port->phylink_config.dev =3D &dev->dev; + port->phylink_config.type =3D PHYLINK_NETDEV; + port->phylink_config.mac_capabilities =3D MAC_ASYM_PAUSE | MAC_SYM_PAUSE | + MAC_10 | MAC_100 | MAC_1000 | MAC_2500FD | + MAC_5000FD | MAC_10000FD; + + err =3D fwnode_phylink_pcs_parse(dev_fwnode(&dev->dev), NULL, &num_pcs); + if (err) + return err; + + available_pcs =3D kcalloc(num_pcs, sizeof(*available_pcs), GFP_KERNEL); + if (!available_pcs) + return -ENOMEM; + + err =3D fwnode_phylink_pcs_parse(dev_fwnode(&dev->dev), available_pcs, + &num_pcs); + if (err) + goto out; + + port->phylink_config.available_pcs =3D available_pcs; + port->phylink_config.num_available_pcs =3D num_pcs; + + __set_bit(PHY_INTERFACE_MODE_SGMII, + port->phylink_config.supported_interfaces); + __set_bit(PHY_INTERFACE_MODE_1000BASEX, + port->phylink_config.supported_interfaces); + __set_bit(PHY_INTERFACE_MODE_2500BASEX, + port->phylink_config.supported_interfaces); + __set_bit(PHY_INTERFACE_MODE_USXGMII, + port->phylink_config.supported_interfaces); + + phy_interface_copy(port->phylink_config.pcs_interfaces, + port->phylink_config.supported_interfaces); + + phylink =3D phylink_create(&port->phylink_config, + of_fwnode_handle(np), + phy_mode, &airoha_phylink_ops); + if (IS_ERR(phylink)) { + err =3D PTR_ERR(phylink); + goto out; + } + + port->phylink =3D phylink; +out: + kfree(available_pcs); + + return err; +} + static int airoha_alloc_gdm_port(struct airoha_eth *eth, struct device_node *np, int index) { @@ -2873,7 +3004,23 @@ static int airoha_alloc_gdm_port(struct airoha_eth *= eth, if (err) return err; =20 - return register_netdev(dev); + if (airhoa_is_phy_external(port)) { + err =3D airoha_setup_phylink(dev); + if (err) + return err; + } + + err =3D register_netdev(dev); + if (err) + goto free_phylink; + + return 0; + +free_phylink: + if (airhoa_is_phy_external(port)) + phylink_destroy(port->phylink); + + return err; } =20 static int airoha_probe(struct platform_device *pdev) @@ -2967,6 +3114,9 @@ static int airoha_probe(struct platform_device *pdev) struct airoha_gdm_port *port =3D eth->ports[i]; =20 if (port && port->dev->reg_state =3D=3D NETREG_REGISTERED) { + if (airhoa_is_phy_external(port)) + phylink_destroy(port->phylink); + unregister_netdev(port->dev); airoha_metadata_dst_free(port); } @@ -2994,6 +3144,9 @@ static void airoha_remove(struct platform_device *pde= v) continue; =20 airoha_dev_stop(port->dev); + if (airhoa_is_phy_external(port)) + phylink_destroy(port->phylink); + unregister_netdev(port->dev); airoha_metadata_dst_free(port); } diff --git a/drivers/net/ethernet/airoha/airoha_eth.h b/drivers/net/etherne= t/airoha/airoha_eth.h index 53f39083a8b0..73a500474076 100644 --- a/drivers/net/ethernet/airoha/airoha_eth.h +++ b/drivers/net/ethernet/airoha/airoha_eth.h @@ -498,6 +498,9 @@ struct airoha_gdm_port { struct net_device *dev; int id; =20 + struct phylink *phylink; + struct phylink_config phylink_config; + struct airoha_hw_stats stats; =20 DECLARE_BITMAP(qos_sq_bmap, AIROHA_NUM_QOS_CHANNELS); diff --git a/drivers/net/ethernet/airoha/airoha_regs.h b/drivers/net/ethern= et/airoha/airoha_regs.h index d931530fc96f..54f7079b28b0 100644 --- a/drivers/net/ethernet/airoha/airoha_regs.h +++ b/drivers/net/ethernet/airoha/airoha_regs.h @@ -357,6 +357,18 @@ #define IP_FRAGMENT_PORT_MASK GENMASK(8, 5) #define IP_FRAGMENT_NBQ_MASK GENMASK(4, 0) =20 +#define REG_GDMA4_TMBI_FRAG 0x2028 +#define GDMA4_SGMII1_TX_WEIGHT_MASK GENMASK(31, 26) +#define GDMA4_SGMII1_TX_FRAG_SIZE_MASK GENMASK(25, 16) +#define GDMA4_SGMII0_TX_WEIGHT_MASK GENMASK(15, 10) +#define GDMA4_SGMII0_TX_FRAG_SIZE_MASK GENMASK(9, 0) + +#define REG_GDMA4_RMBI_FRAG 0x202c +#define GDMA4_SGMII1_RX_WEIGHT_MASK GENMASK(31, 26) +#define GDMA4_SGMII1_RX_FRAG_SIZE_MASK GENMASK(25, 16) +#define GDMA4_SGMII0_RX_WEIGHT_MASK GENMASK(15, 10) +#define GDMA4_SGMII0_RX_FRAG_SIZE_MASK GENMASK(9, 0) + #define REG_MC_VLAN_EN 0x2100 #define MC_VLAN_EN_MASK BIT(0) =20 --=20 2.48.1