From nobody Wed Dec 17 08:56:35 2025 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.3]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BD25323505D; Fri, 9 May 2025 15:55:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.3 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746806138; cv=none; b=kgWlmddsyZoODjmodCegpdvuCZ8YY6dnRdWN4lpFaAWZsesHkC2T1TSAt1SAZL3cVs29ICZxxLECSQhIfAKR4QvOV+yO9HCuU/PNQ5PuQgcZjdM5eo6v4Yg4Fn1ObUvGl4WNHUdAeaBRJP3o/Zkn+003LJ0KvdsmQGu1nWMRtys= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746806138; c=relaxed/simple; bh=fj+CsMRTdhR1fX9gY8RgTc+l5nN9Ow3NT2nQ+WxKZ50=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=cjpCeB1fDE6rI9OJTd8uk1Fv+Y1sb/3aMObMvy20vyrexoJ5SoNN3usA3nNtX8PbclSjEB8Tv2OED3kh7m2Mzp+22c0Lsrd/UPjb2UmVpaxFtWx8AOYt+g4yLWUEoMpny/e/9dloVGNV37j5Z8x3XA4ZxT1QpZkLVio0hKby6yU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=K4TmGG/G; arc=none smtp.client-ip=220.197.31.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="K4TmGG/G" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=OK C2LPdw3n8i6eOmbAF8IdjSTk4530z62vZdkc/GbAE=; b=K4TmGG/Gh050AD01ci CGYzNi+IKjeMx3Ur2n6Sex5JqqZ62XFfjPjUkxYn762sl2+ZPxI424t0VffM5boi Blu1K+FDdxI3OcZ8Lkf0r1QUnQagracG39qcLK6fHpLn4cylGci/6DaotPrReWMV j7NOGV7GlfYR/U89vvwV+MVdU= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g0-4 (Coremail) with SMTP id _____wCH+a9CJR5oqYT+AA--.23731S3; Fri, 09 May 2025 23:54:44 +0800 (CST) From: Hans Zhang <18255117159@163.com> To: shawn.lin@rock-chips.com, lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com, heiko@sntech.de, manivannan.sadhasivam@linaro.org Cc: robh@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Hans Zhang <18255117159@163.com> Subject: [PATCH 1/4] PCI: rockchip-host: Fix "Unexpected Completion" log message Date: Fri, 9 May 2025 23:53:59 +0800 Message-Id: <20250509155402.377923-2-18255117159@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250509155402.377923-1-18255117159@163.com> References: <20250509155402.377923-1-18255117159@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wCH+a9CJR5oqYT+AA--.23731S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7XrWrWF4xXF4kArW3Cw1fCrg_yoWkGrcE9r n8u3W7Aw45KrW3A3Wqy3yxtryrAas09a1IkayrtF1ayas2vr10q34kZ3y8JF15ur1DXF9r Kw1qyr47WwnrZjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7sRN73v5UUUUU== X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/1tbiWwdIo2geJBoynAABsQ Content-Type: text/plain; charset="utf-8" Fix the debug message for the PCIE_CORE_INT_UCR interrupt to clearly indicate "Unexpected Completion" instead of a duplicate "malformed TLP" message. This improves error log accuracy. Signed-off-by: Hans Zhang <18255117159@163.com> --- drivers/pci/controller/pcie-rockchip-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/cont= roller/pcie-rockchip-host.c index 6a46be17aa91..2804980bab86 100644 --- a/drivers/pci/controller/pcie-rockchip-host.c +++ b/drivers/pci/controller/pcie-rockchip-host.c @@ -439,7 +439,7 @@ static irqreturn_t rockchip_pcie_subsys_irq_handler(int= irq, void *arg) dev_dbg(dev, "malformed TLP received from the link\n"); =20 if (sub_reg & PCIE_CORE_INT_UCR) - dev_dbg(dev, "malformed TLP received from the link\n"); + dev_dbg(dev, "Unexpected Completion received from the link\n"); =20 if (sub_reg & PCIE_CORE_INT_FCE) dev_dbg(dev, "an error was observed in the flow control advertisements = from the other side\n"); --=20 2.25.1 From nobody Wed Dec 17 08:56:35 2025 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.5]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D60FF22F3B0; Fri, 9 May 2025 15:55:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746806130; cv=none; b=TkLvVwXY1KsFuUfQInCJq0ZWUK7MmM9578vbh+7zXZMhPg3lvJAdvETlp3z67TbG2hzQK5qrEz4QLHeEMdpAzcTMZKKCOl7B5Xdw+fhBIQtET2sJ4y5/5AptLDWVxapiZKtj5Ph0FTCQSVEK/CYHaxthHgxjd4cvrw1/MyJejow= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746806130; c=relaxed/simple; bh=RWQ4XGYVHDZycGxd62P1KIGqj+01EfPS/QKkS6xcxKQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=nhxovWMRVJ+/T7j/NXMkdkF+Ufgy5lEMWnMpIXkkwoNeGZoDI1ClCn4aJU1LT0rgJt2g0ukm+79RTK8q9AkhgtuUXaOJro9MXE0bWDOyf/S7EZThlIk+9jE/2NUkHUzbrTwhod0XPf3pMXWA7E/VB5PJqmg9Z/e/orlBvxnCLDw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=XOezCR2K; arc=none smtp.client-ip=117.135.210.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="XOezCR2K" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=7x riZp5G3YdXkIK9LD+KY/Qb8BNn8y/0CGxYnt75nvI=; b=XOezCR2KtqaqZL0aNI VjUl4PDOUfndplYFo2dTpD8zhFOqP3m9QLE+VuE2iqhrkE9sDvpyQjfn7JxoAnmz el/BVm3A4xP1tkPgtFxjVqvwCiwzt+ESgzUxYG/yCizYoiirttllG+9Qda3Cdtne cLNAIPHjuRkuHvqS6cUoZq9+Y= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g0-4 (Coremail) with SMTP id _____wCH+a9CJR5oqYT+AA--.23731S4; Fri, 09 May 2025 23:54:44 +0800 (CST) From: Hans Zhang <18255117159@163.com> To: shawn.lin@rock-chips.com, lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com, heiko@sntech.de, manivannan.sadhasivam@linaro.org Cc: robh@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Hans Zhang <18255117159@163.com> Subject: [PATCH 2/4] PCI: rockchip-host: Correct non-fatal error log message Date: Fri, 9 May 2025 23:54:00 +0800 Message-Id: <20250509155402.377923-3-18255117159@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250509155402.377923-1-18255117159@163.com> References: <20250509155402.377923-1-18255117159@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wCH+a9CJR5oqYT+AA--.23731S4 X-Coremail-Antispam: 1Uf129KBjvdXoWrZr4ruF1fCr4DAry5tFyrWFg_yoWDKrcE9r 1jva47Zw4UKr9ag3Zay3ySqr9xAasI9r4Iya1rKF1aya47Xr1Fq348Zwn8JFn5Cr15tF9F g3sFyFWUuF43ujkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRurWrJUUUUU== X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/1tbiWwxIo2geJBoy0wAAsV Content-Type: text/plain; charset="utf-8" Correct the debug message for PCIE_CLIENT_INT_NFATAL_ERR from "no fatal error" to "non fatal error interrupt received" to match the actual interrupt semantics. This avoids confusion in log interpretation. Signed-off-by: Hans Zhang <18255117159@163.com> --- drivers/pci/controller/pcie-rockchip-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/cont= roller/pcie-rockchip-host.c index 2804980bab86..209eb94ece1b 100644 --- a/drivers/pci/controller/pcie-rockchip-host.c +++ b/drivers/pci/controller/pcie-rockchip-host.c @@ -489,7 +489,7 @@ static irqreturn_t rockchip_pcie_client_irq_handler(int= irq, void *arg) dev_dbg(dev, "fatal error interrupt received\n"); =20 if (reg & PCIE_CLIENT_INT_NFATAL_ERR) - dev_dbg(dev, "no fatal error interrupt received\n"); + dev_dbg(dev, "non fatal error interrupt received\n"); =20 if (reg & PCIE_CLIENT_INT_CORR_ERR) dev_dbg(dev, "correctable error interrupt received\n"); --=20 2.25.1 From nobody Wed Dec 17 08:56:35 2025 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.4]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0216B225405; Fri, 9 May 2025 15:55:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.4 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746806126; cv=none; b=Gm3H8XaXxg8F6+TqcW8V0z0ulGmB+KMK8z02+9vhEllpPBrgs2ZPAy/2XO6w6vWkBh6M15K+U3yeOkwIBtwgZqiDa/JUBkkug8WLd/xYm+jkHIDMwe1mp9BY0t1nWfpoo3xXaD/NSIifij1aLUHE6NWYya0VflJmEDCLOz4KIJI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746806126; c=relaxed/simple; bh=od8nP8o0UlODMNkoyBI4gReWiVWh67aEDsUBdwCRDNg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=KeXb43i+DsLZZ4B2UuSLocSSz8MAyQjKrcxxdHuMatqADS+lDamwB6G//MwKhivVW1FSuMydBw59tHRe3yMxw5QJ0b4SwzAoM9N2p7FKISnNXXCBjxIfGy5Nnd3Xu6WDv/QpsXoGbfvJNd/N59xsp79kn84kCfc6aeDHa+rx2ss= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=PR9ov2Qu; arc=none smtp.client-ip=117.135.210.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="PR9ov2Qu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=lv ElYGxbUgfGLHwTggNkO6oW/94xCB8HSeEjWFVcDz0=; b=PR9ov2QujZ5597Hu+c hexQ+mdYPSQHxc5O4IrchlCD+aLmL0nq23Ry1Cwy6nLwckpATO99bON7Aerqdd2n j8gB73BT8Kus+WxrKMUhRnRaCkEMlI1bJzesQjPEtI2Lrl44S4ToqelxjxFhVqAf jBYl8SYCgvqTHb+MOxZUdvi5o= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g0-4 (Coremail) with SMTP id _____wCH+a9CJR5oqYT+AA--.23731S5; Fri, 09 May 2025 23:54:45 +0800 (CST) From: Hans Zhang <18255117159@163.com> To: shawn.lin@rock-chips.com, lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com, heiko@sntech.de, manivannan.sadhasivam@linaro.org Cc: robh@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Hans Zhang <18255117159@163.com> Subject: [PATCH 3/4] PCI: rockchip-host: Refactor IRQ handling with info arrays Date: Fri, 9 May 2025 23:54:01 +0800 Message-Id: <20250509155402.377923-4-18255117159@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250509155402.377923-1-18255117159@163.com> References: <20250509155402.377923-1-18255117159@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wCH+a9CJR5oqYT+AA--.23731S5 X-Coremail-Antispam: 1Uf129KBjvJXoW3Jw1rWF1xuF15Gw4Dtr4ktFb_yoW7tF1rp3 yUtFnrAr48Xw1fZr9Iyw15X3WrXFnI9aykCrs3G3y7Z3Wvyw1jga1jgFZxWw1IgFWDX342 kw43tF97ZFsruFJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zR9NVJUUUUU= X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/1tbiWxRIo2geJBoy5wAAs5 Content-Type: text/plain; charset="utf-8" Replace repetitive if-conditions for IRQ status checks with structured arrays (`pcie_subsys_irq_info` and `pcie_client_irq_info`) and loop-based logging. This simplifies maintenance and reduces code duplication. Signed-off-by: Hans Zhang <18255117159@163.com> --- drivers/pci/controller/pcie-rockchip-host.c | 110 +++++++++----------- 1 file changed, 48 insertions(+), 62 deletions(-) diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/cont= roller/pcie-rockchip-host.c index 209eb94ece1b..ba1f7832bda5 100644 --- a/drivers/pci/controller/pcie-rockchip-host.c +++ b/drivers/pci/controller/pcie-rockchip-host.c @@ -36,6 +36,45 @@ #include "../pci.h" #include "pcie-rockchip.h" =20 +struct rockchip_irq_info { + u32 bit; + const char *msg; +}; + +static const struct rockchip_irq_info pcie_subsys_irq_info[] =3D { + { PCIE_CORE_INT_PRFPE, + "parity error detected while reading from the PNP receive FIFO RAM" }, + { PCIE_CORE_INT_CRFPE, + "parity error detected while reading from the Completion Receive FIFO R= AM" }, + { PCIE_CORE_INT_RRPE, + "parity error detected while reading from replay buffer RAM" }, + { PCIE_CORE_INT_PRFO, "overflow occurred in the PNP receive FIFO" }, + { PCIE_CORE_INT_CRFO, + "overflow occurred in the completion receive FIFO" }, + { PCIE_CORE_INT_RT, "replay timer timed out" }, + { PCIE_CORE_INT_RTR, + "replay timer rolled over after 4 transmissions of the same TLP" }, + { PCIE_CORE_INT_PE, "phy error detected on receive side" }, + { PCIE_CORE_INT_MTR, "malformed TLP received from the link" }, + { PCIE_CORE_INT_UCR, "Unexpected Completion received from the link" }, + { PCIE_CORE_INT_FCE, + "an error was observed in the flow control advertisements from the othe= r side" }, + { PCIE_CORE_INT_CT, "a request timed out waiting for completion" }, + { PCIE_CORE_INT_UTC, "unmapped TC error" }, + { PCIE_CORE_INT_MMVC, "MSI mask register changes" }, +}; + +static const struct rockchip_irq_info pcie_client_irq_info[] =3D { + { PCIE_CLIENT_INT_LEGACY_DONE, "legacy done" }, + { PCIE_CLIENT_INT_MSG, "message done" }, + { PCIE_CLIENT_INT_HOT_RST, "hot reset" }, + { PCIE_CLIENT_INT_DPA, "dpa" }, + { PCIE_CLIENT_INT_FATAL_ERR, "fatal error" }, + { PCIE_CLIENT_INT_NFATAL_ERR, "Non fatal error" }, + { PCIE_CLIENT_INT_CORR_ERR, "correctable error" }, + { PCIE_CLIENT_INT_PHY, "phy" }, +}; + static void rockchip_pcie_enable_bw_int(struct rockchip_pcie *rockchip) { u32 status; @@ -411,47 +450,11 @@ static irqreturn_t rockchip_pcie_subsys_irq_handler(i= nt irq, void *arg) if (reg & PCIE_CLIENT_INT_LOCAL) { dev_dbg(dev, "local interrupt received\n"); sub_reg =3D rockchip_pcie_read(rockchip, PCIE_CORE_INT_STATUS); - if (sub_reg & PCIE_CORE_INT_PRFPE) - dev_dbg(dev, "parity error detected while reading from the PNP receive = FIFO RAM\n"); - - if (sub_reg & PCIE_CORE_INT_CRFPE) - dev_dbg(dev, "parity error detected while reading from the Completion R= eceive FIFO RAM\n"); - - if (sub_reg & PCIE_CORE_INT_RRPE) - dev_dbg(dev, "parity error detected while reading from replay buffer RA= M\n"); - - if (sub_reg & PCIE_CORE_INT_PRFO) - dev_dbg(dev, "overflow occurred in the PNP receive FIFO\n"); - - if (sub_reg & PCIE_CORE_INT_CRFO) - dev_dbg(dev, "overflow occurred in the completion receive FIFO\n"); - - if (sub_reg & PCIE_CORE_INT_RT) - dev_dbg(dev, "replay timer timed out\n"); - - if (sub_reg & PCIE_CORE_INT_RTR) - dev_dbg(dev, "replay timer rolled over after 4 transmissions of the sam= e TLP\n"); - - if (sub_reg & PCIE_CORE_INT_PE) - dev_dbg(dev, "phy error detected on receive side\n"); =20 - if (sub_reg & PCIE_CORE_INT_MTR) - dev_dbg(dev, "malformed TLP received from the link\n"); - - if (sub_reg & PCIE_CORE_INT_UCR) - dev_dbg(dev, "Unexpected Completion received from the link\n"); - - if (sub_reg & PCIE_CORE_INT_FCE) - dev_dbg(dev, "an error was observed in the flow control advertisements = from the other side\n"); - - if (sub_reg & PCIE_CORE_INT_CT) - dev_dbg(dev, "a request timed out waiting for completion\n"); - - if (sub_reg & PCIE_CORE_INT_UTC) - dev_dbg(dev, "unmapped TC error\n"); - - if (sub_reg & PCIE_CORE_INT_MMVC) - dev_dbg(dev, "MSI mask register changes\n"); + for (int i =3D 0; i < ARRAY_SIZE(pcie_subsys_irq_info); i++) { + if (sub_reg & pcie_subsys_irq_info[i].bit) + dev_dbg(dev, "%s\n", pcie_subsys_irq_info[i].msg); + } =20 rockchip_pcie_write(rockchip, sub_reg, PCIE_CORE_INT_STATUS); } else if (reg & PCIE_CLIENT_INT_PHY) { @@ -473,29 +476,12 @@ static irqreturn_t rockchip_pcie_client_irq_handler(i= nt irq, void *arg) u32 reg; =20 reg =3D rockchip_pcie_read(rockchip, PCIE_CLIENT_INT_STATUS); - if (reg & PCIE_CLIENT_INT_LEGACY_DONE) - dev_dbg(dev, "legacy done interrupt received\n"); - - if (reg & PCIE_CLIENT_INT_MSG) - dev_dbg(dev, "message done interrupt received\n"); =20 - if (reg & PCIE_CLIENT_INT_HOT_RST) - dev_dbg(dev, "hot reset interrupt received\n"); - - if (reg & PCIE_CLIENT_INT_DPA) - dev_dbg(dev, "dpa interrupt received\n"); - - if (reg & PCIE_CLIENT_INT_FATAL_ERR) - dev_dbg(dev, "fatal error interrupt received\n"); - - if (reg & PCIE_CLIENT_INT_NFATAL_ERR) - dev_dbg(dev, "non fatal error interrupt received\n"); - - if (reg & PCIE_CLIENT_INT_CORR_ERR) - dev_dbg(dev, "correctable error interrupt received\n"); - - if (reg & PCIE_CLIENT_INT_PHY) - dev_dbg(dev, "phy interrupt received\n"); + for (int i =3D 0; i < ARRAY_SIZE(pcie_client_irq_info); i++) { + if (reg & pcie_client_irq_info[i].bit) + dev_dbg(dev, "%s interrupt received\n", + pcie_client_irq_info[i].msg); + } =20 rockchip_pcie_write(rockchip, reg & (PCIE_CLIENT_INT_LEGACY_DONE | PCIE_CLIENT_INT_MSG | PCIE_CLIENT_INT_HOT_RST | --=20 2.25.1 From nobody Wed Dec 17 08:56:35 2025 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.2]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 819782376EC; Fri, 9 May 2025 15:56:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.2 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746806190; cv=none; b=C3ftPMjEi/d+Ae4y1JgnF+CXaxz0Cll8eJt4fLM3TUs1RNYL4e95xyJ8aMjPbZZ7KDrlvrY+wzOWCJ/74PoqVqermGPyL8cfg/NS9ZLDPtfLV6qwW9sfABz2PVIQLjYjm83HNgrvafw3VouyH2GgkiX14sOcoE2rNZNiXcVO9vg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746806190; c=relaxed/simple; bh=xDL4SR8iE4eZctXxjrMatTXbEPFSbQwDhG+e/Jrir5I=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=o0lsHdPyyPpqzi2Xw+uYNXZf2mINNHgCiV1fK5FFrL0wTd6ooUObwd82OAwB2T7UZBPt8M/UcPo7k92qYG4xt75Dgl+3h0RL2GYT36k05MV1ghzH2rx6Q+JAC5EDNZ/xU/fCq6wX5dMRkeovQldxRD860uEg38mpEz5CZw6l2CM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=ER59UXA3; arc=none smtp.client-ip=117.135.210.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="ER59UXA3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=Ht oycmPbpqBasA/drBUodysvfnREG7Bsxmru8dbrqNw=; b=ER59UXA31khSY9WbeL MDhFLDWNjr3qr0JvmCSTZWQ4aqQk+QFeHeEHlgP56JaN8q4p0orern3cx25Od9Qo FtX+f923x9siPOlQyZzxBm5i01bl1fKzTIlI4RCnrxSc57E6D1KCc0jQzMn4ekxR cmoTNvAYZ/3VcLKMr6PTR8L+g= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g0-4 (Coremail) with SMTP id _____wCH+a9CJR5oqYT+AA--.23731S6; Fri, 09 May 2025 23:54:45 +0800 (CST) From: Hans Zhang <18255117159@163.com> To: shawn.lin@rock-chips.com, lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com, heiko@sntech.de, manivannan.sadhasivam@linaro.org Cc: robh@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Hans Zhang <18255117159@163.com> Subject: [PATCH 4/4] PCI: rockchip-host: Remove unused header includes Date: Fri, 9 May 2025 23:54:02 +0800 Message-Id: <20250509155402.377923-5-18255117159@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250509155402.377923-1-18255117159@163.com> References: <20250509155402.377923-1-18255117159@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wCH+a9CJR5oqYT+AA--.23731S6 X-Coremail-Antispam: 1Uf129KBjvJXoW7ZF1fWw17JryxuryDCrW5Awb_yoW8GF1UpF WqkFWxJrZ5AF1UCFnruF1qkr1Yqw4DZw17J342ga47Z342yr1vq395Crnxtr1kAFW2gF15 Cay3trs5CrW5XrJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0pKiiT5UUUUU= X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/xtbBDxxIo2geIgCSFQAAsr Content-Type: text/plain; charset="utf-8" Clean up the driver by removing unnecessary header includes (e.g., , ) that are no longer referenced after refactoring. This improves code readability and build efficiency. Signed-off-by: Hans Zhang <18255117159@163.com> --- drivers/pci/controller/pcie-rockchip-host.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/cont= roller/pcie-rockchip-host.c index ba1f7832bda5..e2c603634bda 100644 --- a/drivers/pci/controller/pcie-rockchip-host.c +++ b/drivers/pci/controller/pcie-rockchip-host.c @@ -12,26 +12,17 @@ */ =20 #include -#include -#include #include -#include #include #include #include #include #include -#include -#include #include #include #include -#include -#include #include #include -#include -#include =20 #include "../pci.h" #include "pcie-rockchip.h" --=20 2.25.1