From nobody Wed Dec 17 10:50:37 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4FC0292094; Fri, 9 May 2025 13:43:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746798220; cv=none; b=Mpspz22VtlC+vyTlAwi8Tkki8QEogw3oJZZXGpct4tADt2geOhrQ23kzIZKiFVS/rFw7UjnCActGwV6Q+p3UzlK0GIHZNppIKyVnYpWmqsV+cxKhvAAhORrCqVhXUA+Ebl9s86TRxvho/Ykg3J0qwEysagzK2Y/I6L7N9CcChrI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746798220; c=relaxed/simple; bh=yayUarAX8X3tfzX0SpaAvhwTSPtyJvnXGGy5hl5BI4s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H7LDZqq5b+rYXV2lK4cChI+MmgHjWKwOftQfLtPNoUK2m0H1wgpDIa5krelxqPKR0GvHwWMJ/0i0M/QLdl5pzzXw9IAmyHueqJgGmBQz14qSutSWG5HzGVkxbCxx3b7aG10FzRQ7qgaA0YkTuMIEKSEHmHBgjM516SnnOgq5oY4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=X/en6uLo; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="X/en6uLo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746798218; x=1778334218; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=yayUarAX8X3tfzX0SpaAvhwTSPtyJvnXGGy5hl5BI4s=; b=X/en6uLoKH0547ubXsWx0clTEZmuBbQ4DfOkJPFIkOy09VzXxiMXT/nB a9RLpx0ATqVjWy2pZyQz/DZbZor1bj7jUNhheoKLDsdrJ/BFjrOfNPPMI GJlok6zInRmXCClQxixnoQd4QS8MypSqnMbZ7jPcf3D3Bf2Ggf45laBoS m1jukiB4iI8z9cIJcPP/HRuXkLPyXcGUY+NCxpb0c63kWLZbxUjKL8ldS c4NrG9syzyF9okgcYA8RxrogMZT8Yu2Gl/K4E25UhVrL9CJ4W2gKIKwcn YkP9XTtg+Aq/ZnrzLqzxOFRUSVn1Kl0gQEJ2IXcSRlVt8GI78e5ZX1Stf g==; X-CSE-ConnectionGUID: JgLnoKIHQluyatPXwnAaPA== X-CSE-MsgGUID: 6xo2/zZ1QzS3WtQ2hNQPTQ== X-IronPort-AV: E=McAfee;i="6700,10204,11427"; a="48532847" X-IronPort-AV: E=Sophos;i="6.15,275,1739865600"; d="scan'208";a="48532847" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2025 06:43:37 -0700 X-CSE-ConnectionGUID: NMw366aTQO2xPbG8vtTnDg== X-CSE-MsgGUID: PsUfP4qYSKu4IV+7lcDWpw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,275,1739865600"; d="scan'208";a="136323181" Received: from irvmail002.ir.intel.com ([10.43.11.120]) by orviesa009.jf.intel.com with ESMTP; 09 May 2025 06:43:31 -0700 Received: from mglak.igk.intel.com (mglak.igk.intel.com [10.237.112.146]) by irvmail002.ir.intel.com (Postfix) with ESMTP id 6EDC134312; Fri, 9 May 2025 14:43:28 +0100 (IST) From: Larysa Zaremba To: intel-wired-lan@lists.osuosl.org, Tony Nguyen Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Przemek Kitszel , Jiri Pirko , Tatyana Nikolova , Andrew Lunn , Alexander Lobakin , Michael Ellerman , Maciej Fijalkowski , Lee Trager , Madhavan Srinivasan , Larysa Zaremba , Sridhar Samudrala , Jacob Keller , Michal Swiatkowski , Mateusz Polchlopek , Ahmed Zaki , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, "Karlsson, Magnus" , Emil Tantilov , Madhu Chittim , Josh Hay , Milena Olech , pavan.kumar.linga@intel.com, "Singhai, Anjali" Subject: [PATCH iwl-next v3 04/15] libeth: allow to create fill queues without NAPI Date: Fri, 9 May 2025 15:43:01 +0200 Message-ID: <20250509134319.66631-5-larysa.zaremba@intel.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20250509134319.66631-1-larysa.zaremba@intel.com> References: <20250509134319.66631-1-larysa.zaremba@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Pavan Kumar Linga Control queues can utilize libeth_rx fill queues, despite working outside of NAPI context. The only problem is standard fill queues requiring NAPI that provides them with the device pointer. Introduce a way to provide the device directly without using NAPI. Suggested-by: Alexander Lobakin Reviewed-by: Maciej Fijalkowski Signed-off-by: Pavan Kumar Linga Signed-off-by: Larysa Zaremba --- drivers/net/ethernet/intel/libeth/rx.c | 9 +++++---- include/net/libeth/rx.h | 4 +++- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/intel/libeth/rx.c b/drivers/net/ethernet/= intel/libeth/rx.c index c0be9cb043a1..b077454c4100 100644 --- a/drivers/net/ethernet/intel/libeth/rx.c +++ b/drivers/net/ethernet/intel/libeth/rx.c @@ -143,19 +143,20 @@ static bool libeth_rx_page_pool_params_zc(struct libe= th_fq *fq, /** * libeth_rx_fq_create - create a PP with the default libeth settings * @fq: buffer queue struct to fill - * @napi: &napi_struct covering this PP (no usage outside its poll loops) + * @napi_dev: &napi_struct for NAPI (data) queues, &device for others * * Return: %0 on success, -%errno on failure. */ -int libeth_rx_fq_create(struct libeth_fq *fq, struct napi_struct *napi) +int libeth_rx_fq_create(struct libeth_fq *fq, void *napi_dev) { + struct napi_struct *napi =3D fq->no_napi ? NULL : napi_dev; struct page_pool_params pp =3D { .flags =3D PP_FLAG_DMA_MAP | PP_FLAG_DMA_SYNC_DEV, .order =3D LIBETH_RX_PAGE_ORDER, .pool_size =3D fq->count, .nid =3D fq->nid, - .dev =3D napi->dev->dev.parent, - .netdev =3D napi->dev, + .dev =3D napi ? napi->dev->dev.parent : napi_dev, + .netdev =3D napi ? napi->dev : NULL, .napi =3D napi, }; struct libeth_fqe *fqes; diff --git a/include/net/libeth/rx.h b/include/net/libeth/rx.h index 5d991404845e..0e736846c5e8 100644 --- a/include/net/libeth/rx.h +++ b/include/net/libeth/rx.h @@ -69,6 +69,7 @@ enum libeth_fqe_type { * @type: type of the buffers this queue has * @hsplit: flag whether header split is enabled * @xdp: flag indicating whether XDP is enabled + * @no_napi: the queue is not a data queue and does not have NAPI * @buf_len: HW-writeable length per each buffer * @nid: ID of the closest NUMA node with memory */ @@ -85,12 +86,13 @@ struct libeth_fq { enum libeth_fqe_type type:2; bool hsplit:1; bool xdp:1; + bool no_napi:1; =20 u32 buf_len; int nid; }; =20 -int libeth_rx_fq_create(struct libeth_fq *fq, struct napi_struct *napi); +int libeth_rx_fq_create(struct libeth_fq *fq, void *napi_dev); void libeth_rx_fq_destroy(struct libeth_fq *fq); =20 /** --=20 2.47.0