From nobody Wed Dec 17 10:43:34 2025 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49E1B274FCE for ; Fri, 9 May 2025 08:59:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746781192; cv=none; b=TPLEHoGSJmYnTM8EKDUBuxbq4T/A0/a+nJzrVR9sWrYbjPiJGxD+kmdY792m6pttZNF2UYYw7Iv30z8per15cSVla7uz+b5bIRVjbO3aCl2wtdtV1iLsex3Xgquqc2rPjIp80wAD52Nh8+d8LHhb4gxmvxFPeFkstUXiD5jsWtI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746781192; c=relaxed/simple; bh=dN37TqGtAW4iOa2jbs7Cudzthti3SyAS+DOD3bmionU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=L46nq7c9+vDRILqWZJz38LPAPRQOmJWuXZ8hm2RWLCof4zjQXBaz5m1Ya2D5dah35kIarfhb7TGxEREDjnhH2jzOu/xX44XBCkyR7Kw4ywE8jyzkm29H3iz1X4sAhB791UfOhYWDrXE9bm8IE3BYtNWe6qpoRUXWOpTG+J8fUIU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=a/4wB04Z; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="a/4wB04Z" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-43ede096d73so12983545e9.2 for ; Fri, 09 May 2025 01:59:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746781187; x=1747385987; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=iC1XUrhKoAzfRL3DmpwkS9UkFLx2+etmwcGscfV3g9w=; b=a/4wB04Z2G8WGdn20e5PV9dLG6laTgRdRClLUpvSDPj5BTKs1IfNxKG90CegCvlUr/ Zhn8IOXznvA5UZ4VeS6XKS2mIwkRUKCC8vb0FsgA5mX3XrKifgwHIhc8U0vipFeGX0rH 6qUp9dhHoT6V3nlVd8vhsTM09yCWkSQ3GmVj9j8F+18pIbhwmPNWNy2GOkqiofLj3wdU soKRdw+2RD7nQkIEIuvF4ev4gozguungwG0sCyTEwLY1X6VHVRUg3DFzXLeLTzWHZiuL vEpjuAhP1y+2c9dYxieFlFUBhyTaKD7aixF1yIxrSrcaPeHclCTo1a/1qwKfcVE05afv 5xzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746781187; x=1747385987; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iC1XUrhKoAzfRL3DmpwkS9UkFLx2+etmwcGscfV3g9w=; b=lV3CWCoS4827Do/3VtRZ+WfQdvd79xeKIIfd1PVaI3qXi74XH5Q48z4sKRZuk69WHt +GLxFdL4UpwyaL89sqRwPjOY5T6cBAA8R+08FKRD6AT6yBHZ8ekBTB6QWI06eR8Cqd88 XktaGYbXAGykoqKi814RRu/+8jXXDq3cg+IWPRO+cSDtfbrqxudzZQ3sZ+xhnZGp2FI8 iycsuWcK0KCNZ3Kq6bGPw0Ouk1HEKvrvEPbdZC9FR2w9bhqQ3s6gTcJq1eSI7SWOQ88z u9Y+/SqLlM5yG/ZS/R9TTrOhaWgohIbRw7H3mkPu8vcMJbIyQ4dPzpAk0k19o97h4wy7 nhgQ== X-Forwarded-Encrypted: i=1; AJvYcCXXfwySUTPeIEB/b+KBUVdJsx0d61WMmyS2py8iBMg7SPkj+UXH3/G4UEIFZqY2in/L4nmvWy2im3yhAss=@vger.kernel.org X-Gm-Message-State: AOJu0YxSF5JG18I1WaStQpNQ/uZxWRbUeclFBaqAzygz+/sylQ1kMarK f8TXR8l5J9Ll02sOqZhUittDLtPnq7pYyG8dV1DPT7yJw/IgDT93qntitUIu3Mo= X-Gm-Gg: ASbGncv0B/8OQkc9j+uLokMdXECHDd31PlaLGqQL/wH3owqC4ou4AvIMMcNAxDf6hd6 80d/rKtBp41lwLsH889K4G0nmgL+3iwjqW93wDPTSXBhp1hxUE/LU4V+65HaCDX6+/dMdj+VnP1 9MC4NWAkxiuDYNzbLWnFaGgUzgZOWOHbV3vy9blR8OTZH3a81W6gl0uwXu52BfnPR/DsPUSMsjG HUvI4cJc/I515krGoDasPLr2QThoJMFV+12CSL7OCZpUaMtLrX351ya/ODR6sCXtAqeVttedmWz xqUq3J6Qpv8sQSbQRE3v5kkjMkhbRwII0kY+EJve2dxYMWgmJGNMd5Alm02M9w== X-Google-Smtp-Source: AGHT+IEwTRbaYhLW+eKsAXK0abPfDBd+lPLDrxQV3TCNwHIkW2G3/B5QrqZiEPvbaIo3GBAyFIokyQ== X-Received: by 2002:a05:600c:1d8c:b0:43d:683:8caa with SMTP id 5b1f17b1804b1-442d6d64644mr20786345e9.15.1746781187478; Fri, 09 May 2025 01:59:47 -0700 (PDT) Received: from arrakeen.starnux.net ([2a01:e0a:3d9:2080:52eb:f6ff:feb3:451a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442d67df639sm22369115e9.13.2025.05.09.01.59.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 May 2025 01:59:47 -0700 (PDT) From: Neil Armstrong Date: Fri, 09 May 2025 10:59:41 +0200 Subject: [PATCH v2 3/6] drm/panel: visionox-rm69299: switch to _multi variants Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250509-topic-misc-shift6-panel-v2-3-c2c2d52abd51@linaro.org> References: <20250509-topic-misc-shift6-panel-v2-0-c2c2d52abd51@linaro.org> In-Reply-To: <20250509-topic-misc-shift6-panel-v2-0-c2c2d52abd51@linaro.org> To: Jessica Zhang , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Abhinav Kumar Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Casey Connolly , Neil Armstrong X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3216; i=neil.armstrong@linaro.org; h=from:subject:message-id; bh=dN37TqGtAW4iOa2jbs7Cudzthti3SyAS+DOD3bmionU=; b=owEBbQKS/ZANAwAKAXfc29rIyEnRAcsmYgBoHcP9zSCgk84BclFuLXnIeyWSCLz/kAsnKXNY/oDo 1ykb6meJAjMEAAEKAB0WIQQ9U8YmyFYF/h30LIt33NvayMhJ0QUCaB3D/QAKCRB33NvayMhJ0W3WD/ 9ZwENFWG05mEkF1pJBoOW+iQOVWmZLuZGgU1955waz/OaskZH1WGIVtXYGLXoK191ocla+lX7p77Sg 7bMdEFUIxNgBV6JyyQa4AlbruCKX7rj3CcvXRmuQTKFpd8gmHcbEioLhruJ6jaEVzXiEZEbzCVhbvg oRtpUtxFf0MXgNLUKOcTK3S5vQDYaAByiyKi8wxtYYy2Wp+lAmz28emu8LnFsM/rD9HGzfSSYJBCIa auzZCTnRCvW6MhCbLGSu1TZYiNi4xc+xwFPSHb9uKLwtLBKjci+5gD0Bz2jHpz1bV9y/ieMu4a55o3 P4L/r2h+MzibJ0wPHsZDiYjlyOGa3MN0angVnI1mG6ea0b+/NPntnLb51ZoDs2OkQ5q4t9jUUzQieV YLNsYWzMsKE/GiBLb88VNEa+JS/e4gRL8m2snBJ0tXutTWuA9Z9Kc9CExr1IqKCbRIxT6+zFQLsCgB corR5CfVUNFgF0royk2kDYxPl6/E9FgfNcYM2OcGdFPa9byxaUw23pZpqFaKpFY50EFz09kIhvl5m2 0d+7htI1NDArTki9K/h3BagXPTxpeLrPIV94nbNdsLgbyWsqWLZdq01lBcZxFRSmwl9BVtAseco8c1 qk5ei8qhofJ10/JiNptsP2FzxB9LG8knt2XwhLyrQ4p3Zxpui27cDWGI1rIw== X-Developer-Key: i=neil.armstrong@linaro.org; a=openpgp; fpr=89EC3D058446217450F22848169AB7B1A4CFF8AE Switch to the DSI _multi variants to simplify error handling. Signed-off-by: Neil Armstrong Reviewed-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-visionox-rm69299.c | 48 +++++++---------------= ---- 1 file changed, 13 insertions(+), 35 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c b/drivers/gpu/d= rm/panel/panel-visionox-rm69299.c index 156bca0197481b470fa85b2eab7c979b76e489b6..c3c14150a5546512151fb15c8e9= a91269ca21c65 100644 --- a/drivers/gpu/drm/panel/panel-visionox-rm69299.c +++ b/drivers/gpu/drm/panel/panel-visionox-rm69299.c @@ -72,30 +72,24 @@ static int visionox_rm69299_power_off(struct visionox_r= m69299 *ctx) static int visionox_rm69299_unprepare(struct drm_panel *panel) { struct visionox_rm69299 *ctx =3D panel_to_ctx(panel); - int ret; + struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D ctx->dsi }; =20 ctx->dsi->mode_flags =3D 0; =20 - ret =3D mipi_dsi_dcs_write(ctx->dsi, MIPI_DCS_SET_DISPLAY_OFF, NULL, 0); - if (ret < 0) - dev_err(ctx->panel.dev, "set_display_off cmd failed ret =3D %d\n", ret); + mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); =20 /* 120ms delay required here as per DCS spec */ - msleep(120); + mipi_dsi_msleep(&dsi_ctx, 120); =20 - ret =3D mipi_dsi_dcs_write(ctx->dsi, MIPI_DCS_ENTER_SLEEP_MODE, NULL, 0); - if (ret < 0) { - dev_err(ctx->panel.dev, "enter_sleep cmd failed ret =3D %d\n", ret); - } + mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); =20 - ret =3D visionox_rm69299_power_off(ctx); - - return ret; + return visionox_rm69299_power_off(ctx); } =20 static int visionox_rm69299_prepare(struct drm_panel *panel) { struct visionox_rm69299 *ctx =3D panel_to_ctx(panel); + struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D ctx->dsi }; int ret, i; =20 ret =3D visionox_rm69299_power_on(ctx); @@ -104,36 +98,20 @@ static int visionox_rm69299_prepare(struct drm_panel *= panel) =20 ctx->dsi->mode_flags |=3D MIPI_DSI_MODE_LPM; =20 - for (i =3D 0; i < ctx->desc->init_seq_len; i++) { - ret =3D mipi_dsi_dcs_write_buffer(ctx->dsi, &ctx->desc->init_seq[i * 2],= 2); - if (ret < 0) { - dev_err(ctx->panel.dev, "cmd tx failed, ret =3D %d\n", ret); - return ret; - } - } + for (i =3D 0; i < ctx->desc->init_seq_len; i++) + mipi_dsi_dcs_write_buffer_multi(&dsi_ctx, &ctx->desc->init_seq[i * 2], 2= ); =20 - ret =3D mipi_dsi_dcs_write(ctx->dsi, MIPI_DCS_EXIT_SLEEP_MODE, NULL, 0); - if (ret < 0) { - dev_err(ctx->panel.dev, "exit_sleep_mode cmd failed ret =3D %d\n", ret); - goto power_off; - } + mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); =20 /* Per DSI spec wait 120ms after sending exit sleep DCS command */ - msleep(120); + mipi_dsi_msleep(&dsi_ctx, 120); =20 - ret =3D mipi_dsi_dcs_write(ctx->dsi, MIPI_DCS_SET_DISPLAY_ON, NULL, 0); - if (ret < 0) { - dev_err(ctx->panel.dev, "set_display_on cmd failed ret =3D %d\n", ret); - goto power_off; - } + mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); =20 /* Per DSI spec wait 120ms after sending set_display_on DCS command */ - msleep(120); + mipi_dsi_msleep(&dsi_ctx, 120); =20 - return 0; - -power_off: - return ret; + return dsi_ctx.accum_err; } =20 static const struct drm_display_mode visionox_rm69299_1080x2248_60hz =3D { --=20 2.34.1