From nobody Wed Dec 17 10:43:02 2025 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F9A1290D8C for ; Fri, 9 May 2025 11:07:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746788829; cv=none; b=duia9dlq8OVmjJnalB1EZa0VDG3h/FwV1skJRxkirNPICxYygk6lKpK7qnmVR4aVYWON9cQHs3il5DFPpcUWi8kFVsZXGhWlO3NYW9rWS/NQ36Zrrthr4FUsfEqYycbVS6+TLCOazSfVpNka+ZX7TQY53IsbZnKdYV92dpXgEzQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746788829; c=relaxed/simple; bh=Wzbi1SX9mtAF2E7Mjcw8XjP0xTVKnkUioAGI/9ufBe8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=f5ImUw+L92EtBtq4UYwHdcN/6XOUEvcuq+fuOdHRJsP7CvJBsYfSfLiUP8T2FoS9RPg/zD+cW5G7daVgYKBxzoxoQ7z7CoSx+TdOCDc/yIpPgrHALv3CtrEmQefaq1pFo0FZ1ycaSAEecdPmYrWOPNCsoxpGntIO2KgnAnf/NvQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=gGLnv/Tl; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gGLnv/Tl" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3a1c85e77d7so799078f8f.0 for ; Fri, 09 May 2025 04:07:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746788826; x=1747393626; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=X9YN8+8rnHDsp/b09Y/xOR9H3TlYqB2jpDQsHdPnIdk=; b=gGLnv/Tl8Sm21KyMwuvCdXbd/QsLcu66maSgRkpo7Zjrz41eM6Ml3NXnPwDdguOBmG yk7DlIZHnti3+8ZO+ATC171E9QAeblcJk8IuII7C33S8y8yHFobCehDUvDXFLyG3klEY G2o1ggip1ye+gdIRxc5L6+biWMJpkd+LuJWXjHYCU+WeNriNDbBiaA3SVfmBAucptSKk u7NMYImjM3YTkLZo3WgIAXhgOqqtNAM232Cl+J7xwLZwXT9ro9HEPq0VZTIYT75WaOYT sSLIpiR2GKXhs2ACMBuTh/DY0nBLPbzOqJ826zjR3GBZ6sLwfIttmmkONeR4ZQe64DDT 9/qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746788826; x=1747393626; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X9YN8+8rnHDsp/b09Y/xOR9H3TlYqB2jpDQsHdPnIdk=; b=QC843jhcm0g0B2UPwVe+6zmL7rhZ8BWZvV5aPmWo8KypIXs4EuDYnfm4Fhje16v9EH LuOLRmDZlWw9SWMZv5ANzRs71unL9Ggg8pr+yZWxZfbq11qqx3C9Rg4EmJh1P/a9y8OT w1pLvc7uLQ7BhsBwwv+bXigmF00u1iyOOWVxrtexi+XHpsnh0QJlx08bj90ZnlqptErl NhMp/qCWNVOsIK0dcoveOfAOoa0CpwWv1EhGp2MYlfJmVzCr3kwYuyy7RIHY++XM5ojE NzpIZc+7BhZZKCART6wFqlfTpSq7QrFk1UK+CV4av4ji5vgaKjmxrYvgNqLtdcVUE8l6 GsqA== X-Forwarded-Encrypted: i=1; AJvYcCX8yNiNj2dUAfB4ujR/jIryV5vK/FxwnWYnzwjUtRPpIXBsHaVP9NOlX3ld8N1uRo3yH1Lz878wkaNLFZ4=@vger.kernel.org X-Gm-Message-State: AOJu0YyHWv4XnH348enDmLIh1QCHM/uaHWjTocRDFtgoTdAReJeMa70X AUDCkaZYLIL6RNSP1l/dwDoZTnqJBrcuELzoYpBopogidhOCZcYeIupEIMTzC6M= X-Gm-Gg: ASbGncsXVPENS67xXZsNBdnpKzzHP0frgKTNOARM9SaylJI2/AQCD3UHH/fY1IR8KD5 rn3JnVdI3BZaDeAyoP93aASiN8+uYcO8XVL9hG2NNPfq+RqVNmGRGZKDFQ2b6xJPiUHOx70M1Tl XXChN9lF4IwAYjovXjGvvYOz8Bn3IpGMqtNTSJYZC2pgNfJ5ZVBEnxcIFpA3cnJCj4ogblzBO4H aSSL/Yh1Cw9wTsEGe7ECH+OXSe7dVNcp+Lo+WVCPVoMWUFJNeVn8fsTkADUSb/i1s+SA7Q/KG8I PDVLuL8ULBjby2ygTdfKHmjgrtx5jvOZYpT/Viq8OBrdQEY= X-Google-Smtp-Source: AGHT+IGTcDbYuLQC5gOTqBLxhDeYoC8oTLnNT0OALiU2xxGu34CRv1e+8uSkOAx/4GXBO/mVq1Dayg== X-Received: by 2002:a5d:584b:0:b0:3a1:f635:1136 with SMTP id ffacd0b85a97d-3a1f6487d80mr2603233f8f.28.1746788825706; Fri, 09 May 2025 04:07:05 -0700 (PDT) Received: from ho-tower-lan.lan ([77.81.75.81]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a1f58ecadfsm2914797f8f.22.2025.05.09.04.07.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 May 2025 04:07:05 -0700 (PDT) From: James Clark Date: Fri, 09 May 2025 12:05:55 +0100 Subject: [PATCH 08/14] spi: spi-fsl-dspi: Use DMA for S32G controller in target mode Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250509-james-nxp-spi-v1-8-32bfcd2fea11@linaro.org> References: <20250509-james-nxp-spi-v1-0-32bfcd2fea11@linaro.org> In-Reply-To: <20250509-james-nxp-spi-v1-0-32bfcd2fea11@linaro.org> To: Vladimir Oltean , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , NXP S32 Linux Team , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , larisa.grigore@nxp.com, arnd@linaro.org, andrei.stefanescu@nxp.com, dan.carpenter@linaro.org Cc: linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ciprian Marian Costea , James Clark X-Mailer: b4 0.14.0 From: Larisa Grigore Switch to DMA for target mode otherwise the controller is too slow to feed TX FIFO and UNDERFLOW occurs frequently. DMA can work only with 8 and 16 bits per word. 32bits per word is not supported, this is a hardware limitation, so we keep the controller mode in TCFQ mode. Signed-off-by: Larisa Grigore Signed-off-by: Ciprian Marian Costea Signed-off-by: James Clark --- drivers/spi/spi-fsl-dspi.c | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c index b7363cfc649d..50cec3b94322 100644 --- a/drivers/spi/spi-fsl-dspi.c +++ b/drivers/spi/spi-fsl-dspi.c @@ -137,7 +137,8 @@ enum { LX2160A, MCF5441X, VF610, - S32G + S32G, + S32G_TARGET }; =20 static const struct regmap_range dspi_yes_ranges[] =3D { @@ -182,6 +183,7 @@ static const struct regmap_access_table dspi_volatile_t= able =3D { =20 enum { DSPI_REGMAP, + S32G_DSPI_REGMAP, DSPI_XSPI_REGMAP, S32G_DSPI_XSPI_REGMAP, DSPI_PUSHR @@ -197,6 +199,15 @@ static const struct regmap_config dspi_regmap_config[]= =3D { .wr_table =3D &dspi_access_table, .rd_table =3D &dspi_access_table }, + [S32G_DSPI_REGMAP] =3D { + .reg_bits =3D 32, + .val_bits =3D 32, + .reg_stride =3D 4, + .max_register =3D 0x8C, + .volatile_table =3D &dspi_volatile_table, + .wr_table =3D &s32g_dspi_access_table, + .rd_table =3D &s32g_dspi_access_table, + }, [DSPI_XSPI_REGMAP] =3D { .reg_bits =3D 32, .val_bits =3D 32, @@ -294,6 +305,12 @@ static const struct fsl_dspi_devtype_data devtype_data= [] =3D { .max_clock_factor =3D 1, .fifo_size =3D 5, .regmap =3D &dspi_regmap_config[S32G_DSPI_XSPI_REGMAP] + }, + [S32G_TARGET] =3D { + .trans_mode =3D DSPI_DMA_MODE, + .max_clock_factor =3D 1, + .fifo_size =3D 5, + .regmap =3D &dspi_regmap_config[S32G_DSPI_REGMAP] } }; =20 @@ -350,6 +367,12 @@ struct fsl_dspi { void (*dev_to_host)(struct fsl_dspi *dspi, u32 rxdata); }; =20 +static bool is_s32g_dspi(struct fsl_dspi *data) +{ + return data->devtype_data =3D=3D &devtype_data[S32G] || + data->devtype_data =3D=3D &devtype_data[S32G_TARGET]; +} + static void dspi_native_host_to_dev(struct fsl_dspi *dspi, u32 *txdata) { switch (dspi->oper_word_size) { @@ -1398,6 +1421,9 @@ static int dspi_probe(struct platform_device *pdev) dspi->pushr_tx =3D 0; } =20 + if (spi_controller_is_target(ctlr) && is_s32g_dspi(dspi)) + dspi->devtype_data =3D &devtype_data[S32G_TARGET]; + if (dspi->devtype_data->trans_mode =3D=3D DSPI_XSPI_MODE) ctlr->bits_per_word_mask =3D SPI_BPW_RANGE_MASK(4, 32); else --=20 2.34.1