From nobody Sun Feb 8 17:13:49 2026 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2041.outbound.protection.outlook.com [40.107.249.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BDDC264633; Fri, 9 May 2025 04:47:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.249.41 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746766032; cv=fail; b=sKaCldbWKmjKYyCCex2OGNEPJd7aSNANhctNbPQCSoW2hq5GaAuctJbUQ6RGYCTk8K0bw+kO0Shb5t/mOxvAXX+WnCRb/Ubt4GFXMKufpobXCyFVMJY5x26P9TbGP5vq3YuUBdA3DJiM+wIqUpCqoYG99oQ+62GVWzXUIp4DMDA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746766032; c=relaxed/simple; bh=VzHhN9I4lLjZJT316RIURX3UVBZMrOsA9pUkfyh8sxU=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=i5gOaaykZgp84fp3Lgf4G+Evsj9+26AtqVG4QvyZkqOt0cao3nXGXz0LChh0abSLOOsvvKSYZ47opiUUDE51Wh9Q/T6hJc8iNbBjH1XfsyjN8smUbI6Jj7RIP0Tv2WQqktwSbgOq1ceOBWkpiFQXOoIHqq6HMWj2tPrFJLFeXGA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=ToQgj6T+; arc=fail smtp.client-ip=40.107.249.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="ToQgj6T+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZxEOxc0ro9nf/HxWAkiEgOAQ6uvdGrGkmzJRV1Jm2eN7kYmfSeiBo4AbmznJ5E0xppVQg/InCVGr0G14cQl+qRoTnw94gjPinokvIdFsPhzNdrlQuc2ylMispT5jI5NsTxfeuXCmATgtTMvuMHyUPj/kFuQwenRXFtJXdRoFwGC3Oz7+iIXOIk6CJYeBwj82FUeHtKnLhby6DYtiPlITeEDxGpzIzUKcUrvdfLTNK/l3OkGjJSVqjteYnaooaSszzUDzioMypSFS58Ryo4E+83LDyo7Cus4xq/kbiVoHyIHmfatr8T+Srhj+I4mEo81oYL2W+Cm2QAx+pZoHA5OSUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wS7b4LgF6GBGG7jzg46Ynpmrw8c37xEpmIqwlULhey0=; b=LYVSFmJ1sjUlmv+nkmSOAwePkcQ2qv123MwNUQSzrK/EOKa0+YtUfDdpsTXVFvosOp8gM2n39H5Nf9+pSyisEctix5v6yGJrjTeuxvSUvQP0lw4I/etOEQCOjPcXCtooF+UaPzxatU2sylSF6nhjFrMSp/opyquRAlIDH1LFeMQPJZStTKObLyKOi0/vTfY0yXHoGZcub8/LjaOtAm6hL1Xi5Oa9gallnEHOK/mpmcyTNNyDD9DYf7zTCmsw7zH8psmREW8hMwS6aC1RSzbbm3yzfs2BUGRqOVRttjnBoHAEVBarIu1zK/fPrAfTjCd6qE9Vd94RJGAst8WBCJDPTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wS7b4LgF6GBGG7jzg46Ynpmrw8c37xEpmIqwlULhey0=; b=ToQgj6T+mBp0/0rMKxGDEOuU8XcmVTHqWDAlIGYIdzPbTf6Q2v5ULYWVYrCFxXuks9gCZstVf3ZAfgmYUP4P+goIzD5RPxJjUZbW2ojmM0Qf1h1QuR69qnUZ+rhvkTDLY5bVes18jtHKGtXwZipQdKqA4HYoIiT0SRe+RTy9EhwK83OL658wWk//vsYEeOASIjYixwJocHHUeWl3qYtjtjgNCu/wMKqxCoG5X7EazNWIJr3LJnyjcHWxqCTdcZ3K9fSehK7ulknXPTtLO1Qrf+Tqzc9e8Vcx/9z3Kxn+11uRGSNEnrXh/mJ5sW2pdivJyNdOcWCV2DexmxGRejFD9w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PAXPR04MB8736.eurprd04.prod.outlook.com (2603:10a6:102:20c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.23; Fri, 9 May 2025 04:47:08 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8722.020; Fri, 9 May 2025 04:47:08 +0000 From: "Peng Fan (OSS)" Date: Fri, 09 May 2025 12:45:32 +0800 Subject: [PATCH RFC 1/9] gpio: bcm-kona: make irq_chip immutable Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250509-gpio-v1-1-639377c98288@nxp.com> References: <20250509-gpio-v1-0-639377c98288@nxp.com> In-Reply-To: <20250509-gpio-v1-0-639377c98288@nxp.com> To: Ray Jui , Broadcom internal kernel review list , Linus Walleij , Bartosz Golaszewski , Florian Fainelli , Scott Branden , Vladimir Zapolskiy , Keerthy , Robert Jarzmik Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1746765944; l=1154; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=+czX987lHw7YdsJy0OqqXqyZxlQ8brvuzmo4B/Dqc/o=; b=6mZxSUh54AnoFAjeksq5/Gcgi2jFo/JlxzSucdd4eMV40L6I6OtR/OT7fP90VuwWjIMF12tbs 7QjnkXTM/+hBH276Nm9nZXLB68AH1nP7sc0IKVc0cRRAfBITf5sxX+8 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI1PR02CA0011.apcprd02.prod.outlook.com (2603:1096:4:1f7::19) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PAXPR04MB8736:EE_ X-MS-Office365-Filtering-Correlation-Id: 548fc7c2-7ee7-4dcb-3d22-08dd8eb48dae X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|376014|7416014|1800799024|366016|38350700014|41080700001; X-Microsoft-Antispam-Message-Info: =?utf-8?B?N3pEUjVWcGVDWEd0YWoxNG8ySmtUTmYzVkdqaUtqcTBPQ2hqNWZ4YzFlN2VT?= =?utf-8?B?eDI3b2VET1M2TitqU1o4bCtBb3lGV05zQ3Z0YXVBbllON2x6U0xuWkxlYU5Z?= =?utf-8?B?cG9SZ3NGVFZrRk9aWVRKR01qU2NrY0JjU2VxT1dUQUFDR3RqcWQwenhCS3VW?= =?utf-8?B?ZGxQKzkvTGVQMndFcXdQYUZBZW9FWXUxWUxwUmwxVzd5TkJIeXRjT0lqeENM?= =?utf-8?B?ZjdObWdtQlZoSTN3YXl4TVJGUUJidG9GN1RtWHhPL2ZkTUtsL2dVcG5xcFB4?= =?utf-8?B?cmFWODRCRW8rVjNVRi81eE51ekdxc0RjbDJwZE1kcWEvZDZ0YmdvRjEvSEt0?= =?utf-8?B?N2JybDQ0NGMzNWxXR0dHOC9ES0dJdmM4OUdLM0dSbnVQU1pHbTNBeTZBMEwy?= =?utf-8?B?ZDVidytWWFJoOXNSS3pCeFRlaFNTbjZiR2JIQ0d5VVFEWkNmVktqWU03Z1pk?= =?utf-8?B?Vm1JZmNRdG5MTlkzWW80bGo2bW1jMG1hTU9DQ0VBeUlORG1LeStuTEFqd1Yw?= =?utf-8?B?TEhQdjlGZVd3YmFTam1idTAvTjVoOWdXcmhRbnZmUkN1d2l3OFl0OVRlSkx6?= =?utf-8?B?R1lIeDFtUS9oV04veXZNM0pxbFJ4OERtQmNQZ0VIa3NDQldkN2k4cEpDdk9k?= =?utf-8?B?S2tPQWdNQ1diczBCUkN5SCtGcWVYejBkdmhySE9MMis4REZlajlzK0tsUDNL?= =?utf-8?B?cnRlL3lJdE5pZE5XeUhaWXdtVGd2T0IzTUF4NFRCWjFhektnK01mTkZlS3d6?= =?utf-8?B?N2RaN2tjZVhNSTFoU2xpUkIzdUIydm5sU05YT1BGb2gyNHQrUHhZQzc2SERZ?= =?utf-8?B?SGpzejJIMjBkdGtTekR1UW0weVhKTTNGSWpwbG9FMGJNS2FTTUI5akx6aVor?= =?utf-8?B?bGtyaXJGM3pxUFlVNEI4NUpFK3pjSjR3bmhUbVgwYnlMTjRrRHJnQWdrV1oy?= =?utf-8?B?WDFHVHZrVWZZek16VEI2RzFtWG9jSW96SjhnSzZqTzZGK2Vib2JQMGUwNzJ4?= =?utf-8?B?Q0M1TDd4MVBwcnNJOU9OdTBFVDl1emIzMEp4cDI5ekNVcHhkS1JoYTc2M3JK?= =?utf-8?B?bmVMallTOVprUzdMbnJLUVdvL0ZTakxPa3JTamdBWThnYkMyTUtjSzhPdVNr?= =?utf-8?B?UEE3ajc2U0lmaFRudFRRbEhuRVMxa1o1MzlDRzdqVHkxZ0dIbUtZTmVQNzNo?= =?utf-8?B?SGRLUVlXVFBkTWd0MXdncVd4cjVkd3VML0xMcU5UeGpkcnBEOWhhbGJibHM0?= =?utf-8?B?QTRRYlp6ZGtQRlVJN3FPc3RzVjQwd2l1KzJqRGZLZk9vZUtXaEE2TXNnVmFW?= =?utf-8?B?TnFWU2svVUNMcmQ5VjhKUTl1TmJoaXd1WW9aZEJuR2tHNm1qdUZPU2xTditp?= =?utf-8?B?NGtPaUdRTEx2UkswbUQ5YVphSDdXdnRrYVNYZDdZNXZLRlZWSmp3dUM4U1Z2?= =?utf-8?B?RE5mS1VZWG1ZR0VwTzlTektwamRKcnBaNWhtWWVqdjcxNEppZnRDRUlZWFdB?= =?utf-8?B?WWtsRWJWeUQxUXdnTk9hMFVoK3RpMEZ2SC92QWdVQjFMYS90QndWV0kxWkVo?= =?utf-8?B?UzM4Snk3ZUxFTmVpdDcyZk1QVlduSXcwL1h4ZjZOaHJ1WHhSL0N6N3pKZG9m?= =?utf-8?B?amFVU0NRNk1MZFZUbUhSTDh0RmJ3a1pCWHZQTU1sNjFtUGQ5dUxJallkYVFM?= =?utf-8?B?cE5UYUVLeEs0WmUyZklwZE1QZlFuN2g2Ni9Sa3liQU93S1k4L05LSnVqYy8w?= =?utf-8?B?YVNSd0g3WlZ0SmVlbUFsYXpMY1JxRFVGdjJ5blppSGpRMHBPdWhIQmdrUDVM?= =?utf-8?B?bzFZajdMM2JveldkL2syUGdyWmRocTg1dUJrUXk1cjQ0Q3l4Q1h1R2ZxYits?= =?utf-8?B?dm5KVXJwcjJsYm9DWTQyM3ozN3hITVdMazhYZWx1UzdSMHVBS2xQYkVxa0Vn?= =?utf-8?B?VkZrcHJQWksrQ1RZY0p0SFkydkgrdTlUL2MzOHNTTDdUUHcrQVQzdmZRL25M?= =?utf-8?B?Z1ppVkcrb3pZaXoxaitUUnMyNGtaRW1jMEdhZjRULy9jQk5CNkF4WEFWUmha?= =?utf-8?Q?yoUqmB?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(376014)(7416014)(1800799024)(366016)(38350700014)(41080700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?emFjdFpRbXhibTc1N0xVK25waTlhVldkY3FFVzlNNnpwUjJQVzdLc2Q2YXdq?= =?utf-8?B?Z3JtRFRzeVM5UUdIZkZXYjlYby91WTJrRGVNK2V2QTFqQnJuK2owVTFqdkdL?= =?utf-8?B?SXN3cUczM2k1VlcrckRhOERxaFg0TUJDZy9mUFdPVU9zK1EyaTNpYkgwa2tp?= =?utf-8?B?cWZoVG5FZXBlK0tjTGkvVlhvWHcxNm9pODlkSFR0WHlOWStyelBXNU9pMUlr?= =?utf-8?B?azlzQk13VlVnZHRuNlMvZHhBUkJHWXc4T0wrN1g3NnlwTm55S0pPQmxJaXVX?= =?utf-8?B?UEthcURTZkcwOEQ2dERIaEU0aDZhKy9Gb1o4M1VMckFOTTJMdG5KTW9oRDM2?= =?utf-8?B?Ri9uc0pCZXdZTWNrY1MxVWY5bldDbDU4bVJwRUVCY1FyZENKOWhPdnZNYWUw?= =?utf-8?B?SUtZcERxS3FMM2wrNnZwQ0tVQk5UejhSK1FMVWU2bkp6ZkllY0pqbDByNzJU?= =?utf-8?B?NW0zUmRxRDRmQml6c0swSS9abGErcGFsTWlHUGJpc2dLKzI0SVp0dVpnNHlS?= =?utf-8?B?STQ0MjFyMzRROHhKWU9QTlpVczNodjlUNEMrT0g5R3d0eWF6RERBWmdFOG80?= =?utf-8?B?cmNJTm1QNi8zR2JFVzNGTVk1dHBSV2dzbDZiWG9CM0VyWWNaZDhEMlIrN3RN?= =?utf-8?B?Ry9KQm5PUTIvWThxaDMwQWtxazdOMXdWZVk3WCtwT2YvaXVWTkVnZHl5TlUr?= =?utf-8?B?bFdEVHlaamI3alA5NTdKejBsSWJBdCtTQm1xZERpYjZFK0xZMmpxZEhKa3o2?= =?utf-8?B?RVd6MVBwUGFaTDN2d2h6eG5SWTUwQUFmMXgvWTU4ejRxZ2lDOWx4bGxlMUo4?= =?utf-8?B?ZXRhYjlMTG5UcnhzcWRhdTFxZGFKYUM5US9MdnhVWWxQc0NCRUFlUVdtaDRy?= =?utf-8?B?aTBOVkhsdXM2NjArL3gyeHpmZ0hHdVBKRGY0TzFSNlloR0VTS3dUcExobGQy?= =?utf-8?B?T2lQNzlMZkNXN1RnZkJpdnBHb3lUNnB0YWJFaFNDSjVtTlJJOWVCMzBiSHRm?= =?utf-8?B?V3Y0WnlLS3p2L0xYNnFIUjd3ZEJXcEkyQW03RGFqVUpwRGw0Z3Mzc0pCWDN2?= =?utf-8?B?TjB0RTdjNkx2N2w3R1YyYUZhZDJTSE1UaG1XbXc3dk5zRXRadmc2TW5XTzN0?= =?utf-8?B?TXNkRmhKUzRoWUtKUkJtMXpNUHZ6WENrSFNINFMrR1J1TnpxUUpGa1VwbG0z?= =?utf-8?B?Z01GRXlaeW52NVZqaHJYZDRPT0dyWVJwdVJYSklUYU1wWlk4bHo3c0lCSE1V?= =?utf-8?B?ajJhenIvdzc3OTZxcEN5NER0aWp6c2x1d3JQRXlpNlRaNVB0SDczOGc5Zm5w?= =?utf-8?B?UEVxbnA3Y2M5TTNHMWdMaFpGS3F5eGtYdERmbXlpdklpM09MM1dWWkpQOVhG?= =?utf-8?B?T1R2eTFHM1VXU0ZRejdmTHhlZ3g4dzlRRFE2QWw0dVhEV0dLZVd3SlZDT0Fy?= =?utf-8?B?N3VsS25ycVhPS3NkaHZzQVJVMFQ4WjVVeXAra3V2dVcvbkdBcGdRL2tKV09X?= =?utf-8?B?MmV2d2NtdW0raWRmM2N2ai9qdng0WWQ5djFrNUg4K2g5SzFQbnA5eUN5T1dE?= =?utf-8?B?VHREL3NFUVhkRnBHUjRGemNhZ1ZlRHFQRTVDV2k4WSt5OG05SVRnRDhwTUZy?= =?utf-8?B?ZWFMZ3M3YnVXeHoxME42T2RENmdXUTNUQ0hRVU9vVDR2TGlqTXArRUdueTMv?= =?utf-8?B?L0hUcURwcFhHYUhuUGF4ZThQOXhub0wzUG9FYVhWRktBRGFHYkZBSDRwcWxz?= =?utf-8?B?bGpxK0s1d2p0eGd5cFYvVVZTRlU3QWVYbWRJbm10YWtFeUllQUhpMHAyMFFo?= =?utf-8?B?TmNHcFNHNHg1Tk4xMkFxSnlYKzROVHpiMEdGYzFjWlQ4T2l2cks5NENYaHJD?= =?utf-8?B?UU4wOXB1eTVJS0dhbEc3REdyRlNxdkwrbVNSSUt4dGVUVW9lbEpiY1ZTam9X?= =?utf-8?B?VUx0bjRkdWt0SHQ3MFFYNW51UGp6V0ZlWnd6OXlReDRwbWxQaDJnclJhdWpv?= =?utf-8?B?QXZ3Zjl1OXZZS1dHbDRrV3Z5T0NNUUFNeDA1TmkwMDdUTEMvbEVLS2RBZ2xT?= =?utf-8?B?NmQ0YlR2V3ZPdXFONnZjNmordmhLK3lVNmN6bFlMSkZBOThFQ2FlTGFKditr?= =?utf-8?Q?BxT8Z1lP/mj8xqx9KmIvBGVCk?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 548fc7c2-7ee7-4dcb-3d22-08dd8eb48dae X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2025 04:47:08.0241 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1hx2Z2q1UVucpX0YU5CuttWw+9pVth0Tw2CtSh3wd9To8/IAygfTS2R7E98hSV8FheuNd1W7MGVapMVcVhTnSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8736 From: Peng Fan The gpiolib is moving to make irq_chip immutable, otherwise there is warning: "not an immutable chip, please consider fixing it!" The bcm_gpio_irq_chip already has irq hooks configured correctly, bcm_kona_gpio_irq_mask/bcm_kona_gpio_irq_unmask calls gpiochip_disable_irq/ gpiochip_enable_irq, and bcm_kona_gpio_irq_reqres/irq_release_resources calls gpiochip_reqres_irq/gpiochip_relres_irq. So just need to flag it as IRQCHIP_IMMUTABLE. Signed-off-by: Peng Fan Reviewed-by: Linus Walleij --- drivers/gpio/gpio-bcm-kona.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c index 17c287dc747151c6217c11fe77d83e3542e830c2..8f22cb36004d4b27a3ca33352dd= 1ae176aee5331 100644 --- a/drivers/gpio/gpio-bcm-kona.c +++ b/drivers/gpio/gpio-bcm-kona.c @@ -516,6 +516,7 @@ static struct irq_chip bcm_gpio_irq_chip =3D { .irq_set_type =3D bcm_kona_gpio_irq_set_type, .irq_request_resources =3D bcm_kona_gpio_irq_reqres, .irq_release_resources =3D bcm_kona_gpio_irq_relres, + .flags =3D IRQCHIP_IMMUTABLE, }; =20 static struct of_device_id const bcm_kona_gpio_of_match[] =3D { --=20 2.37.1 From nobody Sun Feb 8 17:13:49 2026 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2041.outbound.protection.outlook.com [40.107.249.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21256264A88; Fri, 9 May 2025 04:47:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.249.41 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746766035; cv=fail; b=Leq5QRG0U/98WurfnCqrRxzyFUJehh3qrMY9UuM3yKyNDqFykaB1L4If4yxZuCmB6G9KUtt4yIXFLTzZv8xAzI6vcH/w3Q+JKmbgsGpCixjv76OdSzKhzUHzIaNW2Pa6g5HPoyf03CRJ3+3J8/VyjSPJ8txWIIzFiKmkurGskaI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746766035; c=relaxed/simple; bh=e2Rjlz3WZlRUpcPd5T81f1A652kFjdLPKaU94OLX84U=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=bjDzOvi0EA56586f3ngIfUbJcrRWjp+b2O2tMXNTgRVuUgna0lUcuPnTgKsQPjiUliYbppRghUUgW9jsocVtsS/1+FPfs7Rlso1jCqK1Ib4yxodWRThyC1IRIqH1fVlCix2IOtkXPSrg/XRYZkLQz6y8LYyjvJs5rZzzuVcZGCw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=ojea9Mji; arc=fail smtp.client-ip=40.107.249.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="ojea9Mji" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WzGwrtKKH47tnOCV6HFGacYhNnTcmPxv6U8UarqDl9JSPkHyLmjPIsiJgp6h12A0fP3M8ROkNWAwNqG9U+J/V5wPnFoxhr2P6YVkECUC9kf4yn8Gtf7GPghy1IYMmVl6DlE6Sxvdc5fcBOFvh3QRi4YDEXHERr71S4DlZAkZXK8RCYjqdaVcq8Bctbj//vA9SQ6WweQPaKs+5CVrFmLKYWM43+JdNDZMVTvW3CCjICwpRSyP8Mz+ywJc7SjczAglAUbMM15H2msmOeUsgo/ffBs+WXIhJ09BkVme8V2aay98TOhkfNsMVKQUeclAEcC7m1Sqt1hOgf/p683dZtPQfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tmGIXy4wa+haW56OLX5lijzERyYduTaWxM2jShlbGR4=; b=g7Rr5Lu09oo0aCC6Dp03ISBFD/hokYmPjILIRfiobIwSsbrsY/drC7pmRa5xPofEwCIhDnAIvw+eVtFrEOAepAYzfRYTiHYQxJl88Vowe2UlVk7iMnv8bFiiarU2sfxnmwlsIzwcApC7elMMZTw8QLJz1eohWTV5PUg7Gon5F/ZCJPE2L185ZT5deJkjM13qM++DcdesfOYdL/g8Ex0qlQcluZF2FTC+8aCSSk4iy9o1lyJ+4bssbMInTiJdVZOvVw5entppwOXv5ifIsUaSeW0Ueww80mwnKTFPtMzwqrIWF5791Cq9Yvb2XAfKcZTmc9CMLQWZjaUGfGBu7VGmuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tmGIXy4wa+haW56OLX5lijzERyYduTaWxM2jShlbGR4=; b=ojea9MjiAcyfLymsJw/MdhbnnXz/g/EuL233ls7NUPBSwYVSTs/Oi17bc3bIqDypIgvGh+YxatvKiJQK3vfSayP3VjuY04rs9XvlQf3GfxueRz7zjb/nj8PeUGMMUD1gNz8GeqptScBor1krVdkiI0OiX04kLZ1Rxs5QkFxb+XUDjc2okKWI6L4CjBTxl35TMXoPRN6J7Bx86pGQP7N2aeA03FhAVsFBgf/iA8akVkha3wDeCxi5N/r999qx86xuOVSwwHX0A948PwswVH+SVpU+m51kdHGRlmBSoNHcli3bePiw44dSyr+x2z58exAoHJ+SP6Xu8Pf4sMtKRuu9Xg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PAXPR04MB8736.eurprd04.prod.outlook.com (2603:10a6:102:20c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.23; Fri, 9 May 2025 04:47:11 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8722.020; Fri, 9 May 2025 04:47:11 +0000 From: "Peng Fan (OSS)" Date: Fri, 09 May 2025 12:45:33 +0800 Subject: [PATCH RFC 2/9] gpio: grgpio: Make irq_chip immutable Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250509-gpio-v1-2-639377c98288@nxp.com> References: <20250509-gpio-v1-0-639377c98288@nxp.com> In-Reply-To: <20250509-gpio-v1-0-639377c98288@nxp.com> To: Ray Jui , Broadcom internal kernel review list , Linus Walleij , Bartosz Golaszewski , Florian Fainelli , Scott Branden , Vladimir Zapolskiy , Keerthy , Robert Jarzmik Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1746765944; l=1672; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=nFs4uDnpLxGpM7ZOKqn5Fr+4jJZ7KNpbOkHyyWppLsU=; b=/XnCT8Ljtl+DI4WyZwiRvvJKFal+NHy8LczWFDZU5kIhfQ+EtPtegyRszqM7z9KH9164Fivmc 3ZjDm5WsVL+B83y7q4TgoOAcSytoDLIidGWkBYYVsBU83PL8pDKbgFR X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI1PR02CA0011.apcprd02.prod.outlook.com (2603:1096:4:1f7::19) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PAXPR04MB8736:EE_ X-MS-Office365-Filtering-Correlation-Id: 9bec19eb-a7b3-4a80-6bd0-08dd8eb48fef X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|376014|7416014|1800799024|366016|38350700014|41080700001; X-Microsoft-Antispam-Message-Info: =?utf-8?B?NUVvWHhLRmlkdVhjbEhZNVZkVTBobm9PSHc2V1dIUDJKT3FHTjEzK0t5UjBw?= =?utf-8?B?SHQxZFUxZXM5ZVZ0dVFwZ1BHYnVrSDhFTXNCM2V1a2dydmVRN3prdnNQeUtj?= =?utf-8?B?VHFEaklDUThjKy9UekhsSVJqUC8yWUxlNzY3eDVjd1NlWU5YelJma3pGM2Z3?= =?utf-8?B?dXIvUjVnTkRYR2xkUnVpY2Z3MVlEZ0Yya29GNTlvV0NQOTNoMGFieWhNcXQv?= =?utf-8?B?bTZVdUU4S0pYczFLVWEvU2h5bHJ4TnhhamlhcERtUFRHSVBMUHNTMWh2Z0Z1?= =?utf-8?B?T1hnSXFwaXkzYitmci8vaWpTSEV0eEtqdE9keXlGMDRDQm9ZOGdVaHZXM3BD?= =?utf-8?B?QXhydWRub2ppZTFBSWZkZXk4Y3ZWRlBzUWNsd1hGUGF2UWJldnQ2RXFoakZK?= =?utf-8?B?Y2R3Y1dJODc0ZVRacDBnYkxlYTF0bjdXTnlTbDVSNkhOK0kzNDNrKzI5QkM1?= =?utf-8?B?R2lGVkZGYXpFNk9qUFo5aFVXV1VKQitnVDQ1a1BJUmpLZm1pL1FMaENmdHhM?= =?utf-8?B?WlFPaUFIa0JIVU1udTZYWmw0UU4rL21GekZDWnhCdjY4MmRzclk1VHphZVE2?= =?utf-8?B?UXo5dDRXazFldWZGeGp1ZWpIUWZpcDJ5U2dZOEwwTUJGWTZIYThPQUFHdndj?= =?utf-8?B?enVuODVhK2dGakp5NFhyeWVRN1MrS3IzczcwbkovYzRQSVJ5bXc4d1RtaGN3?= =?utf-8?B?dmdCMEFVWE44VWFqRGxqSDdoNUEwajEyRUJISy9vNDA2VXRSVW9yN1Q5L0Ez?= =?utf-8?B?VkVmTnN4bjRHZXhPZjk4QnlMRW9QangwNDVBNEE1Z3krTjgyZ3FmeHUyQnAr?= =?utf-8?B?eGtHcDlTSlEvNnpyMmNRdFpvS2J2djdCdEF1SnRnd2RRMm1NM0wrbkFnWStx?= =?utf-8?B?MzNvYVkxcWd1OHViaXVNQ3Jwa0JDTndVaVlZeEM5VjdQUUtXUGtZaDB0LzN4?= =?utf-8?B?eTZqcnRscm0rVkl1cDVIVTd3WHhaSGoxc0lLcnNDY29kN01xLzJoYlRTRUI4?= =?utf-8?B?MkNrS0wvWnBLeWx2dmV5MkxLcG45NG1iRTlZQjNLOTFlM05RekUvUHMzaGVV?= =?utf-8?B?RjBhYnpnQU1aNFQ1cXZ1RmxEdXRyY0IrQUF1aVpNNGwrZmlrbmZFcFFwZG53?= =?utf-8?B?aENkUndaWnJlTnU5UDc2MldLTFpDVDF4S2hPQnFvRHNCdlA2czhLdkNBWFNG?= =?utf-8?B?MkZtTmpreGdBazVBT0hZaVFRUVJOKytBK3dZNVZ2RnB3ZW04YS93Vzd1eU5L?= =?utf-8?B?TGJuRnZ2ZGFsQUxiSFYwUzBtMlVId2xXcUdvNnIwczBMZS9ZRTlaQkZaTkFj?= =?utf-8?B?Z0xyYmZ5M3Q3My93OGxKeUNVSStvZGgzOTBkZ0JmY1NvYWVjYzBUZE1PMElm?= =?utf-8?B?VEc3L2s0SnM5RnBrWTJqQWtsWWZHdkM4TWwxd0Z3NmtpZWdVMWdkMVhlNUF3?= =?utf-8?B?WHZ1SmhxN3ErNS9MbEdoL09XVE1GdWZESWpJSFJ6TWlnajJ2M3NDWjVOSFNK?= =?utf-8?B?eFFhRnhlZzB3YWpaY0FZVVIwTHlSa0hTckxRVm5IRTFWZU0zNzIvSFhHZUts?= =?utf-8?B?dEkrNWVIZkNHL3JsSktNYzUzQk5rQ3B2ZnhIZ2lOMWU0T0cxMkFGUEM2TXJX?= =?utf-8?B?Qlo2cDN5M1pwZFZDVGNPWEZvNGxaVENMU3pheE5UYVRUbWN6ZFkxZi9JRldm?= =?utf-8?B?TzdMN1JEUzlHeHRpeUdmUFo0T1Z3RlQxR3NiZTFic3ZLU28yVTM3Vi8rWFdR?= =?utf-8?B?emR6VHN4M1dQRldzemJoWSs2MnFmK2lFeGlIUXFIVnFaUDhPUDdoaG5HYzV2?= =?utf-8?B?YlpVQWJ6RFpSUy92cjJqTFpkWGtWc1l4OVVpSHJibTBmeFZONndCVGhUQmdG?= =?utf-8?B?MFVyV093QWNjZnRVbmw4bFc0TXlZSGRodlR6VXhJbDZkY2pkWVNKZDVBOTNU?= =?utf-8?B?c2VKaFgrcWQ0SGdKNDErTG9uQ2xyc2dxVTdCd1FqcHRBb2pveHhkeWJKSFVz?= =?utf-8?B?QzVMUWVxa0xMWHI2MUg2eEpnRWIzSWZyenh2MktPZUlXYjdCT0p0TVROSTlQ?= =?utf-8?Q?QyN7Ja?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(376014)(7416014)(1800799024)(366016)(38350700014)(41080700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmQ1NnFrc2Vab0lad3ppSjNLenVlQ0NvK0lodmlNbVozK21jelYzbTVQQ2NO?= =?utf-8?B?SGZrdStjQ25VN1NZTzZCZ2ZpaGJCSXlCUUZrNVVJNWZPQkJ0T29PS2hRODQ4?= =?utf-8?B?R1d2Q01tTFozbnUxVWxrQUo5bUswOFdvUDBCbUM5ejFhcDdJNWN5Nk1QZ0Rl?= =?utf-8?B?RGNBa1dZa3BIZlNrZEs2cFpVOHVwK1FiWS80aUdaRVJMSGFIOW1WVXV2SC9M?= =?utf-8?B?VWp3TGpGQzJBdzE5YUNURGgrN1VWT2ZiU1EwMmFtdUtYdlVLa3hNUGwvMVVK?= =?utf-8?B?WmE5citkb2UwMVhUSUlVVG9hZVlpcU52K1ZpVGxrR0FUWVpHREU0Z1VHNWIr?= =?utf-8?B?Z3RtZHRObWhNbFNPZ1Z2bFBFVUJkd0Y3NDdkSnJlTmR6dC81V1VJTDNuOUxI?= =?utf-8?B?a3R5S21nU2dEQ29WSHQ5YTBWS1VKNmpjMzlOU21vUm02RUczVVFMNTVKN1Fh?= =?utf-8?B?WFBhS01LalVSbzJqQmVTVjRZdTZHQ052elJaVVVMYUNUbWlTMlgwSEJwVXBs?= =?utf-8?B?NG96U0cvQjJlVFdUTlByczFCRGVoU3c4b2NlV0N6dGVVVStYUHpRdnNzU254?= =?utf-8?B?MVFKWEZ5ZUdxSFFsb1lkVGp2YVZmc2ZDNEU5eGwySG03Z09keEVPODJvN1hm?= =?utf-8?B?N2RDb3A5Q1NMTDVvK2swWXREcG5oc0hZcU9FVkN0RXpPTldMU0ZnOFBqZjVP?= =?utf-8?B?K0VHdm5IOU1LWmV0TkltKzFIRGpFRFB4Yld2U0xSVWVoMnRVTTVVaFlPa2cy?= =?utf-8?B?SkxRUDU2d05EWUdaS2xWUmxLODNqb0V6QllBZzdWeWh0SjJSMFlhaVljSUd4?= =?utf-8?B?VXJHY3VjcHZsQ2l2ZmJXblRmTDdYQWJjanJMK09DeTBGdXd4RitxZFBqVktN?= =?utf-8?B?MVpPc3VveHNTdzRtVzlHV2NYR0pMM2RwdkZ4cWt0ZC80bzVFSXl0dk9FdUt4?= =?utf-8?B?Mm1PWUpsZFp4bHg0UEE0UjFiL1crMTRtMnNRcGtsR3NRRHlEQUYzUGlCTmhO?= =?utf-8?B?WlorTWNOTno3aGd0dDJxaTh1cnJ3bS9nWlNialdKdmZCdWp5QmpVODdGTXZT?= =?utf-8?B?aUNJSHVLTmtRQTBFTVRZRUpQM3ZTcmd6UGVZT0pBbVZSMTlZb3gwbTQ3ZkNu?= =?utf-8?B?TGhyS1ZHSno1ZVRZK1lVbkQ3amwxWUl2bkh0ZTJqajdhSDhFc3FyVmRpTHZN?= =?utf-8?B?Q3o4c2o2TE1xTHRNSXZRM3RkVjRJT05kcnRPVUdiL1FvUEVCQVlBQ2JjaTdN?= =?utf-8?B?Qm5rWkU4REIrcCtRUGQ1R1NrdVFQZVB1RVFpV1J6amcyR29mQVQ1VlJTbVJL?= =?utf-8?B?b0k4eS9tQmNJektHNWwwTVNiamhKRnhuUXQyTWhFT3lmdjcyNHU2MlVjRHdh?= =?utf-8?B?eWRvajJRMzNzYUo5bXFmZGVUeWh6YmRVT01ubUxkZk9ZY1Q2ZEQvUFJoT1Y1?= =?utf-8?B?SitKYWJRK1U4Q3RhcVdPTHVIRmJVRGlFQUNjekVrVktBbjFXK2VRQldudlAz?= =?utf-8?B?bjVhdGxJeEx6bWhSODdOZGhZK1ZvRHlYRHBkekdxSEdFK2lrUGdLYTdNYlox?= =?utf-8?B?YzV5R0tiUVYzTGZVbGFqYmFqbUxqaUtnWW0vMjJmaGd0M01oQmVobEZ1S2ln?= =?utf-8?B?Wk9TdG9rWHpzVDc2aEEzVXlUU1V6MzByTzd1ZWFuK1hzMi82WENMdG5Rcmdj?= =?utf-8?B?aGdIZStLd2tmcVBzSkVnZjl6eGkvY3J2RjJmZUk0c0RXb0Q5Z2g5MWpEYWNo?= =?utf-8?B?ZjJ4b0QwSUNVUFBuYURDVERDS3k0OXl2aTRoV1JNOXpnY0hNcXlnOVZKTm5R?= =?utf-8?B?dklpT3VQWmdCbDc1czdiZ2hEWERHOTdGMEV4QXAzK2hkTFVKQ04zbFVUTitN?= =?utf-8?B?cWY2K2FoZTRIMmhDSUZjSGhpbTc2NVFoWUU2blRibzFiYnVOWWtOU3N3Vmpu?= =?utf-8?B?ZUdsSWpFdlVoRGpTOXlFczZPSWVLRU9FdXl3YWp0c1lrNEErcE9xQWZhbXZ5?= =?utf-8?B?KzhSeG1xQi8waE94d2FBM3lGbnh2R2VsUElVZnZEQTlTZW82ampYYWI5Mmxh?= =?utf-8?B?WmtXWDlDMWlITUs0YytjVjJmY0lGSDZIUVBjaDBLYW9pZzlxbG9QUGFlZUFn?= =?utf-8?Q?d9u1Oj/31PUtUX6PSIIyM9yaY?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9bec19eb-a7b3-4a80-6bd0-08dd8eb48fef X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2025 04:47:11.7620 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YR8RBv58UcQkSBuoiQw98ASHWSfqbyRAM849yskpZoaVgaRBAeS4Qgc3KffxHGp+ne4jpPb1YzsXBoK8crzCDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8736 From: Peng Fan Kernel warns about mutable irq_chips: "not an immutable chip, please consider fixing!" Constify grgpio_irq_chip, flag the irq_chip as IRQCHIP_IMMUTABLE, add the new helper functions, and call the appropriate gpiolib functions. Signed-off-by: Peng Fan Reviewed-by: Linus Walleij --- drivers/gpio/gpio-grgpio.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-grgpio.c b/drivers/gpio/gpio-grgpio.c index 641df8f2fd3d3fc523acd5103cc77d50113599e5..d38a2d9854ca524f05164180601= b1a936cc70983 100644 --- a/drivers/gpio/gpio-grgpio.c +++ b/drivers/gpio/gpio-grgpio.c @@ -170,6 +170,8 @@ static void grgpio_irq_mask(struct irq_data *d) grgpio_set_imask(priv, offset, 0); =20 raw_spin_unlock_irqrestore(&priv->gc.bgpio_lock, flags); + + gpiochip_disable_irq(&priv->gc, d->hwirq); } =20 static void grgpio_irq_unmask(struct irq_data *d) @@ -178,6 +180,7 @@ static void grgpio_irq_unmask(struct irq_data *d) int offset =3D d->hwirq; unsigned long flags; =20 + gpiochip_enable_irq(&priv->gc, d->hwirq); raw_spin_lock_irqsave(&priv->gc.bgpio_lock, flags); =20 grgpio_set_imask(priv, offset, 1); @@ -185,11 +188,13 @@ static void grgpio_irq_unmask(struct irq_data *d) raw_spin_unlock_irqrestore(&priv->gc.bgpio_lock, flags); } =20 -static struct irq_chip grgpio_irq_chip =3D { +static const struct irq_chip grgpio_irq_chip =3D { .name =3D "grgpio", .irq_mask =3D grgpio_irq_mask, .irq_unmask =3D grgpio_irq_unmask, .irq_set_type =3D grgpio_irq_set_type, + .flags =3D IRQCHIP_IMMUTABLE, + GPIOCHIP_IRQ_RESOURCE_HELPERS, }; =20 static irqreturn_t grgpio_irq_handler(int irq, void *dev) --=20 2.37.1 From nobody Sun Feb 8 17:13:49 2026 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2044.outbound.protection.outlook.com [40.107.249.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4093D26461D; Fri, 9 May 2025 04:47:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.249.44 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746766040; cv=fail; b=DZaCawnyp51bgzD3Mr3LqEYSn+twvyE3ICDvmDf5VZ8Svtp+6KZVDCGLNq+/XG+s+9rDSeSNXUPUUtaCAPjMvk09QmkgCDNaMLh6zTiYPEsoF8v7OrOQnNg0ipc4zOI0irJg+ZOmMDqDWm+FjlBL3FwaVZ9X2/0knbETKvAH/80= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746766040; c=relaxed/simple; bh=B7DKR8PT9x+XuHYQVjXd6Oo6jI8CRaTgxeWDZYNGYkY=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=Yj69qxKr6o3gKoPsQNBqZTlShf2D2q6aggjpYMOp8jaV99D5XNQ7ypn7W90yMLLjvFHzCAKSWjwNPzckmYw6sUedq9iwao263vsAw+KsslrEdtaRRF72PNEqvba0kx/n7toySDc0PL7SgDwdrvidgmbx8nYdOhbop4F2r9aZHjQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=IWwIhGQo; arc=fail smtp.client-ip=40.107.249.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="IWwIhGQo" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uduUeNKHmsaewsLx75DizQUBSR7oMV9aJNxbIFY842FEnISxFd8d4aWazfhAxalejIRFBwCRKUUBNzJFxLpndeM8cHVDcQINUBxTxDztytHUiI5/sZkFjRddP8KP16re++b9bIwfLsCAFqjtEN4TVoDb9LsJtfjDHQ5gouJRvjoAXwvKJgGjZOwLbJ9UQlZrFr4lbUJ2LxR6PwbH0FO+1DqHXnvlTbQ2CQmpjKYA7zHYfzHL6wfIihJguOJJ7xEgckmDWsR3v/KAycwZoFW//rtzgLunb1yR25T9hhYznJaikk75L2rwAnJewH/asNJ/tksK2jvB0tgweEms2nCH8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QB5SI/pQkLAzQB7bn5/uxcb06qJhknkRL6GHx+86AbY=; b=voKa/mO8UMfuECBB83jSsceLkxTj66Id56atHTUPA1Vu5VeCsou8sxFpIbdhtCMOf9caA7il/m6KASkCXWbCSbx8YyaflVsZrjlcoaIIWrw+J3M9J/DwRb9RAhEG0nJ6DWr77oj9dr8E+K9TvjavcGn5hnsPgv+pde8HdK3Zfi+3ZJXvGtgosxzrYIt7N1ZpyPFEVffPHLXppF4yTqrX5unS/1dOBIRmpxutzWx478WxST183DE43Hwl+ra0zdSBzizxN+89Caw1vS+qfpbQPKmvp36ujjYHMwcD9D4mqPuz7okKlLRlmkR2tKs9qRPwCIcWcCptC4x+PtVOZd7FrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QB5SI/pQkLAzQB7bn5/uxcb06qJhknkRL6GHx+86AbY=; b=IWwIhGQovonO0miXtWNfmpIoFWlHhehZXljTuQdmLHEXbcQzbistJM2qKx+fRLQkTGt/hDyBMKwHxw7yDq24rD77oJFAxaOLfbuvJRr1FLy/P9rGeMyu8ok1YP2RiIN8Fkb21aeUUK0v7V3HK0G5FW55PHIjfhs9RbJCHLchJildc9GN8z5Im4fE7rd3jT899FgjzFUpQKgQ4J8kVHKGCXUnVEOfVkgOpn6JIsnEN7cg2+3xBqEEK2nOiXWsoXdgX8C8hkTUuD1jx0oycWoffs2DrAX7S5RnbNRutfjxFGlg6WPeR2o7fAdL+YGYNZ3tt2xvQz1c8Su2vb+SLfnJRw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PAXPR04MB8736.eurprd04.prod.outlook.com (2603:10a6:102:20c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.23; Fri, 9 May 2025 04:47:15 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8722.020; Fri, 9 May 2025 04:47:15 +0000 From: "Peng Fan (OSS)" Date: Fri, 09 May 2025 12:45:34 +0800 Subject: [PATCH RFC 3/9] gpio: lpc18xx: Make irq_chip immutable Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250509-gpio-v1-3-639377c98288@nxp.com> References: <20250509-gpio-v1-0-639377c98288@nxp.com> In-Reply-To: <20250509-gpio-v1-0-639377c98288@nxp.com> To: Ray Jui , Broadcom internal kernel review list , Linus Walleij , Bartosz Golaszewski , Florian Fainelli , Scott Branden , Vladimir Zapolskiy , Keerthy , Robert Jarzmik Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1746765944; l=2380; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=Qz241mmKXCwKGOl5Ksj3hwc0ajIp1wg0T0UUbiHF2G8=; b=/sGu+t2jBMw40Hk0hIoEvAC3uraOpUSl/uAuVH6rdqEp1F6QchTJOv9cAskhW2mj3mwaJdKqG i40llae4LFfBbtXlP6GIZe5GkeoA2UqHPnK0Pl7dzySwr6Asjz4ORUB X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI1PR02CA0011.apcprd02.prod.outlook.com (2603:1096:4:1f7::19) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PAXPR04MB8736:EE_ X-MS-Office365-Filtering-Correlation-Id: 4cc04183-980b-4428-375d-08dd8eb4922d X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|376014|7416014|1800799024|366016|38350700014|41080700001; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eDY4RXRaYVlJc3F6bmJrTTdsdXpHaWlVY1AvZHp6SnB0S2l1ZmlOVlMyRm1T?= =?utf-8?B?RVRvZWxROU80amRWSGJFUStRVjljbjdJUmIwMTJxV0xDazRKSjNQaG1xdWpS?= =?utf-8?B?TTVPUjZOcWlIeGpGSWhLZ1VldklwRzVZVGVUR1hWS0xiOGJQN01WRjR1WHp1?= =?utf-8?B?SldaVVFRRW9mdDh5dkRDcjRnN2JGRGVjcWxlakZYeDNVZUZpSGRsaEwrZndI?= =?utf-8?B?RlU5dUtIenprL3lYUVM2N01CTGlzQmtmbmhGbFdBeEFHTGRzZUVxSlhEUkhT?= =?utf-8?B?M3daN0VjRSs2SjZLQ3FnKzM1MU5LaDMvdUZmMGt4a2gyMlNxaVk3bEtJb3gz?= =?utf-8?B?QnBlb04zQ0YreFowQ1k2ZG1VYXBFemU0c1hQNDgvUEUvK0svMEJBZTFONEFW?= =?utf-8?B?ZmNxc2RYL2JyRXFWMzZ3TmJXbUdPWkpIN0NlTjBWSGdyUlhqVDl4VkljeVgy?= =?utf-8?B?NkFUeitCYVdZZEd2aXBUZkFJZUEzNEx3Q2ZXbVNxbXhzTDg5Nkl0czFqU0hG?= =?utf-8?B?RDl3SVlSTnh4a0x6dHMyVUFXaVhLZ1hreFZ0S3BOeHphd2VrRnh2eHd6cVdX?= =?utf-8?B?b3FqVEl0Yldyd09MT29ONDByVkhyczkwdzdZalBxU28xUXhaeHRoZDVmcHAy?= =?utf-8?B?M05mSjdqcWdPTW8yRTQrMjhOemdYR3J1WUtHUFpqM1JKUEpCM3pqRWpsL2Fw?= =?utf-8?B?clN2TWMwN1J4RGFSRXhHd2VrYWRvWGliRFJsN3JVRCtrUVdpRzlHTUVmZlFx?= =?utf-8?B?S09OWTZIT3Q2dFdySHlFQlRoNklWQkUvbHJnV05TZ3lZd2Z2aldWTmUwMFJK?= =?utf-8?B?dlkvUnR4VFZWUGN3b2ttdFZ5dE5QQzJDYmNqLytKN0x0WUM5akRoei8vRjUx?= =?utf-8?B?a2VWa2N6czJKL1F5Nm1hSWhjRGhtczNvUVV5a1I5bUNpT2dONFNiQ25GRmhn?= =?utf-8?B?UHdOeEZOT3ZHZFl1NzlITEtGbGEwSWxybFRoZS9yRm5lZVhETWo3dkIyRTIw?= =?utf-8?B?NS96aFNKVWVNNnFpR3djQXJIeFJHTUdSVDNnVDh0ZWE0aFNzbFJNNnF5SWd0?= =?utf-8?B?MGRwMjh1S2hXbGFqZEo2OXhFQ0RlZXRWQzNSYThVSDdHY2lyek1HMVRTNk1D?= =?utf-8?B?RGpQNWFEY1pnbUFyVWNwMjJqdkxvYlcwSnA1WFBsbFpIZ0xrUUhmbGRGQ1cz?= =?utf-8?B?c1Y4TWdWL3ZiOGp2WW9PVnpUU3k4Z3Y1YjUxdTRDUllWRkNXTmJkenpYSDVG?= =?utf-8?B?YlBPQXBIbHlDWlBuMkZiR0FrbktubUU0K2M0UGl5RncyZmdVc1FFZHRibUYz?= =?utf-8?B?d3IrdC8xakZGQytQTU9BeFBHZkpZenAxcGE1OC83MkhyQStQMStEZDVUdTht?= =?utf-8?B?SFc0Z0RyRTdWdGxsTXpQazhmS0RtNkhrUDdIOVpPSTN6VTU2dSt3ZHk4STBp?= =?utf-8?B?Qkc3eUZmRS9WVTBOa3dOQmRLTnhFRHNpbFFTR1pEWXhvc1d1TE1kVGMvbW1z?= =?utf-8?B?R2hmc2thSis0ekNHYldKb1IrODQ2YXVvcGZVRVpyR0xFODhzV3JrRzBjVUhq?= =?utf-8?B?KzBCTEpDYTVPSWVJcGFsZGRBaWtvUHhldGJvYm4wcHQxSnhKeEJBaStkcDl4?= =?utf-8?B?OWY3QnQ3MVBzMmNDeXg2OWF2Z0NWT2Rvd3dld3llbW1WRUJuNk8zcGQ4UC9u?= =?utf-8?B?TmcyQTYwcTlWTUViclFmSVMxSGY2Yk5NM3VscUVpak9iNFJDR0pTWTYxQlhO?= =?utf-8?B?bDBaUlc5SDNkM3VDeE42ZnFScUtibm9Uc3UrRUs5andHMmZnSzlmQXdhVzJY?= =?utf-8?B?eDFST2RZOHk0T0RFcW8wRXlKVVhGZkFPaUdiRENwWXdKeDYyMzBxUjV6Sith?= =?utf-8?B?VnNqSmhMTWJHZ0VtVXBrUkJIZVorYk54WCt4dUhIVzlQeStZUjFFd0lSTEQz?= =?utf-8?B?L1Z0R1poMzRLcVJIVGJOUk1ndHhDZFhyWmJzVm54K1N1b0tNcGw2ZkVqd2FM?= =?utf-8?B?MlFWMGhaemg2cjhCUHozYldhdlkyd1NyY1hraGYvSVRPWXY2TTlPUUpiZHJC?= =?utf-8?Q?WWV8Og?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(376014)(7416014)(1800799024)(366016)(38350700014)(41080700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qi9PVTJLZWhsYkFPOWxScit5dElpQkQycmgvYnVCWFZBb28xN3ZHWVQ5Mkg2?= =?utf-8?B?ekVTZEpGQU5wUGc3dmpvbUNHWG1zWGdsUDJCZTU0TUpHZUVESHdVWEZZVVJw?= =?utf-8?B?Tnc5bTJxcGJtWmx0MUtwMnIwbUtjenkzVWxXdEV6amowb0M2ZVBXZ3JmRmc0?= =?utf-8?B?cVRZTlVqOFVQWWdPcVJyYTdqanV3YytscWZHRVcwT2ZVQm1tbzRpL3B5Sk5Y?= =?utf-8?B?ajRoTUNRUTlBUWJMajBiZG1SSCtJL3lxVDlVT2kxbk8vWHJmZng5SVhzSG9p?= =?utf-8?B?Z2JIbitBNmI0Tk0yNEJ1cmRQSDBsU2d3WDFYMWVRWHE4M2FyN0UvTkV5b0wr?= =?utf-8?B?WTVVdUpXd0FMYXZpcXd5ZS96WmdMR1RHWExnbE1FVXU0bFhGa3l0VkRGSjJT?= =?utf-8?B?N3NMUjdhQkZ5MFdwYndreFRlcXpCZnRJbENUNEljZElZM1I2UkltRlhpRllx?= =?utf-8?B?N3psMTBnQjJMcGVwSVBxKzlPMXUrWUpLYTlvTGdZb2ZVcTVxemlxNHgrNVIw?= =?utf-8?B?b0k0OXIvcm0zT3ZzYlpGSjJ1Z3ZVMUlGVisrSXpqcUNZRlJOMlFsUjV5bmtJ?= =?utf-8?B?aDkyWFZucmJMY2oxMXo0aXdqeWxmQUdMcHFKdVRpRmxVSE1ZYlhUOFlRMmMw?= =?utf-8?B?UDJhQ2dBdGVOUHR0d2gvZkdHM2JaSXp1VmJPN3pVUnRDc2Q3cUJKZTFRL1o0?= =?utf-8?B?N1NCbGpUaDcza1NScHdTR3RPL3FJV0VaeVVPMnhyMjYydHJOWXl5eU5Pdk00?= =?utf-8?B?WjdWWFdRRVJpd1Jra1dlc1NWc2Yvd0VYK21VanZCREF4ZlNpZXg3bzFnT2I2?= =?utf-8?B?UUpQN1NvaHJ0aG12RnVXeWxSUldhRUhpSXRSUzhLQ0pvL2J6MHZaSGZpSHl0?= =?utf-8?B?RTlLRlF5dmlCbkdWOG9DYnhJUzJ5N3orY3YyRjRhalErUHVjV0svQUNRYVFS?= =?utf-8?B?UVRwMElNOEJsQnNpK0NVNzMzMzlmNmNvME9iUmZpYld2K01PeHprUnU5a1NY?= =?utf-8?B?Skl0aEhDK0VIZS9YRXRTTElCYzZYT2Q1blNoTjVxbFF3QnNNeFhJd0FGSkVt?= =?utf-8?B?aEVMV2Y0RzQza2lWU0Ira0kzU1M0MnZEb1I1dHUyM3AxeTh6a1J4SSswU1ZR?= =?utf-8?B?b3RSZnJuV0FjSlUrOUE2VDJtanBVZGFSSkt2dUdSejJMbCtUdXcwWk5FMjVz?= =?utf-8?B?a0kvMDZOK1FiSHoyeFo5bnNvTmpQMzVNWHdXUGZtTnZ1b1Y3V3JXLzBDQkRY?= =?utf-8?B?TDJlbGlCaVByN1FFallqbnRNTUVVcWNQT0RDZGFrcGhybW5ha1ZKM050ZFA3?= =?utf-8?B?YWgzenlmMWpQeW9sbUovQnVaeDE3RU1yblNGMTQzeEpSOUM1RUorbEVtUVNZ?= =?utf-8?B?eGFaZEJuR3YrVWVqZ1JHVHdJSUFyeTk2aFduc3hPV3JTNC80cVB4WWE5NVp4?= =?utf-8?B?TnNrVlNkT1ptdDJHcS8xMkUvaWtLSysyUURDQ0RJZkpKN3ovRkIyd1V5RFdM?= =?utf-8?B?L2oydHMrbFFsa3BJbE02cVdPTzMzZGtrSFFOVjFaUzh2ZHZWejRyaFJFVnVy?= =?utf-8?B?WVhoMXp4TTJTQzZTaEYwc2MyMGRhT3UvR0IwNTVmbmtmYTZmRDVpbDUwTCtC?= =?utf-8?B?R01objY5cFZWbnBhaEFYY1AzMXJrLzN0ZXpCZ1gzRW9kcWdEazAxVjlZUXdD?= =?utf-8?B?enRLZUUzSXNGZHl2Nk1IeUpFVDJWVk5JZEVkdk1VV00xTlZwaTVNZ1hrN3lH?= =?utf-8?B?WjIzSmY2ZFpyaVYrcmpRaE5kVTJHOEQ0VlBNRGJOdmU0Q0ZaWmJ2WjdJZjVS?= =?utf-8?B?dnpkd2JrNy9mR1lDa1RTTWYyOTlIcUV4bTZseU9TcTBsMUI1NkhiblFCMUR2?= =?utf-8?B?dElhaVpZVDRib0tIQjNRZUdYOC9oakpDYWI5cDBQd0RoNGhXSVp0VmloY3Fu?= =?utf-8?B?SFlZSXlnNCs4THhnamQ5NHh4ZFJOaEo3cWNFRXdPMy82VWFJTXZ1d2UwTWtP?= =?utf-8?B?MDRXWUpDMGZPSUdXeUtWaFM3UGN6T2RZaFpOSm1EamR6OGk0SG4rMGZUR1Nz?= =?utf-8?B?OEtldm8xUDJvRVFiOWRnd0ZvU0RlTXdRMTFHYzNvdzZpOFYyQ2F4M09vOGtC?= =?utf-8?Q?f6148VFLVzBU5zUiOJoVrAmOx?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4cc04183-980b-4428-375d-08dd8eb4922d X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2025 04:47:15.5456 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TtjAAz6fuHfZxpt+uW8k1naOpJqbY+uv4E6HifmU1JvEvJ8Uk6i70P4IvkkMGptyp99Qdw0tZgylA/JNhTt7lA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8736 From: Peng Fan Kernel warns about mutable irq_chips: "not an immutable chip, please consider fixing!" Constify lpc18xx_gpio_pin_ic, flag the irq_chip as IRQCHIP_IMMUTABLE, add the new helper functions, and call the appropriate gpiolib functions. Signed-off-by: Peng Fan Reviewed-by: Linus Walleij --- drivers/gpio/gpio-lpc18xx.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-lpc18xx.c b/drivers/gpio/gpio-lpc18xx.c index ae6182cce7234166fe94ab0c8d5e07c11bb71101..a2e316d9350b736e8bb89c17845= d70cc74481d1b 100644 --- a/drivers/gpio/gpio-lpc18xx.c +++ b/drivers/gpio/gpio-lpc18xx.c @@ -42,6 +42,7 @@ struct lpc18xx_gpio_pin_ic { void __iomem *base; struct irq_domain *domain; struct raw_spinlock lock; + struct gpio_chip *gpio; }; =20 struct lpc18xx_gpio_chip { @@ -74,6 +75,7 @@ static void lpc18xx_gpio_pin_ic_mask(struct irq_data *d) { struct lpc18xx_gpio_pin_ic *ic =3D d->chip_data; u32 type =3D irqd_get_trigger_type(d); + irq_hw_number_t hwirq =3D irqd_to_hwirq(d); =20 raw_spin_lock(&ic->lock); =20 @@ -88,12 +90,17 @@ static void lpc18xx_gpio_pin_ic_mask(struct irq_data *d) raw_spin_unlock(&ic->lock); =20 irq_chip_mask_parent(d); + + gpiochip_disable_irq(ic->gpio, hwirq); } =20 static void lpc18xx_gpio_pin_ic_unmask(struct irq_data *d) { struct lpc18xx_gpio_pin_ic *ic =3D d->chip_data; u32 type =3D irqd_get_trigger_type(d); + irq_hw_number_t hwirq =3D irqd_to_hwirq(d); + + gpiochip_enable_irq(ic->gpio, hwirq); =20 raw_spin_lock(&ic->lock); =20 @@ -149,13 +156,14 @@ static int lpc18xx_gpio_pin_ic_set_type(struct irq_da= ta *d, unsigned int type) return 0; } =20 -static struct irq_chip lpc18xx_gpio_pin_ic =3D { +static const struct irq_chip lpc18xx_gpio_pin_ic =3D { .name =3D "LPC18xx GPIO pin", .irq_mask =3D lpc18xx_gpio_pin_ic_mask, .irq_unmask =3D lpc18xx_gpio_pin_ic_unmask, .irq_eoi =3D lpc18xx_gpio_pin_ic_eoi, .irq_set_type =3D lpc18xx_gpio_pin_ic_set_type, - .flags =3D IRQCHIP_SET_TYPE_MASKED, + .flags =3D IRQCHIP_IMMUTABLE | IRQCHIP_SET_TYPE_MASKED, + GPIOCHIP_IRQ_RESOURCE_HELPERS, }; =20 static int lpc18xx_gpio_pin_ic_domain_alloc(struct irq_domain *domain, @@ -249,6 +257,7 @@ static int lpc18xx_gpio_pin_ic_probe(struct lpc18xx_gpi= o_chip *gc) goto free_iomap; } =20 + ic->gpio =3D &gc->gpio; gc->pin_ic =3D ic; =20 return 0; --=20 2.37.1 From nobody Sun Feb 8 17:13:49 2026 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2044.outbound.protection.outlook.com [40.107.249.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9444265CA2; Fri, 9 May 2025 04:47:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.249.44 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746766042; cv=fail; b=rAZIJyEdYsx7yl7y32Vm1yCb3E0uki8qoChTXE0h2ciiLYT+vKD3vqVIGdKfHTyu3+zumUtEJLWCndj5++sUeMEjT9z452/e2yb+C0NmXnCFbawhhDUrFbUaf5+3X6BDIejA6sU21UiE6Bj4XqB7sZX9VlopsnfvK6tbN8IUkZc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746766042; c=relaxed/simple; bh=htc4J7OFd9hkd/s33p771hBb5XhU1E3w+Jd5L6vdTkQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=hBsfy/VcqbyHenpdcBl/5mO32+duyY2CmokFkG7RSTjJWzRmnSKGrKhUeJArcrsbXfXCZJklrqLx4+Bc4pEW5q7p9DktAqTuiWR4Y/oYIx2RNciXodKKT9Rb8YMd4EJVpXmzxklBSnw/+7sor+xb+4x6XRCeW1ZtIQoK+eqcTV0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=DcGstUTI; arc=fail smtp.client-ip=40.107.249.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="DcGstUTI" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Cn6KSUvdFFdly9YClKtKXR4cKO9USzkHlnIZXxyGarVWkjNhkjXGRgAbnbp0HOdlVqBFqBJiY+6vEuv5Xmjf5t0ahge/NBJ9rsze3t0RplWhy+KeuR0TfDLBC/FABs2sAsUEogRMLVeyzpAX03wy+KHdsxpWQk6gTvg2RYKsY2NKhRmULpS1qisCAagwoQB+1heUxqleVB8qVgDnnpKeAYGbIfKdFBR2YnCd8OIRyWNvFcz6v/h0t7ZZzZVCCfUeo8ODnAdQWRDXMVbh1ZE70hiXdFGcTIriK8TelXpGXomOPr6BNDZ+wJX1gFBbZ634LCus7ClvhP/brFu56uRrJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cY4WlWNQKHmiP+fJwOu0OlAPAHncJ/4xYG/UJMm6RbY=; b=QkTeQhf2vHWlellejuLIMei+nEafgNwBa+wWPuUHS7/Mu0+X6ciYN3uUeA8wvAyhxwj3Hyh2lgcUC7sV4PGalf7nUEVLRmV+I2lKq0bwuSmT2+MR93bv5EwBxGzpUSMmCATziMEh49/4XCzEOFsP8OHgDWHsDSsYNMFBaY5scC7PwH0r9BHWe0fvmlOEvSKZDazCaBQvtR7j+4xALTDEqPGLYC+0/yNvM0C9zWe+ImqCssLUWYC2I4Gh80jP3RjdWIEidoqb2gw9Lg6vs7byqbswOqz5IVzXwiirtlExYxfgR/82EP4axKQ1Ssh42Jmh0YMHsgNr0uNaUFso1qxdXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cY4WlWNQKHmiP+fJwOu0OlAPAHncJ/4xYG/UJMm6RbY=; b=DcGstUTI7eadfAw8nvHTTcxAb1DTphbLiO2TgzzYpQUOWkYBgPyMtY7FwDRb4mZyeWwYE3wy1t9BVprKBQHTPU6NOITLYT6D5qzCn6YfI2Lc0+ePCD7TAZClseVMWCAjNuZzv5nho7FqKFIy3NqXmJ7cTGI2Q/5a/SX/xekSGKjfcc+bs47y9EG9yG+rtuTrQWUFZCdfVyOV99W3dbN1Oy7NRKdg2cr5+vovm2m6ULip9MpolPbTGhhZvlcFaKucM8SOFUTmEG9VN1TEa/aWfoV2X77/0eH2d4lYtdY4bZq+ZVqGajQOYrtZRzHorOukFvUN3xBJeCT1v8oZRVX4cA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PAXPR04MB8736.eurprd04.prod.outlook.com (2603:10a6:102:20c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.23; Fri, 9 May 2025 04:47:19 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8722.020; Fri, 9 May 2025 04:47:19 +0000 From: "Peng Fan (OSS)" Date: Fri, 09 May 2025 12:45:35 +0800 Subject: [PATCH RFC 4/9] gpio: mpc8xxx: Make irq_chip immutable Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250509-gpio-v1-4-639377c98288@nxp.com> References: <20250509-gpio-v1-0-639377c98288@nxp.com> In-Reply-To: <20250509-gpio-v1-0-639377c98288@nxp.com> To: Ray Jui , Broadcom internal kernel review list , Linus Walleij , Bartosz Golaszewski , Florian Fainelli , Scott Branden , Vladimir Zapolskiy , Keerthy , Robert Jarzmik Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1746765944; l=1982; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=4j9oSA0KByfIsCZAcLkqiclcrvnGC5RjquiLsBcg7yw=; b=m9EsFFtZVTSarBcHpAVUTna9caoXkUuE6kcPFnDzD7oDVAqVZzjlCrONBHcp3MN4mVnAA657u EjE4+OfWcejAsKuYBm/gW5dkjwMAgwcs4GGWrIJqWBAUotWKUog9ImG X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI1PR02CA0011.apcprd02.prod.outlook.com (2603:1096:4:1f7::19) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PAXPR04MB8736:EE_ X-MS-Office365-Filtering-Correlation-Id: 1c18f505-fe80-4c30-9dae-08dd8eb49470 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|376014|7416014|1800799024|366016|38350700014|41080700001; X-Microsoft-Antispam-Message-Info: =?utf-8?B?b3V4OU5sS2ZUVGNtREF0QmpLVU9nWS9rS1BHbXcyamIreS9laDZ2SGsveFI0?= =?utf-8?B?d1N2K2Q0cjhJMXhnL2dXVGd1OUhMNDBZUjJkOVY0K1kzM2hFTXd2amcveVhY?= =?utf-8?B?OTVacTRvanI3Yk9oZWZVcC90eHJubWwrUDM5WG9JM1RaK2R1NC9jdmhDQ0Fx?= =?utf-8?B?YmlLZXkvUk1sQzR4N3FoZ1lCZWlLamJtOUkxUGJWVjJwSFU2NjZCdWVmV2tu?= =?utf-8?B?d1ZId2V6SW8xektiNHRkUnZ6ODNJQnZwRmthTXFaZHozcnJVWkdxMkJBMHdt?= =?utf-8?B?RVR3eWNGdWVSUG4raFU3ZVUyWE16TmU1UGxKb2tRQnplL0l4ZWg2dlhvQi9z?= =?utf-8?B?Wm11MXhVRDRFUERjbHh6QWpwb2ZoNlFKUk5ya1E5bGtLcDUzQzd1aE5xODc5?= =?utf-8?B?ZnU5a0JwRzAveXpyVmJqcnlLbmlMbXF2T3daRy84RHphb2dPTHNGVzdGZnZa?= =?utf-8?B?aDRtam82NDdZaUE2MWwwdytRQ1dycm1ndGVZWjdwV09VMG1WSEIyc0lvN1BD?= =?utf-8?B?RXhxb0lMOFFVbW85Qmg4cVNHOUJoaGFURGw3UE9tM3I2bGhWdHZXRFhvZXo3?= =?utf-8?B?eExlQ3NUb1krM2k2bWJMZUc4T3hJMXIrTW5UenkzaHhSQTlReWNrUHY4eU9v?= =?utf-8?B?ZnNzOG5LSlhIckRBWnZLMVZrSTdhQjJBZS9tc2psRVVpcUg4aHA3VnFaaHhs?= =?utf-8?B?NEZjQWZUQm9LVTd0MlZHcnVodGJyQ3NUbFJPWlJhelQxUk5FQUlMNmZmaE1J?= =?utf-8?B?d1JlWEFES1owTmZhUG9yUXgrZjZjR2kyUHhGN1d3c205NFVWRjRxMzVhenZR?= =?utf-8?B?Mk9rTW5EK00xUUFvdVpuWi85eHJabGV5cG8wMkFHWnhCWjlQZ1lPU3NaaVMw?= =?utf-8?B?Tm5RS0FodkpjcVpHaWtyNEdxUXBlTXIrWFN2Z1dUajBoSmphZ3p6SUJoaE4v?= =?utf-8?B?WXB1TWRRSnVMU3VOUDZxNE9jYWp3MzN3bVl4Zkgyb2NUdTN1eEFaWE5OTThR?= =?utf-8?B?eXk2N1YyNkhpb0ZNa1gwTE1oVlZyN0Zkd1VBNlNtTGd6d3g5NnZjQ1F2dW5U?= =?utf-8?B?OHgrY1pwQ3BJSWRrQ3g2U2tWWHU5MTVQQksyN1RUcmVoMDhlTXYwUzRqNGow?= =?utf-8?B?VG9uQkZVSGU1RjJUTXViSkVOaEFGVU9nb2xHUWg4VzN1VG9ITDlsVkVJUDFn?= =?utf-8?B?elFYNWg2WDU2SENKMFAxcjRrbE5LSWNGb0VjZFA0NnNBT3BNNkxXSUI1ZFNl?= =?utf-8?B?U2VoNS9RMVdiY3N5NlRZYVpBdE8vZGpnaDM2b0tmUXdYWDNCOG1pYUdSclNl?= =?utf-8?B?T1JUa1lOZHdzWWdWMUI3K2RNYUZvZHVxYTNyZFR3dlM0OHBjS2k0WHYyZmZp?= =?utf-8?B?Q0lzdTRPbGg3OVdKTW1sUk56QURxSUlkbTNjV2NJb2F1Smw0a3Z5V0pKcklm?= =?utf-8?B?S3lDK0ZxdklSNVd1Nks5bTRRUC9SdERCbk0xRmZiYUNSdWhCMFhMQlZBcEp0?= =?utf-8?B?K3g2TDlJckg2aVhTUHNGV1Vtck1pU0o3a0VrQU1sRStrdUs4TlJNeVZ2elBB?= =?utf-8?B?bVdheDN0b0ZIZ2gzc3ZSaGJQM2lJZ0ViM3RlUm5RRytlWHphWVlkb0ZHeDFY?= =?utf-8?B?L1N2azV5a1dHTHpWSm9qd0ZxMU5SWDdVUTlKcUdkb1BtSGI0Mzh5SDV1dHpC?= =?utf-8?B?YURadldvcG1zMVZ2TTN2OTZSNjNHaXJlYU85cDI3M3AvVks1MHcwR2l4Zm9I?= =?utf-8?B?STZIZ0lSbmVOY0xFSDlsaEI2eGdmc2JPNTE4dDJCT1NRNjN0ZkhYQUhPTkMr?= =?utf-8?B?NHNRN3RhVkxibnY5eUFtd0lpMHo5ZnNGNm1sWnZkNjVOQVV4RVhxbUFoYnBY?= =?utf-8?B?TWhnVFM3eUZLTmtJc1ZBUmc3alIyQThZVllyWkxFcjlGNjRsaWV3RG1neDRC?= =?utf-8?B?a2hMZG1iU0h0eWl1ay94ZHJFeU1iVzdlMHE0eVR3c0NnK1plWEVPSUY4RzdM?= =?utf-8?B?MGpOTnZEMU9ETDhoazJkbjdZc2duOU0xMUVmdDBwQ1M0SmNHdUxGZHdxUDI1?= =?utf-8?Q?rnp6ZK?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(376014)(7416014)(1800799024)(366016)(38350700014)(41080700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RXIrSHBwYzFMVm5OSC9HNFRWbWdQeXExNFI4KzFmbUQ3Y2IvaHpQSGM4alZo?= =?utf-8?B?OTVaRDRsQ25OUkRiWlJjQkp4YTRNdUFXeG5OQVBzWU1OaWJEbDF3VnNxa3o2?= =?utf-8?B?U1MzUlBZcFNBRzJYb1hvUGI1WHBGQzJiM1RZRU8zMUlRcXZpOWZzbGIreWZz?= =?utf-8?B?MFdwZmd5SVZIWDFYeHhUVk95SUZxK244eGNpUTBkYk8wcndpVkoxN0kvRW42?= =?utf-8?B?TjFQVkhBY0UydnROS2IxaDNiSHRVdjQ2djIwbE8wK0xya1UzS3pkdDdOTkhD?= =?utf-8?B?Z001blZYTWFKVy9iSG5aSzlRRVRVUXk5cEs2SEo4VGd1TnZBTGJYZEsrMndE?= =?utf-8?B?N2k1OGZZa1Q4T0ZRQUcyc2E4cmQ3bDlYWmtrYzlYcUk0cEJYSG5KZ2VmZ3JY?= =?utf-8?B?ZXlxMVJDWHA2UU5OdVdJN1VNN1R5ejN4ZkhaU3RBU2xLeHhOWDZjSFl1ekhR?= =?utf-8?B?bjZWTVcrZ3ZGT2x4aEdJK1RGV0VxclFiWUlIbmMrcWVZNU1wUEFrTEtxQkxn?= =?utf-8?B?OHRFSWpxWDlXYUJVY1ltQ0prcUdZWkR0RzgyTFIrQ0Q0SVg2MGFPN015LzNn?= =?utf-8?B?R2djbUt4ODF5QSs1Y2NFb2dDb0NiMHQ4cTAxNThrQjQ4Q1NaRzRsVXBXY3FM?= =?utf-8?B?TElyY2VXMWFGTWQ3S2tYZkw1OFlQQWViQ05qckVMR0pBcy91WnQ1cm9rMjVG?= =?utf-8?B?aFRBcVg2TWdySGtIWFVPSVYwK0ZjWC9PeTg5U09lRVc2dnBZejhVNTZVVEsx?= =?utf-8?B?dGx3WTM2LzArMzdvdnB3a2lJV0Q4VjBiNW5YVWExcnd0aHlzend2L1FHbjU0?= =?utf-8?B?cUQ0QllHbUE4RlJmUjVpcTEvMzUvTlpRTVBTYWZGRG1sRXd4ekVjejg2Rldp?= =?utf-8?B?WTVJUzR5OU9HaFJQNGx0RHgxOThFcnlIYmhLR3pQMFhKYzdPMEtLcy96VThE?= =?utf-8?B?VEc2cHRQNEc1U0FGMGtlejlUbmJYVVhLdEJQZHcwN0JTbnU3c0NkUjNsQTBI?= =?utf-8?B?S2FURVprSC9xWFpwNzhIbWhGalc2SE1wVGMzNzhNeFlEZXpKOTQ3aThmOHpl?= =?utf-8?B?ekw3bjhCcE9JbzBjRTJLMW1HUjJzZGJXcG9wZ05oUDhHNmVLWXFUYUEwWVI2?= =?utf-8?B?OStxN2Myc2xQNUhscXBDVjM0eThUT3d3RHRSUWQ4WXhZVERlU0I5LzB3ME80?= =?utf-8?B?aDFtMkJ5TklNR2dtSGpDV2lhb2M1alQ2MVlFbDV1Qkh2QjJhQjVsQTJobjRW?= =?utf-8?B?cDdnWE5HQXBhQzFYQXBtcXY3RFYzbjNxSmRiMVA2Szd6S09qNEdyOUwvNGg0?= =?utf-8?B?ZExWRWtNRkZHbXQ4VjhGSFJNaGs4S1dNT25QdTRBWTA5ZzZHcTBkSnFZUDVJ?= =?utf-8?B?Mzk5K1J5akVQcCtRVDlZS2owZWhtd3p6RCtJYlp5WUpPblNGRE51WExkSEQx?= =?utf-8?B?NXdMZ2NqWEFjemdQQjZ5MmdISWYzWGZrdWRVUllDNDYvR0twSFlSUkR4VlJk?= =?utf-8?B?Ykt3QlY2cy9XNkJlYldVWTV2QVZBQ25aNEp4WE5Qa1ZFY2JtYVY4THZTbWox?= =?utf-8?B?b2hxRTFINzFHUEJSeG96WDkvTTQwRDFwaG1CSEVoaHVkKys5YjgyUHdUWUEz?= =?utf-8?B?TURHTnF5UHBoWDlCRnJldDJ4Y0lvSVhrYnIrenRpdE14UFA3ZkZKZ3B5TXhh?= =?utf-8?B?c09Ic1JFSXJFeEJaL3FWbmR5ZXNQWmNLQk9OVWpaU0NwbFN5Y1hmRWNIRVVs?= =?utf-8?B?R3Q3WWwvMUE1NCt6Q3JKdHozNTY1bWJGdWxrQmZLVDZSblV6WEZGc2Q4Njh5?= =?utf-8?B?aWVhMmxlRmNidUVqRDM4N3VKTFFkS3RVeituYzQyZGcyV2hzNVljYlRCOEZy?= =?utf-8?B?aHpXZjJ5QmU4YWNDaDlLa2w0WkppcFV6bXZYY0FlTGUyOUF6NlNHMVZXb01j?= =?utf-8?B?M3NNZWJNbTU0c0lwR0I2NE5xbXBxelFwK0UrMXNkNlhreHpHL0IyMkg1SlJs?= =?utf-8?B?UHJiVTQzVFhnRVhneHhWRTNQVFhJdFBBcE1yd3NrMithNUJOWnU5ZDBwRkNV?= =?utf-8?B?TmZXUzVmbVFOaFk5U0pzVE9VV2lMeGJ2Titha21xT0t1eU96bzF2SnZHSllU?= =?utf-8?Q?38MpnmX5UmfIKiqPXxLKk1y/T?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1c18f505-fe80-4c30-9dae-08dd8eb49470 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2025 04:47:19.3452 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IIJjHMUSZEQbwNQBgNbWAHlEJmpE0MK7WgmqzCHRBA2PbGNyvRqNrMHKvGDXSdwAJTmIez72zzc4FrxZAjV26Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8736 From: Peng Fan Kernel warns about mutable irq_chips: "not an immutable chip, please consider fixing!" Flag the irq_chip as IRQCHIP_IMMUTABLE, add the new helper functions, and call the appropriate gpiolib functions. Signed-off-by: Peng Fan Reviewed-by: Linus Walleij --- drivers/gpio/gpio-mpc8xxx.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c index 5415175364899ef621fab83748f4cea34f430556..121efdd71e451d4f992fa195b0d= 56d7146a6f3dd 100644 --- a/drivers/gpio/gpio-mpc8xxx.c +++ b/drivers/gpio/gpio-mpc8xxx.c @@ -123,9 +123,12 @@ static irqreturn_t mpc8xxx_gpio_irq_cascade(int irq, v= oid *data) static void mpc8xxx_irq_unmask(struct irq_data *d) { struct mpc8xxx_gpio_chip *mpc8xxx_gc =3D irq_data_get_irq_chip_data(d); + irq_hw_number_t hwirq =3D irqd_to_hwirq(d); struct gpio_chip *gc =3D &mpc8xxx_gc->gc; unsigned long flags; =20 + gpiochip_enable_irq(gc, hwirq); + raw_spin_lock_irqsave(&mpc8xxx_gc->lock, flags); =20 gc->write_reg(mpc8xxx_gc->regs + GPIO_IMR, @@ -138,6 +141,7 @@ static void mpc8xxx_irq_unmask(struct irq_data *d) static void mpc8xxx_irq_mask(struct irq_data *d) { struct mpc8xxx_gpio_chip *mpc8xxx_gc =3D irq_data_get_irq_chip_data(d); + irq_hw_number_t hwirq =3D irqd_to_hwirq(d); struct gpio_chip *gc =3D &mpc8xxx_gc->gc; unsigned long flags; =20 @@ -148,6 +152,8 @@ static void mpc8xxx_irq_mask(struct irq_data *d) & ~mpc_pin2mask(irqd_to_hwirq(d))); =20 raw_spin_unlock_irqrestore(&mpc8xxx_gc->lock, flags); + + gpiochip_disable_irq(gc, hwirq); } =20 static void mpc8xxx_irq_ack(struct irq_data *d) @@ -244,6 +250,8 @@ static struct irq_chip mpc8xxx_irq_chip =3D { .irq_ack =3D mpc8xxx_irq_ack, /* this might get overwritten in mpc8xxx_probe() */ .irq_set_type =3D mpc8xxx_irq_set_type, + .flags =3D IRQCHIP_IMMUTABLE, + GPIOCHIP_IRQ_RESOURCE_HELPERS, }; =20 static int mpc8xxx_gpio_irq_map(struct irq_domain *h, unsigned int irq, --=20 2.37.1 From nobody Sun Feb 8 17:13:49 2026 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2053.outbound.protection.outlook.com [40.107.241.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CF7F26656C; Fri, 9 May 2025 04:47:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.241.53 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746766048; cv=fail; b=l/lWIdEqnNW+8jc+WbxuKfZsdeXomDBcJbhVFi35IpmkBlJqgJfDZOFc/29GoVuQO0Q2tvFdsRXdq6KN+3TEp/UFDl+3XrsmGlNp4SECu7o4/eas5h6RvaXGwT7KYZPCcljoh9aMsGjiAEj8bIS5OJJqpNVE3tmHrSZQz4/mZLM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746766048; c=relaxed/simple; bh=zCjpmGpwsl5urpEsD4+NIon5SpzEHQ7Mwq4S2hRKctA=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=ng3+le8UB/747tfCKTF7+M5hfDgpFqMdYfzzxwaLjnklitlXbMhv8NySGPbXT02iME+EZ7zIOAdLFirzvp+DDACBrhydlvfqok72bFOzKK8ZbUISe9RbK5T0exkC+SphlbdsEDvqfwcz4KwyoNP5C7y216yKERAEEnYA71e242Y= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=fZsfM5bF; arc=fail smtp.client-ip=40.107.241.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="fZsfM5bF" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rYIW7fX7nr65EXWHk7PFUoPTbCDsNdQUX8RFLEVG6aGBpAu25fOar3qfW0v2mQNGXakGol40OrRBhZ2KQv+whaTd59Pe8cUX9ZVJUu/5NapMdAL9V6y18IMmYi+FSGuMdayPuODrSbHcCB1wZZcVLYjkNBdTM/1B8Ib5pWkF6XNnE85wAG6D6Xd4n2Ngfj5iUtPZHMUQwYSbqHVvgOrKBaJHMkxiS6V2Z4/C0k5j1jOXf4qwD4KtZlnTcZrqka/JN0uEuUMP+mwAW6v3zMCpFWauFiR8VH6Yb3LyMPrIZhEIvyuncYpKhpV/IC+M2IMO0hJHSxlMSMMUXGWEHvzC2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=znsv2EWPYSYRTdG5abL+KjY1AUXxSBJV8UpqzARVx9A=; b=QtoJEuOlL0j20nYqN8x/KUCKZ5yvS9I79snY1rS01JH/X08AreY7/F3KRIrkuBmU5Y/r2kVnyk/kAT3WD7YK2Y4eJ7SP3yh3u86zH5v2A1StjuToI8o/a4cMWrzs6uoNUNs/Eson35f/z9tqTZ8Rr8q7TyU1lIu88qehJp5u7KukI4D79zdgQdnmXLmnKijHStoMcV8Khu6MhDJ5i5PjrBVvy5ECiuahhTqj/XuXjW5WCS9np/6drEA0zTUwLhV42ZrdaEAb23OBedrAiUo0mf515ILIwpzqaKFMhzSw8qGkf6fdk/TIq2S+/PJeB/l1UTeZqD+jh3U533Ip+DUaWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=znsv2EWPYSYRTdG5abL+KjY1AUXxSBJV8UpqzARVx9A=; b=fZsfM5bFBCuigIM1nAAej6oWDi3SV5gs7wnM+0o3/Km44E6g2u0gFmEc67jtuvwqinijV7Ox7mbkxdfBkoNFt8MpncwfLv3A88xqVYHxKzXpg+BwoB5VUqS9gSdpjFRHHtXBHxkLatvRBGuE4zgFri6kfh/43+MFznzkRO6OBNZYSRZPY5b+4PNyvdwODa8ngjrvJiwlj0h1+Et+Ls170DMzVghKrPv7z1JgfA1d3lI20DUo6uvfxFe5GLOjXrJxUegQ2W+UvDe7BNTih0duQDvBix8ZPa1lHwDr9SvZWDKFgBDh54AldZlTUXNV25X18Zks0UC+KpVzmuJvKOR6Sw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PAXPR04MB8736.eurprd04.prod.outlook.com (2603:10a6:102:20c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.23; Fri, 9 May 2025 04:47:23 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8722.020; Fri, 9 May 2025 04:47:23 +0000 From: "Peng Fan (OSS)" Date: Fri, 09 May 2025 12:45:36 +0800 Subject: [PATCH RFC 5/9] gpio: davinci: Update irq chip data Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250509-gpio-v1-5-639377c98288@nxp.com> References: <20250509-gpio-v1-0-639377c98288@nxp.com> In-Reply-To: <20250509-gpio-v1-0-639377c98288@nxp.com> To: Ray Jui , Broadcom internal kernel review list , Linus Walleij , Bartosz Golaszewski , Florian Fainelli , Scott Branden , Vladimir Zapolskiy , Keerthy , Robert Jarzmik Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1746765944; l=2614; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=2oQPUFLyyrBRXdZ7hQ/Q64Wp/MYfqdQZm0Xlq6uIOPs=; b=f9wkoLQHOPG7XWNCsb76DyabPWz+1yJd6MToDWGkpb0R71ZCd+yKe4b4flEoimQ9jzhajfvaB LzopEQGR2fPAU7SCW6i8f9h/hEI31NWkjHIBj7kbhQN4VAbU+Qycr5Q X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI1PR02CA0011.apcprd02.prod.outlook.com (2603:1096:4:1f7::19) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PAXPR04MB8736:EE_ X-MS-Office365-Filtering-Correlation-Id: 6a804f10-adfb-4322-59dc-08dd8eb496b2 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|376014|7416014|1800799024|366016|38350700014|41080700001; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UlpzSyt4ZTdWYVNoODVpWDhEaWhXNEh0dStZQURJZ2VDaThiRTVudUxGa1l5?= =?utf-8?B?MzV3RTE0NzlCbnU1VG9zcUpRajM2aHFlZFdOckpYREpzMnJmanpaSTFWUlJy?= =?utf-8?B?cGdDeC9YZ0hsalA5QXA3emVYbzkzWG5LTkRxLytCb0FYbWlYU1FHZXVzSnRv?= =?utf-8?B?S2ZCcEU1Vk1tRHVrSmxxUkZrK2wxb01VRWRtSDNmcjlFcTZqNHgzcTU0QXE5?= =?utf-8?B?VkxkZ0djczBLTWhUVXZBSk9UZEp1ZkJFaWhzOGwxK2tzMWR4dng2ZmlsWVhY?= =?utf-8?B?T2U5L2hTZVJDK01ubGhnVHRrbXRVRDl1QjlrNytLaVZBemQ0ZnFweTJjclYv?= =?utf-8?B?eXYrN0tpc09wYm5vK001L0xkOXAwS1kveFUyeWJBT1dGcWRESFY2dldBdWQ4?= =?utf-8?B?QTZTMnl6c1IrL3gxd3JCL2U4dFVmUDIycEJyZm1nUmRaRHZzVEhlbjh4Uzg5?= =?utf-8?B?VEtRSTE5Tzk5WXNDQ240UDgvU1k2aWRCZXF0MUd1amFCbU5wM0w3TE5aY1VN?= =?utf-8?B?U2p4NlhyTnBGWXNheDhPVHJGYyt0TE5sNWh2clJwUE9iam85MWRsLy83S1Fj?= =?utf-8?B?dWg0R29kdEk3MG80MGVHSHBrT2FQT3NCQmRIRkVyWTB3cHdmYXFWNWNDLzMw?= =?utf-8?B?T0tHTk9qdk1DbGE5ZGVTS0FBMXFGMFA0ZVdJZ3ZJN2FYTnM2aWdCTGFvSERX?= =?utf-8?B?cXEwQmFMRHVWRzBJVFFkUWt2dFd2b0NNUEtwVTRCMnYvZ1ExTFB3Qk9xTmZX?= =?utf-8?B?V2IxN3VPWHo3VmRPS3Zmbmd0cndXS1ptYUJVZWNPYlFTUVR3bGk0c0ZLNHJW?= =?utf-8?B?NEhNQkY2cFV0RTQxWjNlbTU4alhRK3BnWXRsdzJmbjc4SU56RGttcmxqaEtt?= =?utf-8?B?dWZ3aUFzS0pTQlZXcEZtKzN6WXNMMTFNbGJSSCttL01TSWtLNXZMWU5HQita?= =?utf-8?B?bnBEU0UrOHFwN2cySFV0SVl1MEZ3bUoxQkN0TDVUUGluYjFCSVNoUjhhcVgw?= =?utf-8?B?QzdmNWF2aGw3ZHVTYjJuekhhQlZSQVh1R0xVRTBHMkp3Rmc5bzd0OFpyTThu?= =?utf-8?B?QmdiODJjOGtuMFp5eGtIY1Fob0hlZUR2SkVEQmozZWJVeFB2aWhVMEFmS3FM?= =?utf-8?B?RlEyQzF2TTZXWmt0b01BQzUvQitiUVRvWHFsYkRZYXRRWFFYU1p5Mk52MHl6?= =?utf-8?B?c3VMdDhVS3dqQnhmbTV4M3FXUGlLZHFXdTlXL1pKbEMrRFVrMFNORWt2cFNt?= =?utf-8?B?Mk9CcnRhcUNyaUhzTXF3b2RXRzRpcnB5VGhRdUtERFVKRTlHSjJOdDRFeVVr?= =?utf-8?B?UXZDR2ZMRm5EaWMySGZjM0FBaGJCdno2WkZMV3YraTkyTTRVMGVaQkJyb3hu?= =?utf-8?B?NG45UEI1WEt2TDA3R0F1ZDRrZEQwQzhiZkd6SHN2NmJGMm9VcDgwbnJKc3hi?= =?utf-8?B?REFZWFVFck9kZ2xRMW1wdmwxbllBMnd5T0dmbHoyOWI1ZGd1bVhLaENSMWpK?= =?utf-8?B?Q3gxdTJjVjB6azZDelJTN3ZaN1dsL3ducnJDYW1yc2FCNnM2WncrREl0QWQ0?= =?utf-8?B?UDdoejZZYlgzcUh0WGZOWk42YlhudTJwRHQ5VDl4YUc2dVd4RXM4cjVERTZu?= =?utf-8?B?YXVlNHlMQUY5ZVlvWFVlcEE4NDhPRmpmUDdZakxUek5kYnIvYm96QWVZRU4x?= =?utf-8?B?NzdpK1hwVDdRTUdGbE5pWWh1NTRSaFBnQ1FmVzVWWmNWcDVtRWZnR1hwWXF2?= =?utf-8?B?MzAzU3NoK2xoaW1WVnIrZitTZG0vR3Z3a3UzSVdyaGI3NXNVNmljMElwbzlF?= =?utf-8?B?MlJZQ3hhanVjeHVrY0ZEWk10SGJmU3Q5Und5N2FhK1ZhRzd4ZU55b25HMlZL?= =?utf-8?B?Y2tlWDZkVGc4TXZyQ3RUMWg1VFdBaTdvTmp6bFdDNUtBWUJBSmRFNEsvNGty?= =?utf-8?B?Nmt6d3JQNzlPYlBDQnRkRkphcnp3TzJNelZXZGJoR1ZFU0tSOXhqVVpyZW9Z?= =?utf-8?B?Z0dHYWZjS0w4cGhVcXoybjB5cW53M0t5N1BDRmlONlB4bXlPTXl5U2VmYXJn?= =?utf-8?Q?IOSZUa?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(376014)(7416014)(1800799024)(366016)(38350700014)(41080700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWUvcy81cWExQnk5Y0lQQWQzcjdKRWl1NTNaN0FOM3NJSUdmN3ZLZVQ3WXdV?= =?utf-8?B?bHV3L1hibm1oR2JWNm5Gdjd5QXphZll4NXFMSEJpSHpUZEJsaytqSEwybXpq?= =?utf-8?B?UzVLMXJwNzkrYmoyRnR1VUNwZFVtdC8xTSsramkweDdYZzY3d3FLeEVyNmFP?= =?utf-8?B?WjcxdVVUMVMwbFVDM01VSmlMTUxLWEY0QzJGMnFkWGJheWRzUXFRcEY3WjFh?= =?utf-8?B?SUUrSlA1NUd4cGU3WHZkZENzWUV3Y1dFeS9CSE9aZGh4R2lISVo5eXJDOXZC?= =?utf-8?B?Z25MemJTTDREMUdGWURKMkN4RVZIeTlzZXpWQVJabkpkZGVXVXZ0Z1FHczJO?= =?utf-8?B?QzkrYzljS2hpQWxwenZ0Vm1XemlZbVVma0p5bjE2ZThyYmlzc2lFV1hJVXdK?= =?utf-8?B?dzQyMExzTFFyVkxRSkwxNm5DNitnZW1qSjdPbG80bEU0MEN1ZG9vdXdqeWRx?= =?utf-8?B?dVptL2NlWmJhNnd4TkFYck9YQkg5TUxLT3FtS1BwZUJVcjZvQnZodG9hQTk3?= =?utf-8?B?NCtQVTIrckN4U1oxcGx6NFRwNmg5anFUTklFR0xZaEtiV0xXb3NtdzJETFdk?= =?utf-8?B?dkVLTDJQTElqdmJCSndBN3p5b0hOZ1l1dTlWUExCeXIwRis4TklwRUI0c2sv?= =?utf-8?B?NmhJTyt0NFkxRFZrZ0I2MUc0OEMrYi95VXlTRXA3eDZTRzVKVHFaTU5iSGo2?= =?utf-8?B?ODlOMlhtc3pVVCtvdWNtSGNCQTdZdXduUldoMmNCZWFyOGpmZ25ocEw0dmxI?= =?utf-8?B?T3lzYS8zUTUxTVV2YjgwUlpveEJ1Y0xUVDcvR1FOZUNUQ0I3QTBTTWRpTjJB?= =?utf-8?B?Ymp0UysyRWFrbVN2T0dRdWhkOVg3UjcvT1p0aW9tbXdmWFduUHZ3NENacmRU?= =?utf-8?B?ejk1bkhLbDgvcHZISlMyTW45bDJMQTZQUC9Rc1JwKythcWNJZExMeC9xeXE4?= =?utf-8?B?NERKbGVsOVBaQWFRam5tV1QyNnpyMk5icCtXQlViRXdRSEJ3MWZDdk1HQkwz?= =?utf-8?B?TitObHRiTm9TWEpYMEttQXVnQnU3bHB4ZW4yYmJVVmJXa3oySTJucGdyaEdm?= =?utf-8?B?TU9FZXdMak5hY3BSMXJuWHpwZlJOK1BJaGJlb0E4ZUlxWjFYcG45THk2cWF3?= =?utf-8?B?eFQwOG8vNS83YVIwZVFBUXd6MTdBd0R2aUJGTkllZ0VDUXFIL05NN21tQVRy?= =?utf-8?B?eDM3TXQ5VytGTENRK25GcTJSdlNlM1djNzBWREc2YkQxcks3dTgvTlNJSkU5?= =?utf-8?B?ZWFzd0dRYURnNThvOG81cFUzRGtkajc0QkZwRkdmMkw3RkNiaFNDd0p3T3JM?= =?utf-8?B?UVBvYjFuR1EyMVNvR05RRmRwTlYwWXVjQnZ6QWNtS2RBOEE2cjFVbVZJbkN2?= =?utf-8?B?ZUxVbnlQUmNmV3ZnVnQrbXNPOVNneFlvOXFSZzMwWWtqTFZWS0NpZzFwWUYx?= =?utf-8?B?YVIya29kQjUrRnlRSEFreUdCTk1VdXFvbk5oeG52elA3MVRpbFVYaE1iVG1M?= =?utf-8?B?VkRGZExEeU9mQlpUaUJjdUdKNnhKeVVZTmcvVnJuTmtVSmRTYk1MK1hxRzU1?= =?utf-8?B?T3ZjVkxvSm0xYWNxQjRNSDlkMWNNUm9qRmZsd1FEQjRVK1crU1Y5T29IVGxm?= =?utf-8?B?MTZlQXBQanN6UjM5YzRaSGxBTi81ajNBZDFCMy9XaHJtRzhESUJlc05UMHFT?= =?utf-8?B?UXZQUDMrRjNlTWVFNDUxYmwxRG1PcEJYckNVV1R5bXVxQ1crcWpqazJ1WEh1?= =?utf-8?B?REdPbTYvVGlMc1hLTTgvMzRFY1lMYmtQbUtlNUNpdi9JTVRmNUJmdDVKOUsv?= =?utf-8?B?Rzd2YkhCeUNBR29xWlJhNzNaTm4rNDhQWmV4cFVic2tDMVI2U3hKb09yWGNt?= =?utf-8?B?WVd0Wm9lcU1TQTk3Ukl2aDRzWFB1RTBTRGVQakZRNEZ3UEk2MzRPMm5CdEdI?= =?utf-8?B?ZFhlbUM2ZG5DTjBGNHA2K0Z6NWMyNlZrcnR4YjI5SERpVk40b0NOTEdrZFlw?= =?utf-8?B?N1YrZDQ3ZkpRUHZRWExmY2p3clErNkVWaCt0c21zOEROWFlkUk5sWklwQ3Y4?= =?utf-8?B?NGl0Y2I1QkZOYlVscHdrSzBVMkZHTkltbWpCOU9qQkZIc2d6bjNIMWN3cEo2?= =?utf-8?Q?P/z9gI9NBTAE2zw81uA6Tvi02?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6a804f10-adfb-4322-59dc-08dd8eb496b2 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2025 04:47:23.1216 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Qo4TluE5v6A0k/op4leDLZ1fNjaMjeknzWM0krVYBGSsfuVsEvUWaWIppfhjZLY2nrRBu0GcsZ/QDio6WPCceQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8736 From: Peng Fan Use "struct davinci_gpio_controller *chips" as irq chip data to prepare for immutable irq chip, then it will be easy to get gpio_chip pointer in irq mask/unmask. No functional change. Signed-off-by: Peng Fan Reviewed-by: Linus Walleij --- drivers/gpio/gpio-davinci.c | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c index 3c3b3ed46d9b480eb7916fa2402e5bbcc06cd563..4494acc14630bcc7cb75dc475b5= ae7e0a595cc5c 100644 --- a/drivers/gpio/gpio-davinci.c +++ b/drivers/gpio/gpio-davinci.c @@ -68,15 +68,6 @@ static inline u32 __gpio_mask(unsigned gpio) return 1 << (gpio % 32); } =20 -static inline struct davinci_gpio_regs __iomem *irq2regs(struct irq_data *= d) -{ - struct davinci_gpio_regs __iomem *g; - - g =3D (__force struct davinci_gpio_regs __iomem *)irq_data_get_irq_chip_d= ata(d); - - return g; -} - static int davinci_gpio_irq_setup(struct platform_device *pdev); =20 /*------------------------------------------------------------------------= --*/ @@ -255,7 +246,9 @@ static int davinci_gpio_probe(struct platform_device *p= dev) =20 static void gpio_irq_mask(struct irq_data *d) { - struct davinci_gpio_regs __iomem *g =3D irq2regs(d); + struct davinci_gpio_controller *chips =3D irq_data_get_irq_chip_data(d); + irq_hw_number_t hwirq =3D irqd_to_hwirq(d); + struct davinci_gpio_regs __iomem *g =3D chips->regs[hwirq / 32]; uintptr_t mask =3D (uintptr_t)irq_data_get_irq_handler_data(d); =20 writel_relaxed(mask, &g->clr_falling); @@ -264,7 +257,9 @@ static void gpio_irq_mask(struct irq_data *d) =20 static void gpio_irq_unmask(struct irq_data *d) { - struct davinci_gpio_regs __iomem *g =3D irq2regs(d); + struct davinci_gpio_controller *chips =3D irq_data_get_irq_chip_data(d); + irq_hw_number_t hwirq =3D irqd_to_hwirq(d); + struct davinci_gpio_regs __iomem *g =3D chips->regs[hwirq / 32]; uintptr_t mask =3D (uintptr_t)irq_data_get_irq_handler_data(d); unsigned status =3D irqd_get_trigger_type(d); =20 @@ -399,12 +394,11 @@ davinci_gpio_irq_map(struct irq_domain *d, unsigned i= nt irq, { struct davinci_gpio_controller *chips =3D (struct davinci_gpio_controller *)d->host_data; - struct davinci_gpio_regs __iomem *g =3D chips->regs[hw / 32]; =20 irq_set_chip_and_handler_name(irq, &gpio_irqchip, handle_simple_irq, "davinci_gpio"); irq_set_irq_type(irq, IRQ_TYPE_NONE); - irq_set_chip_data(irq, (__force void *)g); + irq_set_chip_data(irq, (__force void *)chips); irq_set_handler_data(irq, (void *)(uintptr_t)__gpio_mask(hw)); =20 return 0; --=20 2.37.1 From nobody Sun Feb 8 17:13:49 2026 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2053.outbound.protection.outlook.com [40.107.241.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A38BF26658D; Fri, 9 May 2025 04:47:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.241.53 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746766050; cv=fail; b=pqkgkTT1PVvbM6F4DZ1H6PgwKXTCiPfNl2g+qkGUNjA5B74xZfm6gkE0CIW4yOkZu5uhDOs9i4khriVyWUYziCumFuA4JJLn+E38CCbQtVIJIgBnjynvlgwzKn1BLe+Y+LRrVQK7+InJ4/fW6p1qPCuM+ElD7RwBSdKWLe93ilQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746766050; c=relaxed/simple; bh=/Aln2p1g/BR223BAm9q+Kg6bpRzVKDzf17wLRK2quNk=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=sQpACsHKwZjHUz6i1iQqBZtBX1KzQLb2sxDRlkHLLYfqZXuVxru69HVHTkEp0grbaajgkYTSZ3OO1FnIvPx5hP3GO8suMJCrYQAbzTpQMH6sBoWe6duN+t88MYlxA68tpIeJjN2zvPLgM+yqP18Bds7Tjrg+5fHmj4Rw2VcPBKU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=ftZ0pa+j; arc=fail smtp.client-ip=40.107.241.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="ftZ0pa+j" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MlEdUj9bKzgOoiq2XizJywDMgbiah1W9fQL0SY//PI9u9gJ/Ber+AFoz8lpoERvsS8nwm0CvsRm5/ZDmqzw5SNtZgd2ZMYL1o4RjBjvQPwXE5WodhQd7uI1lH3m0OY5EN/hmPvtrjhZYZoCkl0Zu7phoaXvziJMHN1yf6il16PCql6uZJ4NWSWhUzJ2WKK2FhZP76m1fvAu2zMM/IR0Qb9sUTFbTJIKKFag8em/IWdcfTC5tSmT7sNxvQ3tOFtLAlnPNI9hO2OqtmbWzmH2ZUjx/7FPynzAD4hWNsSQi2PQpD6KzKRDQjHOVTJGfwJeMIXl5TEclDJErQvhuZ1Ummg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iHjNOkLt5bA7AYkTbh6Pxylo/1E55nPeqDHDURClZUk=; b=j5d1o9EnDzdhESP2vvuVLLljoA6+h8IKQBGh18WNQzltZgCh6XaNeiQZqemzY1jFuO7b3HVHDXMUkm54q8VpaDQUYicmDgPLhu0zBxSg3vBurTZCCR6bqejM9x/huS6CyxcsP2Sa7BFQ55GMmaHjuiKElcRgK+csSFl2ndb8bHwJvRihvxgObAp03khWHnkno/HxUzPnmuk8DG+3e/S0AYEZXO4rrUN5GCKXUCX4PJQEAZH9MQoB6aMlvOPgMi6zqVHEf0t65HYNIvPJJmvURGMTjtGjdqM/n+r/0sGt4i3lvBNI/OYhWW8nnK6i2NAmHsqcm3RHDsBEmwPqRs2EIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iHjNOkLt5bA7AYkTbh6Pxylo/1E55nPeqDHDURClZUk=; b=ftZ0pa+j7sfJJDSx235AmZn/yeSWVECWXQY6OgiBPWEwDaULqKJYcit9oLj0Um2GVFBviDfnH+VxJ+/2jSf8HVzYzAa1e1KpNdGeCYlnkY2Ou555rus2+nyHUBeaQEyuvLaCd9phzUgcUt1O9kL/0dX2PuH/Z6/6wfXVzBjJ/R/uLirQ13fp3yb1rbq/Yf0rlmTs+2zAJqA8vsLVHL4UzIP9wHjK3MGktS5eM2VSiQ4Y3V9lhcSN7UX8m306Vf0BfZVFLV5dShiPX4THwk56QUD3WrPXO2Whevc8jWAg6CadSa4t/dEHoWJY1Mkmue6b40qaUY5vvSgIWYLJsHlAiQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PAXPR04MB8736.eurprd04.prod.outlook.com (2603:10a6:102:20c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.23; Fri, 9 May 2025 04:47:26 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8722.020; Fri, 9 May 2025 04:47:26 +0000 From: "Peng Fan (OSS)" Date: Fri, 09 May 2025 12:45:37 +0800 Subject: [PATCH RFC 6/9] gpio: davinci: Make irq_chip immutable Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250509-gpio-v1-6-639377c98288@nxp.com> References: <20250509-gpio-v1-0-639377c98288@nxp.com> In-Reply-To: <20250509-gpio-v1-0-639377c98288@nxp.com> To: Ray Jui , Broadcom internal kernel review list , Linus Walleij , Bartosz Golaszewski , Florian Fainelli , Scott Branden , Vladimir Zapolskiy , Keerthy , Robert Jarzmik Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1746765944; l=1810; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=r4hphFfPr6fMQpFirWBB3MbwJG5e66SPg/WKr7hhI/g=; b=DM72xFA/AZmjheuh5J1wxbp+s2vVmAXbFST4nvwYpNZXzKwvcUJah/W2FZVN2y+ZdeVcQImIR u8jqle2l9R+AKH7nGd4b/YFFYQ8Worn5XeJAXS5XDjuz0ZJfGLgVY/2 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI1PR02CA0011.apcprd02.prod.outlook.com (2603:1096:4:1f7::19) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PAXPR04MB8736:EE_ X-MS-Office365-Filtering-Correlation-Id: 37c1f3b7-cab1-4af7-9e5e-08dd8eb498ee X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|376014|7416014|1800799024|366016|38350700014|41080700001; X-Microsoft-Antispam-Message-Info: =?utf-8?B?OURmR01ubzh6b1RBZHphbE5qMFVjU2N5K1RuVUIveWhhb1QwZGlhcWpNRzlr?= =?utf-8?B?SW1pb0ozdDJIQUZ3YTZ4WWhrdmtJdnRaQXBKRkg4YWlBKzlPU0FwVFluWmNH?= =?utf-8?B?cWVHeisrdDd3cFp0MGQ5YUViMFFFZ0RDZC9MOFZDd3NWcXFqTTd0S3FZdXZy?= =?utf-8?B?akFveHRlWnlTb3BOREZEVDVLbUQ3cUFLdWRTd1BYTzNnQU9VeW14ZWhERjhq?= =?utf-8?B?NW1UT1pJTnRabVpFMXZnTnhVZXRqY21nQWVxMTFyYnRIMEFhNGVDVlRvbDdG?= =?utf-8?B?TUNNeWtEOU50ZXBYaU1qZWorOUdxQm5wUHZJaldsakNhaU4yanNMaWFvd2VG?= =?utf-8?B?Q2xvcTRZY0M5emp2bGdwRE1tVERQRzRUbHU1emp5L09oK0VTRnprbzZheVJh?= =?utf-8?B?MVJpNHB0SVl1QzdOeFExV2E3S1g3eURnY0NDOGozeHVzc0w2ZTF4dytiZjJ0?= =?utf-8?B?UTV4MlMwbkVHbnVjUXFBMmppTjNDaldOZ01GY2YycGlRTjZUclBGdUpoM212?= =?utf-8?B?ZFVZU0tpWlhybzdvTDV6YVJncE1LN3ZiZkZ0ZmJHdkR0ZDFqQVFCT1lxR2Na?= =?utf-8?B?aDhVcVJDZTYzQ1I3SWNWbUtHNlFUOVRPbFhKcFYyM0duM3lPSWc0b0FaanA5?= =?utf-8?B?Tkk2NFVNaFg2NWFPT3FhZXNhMjRzdXBGNzhXYWI0MjZGV2lyMEwrWHZJbTRW?= =?utf-8?B?MkVTVnRYVmtCdFY1NzIrQU4xeVQveEY0SklhRnZrMVBpMWZYMDNJb3FmN1hh?= =?utf-8?B?c3M1bjN5dHpLQnljNTEyb0ZyYStTeWJNRmRNV2NLOUZEbDRQVlMreGlQalEx?= =?utf-8?B?Y0V3NlNCYUh0YWJNM1BXdW9ZYVVkaVpGRDVxMFkxeldFTjAvRnJxNjE2b2Fw?= =?utf-8?B?NnpOKytUS3BLZ2xGMFNaMGRnbHQydFV2MUF1NTBRTmhyYzdTcGhFRDdjTFNQ?= =?utf-8?B?VlViSjYzeDNEcG5YTmw0a1RQSDh0S2xxdHg4d215TWJLR1dGRXIzNDJ6Y09x?= =?utf-8?B?M2UvZzErZ29nSk9TWjlJYmNGQ0dabno4aVdxZVZZSFlvUEJ0dHRsbUYxTVdL?= =?utf-8?B?T215SVc5RTBKWnhLQ0NZdkZ1NjNqTnNsQ3NLTGl4c3dtdWlUSTJRWjFwTmwv?= =?utf-8?B?S2tsTW52SkhoZVhxdWpXajVFSUhTNnBpZDRUa0xtWmFGMWkyMEh5QTBxcU44?= =?utf-8?B?MlQycXBydjBRMGg5bUQvVnN6RTNNajdLN1dzZTdURzZYUGZUU0FIYWpMMVdV?= =?utf-8?B?bmRWRXpmTWg2MnYvM0xtbmYwdmxndmdEcEt6NGhzcVhMek15VWE4cDJhNHZS?= =?utf-8?B?N0xvQ003ZUJvSkVDajFHOEozeGFlRldjSTNodndLQXBQc2x1Q3lwQXd6VDF4?= =?utf-8?B?cS9xS1JzdmNJV09vT0U3ekN4MG9nRDV4bWx2ZVNPclRlSlhHTmE5ZHowVEt1?= =?utf-8?B?OWcybnNGNEVDdm5laXJVWEdMb3pYSWhmU1E0eHNFd04yRFQ4Nnh1Q3dhVGFQ?= =?utf-8?B?S0FvemowUXpQOGtTcTVCek1Sci9xT05mUkQ2bnQ3SktRM05NdXlWVUVQT1Mx?= =?utf-8?B?TFlqVUw4eXk2cHV5LzlRUHc5QldQMk5HMUZNZ2FkVzJ2ZGF0c2FqZ0pJNWw4?= =?utf-8?B?V2J1RGUwR3dpcGVuUXNTMVVEKzRQeHg2Nzh4SzJBNWxxZ3E1N2x4YysydGo0?= =?utf-8?B?TkJwenZGTCtUYjZqbzhLN1Z2MkRrVFJ0U2xZbnpzZUc5SXVhejJ5WFRHS2JO?= =?utf-8?B?VDd1bXdNeGFidGYvQ2ZsdmhtcUIwZzhsVVUydzFkRkh2eG9Bb0RMQkNQSDZ3?= =?utf-8?B?eStJeFJlNG9jK1RSM1Nqd0RnOE9vZlZuVDB3U1IydFAyK0x6UzVjQ1NQajlO?= =?utf-8?B?M0Q4b2JvQy9PQWxMbk42emtQckVteDlJdXBVK1g4N1cvNlI0MTdiRktMa21J?= =?utf-8?B?ZUl2S3ZoS0hOdXlKV1dqaXZXcTRLOE1PWHBmMjRhMSsrQityMjgyWWhYYWJp?= =?utf-8?B?L3ZQUkt1UVdKRi94VE1reEt2Q21KQ1A2WlN1NGpmZ0JpV1pmckYvek9HSEc2?= =?utf-8?Q?Fj9KeM?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(376014)(7416014)(1800799024)(366016)(38350700014)(41080700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rzd1R1FOZnBIcU5lY2VlZXVUUWF4eDBMWTl5WThXd0NneitSclc3YnZuNUth?= =?utf-8?B?bFROM29vclZPSldONDhOSWxSUTQ2YUhiYXgzVXE3dGl5bWNaVnJoN1QzdXNE?= =?utf-8?B?bzdoMTRXQUs1bDB4WXp6cHRpMHV0dVhqUHFxWFhCZG5CWlI4UnVhYW5pcm1X?= =?utf-8?B?VmF4N2ZoMS94SFBRWGJicDBaUFBGNlgyUVF3N3JGMEZETkZKTFZ0WTNFVmFJ?= =?utf-8?B?K1lBQ29RcmdxTzdlQis4WmNJMWVVOUdzTG0wMkNhQzYvcERmSlBIMWZIMUcv?= =?utf-8?B?QTBtQ1BmSUdUWnBnQlNTbGFzMys5ejJNYTVCVFVsNjd4TjR2bFhCSkR2YTBO?= =?utf-8?B?NkVzUC9jMGNXTG1XNDhDT0dtekhQblV0OUJ1TWhOOHBvNXZXbGptNFBwdkhW?= =?utf-8?B?Yk1OK05DYWZ1aWVXSWhweEltUnNIdWlBSzM0S0ZEd1N2TDJCZC8rdjRjZnNx?= =?utf-8?B?YXFHUm9RQkU4QzNnU0JJZ3d3QTJTbUE1VTV1a3JRMTE4cytlbU5SSmV1RXNY?= =?utf-8?B?eEJMbEFEZUZIdVVtZ1docWRLalJqK3JPcHNxN1ozUDNjQTZ2VFd1OVY0Y1Vi?= =?utf-8?B?cER3MVFQZ2JXaFYxa05kQVBSRC9uNDFXcGhTK05BU0RqcUM0TXNSUnJyMHVN?= =?utf-8?B?M0NzcUV2L2VURHdJNzVxTGlEa0ZLajVNZTAzdDNxMXNOK1QrRnU3R0NzeXVJ?= =?utf-8?B?aXl3R1NxT2ttc1hsKzlXWDF1MXRkMXZhMy9QS0JSYUM1djRySzhtYzVrZm4w?= =?utf-8?B?alMxQ3VBS0k2T1dDR0IvWWN6RGl2TW9iOHFEai9YSTRaTThER2xuVEVCZHFu?= =?utf-8?B?cXVQanZma1JjMDl3alVvTys1OXlPOUlSUWE2VTVseUpINjMxTmVKUHhTZUtn?= =?utf-8?B?OHhHUXEwOW1TbEM1UldFUUNNcC9kamJPZ0JDelhMN3NxRFNIVjhNSm5uVkQr?= =?utf-8?B?THlJek5jRTA1ejFsOGlmWlFEenM1QnE1ZGhZSnNHRzkzZ2RycEJ6STVTY0hk?= =?utf-8?B?bmRLN1RjQVQyNFFMc0RrY0tCaHlGK2JlSzNSMFFoZUpNcWpicStNTGMweDFt?= =?utf-8?B?bHo1V29BVS9UN3RNM09ZcEF5VHFkL1JXOU1mcDFyejJybkYxczNDOEtreURs?= =?utf-8?B?bWNMRDFTdXl6U3p3bnAwZWdGeG9LdzE2aWFKZEZMYnFlN2xPVEg0MExBVXFp?= =?utf-8?B?REZJcllJNGlVbXd3ZGpha2ZVT1hveUhKRXRVdk5NaUVWcEhpUTVycTJiNXZk?= =?utf-8?B?emh0bHUvMWE5cnZzcHo2OVdXNEJBRFJOa2FwVWpEOXpsc2FIV1gxSGpqR3Vp?= =?utf-8?B?M1RaV3FDS3BvZFl0VVY2UTVmRHE1UVppdXFUMU5vV3VKclJyaTNhQUdHblVY?= =?utf-8?B?a1J2WEtiUFd3TjgyWVkrWjIvSTdkR054ejUvNktlVjY4Y1ZXOTRYYjBTQzVq?= =?utf-8?B?MWZ2SXR3eGN4S2l6aml6UXg2Y2hhazlFVzU0YmVrU3hXeVcwNWxsNVlNUXJ4?= =?utf-8?B?WTBCM3IxNmJmRE41OWRrSzVhakE0V09YZW9zSm5TbTJkQ1NlWlpDSFcwWDlW?= =?utf-8?B?dnYvZzdGL2QrdHRaOXBIUDBiQ01EWThGNVIvSjVnb29jMGgwS2lCVE1jbWZp?= =?utf-8?B?T2xaRWc0N09IU1BBZHVnR29ZblJuSkU2RGVBQU1vU3h2MzdvVTMwWUlRRlBw?= =?utf-8?B?OTRFNlAxWHlic1VEckdNOFA0VXhIenplMWVEUEFUd0Y4V3BqeTdWQXN2Zld0?= =?utf-8?B?TWFLalh0aTJzWjB3TjBHNE5aMi84TUpubUlFVFRFWnVPc25VWXoxZnRndWw2?= =?utf-8?B?V2VoRG1WWWIyT3dJbVJYQnNMWUxLWExZNFpXYUpUdTdlNnJrbXVwYWxMTFRu?= =?utf-8?B?akJTbDY3NklpWXFhZm1ObnZBa3pTcnpVT0ZYczQxY01CTkNmaE9nRkVDNWdD?= =?utf-8?B?UURnMnM2SFNZQWd6anFqRWFoTUE1TnZMbmZNSEJHMjNjWkZMS21Ecm03aDcw?= =?utf-8?B?enhkYkw5SDBmdXdmRTdJOTdTeG01WHM0ZEx4NU05a2c0RUZpVjE1TENCbzlM?= =?utf-8?B?VDdFc2pFbER0WmJ2WEVITVMrK1NMc0hQSGNOUFZidEh1QWJhVmY2WWNDNmw0?= =?utf-8?Q?voGEc9Rdup1yLRlt5GgCkUJVz?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37c1f3b7-cab1-4af7-9e5e-08dd8eb498ee X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2025 04:47:26.8808 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +BDTNkro3c3wEpdwNcpRMpDwEVbLTeahJt+OjtYQNshI6MNBUKxCucRF3BZG7kd9qWzuuXa1+AcX90wFPIKI1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8736 From: Peng Fan Kernel warns about mutable irq_chips: "not an immutable chip, please consider fixing!" Constify gpio_irqchip, flag the irq_chip as IRQCHIP_IMMUTABLE, add the new helper functions, and call the appropriate gpiolib functions. Signed-off-by: Peng Fan Reviewed-by: Linus Walleij --- drivers/gpio/gpio-davinci.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c index 4494acc14630bcc7cb75dc475b5ae7e0a595cc5c..80a82492171e43876e617e86ba0= 24aef095229e1 100644 --- a/drivers/gpio/gpio-davinci.c +++ b/drivers/gpio/gpio-davinci.c @@ -253,6 +253,8 @@ static void gpio_irq_mask(struct irq_data *d) =20 writel_relaxed(mask, &g->clr_falling); writel_relaxed(mask, &g->clr_rising); + + gpiochip_disable_irq(&chips->chip, hwirq); } =20 static void gpio_irq_unmask(struct irq_data *d) @@ -263,6 +265,8 @@ static void gpio_irq_unmask(struct irq_data *d) uintptr_t mask =3D (uintptr_t)irq_data_get_irq_handler_data(d); unsigned status =3D irqd_get_trigger_type(d); =20 + gpiochip_enable_irq(&chips->chip, hwirq); + status &=3D IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_EDGE_RISING; if (!status) status =3D IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_EDGE_RISING; @@ -281,12 +285,13 @@ static int gpio_irq_type(struct irq_data *d, unsigned= trigger) return 0; } =20 -static struct irq_chip gpio_irqchip =3D { +static const struct irq_chip gpio_irqchip =3D { .name =3D "GPIO", .irq_unmask =3D gpio_irq_unmask, .irq_mask =3D gpio_irq_mask, .irq_set_type =3D gpio_irq_type, - .flags =3D IRQCHIP_SET_TYPE_MASKED | IRQCHIP_SKIP_SET_WAKE, + .flags =3D IRQCHIP_IMMUTABLE | IRQCHIP_SET_TYPE_MASKED | IRQCHIP_SKIP_SE= T_WAKE, + GPIOCHIP_IRQ_RESOURCE_HELPERS, }; =20 static void gpio_irq_handler(struct irq_desc *desc) --=20 2.37.1 From nobody Sun Feb 8 17:13:49 2026 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2088.outbound.protection.outlook.com [40.107.249.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C37226656C; Fri, 9 May 2025 04:47:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.249.88 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746766055; cv=fail; b=RoIaltWAUCk6RyEqHqWkXqVHsJ5w3u0niLELCBydivaK42tRcL7Mzup8YXA219nkN07zdVMS1mwPtbJOaEisSdFdZE6wWRj6K8UV4A/1Nv+nEmjUPx3V4JAW3tf9ZAcR9RMbvwzwvfIsjmcgVZWxmrmFsfnfVjLDKzh0b6C9BLc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746766055; c=relaxed/simple; bh=XPVdPghn0ZV+h869NBsb8p2uaI7YvOSKG5FJP8E162o=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=TXGvtqZdf5iJ9Bo4YJmEyTrus+LHXlqzA0afNOtzG1zZmMd7HD/fvHiUxMw0xi6Ti8o0RbZ4hATNFYsseg9ynqfFQCtEGvwgoEKUqVfxki797h1fkzudUeerrcNKTgO6rN5FykgyiJN3hWAAAoft6QQZBzlWq+lrQtextVF3bEI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=h1DK899X; arc=fail smtp.client-ip=40.107.249.88 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="h1DK899X" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MWomLKEwsD/Q/E4A/vpLQDttDHR3+JPoCPJqX/wOtsROr0D97hCgjtDJktNp8eZyPapBHYIbec5ftHO2wB9DsBU5zqDvkZT9qYeuqV/DM+zfVEuw1jylTkmtZFTP2tIDlkWDENsn5ziezoOyvDqkaCleIhZWdsqiMMNGcUDBHFTiYdmjCQHVmii3AxlvOEontxrdhkpcJ9uBttvCexfxrYEBl8K2TkZGIO77r96fNCffNR1jt0tD3Zwme/wUblQmjHrzCg629pYQ8UnyrC5/SY9ndwozR6E7y3A2WFRTrZ4PfhBN3nJOcxNwQBvTMuufIbrqEExRipMQP7AuF000kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TkwRetyU53rduLeEtVzRo0QbVvLj3VhvAQTFT81haC4=; b=Fd1BvtVu1Wk8VyKBNDNOR9eADa1H3KtIXT4frNRfy/JVchRNG+SCXTCowP290Vqzs4B9J3O7xh8AgVGdgLHY0LYRKv/Vm6TjJxgVdbiCgK3ZnI7q3VFpIb/GBtJzSBEYGTx250AiIVK+F8cBf+LFDXnIAqFSUyfzWV6wqNUYpB5oX1z1NNXxNPRh9nb1Q2Ap6gLGgS38uS2fvhlGHM24WCiQQBOA9FJtjTJFF360ukqNtqBgz4m2DgjoKeWUgQf4VOt+iW/soCR5Zp4H/C834snsQqR7aqQU12OOhGxTRU8avEjIL+eTET0IJq+mxjzsomSsX3JEVdUeIfIE2at7cQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TkwRetyU53rduLeEtVzRo0QbVvLj3VhvAQTFT81haC4=; b=h1DK899Xa5ol5ZOrWe80+i4V0vGl8DMxOKhqPuAiKwUUu17Ztasz/t6xYtAa75epwFoz0NPFqw3bJgCfaTrX925+gyi01lJXlDpiBdESuIn26ua9O6NMhgNnChOtvFF021KSlQA9W1Hr6tR7CTn7IjsPzk7ml94MT8S6c3V9ZzZdeqi3YAIlfAcld5Kwe8RRFgnLvWQnJOW3IkJSKJrcKL5w517OXYz6ajBGIXQKwRxh+IWvbAo/STeS3xhBlL99evbr1GW2OiuXU9pNWUknRwuhzaJEElAtzzehgoBAYDvx/orDt9Z5Xvj5xaH0lubC/31yDYO7Ejs9GicmC3ifwQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PAXPR04MB8736.eurprd04.prod.outlook.com (2603:10a6:102:20c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.23; Fri, 9 May 2025 04:47:30 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8722.020; Fri, 9 May 2025 04:47:30 +0000 From: "Peng Fan (OSS)" Date: Fri, 09 May 2025 12:45:38 +0800 Subject: [PATCH RFC 7/9] gpio: xgene-sb: Make irq_chip immutable Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250509-gpio-v1-7-639377c98288@nxp.com> References: <20250509-gpio-v1-0-639377c98288@nxp.com> In-Reply-To: <20250509-gpio-v1-0-639377c98288@nxp.com> To: Ray Jui , Broadcom internal kernel review list , Linus Walleij , Bartosz Golaszewski , Florian Fainelli , Scott Branden , Vladimir Zapolskiy , Keerthy , Robert Jarzmik Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1746765944; l=1802; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=hlzn7+kz34e+S5Z+vmcN6kj5jbURUYIZf51GmHf01Qk=; b=l8eUAm32i2fOhJoKboUlttzOs7XJd3Dos0FvvBeEYrY3ibbEdIGNow0oopkD9IRo47pJlLMqm EY/nKG/eH01D4qBhEy6mGowiVUiLDFShQ7I6h2pcJ+LEqw3PUg4Nk2t X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI1PR02CA0011.apcprd02.prod.outlook.com (2603:1096:4:1f7::19) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PAXPR04MB8736:EE_ X-MS-Office365-Filtering-Correlation-Id: 64601b14-f260-4582-b350-08dd8eb49b3a X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|376014|7416014|1800799024|366016|38350700014|41080700001; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TWR5d3g4KytESXJTNE1VOW4xSWs1Vm5oODhGVTVlcE1xaFJvOUVaS3UwYldo?= =?utf-8?B?WVp2S3JDaFlGZ1pLWHFNSEJNdEJMWlRWbjRMT3hBblA2dUJVZmlDM09aRE5L?= =?utf-8?B?Q3N4RkdNRGFUeTlyWVA4dGg3WDBtb25FQ0JlMGloTGlXNzhndGIwN2c0b3Y2?= =?utf-8?B?ZVR5dWlwbS9YNm1hd2JjNmprR2tEeFQzWVg5QmUzSEY0NXdreHNsa2VYZ29w?= =?utf-8?B?a1B2NHRKV2ZnQ1JmaVlreVdoTmJWbkFqb0hsdGNjcHgrQ2ZtQndsSjMxenZF?= =?utf-8?B?NzAvL1p0djR2Y205Q2V6Y2VpUG5weVo5a29KVnhGZW5RUjNEOCtQUmZxQ0FY?= =?utf-8?B?SHpyTjUzUWNIYXJiYTZFQVc5MXJMb1J5b2paVG83T1BoZnRXMkNWcERLb3FF?= =?utf-8?B?U0Z6eGRiTjBtSk9xazV3S1dlUUx2eFY3RHhpQ0xNZnR5SVNKMEdpNFp5b2cx?= =?utf-8?B?clowb3cxcWt5WG1PZSt6WVJlSTdkdDhnUDdXQTkrQmtNYS8vaGNyRHB4SE1Q?= =?utf-8?B?cDdpdFFaTHhTV3grMHFiM3FXNlYxK3VrZTE4OGtxelFSY3BXSXhlS0grcTU5?= =?utf-8?B?bmt0Y3FUcC9EMmFIM0FrL0djbGNrcmQyZTI3d05tTUlqQXV1U0pubW9IcSta?= =?utf-8?B?QUpqam9nNXRiaFllMG01TndTa2ZnaHVBNXdmdkRpdFJFbm5RT3hNeTJuc254?= =?utf-8?B?WFBzb215VmxPS1liQjFZV1UzUTAybWxpQXNGOG5FQWFzVE95Skd4NjJDY3Ro?= =?utf-8?B?czdEaWJXbVdLQ1ZGWVkrYnRuSXNRQjArWXYrZ25CVVgwcXNnWE40ZzNldlFq?= =?utf-8?B?SjJBNGpJRjRuU25KZmJJdVk0YjV1SGpwUDE1T1FUYVZjdFRldUJLb1lTbUNT?= =?utf-8?B?U2t1VkFQMVNHbG5DcTRIU21ldXZGV256RUJhUWczR0Rpa0dPWFVibVRGSUg3?= =?utf-8?B?bm5hVUh0UFc3V0QwK0pEMzlLMEtIaTdkZGZHcENKZlNodVJpdkVlNm4yQkN0?= =?utf-8?B?ZFlaU2FIRnFKcG5kRWg1dlc2VjhYalB2M0FhWWUxbnFvWGorSHJmakd3Z0lY?= =?utf-8?B?MS83YmNhUEJ3VzFUQ2d3Q29MWHFTZjg5Q2h5M2FmSGYyb2kyeWh1L1NGZTY1?= =?utf-8?B?bXdOZytyNzNSWjRraE5ocitxT2hlVHFKRnNZOCs1QWpzWFVWbVY5c1JaRXp0?= =?utf-8?B?WTZMWHlXeU9kUEtQM0hRdzZjViszcDBBbXdXeGhxSzFaczZJWExkRFRSV3ky?= =?utf-8?B?K0ZrRWhkYk1QekdoQ1FxNlQvOTBCeFZZYTk4b3I0V2JORDVzSzdzTE5lSHdJ?= =?utf-8?B?TmNSQjVEOVFCMllXSWNXMTIrYm5CT0JreUFRcjYzYVhHakYrdE9URkp5Wkl2?= =?utf-8?B?cjd5dytzbDh1Vmd4ZzV4c3FUVzNDT2pqNFVNZkNZbk5UbExheDlNOVBLODFm?= =?utf-8?B?Ui9EaTVHL0U2dUh5QXlVZFptVnIzcE5SRmk4U09mT0JNN0VDRU5uSmt0VXNl?= =?utf-8?B?em5FaE16cHlWQVN0YXBkS1ZwdzJDb2tCb0dadUh3WG03YXQveWYya0xXYUxW?= =?utf-8?B?MllqY203K2IrTXZmbjRkWXRHUnpYUHRJR2ljL0IxZDhWTGlxbThPSHBJQ0l4?= =?utf-8?B?MldxOTI1cHFBdS9kL2o2Q3BBeEdudDhFT0lzSmtsSko0SWtubWZkalcwaSt4?= =?utf-8?B?bzR4bTE1ZEhiK0tnNWZZZGR1WFNxb29RYytwdnpGeGJmWkdpdWJxVmJqMzRK?= =?utf-8?B?MWhtZVdqZWgramxXUkFkRUZrUmlPZncyV1VhQ3FkMmlsdEVmZzZNWGt5T2VG?= =?utf-8?B?Ui9IaENlUmJyOUVrNmt4cFhPQXl4UTZsVWt1RFFMOTIvWU9TV2Y3QjZIamww?= =?utf-8?B?QjRkc1JOL2s2aTd2MEFTZ212cjRCLy9qcktTRUhuYVRNRk5tSFYrRmdmZzZU?= =?utf-8?B?VmhIRXFtdU1QNkNLbFhlKzc2dngxMkNjcGlEUW0vQVdwcGpseUJZaERFU1Jj?= =?utf-8?B?bDBhZ2N2WGk3RE9BRENPMzI4dHgvTDN2TWkwZnVQM1ozSGZOTWNRelBsQmdw?= =?utf-8?Q?dsXQ1+?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(376014)(7416014)(1800799024)(366016)(38350700014)(41080700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ny9saCtpaDNhYXhBOGRQbzhlWGx1YVorZ3dTbUxCK0pOc3BlbERpamtsNWt6?= =?utf-8?B?SkdzaEgrdk9LaU13R1hBblgwMmZabXNqM3NQTnkxWjBHY1NLaVFHcTRHUThQ?= =?utf-8?B?bXBtU1VPUVpXb2xwWnY1NUdzWWg5emNwSjAvOTBPeDhTVmxsSW5aRHJyMStX?= =?utf-8?B?Q2hGY2VyRjBCNTZNMzEwQmpRNnNsNnhBVkQ4dklvNmNzZHRwb1MxdWJQVjVV?= =?utf-8?B?ZUJTamlyODVnbU8zR0pVVHJlYnBuK25JYXF1dWw5YVlxQndtang2ai91K3hJ?= =?utf-8?B?YXhBZ1lYZ0trT3kyTlBoUG1SNm1JT1lVV1dUb3licnI0dXpzTGRtZkxCNld2?= =?utf-8?B?NmMzKyt1TDdvcTVPQ0g4WFhwaUZyTk5DT2pYOHViV1NpYXBmb0dDS0dJOWJY?= =?utf-8?B?NENKTFYzWnB6VWtUYnUzb1E3aHIzblplUUFxYUFRQVRJUU9Ec2luQmVmSWV4?= =?utf-8?B?MklXalpJNmxqVHhwejRmYWtNZFcvS3Y0TnRhNm5HZW1KTzM2OVI0bG41KzVS?= =?utf-8?B?dktzZ2w4OUZVL0U2ZmhCOGZNa3p1WnRiNjZ0bWlmbGxEeWFJakFXSzEwT09Q?= =?utf-8?B?WkQ3c1lDOFgvNExSSm04ZlRnZ0FHaHRyTW9RbHpDcnFGZktzdGxKOUhvUHlr?= =?utf-8?B?L25oQlBqR3BOK1dweFZCSDlyUzFoTnUzcGFkWE9zVklxQzlLMFFLVjBPL3hz?= =?utf-8?B?L0JkS2hqVUZPSFIrNzMzZWZpL1lNaUk5TzdZbGJiYitzSk9teHI1Q2o0ZlQ5?= =?utf-8?B?R3NoNnpDb3E5WXFEYzd5cmpGSVJlMVZFQktTeldkaXlHT0t6UUZKNDEvOTBi?= =?utf-8?B?TmNSL1VBR00yTjl5dHByY2QxMk40TmJBUGp4b1hUbENYdW9QL2paY1pDaHFm?= =?utf-8?B?ZGdsQnNSeWxIZkp0eUUvQ0ZjVmZ3TGRkd1pQQkdRQ3lZZzNpaStkb2VFVGhG?= =?utf-8?B?clRpYkZaL05QRkJUOW1Ma3NpMmYyeU5VTjJvSmdlSnNMUkFNSnVsajZQTkQ2?= =?utf-8?B?VnFkY3ZPdW9xdHpOS2xBY1FSdmFFM3l6UVVXM1V4R1V2RmdsMFhZRjh3Qjdn?= =?utf-8?B?SjQvUTViTmFveHJCM2ozNVdPblJwbnhqbmtaaElOWFhHWGt4ais5MHgxNjM3?= =?utf-8?B?MFVZRi9SMSt1ZEtLbVhkaDdqSlVMRm9RNUdLZmwwVFFqWHZWVnNlWHB4eldu?= =?utf-8?B?UGNXeVZOUldhN2YyanZyYW1QcFRKM2djNHpqNFZyeFdrNUF0cnRxc1Q5K3lV?= =?utf-8?B?Z0JjSlV6L084ZjdEK2lSK0NqbFhwNFFFYm5NWFc5REMvUHVZNDJZQ2F5YmlM?= =?utf-8?B?RGp5bVhFZkkwQS9zeXkxTkJ2VzJnZUVCNTlEOElyZUV6T0lrL0N1a0ErcnFo?= =?utf-8?B?SmdJeTNDYWUwUG51QVpaUmV4ZTg0V3pwUFBkVnIvSGdSZVVhQVk3SjZKWWxY?= =?utf-8?B?U09YYlpyVHRVTkFzTjNOL0F4eXZxdjBNdVI3bW5jd2hZb0tyaGc4MW9ySjlB?= =?utf-8?B?NitkZ1JzT3hFbHB1VTFJcXhPbnp3dU9qWExEMnI2Zm1Cc2ZHVktvT2dVVEFC?= =?utf-8?B?Q1I0ak9PWk0vTm5GcHQxaVdadmRWSkcyYUhvdzBNL1R5NUhqUFNVYmdKQThS?= =?utf-8?B?Sy9Ra0NpWGVpZmtMWlF6R3JTbk5reDJYS2FEWVgzaTBzd1J1Y0lJc3RmQTdm?= =?utf-8?B?RXBXZVR3czkrRURUWHo2dGdER3RUS3NPQWdxN2dqRGN1UnNnSUhUUE5IMEpp?= =?utf-8?B?b2xiTmdQbWdxK1I2K1lQM1M3K0VYZ0k2UERPRk9KbVFBTlBnSjYyc05zMG5U?= =?utf-8?B?Vm5qTjhFWnlKL2xFQTdwTjUvT0tnMlF0eUsvcG1ITENkZU5oN0E1T05zY0dS?= =?utf-8?B?NzBPWVdlZU9DRkdpWDNha3RNOW84MG9tWGRRY1pRWnVtTkExSnpkNmJ6aHdr?= =?utf-8?B?ODR4N1J0K05aVndMWGNsZ0lFT2s4bGJJMjdCby92cjZvTjFZQXJ2WUhobmxQ?= =?utf-8?B?TzUrOXA4SnRId1czc3gvanMyTk5KUVhZQW1kcjdOMmQ4WFN4U3Fub2FCS1Fm?= =?utf-8?B?QlIrZ29xL3hlUkw0V3NmRkQ0aWxoa2VJaVI2dDhlTFFsc2x2aGhrVEZHaFZL?= =?utf-8?Q?Vomxo3vGezmpGlrxg6oMqPweM?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 64601b14-f260-4582-b350-08dd8eb49b3a X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2025 04:47:30.7047 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WQVNVzW7LVCQoklS37xXjOe+CgBZ53CciR4Uug47GPpvIsiOTIpsg5x6DLseojtwGqt2Co8tVzIU07fUBFEyrA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8736 From: Peng Fan Kernel warns about mutable irq_chips: "not an immutable chip, please consider fixing!" Constify xgene_gpio_sb_irq_chip, flag the irq_chip as IRQCHIP_IMMUTABLE, add the new helper functions, and call the appropriate gpiolib functions. Signed-off-by: Peng Fan Reviewed-by: Linus Walleij --- drivers/gpio/gpio-xgene-sb.c | 26 +++++++++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-xgene-sb.c b/drivers/gpio/gpio-xgene-sb.c index 48b829733b1509d9e0b409a0422f95ddb78d4525..b51b1fa726bb5ac6fce21f93e98= 035b5f684ee88 100644 --- a/drivers/gpio/gpio-xgene-sb.c +++ b/drivers/gpio/gpio-xgene-sb.c @@ -103,12 +103,32 @@ static int xgene_gpio_sb_irq_set_type(struct irq_data= *d, unsigned int type) return irq_chip_set_type_parent(d, IRQ_TYPE_LEVEL_HIGH); } =20 -static struct irq_chip xgene_gpio_sb_irq_chip =3D { +static void xgene_gpio_sb_irq_mask(struct irq_data *d) +{ + struct xgene_gpio_sb *priv =3D irq_data_get_irq_chip_data(d); + + irq_chip_mask_parent(d); + + gpiochip_disable_irq(&priv->gc, d->hwirq); +} + +static void xgene_gpio_sb_irq_unmask(struct irq_data *d) +{ + struct xgene_gpio_sb *priv =3D irq_data_get_irq_chip_data(d); + + gpiochip_enable_irq(&priv->gc, d->hwirq); + + irq_chip_unmask_parent(d); +} + +static const struct irq_chip xgene_gpio_sb_irq_chip =3D { .name =3D "sbgpio", .irq_eoi =3D irq_chip_eoi_parent, - .irq_mask =3D irq_chip_mask_parent, - .irq_unmask =3D irq_chip_unmask_parent, + .irq_mask =3D xgene_gpio_sb_irq_mask, + .irq_unmask =3D xgene_gpio_sb_irq_unmask, .irq_set_type =3D xgene_gpio_sb_irq_set_type, + .flags =3D IRQCHIP_IMMUTABLE, + GPIOCHIP_IRQ_RESOURCE_HELPERS, }; =20 static int xgene_gpio_sb_to_irq(struct gpio_chip *gc, u32 gpio) --=20 2.37.1 From nobody Sun Feb 8 17:13:49 2026 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2088.outbound.protection.outlook.com [40.107.249.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC8262673AF; Fri, 9 May 2025 04:47:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.249.88 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746766057; cv=fail; b=DH2N0aZLg0J9GzbUdbC6ym79FUr+8ik1YDsRYvsP6WIPK8munMm6eYdNLIOOLJVtXtmDhnvrwGwCTzMNNGDps7JkUFfydtYgOrt7rhHHYNfNXKeNFHIXY5d8f2v+OXAShEt/bfo8WkQSpCnBpcUpH1O1e5QFIXI8MTCd7gs1L7g= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746766057; c=relaxed/simple; bh=cvgd7D7tQOTthN0qvSyk6yQE3jR+tgJd6tJgbd2rDyM=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=o+OEqSpiKE9kfFTdEXFSd+hj5fAREgtomYrikkqtEEiq5nPq3cC8+G1VfW1dgX2rC/rP9L+j23Jdjpoc1Kr0yp7Tq1V2mpTZJLCaMjIUm3cjAZ4r78bN43I8BXVx5sGl+iS3gSMxejZJyrTMHUh02uMi+gMkFsW1q4/Hw7PgPiI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=CyApR5rN; arc=fail smtp.client-ip=40.107.249.88 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="CyApR5rN" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SEKRDhYrQ4HwjA/7nEjzRvEkPqrgsewTTqrd8sZb3cCyWk2T1LtB4h85xN3Ihlw2ulIWM0myOyJMe/suoWUXZ31rgWO4VIlkZjWltkJbhFukwfz6QrGB+pR8QWGxgGw7RcSu4tqvoSlE9mhikYV4zlvclRLVttAPYuBHMWC87/pj2ItBgfSy3AvQ0Fsx0hHe2ZZgiMTZriPOj5AmKXxmUJja6rM/xkVSFzrJST2oWoXi0KOxaJrSidDgb4wPhcpdYOcLzdIL/bQVvzt0io9/x6+XajVC81QnfkQRu3Kwf9A+jl+Uad6wD81bi8/7ZRPbxpNRQuTb70zEtcUdVUCYIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r2GSVyEBcbdVJZ2GRg3F5MDQlL2r1kimCOW8vEgQfXQ=; b=OszbGZtzSSahaQno8SG23itiVBrt/VCVqmW8ZXSaiaCFfVxK/YHm1MPBWxVD00YVfT1jnsrjZiw5MYVb7Mn3KB/MFbhGjyxSwYH5A0nAGhxkt0IVGoXP5wrOQ+dWb6FlqPAGd6ADtKz6Ls3l1wCXfpebAcWMOnAVrrYZKoWPLI7rUnGDfTG8+ZZlmxVh+VW3y2xzBQGKbCHVAq8jBt6kZB4Y2sghB4jhX57IqcpqOdaRyPpIlWSeLRBkUpHOhnA08V8XL18iLR0AWawwfVuhdAtRconi431JuBDzKJQZYei2u6tQ3KalJ8kOS/Z8rUm3DgNFJRHPKBnBVc65moXo5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r2GSVyEBcbdVJZ2GRg3F5MDQlL2r1kimCOW8vEgQfXQ=; b=CyApR5rNajUoSjJYS4IfMxnJ5susd1yTeO1ONSECA1KBAAyyqX+4Bul5UtqDLrZ69EHeE+kwratQTmh6Fy0GE/3lxCN2sUbycVNxrLKB6rhuZx8FSBVbJbn9UOYq4Z1vpY5B5s/U6iysj4Ofbov10/ejJgtrafxeMV3lRAxHLvaR+hBDg+vROuLOcZ83T0MEgE4TwBqLsFr4g+5pdk27UHGVa0YfU0IuC+B/jXPdyiAHl52VnTcIILGsXuVPjsUn6EZm4gO8JRox0Q5A68969juBTlKfG71rpug3zlcQJOcl7m30tTEBkNMNhrPJK+JUnKZYD5cvK2iazRT7Nwr4DA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PAXPR04MB8736.eurprd04.prod.outlook.com (2603:10a6:102:20c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.23; Fri, 9 May 2025 04:47:34 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8722.020; Fri, 9 May 2025 04:47:34 +0000 From: "Peng Fan (OSS)" Date: Fri, 09 May 2025 12:45:39 +0800 Subject: [PATCH RFC 8/9] gpio: timberdale: Make irq_chip immutable Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250509-gpio-v1-8-639377c98288@nxp.com> References: <20250509-gpio-v1-0-639377c98288@nxp.com> In-Reply-To: <20250509-gpio-v1-0-639377c98288@nxp.com> To: Ray Jui , Broadcom internal kernel review list , Linus Walleij , Bartosz Golaszewski , Florian Fainelli , Scott Branden , Vladimir Zapolskiy , Keerthy , Robert Jarzmik Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1746765944; l=2070; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=ZRY2NdpPEc9pEcyygw9SV/DHF/Gf2/XIk1rC6/QV+Tw=; b=odDPSfWt6Oe1LPfmqg/nBbEX1w5sS/MPZP6Vv5DrRYp5Uq3Cf+rL+Ztv1rjjtrSxWPDviyUnC R4bmXNd+IR0BhS+3H1+zfOdYRYTHfkfZUA79iCI/ofNozMcmI+C5YLt X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI1PR02CA0011.apcprd02.prod.outlook.com (2603:1096:4:1f7::19) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PAXPR04MB8736:EE_ X-MS-Office365-Filtering-Correlation-Id: 5f91cc4d-63b2-4889-02ab-08dd8eb49d7e X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|376014|7416014|1800799024|366016|38350700014|41080700001; X-Microsoft-Antispam-Message-Info: =?utf-8?B?OFVjQ0dzS0lkZStiTEVaQWRieFVyOXJVMUNrYXY2c2ozaHpYQkdpcTYycWM5?= =?utf-8?B?eHBvMCtTOTAvYXhldEhyYnFlZ3hyYnk0WjlSWkVSK1cxU2ZxT1NpU084aUZn?= =?utf-8?B?anZYU1RvdVhrMWZEMTVhcmdhQVRENFJBbU9EUWVhM0dZdXVGTWJDU3kxK004?= =?utf-8?B?QVpsc2g1UmhXSUl4YTdhUjhCejB5V2RHc2toTEkyd1AvczFucU9uZVJxaGd2?= =?utf-8?B?WUFXVFhyUU12ZXhGdGY4NWUzamJnTUNiejJIck1ROEVlWndMNW5pRmY0VXFZ?= =?utf-8?B?b016Sm5tWkpCaTQ3WElCVmdta2tWTGhPSjFTNGprYmI5c2I4MlU5Y1dPeTA2?= =?utf-8?B?eXZKWUxaSjV2bFVHTHJaWjhBa1ZqVVNnb2tRcHNYZ29UZVNoaHZHeGJYSUlu?= =?utf-8?B?TWRnaWM0dFJSR2JSM1h6WGNnVHkvV1ZXbWhGSjlURkVRVUxxOTF2d0s4Q1g0?= =?utf-8?B?SWlZS3pOS3B5NzlKS1lUQ29HZGVMcnJIRjkwL01Ka2lpelhCTTI0aXQxWVlF?= =?utf-8?B?eHVrZDlDbDZsRXBPWXdGWXZlVzRwcGI4eDIxbW9tSGZlS0JkKzNhTUx3N1Zt?= =?utf-8?B?RDQwUEg2RS9ZYlRhTjJqeTF5WGJaeldzNUk4RSt5VktqWmUybGo1aVk1QmxI?= =?utf-8?B?ekFsTFNPUk5mSmF0ckxjUEFQS1Y1SXBDdTYybVJFQlY5TDkxWU9ZVlI1cDl3?= =?utf-8?B?b2xDcld2UThQSWtKUDI3a1pRNmJoS2gzZVhHaERRMk56R2N3VnpMNDVqenZO?= =?utf-8?B?ekJWTUxyTVNDZFFTYVgxV05XQUFSazY5bnV6U1Y2MEl1WlRxTDFaV0RETlNT?= =?utf-8?B?VXVRWkFsZUpFemd0NU1qOG05b0M3YXg2LzNNaEdWR2Y4NUpRc2RDekVVSHdw?= =?utf-8?B?QmRTSWxQQlZiL1VkVm9wZW9qaUw1Q253OXgyUkl3dTYvTW1aTG9EVmVNbGo5?= =?utf-8?B?dllyVmFSYkVoVDJ5UU9GMEtaWmpvUHB2YlQwd1NTc1BZc1FKUnhBbFFTdG4y?= =?utf-8?B?ZFBPczRhR3JhNEV1aHRmdGQvYlU3MzFXbGYyNjlrVnJEaXFMNEtOUC9iSVRE?= =?utf-8?B?enBWcXVOOWpYMTRRL093TWJuaWZBcnN2Sng5WGFPUUk4ZzlKYnJKaDArR2R1?= =?utf-8?B?ZzZNR3d3bjMzaW9Pak1xRlBYdUNPVHovYW4yMnBDaUtMaXFDS25mUTRvS2hr?= =?utf-8?B?VUlUaHR5QjNzUVlvenBXalBDSTh2dWJjZUdONjFUOFlFMlp3aUdKdDVBbnB1?= =?utf-8?B?d28zTUtYSUQxdHdEOVMvc3Nray9vRitHNVdSTWcrSEQ2RGJab2ZPTXhXSTJ5?= =?utf-8?B?OGJIdk54SmlYZEhvZVpudDZQTDVCVjZsbzJGMUVQUUdZWWJNTklyTGFNMDUy?= =?utf-8?B?SzZWK0ZtWWovNnBwN2hqc1BZN0RCOWlDVHdlQnhLdDQxdHBTbG4xSWNrTWNz?= =?utf-8?B?Ym9jWUIzQXMyMGg0UVlCdnVselZKamladWg1OVNEY0V5OHJZU054Z3FMZFVY?= =?utf-8?B?cEFPMmlqMlhlYkZEbEdKV1A0K1BxZXc2Z2ZIclgxQ0p3UlYzN3hoSWdpZHE2?= =?utf-8?B?OXBQWHNOKzhKVENMa2tYRWR6bDNDK2tRV0xOZlB2RXREcjAzQnpkL0FJV0VG?= =?utf-8?B?cUNtOG53RDJJV0VkemxYOU13Q1lXSDVsdDU4dTNTRlcrWlNMWHdkVDJsMGhM?= =?utf-8?B?dFRXRmJRaEl3cWhQSTRmanB1U09kTEVUVGxiZWdicHdZbjg3V3dPdWsrOWpj?= =?utf-8?B?M0MvbTlTSklkM2l0QXB5ZnZ4YTRBVHRBYmtjNkVVS2FuQnNEY2lMbWZwa0k2?= =?utf-8?B?aEs0eTR2Tk42VFV2aXN2WFIvblFkUHUvSE10eU84dGhTU05sUVQ0dlIxSGdL?= =?utf-8?B?S2VKYlNSY0szZXdLMjY5cGtycHdBOFNlcjZHUU5GS1hoYlhubENKNUlVTzkx?= =?utf-8?B?aExJbUw0NFhVMVRFWkpEUWVaUDdZeUJCdXlYNFJNeUpOdXMzbGlzU0NvM0dQ?= =?utf-8?B?cDg1RVRHeTNMNXFZbnpmc0NGb0RvejEzMXpOWjlYMENyUDZsSXBQci8wVytM?= =?utf-8?Q?+PPRVz?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(376014)(7416014)(1800799024)(366016)(38350700014)(41080700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VDhMTkt5STNkZlhjN28yY1Z4ZUNIRjlRWnVWOVRadTN2cVBzSFVuYXB4UXY1?= =?utf-8?B?cXNyc056eE5YWUZGUnlBK2RyQ3Z4MzZBZzJYR1JNWWlXSTZmdGwwUzNRZkw2?= =?utf-8?B?czVPV1doVUVMOTBUOFpUWXFTUDRGYkZrWk9kSGtxOFJxL2IyeDhoN1NxeXVo?= =?utf-8?B?d2lhTmNxQ0tMVThHN0lxSk5NUjFHU0VCYUtQejZVczdZaE9ZSW9lZXRaVFJF?= =?utf-8?B?SUpQZzY4L1craTdtbHI3YjMrK3hUOXhhSTlDUHlGSjE1MjZFaXo3M1IxbzFi?= =?utf-8?B?MldvbURWN2tFdTRtRndXbWp4RGp6dWFLbVltOTAraDE4WXZ2RDZ2QzRvWHJM?= =?utf-8?B?VDVsYU1ReXdrdHNES3J5ZTl3UVFYV0hHSjBIWmR0VjRDOGlNbUQxYTYvK21Y?= =?utf-8?B?NTVsMitLYWEwZTJZcUhOdUdKWm1ETzF5LzdOTVk0SmZuR1VhSUgzTWs4T2pN?= =?utf-8?B?TUwwYktZQ2Ixd1k0UE9TWFJ5eEp0dFFuZksvblI5a0U2YThXdzB0VlhibDVo?= =?utf-8?B?U2JBdmwrS2FROWcyWDlUTlhMQXdCWWhaVzIxaitidEN0c1dIVUVJa01qbEtP?= =?utf-8?B?ME9kUExwcTE5TjdUb0FzbE5vamJtRW9iYS8vUVJRTnovR1N4aVltNld6OHlW?= =?utf-8?B?NG9MZXVuRGVTYlBEMGpLak9BYVFtRjVuQjdmVmdDSUpWaUJkb0lacC9Xb1U5?= =?utf-8?B?TGhZbnBBLzUxTHpEOTh5OENOd3hhL3A5bW1pdnhCSzViNEhmaS9GWG5Wb2hJ?= =?utf-8?B?ZWMxcnRPSHJXeWhJZU1TaVAzRjh0OXNCall1TmxreHo1ZnJzMW9aZkVmay81?= =?utf-8?B?YktncURSbEVnTkNCUlNVOWgxbnFIVk9MZ3dzdVo0M3JuemhoYXowT0FZaHM5?= =?utf-8?B?Z29LK3JNMXNvMTFWVVEzck0vcWl2YlgrYkxHNGp2MXBJcXV6TzRkVGdLS3Y2?= =?utf-8?B?Y3FiU0NOZThnblVxS3MySU42dTRjcTdHUURVUE5tek9janFBQXZiQ1VwZ3NG?= =?utf-8?B?OXd1OUN2RVpDbmpRUFlxRE80K0FHMU9lbDlyOFlBcUFpRWZyYURKSTlnSjF2?= =?utf-8?B?bnRGUlBURVVRNFM3cnVLb3FYcWFzVVpQNzF0amRXUHFvNGRwcVNpcExmaXg2?= =?utf-8?B?Y2E0eUpPVk1nenFoRzhuZktlNlpZWGJ3Y3NRQVVoU2x1M3lzL3dTUmwzS1h3?= =?utf-8?B?MWRPVGNTOUNxbFRCa2Z4SlMxSC83NEh1NVVpb2hXRWFDYXY5bTVRUFlIZTht?= =?utf-8?B?QytqNEE5T0xVOE9jVlJEZGFYenIzdUhzajQ0ZHd1eWFENEMyWmJEczRTTXhD?= =?utf-8?B?aHk5WVVYQVNWaStXZCtsZkVydXBBNTF6SmdpMUdNSGsxb1NGREdtZmdmUi9Q?= =?utf-8?B?MGptQVRxdUVVSjFJc0I2R0R0QTNNODExdE9HN1V5aG1tcmVFclQ5TkY4c3hR?= =?utf-8?B?K1QxMTFJMXB3d0xGdFlWSCtOUlFCSGlGQ0lDbThFSWpSbWJoN3lIRCtrOTE5?= =?utf-8?B?TFdaVzdRTkVrQ3dMaG1aOUd6WFdKRDZyMGZic3FCeWowdkZXZGxPNm16Mkho?= =?utf-8?B?OUlLOStLYUJWYktHSHFKa0VPQ2tWOURodjFIam0yQ2prSE1EVEY0VkhOTUVa?= =?utf-8?B?WVorQXZEeXk2aUxkK0FMWEdjbGFXMUl3T1IwWm02U2N2dTduM09YdWtOZ21F?= =?utf-8?B?SFJJenVpVzFwWXJQMGY5WmdMcUNRWDhZVG1XSEd0V1dNUVdhY1lqWm0rdk5T?= =?utf-8?B?OXJBc3FlREpmbnRkSFNXc3B5M0pDODdQT0pQck1PNEhrYXdOMDk5NlZFK1ZD?= =?utf-8?B?VFAzekdqTmM5VGxUdzhtUzJybERIaTU4cDU1YjFBY3dYeFF0TVZqL3cyM0cv?= =?utf-8?B?ZFFoMDRvc24xTytROEtCSUJQb3FDV3lDTGswb2p6cEd1L2hCV0N1aGFhYzZK?= =?utf-8?B?dmM2V1o0azB1WUlaQ1Vjd05xaTUzMlIyMTArSU1yQmdTdEZrM3F1eWRRNGNQ?= =?utf-8?B?OERjb1ZsQk9OTG5odGRzaU9GVU9QS2hkYk96N2pwWGhLSmdhOUszZGpSMnN6?= =?utf-8?B?a1QwUmZ6bGlKdUg4QXgxQytpK0xJTnJjVW9rV3Zlc2NsV2RFeldrVyt0NU53?= =?utf-8?Q?Q/oIHF72dUDLtbqn3EX7DlGdR?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f91cc4d-63b2-4889-02ab-08dd8eb49d7e X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2025 04:47:34.5178 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0rp006NUFXtzgLcDScuBhvRhxXNBoJdNTHIzbXnFdMuAppsrkBlNcOr6sK+Za9EZO+QjjGk+jlpyFDxOSLTSmA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8736 From: Peng Fan Kernel warns about mutable irq_chips: "not an immutable chip, please consider fixing!" Constify timbgpio_irqchip, flag the irq_chip as IRQCHIP_IMMUTABLE, add the new helper functions, and call the appropriate gpiolib functions. Signed-off-by: Peng Fan Reviewed-by: Linus Walleij --- drivers/gpio/gpio-timberdale.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-timberdale.c b/drivers/gpio/gpio-timberdale.c index fad979797486534d3cc6a1437fdca765baeb7b47..cb303a26f4d3cd77368b5bdac42= aa42821b39345 100644 --- a/drivers/gpio/gpio-timberdale.c +++ b/drivers/gpio/gpio-timberdale.c @@ -103,20 +103,26 @@ static void timbgpio_irq_disable(struct irq_data *d) { struct timbgpio *tgpio =3D irq_data_get_irq_chip_data(d); int offset =3D d->irq - tgpio->irq_base; + irq_hw_number_t hwirq =3D irqd_to_hwirq(d); unsigned long flags; =20 spin_lock_irqsave(&tgpio->lock, flags); tgpio->last_ier &=3D ~(1UL << offset); iowrite32(tgpio->last_ier, tgpio->membase + TGPIO_IER); spin_unlock_irqrestore(&tgpio->lock, flags); + + gpiochip_disable_irq(&tgpio->gpio, hwirq); } =20 static void timbgpio_irq_enable(struct irq_data *d) { struct timbgpio *tgpio =3D irq_data_get_irq_chip_data(d); int offset =3D d->irq - tgpio->irq_base; + irq_hw_number_t hwirq =3D irqd_to_hwirq(d); unsigned long flags; =20 + gpiochip_enable_irq(&tgpio->gpio, hwirq); + spin_lock_irqsave(&tgpio->lock, flags); tgpio->last_ier |=3D 1UL << offset; iowrite32(tgpio->last_ier, tgpio->membase + TGPIO_IER); @@ -205,11 +211,13 @@ static void timbgpio_irq(struct irq_desc *desc) iowrite32(tgpio->last_ier, tgpio->membase + TGPIO_IER); } =20 -static struct irq_chip timbgpio_irqchip =3D { +static const struct irq_chip timbgpio_irqchip =3D { .name =3D "GPIO", .irq_enable =3D timbgpio_irq_enable, .irq_disable =3D timbgpio_irq_disable, .irq_set_type =3D timbgpio_irq_type, + .flags =3D IRQCHIP_IMMUTABLE, + GPIOCHIP_IRQ_RESOURCE_HELPERS, }; =20 static int timbgpio_probe(struct platform_device *pdev) --=20 2.37.1 From nobody Sun Feb 8 17:13:49 2026 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2084.outbound.protection.outlook.com [40.107.103.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE211265613; Fri, 9 May 2025 04:47:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.103.84 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746766065; cv=fail; b=dB71P/9hVgtz+gnGavFGr2Rf/NL4ox7GtbY+sSoscbvJZymDwCU60ZPgRTIt8u25DUT1WttrVu2snVJoBqRV8UPCFrTTXJgeTmB6cT+W1Pyv2XgLADJ+u3PamlwUwRv0J1Onm11IbG7EWMXkuhF4Cyin2jDclrlES4apcQcSUNY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746766065; c=relaxed/simple; bh=LvnI7122UpWn06ie26QqhPkq1Hcv2t4k6wVvVXEd1f4=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=aH1K6UIR4Fr34QUGnRzTXOmtmytNNXMHVywZT6KRy73qZCGBprjlQY23KQUVcXTcJ/1ATLJLnI8C9rAEGbRVUyHf3y70XaxA8D41Ysm0Tr9i5395S0+g4tr/mHuzw5qQdC2oHEpzMbXX3xydKj/Wkj7ncqPKJEol9kriJLDknUQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=UR95yJXa; arc=fail smtp.client-ip=40.107.103.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="UR95yJXa" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IZiORLsGqFmTNLkP8i3IcypJRKAWj8xPyGQzP6UG6XhkJk+ZLFowedD7HYVc2SmSY1P4FbpqGrfTcWRKCV+EuBcWFnKbaZTL0o9E530JwGMjY6P2xAlQfePTb+8TDmGEtxxghBAZsDNISzfuJupcvTHSIpB6DGEXXQ3KQ9Oxk36WuuZsBAdbxKVzdmDDhfsa2cVhDlT+b5W7+VK4EoI2e8PLnmcLDFG23NZ0ocW5ykInyPc6p5Ftyb+HDdiPGonsa575uQGXw+DntjnDy4K4zc+1IcZ6oHmKjVjckyyZKrLwblr501Ka2fKEx/15+14qAtFeZW+KLNSzgFRlzakoPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yrqGOaq7nS84ubtipNA7Tq/bmEX7TxKRsTjfvZZgKm4=; b=e+ZSQ2Z05zeg/ahJI3fMVSjMrW7RAtsaD/X3lu+l0T90kPq0H93p6sLjOsU8oeQPTrU3tjbt0lD4I5c4E7gc8q25JyVnm0UROJMh4yTAoO38C682KBoLyc2nuLAFQgOhXlkSWXOWxRoreeg5lQuRq8AQlL9XTgV7MOD/9nCR4L31EsW9iPUxGTcZ1+U5dVC0Z065C7L5UrHsChRbtjpavuuR8rleLv37H62HXiAW8cMIMqpolKOBlXkxlM7FhlpLy1oDUPXwvWC4p15QjrYVWXPmWNtkwHbtWYQaAHZ+u3VKkR5Nph/Et2E/2N/0eo+topZGiDzZx7qxZKPDHHywSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yrqGOaq7nS84ubtipNA7Tq/bmEX7TxKRsTjfvZZgKm4=; b=UR95yJXaQ1PIU8bQqyJdFuz8D7H1qlF7Ohy55XOAw3sosBT5wOKX8h24glFs4kLjvL4B8dnkxV6h1YXNPSwHRXkCGNK/Y4uh6HqkdPaK2DP096d7o+SDRBP0+15lbNtoP9jE7cY4nmtLspPgSC578y7DGj3b4Uh1RRyT/6+Lld9Ll/qsxn8QMJJ6p2BK/EKjdYbOeA65G37UyyG69w8FUK9NXs6Z1DqJ++zzhpnzJEf46BPug/Fkx2gSByd93l54tbTsyk7VVN+qMbRGRy55hnRs94/czmyZkoBUh2fmsF9sNbYGIYZXc/BWiN/OeXFzCRnjf9eLYKuE17ormtIbzQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB8PR04MB6842.eurprd04.prod.outlook.com (2603:10a6:10:11c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.25; Fri, 9 May 2025 04:47:38 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8722.020; Fri, 9 May 2025 04:47:38 +0000 From: "Peng Fan (OSS)" Date: Fri, 09 May 2025 12:45:40 +0800 Subject: [PATCH RFC 9/9] gpio: pxa: Make irq_chip immutable Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250509-gpio-v1-9-639377c98288@nxp.com> References: <20250509-gpio-v1-0-639377c98288@nxp.com> In-Reply-To: <20250509-gpio-v1-0-639377c98288@nxp.com> To: Ray Jui , Broadcom internal kernel review list , Linus Walleij , Bartosz Golaszewski , Florian Fainelli , Scott Branden , Vladimir Zapolskiy , Keerthy , Robert Jarzmik Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1746765944; l=1706; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=Nx5M2HT08Yg9LXdEWgdgVIt2WTydUu/72IK9Wwc29PU=; b=iv/w8UAUfrxu6AdL3EwNTZMFquVPRI72l0IBch1/2jB1zUNFgVtz46vkt8fxA7w77JIEI57zY SaiH/daO/N8ACqpFZ2H/GBu7FZGmlx3hOu7HG6txDemQPu9I0dkHg4h X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI1PR02CA0011.apcprd02.prod.outlook.com (2603:1096:4:1f7::19) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB8PR04MB6842:EE_ X-MS-Office365-Filtering-Correlation-Id: bd5a03b2-43e9-4792-8e4a-08dd8eb49fbe X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|52116014|38350700014|41080700001; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dzBjV0FNS28rc0RicDAySzR6c1dvYUZDdG1DZnNwQUh5d21kNnBMVG95eUFE?= =?utf-8?B?TE1PYlo3SFV4ZnIxbjR2ZE1CYVZvNE1YSEswRnFMZHVBWkxOM2UzZ0d2QXNN?= =?utf-8?B?SVhITkRmZmtFZVVvMXY0eFZnbGZPS281T0VxREpiTWt2cGx5ZSttRko5b1Nn?= =?utf-8?B?YXJtVWVZM2FhUFVzRnNLZk5ndXg4YktmSGZUUGFJMkc2SHRlaXlnaWFCYnZF?= =?utf-8?B?MUhMajh5anRRWjF0K3JYRXlHR2FCTEtFNmZWcjhPMjYydFIzZ2lpc1FsZ2Ja?= =?utf-8?B?TjM1eVJSdi9FVUpNOGoxMzdYc2taUUdFVVBXcXlORm45ZGVsTUdub1dOQU44?= =?utf-8?B?SXJ4dUpiNmk1a0hHV0hiQ2RzSXV5bzNRWThBWmxIWUhLSU13RlpWRysyNTk3?= =?utf-8?B?azBldlM5S3RveEF3eHFnM3gxeUVPT2pPdm1tZ2J4UTlYU1hFUlg1ZTZPWGZI?= =?utf-8?B?VE16UkpzaWNqcFBvaVE0L1pndmRHVE1mcEM3UnRUOUk0dXIycWhuSTQ3WXVS?= =?utf-8?B?dnZCTk1QekhvN3VLRE82ekFNaTZIRm5JQW0rK1hNK1FsWWdEdU9IV2xTUjR5?= =?utf-8?B?TjRSaDM3akYvVnFOSXNPdjlCZW1FK2dJWXpZdm9scThwaHpTeU9xUWtFWjFn?= =?utf-8?B?Rm43QTNMNXhPbXd5alFsSmpOM3Jnbm5nUnFpSXlpWUx3Q01EVDlxTFo0K3E1?= =?utf-8?B?RUxsU2VVK3RRRExrZCt2U1UwNUtjT0ZFNGtoaGNYRFNkWjJZOFBwbXZ4OUFW?= =?utf-8?B?d1pjNUtNb3dYTkxVeHl2WXI4ckMxUUxLVGt1TjE2N2U3SGl3cUZTdFRrZ2pN?= =?utf-8?B?TTl6eTJyY3JyWnZjMTJLSm5oSTRIMDVESG9SRHFPV3NXVnYyTmhrcTFPU1JQ?= =?utf-8?B?c3d3NEN2bDNFcU5RbWp4SGhxOEo4VTB6bk92MVkwM3M3WGJ2a09BOWVvS0xM?= =?utf-8?B?SjB3bk42TUFtME1nVGlUbGRpUmFHeVRjSDNkMW9ZWDJWSlo5TnBoNEsrZGE1?= =?utf-8?B?M0JiS3B1bHFxSlFMckdLVWNyUm44NHhaREJxZ1BiRElXZUUveEFlbFdERW9W?= =?utf-8?B?N1NPV2RMbFF6cnBRYVl3UmwwOXBzcCtvb1RiWFlSK3UxK1E2VFZhM1ZDVlF1?= =?utf-8?B?YSt4TDljR3BRS1R4R3ZWNjVDM1RqQmlIU0xXcE0yM2NNR2kvSU5ramg1Ykd3?= =?utf-8?B?WHBySWtSNzZHZllBeG1RY0xSaEdGbWE1MDMrOXdkSFp1ang5S2dJTjEvdERE?= =?utf-8?B?a3N1VW1DWTR6NDhUZGhWcmE2RHZ0aGltaDByWFdNbklWT1BhUTRraFlWcXBQ?= =?utf-8?B?b0xyUWpxVFpWeVJWVDZwUG9nSFdZaWVvSWpCZ0l5VS9RM2VVNmp0YUwwZDhk?= =?utf-8?B?djBNYmJhUlVENDMycG5XTStXR3p5d0hKNmtMVVlPbU1HNnF0SGFjd0w4QmxZ?= =?utf-8?B?dTJITGNic3p2WTE0a2docXpWWjExMm5HT0R3NWNHUTk2dGY0Q3VzaEFnNEp5?= =?utf-8?B?VUt6bUFaRm5LK1JvRUp1UmdQalRFcGtlRXRUQjBoMWc2ZStSWnZ6ek02dkNL?= =?utf-8?B?cU9WeU9VVW85dm9TNW5Gcnlpc2tTbHpUdUpoeG1Rd2VwS1JSZ0RqSHVNSnJx?= =?utf-8?B?OEQ2cFFSKzNRei8xQklWa3QyM1ZtL3lGcVg4WUZNYkd0UHkyVDY2dmlqQUtF?= =?utf-8?B?N0p0b0VNeCt4V0xmOWpEMCsrY3BBRmRuVmlPdEpvanJtSTZrazNDQTAwUFRm?= =?utf-8?B?NEFkb1dhdFcwWVUzY01QUE5waWRROTE0R2o3WjMwcEtLTXlwUHEzYXRINEUw?= =?utf-8?B?bzlpZWNJNllZeWVxTWk2b1U4VUhXZDdRS0dsaUMwb1ozbXE4VjBSNUhsZXJh?= =?utf-8?B?SFZsTkpVL1p6dzlXQlFNcWVFbEgwdS9wZDdTRFJyMnlqNVg2K00xMjllam5u?= =?utf-8?B?SDFyYjRac3VmekJIYWRUVkhCcHllSysvZCtBOWV5MUtrLzBYWkxyWXA5dzJ4?= =?utf-8?B?bStDSTVuc29lQVBtb0wxSFhPZVVnWFpCWW9Zd3d5ajlveHlDVnVQaGF5SnIy?= =?utf-8?Q?nXws7n?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(52116014)(38350700014)(41080700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VVBpWDlKR3VoUUE0QUVjdExBbVdQUlg3ejJ3WE0wK2Q1OXhsL2ltMTBFVEgx?= =?utf-8?B?NEY4NnFGYk1yT25Hdzdzemhaenh0dTFoOE96SEVnb3BaMDFsaWxPYlluNTZx?= =?utf-8?B?TDNpbkdIMWRWUnJrTm9uUHhib0h5dVFqREZlV2NVcG1wdDdTWFhvNnBIV1Er?= =?utf-8?B?RFkwV250YThjckoycHV0MzlFMjBZOEhIUG9sUmYzRDNSUkZ3NkVpRHlGZzhW?= =?utf-8?B?ZkZ4bTdBY3lGeVFndjF0cUhuTHNxdW9iTjBoZWNnbXc1eDVlaHkzMVBtZ1Zy?= =?utf-8?B?V29CUkdKWStLZDJrcWQwalJ1WFI1YmZlMmRNNHljZWFVWEtBWUlhOENZcmxF?= =?utf-8?B?UGZTc0sxSWZsRjh1UGNFempBMVl2S2dHZlQ3ZjV3VXVmN3Z2d0hrRVFDZEM2?= =?utf-8?B?aklsUUhyKzU0QkRwWWx6dytSYmJDL3Nrc0FrVHVFbHhvbStnSkpCRmdnZlFs?= =?utf-8?B?dlA3Y01pYWl2UEhXR3VhNk12YlpHVjVyN3JFUW42K2JBUGdJQkFFeXVwZGdP?= =?utf-8?B?WHp3WjMvcURpdlZBTkVDcjFVRjNOSmg4T1AyTkRmdFpCcnZ1MlVlWW56WWlk?= =?utf-8?B?alY5U3RFblFrZ1N6aVRsU25YOUJ4K3VxVWJYZk1zaFlzNHZZbkZoWWtGa1g4?= =?utf-8?B?SWRibG5MV240Z1psRHh1cklRL0lVZFBsM1NKL2xlVFNjZ1BRUjY3UjlvVitr?= =?utf-8?B?M0lSNGFNSWFGclpxczNJSUIyTURGS3lVeWcwYlY2dUNhbVFmTUpYQmJKczZi?= =?utf-8?B?ZHNQN1pMTlEwQVY5T3FsMDdnaXlTL0Q4VjVHNGNTRzB1UXNTajJ4QzFETjB4?= =?utf-8?B?N0dQUU9lc0Z4L21nOWlicStiVWNEeDJGblNFb1RuVlM2K3paR3J3QWZLUEsy?= =?utf-8?B?NEF1V3E1a1hPRW9JVjBjR0NzeUpQTGNIdGlBY2w0Q2x5a2FERkpZK0FIVjE3?= =?utf-8?B?cE1IWi9OMkdqaFIyMWgxMk5La2l4b04zM0tJUStLNE9PRHpUREhFUE4zdmd2?= =?utf-8?B?a2U4QXBBRmdLOW1DZlZ3MDVybWZrVjBDZGhrczZNYzhWTjJ0b2lFOVVHN3Zq?= =?utf-8?B?anordmVHOWVSQkxmWW81QUgxRFNDOHAwaTlhVkNocVhTTzcrN3NkQmp0K3B3?= =?utf-8?B?OGhtVU5lVEgrSU1xT1ZyV2xJS0xXWWVCeWs1b1N4RHFWNW42S1VYSzlYejZh?= =?utf-8?B?WWNQQURrUXFLZUsvRnlFV0tXT0VYUUFkb0dsWDBOZjJuK0Fnb0N3eEl5OWp2?= =?utf-8?B?YVRhY0twRklIZm1GRFNnRy9DUFpKUFhXOEJ5em53SUZOcTgzK1NJaHdCdzhs?= =?utf-8?B?WGphVFphSjVxalYrZEVHeEFETUd5ajgxQXdWWmFURm9FYjBvaXdzSDUyOWFU?= =?utf-8?B?Q0FOUzRPalhUUnhydGI4ZGNFUWNyRFZISXJzWEsrMEplbkpWK3lFM3FjWi9Z?= =?utf-8?B?KytYeml0SlQ5Lzk1ZEt1UzZQN1F0a3pRT3FrRGQ0ZzE0RHJRRHZtUUREVDlJ?= =?utf-8?B?NThqYlBqMnl6eFV3SWFYZERjZmdJYTJnWjZCZGhZRGxHN0FiaER2bmR1cUE2?= =?utf-8?B?eWwvVzExMkhnNXNDcS93Y0lyMU5Hc1MxV2dqcEY4V0pKNWJSeDVqUDdSZDNO?= =?utf-8?B?bWxNVWhrSlN6U0UwWGsyVFRsOTVSaEdSNCt6c3RZT1VRTEpnSVVYd29HNEV1?= =?utf-8?B?OFNTei9tZ04zZjNvVkVJNFdLRE9xTmdua2pMYy9hY21OZzdYSytHelNSNkhu?= =?utf-8?B?VXpvVExkdGNHQlVlamh6cCszbWp4WXpaVGJpTHN1dlVqWXZBaUFjTS9YRSts?= =?utf-8?B?YS9oMXlkWTN2d0ZuL0o5QXIydEFoNmZVeWNoUC9qNTBNOHY2cVlJeXZzUFZ4?= =?utf-8?B?QlB5UTVKdUVUTnNEa3RHaVYrV1FhVWRpbzc0MWJibk9rUlNaNHVzTVpPbHgy?= =?utf-8?B?dC9RYlBNL0NRZnRvQS9yM1lUcVd4cTlaY2VYdUx3enhNUEhwRlVXaWJzdklo?= =?utf-8?B?clhqZVMvNFdQUW9PZmo3ZGJwNWJDN3hGVm5CSHZOM1JRb2txRFlYbGt3Qlpk?= =?utf-8?B?ZGlNcmxVamptUTAzeE1mTzkzUEdMLzFSRWRrdkFLOEYwU1hhUXZiOEVtVTBa?= =?utf-8?Q?sOWUMenW7fndWx2qM14Jsk8J0?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: bd5a03b2-43e9-4792-8e4a-08dd8eb49fbe X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2025 04:47:38.3216 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RS0+l6ED2zMsFpFAUeFv3g+WcKFAdXYxfBgQbnYjDHWMVUxdp4msg/n/jhNqbSrfyoAGfeY2idpI6rTW+7EGkg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6842 From: Peng Fan Kernel warns about mutable irq_chips: "not an immutable chip, please consider fixing!" Constify pxa_muxed_gpio_chip, flag the irq_chip as IRQCHIP_IMMUTABLE, add the new helper functions, and call the appropriate gpiolib functions. Signed-off-by: Peng Fan Reviewed-by: Linus Walleij --- drivers/gpio/gpio-pxa.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c index c3dfaed45c4319a54b545bd89b834253b77d369d..aead35ea090e6c37e80ae3c29e1= 2c44cc8e930c7 100644 --- a/drivers/gpio/gpio-pxa.c +++ b/drivers/gpio/gpio-pxa.c @@ -497,6 +497,8 @@ static void pxa_mask_muxed_gpio(struct irq_data *d) gfer =3D readl_relaxed(base + GFER_OFFSET) & ~GPIO_bit(gpio); writel_relaxed(grer, base + GRER_OFFSET); writel_relaxed(gfer, base + GFER_OFFSET); + + gpiochip_disable_irq(&pchip->chip, gpio); } =20 static int pxa_gpio_set_wake(struct irq_data *d, unsigned int on) @@ -516,17 +518,21 @@ static void pxa_unmask_muxed_gpio(struct irq_data *d) unsigned int gpio =3D irqd_to_hwirq(d); struct pxa_gpio_bank *c =3D gpio_to_pxabank(&pchip->chip, gpio); =20 + gpiochip_enable_irq(&pchip->chip, gpio); + c->irq_mask |=3D GPIO_bit(gpio); update_edge_detect(c); } =20 -static struct irq_chip pxa_muxed_gpio_chip =3D { +static const struct irq_chip pxa_muxed_gpio_chip =3D { .name =3D "GPIO", .irq_ack =3D pxa_ack_muxed_gpio, .irq_mask =3D pxa_mask_muxed_gpio, .irq_unmask =3D pxa_unmask_muxed_gpio, .irq_set_type =3D pxa_gpio_irq_type, .irq_set_wake =3D pxa_gpio_set_wake, + .flags =3D IRQCHIP_IMMUTABLE, + GPIOCHIP_IRQ_RESOURCE_HELPERS, }; =20 static int pxa_gpio_nums(struct platform_device *pdev) --=20 2.37.1