From nobody Tue Feb 10 02:59:38 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1326CAD5E for ; Thu, 8 May 2025 23:33:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746747217; cv=none; b=p4iO1nHjl/jiY8R9KskBSvUqXy++bEmbgfNd4OhpTD6LH5kwbunUni3T38nKGngxqlKHF0fpzcKqqVfDqspqJhlPDdYj0gGQ1P5L2OAraKa9tAVB56whZ+1GjdYQndIOgd3iLxdTzL2C8NbQWWwoVTtGa1kJ9gSvsWPYGQsLZ+k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746747217; c=relaxed/simple; bh=qrbtE4GJAc5CkkZvuRY2A4Vna57jDG+6dB5+Nw5K9to=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=tD3F5+tKm6bJ1WOi/W6z6jyd3HDbgSDGpxz46EGDN4dVgN7xE0dwcPFM7Euh9g6n9DLLnDwdC2DY/F7QEh73tbaaQP/DwHj68EpmDGYXMlVNaZrL9kric+uxM46EWwMIWA/Sue8m/otzMvCB2/sdMLOMosFnc6Nd3P1g1iiw4rs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qp/+cd0a; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qp/+cd0a" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5428C4CEF0; Thu, 8 May 2025 23:33:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746747216; bh=qrbtE4GJAc5CkkZvuRY2A4Vna57jDG+6dB5+Nw5K9to=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qp/+cd0aLdjY1AeppBROmJzDS1w0IVP2u2f2XHj9own9KkNr7DK5VW0NKgXXsPoaK B/CA+Z74yAfX6G/l8l20eG6PuYkkPlDJNRd6JYbtVLw49138zf6KlE0tvlMYzBGg1O edvUw6YmBtZD2UEu99Gug1fEjOwN6uEX9qR8UCTF1ld2S2Tx0WXYVLjI3R1Rcwq07c sEior2X/RNuB+RQiKzlE9LUxAOHv5Cvoz/nYgAnFYAl/C4rjqUviBheNuDrBbYD0uy rERZVJk2KKAr7tphqTCnUj2b2rbSft9z0VSm6PwdQXo1UGK0piSs9IMCMJbPPVzCDE /qKV4eVHKXUNw== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 628A6CE11D4; Thu, 8 May 2025 16:33:36 -0700 (PDT) From: "Paul E. McKenney" To: linux-kernel@vger.kernel.org Cc: kernel-team@meta.com, Andrew Morton , Kuniyuki Iwashima , Mateusz Guzik , Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Jon Pan-Doh , Bjorn Helgaas , Karolina Stolarek , "Paul E. McKenney" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH v5 03/21] drm/i915: Avoid open-coded use of ratelimit_state structure's ->missed field Date: Thu, 8 May 2025 16:33:17 -0700 Message-Id: <20250508233335.1996059-3-paulmck@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <1bcf7d5e-b89c-4118-b872-c8896bdbdc19@paulmck-laptop> References: <1bcf7d5e-b89c-4118-b872-c8896bdbdc19@paulmck-laptop> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The i915_oa_stream_destroy() function directly accesses the ratelimit_state structure's ->missed field, which works, but which also makes it more difficult to change this field. Therefore, make use of the ratelimit_state_get_miss() function instead of directly accessing the ->missed field. Link: https://lore.kernel.org/all/fbe93a52-365e-47fe-93a4-44a44547d601@paul= mck-laptop/ Link: https://lore.kernel.org/all/20250423115409.3425-1-spasswolf@web.de/ Signed-off-by: Paul E. McKenney Reviewed-by: Petr Mladek Acked-by: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Simona Vetter Cc: Cc: --- drivers/gpu/drm/i915/i915_perf.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_p= erf.c index de0b413600a15..1658f1246c6fa 100644 --- a/drivers/gpu/drm/i915/i915_perf.c +++ b/drivers/gpu/drm/i915/i915_perf.c @@ -1666,6 +1666,7 @@ static void i915_oa_stream_destroy(struct i915_perf_s= tream *stream) struct i915_perf *perf =3D stream->perf; struct intel_gt *gt =3D stream->engine->gt; struct i915_perf_group *g =3D stream->engine->oa_group; + int m; =20 if (WARN_ON(stream !=3D g->exclusive_stream)) return; @@ -1690,10 +1691,9 @@ static void i915_oa_stream_destroy(struct i915_perf_= stream *stream) free_oa_configs(stream); free_noa_wait(stream); =20 - if (perf->spurious_report_rs.missed) { - gt_notice(gt, "%d spurious OA report notices suppressed due to ratelimit= ing\n", - perf->spurious_report_rs.missed); - } + m =3D ratelimit_state_get_miss(&perf->spurious_report_rs); + if (m) + gt_notice(gt, "%d spurious OA report notices suppressed due to ratelimit= ing\n", m); } =20 static void gen7_init_oa_buffer(struct i915_perf_stream *stream) --=20 2.40.1