From nobody Tue Dec 16 13:24:15 2025 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C47DD253F15 for ; Thu, 8 May 2025 14:10:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746713421; cv=none; b=J8nl8/jIoxgu3ZeqjD6FcrJWosBqhWBNB0qHvVnvZSQAed6RybEHQM1BXrqLcvM576dn2x6BBTn31cXhGSEs/+r02q+WhyOfs3fmBc5Yxljd4SNADjLjN+eEu3zA3Lx1eu0/i06dNPrvkNLTH6VIshKia4S5UDNbxC2cmIrNFy8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746713421; c=relaxed/simple; bh=h9ceh9DWtwvOAv8lZI5QIIzEnFfIR1nnvswMVkuMh7c=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=MtPutXHPY2Rj8ZXoIz7wolIISQHzKWTdmX6dqWEcj8RMyVv9aKScTMxG0HjNKHYKfS8srrb4AnuU2SoIG0WLx2Uf2Srcu+Hb1gLRektdmuXFShW5uRCN62J2g3rnhKZwdcWV24WPx2Qx/ZmeLdyH9i7NxaZpcg1EGq3on1DYqXs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=bm6axfZm; arc=none smtp.client-ip=209.85.210.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="bm6axfZm" Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-7395d07a3dcso785863b3a.3 for ; Thu, 08 May 2025 07:10:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1746713419; x=1747318219; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=p+56ubm47OlXcm/VaWogaGlH7q4WP+P+2pKjZu9cp4w=; b=bm6axfZmRXgeuF9fa6kEQJoma3Qim35CdnI18deLf9b2MaHRq1Z0ouEjlfGuk+Jv6J GRT4f8NL/JVvw7LKwHhyuIxPK53pYd0tKVbjFT+JxDH8ZSEeG5NG0vZ1pCNwV0Ic2uMk +/dW4LwVu+Mc7JoQ5ms0DVqsVQ4kaAZui1imiDkYSX6Rh9M4wmjdGNyjOJR7hZ2lSO6u XSGQpQ3itYTHSfAt2Y/IDTn7OC1x3QzheU7QXT9yWpwImj0U1bzcAjwOUeBMLQSdSVMt wm2L+YdvtlqTtY5ChjG6VJ7AgPc6xN0ve0lUaZNMXtC47/4jS5iqUcSZOuGrhOVEIwpf vAFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746713419; x=1747318219; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=p+56ubm47OlXcm/VaWogaGlH7q4WP+P+2pKjZu9cp4w=; b=SQIX2jt2D3RPNrr1YcmL5Cg9YnBv9y/meR3GFP7R+13PuFApqA85e+lgqelnF+Yjik umcLcXaO68AtXzI4Gdf5CQLLIYXuGRHbAc15l0aI964H9n7/SXdEbeZKxsKToD2KS3yC AMJagskYddkYhtcf0Bi+7e+WHPlOyXjG3UUhGuTKN9TM1xaO+xdWW/5ezRmESKzqc7/x tN0XOdYgHh14CrkdsnFOSHC6dOdwFCIDsSDy6LdU3V0qyD3a9H1l5JWZcv/FDEIRirZ4 vMPpSC6t0xOMnL1DVzIOe8OMIFTEZllQ+WkHWFkWK/xhVQv357JSz0uZSaOG/UoRBqS1 11ng== X-Forwarded-Encrypted: i=1; AJvYcCWOwOAZm4V1urb5hUq9D35Awf7xjdCRFfY+IWzM4iTmY7Qfcfw7R6wwHdsax+8p6SHE3Hwy9LTkOKrdsFI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/xu8BBse0itB1s/q7LNVPcI/izcXwvqTVqGjaoLvPtLsymwgK 3hWenh8dfkiaQvcs9ljI1xIcRK5cWlcxx6G+zxPnd2n2OVVLXVKI4GUApJScTL9vvSJ2CP6A7FI wNg== X-Google-Smtp-Source: AGHT+IG2eg6x/bjzTx5zXZD+HM1Dnr1Anhc1D/g6qFT5/6izbWgde1cjoEAZ96/ZeW59opbMXnoIvhkIYXc= X-Received: from pfbdu10.prod.google.com ([2002:a05:6a00:2b4a:b0:740:41eb:584c]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:4c0c:b0:736:41ec:aaad with SMTP id d2e1a72fcca58-740a99cdbe4mr5209318b3a.14.1746713418848; Thu, 08 May 2025 07:10:18 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 8 May 2025 07:10:09 -0700 In-Reply-To: <20250508141012.1411952-1-seanjc@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250508141012.1411952-1-seanjc@google.com> X-Mailer: git-send-email 2.49.0.1015.ga840276032-goog Message-ID: <20250508141012.1411952-3-seanjc@google.com> Subject: [PATCH v2 2/5] KVM: Bail from the dirty ring reset flow if a signal is pending From: Sean Christopherson To: Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Xu , Yan Zhao , Maxim Levitsky , Sean Christopherson Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Abort a dirty ring reset if the current task has a pending signal, as the hard limit of INT_MAX entries doesn't ensure KVM will respond to a signal in a timely fashion. Fixes: fb04a1eddb1a ("KVM: X86: Implement ring-based dirty memory tracking") Signed-off-by: Sean Christopherson --- virt/kvm/dirty_ring.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/virt/kvm/dirty_ring.c b/virt/kvm/dirty_ring.c index 77986f34eff8..e844e869e8c7 100644 --- a/virt/kvm/dirty_ring.c +++ b/virt/kvm/dirty_ring.c @@ -118,6 +118,9 @@ int kvm_dirty_ring_reset(struct kvm *kvm, struct kvm_di= rty_ring *ring, cur_slot =3D cur_offset =3D mask =3D 0; =20 while (likely((*nr_entries_reset) < INT_MAX)) { + if (signal_pending(current)) + return -EINTR; + entry =3D &ring->dirty_gfns[ring->reset_index & (ring->size - 1)]; =20 if (!kvm_dirty_gfn_harvested(entry)) --=20 2.49.0.1015.ga840276032-goog