From nobody Thu Dec 18 12:28:40 2025 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D49528B7E2 for ; Wed, 7 May 2025 17:01:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746637315; cv=none; b=GB0BshTB0lS6qTl9WsAHWnISx5zZz9hd9djU6fQ2GdunjHEKhT+6YzUVOUbgwKcP0kWzNKhVwGq/qPKKXvYUrOslXfBJH3BCmsZrAHHoGgttADXnBkSyYZDRp/W/dpIW2GlvB193tSGtMT0PowCEuZNaHocIxT5pCrOlRKZnh8Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746637315; c=relaxed/simple; bh=Xrko5q/lzVr0TFyoqkdvUcS7YYXQcRlNO7SZ0CU4BJE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AL2aNiuAAhA9eIZKVXTgIGCJ/GkU8BYQz21EqngcpY5FKmR9RJnzcy6QE9TtWQsmmQAHLTMuxqH/usz4A7WWFfN44SqYjPfSToRfBGPfCOECznztFvXgjC+i1IEw2OhYqFxuRvCRpL4gLVKfkO1c1fHINccFfuWMYl8xb84bmpU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=BWrXuOuf; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="BWrXuOuf" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=mdvcmG+pr6izOQ7iKhUgbPE6Eufkwe+TQMBeVd0mk4o=; b=BWrXuOufb/Y9cgZi +OfTXNNxxg93bzC2uLEpWea9qvrYjUiZnoPMyMolIBNXSFs40EshAI59Rcs3T109JfPXYB+lJVvwt ELBY2IcHnEorneocHCreEe/Y3lnmwJ70AMJ+eKQY7/Y0Kn4wmH9xUbCayAYEndP4iUVSV1Vkmko4b 2eRgNk4oxggzP7wxFS1BAjqJLuyZQJQMVW6/9wNyT7P4C4r/a62JhuMAU9T0rzn2GtBK01vnOim+0 ySS4gVUYmmDhJ8uDZrD1LVqDUlxm0ObqlDIVAtkjhXeNJ6ifYA0mvj78x6rOYJu4n2GFBmZHLvykV 8AyT+DVBeS/KNaCXLA==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1uCi9T-002EIU-1I; Wed, 07 May 2025 17:01:47 +0000 From: linux@treblig.org To: alexander.deucher@amd.com, kenneth.feng@amd.com, christian.koenig@amd.com Cc: airlied@gmail.com, simona@ffwll.ch, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH 2/3] drm/amd/pm: Remove unused smu_mode2_reset_is_support Date: Wed, 7 May 2025 18:01:44 +0100 Message-ID: <20250507170145.102508-3-linux@treblig.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250507170145.102508-1-linux@treblig.org> References: <20250507170145.102508-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" smu_mode2_reset_is_support() was added in 2020 by commit 5c03e5843e6b ("drm/amdgpu:add smu mode1/2 support for aldebaran") but has remained unused. See discussion at: https://lore.kernel.org/all/DM4PR12MB5165D85BD85BC8FC8BF7A3B48E88A@DM4PR12M= B5165.namprd12.prod.outlook.com/ Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 13 ------------- drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 1 - 2 files changed, 14 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/am= d/pm/swsmu/amdgpu_smu.c index 46cce1d2aaf3..04bbeeac98a3 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c +++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c @@ -3432,19 +3432,6 @@ bool smu_mode1_reset_is_support(struct smu_context *= smu) return ret; } =20 -bool smu_mode2_reset_is_support(struct smu_context *smu) -{ - bool ret =3D false; - - if (!smu->pm_enabled) - return false; - - if (smu->ppt_funcs && smu->ppt_funcs->mode2_reset_is_support) - ret =3D smu->ppt_funcs->mode2_reset_is_support(smu); - - return ret; -} - int smu_mode1_reset(struct smu_context *smu) { int ret =3D 0; diff --git a/drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h b/drivers/gpu/dr= m/amd/pm/swsmu/inc/amdgpu_smu.h index dd6d0e7aa242..a5ba37f57650 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h +++ b/drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h @@ -1601,7 +1601,6 @@ int smu_get_power_limit(void *handle, enum pp_power_type pp_power_type); =20 bool smu_mode1_reset_is_support(struct smu_context *smu); -bool smu_mode2_reset_is_support(struct smu_context *smu); int smu_mode1_reset(struct smu_context *smu); =20 extern const struct amd_ip_funcs smu_ip_funcs; --=20 2.49.0