From nobody Thu Dec 18 04:18:33 2025 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E55B229114E for ; Wed, 7 May 2025 13:54:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746626086; cv=none; b=fiStZhAgOvcBFdMlmaMZ2pviw1OTOKCEgjirTcbPrpYBQc2EwyEIpgn90CX6HVRBxvWmc0pvCVLecce9XSbi88ltgmiY747cOA7UFv/NXP7q/oU79TToDzq7doZMQExokblnJfU5UF7B5TLNXcvZ3yaz+7giuSNr4AHkPAeelE8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746626086; c=relaxed/simple; bh=hAGubNDj1gOlblEMHz8Wzny9A9txOnH2teTzYA0yIM8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fWV3ForfPid+fq1MZNpict8qTKX41yKuFqTBgaanVWXUiV+WODMj7nBHvua3yvrqbKwjv2HVAdxOF0/tjUOsj2MLdOIQPUQK9g8PpIHwWS+uRDa58pcCPwLwgyDsMMEi+c/G/ACsybKwZbOmLrKHGMUx+d6etm8zJg4ucJr2jiU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y6KVQ2rY; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y6KVQ2rY" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-39c1efc4577so3615798f8f.0 for ; Wed, 07 May 2025 06:54:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746626083; x=1747230883; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QUF0gW5TISqhpqMIsQd0HHfVnPAth32nyY5ETve72ow=; b=Y6KVQ2rY0JGHf4AakmblnOkYcEG2MG91yxckewG6xYHC2u8c7WWGkia6RyTS7ElTLA sj1UapoWA66bMfrH9R2NRXSCLnMl7beYjtIVmiev/PpYp65P6LR1/FLGMQA5zYq3ZVMP QIjUye69ZpWHuTdnR6L7Uj7INBYhjP9M4N9My7uMLn1u3ktxyvmEaNSCIvOWjaXosWDc /xvWw+qzvE7l7EvKur2P6HZqPeB4yb6RjXa6novkWhAnYJTbE2+XFF0pNKEVn8r7H8rk NAWLytcHmxApHEeeKjavqHVpjXbS3PQu1wrmjqZRRsoyWZ7OX4zEGmS4q2dN8dL0BN2U mWZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746626083; x=1747230883; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QUF0gW5TISqhpqMIsQd0HHfVnPAth32nyY5ETve72ow=; b=qJvIxETKKzf2LoOcoyZ1X6Jcumm6IEzTMjJc8kjI8+XJF9QdGKF+7vH0dRSezLee5V BZKWdl9OnxWxQf6PFjr+dfw7ed8jigcAYe0LL+fhviAkcMKZq1/8JRODn+YRcgHmz2Pd UnITsxxNzEsAa0AqWoTqWLoJvJJ9gSzfzCfP8GRym5tcgON5PNZG3e/veEU6pQcIAn18 j8yYdRnKta3GUIaacu6ynjIRNIw3CnC0IiaYZrvNGx3tPb7lOMj/iYcNqkW+yb38zqeQ OHOTcxFq4sjH1PAmF7BnMkJDK7Uk1iL6oPAdGIRQqbm8R0ltTqHOBZGX8p8/FCOvAAtU /h7w== X-Forwarded-Encrypted: i=1; AJvYcCV4YLpg3ElieDj79F3+iDOnJisZt9swSQamE+0L1AHWO+negWc0k77eGL6ubjJLB15gHZyDJBjAbQ56aYo=@vger.kernel.org X-Gm-Message-State: AOJu0YwYBviQ+vLTZdc3Zzhi8jOSKD/7dWCl/fB6FpFiB4O65IDyDfnX 1Dkr4/J3oqC3S/DEC4eyFEOAs4ylJKGlErURMshK1/6mwlxn0MUS X-Gm-Gg: ASbGncueRo1oulECC+C63LlIaQNJWi9QirigdtPnwyldClEj8XzsEGbnUq1mzrwoPpw wDkXa2tMNpdsH5dGcU5l3xctvhP6ZlH6c4XJnKrwcBH03ZFKj0Ah8x+iJoyDVmAe0aGGY8lKZQo EBk2KIafIcxgvQ7CfuOnJu7pI+tcmANPI2TXlK/G81paO1Ee/ZKdweeO+63XuPtRVJVVlrWMs3T Vk6OedACV1/u3PEH82RbqQvbC1tMFxCVUiuCxjU+PP8Fm6IhnL7SVmIjs5CaodSAzpK/T7Pe/jo dGlcDqmIP97tYf7srlECckdzPyFoImx+dEfInY/jSQ== X-Google-Smtp-Source: AGHT+IErie+ggvRQeaQ+1n7p9+VSNmynrdNGiIjkXiczR1lc20MESvq6mYvfQ+EAengMM8UOWdLkXg== X-Received: by 2002:a05:6000:4308:b0:3a0:8c45:d30e with SMTP id ffacd0b85a97d-3a0b4a29b29mr3051022f8f.35.1746626083047; Wed, 07 May 2025 06:54:43 -0700 (PDT) Received: from fedora.. ([94.73.35.165]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442cd32f1eesm1894295e9.9.2025.05.07.06.54.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 May 2025 06:54:42 -0700 (PDT) From: =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= To: louis.chauvet@bootlin.com Cc: hamohammed.sa@gmail.com, simona@ffwll.ch, melissa.srw@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= Subject: [PATCH v5 07/16] drm/vkms: Allow to attach planes and CRTCs via configfs Date: Wed, 7 May 2025 15:54:22 +0200 Message-ID: <20250507135431.53907-8-jose.exposito89@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250507135431.53907-1-jose.exposito89@gmail.com> References: <20250507135431.53907-1-jose.exposito89@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Louis Chauvet Create a default subgroup at /config/vkms/planes/plane/possible_crtcs that will contain symbolic links to the possible CRTCs for the plane. Reviewed-by: Louis Chauvet Signed-off-by: Louis Chauvet Co-developed-by: Jos=C3=A9 Exp=C3=B3sito Signed-off-by: Jos=C3=A9 Exp=C3=B3sito --- Documentation/gpu/vkms.rst | 9 +++++ drivers/gpu/drm/vkms/vkms_configfs.c | 58 ++++++++++++++++++++++++++++ 2 files changed, 67 insertions(+) diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst index abe7a0f5a4ab..13b96837a266 100644 --- a/Documentation/gpu/vkms.rst +++ b/Documentation/gpu/vkms.rst @@ -98,6 +98,14 @@ CRTCs have 1 configurable attribute: =20 - writeback: Enable or disable writeback connector support by writing 1 or= 0 =20 +To finish the configuration, link the different pipeline items:: + + sudo ln -s /config/vkms/my-vkms/crtcs/crtc0 /config/vkms/my-vkms/planes/= plane0/possible_crtcs + +Since at least one primary plane is required, make sure to set the right t= ype:: + + echo "1" | sudo tee /config/vkms/my-vkms/planes/plane0/type + Once you are done configuring the VKMS instance, enable it:: =20 echo "1" | sudo tee /config/vkms/my-vkms/enabled @@ -108,6 +116,7 @@ Finally, you can remove the VKMS instance disabling it:: =20 And removing the top level directory and its subdirectories:: =20 + sudo rm /config/vkms/my-vkms/planes/*/possible_crtcs/* sudo rmdir /config/vkms/my-vkms/planes/* sudo rmdir /config/vkms/my-vkms/crtcs/* sudo rmdir /config/vkms/my-vkms diff --git a/drivers/gpu/drm/vkms/vkms_configfs.c b/drivers/gpu/drm/vkms/vk= ms_configfs.c index e9f445043268..2cf97c2b6203 100644 --- a/drivers/gpu/drm/vkms/vkms_configfs.c +++ b/drivers/gpu/drm/vkms/vkms_configfs.c @@ -38,11 +38,13 @@ struct vkms_configfs_device { * * @group: Top level configuration group that represents a plane. * Initialized when a new directory is created under "/config/vkms/planes" + * @possible_crtcs_group: Default subgroup of @group at "plane/possible_cr= tcs" * @dev: The vkms_configfs_device this plane belongs to * @config: Configuration of the VKMS plane */ struct vkms_configfs_plane { struct config_group group; + struct config_group possible_crtcs_group; struct vkms_configfs_device *dev; struct vkms_config_plane *config; }; @@ -71,6 +73,10 @@ struct vkms_configfs_crtc { #define plane_item_to_vkms_configfs_plane(item) \ container_of(to_config_group((item)), struct vkms_configfs_plane, group) =20 +#define plane_possible_crtcs_item_to_vkms_configfs_plane(item) \ + container_of(to_config_group((item)), struct vkms_configfs_plane, \ + possible_crtcs_group) + #define crtc_item_to_vkms_configfs_crtc(item) \ container_of(to_config_group((item)), struct vkms_configfs_crtc, group) =20 @@ -178,6 +184,52 @@ static const struct config_item_type crtc_group_type = =3D { .ct_owner =3D THIS_MODULE, }; =20 +static int plane_possible_crtcs_allow_link(struct config_item *src, + struct config_item *target) +{ + struct vkms_configfs_plane *plane; + struct vkms_configfs_crtc *crtc; + int ret; + + if (target->ci_type !=3D &crtc_item_type) + return -EINVAL; + + plane =3D plane_possible_crtcs_item_to_vkms_configfs_plane(src); + crtc =3D crtc_item_to_vkms_configfs_crtc(target); + + scoped_guard(mutex, &plane->dev->lock) { + if (plane->dev->enabled) + return -EBUSY; + + ret =3D vkms_config_plane_attach_crtc(plane->config, crtc->config); + } + + return ret; +} + +static void plane_possible_crtcs_drop_link(struct config_item *src, + struct config_item *target) +{ + struct vkms_configfs_plane *plane; + struct vkms_configfs_crtc *crtc; + + plane =3D plane_possible_crtcs_item_to_vkms_configfs_plane(src); + crtc =3D crtc_item_to_vkms_configfs_crtc(target); + + scoped_guard(mutex, &plane->dev->lock) + vkms_config_plane_detach_crtc(plane->config, crtc->config); +} + +static struct configfs_item_operations plane_possible_crtcs_item_operation= s =3D { + .allow_link =3D plane_possible_crtcs_allow_link, + .drop_link =3D plane_possible_crtcs_drop_link, +}; + +static const struct config_item_type plane_possible_crtcs_group_type =3D { + .ct_item_ops =3D &plane_possible_crtcs_item_operations, + .ct_owner =3D THIS_MODULE, +}; + static ssize_t plane_type_show(struct config_item *item, char *page) { struct vkms_configfs_plane *plane; @@ -272,6 +324,12 @@ static struct config_group *make_plane_group(struct co= nfig_group *group, } =20 config_group_init_type_name(&plane->group, name, &plane_item_type); + + config_group_init_type_name(&plane->possible_crtcs_group, + "possible_crtcs", + &plane_possible_crtcs_group_type); + configfs_add_default_group(&plane->possible_crtcs_group, + &plane->group); } =20 return &plane->group; --=20 2.49.0