From nobody Tue Dec 16 07:06:59 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FD6825F7BC for ; Wed, 7 May 2025 12:23:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746620611; cv=none; b=GzNeLTCxMLfxA+4rA0k6aNMBW3IUQkJp72jrPtQQpKTX+1YWJ2J8T8Tt9F2gRVmTD2E9FToSHQ96RFkovLbIZjdqMQVAy4yuW+XaUZciCKu1WvlVuHfWD9m7pZgLppXb79lQ9BgEPfuz/XKRPw1hi08JZ9gRUUhcCDdKH+bpi9k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746620611; c=relaxed/simple; bh=wstjbJH1UyMo+LF5FaHWTbfkuXNTo5rZRqDKY0yRXBc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mUhycwdzdQKkCj+U4uPOqVSIuRhplCPKzrdHIBxUBXk4LTBesa6jfTYIBZ7jTbMuArRlbtAsoHy24+EGFRU56YktFGMRmSCuSSBKaEEI5sdq+pUXQf3ERRK5D0paJ9WDzfkLQYG+zdX0j4tlbmPcrmQRI6+N4ybkM8EB6TgqA/s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fuqAz+Xl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fuqAz+Xl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C386AC4CEEE; Wed, 7 May 2025 12:23:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746620611; bh=wstjbJH1UyMo+LF5FaHWTbfkuXNTo5rZRqDKY0yRXBc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=fuqAz+XlOwDRClCaVi0ae1tzr2c+cpR6MsX8wyU+WblgbDTwOp7DwrMvS6v9IrF2W B5BDTJNTwXLOgBa/6d1LEjUbiPD9zGFn58+MtOChaaUnGJIXzXcKmXFwvEOXiJLFc8 kAD0++8S//6JUSfXGBIxLoR3BAzNLowEbCt+LCAJkmZSZYexeKJdxyWPtqDeZfdqKb YAZPGHW/2RYoXkoFZJV4d6L9TCtDBVNWqNoD5e5AvxUpAV4cHK5jjWtWUDVRdCA6Xi MmwqsMaPvIWn8qr5A3kIuIKdc+rcc7rucgUR4iyJtvr9eRZnpVOnfTwunrCBTVLZNO fw8th/0B6o2yw== From: Daniel Wagner Date: Wed, 07 May 2025 14:23:06 +0200 Subject: [PATCH v6 10/14] nvmet-fcloop: don't wait for lport cleanup Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250507-nvmet-fcloop-v6-10-ca02e16fb018@kernel.org> References: <20250507-nvmet-fcloop-v6-0-ca02e16fb018@kernel.org> In-Reply-To: <20250507-nvmet-fcloop-v6-0-ca02e16fb018@kernel.org> To: James Smart , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni Cc: Hannes Reinecke , Keith Busch , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Daniel Wagner X-Mailer: b4 0.14.2 The lifetime of the fcloop_lsreq is not tight to the lifetime of the host or target port, thus there is no need anymore to synchronize the cleanup path anymore. Signed-off-by: Daniel Wagner Reviewed-by: Hannes Reinecke --- drivers/nvme/target/fcloop.c | 21 ++++----------------- 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/drivers/nvme/target/fcloop.c b/drivers/nvme/target/fcloop.c index f999bd6513c19b19af64e0ea547db26b627aab69..fc10d380c17e77ed35706ddd769= 0e6f6a8d268c6 100644 --- a/drivers/nvme/target/fcloop.c +++ b/drivers/nvme/target/fcloop.c @@ -207,7 +207,6 @@ static LIST_HEAD(fcloop_nports); struct fcloop_lport { struct nvme_fc_local_port *localport; struct list_head lport_list; - struct completion unreg_done; refcount_t ref; }; =20 @@ -1083,9 +1082,6 @@ fcloop_localport_delete(struct nvme_fc_local_port *lo= calport) struct fcloop_lport_priv *lport_priv =3D localport->private; struct fcloop_lport *lport =3D lport_priv->lport; =20 - /* release any threads waiting for the unreg to complete */ - complete(&lport->unreg_done); - fcloop_lport_put(lport); } =20 @@ -1234,18 +1230,9 @@ fcloop_create_local_port(struct device *dev, struct = device_attribute *attr, } =20 static int -__wait_localport_unreg(struct fcloop_lport *lport) +__localport_unreg(struct fcloop_lport *lport) { - int ret; - - init_completion(&lport->unreg_done); - - ret =3D nvme_fc_unregister_localport(lport->localport); - - if (!ret) - wait_for_completion(&lport->unreg_done); - - return ret; + return nvme_fc_unregister_localport(lport->localport); } =20 static struct fcloop_nport * @@ -1328,7 +1315,7 @@ fcloop_delete_local_port(struct device *dev, struct d= evice_attribute *attr, if (!lport) return -ENOENT; =20 - ret =3D __wait_localport_unreg(lport); + ret =3D __localport_unreg(lport); fcloop_lport_put(lport); =20 return ret ? ret : count; @@ -1772,7 +1759,7 @@ static void __exit fcloop_exit(void) =20 spin_unlock_irqrestore(&fcloop_lock, flags); =20 - ret =3D __wait_localport_unreg(lport); + ret =3D __localport_unreg(lport); if (ret) pr_warn("%s: Failed deleting local port\n", __func__); =20 --=20 2.49.0