From nobody Sat Feb 7 23:23:19 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 141BF28466B; Tue, 6 May 2025 16:48:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550096; cv=none; b=EtPpqymrT/jTOtz9SM+CRp/eKm8zV8n98W9VDxydbrp34IPkLjm/xCl+pYEy3vwbV13lHM0bZjlQHX0OzFCjwauqe+CGjNXzUC/i07j8B0FDYK0BkumiX0y/kO6RvmapNWlkwPL6lEZrd721pWm8ISFIdlhxw6MOq7BbgHTURBc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550096; c=relaxed/simple; bh=mdNYtaRODBwuKF3VeWvQWytU/9E3Yw8BVWMEoPcA6lQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jP0cZNQSynHm+KciTSRHOhdQaKVoLfnHYtKNZmEYusnTCjWaZeqGEPrqZo2dFH4Kwvdn9GKyU1aM/Bnkknz8j+50yqEzIT/+mLgevnDJHpF84c9OBLSkfcJRsjF44gpqz7/fnny76U0poYWxhtroHcLIhDquCS9EIz/9rbdH6H0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Q9i8tK4u; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Q9i8tK4u" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746550093; x=1778086093; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mdNYtaRODBwuKF3VeWvQWytU/9E3Yw8BVWMEoPcA6lQ=; b=Q9i8tK4uocx2/iQgOajK978jUBG5cNu3/vWkTXqA7FaSpP1XwOenT4WW alOzreIx0tV+LUFXqglKYRA+5gPbqPYjJ6x0oUXRKC1e6fVp5TPNU2j2M FC3hNgQaenOBHbv/T8feuF0VRkIhCguezTea7b5aPO68h0DpV5uMChFW7 aPJO2eyoQosRPX6UFqlT7nafPW8rXzybHFJazz7YCPW5JR2Y4ZwxgZG/d Kznsi1Lzt6CpDyJfd1L1xpNM41LUMbItRVkWjmXsk/4xaXl+yrJKlBfWQ JbW5R9f6qDnSgeIoWA7AcbQEGqcLdHyChOq3lnK8OmBN908Vi5LUfRP79 A==; X-CSE-ConnectionGUID: 3w1T0rgxR/GRt3NRbHw8HA== X-CSE-MsgGUID: /FSwg7AaQIObnBmfKgp80g== X-IronPort-AV: E=McAfee;i="6700,10204,11425"; a="59595215" X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="59595215" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2025 09:48:11 -0700 X-CSE-ConnectionGUID: ovA2FqPhTrGIn+ztkKVIDw== X-CSE-MsgGUID: IKCG6UOVT72WMMuJbsczww== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="135674837" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa007.fm.intel.com with ESMTP; 06 May 2025 09:48:10 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang Subject: [RFC PATCH 01/15] perf: Fix the throttle logic for a group Date: Tue, 6 May 2025 09:47:26 -0700 Message-Id: <20250506164740.1317237-2-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250506164740.1317237-1-kan.liang@linux.intel.com> References: <20250506164740.1317237-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The current throttle logic doesn't work well with a group, e.g., the following sampling-read case. $ perf record -e "{cycles,cycles}:S" ... $ perf report -D | grep THROTTLE | tail -2 THROTTLE events: 426 ( 9.0%) UNTHROTTLE events: 425 ( 9.0%) $ perf report -D | grep PERF_RECORD_SAMPLE -a4 | tail -n 5 0 1020120874009167 0x74970 [0x68]: PERF_RECORD_SAMPLE(IP, 0x1): ... sample_read: .... group nr 2 ..... id 0000000000000327, value 000000000cbb993a, lost 0 ..... id 0000000000000328, value 00000002211c26df, lost 0 The second cycles event has a much larger value than the first cycles event in the same group. The current throttle logic in the generic code only logs the THROTTLE event. It relies on the specific driver implementation to disable events. However, for all ARCHs, the implementation is similar. It only disable the event, rather than the group. The logic to disable the group should be generic for all ARCHs. Add the logic in the generic code. The following patch will remove the buggy driver-specific implementation. The throttle only happens when an event is overflowed. Stop the entire group when any event in the group triggers the throttle. Set the MAX_INTERRUPTS to the leader event to indicate the group is throttled. The unthrottled could happen in 3 places. - event/group sched. All events in the group are scheduled one by one. All of them will be unthrottled eventually. Nothing needs to be changed. - The perf_adjust_freq_unthr_events for each tick. Needs to restart the group altogether. - The __perf_event_period(). The whole group needs to be restarted altogether as well. With the fix, $ sudo perf report -D | grep PERF_RECORD_SAMPLE -a4 | tail -n 5 0 3573470770332 0x12f5f8 [0x70]: PERF_RECORD_SAMPLE(IP, 0x2): ... sample_read: .... group nr 2 ..... id 0000000000000a28, value 00000004fd3dfd8f, lost 0 ..... id 0000000000000a29, value 00000004fd3dfd8f, lost 0 Signed-off-by: Kan Liang --- kernel/events/core.c | 55 +++++++++++++++++++++++++++++++++----------- 1 file changed, 41 insertions(+), 14 deletions(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index a84abc2b7f20..eb0dc871f4f1 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -2734,6 +2734,38 @@ void perf_event_disable_inatomic(struct perf_event *= event) static void perf_log_throttle(struct perf_event *event, int enable); static void perf_log_itrace_start(struct perf_event *event); =20 +static void perf_event_group_unthrottle(struct perf_event *event, bool sta= rt_event) +{ + struct perf_event *leader =3D event->group_leader; + struct perf_event *sibling; + + if (leader !=3D event || start_event) + leader->pmu->start(leader, 0); + leader->hw.interrupts =3D 0; + + for_each_sibling_event(sibling, leader) { + if (sibling !=3D event || start_event) + sibling->pmu->start(sibling, 0); + sibling->hw.interrupts =3D 0; + } + + perf_log_throttle(leader, 1); +} + +static void perf_event_group_throttle(struct perf_event *event) +{ + struct perf_event *leader =3D event->group_leader; + struct perf_event *sibling; + + leader->hw.interrupts =3D MAX_INTERRUPTS; + leader->pmu->stop(leader, 0); + + for_each_sibling_event(sibling, leader) + sibling->pmu->stop(sibling, 0); + + perf_log_throttle(leader, 0); +} + static int event_sched_in(struct perf_event *event, struct perf_event_context *ctx) { @@ -4389,10 +4421,8 @@ static void perf_adjust_freq_unthr_events(struct lis= t_head *event_list) hwc =3D &event->hw; =20 if (hwc->interrupts =3D=3D MAX_INTERRUPTS) { - hwc->interrupts =3D 0; - perf_log_throttle(event, 1); - if (!event->attr.freq || !event->attr.sample_freq) - event->pmu->start(event, 0); + perf_event_group_unthrottle(event, + !event->attr.freq || !event->attr.sample_freq); } =20 if (!event->attr.freq || !event->attr.sample_freq) @@ -6421,14 +6451,6 @@ static void __perf_event_period(struct perf_event *e= vent, active =3D (event->state =3D=3D PERF_EVENT_STATE_ACTIVE); if (active) { perf_pmu_disable(event->pmu); - /* - * We could be throttled; unthrottle now to avoid the tick - * trying to unthrottle while we already re-started the event. - */ - if (event->hw.interrupts =3D=3D MAX_INTERRUPTS) { - event->hw.interrupts =3D 0; - perf_log_throttle(event, 1); - } event->pmu->stop(event, PERF_EF_UPDATE); } =20 @@ -6436,6 +6458,12 @@ static void __perf_event_period(struct perf_event *e= vent, =20 if (active) { event->pmu->start(event, PERF_EF_RELOAD); + /* + * We could be throttled; unthrottle now to avoid the tick + * trying to unthrottle while we already re-started the event. + */ + if (event->group_leader->hw.interrupts =3D=3D MAX_INTERRUPTS) + perf_event_group_unthrottle(event, false); perf_pmu_enable(event->pmu); } } @@ -10326,8 +10354,7 @@ __perf_event_account_interrupt(struct perf_event *e= vent, int throttle) if (unlikely(throttle && hwc->interrupts >=3D max_samples_per_tick)) { __this_cpu_inc(perf_throttled_count); tick_dep_set_cpu(smp_processor_id(), TICK_DEP_BIT_PERF_EVENTS); - hwc->interrupts =3D MAX_INTERRUPTS; - perf_log_throttle(event, 0); + perf_event_group_throttle(event); ret =3D 1; } =20 --=20 2.38.1 From nobody Sat Feb 7 23:23:19 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16E89284B50; Tue, 6 May 2025 16:48:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550095; cv=none; b=a04NKQgeCB5/eHJW3DpxoknV8cAdAPOIhtJeRHYNMt+s7kaNOWWcgC7mIwfovz1gLMNsTp/PJQW+XDvzdIEKEQ5CbBfYr6PddGvH1kV8InrH8nj5HJ22t4MnSzLInrf3/no17dDOIfWSFAKUtBDyf1enHcPhGdPEFqSbVBlUHKA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550095; c=relaxed/simple; bh=8RE0xbWDyWwo1by9qxsaBAuAFWZOZ+iKPD900Oa+h/I=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=VtPK8GuMSCEjxTDJVVlZPKe0yxigFqQ2f9PPI7mR2WxFk7GhGieXtJCJiywLjLyNnDhRjlqHVqfs3O6q9/iEGF5tGCsk46r/6Hv27V48JvCfml5SLydPf2isi8wsTLu3pd1G8GYBD2HeqKqJpMPgt3BNcY2GMSJoSLH1delayqE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=mXehuzW/; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="mXehuzW/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746550093; x=1778086093; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=8RE0xbWDyWwo1by9qxsaBAuAFWZOZ+iKPD900Oa+h/I=; b=mXehuzW/UQqesdmST8T9yEMOlbr+I3cbE/hkyqXbvXLVzMPF6AGd56bf GgQQTzm/tjzB2R9Co++UxH4LLQWB9zaoNwnCK6PxJOHdmrUOWafXUHhUV 7lCRE+65yc0ao4QLnfKTWZ3Z31ywGg7w5pohEkoqCSgV6jmrgEq5SFNUW GFGbbChCsfLj9Fm6vqMqSfTGT4YC3BdAhXv38z5qEFl3yJk8XWmACzirZ IH0GypyfIgLQUZhvWg+5jklJf5FUbMNcqn+ZdHwP6oZrsyj+qn+euNW7S uoXTE66m0N8pjrEvp5aD1nyoMSOOk0PHUKuG9R4z0n8d4CEmrFrIVenVw g==; X-CSE-ConnectionGUID: YO45yPZ8Rlyo987zAepaEQ== X-CSE-MsgGUID: avAsFJ6LRCuuVg6G9pwfdw== X-IronPort-AV: E=McAfee;i="6700,10204,11425"; a="59595226" X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="59595226" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2025 09:48:12 -0700 X-CSE-ConnectionGUID: NVDxh0tIS0Sfq0k8upO/aQ== X-CSE-MsgGUID: nRI49dU5QaqKDYGNK/eOaw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="135674843" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa007.fm.intel.com with ESMTP; 06 May 2025 09:48:11 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang Subject: [RFC PATCH 02/15] perf/x86/intel: Remove driver-specific throttle support Date: Tue, 6 May 2025 09:47:27 -0700 Message-Id: <20250506164740.1317237-3-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250506164740.1317237-1-kan.liang@linux.intel.com> References: <20250506164740.1317237-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang --- arch/x86/events/core.c | 3 +-- arch/x86/events/intel/core.c | 6 ++---- arch/x86/events/intel/ds.c | 7 +++---- arch/x86/events/intel/knc.c | 3 +-- arch/x86/events/intel/p4.c | 3 +-- 5 files changed, 8 insertions(+), 14 deletions(-) diff --git a/arch/x86/events/core.c b/arch/x86/events/core.c index 186e31cd0c14..8a2f73333a50 100644 --- a/arch/x86/events/core.c +++ b/arch/x86/events/core.c @@ -1730,8 +1730,7 @@ int x86_pmu_handle_irq(struct pt_regs *regs) =20 perf_sample_save_brstack(&data, event, &cpuc->lbr_stack, NULL); =20 - if (perf_event_overflow(event, &data, regs)) - x86_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } =20 if (handled) diff --git a/arch/x86/events/intel/core.c b/arch/x86/events/intel/core.c index cd6329207311..3a319cf6d364 100644 --- a/arch/x86/events/intel/core.c +++ b/arch/x86/events/intel/core.c @@ -3138,8 +3138,7 @@ static void x86_pmu_handle_guest_pebs(struct pt_regs = *regs, continue; =20 perf_sample_data_init(data, 0, event->hw.last_period); - if (perf_event_overflow(event, data, regs)) - x86_pmu_stop(event, 0); + perf_event_overflow(event, data, regs); =20 /* Inject one fake event is enough. */ break; @@ -3282,8 +3281,7 @@ static int handle_pmi_common(struct pt_regs *regs, u6= 4 status) if (has_branch_stack(event)) intel_pmu_lbr_save_brstack(&data, cpuc, event); =20 - if (perf_event_overflow(event, &data, regs)) - x86_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } =20 return handled; diff --git a/arch/x86/events/intel/ds.c b/arch/x86/events/intel/ds.c index 61ee698deaab..f33451dc7bc7 100644 --- a/arch/x86/events/intel/ds.c +++ b/arch/x86/events/intel/ds.c @@ -2362,8 +2362,7 @@ __intel_pmu_pebs_last_event(struct perf_event *event, * All but the last records are processed. * The last one is left to be able to call the overflow handler. */ - if (perf_event_overflow(event, data, regs)) - x86_pmu_stop(event, 0); + perf_event_overflow(event, data, regs); } =20 if (hwc->flags & PERF_X86_EVENT_AUTO_RELOAD) { @@ -2591,8 +2590,8 @@ static void intel_pmu_drain_pebs_nhm(struct pt_regs *= iregs, struct perf_sample_d if (error[bit]) { perf_log_lost_samples(event, error[bit]); =20 - if (iregs && perf_event_account_interrupt(event)) - x86_pmu_stop(event, 0); + if (iregs) + perf_event_account_interrupt(event); } =20 if (counts[bit]) { diff --git a/arch/x86/events/intel/knc.c b/arch/x86/events/intel/knc.c index 3e8ec049b46d..384589168c1a 100644 --- a/arch/x86/events/intel/knc.c +++ b/arch/x86/events/intel/knc.c @@ -254,8 +254,7 @@ static int knc_pmu_handle_irq(struct pt_regs *regs) =20 perf_sample_data_init(&data, 0, last_period); =20 - if (perf_event_overflow(event, &data, regs)) - x86_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } =20 /* diff --git a/arch/x86/events/intel/p4.c b/arch/x86/events/intel/p4.c index c85a9fc44355..126d5ae264cb 100644 --- a/arch/x86/events/intel/p4.c +++ b/arch/x86/events/intel/p4.c @@ -1072,8 +1072,7 @@ static int p4_pmu_handle_irq(struct pt_regs *regs) continue; =20 =20 - if (perf_event_overflow(event, &data, regs)) - x86_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } =20 if (handled) --=20 2.38.1 From nobody Sat Feb 7 23:23:19 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57D902853F7; Tue, 6 May 2025 16:48:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550095; cv=none; b=oO6GeCl2XLMIOSG5dZ0zaFsziWcRW0otYsOAxznmjQhEQR/LdSRy39rMmYfZORen8PisNUHh+oTJDjBsGhqQCjoDk4CPu5TVUJ51CMHyngQoA5DdNGp2+RqQugLJkx7v+06NbROEvLEE03RlaO/2ui1IDrxkRIqCNG0WVNdTmMA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550095; c=relaxed/simple; bh=RMEehrWYnmEORlN8I5Spw4Yog1jSoilWyq1ppX1bKEc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ke8SVwQ9c8y9lPuPhXvmLyHoH8gx2W0Xzqecm4Pg6DmGtc3zqP9Pd2mTWh2jSe2BJ3wknjSYk263YENsh0mi8pdwvhI5wtKI5xIrl+BNGVSMXcCnleS5jcRYzNILLm1SRltUO74nUiBCtSA8/b4LsydBdf4sTEIlbvr+ddMVHUQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Lv+DAO+O; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Lv+DAO+O" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746550094; x=1778086094; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=RMEehrWYnmEORlN8I5Spw4Yog1jSoilWyq1ppX1bKEc=; b=Lv+DAO+OCoFn45r4VUnPpYy8Xy6T3RZkPXRncj0l7pu0IT5nprNuBAN4 lK2PY/SdVxCJs7uZnkWTid5hU8XplOmHRFsWsH5lSCPz5kM8zCJRUtKUY pJsM0x/zAiJn4KzdUnG2nSoHDzetMngal8cnWpDBXCPE4W8MjA6iQpK9V 3SSwHrOeg8q3SCVl51qexuU+5DqgJIA7zIxIsiypQ5ou8bqiTo0f/cL+d gdapDYaz0vPbaxRsTkyp28eAMyLEy3eF3U7QqkR6jLXHpg2yD4+sT1k+6 adNdBe7GG3gYmeS6e3SqfPKmQYRLV3i6SR2dI+ci9hy114RPapi55KTF4 A==; X-CSE-ConnectionGUID: k4qxrZsXSwOQaPd85FVpeQ== X-CSE-MsgGUID: y2Fy/EhsQ3qshUBqyEqRFA== X-IronPort-AV: E=McAfee;i="6700,10204,11425"; a="59595238" X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="59595238" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2025 09:48:13 -0700 X-CSE-ConnectionGUID: BT+lBUeSQzumpL83ImWCeQ== X-CSE-MsgGUID: ul4nINe+TZ6rCAqW1RSGxg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="135674849" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa007.fm.intel.com with ESMTP; 06 May 2025 09:48:12 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang , Sandipan Das , Ravi Bangoria Subject: [RFC PATCH 03/15] perf/x86/amd: Remove driver-specific throttle support Date: Tue, 6 May 2025 09:47:28 -0700 Message-Id: <20250506164740.1317237-4-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250506164740.1317237-1-kan.liang@linux.intel.com> References: <20250506164740.1317237-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: Sandipan Das Cc: Ravi Bangoria Reviewed-by: Ravi Bangoria --- arch/x86/events/amd/core.c | 3 +-- arch/x86/events/amd/ibs.c | 4 +--- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/x86/events/amd/core.c b/arch/x86/events/amd/core.c index 30d6ceb4c8ad..5e64283b9bf2 100644 --- a/arch/x86/events/amd/core.c +++ b/arch/x86/events/amd/core.c @@ -1003,8 +1003,7 @@ static int amd_pmu_v2_handle_irq(struct pt_regs *regs) =20 perf_sample_save_brstack(&data, event, &cpuc->lbr_stack, NULL); =20 - if (perf_event_overflow(event, &data, regs)) - x86_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } =20 /* diff --git a/arch/x86/events/amd/ibs.c b/arch/x86/events/amd/ibs.c index 0252b7ea8bca..4bbbca02aeb1 100644 --- a/arch/x86/events/amd/ibs.c +++ b/arch/x86/events/amd/ibs.c @@ -1373,9 +1373,7 @@ static int perf_ibs_handle_irq(struct perf_ibs *perf_= ibs, struct pt_regs *iregs) hwc->sample_period =3D perf_ibs->min_period; =20 out: - if (throttle) { - perf_ibs_stop(event, 0); - } else { + if (!throttle) { if (perf_ibs =3D=3D &perf_ibs_op) { if (ibs_caps & IBS_CAPS_OPCNTEXT) { new_config =3D period & IBS_OP_MAX_CNT_EXT_MASK; --=20 2.38.1 From nobody Sat Feb 7 23:23:19 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0097A2857C7; Tue, 6 May 2025 16:48:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550097; cv=none; b=fNuXHYRrVdm6Q4MNJAv+xDbompr5POpDH/i8aCGtJ8wiNiYM5IJIUCdIBcHnTVnVHREM8+YUa2L+ZaH3qHusw/8qQENZ11eZC4/60TrVKr7AxSAdrXOWqFF3HPhOUK2LrmsISC1CiEoD3I6DFQWwAx0jBFKJ9ccZ9YEPKnw8SoQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550097; c=relaxed/simple; bh=eftPXZUtS7TWj+fyRnjgJB01av2QQsqnM0j4qbjXMQk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=X9+DY2ubAOqGyWe68MibtuRsFFpot1g5oHGF+UO34ct5lescciw/LQp5umAocMF9taigWAn2Zc0VxlOotnZu2vYsu8RE0MeiPzO0dDzxZeUhooFvoyeX5lDxMVvp8Gf2t/4chdhXrJMWpU0YtC0gT9lbFD550YAjN/xfaQw7iuM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=F92iWebO; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="F92iWebO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746550096; x=1778086096; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=eftPXZUtS7TWj+fyRnjgJB01av2QQsqnM0j4qbjXMQk=; b=F92iWebO7rrJbzGcROVb3GydGYdOhlyYFBqhffqsKZh4zfgxc6FbpAQS 48WlSH7N7z5WdBhwPCIlTm3szkwVw4jDfUK9WPMzIMpScyBuZkhbRaYPI RgEAJcGiaVUtORCyae1k/bdAQMqoMUmfQuwrhzjY1NqXe24Gn4juzFNaQ 0SPOzEVwnxvjguJL9EstEaAh92AJsGCL4DVNtRE++wub8BUwj1vfpPH2r qBoMey0WPSgDTiC3x36VGh9HQqxfPw9ZCZYArPWwozotQlkJ88TdnL+fD pmq2XxgKxu+GjsZICXgbOJmee0ukZyud014y/DUgt6R6kS+9/IzVpKVlI g==; X-CSE-ConnectionGUID: OfBLrJyRQQa29d0wUg9ctQ== X-CSE-MsgGUID: 1F60uAGaRJOBIoPmcW6kEQ== X-IronPort-AV: E=McAfee;i="6700,10204,11425"; a="59595251" X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="59595251" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2025 09:48:15 -0700 X-CSE-ConnectionGUID: nwc2n/8oSXqz7NO9qurilw== X-CSE-MsgGUID: 4oBJitNqSK6h5o/ebWw9hw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="135674855" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa007.fm.intel.com with ESMTP; 06 May 2025 09:48:13 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang , silviazhao , CodyYao-oc Subject: [RFC PATCH 04/15] perf/x86/zhaoxin: Remove driver-specific throttle support Date: Tue, 6 May 2025 09:47:29 -0700 Message-Id: <20250506164740.1317237-5-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250506164740.1317237-1-kan.liang@linux.intel.com> References: <20250506164740.1317237-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: silviazhao Cc: CodyYao-oc --- arch/x86/events/zhaoxin/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/x86/events/zhaoxin/core.c b/arch/x86/events/zhaoxin/core.c index 2fd9b0cf9a5e..49a5944fac63 100644 --- a/arch/x86/events/zhaoxin/core.c +++ b/arch/x86/events/zhaoxin/core.c @@ -397,8 +397,7 @@ static int zhaoxin_pmu_handle_irq(struct pt_regs *regs) if (!x86_perf_event_set_period(event)) continue; =20 - if (perf_event_overflow(event, &data, regs)) - x86_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } =20 /* --=20 2.38.1 From nobody Sat Feb 7 23:23:19 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 009122857C6; Tue, 6 May 2025 16:48:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550097; cv=none; b=gMgDl3V+Vye0UU6CnTr+t5NNBk6uCuRFfjFRtiuUqcxs/sVvl1vFTFB8d6eeEAcLfxZ/N0XG3RbzxUg+b5RbRl/3f+MsBzvp4NVfsSm/YvoAE4vW65crS5y59DBZfksqMEdQJxwT7GYOCThfW2ylHmW4/MtNo5/kGrOoIGqmEgE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550097; c=relaxed/simple; bh=VV8txqq1/dac9dNKChyvYqISNo6GE9wkTCjkP9SqIFc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=tvAU83cjl1vI9b8jJi4IL4eDt17gc/RUMVUGb/JnxcSRuwUrE+9uLusSMdbiqNIIuvIIGrOdD7SpUzMTczuRQKAY5ePott7GJbQgBo0WNqhGL1sJJ3L+IacVXf/c0LUi2+Hi5UjWCtiR1kYu9ji/C1+9vh6al3JFvdq4ViNkM5Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=D+HUk/X9; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="D+HUk/X9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746550096; x=1778086096; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=VV8txqq1/dac9dNKChyvYqISNo6GE9wkTCjkP9SqIFc=; b=D+HUk/X9Lx+PmXbObv7MLTix2AB10K9nvekV6pXG3lYfTDOlIiM6FcCb Hp47ZPu8C8GO73Du3Ij3oB5c++OsT0/Bb8VxPfCNGFQYLgK+XunpRCkon KfSaOO5v/cAaL3QAPyo97uMbZ8E8k8A5yWTrHRzHckrll7nvTGJbaL8mE EV+FgFIjhgeQYHsF0dlPiluQ17YyCUr5kG2Ap/SyLyA9sgRHE4MqHvcRx PD5pr4s1se9oOpzPlZ8QZH9k4z5icpX2KQrytqo+8gutOPU4+CoeqpUWS AjZXt2+YIJyClBoTa6DqcQvXl3+C5EjbruTus44gLn3oXb2eA8PurrVns A==; X-CSE-ConnectionGUID: eA0iz0mzRFyrv05iSu2I2g== X-CSE-MsgGUID: 4pdA+pByTnqscNDxcxzCNQ== X-IronPort-AV: E=McAfee;i="6700,10204,11425"; a="59595262" X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="59595262" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2025 09:48:15 -0700 X-CSE-ConnectionGUID: 9atE7ECQSVeYRU1cJ5Vacg== X-CSE-MsgGUID: JD9/R/cATQO8HgvGmKztKA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="135674862" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa007.fm.intel.com with ESMTP; 06 May 2025 09:48:15 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang , Athira Rajeev , Madhavan Srinivasan Subject: [RFC PATCH 05/15] powerpc/perf: Remove driver-specific throttle support Date: Tue, 6 May 2025 09:47:30 -0700 Message-Id: <20250506164740.1317237-6-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250506164740.1317237-1-kan.liang@linux.intel.com> References: <20250506164740.1317237-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: Athira Rajeev Cc: Madhavan Srinivasan --- arch/powerpc/perf/core-book3s.c | 6 ++---- arch/powerpc/perf/core-fsl-emb.c | 3 +-- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/perf/core-book3s.c b/arch/powerpc/perf/core-book3= s.c index 42ff4d167acc..8b0081441f85 100644 --- a/arch/powerpc/perf/core-book3s.c +++ b/arch/powerpc/perf/core-book3s.c @@ -2344,12 +2344,10 @@ static void record_and_restart(struct perf_event *e= vent, unsigned long val, ppmu->get_mem_weight(&data.weight.full, event->attr.sample_type); data.sample_flags |=3D PERF_SAMPLE_WEIGHT_TYPE; } - if (perf_event_overflow(event, &data, regs)) - power_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } else if (period) { /* Account for interrupt in case of invalid SIAR */ - if (perf_event_account_interrupt(event)) - power_pmu_stop(event, 0); + perf_event_account_interrupt(event); } } =20 diff --git a/arch/powerpc/perf/core-fsl-emb.c b/arch/powerpc/perf/core-fsl-= emb.c index d2ffcc7021c5..7120ab20cbfe 100644 --- a/arch/powerpc/perf/core-fsl-emb.c +++ b/arch/powerpc/perf/core-fsl-emb.c @@ -635,8 +635,7 @@ static void record_and_restart(struct perf_event *event= , unsigned long val, =20 perf_sample_data_init(&data, 0, last_period); =20 - if (perf_event_overflow(event, &data, regs)) - fsl_emb_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } } =20 --=20 2.38.1 From nobody Sat Feb 7 23:23:19 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63E322857E1; Tue, 6 May 2025 16:48:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550097; cv=none; b=HzBt6KVuJme/CRQDiq7gUdGji/ALvyAcVlvzjpeqbHOiR8ugdQZNt/TAFh4znkfN4bMhNc9fhipQaKSCAonEXXEORD9tUKFkdAk2qb5udVpqxGWICG/cGmmJqSa5QOJsWAKR5Ucjqvz6U81hhchKyCsviJOrugdSpHZ7A+/U1ew= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550097; c=relaxed/simple; bh=HSdv283f+P99zUV0yE0dYL7wNhVhUAdWxElvJ/afTp0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=naENiVNXaSx231N8zRD+plswm0ES6w3aBSJ/FQ60kSmW6j+FMtmnuk5vficfxkBOWTwxc13qCKB0+rOXTqXtFSHO4jvbblnmtg/JHYbQSzguyxi6GVGtWr1vFdzlguYdsCBnasUv5p13zE3oKoZSsUf3a8uyFaqzcYbxecKIOt4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=h77u3Pxu; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="h77u3Pxu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746550096; x=1778086096; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=HSdv283f+P99zUV0yE0dYL7wNhVhUAdWxElvJ/afTp0=; b=h77u3Pxu01OldGYcOoWXtwseVIjmPawE5YXqvw0iI4+S3SgzOxcFTW1Z YIcPo2aDoyPT0rSAzYlkOwVndiAG0yCg/88z5w5PGRu93zFmOa5+l6Thf 2kjCyoW7xOD5/zMI1F1w06W8tOkTMNxn6zXH8saUWBPffhSBt+uavKkQR YD4Df0ibf+3SgwuAub9qeevX2BIzf0Oa1qrn2nZWP0IZhULtsmtzdNgyJ iktql4wZymCb9DJcmIA4/xSnGIPLPnbIqcSc6yij5rH3Fl51ybUgNK6Ph ilIddNty8fXcVDooIALgci9lCY9SFX6xZSvqbb4D4sNzcuYXyc5ZGogyl A==; X-CSE-ConnectionGUID: 4xQGsFnnTqOhInleiPpwCw== X-CSE-MsgGUID: bbChFpHsRwizp82+an2lNw== X-IronPort-AV: E=McAfee;i="6700,10204,11425"; a="59595274" X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="59595274" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2025 09:48:16 -0700 X-CSE-ConnectionGUID: kYvKpvcdQwaiD2Yl5RvFXQ== X-CSE-MsgGUID: pDpv7dLlQWSnDJilYdxbwQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="135674866" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa007.fm.intel.com with ESMTP; 06 May 2025 09:48:15 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang Subject: [RFC PATCH 06/15] s390/perf: Remove driver-specific throttle support Date: Tue, 6 May 2025 09:47:31 -0700 Message-Id: <20250506164740.1317237-7-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250506164740.1317237-1-kan.liang@linux.intel.com> References: <20250506164740.1317237-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: Thomas Richter --- arch/s390/kernel/perf_cpum_cf.c | 2 -- arch/s390/kernel/perf_cpum_sf.c | 5 +---- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/arch/s390/kernel/perf_cpum_cf.c b/arch/s390/kernel/perf_cpum_c= f.c index e657fad7e376..6a262e198e35 100644 --- a/arch/s390/kernel/perf_cpum_cf.c +++ b/arch/s390/kernel/perf_cpum_cf.c @@ -980,8 +980,6 @@ static int cfdiag_push_sample(struct perf_event *event, } =20 overflow =3D perf_event_overflow(event, &data, ®s); - if (overflow) - event->pmu->stop(event, 0); =20 perf_event_update_userpage(event); return overflow; diff --git a/arch/s390/kernel/perf_cpum_sf.c b/arch/s390/kernel/perf_cpum_s= f.c index ad22799d8a7d..91469401f2c9 100644 --- a/arch/s390/kernel/perf_cpum_sf.c +++ b/arch/s390/kernel/perf_cpum_sf.c @@ -1072,10 +1072,7 @@ static int perf_push_sample(struct perf_event *event, overflow =3D 0; if (perf_event_exclude(event, ®s, sde_regs)) goto out; - if (perf_event_overflow(event, &data, ®s)) { - overflow =3D 1; - event->pmu->stop(event, 0); - } + overflow =3D perf_event_overflow(event, &data, ®s); perf_event_update_userpage(event); out: return overflow; --=20 2.38.1 From nobody Sat Feb 7 23:23:19 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA79A28640E; Tue, 6 May 2025 16:48:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550099; cv=none; b=MAfNqVjYjfal37yZXbesbhYJtCdNAsZMztw5bLXazpPOx49z4DhFpE7GJT2GfM7KOW7/uQoUEhlu4bESbrzDvHr0us8xIMsQsAjSbCqq8U8Bel4rM/TDD0C99bXqcbKs4Hyd+27N21cZhN59Bpkl8naC6+t7ocQ9xBNXHG1iJyQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550099; c=relaxed/simple; bh=niFjfiqBff3Sw+QM/hZYvrfOZbyI/nWGDj/epacEVR0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=t9T0rAjSK+GFtbFlN+AsskTjWH4Yo6dgdUa2CjUW7GWQRH9ZeTM+kb9TFkA5fIlc1tE2XQTMkzYLJuLvZu84ZXOhkcW9mvDjuInyWDU2JPtSbmseHbAPcHaBEg1PGMxvwO7WC1NO90VjRbbf1oD/U9vCKL0RvJzyfT8Xm4riXEU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=MBh/46W4; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="MBh/46W4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746550098; x=1778086098; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=niFjfiqBff3Sw+QM/hZYvrfOZbyI/nWGDj/epacEVR0=; b=MBh/46W40ufo7Ahxis0ISlbg5ytV0DdCmyXm8uJTJhEAImetJ1OPdXJ3 aN8i0uvi+/TqHbGa0W5Dp7WCCwfqSmxJ4Ofo0P9dp8NneIEHdGm2a2+Ly 57uPlhFQ0yUAtddtFZnm2b1ELaIn0yBZ1JDghu58eZO97p/tdjAX7B8zg bTVtT/azTdQaaA5rAbIARdzhoiDgGn4LfogIL2TEwdxgGwarAFmpl9KUx Z+q6eDdDAnxaZzRLD2NjbQ0Z8NDoCXSdTfyb5VB5znBMcYn+Toy7c8D/f 6Swx5EM1mVkybqLkexsRFTJine0JBX4kb/cNlnmdyRwI9AR2F2OtHtUbX Q==; X-CSE-ConnectionGUID: Nt55YKsuSnCcPT8/p2yA2Q== X-CSE-MsgGUID: fOBcvfSoQyOqcp3wJQJWtw== X-IronPort-AV: E=McAfee;i="6700,10204,11425"; a="59595282" X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="59595282" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2025 09:48:17 -0700 X-CSE-ConnectionGUID: py3ST6METdqMUXLjGrdM7A== X-CSE-MsgGUID: qXGlWkaVTKOJ+TzHrw9P6Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="135674871" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa007.fm.intel.com with ESMTP; 06 May 2025 09:48:16 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang , Rob Herring , Vincenzo Frascino , Will Deacon Subject: [RFC PATCH 07/15] perf/arm: Remove driver-specific throttle support Date: Tue, 6 May 2025 09:47:32 -0700 Message-Id: <20250506164740.1317237-8-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250506164740.1317237-1-kan.liang@linux.intel.com> References: <20250506164740.1317237-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: Mark Rutland Cc: Rob Herring (Arm) Cc: Vincenzo Frascino Cc: Will Deacon --- drivers/perf/arm_pmuv3.c | 3 +-- drivers/perf/arm_v6_pmu.c | 3 +-- drivers/perf/arm_v7_pmu.c | 3 +-- drivers/perf/arm_xscale_pmu.c | 6 ++---- 4 files changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/perf/arm_pmuv3.c b/drivers/perf/arm_pmuv3.c index e506d59654e7..3db9f4ed17e8 100644 --- a/drivers/perf/arm_pmuv3.c +++ b/drivers/perf/arm_pmuv3.c @@ -887,8 +887,7 @@ static irqreturn_t armv8pmu_handle_irq(struct arm_pmu *= cpu_pmu) * an irq_work which will be taken care of in the handling of * IPI_IRQ_WORK. */ - if (perf_event_overflow(event, &data, regs)) - cpu_pmu->disable(event); + perf_event_overflow(event, &data, regs); } armv8pmu_start(cpu_pmu); =20 diff --git a/drivers/perf/arm_v6_pmu.c b/drivers/perf/arm_v6_pmu.c index b09615bb2bb2..7cb12c8e06c7 100644 --- a/drivers/perf/arm_v6_pmu.c +++ b/drivers/perf/arm_v6_pmu.c @@ -276,8 +276,7 @@ armv6pmu_handle_irq(struct arm_pmu *cpu_pmu) if (!armpmu_event_set_period(event)) continue; =20 - if (perf_event_overflow(event, &data, regs)) - cpu_pmu->disable(event); + perf_event_overflow(event, &data, regs); } =20 /* diff --git a/drivers/perf/arm_v7_pmu.c b/drivers/perf/arm_v7_pmu.c index 17831e1920bd..a1e438101114 100644 --- a/drivers/perf/arm_v7_pmu.c +++ b/drivers/perf/arm_v7_pmu.c @@ -930,8 +930,7 @@ static irqreturn_t armv7pmu_handle_irq(struct arm_pmu *= cpu_pmu) if (!armpmu_event_set_period(event)) continue; =20 - if (perf_event_overflow(event, &data, regs)) - cpu_pmu->disable(event); + perf_event_overflow(event, &data, regs); } =20 /* diff --git a/drivers/perf/arm_xscale_pmu.c b/drivers/perf/arm_xscale_pmu.c index 638fea9b1263..c2ac41dd9e19 100644 --- a/drivers/perf/arm_xscale_pmu.c +++ b/drivers/perf/arm_xscale_pmu.c @@ -186,8 +186,7 @@ xscale1pmu_handle_irq(struct arm_pmu *cpu_pmu) if (!armpmu_event_set_period(event)) continue; =20 - if (perf_event_overflow(event, &data, regs)) - cpu_pmu->disable(event); + perf_event_overflow(event, &data, regs); } =20 irq_work_run(); @@ -519,8 +518,7 @@ xscale2pmu_handle_irq(struct arm_pmu *cpu_pmu) if (!armpmu_event_set_period(event)) continue; =20 - if (perf_event_overflow(event, &data, regs)) - cpu_pmu->disable(event); + perf_event_overflow(event, &data, regs); } =20 irq_work_run(); --=20 2.38.1 From nobody Sat Feb 7 23:23:19 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1BBF28641F; Tue, 6 May 2025 16:48:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550099; cv=none; b=s7iQzCMHtHIpV4s3qeZ3ZjSsqUpjrySxFiWIyUlcB6kE8rYvwnMOcME4UsdXDgh6e3FL8kfF+bmsy3tFDzC4dTGMKY2ekBfBX+nypjVn4q69LwhZspDK2XN8dno2tk5fFc3T0QhHjnDBdDs10X9BPdd5dpD3Ph9ogwtt+qCdrsY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550099; c=relaxed/simple; bh=jtzi1Dswis+7E8s5xuD4Q5RcegCZpv4/8lL3qUWjHa0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=kPWI0HXUaHwLN/O7fsuQmDWxq0nll3HryGC8pWSFd0QsVRVuLPu7szF6dydZkukfOPJE92ZNJutkgaPRqnZI17Y3zdEBxYMNWDrPytH775nuB90V0Y5xX5YeK3h/EwuM1/obiNwwGDYU0C1ltR1x4PoDSkiBoiDXpMUsykBQA4w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=bW/0+qy+; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="bW/0+qy+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746550098; x=1778086098; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jtzi1Dswis+7E8s5xuD4Q5RcegCZpv4/8lL3qUWjHa0=; b=bW/0+qy+TtCEMGFvFGSK48ku+ca2oYJWafYMAb3XKFSjGa3gBXnE6r+s xoAXJrOZr/iU6wjbteY6k1ksspq13Q6zE/FLEqp9ECuQmXN/L8lcKz90c hdxPYROqas/7Orfphxh8GeP+cidPcxsAtv2Y0GRcyS8eritrdGkLhJTe+ s66kgCpxUNwOAmHrJuIplLYjaGwQ+ieVGTaOPmlgMBBg0chtacV9Sapxq jurFA8qjo1cE6Fk1IWAPM1/ZKgGyliXrumcOzsxue2brluktMIvFIocZL DAxz5mgh+5tLfj8D6/JChcLystF6bYi/KPT7piuvosHGTSHsZqXNa5auQ A==; X-CSE-ConnectionGUID: 13Go7aH4SuOk15RksTsESA== X-CSE-MsgGUID: qt9ZVx5IQIucORf3sUKPDA== X-IronPort-AV: E=McAfee;i="6700,10204,11425"; a="59595291" X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="59595291" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2025 09:48:17 -0700 X-CSE-ConnectionGUID: 0NTosvbcRUu9FW/MC+fc9Q== X-CSE-MsgGUID: TehkUsDYTma9onAXHpI8Mg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="135674877" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa007.fm.intel.com with ESMTP; 06 May 2025 09:48:17 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang , Oliver Upton Subject: [RFC PATCH 08/15] perf/apple_m1: Remove driver-specific throttle support Date: Tue, 6 May 2025 09:47:33 -0700 Message-Id: <20250506164740.1317237-9-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250506164740.1317237-1-kan.liang@linux.intel.com> References: <20250506164740.1317237-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: Oliver Upton --- drivers/perf/apple_m1_cpu_pmu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/perf/apple_m1_cpu_pmu.c b/drivers/perf/apple_m1_cpu_pm= u.c index df9a28ba69dc..81b6f1a62349 100644 --- a/drivers/perf/apple_m1_cpu_pmu.c +++ b/drivers/perf/apple_m1_cpu_pmu.c @@ -474,8 +474,7 @@ static irqreturn_t m1_pmu_handle_irq(struct arm_pmu *cp= u_pmu) if (!armpmu_event_set_period(event)) continue; =20 - if (perf_event_overflow(event, &data, regs)) - m1_pmu_disable_event(event); + perf_event_overflow(event, &data, regs); } =20 cpu_pmu->start(cpu_pmu); --=20 2.38.1 From nobody Sat Feb 7 23:23:19 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98038286882; Tue, 6 May 2025 16:48:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550100; cv=none; b=Q6zrs0GG+njeXXbY20WbbxWeJzTcJEZd5HfihYYaN0HQj+ourJvJG5/SVEuaFQCR2SeDUezPxAmAfKbbhlxRchHj8lLZzeNu42GQj2ZE59lqb7mpWQ7iFJ6ZfUuJxLwvvdmvo+h7sQIkFBIpQbTShdwSje7jQ6R+DIcn/KzmfTw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550100; c=relaxed/simple; bh=NhpvDIFF3RCGCMgFlua6GwCE5WabCIdXhqFSclRzhlI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Z+/yydMPnEeod2xXzt+hOIW0KAwIcHy9TWqogmI8VRg8uLeN7HVvxJlabMDvyMY1KsQFfxUOXtbDtMNiohaKUn2Ormsr2n54Ul9pvUd2IpaQUA0NXoTWcbyEvxS2L09sn3BqbPAyCxof+6CDGuyyZAPGPheJnpKil+l3E25L9WY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=WpEmjktg; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="WpEmjktg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746550099; x=1778086099; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=NhpvDIFF3RCGCMgFlua6GwCE5WabCIdXhqFSclRzhlI=; b=WpEmjktg0kb6+NTNDQ6ru9jCfh/akuRPpeIrAfzjhMpBuuyc8y7Evsyy pxNeK9ZsS4h2JgBamvDJB+zdByMqZEFfOKkq1OlPOwzvDFhxFGZ0R2qKu 9+oPyYOO+jjVeMJEUf9CeaUzMtesoOECW6xooXa0WB9EHZ6C4ynrWiuj4 trOkozLk/ST/Qa1u7w0z+sd4TSi1V7IDy/ZzuBNpMutDk0re0iqQSKEUd 2HYeKYePZoPDni2EiciN9B1KCghwtQ9wSpREavsc0LwR6NUATpC1w2Un7 wmNUwLiA1YOLDC3Z1AkWXoui9Q+2uxVLpqv4OmNMvkoi4O0I1Um+kki/4 w==; X-CSE-ConnectionGUID: ZfYFRmwVT0uyzF0tF6P3UQ== X-CSE-MsgGUID: bHpt9DRjRXuCeJ5TN/MKlw== X-IronPort-AV: E=McAfee;i="6700,10204,11425"; a="59595300" X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="59595300" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2025 09:48:18 -0700 X-CSE-ConnectionGUID: 7PwS+b2gSty16kOUsenMog== X-CSE-MsgGUID: voF3L+7zSRiBnSGzrla8vQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="135674881" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa007.fm.intel.com with ESMTP; 06 May 2025 09:48:18 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang , linux-alpha@vger.kernel.org Subject: [RFC PATCH 09/15] alpha/perf: Remove driver-specific throttle support Date: Tue, 6 May 2025 09:47:34 -0700 Message-Id: <20250506164740.1317237-10-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250506164740.1317237-1-kan.liang@linux.intel.com> References: <20250506164740.1317237-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: linux-alpha@vger.kernel.org --- arch/alpha/kernel/perf_event.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/alpha/kernel/perf_event.c b/arch/alpha/kernel/perf_event.c index 1f0eb4f25c0f..a3eaab094ece 100644 --- a/arch/alpha/kernel/perf_event.c +++ b/arch/alpha/kernel/perf_event.c @@ -852,14 +852,9 @@ static void alpha_perf_event_irq_handler(unsigned long= la_ptr, alpha_perf_event_update(event, hwc, idx, alpha_pmu->pmc_max_period[idx]+1= ); perf_sample_data_init(&data, 0, hwc->last_period); =20 - if (alpha_perf_event_set_period(event, hwc, idx)) { - if (perf_event_overflow(event, &data, regs)) { - /* Interrupts coming too quickly; "throttle" the - * counter, i.e., disable it for a little while. - */ - alpha_pmu_stop(event, 0); - } - } + if (alpha_perf_event_set_period(event, hwc, idx)) + perf_event_overflow(event, &data, regs); + wrperfmon(PERFMON_CMD_ENABLE, cpuc->idx_mask); =20 return; --=20 2.38.1 From nobody Sat Feb 7 23:23:19 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D93A286D5A; Tue, 6 May 2025 16:48:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550102; cv=none; b=VDr8xWq25vavXl7c8JarQHxg6qxZWwszO/rfeb9jKoNWTxjTkvOyuUPTQp25r1gqFV2zPzz4sCPjyLFpt+Z6SXZlSBm6fzG7WkI9Pa8PdnZjLmbMlZV/6ukNCvytEp2/Sb43Sks9/fV+iv0mJYNK/jhdN5LfiX4jPTfiM4Y8p9A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550102; c=relaxed/simple; bh=0mKYVrYQyC2W8elMimVQZxsUfveK3GJxU+vrnQYmQLQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lJxMb0TY8pTL2I5HggZMRlr2U/PdJ5gHrfn6lZL97Tl3IKdhe5HaSpmnVPkRhfbkBGturvMdBxKU386iOmX4Ie2tQwRRXVCbBXcFFb5LLjfZ1kgLcj90qrpjTnnC+IjzX/j6myCBTDFxWtwfq0f4mtrejY8UjTePa6n/lNN6GZc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=JtQYD7KW; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="JtQYD7KW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746550100; x=1778086100; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0mKYVrYQyC2W8elMimVQZxsUfveK3GJxU+vrnQYmQLQ=; b=JtQYD7KW7cavEt9sU/Vwzcbf2KDGXGV9iuEfAw4UFxzUPrA39tlAeTd1 cpOeJfHUCkwOSeCiwLEAoY0QWlujN5CCx84BIZHorTGqpZSvWdXJP99Ys ZDvdmiTmITIKWPRpkTDaG1FH+Lsx5qcxgUq64Lt6qlZcbyeDBpbZGVuA7 1EVAxuRNs7+QKa4S7l2aCFIuukPHFGk0TVcPiMZY/8xGuAt0mcQxEDa52 WrzYrzMyJHyOQGN+nXXHNo/HO7V3XJBttD/DERgaH6VvuhI9AwRJV1XLf rIW5XpC/d4ce6hWPafssC8K5DLbJoUTQGTn3HbaYWUcYJyzCjYTdmlOoj Q==; X-CSE-ConnectionGUID: 49i1oNL1QHGFkIfEkx3Ymw== X-CSE-MsgGUID: ic/Cy9WXRGqq/WxpI9WDHw== X-IronPort-AV: E=McAfee;i="6700,10204,11425"; a="59595307" X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="59595307" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2025 09:48:20 -0700 X-CSE-ConnectionGUID: ZCUbzolUTCacK7kXTNKhsw== X-CSE-MsgGUID: OzRrGi+rRiGr5rEoFMTNWA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="135674885" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa007.fm.intel.com with ESMTP; 06 May 2025 09:48:18 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang , Vineet Gupta Subject: [RFC PATCH 10/15] arc/perf: Remove driver-specific throttle support Date: Tue, 6 May 2025 09:47:35 -0700 Message-Id: <20250506164740.1317237-11-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250506164740.1317237-1-kan.liang@linux.intel.com> References: <20250506164740.1317237-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: Vineet Gupta --- arch/arc/kernel/perf_event.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arc/kernel/perf_event.c b/arch/arc/kernel/perf_event.c index 6e5a651cd75c..ed6d4f0cd621 100644 --- a/arch/arc/kernel/perf_event.c +++ b/arch/arc/kernel/perf_event.c @@ -599,10 +599,8 @@ static irqreturn_t arc_pmu_intr(int irq, void *dev) =20 arc_perf_event_update(event, &event->hw, event->hw.idx); perf_sample_data_init(&data, 0, hwc->last_period); - if (arc_pmu_event_set_period(event)) { - if (perf_event_overflow(event, &data, regs)) - arc_pmu_stop(event, 0); - } + if (arc_pmu_event_set_period(event)) + perf_event_overflow(event, &data, regs); =20 active_ints &=3D ~BIT(idx); } while (active_ints); --=20 2.38.1 From nobody Sat Feb 7 23:23:19 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0E10286D6B; Tue, 6 May 2025 16:48:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550102; cv=none; b=DoZ5Zs/41KwSyiN0QvZc5jrtLPRB554A1FTqoyllQq7hLsrCxER6ZMb2jDXNYKSCrIpjWcJSxIBVBnqHwgFNBQJ3kMDzgGGhBB1WU95zKqkfOhcK6NVRLrI0eiVprN2LZeE2JSX0srF+tZfRdqGkY01sy+PIh51fGS+KdNh8uwc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550102; c=relaxed/simple; bh=V6nXz/yCtJ1VxaLqKn5i3FS20UppU9XH8lr/vOeoYWM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PVybmS2bv7l5eBA6cjYIHPreqtmPd++3BCfmklo7v4KeqbCkzUbE6xYpLedIwnS5O6IEeF8np3owY9sY4V78DHVrkydj6UIMjNFJno69W2ER3hYTjXKYMPSqkr9vdZVkbaZmaG2G+Z4datq5aI+EJs1xQfRhJ7py/Lwhmr0tVCE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=QDU+yITE; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="QDU+yITE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746550101; x=1778086101; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=V6nXz/yCtJ1VxaLqKn5i3FS20UppU9XH8lr/vOeoYWM=; b=QDU+yITEnpa+XiGj7SahE+Ipa5CgmppSFPEhB4CsLox1aas9ZxMD0b85 wX3Z7ImbrIBnITAQnc1lI+rXaf4ID92wRYoLxcT9sdmPD95rC3UoLVZsN 2Npk+SNXF+NQCrdbiBmatcZzRgzcvEny5fpPXEBx7TEl+tp8rqQX6VCjQ KRJ+IUHUPRUIad/7i3dvQVl1SM/kZ9058seu20n/l9o7GAdvO6TUARmS0 errf/qBXoygJejtwDoFqT9rsubHRBGB0ax/3fQQMJUQxUQVEOoqRCH55p 9ZxIRvm5WjYoODtqTdHrydYHck3mdlUQj6vGKHSrmy93rfmxY7Rol1Czl w==; X-CSE-ConnectionGUID: vs5TI4J6T5O5VoWxZt1/1g== X-CSE-MsgGUID: dU67HPt/SqOfJ78+AhQQ7A== X-IronPort-AV: E=McAfee;i="6700,10204,11425"; a="59595315" X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="59595315" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2025 09:48:20 -0700 X-CSE-ConnectionGUID: 17+2+htoRuGk3kDJ2su+dA== X-CSE-MsgGUID: uJn8WK7cQ/KRfwKa1IlySw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="135674890" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa007.fm.intel.com with ESMTP; 06 May 2025 09:48:20 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang , Mao Han , Guo Ren Subject: [RFC PATCH 11/15] csky/perf: Remove driver-specific throttle support Date: Tue, 6 May 2025 09:47:36 -0700 Message-Id: <20250506164740.1317237-12-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250506164740.1317237-1-kan.liang@linux.intel.com> References: <20250506164740.1317237-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: Mao Han Cc: Guo Ren --- arch/csky/kernel/perf_event.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/csky/kernel/perf_event.c b/arch/csky/kernel/perf_event.c index e5f18420ce64..e0a36acd265b 100644 --- a/arch/csky/kernel/perf_event.c +++ b/arch/csky/kernel/perf_event.c @@ -1139,8 +1139,7 @@ static irqreturn_t csky_pmu_handle_irq(int irq_num, v= oid *dev) perf_sample_data_init(&data, 0, hwc->last_period); csky_pmu_event_set_period(event); =20 - if (perf_event_overflow(event, &data, regs)) - csky_pmu_stop_event(event); + perf_event_overflow(event, &data, regs); } =20 csky_pmu_enable(&csky_pmu.pmu); --=20 2.38.1 From nobody Sat Feb 7 23:23:19 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1C3D2874F1; Tue, 6 May 2025 16:48:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550103; cv=none; b=byCOsRqsBSPSpN2LT9554v0PawO9fbRzmD1l3HhswaX3LgjvW1eB2uuqtajWaXR4feV+u17Qe9Fdx4r/LoGCjBfw6qLfLJFROl9kTwBGqS93cSCd//KMrMkcB4XulVavFxZzMqKuCLJM32lqGWqzjOKKjqNRUHuZuCJjE2iSCtM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550103; c=relaxed/simple; bh=e6ZGtoFS3wb4lZcFgyi/mMNsez4qDnJTe8sAQRVY/KA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=F6zS4g1TEOqbJEHylkzBlMV3NUYsQ381rw/q1wJnDxnRwcQh4Ueu9X45CaJ4NDQODYmtqQsCjUVngR6z0Gmu0s0kune39Br6PqrSFEVpb0i9+oRS7MSuT+HiIoBITW0+UaiulOLVm9LYPHg08Z7kLN26kWJCQ57+5DlhPz5PIj8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ZFlJ7WgG; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ZFlJ7WgG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746550102; x=1778086102; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=e6ZGtoFS3wb4lZcFgyi/mMNsez4qDnJTe8sAQRVY/KA=; b=ZFlJ7WgGWVAIIj90eBNmB8p/nUYCwifdrfbPWeSA/VhnwZ+mHTPLACOG lXXXXSwRaA/DWDNilE90icdh6zLG7NJlE0yWDC3H3E4D/RPlP9RncnLC5 edho5UcTOuTSHk8rrl65OfTFeaoeGxgNcDwXnfC4eKXCPupX8ktuG696m Z+ayMifFV12wMZXXCeO4cquKqbDdkEbd1BY4M7Nr9/uvpH2TLsxPgh2RE +gHzGeXZ2pXwWj0G0L1HhIPG0wpCTloIxUb9xlnyAF3fj0sCWAHJBfG81 GUpSsWmiOvNu7Kl/6lYrK99oY9N6hJGU9VusI3oYCbQroEn6ok2LiFuKJ w==; X-CSE-ConnectionGUID: is+xYLB4TXi89NwDHIhhPQ== X-CSE-MsgGUID: Gxyb8V/xTC+RIeZYv5jfXQ== X-IronPort-AV: E=McAfee;i="6700,10204,11425"; a="59595323" X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="59595323" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2025 09:48:21 -0700 X-CSE-ConnectionGUID: gY61lUd7QIayNdAhRfPncw== X-CSE-MsgGUID: tYrTELXYQ0yDCZtkqHR44Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="135674893" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa007.fm.intel.com with ESMTP; 06 May 2025 09:48:20 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang , Bibo Mao , Huacai Chen Subject: [RFC PATCH 12/15] loongarch/perf: Remove driver-specific throttle support Date: Tue, 6 May 2025 09:47:37 -0700 Message-Id: <20250506164740.1317237-13-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250506164740.1317237-1-kan.liang@linux.intel.com> References: <20250506164740.1317237-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: Bibo Mao Cc: Huacai Chen --- arch/loongarch/kernel/perf_event.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/loongarch/kernel/perf_event.c b/arch/loongarch/kernel/per= f_event.c index f86a4b838dd7..8ad098703488 100644 --- a/arch/loongarch/kernel/perf_event.c +++ b/arch/loongarch/kernel/perf_event.c @@ -479,8 +479,7 @@ static void handle_associated_event(struct cpu_hw_event= s *cpuc, int idx, if (!loongarch_pmu_event_set_period(event, hwc, idx)) return; =20 - if (perf_event_overflow(event, data, regs)) - loongarch_pmu_disable_event(idx); + perf_event_overflow(event, data, regs); } =20 static irqreturn_t pmu_handle_irq(int irq, void *dev) --=20 2.38.1 From nobody Sat Feb 7 23:23:19 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 326472874FB; Tue, 6 May 2025 16:48:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550104; cv=none; b=tOCcpb1VGpmwMnQvKAmmMZv7lIFtUabZrYEnAAu6DAg0SxHiDbFYs4RkPAn2gJlka2ms4BeLikRSXfO+u7LHclPtXDkS99fTkQYE/6m7SSmf3HF/a1VVCDs2x9Ek83ZN/vZoTbDehzvA8S5T3Gt493Q3qHefqByOwuiMQ7b+kWU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550104; c=relaxed/simple; bh=B8QsEFV1XiWjwO1syGoIhQQIyeZx4cI+2rXT69sma5A=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FonG6X2h21iSNy9WRZur78HBH+a1p0UGfkH7q1xhlomtJ4E93+IIa+JqkB33kfrS4jvsPzVuzLiKImnc+CFBjdCTeTIr+hehNAKWhw9/klT2Cwt2paafgcPN85QvBr8KBGfvOG6mywEQJJH8E1qwrUUKHO5LXOfslXcOMRXP0uY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Bd0sSzbL; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Bd0sSzbL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746550102; x=1778086102; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=B8QsEFV1XiWjwO1syGoIhQQIyeZx4cI+2rXT69sma5A=; b=Bd0sSzbLP6rnjuC8HkxCyoSTnh20gj/uiD3hwk8POVWm36Gc5oDsL/c5 0EcZyWr5PQQgIBCGFN1dAQPa/3iwCgVMCFvNKP3HsGNSSCXqo25i8SMDa bmdRgDfmPXH7ZOEz4vytSEXIJOqgeePJRAseDHNyGJmBFeGjGj0xfuy/7 FHd1YFkVnCvoio6GrSYx0KRDVVG4YVQF3E9nFnrM45G10AJinWVGUMi61 gVdGiR+p9ZJUOk4LwxvW8zRNoV6lWockUhzYpBmAEJa2mC8WGheo2oJ5D VVHuELnyC23toEdgJgoL6CJ6bU0/YqIa/JNGvNFduocSsTJRSObpMzamY g==; X-CSE-ConnectionGUID: MAqiBhLvT6uzHNhdP207Rw== X-CSE-MsgGUID: EbkXbxFhRe+5nGPE1f0yYw== X-IronPort-AV: E=McAfee;i="6700,10204,11425"; a="59595332" X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="59595332" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2025 09:48:22 -0700 X-CSE-ConnectionGUID: ON9dzfoMQ3q3ixbCJ6PDkg== X-CSE-MsgGUID: WiO49QYWQWayAOM/A83GCQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="135674896" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa007.fm.intel.com with ESMTP; 06 May 2025 09:48:21 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang , "David S . Miller" Subject: [RFC PATCH 13/15] sparc/perf: Remove driver-specific throttle support Date: Tue, 6 May 2025 09:47:38 -0700 Message-Id: <20250506164740.1317237-14-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250506164740.1317237-1-kan.liang@linux.intel.com> References: <20250506164740.1317237-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: David S. Miller --- arch/sparc/kernel/perf_event.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/sparc/kernel/perf_event.c b/arch/sparc/kernel/perf_event.c index f02a283a8e8f..cae4d33002a5 100644 --- a/arch/sparc/kernel/perf_event.c +++ b/arch/sparc/kernel/perf_event.c @@ -1668,8 +1668,7 @@ static int __kprobes perf_event_nmi_handler(struct no= tifier_block *self, if (!sparc_perf_event_set_period(event, hwc, idx)) continue; =20 - if (perf_event_overflow(event, &data, regs)) - sparc_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } =20 finish_clock =3D sched_clock(); --=20 2.38.1 From nobody Sat Feb 7 23:23:19 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F21F928751A; Tue, 6 May 2025 16:48:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550104; cv=none; b=FkDRmmAURWtZbhhUwJLKwf0YXe2NK0GK/U4duMfkFLHromQeyUtRXM0Nfi+7eMqiwWk/cDFKMalBQoIu6isyRyoP51iQbjwh9Xb3kFWDkZ7LcQE/h6APjKluYGLKa/4RuQcOotD7nPUAuOeRnzdNdSzfEQbSuFiozBEhm39p000= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550104; c=relaxed/simple; bh=4mpX1YmJsKhiwoN8Qz2qbRy/2tQafGlzgwM0Wm9azSo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=dVWhynAWt0ogKqX0KZ/BVCmIZe4xWmURWKIHsIrMsRMBj04KmknWW5XyymzVy41H7EUMEDOGFhvMVfML2JlyiVRxrB7RvNcZvy+EpFuV2v9rWkoeXbyFDstvQ0fZYlW2EXisKNR+lcfthj7Bjav+f2wzj2qL0chLJwdyK+qhmjY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=isnW4O+e; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="isnW4O+e" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746550103; x=1778086103; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=4mpX1YmJsKhiwoN8Qz2qbRy/2tQafGlzgwM0Wm9azSo=; b=isnW4O+eQweU3B7x9FnMHUrrwxNWPDhE9XVBK7aTPp732rmOSqD1XPcD yH6q7eDWVPuJL4C5mHm9XyGzFGLdatnIN0hnRA2UpRWQCBkf+Dhlhsom+ BbfJSU5VzHodc+ivKJrZsRY6rp0jjiUyrSdtg1I+yvc7Mc76ZkaRuUZ67 dOs6/CaVNFLTWyplm35tsExfq51k9Z4Clr9ORxvJgUJOotdmo+JhDw+VF HY/haMDysLqcmQ8ry/tXfZacdG9apBRCkaRJw9qtkuVSO6g31fIJ6NIdG 1YPKnySYjIXMPO4KfmJjUAQgLOINqZI6KnODXpjUgaQoSg0VdsBONuYfu A==; X-CSE-ConnectionGUID: vNhQZMsWQGS4aWmnMXgn+A== X-CSE-MsgGUID: wsObRy7CQNS6q+bZpqzxgg== X-IronPort-AV: E=McAfee;i="6700,10204,11425"; a="59595341" X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="59595341" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2025 09:48:22 -0700 X-CSE-ConnectionGUID: MnshmrgQQDq73z9YdAaT8Q== X-CSE-MsgGUID: wLLBYeL+TkS20ZXm+AXRqg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="135674904" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa007.fm.intel.com with ESMTP; 06 May 2025 09:48:22 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang , Max Filippov Subject: [RFC PATCH 14/15] xtensa/perf: Remove driver-specific throttle support Date: Tue, 6 May 2025 09:47:39 -0700 Message-Id: <20250506164740.1317237-15-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250506164740.1317237-1-kan.liang@linux.intel.com> References: <20250506164740.1317237-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: Max Filippov Reviewed-by: Max Filippov --- arch/xtensa/kernel/perf_event.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/xtensa/kernel/perf_event.c b/arch/xtensa/kernel/perf_even= t.c index 183618090d05..223f1d452310 100644 --- a/arch/xtensa/kernel/perf_event.c +++ b/arch/xtensa/kernel/perf_event.c @@ -388,8 +388,7 @@ irqreturn_t xtensa_pmu_irq_handler(int irq, void *dev_i= d) struct pt_regs *regs =3D get_irq_regs(); =20 perf_sample_data_init(&data, 0, last_period); - if (perf_event_overflow(event, &data, regs)) - xtensa_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } =20 rc =3D IRQ_HANDLED; --=20 2.38.1 From nobody Sat Feb 7 23:23:19 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 216E72882C7; Tue, 6 May 2025 16:48:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550105; cv=none; b=erMQR43RHnEMpodyXOsSmB9vnhn8fXODSZzZxC3bni8S7DinQ/0f5q0Bsz8rY8L50zou02RZZtn/0L3Npe2YBwCQqHxyP/7zTFF60KU+g9NJsK2JiRAXUnX5gDLt16tEHICWB2l7CXFunDpLJzMXVpFeO6U3h9+ej8L9E9/ZZek= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746550105; c=relaxed/simple; bh=JiwvHEAYw1T9QTlO99VilV21kD4dORO/tZIjOkKmDDQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=J3Ml1kZOX8fbJl7BVktEMaopNf8cBVRDGgyZyVHvyfQknhyyHYGISVFttcgIVJ1HjwF4q49X8e7dI5Dug5UNRRyBLCRNCv2Uf99Iqo/arN8E2W6c1yptfcM9vJm9mbdpWUdV5rrQ/RuSZNeWY1+GWDPbzl5I3WJ1+kO4XbzluU4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=RS/RhSox; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="RS/RhSox" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746550104; x=1778086104; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=JiwvHEAYw1T9QTlO99VilV21kD4dORO/tZIjOkKmDDQ=; b=RS/RhSoxZREfEVH7cUixDkgKqLbEBAgivTDTvSwSQ2ARnHxnD5HBt+Y9 Tr6p/vVXwD5MaxoMiRfIorWBGCD2LZQtDBG/1GKUDGkfhcojniFd4sRMb dcPdMyFg/6S16YLfk/H7gEPyP8d75cM5Ho58mdOsabS0zncYCps2/ulWF 1UjvMOx4QmWoQBufO+O02TTgFHRgGNcnQOHfp/IiiLhmdq/pclQfjj23Q nWlgM+UuESR/oGmn2uYAKLnwS+pLVW3hvbgKfFu0/+bpJ64WlT6HjIdw/ 9KFkCQb6Lxpa+X8Mat/hIRFPFAkiYrEAI+50rh5LMS6ZYWFeneGSYfgZ7 w==; X-CSE-ConnectionGUID: SO49iDrxTEyakXWkNbem6A== X-CSE-MsgGUID: g21pdYN0S9eYc2z5u3+xzg== X-IronPort-AV: E=McAfee;i="6700,10204,11425"; a="59595349" X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="59595349" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2025 09:48:23 -0700 X-CSE-ConnectionGUID: PTJ6Lt5rQda926yXGjd9SQ== X-CSE-MsgGUID: WFzlB+Z+ROWlvkmzdTUuRw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="135674908" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa007.fm.intel.com with ESMTP; 06 May 2025 09:48:23 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang , Thomas Bogendoerfer Subject: [RFC PATCH 15/15] mips/perf: Remove driver-specific throttle support Date: Tue, 6 May 2025 09:47:40 -0700 Message-Id: <20250506164740.1317237-16-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250506164740.1317237-1-kan.liang@linux.intel.com> References: <20250506164740.1317237-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: Thomas Bogendoerfer --- arch/mips/kernel/perf_event_mipsxx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/mips/kernel/perf_event_mipsxx.c b/arch/mips/kernel/perf_e= vent_mipsxx.c index c4d6b09136b1..196a070349b0 100644 --- a/arch/mips/kernel/perf_event_mipsxx.c +++ b/arch/mips/kernel/perf_event_mipsxx.c @@ -791,8 +791,7 @@ static void handle_associated_event(struct cpu_hw_event= s *cpuc, if (!mipspmu_event_set_period(event, hwc, idx)) return; =20 - if (perf_event_overflow(event, data, regs)) - mipsxx_pmu_disable_event(idx); + perf_event_overflow(event, data, regs); } =20 =20 --=20 2.38.1