From nobody Sat Feb 7 23:23:10 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3DA52853F7; Tue, 6 May 2025 17:09:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746551374; cv=none; b=N0BT/MbtNrc8/7v0TMMseIjMFzH5BaQ0onQgEMrAxPk+d6ifZtGRIme0XSDS3sXjY2Msd6+g3YNLvjt6+jl6gQElT/k+Y1TKlj2D39wfoICjysW2MxTfbCeuz7+JxLFXCqK//6egUQzr3Kli9t8vZjazaC/B3xyS4yITE/L+qU0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746551374; c=relaxed/simple; bh=pwtLzPif3UxjTFKs4y8IgdJ7SvrBTPG4ooY9nRPu9+k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OUGJblcfISq/wRoTnXX7LVx8tIOAXyUDwIzPN2KyQrFh7LIj8ilFbyVExPmc3CUNOymGXwa7EHItKkbIsrH/Ayd/Qaks0rLThPSS9vZmUwZ61b3LfG4DtLAAhiUJkblKzU4VuOu7yqa1JzaOHrqVUwx9QlR+VXE/sgeiV5u8FqM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Cd1jEIrN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Cd1jEIrN" Received: by smtp.kernel.org (Postfix) with ESMTPS id 4B814C4CEE4; Tue, 6 May 2025 17:09:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746551374; bh=pwtLzPif3UxjTFKs4y8IgdJ7SvrBTPG4ooY9nRPu9+k=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=Cd1jEIrNH1fw0sN+2+GlMNYkOvpFtrAY3fqw5Xo8at07tAyBQZVeWPYdyq8Dz6S3T 1/8rzORY+vcApvzVLW1nvA1VgtzwWKIiRHIS1mK8qDYEoCzR7oDxLu3UzDhqxJAuXv 9XxUpSwbac1zAj0xQKK419sMsD0WEA/dd7LQC3Ld5A5o5D0fq1CC7qfFN0lTCeZiqx kG9u8DnpK+vaL1C4mjA44JEqoVCufjf7vs7/5VicrCtSyQotaPcWkoAQjqrGo/Bv4H OyGImq7sYuxJygk1TlehM+iiOZ2XUgOhsEy94qC27Ii+OhaO8tpe6yQY6BC1z1kZdt xerSJVtB5Gz8A== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BD31C3ABBC; Tue, 6 May 2025 17:09:34 +0000 (UTC) From: Aaron Kling via B4 Relay Date: Tue, 06 May 2025 12:09:17 -0500 Subject: [PATCH v2 1/2] dt-bindings: phy: tegra-xusb: Document role-switch-default-mode Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250506-xusb-peripheral-v2-1-bfbe00671389@gmail.com> References: <20250506-xusb-peripheral-v2-0-bfbe00671389@gmail.com> In-Reply-To: <20250506-xusb-peripheral-v2-0-bfbe00671389@gmail.com> To: JC Kuo , Vinod Koul , Kishon Vijay Abraham I , Thierry Reding , Jonathan Hunter , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Aaron Kling X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1746551373; l=12515; i=webgeek1234@gmail.com; s=20250217; h=from:subject:message-id; bh=bXDz9V7ijjOjEJDjbseeUMoc4cMqeqy8K+grZCx+HLw=; b=GK4I3KpBd+lxijxREOMj3v4HHSzQOPDNux/+SXpHMeMi8uzDS6uEDdGuyu5bXQw2ENsgPvtPL L19irEOUYKfDSAsiMpZ9XZxUubnrs+Hepayj3lgnO6WCO/Hi5ly24XI X-Developer-Key: i=webgeek1234@gmail.com; a=ed25519; pk=TQwd6q26txw7bkK7B8qtI/kcAohZc7bHHGSD7domdrU= X-Endpoint-Received: by B4 Relay for webgeek1234@gmail.com/20250217 with auth_id=342 X-Original-From: Aaron Kling Reply-To: webgeek1234@gmail.com From: Aaron Kling This property is used to default an otg port to host or peripheral. Signed-off-by: Aaron Kling --- .../bindings/phy/nvidia,tegra124-xusb-padctl.yaml | 33 ++++++++++++++++++= ++ .../bindings/phy/nvidia,tegra186-xusb-padctl.yaml | 27 ++++++++++++++++ .../bindings/phy/nvidia,tegra194-xusb-padctl.yaml | 36 ++++++++++++++++++= ++++ .../bindings/phy/nvidia,tegra210-xusb-padctl.yaml | 36 ++++++++++++++++++= ++++ 4 files changed, 132 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-pad= ctl.yaml b/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padct= l.yaml index 33b41b6b2fd539450f9ce72db8bba204e9c08eba..f383f25d932071bb4e4c86cb9f8= 7f51e6a59aaac 100644 --- a/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.yaml +++ b/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.yaml @@ -357,10 +357,21 @@ properties: =20 See ../connector/usb-connector.yaml. =20 + role-switch-default-mode: + description: + Indicates if usb-role-switch is enabled, the device default = operation + mode of controller while usb role is USB_ROLE_NONE. + $ref: /schemas/types.yaml#/definitions/string + enum: [host, peripheral] + default: peripheral + vbus-supply: description: A phandle to the regulator supplying the VBUS voltage. =20 + dependencies: + role-switch-default-mode: [ usb-role-switch ] + usb2-1: type: object additionalProperties: false @@ -392,10 +403,21 @@ properties: =20 See ../connector/usb-connector.yaml. =20 + role-switch-default-mode: + description: + Indicates if usb-role-switch is enabled, the device default = operation + mode of controller while usb role is USB_ROLE_NONE. + $ref: /schemas/types.yaml#/definitions/string + enum: [host, peripheral] + default: peripheral + vbus-supply: description: A phandle to the regulator supplying the VBUS voltage. =20 + dependencies: + role-switch-default-mode: [ usb-role-switch ] + usb2-2: type: object additionalProperties: false @@ -427,10 +449,21 @@ properties: =20 See ../connector/usb-connector.yaml. =20 + role-switch-default-mode: + description: + Indicates if usb-role-switch is enabled, the device default = operation + mode of controller while usb role is USB_ROLE_NONE. + $ref: /schemas/types.yaml#/definitions/string + enum: [host, peripheral] + default: peripheral + vbus-supply: description: A phandle to the regulator supplying the VBUS voltage. =20 + dependencies: + role-switch-default-mode: [ usb-role-switch ] + ulpi-0: type: object additionalProperties: false diff --git a/Documentation/devicetree/bindings/phy/nvidia,tegra186-xusb-pad= ctl.yaml b/Documentation/devicetree/bindings/phy/nvidia,tegra186-xusb-padct= l.yaml index 8b1d5a8529e38a1956a60e402c40ebec089ff2e9..f38ed6d339f125df136bcf0e954= efb9f5b46466a 100644 --- a/Documentation/devicetree/bindings/phy/nvidia,tegra186-xusb-padctl.yaml +++ b/Documentation/devicetree/bindings/phy/nvidia,tegra186-xusb-padctl.yaml @@ -260,12 +260,21 @@ properties: =20 See ../connector/usb-connector.yaml. =20 + role-switch-default-mode: + description: + Indicates if usb-role-switch is enabled, the device default = operation + mode of controller while usb role is USB_ROLE_NONE. + $ref: /schemas/types.yaml#/definitions/string + enum: [host, peripheral] + default: peripheral + vbus-supply: description: A phandle to the regulator supplying the VBUS voltage. =20 dependencies: usb-role-switch: [ connector ] + role-switch-default-mode: [ usb-role-switch ] =20 usb2-1: type: object @@ -298,12 +307,21 @@ properties: =20 See ../connector/usb-connector.yaml. =20 + role-switch-default-mode: + description: + Indicates if usb-role-switch is enabled, the device default = operation + mode of controller while usb role is USB_ROLE_NONE. + $ref: /schemas/types.yaml#/definitions/string + enum: [host, peripheral] + default: peripheral + vbus-supply: description: A phandle to the regulator supplying the VBUS voltage. =20 dependencies: usb-role-switch: [ connector ] + role-switch-default-mode: [ usb-role-switch ] =20 usb2-2: type: object @@ -336,12 +354,21 @@ properties: =20 See ../connector/usb-connector.yaml. =20 + role-switch-default-mode: + description: + Indicates if usb-role-switch is enabled, the device default = operation + mode of controller while usb role is USB_ROLE_NONE. + $ref: /schemas/types.yaml#/definitions/string + enum: [host, peripheral] + default: peripheral + vbus-supply: description: A phandle to the regulator supplying the VBUS voltage. =20 dependencies: usb-role-switch: [ connector ] + role-switch-default-mode: [ usb-role-switch ] =20 hsic-0: type: object diff --git a/Documentation/devicetree/bindings/phy/nvidia,tegra194-xusb-pad= ctl.yaml b/Documentation/devicetree/bindings/phy/nvidia,tegra194-xusb-padct= l.yaml index 6e3398399628766e820ff2a5da0ee644dcdee956..8253ff3ac5e8cffba16ddca3fbb= c0fa32b58384f 100644 --- a/Documentation/devicetree/bindings/phy/nvidia,tegra194-xusb-padctl.yaml +++ b/Documentation/devicetree/bindings/phy/nvidia,tegra194-xusb-padctl.yaml @@ -251,12 +251,21 @@ properties: =20 See ../connector/usb-connector.yaml. =20 + role-switch-default-mode: + description: + Indicates if usb-role-switch is enabled, the device default = operation + mode of controller while usb role is USB_ROLE_NONE. + $ref: /schemas/types.yaml#/definitions/string + enum: [host, peripheral] + default: peripheral + vbus-supply: description: A phandle to the regulator supplying the VBUS voltage. =20 dependencies: usb-role-switch: [ connector ] + role-switch-default-mode: [ usb-role-switch ] =20 usb2-1: type: object @@ -289,12 +298,21 @@ properties: =20 See ../connector/usb-connector.yaml. =20 + role-switch-default-mode: + description: + Indicates if usb-role-switch is enabled, the device default = operation + mode of controller while usb role is USB_ROLE_NONE. + $ref: /schemas/types.yaml#/definitions/string + enum: [host, peripheral] + default: peripheral + vbus-supply: description: A phandle to the regulator supplying the VBUS voltage. =20 dependencies: usb-role-switch: [ connector ] + role-switch-default-mode: [ usb-role-switch ] =20 usb2-2: type: object @@ -327,12 +345,21 @@ properties: =20 See ../connector/usb-connector.yaml. =20 + role-switch-default-mode: + description: + Indicates if usb-role-switch is enabled, the device default = operation + mode of controller while usb role is USB_ROLE_NONE. + $ref: /schemas/types.yaml#/definitions/string + enum: [host, peripheral] + default: peripheral + vbus-supply: description: A phandle to the regulator supplying the VBUS voltage. =20 dependencies: usb-role-switch: [ connector ] + role-switch-default-mode: [ usb-role-switch ] =20 usb2-3: type: object @@ -365,12 +392,21 @@ properties: =20 See ../connector/usb-connector.yaml. =20 + role-switch-default-mode: + description: + Indicates if usb-role-switch is enabled, the device default = operation + mode of controller while usb role is USB_ROLE_NONE. + $ref: /schemas/types.yaml#/definitions/string + enum: [host, peripheral] + default: peripheral + vbus-supply: description: A phandle to the regulator supplying the VBUS voltage. =20 dependencies: usb-role-switch: [ connector ] + role-switch-default-mode: [ usb-role-switch ] =20 usb3-0: type: object diff --git a/Documentation/devicetree/bindings/phy/nvidia,tegra210-xusb-pad= ctl.yaml b/Documentation/devicetree/bindings/phy/nvidia,tegra210-xusb-padct= l.yaml index e9237c58ce45df7fa25cac861891b3fe76efe83d..c14bb947d306912fb732ff21951= 1c6d6fda80f7c 100644 --- a/Documentation/devicetree/bindings/phy/nvidia,tegra210-xusb-padctl.yaml +++ b/Documentation/devicetree/bindings/phy/nvidia,tegra210-xusb-padctl.yaml @@ -379,12 +379,21 @@ properties: =20 See ../connector/usb-connector.yaml. =20 + role-switch-default-mode: + description: + Indicates if usb-role-switch is enabled, the device default = operation + mode of controller while usb role is USB_ROLE_NONE. + $ref: /schemas/types.yaml#/definitions/string + enum: [host, peripheral] + default: peripheral + vbus-supply: description: A phandle to the regulator supplying the VBUS voltage. =20 dependencies: usb-role-switch: [ connector ] + role-switch-default-mode: [ usb-role-switch ] =20 usb2-1: type: object @@ -417,12 +426,21 @@ properties: =20 See ../connector/usb-connector.yaml. =20 + role-switch-default-mode: + description: + Indicates if usb-role-switch is enabled, the device default = operation + mode of controller while usb role is USB_ROLE_NONE. + $ref: /schemas/types.yaml#/definitions/string + enum: [host, peripheral] + default: peripheral + vbus-supply: description: A phandle to the regulator supplying the VBUS voltage. =20 dependencies: usb-role-switch: [ connector ] + role-switch-default-mode: [ usb-role-switch ] =20 usb2-2: type: object @@ -455,12 +473,21 @@ properties: =20 See ../connector/usb-connector.yaml. =20 + role-switch-default-mode: + description: + Indicates if usb-role-switch is enabled, the device default = operation + mode of controller while usb role is USB_ROLE_NONE. + $ref: /schemas/types.yaml#/definitions/string + enum: [host, peripheral] + default: peripheral + vbus-supply: description: A phandle to the regulator supplying the VBUS voltage. =20 dependencies: usb-role-switch: [ connector ] + role-switch-default-mode: [ usb-role-switch ] =20 usb2-3: type: object @@ -493,12 +520,21 @@ properties: =20 See ../connector/usb-connector.yaml. =20 + role-switch-default-mode: + description: + Indicates if usb-role-switch is enabled, the device default = operation + mode of controller while usb role is USB_ROLE_NONE. + $ref: /schemas/types.yaml#/definitions/string + enum: [host, peripheral] + default: peripheral + vbus-supply: description: A phandle to the regulator supplying the VBUS voltage. =20 dependencies: usb-role-switch: [ connector ] + role-switch-default-mode: [ usb-role-switch ] =20 hsic-0: type: object --=20 2.48.1 From nobody Sat Feb 7 23:23:10 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAFF028151D; Tue, 6 May 2025 17:09:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746551375; cv=none; b=iE5AG3t+HKmbAd9Lw3HqhGYVzSpdZO6GJ8ejIt8OXuIAoRlVgGiq0TmWppgpNy2mo5c6xVQK5g7R/luqARf1zipoCR5ptU57ByZXDOikCiD4fOiVmJTEp4zqCkdpprC8xQUcGlGwsHeqETn/LAmv846SvTiz9jxOhBU9DRQB5Ew= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746551375; c=relaxed/simple; bh=k+gZ1pxmpGXcLHj2TLw4nLia4cr2GC0EuPxS3YjpOCg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EKHco1pGoZ87Ww7V5HrXRPMysq69Ef4g0JaMdIEFaynsRpizxeoaC+TSacIoZyAd2FsarL4K0IfoKLurDoxVyyNkRckIsQJhGza+XlJuZpVs6hcJ2HDbYB1JFKgBz8qJAgEP+UzhB4YLZWiDd3YSMXgLx+sZkIfZqZdNlnakJTI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VcDx68d5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VcDx68d5" Received: by smtp.kernel.org (Postfix) with ESMTPS id 58F7CC4CEF3; Tue, 6 May 2025 17:09:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746551374; bh=k+gZ1pxmpGXcLHj2TLw4nLia4cr2GC0EuPxS3YjpOCg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=VcDx68d5Wc2yLUlRvccpd/myN1moA5pKE7H4f4f0ib88r7j1fENwvw70NQSonwxgT CoE7MGXOHwDCwuIbSm/A2O46wmnjfivqwDUitiIa0y+7kxPeWTaIManccTNRWz2/0f VtYWfG1NK1BQEZZ+omAqXCAyT2yy7lnwcYvf7T/lCurvR/bf5djhiHe9SZ4Po6ZlFR jOObMVTZ0NSuKZH0M4+qy09FQyLibIE2v6Jz0uZG0NkmJdg0JODLYztSIpljgwOKaf 0yCl9OjzkYWmiNwj/2OyGxUfVsU5jkw1l/muai+Mju8ETfY06KbzZlijB4bu+YcNKy 1RbOH1vM0675g== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4942DC3ABC5; Tue, 6 May 2025 17:09:34 +0000 (UTC) From: Aaron Kling via B4 Relay Date: Tue, 06 May 2025 12:09:18 -0500 Subject: [PATCH v2 2/2] phy: tegra: xusb: Default otg mode to peripheral Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250506-xusb-peripheral-v2-2-bfbe00671389@gmail.com> References: <20250506-xusb-peripheral-v2-0-bfbe00671389@gmail.com> In-Reply-To: <20250506-xusb-peripheral-v2-0-bfbe00671389@gmail.com> To: JC Kuo , Vinod Koul , Kishon Vijay Abraham I , Thierry Reding , Jonathan Hunter , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Aaron Kling X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1746551373; l=1618; i=webgeek1234@gmail.com; s=20250217; h=from:subject:message-id; bh=WY090858pJtzoKww7YaC7Z9JTjET1bec4L1964gg6J4=; b=NaDOg+nVQv05p86Ta/79J6j2EU3M3vcxowUBXmQydstuVgGIULGpaJycP9oGlAbZopQhyWfpF OWzO8bM+nO6Cp/bxIk33uX0ce/QeUjBV6iUHqoiGfgtc3beuBTn+vi1 X-Developer-Key: i=webgeek1234@gmail.com; a=ed25519; pk=TQwd6q26txw7bkK7B8qtI/kcAohZc7bHHGSD7domdrU= X-Endpoint-Received: by B4 Relay for webgeek1234@gmail.com/20250217 with auth_id=342 X-Original-From: Aaron Kling Reply-To: webgeek1234@gmail.com From: Aaron Kling Currently, if usb-role-switch is set and role-switch-default-mode is not, a xusb port will be inoperable until that port is hotplugged, because the driver defaults to role none. Instead of requiring all devices to set the default mode, assume that the port is primarily intended for use in device mode. Signed-off-by: Aaron Kling --- drivers/phy/tegra/xusb.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c index 79d4814d758d5e1f0e8200d61e131606adbb0e2d..22338f3f24a0794c22544a0e16e= 0fc706c4fb6d7 100644 --- a/drivers/phy/tegra/xusb.c +++ b/drivers/phy/tegra/xusb.c @@ -726,18 +726,15 @@ static int tegra_xusb_setup_usb_role_switch(struct te= gra_xusb_port *port) =20 static void tegra_xusb_parse_usb_role_default_mode(struct tegra_xusb_port = *port) { - enum usb_role role =3D USB_ROLE_NONE; + /* Most switchable usb ports are normally used in device mode */ + enum usb_role role =3D USB_ROLE_DEVICE; enum usb_dr_mode mode =3D usb_get_role_switch_default_mode(&port->dev); =20 if (mode =3D=3D USB_DR_MODE_HOST) role =3D USB_ROLE_HOST; - else if (mode =3D=3D USB_DR_MODE_PERIPHERAL) - role =3D USB_ROLE_DEVICE; =20 - if (role !=3D USB_ROLE_NONE) { - usb_role_switch_set_role(port->usb_role_sw, role); - dev_dbg(&port->dev, "usb role default mode is %s", modes[mode]); - } + usb_role_switch_set_role(port->usb_role_sw, role); + dev_dbg(&port->dev, "usb role default mode is %s", modes[mode]); } =20 static int tegra_xusb_usb2_port_parse_dt(struct tegra_xusb_usb2_port *usb2) --=20 2.48.1