From nobody Tue Dec 16 15:24:59 2025 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12FCB264615 for ; Tue, 6 May 2025 09:01:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746522117; cv=none; b=LH87gRMNHWxCZ3Fc7zZJBqXL8HyM1onWoVXD3eStFYzGAEk/m1KnoAZjCoSHtCjENwtwFI4fLRgt1VNMUv3cQlCCJg8AtZ4pQ/902fyhBFiNii76Qy3oaWi/Ll9op9x8mX53C1sXgszPjOyCYmaFICXKEItkiTsI4ZVxgrteLQ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746522117; c=relaxed/simple; bh=gYKt/V/uMuHipLynaF1K3ceGiFbenp32cyT/tx97Akw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IxN+Rh0U3+7jHdYnBx9YU1dZdz4GLqK7QjP0ikrH4laZ82tBaRI90CXKj/CbVvWkyN+7rsVID/Y+kYrfLl8qw2cn6yipKpHDe+3AXFkerZ0ehlW8Hc5/Q6a6jsnHaDKjGxA/5m+YgCkqdKfR3UmaateDL44bFOx+S3iotiMOlKo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=E82NgLrd; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="E82NgLrd" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-441d1ed82dbso2469055e9.0 for ; Tue, 06 May 2025 02:01:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1746522114; x=1747126914; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=fqB98pFRqw492ZhmHp/PFeUzRjROzd7VojSNtl3mvpE=; b=E82NgLrd5aQePPCmpkwHp6MC+yNO5DOha0vWYFlF6Q5aYeifX+SWL6nYaeVHSx4mr7 P/HxRA6mP89AtNKvVfP2SCwRoAFyf3JmcsLJbkONuTIvG3orazs9cQkFIX/OZOeWwT2F yWCnfXkLhrC/qVgQbubyv6LtctGSw47Vb4p0qMPfsWv1ESdL3QR+L6MN/mDh9WFatYpJ +dnQaKmS0duVcgh6ZinsEfRBP1kVpeGyB7M2ZvJSf2oMM9553pUfHJ4svHtx2eUQXpWx t46a2g2p7k0aN3GBLfXhg4ZxO4DqD+XVg04gsUSG3Ia1Vf/6upoY8AI9BVkz49Dv5Ma6 LKAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746522114; x=1747126914; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fqB98pFRqw492ZhmHp/PFeUzRjROzd7VojSNtl3mvpE=; b=R+dZlZyzZtNihn/x75WxMxarIYnDao0DjBQoksb5b9nz6eb9OC0n3DYBswyWHGBKHP 4BgJ5z6s7/QvYvArAY7RTdJ8r/E9d/t0pHFvOxT9MbSCZGSJmBYZfw8VrtEcFy17+/9c gTe3EpjGhGHjOndlyJuJRi0/B1Ttsvm3AfkBdCYpTeZbSk+gQCh19JAhkd6zhHb11qSY h88B7jxWlp6yo54SgedosV+5Fe9l0B0VGUgmZUUbe0gAFBN4ibNq7uVYiUK0oTROjXlI yVtXigVclgeh+d7vRtLNJpyRuF0LhQKHbfeaJ+DaZskNLLXboBgoPGE5KZGNP9bJYsib cDWQ== X-Forwarded-Encrypted: i=1; AJvYcCUl8GV/iZ4jOPuYt2cc1Dfj1RjeuixvHnkB/9HgjY+10lOcu6jP5T/IN13bRrh2/b0jFyPoaa2PXpRX/ig=@vger.kernel.org X-Gm-Message-State: AOJu0YyCl6/IAkA/cfr4csHIxaKqHLR1vu8cRY16M90LYpKclv87FNAK Cnsl5v9xfZOlSDHYlh8Cy6FzfaN8pkS+4eFNPWDSRRWjoWyzJkA1vLJsLkkeMf73kzrJP1Immev X X-Gm-Gg: ASbGnctdFdhVO2oriGQ4bf87RIk+bPKAQsuaIsEPos/2N6gqngRNlShO3P+Cvxve+Sx rkh2Qvhw1HyWmGIwovOXmm/QPcP/BOWv0h1CR+PvoT3ZBoo/XuhCZlVfzmvP7hmMHFQ+7n7GjAd /q39EzIzNha9HmoWAIBtnBt1en/iVUN2tFEsWoa0Ak0RXQEo+Gz8lpuuYHmQRI48448e99ysyB/ 7mM/g3utFJobY7DLrK5yv78YbB03Dcq+6mdbDRQY56MZmMIJgMui30ITKXlm0LhOSRs1nCykThU xlHvEChp4+XlK0l2m2yqD7CJqlb8mQgXNXU= X-Google-Smtp-Source: AGHT+IGDU8UwVARAbr3wvLnx+R/CMU+fndtw+gPiz5QuLHtsjMKW02FOMERXLYV/50G6vY3UpD1p6Q== X-Received: by 2002:a05:600c:a375:b0:43d:300f:fa1d with SMTP id 5b1f17b1804b1-441d10154abmr18934305e9.31.1746522114107; Tue, 06 May 2025 02:01:54 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:bfd0:3ad7:fd8a:fe95]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441bc83d471sm138125725e9.26.2025.05.06.02.01.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 May 2025 02:01:53 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 06 May 2025 11:01:44 +0200 Subject: [PATCH 01/12] gpio: lp873x: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250506-gpiochip-set-rv-gpio-part3-v1-1-0fbdea5a9667@linaro.org> References: <20250506-gpiochip-set-rv-gpio-part3-v1-0-0fbdea5a9667@linaro.org> In-Reply-To: <20250506-gpiochip-set-rv-gpio-part3-v1-0-0fbdea5a9667@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Vladimir Zapolskiy , Piotr Wojtaszczyk , Charles Keepax , Richard Fitzgerald , Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1643; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=KzVnua5lKk6LSZ+RA6U6z6ophC29UZ2psB9O2qSifco=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoGc/8PZdeK3eoxj5LZCAwJ2tSgAZHtlOTQquu1 TAv25EMsKmJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaBnP/AAKCRARpy6gFHHX ciBXD/9eOGxP6WMpRIbDeI4ZPyWQdRiVWSzDMz0kD+ULzuBS7OHZLm1Lxi6rYWDOoZpA1aa/qRm T5DXumO4TNeoTYBlW4zeeAEyA6tdzECpf1BhhK/71Cn3CTpEE5pCBPbr1SvCuil2ysLA1n3Xg75 kgPpAliYslsoCvHFYMZmoP/fFYVs5VoMLCCbAt25ueJJhtaMLmaUr9+nsxjQWRQFjce8XjxLZii uJ3Itxgyt00NTON1YpRsK3F1mGAeoZ1Pd/RUkCVXkRsvFN+faFyk9IbdH7qlAUYAG0U+ejvRtYm /UyYpvwOe23hQyg+2Oi7V74VaTaEQoEy4t/s95EwAXun2JRR/3iJiMs2DCKh7mu6mmarCHQ0UJ9 rxrMU0F8SWGoNdoHJI84PkrzCowsnyGfaRbErOycQwKW7sif5ra5B+FBN0FTOzpt9H50VtulR6u ki6ZquD5iMa4DJg4U7s5rj4LSL41DL1E1PI6WKGM1SotlSot6p+ShkRrgong21J0XZ/Ct28bQfO FHWNqOgECDw9gWlNurVLK1udL3d1qtF24kPC+tq5Z7CmYOa+J86cFTFVihnXzLEUpjlgrhnsTd9 LVPrjLlEel3vU7pgznmnDpKarYuIvU6If7rb8TRGHcBwE3diBLGk+eBSPYNSNnX5lDbsWkoDzMr JAhTSgymkWD4x+g== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-lp873x.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpio/gpio-lp873x.c b/drivers/gpio/gpio-lp873x.c index 5c79ba1f229c4..1908ed302e923 100644 --- a/drivers/gpio/gpio-lp873x.c +++ b/drivers/gpio/gpio-lp873x.c @@ -58,14 +58,14 @@ static int lp873x_gpio_get(struct gpio_chip *chip, unsi= gned int offset) return val & BIT(offset * BITS_PER_GPO); } =20 -static void lp873x_gpio_set(struct gpio_chip *chip, unsigned int offset, - int value) +static int lp873x_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct lp873x_gpio *gpio =3D gpiochip_get_data(chip); =20 - regmap_update_bits(gpio->lp873->regmap, LP873X_REG_GPO_CTRL, - BIT(offset * BITS_PER_GPO), - value ? BIT(offset * BITS_PER_GPO) : 0); + return regmap_update_bits(gpio->lp873->regmap, LP873X_REG_GPO_CTRL, + BIT(offset * BITS_PER_GPO), + value ? BIT(offset * BITS_PER_GPO) : 0); } =20 static int lp873x_gpio_request(struct gpio_chip *gc, unsigned int offset) @@ -124,7 +124,7 @@ static const struct gpio_chip template_chip =3D { .direction_input =3D lp873x_gpio_direction_input, .direction_output =3D lp873x_gpio_direction_output, .get =3D lp873x_gpio_get, - .set =3D lp873x_gpio_set, + .set_rv =3D lp873x_gpio_set, .set_config =3D lp873x_gpio_set_config, .base =3D -1, .ngpio =3D 2, --=20 2.45.2 From nobody Tue Dec 16 15:24:59 2025 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CF88264A95 for ; Tue, 6 May 2025 09:01:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746522119; cv=none; b=QBa3dzH0Zx27zFS4r4CKdXiSwW4UUCp0RlMUHoq5PGCy54lG/7TR3rTCVSODzF+1W7xu1+pWG4eYXtVh+O3njl7P+X8N36GY56y+Dg6S95DlD89eZrHWs02TwzZYkKvFYDM0XCvdrnIGOBCkZ8tF6sI0sSovOqSBU3ZmTTbQtuk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746522119; c=relaxed/simple; bh=2or+JBNGnO4YRdXBRTn6HPiuWZpgrAjupHyyTXPwtVI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rAzhB5+evF+e0He8UID3YVPGhB7X2U6Ix/xHi0QOgbRu46bufQavIHKf1tOqsIl2siW6Wx7SpEElZ4LXfnoNSWlQEVKtAAQ3yZVwh7yuOakDi44ihspIRmfGZv++HSFoDJ3r4w8BwIH2r7hQ4NBE8GdsQGt7HG1pZjwjP2EoGQQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=mIhx1pNX; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="mIhx1pNX" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-441c99459e9so15836555e9.3 for ; Tue, 06 May 2025 02:01:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1746522115; x=1747126915; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XRbwfcPISTocHOhXVUtVqcS/MjhgKVKyymoCXJ3Oarc=; b=mIhx1pNXiRg6DKqnGmXv7U3tmrU2QkwhC0UIUDnOP56SBA3guWJq42dedFTc67sEmp ouM1pj7gJbytnit+E3ok730tsVXEhKP3WyQY9u77zqIE1NLCmHn9+GHPzbIdY936A8+B hcxHqLrO1WYiejhnXgp4f7pkF7mP4qLtIvk17DDHe7zbx8xJVu1mBDv8YKFp+3T3qDBA aqPjIULm516IAzby1rzStCMCt+Bp68mB4tV2GdSFAOx9iipSpS3GskcsnakXJQt83KaA f63897Aii2+6eVbOny/THQIIIUXQvDZhV1o3JFDQr9KOTZX8GTHRG+fTqXpekFgXRITK BUqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746522115; x=1747126915; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XRbwfcPISTocHOhXVUtVqcS/MjhgKVKyymoCXJ3Oarc=; b=uHjRVtLas+JsAc8VdjvPoVL9ck73V3edCn5UPdFqAX9EAMCYCKqLkNGW5y9JopXinu xZIP4pqkxNzjwKzZxOXFZrwtpWOatBddBWXPKNJIphQnb11nkL3XxwAe734EtuSB5rxK 3kNznfy75RG3A4BxjZSGj4z1yPYo8fzjwBwcaD9gtrH/UbNUsz1q7BZrx5NkA6EaqBi8 sep6pO5C2MNz0fWXAnop9Mp25cNmEEwVgwSHyBZuEghme3QpZ5f+254Jis/dyiyy5caj VraGLx0oi6+N0xm52TT6gA0OKnYk3qeCoQzZe/64jS1gFFKwkHjUkxyXeHJFos75kqMJ zkZA== X-Forwarded-Encrypted: i=1; AJvYcCXlVMe6MDnvUXOERb1tIAJaxgsRoPihYYOlGG/ZnVeEkHlZXAWCT/aqYnghRmKz69vKp2/XfBfN0UCGCb4=@vger.kernel.org X-Gm-Message-State: AOJu0YyyI2gN7LMQg57JGjTLNX3NuqbBT//960V8eXxWxgp59ETu78cw jrWhfcJHKnxlqrUWOmkrc2NxI3TJwoeeE3QVdxFLfJ9+V2tKNLzkQbvE7oJ6vU5xiCDdbXCiR6C r X-Gm-Gg: ASbGncv4RSrfxYbca5L84brp6obNOG7dRfKrl34ZEwhb35THghZ/ycLTY/yNHUEwBus QO2xFBRW3bM1k3RkacKz6nQe50/LVvmxe8km0ccPVJF5FNR7sPVPF+N16o2j7W3qDdzGN8VVTTp bocMD+4cBBHtjkONalj6Ngde2pP6E12PKItg6MJB3AxXa0LjuXreEbS/HZj4PONbjfvyAQRSX9M WqaFrTnM3lQ+jJOF0+72tXddoiGU5fOGOY0gAncLFtGZR4YGx4x/ttsiXsuSPFicQ8OD+6d/bg5 hrp/HXtZHRolUCggyXPzMOeJggh8hh6xpU4= X-Google-Smtp-Source: AGHT+IFaS4uuNDBaE6dhkhCQZlPqtoW9s6ejNK/wKywX5ZJFKn+MgnjgDQY3rIFa7aCju9NeyyMDmg== X-Received: by 2002:a05:600c:1987:b0:43d:49eb:963f with SMTP id 5b1f17b1804b1-441bbf33b31mr127301045e9.24.1746522115124; Tue, 06 May 2025 02:01:55 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:bfd0:3ad7:fd8a:fe95]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441bc83d471sm138125725e9.26.2025.05.06.02.01.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 May 2025 02:01:54 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 06 May 2025 11:01:45 +0200 Subject: [PATCH 02/12] gpio: lp87565: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250506-gpiochip-set-rv-gpio-part3-v1-2-0fbdea5a9667@linaro.org> References: <20250506-gpiochip-set-rv-gpio-part3-v1-0-0fbdea5a9667@linaro.org> In-Reply-To: <20250506-gpiochip-set-rv-gpio-part3-v1-0-0fbdea5a9667@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Vladimir Zapolskiy , Piotr Wojtaszczyk , Charles Keepax , Richard Fitzgerald , Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1940; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=g7BgjBBWPP4HAHZDBrZkWD5sdQj4Cs5tbDmVip+FOsM=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoGc/9ERgHtadWP7KkHQX+SJca3tVfXEyXuW72V BoPbo0tG1CJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaBnP/QAKCRARpy6gFHHX ciGyD/4zlyrvqUlkFdwqgF6/1bmPTMA+93X1SFLWKapDdKrqY6qB5ax4uK8vlaoVJj+EGNLpV45 PxHxDOaQwYLAlMSatc7jXiGCGhFX8dfDyqEcKM4w1ow25Cgx9GaOf2IxMKeUtA5DljGR+fvaoLo itfBnXi9u0KhlfX6aoEtMfKJjL/waIWp4HMGISTreeWZBiK/Cancv+qdCZem5nlVnQToK+nrrY4 C1rwbZ20aJhha4hrK/A2mGKhGOtA1qA/CXE7vBSKVVN5BraH3iAvlbNfWgk1rCz6X9x58IRAE34 gc9M0lREJ5yJoopjEyvR7jxpGpRZ21kiuIMlvD6PRwNyUwi1j8I7SoxNr2UwWq+vmQcN/qnE1nQ fFlHfYEhHGibqrl/EgGf/eeG0O4qc1GcoCLK2ocm+ENCoFiEpiPYbS56b3rYUHy6JFWD1+RIJ5/ 4hdQE4Gm0b7F0sOa7+yC0sijojAZ8yPPZFhHayprULmzhS9MNlO9lAOjh/VXpKOrdfi2lnarnvy HqvtmfwYKU6qCO7JnlJP8GRepr43s/XAN4BVGd4J9hX+CcPSLfKB+xkM/D0XukauNtFoUctNuX2 0VmdoCwcYQWChvaZ3d49YENC3PYbDFUmJm1LMxRXD8oMQHMSi6YELPLvRftvqL0K5n7q412i8uz XTil/+VBYkSIXwQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-lp87565.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/gpio/gpio-lp87565.c b/drivers/gpio/gpio-lp87565.c index d3ce027de081f..8ea687d5d028a 100644 --- a/drivers/gpio/gpio-lp87565.c +++ b/drivers/gpio/gpio-lp87565.c @@ -30,13 +30,13 @@ static int lp87565_gpio_get(struct gpio_chip *chip, uns= igned int offset) return !!(val & BIT(offset)); } =20 -static void lp87565_gpio_set(struct gpio_chip *chip, unsigned int offset, - int value) +static int lp87565_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct lp87565_gpio *gpio =3D gpiochip_get_data(chip); =20 - regmap_update_bits(gpio->map, LP87565_REG_GPIO_OUT, - BIT(offset), value ? BIT(offset) : 0); + return regmap_update_bits(gpio->map, LP87565_REG_GPIO_OUT, + BIT(offset), value ? BIT(offset) : 0); } =20 static int lp87565_gpio_get_direction(struct gpio_chip *chip, @@ -69,8 +69,11 @@ static int lp87565_gpio_direction_output(struct gpio_chi= p *chip, unsigned int offset, int value) { struct lp87565_gpio *gpio =3D gpiochip_get_data(chip); + int ret; =20 - lp87565_gpio_set(chip, offset, value); + ret =3D lp87565_gpio_set(chip, offset, value); + if (ret) + return ret; =20 return regmap_update_bits(gpio->map, LP87565_REG_GPIO_CONFIG, @@ -136,7 +139,7 @@ static const struct gpio_chip template_chip =3D { .direction_input =3D lp87565_gpio_direction_input, .direction_output =3D lp87565_gpio_direction_output, .get =3D lp87565_gpio_get, - .set =3D lp87565_gpio_set, + .set_rv =3D lp87565_gpio_set, .set_config =3D lp87565_gpio_set_config, .base =3D -1, .ngpio =3D 3, --=20 2.45.2 From nobody Tue Dec 16 15:24:59 2025 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11B6526562A for ; Tue, 6 May 2025 09:01:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746522119; cv=none; b=Lynat7qYxKhRZugZE5hFBd4wybtzBBdAncrdqUmM+9ET76ISDjbt2mb8JGCMwzvglNLUkmbg9vlNz1KL2+JDJcLJD3BlpE0VA+w+uI1VxJAhvXmxkoFjMrZTnSyvlMlZJNZYY0nDdwypQPZ+GTgt+5iL5UfkZrEnA9wwcd+0MPA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746522119; c=relaxed/simple; bh=h/WDiVXfFCZHqvgjoPb6omhRMFBcxZL1KWQ7TBjLi3U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iN1yVLq/jb7VjhvdRCuqi3WAZCFkCH0zQC8iGlkMyfcTQt9TZ8dKeC/QQgXuR9Ywnecn3iOVeXOQxwZtx8YF2j3O648iahsfTMWP1vqBfIB4/C/mPHqAmN3X/AK5C2e7AcSTW1d6gKTYgPeAeHQKXiKIYFUzvi5+CZHYVvVH8GQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=Axtsrb9/; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="Axtsrb9/" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43d0c18e84eso23298295e9.3 for ; Tue, 06 May 2025 02:01:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1746522116; x=1747126916; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=B5xX5xDK1LhTZKmUeFagQY4z7X//bT5WMr4CQHakD5w=; b=Axtsrb9/gBTNBnBN+wn/Da3sjU+W7rcDpTPyyyf1H4KskiR7W6tLd0QNO45rQWCcdz XeutclkUh5kd6zv17pINpC0vVDTIjh94HUKdmLnRiX81OPJW9Md3nOF+TF5EdtUgPo2v q3Q228AsBn6B7x1sj25FNbQExG70lCmXRonwkAumgFrmjFtpS+CxOxQ0IRZ6L2S2smoz eP5OmX2IKRUaypguMtm48Yosgqy2vReL81FH2gUHQG1Sn2j54KjEmaCUNuXC6tquij6y 9fsdGj1L/t0+9/477McPq9ckrcOQ5Gaz24oGzcS4dUwWlmkQjYtUEodEvfRWQ7RwgGsi 0Jbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746522116; x=1747126916; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B5xX5xDK1LhTZKmUeFagQY4z7X//bT5WMr4CQHakD5w=; b=BT8PG8n7a//0SdFmXmQKmyVksvCM4QMeQQ6lfeHTzDlojJMbYW/jVKv3v3f1SGi2Ub uJ3+qiXY1WuOiNK4jiUlRjphkKqs9p1WQXCo2WxX25WRQvHgzeISf8zLwdvbuff6H9+w V9BC4/yCtCMnSGOc6VgE70fDiTsCDFzTUSy6ZxHee8EOCt8vdmsa/pGdJnHB6iXdO2M1 VCVLZraS0v35snxp7Nk0CypNI6151RzvHj6uJRFMATuoCTbZ5IDcWWeZ1YGVo9xt4eol iChaW1VNLIpejel0wzQLbOj2SslqofpC3AYRBRMPjJ32qiKtr/ji1vIxk2SmMT/R8iIH WUsw== X-Forwarded-Encrypted: i=1; AJvYcCXUtCSJA0RCtn2FKieueTt0SmUDllZ7wNJqjnJN2Yt53asgteuMb2kO31nW7HfbVCW81eU7tulEV5NQbUQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1cp4k3johVt1lLx2jeQg7ShwevB8EpHYi/zoxv70APstqsiQk XPKxtcMcuA1s1dQQDooF4O/ygbZf49kFmaRi/UtEJ6fUBzIgOncaWB4UkvSJaKMykefc+I0TMFd D X-Gm-Gg: ASbGncvZRFNRZyRxGidcVS1IErkqihpn+mJcwroKt0T5QSderV+4Cth+580SJxq3Nc7 xhtR2g9BOlGZMXxjEJcbNj+fu2nbeRmN/FRcGkFHT5NQJNERTfH4AjV10hF86t7Cs+6QbuJj1YH pfPdOgGeRSKwMvABI7oyuNKG4sQjeMaZWp4VUmMr6YXmPDTo+hm3QlKsxCmZcVTCR6WQg36ROyB 7k33hJmgh8+8Vo0sOc3RTnhTWFUpe+ADCvVXOAetcW1zD1Yx+f/Njikg+ALuguHvcI1BD8aySVa DnGIxSJQSWjze6iVGMm7nKGUBWk6BztSENo= X-Google-Smtp-Source: AGHT+IEhEQmtTeTN7IWRZ8t6vAkVX+cpAae/AbxZLwUc76/VgMs/gN09VBYqk+ftARkXwaYPcjiIdA== X-Received: by 2002:a05:600c:3d8f:b0:441:c1ea:ac35 with SMTP id 5b1f17b1804b1-441c48dc3e2mr82793035e9.18.1746522116150; Tue, 06 May 2025 02:01:56 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:bfd0:3ad7:fd8a:fe95]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441bc83d471sm138125725e9.26.2025.05.06.02.01.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 May 2025 02:01:55 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 06 May 2025 11:01:46 +0200 Subject: [PATCH 03/12] gpio: lpc18xx: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250506-gpiochip-set-rv-gpio-part3-v1-3-0fbdea5a9667@linaro.org> References: <20250506-gpiochip-set-rv-gpio-part3-v1-0-0fbdea5a9667@linaro.org> In-Reply-To: <20250506-gpiochip-set-rv-gpio-part3-v1-0-0fbdea5a9667@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Vladimir Zapolskiy , Piotr Wojtaszczyk , Charles Keepax , Richard Fitzgerald , Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1404; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=gRCbKDYWwPPaQt6l4gb0BixRmpWGNrb8kCwxis9bt0g=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoGc/9i0uQJY2BhC2Zrkvn3BoBUEcrSA7AXU5Qy HhV9DYw8tSJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaBnP/QAKCRARpy6gFHHX cgjwD/93U00fkkxaHhdkDkIlVUsJezLok4i7YHaxAuCQXD7314SjDuTfb66TE169HcoiHhxuRCh oZ9hw3ekQ6adWrpAosQzSS8Y2ZhLhCox7bdRrgm5fVQOOH1Q8G+DOyHbaKjLc7aI1ntaZQNaxCX KhvlUhTFYk5VEjQAbMqTNCXOpK/wnoHjaB5G/FCOgPrBygbAgZm+HYGVLCkqBh0KmgQQopw5qFB bTbl+qG/kj7i1rjObZx6DLtTURDsJj28sztaAM5lHt9fGhrBD28XodsWCb5vU1v9qM7OZIFJ3JO cHAed/Ei61otC4cOXACJIOumlsXwVyGXf/W0Ca7VBmdUgSk6PjnVxGMjfEZK77/8dJtBPucS55R 6SeGYrN6R9bybkiF/oOdzmWfh+VsJHoqcgMgzMJxLUQP3iM1zxxyMADvjoT2dxh/H5GWR0FVzWa Kb1/HsMmdhOY+yazJo2P0qrsLQsk3HoHrh3fMzUPgDNd66E2ZIHTGEq4DQSHRg89IbZGY9f40eJ 276sGF0uzhjcKzLq1iBiDTi8iti8/9WYhenl30CK/2wkos6A9sIbIgTjGKy8VF9+Rf0lGaCS6dv LPjIK06bWcIcR8WWzwbvk1lHdjbt5yhXnftqAT3zT9PhSxFX6miZo++KAtjyw2zQnBAicckizWw n85veXeo0akuOxg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-lpc18xx.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-lpc18xx.c b/drivers/gpio/gpio-lpc18xx.c index 2cf9fb4637a2b..8bb8a87ec1e99 100644 --- a/drivers/gpio/gpio-lpc18xx.c +++ b/drivers/gpio/gpio-lpc18xx.c @@ -263,10 +263,14 @@ static int lpc18xx_gpio_pin_ic_probe(struct lpc18xx_g= pio_chip *gc) return ret; } =20 -static void lpc18xx_gpio_set(struct gpio_chip *chip, unsigned offset, int = value) +static int lpc18xx_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct lpc18xx_gpio_chip *gc =3D gpiochip_get_data(chip); + writeb(value ? 1 : 0, gc->base + offset); + + return 0; } =20 static int lpc18xx_gpio_get(struct gpio_chip *chip, unsigned offset) @@ -316,7 +320,7 @@ static const struct gpio_chip lpc18xx_chip =3D { .free =3D gpiochip_generic_free, .direction_input =3D lpc18xx_gpio_direction_input, .direction_output =3D lpc18xx_gpio_direction_output, - .set =3D lpc18xx_gpio_set, + .set_rv =3D lpc18xx_gpio_set, .get =3D lpc18xx_gpio_get, .ngpio =3D LPC18XX_MAX_PORTS * LPC18XX_PINS_PER_PORT, .owner =3D THIS_MODULE, --=20 2.45.2 From nobody Tue Dec 16 15:24:59 2025 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AA8019F115 for ; Tue, 6 May 2025 09:01:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746522121; cv=none; b=T/NTU/L9NxY899ENHnNU1gkR/cby892SHOme8aokpOSGmERqyGiHPRVszcb/5D1axWJcvPBuP0djKawr9tK7+U5VFsxfm1CkX7KJ12Mi/mszPrHCTxWf+v08Fl0B1utTGpv0KlL3YKR8ZR0h17V/EB+scPFydmyRl2zBoNonfxg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746522121; c=relaxed/simple; bh=IbSKueG4T1w5hLwqUJQp0pczxkABxHLz/yO6KUzj4SY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Vfu8MpEnWwFXkN9AuxBk1taEgSUDhfNuqC34+a+yEVhzRE8/zYmlfh0z9GW8cKHDFRihNHcCeXRQTKlS2DCNqAgM06G5EZBtMdCpR4Qaz/CNhXEggl3DzYrOB7Ovg7ZewveOqGSMWn7aaITpcZmigr9S/mBnmsqfPoeY4w2/mjI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=y5IjZGwM; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="y5IjZGwM" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-43d0618746bso36695235e9.2 for ; Tue, 06 May 2025 02:01:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1746522117; x=1747126917; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hzbCIL5EmcrHi3mTAUSbK1a5S0Wxm64DnLguO1BXQQU=; b=y5IjZGwMxnkFQ0uj8yUwyBnp7WVt5E0BRkpni/NjTYjlTh7Iazi135MNNBdPgN8lWh 8DkBGpTwbfLctSnJzDftEg/oqQpHEZRjxYSuFdDd2o3FpvSfZ+kcP0l2SFhr8CtBa0LG WBpLrqkc+LR5p5r4Vev68VR4+nxEwoU1AFHhAZjKMTmkkytliQ5t2j3gjJ3LEUT6rNEt zGKL0jpuX8dNc4npvtiIf4lIumUKkj35qE+rPzbfXZ/aCwxPMNzSi1o138EXrQXQgsCi tC70FSY29EyumSsQasZ0m/I8iBbq6tOJUSpfRW9/rP8NDlPh2Nak2XwOTScwQqX46YWl dmsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746522117; x=1747126917; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hzbCIL5EmcrHi3mTAUSbK1a5S0Wxm64DnLguO1BXQQU=; b=aqX6BAQucMgn7iNce4fhNGHtxa8Mhk9MDJWWbya85SbPulVzVBs/4T4ILVT9RiPsBw bnqCawh7JhcADORbBcn9KgBQRyZesaw8Ms9dBAyYihLczLCngHrHLRNT8i4JFcPwmIm9 uh4gO0AFX9If0LrwM5uGUdUxfX7pp7TjX5Z/j+/3/wgNaAP5b+Rw07uWkWSoQm3/jgzL 8zRIzoBPBE4htT3kP4ojM2A0hwTmBt0JtcsVPtVVusa6v3sH/rX5XLdAd3x+HcUCuKkq u1pbDWUAW4u+aSo+YqICCcHKhdkTUmUGHxajnPh4vdyDwqZv25xRXbiDsz3JEZaGVM1H 5p0w== X-Forwarded-Encrypted: i=1; AJvYcCUnBaAQ5gENyPxPDqBI1pxtbL7+QDcCQNfFS5T3Aw/YhLu6E2gHye+JgHLQlV0CS5n6cuKgj3+QTBO99x0=@vger.kernel.org X-Gm-Message-State: AOJu0YwsoTicgf8UYTwYa+HiOVYM82QhSC1fGAZTHrpv7S6PJ/g5kqIj Ov90nXSaZHIyA7moFqFBqS7ruo1/6331ia5iic0J5Co9+G+CyaLgHQjZ6lxRWiCpATRwdoeVkI+ A X-Gm-Gg: ASbGncthIilwY0WgMdogZZSRFDmMVC1xATlAvreSMTpGThdqOZjW4IC8ZLDOJCOoAEo tM1F6B5kKylcolRxBOCcC5EwraFTB1HucNhfgRu4DCtDbTBRBJyKxESywOkeJEsX1WkDZzpSsBC kDk1ZoGlHPeA443XnyfKaiycsdKh+/gO/VQZVykUOlogMsJMClsKwRJersLFh6W1B9hqrq1HIAi ERLANEnYdmp3YvCPc6s5FkRZFueXBNerZFM0oq96QE0U3npozZZh+/nnsaZXdbZV2ngUWnMg1uD d2u88U8iUIcfqttUUy5mIXaUZVYSQS0ICdA= X-Google-Smtp-Source: AGHT+IGgnwi/HajGwBN2etEehTpEfYXl+12hvkBZaP+MY4NtXZEvU51wQ1BmWfxWVuZOtYDPaafmGQ== X-Received: by 2002:a05:600c:870c:b0:43c:f61e:6ea8 with SMTP id 5b1f17b1804b1-441c48b0293mr95619375e9.2.1746522117202; Tue, 06 May 2025 02:01:57 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:bfd0:3ad7:fd8a:fe95]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441bc83d471sm138125725e9.26.2025.05.06.02.01.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 May 2025 02:01:56 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 06 May 2025 11:01:47 +0200 Subject: [PATCH 04/12] gpio: lpc32xx: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250506-gpiochip-set-rv-gpio-part3-v1-4-0fbdea5a9667@linaro.org> References: <20250506-gpiochip-set-rv-gpio-part3-v1-0-0fbdea5a9667@linaro.org> In-Reply-To: <20250506-gpiochip-set-rv-gpio-part3-v1-0-0fbdea5a9667@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Vladimir Zapolskiy , Piotr Wojtaszczyk , Charles Keepax , Richard Fitzgerald , Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=3802; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=pkwKmHhImUif17/jZfTfBMk3jt1SPyMBx6Ss/hErFtg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoGc/9TJ55lbmkFhoanmnEostEI47tL6hoIvYnL ZZagsOqxo6JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaBnP/QAKCRARpy6gFHHX ct1QEAC423y9clg9nGV1YeByPJgeWj0gMw56ZFNdnyyMycEv3OSni1/WHQkvTTCQFt8E1qq7b/F 6xhGCoM/JqbCjOGU9mCTIv2WeeSa7l2AknIRXh0ZkvEd2FghdLwtj9Wm67vEXZ55TDva/H1vZ0s 8CPBER8+RCKw7XgM+69mvkJWqryrpun0ZTxG2mG/+6LMLFOB5oSNVhtcoTsMp0tRUkvxzuzp7WA 8cYw//hoLHjPizzikrb2hL0VNSxUTBPng/Kwz52q4AtH9anIm4EQ4FepkyQl8hMeljpBLU8OIoj IJYc1ZP7RPRsKOtdIgUgAQFzAFmBuOlT1uudjCpC3lSkp1iavqrp33+oHwYyKXli88bW6JVVNN4 JgV6huyPI/62eFf/NmMrwLmniamsI6Jebb6J8zq5QJbM/XH5flRznoYFzaJkxTFeH4vdR7AeqIJ KunX2Fx46t8qItztrc95vcyygKaK9KZWJTjxSJAqz52jAW8hcoP1ui6txBNde6Zuwmm9xepQfJR P+ZCRkbEVhQ2azeYr1hkGl6JHTulaGxuykZlI33bsmw28EtPYBHjknlyz8X0JciXIOi9+HR/SJB fMi4/Ly0G9I4Y2I0gepTijxupA9E+Wv6Ps5L8AlBdaoeWDZ8JZxNpbA0cFatfxf0fqSX7IQRio4 TYfKXfSySfvZL/g== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-lpc32xx.c | 28 +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/drivers/gpio/gpio-lpc32xx.c b/drivers/gpio/gpio-lpc32xx.c index c097e310c9e84..6668b8bd9f1ea 100644 --- a/drivers/gpio/gpio-lpc32xx.c +++ b/drivers/gpio/gpio-lpc32xx.c @@ -340,28 +340,34 @@ static int lpc32xx_gpio_dir_out_always(struct gpio_ch= ip *chip, unsigned pin, return 0; } =20 -static void lpc32xx_gpio_set_value_p012(struct gpio_chip *chip, unsigned p= in, - int value) +static int lpc32xx_gpio_set_value_p012(struct gpio_chip *chip, + unsigned int pin, int value) { struct lpc32xx_gpio_chip *group =3D gpiochip_get_data(chip); =20 __set_gpio_level_p012(group, pin, value); + + return 0; } =20 -static void lpc32xx_gpio_set_value_p3(struct gpio_chip *chip, unsigned pin, - int value) +static int lpc32xx_gpio_set_value_p3(struct gpio_chip *chip, + unsigned int pin, int value) { struct lpc32xx_gpio_chip *group =3D gpiochip_get_data(chip); =20 __set_gpio_level_p3(group, pin, value); + + return 0; } =20 -static void lpc32xx_gpo_set_value(struct gpio_chip *chip, unsigned pin, - int value) +static int lpc32xx_gpo_set_value(struct gpio_chip *chip, unsigned int pin, + int value) { struct lpc32xx_gpio_chip *group =3D gpiochip_get_data(chip); =20 __set_gpo_level_p3(group, pin, value); + + return 0; } =20 static int lpc32xx_gpo_get_value(struct gpio_chip *chip, unsigned pin) @@ -401,7 +407,7 @@ static struct lpc32xx_gpio_chip lpc32xx_gpiochip[] =3D { .direction_input =3D lpc32xx_gpio_dir_input_p012, .get =3D lpc32xx_gpio_get_value_p012, .direction_output =3D lpc32xx_gpio_dir_output_p012, - .set =3D lpc32xx_gpio_set_value_p012, + .set_rv =3D lpc32xx_gpio_set_value_p012, .request =3D lpc32xx_gpio_request, .to_irq =3D lpc32xx_gpio_to_irq_p01, .base =3D LPC32XX_GPIO_P0_GRP, @@ -417,7 +423,7 @@ static struct lpc32xx_gpio_chip lpc32xx_gpiochip[] =3D { .direction_input =3D lpc32xx_gpio_dir_input_p012, .get =3D lpc32xx_gpio_get_value_p012, .direction_output =3D lpc32xx_gpio_dir_output_p012, - .set =3D lpc32xx_gpio_set_value_p012, + .set_rv =3D lpc32xx_gpio_set_value_p012, .request =3D lpc32xx_gpio_request, .to_irq =3D lpc32xx_gpio_to_irq_p01, .base =3D LPC32XX_GPIO_P1_GRP, @@ -433,7 +439,7 @@ static struct lpc32xx_gpio_chip lpc32xx_gpiochip[] =3D { .direction_input =3D lpc32xx_gpio_dir_input_p012, .get =3D lpc32xx_gpio_get_value_p012, .direction_output =3D lpc32xx_gpio_dir_output_p012, - .set =3D lpc32xx_gpio_set_value_p012, + .set_rv =3D lpc32xx_gpio_set_value_p012, .request =3D lpc32xx_gpio_request, .base =3D LPC32XX_GPIO_P2_GRP, .ngpio =3D LPC32XX_GPIO_P2_MAX, @@ -448,7 +454,7 @@ static struct lpc32xx_gpio_chip lpc32xx_gpiochip[] =3D { .direction_input =3D lpc32xx_gpio_dir_input_p3, .get =3D lpc32xx_gpio_get_value_p3, .direction_output =3D lpc32xx_gpio_dir_output_p3, - .set =3D lpc32xx_gpio_set_value_p3, + .set_rv =3D lpc32xx_gpio_set_value_p3, .request =3D lpc32xx_gpio_request, .to_irq =3D lpc32xx_gpio_to_irq_gpio_p3, .base =3D LPC32XX_GPIO_P3_GRP, @@ -476,7 +482,7 @@ static struct lpc32xx_gpio_chip lpc32xx_gpiochip[] =3D { .chip =3D { .label =3D "gpo_p3", .direction_output =3D lpc32xx_gpio_dir_out_always, - .set =3D lpc32xx_gpo_set_value, + .set_rv =3D lpc32xx_gpo_set_value, .get =3D lpc32xx_gpo_get_value, .request =3D lpc32xx_gpio_request, .base =3D LPC32XX_GPO_P3_GRP, --=20 2.45.2 From nobody Tue Dec 16 15:24:59 2025 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 801CA264A7C for ; Tue, 6 May 2025 09:02:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746522122; cv=none; b=lWw9Ae3s4L3fuNG1IG4Z577I4SeJdE65he4QN2rTD8e84slYOzwjce5xD54JeblITy6tMOwlih2Y+UkJEV1jnZqhsyrpLpPW9Fzv4UYi8ptc1yCCd6z2iva1jcbKjHFWQ7/n5wgtcor/lca6vPGL+YCOSs7opphwrpjJUIIOZ+o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746522122; c=relaxed/simple; bh=/euti+QuooeNdB+WdZUjDlGE6JGFo/o5Aun83gK9Nww=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EEwEejk7EasQFJPsU3JDCUC2f08+/FW3IBp9+LlnUsl9zNx/c4G8daVBUmFOmeyA8ukvK3Ku4eWUAmvJwuCUMJAbpDlqzOQhKTbBhGLS8zW7sAAS6PjSdOHyVJo9TQQBXMZwwAFhXDzOtg7qv5xtdDvUHTK7kJoCKW6N+caQki8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=bMiGOidQ; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="bMiGOidQ" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-441ab63a415so53419625e9.3 for ; Tue, 06 May 2025 02:02:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1746522118; x=1747126918; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=0yY34Nsc7/2UlbzCskK3g4iLw+MDnwVImSZrJoLfm7I=; b=bMiGOidQ+oEdZHJ/IiwTPDM+zhtGtrmvnbojczCBzeLJ7ejRe159xq+RSLhsVcz73C bK0XcwJeWl++EZPvtvs32B7aJBt0gpOoVhZPiD2dvF1jjYt9LGpPHaJ5zBv7knq/Yl0w XKSm9qqPY9Rb3RKgcXB7p1pQcGUdK1bqKBM4w/DMyz72mCdS39NFev7Kxytol1aRxNqP R3A83QbxvnvLixgp4WQxEcKyE+zx2lQDSWRyMpF3oLjxOnVOVllZb5iDgzVwxyi96ADQ jMgL5cvdzQyyiRLE/+/vsgieUjpHFQ3RmDcH19cQ1LtLZtm89E+oVUIgzRP/jkqbphu5 SnkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746522118; x=1747126918; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0yY34Nsc7/2UlbzCskK3g4iLw+MDnwVImSZrJoLfm7I=; b=boawyI2FHIHvb0Dh05lNu9+/vylRsFD2nDGpn9ByEEeg556Fr2FropnteJsibeGozJ 967ugjCojP8toYqMsL0aoI4mKki3Riprr4Sx3PL08HUghEwXgZW/0y0lBzNsK1yvQ3/O BEt+Uok2rsGM2vT7UrzcPQfBGd3dkcwYkop+qcoOLIqiqLezOyqccgGuiXoUiWORZP7j 2R+/ZNiiAkI4mpGixfqKhbTnwdMZOtiV1N9x5EBTOFV+F3gqXpMEflMfbXW7sqav1ABw 5bkVfVIIF4dxYX5SmdUwigCfvwbN3CqMdGNfSQm6Npj0XHCzAWjRk4TefqgeMCQxd1FG rQ+g== X-Forwarded-Encrypted: i=1; AJvYcCU6+GqDW0j3oRiMgNN6gLZfbdS778rASOq8tR/3i/MhLEhwsnamQnAUe7Y9mSKCGVXfRHj9/MAyZtTJh8Y=@vger.kernel.org X-Gm-Message-State: AOJu0YyMWyqG1Z/zNrdQ/fV+zHeNvXviLiu/hChbZACfKR+Cjx6u0UDA ZH62aNFVkUlGmHQQFa7xIq0F+hAYJkmkqx+2tnPN/Jx37/l1+Ma1kJv8JlbJZashujDFEKpT87M D X-Gm-Gg: ASbGnctqUP6UkwbeiZhlZX/7W5XsjZ583dBT/DUoVHd0nhcMvB5OF7n9siybL1p6z7a y2j9m4MlojmAsblAy3AzqrSdDETwMV0LI3gucc/yG1AhXGVThBwOs9aUJQwj8vb+Js58C4wT3pD nMAyuxeQ3yh7G26jaFMEXjzkknolFN2imp0P/6GsDKUQNnGTyJHZ51kWa8UCaJQJkSM41hHz5Im jZj1CEUz558qMQflmGzl/9venHEKRkTeqI+S8CpW1L7umKdBTy8HyTHbsnv/TxzeSrY+FJLJ2m7 ehnQ4/dJAlMH1qZ9En3aowUV5R5QBuDAk7Y= X-Google-Smtp-Source: AGHT+IHlrqVIs5Aw286+uquukoDPpnOG8CuGZuW/5Q7O+V4/Xk4pBW6x/ZhR+RATXx4lWatFtAIZYQ== X-Received: by 2002:a05:600c:3c9b:b0:43c:efed:733e with SMTP id 5b1f17b1804b1-441d0fcd574mr18810665e9.14.1746522118135; Tue, 06 May 2025 02:01:58 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:bfd0:3ad7:fd8a:fe95]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441bc83d471sm138125725e9.26.2025.05.06.02.01.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 May 2025 02:01:57 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 06 May 2025 11:01:48 +0200 Subject: [PATCH 05/12] gpio: madera: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250506-gpiochip-set-rv-gpio-part3-v1-5-0fbdea5a9667@linaro.org> References: <20250506-gpiochip-set-rv-gpio-part3-v1-0-0fbdea5a9667@linaro.org> In-Reply-To: <20250506-gpiochip-set-rv-gpio-part3-v1-0-0fbdea5a9667@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Vladimir Zapolskiy , Piotr Wojtaszczyk , Charles Keepax , Richard Fitzgerald , Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1886; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=VRF/3N1EVGTtM6WG9zf061j9Cu7jjnguKsupmm1lpOk=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoGc/9HAJpDoBjHPguAUrkQ2bywcX0IE4BkH72+ gedeertAESJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaBnP/QAKCRARpy6gFHHX cmW4D/wN/rp+VApidRjxuIIZZuw5p6GCIcK7pifUdrQJgNqrwknypL7yMfOuZhfzvGJtf7Pt0aZ ANnCXCR6wj0ZptCeqhSAN4cR+cB3sqy/D7AiVjPwEF/dHzLauvNZviX4DqjpkfpZ/cHVp61q5cP pS5dluslaLUqUlJhpN47WpCdZAfy0LEyMgGPjyjWJvB7+m3kTf6il/Pt22y7Y5QJkqbLp2rvsIl kYltmOq2+ZDnlt+FTSrM0zpOBmnLsOe9lmXeeSlIlb8wJdbOtzLM6aAKDcNj1UrOUKW/6yNnxrT HKbqSA3kIr3QGEE29jBCD8sdNysAsSYvXIr0BSmDJmVL5GZihzsPl+v4ghss5DB5yj7HJ+P6Bv8 bThnZPd+f4niokXgcKGD87GalnGPCESS63IjePPCIQ//CLa9cgZMWIw3drkFkYZIROYxscxwf1B lPIwm9ptXGE6IDQeAYZckd2EwXftyWs9WBoC9bHaQ+oxeOxLdqmEqqHqofitTxT2r3iBGEDEXba tFcGhWZyg5Aac7bGW37Qs9QkLEO9Q7pf7drBBnXLqux2qfVqCU+HY+oebMQc7MmO2DSAqGvPQPV a7HASDWQuejDmEfxkjjye+/Aj4H3A2M9Xhvc0BqfgUB2pXj2FvhWMKiRqisY+FrAzGjcASUDc05 p3o05soZ+uWZTXw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Charles Keepax --- drivers/gpio/gpio-madera.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/gpio/gpio-madera.c b/drivers/gpio/gpio-madera.c index 8f38303fcbc4a..e73e72d62bc8d 100644 --- a/drivers/gpio/gpio-madera.c +++ b/drivers/gpio/gpio-madera.c @@ -87,23 +87,17 @@ static int madera_gpio_direction_out(struct gpio_chip *= chip, MADERA_GP1_LVL_MASK, reg_val); } =20 -static void madera_gpio_set(struct gpio_chip *chip, unsigned int offset, - int value) +static int madera_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct madera_gpio *madera_gpio =3D gpiochip_get_data(chip); struct madera *madera =3D madera_gpio->madera; unsigned int reg_offset =3D 2 * offset; unsigned int reg_val =3D value ? MADERA_GP1_LVL : 0; - int ret; =20 - ret =3D regmap_update_bits(madera->regmap, - MADERA_GPIO1_CTRL_1 + reg_offset, - MADERA_GP1_LVL_MASK, reg_val); - - /* set() doesn't return an error so log a warning */ - if (ret) - dev_warn(madera->dev, "Failed to write to 0x%x (%d)\n", - MADERA_GPIO1_CTRL_1 + reg_offset, ret); + return regmap_update_bits(madera->regmap, + MADERA_GPIO1_CTRL_1 + reg_offset, + MADERA_GP1_LVL_MASK, reg_val); } =20 static const struct gpio_chip madera_gpio_chip =3D { @@ -115,7 +109,7 @@ static const struct gpio_chip madera_gpio_chip =3D { .direction_input =3D madera_gpio_direction_in, .get =3D madera_gpio_get, .direction_output =3D madera_gpio_direction_out, - .set =3D madera_gpio_set, + .set_rv =3D madera_gpio_set, .set_config =3D gpiochip_generic_config, .can_sleep =3D true, }; --=20 2.45.2 From nobody Tue Dec 16 15:24:59 2025 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DCFA26C3AA for ; Tue, 6 May 2025 09:02:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746522123; cv=none; b=usUuFBF/EMMZbFaA7wzY3E0sI8peNS7xvlOHl+RtKdkjh5IH63Ou8ce+/NLMK3NwLTKWAK8a/Sm1uut43rT6ypt5bSTo1bmnGCpHLdCx0YU3rG9dVrgSiLWQCUcrAhhAJxDwmBZu4RkuRr//iAYY0+u5a1oEtvoSgJefLg9TVLQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746522123; c=relaxed/simple; bh=J9Yj8CedNMj5JM6ni24l2rshEZjkmfXOzVX7kgR0zdU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=skq3I3jb2XIa7T2gQ6SIdOO5GjIFIHvsyVig60oPpmYE999QibdBVOwIUNFuOw5kjixfc4MeaRrvcwQrB0XdrBnCX4tXaQruxWZZNWzV8mgPy5hEMSdPLS6Q3NkSbTz3W7it4LDkqaqQ2i1l+/7dno/H4pQNVXFKjiK0aCsw4cI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=wZKt+1lC; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="wZKt+1lC" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-441d1ed82dbso2469975e9.0 for ; Tue, 06 May 2025 02:02:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1746522119; x=1747126919; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ZqmuA8vzWG7JwGdGuncL1WKx+Z40oy7BuFrvWPOr8LE=; b=wZKt+1lCx9UFftWQ/Z1O8FzSDDfMRgh/gjJY3kzuJ5F2+yNiMmMnau4X3cLEuccVMV 7SbVA2v7iBp96KOYxJ+WFoszrPCQGKQoT+pNFGCHy/K12cf7Gbcb9jgFgSP9p8VtkfoT 7X9tqx6j/oNNB4HdBLUr48iUcqZCOnobbyXZlPR2Qrsa9VPn5EPwZ8+5CtwpggcdXbX7 SqVHDFIMzV/lR/m58AluR4qIekSFmcz63RoyjT6hCc1mrJU/FXEZo+qKb0miIKqhilEl iFGUez7gHgar28z01/yy/DrKVdbqmltn2IVyTBtKELVeyPS/0Fl1KMBMo/KcxqKk+PBN MTXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746522119; x=1747126919; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZqmuA8vzWG7JwGdGuncL1WKx+Z40oy7BuFrvWPOr8LE=; b=noA31rCIzJKxDhKmxTJYFBJZArAU+oTjB5iZAWlFwADf9CB3E8DZ/aBC6vqv/+m/M7 2R+2VCOh6vg7gxhS8Lyzto4Hyu6yyd8cbaHUXgv4tthiIrwrTCpQmPOPTMC16zPWMxAD 9oMi+ra7dSETnomTmOEofRY1Bq5Pm77STHJaAfoJuLoj8nx1NTD5ECs3Wwi3q3O9NlY9 +Qb3wJa7jl6JIgF2sm416THCHjnysCNJW7Pw3AlahhqbMQfIxl3GIgyYXcSmIZdqzSVk /n7BsKJeb67RhQu2KWO46fieeOj6EhNgdItVYZ5Sbd66n6a+6+N5o6zkSA2fDDC+npPr Ae9g== X-Forwarded-Encrypted: i=1; AJvYcCWlzi5Wj743dGAA9n/+x3Rx0QrNaC9femaA1lNFGGOGNxPygJGWdsMd/oZm9ITzaqUA47MHtF1pYpekuMI=@vger.kernel.org X-Gm-Message-State: AOJu0YzdxgrceukjOmMNFRZwSANtX8AB0LVwjg3Mjjr1PiIT3YDTuVCJ C+OrzLEimWbjf+jEBcGD7l7bxhqz5exP1ExzItL396ctS5uxh4CjBSmQUABPx57dIkRWqZGjspt + X-Gm-Gg: ASbGncsxCBQF/l1A+rWfPJsvh6ab3DtDVKE/6j6q0ZtJparIO8m+4isV09iG+dydmdz +rUr+N9BzzJG9n3lrHSCuHB+kp7JOxhv4O2P4kkKiVM4LFwfZ7fsXG/Rrs8cVFiY2rugrbqcL27 DHTYUGWZntY5MtzFalc6k0jao7yxj5fjfx9FfynlpuXVhfixnic3VOdk2tImAHVl150K4zbilPN 09qjEt8Tld/nwejccw3oPSvCwONBO7jDo+crowq9dLpBmz8w1Mf5G7QbYi4f2v+nm27Nf/Uoedx eUYq/6eLO1Y11RFRDjulC9Dob11KoKjPTdY= X-Google-Smtp-Source: AGHT+IE8JUabBzKM92O/84MQPWd1WLHM3XpE0TI2Ymwc3HYRvwGlfQk0QZso0kEgfuXzy3SeMbuyHQ== X-Received: by 2002:a05:600c:5105:b0:43c:e7a7:aea0 with SMTP id 5b1f17b1804b1-441d100a80emr16950635e9.26.1746522119581; Tue, 06 May 2025 02:01:59 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:bfd0:3ad7:fd8a:fe95]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441bc83d471sm138125725e9.26.2025.05.06.02.01.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 May 2025 02:01:58 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 06 May 2025 11:01:49 +0200 Subject: [PATCH 06/12] gpio: max3191x: remove unused callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250506-gpiochip-set-rv-gpio-part3-v1-6-0fbdea5a9667@linaro.org> References: <20250506-gpiochip-set-rv-gpio-part3-v1-0-0fbdea5a9667@linaro.org> In-Reply-To: <20250506-gpiochip-set-rv-gpio-part3-v1-0-0fbdea5a9667@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Vladimir Zapolskiy , Piotr Wojtaszczyk , Charles Keepax , Richard Fitzgerald , Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1591; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=uCZv0LrEzy8ud4KkWpNsBzdnLQeoymZc1NVUk4tf4VQ=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoGc/+AppL2eFtEqFE/Vs0gNp1cXoYKuSQEWvx1 S2/TAMByK2JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaBnP/gAKCRARpy6gFHHX cq5HD/9HyaQrVcRS2SmjLzWGPQc6hSa3wPn27qklXKNgMw8ZoMukH+bqB5mfDRtM6NUrmQD4x7M 3vd98abOWOBCZkKheY5mu84Ems1rxlmXI9p1M/Zi4lsYf26yT+Pt4dbMt/ZNXxNxFaF/XMUTQe2 o+4aglfuV0lO3tHfmy7c9dLk8qEEiHXETDfcpHCJnB+BqDgz8aWwfrQYgMFDbXeTO/FVnBZp8Fw SutR3wH+u4ac6VY0sIXN3Zz35TrYg0bWElply7PdiJlVUty2whyWhAGt5YnI16f2OYymRDpb7I5 nNntQtwTa0J8zJ1ArYsW6JaXlIYdBsdM8nXtqdavnT2FmMHLoIk+4CIzaWZ+PcEq5zBLzXWDPYT dZRSIwtUKeHxwJfN4T1yaZcF+WXGR5df4XTKfGEJ47Q3CtrRSClqXFT0kxNZvdgB+ovjRkStec+ LHnqrVYf08eaSeSstqga6tksa7JA5HKAawG7Qr0ThwJmZ29w0HPY+VdzuNyB85PReUluYKkVlLS K75yhDoPQtYTnzkIyjpatRNoJ0whVIQaycWgTndtZlo0/Slg6lDwbN8eehGu5o9UVC2z1nSnWI3 PaftfnkHNsifK6ahgdM/84ynLS728hSV0wOAmsiykjd9W49dktGiYn/5XHdBEKEuciZvq77o4oU 02XZNAgeT4PdUwA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski This driver is input-only and as such doesn't need to define empty set() and direction_output() callbacks. Remove them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-max3191x.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/drivers/gpio/gpio-max3191x.c b/drivers/gpio/gpio-max3191x.c index fc0708ab5192b..6e6504ab740a4 100644 --- a/drivers/gpio/gpio-max3191x.c +++ b/drivers/gpio/gpio-max3191x.c @@ -103,19 +103,6 @@ static int max3191x_direction_input(struct gpio_chip *= gpio, unsigned int offset) return 0; } =20 -static int max3191x_direction_output(struct gpio_chip *gpio, - unsigned int offset, int value) -{ - return -EINVAL; -} - -static void max3191x_set(struct gpio_chip *gpio, unsigned int offset, int = value) -{ } - -static void max3191x_set_multiple(struct gpio_chip *gpio, unsigned long *m= ask, - unsigned long *bits) -{ } - static unsigned int max3191x_wordlen(struct max3191x_chip *max3191x) { return max3191x->mode =3D=3D STATUS_BYTE_ENABLED ? 2 : 1; @@ -421,9 +408,6 @@ static int max3191x_probe(struct spi_device *spi) =20 max3191x->gpio.get_direction =3D max3191x_get_direction; max3191x->gpio.direction_input =3D max3191x_direction_input; - max3191x->gpio.direction_output =3D max3191x_direction_output; - max3191x->gpio.set =3D max3191x_set; - max3191x->gpio.set_multiple =3D max3191x_set_multiple; max3191x->gpio.get =3D max3191x_get; max3191x->gpio.get_multiple =3D max3191x_get_multiple; max3191x->gpio.set_config =3D max3191x_set_config; --=20 2.45.2 From nobody Tue Dec 16 15:24:59 2025 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C801426E16F for ; Tue, 6 May 2025 09:02:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746522124; cv=none; b=JA4qPLOzMVnmH0RfLjUz1MO/wCuOOEsfHBVSL9qtTDkoZzyfsJNF5x7aCtsL0GbLMSMX452aebBw8CYfGqbiNr7OikR+NhwkKwObHNbbpN4Ewb03Dwceqrn7Ys875zTmytrrD2p6eGycsyGzvaPNnoDhgDw6MF3Z61wC2xJPn08= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746522124; c=relaxed/simple; bh=XH/0XVuO7qOBuaRm9fMchaz5m5bawJAXac5HMn3Z4GY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=A80kjJWEr8+jzyfWyIscCVjV7QAsDIw/sDtcKSGBjSLBq/zCNfoe1UYUYSjoi67WWtlqg87dhm020G+i+E02uogC7q6xh21mhk3UbUYQD04zwdIeIIkYOXvKCXeAHbo1UMgauc7D66ZsUnjOa5mlgjvzLfeXZ9oaNexoWp7i7P4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=XHbTKbQZ; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="XHbTKbQZ" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-39129fc51f8so3488241f8f.0 for ; Tue, 06 May 2025 02:02:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1746522121; x=1747126921; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CO0TStYciJkxVrEVhFTekbwNrwQKqZ04D9RRPnQx4NI=; b=XHbTKbQZj8k89p++tV5ogn8czxk10OCH4nJ+ZLSdK3PZMdirktdcuNAOZizMheyWdZ kUDPbuNiEJQvT/Ia3xMDCPPHutUXHikdp8YILDVK0kXMwX+YTqvmTCgex0nAJ7VIsL4i PowY8NYHBcV368CDi+d6xUF8PjovrBy6aYkhj2svDHE/Yu+KdpmRHO2K87ECI0+pvzRo mj27xXq2dedUswOaLrJLfDrwtolKgkHO1iUiH0QDhlCzPZPRHYYCXlccxsdiCSH7VLg5 8uvnCud3fH6LwSXOBuDwM54UlFJ/2QxknbS443rE7hk3tAUNzxK9/7N9KKGujSreFOYb 918g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746522121; x=1747126921; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CO0TStYciJkxVrEVhFTekbwNrwQKqZ04D9RRPnQx4NI=; b=V/tqBTxDUlKkiLCmxfNq3hdbImui2IO4Plsbm3UAlEhlNGD0WY+KQrfHaedOUtWTMc wrGAPurJRTKFSy4SSIzzNeRWLilVvVHnDCw2/eGEfarQNvHpz+9DOiKKEu+Tme7tOIiO i8reDPVhyru50cbBx7h7QGqeg7DM/knun3RK4JQ5Ea8jktvF1uxlYvma85Vwxqym5KxK oyXpOkF+G2LXzM5DGtehFNdMDorRzB1K5OqDuBmX27AbdZB/5cEoeW5vK0hPRZ6g+R2k 9jbLc+1ZMhlnz98DH9CFLSq4wkNljYgd35acviZ2gwnqbzJfgFRS6n7p+Sa+pwpaHIzl u6bQ== X-Forwarded-Encrypted: i=1; AJvYcCVTN9BugZZaLM1+8wXmgU6i3WeHyvBbCfHSHCT447kMYdJOheswPwxKnptpim2z5XXnrNAP0KvDIlHbu1c=@vger.kernel.org X-Gm-Message-State: AOJu0YzBpXCmtfE07jsvcvMfDtHLRWtuJwzImEXvkmYWLJa4T9sN6v3J K/J7bhCGC8UGf0sU/mKTxyOCpZ2os95WUy6JeL3Y7oMaZaemYUwcFgP7COtTGbc0uv9SqiBDKQJ e X-Gm-Gg: ASbGncvuj2TgvtQ3drPuiHGgGInPg74x7MQooR3FELlgNFoKMohiq8Vd1N/V2laP/ng 7pfTLAiInyMKshl4vNSnCk7P8kjw9qYpLvoWv/yYUJT3ZmAxf353Ryvl637I/GLfBIoH5TfKMlc Xxr1JwpwI1WRrq5yLLSkbRbtzlfEDQTSWsTxTPuZghqR3/Tdm98cIbp9yfy20XfK9Nbs+jTBGZP cCDvRoNumIIwm6hGI1EUCM1arbCDer6GwAghXvgPf07uyWqQA1UOBnOld5GxQvb46+NFwy7cETZ gdQdBBYE+ij7/mwxokTEY44mHFjMyMdDADc= X-Google-Smtp-Source: AGHT+IElhv2wXvdZWe2BSaVQF6FOWYHmUMWsGXgp9L0VyKZ+PRC8C1pEa8f8v6TOsPJ2duwzmaV3Gg== X-Received: by 2002:a5d:47c7:0:b0:39d:724f:a8ae with SMTP id ffacd0b85a97d-3a09fd9a77cmr8078099f8f.33.1746522120559; Tue, 06 May 2025 02:02:00 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:bfd0:3ad7:fd8a:fe95]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441bc83d471sm138125725e9.26.2025.05.06.02.01.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 May 2025 02:02:00 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 06 May 2025 11:01:50 +0200 Subject: [PATCH 07/12] gpio: max730x: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250506-gpiochip-set-rv-gpio-part3-v1-7-0fbdea5a9667@linaro.org> References: <20250506-gpiochip-set-rv-gpio-part3-v1-0-0fbdea5a9667@linaro.org> In-Reply-To: <20250506-gpiochip-set-rv-gpio-part3-v1-0-0fbdea5a9667@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Vladimir Zapolskiy , Piotr Wojtaszczyk , Charles Keepax , Richard Fitzgerald , Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1472; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=C5mTxUoTZPoD+BYVxin9KA6rS3qrIxYM91GYOHN0blw=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoGc/+9uVpoftEKtklCkxpA9QpLMSMlQ3zO+VCP JvYVtcusGyJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaBnP/gAKCRARpy6gFHHX crEqEACZiG048DnwbwoC7fKykT2HjmLlxGLUX+fOdkrVU4deU6eW5TBlgxOQkJPjFJiyoH62ZmB C/K/BY0xA2mtQYv0bhFzB+feuOq987JHl/stxocmaMoovOFz/uHyGOcAa2SfN5Lpfyw1XGIiFsB Io9NBYkF1Mv24CWFZlJcmu+Sf+GxeocPLW8Uab+Y1zQ8gqs8RuhnT2r+MzDpEEqX5cui+zkHFIf MiaMheSndz0bOIZJAgqzwVZADh3BBUG19tkWHT8S024LjDJ0mFn+ozP7n/f+N6d5soMTwhbbg+A QSW3JGZUtwrOnoT48SHITN6E+4QTNPWoG9bVpgpI9OrwQ6H56XnzswAsrpxdsElw9FNoiwpo56+ IW7Iannd1gMlFBAmcDb9maEt2zD8MDdhv7IHV6g0BtJ+UvGgYrVETOjMYJpVJfqepWEwXWB1hvb jqtDvVu11/h44dejZHJKC7wouv3+oPEimede/G9wLY1CLX9UwMj24m6gAKpNbQ7/y/2Yi+UmiqY 3pQFKze/tDjxRP3DycPAFPAv5ndpCC0t+oESotdZ2V7lMKGbFFdFg12/FQwGSBQJClCMa4IiTHA hiGrXFn5gFnbgXm5UJRga7lUvJscYCjwKSyRhuQidCfq+Uf9vnR8KpSELqboZrtwKj9ax0nWL10 f4/nsoY5wR+SYgw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-max730x.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-max730x.c b/drivers/gpio/gpio-max730x.c index e688c13c8cc32..75d414d8c992a 100644 --- a/drivers/gpio/gpio-max730x.c +++ b/drivers/gpio/gpio-max730x.c @@ -143,18 +143,21 @@ static int max7301_get(struct gpio_chip *chip, unsign= ed offset) return level; } =20 -static void max7301_set(struct gpio_chip *chip, unsigned offset, int value) +static int max7301_set(struct gpio_chip *chip, unsigned int offset, int va= lue) { struct max7301 *ts =3D gpiochip_get_data(chip); + int ret; =20 /* First 4 pins are unused in the controller */ offset +=3D 4; =20 mutex_lock(&ts->lock); =20 - __max7301_set(ts, offset, value); + ret =3D __max7301_set(ts, offset, value); =20 mutex_unlock(&ts->lock); + + return ret; } =20 int __max730x_probe(struct max7301 *ts) @@ -185,7 +188,7 @@ int __max730x_probe(struct max7301 *ts) ts->chip.direction_input =3D max7301_direction_input; ts->chip.get =3D max7301_get; ts->chip.direction_output =3D max7301_direction_output; - ts->chip.set =3D max7301_set; + ts->chip.set_rv =3D max7301_set; =20 ts->chip.ngpio =3D PIN_NUMBER; ts->chip.can_sleep =3D true; --=20 2.45.2 From nobody Tue Dec 16 15:24:59 2025 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE29226FD8A for ; Tue, 6 May 2025 09:02:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746522125; cv=none; b=RyJQgY7FxJELsTeSsp+iSgDRvnTeMAbPSPmqEdM8NRUA8eGmYMmTAorZPQEn9XpQpW9YZAYoO8JSegGDCH8mxwd+uvHAiozb69SWSmCngIWQmkXMP71r4fQTE7wHJe++WwXrSK9nJ2krLeEP/Zze/AjY7AcIp1BMwml76TWYaQM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746522125; c=relaxed/simple; bh=Ecb96MKrbu/U0qaUA60xpSbdiSPpwxoaioMHdflsb+M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=n3soNcERMH1tmpYaGTv79dtMIvcY1v7iC8d9nGwCvUtTTYXRw/YTtoDnm3KYxtL1GNYKrDzBMeGF15+P5a9yM+ap7gJUDsl3gbXUEMlcnywHdarPv6gwbY714DN0wNBo9gdSgB8FmykDc+jVT0UF47ORjaxs/JeufrjeNxBkmFM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=PfTp06xu; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="PfTp06xu" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-43cfdc2c8c9so23408455e9.2 for ; Tue, 06 May 2025 02:02:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1746522121; x=1747126921; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=u71xXPv2Cn7JbdcKCIhenriwZi9FR0pSz159YD5Hm9o=; b=PfTp06xulO890+cmpTi6exzsccago4kvTVni/qKSxagGopI/Arlz6r36ovftl0Ihfj qrnKX7SNtfBF4Q5omsvLxVSod11lq8/1QKUQrxCpO7wsnEq4o2kmMd6kGnGFdNZammpJ HHLWkM75dAYIa9SMrWl/NQLlAmAyErzR7P7qfZP9l4FAvcPbrbXk9VcrSq3w0CBcu+WJ 3l4Dfdp0lKSf8d2Wea+E99629NjY43wfvBXabaauqCzHltA2WfRFfiLg1lQuQx2Bnk1r GIOLe6zRGwUDA9PCRwNl7G72YpRjj4IOrCaxAjsToETm+3n+TYcrD4doobxlFjIi9VsW xaZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746522121; x=1747126921; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u71xXPv2Cn7JbdcKCIhenriwZi9FR0pSz159YD5Hm9o=; b=LL/sRlIyyedwbqiwiZHYYxKLREfUkuiKLyHccwsMz46dziWQmlQ44O5klzCc3BgT0y pLYKjjyobYvyHnq5qYbVZZRwEPhALkcYVLcyCPWk/En+7Z9CfDYAR7SvKdBENAFhXdmA tv7E94sppJDAASZacrlP1ROvPtwmRj4nNOh7c5Y/X5LpsWBIlUbSjqxhcs/iIdMp7aoa gk/j5RseQG6z4VT61dplmsf61ZhjC3PKiKSQIoNsRtNlRo0OHiaTmlQiiy3UFuU/F68G NuizF6b5NtqOeuWLFuHcY2gL610/8K4zwi3hnANqc7zHRK2znCqr6tKrULSEsQEgm1sj 6kMg== X-Forwarded-Encrypted: i=1; AJvYcCVNnDMeCZPfhDhnaGvA1r7hvhiXWJjDB9vW3gB59A+zoWffI7w2/+GYV4URbC/AbhOd/+uaOZBa2T4grds=@vger.kernel.org X-Gm-Message-State: AOJu0Yycuae/RDUsKxE5y39vp7kyOJQR3eD059zGpGzdSAfFolhApmlS 9FG/rlBysHRMiJmjDHuM79+rVOjaKdkhysmorFhDiW4k+pc+Rc9mCYWN3DprUVOd5hLAOUnACMz Y X-Gm-Gg: ASbGncvTn8pzRPrgcBQBRmRvfiTZ90YcTWEGinOSHV2+2g0e2JqiH1UkYqG2EJOPpS9 +qWIybI+FsHQrxSblBrr7LTpyU7XwvHx+EGX0ciOdtk+SyFofVrKj+lWWQoz6cTctQR/hZPH0jY 96DxlMaz01QP1g+ZDUpU586BxPix+xxxteTbqJGQRM7wRAfhqoydMjGZOGdSUdE0BEgLhmhyaRY vOo0nlKdfke/YpqHv4Ro2yLkRM2LbJpYIcC69oB9yNxHx7RQRwjBl9Bwo3M520QPLi/4aknbS0a /boOlhzK9pzaqLAPlZaftme756Sv/BwffN0= X-Google-Smtp-Source: AGHT+IHXB3gkSMrAkiaEdkZgfwPUxM31hHCvMRRqx1aDQWE8PbU/eLSpr9sDJNShzozwei4n8wZn6A== X-Received: by 2002:a05:600c:4ec8:b0:43c:f8fc:f686 with SMTP id 5b1f17b1804b1-441d0fbd494mr16499275e9.3.1746522121626; Tue, 06 May 2025 02:02:01 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:bfd0:3ad7:fd8a:fe95]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441bc83d471sm138125725e9.26.2025.05.06.02.02.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 May 2025 02:02:01 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 06 May 2025 11:01:51 +0200 Subject: [PATCH 08/12] gpio: max732x: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250506-gpiochip-set-rv-gpio-part3-v1-8-0fbdea5a9667@linaro.org> References: <20250506-gpiochip-set-rv-gpio-part3-v1-0-0fbdea5a9667@linaro.org> In-Reply-To: <20250506-gpiochip-set-rv-gpio-part3-v1-0-0fbdea5a9667@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Vladimir Zapolskiy , Piotr Wojtaszczyk , Charles Keepax , Richard Fitzgerald , Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2114; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=+ZH07YfdYJrmGtGKxfVboFth3KKtcaZ+GSxu05Ln8Qs=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoGc/+lvgMQ4oQLj/Eaktuwp8Im+zWEzU1mIo+f E1B/S8mAleJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaBnP/gAKCRARpy6gFHHX cuuSEAC2pyP7juGwnu8AnZibZ0/xjMAmnRTRcL04Pm0UhdkxVpm+6aQ8khE/D7bgVXSp3FccL/3 2jYnQ9XYJM+/AHIAlPbtcIpl/Ep16qBqdLQFAZJyudTQw5emHdDNCpAJL6WVcUy7tScevv+93Cq +sLanICe0/iy5Eq4PG1Rd//mpz3FIPbR2IfU6aKestqMvnonexknwOY5yc9dTsXlqpxAPVxV88l mcYWutkd225tHOYT1MR6QYIDmEK18C+N5qFE/MQWrZWIA7ixLDoPTbW8KSn7u8SKARs3yEF02Z0 1XrDaB8wlkmlme34eU79hg89bscEmb9ZldhoPAgkpTHlL1+hR+pPCSoV1pVVOgB1GxOjLP1HSsu kMrYNPOiO+pauSJaHd3nYHL8CIeLj0yIBT0r1PlOO3ISM0fdlFZYzdZS5Bufh2kCRh2SzYf7nzG elYIUetSzi/RDeR5vHN9geaeW1Zi5jF4jldlXsqki83hz840gy2ribrdaj224iQMLfkoKFgbKLc ZNkHwV7FZ12U6lT9vuIn0kFyzmtcyeLzkM7MRJgwsQela8SVqVmbud1Q34yl+qyZJvGgaI5gdLs Y9jumqWY5pjlx8BSNrkkuR2ZRJU+JE07KiDNkx4YXP4E089iCHnMW+5GQ2krp9kKz5ElnqUFCwi +RcqvFGksZTkCqg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-max732x.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/gpio/gpio-max732x.c b/drivers/gpio/gpio-max732x.c index 49d362907bc7d..d5ffedb086af4 100644 --- a/drivers/gpio/gpio-max732x.c +++ b/drivers/gpio/gpio-max732x.c @@ -225,16 +225,19 @@ static void max732x_gpio_set_mask(struct gpio_chip *g= c, unsigned off, int mask, mutex_unlock(&chip->lock); } =20 -static void max732x_gpio_set_value(struct gpio_chip *gc, unsigned off, int= val) +static int max732x_gpio_set_value(struct gpio_chip *gc, unsigned int off, + int val) { unsigned base =3D off & ~0x7; uint8_t mask =3D 1u << (off & 0x7); =20 max732x_gpio_set_mask(gc, base, mask, val << (off & 0x7)); + + return 0; } =20 -static void max732x_gpio_set_multiple(struct gpio_chip *gc, - unsigned long *mask, unsigned long *bits) +static int max732x_gpio_set_multiple(struct gpio_chip *gc, + unsigned long *mask, unsigned long *bits) { unsigned mask_lo =3D mask[0] & 0xff; unsigned mask_hi =3D (mask[0] >> 8) & 0xff; @@ -243,6 +246,8 @@ static void max732x_gpio_set_multiple(struct gpio_chip = *gc, max732x_gpio_set_mask(gc, 0, mask_lo, bits[0] & 0xff); if (mask_hi) max732x_gpio_set_mask(gc, 8, mask_hi, (bits[0] >> 8) & 0xff); + + return 0; } =20 static int max732x_gpio_direction_input(struct gpio_chip *gc, unsigned off) @@ -580,8 +585,8 @@ static int max732x_setup_gpio(struct max732x_chip *chip, gc->direction_input =3D max732x_gpio_direction_input; if (chip->dir_output) { gc->direction_output =3D max732x_gpio_direction_output; - gc->set =3D max732x_gpio_set_value; - gc->set_multiple =3D max732x_gpio_set_multiple; + gc->set_rv =3D max732x_gpio_set_value; + gc->set_multiple_rv =3D max732x_gpio_set_multiple; } gc->get =3D max732x_gpio_get_value; gc->can_sleep =3D true; --=20 2.45.2 From nobody Tue Dec 16 15:24:59 2025 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4B97270EA1 for ; Tue, 6 May 2025 09:02:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746522126; cv=none; b=nGQ27azMpFABTJqx7C8+td12xheW9vmQJZnBRssAFEcXdpr22RoqqZqmYTz7fQu+0i0Gm7TS5giHASB2SseJxgAuNqfLf3P54kSUsGwOb+ePXnfOYTyvhgydHRXf8ZLrTsIwGvHbIzLHjM7J4ul36Hg6sR3MDyCyQ9grTOhpZhg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746522126; c=relaxed/simple; bh=JFsmM57P/O8V67mF5am73nGzAoBwKLj9GVKn594zJu8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Vt0o21ywFiitjm8C25NOi6s97ZByGBXbOkAaJ1vZbZNauxT6f4vn0dbGBKuh9zATwt4nV2z0szkSnZIKz+jcpgcPmKEKNBgI6T1CBystRX0a0zRc/XB8BbppPI53LB8Z1e+91pCZXIRoUpHLilwWYl7cTIQigppu1icfjUeRdDY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=KiqDPwVr; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="KiqDPwVr" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-43cf257158fso29118285e9.2 for ; Tue, 06 May 2025 02:02:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1746522122; x=1747126922; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=RViy5sXSyCVllDQ7MtbJFUrGShqaZa6Mlg+17kGovwY=; b=KiqDPwVr/bqGRBpancIeuMJGK33ys3EC+5/gGnOiTmzlKk/K0VYeX8kgo15qFTHhay XgrnqhGnrGrcPS4vDQJIcAySVa5p4pWN2E5hnB7ov0rSYp4Wp/EY7rRjqs+iqQPE++SG 8ZgvX2KGamktM4UK8AFz6Xm8wW+c1ro3KZYWC2QVVLqk1oxY2m7GsazjDHbdztfVOv1M tfT3Wlk0ROfCqBdcLzQlHivmYF1tlNyubmTaTg5pecI2t851kYxHjpgO6AIEJuaU0+3g jTpSOOw36aJTgwyrIlR4gzkA1KMEWDEStMTx3VbLwt6eQ/DZ/rjbAMXAsT66LffXiF5T gFTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746522122; x=1747126922; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RViy5sXSyCVllDQ7MtbJFUrGShqaZa6Mlg+17kGovwY=; b=O/f9UKh6YmSe+PBc5mTnhncZvZxf//NF9rVpHVubADKthg7If3wAkoj/EJz5qq+hEa X4JSEbXS93B7HC6uP9wS5nXuKPc4/dOYk74y0sC+D0y7fvpGwgChEHWIMIFjjIMVm/iX 3RkUURXDeyx+jZqHYggwJ67X7GiBFrrcGJu+nDasdCVeabUS13dixB8P3vE1EHnDg9Sp 4ft3j/Nf194/SmoBSWchBQMcxHIeZP4mTWdvUfVU6NEFyzdJh4IcBfFC9j6G13+u+RLz +Rd2vHZmzMQMDRyB6D4GzrZ6yw0Zf3JrutTqjMy4g/kLLNNVEjxbeXI0fyEnfIqgQ7Dx mWWA== X-Forwarded-Encrypted: i=1; AJvYcCU6wJNaop35jaHwI7KYHtm0mw54FVMhFOI6Zg8s2SQNMtajtXj3fPvO/XFBMBlsYfipF4f1arqhXO6Agvw=@vger.kernel.org X-Gm-Message-State: AOJu0YykRndcxUWQ92tokLNnxsacsXPjHmL2mKZNI8GSe1jgf6dnpx3c p+2H4tk9zR7jLgYxN/FeaNagAgLM2byS1wKPFKwzAzAN5PEINdguD0gIBA36j4/zu+BV43DNQ4q z X-Gm-Gg: ASbGncvPHv23iIHUJvB+E03YBBidmXzKN2jR8F08R57oIXDmWve9YAoPSfBlEBbY++f CdJwzwSJVoRu7gNlJIyLK9SiudcuB29epd+XI4e7c0pvXxlPPZXh1ljlmdTiW5sDpYdS1+9l039 BlaGeIEYadDcueQdFJFScRbcWMLsubWyyq1PvTVGSHU4pjBs2U3plyfZuSqinQCLHQyZAxvdkim 6Vi98xQ6tIPyisTrTEZTn6osfB9gD0ik0aAwAriPG4Modx7qiZQWochGrLkU9dMNrycPWFzrjda PpbgI5pShSvaSV1zAu4otQJzNAqVqe/A2l8= X-Google-Smtp-Source: AGHT+IGdutjQDLWY4nxQmqNnyyXxS0dNKsu0ias92lCYMh/g/yYLkvUyWFqlVczz1tB/yWiChJXrVg== X-Received: by 2002:a05:600c:1c9b:b0:440:54ef:dfdc with SMTP id 5b1f17b1804b1-441d04fe785mr18148395e9.8.1746522122499; Tue, 06 May 2025 02:02:02 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:bfd0:3ad7:fd8a:fe95]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441bc83d471sm138125725e9.26.2025.05.06.02.02.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 May 2025 02:02:02 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 06 May 2025 11:01:52 +0200 Subject: [PATCH 09/12] gpio: max77620: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250506-gpiochip-set-rv-gpio-part3-v1-9-0fbdea5a9667@linaro.org> References: <20250506-gpiochip-set-rv-gpio-part3-v1-0-0fbdea5a9667@linaro.org> In-Reply-To: <20250506-gpiochip-set-rv-gpio-part3-v1-0-0fbdea5a9667@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Vladimir Zapolskiy , Piotr Wojtaszczyk , Charles Keepax , Richard Fitzgerald , Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1910; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=N25xpJo8Wn4hKIWS80X1OeMM9GyN+r2jXu3hvoWtCc0=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoGc//2ujX9nyCkowWcEn/X2y1T3zJBYnvdxiIf DI/74eJ1XSJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaBnP/wAKCRARpy6gFHHX cglrD/9d2BqfRFTo/ZvbXdSOrxA5s7AwPuYI4BfypgQhHVodS2YDBzc38ssqw2XFiZLwZWBz3H1 yT5wAUAQQWE5s9wPYMUmf1RoawcD7o1WoJQHOR8SBDCgNxqt6AAw5p3Upal0icQAj1onotwcC42 oNnVxsffJn0EcIybOmVUS3TyWy//M9EPvurNHwQ1vHB57HsRCTqVyhlAVuSKDpPsUVQgJArFX/I 24hJt5bDP3QjFBrYQdhuHUdaAT7Mebw5Pf8e2tAfjCmsWaVwl0B7Q/0lx+ER809GOfvtwmlr6dr e8+bhQwIDDfkfDahHnGbsvEpeFgNvweIilQIyD9TWa6E0gO9dF4Wt3MZBAbTlAXXLDIt9zvBDiV FHzaje/uSGCjxE9b56QumVVPfB/u60CwCfAGv30O1Ftc8Nlm+t7vPOHzSuCLvIwVIq0uBgCdXTx 6vSsM1FOpiW8Wpxh1AVdHMAWNGJjhOMCjA9P/qc9UixgIihxDtU8XCvCGxjWNUkc3ozxh6LzXGz tRO2yeelJaxSePVRjF+pIuA7t4GLAlbuH7QCABaWhi9/cQI2fv557qemD5P1yTrLqvVyKzQP6fq lYkOBAWGLMIM+8AHGQ+5CXXpTGrzzE5LP/N0ABm64t1B3Uzn5AJ0cpN5WBiA5KuY61hBME/RAxd hntlJwr9tShuI5g== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-max77620.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/gpio/gpio-max77620.c b/drivers/gpio/gpio-max77620.c index 8c2a5609161fd..af7af8e40afe4 100644 --- a/drivers/gpio/gpio-max77620.c +++ b/drivers/gpio/gpio-max77620.c @@ -223,20 +223,17 @@ static int max77620_gpio_set_debounce(struct max77620= _gpio *mgpio, return ret; } =20 -static void max77620_gpio_set(struct gpio_chip *gc, unsigned int offset, - int value) +static int max77620_gpio_set(struct gpio_chip *gc, unsigned int offset, + int value) { struct max77620_gpio *mgpio =3D gpiochip_get_data(gc); u8 val; - int ret; =20 val =3D (value) ? MAX77620_CNFG_GPIO_OUTPUT_VAL_HIGH : MAX77620_CNFG_GPIO_OUTPUT_VAL_LOW; =20 - ret =3D regmap_update_bits(mgpio->rmap, GPIO_REG_ADDR(offset), - MAX77620_CNFG_GPIO_OUTPUT_VAL_MASK, val); - if (ret < 0) - dev_err(mgpio->dev, "CNFG_GPIO_OUT update failed: %d\n", ret); + return regmap_update_bits(mgpio->rmap, GPIO_REG_ADDR(offset), + MAX77620_CNFG_GPIO_OUTPUT_VAL_MASK, val); } =20 static int max77620_gpio_set_config(struct gpio_chip *gc, unsigned int off= set, @@ -314,7 +311,7 @@ static int max77620_gpio_probe(struct platform_device *= pdev) mgpio->gpio_chip.direction_input =3D max77620_gpio_dir_input; mgpio->gpio_chip.get =3D max77620_gpio_get; mgpio->gpio_chip.direction_output =3D max77620_gpio_dir_output; - mgpio->gpio_chip.set =3D max77620_gpio_set; + mgpio->gpio_chip.set_rv =3D max77620_gpio_set; mgpio->gpio_chip.set_config =3D max77620_gpio_set_config; mgpio->gpio_chip.ngpio =3D MAX77620_GPIO_NR; mgpio->gpio_chip.can_sleep =3D 1; --=20 2.45.2 From nobody Tue Dec 16 15:24:59 2025 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0544C272E7A for ; Tue, 6 May 2025 09:02:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746522128; cv=none; b=GuByZEAryIgtIg7LuJY2jB2f2kSZGd+xKUMv38mLCFiVgwCrE7TIJnmQ9qPeEB4TdHXZ+ehb8xVLXeRIwWuHpZTKojtlrHFtTQNYZNgrWWXJRXaBI9Wmq6cZl6BOwEIcQi4vc42IGtEQEYpgw4LgnaUnyTrwyRulFp/QwI+fNVw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746522128; c=relaxed/simple; bh=hcIZWHI2OFSlwwqSAvtsOAaH6T2rInpLX8inAqA7EA8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IkXgZZYhS/NNr3XzgMnsxn4eTiHf43xR1+AhG7JQL8/X4L+0ymnZUKohFV5wf65twlPSbUVtkdyGe2Ztp6DIK55sBYXFi/L6trGKN7kJoZzDUmvZnlo6MB+zEYnDUjBALJVSUUrbuz/P6ZXYJQojemqJdAyMIi4vzLWzifQvSAA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=bp610mJa; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="bp610mJa" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43cebe06e9eso33585135e9.3 for ; Tue, 06 May 2025 02:02:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1746522123; x=1747126923; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EqJOkLDpEbdjHj6y0NvdqBxAKuQLVchFLzPyCOvEcoA=; b=bp610mJahfEPRDdORxb/sXthIV9Utx/8W8D/C9Tz2P0tBj9Yd8S79IjJ5w0aztkOcE qgJAqv5zT6dHiUCKId3zPfqYTwEvHVDCI65f9kWCuh/NUrIwvg5ku3ghOXStJGPD3121 E4txet1D86kS2Z5CYukvhFdYOP6ljgaXrdCL4VcmRuDW0DEibLN1/vE6capKIqOK+BRP cJo/z14+eZN/msVmRfI+1SLYeauMJxWu9rIyhrdz0p0+wE+d/RPNdNLuIO66CavONCtD Ph/MRMNmPWOaGkdp5Wu07Oq1dHh3up2KIPPPTTQ3SPnmvdCczkYlZK63thUawjSVweDk iDMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746522123; x=1747126923; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EqJOkLDpEbdjHj6y0NvdqBxAKuQLVchFLzPyCOvEcoA=; b=i/9VXUq9M1RsPqUrcprjqE7PP/SL/Lvbj/UeWMC8Pedms5tzrP6DzB7Se2ANCn2x+s sB++wLZDg0AthIsiX25H2lB8fzVPigXhgEt9OoyAw4LW+6AJ/O79+cHhOpKpATZsduWs DmcKrV00LaOgsrXkZcFxkMx6CESdJkqRFI755uY3mPxrpeJqTSCjDLO5CDW8huryHx8W d5xB/yn5QARNj8p9dazibqdH5v9PP0/nEpWgmfc1TkFTBH0zQbbdlT0mIUZ25+YrvOHd 79+JWFwt8PhqQsi1E4lnm7gJoyJ15bINiPsxz7sP4Z2l9eI93Ol+s3e5JoviIUh6oBc7 St4Q== X-Forwarded-Encrypted: i=1; AJvYcCUtn1zK0mnoM3EKwlHFOMnJbuV0syv9/2njC3GapfNCdntuxIO1FNrVBjpfFfOI/SobOCs26n4MG7VE0yw=@vger.kernel.org X-Gm-Message-State: AOJu0YzZSWHOD6oFqIlaCO4Nbb80is66XU2OiY0Kyj9lkmq2jWo3gjaA JQAJo0APduiDXbsnyK3IDDFHWbGrbKCsBmoCiSHhdmkXVFsBrUKZ1uup2bGw1xM+7xL8GZZ1swT 8 X-Gm-Gg: ASbGnctTKZcC8xRmXWuDb+SZ4tyET9i9NrJDwcpQMHq7spulrowo4cfq+8GHQ6DrAyO JI65uWccdhm+HfvbKKYWTTD39LjFEOJ0j18N77pA4fQ0SFDMk9d+qwNeieYTQ5/dwRnQONd0OBA jLNcuH8MrfC35FGkHRTWAQX/xfmegRzqCC/Rk6Hv8VmVQlfzgFtfQqrJXAZDWz5IOplZvTjv4qW mogXiOxCQDzDH7r/D50iKVqpV8znMQCCBDbH2d1uZk6ZUzhardNQn5PIoIc6igcO0Qnzq/cKHQ8 l1mdmhE28Hh5stpd2Ds9/YhrmRXd6d2V7DEAPTTc2wr+Gg== X-Google-Smtp-Source: AGHT+IEQBbyGNvSBH/IUZ7yIkS1NqraYFdwMWxFz3yplI3ge5b8Y0Hl4j3r2KPDZyW7P/JlTUqu6oQ== X-Received: by 2002:a05:600c:1c0b:b0:43d:649:4e50 with SMTP id 5b1f17b1804b1-441d04feeabmr20345795e9.13.1746522123409; Tue, 06 May 2025 02:02:03 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:bfd0:3ad7:fd8a:fe95]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441bc83d471sm138125725e9.26.2025.05.06.02.02.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 May 2025 02:02:03 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 06 May 2025 11:01:53 +0200 Subject: [PATCH 10/12] gpio: mb86s7x: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250506-gpiochip-set-rv-gpio-part3-v1-10-0fbdea5a9667@linaro.org> References: <20250506-gpiochip-set-rv-gpio-part3-v1-0-0fbdea5a9667@linaro.org> In-Reply-To: <20250506-gpiochip-set-rv-gpio-part3-v1-0-0fbdea5a9667@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Vladimir Zapolskiy , Piotr Wojtaszczyk , Charles Keepax , Richard Fitzgerald , Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1602; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=Af+W5lkq0OOTLJFoxPrjkcufnz4i+x8pujOP6mAns+I=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoGc//nXJvfvNuFXirRuBnaS/f3lvGmAa5BZS94 o12DeEaGrmJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaBnP/wAKCRARpy6gFHHX csv3D/kBSFLlqOIfps57wWdE3tJ2zBgTTX6pQhnjc+vB+c9WXL77cC666D4OrG3ZGaW6oHBRDyx L3R8OnvH/U5qaStUlQ5U9+TFz9broTUfI2FxGDe60Vzch63Db7uKqaL738vRE70G72+ZUvBjy3z 6VKr08Xe+lh5X4MIcxgthLTcUbLgqoXDKe1gkY3EqhN18R0bwJce3TF1OTTu5t16AD+a2jKTC8c jq4ld6KmVGe9wVjijQ66U9hAcuFOTkgW6vsHNrvVV4a2Le81VAXLQvL06/eBXNz7ZcWvgT2DpJm MuZKiD+dhlkfjCQ5/IH+5GkDyZE+TfgrdvRR1jMPPqpAesr0CIOK8hctYXVVJV22fMTpIxiyQSe mpfb8FlR1eiH6pD5/rph8sCQbArUWnYkhYEKwtzRLcbh56YgfgEutZ2r+kHA76+FfJ9SZvaqpz8 EEaqaEzNTIoZOlQ10V98eMiFEHR4Aa4yUvXEVpKp9Mj2blyVVImYq/L/iVawMBy2epMhgmmq69O g8RbmijkDxZxPl2xDTZkx63YLaNDnxVY/ZF1w05JkPOjqB8jDaeQ8ah+NYHr3UexNuHBVTJdiGp SOLKdtn8jdGUEUm57R4EzgCvi3f7td1g089F9N58QYUROqemQTFNdj+SWERzB2adHKC3Pr038oc 74tmNN0JQEtX9MA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-mb86s7x.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-mb86s7x.c b/drivers/gpio/gpio-mb86s7x.c index 7ee891ef6905c..5ee2991ecdfdd 100644 --- a/drivers/gpio/gpio-mb86s7x.c +++ b/drivers/gpio/gpio-mb86s7x.c @@ -119,7 +119,7 @@ static int mb86s70_gpio_get(struct gpio_chip *gc, unsig= ned gpio) return !!(readl(gchip->base + PDR(gpio)) & OFFSET(gpio)); } =20 -static void mb86s70_gpio_set(struct gpio_chip *gc, unsigned gpio, int valu= e) +static int mb86s70_gpio_set(struct gpio_chip *gc, unsigned int gpio, int v= alue) { struct mb86s70_gpio_chip *gchip =3D gpiochip_get_data(gc); unsigned long flags; @@ -135,6 +135,8 @@ static void mb86s70_gpio_set(struct gpio_chip *gc, unsi= gned gpio, int value) writel(val, gchip->base + PDR(gpio)); =20 spin_unlock_irqrestore(&gchip->lock, flags); + + return 0; } =20 static int mb86s70_gpio_to_irq(struct gpio_chip *gc, unsigned int offset) @@ -178,7 +180,7 @@ static int mb86s70_gpio_probe(struct platform_device *p= dev) gchip->gc.request =3D mb86s70_gpio_request; gchip->gc.free =3D mb86s70_gpio_free; gchip->gc.get =3D mb86s70_gpio_get; - gchip->gc.set =3D mb86s70_gpio_set; + gchip->gc.set_rv =3D mb86s70_gpio_set; gchip->gc.to_irq =3D mb86s70_gpio_to_irq; gchip->gc.label =3D dev_name(&pdev->dev); gchip->gc.ngpio =3D 32; --=20 2.45.2 From nobody Tue Dec 16 15:24:59 2025 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6210327587C for ; Tue, 6 May 2025 09:02:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746522129; cv=none; b=YDGGch+++QfQ18qS1BwJcZgrUVSTR4v9LxmCLForMcKWUokw72N4XNg//A3cOt2tLT23GmZpDbqoNCdjMUqLv/R9fFSe/ElEJXWxfGwaGpfvxrekCdwh3LD5+JMJtDKAPPspQZfeSLwmNqs33cigoi1fRZjgF1/bZxNMAKTHoWw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746522129; c=relaxed/simple; bh=ZkRJCrK6scuZdggi5orvTvUK9ZzbA+DAkoUDdmoNVIg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aOgKnpuMxQTbB0zDIHget0/BCHgCI6JfHHU7IYL+MGYCBOwb9bFCDNQdPVZV3KY6djfVn1zoOkBTwO2TNbtfla+AlRUlkn9aTPsu9HoGiWx4XCvXzTactwS0dcZA2WOLjAZGZyPbPW3Ohxzq7uUs90haxFIGTDfmr+TyEWRtD7w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=pQAbfEl6; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="pQAbfEl6" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-441d1ed82faso1997485e9.0 for ; Tue, 06 May 2025 02:02:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1746522125; x=1747126925; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=pnErFkFW00l/PAG6MwIj1HiufEnT+BpJAjKHZo9C8hw=; b=pQAbfEl6QI6uAXew5mudmwDQhwhwDYGtAxlEt2HmqVVcu0XeDbnnUaFjv+eVX/Op5v cp6pRNIOYSPFSdatfyHXcbaDvSaaSGJJlyi77nrvA4g2yLGEarwIrNq0YlaVtispiyEH 7twpS1Z4ZDcCnUJYkqMD0hm1Hv2VyNoJ5CoztsCxw2lbohYw+P6OiDCjVstfrPu+eM+F xk2Dv3U2Mn05ZSWeSGKSvgVEsbJRd1JO7SQj+5zu0xcb4xsnXyIgkzhbD/pbrtr19Lcc k685SQx9MkVrMHqR+fiyedSkoFKFuy7ftUF2vCADmrmhdDa8JjBn1R4hN04yAfsRvB3x uMWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746522125; x=1747126925; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pnErFkFW00l/PAG6MwIj1HiufEnT+BpJAjKHZo9C8hw=; b=OyTd3YBaSh1DI8W06g2JtlGqKlX2BlXK2KHjC6uOgjurpISrF593pQoBWQ7a5G7ZhB i9G+GZCJRQS6IlBGsWMj+0vGcdIywAiLFpbM7u1QAqSJ7laSW/SR/TMQMR24iGboQRwU 5UHC7+FDOElVkLB/n6rtK2uAvqrEzHX64tVl0R72Vd4yQN2rMC7KXN0PH3pl7ICmkZLX cFfikQnIJDbYGUQXzia+ztL2l+vWo5SxhzcH4t/n92digvf3KwnCv3m3pStr1pDH8oAy 74otQcaBQmuX7RYfZPFnItnQwfPbotXyV6IWuv4ZTo2MWrI4UfvGPiDwISudymqf32cv Vpdg== X-Forwarded-Encrypted: i=1; AJvYcCW0I4+/BRB4+Mvi8YgJBd1nz2o8ThN8YFJs/PjbdGygFGvEt/tAFGEM6jYt5MIDLu+W221hguSd8UcY2ec=@vger.kernel.org X-Gm-Message-State: AOJu0YyvKU645zU0NJ8wNzbf8PvOFn0NsvV+pddPMYwtL0jgj0zYgfjG 9BhbYpE6SeHafDLLskMCKVCo/B+72qMNjXGdqowghMmyGcMubR2gh0wsL11iibnX/AujCYi2zoi t X-Gm-Gg: ASbGncvmNz0lF2Q27fxsCQTnLizgUW9ZXOCwd0iQYdovocGLMoSR8prJ7UpaP6kHKY/ ImhCsJlF381w0fOXlpJ7ZTdjvmOmSS6R7YIk7weFuVFsrbi5ZaC9jMyR3jI6TUE+o4wRUxbg9UP PCfHmMzcHH5Ay+XY2ilRQgF/8xrpeHYG6E2h2JZW4bwuNxUIycCVCXVjnFQOp5Y8OKFZWZj+SJ4 8nBvlE7XZsmyXeJr3TDz1Sj+cdt21mZc0NOMieKWljV44nl8n3M5p0e8dvjs9GHwhPqpUf3GF6R WNmBmjiC/CLGF+St87A9Hw50RXTNfsLN+h8= X-Google-Smtp-Source: AGHT+IFO1hQZjV4t7yl1TN8fzggwDVqxrNbuwXVatO2B4+xlJe0tbSOvXbGoPbT3JNs0BKBgDLCecg== X-Received: by 2002:a05:600c:3e09:b0:43d:2230:303b with SMTP id 5b1f17b1804b1-441c491fce2mr77521325e9.20.1746522124947; Tue, 06 May 2025 02:02:04 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:bfd0:3ad7:fd8a:fe95]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441bc83d471sm138125725e9.26.2025.05.06.02.02.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 May 2025 02:02:03 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 06 May 2025 11:01:54 +0200 Subject: [PATCH 11/12] gpio: mc33880: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250506-gpiochip-set-rv-gpio-part3-v1-11-0fbdea5a9667@linaro.org> References: <20250506-gpiochip-set-rv-gpio-part3-v1-0-0fbdea5a9667@linaro.org> In-Reply-To: <20250506-gpiochip-set-rv-gpio-part3-v1-0-0fbdea5a9667@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Vladimir Zapolskiy , Piotr Wojtaszczyk , Charles Keepax , Richard Fitzgerald , Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1353; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=9Aw2t8H6c4f+KPi58wqKHwRBhg3G3TO2LIpCTfvznKY=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoGc//cXPCtvlIjGZ1ft1cmtsktDk5hauqLZ6Y7 3Y2mIFq9N+JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaBnP/wAKCRARpy6gFHHX cjLVD/9YUlG7AuOZS97Og0sK8FN+tAo62VFK/rgAzGiJNFZSbqlvlN1wPCOJQDyskKi66mM+q6N mjJlED+ljPXgxPZ/4ciL8jENmyBCCpVBrUsMbg0LV1LKsBKWVCH8d4PDzOu+G5aB8WxVtsKFoBl KYMcS2lkNNAqVA1xOi6dMBvv4mA2zTXG+MGHvY2lRMc47WNRbGwoCj/Bveo8Knyexm9kW3HAITm lzbBU8uxOtTstsOQl4Q0FruUVkqCIhyeUmKflEp3QsKxKg3w0CevbvIXHy8YNYoM50mXdPGsrv0 4+k0bOz23bo/em2m7GxmaR6jLbMmgFmTC3Ooc19a0/8SkTjzNVIAEx1thJTZ2SAPxtZ5hjdCWe4 j56/zlckvNcAr2+4RtsC98mry3xnETRdeCYqek20zpECJc6o5ctYVL1lhFvS3E2RRZH6S6I1Pel Nwe6hcAPJwMB+NRU153wiKSa8xGaOgch+5O7RgmxCU/lfXy6UShkzHjVWYQCJ57+q87/KVKHWXC 8GVLJ2SgL8V7PnLR5ZfP0t2p/AV0VDDfJl5jcqjjJNSyR5EyRxqkmoGfu2K+5OwCMB8nKpDXZeF wLOo+wMHweQCnw+eSaiqeiCKWO+wEB4lU1b2vmo90SDtlnNAsDwCHfG1U7dsaNqUxA9uKWZaqrx KhUwh/jd72TxWhg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-mc33880.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-mc33880.c b/drivers/gpio/gpio-mc33880.c index 5fb357d7b78aa..e689561041616 100644 --- a/drivers/gpio/gpio-mc33880.c +++ b/drivers/gpio/gpio-mc33880.c @@ -57,15 +57,18 @@ static int __mc33880_set(struct mc33880 *mc, unsigned o= ffset, int value) } =20 =20 -static void mc33880_set(struct gpio_chip *chip, unsigned offset, int value) +static int mc33880_set(struct gpio_chip *chip, unsigned int offset, int va= lue) { struct mc33880 *mc =3D gpiochip_get_data(chip); + int ret; =20 mutex_lock(&mc->lock); =20 - __mc33880_set(mc, offset, value); + ret =3D __mc33880_set(mc, offset, value); =20 mutex_unlock(&mc->lock); + + return ret; } =20 static int mc33880_probe(struct spi_device *spi) @@ -100,7 +103,7 @@ static int mc33880_probe(struct spi_device *spi) mc->spi =3D spi; =20 mc->chip.label =3D DRIVER_NAME; - mc->chip.set =3D mc33880_set; + mc->chip.set_rv =3D mc33880_set; mc->chip.base =3D pdata->base; mc->chip.ngpio =3D PIN_NUMBER; mc->chip.can_sleep =3D true; --=20 2.45.2 From nobody Tue Dec 16 15:24:59 2025 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 692AD2777E4 for ; Tue, 6 May 2025 09:02:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746522130; cv=none; b=o716dghsCSYHZS9Ez8Euhw+1Z8UxFeJrfbyZwmh5EW3sRyaMtpZI9n895NYEYkCC9YKINo3DKTVVL+DlnG0crAnrl0/7M93Kg9XrHl3s+0QRxvmtdgsR2zW8s8/Xexta8+WBmSfYrmGDbuqdATP5MNGsJBGwzN2+9FIsnyJZ7S4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746522130; c=relaxed/simple; bh=L7ylAv3DjJzqa9bWTH30KaUS/rijboOvo44ZRxv2joU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=n0sNLHS53QiT2yMgJnXfla1xALE1WUWX0JXTpC7zGPaJyDhZ96zgZ3ZbLaR53uxBMuoSxseEOzTTU5eNaEmR3TQH+DeGJcLUYOkpeTC0GqRIIPaGYOuuBiD6/0RHZiXIj/W4jULWg7pkrnI8ZKnBpGtsYRc3f3vobNHRtzVlNIs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=E0lqo8iQ; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="E0lqo8iQ" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-43d0c18e84eso23299505e9.3 for ; Tue, 06 May 2025 02:02:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1746522126; x=1747126926; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=M5t7463cNsExwzuHfixoOLULX/8A+JIXQFhWYI91z8U=; b=E0lqo8iQ2gFu/uIG4u0cJqfZVehC7sha5rtDgIEK3nv6Ywm7uQVY7WRS7tVOnhsswR s9ajmW8vFinVgCrb3I+RXU+Tp3TH9dMlxJxJRT5Uit3MjUSRFcdeyf21D9P3sOGYuhDE TyTAX2nXCEYtuy4sB1THjgHR/U18dRd38Ry7+K335CDahUooCfGsBR3yQMsetU3lE7Oj iQcnsqqFg28ejTYC6Wyo+0uI6HflbBqzfYDq61JLoIBak3v7KF40HvOHk3sNKbXNFEYd oCpc9qigeqrGpa0fxH+rwjrrRcv1gHGLm/tDUyMgECCjosu9+JqNYblPiWCOIEd5H5SH IXtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746522126; x=1747126926; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M5t7463cNsExwzuHfixoOLULX/8A+JIXQFhWYI91z8U=; b=SyQyk3B/opwBIt4PlsR0V0E1Ie4MHXbME03Mha1l99+Rb2MwSIK+yr0QgMhcxYIcZp 1J+xATB9pCPgEgj1KMOblOJ3odsVukn1eE3toavsF2WMbzZB9DFukZmts4toHMT24nj5 ZZ6Q+gOPAOpDS/Tgf3+RN5SIO9w3yil5qjd60TEI6t8Jd9+mDmwRJ+ykIBBOk0JOiSc0 wawJ3aYZOeAop/eGajG5nXwgWrIVWvnRiaI6kKDBKfPnqX6RaYehaaHPQ6fMUi4GxMJW P0dct1dRgCxWLPsqAt9/PLn6YXAv/0aJ8K/O7PptRsn/YNOxGF8pl25IWPGnMorp0UVX UcMQ== X-Forwarded-Encrypted: i=1; AJvYcCVtN/88R6xAzUHIAjYdI7cAYgywyMAJu05u5YqzfXTPkPCKXcrosrFWPA+fvsLjA2+mu3GjQ8fx9bJqc2c=@vger.kernel.org X-Gm-Message-State: AOJu0YwPdFDsvlcxWO3qwXGk7L06uTTqYUlBjWLiNfUlsgR86bdfiEp2 uZZCjlieYaB0JGGi2qaAWCQAnUkJyXSnxhDugZ/COAiYAj25fyclsSkXmhi6GH++HLZiyNRaxnl 3 X-Gm-Gg: ASbGncuJYajWLl9BVb5VUYaYZxhXF2I5Oqxa0IdaqsxNI02vq8XlbqdkcAbxRm3fFEt EwyaSIjX7dtURooUX/6BYwsxQO8vx0knDQimkGnHzZmXLTXJI59iAUxgmezZb99txdFsWcH0YZu ORH2K1LMaHxwWuPGQ9QhiunZdUuregxYE6YZdMpW8pI1zgKB96IvDfWe2Ztcw8i9vas3F1MXC0O j7seBug3qPSsk89fJk4HGIpmjRzkgtyhZtbhHP8asaHHqHqv7iT4B6g+LPXNoQnj8+MpFlDyVuk kDooayM/rNFSTKcYMj27qt8NEhU0/RpRXCo= X-Google-Smtp-Source: AGHT+IG2JavFAOfkm5yvEVzhBOWiCM+n63NE0WGorpmBiJ6Up7VY84BWzS6I5+ST2HXolMCVpnzNgw== X-Received: by 2002:a05:600c:a413:b0:43a:ed4d:716c with SMTP id 5b1f17b1804b1-441cbc3e6c1mr42623835e9.22.1746522126365; Tue, 06 May 2025 02:02:06 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:bfd0:3ad7:fd8a:fe95]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441bc83d471sm138125725e9.26.2025.05.06.02.02.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 May 2025 02:02:05 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 06 May 2025 11:01:55 +0200 Subject: [PATCH 12/12] gpio: ml-ioh: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250506-gpiochip-set-rv-gpio-part3-v1-12-0fbdea5a9667@linaro.org> References: <20250506-gpiochip-set-rv-gpio-part3-v1-0-0fbdea5a9667@linaro.org> In-Reply-To: <20250506-gpiochip-set-rv-gpio-part3-v1-0-0fbdea5a9667@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Vladimir Zapolskiy , Piotr Wojtaszczyk , Charles Keepax , Richard Fitzgerald , Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1487; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=nNCKmy4dSJPb2zDH2e9wzncuQT/cTu26TwYiGfHINVU=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoGc//yRkQw+Mjxb/VAzEYh4NS0eiU4M8rdeHKD lwNJrrj8Q2JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaBnP/wAKCRARpy6gFHHX cgkxEAC8fJnRNCwURyy7LqresTVWXPVo+9MHCVv7Xny2M4dcRTEzIR0UWviKCey2j9UtttbRC1S RJLdo1AbErdGoC9X4GXxqTF0HVzys7e2R5IuMDKile7aI5gtS25t3B/MxMAimQGNZYszacXclvV tAEhuuUXZoOi0tn+vUL8M0kI5Q0rPoBxjafYzpV7vThKuVDJVlFHnbpX+v73bcpvPrKnNQxkGSk Y0ddRdsoVggcxRyRQoP3reI1vnrUAQX6EVbl0eOABGFQGn5v4UtlTf6fcyoK/M8iEkK/fJIwDwe 1sKo8qCEErY5+/tc0jkNVU7rz2aVDNl+tdxRS/L0uPkdjAFf2hGusuctrIArQjq/fLM4qXcTYis oQpVROTxZ8BCKks2ipR9OUnareuOcKkzEwnyNz9Euvbbf9/QTzg8QXilXqdUZs1p2MatmAAVgzy 78QVnDB1XkwMaayWKL8MjmyZp0VEhrL6MAEYWhEF1e7F9UATHREd/Nb5VfyvjUa4Z4POrtU59r5 b1cUgOhohRjs6+sUxZ//I7AUuhwYARthUobnm8V6tbEGwKnCsPz/T+1BJ/Zh197UpgE6ML4YMNH tu/dPXHdy/6tt4ZGX9/ew/2vhmW0kspKtafG/On2TTVH+5+s9QEUPxqnWJ5TPoPXzMjbkC6HR3t 6/VRTvBri4V3vRw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-ml-ioh.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-ml-ioh.c b/drivers/gpio/gpio-ml-ioh.c index 48e3768a830e7..12cf36f9ca63b 100644 --- a/drivers/gpio/gpio-ml-ioh.c +++ b/drivers/gpio/gpio-ml-ioh.c @@ -89,7 +89,7 @@ struct ioh_gpio { =20 static const int num_ports[] =3D {6, 12, 16, 16, 15, 16, 16, 12}; =20 -static void ioh_gpio_set(struct gpio_chip *gpio, unsigned nr, int val) +static int ioh_gpio_set(struct gpio_chip *gpio, unsigned int nr, int val) { u32 reg_val; struct ioh_gpio *chip =3D gpiochip_get_data(gpio); @@ -104,6 +104,8 @@ static void ioh_gpio_set(struct gpio_chip *gpio, unsign= ed nr, int val) =20 iowrite32(reg_val, &chip->reg->regs[chip->ch].po); spin_unlock_irqrestore(&chip->spinlock, flags); + + return 0; } =20 static int ioh_gpio_get(struct gpio_chip *gpio, unsigned nr) @@ -222,7 +224,7 @@ static void ioh_gpio_setup(struct ioh_gpio *chip, int n= um_port) gpio->direction_input =3D ioh_gpio_direction_input; gpio->get =3D ioh_gpio_get; gpio->direction_output =3D ioh_gpio_direction_output; - gpio->set =3D ioh_gpio_set; + gpio->set_rv =3D ioh_gpio_set; gpio->dbg_show =3D NULL; gpio->base =3D -1; gpio->ngpio =3D num_port; --=20 2.45.2