From nobody Mon Feb 9 18:59:58 2026 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2062.outbound.protection.outlook.com [40.107.100.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA41A17736 for ; Mon, 5 May 2025 14:13:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.100.62 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746454412; cv=fail; b=De2VU0SN3w9HHA2KTua+R9TyE7VuMU+igopXHL7Q4ke0FVyqGVlYURXDQv8k5AXtFytRZScVwRVTOUzf3phSwssMZhLeUnjHSoS/Ps89gSHb4gi0JxHSbTXN5DoBxpgHFgw5CFatVNMGl6LhQMEk5b+JI8iVYtwCud1JIDpd7QY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746454412; c=relaxed/simple; bh=hLFwRTr3jnzyx70bUHR2cqwyr8szEPZKC83afOxxkjw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lU71RMk8y/KnG7NbFdfZ7XqGJ6lOa0G/7alKCv5Wv0fQnT/fkDM1kMdSW/GXFthJREvAvIUX7nZIhtLALfaiviudJPYnWvmXD7Jy5XoUECWSf7qwl/BWLjh1STJsTKjQYAlPx+TNHr0iHbcAGfaKs9HWrKVdSfpp7HUTKQFjDZ4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=GzbTnlVA; arc=fail smtp.client-ip=40.107.100.62 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="GzbTnlVA" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Bq3guA/i+yMFzRNEGg7PbKlOXglyIZu43T5VS2ZEGI1mAjfntYJdLOGoa79COsfePijGrn3dJ8atGn0oMq991Hcfu3y7ozhAOTbATQ/NArTLkvTqsO3Pa4/X6l/6iy3GrIqdtE0yFCBMYJTLbAcyZVDmUyhbpuuVduWjLSU3mR7KhHPR3GG9NgVTSyOTa7+QKItbJpNx6wDpWa+IwH2nBVrvwy4RzBCiJIjyiPAR6mqpAiJEnNIVHMVALl6dsQDYAnIYx8/4Ij8wB7ef71EcFs/UUAog2M2U9eZDXuEpZT49OGc9Ad5iEum2H1qeOceCGmPwQusPlWCELGPNUz93rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JvgKNHXNGh7C/yM4n+UrUcugOlw73TIvF35hcEN2+xU=; b=Yox4BrFSAeZrTiYZCRBj7kIkOQ5xEkUve9AY19vPwjtBNJpQAtXRmUKDrRiqUlU/NiIK9czpNPompVG7XK2/0UJHiYij2SM63XQ06fZ9LSYpo4cVKadhNuMR2WoLzRqAouRjYxKPis67QpNQhqPK6HeAPUVsjnEtnvHvzpakQvs8E85oY9PS5kVbwdmMxyKfsXhsd50VQdizvSvmeiaBFuXcu1Gu5GbdOjCyNodIxA4GM7zmTFtfob52YPpn6JqpzNaNUnqUoUzvMF+7ipVLbuUe1q8VSIJkXXsjSB/bzcf+0akNeiG6SKHr6akKYjki1GXwr+mAT5qxGecajhlvMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JvgKNHXNGh7C/yM4n+UrUcugOlw73TIvF35hcEN2+xU=; b=GzbTnlVAUEL9VNOqv3UXp7Lax1IsKwLa5krVTtfupSLNxANl1YU/nFezL7qmKNrdLr95Q/Tdn3suIf75FRXcYgCm7pMsSAkHlTgzgiSAnlXmqvXn0pz5k4r498+FiZtYAru5FPFf5nM9MuLM6TUSAZQd9+uf4dTXKI9zHco6CKg= Received: from DS7PR05CA0059.namprd05.prod.outlook.com (2603:10b6:8:2f::32) by PH8PR12MB6746.namprd12.prod.outlook.com (2603:10b6:510:1c1::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.26; Mon, 5 May 2025 14:13:24 +0000 Received: from CY4PEPF0000EE39.namprd03.prod.outlook.com (2603:10b6:8:2f:cafe::51) by DS7PR05CA0059.outlook.office365.com (2603:10b6:8:2f::32) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8722.17 via Frontend Transport; Mon, 5 May 2025 14:13:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000EE39.mail.protection.outlook.com (10.167.242.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8722.18 via Frontend Transport; Mon, 5 May 2025 14:13:23 +0000 Received: from aiemdee.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 5 May 2025 09:13:18 -0500 From: Alexey Kardashevskiy To: CC: , Thomas Gleixner , "Ingo Molnar" , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Tom Lendacky , Nikunj A Dadhania , Ard Biesheuvel , Brijesh Singh , Ashish Kalra , Paolo Bonzini , Michael Roth , Kuppuswamy Sathyanarayanan , Liam Merwick , Alexey Kardashevskiy Subject: [PATCH 1/4] virt: sev-guest: Contain snp_guest_request_ioctl in sev-guest Date: Tue, 6 May 2025 00:12:35 +1000 Message-ID: <20250505141238.4179623-2-aik@amd.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250505141238.4179623-1-aik@amd.com> References: <20250505141238.4179623-1-aik@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE39:EE_|PH8PR12MB6746:EE_ X-MS-Office365-Filtering-Correlation-Id: a784f367-1437-4a33-015b-08dd8bdeff46 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|82310400026|7416014|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?EtCchHvb6ghn6cgu2WyMeasmXZT+cfXp3/aaBs4XmWxzLCHKN9uZAskFLtvV?= =?us-ascii?Q?TIHoB7FEtcchw461g1vmjfOLrJLnESuA3crmVmaQ9bXI5XEeqpyGENqOYhEV?= =?us-ascii?Q?bGL2DfBSEkfEgiSHJ8hBHeyBUgv/Qib7Q2Ef24gINkmx7iXc5tmkHHRHF0/o?= =?us-ascii?Q?W1g0apMdD0IEHJIz0PclMchQRIdx3xV3rNm6Ndwt+NZG14lSsQm4yMpXFf3m?= =?us-ascii?Q?Y8arZr3tGEYrtBL7FTX8QwszvQ8GsfC0j6sjGtxKkpxxs83emjEeetwIDpEM?= =?us-ascii?Q?wwo6rCp3kDJZDrXa1CDG/LJRPVDNfzmVz8i33CJFe+EiFnd4ZUEF+PcjTt1X?= =?us-ascii?Q?pC0oPrupvZXi2hrSGcZXMt7FkWArP33DanOdy6k2SlIuGDObcL4Ot1AqT7h+?= =?us-ascii?Q?XNyWTusq6zBKZdWsPgMLlYjLCUO9cyrIF+Lc6vAVwO8plfvWhfhljvB4nqnR?= =?us-ascii?Q?KLxU2G5p1Q/d8bvAp+iMfG8K4+NkuEVX6tiq5O2yLVVK6uEFPGLV+ecGGLFi?= =?us-ascii?Q?LrPF5H24n+CWOtHOZKABp/pzTQgZvgfCcTlB6cV4aD2IepgEH4IvI7CT/rQg?= =?us-ascii?Q?HIAzfcOW7tj0zJvcdisw1TivFWglpYqsn5Sl05LjJ+4XF+NlysPcVk2P++Yx?= =?us-ascii?Q?ERUAlZsL3j5t8W7caZ39qysTb+pj+gfCDYkN5qKlOCyZrksMFxEXVsryQHK4?= =?us-ascii?Q?ZnmJAiNgXT8FJQlfbmp58YXTqc3YyrzSWwx7OODkrbHr8jLmzsgBUHAv3Hmj?= =?us-ascii?Q?OxvlWb1U/lrkDfsOg5zlP/nFXc2Q2+lrpaTibtHhQuKYgMJ1RDkptJ7ghNRS?= =?us-ascii?Q?5hsvACdhBkK7rSARDYtK1B6XFnMhl2xcquv73ik2bmwBn2F1NPEIEEiLXRvA?= =?us-ascii?Q?cElrHA07Mt9T2XurvyNcr9h5c9R9RPLMoezn3td02q7JiF4sDaX77LZB1hqs?= =?us-ascii?Q?EhTh88CdKHj3Zr8fjsdQWzCm09XgTmQ3NZuPQn9XsqmO2B5h1cW1OCYSjsB6?= =?us-ascii?Q?ODHSIsw4Vyb+tjsksFsgqjMIkxmdhU+Yfgw8f2b7Ea9SvH2v8l/OhySww0fw?= =?us-ascii?Q?vIDxlywxr6v+nBqGbICceBdb7u2OccPF7seiOMPstqwhM0TCJobjNcP2kK6G?= =?us-ascii?Q?8RljtK+6eIixwTz/eiS9usS58b9hY7Rg6MIkU5yvZgJSVaBxX+Zb5XBTc5it?= =?us-ascii?Q?FtK9DgTi4Sft/+dSHmseaQl5OaGa/YbmxC04hJcFUTgWzWIZUXSlWFZxcPbz?= =?us-ascii?Q?Z4OT/h+iwQuaetrNYMpd/+T2Hot8z4/O1Wlfv3OuXjXxmy8OJwoPWM09uj9+?= =?us-ascii?Q?5vT6tUdG8vFNYL0ijOdfkGl9TrWAq54FdxE4MJF94wYL/s+oI71ag1GLPw6/?= =?us-ascii?Q?DEtO0CBbZ78UXU7Ch4efJyFrKxE0o8uNWhdUcUSxjUOzb/+IIUI6PhxhrDyd?= =?us-ascii?Q?5dotWIUGakf2QNAFBwBwIUa65R4mvIMRHyUa9cRzHL4bJzV6buT01cnnC9Rv?= =?us-ascii?Q?/SvJk8fb50MpNKQy/D/T1+p1NxNTe9INzMWN?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(82310400026)(7416014)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2025 14:13:23.6795 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a784f367-1437-4a33-015b-08dd8bdeff46 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE39.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6746 Content-Type: text/plain; charset="utf-8" SNP Guest Request only uses exitinfo2 which is a return value from GHCB, has meaning beyond ioctl and therefore belongs to snp_guest_req. Move exitinfo2 to snp_guest_req, remove snp_guest_request_ioctl from the SEV platform code. No functional change intended. Signed-off-by: Alexey Kardashevskiy Reviewed-by: Dionna Glaze Reviewed-by: Tom Lendacky --- Not passing exitinfo2 as a parameter as it's been mentioned on v2: =3D=3D=3D having a struct request which collects all fields you need to pass down or = return to callers is the RightThing(tm) to do. =3D=3D=3D --- arch/x86/include/asm/sev.h | 10 +++--- arch/x86/coco/sev/core.c | 36 +++++++------------- drivers/virt/coco/sev-guest/sev-guest.c | 9 +++-- 3 files changed, 23 insertions(+), 32 deletions(-) diff --git a/arch/x86/include/asm/sev.h b/arch/x86/include/asm/sev.h index 13a88a4b52a0..db233a03f472 100644 --- a/arch/x86/include/asm/sev.h +++ b/arch/x86/include/asm/sev.h @@ -231,6 +231,7 @@ struct snp_guest_req { size_t resp_sz; =20 u64 exit_code; + u64 exitinfo2; unsigned int vmpck_id; u8 msg_version; u8 msg_type; @@ -486,8 +487,6 @@ static inline int pvalidate(unsigned long vaddr, bool r= mp_psize, bool validate) return rc; } =20 -struct snp_guest_request_ioctl; - void setup_ghcb(void); void early_snp_set_memory_private(unsigned long vaddr, unsigned long paddr, unsigned long npages); @@ -513,8 +512,7 @@ void snp_kexec_begin(void); int snp_msg_init(struct snp_msg_desc *mdesc, int vmpck_id); struct snp_msg_desc *snp_msg_alloc(void); void snp_msg_free(struct snp_msg_desc *mdesc); -int snp_send_guest_request(struct snp_msg_desc *mdesc, struct snp_guest_re= q *req, - struct snp_guest_request_ioctl *rio); +int snp_send_guest_request(struct snp_msg_desc *mdesc, struct snp_guest_re= q *req); =20 int snp_svsm_vtpm_send_command(u8 *buffer); =20 @@ -565,8 +563,8 @@ static inline void snp_kexec_begin(void) { } static inline int snp_msg_init(struct snp_msg_desc *mdesc, int vmpck_id) {= return -1; } static inline struct snp_msg_desc *snp_msg_alloc(void) { return NULL; } static inline void snp_msg_free(struct snp_msg_desc *mdesc) { } -static inline int snp_send_guest_request(struct snp_msg_desc *mdesc, struc= t snp_guest_req *req, - struct snp_guest_request_ioctl *rio) { return -ENODEV; } +static inline int snp_send_guest_request(struct snp_msg_desc *mdesc, + struct snp_guest_req *req) { return -ENODEV; } static inline int snp_svsm_vtpm_send_command(u8 *buffer) { return -ENODEV;= } static inline void __init snp_secure_tsc_prepare(void) { } static inline void __init snp_secure_tsc_init(void) { } diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c index 5b145446e991..7a49c896feb4 100644 --- a/arch/x86/coco/sev/core.c +++ b/arch/x86/coco/sev/core.c @@ -1322,8 +1322,7 @@ int snp_issue_svsm_attest_req(u64 call_id, struct svs= m_call *call, } EXPORT_SYMBOL_GPL(snp_issue_svsm_attest_req); =20 -static int snp_issue_guest_request(struct snp_guest_req *req, struct snp_r= eq_data *input, - struct snp_guest_request_ioctl *rio) +static int snp_issue_guest_request(struct snp_guest_req *req, struct snp_r= eq_data *input) { struct ghcb_state state; struct es_em_ctxt ctxt; @@ -1331,7 +1330,7 @@ static int snp_issue_guest_request(struct snp_guest_r= eq *req, struct snp_req_dat struct ghcb *ghcb; int ret; =20 - rio->exitinfo2 =3D SEV_RET_NO_FW_CALL; + req->exitinfo2 =3D SEV_RET_NO_FW_CALL; =20 /* * __sev_get_ghcb() needs to run with IRQs disabled because it is using @@ -1356,8 +1355,8 @@ static int snp_issue_guest_request(struct snp_guest_r= eq *req, struct snp_req_dat if (ret) goto e_put; =20 - rio->exitinfo2 =3D ghcb->save.sw_exit_info_2; - switch (rio->exitinfo2) { + req->exitinfo2 =3D ghcb->save.sw_exit_info_2; + switch (req->exitinfo2) { case 0: break; =20 @@ -1852,8 +1851,7 @@ static int enc_payload(struct snp_msg_desc *mdesc, u6= 4 seqno, struct snp_guest_r return 0; } =20 -static int __handle_guest_request(struct snp_msg_desc *mdesc, struct snp_g= uest_req *req, - struct snp_guest_request_ioctl *rio) +static int __handle_guest_request(struct snp_msg_desc *mdesc, struct snp_g= uest_req *req) { unsigned long req_start =3D jiffies; unsigned int override_npages =3D 0; @@ -1867,7 +1865,7 @@ static int __handle_guest_request(struct snp_msg_desc= *mdesc, struct snp_guest_r * sequence number must be incremented or the VMPCK must be deleted to * prevent reuse of the IV. */ - rc =3D snp_issue_guest_request(req, &req->input, rio); + rc =3D snp_issue_guest_request(req, &req->input); switch (rc) { case -ENOSPC: /* @@ -1920,7 +1918,7 @@ static int __handle_guest_request(struct snp_msg_desc= *mdesc, struct snp_guest_r snp_inc_msg_seqno(mdesc); =20 if (override_err) { - rio->exitinfo2 =3D override_err; + req->exitinfo2 =3D override_err; =20 /* * If an extended guest request was issued and the supplied certificate @@ -1938,8 +1936,7 @@ static int __handle_guest_request(struct snp_msg_desc= *mdesc, struct snp_guest_r return rc; } =20 -int snp_send_guest_request(struct snp_msg_desc *mdesc, struct snp_guest_re= q *req, - struct snp_guest_request_ioctl *rio) +int snp_send_guest_request(struct snp_msg_desc *mdesc, struct snp_guest_re= q *req) { u64 seqno; int rc; @@ -1976,14 +1973,14 @@ int snp_send_guest_request(struct snp_msg_desc *mde= sc, struct snp_guest_req *req req->input.resp_gpa =3D __pa(mdesc->response); req->input.data_gpa =3D req->certs_data ? __pa(req->certs_data) : 0; =20 - rc =3D __handle_guest_request(mdesc, req, rio); + rc =3D __handle_guest_request(mdesc, req); if (rc) { if (rc =3D=3D -EIO && - rio->exitinfo2 =3D=3D SNP_GUEST_VMM_ERR(SNP_GUEST_VMM_ERR_INVALID_LE= N)) + req->exitinfo2 =3D=3D SNP_GUEST_VMM_ERR(SNP_GUEST_VMM_ERR_INVALID_LE= N)) return rc; =20 pr_alert("Detected error from ASP request. rc: %d, exitinfo2: 0x%llx\n", - rc, rio->exitinfo2); + rc, req->exitinfo2); =20 snp_disable_vmpck(mdesc); return rc; @@ -2002,7 +1999,6 @@ EXPORT_SYMBOL_GPL(snp_send_guest_request); =20 static int __init snp_get_tsc_info(void) { - struct snp_guest_request_ioctl *rio; struct snp_tsc_info_resp *tsc_resp; struct snp_tsc_info_req *tsc_req; struct snp_msg_desc *mdesc; @@ -2026,13 +2022,9 @@ static int __init snp_get_tsc_info(void) if (!req) goto e_free_tsc_resp; =20 - rio =3D kzalloc(sizeof(*rio), GFP_KERNEL); - if (!rio) - goto e_free_req; - mdesc =3D snp_msg_alloc(); if (IS_ERR_OR_NULL(mdesc)) - goto e_free_rio; + goto e_free_req; =20 rc =3D snp_msg_init(mdesc, snp_vmpl); if (rc) @@ -2047,7 +2039,7 @@ static int __init snp_get_tsc_info(void) req->resp_sz =3D sizeof(*tsc_resp) + AUTHTAG_LEN; req->exit_code =3D SVM_VMGEXIT_GUEST_REQUEST; =20 - rc =3D snp_send_guest_request(mdesc, req, rio); + rc =3D snp_send_guest_request(mdesc, req); if (rc) goto e_request; =20 @@ -2068,8 +2060,6 @@ static int __init snp_get_tsc_info(void) memzero_explicit(tsc_resp, sizeof(*tsc_resp) + AUTHTAG_LEN); e_free_mdesc: snp_msg_free(mdesc); -e_free_rio: - kfree(rio); e_free_req: kfree(req); e_free_tsc_resp: diff --git a/drivers/virt/coco/sev-guest/sev-guest.c b/drivers/virt/coco/se= v-guest/sev-guest.c index cf3fb61f4d5b..b18504398619 100644 --- a/drivers/virt/coco/sev-guest/sev-guest.c +++ b/drivers/virt/coco/sev-guest/sev-guest.c @@ -101,7 +101,8 @@ static int get_report(struct snp_guest_dev *snp_dev, st= ruct snp_guest_request_io req.resp_sz =3D resp_len; req.exit_code =3D SVM_VMGEXIT_GUEST_REQUEST; =20 - rc =3D snp_send_guest_request(mdesc, &req, arg); + rc =3D snp_send_guest_request(mdesc, &req); + arg->exitinfo2 =3D req.exitinfo2; if (rc) goto e_free; =20 @@ -152,7 +153,8 @@ static int get_derived_key(struct snp_guest_dev *snp_de= v, struct snp_guest_reque req.resp_sz =3D resp_len; req.exit_code =3D SVM_VMGEXIT_GUEST_REQUEST; =20 - rc =3D snp_send_guest_request(mdesc, &req, arg); + rc =3D snp_send_guest_request(mdesc, &req); + arg->exitinfo2 =3D req.exitinfo2; if (rc) return rc; =20 @@ -249,7 +251,8 @@ static int get_ext_report(struct snp_guest_dev *snp_dev= , struct snp_guest_reques req.resp_sz =3D resp_len; req.exit_code =3D SVM_VMGEXIT_EXT_GUEST_REQUEST; =20 - ret =3D snp_send_guest_request(mdesc, &req, arg); + ret =3D snp_send_guest_request(mdesc, &req); + arg->exitinfo2 =3D req.exitinfo2; =20 /* If certs length is invalid then copy the returned length */ if (arg->vmm_error =3D=3D SNP_GUEST_VMM_ERR_INVALID_LEN) { --=20 2.49.0 From nobody Mon Feb 9 18:59:58 2026 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2075.outbound.protection.outlook.com [40.107.243.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6A5E1E1DE5 for ; Mon, 5 May 2025 14:13:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.243.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746454428; cv=fail; b=HKn3lAAYRu6XLDI+OxAtyHAeaAm/ItMFFeV4yuL/YkQ+IoiDpJJqvZ/2C5rYMpK9ePJpdeLsMD5/+UaOpRDDO0pS08YYb493oMXaQeNiRSvOarKKSvXctXdexycF4AUtK+JodhV96adiKMjkeiOCJyvMix4Zf0NeffP4nv8ggpU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746454428; c=relaxed/simple; bh=eMuNUjl/TKQFSJm+FvahZ44PgaAF2t7j5cZDjRjbDks=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GwWDSQlEof7QdtOKFpRTPL7bjhM1xZSwYFBK3IEeDcMfoZUL3FE5tBMiE4OU6NS7JFOyaIuaOAPxtGdxwpiqQDCoP+WUiM06bKZXD95aS1iG6a6FwRuYRhvWpw3ZmPs4Hg0lyt4OXjgdJy55Zz70gTzXIYsAQ37ID4fd89H4R1k= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=UUq3YQbE; arc=fail smtp.client-ip=40.107.243.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="UUq3YQbE" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KqpGeknJYlHW7LiWDMmny7wd/GQL0L5RKHAohQ7qZUq+e45j+3Gn88rc3ec7mw+zcsk7NzLxcGQijsvcYG6185b3ga2SqH+Uh52f2C9dsrvUb2iLFb3il9wWt27SjjbLQ0rEg6PIA89lBN/xRsBRuNJsvsez46RXesK0xOtWsLgBwNtadr6QaexNkhJ9ia8p9pxZm9HrvSwP0iBtBiDJxgbLGqHC1iB7KsSNtk1VIDlJ3sP1k9I0AvXE+qg+qdtOOl5XI0wlBnzzfCM6SdwFsQCe/CQ/6ibm8Imzq8Nc9MAi1qrczrL/xDi2yx0OVb0drPMeA01FtZOsHLyRzEiSRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A6M89bglZ/pD9ejtJcGiJ0R0Y5XT2vX+sCFaTkqh/lM=; b=Mid4NwJ0bKM2QKbnmxitspdcqA94Wz1XI5i1rZR0elOMmXsRLvoO+72OotqyzQ2ZTUoIC3zXYo9rUN2I0zCNLXbELS0UHnNOgpkQppMIvNhuAc6q1waGZy3bhigc0fXIxsgaRwVgqrwkKQqpvXx0mehNcSH37t699SG4EP3ZvgMYkNiJMrToulMv2lbtZo0PFgP27i8WLAuehgIUj57vSmLfyW/x9U4H1dqKE5hPlS1Wqe5AkiYOqJz+4YSZY35u0dqXyMxe/I4xLPbFDaYbHTG6sppPQ6iX+EDNmbbRLDJTKscdYEmSTc3dbjN6F72A/Ek5G/j+N/bn6OLKCBHDpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A6M89bglZ/pD9ejtJcGiJ0R0Y5XT2vX+sCFaTkqh/lM=; b=UUq3YQbENMbWWPEXy+j2E+Qu0iiVrEOiDc91XUw5d2YPJXlbf76zobOcIv5VG8QGs8NQTEcx6QY8K1FBBH/klFHjcyTlNF17/3vQNEtC2A9G9D7e8OeTCy5/ANbvpld6wau1cA+cFvjNFl2Sot9nDCClw8E1Z1cLYqxF/RZbnSg= Received: from BYAPR02CA0025.namprd02.prod.outlook.com (2603:10b6:a02:ee::38) by SJ0PR12MB6736.namprd12.prod.outlook.com (2603:10b6:a03:47a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.26; Mon, 5 May 2025 14:13:41 +0000 Received: from CY4PEPF0000EE3E.namprd03.prod.outlook.com (2603:10b6:a02:ee:cafe::88) by BYAPR02CA0025.outlook.office365.com (2603:10b6:a02:ee::38) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8699.28 via Frontend Transport; Mon, 5 May 2025 14:13:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000EE3E.mail.protection.outlook.com (10.167.242.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8722.18 via Frontend Transport; Mon, 5 May 2025 14:13:40 +0000 Received: from aiemdee.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 5 May 2025 09:13:35 -0500 From: Alexey Kardashevskiy To: CC: , Thomas Gleixner , "Ingo Molnar" , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Tom Lendacky , Nikunj A Dadhania , Ard Biesheuvel , Brijesh Singh , Ashish Kalra , Paolo Bonzini , Michael Roth , Kuppuswamy Sathyanarayanan , Liam Merwick , Alexey Kardashevskiy Subject: [PATCH 2/4] x86/sev: Allocate request in TSC_INFO_REQ on stack Date: Tue, 6 May 2025 00:12:36 +1000 Message-ID: <20250505141238.4179623-3-aik@amd.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250505141238.4179623-1-aik@amd.com> References: <20250505141238.4179623-1-aik@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE3E:EE_|SJ0PR12MB6736:EE_ X-MS-Office365-Filtering-Correlation-Id: c9125b91-cb26-4a85-7360-08dd8bdf0989 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|376014|7416014|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?mBJYRxr9dt1LVHlpFt9FJa9RXR2xLTQv/mosoRj6RtuaiibqWYgZam1GpMJp?= =?us-ascii?Q?h719IN/uu0IpzG8W2TFPvubpAOReth5wWvTFuFlSwBkK3gex0L5Y1TGYKmPk?= =?us-ascii?Q?/1vHEK+lrxnAYWD2rQRxz2g2+SM3kYmw1ytiiH3AQnUMUIh0DibBUQjm8nvz?= =?us-ascii?Q?YgzFd+pmLjRGkdmQgFOJUO1zM21cXNRNSJBCIfpvU+fRPnYdOjYVhYRSxhtV?= =?us-ascii?Q?Q4DE4fOg3AeoleiyAuCEO6BftaCcVC2hOK6udajD4QdgJB76X8YBxkEBfvWN?= =?us-ascii?Q?YEfk8yfK68d+p78ryLMptm5ArgbP2UYYCFP8OaniLhfiZxyNdTYrMXTJQqNf?= =?us-ascii?Q?L5mf6wsHu5Zo98XsKMoUVPF+QSepOL2/AIL3jSSFzNg6jNcf6AO524KfvO12?= =?us-ascii?Q?jKDXdDlXCOlWY8zyqbfYeq1ow4VxaKITQ38+Ps3EbcyZQRHUL1HcCE8NtZ/6?= =?us-ascii?Q?4b3kjWW2OWDKnEkAF0bhePbyzsi4DqetLkMtOo09hmFRgHvqW02j7Vwg7wYI?= =?us-ascii?Q?CGgH6aZp3eovM3dQaV/RF3M6EdKB6f/o8eFQZoes4WRd8EZ51Zx4Z0p/9NEI?= =?us-ascii?Q?c31DnxkbDRlwgnfeJK7NA4MI4kU/hsBLe631x/am2O+sLyYkQHnxeRTuDYM1?= =?us-ascii?Q?v724ytPkBtkfuayY5h7qHGUTbgRxFsD0YuRuLwIJa2huA3425bsef+PW3X4W?= =?us-ascii?Q?II3dpwve30zx92js1K6pyKG0mNF51G9q9EDNdZAQ6XW+nlWLtExEKNh1voo5?= =?us-ascii?Q?S/l/usKKROj98p839vltjI4DFZYPn56GRdp8Jqbl3lB92CSt1A9pP1yNFSgj?= =?us-ascii?Q?dTPbx87/3xMs92UgJUTGrk0L0A8AP3N0EoRETe6jBF7aTfBUbf+/L9iAOTR/?= =?us-ascii?Q?VxJ6ZgFGUkyCDUWk5r/4B2wTI0lBok/E93jHz2v8fhmkaME2zOA2+ekehhws?= =?us-ascii?Q?jO6avwFNEPBGwQYGgGAo0w/NkAn4nb2gOqfD/nEOhboXkayFOCEX3yKBm3Qy?= =?us-ascii?Q?lokkdsrOuLwtDhmnjerR4CnIXQae/3FyrUUy/wKQVz5Liq2QcR2T1cRTXAz1?= =?us-ascii?Q?9qu50IcOuOhudGDRjRbk4qPCgxjsoscyEWVIdjP+n/iak1pKZd6Yul6lAWsP?= =?us-ascii?Q?Bos5Zq0KzOzaPaDOfrKDULRdHg6nSJLW6uP2lKNgcsJJtMpwFSskigRSH8a3?= =?us-ascii?Q?Sc+vEKCdh6dA4hfUt5L6r+eWrJZYKNBO5k5BzSD7y6rEsuLzMKxgEAJrbzCe?= =?us-ascii?Q?8JohXNI2BLSDjLczCp//ruA8Hvqhhf4f1aWxJ1XwPukkGzcYiyv/svNCwkiU?= =?us-ascii?Q?tIES+iuA+q2dH35pmgh7yjNUVh+vZOB6xaGOGVtot+BAICVbLukfSmcA7/Na?= =?us-ascii?Q?13rlfBmf7aKASixaeL5pSgl4KizFYLtWn+4SOdyEhkgBYCTE/pXgkIEYipTP?= =?us-ascii?Q?jbbVR9Z0eUVNRB3x4JRknifDyg0dg0bl8hLHVsbmBYiqPshH3BsEE24wNgU2?= =?us-ascii?Q?868lyrocH3m3v2dBCKZTzzEF4SihCIbkfEUz?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(376014)(7416014)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2025 14:13:40.8992 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c9125b91-cb26-4a85-7360-08dd8bdf0989 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE3E.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6736 Content-Type: text/plain; charset="utf-8" Allocate a 88 byte request structure on stack and skip needless kzalloc/kfree. While at this, correct indent. No functional change intended. Signed-off-by: Alexey Kardashevskiy Reviewed-by: Dionna Glaze Reviewed-by: Tom Lendacky --- Changes: v4: * keep initialization of @req in one place as before --- arch/x86/coco/sev/core.c | 30 ++++++++------------ 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c index 7a49c896feb4..818ae7b1694b 100644 --- a/arch/x86/coco/sev/core.c +++ b/arch/x86/coco/sev/core.c @@ -2002,7 +2002,7 @@ static int __init snp_get_tsc_info(void) struct snp_tsc_info_resp *tsc_resp; struct snp_tsc_info_req *tsc_req; struct snp_msg_desc *mdesc; - struct snp_guest_req *req; + struct snp_guest_req req =3D {}; int rc =3D -ENOMEM; =20 tsc_req =3D kzalloc(sizeof(*tsc_req), GFP_KERNEL); @@ -2018,28 +2018,24 @@ static int __init snp_get_tsc_info(void) if (!tsc_resp) goto e_free_tsc_req; =20 - req =3D kzalloc(sizeof(*req), GFP_KERNEL); - if (!req) - goto e_free_tsc_resp; - mdesc =3D snp_msg_alloc(); if (IS_ERR_OR_NULL(mdesc)) - goto e_free_req; + goto e_free_tsc_resp; =20 rc =3D snp_msg_init(mdesc, snp_vmpl); if (rc) goto e_free_mdesc; =20 - req->msg_version =3D MSG_HDR_VER; - req->msg_type =3D SNP_MSG_TSC_INFO_REQ; - req->vmpck_id =3D snp_vmpl; - req->req_buf =3D tsc_req; - req->req_sz =3D sizeof(*tsc_req); - req->resp_buf =3D (void *)tsc_resp; - req->resp_sz =3D sizeof(*tsc_resp) + AUTHTAG_LEN; - req->exit_code =3D SVM_VMGEXIT_GUEST_REQUEST; + req.msg_version =3D MSG_HDR_VER; + req.msg_type =3D SNP_MSG_TSC_INFO_REQ; + req.vmpck_id =3D snp_vmpl; + req.req_buf =3D tsc_req; + req.req_sz =3D sizeof(*tsc_req); + req.resp_buf =3D (void *)tsc_resp; + req.resp_sz =3D sizeof(*tsc_resp) + AUTHTAG_LEN; + req.exit_code =3D SVM_VMGEXIT_GUEST_REQUEST; =20 - rc =3D snp_send_guest_request(mdesc, req); + rc =3D snp_send_guest_request(mdesc, &req); if (rc) goto e_request; =20 @@ -2060,9 +2056,7 @@ static int __init snp_get_tsc_info(void) memzero_explicit(tsc_resp, sizeof(*tsc_resp) + AUTHTAG_LEN); e_free_mdesc: snp_msg_free(mdesc); -e_free_req: - kfree(req); - e_free_tsc_resp: +e_free_tsc_resp: kfree(tsc_resp); e_free_tsc_req: kfree(tsc_req); --=20 2.49.0 From nobody Mon Feb 9 18:59:58 2026 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2049.outbound.protection.outlook.com [40.107.223.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B021417993 for ; Mon, 5 May 2025 14:13:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.223.49 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746454441; cv=fail; b=Ulx49OZfkRGdMdvd2zzR0cFl/9llYt8XW/gE6GsBXJOGZ6ScryY8S1fClcIGBRhRMyVabGiLm2VWq85pzS2i2k8MnqvDe6PJ8so/yfNmze1p3+dlCXqdaYb0ofXBxqfYMj7Up7Ew0HXn2vetGd1SIZNDFLnWHbsu7/6e89FSeBE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746454441; c=relaxed/simple; bh=qixu2PwtYPw+/eOWgMQXNfluwGc5pNyj8Fd1Q3PbOwg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=F3u8C3Eh7ZcECOmu4DbdBt7ZfYcMLiFzYtdCOELOHFpkQmrzVSMpIYQQ+K8oX/UgHkFcDmkZ5j+tiHEE5YOAs46kJYAI5ZxEfAcyregjZ4rdsNcSkr6lNcAf4u8mo1JBjSNIHHY5aPGV4hKL+EumKgBHAs2ew0vWD5VA1r8kI7Q= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=S/a61J7l; arc=fail smtp.client-ip=40.107.223.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="S/a61J7l" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WM9CSDIq12zYS77kzJRkrbj6R3cT2j65/1hBwNVdWaRIB4EsduyhOXZ411neDWIW2DFg5lmS0pE0gpvekvCVElf0yNABrVqAfqutaemNKNCR9hPMVW+MMlbmq99hySlLxqcXCdkcuHeT4Og+o4ws1roWg0jTcR2pmzDCSzYeyq76iaVOVgR4YbOSHLac1wJQwNp6LdG2KRBLa01UzA32cnOqCcxluFMYNn7hyPTgH6DC+ffx8kirYD7rIhN7sslAHW2p1SIjQ5L0xaiNr7ISIxg7ilbOaEL1dj55RpB6yplHDX5kjaufyLHfVGNDz3xgDpRc+8ZoVupRZ+tV2RMxwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xtCHTBj2ikjUoFZLg2R/mABh1LpJMFoE8LMOfmVxPVY=; b=Tx1u/6xZ+9cbenee21rkSRrCxYk73JX9kfd7xIHWgmjYQLa0MLeriV1dhkp6eb+eW6ef7WTGLbpouDl16kHEmmBVVF/pY38+qiiefzgkvjIwnG87vGQWUqTs7zGnF+gz4qA4Q7WSWOBU01aAxsbIfcjRlaCljEER094Bqx2s1BhWlti7/QDwpvPrEfiM088GRYIo9t0GJkCoOilABx3V3NlziavsYHvb/NInl17ZDSleCHCntCs/l2pusjm/l9azDwg9h2wKdoU327fN8ZCCnp2SSrmpFcgQdIMdJFPqs4otIAyjreu6lR0sr3UzrrMp7Gvb9Ws7I/nFMoopZtZtOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xtCHTBj2ikjUoFZLg2R/mABh1LpJMFoE8LMOfmVxPVY=; b=S/a61J7l06Bu1ApNuXdfz8fp1GElZhvmG9YXtuisVvtaOEDH7bNWr/15VBrjGU0htP4izATkn6Lspf/OvOES9rArfmK4K/e0vTIpKsmCg1+ow5neXZXz3hWSHHOdBW6uYe27sRXYrB0IkHutJYleW1g/NklsxsDGKcm4lkErfcY= Received: from DS7PR05CA0079.namprd05.prod.outlook.com (2603:10b6:8:57::9) by CH8PR12MB9743.namprd12.prod.outlook.com (2603:10b6:610:27a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.22; Mon, 5 May 2025 14:13:57 +0000 Received: from CY4PEPF0000EE3F.namprd03.prod.outlook.com (2603:10b6:8:57:cafe::3a) by DS7PR05CA0079.outlook.office365.com (2603:10b6:8:57::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8722.19 via Frontend Transport; Mon, 5 May 2025 14:13:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000EE3F.mail.protection.outlook.com (10.167.242.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8722.18 via Frontend Transport; Mon, 5 May 2025 14:13:57 +0000 Received: from aiemdee.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 5 May 2025 09:13:52 -0500 From: Alexey Kardashevskiy To: CC: , Thomas Gleixner , "Ingo Molnar" , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Tom Lendacky , Nikunj A Dadhania , Ard Biesheuvel , Brijesh Singh , Ashish Kalra , Paolo Bonzini , Michael Roth , Kuppuswamy Sathyanarayanan , Liam Merwick , Alexey Kardashevskiy Subject: [PATCH 3/4] x86/sev: Document requirement for linear mapping of Guest Request buffers Date: Tue, 6 May 2025 00:12:37 +1000 Message-ID: <20250505141238.4179623-4-aik@amd.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250505141238.4179623-1-aik@amd.com> References: <20250505141238.4179623-1-aik@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE3F:EE_|CH8PR12MB9743:EE_ X-MS-Office365-Filtering-Correlation-Id: 2dfa29a5-40a2-48e5-6bd2-08dd8bdf1351 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|7416014|376014|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?YJF88JC4K4u/4EVakOb9heNPDaS+7MP44ftEM8Zq+LcVO439D0azGZQBAcTE?= =?us-ascii?Q?CbqhvcoedOKJ5a0LdSUHbv6zl4KmOarYXFrtEl/aX1E+GBuDt8hZfQPLwytd?= =?us-ascii?Q?UGIVXNldQvxjP14k1f9G48RlxZsNcIlUr7Eo7Y0kkSffCu5skIWMLyE0HkmH?= =?us-ascii?Q?EYDC8V9dCGwlPbcpgtMQdEa0Dh8c/ELrgS2WHY6iJv/rPwmUzm2W1OvGSR+s?= =?us-ascii?Q?lguS3VDD8x37JjyEDGD2EPHZONfMUkEdO7fBdiMNHUqcHKNHhZRpAq1Uxx67?= =?us-ascii?Q?CaovL8eMEFyJxuRQw7gAtFrcL9CtRsRW3aKIjGQEtfYH/0h8UT0xFlyWJora?= =?us-ascii?Q?Wuodovii9RAXwT5obNaFZ5KtozQcuS2M3fYOUBP/deOtnA6agbtmn0AQN4DX?= =?us-ascii?Q?Na0o9LleiRpzZ/dYCiJlBlWxyUfl7yk4ecv4uzfH09LORK8l2WV1txUVs1Vr?= =?us-ascii?Q?FDAdcIm5QgphifCdWGTVKpdXEzZ0sIJo7C/tSjpjiYa2OsflngWP8gVhzp8F?= =?us-ascii?Q?Ve9C9ziFHdBhOIo7JrNhBAMvKKYKuwl8B5a70I3U0rS21whl8FJ5PxPC3hMf?= =?us-ascii?Q?GwwCpQb543iHLqDSGmGGZK+sH3F3gP0hXE+hKC4UAlHpNpn4+2bu3/yc1rmA?= =?us-ascii?Q?Ghp5aUTGzUcNvH2fNp/twOehKMJ6BXO+nqOTT0QcqvhwH9BQcG314VFIZL/k?= =?us-ascii?Q?WWXfXc42tvS5l9TL1s7I2LU+PIPKWpIY6R+kKQDc3XMuQbBjXNmVi6EVhGQe?= =?us-ascii?Q?Be23rgZOVFsXaDe5+rAQmelLR884esS8vKMKGu9Gue++tBOZGR+0x662thRY?= =?us-ascii?Q?ksWJRB5AZ/hSAWWqjsHEnZbOA7Ma+cit+WifkGYLpwWx3P729mdUlDkAqD+7?= =?us-ascii?Q?6Obuh7nk6bgv05ra07jSaMhBsgQdOFpux/cnAnFg6MoCN2Nb8qZ4ZTP4z3pp?= =?us-ascii?Q?IzjtVBCybKAosdIE/GinpFTKZRQV9xEhcZNYI2AzglXKFZDjtXFCj5q87GiX?= =?us-ascii?Q?aMf+XXWVyEzLgQmiVnE712w946YfxgsLXWFi3fpt/VSH8vXoyZ/eQkqirsCx?= =?us-ascii?Q?+cPRk9zKAAZsY71b1VMKcdcwOZiNnrn3qTlGE6BZgcWxofFXDtS4ok5nj2Bm?= =?us-ascii?Q?J5PQ2z+1vs/0gmSPFT+yF6Naxir5yArdho+Kj42EN9hudt9d82EAU5S8da2x?= =?us-ascii?Q?VO0muT57UJS5L5nTRZm9YDWY3FffuWR7aKclQhbqax80dF9vjDTyHK7SV5xW?= =?us-ascii?Q?4F/fOqnQ2kCb7JsF5ABJP3LO0AdzJCFJ8dLuYWoDmSB2AxRaoH85n4r74Gw0?= =?us-ascii?Q?Re5J/ZrK5tqWdIw/2RU5nqpPsbk2IBurRPwSXNv8hxGacwvDJtpHQJReMsaX?= =?us-ascii?Q?IweTGrxC6f2NbWRXBW6mU+2PuYLnZSEL8rP5ZOH3J9bdi2+0FohphL1QCL3l?= =?us-ascii?Q?4v9jWIfm3k2h0pJARML/V0aQ2gU/0hAcpc2F2yoB/eimiQEZh56p+6GvIEB0?= =?us-ascii?Q?hseRigM/gQQUWWJ9VaSaQyloK4p/gcFFh50q?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(7416014)(376014)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2025 14:13:57.2991 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2dfa29a5-40a2-48e5-6bd2-08dd8bdf1351 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE3F.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH8PR12MB9743 Content-Type: text/plain; charset="utf-8" The Guest Request supports 3 types of messages now, the largest is the extended variant of MSG_REPORT_REQ: sizeof(snp_ext_report_req)=3D=3D112. These used to be allocated on stack and then moved to the SNP guest platform device (snp_guest_dev) for the reason explained in commit db10cb9b5746 ("virt: sevguest: Fix passing a stack buffer as a scatterlist target"): aesgcm_encrypt() and aesgcm_decrypt() are used for guest messages and might potentially use a crypto accelerator which requires DMA buffers to be in the linear mapping. Add a comment, pr_warn() and return -EINVAL when the buffers are not in linear mapping. Signed-off-by: Alexey Kardashevskiy Reviewed-by: Dionna Glaze Reviewed-by: Tom Lendacky --- Changes: v4: * ditched BUG_ON and ifdef --- arch/x86/coco/sev/core.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c index 818ae7b1694b..0b714df62445 100644 --- a/arch/x86/coco/sev/core.c +++ b/arch/x86/coco/sev/core.c @@ -1941,6 +1941,16 @@ int snp_send_guest_request(struct snp_msg_desc *mdes= c, struct snp_guest_req *req u64 seqno; int rc; =20 + /* + * enc_payload() calling aesgcm_encrypt() can potentially offload to HW + * which involves DMA so the data to encrypt in the SG list has to be + * in linear mapping. + */ + if (!virt_addr_valid(req->req_buf) || !virt_addr_valid(req->resp_buf)) { + pr_warn("AES-GSM buffers must be in linear mapping"); + return -EINVAL; + } + guard(mutex)(&snp_cmd_mutex); =20 /* Check if the VMPCK is not empty */ --=20 2.49.0 From nobody Mon Feb 9 18:59:58 2026 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2068.outbound.protection.outlook.com [40.107.95.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25EBD17993 for ; Mon, 5 May 2025 14:14:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.95.68 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746454459; cv=fail; b=Dqg922+d/VwBqusDqzRCBPKhQp1BI+RhbWVs/I5tlGGfCeV4sAPGDNkEMbNhPZG6uekZU7THl/tjfnnjo5BDGXoILhZ9uhGH+6AuGFV/NOWIYz3oJjedLvLCsEoA8lZ71RnnTnpl53GeD9lr2y8YvEPvJE66UJsPUICe1yCtVQo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746454459; c=relaxed/simple; bh=FgvQYS7cp7zyMu19Ze7Xkvl2B3hyTaBlVH21YbJfTig=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jzN0p9mkvA7MNs+RrczIHMJuQ3LEbgO3okdLQUjn3Hh5JnFXWyjHF3cLqQ6Ks+YYMI0J4GovhRAEzoKFOztKJHgjwzZqLkQSUiKTQEqj/z1/QbOMWvjuxoXlOBLDoues+5MAarhfDvpPFF5BeeIIY0MJzXGieD8q0s9HAv7VmiY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=2wib2o3u; arc=fail smtp.client-ip=40.107.95.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="2wib2o3u" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=werh/cmWVHYX71ISvEKlGyLtoy9/CyRQxHBgeli4Cc7nCjXFcSGUyXDdYI67WkyjHn6vq60Pq2k29utrgnBZWo7TfGmVDerFag4LNBwbLlRO/zm7hkyLPlPjDnRGdWEPP8Ar58NkWM5JTgtEBUKhESaHSlnSmcqEMORMw1qGzflBL57adh2hs0LLqrGoIk8E8OqPx1FolnvWmnjTJzNY/MYbudHXoq+WHqviaWzhM9qNcmqVpfm5rGyPDbMd/zLbW1WtJhGSR/B7W/gfiOaFB4Btt/CY6kI1pdvSgCq+APLLb9szXovFWl6DYwFQaL1Y4uYFG3cSWAKq07cL/CT8uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o5/g+QkU580S89oKwQSW88bt/90xhIB2AOp8xCEH3Ls=; b=liutExWv7lPvf7LWMig+j1l6iUBBB+dSyGkxIEQmc5n8H76tgprmBDG7FdrT4H3Mf9mD5TNoLxgrFsHqNhJ4wfjdKdJk/44XVy+eYLnAjrvDFKp1AJLsMWNeoKKmnXiWazZQvvMKA3TOdhPXoeAdKiJWuWStWwvCkZD1g5wVzItYTrPfXp27sZ0lbGMMJ/tdDrRwDDy0bEi20LHS29muYDsxUFkrB1IE4FYFBXXAND7X3OdsPctsJ7U+w2aqWB4kjeyKq8/66KorQvu3Jk4umxZzVVQpB8aTJ4DIdn4IeEWNYHn17/J7/WX4yW34vIGcwljoXfTaYN2LMOvrNnAzJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o5/g+QkU580S89oKwQSW88bt/90xhIB2AOp8xCEH3Ls=; b=2wib2o3ugDJd0IwojYOgVJeVaQMeqRkJRJeyf5yJZ/fIjtHE0/2a3fsQXXhR1xlHh9XOKTNohdYiqjTVRWveoAj+4p8sOP6zba4ppMesg6IpRXofl9AZdNAKrFUYMoUILwfPh2jLowGEawmNylt3q5maRuY1HenZbtJ8RuyuJ7I= Received: from DS7PR05CA0045.namprd05.prod.outlook.com (2603:10b6:8:2f::7) by CH3PR12MB9395.namprd12.prod.outlook.com (2603:10b6:610:1ce::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.26; Mon, 5 May 2025 14:14:14 +0000 Received: from CY4PEPF0000EE39.namprd03.prod.outlook.com (2603:10b6:8:2f:cafe::7b) by DS7PR05CA0045.outlook.office365.com (2603:10b6:8:2f::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8722.19 via Frontend Transport; Mon, 5 May 2025 14:14:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000EE39.mail.protection.outlook.com (10.167.242.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8722.18 via Frontend Transport; Mon, 5 May 2025 14:14:14 +0000 Received: from aiemdee.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 5 May 2025 09:14:09 -0500 From: Alexey Kardashevskiy To: CC: , Thomas Gleixner , "Ingo Molnar" , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Tom Lendacky , Nikunj A Dadhania , Ard Biesheuvel , Brijesh Singh , Ashish Kalra , Paolo Bonzini , Michael Roth , Kuppuswamy Sathyanarayanan , Liam Merwick , Alexey Kardashevskiy Subject: [PATCH 4/4] x86/sev: Drop unnecessary parameter in snp_issue_guest_request Date: Tue, 6 May 2025 00:12:38 +1000 Message-ID: <20250505141238.4179623-5-aik@amd.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250505141238.4179623-1-aik@amd.com> References: <20250505141238.4179623-1-aik@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE39:EE_|CH3PR12MB9395:EE_ X-MS-Office365-Filtering-Correlation-Id: 76d5f884-0c40-4999-5a38-08dd8bdf1d5e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|82310400026|7416014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?KMDYJ3PxR+Lv6KdgdexRFAy1VoDyVyYKe3KH4nc10aJiTpAxyRLOUagzZwLs?= =?us-ascii?Q?q1+1U8q+UD/6Wjkjkz3OEf6psuO+BA7I6p57gbOyRaZU9cjjwaAUDaadOvZA?= =?us-ascii?Q?yLfgvnjsuqQVqbtmGwamY6BBenWbQhctKHsboUmdbRn300oyCWIjLvF+0RxN?= =?us-ascii?Q?0NwUzns+Q6Q+c1pdHSHt1TDg6FQLZ50mM6RqGbZs3D8LhZmSkPQdMsEUqv8X?= =?us-ascii?Q?LaRVVQuaZGuFVeAXpfgTTMd4oIk8c+u+ssWhdm51cmlVUWhq8nicQvB+ftSg?= =?us-ascii?Q?7D58C4b5r7UPqMNMfsHEHnj41L97uU1z+L0XHbBaikJQQYMbRdLL3UfsI7WU?= =?us-ascii?Q?nREOxS6o9xNQnvW88Wc+SWfKn8BKvFOHib8rd3dwK7LSJ/+qKI5JwyXufAsm?= =?us-ascii?Q?l5rinvRFKrFP2VIkMocAtjYmaCPaQWH3plLQcTm25zObTwZWsdWySu1RB9M7?= =?us-ascii?Q?DhzWtUqZl5eouKISspVPVpPE7hSU1t9a3V2WIGFQAbTm5TksVYwV1253EcxD?= =?us-ascii?Q?0uv0jYADBUJnOWfZE7Hz6fhoRA63R83ATGCddZgdQeyGMZ2NK8cG8xKx/+O+?= =?us-ascii?Q?7cAc9oeIm1yQHWI74E8b6RdGpc6+S6Hq4d9O40f7h+sA5ZzIHy8mSKgU1XV2?= =?us-ascii?Q?IReUGBgZj0L38bu6uPo2AR7dqlCKtknDgwfEPtFQifaVVVeJkbetajqYcnvS?= =?us-ascii?Q?C/ZwEHbVfKRY2MhQioDMv7sO1tWbdkXMiOAAUAYwsIDV6dItJKuJZk0dUe1W?= =?us-ascii?Q?0CBlMi3glf6F87EAW3GkEy++9AeJsJV1T1Nn4zH1ZCuk1VF4tz0ZR70iHZpk?= =?us-ascii?Q?+g6sAjQ1dlVuZDhapWvu8QZmYwPdddu2ilgv7aWjNb7gOVkSoqCi0CbjmLME?= =?us-ascii?Q?OMdAIktxMoVPHGmTDs22gKJ4Xav6LNhrdYK3A4bs4CG1GALBa5s/jGQ6f/ks?= =?us-ascii?Q?pn/FHD4Usx6YW2byLCAjmvoZ0iDBpqTYz/sgitCF1rIY3oBOr3z02hogjdVW?= =?us-ascii?Q?kXQGBZixkxBvVojLSXj4PWS+LFuaYm5n4Be9bEpXc+28oGrmK7VBbf1pGYBn?= =?us-ascii?Q?u83Rs2ZZs576/M55V7qg9B2+KJnDK7yxNvvEwWjHQov3inKfoTlvE5xHhy7k?= =?us-ascii?Q?Vzxb9MkTT6Kvw2YiDCzBBXRftCiVJ6xPwO5UdjLNXDos6Av6c+Tc9Z7e55ou?= =?us-ascii?Q?RyaPpZxmzCJ1kbdkAhjtI6JBUXSS229MLiOyryEGl4HUOdzp4W3Wp77lu1Kq?= =?us-ascii?Q?coYrzEDsdoONnkb9KzDgN5ReFBK80gITWUbIzBrqOhaviQ8TnjMAEEKJAsPn?= =?us-ascii?Q?mK5mytco+0b1WHfcS7gVwTIk7laAmrI08FWeM4JhVoWaqOJt1aH5HjK3sIp/?= =?us-ascii?Q?0dNNa/smzQ76aMU+i8S1fk68SeD3BluoJqBCWuNqik/WnF76naVM6hcIzkl6?= =?us-ascii?Q?NUyRdMPwYRgmOeZ+BbXbRY0Pss5lMbbBodv1CF0zfhDQaDAgyUWIXV1XmiIx?= =?us-ascii?Q?mpzlaWW+aPukXH+SmbrhBKqiAmahNvgW1t3A?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(376014)(82310400026)(7416014)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2025 14:14:14.1706 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 76d5f884-0c40-4999-5a38-08dd8bdf1d5e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE39.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9395 Content-Type: text/plain; charset="utf-8" Commit 3e385c0d6ce8 ("virt: sev-guest: Move SNP Guest Request data pages handling under snp_cmd_mutex") moved @input from snp_msg_desc to snp_guest_req which is passed to snp_issue_guest_request(). Drop the extra parameter. No functional change intended. Signed-off-by: Alexey Kardashevskiy Reviewed-by: Dionna Glaze Reviewed-by: Tom Lendacky --- arch/x86/coco/sev/core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c index 0b714df62445..0334c40a5c8d 100644 --- a/arch/x86/coco/sev/core.c +++ b/arch/x86/coco/sev/core.c @@ -1322,8 +1322,9 @@ int snp_issue_svsm_attest_req(u64 call_id, struct svs= m_call *call, } EXPORT_SYMBOL_GPL(snp_issue_svsm_attest_req); =20 -static int snp_issue_guest_request(struct snp_guest_req *req, struct snp_r= eq_data *input) +static int snp_issue_guest_request(struct snp_guest_req *req) { + struct snp_req_data *input =3D &req->input; struct ghcb_state state; struct es_em_ctxt ctxt; unsigned long flags; @@ -1865,7 +1866,7 @@ static int __handle_guest_request(struct snp_msg_desc= *mdesc, struct snp_guest_r * sequence number must be incremented or the VMPCK must be deleted to * prevent reuse of the IV. */ - rc =3D snp_issue_guest_request(req, &req->input); + rc =3D snp_issue_guest_request(req); switch (rc) { case -ENOSPC: /* --=20 2.49.0