From nobody Tue Feb 10 01:31:17 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDE4F2690F2 for ; Mon, 5 May 2025 17:42:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746466930; cv=none; b=cBmtnH/YXjh280ITBGxd/GkHLsf0fcI4MM7zg9DPSTjqiIoTKd6V8Y/h+x2/IzsHaQwTXK9n6MT5F7q0810Bu6oh2mxexWXW1Lj0eqt9TLLPUZxCLJCpaV3lX7PhypSlSjzh7djhIM8VWypFuW/RZ3XfGH5MyMakVYipR3gDF4g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746466930; c=relaxed/simple; bh=fAH11pHsRrYKcysroQjLM8Q9UwAmjfM3znAZKnmfIi8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=f5kGi0hFUUa54ukVZ6CcIQzEUdhQcNsyfVeQi4KR6J0E5QgdfhiK/HkmRMzrAGxS3n+ZbO5lsYQMO6UTijkdvanct1DSJ4SnJG5SIBbKx8xxsQQlRBZGcUvUpK8Djekgj1IF3MZdT/BUjQcrHlpgPqJJRuDkpVzmXxtaA8/ReVU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=I411hL8P; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="I411hL8P" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-39c266c1389so3483110f8f.1 for ; Mon, 05 May 2025 10:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1746466926; x=1747071726; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+RjSK5+oOhqZKQ0oK0twEFsYWTKP2YoDTHH/eJYqDLQ=; b=I411hL8P9bibRZoMbu52yEjnvCF6kAmIchHnNoTP6/TqNQWeQEKlw5UY5RW1j9I/UG Pk0wABnp2ASWeB7xc/qRADcxa1G98nylvxf9VEeb1yspaucfBWX9UDlJU3C5dKcpKV2N NYZUDcbt+v6cj1hmUsZvHymXaMPopcVvvbktEDXJ/zIkhsKfy+LFxIDOM6SpfJksNREO 7RBFZ/fLsDSkGC1N4dZodQp9CLkI0mrtXkQe7eXCgyasWbUZtU2cYcT3q6azFF2loG3G E2KGAEJjxy7v5TB1xNyH4T2QUey4HiOzVgwfdx3WyoeQUvtY6p6MNXanKZFuhXjO9AAc ObFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746466926; x=1747071726; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+RjSK5+oOhqZKQ0oK0twEFsYWTKP2YoDTHH/eJYqDLQ=; b=VgiuaFJ9qfgZxtgSYo+yYocKEwyexlFQHStNNENEjHsULIzI05Nv5Eo39YcGDxAtO8 fElqikiclK6S+fPpUiqsNiaKoTYGJ1jrueC3T0zcfiu7kSJ+CdJQuQeoSN+HHwrGpBI7 nL9NeHG9MkaEhMbObIuvCwTuwrTitbvGyjqYEEEZkr04WF291/dBr5asY2LI42j4FLlJ 3C1z7Z1nTaannG/w1pltcxcHTis7qBnIU349G+H0ZZ3zK4dNSsPNKhIjvNYtVDFyCQes xSKoWSzFfT60M94lM7N0Ka6w0sA51ndnR6r7/ka+rS1lsPSG2cUi0ylWwDz0w3wMzzmU ioyw== X-Forwarded-Encrypted: i=1; AJvYcCWrPc9pJxXefBMIWXOZ/2ntAXxRvoPMM9MGsREa/hdE05qKDGT0n5JJajeBtODbSY7B92l6L9K/TtYnjns=@vger.kernel.org X-Gm-Message-State: AOJu0YzfkfsNs4kxehRPWAd1U4zyxYYTF/svz774mErls82BS6Gcs8RD nSdZhSw3TOiDTAxVeBhuuMnaglhs5MefKeJ7NEURLbvrSVhv970IRnquWhyAq5g= X-Gm-Gg: ASbGncsyzzbUpzDTp70M26po2XbCf1O9YGOBJIgyVKmEjjqRHFGtpS+8D6GuY2QhXU5 Cr+mEX3+41qTKHhtk7e1g6wv4fle8pGle9I6A17pnYq69I0+5OfpN/vUbLCKDqVWr69OlHyEZ2I 1OIFX5Ct3v7oC9MbRC1Wx/oSgY0fkiMa2DHaVxUeJUOlmR1ENlwv0NGP11zC62w3toqtXNHlDxL IX2UCrhDsnSoX6mcWnL6nbpLoCosHDJAwA0GuKyBZPtuodgfKae1A8oBPZPMR2PU7lSWiONR+TV +4T2wPYA4yj1hyuiH1pJ1q2owBvthHzCr3TXQ9+0YJNXyHTC2PxjfQ== X-Google-Smtp-Source: AGHT+IGAYa+if0CukQnbgX4pEVrN5Xsiai21uC7+G5ERCrGhLg5b+LFY/FpMStNNjBLuuOjsvZ9R8Q== X-Received: by 2002:a05:6000:420e:b0:38f:2678:d790 with SMTP id ffacd0b85a97d-3a09fd7c855mr6686785f8f.33.1746466926206; Mon, 05 May 2025 10:42:06 -0700 (PDT) Received: from toaster.baylibre.com ([2a01:e0a:3c5:5fb1:dc81:e7a:3a49:7a3b]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-3a099b0efbfsm11345829f8f.69.2025.05.05.10.42.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 May 2025 10:42:05 -0700 (PDT) From: Jerome Brunet Date: Mon, 05 May 2025 19:41:47 +0200 Subject: [PATCH 1/4] PCI: endpoint: pci-epf-vntb: return an error code on bar init Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250505-pci-vntb-bar-mapping-v1-1-0e0d12b2fa71@baylibre.com> References: <20250505-pci-vntb-bar-mapping-v1-0-0e0d12b2fa71@baylibre.com> In-Reply-To: <20250505-pci-vntb-bar-mapping-v1-0-0e0d12b2fa71@baylibre.com> To: Jon Mason , Dave Jiang , Allen Hubbe , Manivannan Sadhasivam , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Frank Li Cc: ntb@lists.linux.dev, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Jerome Brunet X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1058; i=jbrunet@baylibre.com; h=from:subject:message-id; bh=fAH11pHsRrYKcysroQjLM8Q9UwAmjfM3znAZKnmfIi8=; b=owEBbQKS/ZANAwAKAeb8Dxw38tqFAcsmYgBoGPhoKlIvsdmRmR9d6/kM75+1NA+V25FqgfZ4A LjBSUdeufeJAjMEAAEKAB0WIQT04VmuGPP1bV8btxvm/A8cN/LahQUCaBj4aAAKCRDm/A8cN/La hWvCEACJQ3glDx7dWhKRBd+uiK+/HZdut2ULVasmSE/3OzCr5HaDdpm5oFp1p/SPpmW/13cgqIR ju1V858zABuU9lVRidP/F6No+RTJfhh2lRQRLAFJ7y796sHXI96Wnky6L+g3nloKQQ557hwSITC nIfr8pW2RffnHuorPF4sr0W7gzKLAIEOJaxeGn2EAYFThw0vJmjLnHcAzpKlu2gNqRUsV6UokrB QMWj+UrP9UNAQ9fryuVyxCOW+JtIbjmTNno/1bjwWPEs3tG+MswgbT7UCFBl5KBNtmD3QWUyt4x XEniJy1KhdE/8AvcBfctFTMM8dZpY6P1cTQAukOThQbd3Pxrd9eq/jG5t1tP2vMxF3BFETc5mt1 PA349TzY8INQGg2vQJvRE7nfneZSM/++WL/z5Hf9oa6fLO1ztBIvuJghyfNjYXKYJDD+VMMPc20 nwan4o5n+1O7DR+qMMwaaI5JDLFOnUQ/NegzCtUR6t0kgXd4xOiI+kBScwwMmeulsE+pX7jVxMN s1a4kUeYqC3unYWS5WdD9Otwqw2abNqWYhiAS0o9s+O0MT2mPLJ1ndYYuOv/Ytjz05t+5EEi84T 0ZnPAcYq11sHoEg1ECjqdj4ayc4axe8FqKUyKI3eUSH2r65VOleE2GX3Tij5tF7j3ANz1GUtLL6 VfwZygZfa1KIWNg== X-Developer-Key: i=jbrunet@baylibre.com; a=openpgp; fpr=F29F26CF27BAE1A9719AE6BDC3C92AAF3E60AED9 According the function documentation of epf_ntb_init_epc_bar(), the function should return an error code on error. However, it returns -1 when no BAR is available. Return -EINVAL instead. Fixes: e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP= ") Signed-off-by: Jerome Brunet Reviewed-by: Frank Li --- drivers/pci/endpoint/functions/pci-epf-vntb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/en= dpoint/functions/pci-epf-vntb.c index e4da3fdb000723e3adad01f0ddf230ecc0e572a7..35fa0a21fc91100a5539bff775e= 7ebc25e1fb9c1 100644 --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c @@ -680,7 +680,7 @@ static int epf_ntb_init_epc_bar(struct epf_ntb *ntb) barno =3D pci_epc_get_next_free_bar(epc_features, barno); if (barno < 0) { dev_err(dev, "Fail to get NTB function BAR\n"); - return barno; + return -EINVAL; } ntb->epf_ntb_bar[bar] =3D barno; } --=20 2.47.2