From nobody Tue Dec 16 07:35:36 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78F871C1F05; Mon, 5 May 2025 21:06:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746479181; cv=none; b=GkIS1d0cJBT0s+xuNVo+Ey1aNZU6MhLAMV1joRkeSxxvqLuoPGtU9iLHis5kTsx7TvXPwD4mtD5wBswDHpqpdrkDc/04SbHww8RQ+tTsUgawkbkohtL3F/AhkQNcdULbBQ3t056OvS2S4FTy/Kcdf+uddCSX4W0qKOUKB1IuBIw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746479181; c=relaxed/simple; bh=8a8vQY24kpOTOSPqYHfBqqeVHZ2y0yNa9wTnorDnezo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=f0eL7QuhTjQFMUOrcS4Cl8z/ylMuo6HheZIMgoSAKGi6WSGFX5bcJVzJmqEJJd7kh2j6rqXhQPdLFcM9ZFPWzuoWyIxjrEqTtvVpeoooOY0oD5WIRZOoM211cWlsuz6Yg9wD+Z04CPYPaD09RORJPRDvWFX1IgwCLjGKZz7P3Js= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=unlUM/5l; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="unlUM/5l" Received: by smtp.kernel.org (Postfix) with ESMTPS id F38AAC4CEEE; Mon, 5 May 2025 21:06:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746479181; bh=8a8vQY24kpOTOSPqYHfBqqeVHZ2y0yNa9wTnorDnezo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=unlUM/5ltHZsBn615oUc6nrc9w/dn60B1TcBHwxLtiEEOsUmLGyBvP+8O3fxQTzEB kqV8f35GEk64ZUTBCGtGOPU9+9xs61SuMTyXXgZD9mNJp1VTpSxZNqOfiwsusCg8Gk 5Bj9nelwEQ3Qns8tmYHdQbK1L1ltxo8sqOv6Q4j7/UGMN8qNz1eSUHeY3ZCG421LIx IaLpA14mqgZkcT1SIwORILnbWCOxuIJlqVIUr+z7tmCdjdGs/oZuGp4y+pheG2V4Kr gRVku9l5LgEsy4BfFTAC/PNbps4Np2EA5oUNGrS3CKqUK5wwemX/1T012gov9vYT3m vbkvwtTRBzSCQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id E344DC3ABBF; Mon, 5 May 2025 21:06:20 +0000 (UTC) From: =?utf-8?q?Andr=C3=A9_Apitzsch_via_B4_Relay?= Date: Mon, 05 May 2025 23:05:53 +0200 Subject: [PATCH v2 1/4] media: i2c: imx214: Reorder imx214_parse_fwnode call Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250505-imx214_ccs_pll-v2-1-f50452061ff1@apitzsch.eu> References: <20250505-imx214_ccs_pll-v2-0-f50452061ff1@apitzsch.eu> In-Reply-To: <20250505-imx214_ccs_pll-v2-0-f50452061ff1@apitzsch.eu> To: Ricardo Ribalda , Sakari Ailus , Mauro Carvalho Chehab Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Apitzsch?= , Ricardo Ribalda X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1746479179; l=1201; i=git@apitzsch.eu; s=20240325; h=from:subject:message-id; bh=JSOcAgvTpyrSY1gtujk/NN7HrGG2Tbe4hfXbnAXabfw=; b=A17WdpUX7bcV8mSaK6O1qISUffpXeg5wKTbZf8Tzgm8CijG16W3pkgwt40u5qH6MH2D7cU0or gwNaN4QORFACswGPFFRU1RDyLTGMFfstBijxE5Zvu4dWI+WQ7FH5b7P X-Developer-Key: i=git@apitzsch.eu; a=ed25519; pk=wxovcZRfvNYBMcTw4QFFtNEP4qv39gnBfnfyImXZxiU= X-Endpoint-Received: by B4 Relay for git@apitzsch.eu/20240325 with auth_id=142 X-Original-From: =?utf-8?q?Andr=C3=A9_Apitzsch?= Reply-To: git@apitzsch.eu From: Andr=C3=A9 Apitzsch Reorder imx214_parse_fwnode call to reduce goto paths in upcoming patches. No functional change intended. Acked-by: Ricardo Ribalda Signed-off-by: Andr=C3=A9 Apitzsch --- drivers/media/i2c/imx214.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c index dd7bc45523d8b5fcb3ec95728a6d32c4fddede72..0199195dcb7d12dc2ff253fe3eb= 77ddbcd0812a9 100644 --- a/drivers/media/i2c/imx214.c +++ b/drivers/media/i2c/imx214.c @@ -1261,10 +1261,6 @@ static int imx214_probe(struct i2c_client *client) struct imx214 *imx214; int ret; =20 - ret =3D imx214_parse_fwnode(dev); - if (ret) - return ret; - imx214 =3D devm_kzalloc(dev, sizeof(*imx214), GFP_KERNEL); if (!imx214) return -ENOMEM; @@ -1295,6 +1291,10 @@ static int imx214_probe(struct i2c_client *client) return dev_err_probe(dev, PTR_ERR(imx214->regmap), "failed to initialize CCI\n"); =20 + ret =3D imx214_parse_fwnode(dev); + if (ret) + return ret; + v4l2_i2c_subdev_init(&imx214->sd, client, &imx214_subdev_ops); imx214->sd.internal_ops =3D &imx214_internal_ops; =20 --=20 2.49.0 From nobody Tue Dec 16 07:35:36 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78F1A450F2; Mon, 5 May 2025 21:06:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746479181; cv=none; b=LT26yWC8lYfHhcPt95wklVnw5bO+C7R/Ngt86+vjOOOEI9KyzayoOfMVPz1OrEp50Sk22cl4RmEVFeIMW4EmwiUxzQvgCowIUw8up95wVQNEj2Mha3NgwMezapXagqMFWoDd5RCM03mz5SAWJkc6IKFiGQU63RzVJeHM7Xr7wW8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746479181; c=relaxed/simple; bh=L2WGN7X2JUviaBc60J76R20EMSD9EzQJaZPVXw+rN/E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dyxk/rv8OzPZmMDET8UKtCE3ocZJFZ+I0st+qc8SWT205MhFfw5j0FqbvQadABj/nV43RnYz+6gRlt7d3aIp+roAeF3NV+MpF/8lcNBizIZv6BPMmt/9ajG5m+sce+AKWMiMG5YpB5NbBI3ZxjmMydeckVgyy24QT64QJ6+w9CU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BWozyQP8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BWozyQP8" Received: by smtp.kernel.org (Postfix) with ESMTPS id 0C656C4CEED; Mon, 5 May 2025 21:06:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746479181; bh=L2WGN7X2JUviaBc60J76R20EMSD9EzQJaZPVXw+rN/E=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=BWozyQP8O4UqTA9SvaW7TjuBaG1JFZVKtlDfsE4QDTy4RLAY+y7CxhBYMu/WB188a 1iOyjnqhFs9xGyJbrhgbscdH93Wd8rc3WdF32rlhPwPhv1SSvcNjLeFeen06MTqr0i MpSRHV7o9uSiYW8BIejAYy/jt87ff05vHu9MC85ntCGqAl4dWdPGZYDHxuSQO+/BRN Ao/iBNaWHLESSDOvn7SJ4Ul8CMmYGA9WGxDybwqo9KvbSlnUNabILsbwzgiCODQ/B5 dGvBr7TDQipXTGBKrpXKu0oq/b8GJx1zg2AyP4xY/NPG+SzHd6kifCkTUdDMxi3Zt9 keBXf9AsawNxQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id F149CC3ABC0; Mon, 5 May 2025 21:06:20 +0000 (UTC) From: =?utf-8?q?Andr=C3=A9_Apitzsch_via_B4_Relay?= Date: Mon, 05 May 2025 23:05:54 +0200 Subject: [PATCH v2 2/4] media: i2c: imx214: Prepare for variable clock frequency Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250505-imx214_ccs_pll-v2-2-f50452061ff1@apitzsch.eu> References: <20250505-imx214_ccs_pll-v2-0-f50452061ff1@apitzsch.eu> In-Reply-To: <20250505-imx214_ccs_pll-v2-0-f50452061ff1@apitzsch.eu> To: Ricardo Ribalda , Sakari Ailus , Mauro Carvalho Chehab Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Apitzsch?= , Ricardo Ribalda X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1746479179; l=3684; i=git@apitzsch.eu; s=20240325; h=from:subject:message-id; bh=ddkeGCuuPcPPzIbz+qwlV4L+uKUvrwzDr+fPplJy9lU=; b=OZexZU10Fpuk6/yCi9TMiqXMeogRkhDf/yVivEiwsqbERO1japjtgJ1EsaXXSQTmXuil0LMYX +pZKyaXaJAkCJl26yQ/gRrDCd/aItFjFY4ugUR/GywhQH2ANUyMd4dR X-Developer-Key: i=git@apitzsch.eu; a=ed25519; pk=wxovcZRfvNYBMcTw4QFFtNEP4qv39gnBfnfyImXZxiU= X-Endpoint-Received: by B4 Relay for git@apitzsch.eu/20240325 with auth_id=142 X-Original-From: =?utf-8?q?Andr=C3=A9_Apitzsch?= Reply-To: git@apitzsch.eu From: Andr=C3=A9 Apitzsch Move clock frequency related parameters out of the constant register sequences, such that the hard coded external clock frequency can be replaced by a variable in the upcoming patches. Acked-by: Ricardo Ribalda Signed-off-by: Andr=C3=A9 Apitzsch --- drivers/media/i2c/imx214.c | 54 ++++++++++++++++++++++++++----------------= ---- 1 file changed, 31 insertions(+), 23 deletions(-) diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c index 0199195dcb7d12dc2ff253fe3eb77ddbcd0812a9..3aca6ebb02d649c1b7f0b6a6049= c1e3aa3d08951 100644 --- a/drivers/media/i2c/imx214.c +++ b/drivers/media/i2c/imx214.c @@ -299,16 +299,6 @@ static const struct cci_reg_sequence mode_4096x2304[] = =3D { { IMX214_REG_DIG_CROP_WIDTH, 4096 }, { IMX214_REG_DIG_CROP_HEIGHT, 2304 }, =20 - { IMX214_REG_VTPXCK_DIV, 5 }, - { IMX214_REG_VTSYCK_DIV, 2 }, - { IMX214_REG_PREPLLCK_VT_DIV, 3 }, - { IMX214_REG_PLL_VT_MPY, 150 }, - { IMX214_REG_OPPXCK_DIV, 10 }, - { IMX214_REG_OPSYCK_DIV, 1 }, - { IMX214_REG_PLL_MULT_DRIV, IMX214_PLL_SINGLE }, - - { IMX214_REG_REQ_LINK_BIT_RATE, IMX214_LINK_BIT_RATE_MBPS(4800) }, - { CCI_REG8(0x3A03), 0x09 }, { CCI_REG8(0x3A04), 0x50 }, { CCI_REG8(0x3A05), 0x01 }, @@ -362,16 +352,6 @@ static const struct cci_reg_sequence mode_1920x1080[] = =3D { { IMX214_REG_DIG_CROP_WIDTH, 1920 }, { IMX214_REG_DIG_CROP_HEIGHT, 1080 }, =20 - { IMX214_REG_VTPXCK_DIV, 5 }, - { IMX214_REG_VTSYCK_DIV, 2 }, - { IMX214_REG_PREPLLCK_VT_DIV, 3 }, - { IMX214_REG_PLL_VT_MPY, 150 }, - { IMX214_REG_OPPXCK_DIV, 10 }, - { IMX214_REG_OPSYCK_DIV, 1 }, - { IMX214_REG_PLL_MULT_DRIV, IMX214_PLL_SINGLE }, - - { IMX214_REG_REQ_LINK_BIT_RATE, IMX214_LINK_BIT_RATE_MBPS(4800) }, - { CCI_REG8(0x3A03), 0x04 }, { CCI_REG8(0x3A04), 0xF8 }, { CCI_REG8(0x3A05), 0x02 }, @@ -405,9 +385,6 @@ static const struct cci_reg_sequence mode_table_common[= ] =3D { /* ATR setting */ { IMX214_REG_ATR_FAST_MOVE, 2 }, =20 - /* external clock setting */ - { IMX214_REG_EXCK_FREQ, IMX214_EXCK_FREQ(IMX214_DEFAULT_CLK_FREQ / 100000= 0) }, - /* global setting */ /* basic config */ { IMX214_REG_MASK_CORR_FRAMES, IMX214_CORR_FRAMES_MASK }, @@ -777,6 +754,24 @@ static int imx214_entity_init_state(struct v4l2_subdev= *subdev, return 0; } =20 +static int imx214_configure_pll(struct imx214 *imx214) +{ + int ret =3D 0; + + cci_write(imx214->regmap, IMX214_REG_VTPXCK_DIV, 5, &ret); + cci_write(imx214->regmap, IMX214_REG_VTSYCK_DIV, 2, &ret); + cci_write(imx214->regmap, IMX214_REG_PREPLLCK_VT_DIV, 3, &ret); + cci_write(imx214->regmap, IMX214_REG_PLL_VT_MPY, 150, &ret); + cci_write(imx214->regmap, IMX214_REG_OPPXCK_DIV, 10, &ret); + cci_write(imx214->regmap, IMX214_REG_OPSYCK_DIV, 1, &ret); + cci_write(imx214->regmap, IMX214_REG_PLL_MULT_DRIV, + IMX214_PLL_SINGLE, &ret); + cci_write(imx214->regmap, IMX214_REG_EXCK_FREQ, + IMX214_EXCK_FREQ(IMX214_DEFAULT_CLK_FREQ / 1000000), &ret); + + return ret; +} + static int imx214_update_digital_gain(struct imx214 *imx214, u32 val) { int ret =3D 0; @@ -1020,6 +1015,19 @@ static int imx214_start_streaming(struct imx214 *imx= 214) return ret; } =20 + ret =3D imx214_configure_pll(imx214); + if (ret) { + dev_err(imx214->dev, "failed to configure PLL %d\n", ret); + return ret; + } + + ret =3D cci_write(imx214->regmap, IMX214_REG_REQ_LINK_BIT_RATE, + IMX214_LINK_BIT_RATE_MBPS(4800), NULL); + if (ret) { + dev_err(imx214->dev, "failed to configure link bit rate\n"); + return ret; + } + ret =3D cci_write(imx214->regmap, IMX214_REG_CSI_LANE_MODE, IMX214_CSI_4_LANE_MODE, NULL); if (ret) { --=20 2.49.0 From nobody Tue Dec 16 07:35:36 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7904B1EFF93; Mon, 5 May 2025 21:06:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746479181; cv=none; b=ewT5DAuKHgED02JLar1KpAhhVKnFpbfHKxq9Wr4lcktNr4B/lTSjndgQjYo/Rw4sfWVsSNbQti/+tz3MV7RiZ9eEnUrMd4gF0DR2ZRNjx45c0RnIEXn/B0Mzk0M2Sxb7v5knbVfOcd+71nHqwehvqSGDnd5sg+YNU6YGO2r11vs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746479181; c=relaxed/simple; bh=zf4+GahcGCP05De4YqXTJDg59FcbikVU7RlqqKH9cSk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JumHP/ngKEdm9mv026xfnAaS1szj0KW+KiN+MxMRTidULTmJd9pqgNLJchKuwg8DYcpaz0BORhfq55Lz4XqpHRemieVTJJQKqARyeIoJ/ggKvr9Drjv9mVyRvRLsZyHsO7mU6GIggGTOqt0h+mxr+9bURR9SmYn01fdet7KSISU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GWcDw1/Z; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GWcDw1/Z" Received: by smtp.kernel.org (Postfix) with ESMTPS id 167B7C4CEF1; Mon, 5 May 2025 21:06:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746479181; bh=zf4+GahcGCP05De4YqXTJDg59FcbikVU7RlqqKH9cSk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=GWcDw1/ZNmcSxu0f3S6JxeZAjCJNwEZJ1ULcntllYcPEPGZs7IOkzxPianlWFkY+/ LYN/ptrGDAVq+ioM5tUBsO8bE+eb3In/NPU1FIex+n5mCsMli1vbxkP4DSwCtpCw/5 vXo5yXPBiNwlvQsFzfy7St/T0CF/XCoo5Z8wG/ebVW6mBOvCw26toqLyzYu5l3ohdi S3Q+IFb0+2G0iv1nMV9ZgLOgAe6xZWkzj6iYGNT+/HMd4X3lQda+U174pdTzcoe2WJ MWGSKzEWZCeCTd4tXuFkq0evUBQIKjnMUONuaWHHhCaeUqGiXjIf7VRf00LAfWjLeH 96ZJGQ4O1dSiA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09395C3ABB9; Mon, 5 May 2025 21:06:21 +0000 (UTC) From: =?utf-8?q?Andr=C3=A9_Apitzsch_via_B4_Relay?= Date: Mon, 05 May 2025 23:05:55 +0200 Subject: [PATCH v2 3/4] media: i2c: imx214: Make use of CCS PLL calculator Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250505-imx214_ccs_pll-v2-3-f50452061ff1@apitzsch.eu> References: <20250505-imx214_ccs_pll-v2-0-f50452061ff1@apitzsch.eu> In-Reply-To: <20250505-imx214_ccs_pll-v2-0-f50452061ff1@apitzsch.eu> To: Ricardo Ribalda , Sakari Ailus , Mauro Carvalho Chehab Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Apitzsch?= , Ricardo Ribalda X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1746479179; l=13307; i=git@apitzsch.eu; s=20240325; h=from:subject:message-id; bh=lRnvM9ovlLU9yRH50RpRp0NCi55W4Gtog/Nbf1nNTiY=; b=AGw7o2fNWb1FeYX8NdpNzA6zj7XO6uERXh/C/IOPOyz2Os4pKUB4YxpXlLiFqRzqw4PBDsttF uQJjO1R4BAgBLp7lkXmHtaCfgGRxwP4wRp/8RoA11HerwOvMCRSQUUG X-Developer-Key: i=git@apitzsch.eu; a=ed25519; pk=wxovcZRfvNYBMcTw4QFFtNEP4qv39gnBfnfyImXZxiU= X-Endpoint-Received: by B4 Relay for git@apitzsch.eu/20240325 with auth_id=142 X-Original-From: =?utf-8?q?Andr=C3=A9_Apitzsch?= Reply-To: git@apitzsch.eu From: Andr=C3=A9 Apitzsch Calculate PLL parameters based on clock frequency and link frequency. Acked-by: Ricardo Ribalda Signed-off-by: Andr=C3=A9 Apitzsch --- drivers/media/i2c/Kconfig | 1 + drivers/media/i2c/imx214.c | 216 +++++++++++++++++++++++++++++++++++++----= ---- 2 files changed, 178 insertions(+), 39 deletions(-) diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig index e576b213084d232e90b7e556a7a855a3bb95544c..c8e24c42e0c4ea169f1b6cdc4f2= 631234a51c7d9 100644 --- a/drivers/media/i2c/Kconfig +++ b/drivers/media/i2c/Kconfig @@ -141,6 +141,7 @@ config VIDEO_IMX214 depends on GPIOLIB select REGMAP_I2C select V4L2_CCI_I2C + select VIDEO_CCS_PLL help This is a Video4Linux2 sensor driver for the Sony IMX214 camera. diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c index 3aca6ebb02d649c1b7f0b6a6049c1e3aa3d08951..9e9be47394ec768a5b34d44b06b= 5bbb0988da5a1 100644 --- a/drivers/media/i2c/imx214.c +++ b/drivers/media/i2c/imx214.c @@ -20,6 +20,8 @@ #include #include =20 +#include "ccs-pll.h" + /* Chip ID */ #define IMX214_REG_CHIP_ID CCI_REG16(0x0016) #define IMX214_CHIP_ID 0x0214 @@ -34,7 +36,6 @@ #define IMX214_DEFAULT_LINK_FREQ 600000000 /* Keep wrong link frequency for backward compatibility */ #define IMX214_DEFAULT_LINK_FREQ_LEGACY 480000000 -#define IMX214_DEFAULT_PIXEL_RATE ((IMX214_DEFAULT_LINK_FREQ * 8LL) / 10) #define IMX214_FPS 30 =20 /* V-TIMING internal */ @@ -84,6 +85,7 @@ #define IMX214_CSI_DATA_FORMAT_RAW10 0x0A0A #define IMX214_CSI_DATA_FORMAT_COMP6 0x0A06 #define IMX214_CSI_DATA_FORMAT_COMP8 0x0A08 +#define IMX214_BITS_PER_PIXEL_MASK 0xFF =20 #define IMX214_REG_CSI_LANE_MODE CCI_REG8(0x0114) #define IMX214_CSI_2_LANE_MODE 1 @@ -249,6 +251,10 @@ struct imx214 { struct clk *xclk; struct regmap *regmap; =20 + struct ccs_pll pll; + + struct v4l2_fwnode_endpoint bus_cfg; + struct v4l2_subdev sd; struct media_pad pad; =20 @@ -758,16 +764,22 @@ static int imx214_configure_pll(struct imx214 *imx214) { int ret =3D 0; =20 - cci_write(imx214->regmap, IMX214_REG_VTPXCK_DIV, 5, &ret); - cci_write(imx214->regmap, IMX214_REG_VTSYCK_DIV, 2, &ret); - cci_write(imx214->regmap, IMX214_REG_PREPLLCK_VT_DIV, 3, &ret); - cci_write(imx214->regmap, IMX214_REG_PLL_VT_MPY, 150, &ret); - cci_write(imx214->regmap, IMX214_REG_OPPXCK_DIV, 10, &ret); - cci_write(imx214->regmap, IMX214_REG_OPSYCK_DIV, 1, &ret); + cci_write(imx214->regmap, IMX214_REG_VTPXCK_DIV, + imx214->pll.vt_bk.pix_clk_div, &ret); + cci_write(imx214->regmap, IMX214_REG_VTSYCK_DIV, + imx214->pll.vt_bk.sys_clk_div, &ret); + cci_write(imx214->regmap, IMX214_REG_PREPLLCK_VT_DIV, + imx214->pll.vt_fr.pre_pll_clk_div, &ret); + cci_write(imx214->regmap, IMX214_REG_PLL_VT_MPY, + imx214->pll.vt_fr.pll_multiplier, &ret); + cci_write(imx214->regmap, IMX214_REG_OPPXCK_DIV, + imx214->pll.op_bk.pix_clk_div, &ret); + cci_write(imx214->regmap, IMX214_REG_OPSYCK_DIV, + imx214->pll.op_bk.sys_clk_div, &ret); cci_write(imx214->regmap, IMX214_REG_PLL_MULT_DRIV, IMX214_PLL_SINGLE, &ret); cci_write(imx214->regmap, IMX214_REG_EXCK_FREQ, - IMX214_EXCK_FREQ(IMX214_DEFAULT_CLK_FREQ / 1000000), &ret); + IMX214_EXCK_FREQ(imx214->pll.ext_clk_freq_hz / 1000000), &ret); =20 return ret; } @@ -872,9 +884,6 @@ static const struct v4l2_ctrl_ops imx214_ctrl_ops =3D { =20 static int imx214_ctrls_init(struct imx214 *imx214) { - static const s64 link_freq[] =3D { - IMX214_DEFAULT_LINK_FREQ - }; static const struct v4l2_area unit_size =3D { .width =3D 1120, .height =3D 1120, @@ -895,15 +904,14 @@ static int imx214_ctrls_init(struct imx214 *imx214) if (ret) return ret; =20 - imx214->pixel_rate =3D v4l2_ctrl_new_std(ctrl_hdlr, NULL, - V4L2_CID_PIXEL_RATE, 0, - IMX214_DEFAULT_PIXEL_RATE, 1, - IMX214_DEFAULT_PIXEL_RATE); + imx214->pixel_rate =3D + v4l2_ctrl_new_std(ctrl_hdlr, NULL, V4L2_CID_PIXEL_RATE, 1, + INT_MAX, 1, 1); =20 imx214->link_freq =3D v4l2_ctrl_new_int_menu(ctrl_hdlr, NULL, V4L2_CID_LINK_FREQ, - ARRAY_SIZE(link_freq) - 1, - 0, link_freq); + imx214->bus_cfg.nr_of_link_frequencies - 1, + 0, imx214->bus_cfg.link_frequencies); if (imx214->link_freq) imx214->link_freq->flags |=3D V4L2_CTRL_FLAG_READ_ONLY; =20 @@ -1006,6 +1014,7 @@ static int imx214_start_streaming(struct imx214 *imx2= 14) const struct v4l2_mbus_framefmt *fmt; struct v4l2_subdev_state *state; const struct imx214_mode *mode; + int bit_rate_mbps; int ret; =20 ret =3D cci_multi_reg_write(imx214->regmap, mode_table_common, @@ -1021,8 +1030,10 @@ static int imx214_start_streaming(struct imx214 *imx= 214) return ret; } =20 + bit_rate_mbps =3D (imx214->pll.pixel_rate_pixel_array / 1000000) + * imx214->pll.bits_per_pixel; ret =3D cci_write(imx214->regmap, IMX214_REG_REQ_LINK_BIT_RATE, - IMX214_LINK_BIT_RATE_MBPS(4800), NULL); + IMX214_LINK_BIT_RATE_MBPS(bit_rate_mbps), NULL); if (ret) { dev_err(imx214->dev, "failed to configure link bit rate\n"); return ret; @@ -1105,6 +1116,112 @@ static int imx214_s_stream(struct v4l2_subdev *subd= ev, int enable) return ret; } =20 +static int imx214_pll_calculate(struct imx214 *imx214, struct ccs_pll *pll, + unsigned int link_freq) +{ + struct ccs_pll_limits limits =3D { + .min_ext_clk_freq_hz =3D 6000000, + .max_ext_clk_freq_hz =3D 27000000, + + .vt_fr =3D { + .min_pre_pll_clk_div =3D 1, + .max_pre_pll_clk_div =3D 15, + /* min_pll_op_clk_freq_hz / max_pll_multiplier */ + .min_pll_ip_clk_freq_hz =3D 281667, + /* max_pll_op_clk_freq_hz / min_pll_multiplier */ + .max_pll_ip_clk_freq_hz =3D 100000000, + .min_pll_multiplier =3D 12, + .max_pll_multiplier =3D 1200, + .min_pll_op_clk_freq_hz =3D 338000000, + .max_pll_op_clk_freq_hz =3D 1200000000, + }, + .vt_bk =3D { + .min_sys_clk_div =3D 2, + .max_sys_clk_div =3D 4, + .min_pix_clk_div =3D 5, + .max_pix_clk_div =3D 10, + .min_pix_clk_freq_hz =3D 30000000, + .max_pix_clk_freq_hz =3D 120000000, + }, + .op_bk =3D { + .min_sys_clk_div =3D 1, + .max_sys_clk_div =3D 2, + .min_pix_clk_div =3D 6, + .max_pix_clk_div =3D 10, + .min_pix_clk_freq_hz =3D 30000000, + .max_pix_clk_freq_hz =3D 120000000, + }, + + .min_line_length_pck_bin =3D IMX214_PPL_DEFAULT, + .min_line_length_pck =3D IMX214_PPL_DEFAULT, + }; + unsigned int num_lanes =3D imx214->bus_cfg.bus.mipi_csi2.num_data_lanes; + int ret; + + /* + * There are no documented constraints on the sys clock frequency, for + * either branch. Recover them based on the PLL output clock frequency + * and sys_clk_div limits on one hand, and the pix clock frequency and + * the pix_clk_div limits on the other hand. + */ + limits.vt_bk.min_sys_clk_freq_hz =3D + max(limits.vt_fr.min_pll_op_clk_freq_hz / limits.vt_bk.max_sys_clk_div, + limits.vt_bk.min_pix_clk_freq_hz * limits.vt_bk.min_pix_clk_div); + limits.vt_bk.max_sys_clk_freq_hz =3D + min(limits.vt_fr.max_pll_op_clk_freq_hz / limits.vt_bk.min_sys_clk_div, + limits.vt_bk.max_pix_clk_freq_hz * limits.vt_bk.max_pix_clk_div); + + limits.op_bk.min_sys_clk_freq_hz =3D + max(limits.vt_fr.min_pll_op_clk_freq_hz / limits.op_bk.max_sys_clk_div, + limits.op_bk.min_pix_clk_freq_hz * limits.op_bk.min_pix_clk_div); + limits.op_bk.max_sys_clk_freq_hz =3D + min(limits.vt_fr.max_pll_op_clk_freq_hz / limits.op_bk.min_sys_clk_div, + limits.op_bk.max_pix_clk_freq_hz * limits.op_bk.max_pix_clk_div); + + memset(pll, 0, sizeof(*pll)); + + pll->bus_type =3D CCS_PLL_BUS_TYPE_CSI2_DPHY; + pll->op_lanes =3D num_lanes; + pll->vt_lanes =3D num_lanes; + pll->csi2.lanes =3D num_lanes; + + pll->binning_horizontal =3D 1; + pll->binning_vertical =3D 1; + pll->scale_m =3D 1; + pll->scale_n =3D 1; + pll->bits_per_pixel =3D + IMX214_CSI_DATA_FORMAT_RAW10 & IMX214_BITS_PER_PIXEL_MASK; + pll->flags =3D CCS_PLL_FLAG_LANE_SPEED_MODEL; + pll->link_freq =3D link_freq; + pll->ext_clk_freq_hz =3D clk_get_rate(imx214->xclk); + + ret =3D ccs_pll_calculate(imx214->dev, &limits, pll); + + return ret; +} + +static int imx214_pll_update(struct imx214 *imx214) +{ + u64 link_freq; + int ret; + + link_freq =3D imx214->bus_cfg.link_frequencies[imx214->link_freq->val]; + ret =3D imx214_pll_calculate(imx214, &imx214->pll, link_freq); + if (ret) { + dev_err(imx214->dev, "PLL calculations failed: %d\n", ret); + return ret; + } + + ret =3D v4l2_ctrl_s_ctrl_int64(imx214->pixel_rate, + imx214->pll.pixel_rate_pixel_array); + if (ret) { + dev_err(imx214->dev, "failed to set pixel rate\n"); + return ret; + } + + return 0; +} + static int imx214_get_frame_interval(struct v4l2_subdev *subdev, struct v4l2_subdev_state *sd_state, struct v4l2_subdev_frame_interval *fival) @@ -1211,12 +1328,10 @@ static int imx214_identify_module(struct imx214 *im= x214) return 0; } =20 -static int imx214_parse_fwnode(struct device *dev) +static int imx214_parse_fwnode(struct device *dev, struct imx214 *imx214) { + struct v4l2_fwnode_endpoint *bus_cfg =3D &imx214->bus_cfg; struct fwnode_handle *endpoint; - struct v4l2_fwnode_endpoint bus_cfg =3D { - .bus_type =3D V4L2_MBUS_CSI2_DPHY, - }; unsigned int i; int ret; =20 @@ -1224,42 +1339,52 @@ static int imx214_parse_fwnode(struct device *dev) if (!endpoint) return dev_err_probe(dev, -EINVAL, "endpoint node not found\n"); =20 - ret =3D v4l2_fwnode_endpoint_alloc_parse(endpoint, &bus_cfg); + bus_cfg->bus_type =3D V4L2_MBUS_CSI2_DPHY; + ret =3D v4l2_fwnode_endpoint_alloc_parse(endpoint, bus_cfg); + fwnode_handle_put(endpoint); if (ret) { dev_err_probe(dev, ret, "parsing endpoint node failed\n"); - goto done; + goto error; } =20 /* Check the number of MIPI CSI2 data lanes */ - if (bus_cfg.bus.mipi_csi2.num_data_lanes !=3D 4) { + if (bus_cfg->bus.mipi_csi2.num_data_lanes !=3D 4) { ret =3D dev_err_probe(dev, -EINVAL, "only 4 data lanes are currently supported\n"); - goto done; + goto error; } =20 - if (bus_cfg.nr_of_link_frequencies !=3D 1) + if (bus_cfg->nr_of_link_frequencies !=3D 1) dev_warn(dev, "Only one link-frequency supported, please review your DT.= Continuing anyway\n"); =20 - for (i =3D 0; i < bus_cfg.nr_of_link_frequencies; i++) { - if (bus_cfg.link_frequencies[i] =3D=3D IMX214_DEFAULT_LINK_FREQ) + for (i =3D 0; i < bus_cfg->nr_of_link_frequencies; i++) { + u64 freq =3D bus_cfg->link_frequencies[i]; + struct ccs_pll pll; + + if (!imx214_pll_calculate(imx214, &pll, freq)) break; - if (bus_cfg.link_frequencies[i] =3D=3D - IMX214_DEFAULT_LINK_FREQ_LEGACY) { + if (freq =3D=3D IMX214_DEFAULT_LINK_FREQ_LEGACY) { dev_warn(dev, "link-frequencies %d not supported, please review your DT. Continuing= anyway\n", IMX214_DEFAULT_LINK_FREQ); + freq =3D IMX214_DEFAULT_LINK_FREQ; + if (imx214_pll_calculate(imx214, &pll, freq)) + continue; + bus_cfg->link_frequencies[i] =3D freq; break; } } =20 - if (i =3D=3D bus_cfg.nr_of_link_frequencies) + if (i =3D=3D bus_cfg->nr_of_link_frequencies) ret =3D dev_err_probe(dev, -EINVAL, - "link-frequencies %d not supported, please review your DT\n", - IMX214_DEFAULT_LINK_FREQ); + "link-frequencies %lld not supported, please review your DT\n", + bus_cfg->nr_of_link_frequencies ? + bus_cfg->link_frequencies[0] : 0); =20 -done: - v4l2_fwnode_endpoint_free(&bus_cfg); - fwnode_handle_put(endpoint); + return 0; + +error: + v4l2_fwnode_endpoint_free(&imx214->bus_cfg); return ret; } =20 @@ -1299,7 +1424,7 @@ static int imx214_probe(struct i2c_client *client) return dev_err_probe(dev, PTR_ERR(imx214->regmap), "failed to initialize CCI\n"); =20 - ret =3D imx214_parse_fwnode(dev); + ret =3D imx214_parse_fwnode(dev, imx214); if (ret) return ret; =20 @@ -1310,7 +1435,9 @@ static int imx214_probe(struct i2c_client *client) * Enable power initially, to avoid warnings * from clk_disable on power_off */ - imx214_power_on(imx214->dev); + ret =3D imx214_power_on(imx214->dev); + if (ret < 0) + goto error_fwnode; =20 ret =3D imx214_identify_module(imx214); if (ret) @@ -1341,6 +1468,12 @@ static int imx214_probe(struct i2c_client *client) pm_runtime_set_active(imx214->dev); pm_runtime_enable(imx214->dev); =20 + ret =3D imx214_pll_update(imx214); + if (ret < 0) { + dev_err_probe(dev, ret, "failed to update PLL\n"); + goto error_subdev_cleanup; + } + ret =3D v4l2_async_register_subdev_sensor(&imx214->sd); if (ret < 0) { dev_err_probe(dev, ret, @@ -1366,6 +1499,9 @@ static int imx214_probe(struct i2c_client *client) error_power_off: imx214_power_off(imx214->dev); =20 +error_fwnode: + v4l2_fwnode_endpoint_free(&imx214->bus_cfg); + return ret; } =20 @@ -1378,6 +1514,8 @@ static void imx214_remove(struct i2c_client *client) v4l2_subdev_cleanup(sd); media_entity_cleanup(&imx214->sd.entity); v4l2_ctrl_handler_free(&imx214->ctrls); + v4l2_fwnode_endpoint_free(&imx214->bus_cfg); + pm_runtime_disable(&client->dev); if (!pm_runtime_status_suspended(&client->dev)) { imx214_power_off(imx214->dev); --=20 2.49.0 From nobody Tue Dec 16 07:35:36 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A15325D527; Mon, 5 May 2025 21:06:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746479181; cv=none; b=PNxWmWvbKdfiiYtr7MxwxvB6OqIG6eI0oOeZc6K2hI4NWm6e9T0xL3/j3W7/Qz0sWuDZdtEGjZHZQdctF+NB98c3szBfe0GccWm87AQdwxaO40wLSHHWMSLWZK36ksHe7X3tkiLgKCizKQPVxnDFRQvEGIAI/5acKtQLsKmHoLo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746479181; c=relaxed/simple; bh=bqiG3EisNRx2Bf+d4Wnt3HiRFsYTE9AsHxoBgJ7to2I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IOWAMC/V8VhuLeKhRgctRBDKQBJjzJqVc8lTAY2hEH+C1UaM9KjsT5HFqmF/WhRKRF+dcaf3lnZzWF79wX62Tat22x5+/nY0hSlIkEQKGrUqrIkwY75qkxdGxSUcAQHG5PNycxI/A0giBkkn0R5fLCrf8/UFpRIFeyoc6Wp9SEg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sHwJ1GVL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sHwJ1GVL" Received: by smtp.kernel.org (Postfix) with ESMTPS id 1DB7BC4CEF4; Mon, 5 May 2025 21:06:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746479181; bh=bqiG3EisNRx2Bf+d4Wnt3HiRFsYTE9AsHxoBgJ7to2I=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=sHwJ1GVLRypcfNkR/X7+8/XerWV73HMLMIAMNnQEqzoVj/Cb5a2nIr65I86Uytvpv sxwYJHBn4m2QKUu0wp5y5stR11DbAYDDBv+ym8xkHYda0/uDwMeY2t9JIhalOZXNM1 QYla+DLnq0iwlYPm57s9ChjSpXH5P4K7pWaWy2nkRfUMIv6u0XrhqFkiTd1S+pjoM4 CCAzEihX6vwVZhCgq3QQw89swM/Ivt1PwTzQGuC4hlA6ijdZntAFzM4DSwcaI+0vlf 6QYI7a6+pjxa4lOaKZORdsW2cY+ZBKyxKvKvPhWKKkRSukjBBApnHYMZimkWVThpUl K434nDedyGbEA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14F24C3ABC1; Mon, 5 May 2025 21:06:21 +0000 (UTC) From: =?utf-8?q?Andr=C3=A9_Apitzsch_via_B4_Relay?= Date: Mon, 05 May 2025 23:05:56 +0200 Subject: [PATCH v2 4/4] media: i2c: imx214: Remove hard-coded external clock frequency Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250505-imx214_ccs_pll-v2-4-f50452061ff1@apitzsch.eu> References: <20250505-imx214_ccs_pll-v2-0-f50452061ff1@apitzsch.eu> In-Reply-To: <20250505-imx214_ccs_pll-v2-0-f50452061ff1@apitzsch.eu> To: Ricardo Ribalda , Sakari Ailus , Mauro Carvalho Chehab Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Apitzsch?= X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1746479179; l=1194; i=git@apitzsch.eu; s=20240325; h=from:subject:message-id; bh=wQtNz8rcdaU2sbMuHsPX3jQboaaqyQe4OYWiqe9auLc=; b=Z8zfbIjKoHgzrhBmnrIIHhsuegaa7I80/bXxyb0n0ObfxuMRZTdiFP2uEi3M4eSfelKLUI7gY 1F/CUK3FpJ3BZRTTFlfVo8awUN37QqAwCiEbEUZbuuI0aIjveSQuiYk X-Developer-Key: i=git@apitzsch.eu; a=ed25519; pk=wxovcZRfvNYBMcTw4QFFtNEP4qv39gnBfnfyImXZxiU= X-Endpoint-Received: by B4 Relay for git@apitzsch.eu/20240325 with auth_id=142 X-Original-From: =?utf-8?q?Andr=C3=A9_Apitzsch?= Reply-To: git@apitzsch.eu From: Andr=C3=A9 Apitzsch Instead rely on the rate set on the clock (using assigned-clock-rates etc.) Signed-off-by: Andr=C3=A9 Apitzsch --- drivers/media/i2c/imx214.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c index 9e9be47394ec768a5b34d44b06b5bbb0988da5a1..c12996e294dccebb18c608254f1= e0d14dc064423 100644 --- a/drivers/media/i2c/imx214.c +++ b/drivers/media/i2c/imx214.c @@ -32,7 +32,6 @@ =20 #define IMX214_REG_FAST_STANDBY_CTRL CCI_REG8(0x0106) =20 -#define IMX214_DEFAULT_CLK_FREQ 24000000 #define IMX214_DEFAULT_LINK_FREQ 600000000 /* Keep wrong link frequency for backward compatibility */ #define IMX214_DEFAULT_LINK_FREQ_LEGACY 480000000 @@ -1405,11 +1404,6 @@ static int imx214_probe(struct i2c_client *client) return dev_err_probe(dev, PTR_ERR(imx214->xclk), "failed to get xclk\n"); =20 - ret =3D clk_set_rate(imx214->xclk, IMX214_DEFAULT_CLK_FREQ); - if (ret) - return dev_err_probe(dev, ret, - "failed to set xclk frequency\n"); - ret =3D imx214_get_regulators(dev, imx214); if (ret < 0) return dev_err_probe(dev, ret, "failed to get regulators\n"); --=20 2.49.0