From nobody Fri Dec 19 16:07:40 2025 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91E3718A6DF; Sun, 4 May 2025 09:00:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349216; cv=fail; b=a4nfg9uemqeHwHbFO9KlKIzR+dnQBKM0zmnLcN6zJ2aIBiObLu8QC5TpRNSqDjQwBFBNDlBqR/4731G4bQtzKtaMkbljQWpWjTCgNejiXTn2b5PHUkfjmxaaGxoClL4tS/xpIhDsNmGXTHJUlXUC38MWichOiEdDf/YvdvV1LK4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349216; c=relaxed/simple; bh=s9umRKRFfgTIQlD4/bOES5+0zQw8uME5kwsNul37vHI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=bmzbrGIxZlbFKVw+Zxi3EnzyqIXDqdPThdQhXeiVLuql1HJYpJnGa4to+bODRSC0oz2sKb4MRvOytAwnQWlFD9FD6Ng84+rPyT7lJgJIR/BNtXWGOfvxz2dymnB8ZgaurL6IKl9h6Y8jK5WHdD7b2EsAodVAp3NjSZZrFYrX3mk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=hlkEYTqL; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=Ikrpgtlo; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="hlkEYTqL"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="Ikrpgtlo" Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5448l9FE004894; Sun, 4 May 2025 09:00:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=rd6C5ey/l+sEGTPpaZvEmNeGhYfJukcUhgGdg2fVxfg=; b= hlkEYTqLf271AWIZ7Y0Yn7roQOOyeJK1/7YTRxDXBZO9iqJWxpuTB1jlDHO54B8c tQaKJBbxO37nS9sX72kOuU5TbaVipCv0+LSvv++nk2gKAAT4L6h1vp+HyegoH+g4 WhXY6iT1jlada8lf1XCwOHl2dm3yXINt/RzQdrjXmiA/zl914toyGHd7mjmMEmnV RCbQaJtR74nzAHUPu4SPrAHLwZqlgnP5FYyLA1LYjWwEhKj9SLXMWBUcYwf7L0Jr nrWePKHRU5rwopqlJNm73QMXuxXZ2zABPTCLpTrQ/gA6L0aNLEW5RJb+AwtO7H+0 R0mCZ9Lzqjm9gUhtqmP7/w== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 46e51bg07s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:00 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5443UDQo036077; Sun, 4 May 2025 08:59:59 GMT Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazlp17012052.outbound.protection.outlook.com [40.93.20.52]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 46d9k7ghc9-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 08:59:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Odi6SQBfZTD7/nQrWXi5QbvixvH61Wggb1LYTaXYhf0LtRYPr2oxlQMMNEd/CnioHg0UnIDTjztUbZbJbxFG1GkrUlUM1YJ7NX9HxU/OjAte+CLWqOyabEDwHrT7sqR8i/Hcr6qEj1oPZ4dBTh8fi+Hqc86jQP4KxyCaLnUXt/Bn8Flm4aGeeLArSvn0LYMGyfHe4t3FIU0f+JderjHRILurjAy+BMjx/TEnoVeL8x8hBbQ2AYvmSJhWAYXG/Fz1kgB9iHUW+urLeIY21NRlRDg4F9JZQ00SwCPnk95PytGtRnL8ifPVD2sSSP5QbamRGcc0t2oirvruNC4Vsuo+NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rd6C5ey/l+sEGTPpaZvEmNeGhYfJukcUhgGdg2fVxfg=; b=RAoAMIX7oQNqoRNESqoJvmSE4b+emKssiUrIw9LygIr3+dOcMujlc/JJT3kc45zzNxMZiMGiXZHoulZ5L7YGEr8PAsFelY3Uv29DFrRRHQwE1hObl9jy9w3SMIXTqR60zo4OqqmFG3sY6hu1TakpOwwNdrMcpTwHaY6xj7e2ZU2tNBSIdz4YYD/uaRIXv/EBZqCxhajUn0g0Pj0P94DozUTf2hL701HS7BbpnRTt8crH4dcO+YgWj8ngUseeV1HawAsvaQFR0QoIKyIGJab9k75ODuulKQsIggiHCEPUppEragrYjYOu0grO+D1kg6NfJ7ZK+c7upTM5ccYZbdEwlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rd6C5ey/l+sEGTPpaZvEmNeGhYfJukcUhgGdg2fVxfg=; b=Ikrpgtloy3hn9lV+0b9Y6zc6VuYERZF0QROj70i9Q9+2oORHlJQxECmtaihxeB6v+6IR9fjSfyh/97rbJPsqJMQwso137HURJICCEhlJOKHvXeQOBEDGw5FSSwJozDKjLuwl4+XH7ITPL5jQzgmflZaUWmhtE0YVM3PgK77/t8w= Received: from DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) by DS7PR10MB7178.namprd10.prod.outlook.com (2603:10b6:8:e1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.23; Sun, 4 May 2025 08:59:57 +0000 Received: from DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088]) by DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088%7]) with mapi id 15.20.8699.022; Sun, 4 May 2025 08:59:57 +0000 From: John Garry To: brauner@kernel.org, djwong@kernel.org, hch@lst.de, viro@zeniv.linux.org.uk, jack@suse.cz, cem@kernel.org Cc: linux-fsdevel@vger.kernel.org, dchinner@redhat.com, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, ojaswin@linux.ibm.com, ritesh.list@gmail.com, martin.petersen@oracle.com, linux-ext4@vger.kernel.org, linux-block@vger.kernel.org, catherine.hoang@oracle.com, linux-api@vger.kernel.org, John Garry Subject: [PATCH v11 01/16] fs: add atomic write unit max opt to statx Date: Sun, 4 May 2025 08:59:08 +0000 Message-Id: <20250504085923.1895402-2-john.g.garry@oracle.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20250504085923.1895402-1-john.g.garry@oracle.com> References: <20250504085923.1895402-1-john.g.garry@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL1PR13CA0276.namprd13.prod.outlook.com (2603:10b6:208:2bc::11) To DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB4313:EE_|DS7PR10MB7178:EE_ X-MS-Office365-Filtering-Correlation-Id: ec20a1b1-e1c5-42e0-dc34-08dd8aea0b27 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?d8Tqt2ePendC80wwlpXMwzaSb7f+JB0BfLSaqebeJzmpjC0r8Jq6Nkf4O3FN?= =?us-ascii?Q?SAh3ChADXpyJXUpzmSW3QjNtQs1mn1o4zMf/QJLIakFuQn6zIlc6EQqxIzfU?= =?us-ascii?Q?4NwI1tWvSt4Irel/mooI6mU+LqTIzpGTDr2G4npyW8syyr1Jk7HYYec158wY?= =?us-ascii?Q?vyCiYMnDLXOmZayL91eEuH1E3XxGSaGKQM//1jaRvURsFJ8oN03Ezj8+cJ4e?= =?us-ascii?Q?m6y5nbKvwMKstFvAbYGyHR2nBGvIhAuMuiHNcFIeMjI8PeFRtqX14+divz0w?= =?us-ascii?Q?XiRw1UrEtsWUCQm9aQcjBgtEJZCLxHFWGlM8MfkFbCUix3/Ge0fEOmrRRS3y?= =?us-ascii?Q?xtrIC49Oectqoe/N1aUpB93bElHWMAk1qcwKSzJWl3i3BGTtsu2lxYuSgqmB?= =?us-ascii?Q?SIU1Hd8cGV61lCMo48Q0xk1AW7cmT9Z0HsQEFBu5EbVfSDqwkLLc6jZjs6cb?= =?us-ascii?Q?wcBYXimIOjcdwhVBjznMmGRvcaWq5CCDLuwWJdEoLd3E54WqumYjczYqslNG?= =?us-ascii?Q?KA1+o+VsXoeSz9E60G6aSc64ZBbfiVvdkraT6c/LryWn+rqTtsPvlA/3z0ia?= =?us-ascii?Q?aQgtt7ChuXGCOll7SRnlWlNmkkOZ1I8PyugtezdjQd9ZGLWsCS5yf2rZLQNA?= =?us-ascii?Q?U+hZIDh0/rYb7mS3GYhYMjyU0tnYGfpTMnoWu4p4rs3F7T2dhLsCfSWas/OB?= =?us-ascii?Q?H4gXjfDwH9Kc7q3Jx0l+I+mnP7vu4fcD3xg6vw57tsUPfK5jGGWqAC7m4GKp?= =?us-ascii?Q?lTVn1Bq7Ub7gSOqpj3X1E5q056XA1EfycD6v3zVzaWLC3mOwIq7GR8Ic70GQ?= =?us-ascii?Q?NdRRCiMBPplU+0YV9u82vISG/tg42SBOT3CiPkEz7GqhekG7QZMuOyfjJ4s9?= =?us-ascii?Q?5kpDeDR0lqCD5kJg/77pEsHCWJGAFK2umhj5fbwjab2tMIi5gvisfQWbGdJF?= =?us-ascii?Q?EQgPsSixzfR+RwT90O4v71erkI0E9tYb7chSEBfqP/9uL+smFzPP55udTFVo?= =?us-ascii?Q?Wdb3ZnLvEVc4fN3Kl3aBVfBhugD97UTKJjF/vv+mPI6jTH/LmfOppefG9PRr?= =?us-ascii?Q?8uO05dz5+5mY8r3/E++PLq0NDdeNK8+UruG0IjUtR80g+d2ioBLr4H7f0aCN?= =?us-ascii?Q?WVzNnwcecBfxhfhEoL9EOrNgp+LJDQm0O2nf+PQiiZQYN0oaiQN7b3PTir5U?= =?us-ascii?Q?dwxL9eaQS5p0FzSnwOMpMiK4raZjZXSAeSzRxgspulB0Sq4IBrnBAMvaYE3D?= =?us-ascii?Q?p8kFSzlEBCIZ4iQ9bESOJ03dazxNWYjyZnpd4D3q7eIAViFAsoIYA8OssnQp?= =?us-ascii?Q?4MvS9EujdrOuToQOeIj7Ra/Euxc1SQKsI0z/HiXwvQxFZlTP1OcC1UMumKyX?= =?us-ascii?Q?DR15FrtnE+NWKAZaaLPhAjqjpjKK+8CHIEKpGQpiYdBpNvVdAvBCKLCzs1Gl?= =?us-ascii?Q?nybcFxpKl7o=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB4313.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jFTRw/CcfmIlH8eqYcyMamkq36HJyJ6V+k7nGeLvKXLi4YG+wKCdJzV7U0Mj?= =?us-ascii?Q?LD8/EiiM04/7zRvyEL84ml3g6pyX/RxdVprKSKtW8sTynbiOr/oFBGPOz+Ie?= =?us-ascii?Q?tsN8BPgGW7zea8wkNYvEmVFw1waY07a041PqL9KeeAf+u7/fabtovXkarwDi?= =?us-ascii?Q?zk+HHbO3eJ8efVceHsYo9Qb1nu1xu0gFn+GTUYX0sizeGv1UWxfmIuCEwldX?= =?us-ascii?Q?aZcFf2In4ek3F52Z38laSsWQn+99clEQ6eDOh85lQT4+/UWOFZKxkHXUvwwQ?= =?us-ascii?Q?Bbm9MLgCQmzG+J+RgB/g0887/wAlNHBj7UAsL3DkLtFXak7x0zj86rSY/qaE?= =?us-ascii?Q?zrA7WJPArH7KrMC9VrC4MKzzKesMul7ldLXOE7qZuZPcklqCzrr65KlRUJMt?= =?us-ascii?Q?vSWWWKjkHU/4mSWZ2pkP2/KWequjYEhYlk+00BvJ5fvqm0wyXERVFDp5+QGi?= =?us-ascii?Q?Wdb+XuKQBfLZMZZrJldlUBecZ4chCB/h208tWfkKHWtROSU/dJ3ORmPW6lk/?= =?us-ascii?Q?rmi7A6LMKMwmqaeViA56FOvec9uLqTgKdOYV5FjopvBMApxpBMp4Q1+asKzl?= =?us-ascii?Q?jqfjukhWtv9rnPiMrVEvAm5xM5H0nLtYGD/kvhNgcd+F2oa+Lh19pSUCSTnu?= =?us-ascii?Q?C7mYctf+hL0G+jUDv/fEjlrxsh1eWRY8rUtSaW0ECyGFyCiy+TRf90JGjx/I?= =?us-ascii?Q?vi7Zvr1NmuiotZQ52AKdPSbX0fRh5u4bH7HxnoWiqpS1ZXE+Q7SagaVhP2I1?= =?us-ascii?Q?C0bL/DCoD/KsA2r4zsJFMdaDl5zlPo3pSn29odtBqfhmgGgoB9bmZsURi3n6?= =?us-ascii?Q?6hTau0FmxUh6SHSlEWNP656NF+MJyw4EvAr7CcMw5DbZe3z1/9b8pNfPy0PE?= =?us-ascii?Q?Px7NOdDN/2trdrZbb51VE1BG6o1GJJD3blgDl66ntoSuPKab5R5jWEYf6pvk?= =?us-ascii?Q?6H4KW3d0tAEg9TnJ5oTSu4wLyDII+DE9OLOi0jOqM7y0+mXyejW3XWiBOYbo?= =?us-ascii?Q?AMk/Uf9uLxJ6AQZHEJO+RdOwpkbPH4G5z89pI3uuZoK8s6OqKxGGNUu1z2CM?= =?us-ascii?Q?3yZ1bpRpTmFYZZP6QKXu9k39AksA8J9t9kFO/92sgI/P4h34VLTaynNwU26z?= =?us-ascii?Q?1ZbJZDGJWqFzlORuSdENVKup4nMoAE4q6KIb/YmdIOGNGhgOLfE/Bh+l9JDR?= =?us-ascii?Q?Jik0CR44XnR0N810Hl/tw6kcu9QW3mHM2nWwR8aPfr5ooYqP0Hp7GLmZcvsN?= =?us-ascii?Q?S3KMq04TY3X+5L5Fw7HKMDu/btvG2a56C49EsHhHeoYKkiRtyYF6inDDhNHN?= =?us-ascii?Q?uQ1M8jq3nCpmD/t7pLOuTnV0H5HDY6/x2OOImtKImaxjHwaHyrRssOSm8oY1?= =?us-ascii?Q?1kA9NLgOrkFyn5jiqMfrxFhTerkivFjxgnIdAMgcSeO4S3vQp9clYBTYcoiu?= =?us-ascii?Q?W34d4X3MTk2HJe+xaz0rGT3f1LZ9TjbpTCJvrPtf/LR1VCOM0Px7mlGjTWyM?= =?us-ascii?Q?3dwgIg8jHZ1sNwFJuuPiBJMRNXX+lQWVfqxN6zl2Xi0zYXqh1JjpMLISjwGk?= =?us-ascii?Q?P5PvkvvDLclNnKg8p7U5R94fjUNy1FkVUpilpxkEWZZKjckwmGNfytPGhU+c?= =?us-ascii?Q?3Q=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: qi/9JzKwQF9YPlstp1DbtJjX9xOGjh/MDktcDW177xbF8KDNwCBijILn+VaprdHOHQqoexXhMPP1NjKiHHX1JAb2HEAh/7Ws5r8vWQ6Ht2lFLPRWrom9x7nsvo+ROhLsjOZOjniaO1u2Kn4NAIIrEItsF34/UMI085BkR1xUSPIZveFy/VljdUcGUUrCp7yAxts5UyUxR+qNHUhFKKiOxyfBcbd4QjtXy/voX+ywWMBImx3EqYDKzR/d0rVM3bDoMB325oYL/n+W16nKi/PmSZsdBjStiYx5UsPsvRzng9JVXI7esJWIk4qQHCkFvBaIXvRS2EyHm8UC6PAj8O1S6+To0oTFtB5ccb9BTL0ugBGHP2jsOB+t2+ssWk03ZIJL53yGKjoljKTmtxlxoiBHG5N1RyKj4bGYKwvJkU8s5AKCvcrWGjhFBN2yFkGzkOiP5fRhIDAWMnHLVYH2QiF7jHALwqOhaYsEGJNRDz1Ep39u8CpPlj7kbdoOzdBmEfOqMRLrpkO/dtm4V0NWxrbH4mfLCFjZdg/bXNDgulSJYIfFDRj+QmY0lW/o/cdPcuFxd3b//LYbLCAHeapDUt60cBVBtHBqQfnMAXiuNjC1qEc= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: ec20a1b1-e1c5-42e0-dc34-08dd8aea0b27 X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2025 08:59:57.1896 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3GYih//ti8HbaFRxulGx/WnSyT7fz0fJ8oub/ATKceAvhraDuVzLn/Tk/pNpCST/fUuUpGSGg00cTamanLsktw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB7178 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-04_03,2025-04-30_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 adultscore=0 phishscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2504070000 definitions=main-2505040081 X-Authority-Analysis: v=2.4 cv=C8LpyRP+ c=1 sm=1 tr=0 ts=68172c90 cx=c_pps a=OOZaFjgC48PWsiFpTAqLcw==:117 a=OOZaFjgC48PWsiFpTAqLcw==:17 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=dt9VzEwgFbYA:10 a=GoEa3M9JfhUA:10 a=VwQbUJbxAAAA:8 a=yPCof4ZbAAAA:8 a=ihQL3A0VzzIQ68P4lnIA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTA0MDA4MSBTYWx0ZWRfXxMq2Xah69NC1 VyHY46C6ZtyZydpiNxuT9snx0YCBzJFmzf13qUctf96gVMRrpxtmxY4EuiXV7MKB2Y1y7oWEnow XA1MaBaqWn3qJCSJ/aHaFn+uLPJcgXTzjxASAnG7hBtzHq/ITNJntJJkjL9dsohw8NU/ybdEmIn YiDBNfT/GTWZHDpbBpeQsHSC4SRLy5DfXurDgW5IXzFYnTUkmnFkZSN9fB/CUOr2kEbUiTIelNk z/f7MGPshBh4lU3GBVQC1ynMuO21s7hgewfKTlZTaQ8hlrtBOZK9xKQ/4qeZl+8Sw4jvn8RfLGL wh+6DGTv1cDE1pyqhgbPTfdcNuxL9yqBtsNZaHwkj+ObvhdVy62e2xEfu7Q0O3jEoEhYshmPoQu GuQHMxlxgcuLUG/E1+hFAlMVz7pKZNAwoAGWcqbY6OUIU8Rh6RxSNx9AmmuRVvQawVYv6PHv X-Proofpoint-ORIG-GUID: _AiMWzkN1yMMLCYjddBPvlAm4RXKLso0 X-Proofpoint-GUID: _AiMWzkN1yMMLCYjddBPvlAm4RXKLso0 Content-Type: text/plain; charset="utf-8" XFS will be able to support large atomic writes (atomic write > 1x block) in future. This will be achieved by using different operating methods, depending on the size of the write. Specifically a new method of operation based in FS atomic extent remapping will be supported in addition to the current HW offload-based method. The FS method will generally be appreciably slower performing than the HW-offload method. However the FS method will be typically able to contribute to achieving a larger atomic write unit max limit. XFS will support a hybrid mode, where HW offload method will be used when possible, i.e. HW offload is used when the length of the write is supported, and for other times FS-based atomic writes will be used. As such, there is an atomic write length at which the user may experience appreciably slower performance. Advertise this limit in a new statx field, stx_atomic_write_unit_max_opt. When zero, it means that there is no such performance boundary. Masks STATX{_ATTR}_WRITE_ATOMIC can be used to get this new field. This is ok for older kernels which don't support this new field, as they would report 0 in this field (from zeroing in cp_statx()) already. Furthermore those older kernels don't support large atomic writes - apart from block fops, but there would be consistent performance there for atomic writes in range [unit min, unit max]. Reviewed-by: Darrick J. Wong Reviewed-by: Christoph Hellwig Signed-off-by: Darrick J. Wong Acked-by: Darrick J. Wong Signed-off-by: John Garry --- block/bdev.c | 3 ++- fs/ext4/inode.c | 2 +- fs/stat.c | 6 +++++- fs/xfs/xfs_iops.c | 2 +- include/linux/fs.h | 3 ++- include/linux/stat.h | 1 + include/uapi/linux/stat.h | 8 ++++++-- 7 files changed, 18 insertions(+), 7 deletions(-) diff --git a/block/bdev.c b/block/bdev.c index 520515e4e64e..9f321fb94bac 100644 --- a/block/bdev.c +++ b/block/bdev.c @@ -1336,7 +1336,8 @@ void bdev_statx(struct path *path, struct kstat *stat, =20 generic_fill_statx_atomic_writes(stat, queue_atomic_write_unit_min_bytes(bd_queue), - queue_atomic_write_unit_max_bytes(bd_queue)); + queue_atomic_write_unit_max_bytes(bd_queue), + 0); } =20 stat->blksize =3D bdev_io_min(bdev); diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 94c7d2d828a6..cdf01e60fa6d 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -5692,7 +5692,7 @@ int ext4_getattr(struct mnt_idmap *idmap, const struc= t path *path, awu_max =3D sbi->s_awu_max; } =20 - generic_fill_statx_atomic_writes(stat, awu_min, awu_max); + generic_fill_statx_atomic_writes(stat, awu_min, awu_max, 0); } =20 flags =3D ei->i_flags & EXT4_FL_USER_VISIBLE; diff --git a/fs/stat.c b/fs/stat.c index f13308bfdc98..c41855f62d22 100644 --- a/fs/stat.c +++ b/fs/stat.c @@ -136,13 +136,15 @@ EXPORT_SYMBOL(generic_fill_statx_attr); * @stat: Where to fill in the attribute flags * @unit_min: Minimum supported atomic write length in bytes * @unit_max: Maximum supported atomic write length in bytes + * @unit_max_opt: Optimised maximum supported atomic write length in bytes * * Fill in the STATX{_ATTR}_WRITE_ATOMIC flags in the kstat structure from * atomic write unit_min and unit_max values. */ void generic_fill_statx_atomic_writes(struct kstat *stat, unsigned int unit_min, - unsigned int unit_max) + unsigned int unit_max, + unsigned int unit_max_opt) { /* Confirm that the request type is known */ stat->result_mask |=3D STATX_WRITE_ATOMIC; @@ -153,6 +155,7 @@ void generic_fill_statx_atomic_writes(struct kstat *sta= t, if (unit_min) { stat->atomic_write_unit_min =3D unit_min; stat->atomic_write_unit_max =3D unit_max; + stat->atomic_write_unit_max_opt =3D unit_max_opt; /* Initially only allow 1x segment */ stat->atomic_write_segments_max =3D 1; =20 @@ -732,6 +735,7 @@ cp_statx(const struct kstat *stat, struct statx __user = *buffer) tmp.stx_atomic_write_unit_min =3D stat->atomic_write_unit_min; tmp.stx_atomic_write_unit_max =3D stat->atomic_write_unit_max; tmp.stx_atomic_write_segments_max =3D stat->atomic_write_segments_max; + tmp.stx_atomic_write_unit_max_opt =3D stat->atomic_write_unit_max_opt; =20 return copy_to_user(buffer, &tmp, sizeof(tmp)) ? -EFAULT : 0; } diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c index 756bd3ca8e00..f0e5d83195df 100644 --- a/fs/xfs/xfs_iops.c +++ b/fs/xfs/xfs_iops.c @@ -610,7 +610,7 @@ xfs_report_atomic_write( =20 if (xfs_inode_can_atomicwrite(ip)) unit_min =3D unit_max =3D ip->i_mount->m_sb.sb_blocksize; - generic_fill_statx_atomic_writes(stat, unit_min, unit_max); + generic_fill_statx_atomic_writes(stat, unit_min, unit_max, 0); } =20 STATIC int diff --git a/include/linux/fs.h b/include/linux/fs.h index 016b0fe1536e..7b19d8f99aff 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -3475,7 +3475,8 @@ void generic_fillattr(struct mnt_idmap *, u32, struct= inode *, struct kstat *); void generic_fill_statx_attr(struct inode *inode, struct kstat *stat); void generic_fill_statx_atomic_writes(struct kstat *stat, unsigned int unit_min, - unsigned int unit_max); + unsigned int unit_max, + unsigned int unit_max_opt); extern int vfs_getattr_nosec(const struct path *, struct kstat *, u32, uns= igned int); extern int vfs_getattr(const struct path *, struct kstat *, u32, unsigned = int); void __inode_add_bytes(struct inode *inode, loff_t bytes); diff --git a/include/linux/stat.h b/include/linux/stat.h index be7496a6a0dd..e3d00e7bb26d 100644 --- a/include/linux/stat.h +++ b/include/linux/stat.h @@ -57,6 +57,7 @@ struct kstat { u32 dio_read_offset_align; u32 atomic_write_unit_min; u32 atomic_write_unit_max; + u32 atomic_write_unit_max_opt; u32 atomic_write_segments_max; }; =20 diff --git a/include/uapi/linux/stat.h b/include/uapi/linux/stat.h index f78ee3670dd5..1686861aae20 100644 --- a/include/uapi/linux/stat.h +++ b/include/uapi/linux/stat.h @@ -182,8 +182,12 @@ struct statx { /* File offset alignment for direct I/O reads */ __u32 stx_dio_read_offset_align; =20 - /* 0xb8 */ - __u64 __spare3[9]; /* Spare space for future expansion */ + /* Optimised max atomic write unit in bytes */ + __u32 stx_atomic_write_unit_max_opt; + __u32 __spare2[1]; + + /* 0xc0 */ + __u64 __spare3[8]; /* Spare space for future expansion */ =20 /* 0x100 */ }; --=20 2.31.1 From nobody Fri Dec 19 16:07:40 2025 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5A94128819; Sun, 4 May 2025 09:00:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349215; cv=fail; b=dTB9MLeNIET/Lu6z/78iI+FekEa6tCoyAEhHpfLNTRpDpBxlxkXO1H90lUHNXde3vrqoskXi+dBZ0HGn26cSZbWcLnuXNxpMEsiRcY+Rf50qbhb/kaN2ZgIPVEc+3KdN1pHkaUZbT0TXNtxjtBnZXzUvjQQ4lGO1nfdMw9i4Zo0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349215; c=relaxed/simple; bh=wZyGZkcWUDkwl2fYixZtEJ1EyvHtw6/GeKeqR+6rOaA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=ANE1QA8vQLMv1lICqhRNqtBoIMwz89AKSfdSY41oT233fAyW+nb9lGN/dyauMya2GmPzvQqUOIABU0hbCNsI7T/oHpVqsDxNMEP/2sp7p0M9upuy6TguiaLbj2o7Ex7HNGDu+1zCRh5g+DKNmojX3hTe+qZymj7Swax2n4v3bgA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=OGJ3irG3; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=kitaBR6h; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="OGJ3irG3"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="kitaBR6h" Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5447b0rU008341; Sun, 4 May 2025 09:00:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=FGY7X/rVUPMi6d0cWq4YsnWnzlpHNtQ+nFV6a0BaurU=; b= OGJ3irG3YUPkRX2/BnJlP+LIi3oIv7cxAhd5K4pGqdh12U1vMFb42fqhN/YMTpK0 NKP0wvXVQBb8VwZ/JwaBf1vW/zA66VdQ26k4PL0XkQhATFY/w5EY4xkjINuxX539 aCMtVgi5tUthfA7C7E/MPVK+Z1jMDzqvFy9eOdcN+vlhFuOI1/f/inSIAmGRJA04 cJNRHa9E7eBrhm1to+ep4MoWd2cyAAa1GPO1jex8O1J+87L+7DFq59maY+l30EI6 r/IG3zigsruthhJlY9cvzj3bv61j+psFKa74z4g1LTuNiJ6UGs6RPPfFVfdrSMh9 MWb+8wVUHC6UWfskT/Swbg== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 46e40gr2wh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:01 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5443UDQp036077; Sun, 4 May 2025 09:00:00 GMT Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazlp17012052.outbound.protection.outlook.com [40.93.20.52]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 46d9k7ghc9-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xBgN9y+SU9AJ1Mdev2OH1GxrgdcTk61wsvYo6rJQhignO8DH3vywZ4ro+j3wsl4BuV6m4WOkCVGCEiXu08Ac1mnPuXGAdAMc1+tsyD8niGfaaSnlOtENZL0teUE3UcNzw+zazISYnVHJkppnAtyhvf3maF3WbHoO7YaKr+IG2BCYc4tiuAvO5YpZRSSxVCgNT9VN9urZ4MynsMioXkTDKmBDh97P5WT2a4t0ZF4W+6lYFSKosRrmUXZ5UzSrlkzUQ87u/GgHBsEFCttp44lFNzjta2+trgtjbH07MSpNBKER9AWIxuMh3wZy7BIkQf9VUG1eenSJDvpayD92WD4Tdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FGY7X/rVUPMi6d0cWq4YsnWnzlpHNtQ+nFV6a0BaurU=; b=xdEcnqXZlZHooAxtskGatZiYH/nF8FJ+2eGzAhGZzNnFbKvPipdgNt1YkMOAze526sHpVfD4bAI9yCAZZij4YltS0K1DqRkz5q49kTJuP4LvpLEcYrtuKF8GfVJk/SqpMSFzK+q3cipCR/tAq06ZNcGbS89eKd+eV3nZYZhdNzuvz7SwCn3mS/RDEj/qVY3w5OEonkD71giUIlmEvIMCOGFLrqFggM8ZRAPsi0YMt/EJnZk+fcuFed8pAakheAMIA5E9qVAWGfUmwYJHepSQoefCHG4LT0W2QnHFcyMHm5z4HbIiehE9uv+9VfIPtRa+0HeZfafSGbHJZz/mW8SEBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FGY7X/rVUPMi6d0cWq4YsnWnzlpHNtQ+nFV6a0BaurU=; b=kitaBR6hTKEPD/0bLCOcZLfdTNBUHlE2ZSizJ3CuYAvmlf3T7wX+08G6mp+tMwuuHsHW6EfNAhth4mmhTZRTXXwCKouB3dWLk2SldGZ6Eg04V8zEGBvUeth6jvCBgrLH6aJEb6dWX9tyWZR2T39O9Y+chBRvNbQkxV2XBA7+0Zg= Received: from DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) by DS7PR10MB7178.namprd10.prod.outlook.com (2603:10b6:8:e1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.23; Sun, 4 May 2025 08:59:58 +0000 Received: from DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088]) by DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088%7]) with mapi id 15.20.8699.022; Sun, 4 May 2025 08:59:58 +0000 From: John Garry To: brauner@kernel.org, djwong@kernel.org, hch@lst.de, viro@zeniv.linux.org.uk, jack@suse.cz, cem@kernel.org Cc: linux-fsdevel@vger.kernel.org, dchinner@redhat.com, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, ojaswin@linux.ibm.com, ritesh.list@gmail.com, martin.petersen@oracle.com, linux-ext4@vger.kernel.org, linux-block@vger.kernel.org, catherine.hoang@oracle.com, linux-api@vger.kernel.org, John Garry Subject: [PATCH v11 02/16] xfs: only call xfs_setsize_buftarg once per buffer target Date: Sun, 4 May 2025 08:59:09 +0000 Message-Id: <20250504085923.1895402-3-john.g.garry@oracle.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20250504085923.1895402-1-john.g.garry@oracle.com> References: <20250504085923.1895402-1-john.g.garry@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BLAPR03CA0134.namprd03.prod.outlook.com (2603:10b6:208:32e::19) To DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB4313:EE_|DS7PR10MB7178:EE_ X-MS-Office365-Filtering-Correlation-Id: 9c60d606-f93d-415e-8d41-08dd8aea0bd2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?5QnnLtshTWSKgRAdrLo+xYvgflyOLtnIItpIuh1WfZsc814VCtFA9J5QtTUk?= =?us-ascii?Q?WPNp/M0Ok6TsBIX5AgZTuLX8jK+7vqkjKIrMbNobYiyIksWZrZl1+CMBumiL?= =?us-ascii?Q?IQfsrP2rnzDtBPrpU4CvPHcKnbre3oy42lFbyp9f+8lT3/PAB+qvlzygBRr8?= =?us-ascii?Q?XaITP6aVFZMmkyYV3trVmhhQhWb4LLaEkiM0znzOFu+QtFYWfqvBaRitv8am?= =?us-ascii?Q?+AyJn5wp1/5L+aZarolnPNCVtAiFoKtxt3KtZi0cyP+VzwtSRyhzQkTnkyyX?= =?us-ascii?Q?yixWotrxwdzlx4MP8No7RhOhBwXO9faZueMCdOHh5acKukHdEATWb/rpbb/J?= =?us-ascii?Q?puVYhih92lCgKlhPDSBbgIB4N7CK3760l7XAygDJiNTCJP8H6XgUjLh5usRx?= =?us-ascii?Q?EiuvF0lq8W3jNAYswD+bH2HS9mq/6EtO8Fwiy5vQY5f5d4qcCCg5g0u6/xLG?= =?us-ascii?Q?9vdhWQkUA5n/uFEZfJsBs3NNYcd902yv5WXdP/sa0rHLWnVpwe9pN8PL8nKd?= =?us-ascii?Q?UGzSQeUc5lGxfHUJ4G7VQ9pGl/vSQFygbmBYXf4DFVxKPXCsUqneV/50kJMS?= =?us-ascii?Q?O8TZzCTmQEvUi9joUf+WX5ICD86RDaJOzhclJywdd129cxnyr9tp+wIH2Snz?= =?us-ascii?Q?BipiRVwRkQ7L3HzGpp702NuTZKB/LADKu59cMdQy9nOaqiJj5Oi8slMQQBwo?= =?us-ascii?Q?hO6+JamWmXIgtouBcKJORYwwGoVriAc/qHvVWUeuC65FCoyUHOBM6LH/X3pG?= =?us-ascii?Q?agOEzz3YEwBkA5m1aaCsZzmEKgja4aCYTUAX91+BVP4/ycVHtEUYLr1cKbx7?= =?us-ascii?Q?HpakaDOE1sr31ycADlDDkMR8FJvh5hMLrca0XMrATHNhQMC5by+QFLuVhScu?= =?us-ascii?Q?+ZknCTxdPVIe1nqEGWDmhhO/GzWm6ydeCcRD3cGwWeoLP8Lrl3fMxaLbcP/2?= =?us-ascii?Q?hswLwTBeC6osDBYLa7dOEvHzZWWp4FyRWG8lsSNSU4B3vVVFSHWUiSWbuSxZ?= =?us-ascii?Q?TnFQSY9FmGd8IyzbtYsucXWTkFtUHADPrycHu1Dsq+eEQU9ytSFmoxpu5/ak?= =?us-ascii?Q?B+k9qBR4KL8SHJ2x+lVV4ZNjDgVI8AaP8659BKfnPFqYVsW9v2op+o/RRX01?= =?us-ascii?Q?fAMdsJx95Yh2CnLlnEGK9TRkaoVH6RdofvxXQXmEVzsvMC5JwcfhR54YBywV?= =?us-ascii?Q?O+z1o7HN/7xB8UOesqsze307C/f3HPOikv759x1KeKrWGrLEy7KtiNQrSVRg?= =?us-ascii?Q?c1syAYRfo2aB7c1Fa+j5DEpx1oB80V3LZEesgx+UblVbyMtyU4b7xasDyrps?= =?us-ascii?Q?8UCT1KoBgdH1tagKbEm2VqV2MXnGKbCGJXv5ItqbQ5KMptEq7c66Sl3V0/VN?= =?us-ascii?Q?bxHBEt6WlnUgQ7HZKhxPKS1uSFlTAQnswrUKwfBVy5YTpAHlxfTYoJ+j27Ys?= =?us-ascii?Q?8owGhPXMgg0=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB4313.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?svEd1GTEjEEgb0PM2oLSzltemtgTWban3gVAHW2HaFMXhnb/zR3BpBNfL2lW?= =?us-ascii?Q?iKn1IpQJ8O9gD7pDFHCVaXLU2H1+kNyS8V84emHRro3d0uOs/AFVK38jOQ3L?= =?us-ascii?Q?4o/lA3gwE1viw8Ly9YOSXZF66AnQWwJFcqnyNyVhJYqSWRnDZgTs4psgbkl3?= =?us-ascii?Q?wK8MHtJNSbEd0/LPxlm8ZwDBtJtjtXVdCe0bGDJ1nvLTcIjfqI0g5ou8pDYZ?= =?us-ascii?Q?c7lMzx82mCckYIl7TbDr7aJQTvAthzCBMRTKIr48LF4sCp3wlP6gyrFzFFxW?= =?us-ascii?Q?J5RB2OTcxOz5G/BHCBjzapoNiwASecmjjuNZJv6MpIsgAnTj42ccnpzloT2s?= =?us-ascii?Q?mrymHNhMFq6iQgrM6zD+U61c6TXvnEBMWksT4oJNrCFnEOOZES45UwhBP3Q7?= =?us-ascii?Q?NkdUx/8UVrj00ptgIbBAaM4/vN2JUSgTEpJ9i7HrE6lHntiCYQ83lXaQJVV/?= =?us-ascii?Q?jD1JYCpAkLppGO1ZXmmdUNwajxSIEXYHSYBgcwOE1YOdgrlbkyQcT6Ajj52N?= =?us-ascii?Q?0beA3Oirog9j6Fae46ze7F65HE5fRnnWSf5WNBJlGHdRtd1qkAkeJjgXlKcY?= =?us-ascii?Q?4O+zA84zqQav2hvl6Q8GUpKLPUXaY9b3CyZLAEIDR9XrglMXaN71Goudsnr3?= =?us-ascii?Q?wsD0XHsQmoOyQ2+L3Cj8IyKunQqST4Uzx8WmdPTURqMmfdnibN8DSutQrrrE?= =?us-ascii?Q?354oVDMDnmyne/DFOo/DOcYH7GKnANUfqpFEy0F+B2r70+Ge3bV5Z6WzU19I?= =?us-ascii?Q?iHCI3Ev4xiWBL4/FEbjQ/ohQMdVZ/lejs5h2wfQD0BlFOODFQd8w8BiL0r3u?= =?us-ascii?Q?O969PRq6iD/czPk7+YhXCaJGRqNDw3JlxnZDMs9D00M1UXaikiJwF/FmVmWg?= =?us-ascii?Q?q1wGGax+J6ky1N8R36F6sYhCJ1c4gCBi5qGWbKjvuV+uwDoQWGGkj6Piw52i?= =?us-ascii?Q?LRP9W6npbewimJTwxA5HuIJLO7l4x4cec/Msqa+4Ocx/ejVSud+rwwP+5Umb?= =?us-ascii?Q?aYGi38x8cpobyl56cfH3ZO637Od4wDBKDewnwhTLDrmhU2k8xRpuPiyIitfZ?= =?us-ascii?Q?9or8B0hx2eJpLoVhNciT4aBy6ihtRcBwSuAyU4ONT0+wa9fSqTpmq+P5r+PH?= =?us-ascii?Q?TRJmmKwM3YPQjY7VERmDPh0xv6mKPbSrE1r7pjPCWRWs4OBOnaSEbs3mGEbJ?= =?us-ascii?Q?IURWIKdr//fXGn/rE1YX2jMMs3A0ysnKtQAGHsy1dOFcnpxCMVyAmfmgCGtZ?= =?us-ascii?Q?WQM1tguBEphNwfoO4HCwUtVfZtAvA0lHjIWcndot5SVCBhFb0Z/RycvGNinW?= =?us-ascii?Q?tkCqQhQxEHFB61ph9RTtLcFoAO/MfVtUYeIPPAVKZIgUH1GYWVaP3KpsYz4G?= =?us-ascii?Q?KZ8zTeocECiqr2N8CNHUbXlFQoo+jWnefR2/adkz8r1u0//Es3kxVoDRTAsw?= =?us-ascii?Q?VUz9He2yankbs1cE3tbD5d6h64kd1VigtnqN8SOVc9T4iKKtgYDhBkSzFkvu?= =?us-ascii?Q?WW56iqzJPh4PNrhPEaJqo5KsZ7JUhc1hqprWtK+6R/X7xdpizs0zuW+DSTlX?= =?us-ascii?Q?Mf6pJRp7qEopV9VUeM9HhYbxxeoOFHi7Qd4bmUje9/gGTsXesgPsO3tX8u0+?= =?us-ascii?Q?Aw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ThED+/kUfiACN88SbAcNApwKw60GiCFjmTYpE3uJlFHZUMHCWlo6NvHSmIIw8z2jSo9lN9VOLe6+EYo8lS37OnUE+KMxz5iX+WoBRPTh6hXz/+Ls2N+EOXSzUe3Kf+X4azFYVE7kJwzeD+k9G5jgEPPp6YjUq7s4qCsRhSzWOHY++YTmycr+9vfV06Ay9q3tEW0yZnprwKSpj46+7uTRAABKUoClK0vzSgdkqedWBN/EQXeJuETK0/sJ7yWInksAimNmh0P0EkeKdjK+haW348h8wMioKU19DynNtJ71+fFgWn4EeAyGE5hoOqzjJBtjGvCBxIe9rIqxxzhzOqxSg/agt/Ixgc7X2AQE/Tu2duezdDejcy59j5XFnVjxhebW4HD3i2rwRnrrqrEdtyjlP8u1OJOuDZv3eSmfKoS8BhV19CIfQtAjS+XclRT/XQ2Gp1gdDOM00aesKLy+0VtbII5UOCLqHEPow12WXGA3fK5g7xEKDhkfsGUjzW6d1czYRN+dFU9ESDRnXnJkeM0J7k4NBBMOeWKYUyOopKiD2iQ36DTs8TNh8k4oLEQDKa9xojDjgc2TrSgIijKx1yNH3QlUulmM9SkJq5V+hqSi6tc= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c60d606-f93d-415e-8d41-08dd8aea0bd2 X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2025 08:59:58.2980 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fxEI4Wd+S3VSZox+NIsUlwAdGCdmuXB+x3T6A9XfnaxZNIqtP9HNYU1ccu7pBgVnUajj+VjXWgcDd/DnqrFtoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB7178 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-04_03,2025-04-30_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 adultscore=0 phishscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2504070000 definitions=main-2505040081 X-Authority-Analysis: v=2.4 cv=Y4H4sgeN c=1 sm=1 tr=0 ts=68172c91 cx=c_pps a=OOZaFjgC48PWsiFpTAqLcw==:117 a=OOZaFjgC48PWsiFpTAqLcw==:17 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=dt9VzEwgFbYA:10 a=GoEa3M9JfhUA:10 a=VwQbUJbxAAAA:8 a=yPCof4ZbAAAA:8 a=PEStbzsqZpMx2UUXZgIA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTA0MDA4MSBTYWx0ZWRfX4JhBsWk3qdwl dpEVgdNp8gzINXrfPoHgGNpZV8H0H2MSpFws1C3qGr6fvZdNJoP7CYRIKUknWfRNzDXNIhFR/0B 6rdsqLkVaO1TSBdlV+I/uNQ4OWkKhEzj1wclIIe12TnV3/2TFYUePVQhhAkfwRX1PfSQlns/mH3 0M1iDdLjU5YzGwdj28gRQ4JT56nrv6dI4mnQChd36fFHPtqzVBdBD5RhSNCYDbB//x5RL6nQPLU VyQBQcD+SW/3tvqjfDDU+TMRygRiBfT6jLh4g33qACv2M5+x91B2UFWawQJ9+hPQqDvxVrEYMA3 +QvCGgaicvqmus+0Grt8St2nXE3gifqYThXQe0CBvDRHjWBSfQp2a8fkjt9m6bh4BErIXzqZKFQ xIGAUQp005B9iIoU//ftE44GjaTUn3AlMHI9fdqWMwnmMXWiVp6v/IUv/vhDTRPOJg4AQizS X-Proofpoint-ORIG-GUID: rvoprLHMpmkjNy0eFFFvlR0WWSVPpqr4 X-Proofpoint-GUID: rvoprLHMpmkjNy0eFFFvlR0WWSVPpqr4 Content-Type: text/plain; charset="utf-8" From: "Darrick J. Wong" It's silly to call xfs_setsize_buftarg from xfs_alloc_buftarg with the block device LBA size because we don't need to ask the block layer to validate a geometry number that it provided us. Instead, set the preliminary bt_meta_sector* fields to the LBA size in preparation for reading the primary super. However, we still want to flush and invalidate the pagecache for all three block devices before we start reading metadata from those devices. Move the sync_blockdev calls into a separate helper function, and call it immediately after xfs_open_devices creates the buftargs. This will enable a subsequent patch to validate hw atomic write geometry against the filesystem geometry. Signed-off-by: Darrick J. Wong Reviewed-by: John Garry Signed-off-by: John Garry --- fs/xfs/xfs_buf.c | 14 +++++--------- fs/xfs/xfs_buf.h | 5 +++++ fs/xfs/xfs_super.c | 33 +++++++++++++++++++++++++++++++++ 3 files changed, 43 insertions(+), 9 deletions(-) diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c index 5ae77ffdc947..292891d6ff69 100644 --- a/fs/xfs/xfs_buf.c +++ b/fs/xfs/xfs_buf.c @@ -1733,11 +1733,7 @@ xfs_setsize_buftarg( return -EINVAL; } =20 - /* - * Flush the block device pagecache so our bios see anything dirtied - * before mount. - */ - return sync_blockdev(btp->bt_bdev); + return 0; } =20 int @@ -1810,10 +1806,10 @@ xfs_alloc_buftarg( * When allocating the buftargs we have not yet read the super block and * thus don't know the file system sector size yet. */ - if (xfs_setsize_buftarg(btp, bdev_logical_block_size(btp->bt_bdev))) - goto error_free; - if (xfs_init_buftarg(btp, bdev_logical_block_size(btp->bt_bdev), - mp->m_super->s_id)) + btp->bt_meta_sectorsize =3D bdev_logical_block_size(btp->bt_bdev); + btp->bt_meta_sectormask =3D btp->bt_meta_sectorsize - 1; + + if (xfs_init_buftarg(btp, btp->bt_meta_sectorsize, mp->m_super->s_id)) goto error_free; =20 return btp; diff --git a/fs/xfs/xfs_buf.h b/fs/xfs/xfs_buf.h index d0b065a9a9f0..132210705602 100644 --- a/fs/xfs/xfs_buf.h +++ b/fs/xfs/xfs_buf.h @@ -383,6 +383,11 @@ int xfs_buf_reverify(struct xfs_buf *bp, const struct = xfs_buf_ops *ops); bool xfs_verify_magic(struct xfs_buf *bp, __be32 dmagic); bool xfs_verify_magic16(struct xfs_buf *bp, __be16 dmagic); =20 +static inline int xfs_buftarg_sync(struct xfs_buftarg *btp) +{ + return sync_blockdev(btp->bt_bdev); +} + /* for xfs_buf_mem.c only: */ int xfs_init_buftarg(struct xfs_buftarg *btp, size_t logical_sectorsize, const char *descr); diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c index 5e456a6073ca..45e188466e51 100644 --- a/fs/xfs/xfs_super.c +++ b/fs/xfs/xfs_super.c @@ -520,6 +520,35 @@ xfs_open_devices( return error; } =20 +/* + * Flush and invalidate all devices' pagecaches before reading any metadata + * because XFS doesn't use the bdev pagecache. + */ +STATIC int +xfs_preflush_devices( + struct xfs_mount *mp) +{ + int error; + + error =3D xfs_buftarg_sync(mp->m_ddev_targp); + if (error) + return error; + + if (mp->m_logdev_targp && mp->m_logdev_targp !=3D mp->m_ddev_targp) { + error =3D xfs_buftarg_sync(mp->m_ddev_targp); + if (error) + return error; + } + + if (mp->m_rtdev_targp) { + error =3D xfs_buftarg_sync(mp->m_rtdev_targp); + if (error) + return error; + } + + return 0; +} + /* * Setup xfs_mount buffer target pointers based on superblock */ @@ -1672,6 +1701,10 @@ xfs_fs_fill_super( if (error) return error; =20 + error =3D xfs_preflush_devices(mp); + if (error) + goto out_shutdown_devices; + if (xfs_debugfs) { mp->m_debugfs =3D xfs_debugfs_mkdir(mp->m_super->s_id, xfs_debugfs); --=20 2.31.1 From nobody Fri Dec 19 16:07:40 2025 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E9C61A316A; Sun, 4 May 2025 09:00:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349224; cv=fail; b=jlMUl3wW/K/eP1qFLfIgCfPfqsg0Lqv9kixj00wx5zsSAMN3k2Dmmx6oYwincG0ztErUQ46P3LsJl6ILKhmYf/dG8XK0X2avuoi9x7ODgy8eKd8foGR7au+Fc6NhhmnJcxGgAhTSRjUeyP1T5UoNI+lFdiXF+d/M950Aqu98Lvg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349224; c=relaxed/simple; bh=wm7rSgXjAJHQhi8ehc1aU3KcZ144tJmRrGCHWg7nJCQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=KkC3i4/nQxHr/LKiXtsnzu+pUbxY73l4Q/9//2yAsfDAUI6pxqlEk6wtIgua4zTT38ahhxAPfIwuSgCIjOYtNx36mMB2fHxVFGHsrh6nhQEJAgQNp9fJGCOZZTZWeiZS5CuH74wrprGXXbnZ55I7VkGNIettwP9AIVdTN42GrcA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=OBOtMGmS; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=EtIe8z8k; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="OBOtMGmS"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="EtIe8z8k" Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5447MmsP013216; Sun, 4 May 2025 09:00:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=QBdxx6TL6c/ibAyxGBc81pYFfbStco1TPCLf4whYrW4=; b= OBOtMGmSP6Pjc4U26Zb2yk43+Es0o/zBGNaRtzlF8Fi8UwZFYg/+Ljd/jw+JNJtq euVvG4u7FnHW0398E9HNhL6012hEDyK9j9OqxSMpbqQKWqDDQ/mhoBWq43qepCFW jpbFeD2nMS6Hh+aqA514ek0pD9VitrUyWhZAaL2SXS+6p28HU3kx9a9hYAEwabhr emVO5JO2qcsjxUmDvTAl8OZAiiliQ6nOzeqoG0kTOuZNBKfOdPfA5HoRc9KrFqmK 8uwn5MduDAv33xFX0tJE9FMYby8rUFy/wcxqM3xVWVSAI1gv1oy8cDgRJMi19igV 2GzL1kVJkyUzcsS9adBYmw== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 46e3smg2se-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:02 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5445tJYZ038371; Sun, 4 May 2025 09:00:02 GMT Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazlp17012053.outbound.protection.outlook.com [40.93.20.53]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 46d9k6gf9e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=COWEA3hWNVSvKFN2KOhFqcTD65UGxDEP2rqVppgfs5dKd0fV4ryYuxLcKliUGiADGw9m5foDWvwRI0aCWuOgSFAGh6GOELJAjTll1yrDf/dw0+1pnCzrFVltThqtBt0V0N9H2NU/vjgBohAP2RVy7w/3UEA3i900J6Q79biBFHrc5TtA09V1VNV6DQI7aZOSBDxb1idYPY/R0dUui7pjEImEjZUQazwoEsyu+yai9I+WuyE4UiVZUnvIkfTuh+72wbRRRp+cRxAxK7k6wj7biTnyvAyThdRf/klvLcPDTLNCswKAMwueEjdBbvHCbeOV8MgKx0ltOx1okhrvsZeI2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QBdxx6TL6c/ibAyxGBc81pYFfbStco1TPCLf4whYrW4=; b=gnRfZ+1dwLqA0nD1YglE/4t9oo6RA0wcMtXXktY8oDWOh2yC22RBgcAGVzX3LY7C/fCgWIJEfT7ZOqmPEgaiFe9naS33LgnWGS/LNBxAwsvmzMsl2GvPUmyKi7ejXZ5x0JDyrPmaiQybbK5eEGNO0blyIhjb16382IEKxSwP5ccGb9NH9KHheZeXSocN7hiFLq5+pR8wzCe9FyEhGRTrY8NGl/6EUul6LP+weyEoCt5ZIOcyfPfUOHQK7nxdTUiXYQkDxjmhuw0r0Fv0InHfPJE7zGsfxIcXz65a+3uWXzdtKo7+E6JChZwQSvpQ/TBMaBWrj5cfLBck/B3AbOeblw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QBdxx6TL6c/ibAyxGBc81pYFfbStco1TPCLf4whYrW4=; b=EtIe8z8ktSeQWKtiUPyRx2Nnqf5ZcgLWjGXdWxfJV5poys+dPjyMZI111pZF6zRnGlhuwM2jyvVrSyFzBenpFt7Qp4CahzidK6369RpaiXHLxO8pYPALHNDUvgw4Jb6tADwAJXKSKN+jwb2GAQuRz9ZRV13ayuxvIgMCyVbLqOk= Received: from DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) by DS7PR10MB7178.namprd10.prod.outlook.com (2603:10b6:8:e1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.23; Sun, 4 May 2025 08:59:59 +0000 Received: from DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088]) by DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088%7]) with mapi id 15.20.8699.022; Sun, 4 May 2025 08:59:59 +0000 From: John Garry To: brauner@kernel.org, djwong@kernel.org, hch@lst.de, viro@zeniv.linux.org.uk, jack@suse.cz, cem@kernel.org Cc: linux-fsdevel@vger.kernel.org, dchinner@redhat.com, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, ojaswin@linux.ibm.com, ritesh.list@gmail.com, martin.petersen@oracle.com, linux-ext4@vger.kernel.org, linux-block@vger.kernel.org, catherine.hoang@oracle.com, linux-api@vger.kernel.org, John Garry Subject: [PATCH v11 03/16] xfs: add helpers to compute log item overhead Date: Sun, 4 May 2025 08:59:10 +0000 Message-Id: <20250504085923.1895402-4-john.g.garry@oracle.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20250504085923.1895402-1-john.g.garry@oracle.com> References: <20250504085923.1895402-1-john.g.garry@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BLAPR03CA0122.namprd03.prod.outlook.com (2603:10b6:208:32e::7) To DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB4313:EE_|DS7PR10MB7178:EE_ X-MS-Office365-Filtering-Correlation-Id: 2eb62be2-d32f-4829-5520-08dd8aea0c83 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?2Ht90OZTcihCamMShs6/sEsPx+EKSExzN+wc76RAhBrpy4TTpotbfcn/wm2o?= =?us-ascii?Q?WBppU1kMZ5O+x630dDlHHyJDeEZcnu75U/yE9BiN822/rlz1LizkSwzBX5Vy?= =?us-ascii?Q?mdrYkFKX4G2eG1TVHSpOZ5gipDDcI8VObPQqoTSvmhPgAjRMGvMblQZtYrDS?= =?us-ascii?Q?jWaqD+ORrj8lHdrdt1R3+4f9W17KB6Jeg5zGsBzm2ZLv54eY0sRe0Ddluf3z?= =?us-ascii?Q?tT6PLKZ/bsZnUmccgMDXbes1pv4JxHxSsSsMVzkoEysebg+XFFNw4UBfSN6T?= =?us-ascii?Q?I2Zblgy4GoXyFewwBrYIScl9mXFD+2H1go8vL8ywbijurL2PFNCpWfybhMeH?= =?us-ascii?Q?ofethMeVRJWsaVgJO50tOZR+8+cCasRceqnKOayvLMXwOCoxqjzHg8k3s1KQ?= =?us-ascii?Q?CmUtvj17q/Pmy0HYs1YL7OAGt9CLZd57vlsk9zCMZF85xroDZ3+DBKSzmSfX?= =?us-ascii?Q?Ms5U15G88a3VvfakWzRR91xpBKx/R2/aHcNFPWds4XBQ2ycwp87796asacqN?= =?us-ascii?Q?B6vvvSeBTcD4jbfAkE1YazYMUBelMgxIWtrOVtZP1SnANrbTqGpvZqgynzXo?= =?us-ascii?Q?xKcd4fNlfpkYQK0mM0k6C7oBZH71KfZrmzdm+bTZU+ha35kKAIfW+5TeyHV7?= =?us-ascii?Q?rGRz56FxUykjo8uMSNibts3gtfsve7sTJ/tGUKdByfna595ZD5OMW+H5tsj9?= =?us-ascii?Q?kNaG0LY5JvWZeGBWtAp3dFoU1TAmRZiYr0DV5LryYZs6fsEKBjQiozuO2lfw?= =?us-ascii?Q?avA0K7xBzu72X8RPgtyuUwUygiAt885xooGJ6CngRFYsmGkABJac+jZWHPML?= =?us-ascii?Q?R8YWN6Jn3ygVJA4WLoZmvVwUVLVpfNUYQ1/qldYpiOn+IGlQLT6oIpFVhdzi?= =?us-ascii?Q?HfMqGzMkbmnW/P0cP7+qUx5Cs4wMSfp4sQVgG//rXMlSwMC1u2aHCUf7yFae?= =?us-ascii?Q?52nighdTjOBttRZ9Fr+x2Xhy5NhDhOCQpwNBiG5GUZGD+obeMfmfbtlc5GEi?= =?us-ascii?Q?cSmounwsOozDyReEd5NAA/ETbSqISPKp7WO+O3OOG7KaS3ZURoCdLKyMzv9A?= =?us-ascii?Q?bzTyQ1yKwdp1fT7rMJrNMrOF8d7FAhtx08yhAcJxiF1QX5b5hVTzJtZFv1aD?= =?us-ascii?Q?zbPnfX0dycbdX2yojNBIIAm2Z+V09x9SlysDlxO4is0bru2RXUgekqhoEPYC?= =?us-ascii?Q?696nrjhA+c6NSf4qVAc6bco3P8vnXvZcHr8oG/r051Qf/WoYvv5qMbx4Vk4w?= =?us-ascii?Q?yBubMglj+oXyBBbbikMqF7xe17wDJZi7cwfYw3hgVY8aTefIGLutvn/DWmz6?= =?us-ascii?Q?lhrwmAcBpvqh0TbWR+xIn2tFrY25IK/w/QydVZW6SpOu3jiG4CybqdpzHTdZ?= =?us-ascii?Q?rCmDMsTRIgM+gw0bBi69VGk3Aob/dYoYvTC1Dn7lyhT2EvHRm7/cJKRht1R3?= =?us-ascii?Q?nCdrR8fIPX8=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB4313.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?y9QB1RvTTR80aITIyV+S+40Z4aHOAns0h3TZMdDjzNyhlh3ouQDCl1qqc9I/?= =?us-ascii?Q?6p6TL7FQxsuchEsFe3cDUM0ek56KU0egTWLc++I/YV8Klr9fsHVVHUv+XB3c?= =?us-ascii?Q?fJFJ9/KMdy4bG4U9cB9+smsjNV50vDasra02dmekdecPwuqf0xjMQr5BXmGB?= =?us-ascii?Q?kIbDu+DwLFmUnm7pGN+e7QZqa0zZn81U2llyHTsJY1DM6xqDfUGVIF9o7Mr0?= =?us-ascii?Q?8oSd0Fqzg/5k2mxd4LLrD5D9xCU1JNofEzkh1yvZxUfMw3ROYHU/wjREsZCH?= =?us-ascii?Q?DT4cBZRWrd4bDjsfJyvEM0KDwycmizlCchaUngvHwrmSvJcotsP5BKU+Cz/v?= =?us-ascii?Q?AjHTzhTZbeIJaRLpDWKKIn44JRja+qUJJ9s8pFfm96OAmnGFzpcrXILJTlVG?= =?us-ascii?Q?+yJSqBDl+TmfA/gdbzQZcv5VbwUI9D5QKS53db6z4FIfpgc8cSp4dqUUEzU7?= =?us-ascii?Q?B8CKCN0zxXevIIK+/v3zhD18I4olLXbeC8rByKIB8U9oHbknJnqu5lR3n/Gm?= =?us-ascii?Q?jC3xxYPQ9famFlAUjdNYm3bkop/n8N0ltgooMT4zzBTq+PiF+tJ7WM34JF6d?= =?us-ascii?Q?X2TekliNdWR0ZyTGQiBGskpyfufPiwAYOpvDx5GSiZnCTL5v11AtO3ge8/ua?= =?us-ascii?Q?H3ypW5OAcT5c3wNRsagMGT2Kd7nSRQuMqckU9XVOWa/iJkYwGZryxuyh8hv9?= =?us-ascii?Q?Ow/sgRba2PiRsw0IWN3QBCust4ysAduOQcjYACWx8uBgdT85B19dHAb1nDYp?= =?us-ascii?Q?phXV/w8ofyAyaA2UiErZKzEksgh02VdhshaQYIyDbSYUmiQs9fIkM0M6EfIM?= =?us-ascii?Q?o734MnT7ZeoJi6kEJ5OAL5T7XiQW2oWfpvbVNCOUeytqmIFfsl+SSHM1swGQ?= =?us-ascii?Q?OD53mxz+W9bKONpvySR7b/8Ki8mb2tJzuaXqtbCCMw4Ea43f95Ctk7+mXBxz?= =?us-ascii?Q?11P9jAs1WTQqwtD44I9sj8Bmz3atbAxQvIdlsuG8k+nW020+SY+Jrw2zn4c1?= =?us-ascii?Q?mNfhSRfR2d1JTEgz9hETJP9OBvD8Glm1/vj29sX26OW6R+oZrZ0BPeP2DARI?= =?us-ascii?Q?IVW9zv7aKK//2Q5xxjezT9GLHk8ySgEZKmJtAlfBvASKNBx5VkQupbLUEblD?= =?us-ascii?Q?VhTri59hi8lsasFuGm7VsaHWrrTPJ5DXsBRs6KLjsazjEKjUgxyTP7CRGQKR?= =?us-ascii?Q?lgkQ7VP0komm2z/oFXL7pvmkqoPX+uvkGoZZMbcRN8XPuUYpf6llUZKccacf?= =?us-ascii?Q?igoKHVpD0QKziHPmVTCy1xuWr88962CWk1D9lwDGSXB+M6ZcPA0oGDaiIsjm?= =?us-ascii?Q?gBMwuWnWZ0SwDmilCyvQPyjmAEt0LCt779nd2w3ySkh5iRKoklttOyO5W9Rq?= =?us-ascii?Q?ywYM6HgtJRe1qmS4jvrrxalexQijFxxAJEzzhFML4+xuTXb4rOJ99Qi9oN2l?= =?us-ascii?Q?Z5YlLEXsTVVdpUdOqxSHd2Yj+i4TJMG61jdPyC06zs72sGXUWBNMNgvlb4vS?= =?us-ascii?Q?1rAFOLznFjeVvA5bb2J37r8gts2zVEmE28frSjPXnxbiR5jiRbkn52IVLLxp?= =?us-ascii?Q?1NQCReRaYrSOqNy6atawrhb2tl4SCS/jui0nE7LjtTSrgjPObBT4MsgTJSu3?= =?us-ascii?Q?Gg=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: n1887v0qHtVB41yAUbECqsbzfNnIkH9yvooyYUA1Y+cBYp3Z1Lp2LGr+41mFIzXQmYDMYUNOXsw/I/w0AtVpYObp3a/zNs+ybcGcLquJ7m60GZoK+kDguKNj2ih3QGjEa18QeH2wVtNJoHMc3LndVQ/ydYVEZhVWeLJijSRFICPiGvj1cNZyufzbX17GQ7fBv6OP+XSNqlxBxV8cb1a6zRC4Wl1JX3oVzmWya5+PnUn8L5Z6Nmh0v94HmsxFunKa+nvvzbiPcJ3cGNri7+wzNCb8zZnCpCUyjalwVouaf2uSly8R/pc2moGtzfczmSelqI+xe9VnrbWRTA6YElWChMDui3ofpnZvvhAG3D8hzwtVplB5q9EwywBc0vuAJZbrZOpGjgtWS4OwOZwh7A/ByHqvyxwEBaxJv3qdgaqVDtIBgGFS/Z8NHA2FaR0nFOHJPxUluhu+wRjz7bGzlXridP+Y9lxP3Ysd5ncFn74XaUYatjDbkL/I+005eGxsLMKiZ2MJ3OvC8xQmX1/Ns1sE51ccvlaFEv/nlh4doYt0OWvdb6DjpVJlRwAT99dDJIzKW4ChHB7Gcice6dZJIdesZ940igKquqBl7Vke5INhk34= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2eb62be2-d32f-4829-5520-08dd8aea0c83 X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2025 08:59:59.4416 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: p+fK3QdWdfYQlHCBBXMNIztrh6JF4mzB7xXrqgC+gXMiTp+cevIiYEAHIcrZFzPyWllP1ghbohjzs6mbuo+6iw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB7178 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-04_03,2025-04-30_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 malwarescore=0 adultscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2504070000 definitions=main-2505040081 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTA0MDA4MSBTYWx0ZWRfX7wVvJcPubHQ/ HzeJaAovLvE05beDPf2e1fkmrgujd1VQcL3XfWd+lZP9Tg5gNIIgOjsaWd2qskAVMeRxQ1B4WiC XlwiqCbkkZCvBV+ZRpvCHYnGTCNEicsR7r37nqz0Rr3UULRvmY66j96s/wEDvLRiNRs3NF5oxQs 6iTI3A7NZ0wJQvP23C/UgPx4XgxXcsproWgIQV9hZDmqfjSpWdI1OryDzHd4Vtm8ruWowcpBVYj /D/kh3ZamSA9sQQVi7WGG+n4ic/cTp+LSqnJlPJbS4NLMRjI5SPQNLwK7aadvQSBt9kzL7kRdwv gSX+mf/pbERhOPTiUjz03zz1J6qZWblllR8GU7DYZDk75HXwXJ+MWOvK2jGPBZ4J8DwWjqgENrZ rJj8tJ/nrst6e3JIWV4SO1krkTK7uWl8pcjj1yXKsE5L69Xg3OHyhrULwoFd9n+59iOZGg12 X-Proofpoint-ORIG-GUID: molaMx7aPP_JmUAKp-x4_J-7M1h5rl1e X-Proofpoint-GUID: molaMx7aPP_JmUAKp-x4_J-7M1h5rl1e X-Authority-Analysis: v=2.4 cv=bNgWIO+Z c=1 sm=1 tr=0 ts=68172c93 cx=c_pps a=XiAAW1AwiKB2Y8Wsi+sD2Q==:117 a=XiAAW1AwiKB2Y8Wsi+sD2Q==:17 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=dt9VzEwgFbYA:10 a=GoEa3M9JfhUA:10 a=VwQbUJbxAAAA:8 a=yPCof4ZbAAAA:8 a=6KFWBsMsv8NWCX33yDQA:9 Content-Type: text/plain; charset="utf-8" From: "Darrick J. Wong" Add selected helpers to estimate the transaction reservation required to write various log intent and buffer items to the log. These helpers will be used by the online repair code for more precise estimations of how much work can be done in a single transaction. Signed-off-by: Darrick J. Wong Reviewed-by: John Garry Signed-off-by: John Garry --- fs/xfs/xfs_bmap_item.c | 10 ++++++++++ fs/xfs/xfs_bmap_item.h | 3 +++ fs/xfs/xfs_buf_item.c | 19 +++++++++++++++++++ fs/xfs/xfs_buf_item.h | 3 +++ fs/xfs/xfs_extfree_item.c | 10 ++++++++++ fs/xfs/xfs_extfree_item.h | 3 +++ fs/xfs/xfs_log_cil.c | 4 +--- fs/xfs/xfs_log_priv.h | 13 +++++++++++++ fs/xfs/xfs_refcount_item.c | 10 ++++++++++ fs/xfs/xfs_refcount_item.h | 3 +++ fs/xfs/xfs_rmap_item.c | 10 ++++++++++ fs/xfs/xfs_rmap_item.h | 3 +++ 12 files changed, 88 insertions(+), 3 deletions(-) diff --git a/fs/xfs/xfs_bmap_item.c b/fs/xfs/xfs_bmap_item.c index 3d52e9d7ad57..646c515ee355 100644 --- a/fs/xfs/xfs_bmap_item.c +++ b/fs/xfs/xfs_bmap_item.c @@ -77,6 +77,11 @@ xfs_bui_item_size( *nbytes +=3D xfs_bui_log_format_sizeof(buip->bui_format.bui_nextents); } =20 +unsigned int xfs_bui_log_space(unsigned int nr) +{ + return xlog_item_space(1, xfs_bui_log_format_sizeof(nr)); +} + /* * This is called to fill in the vector of log iovecs for the * given bui log item. We use only 1 iovec, and we point that @@ -168,6 +173,11 @@ xfs_bud_item_size( *nbytes +=3D sizeof(struct xfs_bud_log_format); } =20 +unsigned int xfs_bud_log_space(void) +{ + return xlog_item_space(1, sizeof(struct xfs_bud_log_format)); +} + /* * This is called to fill in the vector of log iovecs for the * given bud log item. We use only 1 iovec, and we point that diff --git a/fs/xfs/xfs_bmap_item.h b/fs/xfs/xfs_bmap_item.h index 6fee6a508343..b42fee06899d 100644 --- a/fs/xfs/xfs_bmap_item.h +++ b/fs/xfs/xfs_bmap_item.h @@ -72,4 +72,7 @@ struct xfs_bmap_intent; =20 void xfs_bmap_defer_add(struct xfs_trans *tp, struct xfs_bmap_intent *bi); =20 +unsigned int xfs_bui_log_space(unsigned int nr); +unsigned int xfs_bud_log_space(void); + #endif /* __XFS_BMAP_ITEM_H__ */ diff --git a/fs/xfs/xfs_buf_item.c b/fs/xfs/xfs_buf_item.c index 19eb0b7a3e58..90139e0f3271 100644 --- a/fs/xfs/xfs_buf_item.c +++ b/fs/xfs/xfs_buf_item.c @@ -103,6 +103,25 @@ xfs_buf_item_size_segment( return; } =20 +/* + * Compute the worst case log item overhead for an invalidated buffer with= the + * given map count and block size. + */ +unsigned int +xfs_buf_inval_log_space( + unsigned int map_count, + unsigned int blocksize) +{ + unsigned int chunks =3D DIV_ROUND_UP(blocksize, XFS_BLF_CHUNK); + unsigned int bitmap_size =3D DIV_ROUND_UP(chunks, NBWORD); + unsigned int ret =3D + offsetof(struct xfs_buf_log_format, blf_data_map) + + (bitmap_size * sizeof_field(struct xfs_buf_log_format, + blf_data_map[0])); + + return ret * map_count; +} + /* * Return the number of log iovecs and space needed to log the given buf l= og * item. diff --git a/fs/xfs/xfs_buf_item.h b/fs/xfs/xfs_buf_item.h index 8cde85259a58..e10e324cd245 100644 --- a/fs/xfs/xfs_buf_item.h +++ b/fs/xfs/xfs_buf_item.h @@ -64,6 +64,9 @@ static inline void xfs_buf_dquot_iodone(struct xfs_buf *b= p) void xfs_buf_iodone(struct xfs_buf *); bool xfs_buf_log_check_iovec(struct xfs_log_iovec *iovec); =20 +unsigned int xfs_buf_inval_log_space(unsigned int map_count, + unsigned int blocksize); + extern struct kmem_cache *xfs_buf_item_cache; =20 #endif /* __XFS_BUF_ITEM_H__ */ diff --git a/fs/xfs/xfs_extfree_item.c b/fs/xfs/xfs_extfree_item.c index 777438b853da..d574f5f639fa 100644 --- a/fs/xfs/xfs_extfree_item.c +++ b/fs/xfs/xfs_extfree_item.c @@ -83,6 +83,11 @@ xfs_efi_item_size( *nbytes +=3D xfs_efi_log_format_sizeof(efip->efi_format.efi_nextents); } =20 +unsigned int xfs_efi_log_space(unsigned int nr) +{ + return xlog_item_space(1, xfs_efi_log_format_sizeof(nr)); +} + /* * This is called to fill in the vector of log iovecs for the * given efi log item. We use only 1 iovec, and we point that @@ -254,6 +259,11 @@ xfs_efd_item_size( *nbytes +=3D xfs_efd_log_format_sizeof(efdp->efd_format.efd_nextents); } =20 +unsigned int xfs_efd_log_space(unsigned int nr) +{ + return xlog_item_space(1, xfs_efd_log_format_sizeof(nr)); +} + /* * This is called to fill in the vector of log iovecs for the * given efd log item. We use only 1 iovec, and we point that diff --git a/fs/xfs/xfs_extfree_item.h b/fs/xfs/xfs_extfree_item.h index 41b7c4306079..c8402040410b 100644 --- a/fs/xfs/xfs_extfree_item.h +++ b/fs/xfs/xfs_extfree_item.h @@ -94,4 +94,7 @@ void xfs_extent_free_defer_add(struct xfs_trans *tp, struct xfs_extent_free_item *xefi, struct xfs_defer_pending **dfpp); =20 +unsigned int xfs_efi_log_space(unsigned int nr); +unsigned int xfs_efd_log_space(unsigned int nr); + #endif /* __XFS_EXTFREE_ITEM_H__ */ diff --git a/fs/xfs/xfs_log_cil.c b/fs/xfs/xfs_log_cil.c index 1ca406ec1b40..f66d2d430e4f 100644 --- a/fs/xfs/xfs_log_cil.c +++ b/fs/xfs/xfs_log_cil.c @@ -309,9 +309,7 @@ xlog_cil_alloc_shadow_bufs( * Then round nbytes up to 64-bit alignment so that the initial * buffer alignment is easy to calculate and verify. */ - nbytes +=3D niovecs * - (sizeof(uint64_t) + sizeof(struct xlog_op_header)); - nbytes =3D round_up(nbytes, sizeof(uint64_t)); + nbytes =3D xlog_item_space(niovecs, nbytes); =20 /* * The data buffer needs to start 64-bit aligned, so round up diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h index f3d78869e5e5..39a102cc1b43 100644 --- a/fs/xfs/xfs_log_priv.h +++ b/fs/xfs/xfs_log_priv.h @@ -698,4 +698,17 @@ xlog_kvmalloc( return p; } =20 +/* + * Given a count of iovecs and space for a log item, compute the space we = need + * in the log to store that data plus the log headers. + */ +static inline unsigned int +xlog_item_space( + unsigned int niovecs, + unsigned int nbytes) +{ + nbytes +=3D niovecs * (sizeof(uint64_t) + sizeof(struct xlog_op_header)); + return round_up(nbytes, sizeof(uint64_t)); +} + #endif /* __XFS_LOG_PRIV_H__ */ diff --git a/fs/xfs/xfs_refcount_item.c b/fs/xfs/xfs_refcount_item.c index fe2d7aab8554..076501123d89 100644 --- a/fs/xfs/xfs_refcount_item.c +++ b/fs/xfs/xfs_refcount_item.c @@ -78,6 +78,11 @@ xfs_cui_item_size( *nbytes +=3D xfs_cui_log_format_sizeof(cuip->cui_format.cui_nextents); } =20 +unsigned int xfs_cui_log_space(unsigned int nr) +{ + return xlog_item_space(1, xfs_cui_log_format_sizeof(nr)); +} + /* * This is called to fill in the vector of log iovecs for the * given cui log item. We use only 1 iovec, and we point that @@ -179,6 +184,11 @@ xfs_cud_item_size( *nbytes +=3D sizeof(struct xfs_cud_log_format); } =20 +unsigned int xfs_cud_log_space(void) +{ + return xlog_item_space(1, sizeof(struct xfs_cud_log_format)); +} + /* * This is called to fill in the vector of log iovecs for the * given cud log item. We use only 1 iovec, and we point that diff --git a/fs/xfs/xfs_refcount_item.h b/fs/xfs/xfs_refcount_item.h index bfee8f30c63c..0fc3f493342b 100644 --- a/fs/xfs/xfs_refcount_item.h +++ b/fs/xfs/xfs_refcount_item.h @@ -76,4 +76,7 @@ struct xfs_refcount_intent; void xfs_refcount_defer_add(struct xfs_trans *tp, struct xfs_refcount_intent *ri); =20 +unsigned int xfs_cui_log_space(unsigned int nr); +unsigned int xfs_cud_log_space(void); + #endif /* __XFS_REFCOUNT_ITEM_H__ */ diff --git a/fs/xfs/xfs_rmap_item.c b/fs/xfs/xfs_rmap_item.c index 89decffe76c8..c99700318ec2 100644 --- a/fs/xfs/xfs_rmap_item.c +++ b/fs/xfs/xfs_rmap_item.c @@ -77,6 +77,11 @@ xfs_rui_item_size( *nbytes +=3D xfs_rui_log_format_sizeof(ruip->rui_format.rui_nextents); } =20 +unsigned int xfs_rui_log_space(unsigned int nr) +{ + return xlog_item_space(1, xfs_rui_log_format_sizeof(nr)); +} + /* * This is called to fill in the vector of log iovecs for the * given rui log item. We use only 1 iovec, and we point that @@ -180,6 +185,11 @@ xfs_rud_item_size( *nbytes +=3D sizeof(struct xfs_rud_log_format); } =20 +unsigned int xfs_rud_log_space(void) +{ + return xlog_item_space(1, sizeof(struct xfs_rud_log_format)); +} + /* * This is called to fill in the vector of log iovecs for the * given rud log item. We use only 1 iovec, and we point that diff --git a/fs/xfs/xfs_rmap_item.h b/fs/xfs/xfs_rmap_item.h index 40d331555675..3a99f0117f2d 100644 --- a/fs/xfs/xfs_rmap_item.h +++ b/fs/xfs/xfs_rmap_item.h @@ -75,4 +75,7 @@ struct xfs_rmap_intent; =20 void xfs_rmap_defer_add(struct xfs_trans *tp, struct xfs_rmap_intent *ri); =20 +unsigned int xfs_rui_log_space(unsigned int nr); +unsigned int xfs_rud_log_space(void); + #endif /* __XFS_RMAP_ITEM_H__ */ --=20 2.31.1 From nobody Fri Dec 19 16:07:40 2025 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1B9918A6DF; Sun, 4 May 2025 09:00:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349225; cv=fail; b=ZwL06d7EQOXVMD8xM3kuuFiMCtk3vaopIu/Ceg0hVKNWgLrUfGiQbOfDNaH1DY3cVO0vOi6x0p/DhH9GFpbsx85lg+/S/gF3h0m5zAsvyhpMtJ8h3VXYE9VB8JvOEZ8vp5yjlmKGw+iH8DeJTLXJC5l+eX5lgPCnnwTCWCfSthk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349225; c=relaxed/simple; bh=Y+h0SeI/WhZZN7iLnPC7D4DvuhV4YxHgH5qJQhdZCUg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=gTUnNvoGwZArtI/4JH5CpBKNP3dFdwGPkWpTthAQt7XmzLbF8x8NMr17qRB2nPUtAHf97Kcw3yaIu98MWFUxnSuvCFtzMeYdU8clzmHGWP+KA3Qhsv/bkAVYlxtNHU3cGCTBrF9o77b83hljaiDRtI5QNJcEc6cmbOj/8SM2c70= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=fKASTlf1; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=FL6SHQsA; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="fKASTlf1"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="FL6SHQsA" Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5448MANx029851; Sun, 4 May 2025 09:00:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=Knrw86SB2+FjQtTS7zEUket55dWzKrgXBuOYNwpvZuU=; b= fKASTlf1bNsEYeblCBtLLZ1IAUSkK1zVO2XVwcbp/E5VEFh/CDOJdL3x2wxL6yCS PLx2e1rjZZrvoMoNgnC94qQjtBF8JUEt+NZ+9Zs6VVrPzUnLOYlqcgBe2qy6FhBw 3fYWM7mrx7VJhvArpaHPL45K7LW9/Qs+iRb3cTbDLGGhz+O1jaNDzuPOPn0PxhRp GrgquQiM9VkiJ1DeVdGm8YdMJAaj1bcVmOUNXF1MesoDsF98ZnJFfmNQeUFY1JeL Qa2uclvxyQq2Hs5j0U4+lXnn2YQ3MfwO1bG/tEarJqwa08otUULt87u5uiKVw42t rn57lKeh0PcwnLFAIOjBaA== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 46e4nqr10q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:03 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5445tJYa038371; Sun, 4 May 2025 09:00:02 GMT Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazlp17012053.outbound.protection.outlook.com [40.93.20.53]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 46d9k6gf9e-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OW23dTx8NjBXkhiGQNHWNzJlt/ohz1SoX7woqtDHFOECE0kGIISWiv/W1AJHH5nZZuSj98RcF6Yh0mjURYPdRV4l48AjRIeqmrkzrXbMHLvx2Ad8afSGVGq+KHTq4sw6HUui0GSmgQZowF7ITOVK5Wcj/M1flNoAymIw0a1bfJVT2JcP39kM92pd37EiH+phuP4Vjv6r+YmZ2WHoQ34EA/s9g9QbnOqG6RvrzjuyzE4zvtG/rkcAzlCedvb7HEbzys+ZtvVf2I3RwAMbH8sWAfLRSgmsNmaKkSPcTROd4B9jtfl7ZaxM+6YhsBQTWO4w6cw1LkCgWk5NHadXt3liaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Knrw86SB2+FjQtTS7zEUket55dWzKrgXBuOYNwpvZuU=; b=QX4h1sMYI5rJMYTzVvsVIvHhprhdHqFnHpfKmVadGXR2KTj8L5hvX6TsWVmeDBULdDPt01HairK/PzAJbIB0PDx+92LYfhrirmVutYdIPG6TbBairHh8jOb1Eb3alfzWBz4iQT1rql7AJxBLMNVj7OPYlvofUVQ0xK5gUjz7C9aiboQ5m/Dh+LGFjjsBR2TMfEcCxr5A6WENVnFNkGRjtEGwcmaxar+YhefA+i3UCXjpLVtmtop3XG9Aup5eI1uQOdwMGKDuBrhxxd286ZPQFJ3XhTxz/8qGTnAmZbUMsAduMiUv2OXOHpNYTIPHrLyuGBDAufYytDECvJeJw/yLcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Knrw86SB2+FjQtTS7zEUket55dWzKrgXBuOYNwpvZuU=; b=FL6SHQsAFxfqJuZB2+Pz+hTukKbPtWQWn8MMxo+aS4lhlFSZ1z85NnrmtLHPXIUTiPG2PxrCUzpmrqMpg/Bv4CpxDDbDh3jkevQkbq1iI30gW7Hr29kXhFadG1M9zLctOYXmzz79sF71GIpe+LsSfufLfXcj/lLMgRaQGW9aumk= Received: from DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) by DS7PR10MB7178.namprd10.prod.outlook.com (2603:10b6:8:e1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.23; Sun, 4 May 2025 09:00:00 +0000 Received: from DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088]) by DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088%7]) with mapi id 15.20.8699.022; Sun, 4 May 2025 09:00:00 +0000 From: John Garry To: brauner@kernel.org, djwong@kernel.org, hch@lst.de, viro@zeniv.linux.org.uk, jack@suse.cz, cem@kernel.org Cc: linux-fsdevel@vger.kernel.org, dchinner@redhat.com, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, ojaswin@linux.ibm.com, ritesh.list@gmail.com, martin.petersen@oracle.com, linux-ext4@vger.kernel.org, linux-block@vger.kernel.org, catherine.hoang@oracle.com, linux-api@vger.kernel.org, John Garry Subject: [PATCH v11 04/16] xfs: add helpers to compute transaction reservation for finishing intent items Date: Sun, 4 May 2025 08:59:11 +0000 Message-Id: <20250504085923.1895402-5-john.g.garry@oracle.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20250504085923.1895402-1-john.g.garry@oracle.com> References: <20250504085923.1895402-1-john.g.garry@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BLAPR03CA0144.namprd03.prod.outlook.com (2603:10b6:208:32e::29) To DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB4313:EE_|DS7PR10MB7178:EE_ X-MS-Office365-Filtering-Correlation-Id: 417b03c4-6526-4e8e-6de9-08dd8aea0d38 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?lf8GxdUsyBhff7P0shwfUsG/btKPoHqTW4Fn6dBX//T2FU/msXSn/jX7NFyk?= =?us-ascii?Q?A7Dm240ViTVd8R6fypKC41fPYjRoUylq3mqtzLBq247wkwBKSjPhPWjRLHuJ?= =?us-ascii?Q?5EFNmObFvNUnPEFqKAw0zqevTcivA0phMw9DBaFq55zqh9KSlqcwX9PuySHP?= =?us-ascii?Q?rUBJoXyZHbEDyHLzNQqbZK82IeMzUYKHGvIDieAiKPHr4XUHWSkKCrX+71fF?= =?us-ascii?Q?X4P30Q2bKJm4/e2GI7jhRfNqRx4PyfuLjIKC/og8oVt/Y80KXyMEP3RFjQEB?= =?us-ascii?Q?PIY73ILlGQN68T7rpWGjXDh3JAUT1B4V6LTDv/AKRlqLOu7fMqQHAAAkJBhY?= =?us-ascii?Q?D4sY9+Q2on4kD6abFdJgoEr6MwLuQjCauOf9wVJ0OgcO4KBZiTBd4p5Uh2+4?= =?us-ascii?Q?MOmPRrm8+9iCSQWMza+LIcretThcVtRjBcgm4I61EPvygDEhuW5raloopUGi?= =?us-ascii?Q?hjywLaTHH0mp/r4rtks9vtvMydVtcCKGRMWTYUd5LnH/bdIUK/I2iFWx5ZEl?= =?us-ascii?Q?yp9nQpV/Fip6zpRkO2xqXP9XuiIH64dMiQNO7UmhJjcRdS7e+Qn+qxNrMAls?= =?us-ascii?Q?u1zwWhUHj/Hnw84ujoIwq29384/XsCMIiqDE2sb/ku3k7ZGFqBRXAVbsV/Kr?= =?us-ascii?Q?af9CTkra6xFmJQSkIxTek15ZQjuEDjSS7lwlZ2R5ri30c5W9tMqxi+9MHHHP?= =?us-ascii?Q?hXi6EJSNpzTm5UQa/AQX4RJ7w4kuO9eIv4bRmbmuJp4lmlBorKUcYnbGURIb?= =?us-ascii?Q?otinmWyok7zP/BdWKXPeLxXCi/IOm3zzCaej/o9a9Kuj2NwMoCuJRYvt6gTB?= =?us-ascii?Q?rdvHylLX9+Ayr+yVWk0fx2Oj0G+rIs0RNzKLKLw1+b1SD4e2E5DDMRZ517r0?= =?us-ascii?Q?XMjSwF7OdpW2PfGHhI/g4RWQm84vj7XWsZDViFhOsbMMj4crnOAkjDJO2YSh?= =?us-ascii?Q?/3sf4j0XyV3b0f3rIc2GVCaPs+J9ITZeJVlir6NVh9BwbNhBgBNeIucsROzl?= =?us-ascii?Q?0gh6TXEGKxnG/+lPRQoP1Xw607PbXWBXcWKSKt5BkD2rt7OFyYAt8iReTf8y?= =?us-ascii?Q?WN+kT6QvWvDUHpbjlirgQDoSF5n7fOMAC2ZAsRUzmw3eawuy87qOfCyadlxy?= =?us-ascii?Q?p+ucZJFV4TOJqB/HA1q6VzhE6flBqU+gN4VvgiRb9hoLMMtzCISe9jxMfzEl?= =?us-ascii?Q?b25/0oWLxaOUeSHfH+VIoaZpfNZ0WAa9MAx9pb0v/LkjHVzY1Z9Zi+09CsRI?= =?us-ascii?Q?wWgTp8+UvBG8g66SVVwKFkCnEh36pjAB1WnY/u6xUxPpUmRyZWaQUhH2VSHj?= =?us-ascii?Q?9Hr0+IBnD2ktJVqvgoxoDwtFvkx0BRs/Ou3OXhRAfxa6hDKRpuq+2i8lATxo?= =?us-ascii?Q?eScsviEKK5ZKC9S2aYGNy3AAKkvVhgdsCCQGqvusSTbS7S7d1izfX5VMwNC6?= =?us-ascii?Q?mimc6EHpxRo=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB4313.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nPqMT9Q3VoammP3P9BFzf7qhM64pMkbjRHIyy9e5mjwtHu7aY38UdXkMtxAm?= =?us-ascii?Q?zHWnIsuu1CNAGkctpLToTmrCW7MU3zDsK6EuYIbLEIz4Gj3LqolfkfQiuAf2?= =?us-ascii?Q?CxlU7dQY6LA2NvDsPkm+RNoWd7WcggCJacrmjfS0qvp3iB077yD5kv3mKcZo?= =?us-ascii?Q?heTrw0vM2ZjYwl91KiYF2LEtXNYHX2ySQq+loe8Cfub1zID0FMwM7r/lEAGi?= =?us-ascii?Q?8EQPi1wEYNDBShhqJ/ZHOHAbBnM6jRfAoZdWZjp7zy+/eSGbjZTVNm1iE2Q9?= =?us-ascii?Q?FDxsXufM5YbIo+UxWWrFSUiNx0w22HW/T0mwD2kyrCYPkGqYX9Et6yXrGI7W?= =?us-ascii?Q?iSQVne4EidcQy6Ak8XfIxjdvuM6fnRGalJji2Lp3QbYEQFjGSgrrdiTwSa/E?= =?us-ascii?Q?sJXKdck/qu2M+6aV/culPyeNPuKFbfwsKN860ygKd8Nhy6yaQh47hgzuHHrM?= =?us-ascii?Q?/6rlJD7IlqyjYLh8Xte2XU2YV0fyGRjHH3pRp/Bn0jNawYcUQixoYRNunQAb?= =?us-ascii?Q?T2lHoK0HyEgwIy7/5C7vFS52Kgap3h416mm8SyC/eVogAmm0ZpkwGJVWeoEQ?= =?us-ascii?Q?NE8KiFCiVlv2lLFYI+g7rbgBqk10d6iiyAD/wkuItF+Dot4rkQGJ3TqPoSuJ?= =?us-ascii?Q?//cRqi5HBd3j21p80WKsPbak9BzJ1ue2UgKUxHBgFDh0CK7MOwdIVWqFRcDS?= =?us-ascii?Q?OEtMzFwuxARALkRaIhiShrFluHSaKkGCoy/TjsEC/8PvhqtZd1CRoOrH4pCw?= =?us-ascii?Q?ZLL+FjzdVx6GRfOP30Daths4RKH2tIsCZq1RIFxqm8bv+PRNi5AHMuALNtTs?= =?us-ascii?Q?PVXoe/9ClZHpETTs2b0+nxXTF/EUc946780QeYFNraNLNuX540uXxoXyD1zZ?= =?us-ascii?Q?bSB7ZCtn/RbRsVj0bV8SgfMP/EwTEBceSYPbQ3SO6x+tVE/fRVmarqu75fii?= =?us-ascii?Q?9u+n2+trtwazoBMQ9DwIUzHJWdQgWzeSgUtcAsXdrKcACo2z5ZE0PNsrqDQq?= =?us-ascii?Q?0meHuQM3fMPo3fxEdZKgE2AUgVnq6v5f4ms2FA2zUafDRUKr+Ip2+y/imklK?= =?us-ascii?Q?jcEv9TGIfg4cqxIEbrroiFoBaHMqIGzNkmaK8yEHcBePqdQAt3yGDPVtSfJX?= =?us-ascii?Q?ghov7nK18phTWfeBrHotRG2xhPGtnqdYrxZugTdluE7g9cX+N+tZb1vH0eG1?= =?us-ascii?Q?OC5Alpf1i+KDNPnFfmRGQ8SN44Mu5H2vjzExC96BvNbAaXs6ROHUsCANrDiq?= =?us-ascii?Q?OKdN9CR0z3+9cOu6nNr51DV5MpO7u+4QVWo7B1aWt7X51IXWLgthXPxh3PhV?= =?us-ascii?Q?mWG1dX0Q/UpM3j3kSYV931NktvfxTF/UonEPCEtjbABpkar3rnMAivWImgz3?= =?us-ascii?Q?aU24X1BAT24t5w2wcpN7wdpx/l9FBIq7sqKJ7eAEaoTvoculJqciF7FTzXtE?= =?us-ascii?Q?HkNDiUWvHEUqvct0MtInOoR82Z7+w4wKpiVfkHT1BzJ9CTfk4+uyUYjrTRlS?= =?us-ascii?Q?Viu/ElmOo1WszgLdKKMDWYCHuFYsFGnP4fBDfExbrUkSXG1TNV1ItLaECl0w?= =?us-ascii?Q?vbgvsuG7LrMiAwEkp6xebx3WYVisfjolHLNThxPg8sME8hgNmArem7Uo/HoT?= =?us-ascii?Q?iw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: NqVJPGrg8crdZvhaUXN0KihmNm2k7UcGRb9vAoBSVBkq9Qs5Z6FZMm9NefqIH0n+7L74LhX0ICjRGgMztifXlkQT31kIZ6r+xPBsrVpEvcS71/YA20CRBKEjkejMk1lFqlDG3NIri64zZb8adbqNcyff1VJYGuc+XIe8jbuGI7uWbHlUjc7n8uv//on+UB2UkXxFC5aZqWcIufK6HaJZ8Tv3tk0YmUIG9S5oVTPh9NiJ1n63Xb0RIbcsayMJ9ztDTFPPHEJXvUg4mm3OxKvGb9RHyvpOtXqytfBkK7M1I+7ixMfe+n3EFrvk0Y8L4HxEP9e/8sK+HsmX7tZy3HXihL0zmCRFlpK9hjP8YHtfYjDJmdtJwAWYzaC9dvbjBAtodl+g9jyNlabEr9yb3KSP5tl/KavqP3gx6H1vTvIcsU7v+UPFw8fZC6Dh3FB7Cy4xOYsnyF9+4raj/OXkIfJ+N2jzk9AlXYVP35pLnRmIpLqAv9G3EIIt5Y1mCS583zze5zy9ghpqsITWmgeHgiCowgt6IXbOW+2ybn9lCSOpI7lpLDVoq48hxd59qderj5XTBH9ugCZpL6+R7/N6o5ECdd+D1jUHoQibh4FKCjGH0wk= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 417b03c4-6526-4e8e-6de9-08dd8aea0d38 X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2025 09:00:00.6310 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JCKoc3cDupQn+NDMzVr2XMtz497iGmY9toljFT+gnVimKwYFaDSTQ3AyFsEN02D2OdZL99sLxxQxZoEyTlOU6g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB7178 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-04_03,2025-04-30_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 malwarescore=0 adultscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2504070000 definitions=main-2505040081 X-Proofpoint-GUID: SBXEHcCzjQVcxX_mnVg5i1ElTD4EdXEy X-Proofpoint-ORIG-GUID: SBXEHcCzjQVcxX_mnVg5i1ElTD4EdXEy X-Authority-Analysis: v=2.4 cv=PouTbxM3 c=1 sm=1 tr=0 ts=68172c93 cx=c_pps a=XiAAW1AwiKB2Y8Wsi+sD2Q==:117 a=XiAAW1AwiKB2Y8Wsi+sD2Q==:17 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=dt9VzEwgFbYA:10 a=GoEa3M9JfhUA:10 a=VwQbUJbxAAAA:8 a=yPCof4ZbAAAA:8 a=woQZa1pMVDXcXY9PtcEA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTA0MDA4MCBTYWx0ZWRfX8gt7AVwUyNIW EctNmiQmqvIBHe9/u0fc+0ar92NnXynivwSLInWQp+a05wuULm46g2wpAF3edgIabPlicZYkcjY lhMBGP4ysQXxg4/sAzJEY4C+GTiaGcp3tM5aoWlmai4D3lw4fAkBig3OUS42CQFtCQis5967mG7 gWLUUU6O5NlqcXha5YkJiKijxlQtnYBS5HsM8mWY/E7tzs6ZwRjVcHhMZzTxMgcv+vPUG/SXufp 4cgk6CBkAl6+v5Ym4RV9HI5X1UlAXm9j4o1dv8JcBJov4jd8Zpjdy4ydhAmnrTiPL012NVZ4IYs 65RyXkGFXwNK1UbekqwydNaglXa1BNX6QgOm3qq6wGqkJb0KogSq4AE19aSNuk2jpiJSANLWFpV Vtz/2z/L9f2f9VZ91J6MgVwCWyL/UPkpca761y2KYWy1ywEjP2cTQmoaUqsnXowJQXBK7Hr8 Content-Type: text/plain; charset="utf-8" From: "Darrick J. Wong" In the transaction reservation code, hoist the logic that computes the reservation needed to finish one log intent item into separate helper functions. These will be used in subsequent patches to estimate the number of blocks that an online repair can commit to reaping in the same transaction as the change committing the new data structure. Signed-off-by: Darrick J. Wong Reviewed-by: John Garry Signed-off-by: John Garry --- fs/xfs/libxfs/xfs_trans_resv.c | 165 ++++++++++++++++++++++++++------- fs/xfs/libxfs/xfs_trans_resv.h | 18 ++++ 2 files changed, 152 insertions(+), 31 deletions(-) diff --git a/fs/xfs/libxfs/xfs_trans_resv.c b/fs/xfs/libxfs/xfs_trans_resv.c index 13d00c7166e1..580d00ae2857 100644 --- a/fs/xfs/libxfs/xfs_trans_resv.c +++ b/fs/xfs/libxfs/xfs_trans_resv.c @@ -263,6 +263,42 @@ xfs_rtalloc_block_count( * register overflow from temporaries in the calculations. */ =20 +/* + * Finishing a data device refcount updates (t1): + * the agfs of the ags containing the blocks: nr_ops * sector size + * the refcount btrees: nr_ops * 1 trees * (2 * max depth - 1) * block = size + */ +inline unsigned int +xfs_calc_finish_cui_reservation( + struct xfs_mount *mp, + unsigned int nr_ops) +{ + if (!xfs_has_reflink(mp)) + return 0; + + return xfs_calc_buf_res(nr_ops, mp->m_sb.sb_sectsize) + + xfs_calc_buf_res(xfs_refcountbt_block_count(mp, nr_ops), + mp->m_sb.sb_blocksize); +} + +/* + * Realtime refcount updates (t2); + * the rt refcount inode + * the rtrefcount btrees: nr_ops * 1 trees * (2 * max depth - 1) * bloc= k size + */ +inline unsigned int +xfs_calc_finish_rt_cui_reservation( + struct xfs_mount *mp, + unsigned int nr_ops) +{ + if (!xfs_has_rtreflink(mp)) + return 0; + + return xfs_calc_inode_res(mp, 1) + + xfs_calc_buf_res(xfs_rtrefcountbt_block_count(mp, nr_ops), + mp->m_sb.sb_blocksize); +} + /* * Compute the log reservation required to handle the refcount update * transaction. Refcount updates are always done via deferred log items. @@ -280,19 +316,10 @@ xfs_calc_refcountbt_reservation( struct xfs_mount *mp, unsigned int nr_ops) { - unsigned int blksz =3D XFS_FSB_TO_B(mp, 1); - unsigned int t1, t2 =3D 0; + unsigned int t1, t2; =20 - if (!xfs_has_reflink(mp)) - return 0; - - t1 =3D xfs_calc_buf_res(nr_ops, mp->m_sb.sb_sectsize) + - xfs_calc_buf_res(xfs_refcountbt_block_count(mp, nr_ops), blksz); - - if (xfs_has_realtime(mp)) - t2 =3D xfs_calc_inode_res(mp, 1) + - xfs_calc_buf_res(xfs_rtrefcountbt_block_count(mp, nr_ops), - blksz); + t1 =3D xfs_calc_finish_cui_reservation(mp, nr_ops); + t2 =3D xfs_calc_finish_rt_cui_reservation(mp, nr_ops); =20 return max(t1, t2); } @@ -379,6 +406,96 @@ xfs_calc_write_reservation_minlogsize( return xfs_calc_write_reservation(mp, true); } =20 +/* + * Finishing an EFI can free the blocks and bmap blocks (t2): + * the agf for each of the ags: nr * sector size + * the agfl for each of the ags: nr * sector size + * the super block to reflect the freed blocks: sector size + * worst case split in allocation btrees per extent assuming nr extents: + * nr exts * 2 trees * (2 * max depth - 1) * block size + */ +inline unsigned int +xfs_calc_finish_efi_reservation( + struct xfs_mount *mp, + unsigned int nr) +{ + return xfs_calc_buf_res((2 * nr) + 1, mp->m_sb.sb_sectsize) + + xfs_calc_buf_res(xfs_allocfree_block_count(mp, nr), + mp->m_sb.sb_blocksize); +} + +/* + * Or, if it's a realtime file (t3): + * the agf for each of the ags: 2 * sector size + * the agfl for each of the ags: 2 * sector size + * the super block to reflect the freed blocks: sector size + * the realtime bitmap: + * 2 exts * ((XFS_BMBT_MAX_EXTLEN / rtextsize) / NBBY) bytes + * the realtime summary: 2 exts * 1 block + * worst case split in allocation btrees per extent assuming 2 extents: + * 2 exts * 2 trees * (2 * max depth - 1) * block size + */ +inline unsigned int +xfs_calc_finish_rt_efi_reservation( + struct xfs_mount *mp, + unsigned int nr) +{ + if (!xfs_has_realtime(mp)) + return 0; + + return xfs_calc_buf_res((2 * nr) + 1, mp->m_sb.sb_sectsize) + + xfs_calc_buf_res(xfs_rtalloc_block_count(mp, nr), + mp->m_sb.sb_blocksize) + + xfs_calc_buf_res(xfs_allocfree_block_count(mp, nr), + mp->m_sb.sb_blocksize); +} + +/* + * Finishing an RUI is the same as an EFI. We can split the rmap btree tw= ice + * on each end of the record, and that can cause the AGFL to be refilled or + * emptied out. + */ +inline unsigned int +xfs_calc_finish_rui_reservation( + struct xfs_mount *mp, + unsigned int nr) +{ + if (!xfs_has_rmapbt(mp)) + return 0; + return xfs_calc_finish_efi_reservation(mp, nr); +} + +/* + * Finishing an RUI is the same as an EFI. We can split the rmap btree tw= ice + * on each end of the record, and that can cause the AGFL to be refilled or + * emptied out. + */ +inline unsigned int +xfs_calc_finish_rt_rui_reservation( + struct xfs_mount *mp, + unsigned int nr) +{ + if (!xfs_has_rtrmapbt(mp)) + return 0; + return xfs_calc_finish_rt_efi_reservation(mp, nr); +} + +/* + * In finishing a BUI, we can modify: + * the inode being truncated: inode size + * dquots + * the inode's bmap btree: (max depth + 1) * block size + */ +inline unsigned int +xfs_calc_finish_bui_reservation( + struct xfs_mount *mp, + unsigned int nr) +{ + return xfs_calc_inode_res(mp, 1) + XFS_DQUOT_LOGRES + + xfs_calc_buf_res(XFS_BM_MAXLEVELS(mp, XFS_DATA_FORK) + 1, + mp->m_sb.sb_blocksize); +} + /* * In truncating a file we free up to two extents at once. We can modify = (t1): * the inode being truncated: inode size @@ -411,16 +528,8 @@ xfs_calc_itruncate_reservation( t1 =3D xfs_calc_inode_res(mp, 1) + xfs_calc_buf_res(XFS_BM_MAXLEVELS(mp, XFS_DATA_FORK) + 1, blksz); =20 - t2 =3D xfs_calc_buf_res(9, mp->m_sb.sb_sectsize) + - xfs_calc_buf_res(xfs_allocfree_block_count(mp, 4), blksz); - - if (xfs_has_realtime(mp)) { - t3 =3D xfs_calc_buf_res(5, mp->m_sb.sb_sectsize) + - xfs_calc_buf_res(xfs_rtalloc_block_count(mp, 2), blksz) + - xfs_calc_buf_res(xfs_allocfree_block_count(mp, 2), blksz); - } else { - t3 =3D 0; - } + t2 =3D xfs_calc_finish_efi_reservation(mp, 4); + t3 =3D xfs_calc_finish_rt_efi_reservation(mp, 2); =20 /* * In the early days of reflink, we included enough reservation to log @@ -501,9 +610,7 @@ xfs_calc_rename_reservation( xfs_calc_buf_res(2 * XFS_DIROP_LOG_COUNT(mp), XFS_FSB_TO_B(mp, 1)); =20 - t2 =3D xfs_calc_buf_res(7, mp->m_sb.sb_sectsize) + - xfs_calc_buf_res(xfs_allocfree_block_count(mp, 3), - XFS_FSB_TO_B(mp, 1)); + t2 =3D xfs_calc_finish_efi_reservation(mp, 3); =20 if (xfs_has_parent(mp)) { unsigned int rename_overhead, exchange_overhead; @@ -611,9 +718,7 @@ xfs_calc_link_reservation( overhead +=3D xfs_calc_iunlink_remove_reservation(mp); t1 =3D xfs_calc_inode_res(mp, 2) + xfs_calc_buf_res(XFS_DIROP_LOG_COUNT(mp), XFS_FSB_TO_B(mp, 1)); - t2 =3D xfs_calc_buf_res(3, mp->m_sb.sb_sectsize) + - xfs_calc_buf_res(xfs_allocfree_block_count(mp, 1), - XFS_FSB_TO_B(mp, 1)); + t2 =3D xfs_calc_finish_efi_reservation(mp, 1); =20 if (xfs_has_parent(mp)) { t3 =3D resp->tr_attrsetm.tr_logres; @@ -676,9 +781,7 @@ xfs_calc_remove_reservation( =20 t1 =3D xfs_calc_inode_res(mp, 2) + xfs_calc_buf_res(XFS_DIROP_LOG_COUNT(mp), XFS_FSB_TO_B(mp, 1)); - t2 =3D xfs_calc_buf_res(4, mp->m_sb.sb_sectsize) + - xfs_calc_buf_res(xfs_allocfree_block_count(mp, 2), - XFS_FSB_TO_B(mp, 1)); + t2 =3D xfs_calc_finish_efi_reservation(mp, 2); =20 if (xfs_has_parent(mp)) { t3 =3D resp->tr_attrrm.tr_logres; diff --git a/fs/xfs/libxfs/xfs_trans_resv.h b/fs/xfs/libxfs/xfs_trans_resv.h index 0554b9d775d2..d9d0032cbbc5 100644 --- a/fs/xfs/libxfs/xfs_trans_resv.h +++ b/fs/xfs/libxfs/xfs_trans_resv.h @@ -98,6 +98,24 @@ struct xfs_trans_resv { void xfs_trans_resv_calc(struct xfs_mount *mp, struct xfs_trans_resv *resp= ); uint xfs_allocfree_block_count(struct xfs_mount *mp, uint num_ops); =20 +unsigned int xfs_calc_finish_bui_reservation(struct xfs_mount *mp, + unsigned int nr_ops); + +unsigned int xfs_calc_finish_efi_reservation(struct xfs_mount *mp, + unsigned int nr_ops); +unsigned int xfs_calc_finish_rt_efi_reservation(struct xfs_mount *mp, + unsigned int nr_ops); + +unsigned int xfs_calc_finish_rui_reservation(struct xfs_mount *mp, + unsigned int nr_ops); +unsigned int xfs_calc_finish_rt_rui_reservation(struct xfs_mount *mp, + unsigned int nr_ops); + +unsigned int xfs_calc_finish_cui_reservation(struct xfs_mount *mp, + unsigned int nr_ops); +unsigned int xfs_calc_finish_rt_cui_reservation(struct xfs_mount *mp, + unsigned int nr_ops); + unsigned int xfs_calc_itruncate_reservation_minlogsize(struct xfs_mount *m= p); unsigned int xfs_calc_write_reservation_minlogsize(struct xfs_mount *mp); unsigned int xfs_calc_qm_dqalloc_reservation_minlogsize(struct xfs_mount *= mp); --=20 2.31.1 From nobody Fri Dec 19 16:07:40 2025 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE8DF1862; Sun, 4 May 2025 09:02:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349338; cv=fail; b=B5nMuEmjJNW7hP6vYgbRsZwgtWTEeqXDFNgNeLYUF2TbsxM39/NPKjBZ8Ry39qa53HBPFbZwxO0eLKzfzqAjncYV/lALiT5LtLo7+y6h/k9dJTrrh16acNktvGnMjcfopYdv8UdICeqQidLecIxLGP2oY5268V/orBKexdzFNzo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349338; c=relaxed/simple; bh=PogvYHawQBfcq1w0PK2woXDNT47UrFI/QCVV0ugEp20=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=exWkszTE8loXV6TU/IiM6CVa07Xn21pDooHrwHw6ngnW2qyyj2NiARMcljH8JNjKpd/HLdEFDTB9dOZ8qMmg3R/OD4BHX7qDA/P2kGDQK07WnYmgp06Vy1VIzCwWrwCMipb7/NG/rhaWnnBRCWGasmuea4n2AJiD2zFQ744ujfU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=mov0lQ7U; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=iGJz1Knr; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="mov0lQ7U"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="iGJz1Knr" Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5448tqA6014090; Sun, 4 May 2025 09:00:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=/N66Z+mygfpOG1xPjs3YVUzZuLgtqPhoe7wmNBo3mQA=; b= mov0lQ7UdKs6IumqM6RJZZBWuPA3+ueQt3uxq+XSvsSt2KvcO1/krgwaFZotahEt 2w4WuULG60ixBxTxXTkcZMe4f2M176tSv8fD1nukF3XKPn05CDDdyddE0QbmDvsp vCyK+NSCYngLR2nu6zAsiN9Vsz5/oQEjAax2oDfAPkiCCLrZXYA6SU7DMx9zcOtl d1jFO08phr2mPqyx3NKxSMxUSaaUCbkmKBbUNrYB1TzLVGcUSt06EIpXzz8G/Q7i YTcjK2inO48YqsvD9s7n74GMHwllTwopjPvZ+6KloaZg64saAFKUgrPff1EB5HKu P11t5sD2UaH0YR6HNgWioQ== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 46e53p804h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:04 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 54483HhT035508; Sun, 4 May 2025 09:00:04 GMT Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazlp17012052.outbound.protection.outlook.com [40.93.20.52]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 46d9kd072h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=G7JgV57vj/F/WSQfyof2/V+uY+G4LVVEKr4LV1IotfWJMG3jYYGHIyWmdaYrudi6UdO+klWTDsngfPoKR5xkdD1UVSdtAcoxzjfrdTvzFbQh2bwWdo6u4TwLyzMvQwRXj6OIp6TckvrBeSU1KQ2uY2KmFnebVT8KqUvUbB2uZcR5QHNm2ArfMGiTwjDAda0yOoyeIUkX/mGkRxXCF4klmGlOJWx3PJAxiosdOhxGfhF9l2WqjHXr9y57qNaAtal3RtgGUDewrSWGHqdhxtFPGZTI95mFkCm1wYU537dAM6VxM1US+UUPOeLE4hbz+sKu9i9ip4xCWZn8EL8Rs1Qx5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/N66Z+mygfpOG1xPjs3YVUzZuLgtqPhoe7wmNBo3mQA=; b=V3DVpP3avdTdgAt/boPAjmhW93Imn2djGOyLnKKH18bkSGBpQx6fKLU6Qt5h7cGLRiNSP1zbwwePJx4UuNfUsW0Hap7jQuCDjY40OYPtY7K99GaOPb6if2jp6v+x6w6WJGpy0hD7rUIjMA+pib/QAX7SEoXb10VhoqbXVssiSVihG/wc8xMZ8DJPQEdQqbv2YPqz/o3RjXRhlDfxnmpfPhxnvDaK7se0Fv1hOtmOOUL8+skX+7ZS+CyrsM32Mrz1tuED45eV8t3EtQAvWt9kkGoHlW/ej+Nunh3LTjRrTKs+4Misi/mRa6t5fYP6NcMEIzi2bF3smxfWhPnwcfm/Gw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/N66Z+mygfpOG1xPjs3YVUzZuLgtqPhoe7wmNBo3mQA=; b=iGJz1KnrtshKXLDTq5jHggZtiG21hKtSwRCZJb0+MJ33c3UfvGdz3i91KMYR4KVNotURPmQWKhVJVRvcnjYnZGmV+8//r2lM9UqI+OvfpvzWKs//PFcXjlPNP4oRZxP0yBWJPscI8er+m08toNgqyMdpgJDhoa9mCkCMeQsexR0= Received: from DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) by DS7PR10MB7178.namprd10.prod.outlook.com (2603:10b6:8:e1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.23; Sun, 4 May 2025 09:00:01 +0000 Received: from DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088]) by DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088%7]) with mapi id 15.20.8699.022; Sun, 4 May 2025 09:00:01 +0000 From: John Garry To: brauner@kernel.org, djwong@kernel.org, hch@lst.de, viro@zeniv.linux.org.uk, jack@suse.cz, cem@kernel.org Cc: linux-fsdevel@vger.kernel.org, dchinner@redhat.com, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, ojaswin@linux.ibm.com, ritesh.list@gmail.com, martin.petersen@oracle.com, linux-ext4@vger.kernel.org, linux-block@vger.kernel.org, catherine.hoang@oracle.com, linux-api@vger.kernel.org, John Garry Subject: [PATCH v11 05/16] xfs: rename xfs_inode_can_atomicwrite() -> xfs_inode_can_hw_atomic_write() Date: Sun, 4 May 2025 08:59:12 +0000 Message-Id: <20250504085923.1895402-6-john.g.garry@oracle.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20250504085923.1895402-1-john.g.garry@oracle.com> References: <20250504085923.1895402-1-john.g.garry@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL1PR13CA0271.namprd13.prod.outlook.com (2603:10b6:208:2bc::6) To DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB4313:EE_|DS7PR10MB7178:EE_ X-MS-Office365-Filtering-Correlation-Id: 3ffe7a08-4532-469e-2d77-08dd8aea0de4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?WH9UiWkhFDx79pG0CPRPpzFB4rdAhXWbcVxYqLSyI7YuvJNq3DTLGYJ6VIVq?= =?us-ascii?Q?eD3Oz33aGuHX+P53PohEkFlF0o2P/zsKQjND+I1/siAd5Z4H+YloS/MSEpwb?= =?us-ascii?Q?Gr6C9Ea4M7mK6LQcvq7s6Cs31oxAs60xrb9LSLhskfZWYnNFCxBLNGXeOXyI?= =?us-ascii?Q?TcpaUL4ixCz9XF4zpguNv79ZRNHZvNvEyOIgxxKGmTzlG8vrcDR0gKgNj0Bl?= =?us-ascii?Q?QpsDQMwK0dRKgQwf3TTO+ZD3d2jdVbaLGRlM7VwGT1xnzPwBzRd/tOXiJz7r?= =?us-ascii?Q?+rg4xU8XLYmslQCbJ9L5/HOEgMQel0nqrOjR7x8JbR2WkBO806lAUIAUVbpy?= =?us-ascii?Q?n9wR3weJFxjg+D+s9rMB6pvP7cob6+iPOy5O+PwxXhwkS3tahfyEq3Yp+pvJ?= =?us-ascii?Q?Y5AMifv1Y84rzonVA7OHr08tn3sVzEG3x3Rz5oSGj1JajVYn76zF207YNbae?= =?us-ascii?Q?UJoKNBp/1OGMM7eLeNKiP58D8fDZkFFky2UB9LFd2da6DOM5sZdLFEAfE9/G?= =?us-ascii?Q?8KrkVQNQf2v38iKfgVikUl/Ujvl8x5pkMi+U0m0BXu0vI1/w218juabcTLX7?= =?us-ascii?Q?DNuTlVMa1X54w+mSfDil7EDmuiQ8+gmubPLjREZKwVDRZb2ppJoWV7GoP+HF?= =?us-ascii?Q?W52OWKtFO3dJvH2L1ImrVOImB1e6BWmMwXOL6HW/vm6pKB9sA5BZSCvFvzLc?= =?us-ascii?Q?SUuRrSgtiFcpQTSCMikGtTbFbVp3gZyze9GZVBHEaafqlCA/Hm+h4nx0U3CU?= =?us-ascii?Q?ISyIyohex5U2C6U/cWRNFj8PmFVOQ3RkUFLN3+WI+TJMYibFgny6xGmILgkz?= =?us-ascii?Q?J7eagbb2Fl4qH7cRWjZeGJ6BbS4qeGSV37gWKYzQWSi6f/xLg1TSHTxCn43Y?= =?us-ascii?Q?BnOiToMvIzkRcZtmbiGUlflIbXFV0Ir3n4lVEGDNLg3voO8SUpOHeN5s+zlo?= =?us-ascii?Q?EiBW6Tog5QRDVfj4aJtH0WDBhVvFg7eW0GKQUkZ7v84OtvijijENkk4ROGXu?= =?us-ascii?Q?tQGxWOsOUuXQdz/HoqrDagn34J3uc/vHb3hgl/ly1b1CoGpCqUwXjQNy0ccB?= =?us-ascii?Q?Ur8l+U/OH3I+6uDbDdvmjiCsqM0D89PBci+hi4senfGL6bjKLkPQShXT8Ihc?= =?us-ascii?Q?00GlQ4GWtzb507SCNjjRE7m2lbnWsdEcyKL/ZUJjbxufiQxLDCTJXs21Gry8?= =?us-ascii?Q?XP7UJ2Q7Yc+Jr0wrsq+wUfFRlduMfnxhZ5r6lXF2cWX2AHSgK8iiD107USXj?= =?us-ascii?Q?uAEOgWTt2bgwLrsRkjsMn/hqoZhzSGFgmG0htDMbZyNhNa6Rovy3nqZEE2a6?= =?us-ascii?Q?0zT+xDDyGoWJabux0UTuoTkhp0ROFQNacMWYN3FlEiLQiard1iKBjLfjf7pC?= =?us-ascii?Q?Lqbz69QutCmkALhZabypM3PAhOxZRqt4aFZv3R4gV3ymfIdfgw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB4313.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?C7KbkW+iVrVOJo2b/nHe2bQAEGPubumJukaYCNWmwzdFkDdJjTbS3KTws8SV?= =?us-ascii?Q?D+Z6N4FhDZAVp2TPSu3p8estr9pYptA7REzuChuIsUr537Q7xb85tRnzqWBX?= =?us-ascii?Q?vN/cn1xqjogTYBxQTU8t34onF3CRxu0Rhss+Qy0nsFACGKt+S4VuPYRZNbWX?= =?us-ascii?Q?R34/q6BZoCzaIbgMm4Rg3vQQBGdgUJRCkEauatG+KKGprzj7nJBuBwk6h3et?= =?us-ascii?Q?fq75cvxyV4mmeHYJVqs9O7dXexbtOSyY7VlAOXPoqDL0nahpLQljTp70SbDR?= =?us-ascii?Q?eGzowxpDHopcndQBAU1/IWvoZiD3pZB1Ugc4jHeJU6MZ4g/aCavcCyU2tL1z?= =?us-ascii?Q?hN3leMXg2dBQ2LJriZcCW2VqffWnc9B5MPnTMp4MdSJbtq7JVzd+VpDPr/F6?= =?us-ascii?Q?UE1cXLOmJ3yAzoqF2RSpwvStzGm3i3NsOE2nrmfuHv+ajfj5xF1gBJabQHKo?= =?us-ascii?Q?EwinSHp3YKWGNtaVQjxfHmP0JdhmZSUSerpGHMFroXcqqU4V1JOyTdHS2K68?= =?us-ascii?Q?z/zBFfh4ik9t6NXl2DgtVlqIBTZLgEEK4GT5Jwo64Cz3PX3qWHvVs2V043pb?= =?us-ascii?Q?hMgT5WpSNPQC9sBqaj4JuyzbD8gUzihjOPqVO/XW2E608ydsV29u89BsSo7M?= =?us-ascii?Q?ttH8OmYl9nmW03VkR5bnf1IMc8vOd/PR4gw4RSGlZUTy7v7qzUZgJT9HJOg6?= =?us-ascii?Q?PIBur9SjAgUgIr+ZP2K6lN5fHbmCLf5rzOzAEbRTnM4EuLXC0ywCmF8nTEKD?= =?us-ascii?Q?qIPLGy4Iwkg9agQqKpjsXeyJcCRMOwKmjl/bf3kJ6CAFaZtqV7mw9KrcWgfs?= =?us-ascii?Q?8sgP8TH5JYeCqRV+2pAhTAGm/TK39NVspBB5K3Rog1Zv2tBldRHrKYqphjfT?= =?us-ascii?Q?W0VpifwJQfX7a/nk1P4tDzJzBivzoOizhbMGrodlZFn1liGvVGR1pRgvlLml?= =?us-ascii?Q?BxNfcvhoLVjYLuZ0dhOFtbWBHIQfHffFyYoHr6+ca9Lsa7L4QmBdi8Q3fRq0?= =?us-ascii?Q?1uvIdS8BTexRnu1Gx8COyETb4vSEBI38xbPk8accbFkaG8QWikf4aQy3PkVx?= =?us-ascii?Q?hnTuJI+6WNfjYR/vVHEjFpg5s5IQdZ5fp8WZbqG/6ESuzGA5/HsgjlTTff0M?= =?us-ascii?Q?fIoyAx8AVVACc/4yTv4FM8eHy2XRUKCWRAtATPO7wDFuutqYslJPSKoXpm2h?= =?us-ascii?Q?gmfMWWnehZWUhthf3gorrAnuFGpRwUWzXmZyrMHcYUnJDBTFjrEMEiGfXKaj?= =?us-ascii?Q?V+0FmsYkZCBGfEM5kqjqDnZgJXud4fzi9YzDVS2gY5QhRxG0fUeP9Uat2eKu?= =?us-ascii?Q?85H9y6GIzWRQkbGg9J09NdOdmbAZEZG17jm5rT62ToJY9zudDgJikSLeoH80?= =?us-ascii?Q?tFntAXvq3R5Q78yiEO/oitE8RYH3ctwFE/pcfWK3nA8X+K7NKZvC9z+8PABw?= =?us-ascii?Q?3dqc/Lfxz8n0lth3s8dzQUiVX4JBsOz6fVSCnPNBRTgWdr5qWAoT/wOJGGwJ?= =?us-ascii?Q?CTJo3LrS+6hjtACPiogXG9Ui2fMLYPOFX2XWX+8bZnRyXXR/65XEpPUmpBCm?= =?us-ascii?Q?rvgGmN60QAXNIeyFRGzrKMsuuQ1AFOf05QqZrjgVpFOZWRBJFP0aVCnOWLPH?= =?us-ascii?Q?9w=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: xSFV8c6qfnuuW4FSyiIRF3aUuGo/NKkSBLi3RNi3uyXaJCnwUwtR1yspAh/1eYEvQ9/IseZGdT0y5+qu4Padkj+qRND7dvHeSze4iPLTeqhI+jZy/9M7NF0kP3M5vr5hCNsiVhiZTylDowCUKoJYSVs55UmUjU+CFRNNcNpJYmzHK+FJR4KqTCPX7zS48N2qSAHUSvaq+AOl+xs67FaB66mzhraDh+/QD3/G3qvguVd1nj3/h7uqoxIOjQv0/10LdJNKFQw/WSzcafjB6Bw4QpI7e+yOeZyxToxaJvZShmDkKxkcNZJH/VeCLZGro6S+HyzbkgbrW93vz+Jx1FLXQq4W9ON9w0UJgvIkJgxlV1pmYtlwhG3uIL2tvgEuhWegELARLXw+FFkE/3xB4/nJaVbprS5x/6wlEY6aKs5RHyAd59Td1B46GVC5kmpYYiTH/yFmHsKeUGYY7AQ8W8zLHGuGOOnlPBcGHgKY+Im+kFgA/U3Rj5O0yis5aAv474PX/Lm/RuKOwqQ4w/UqXclXPNI/+AchDlRRSMsvIkJENedJNXktyc2vk54kBXn6r56iKcu167Ncu200mDQzpVfrfTE+F/jEFUDXBGHBpgdQDSg= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ffe7a08-4532-469e-2d77-08dd8aea0de4 X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2025 09:00:01.7946 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mNH72Rq9dseyXyEbcDMqvOxBCQtjWykdheJHL6ev2N14Xw5GPEC/Xsul6RlatYSVP7zYY2uTmvoT5CBlicwtdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB7178 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-04_03,2025-04-30_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 suspectscore=0 malwarescore=0 mlxscore=0 spamscore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2504070000 definitions=main-2505040081 X-Proofpoint-GUID: MSOsQXcfT0yUgqIioc1PkbQzs2JK7xRJ X-Proofpoint-ORIG-GUID: MSOsQXcfT0yUgqIioc1PkbQzs2JK7xRJ X-Authority-Analysis: v=2.4 cv=eMcTjGp1 c=1 sm=1 tr=0 ts=68172c94 b=1 cx=c_pps a=qoll8+KPOyaMroiJ2sR5sw==:117 a=qoll8+KPOyaMroiJ2sR5sw==:17 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=dt9VzEwgFbYA:10 a=GoEa3M9JfhUA:10 a=VwQbUJbxAAAA:8 a=yPCof4ZbAAAA:8 a=zTysb3kGxGKvEiGebP0A:9 cc=ntf awl=host:13130 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTA0MDA4MSBTYWx0ZWRfX2Fj+8uidabbz VNoPzKjT+dURuS4FXyCd5/Lf5Re0FgO3sw61xcKddQUZPV5P0Nl/WO+6i7CfIghmtMLE/E5owWm 519rnMLa7wZNQitJTXzhzonUEFsASQcoiuQZx5RWRFYbbuHutPk//AAtxP4WDXoQfBnKAnl+6fK +HR4KIb2z5/fmDs0yWwgjNPRPibJxjyxGoNXcV5EO66LhgSdaoZCUvrmn3ARIN5j1s7CCiKbmk4 0fDho9XHwam9RJNFl/emtQ8xE/Re9k49oXGXUBbU4moOVipaNClypdqWhRoj+DvzL+DDykrk15O AwyqedwgEIDAupsO8tE1/mPVB7Xr97EoNmL5cIURigd4jAuLsuQwuwNyY8ipS7i11bsJRD+UiAL r63xKO3AbZ6vsh054NwLlLU5cX2LuzYKrelsUu+5b3nXR2XYcBnqsPzjx+eTdW/RCOae6Ghs Content-Type: text/plain; charset="utf-8" In future we will want to be able to check if specifically HW offload-based atomic writes are possible, so rename xfs_inode_can_atomicwrite() -> xfs_inode_can_hw_atomicwrite(). Reviewed-by: Darrick J. Wong Reviewed-by: Christoph Hellwig [djwong: add an underscore to be consistent with everything else] Signed-off-by: Darrick J. Wong Signed-off-by: John Garry --- fs/xfs/xfs_file.c | 2 +- fs/xfs/xfs_inode.h | 2 +- fs/xfs/xfs_iops.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c index 84f08c976ac4..55bdae44e42a 100644 --- a/fs/xfs/xfs_file.c +++ b/fs/xfs/xfs_file.c @@ -1488,7 +1488,7 @@ xfs_file_open( if (xfs_is_shutdown(XFS_M(inode->i_sb))) return -EIO; file->f_mode |=3D FMODE_NOWAIT | FMODE_CAN_ODIRECT; - if (xfs_inode_can_atomicwrite(XFS_I(inode))) + if (xfs_inode_can_hw_atomic_write(XFS_I(inode))) file->f_mode |=3D FMODE_CAN_ATOMIC_WRITE; return generic_file_open(inode, file); } diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h index eae0159983ca..bdbbff0d8d99 100644 --- a/fs/xfs/xfs_inode.h +++ b/fs/xfs/xfs_inode.h @@ -357,7 +357,7 @@ static inline bool xfs_inode_has_bigrtalloc(const struc= t xfs_inode *ip) (ip)->i_mount->m_rtdev_targp : (ip)->i_mount->m_ddev_targp) =20 static inline bool -xfs_inode_can_atomicwrite( +xfs_inode_can_hw_atomic_write( struct xfs_inode *ip) { struct xfs_mount *mp =3D ip->i_mount; diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c index f0e5d83195df..22432c300fd7 100644 --- a/fs/xfs/xfs_iops.c +++ b/fs/xfs/xfs_iops.c @@ -608,7 +608,7 @@ xfs_report_atomic_write( { unsigned int unit_min =3D 0, unit_max =3D 0; =20 - if (xfs_inode_can_atomicwrite(ip)) + if (xfs_inode_can_hw_atomic_write(ip)) unit_min =3D unit_max =3D ip->i_mount->m_sb.sb_blocksize; generic_fill_statx_atomic_writes(stat, unit_min, unit_max, 0); } --=20 2.31.1 From nobody Fri Dec 19 16:07:40 2025 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39B851991CB; Sun, 4 May 2025 09:02:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349339; cv=fail; b=PELLD4Y4wpyF2edtWQ0vLei0t4E4wq8BrdMzL91frGMw8Y3wgrmNoffkgOcFczbCt1TrrDK5XlMGjKRLL4HdbM6CxHjL4alA0Qs92poziJyB85mm1yBUmob9z11y06nLkMKQUx48YbBWRyyDpevIp1Rp65+/w/hRlXjWLiIUl68= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349339; c=relaxed/simple; bh=dpuRhYi9OfC7iBRjrcGVgkGhbTm91gW1lkdoPJyjpdc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=l9RYlkA8Q1DWXyU4zpUGXQsNfPG928pRP4VcAB/2yME9paWIa1ryEwfWUTar3PJej1UjTlNKI7Om2a9RzNyn+A4sdRiktRa51x+A8Y88sqxlYwi+OBHGzXfrS6qbhKiZe4UnpuIX/mcrYdQ1qC/uBGfsgsL2Rphs47Q2hgieTYE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=SDviCwDb; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=pmHc8rTY; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="SDviCwDb"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="pmHc8rTY" Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5448qV8M010215; Sun, 4 May 2025 09:00:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=keV9W0ffoML03s5DKKU92wyZhPD/Bmw9lCz20VCC4ZY=; b= SDviCwDbI411BVnENPKR3P3zH0NeBnnLzWkGmWiIPVgssp/LKjhJMEHPEU49Ne5M PKtPCTSzgGkH49g3fs3ApxUspLR+febXzxLuKDYHUnrueYonFjDDA9z4j7MwNCam qCBPeCd2eL5M1U+aUxPAWzA9fPQmm8OzAbikqKZmqdUuWfUz9nUMc6s8JZP7Qy1G PfoXZdUAx9Veu/UR/xq1pa5dKo4tjR/2/CRYI6p278mEVcKoMH6mshq1IdtodvlT BEErW9xjLYoQy2gwZdZRFy2JlWMh1VlAsxmMz0nbHbaYSDRVT0P/zeBNo7PPdxnm Vo5TkPIVLa59TnL1Ilh3iw== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 46e53p804k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:06 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5444fLML036209; Sun, 4 May 2025 09:00:05 GMT Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazlp17012054.outbound.protection.outlook.com [40.93.20.54]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 46d9k7ghfj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VLIGgkFT5nYmzaofitBaysC7H8yFDbiL6WannGo4Vl4Fv+4FvdN5NoTz+yw3NFNmGgEs7SaRhHTwOJlaRtueeiQO3k3se2I56OKvfUCXJa8xuwnLYWwIJ2Y/wu+QLLnk2b92yycJG3wnsEjE/mcpy0yMxtuMksFvSKHzLBmhydy+/nmcBcPCBbyp5mYbxsRny2ef4jRv0ytxlX031yt9fykv7E1pIT0nRQsTXtLctCRuFp4pSVx3bo3oDDF6c3YGqo8Me8rvAakLeXtee7KdSFUybBohWNsXi4qeDR3P1WAxJPOCR2nv9xNJ+mJW5LKVPTRrF4kt1Uh2Z9Ff7LX2pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=keV9W0ffoML03s5DKKU92wyZhPD/Bmw9lCz20VCC4ZY=; b=EIRVfEZpAGBjXvsx2XplyGtp0dgZBtz3Cb2070ec/Jmm9Ex5udCIeolDuHC5LStcJEF4vSgHpp5JP8QogYQfJi86Bdq5Rrl8dmi73koqFFkmHyCX+VvlGnbAPXNA33/MvEATeMOzE/4pI8dVIrvqPNnvWaDCcGZ1Ywqbm6hDWMd7Ot2EEmRq08CDjinRO61ETIWIWpuzOgWl+DpHpsHtOmvSp5xfPZ+qFi8+TEe/1JNnmxOphhEUzTkpWwJGp7lnUhcdsIwDX5h/CEF8gCW7j58Q7inOMlMSL5QPMJPSfk7Emd2thky0+8k4oMFsXj9BWp1KdBP0LBxKEsK/F40IHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=keV9W0ffoML03s5DKKU92wyZhPD/Bmw9lCz20VCC4ZY=; b=pmHc8rTYokQtGhYQNJnRx/3vE58GUuOCbCqhT2mDhINsRvdnAGN+sViC8GgAQ9TMKVG4sUXTzeJ/t1GLbHgkES1ASe9G4HnYTi2qRPGw0h/M0hnmjUMcOY4/sVPqRGjnpdEk6cRT1Fd6TMH7qpiKkgfXPTaPzsePw3Fmz6a2q1Q= Received: from DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) by DS7PR10MB7178.namprd10.prod.outlook.com (2603:10b6:8:e1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.23; Sun, 4 May 2025 09:00:03 +0000 Received: from DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088]) by DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088%7]) with mapi id 15.20.8699.022; Sun, 4 May 2025 09:00:03 +0000 From: John Garry To: brauner@kernel.org, djwong@kernel.org, hch@lst.de, viro@zeniv.linux.org.uk, jack@suse.cz, cem@kernel.org Cc: linux-fsdevel@vger.kernel.org, dchinner@redhat.com, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, ojaswin@linux.ibm.com, ritesh.list@gmail.com, martin.petersen@oracle.com, linux-ext4@vger.kernel.org, linux-block@vger.kernel.org, catherine.hoang@oracle.com, linux-api@vger.kernel.org, John Garry Subject: [PATCH v11 06/16] xfs: ignore HW which cannot atomic write a single block Date: Sun, 4 May 2025 08:59:13 +0000 Message-Id: <20250504085923.1895402-7-john.g.garry@oracle.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20250504085923.1895402-1-john.g.garry@oracle.com> References: <20250504085923.1895402-1-john.g.garry@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN2PR05CA0043.namprd05.prod.outlook.com (2603:10b6:208:236::12) To DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB4313:EE_|DS7PR10MB7178:EE_ X-MS-Office365-Filtering-Correlation-Id: 25228e17-6f11-41a1-1bc9-08dd8aea0eb0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?15X/XdBgatdPm7Mk5juGdiL1vhlIpdsqf3uPvTiSD8nWi5VVOuw86c38Y30I?= =?us-ascii?Q?pMJoXQynGFfVygGYZj71DcOXS5k/eufsQKe24PGe/GHM3WUSylAtoMOBOCYV?= =?us-ascii?Q?WZAHwXRK27l2Zt4Oj5/kTsLSrMAfxN08RgpOPtXCqdLLUIX67gwdAYDmXhdW?= =?us-ascii?Q?1aW4fRqS73H1Oa7scmAD7ZjddpPKwL+f4v8r688XZJYzgG3X56mGB4Y0bhNN?= =?us-ascii?Q?IYEUtoigxDqQy4BnqubE+BJ6W2PyYqiroBho5elXkEHubBfQJhF3HqbX4cYw?= =?us-ascii?Q?ov8P0qyLKh2KExC482MNblO5Og8J+liEjcw7Cnm90uETI/R4hvR/Fyan6135?= =?us-ascii?Q?ZQr9A9eP17NDArdcFdGCsl08yaekRMAYrybB9TIxubSpXCxeW4QaefctXHOJ?= =?us-ascii?Q?WNSmDtlru7BMNFtpPpKgZaQA+hUP0VO7ALaSoFt/9gLaZzF4dsldo0Y3b3cG?= =?us-ascii?Q?rulAV+u1aa3ZzxMh7AS11UxErgeqhhRKiZ3OTUNwNAg0Qvvk9M0zjfjSAm+e?= =?us-ascii?Q?GNjyfzn4IE2/CIaDNCR2hV3+nlAxG8buoQ3w46p9nRnmWFY2RxEqQgiDIGxW?= =?us-ascii?Q?nIiCXHZHQD5rFVeybSEvuyRmVmUnPm4A8/U3uSpYZUL0ux1M+PuO0TJLKkx6?= =?us-ascii?Q?UlE6IljJLKEnp4wKRDZ31K3gOCTiYqWDnaRUnk1PB8WtANjaXJcwrQGvixyV?= =?us-ascii?Q?3qmC2LqFy/OOMkKgHshwvF5aPcVQ9aemlquFS4sygPLQ9H1NAOQ360rIrQLp?= =?us-ascii?Q?KC98F5CMtJc3U3f5Vo+RM9OaFFBGvO/RtDTQjYBrLJ2sOnmhO+laSsJGIJG8?= =?us-ascii?Q?wxrvKUfUr6hpqJqYN/dABPD9AqX6LDpfVBsrq6n4+z3J4gxexUBiashitgaD?= =?us-ascii?Q?uJVELWzc0NjComYTrqOya8BlqsxCWLQiDPJ4m0mRioyNAVKBvGx1ceF4gyso?= =?us-ascii?Q?snzi0vbOp9arndMRgh3q5uEZQd9B31AGqltwR07D46HdV4QnxOgdaT8OSoGS?= =?us-ascii?Q?dyrGqP2VuZ4TTGfgeqJyonUUm7/Zc8s/7mbTDOcG8JedL6Srv6z4c7Eb/B82?= =?us-ascii?Q?hJLckbUV1vjzJC+c4tswH4qBk4MEWfO6Q+S1abvlDH/VCQh3HJQsoDOGVgmU?= =?us-ascii?Q?Phpzo5GiFNvO/NCyNw+wGYqZC1Wh2GzdwcsGja23lxFRkK+kR2tXzGS8vAwp?= =?us-ascii?Q?36rNwWp3gvNNKj5sRbYcA9SIKGhZ+8WEMbm2rAn4Q5kXlqceIiwAdjUiLD59?= =?us-ascii?Q?ex1W2CLrXXqn3wqf4pVSfCQ55IYdgcje7PPM8gpTDdgyQruM+Z+4frjcnR0O?= =?us-ascii?Q?2kTjwWHlipzR+jKFszgNKD8mNZfZtSsdP5mXZ4sQVHQkTpYIE1VR55h4QVzR?= =?us-ascii?Q?Rzgple4tuqlzom5ybsaejKfKMN+esMiOmqi6JQzX0Q8aySJHhlPU9Tl39wIK?= =?us-ascii?Q?LZPuuo2gF00=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB4313.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ztuDxFzXib6kf+2rd+rdHKNwB+n2WmkzVz1nmEXdGM7eQg8woj8nOBZdxP+I?= =?us-ascii?Q?C4fGZC8sr/CK+LwAGatL4bqTq1YSzWPepi8RtZx30Hta1IlNxuiBHSZZ6/f1?= =?us-ascii?Q?eeEqSvJCBrcFz7FAvWpd9MiGe9NvoRc2e5B6MBHlk1/T83HAaCTNLRUyP11Z?= =?us-ascii?Q?8ZlW1CEPc/DFM14/4pEQrqZdMS2XXXNTvKLUfWJ8FisBnGs7rq8rX5yRRMCF?= =?us-ascii?Q?shbKI0K4X2njj7QVPZF/s+F5ogxRhfu+RqdPAIAK0rJ+/T44m6B3Z9bvUWcC?= =?us-ascii?Q?EPy1UD7UHHgSVa1gTkULcGs0RbTuSSiKEdY6YR7btZX7HTLwwCBDOcFgc6Xs?= =?us-ascii?Q?uD+ckZlvSW4/aI6as4APTbPN4LcLdY4ftFlmBt0FmOfNisOwVzGQCU3XZGK/?= =?us-ascii?Q?v0AizmZa7X2fqwLFocYinAyPDt4ktkPwqiJ/yNhH++/wNHx8SsZxrqb5rekL?= =?us-ascii?Q?6vDlFhVdEceaU1X4V4L22h5DX3Eav2jYb7EfFkTewuRCC+FluuQxlZWPRWc4?= =?us-ascii?Q?kkDq9k9ZhUi0vcjWG8ukqDJZ/ufNQI5jgEbxDifLwK4sMgppaibeVL9oRo49?= =?us-ascii?Q?FZjLPZQO6xenqcu3hK5DjZ+HYgzGHdqRqbg7v1xdhx1o6Q4u/7x/p3LknipW?= =?us-ascii?Q?pb/4fWPxY8yeTKYaR/+5Ww1rZl4OLHiK6b9Q5DY/nNeByltk/SL0r2UzZ3s1?= =?us-ascii?Q?rxzdfjvVJaaa0RKmo1s1+TcwRbvDOeAl1OwlFns/lqcNja2pJa8FZdeESihy?= =?us-ascii?Q?H7dchgui4uBIkPxclpTxo6jQA89qq1TjFCCroeK5Gz61lL+HsNLXF4sPL1bS?= =?us-ascii?Q?adzzak50ilvEnTlmcAP3qo2m9msXPTrRnTsVnKdp69ZjiPPWDkuCcx5Bp2j6?= =?us-ascii?Q?Y3ognQnW9+ExqtOIbYHzlEd5IRpJFm6W90A99PrK12W4O4nxItFL6bqJChwX?= =?us-ascii?Q?Co9RZRL3tXWu4YcFF1gE3Yvn5ETg1X4McbQrm7DocEzKb6GUsgkrxow1jcKX?= =?us-ascii?Q?8oAXFmi/fHfyQ9pTZ/ZKIMHhnLSWyujxSTMB/0WzMpyOt2sEIltuyj8fdpE7?= =?us-ascii?Q?tBJ0NCttC6BGkzc5GquNgqSFqrBiPT5MPhqf7IyoXELg6kIGe5UuhwlCHRj1?= =?us-ascii?Q?AASV6yYRqXnGf4/8RtD2jWI1NfqiMx0DXKQU4DKRhkCGzcnED2X0LLMsdIs/?= =?us-ascii?Q?9XghfGeIs3/jk939RLbediBXjOeTAd5xbt4DA7ZcD9dLi1ss+zyxcsq7p3/E?= =?us-ascii?Q?VEYVCMpgZr8S8iKspLkEzorn1d4A8gIjSeuYWAomf/ppwfmAMxOHoV7uQo1P?= =?us-ascii?Q?ZvJtFJiGha2ywiCL+b2r/MR+01Y0l13DvUj/nKti5ex8LquS5955UyFx0XbA?= =?us-ascii?Q?QpCGf98QOtY6+8lrksamAwQ6IcFO+gX1sMzZRfmJ3/rPDo6ZUkyGzXQ+3CQu?= =?us-ascii?Q?JlDSFTGg6FBBA0N0BLungZ0P29j4phvAQNxmhXY6bFDLxW5P6j6A/Jj4FTK6?= =?us-ascii?Q?J6MSZluNsnHr96EqU3b4RiO4bvyju5QY0gwPihFS5EMEKka0H/kV4o+qIhur?= =?us-ascii?Q?bjnE7DE/Kl7RWMS6z9nc6xII/FzrdDaFz7XC6irrhR4jHKzrmeJKJuvcQdyQ?= =?us-ascii?Q?rA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 5WVFp0riLL6SEFRoI/8/PcfRDOWDz2dIhTm3YVeeDUY0nEmAYVAqc/v4xJED74/D/HtIgESxbl0pBr/R71WECTqMoVHMsURKroae5MM3ZAxUDJr0QyXo6Q/6FBeIvsZAmG/UohUKf3AkH06Zh3LvunDcMEAZjkTF3EnHOUl6IGlOqwgg4iW9862x9dGPlm0Cb5bKaMSwXlAzX9BC3wnOv0kb6/WqVewvVFPANT7MQ2Dc3LSGCPVcNFTQQBLibrH4pcB3YHdOkHtBxT0jqJr8Sfbk66xibHG7YwR/qjxpzasG5D0o7daceoJ+J+Mh5MqUehznp0yIlL5l8plMpcjfO3rsDF/m0kCuzqyIqKxja5DTTMQ0LPBsZhsTrZYp14DONDrh4ayVaGrI3dbfXDlaSQp2c9li/SEadWM4W/w1PJazaAgKqlTIfUMUZYJgh9biCR7HMOV1W6XnjVRRRqc60ukcC9SbgEPTotLuQ8naEbSvbAcccSxjaDzJypEgFZ4a5rakbRSVv1SbPdMQGGX4XId3Jyp79KDgHPr5sGFHcu+zaDlJmiyHAUkT/F21bpCo7N6vjmYT2I4uUVHXgDMQHDiOXykq0xNuTf7aPtU1kGM= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 25228e17-6f11-41a1-1bc9-08dd8aea0eb0 X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2025 09:00:03.1566 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0RP0u4/CVfSNtpH1WLfMLXrjW5DdUwnCv8krXtVtbEkfoFmWYVYpMY7uaDoS3u4IQSpp0PZ7n/GwyEebS9j0rA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB7178 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-04_03,2025-04-30_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 adultscore=0 phishscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2504070000 definitions=main-2505040081 X-Proofpoint-GUID: hlUJ4WqeLqk8EJt9hwaWifsAYMFy9j3c X-Proofpoint-ORIG-GUID: hlUJ4WqeLqk8EJt9hwaWifsAYMFy9j3c X-Authority-Analysis: v=2.4 cv=eMcTjGp1 c=1 sm=1 tr=0 ts=68172c96 cx=c_pps a=OOZaFjgC48PWsiFpTAqLcw==:117 a=OOZaFjgC48PWsiFpTAqLcw==:17 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=dt9VzEwgFbYA:10 a=GoEa3M9JfhUA:10 a=VwQbUJbxAAAA:8 a=yPCof4ZbAAAA:8 a=Aw58oTtQWaA1gqLR3HAA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTA0MDA4MSBTYWx0ZWRfX2MVYHmrul5j2 xEdJvG0oJEFcd5kjT8ZnaAH1C/6lW4+pj/0KPwwJ2CE1zlNNJ/hWYAfhO+QhGNodb6CwZ/I+ngi AsKGAYAIdDN26Xc06++Rv/6ivE9wjsEDdtJNqWSMNdoy4N5E9Fro4oWPsl5yyxHx/43CBovGCSp JYDPsYPjfD7xqgOVW97xRJ7WB3bEJOI9dq4Lv7jMrJAHqEDRk7w5VG5ssw0nR7yj5aEUTnuUvli 9F7ZbSjOQ3VTkuY7N7BL/7DSkUVeYbd3Rxzo2PYYnTYMrAf64Qfzw/lsaUKOyjNtCj85lIOHkJQ vm9MDw+4dSP9TToQHuHWiu81i4g/KryJrH8t/Ks1d+O4U9bE6MsZ11yRcSzRoe+8Il/Ji0nKpPK OclWC9faFer6Eb8Hus8pHPZweh5ZaNpwUIuAir04dMWXxjQl4IAPOI76L7QFs04/tDGZAH30 Content-Type: text/plain; charset="utf-8" From: "Darrick J. Wong" Currently only HW which can write at least 1x block is supported. For supporting atomic writes > 1x block, a CoW-based method will also be used and this will not be resticted to using HW which can write >=3D 1x block. However for deciding if HW-based atomic writes can be used, we need to start adding checks for write length < HW min, which complicates the code. Indeed, a statx field similar to unit_max_opt should also be added for this minimum, which is undesirable. HW which can only write > 1x blocks would be uncommon and quite weird, so let's just not support it. Signed-off-by: "Darrick J. Wong" Signed-off-by: John Garry Reviewed-by: Christoph Hellwig --- fs/xfs/xfs_buf.c | 44 ++++++++++++++++++++++++++++++++++++-------- fs/xfs/xfs_buf.h | 4 ++-- fs/xfs/xfs_inode.h | 14 ++------------ fs/xfs/xfs_super.c | 6 +++--- 4 files changed, 43 insertions(+), 25 deletions(-) diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c index 292891d6ff69..770dc4ca79e4 100644 --- a/fs/xfs/xfs_buf.c +++ b/fs/xfs/xfs_buf.c @@ -1714,13 +1714,45 @@ xfs_free_buftarg( kfree(btp); } =20 +/* + * Configure this buffer target for hardware-assisted atomic writes if the + * underlying block device supports is congruent with the filesystem geome= try. + */ +static inline void +xfs_configure_buftarg_atomic_writes( + struct xfs_buftarg *btp) +{ + struct xfs_mount *mp =3D btp->bt_mount; + unsigned int min_bytes, max_bytes; + + min_bytes =3D bdev_atomic_write_unit_min_bytes(btp->bt_bdev); + max_bytes =3D bdev_atomic_write_unit_max_bytes(btp->bt_bdev); + + /* + * Ignore atomic write geometry that is nonsense or doesn't even cover + * a single fsblock. + */ + if (min_bytes > max_bytes || + min_bytes > mp->m_sb.sb_blocksize || + max_bytes < mp->m_sb.sb_blocksize) { + min_bytes =3D 0; + max_bytes =3D 0; + } + + btp->bt_bdev_awu_min =3D min_bytes; + btp->bt_bdev_awu_max =3D max_bytes; +} + +/* Configure a buffer target that abstracts a block device. */ int -xfs_setsize_buftarg( +xfs_configure_buftarg( struct xfs_buftarg *btp, unsigned int sectorsize) { int error; =20 + ASSERT(btp->bt_bdev !=3D NULL); + /* Set up metadata sector size info */ btp->bt_meta_sectorsize =3D sectorsize; btp->bt_meta_sectormask =3D sectorsize - 1; @@ -1733,6 +1765,9 @@ xfs_setsize_buftarg( return -EINVAL; } =20 + if (bdev_can_atomic_write(btp->bt_bdev)) + xfs_configure_buftarg_atomic_writes(btp); + return 0; } =20 @@ -1795,13 +1830,6 @@ xfs_alloc_buftarg( btp->bt_daxdev =3D fs_dax_get_by_bdev(btp->bt_bdev, &btp->bt_dax_part_off, mp, ops); =20 - if (bdev_can_atomic_write(btp->bt_bdev)) { - btp->bt_bdev_awu_min =3D bdev_atomic_write_unit_min_bytes( - btp->bt_bdev); - btp->bt_bdev_awu_max =3D bdev_atomic_write_unit_max_bytes( - btp->bt_bdev); - } - /* * When allocating the buftargs we have not yet read the super block and * thus don't know the file system sector size yet. diff --git a/fs/xfs/xfs_buf.h b/fs/xfs/xfs_buf.h index 132210705602..7759fe35d93e 100644 --- a/fs/xfs/xfs_buf.h +++ b/fs/xfs/xfs_buf.h @@ -112,7 +112,7 @@ struct xfs_buftarg { struct percpu_counter bt_readahead_count; struct ratelimit_state bt_ioerror_rl; =20 - /* Atomic write unit values */ + /* Atomic write unit values, bytes */ unsigned int bt_bdev_awu_min; unsigned int bt_bdev_awu_max; =20 @@ -374,7 +374,7 @@ struct xfs_buftarg *xfs_alloc_buftarg(struct xfs_mount = *mp, extern void xfs_free_buftarg(struct xfs_buftarg *); extern void xfs_buftarg_wait(struct xfs_buftarg *); extern void xfs_buftarg_drain(struct xfs_buftarg *); -extern int xfs_setsize_buftarg(struct xfs_buftarg *, unsigned int); +extern int xfs_configure_buftarg(struct xfs_buftarg *, unsigned int); =20 #define xfs_getsize_buftarg(buftarg) block_size((buftarg)->bt_bdev) #define xfs_readonly_buftarg(buftarg) bdev_read_only((buftarg)->bt_bdev) diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h index bdbbff0d8d99..d7e2b902ef5c 100644 --- a/fs/xfs/xfs_inode.h +++ b/fs/xfs/xfs_inode.h @@ -356,19 +356,9 @@ static inline bool xfs_inode_has_bigrtalloc(const stru= ct xfs_inode *ip) (XFS_IS_REALTIME_INODE(ip) ? \ (ip)->i_mount->m_rtdev_targp : (ip)->i_mount->m_ddev_targp) =20 -static inline bool -xfs_inode_can_hw_atomic_write( - struct xfs_inode *ip) +static inline bool xfs_inode_can_hw_atomic_write(const struct xfs_inode *i= p) { - struct xfs_mount *mp =3D ip->i_mount; - struct xfs_buftarg *target =3D xfs_inode_buftarg(ip); - - if (mp->m_sb.sb_blocksize < target->bt_bdev_awu_min) - return false; - if (mp->m_sb.sb_blocksize > target->bt_bdev_awu_max) - return false; - - return true; + return xfs_inode_buftarg(ip)->bt_bdev_awu_max > 0; } =20 /* diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c index 45e188466e51..04e361664710 100644 --- a/fs/xfs/xfs_super.c +++ b/fs/xfs/xfs_super.c @@ -558,7 +558,7 @@ xfs_setup_devices( { int error; =20 - error =3D xfs_setsize_buftarg(mp->m_ddev_targp, mp->m_sb.sb_sectsize); + error =3D xfs_configure_buftarg(mp->m_ddev_targp, mp->m_sb.sb_sectsize); if (error) return error; =20 @@ -567,7 +567,7 @@ xfs_setup_devices( =20 if (xfs_has_sector(mp)) log_sector_size =3D mp->m_sb.sb_logsectsize; - error =3D xfs_setsize_buftarg(mp->m_logdev_targp, + error =3D xfs_configure_buftarg(mp->m_logdev_targp, log_sector_size); if (error) return error; @@ -581,7 +581,7 @@ xfs_setup_devices( } mp->m_rtdev_targp =3D mp->m_ddev_targp; } else if (mp->m_rtname) { - error =3D xfs_setsize_buftarg(mp->m_rtdev_targp, + error =3D xfs_configure_buftarg(mp->m_rtdev_targp, mp->m_sb.sb_sectsize); if (error) return error; --=20 2.31.1 From nobody Fri Dec 19 16:07:40 2025 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EF6018C91F; Sun, 4 May 2025 09:02:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349339; cv=fail; b=bw9tAXXN68hie0Xtc/W7NwzQKwMlo8f+qRQxHsaqT9IOVdF83q1IuSD/Tjz0SnYl6jgynem5v1wuiTiP4GOrF1FO/0VdXD4vaPNAkrbmxUeavW/fUrjjQeKkCUZXKA/2RHZM8UBPgmQgrrOT+qveovlBXFGlSHOk0F7gm/oo3ZE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349339; c=relaxed/simple; bh=ojbL9ETQY9oFRhSdUJ0ncgTmZcoEGxx/N41SjSyeLlM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=PYjKmpgmnAPMv9fQfatS4PXoWvh8pBKcvGovL4oVghlXUO0whjnXMQ8g3uTAQetr5iQmQZhkW9YhVV63FHPHDMfWISuZBC1sQ8TTgLFKwHwu31nvVb3/WEY6beAJeROgmwceryW9ThxwiMTYJjC/WA14Kk18RXXvLiu4fs1SFJQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=Fkdt7nx8; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=bghKNqyG; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="Fkdt7nx8"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="bghKNqyG" Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5448mxsg007178; Sun, 4 May 2025 09:00:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=kZCudiUxfsEHIobBWzcPozzioirBNDfaP6h9ncSziu4=; b= Fkdt7nx83aRa7KS7DGYX+6jLNN3e+Ad/LzWkKM2EE7rn6WV1TO8OvNXMK/hwokHU WKPyuhv5PpETbDzzl1Zk5uDQbWa88umE2fQ4TKd3yE579s6y3Yul3nMzlXntNNy0 C9lxGVM97GX386XXkB5Ahb5MYEviB7mK/qWFedu9AEm9eCeH6lDYju8/HuA3Lqrp UN59Zo8+FomJ6V+mb6yGYgZPuTnTc/b/PXXuCzX9F6SMtPIz/EV6Pdvq5PaC71S7 4misZ570eVM28/H3vtJLFxd2hCudg3gh4Pa63k+V41g4aOaJLYXnxCdyY5JCCrA+ uMHghQY6tffDRKGC5ZnbgA== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 46e51bg081-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:07 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5444fLMM036209; Sun, 4 May 2025 09:00:06 GMT Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazlp17012054.outbound.protection.outlook.com [40.93.20.54]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 46d9k7ghfj-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eXQDgejNUHhK/VnjNHBMdVWmwGk+4fU09n60TiKB1SnhzmQpq0xY70MTtoitXd4T9g/B8Z53pk+cejSnKzPFldqTQZvEPXbLAf4IpFUMQPkUHlBU56TZ/4aclUEg3r7YaU91EguQ4OTwO1w0rmUz5yyJVsR+vlvIt5xqciqm/26jvDbp5VVlGGv9DLBGbuLFSitnKfSFLbty/0/a8A2uP1A+3DXANtl9r09g/f76kBSoMbn3DCHzvZ/XY5fQxInlk1K2RpMXL4xTsItZT2rqLtB62oYyfZAsdAtY87eFolP6px56gu7BRxjw4H2DozJhxTbwOxQ6Lq9YGSmPq87TCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kZCudiUxfsEHIobBWzcPozzioirBNDfaP6h9ncSziu4=; b=frB+WZLrhg6IW/PZYyv88g1i6FzfVsMLAGPS4tDU8omPUpTHCZzkRAlEG++XR5ohNYCCXpKi/y+fD7Ll9wCgChyNHRtjoRGo3o+I1Xa9V0ueyBJ9mrSL2lkClKyOHEx4CKfdwJhOaBgLdg5tHp8tzydrL9JXhCAj67msjgguYvrE5CUFVsbT245X6j/uC7sdUrINNP4nlSjFXK/4oVRfPdFb6a5C+ARrIYh6bI+0BD8HY4yzdd48xwpJPfcDjh6zsRoOUEzvquQHN/cLQ1USWlEuFdw4koIxBE0u4gR13M1YJnR7++GdU3cenempjNZwvCOcqiJ0REd11bWmQ8NAWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kZCudiUxfsEHIobBWzcPozzioirBNDfaP6h9ncSziu4=; b=bghKNqyGh0Nt13YyJSC6Ed/NOBBwYVUIgeRQ8pT33OVdCwj6jJ2C7fHLyi+nwIp9hucm8iQrbZoKs9DeFul7hfbJRZ9rUTap3ZkrHvgj76h1c0cSOgjSp0YDvX8oUaQNbD9A7fWebWLRhz6T1KHwPBSuIgoHOQGX0dQs6rjVIwM= Received: from DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) by DS7PR10MB7178.namprd10.prod.outlook.com (2603:10b6:8:e1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.23; Sun, 4 May 2025 09:00:04 +0000 Received: from DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088]) by DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088%7]) with mapi id 15.20.8699.022; Sun, 4 May 2025 09:00:04 +0000 From: John Garry To: brauner@kernel.org, djwong@kernel.org, hch@lst.de, viro@zeniv.linux.org.uk, jack@suse.cz, cem@kernel.org Cc: linux-fsdevel@vger.kernel.org, dchinner@redhat.com, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, ojaswin@linux.ibm.com, ritesh.list@gmail.com, martin.petersen@oracle.com, linux-ext4@vger.kernel.org, linux-block@vger.kernel.org, catherine.hoang@oracle.com, linux-api@vger.kernel.org, John Garry Subject: [PATCH v11 07/16] xfs: allow block allocator to take an alignment hint Date: Sun, 4 May 2025 08:59:14 +0000 Message-Id: <20250504085923.1895402-8-john.g.garry@oracle.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20250504085923.1895402-1-john.g.garry@oracle.com> References: <20250504085923.1895402-1-john.g.garry@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BN9PR03CA0460.namprd03.prod.outlook.com (2603:10b6:408:139::15) To DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB4313:EE_|DS7PR10MB7178:EE_ X-MS-Office365-Filtering-Correlation-Id: e50c6cce-2d5d-43b9-8915-08dd8aea0f9d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?0+YyLjgcnNVjppirn+VCriiOTK3h2Lgkvl+iBxCzaaXrh9GcsfeytS5TV61i?= =?us-ascii?Q?Kon/3IP+9SW3hZiTMbr1Rkl054X+M1DOK9EkEopcRjitVStc7j7MfYFzWt3Y?= =?us-ascii?Q?kMCbRTLORxkAwwc25bUvgg7VY/vxn8LJAnWDY8DsQdeBJtZBqMWFeYLipYBH?= =?us-ascii?Q?LHcdfGavcTnqgyCXeKVMgnt/zjKq2zAYjpgcPFIrryZaKI9MYnn7rWTc9S+T?= =?us-ascii?Q?DNXJNrYwOdWR/uYBHJPzr94THXqgWzDL0AUYlb5zDSNDO4eo/ZtChKIwISBY?= =?us-ascii?Q?Tn3IJNK7MvD0M/eK3vLP4EYHEOnlbWX4bvCsPzLxbND/B9a0sSmFo46Kuu64?= =?us-ascii?Q?yJNyPqPfpDUwHohEx8VtyXKdC5cmDsFzIF1t/j6haq0F0pxE7L9uiGSOgprC?= =?us-ascii?Q?j4euDR0xAawQIAMEwsIy3/h8CleQHe+94q+kf+AnC4VTF7ED0L7uS7qJNrG7?= =?us-ascii?Q?wi0nwaGXJfO91e1GS+j3MkllDECuvE2ATngqkWL704u7g+RLo0WRoof+E+d7?= =?us-ascii?Q?v5p3r4mOWJ/LY2Tvdd2Ntx1at3VquAQMVvjhtitkDDZ7AkCTWn5n/I6hE7jF?= =?us-ascii?Q?KP9yKV4e2Cd8OVGVAvyO+ZyWqaVX5Vb8QvTaIrJFrXoD2y+EaEr1VuNyzR9X?= =?us-ascii?Q?CFWabNFlh2aCUYJfD6fQKpN12Bi7S30L1a1HPgu21eYSQacqRSIFyrz1p4tu?= =?us-ascii?Q?gTqNuRWqTvIKFvfsIY8YlHXzvZfL861vstp6qRN3qt/Cu/OkpKR+0Y6yviV5?= =?us-ascii?Q?soNKP8OvRWTbnCWm9uwMdOFnJxAGSxCcV7GEot0yo+jdJF9kl9lR7Swmo9E1?= =?us-ascii?Q?IuYGMV+xHtj//QpMoCUqXXCWeGFe2RJeqtGyKL9Gs1R2q//t3NQJ6T0paEe+?= =?us-ascii?Q?fEdlrR7RGq+URFc1YMx0GnRiNFcop7dHhf3JHdJs/dTo+wCdzhotYldK28U2?= =?us-ascii?Q?pFpE8vgVB+PjQYFczZXWW25SGBk63UL2jpwANnJyJeyACvoO4aMuUDC/sOxA?= =?us-ascii?Q?GBq3ZVRMnuk1fbm8SsDtF/VdjDXu/FIU2tAwThnbc3SL3z318mcC/Yt/LPst?= =?us-ascii?Q?AGQfVHcLvZflbWfsJCnSRz6Ml9ZBEo5Vy0rxvPSZbQyPkxo28hkmhLKhMsDd?= =?us-ascii?Q?8riz4swrpoznNKC4OesXICKwQBanpOusiMLud7PnJgI340piAeJ3rZl3B4zJ?= =?us-ascii?Q?aFT0sj76PNOjicmZXK2nUG8j0iP0uZKWn57C6Obg9EYLEVfJBPHi1SrtL4HR?= =?us-ascii?Q?fz499SZUqNUr7HvErVdCnw/3wkPOOZuWsfi8+AqZVE/3MMzQBxAHBaxO5Bu4?= =?us-ascii?Q?h8NpB1skDfcg8F1oZ3uDNNOZ9glweoBdnUF+Nmwb3U1ht1zCUTWQ43Mzheyh?= =?us-ascii?Q?Z72+PqyWf50hl/0IaSFxk/Yd/JyWUxCupJuS/44hr69WwDnphI1DiyW6L03c?= =?us-ascii?Q?GhrALQeUCfY=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB4313.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?laemntYsIcgKSDuWFPPtKODl+2SAChPUcMLv//hw8YLx4bBvejdhrvESEwdA?= =?us-ascii?Q?Ui2bVzhBzupw8WW9ihyhDblUxosLzAG9Ijps0wFSlcptbp35g9OZvjqJbDhO?= =?us-ascii?Q?rz+Nn/mk6Mr59fVJhB0AAye4qFXu717Z/WKKfC906CnparADaNSmBMjIprzB?= =?us-ascii?Q?YVDuBiTICVXLaExBQcy4G5OgMzHYmYMOayJYNWBdzleSLnnFWk3vyD/zoPtB?= =?us-ascii?Q?2K+1ekJ7QcakPQdRGVrqr7CXRc9jlbR1as2UE2pxGCwoM2Iux3W9MfPGyB7+?= =?us-ascii?Q?qGvOyJU8ESRwgPN6Um7jJrq7g1MpbMVj/yAnWNMmvLm/WGvbeQ0Kz3NBGT9n?= =?us-ascii?Q?k1tzt8NqUbLIvujaIVlsEPbVClbZ88pGFgMdT+DisHWwBxnIDid6D8ac0+6d?= =?us-ascii?Q?2rO0PPBw0ip6xOJntGMi46ODZUoBZeqy4NvvdH9FrjWsoDL4s8oL+66ybunj?= =?us-ascii?Q?XlCFDXzVXfaqM9yvy5oe2iQSwHev44nDGWjYoZGv4PsacvKRaAzbb7Q8XbID?= =?us-ascii?Q?ZJTODCtMJteBRug1i6f39JI3e5kXoN6Z5SdICsNbMFQNGBA9yzKpzEiL78AM?= =?us-ascii?Q?xv7OXHVEeB/4jNxsY4LCFqZspm4POF2hZZHKRIKSuMVzfEW2KEztUxwgm94L?= =?us-ascii?Q?VcwrPd05eHqf2Hzlon0E1/gtWIo7IjUKmnTMbjl0TIfJo7m05eX2bOBDTmNP?= =?us-ascii?Q?tuMk4sCBEfRSmrKmy5fgyFO9Ot9NUk/SaYDn4dpW/gCbPLr6GqAYdD2XoehF?= =?us-ascii?Q?REYrBPM23LvZUcInCzpcIC+3tijloyCGZ3ogtJKX1DmseoZfr/oFMdq9vBqy?= =?us-ascii?Q?BST7X5Py9Sex2UsQl+SS2nkN51dRnrv8l1af1wx1p2X1tZtacdeQqfTiB+/K?= =?us-ascii?Q?AssTwcq+Ywi8QaqqIz4G+C3xSKikgXKCYGio9ezUh+Tf9CD+LFDhP02feb2t?= =?us-ascii?Q?9oEBZNNG/Rql8ecVtuZZ6VxmP7DI4W4oULTqv2ucNbJ+tB2exoQtZ+6Z+Om5?= =?us-ascii?Q?EIZkBZLE3Ixm5sSGX9JdBYy4gCdyVOYhOibcxBUj25KnqSbr5ou/Y8AD7xCD?= =?us-ascii?Q?OGls6zOr1THRvqxRem6yVelWp1qoL+19sSLHdXkJwO7JDBDSJNYu4D1oOInG?= =?us-ascii?Q?OYPgsO8QyJeTbt+i/RQHZxjrpxEc96+Jf7/6ZKGGPrc/NeK4An1w5NFmXMBN?= =?us-ascii?Q?qi9FYNZHEkUbvnYjfrJdj6XId64ZvSk2hY0hXyblLWMZKXr6TSVwhH69T8xX?= =?us-ascii?Q?YZBLagRksk/pqXXT+NcRaSXhZ1JwJURxX6RizAkRq80UoGEuRCpHWsIBsXHA?= =?us-ascii?Q?OcKhLDQwXkDww049ZhMDB3Gl6MjiNUDqBeSXU5S+4fAzLmFO8dLLnTRIzT6K?= =?us-ascii?Q?v+SSgO1mmyEQRw0pLbQ8nfUjNsLYXb3ohObNmprYA1IP9ugYXaKL8W8FAgPk?= =?us-ascii?Q?YD88UcvDe7/pMiZ0hGU6RS5CzUYY4Zgg/kMhBVkJFzDglbIFm4q1pFWe2Z6V?= =?us-ascii?Q?BayoZwhEOdQImW4E7PIvN6ff2wd0k/C9fwQZ3BJX+SDrxNf7ptppvug7CgN6?= =?us-ascii?Q?7okPV1v8gjQmCZXJXiG1+a1nWKOUafjXKdhRl/r/VWnenxaDqWsWSvqlhK07?= =?us-ascii?Q?lQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 2XlNVow95v/EWCOQU+VnvqjZ4W88UxgV2PNrb8IihZZq4EuazD4KuAxBEyf5kvBF47OsE38UDPL8n9PD1L3AESYMTuvz/yaVzPAEKNQLcsfsD/ugpMVDWIoOuekzQrQdXI+zWKCn/ggk1R/a/R0UlDBSJguw8RwZrJ+MEni19af+kMhy1xM7msVquL51NgmRR6rQOtKZNZArDm8lznj9Fl4gNQSqz3NVXrjB0lEChRvQovrai2ds5uFj55ZZH9nxc6QA6Mpof3gBRmtV5CZKvYUwUajNreFZ0FBZH8fal3JH6gMOvt5EJOz/Iz1y7ts2MLIV5LwtTwGfcmgusB9IAMdM5SjJj7FvJcsM2pzsgIhPdhEcEdVeFAKj6c7PSgp1EwwlbHDVbOUskEn1lB0Z+J6BcXHsvmR5G4xFcxhak0BF8iYLw/hSlIpnx8hCgxRcHtrhWp33N2DQQ5VFlodxEeL0NAY/8lDFy1e7imB/mRXx5SxjlN6KL3JpKXF4XNtpaHiv/uQarXXR2KzyKYruci65SHGbcnTqmDYWGpz4LcWc9BisLUALa1Ct/vuKOPOt07/llW3vHwhC4CNtUZ21ZqmNVij2zPHDQjGAItut93o= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e50c6cce-2d5d-43b9-8915-08dd8aea0f9d X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2025 09:00:04.7010 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cpEZfieKKch7DpHISaIsBsb6MwL3zERKuDszG6lM7cM2fiwtmMiWsxIHKcfGfWzBvGkKoUrzjGVU4O44rtLQ2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB7178 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-04_03,2025-04-30_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 adultscore=0 phishscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2504070000 definitions=main-2505040081 X-Authority-Analysis: v=2.4 cv=C8LpyRP+ c=1 sm=1 tr=0 ts=68172c97 cx=c_pps a=OOZaFjgC48PWsiFpTAqLcw==:117 a=OOZaFjgC48PWsiFpTAqLcw==:17 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=dt9VzEwgFbYA:10 a=GoEa3M9JfhUA:10 a=VwQbUJbxAAAA:8 a=yPCof4ZbAAAA:8 a=BdfLSKS78uDQwj0SyGAA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTA0MDA4MSBTYWx0ZWRfX3RL1fVj9mf7B rpT0voIFERXtt+W+8sjE86ouztpg2YSpFh/fqZ9VWcMbAKHT7caOPS9MjsX5JTBmUpr91e4iBnb JfjSwDa3MjyIRezCprLWng+QysQ/lmwLo/w0sRlPuqjrEw9B0BO1EbF2vF8cQNrQRMaZ6CTcmQG FflFpe1Eb4kgBflbO0ujMpkpdKMm3iUXkfD0c6N4NeGjH9naFCs+s8A78dcYQGRdDS59g1MoaqM 0IEyzNWWHBPXaDA4iIVg/Ewthcjwpr9BJyV4Ut7lkk0A1NgHoX7Ez5C0Uw/sIlPpli47FNVG21/ f2eB12QBhV+d9BihzvvHyU4n8GjAaG7a+4acbppWT5UIXJTTZye/DaEHfC5v8rqAOW+fSEsyKk0 ZMbKtkwDgCeCoJzXv7Hjqo+iWK1ZMT3Yun0nIFet3BjWWYYbp0TkrFJt04oezLC5aZlf7MUW X-Proofpoint-ORIG-GUID: F6RT-MsXx_m0bg_NSRTFBlTx_Z4rlXIC X-Proofpoint-GUID: F6RT-MsXx_m0bg_NSRTFBlTx_Z4rlXIC Content-Type: text/plain; charset="utf-8" Add a BMAPI flag to provide a hint to the block allocator to align extents according to the extszhint. This will be useful for atomic writes to ensure that we are not being allocated extents which are not suitable (for atomic writes). Reviewed-by: Darrick J. Wong Reviewed-by: Christoph Hellwig Signed-off-by: Darrick J. Wong Signed-off-by: John Garry --- fs/xfs/libxfs/xfs_bmap.c | 5 +++++ fs/xfs/libxfs/xfs_bmap.h | 6 +++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c index 63255820b58a..d954f9b8071f 100644 --- a/fs/xfs/libxfs/xfs_bmap.c +++ b/fs/xfs/libxfs/xfs_bmap.c @@ -3312,6 +3312,11 @@ xfs_bmap_compute_alignments( align =3D xfs_get_cowextsz_hint(ap->ip); else if (ap->datatype & XFS_ALLOC_USERDATA) align =3D xfs_get_extsz_hint(ap->ip); + + /* Try to align start block to any minimum allocation alignment */ + if (align > 1 && (ap->flags & XFS_BMAPI_EXTSZALIGN)) + args->alignment =3D align; + if (align) { if (xfs_bmap_extsize_align(mp, &ap->got, &ap->prev, align, 0, ap->eof, 0, ap->conv, &ap->offset, diff --git a/fs/xfs/libxfs/xfs_bmap.h b/fs/xfs/libxfs/xfs_bmap.h index b4d9c6e0f3f9..d5f2729305fa 100644 --- a/fs/xfs/libxfs/xfs_bmap.h +++ b/fs/xfs/libxfs/xfs_bmap.h @@ -87,6 +87,9 @@ struct xfs_bmalloca { /* Do not update the rmap btree. Used for reconstructing bmbt from rmapbt= . */ #define XFS_BMAPI_NORMAP (1u << 10) =20 +/* Try to align allocations to the extent size hint */ +#define XFS_BMAPI_EXTSZALIGN (1u << 11) + #define XFS_BMAPI_FLAGS \ { XFS_BMAPI_ENTIRE, "ENTIRE" }, \ { XFS_BMAPI_METADATA, "METADATA" }, \ @@ -98,7 +101,8 @@ struct xfs_bmalloca { { XFS_BMAPI_REMAP, "REMAP" }, \ { XFS_BMAPI_COWFORK, "COWFORK" }, \ { XFS_BMAPI_NODISCARD, "NODISCARD" }, \ - { XFS_BMAPI_NORMAP, "NORMAP" } + { XFS_BMAPI_NORMAP, "NORMAP" },\ + { XFS_BMAPI_EXTSZALIGN, "EXTSZALIGN" } =20 =20 static inline int xfs_bmapi_aflag(int w) --=20 2.31.1 From nobody Fri Dec 19 16:07:40 2025 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E9761A00ED; Sun, 4 May 2025 09:00:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349224; cv=fail; b=Phtr8Du2DHdyF8DuA+ELmtzmaUhYN5ekFgBYAmbgpjtD0usqHKBZ6BDH5nfRIsjxqf6tlIDXY1QoKnCSjqXCwwwmIM/S/zt7v1BYpr6ZCHygWrQA9MQrg1Fku2lTeMpY5AaGDvOHYgb9Qw9VJpL5KG1+I6wnho5Feh+GOvXNrj0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349224; c=relaxed/simple; bh=bao8ro5jB2y+yAP3hljkJAZmi18dQqmKw3XotU1xy8Y=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=QztBS4glGYrG3g20GCYdd/aaH+T5/kUghBghaDKqikzeks8aLMIpbeDrsYV0SBWZpj4LLcLgzWtAKo9Wj+2H0E87uOLaDXq4KdAVO/0dXcZ+XsN8jl1Qiol+B07XXqiJPYKU4grWlB8LiUa+CwBeeR+8RWziCslj++TkfC50nug= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=Pzu1uJIt; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=B44BTpZu; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="Pzu1uJIt"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="B44BTpZu" Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54480wZj004059; Sun, 4 May 2025 09:00:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=5QDj8Rz5l/t++iluDX5lk+BX2LQlZEDF6iZSgvNbB6E=; b= Pzu1uJIte1dXogHLgwUV9YJMamMCpbE/IceONgK2vjRb66toA0OHiCfmU2jpFanq 41ftuHOYjHMucxII+Qt2H2DMKzbdJezCwAHsN5LqHGZdTjRz2dOYCTQQ3YYyRno3 EWyuF1g2ISAl+jWMPYa6rY+ON38ly5obOa5Dg8/JZur96kaiicDmck/mfFZ2LO36 rWMe3/5AI3UTJrypmcqmDwE5ck9Wwhfv68QvD/9TK6N+bu512PSamsDJN1+naMpU fYAwml7rCEAiZL9bvaSbjaxtLh5P9B+tXuFKy1068ueO4CIlC89fuZfJqJAlnqmI /gv86DEtoYcGrcd36FSw5g== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 46e3smg2sg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:09 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 54465cW0035553; Sun, 4 May 2025 09:00:08 GMT Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazlp17012053.outbound.protection.outlook.com [40.93.20.53]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 46d9kd0776-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PpU53sDhS8OCLTeAySpLoXdWn6BmNY81pATIuUW5+1xG4jA5r/5g3bX1D7Jy/A5GpxwLcVTXQWVDjMns6vY5AVXf5HgzjcaBjpgECe+0Tpqcz3HquNUX2jJbuXpgOIwsth/aFYEYaboVLtupRATmWF6iLN9gcaAFXj8w4B9OMNmzT+iOewqhbb/ir1zKNTLY70WMKMOq7KUJJlah/6+YstQ+ezQ0oIxzdhl5K+tsONpScsOf878akmgkpdt8amh/0SHnEX6uoLQ8+McLkpM7dp0+bevNvxnDRijBIxxZFsvGFepQBvFFxVRmEZ+LKbafT6MAjK+fFnZDXWr5jo6V2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5QDj8Rz5l/t++iluDX5lk+BX2LQlZEDF6iZSgvNbB6E=; b=sq60ce/btD58W0qtkdyD9QNjwZyMB4AkB79RB5K0aEORGpgyP9KX9sjuO0LBbjpZjnlhKcNZRP2csj5o8BVAnT4G845lUUvjLflYbuSm+o9jqniaDd4eQSFGayAgiXs4XBPOYJmbv5LszIalGKE7FhwI4SY/PhYJ1jSg/1LxvQALZLhoHAWvTu/g+gV/SC9gG1PxnLIloeMwFX7OYyBRkLx4gwuxQ0XAdcVSkvHnijYh7FSkGdisrvIqJJi6yOSG9oQyV0ZymXu8AEoKdVSV/AlmBPgyZ6SOiukyibABbu3NB/pLIiGNr9H+j7gzFm2D6zvDsCpOrB+uj1kAE0dkdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5QDj8Rz5l/t++iluDX5lk+BX2LQlZEDF6iZSgvNbB6E=; b=B44BTpZuwGmURQLmgFXV7ZKUsCFlc0qbROqNb3fX8/uDDgDO8mgLoKr3Xa5Zl1DIMyqRrFFixBIm7tKVnwStnWu9+UnMmQjAJXrkiFisPPyHhpkTmdCN6V5Q+oj/Kop4x2iMmz7Dd6zkI/JudTr2xPM+JzSjHQDTrytP+zQcIFM= Received: from DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) by DS7PR10MB7178.namprd10.prod.outlook.com (2603:10b6:8:e1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.23; Sun, 4 May 2025 09:00:06 +0000 Received: from DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088]) by DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088%7]) with mapi id 15.20.8699.022; Sun, 4 May 2025 09:00:06 +0000 From: John Garry To: brauner@kernel.org, djwong@kernel.org, hch@lst.de, viro@zeniv.linux.org.uk, jack@suse.cz, cem@kernel.org Cc: linux-fsdevel@vger.kernel.org, dchinner@redhat.com, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, ojaswin@linux.ibm.com, ritesh.list@gmail.com, martin.petersen@oracle.com, linux-ext4@vger.kernel.org, linux-block@vger.kernel.org, catherine.hoang@oracle.com, linux-api@vger.kernel.org, John Garry Subject: [PATCH v11 08/16] xfs: refactor xfs_reflink_end_cow_extent() Date: Sun, 4 May 2025 08:59:15 +0000 Message-Id: <20250504085923.1895402-9-john.g.garry@oracle.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20250504085923.1895402-1-john.g.garry@oracle.com> References: <20250504085923.1895402-1-john.g.garry@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BN9PR03CA0465.namprd03.prod.outlook.com (2603:10b6:408:139::20) To DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB4313:EE_|DS7PR10MB7178:EE_ X-MS-Office365-Filtering-Correlation-Id: 599157ed-554c-4119-4bd1-08dd8aea1068 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?IQiGYG+8p1AymN3MlMD3mDfwYP1b+UpKDqNnDsERD+zZBY2CJYruRHsgvrD+?= =?us-ascii?Q?vc9DXkXEVkBE+SMq8R7DEaslIl4MNg1nmd7jqhJyXdB5E6dnijisCOmn+RH8?= =?us-ascii?Q?PlRMN5oNCkcc1ma3o3KJRONeB/DIH3kcCYSQdTwa8J+4EEd8HhSxFeAj9yZ+?= =?us-ascii?Q?FTjZ5Vsa7vcm6OtySDHUxMr5FzJle9Cye+qcNJuKrmyieotG4A8zeOHMRIPl?= =?us-ascii?Q?XMuJbx09M4Ij2sth1hC/7snJkcRCjOweSS9Dk3A8O3S5GjHgkBEDMuvFhWx7?= =?us-ascii?Q?HL0lNrxJSihnPcUol7IgKuKWeehXNbszWFF90qy78khQJCp9CgQW2cLJ5ET1?= =?us-ascii?Q?WNz4IZPJs3W05IKqLQAOe/E16zy0wmNcUQ5PuQgtL2emGD7fcozM3VarQamM?= =?us-ascii?Q?m4kYHlaCUoQoaoxbkouWsvHybbdCImmoN2iDrFJZExA2iVCtcuCp0x+jwUbe?= =?us-ascii?Q?urLY7CPkPhoElIDAEDUJK0JNVpFOfkkWykDkW01GIdCayZQXThyX3/swbMmV?= =?us-ascii?Q?c9YAGrHBwtR5tfFMzLDRD9/h4qSWdHNH+q9/SxEin8vcMOY295eirEPj7SE2?= =?us-ascii?Q?a4e3G5E+6S3BXIAXpb+hWTL2fhgVp3o/AhI7Qipx3rHBlqhSA7EnjebQc1q3?= =?us-ascii?Q?UfPIU/JTvl6BRpx6Ca0WmrbU4jPtVHifXF6f9GznLgLALsSSnXY9tryxsvOB?= =?us-ascii?Q?Fch5gRIqhEv882xpN+wOnjj7UW5eTPHvuJ8PDBmNP3hEKfQznvy8jw7E8W/X?= =?us-ascii?Q?6MCrGvN3s5TosMSwbyoWOtinf1/DhgB29vAmBC0/0FW59XzlBQpCNpNU2OPP?= =?us-ascii?Q?+rJynDyein+aSm8eyfFjzkYhWR15ozDn8EgGCFBOcjlj90Wh7XXlQ4TWSWGN?= =?us-ascii?Q?hY/mpnuDd1lgxDKuz5uH/QFSPaErQI38b5RnUgOIpTC6DLeHL/AwaLBOXJY7?= =?us-ascii?Q?wtnm4F/g78h3hxoHEttpYvRNl6W25Xo1oOm5LV3u/Q2chlw9vCy9jjrnozEp?= =?us-ascii?Q?KQnwQqEjbJbphrrZIv2gFO+u4uM5oWOTGFtytQ23pylFRh5cgKHQX8uye51w?= =?us-ascii?Q?9G/uqvVJzfo6lavgILs2A4rUj4c46YcPLP6EFRF+R2qUPdnmlV/emuDACf3U?= =?us-ascii?Q?4e9mGyi/ZWsb262vBVWu/3RFRYj6o7Bka85sYUdiEL8BR9dM76ZeEoD1InnI?= =?us-ascii?Q?MlapvuN7P4FJBNIdTcG/iOCVsNrEAvlynTqASbnPrsbRp5bgxDnURhEv8gRV?= =?us-ascii?Q?hNVF2clw8lJWkQpo+tkt0mBUB9vcW6Xw1qjWXGneheUTutZG6GEycpNq87bv?= =?us-ascii?Q?raSHjTtJ+F0TTqdJ9oAcvPIYMgqf/BbdxVrSPSi7gIbvXFZ3XtW4DvXkXXnY?= =?us-ascii?Q?9gmhrtMLdDwVp1n4kc5OgwKCNmlME0e76d6g550yDeJ55iN0WPhky2PBRuzB?= =?us-ascii?Q?gDFv54GD1PI=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB4313.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pc3hHdrSm5RBi3oOt6H+g1xxB2TG9p2zyVV+jyU3heWT3I394GeohNIRGkeN?= =?us-ascii?Q?VTt14krzNyQW0EppK7GwhTqZBQrrO6KGwEqG48ZRw7ymN+b4nQmXgxjwnHKE?= =?us-ascii?Q?OJk73KXbAnxcv3gXGPGNDIzL5smuILGCYZkYItHpNb9fTchOBHx+2apOymro?= =?us-ascii?Q?7ku40EPBDeaPNTx7y7CFzUFlcOiuRD4y4ZdondrSeW65+T1me7/r8bKknHoz?= =?us-ascii?Q?zY/9u6O7F8WjzzFLD3i1tNwMzYe3GOvl6HK8tdhfcLqpUcH+WG/G3yB6UzAk?= =?us-ascii?Q?AaIYYp8m25vCcE7fNzI/7XJrN5LJjO35u4ltgWCCuZlqcC94jBGoYMLUQn08?= =?us-ascii?Q?ztZkfXxqjgspvluyo9fT13IyhawA+rxqlgOKjQ5txwjFheIMxVM2KN4Wv2Aa?= =?us-ascii?Q?TvcCEAQzdN3smfEWC8yoRB1Ks6ap5oH0SoDNBlqodfyGrbvwaM+/awSJAf3q?= =?us-ascii?Q?3kNc+CVv/HpV1ZBw4Db68p6cA2XMFseL65Hpqkg09BP2rSpf5aPl/wB65vBL?= =?us-ascii?Q?QP4lfu75JfGnOg0gcFUtFWWVI6Z6NhGiVhy89VBWlXtzPCWc5eutNtiiafc5?= =?us-ascii?Q?cjCmxeoyzlgDt6lnrqa/b9PS+jAM0R6/+wuKStNDMGeL2Xd7YMrZ92hlpB2H?= =?us-ascii?Q?xVAzwFWT8x5V73MyZl4QY3vWqhjnDuLCmdZPXzKYyfm3o/yNDSeGmxwr3Rbg?= =?us-ascii?Q?dtyKwJk45RbPtl7jGp3imihsBaSRJMi89FWHRQXWqu/Vy5CCQtVvCrTYtI0B?= =?us-ascii?Q?t7P8zHz+quztzqG081DzYyCXeStd6blY/wSqR7lNdQzK4JtxPNeKsySqfkLV?= =?us-ascii?Q?QSAr2IVzagdL+5huxzGdvALrGcgx0zCfumDPCCu0Ne65LoiUVt0nCPQ557UT?= =?us-ascii?Q?BzAPCQxmFnU6VCcLn9zndxSpBkDy9mv92MKeNtPLylw3IV6Xkv02oLRjwYKa?= =?us-ascii?Q?pUNSaXC6hFVGuRntF0sYs/PpxxUlyy969lj/fxg00dMdDo+BfMUoxOXyGPAa?= =?us-ascii?Q?q8FJPMgxGOda4CEvo/kNyBIKdndqM+EVVoCiSkxDgqUs/KTSAK//1heJKYU3?= =?us-ascii?Q?TV0/5jxJEqu+jU3ikYqXqQLt0RZKzY9gh5KfZBLsslcwYF36BXlkEKZEm/6K?= =?us-ascii?Q?MJxA1Bh01q52K2gsjJr+kUiXwwQuldib/LFOva9K4gMec77R7uCNk+1FIlx1?= =?us-ascii?Q?FQppaB8SFcvn7lDT5T7NxQUFh6M89CMG6tGmlYKKMJK/eSxG6vz2dyxIqu/q?= =?us-ascii?Q?oo4FGq1j7boMC30eDeiJsmRVWd+xUb2QMVI0Zy0pBvOVKK4Kig6AbJZbl8mJ?= =?us-ascii?Q?/wy1i1B49Wv6zkRVfiMjLyfFJYYR0OzrNts/5ImIVD+uNMr0K+/N0Q9c0OEm?= =?us-ascii?Q?FKnHHVBVgknh0s23Ls1XdnpuVr+iIePJ0eVdyQyv0X8T2BqLbl0QKIX+VgNF?= =?us-ascii?Q?HZwDPJnwiJRTEsV8h7fFMWL0R5/qN5+Pce7+nqx8dhF6HrLUOrwaFbu4phuc?= =?us-ascii?Q?4SEkR0R366tUeGV5LcxO9rCL3YkcBCjlcxLedfJyk4xJ4INFu+XdXmJ9Y6LA?= =?us-ascii?Q?3yLiUxCqXgWzZg4tDmOa8G/M6XkgSNy4TaJjnVwzOmA58Z1s3jC6kz0B+wJf?= =?us-ascii?Q?Bg=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ZDQ4UPvAFNB1cKqwDWyvT6F2lifaWBAAtHRd5czkyLe6uY/CeiGX+UWc93X8j8RsZibiXJmhospOmtnp5rkrGYJyylabyIHnMdfnB1Xjuvzov82iRpWEXa5ebmoyECC2isgm1mi010JxZGOE9v8PEL0aTp5ZVnSuipxUqnT1ajRZoL+JrQWqESMz+c0DHYAdFxX+MLBifmKOM1GTL5DfFToGFL14m9Ji+FEwDADQxmejDbBueWYQk1uIDEeFhkVKTclUSNHFchgL72WXo4Buvk3g0nKJyae32S2OzPOn2YQY9Q9JXl5MbERfKq1BNRLIDi7l9x/TSDDCFSpL5tnUi+/NdkJg81tjGPiUEao79ZNfVFBlUWhC208sHpzuVU+/HC8nA5kJfIoKtpmkewIhYR3frAxNnqoFnNkbtU4uvYT7pFZhTN0oOArVIFLEW1xgMZ5EqmvzYGdcdlXzp6bue7Qdrkq3+H6enmlm/4fu00yhZEIcKVPJKSeIhxXZuusdLru9G5OFUSjijW91ERRZPWcdvzhXxUsNSIFGt8zjPrCdGGdCvYLx8WYvJ/Dwo6qqlNjFJnSSS+IccVP7VOmqsrGSUko0zy5FUhjGLXQ6FlQ= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 599157ed-554c-4119-4bd1-08dd8aea1068 X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2025 09:00:05.9818 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cEpk4+xUWya5Gdg5q+2+sr+SM2gCsmpj30gY2bEvMqfVqnt/3YCcCjA8csSQhG+oTaC69kAGE5Byi0zXpPNVBg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB7178 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-04_03,2025-04-30_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 suspectscore=0 malwarescore=0 mlxscore=0 spamscore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2504070000 definitions=main-2505040081 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTA0MDA4MSBTYWx0ZWRfX9hafsmpO999G dsMy+BvHnygc+sp59dt+KQ4hFJqyVwqlPHvEE8ea6EtwNyuTCZ3nVbOpqYnHoRFf/cgjFSj+0Ym NqKBiNCRjrfCEK3uYvza0u7A48zlN9DylLxbm9yaBwlFfxfjUYSeSrA2NkE3fpyvDDZtorrcfIQ RhZYEHJZVrgm3T441sit0qxcLHbELpHC3w6zoQzdO27vo+o32AlqSrbTNuqg7xst8tLrU8qHv52 YdK6gUSxqcm7mh/pyblm/td6YG6BkZMezJbgP/ATrVv+qFO32275iVCv+ug71phr1+eX7Fq6O3+ Og+ylWBWO10or7sZK0N7qGF2UFBDIFEzN25D2lSRQO7V+XOhqqpwjs/I0676ld8+FMUT3qfTrO1 Ff7a23hZyw7c1UaL01xigupZyL8zCEdpVZEbcnXlosbuPRR+iqKj3oB9GGxI7RtT3u2twU9G X-Proofpoint-ORIG-GUID: nDJZud57FYkk9Hj6AbkLq2StrPa1IT0n X-Proofpoint-GUID: nDJZud57FYkk9Hj6AbkLq2StrPa1IT0n X-Authority-Analysis: v=2.4 cv=bNgWIO+Z c=1 sm=1 tr=0 ts=68172c9a b=1 cx=c_pps a=qoll8+KPOyaMroiJ2sR5sw==:117 a=qoll8+KPOyaMroiJ2sR5sw==:17 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=dt9VzEwgFbYA:10 a=GoEa3M9JfhUA:10 a=VwQbUJbxAAAA:8 a=yPCof4ZbAAAA:8 a=zPHwHgG4P_mrsmFPOIUA:9 cc=ntf awl=host:13130 Content-Type: text/plain; charset="utf-8" Refactor xfs_reflink_end_cow_extent() into separate parts which process the CoW range and commit the transaction. This refactoring will be used in future for when it is required to commit a range of extents as a single transaction, similar to how it was done pre-commit d6f215f359637. Reviewed-by: Darrick J. Wong Reviewed-by: Christoph Hellwig Signed-off-by: Darrick J. Wong Signed-off-by: John Garry --- fs/xfs/xfs_reflink.c | 72 ++++++++++++++++++++++++++------------------ 1 file changed, 42 insertions(+), 30 deletions(-) diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c index cc3b4df88110..bd711c5bb6bb 100644 --- a/fs/xfs/xfs_reflink.c +++ b/fs/xfs/xfs_reflink.c @@ -786,35 +786,19 @@ xfs_reflink_update_quota( * requirements as low as possible. */ STATIC int -xfs_reflink_end_cow_extent( +xfs_reflink_end_cow_extent_locked( + struct xfs_trans *tp, struct xfs_inode *ip, xfs_fileoff_t *offset_fsb, xfs_fileoff_t end_fsb) { struct xfs_iext_cursor icur; struct xfs_bmbt_irec got, del, data; - struct xfs_mount *mp =3D ip->i_mount; - struct xfs_trans *tp; struct xfs_ifork *ifp =3D xfs_ifork_ptr(ip, XFS_COW_FORK); - unsigned int resblks; int nmaps; bool isrt =3D XFS_IS_REALTIME_INODE(ip); int error; =20 - resblks =3D XFS_EXTENTADD_SPACE_RES(mp, XFS_DATA_FORK); - error =3D xfs_trans_alloc(mp, &M_RES(mp)->tr_write, resblks, 0, - XFS_TRANS_RESERVE, &tp); - if (error) - return error; - - /* - * Lock the inode. We have to ijoin without automatic unlock because - * the lead transaction is the refcountbt record deletion; the data - * fork update follows as a deferred log item. - */ - xfs_ilock(ip, XFS_ILOCK_EXCL); - xfs_trans_ijoin(tp, ip, 0); - /* * In case of racing, overlapping AIO writes no COW extents might be * left by the time I/O completes for the loser of the race. In that @@ -823,7 +807,7 @@ xfs_reflink_end_cow_extent( if (!xfs_iext_lookup_extent(ip, ifp, *offset_fsb, &icur, &got) || got.br_startoff >=3D end_fsb) { *offset_fsb =3D end_fsb; - goto out_cancel; + return 0; } =20 /* @@ -837,7 +821,7 @@ xfs_reflink_end_cow_extent( if (!xfs_iext_next_extent(ifp, &icur, &got) || got.br_startoff >=3D end_fsb) { *offset_fsb =3D end_fsb; - goto out_cancel; + return 0; } } del =3D got; @@ -846,14 +830,14 @@ xfs_reflink_end_cow_extent( error =3D xfs_iext_count_extend(tp, ip, XFS_DATA_FORK, XFS_IEXT_REFLINK_END_COW_CNT); if (error) - goto out_cancel; + return error; =20 /* Grab the corresponding mapping in the data fork. */ nmaps =3D 1; error =3D xfs_bmapi_read(ip, del.br_startoff, del.br_blockcount, &data, &nmaps, 0); if (error) - goto out_cancel; + return error; =20 /* We can only remap the smaller of the two extent sizes. */ data.br_blockcount =3D min(data.br_blockcount, del.br_blockcount); @@ -882,7 +866,7 @@ xfs_reflink_end_cow_extent( error =3D xfs_bunmapi(NULL, ip, data.br_startoff, data.br_blockcount, 0, 1, &done); if (error) - goto out_cancel; + return error; ASSERT(done); } =20 @@ -899,17 +883,45 @@ xfs_reflink_end_cow_extent( /* Remove the mapping from the CoW fork. */ xfs_bmap_del_extent_cow(ip, &icur, &got, &del); =20 - error =3D xfs_trans_commit(tp); - xfs_iunlock(ip, XFS_ILOCK_EXCL); - if (error) - return error; - /* Update the caller about how much progress we made. */ *offset_fsb =3D del.br_startoff + del.br_blockcount; return 0; +} =20 -out_cancel: - xfs_trans_cancel(tp); +/* + * Remap part of the CoW fork into the data fork. + * + * We aim to remap the range starting at @offset_fsb and ending at @end_fsb + * into the data fork; this function will remap what it can (at the end of= the + * range) and update @end_fsb appropriately. Each remap gets its own + * transaction because we can end up merging and splitting bmbt blocks for + * every remap operation and we'd like to keep the block reservation + * requirements as low as possible. + */ +STATIC int +xfs_reflink_end_cow_extent( + struct xfs_inode *ip, + xfs_fileoff_t *offset_fsb, + xfs_fileoff_t end_fsb) +{ + struct xfs_mount *mp =3D ip->i_mount; + struct xfs_trans *tp; + unsigned int resblks; + int error; + + resblks =3D XFS_EXTENTADD_SPACE_RES(mp, XFS_DATA_FORK); + error =3D xfs_trans_alloc(mp, &M_RES(mp)->tr_write, resblks, 0, + XFS_TRANS_RESERVE, &tp); + if (error) + return error; + xfs_ilock(ip, XFS_ILOCK_EXCL); + xfs_trans_ijoin(tp, ip, 0); + + error =3D xfs_reflink_end_cow_extent_locked(tp, ip, offset_fsb, end_fsb); + if (error) + xfs_trans_cancel(tp); + else + error =3D xfs_trans_commit(tp); xfs_iunlock(ip, XFS_ILOCK_EXCL); return error; } --=20 2.31.1 From nobody Fri Dec 19 16:07:40 2025 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16864189B91; Sun, 4 May 2025 09:01:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349286; cv=fail; b=FM/ZzqKaUSiqHru8LaNiKzRxOFV06Pp7CKj2bRFhFibBlEW5z8w8oW+KciH95bM3fYPx2csUqvA2NakUr/5623IPHXy61G6z4QIbHJX3ndMAi5aBeGJOOmmlpZZm697V53et77VR8PDiGP7i6/hgM1829xgBTWZb/2YCEaALK58= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349286; c=relaxed/simple; bh=9eT+lXdOnGGoGzrugdHnlM6/gxGf6vdsPRVIvBGiSt4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=DFUHkCrTYbx1cGR/2OMRLZcW+mhTa7atMIMaNQ18VAus1cPK5ysRH1QjBx+HnBTOIDWvGwLHVXgsLnGP66lEQGlk4c4rDXJinTSN11cxd9xanoDyUViGkJ6leICY0kJPwVZlVTfDIeC4ImjTXkVkdh4UOExIHaqviWsilwO2vzI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=MXSSGwox; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=h7FL5KkS; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="MXSSGwox"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="h7FL5KkS" Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54477nHl016036; Sun, 4 May 2025 09:00:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=pHPrOF330Ob5KselHNKq17d8XF2FSszAu7gGNAU1b2Y=; b= MXSSGwox0+PRmCsliYlUuZ+bFG6uszSRRWHDLMAF+I9Enk7gi7wOKkCyxhRuXhch SYfvHAS57KqXnWxn9lcvPpYhqNF7LW0KRLu97v0tUdyByQXo4AcYyOZsy3hkQo/z mDeenljiHUOK/pauUpSNFzXcToleYqIKbo4ICF8s+F5z09czt34SiBrNc8W9F2ZS 4izEVHM31SQebdpeqFJVwMTy8EMICgNIKt+nWbdZxElafgjFJ+9c1q6ueDqkAMMO TfTwqg9jg15mi1zrLgWbNIQ/JWP0ndi2iDQscOXuMO1tD01GbhnXZWUFJ+2ZDgi0 eBD1sa+or7B7vVUmWlribw== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 46e3jk03yh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:10 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 54465cW2035553; Sun, 4 May 2025 09:00:09 GMT Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazlp17012053.outbound.protection.outlook.com [40.93.20.53]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 46d9kd0776-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=t7Nh3BBaXXyojAeyrJHwDVun5vDdrojQlmExco0X8NpJTmenIj5+jP7EKdDQD0RtnfLbxr0HXxz6XTj1mU9ud65qUqNyVwOKbUWFNLKKFYYOItLzTyYLe51uwJygtADIaDqWWulsi0js4ZrtiHi4DkpCmTJARFLIrbJ+LZuWcZ0+992fWu8SqIz/PDK+0xV/jg6zuZG+7LKFJTPlp5WyqJyLPTG4LfGOSwIArQtxcXa8iOs0sNMArLal7GSL7YiW75O0RQiVZ4p7ybP0G4aEyF67IsAAQ8vU+j5Ii9PZeq8gjjkcZPOrSGvSYkesKNQxHTM3+MG6UYzEQg5+61rcmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pHPrOF330Ob5KselHNKq17d8XF2FSszAu7gGNAU1b2Y=; b=e1CeScIHkcOl6ouuvvnymudmC5AGOU4Owyq/1ZxD4UZ4rGjwyeQhUWFd/P3ugjJQf6DXVxgvq/lAqE4R65gF0RFA6ryKkXl6nl+X0PkDSS6kqnrvld3C5mrGIJqGzQU/MYG+2SHk8zVenz2naevv6E4RQeMfAPjaOjiSlpsO2yL7aLdcho9CCBHCQUXiTEYvX9/BGPVM5ILZK2XFxKcnuRQw9lvgtUxT/Razp0FrSeEYdte3HyJ7+4CH3WTuCic1xL8HTlpsi+9OBvS8yyk4HtE3zTdn/k7N+fRpomIi06rrUp0MLeg/2jTRk3MhnEn+XR0NiGlE6tXyGKXAsm6RpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pHPrOF330Ob5KselHNKq17d8XF2FSszAu7gGNAU1b2Y=; b=h7FL5KkSAO6YXud5+V6bu7yoQ0vkXDx4IFab9f5BJdZJ8+HeAkmNkG52HTVtjHEJEGgUWeaX/MZ3a26Q6u/TZqPPf83zq4zFu3+auc5t67vLi3pu3yjUiyyGW4V3jji/Pc9UDc3Pz6M8VDBtJ6lQ6wTq+iJgxJ2ISx4KIxTgPRg= Received: from DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) by DS7PR10MB7178.namprd10.prod.outlook.com (2603:10b6:8:e1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.23; Sun, 4 May 2025 09:00:07 +0000 Received: from DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088]) by DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088%7]) with mapi id 15.20.8699.022; Sun, 4 May 2025 09:00:07 +0000 From: John Garry To: brauner@kernel.org, djwong@kernel.org, hch@lst.de, viro@zeniv.linux.org.uk, jack@suse.cz, cem@kernel.org Cc: linux-fsdevel@vger.kernel.org, dchinner@redhat.com, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, ojaswin@linux.ibm.com, ritesh.list@gmail.com, martin.petersen@oracle.com, linux-ext4@vger.kernel.org, linux-block@vger.kernel.org, catherine.hoang@oracle.com, linux-api@vger.kernel.org, John Garry Subject: [PATCH v11 09/16] xfs: refine atomic write size check in xfs_file_write_iter() Date: Sun, 4 May 2025 08:59:16 +0000 Message-Id: <20250504085923.1895402-10-john.g.garry@oracle.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20250504085923.1895402-1-john.g.garry@oracle.com> References: <20250504085923.1895402-1-john.g.garry@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN2PR15CA0025.namprd15.prod.outlook.com (2603:10b6:208:1b4::38) To DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB4313:EE_|DS7PR10MB7178:EE_ X-MS-Office365-Filtering-Correlation-Id: 83a200b7-5a45-47ef-6ee0-08dd8aea1137 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?qBVsDlxU9jQhHVUDNLAdDjXkJBDX2NNC+eirv6McH780xnA6DSeckXQJ3VNa?= =?us-ascii?Q?+sBolX0OmKXEC7H18o+JajPQ+/dEiP9+04kr1gFKDS6a0V51wXvaHwNHoJRL?= =?us-ascii?Q?UfYZY89U4qKaOQolPssB4JJ9SrXbgKDEBLopXm1kHTPvIoYJfLPooMva07iT?= =?us-ascii?Q?ocvIVicxkKqKSvcceUAF0OAAjl7jXVXXUT+I9Auof4lni8V3ghqBq/x/8LuG?= =?us-ascii?Q?15AnYhnfnUimDVL1nRFwvJdRqOJSRpdYuneDxHkoXAtcVRsQt6WkH2DxwBW+?= =?us-ascii?Q?j6cwR8Q/Ca+KBPB3Ek+N8KkSu+B2uwuS/NUg60VE3kKElc7K182Ds35DHOAE?= =?us-ascii?Q?vy45wuVcMay5Y7uhcPIfU3qBnKNd0RGERJ4mrsylv/3M812F1808KeOXUlmC?= =?us-ascii?Q?HTl2PSJQE1zcjt0bOYExKOmhy+SfuoMtTzo2jkR4G+GN0zMSmDQnJk4PQGsg?= =?us-ascii?Q?PSf/b87Lve4/9N7xPY6tgeofBwMOTvznKls5dxKNeCvmkUvnZgZ/IPmz+EzE?= =?us-ascii?Q?iHjF+fHqKs9J6l6Bcx9eLwc8WfZDjY0MR6OyVTau/1PsVuRLTo4k/s/d9NQ3?= =?us-ascii?Q?U6/AHEF4EnENC0dXWY/5Swe2QrQp0gAH6+mVnk5UNDFBYBqWaXghz2UxLJdI?= =?us-ascii?Q?oM+AzGRZWrnkCmQytY7IBwaEVV/VFA4AN7NKpuANwlR8n3NEu7pegxFHGwUw?= =?us-ascii?Q?6sJvNohprBBvIi2WQ9MpTM8W0TxPBvFfzdV/G+dl3FzxVHVAjXtCW03l31su?= =?us-ascii?Q?ZjNiY8/knxjc1YnjVggHgIyiKrsSlKheD2YT4rGQdYG+Uq0Jci+Jm8bA3dJa?= =?us-ascii?Q?agBf2TW2uK/INP//IxPU/T32DvWPE3283CCnRnnj4ois7aQ20UVMAvfqG8HH?= =?us-ascii?Q?l2Tx+BI/WcZyeuZpZesg2lobxzE4jPnQQql+OeAhoz/LEb59n26tKVA1JkRY?= =?us-ascii?Q?kLNDtDtLZ2UgK+wxsHgyZ8o2YtphjIRXXCD/APjseaiCAZRrCBooAztAQT03?= =?us-ascii?Q?CkAl5i/zM0VXVBsSR0tWUYoWFI/LqVLybvD/PNk8iNs6b+pPJyd2+mRUEtAR?= =?us-ascii?Q?VPQ39zWLWMUiKCW4xOE1tZOt9c/kIWmJZHHRTThohjJwsvi0XBq7viMV8nNA?= =?us-ascii?Q?ncoEWsRrq3MOeK9s00F5X6jR14k3TMV6MvIC3eGpeGzlg+ZXL1TinvfsjABB?= =?us-ascii?Q?pjZYOoh+bTV4G9v++phrErEHEOtZmkjgjkhSFrysYOb8iKTXhQS28t63e9F8?= =?us-ascii?Q?tpFwC3CENIpuxvKtF8ki3frNwnGV5kjZSt+7Y3e/v53omjAod4Rlen+FR5Bd?= =?us-ascii?Q?926TlBBWEBZ2eLpKWnfvrhELKn6psz7zs7RG4j0UENPwUkyfX2QPlRXByKlF?= =?us-ascii?Q?l3iwoFdiTpkrghd5YqndbyN/JWxxiqB1yQK3SWnYHseliSXAC5LILg84WhGV?= =?us-ascii?Q?auUBmtGzmsI=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB4313.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?n3hpXzPga7WZJTaQ5jNTawV65pHusRiLT5cSsr5pKjXHzN5tEZd9cUlaWFdh?= =?us-ascii?Q?whV7eYK3KkysMyHXggROyrpksxfnEVkxali5xzxs70DKBXh07jxWoT0EsR1y?= =?us-ascii?Q?zEK7CqGEpvyIlP2hi4cWHr5wld+2lzNPsRN+RvcqMGhPvyk6cLZGYdaVVvJM?= =?us-ascii?Q?68Jj1nnB2RZhOBCaSepdvVmtt9QKzXBKu47Rb1z9viE5VVVcWa/NKWD2fZAM?= =?us-ascii?Q?6c0IsAKHGmjyhj71/pYRBNv1zabWljM8UIK2gWQumHQKRmDytKCHYTtV/Loa?= =?us-ascii?Q?SgKR/wEm4DQVr+gt3clCppH9fFdQ1OaFX1DqVZatW2L4ofgEhD0Pm/VhavMB?= =?us-ascii?Q?KI8woCOtzL34myIg/5I+nqZscW65qN2RUCkjL81CePttiFStgJNwiWW/2V9C?= =?us-ascii?Q?/YgeEZa6O1b5m/rt6Gc4TPXjtO7f0j1/qjUdpjinFx/AxmDVdX3HoXFtn3ie?= =?us-ascii?Q?7IRUpIy7vIkc/7N0VQATqYdMQwMc8G8jL6leGEJnRocacCGR0ekXlHN4kTIt?= =?us-ascii?Q?cNIzEMm2qGTewSFvMxq+L+1eTyo0qv6wDTbPowVFyHxqIN32vnf9nLnF2uJ1?= =?us-ascii?Q?09WHxcOaf291Y0mHsKCsdAZFSLZywsypkSbQk6Gh8H7EG2RkPk2SrNJdtWe8?= =?us-ascii?Q?QQUWoi8a7v2BXTsBixsSlHBCvlmcdQXDpGLqIPh8lqVOE24n3AsFIvs+Kmqr?= =?us-ascii?Q?qqrQ+YOoeI9zLvGRHN/lwpmtVoIUlesHxGNrIa2nXxACy8LO2zrA+kCrkbm2?= =?us-ascii?Q?+MmeAIb8O4GKbuwAeke6Knh7M43CshwsccTlBko0MVCdFO7H/n+qP5Ga3vVr?= =?us-ascii?Q?2d0WIzSIHkwTqc20fn8/DEKtu6J+AAVCtKX0lkH/HnmCUSWAV9aldmmu9Bvv?= =?us-ascii?Q?qVv3ybQVZ7+mLRcIVfYFQdN6g1sQdxJHPfiGkIeab92nXYtJ95SgHLQ7aIis?= =?us-ascii?Q?uMTXC8kck6AhVwE/8bPKek2UXnanYeME1SWV3Lo0+IrjRPaU4sBtnozl76cB?= =?us-ascii?Q?0cBJb3t31+7qNNxYHa/ot125h2vONKhXetRo7CYUiWk9k3g/fztheDx9Vvln?= =?us-ascii?Q?Q5d6hRzigvblsznKSRaf9Mr7lH+zbl8rNvGqIHLacBZ2xVuG3TJAynXzM9w1?= =?us-ascii?Q?e+jJJByAyKVi6tfJV+hUDYDoHfwLbe/Pi8Db77vDUpnpdZpT9UFyp3UiKLlr?= =?us-ascii?Q?3nnngt2k9vXVKA2QWA9Wu8M6U0PqfzYl3rkopIhSym052mRpwZmJvVMu7HYf?= =?us-ascii?Q?zvCBTmvDrjIYAccMG0rJeENj4Hi4qHs5E2rEFoSfM2Kr/n5lWsQMvxHqy4Tg?= =?us-ascii?Q?q08laTRxAmORkwYT7WNXe8ontokCSYpA3MXUooLx1ocmUhMLM/VCDWyWHp0S?= =?us-ascii?Q?IS97fmETCPef6eF0L+jDCGtbV/2GfdfLIlflVzk+6m7lYpA6h5XYIC6QtL3b?= =?us-ascii?Q?ywiZMq/sP//LFxU36EJBKtdAXMwVUs8pI9J8sGXUyQRyJsyTuBhLdUGKyUNn?= =?us-ascii?Q?K0QvnjyZUo991ErT0dW+DfavOCTkbiy1HA2ZYWsOTLmBXIqjRZfkqa5E/Hf6?= =?us-ascii?Q?LdVrC2kJQ6j8XmhNW8aP3HnxLGe3EW2sdA7tNKQTzuTN0M2S/MShixgi5mCp?= =?us-ascii?Q?+Q=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: w3iVmP5VkfC/FlYMawAhW3rfhkilcGISSyLJwiryljULRFpwV0QVN7HXsYUiKe1hXyc05tDXJcUoczDm5+zOhlpgepuTAhAV8gI/FPB/AaamLG84UZg+DTQa17pu3TwzVZFOhNo6Pa5GI99v4iNUHLxw0f30KYu7PE3T0Vi8EYRFu6mEx4PIYWGomL3/00yNJQPL2bPLBl1+rfA6/FVIZx/hze/MMsj6/Br+TBxnAjSCte/BaZS/PzOcwumF/SUCK+jG4sDErALM6lVWlRsTC1I/TYeOnRlq+qxuKE+KP1DDxrHf3Fo/thexNYH+Ve+g5c+KVEEhOWISeO3GfTmP35XdqOd8mzLv2Yh8adqWKaBWkCk/IOxz5VODDlpDMX5RznzfYl1VlyAtcteTDTS5oow/GUgm1F3pR0q4Sdl6sIek0Lh7zDleSUIJWswOH/3r9/WJXdZVcRhyixo2cjzVRc2UVBdNehu0izDFrj6T99kj7FgTtVpK3jNrjWNl15FhVRCFjOOtxo9O09muq1WZQIsHdwJnt/5t6SnY/q30jsi3PD9LZV+QcrfvCpf4iapB6+dNBDDDlUlu0a1yvzKe4nCo2iJooteP2Ja1fj49Cb8= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 83a200b7-5a45-47ef-6ee0-08dd8aea1137 X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2025 09:00:07.3699 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GRwNHeweSX2QciRCBc7c6tV+t1pfaATVnrpWArYylNWMEVby6xfezyLOQij0AYyxJrjeFwAe05NlA0t0uI6bDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB7178 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-04_03,2025-04-30_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 suspectscore=0 malwarescore=0 mlxscore=0 spamscore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2504070000 definitions=main-2505040081 X-Proofpoint-GUID: fwRDk-LmBDr4WyoSIm9_T5kdXppDIa0S X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTA0MDA4MSBTYWx0ZWRfX2AP/vbiFJtMQ IQtI9mW97kTLYI5dK8CRkPaGWAwAYL2daLnrxPF0Q7fGBkUUmLtZCTouXKDzpgogN5jrt2HdtC3 hJrO22L0jxrn/POmoU5u69E54hwSlApBImnGCkfyI9qbUVxjkdbmK/GpM2bUqUsc5KWTFn3wXk+ 9h6so5rs3HEWAhCrWVaE2kROSGGNItUQ7WbBIBWWfNye1568UqIBIcD+ohgxhb13rrazsQzvrHi epDplBl1QCyt5sCxwhrFKuJri5I9YXDQ0r+vGDN71eCS2a3uKDCRbwt+67jgVLHrmxRTHq3T+po eIGrFzCoMz8h35nFONwIXDVpcRmwRfwScF3kwRxmgNtdeLVC6Ar+JjTqXcbbWcywjCMIRkDyJuH iu7D3s+hJRk6oLdzQXXZYZLfUQZVPaT9QnxdrRk4lEXa/Chpz/5w5IhpxVJhLHuXVv+cAlfn X-Proofpoint-ORIG-GUID: fwRDk-LmBDr4WyoSIm9_T5kdXppDIa0S X-Authority-Analysis: v=2.4 cv=IaeHWXqa c=1 sm=1 tr=0 ts=68172c9a b=1 cx=c_pps a=qoll8+KPOyaMroiJ2sR5sw==:117 a=qoll8+KPOyaMroiJ2sR5sw==:17 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=dt9VzEwgFbYA:10 a=GoEa3M9JfhUA:10 a=VwQbUJbxAAAA:8 a=yPCof4ZbAAAA:8 a=hT51KhAs6gTkkLCEbPYA:9 cc=ntf awl=host:13130 Content-Type: text/plain; charset="utf-8" Currently the size of atomic write allowed is fixed at the blocksize. To start to lift this restriction, partly refactor xfs_report_atomic_write() to into helpers - xfs_get_atomic_write_{min, max}() - and use those helpers to find the per-inode atomic write limits and check according to that. Also add xfs_get_atomic_write_max_opt() to return the optimal limit, and just return 0 since large atomics aren't supported yet. Reviewed-by: Darrick J. Wong Reviewed-by: Christoph Hellwig Signed-off-by: Darrick J. Wong Signed-off-by: John Garry --- fs/xfs/xfs_file.c | 12 +++++------- fs/xfs/xfs_iops.c | 36 +++++++++++++++++++++++++++++++----- fs/xfs/xfs_iops.h | 3 +++ 3 files changed, 39 insertions(+), 12 deletions(-) diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c index 55bdae44e42a..e8acd6ca8f27 100644 --- a/fs/xfs/xfs_file.c +++ b/fs/xfs/xfs_file.c @@ -1032,14 +1032,12 @@ xfs_file_write_iter( return xfs_file_dax_write(iocb, from); =20 if (iocb->ki_flags & IOCB_ATOMIC) { - /* - * Currently only atomic writing of a single FS block is - * supported. It would be possible to atomic write smaller than - * a FS block, but there is no requirement to support this. - * Note that iomap also does not support this yet. - */ - if (ocount !=3D ip->i_mount->m_sb.sb_blocksize) + if (ocount < xfs_get_atomic_write_min(ip)) return -EINVAL; + + if (ocount > xfs_get_atomic_write_max(ip)) + return -EINVAL; + ret =3D generic_atomic_write_valid(iocb, from); if (ret) return ret; diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c index 22432c300fd7..77a0606e9dc9 100644 --- a/fs/xfs/xfs_iops.c +++ b/fs/xfs/xfs_iops.c @@ -601,16 +601,42 @@ xfs_report_dioalign( stat->dio_offset_align =3D stat->dio_read_offset_align; } =20 +unsigned int +xfs_get_atomic_write_min( + struct xfs_inode *ip) +{ + if (!xfs_inode_can_hw_atomic_write(ip)) + return 0; + + return ip->i_mount->m_sb.sb_blocksize; +} + +unsigned int +xfs_get_atomic_write_max( + struct xfs_inode *ip) +{ + if (!xfs_inode_can_hw_atomic_write(ip)) + return 0; + + return ip->i_mount->m_sb.sb_blocksize; +} + +unsigned int +xfs_get_atomic_write_max_opt( + struct xfs_inode *ip) +{ + return 0; +} + static void xfs_report_atomic_write( struct xfs_inode *ip, struct kstat *stat) { - unsigned int unit_min =3D 0, unit_max =3D 0; - - if (xfs_inode_can_hw_atomic_write(ip)) - unit_min =3D unit_max =3D ip->i_mount->m_sb.sb_blocksize; - generic_fill_statx_atomic_writes(stat, unit_min, unit_max, 0); + generic_fill_statx_atomic_writes(stat, + xfs_get_atomic_write_min(ip), + xfs_get_atomic_write_max(ip), + xfs_get_atomic_write_max_opt(ip)); } =20 STATIC int diff --git a/fs/xfs/xfs_iops.h b/fs/xfs/xfs_iops.h index 3c1a2605ffd2..0896f6b8b3b8 100644 --- a/fs/xfs/xfs_iops.h +++ b/fs/xfs/xfs_iops.h @@ -19,5 +19,8 @@ int xfs_inode_init_security(struct inode *inode, struct i= node *dir, extern void xfs_setup_inode(struct xfs_inode *ip); extern void xfs_setup_iops(struct xfs_inode *ip); extern void xfs_diflags_to_iflags(struct xfs_inode *ip, bool init); +unsigned int xfs_get_atomic_write_min(struct xfs_inode *ip); +unsigned int xfs_get_atomic_write_max(struct xfs_inode *ip); +unsigned int xfs_get_atomic_write_max_opt(struct xfs_inode *ip); =20 #endif /* __XFS_IOPS_H__ */ --=20 2.31.1 From nobody Fri Dec 19 16:07:40 2025 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A35B41862; Sun, 4 May 2025 09:01:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349285; cv=fail; b=jIaflY8TrjO5bAe5sQ+fZsFmXJugVXRCG/kYg64lrroc1S+qlST6hHmpH3A/Y+0gPA9jiMiB0CuH14xjrMVODxPPMKrH6omU+Y9xTX3Pk6q9/CbkBEwUGQTGTtBRbjEKxWpHhPnLxYr6YTn6SM1Rw2zl9ZCgy+WNoD2fFnx2YO0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349285; c=relaxed/simple; bh=KNVNk1CCx42+fiaAdF2Ll76XGH471BCcnQSWw3yt3kU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=dIhmxgiMPLHU6x1q0zcPyyLVKx3wHOHD9x+0dHj6rEK/UlOu9vgGepIBIODIIuNdWsz4f9Hbz+3MFbwDCtkyS7wM6KJzqdnoCZeodhRYeUe8lkduvgNIK4ddKpb2AX/4/cBYn6Z8qiSXFq2ifdGcCv2ZXtt1mWzQctx9Xmo7fvk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=ZZw8/M6o; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=N1bB9dws; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="ZZw8/M6o"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="N1bB9dws" Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54478QmT017422; Sun, 4 May 2025 09:00:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=W8XlzjetqY8WqWXCTcttc3zdjyPUAZ+82wHngghAoCM=; b= ZZw8/M6oSOXl1BOHhggTxplVc/UbpqlJq9c2ofXpVVoJ+h147BRCPE6tuGcXWad8 4GeUnggpYwAQgB6X4GFuVlgbhJ/3eFfrhygZvGdTdB9/y3LdVIO5gQfqcnL2ICrg p1dbOQ9ilm8XMHcXrj/Gsm0F+YFQ3Qcc9P7SDxxfa/3ce6QoFIiGXUeP6xmXFCT2 kKknO5scmvv4iejVTnnz2gR8s/1CH+j0KHbX4kUsCsO0KoatbVem3jN08Wn4q3cH SCodPGuKKh6Xid3hagNgynjW3SRGDQ4BYCJg3EWBz6Dm4ifhNvLuftQh3FbWER52 S7qmMxzKorlC+DuyvXJcHA== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 46e3jk03yj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:11 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5445PLOp038260; Sun, 4 May 2025 09:00:11 GMT Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazlp17012053.outbound.protection.outlook.com [40.93.20.53]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 46d9k6gfhd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fI5qLsK6pPC1aqQggeQq0yHoPxBQ9vSuiZc0W6hdybQFErA/o8k72Nu9lQjsXbFQPpr5aB7LLDE7IqD5aIDtPoEaJM6sQCT/8TJ44m451vxa/qcNXqbVLVQV2eqRnpNH0TlzlfVxkNdVkCgPlYEbcvpryg52nVcT7tGyod6/cxAVIQgKZdhVO8sU5UCSnY59FKUwj1MjDf204K49AwHDXJnMubcL9n9OxOh6lxEUjswhPzk1rIQIyBfwsc+nAzDQImw6G2Frx2lPbLx6Z/7lAZqJpNqNwthpDw6pA0LWbRE+ayC3Attb5NS71Bb17VXRPj8JCZBreamG9oPIyQQt5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W8XlzjetqY8WqWXCTcttc3zdjyPUAZ+82wHngghAoCM=; b=Mjl32EgY5lWjjnFx4Ev5XAieL1jrhFgB5g5l44Lc/z0+osY9xkKsZMiOCqOXhundycxc8MFGth+Ys2bnFD2kukFCk7esOfrRIXszwr+H4eyZoJhVeTilFOxuSMQhNYYMqAd4BSU9+/tG0DpKomLY0KtK+9A3n+yPGB2QgyHJaBrcdcRwzHQq/bgFDTSgOu82o4y+A/NzCSXyvH45et/XkgGR/wZeAu/ZuxGl2jtEL3mr91jPib4hZXQQwbCVfrtgkS39gF+xpRFF/4dTsgdGIOe+58nxZSXNex196Pc5amba6meuZBkIoK5mGHF0BHtAmEasZgkdJu3jiRcIWVUv+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W8XlzjetqY8WqWXCTcttc3zdjyPUAZ+82wHngghAoCM=; b=N1bB9dws2Ou8fwmhY1x3lZSBxMZQJ1sNSLKzIT9CV9nDxvPAh+WYCLFzyeTzavPnUA11TBXnnojqgnrUl/p66NdNbz7VrHdflxhrvZbsuuUyRdI9phY73Y2Bze02+6tfKFPJo3vjZQPwkupzZaXX+Lt96IrpVY1+KrpVuniJCAo= Received: from DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) by DS7PR10MB7178.namprd10.prod.outlook.com (2603:10b6:8:e1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.23; Sun, 4 May 2025 09:00:08 +0000 Received: from DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088]) by DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088%7]) with mapi id 15.20.8699.022; Sun, 4 May 2025 09:00:08 +0000 From: John Garry To: brauner@kernel.org, djwong@kernel.org, hch@lst.de, viro@zeniv.linux.org.uk, jack@suse.cz, cem@kernel.org Cc: linux-fsdevel@vger.kernel.org, dchinner@redhat.com, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, ojaswin@linux.ibm.com, ritesh.list@gmail.com, martin.petersen@oracle.com, linux-ext4@vger.kernel.org, linux-block@vger.kernel.org, catherine.hoang@oracle.com, linux-api@vger.kernel.org, John Garry Subject: [PATCH v11 10/16] xfs: add xfs_atomic_write_cow_iomap_begin() Date: Sun, 4 May 2025 08:59:17 +0000 Message-Id: <20250504085923.1895402-11-john.g.garry@oracle.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20250504085923.1895402-1-john.g.garry@oracle.com> References: <20250504085923.1895402-1-john.g.garry@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN2PR15CA0022.namprd15.prod.outlook.com (2603:10b6:208:1b4::35) To DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB4313:EE_|DS7PR10MB7178:EE_ X-MS-Office365-Filtering-Correlation-Id: d0ca6d05-c4dd-46f5-f04b-08dd8aea11e8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?iTAzljYe6ubSRxgCG+OfKspKtXIcv+xjsH58dVR8MiNlxa1R8EKFVcvYM4mv?= =?us-ascii?Q?KPtWvnwlH+alel2ZNhfzLyrYbbwOBvSulBvRJI8YQsNN67hbY/dZch99vsRZ?= =?us-ascii?Q?49KLza46fGLP44SWBkpqfHJxsQcv6Sj7Q2qdFSCYiNFba92ODd36dDZg9zW8?= =?us-ascii?Q?PemXWc4lk7E2MvI/Ak2xgGEbKrCTbL7blg5u+3MqOc9LVVPvCakfnaOgV5sf?= =?us-ascii?Q?cRINyXClb3ybf8BvUIykgD1NGnGMUkMlKVde/a8sZzt72nB/aHc4nKu7af6q?= =?us-ascii?Q?cgssHcZgjAm/MZBagzGyNH87sUevCxuTzCl/Sq3EAIK72Dz82H5JB3TqdWR9?= =?us-ascii?Q?YhqhJAFk9R1Qt16M1sYmZzTQ/AjknDz8nKdR4fRpB4vhZZ5Ru3vcoo+toi+7?= =?us-ascii?Q?04G/b5MY3ysXF0Z3pRzMF7zznnQS1BID925s6WXmILOh+WJgcswAIqaEtCQF?= =?us-ascii?Q?8gNx+Te0gFxXJ1YCgOaFX7MCjL078guGXKnyz8xtboiGinUedrOYQcHTB4ZL?= =?us-ascii?Q?YnnftaW4ILh7jj7VTcxCbZoa3n8CceuMziFtzCzBYXkBQU+nHh6vnTuSLbxp?= =?us-ascii?Q?Vqz7hC3+/HUuNmSqeF8p5GLR/Ljz99boDWnPaw12Yk+zU2q9iw00CkPI0wRs?= =?us-ascii?Q?Im8HfMsIWfAYjkfaviNM0kxo5UYzFvHj8rnV9oFtCCLrMM5xx9fB0JKhjYN/?= =?us-ascii?Q?9YeWfppbHDKtpbb7xdAuwnrnp/RNY6PC5K/I7u9qiM7Xns4HclNrFYO+ad5D?= =?us-ascii?Q?CCkoWeRGM0vstuKI0knh6rJRp3KsdAg66tmdWRv4dJCt4V8VWHteB/mt9L8d?= =?us-ascii?Q?R3GoqRdLBAEjDsMR3qhkp0AO3UqE6rtUBpUtyhMZsljd3wgafo/geGONbmZu?= =?us-ascii?Q?e9Lj/c2DX+tY+aphGU23AY/MZlVQDVRZeWsrco5r5ycnPgP3Gr0cY3AjgWNd?= =?us-ascii?Q?RjtsbxSZG6TPcL/Smf6uI7ZDCKfnJrRdW1iHzIKq8KL71nqs9zBj07Lx2E3O?= =?us-ascii?Q?hvpesU0uA7t6LPwVI/53xzloVR0KFYHho1IYWeFuJRMmu/SvhuL2RVMBrOiy?= =?us-ascii?Q?BVh/iZI4LVtwo94yNKiHySwtAPpVAqdcMXGTOiPiP+6G1ytRoyfAVzSDL6FA?= =?us-ascii?Q?82g+428DgYH3KTpYLKem6HqboJ18WTbYVPRztyCztOgEJZkBnJC7CNpAy2dL?= =?us-ascii?Q?J3s55JCbqkPBVgCd0mP+BRN9/0op1w2zfD3vlW0IoU7jpz7rPSEYEBtlJcqa?= =?us-ascii?Q?c+VFclk2a1IfRUB7eJSMtMd0aUwIoCjYPYH53zvycsfetCLnz1TPrURil89n?= =?us-ascii?Q?RBDOUB0qqwt8Pj7TzKR4Mm8nTmefeOXpH+RzddZYNZFXtnxst+uAh877X5Fr?= =?us-ascii?Q?RkltZSoj9ebu2BVbmhjMCwayYZMF/XkojPGDYl3Pcf4txnzG7k57TteLN4uQ?= =?us-ascii?Q?mY6mGc5vOx8=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB4313.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Pzx+AdoqLOaVsvjdZAFBDJNp46QcMdgw9TBxe73nvvVYvyn9WlrXpJ8jZfbL?= =?us-ascii?Q?LOT97NNA/A1aUGvKlWWSfRp08bnbQmkt1V5DA7KbkrA1hpRCiamQwVA5xxpM?= =?us-ascii?Q?2mnOsCOs+OpSnVF40sN2XQZEmpylz5TAQ4wq0MhovvUAXwF6VW2uhbA7w3/K?= =?us-ascii?Q?cshHRmVTSL3Rv+SPlQnXDiqJ3n51qRBWJ804LprHbOhYiD6gBkP9ofwdXHZQ?= =?us-ascii?Q?FEVqTCFtuzZJ83/8ra3Oj2MUKZkzvXPR8GRYd68ySIlLIXuKEv/QUeInYKkf?= =?us-ascii?Q?Vz5+2eI+uub0t8NwY1WBf8N+b3oTQs6ll+p20uV/kk4cLa8LoFHdYn2eHpd8?= =?us-ascii?Q?l8If/6TiPEB9HVMDUUpzt1f4rPcoBqesq56T+yp1wnGBh2vldkUs/p6iRL2g?= =?us-ascii?Q?6YXw7Xm6GMN52MAYA+sRINco9hrtW5vjbaUrCEqiaF7E6AKN1zOSCtNxQ3pa?= =?us-ascii?Q?KmLIEIgLMvXmIDkGuy7cNaAYyk1neu/JaZKZjO0Dp1PLSrrBzTC4jDgFqtHl?= =?us-ascii?Q?oOEJH0rPCGGOxeveoO42egzcnw+aHWxwslJ3/l/GP1JQatniFSiPGQaZDNgq?= =?us-ascii?Q?yB7GOrPxCQCpJrVROSZlvlgixoddNHHoayEVqwJp5SBtvhfFNKULq8HbGolj?= =?us-ascii?Q?ffn45NfMTCZniPVKNHNum8RXJwOkX9EyghAj4oHYF6ncgoPkaP04Sfid6hl6?= =?us-ascii?Q?7Xdpib3FHhXcFLQ+K2unfEIIvjFWnj8vM8EHMXP6sLIGHyaa+VrufqhmN3x4?= =?us-ascii?Q?jlTGq43XYyhYMorBobnlKyZnTsDyELTNiivOMgP7l7+aerSeemmcFxuJt86K?= =?us-ascii?Q?vuDxzuwNdB+eZgGjuKwREz4AMqQUq2R7xmxla6y+higVmKrwnsMiWBYbXPVG?= =?us-ascii?Q?CpAv/l/1F0w6B8RKeitlY16R1gBrf4q2LRVEdfa40dnzcKobsuex6VrIY6BO?= =?us-ascii?Q?xmuYFZeSXDk5bY4i7sGf6pQfs/EGO2PbR3aH0clAdGLhWfLav9kQ9V27ylJ4?= =?us-ascii?Q?jqWHFDs/71y1WapMCAuOeYEcaAT+1Z3fTRykNthAzkuXIbcVli33/KK8mou8?= =?us-ascii?Q?UXPOhICqoW4sWoBrqVz5P2H2dIBfDiSlBzmyDlr0UAu24lsANFiaBXXMJOYD?= =?us-ascii?Q?SDWux7ERgwRbr2R3Y3VhEjQGR7icCYIe3umFltgigHE9M0mjQzBkrorRxrwJ?= =?us-ascii?Q?n/fqP+8uzHQ5CM8Q+/B8JL3xLlHUDVqc4JcpY5r7YawsDxgtnDoK5tHOhAK9?= =?us-ascii?Q?1DTmv7O5B0uO6Ise6WIH4/3eoIodhO9u6C8HK/F+NpSd2mzlTwgW5Cdy59ZV?= =?us-ascii?Q?CJ80/ZOHO5c4i/wWpNjLYK+CW2fzhVmhNYxwetS29yWeGA9EeZUGDHLjYZyQ?= =?us-ascii?Q?EvUJWGrEIMkLszmXjxEMN8MddgleHC0SwHFKm260vilrWuwvL5bLrUDIqN2g?= =?us-ascii?Q?bpTjrZftMvopAqU7sOYmvnz+A7kDmW6sLA9CZbZ9ZUkk+2MEWbHUBRMHK/YS?= =?us-ascii?Q?DbzN+ORFh1pnd5NK+BFfNXOZZXEkXSHSIGjuqp+/xwY6xDo4gmBccUcgjQBl?= =?us-ascii?Q?dynH8HpjJPQYyqSyBolIAZPGV0FZiUbnz4t18T7ZygYX3WUrBuL8KHAVCu8E?= =?us-ascii?Q?JQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 224S14m/txXa/niRE8/3PTEZmTxxJnA69RTy87OR/EnedX193twkDeeyDWZKcIwob03OK6CGZ7WmYNK8VljnUSZaAyVO1ZtHl3/WcuFwyouKFC6FjyCgkX50KP9OeKnr6hMXC8hGQRuz/8qDsCBJwCRfy/n2NsIuPj4LhThhxKZopONWdz9eaY2m9MIX7+LzHmfgZ88b33DgZIIEMVVpl5vpMXWPR0qA1Iirny72MyXtNs/UcAu8jVwVh+KhIZ+RIcaYs3umFW13CrUbDYsbbXEJPtBoF201dB73QlQh2BoYBwV3igqtOnyFOSYF/++D42WCuuOL4FpJwDHQEv+SYgB/OJepu2CEMAVOoeJrjlIAAs9y0mz8zpu0qjPA4xlWFLaMl6dTWRb5uLLtUVc2bDbxV5/VtDnuJjf4qmc+i/QqrXjhdNR6Jg4OdHEuQ0k0QEhMccxJ/HFWlr8CMf2NGwRdwjoRueQQiFA/6Zf+Ns2L5Xqp0M1QGiZrgLE8pGXkzr881Y7vPARxNpDcTR+ctWvlRwX0R3hNkKbEQoccRscxQSDaR/Yel+4LgA2GNRfSClKSiveYpWY6+dYa3T4cWt5UhfD4yyaFC4zEmOL3kCg= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0ca6d05-c4dd-46f5-f04b-08dd8aea11e8 X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2025 09:00:08.4963 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0slrq7+t2fRR68DEfz4nHa/kpnzZZ8qaQuVAmuWSxzBoXKFP/2SEQvxelbexBnnp0BhH3npgAWQlJJYsINy1Gw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB7178 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-04_03,2025-04-30_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 malwarescore=0 adultscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2504070000 definitions=main-2505040081 X-Proofpoint-GUID: WPi_EJTXWNvH2lLG1ZnVq-kiznb9z2-o X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTA0MDA4MSBTYWx0ZWRfXxKoDSrXbin8s 0rK98pgjPiVbbuIuTrs/+Mph26bE1gmWz9G3r+aASVC8lF2Zu0FGNWg5d31IZsn2V39Ryo2zt8O LaTUso/0ATS41On9IPa6w7rwvPv6aZnnJbW8qx7CM/AoWB0Uo3hARidgb0IaZEdQuLXIzX1lewq c0rJ1wLyNsr5StVGN9CI5pWKJQyyIkHt/ipjb1EitA8jyO39/jqbzZ7oqttLFichuuDSMwrkM9E 4vQMBAl3twosAKwQWnATdIFr8mky66A5KWu9fchfU3gn08gFcdMvGfH4iG/iOJko+s4PRaOWDs6 /sWcyGeHJX0kXQzR8bnKkzDiCrP7tYUJfJkAPRQhgBuYOBjqdnRfzkYM2+XUn5OIpiid17+cDU0 H2W1Wo15oBHSr302RSrLjSQWq6vEKlIwZHEXle7XQtMMR+YP23q1Lhz5novVbETm7+x9jpSW X-Proofpoint-ORIG-GUID: WPi_EJTXWNvH2lLG1ZnVq-kiznb9z2-o X-Authority-Analysis: v=2.4 cv=IaeHWXqa c=1 sm=1 tr=0 ts=68172c9c cx=c_pps a=XiAAW1AwiKB2Y8Wsi+sD2Q==:117 a=XiAAW1AwiKB2Y8Wsi+sD2Q==:17 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=dt9VzEwgFbYA:10 a=GoEa3M9JfhUA:10 a=VwQbUJbxAAAA:8 a=yPCof4ZbAAAA:8 a=ZG6D_t86WmhNJCCpPcgA:9 Content-Type: text/plain; charset="utf-8" For CoW-based atomic writes, reuse the infrastructure for reflink CoW fork support. Add ->iomap_begin() callback xfs_atomic_write_cow_iomap_begin() to create staging mappings in the CoW fork for atomic write updates. The general steps in the function are as follows: - find extent mapping in the CoW fork for the FS block range being written - if part or full extent is found, proceed to process found extent - if no extent found, map in new blocks to the CoW fork - convert unwritten blocks in extent if required - update iomap extent mapping and return The bulk of this function is quite similar to the processing in xfs_reflink_allocate_cow(), where we try to find an extent mapping; if none exists, then allocate a new extent in the CoW fork, convert unwritten blocks, and return a mapping. Performance testing has shown the XFS_ILOCK_EXCL locking to be quite a bottleneck, so this is an area which could be optimised in future. Christoph Hellwig contributed almost all of the code in xfs_atomic_write_cow_iomap_begin(). Reviewed-by: Darrick J. Wong [djwong: add a new xfs_can_sw_atomic_write to convey intent better] Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig Signed-off-by: John Garry --- fs/xfs/xfs_iomap.c | 128 +++++++++++++++++++++++++++++++++++++++++++ fs/xfs/xfs_iomap.h | 1 + fs/xfs/xfs_mount.h | 5 ++ fs/xfs/xfs_reflink.c | 2 +- fs/xfs/xfs_reflink.h | 2 + fs/xfs/xfs_trace.h | 22 ++++++++ 6 files changed, 159 insertions(+), 1 deletion(-) diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c index cb23c8871f81..166fba2ff1ef 100644 --- a/fs/xfs/xfs_iomap.c +++ b/fs/xfs/xfs_iomap.c @@ -1022,6 +1022,134 @@ const struct iomap_ops xfs_zoned_direct_write_iomap= _ops =3D { }; #endif /* CONFIG_XFS_RT */ =20 +static int +xfs_atomic_write_cow_iomap_begin( + struct inode *inode, + loff_t offset, + loff_t length, + unsigned flags, + struct iomap *iomap, + struct iomap *srcmap) +{ + struct xfs_inode *ip =3D XFS_I(inode); + struct xfs_mount *mp =3D ip->i_mount; + const xfs_fileoff_t offset_fsb =3D XFS_B_TO_FSBT(mp, offset); + xfs_fileoff_t end_fsb =3D xfs_iomap_end_fsb(mp, offset, length); + xfs_filblks_t count_fsb =3D end_fsb - offset_fsb; + int nmaps =3D 1; + xfs_filblks_t resaligned; + struct xfs_bmbt_irec cmap; + struct xfs_iext_cursor icur; + struct xfs_trans *tp; + unsigned int dblocks =3D 0, rblocks =3D 0; + int error; + u64 seq; + + ASSERT(flags & IOMAP_WRITE); + ASSERT(flags & IOMAP_DIRECT); + + if (xfs_is_shutdown(mp)) + return -EIO; + + if (!xfs_can_sw_atomic_write(mp)) { + ASSERT(xfs_can_sw_atomic_write(mp)); + return -EINVAL; + } + + /* blocks are always allocated in this path */ + if (flags & IOMAP_NOWAIT) + return -EAGAIN; + + trace_xfs_iomap_atomic_write_cow(ip, offset, length); + + xfs_ilock(ip, XFS_ILOCK_EXCL); + + if (!ip->i_cowfp) { + ASSERT(!xfs_is_reflink_inode(ip)); + xfs_ifork_init_cow(ip); + } + + if (!xfs_iext_lookup_extent(ip, ip->i_cowfp, offset_fsb, &icur, &cmap)) + cmap.br_startoff =3D end_fsb; + if (cmap.br_startoff <=3D offset_fsb) { + xfs_trim_extent(&cmap, offset_fsb, count_fsb); + goto found; + } + + end_fsb =3D cmap.br_startoff; + count_fsb =3D end_fsb - offset_fsb; + + resaligned =3D xfs_aligned_fsb_count(offset_fsb, count_fsb, + xfs_get_cowextsz_hint(ip)); + xfs_iunlock(ip, XFS_ILOCK_EXCL); + + if (XFS_IS_REALTIME_INODE(ip)) { + dblocks =3D XFS_DIOSTRAT_SPACE_RES(mp, 0); + rblocks =3D resaligned; + } else { + dblocks =3D XFS_DIOSTRAT_SPACE_RES(mp, resaligned); + rblocks =3D 0; + } + + error =3D xfs_trans_alloc_inode(ip, &M_RES(mp)->tr_write, dblocks, + rblocks, false, &tp); + if (error) + return error; + + /* extent layout could have changed since the unlock, so check again */ + if (!xfs_iext_lookup_extent(ip, ip->i_cowfp, offset_fsb, &icur, &cmap)) + cmap.br_startoff =3D end_fsb; + if (cmap.br_startoff <=3D offset_fsb) { + xfs_trim_extent(&cmap, offset_fsb, count_fsb); + xfs_trans_cancel(tp); + goto found; + } + + /* + * Allocate the entire reservation as unwritten blocks. + * + * Use XFS_BMAPI_EXTSZALIGN to hint at aligning new extents according to + * extszhint, such that there will be a greater chance that future + * atomic writes to that same range will be aligned (and don't require + * this COW-based method). + */ + error =3D xfs_bmapi_write(tp, ip, offset_fsb, count_fsb, + XFS_BMAPI_COWFORK | XFS_BMAPI_PREALLOC | + XFS_BMAPI_EXTSZALIGN, 0, &cmap, &nmaps); + if (error) { + xfs_trans_cancel(tp); + goto out_unlock; + } + + xfs_inode_set_cowblocks_tag(ip); + error =3D xfs_trans_commit(tp); + if (error) + goto out_unlock; + +found: + if (cmap.br_state !=3D XFS_EXT_NORM) { + error =3D xfs_reflink_convert_cow_locked(ip, offset_fsb, + count_fsb); + if (error) + goto out_unlock; + cmap.br_state =3D XFS_EXT_NORM; + } + + length =3D XFS_FSB_TO_B(mp, cmap.br_startoff + cmap.br_blockcount); + trace_xfs_iomap_found(ip, offset, length - offset, XFS_COW_FORK, &cmap); + seq =3D xfs_iomap_inode_sequence(ip, IOMAP_F_SHARED); + xfs_iunlock(ip, XFS_ILOCK_EXCL); + return xfs_bmbt_to_iomap(ip, iomap, &cmap, flags, IOMAP_F_SHARED, seq); + +out_unlock: + xfs_iunlock(ip, XFS_ILOCK_EXCL); + return error; +} + +const struct iomap_ops xfs_atomic_write_cow_iomap_ops =3D { + .iomap_begin =3D xfs_atomic_write_cow_iomap_begin, +}; + static int xfs_dax_write_iomap_end( struct inode *inode, diff --git a/fs/xfs/xfs_iomap.h b/fs/xfs/xfs_iomap.h index d330c4a581b1..674f8ac1b9bd 100644 --- a/fs/xfs/xfs_iomap.h +++ b/fs/xfs/xfs_iomap.h @@ -56,5 +56,6 @@ extern const struct iomap_ops xfs_read_iomap_ops; extern const struct iomap_ops xfs_seek_iomap_ops; extern const struct iomap_ops xfs_xattr_iomap_ops; extern const struct iomap_ops xfs_dax_write_iomap_ops; +extern const struct iomap_ops xfs_atomic_write_cow_iomap_ops; =20 #endif /* __XFS_IOMAP_H__*/ diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h index e5192c12e7ac..e67bc3e91f98 100644 --- a/fs/xfs/xfs_mount.h +++ b/fs/xfs/xfs_mount.h @@ -464,6 +464,11 @@ static inline bool xfs_has_nonzoned(const struct xfs_m= ount *mp) return !xfs_has_zoned(mp); } =20 +static inline bool xfs_can_sw_atomic_write(struct xfs_mount *mp) +{ + return xfs_has_reflink(mp); +} + /* * Some features are always on for v5 file systems, allow the compiler to * eliminiate dead code when building without v4 support. diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c index bd711c5bb6bb..f5d338916098 100644 --- a/fs/xfs/xfs_reflink.c +++ b/fs/xfs/xfs_reflink.c @@ -293,7 +293,7 @@ xfs_bmap_trim_cow( return xfs_reflink_trim_around_shared(ip, imap, shared); } =20 -static int +int xfs_reflink_convert_cow_locked( struct xfs_inode *ip, xfs_fileoff_t offset_fsb, diff --git a/fs/xfs/xfs_reflink.h b/fs/xfs/xfs_reflink.h index cc4e92278279..379619f24247 100644 --- a/fs/xfs/xfs_reflink.h +++ b/fs/xfs/xfs_reflink.h @@ -35,6 +35,8 @@ int xfs_reflink_allocate_cow(struct xfs_inode *ip, struct= xfs_bmbt_irec *imap, bool convert_now); extern int xfs_reflink_convert_cow(struct xfs_inode *ip, xfs_off_t offset, xfs_off_t count); +int xfs_reflink_convert_cow_locked(struct xfs_inode *ip, + xfs_fileoff_t offset_fsb, xfs_filblks_t count_fsb); =20 extern int xfs_reflink_cancel_cow_blocks(struct xfs_inode *ip, struct xfs_trans **tpp, xfs_fileoff_t offset_fsb, diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index e56ba1963160..9554578c6da4 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -1657,6 +1657,28 @@ DEFINE_RW_EVENT(xfs_file_direct_write); DEFINE_RW_EVENT(xfs_file_dax_write); DEFINE_RW_EVENT(xfs_reflink_bounce_dio_write); =20 +TRACE_EVENT(xfs_iomap_atomic_write_cow, + TP_PROTO(struct xfs_inode *ip, xfs_off_t offset, ssize_t count), + TP_ARGS(ip, offset, count), + TP_STRUCT__entry( + __field(dev_t, dev) + __field(xfs_ino_t, ino) + __field(xfs_off_t, offset) + __field(ssize_t, count) + ), + TP_fast_assign( + __entry->dev =3D VFS_I(ip)->i_sb->s_dev; + __entry->ino =3D ip->i_ino; + __entry->offset =3D offset; + __entry->count =3D count; + ), + TP_printk("dev %d:%d ino 0x%llx pos 0x%llx bytecount 0x%zx", + MAJOR(__entry->dev), MINOR(__entry->dev), + __entry->ino, + __entry->offset, + __entry->count) +) + DECLARE_EVENT_CLASS(xfs_imap_class, TP_PROTO(struct xfs_inode *ip, xfs_off_t offset, ssize_t count, int whichfork, struct xfs_bmbt_irec *irec), --=20 2.31.1 From nobody Fri Dec 19 16:07:40 2025 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07314199931; Sun, 4 May 2025 09:00:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349230; cv=fail; b=ixpCAZZRZ/lB3RHSLUzLNhZwcg/1fXdavuXgAyTuo0RI/i/DcVT8bry81BL8OSxGO5fNHe4rBdOWCcFDEiJ3Wi3w8VFeuBh0VpRwdceQCNjD31v07R4jZiNmtnTfDp5WFWBNown2OXdfaZ3ddGaUbAmhBx38Ed97koATjyyHNOQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349230; c=relaxed/simple; bh=9VFmvw8VF1chdP8OjAH5HxqGEv1269P9oeW+EWcQoRk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=GwDtCWDzEQNwBByBhgO0QjOFVYPpdMHA6ZVE7vJjF4weJnAmhkFey8Z8839yznZo0R7z29kCOAYG2JX2NN0Lup0o25EACcI5WFsASPKdGiU9JQSnPtBXsmkkUPB46vedcc3WhPUZ3blyj83R9wdpZrjcaeq4tq01GOWtDMvTMwM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=qHUy6/FX; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=Ll3JYRg7; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="qHUy6/FX"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="Ll3JYRg7" Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5448M51Z029823; Sun, 4 May 2025 09:00:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=j9xxB5gxSLG2TwhErVZly1cUqbdL0R17BVPJ3uUQ5Ys=; b= qHUy6/FXyN8W6GUs3FmUCzNFfTxbO3+Q53ARM65Qng3U9jEXdY/3LEeA/P7ouQpb n3l776Ro6TIho6c3Kd4q7rllvOlXzcs978JKlC0JqBwA++CPtuExMfF9H+nI3tMj n6jvwIlp8iTuNgC7sbSU4nA4kxCuTD7a/pMfmkxCFI6uO9Od1YvZwpb0f0k5LzUx FYisZv8zb3fjjqxCc/Di6O1qex550H63OjFrbtnwv/3/9Eb4pDq4rYneVW+8wa2I q0HpKsHeoiQCOqrJnCBbrwQgMANOgtLulId6qSxvoo9kS3GjJny/n44nad+psh2/ x1Px7V3Wi9p8aVOMv4qHbA== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 46e4nqr10v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:14 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5444Nu7E035905; Sun, 4 May 2025 09:00:13 GMT Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazlp17012055.outbound.protection.outlook.com [40.93.20.55]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 46d9k7ghqy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ib3Bbn3V7PeGuPGb1PGn7q+krttQOLzYY4cnRoBPFBPZR2Ex2A9r6uc2Eyndwn8Sri4pKHEWDU3Uxt1qEnhTymjzJIJafipLNjiuxILFMZtPkhhrLd8AzTD1afzh10XPUf5k3vRyCc3I5zH5vldxEyYNAYIkcRtQXTcscj+54buWQA62018ddoJZwPbaIbyVCKP+TPfPEC1vV0VTjl8WwZva5Q/8kV2BXrjKbIiVUVsWvXXSZ9p3CpeCpKotoq7+unV4EO5Md6U4sm3XUQcCvC9NUnRyRP/h5/CEwa6khBOw52FkQgw1wLrFFiVkKUnoN1AYQjChX0CDBVe4Ttl1PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j9xxB5gxSLG2TwhErVZly1cUqbdL0R17BVPJ3uUQ5Ys=; b=C8t82WQCZpe2QtGzxzw6ukipZZtyO9B5UyR4AWsYarao9uIjVfc3voHVSiMsIuZ5z9+PF2pN/T73VC3ELp81PocBQepfEc6hlGQ300rsqmd7nkbdv//d56Otioup7GhK+xEb+UP/Hrw0sJT0OIQE7KH64aHfwPxBH2iXEDuTLwbEFbnjz8EdI7ig0gTAcg8whP1eF2xVbzumadEbF67K9/xeDkq/eW7iARkJitoaTxqHMp/w0m9cPYNRaeYF1Ft1be6xoR7Fa44gYp8Z4wABnFEOFi9MF2/HT2zi9SrcmSTaNmcbwk/U0YkIBLpvoELLEk5dmjniEuILQpKKpZ/11g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j9xxB5gxSLG2TwhErVZly1cUqbdL0R17BVPJ3uUQ5Ys=; b=Ll3JYRg729Q9Le7sKZzMvI4z3VNNnOqqkuy4JXyg7MhBJ7iGJLAo/ANXPjcGJTFJ00koC5Eypf4lFffvoC3ho54utSK3t+GDMGD7X19eoBcV/mpjFtqn7jTa/Y8eZbYqtmp7xpYb2MvKO6HmvLnzl7XB34MHFY4JDrgkFOBPdqU= Received: from DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) by DS7PR10MB7178.namprd10.prod.outlook.com (2603:10b6:8:e1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.23; Sun, 4 May 2025 09:00:11 +0000 Received: from DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088]) by DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088%7]) with mapi id 15.20.8699.022; Sun, 4 May 2025 09:00:09 +0000 From: John Garry To: brauner@kernel.org, djwong@kernel.org, hch@lst.de, viro@zeniv.linux.org.uk, jack@suse.cz, cem@kernel.org Cc: linux-fsdevel@vger.kernel.org, dchinner@redhat.com, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, ojaswin@linux.ibm.com, ritesh.list@gmail.com, martin.petersen@oracle.com, linux-ext4@vger.kernel.org, linux-block@vger.kernel.org, catherine.hoang@oracle.com, linux-api@vger.kernel.org, John Garry Subject: [PATCH v11 11/16] xfs: add large atomic writes checks in xfs_direct_write_iomap_begin() Date: Sun, 4 May 2025 08:59:18 +0000 Message-Id: <20250504085923.1895402-12-john.g.garry@oracle.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20250504085923.1895402-1-john.g.garry@oracle.com> References: <20250504085923.1895402-1-john.g.garry@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN2PR15CA0030.namprd15.prod.outlook.com (2603:10b6:208:1b4::43) To DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB4313:EE_|DS7PR10MB7178:EE_ X-MS-Office365-Filtering-Correlation-Id: 0ec48e69-afb5-4fc4-68ba-08dd8aea12b9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?bVvdq85UK5pX4+sBOo1v7yDNLY7WeHxTRZ7/TOyuJMAgteZuuwocKm/tahyp?= =?us-ascii?Q?y53klhYyYiqakQSEeQYcqXktbZXMsaXtAE9GBTLLJB8F9olNT9w9yGTt8Y0f?= =?us-ascii?Q?MnhpsO7q72s4NucrLrC6vAUMyBELFwqb0hZIlnWUAMuxvuBGLcPl/kTXUGFL?= =?us-ascii?Q?DVKsRlH7MyOHCInp7isEPcnKVwHnj88h4LK0d94ADQmQSMceQxDZuymohYmv?= =?us-ascii?Q?9fdZ55IlSxF8rfbFUi2k/XbTplqjHs3wBxSasHONnfI0XGT35hB11rZghpGf?= =?us-ascii?Q?IOOW1EZd2/aYeAyCDWOzzKbsZtnChfbr5J440GcpaSb0MwgBhjUhpIiEe+GQ?= =?us-ascii?Q?s93oIFjEnHXegt+Vp8BjtRgRPF2xTkF+Ch7NUXVzG1AJfORSuS3dTCCpxM5q?= =?us-ascii?Q?vEPzj6m++JBXmRW8T7AAc/loC9sjREYPI0LPRPVDr5/meAcroSkmzD4NVDdo?= =?us-ascii?Q?TpHiyG5PSLwBEQ7f05Ir1ZjLlMXNS4uOHFL9mQeYLNWgItjkBaa6XAgTsCWE?= =?us-ascii?Q?oXkxDkLVMtHzA9/lTRzKjH1n7TZOkiskE+xFhf+gA6MLi7eQq7JQcip1QKK3?= =?us-ascii?Q?ReMsiySdLUZmPLqiSjd8U83zSorgTvEh3yTHcQVd7Gg9/suTMQt7K5z9Lza/?= =?us-ascii?Q?jIJec/NrVRANkFXkZzk5fvlB0NB0tKGQWJzhgc4+nvIJ5Xynx4JHDof3f0GM?= =?us-ascii?Q?TL2KhcD2g3j7oZx7/SX62B/P+wAmqa9E/iv61rL/cKUIDnpjO/t8rEHWn1zF?= =?us-ascii?Q?e6pvD45q07MURN31EntE212M2L4I1QJW1K0WgDjUGm++GezuQQPxcAeu+2Xv?= =?us-ascii?Q?GW4hcd82lMZXuTkthkqpzMWapH/gvzl6u0Rc0vqyeRscyeF6M/YUW+0Objdi?= =?us-ascii?Q?SDHS8a5u6qUUReXsPlq6uECY+rL8s+1/SgOt6UXT5UA9Q3Lo0BonwhhV3xTe?= =?us-ascii?Q?fnvL122Z4M4SgbyUt0RGBaAAykOoX4QPDB8cH25gLjTI6SzbaYuF7yhEWw/X?= =?us-ascii?Q?S4EgnmK41deO+obgLUER1FxVqT8UZFhj7kZRRnSV5a2xIKWrzbbHit8lIXdO?= =?us-ascii?Q?uB0Z3XZ9BFeyveu+UKzS1JG034P6hTnI9uc6a7AhGx5SzRUOxeiA9Nch4XGT?= =?us-ascii?Q?FGOEF2CLU5TTaiOUJdPs0kEnLdUeSlbH4jCCNtIOfEClHWQ8DpDpF6XpLO9J?= =?us-ascii?Q?KnbbUtO2IMSoMd6G/krbDFOyThP8hYfsN19zuhGXjs+fIb81dUkTRQeD63xQ?= =?us-ascii?Q?6FE1YrtXcLkX2r/0cvNzrOuRJvrTp/TKk+70PWREtjxrXPEQ28cF5RqspCFR?= =?us-ascii?Q?Wdr4gRP8hnZpjNWZ8U9VvyRVc2Ybuy2jt3dUXewko7KLdt8fT3JytIkRzlXL?= =?us-ascii?Q?0kDLaLSSLXUy9wZGJUW01kDJPHFz86KvWcK4nJEw0DnzAlhWKZTGxIBF1i79?= =?us-ascii?Q?KrCRpawLPcs=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB4313.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?02yqzo2tJD6JVRrKx9yVSU01i3gBKHnqCz8rB3m1qSkyJUtjW4SiKVUmBKUq?= =?us-ascii?Q?R/3CJYmyMN0Jn/HLz+UY4J7Q45m6H3GNh5UH5Jrhgn+WfivkHYax7u0gMmnx?= =?us-ascii?Q?bzt9/Kwv5yBFK4ZNbpPAUt+/fSJU/ue4rtFpLtAPQP69EC/Tntr76yzU31fi?= =?us-ascii?Q?zRCASaiEnPbTcZT0V1YVhvRYDZsh7wnUnFzwaZVgh5ICogHHQdMVHEEfPkvr?= =?us-ascii?Q?qRjCy4uuhQVeRhEDqUqnjTuP7o6f/1LDnLgDQL6jtDOSpATgQS55IwiQ8lA4?= =?us-ascii?Q?7t8meDyjxD+cpDLnPV4eBbJJTB4bOy/OOZs3elIqKZe4Cw+8On38Pz3O84Pj?= =?us-ascii?Q?bzuxX3+6z+JUI/DMESRet2UWAiX/7HOObg36Fl3m2LYOf0+WhMh/zToSsDlt?= =?us-ascii?Q?UuHj8Vt/g6IN8EvVtoEQjcF7MDr4cS6AsTNawI0yG/TPupSjAPq2TeNHnfDc?= =?us-ascii?Q?IiE0HA87VnX6z8YKlb+nuypJKJA4B4q94hnfi+ol9ofVbBbJgQtjzdAKcXnC?= =?us-ascii?Q?Tuw2wAAE2YTB16hoKMO86YdRyzbUo0c99y4TmET04kCqniNYaSOjBhA8Uqca?= =?us-ascii?Q?ZxqbVdn1sJE0CUWRp1hHOeDJxbqtnaABRx3pAlgX33b9JyEUu9DS+HG/OSN5?= =?us-ascii?Q?uaRH0DDLtUPSh2GWM9B+440+US04kvlYFp+oW4GsfYYYmFuOQhsK/b0Tc58M?= =?us-ascii?Q?iGoyGDk09YgbxqgHa4H/a7Zu/vcv0NtwXAdHwxboPurbgr9ejBEoilm6p7PP?= =?us-ascii?Q?fHxYOx27RwMIqqIxceQYAE0k2+vk77a58CPIq8k8qUji9OZoR+3dF/5CsBYS?= =?us-ascii?Q?88atv9ycDXojJmejuw8jDHJKxTd8RApZQNmsOshp+bWg3+4R/OB8sZnDYDW0?= =?us-ascii?Q?m3unK48mht3CimEygdqViYzOD0oD7sHfnS8xARRRYi44g0/22fSRpoNhZhU8?= =?us-ascii?Q?KEVP47xNLoy9RMVdmc4DCaEqfNA2819DClSsI2YwRXocN6hA+jxEu6gjyxYp?= =?us-ascii?Q?CKZCTDfvZbampJLPH9roY0zg8g4EFNB06TwXy9vHatVScqlHMF9TDaLVn8+M?= =?us-ascii?Q?Ka1EAGEz2g3N+HMqWq/O6XRnpGPKULuOpqnMlx269TnLi9flRKMxz1rbAiWE?= =?us-ascii?Q?F24iuVStX7xYhh4PpjryTDJhawyztvJNyCPytPTu2bU+jBohSx0+ABkT5jvQ?= =?us-ascii?Q?KUme4zHHekhsDGLdS2e92wodaNraTuQMSSl9b6dG+tW310yTonmZ/a76AR3U?= =?us-ascii?Q?lnmcX60o6Z5DkuO7gC+GEEThlzqLBJWrxXuzoBsgohyAR7AE3pDyGd0kJhp7?= =?us-ascii?Q?3iu1KXsTsuB9Z7C84n1+aM3hMvjMnifl63xSwrr1VMbT8SyDwtTmjIiGKQmP?= =?us-ascii?Q?V8F/k2NwCYtDvQdUf4pYc5W6HrV0ibPxQXSIuQ2OywByq/XtQkPsxjgI0H1u?= =?us-ascii?Q?trxPUw+bEI7umKp1wim3GTTktcy2hgRedEHlJM3bQZaJFeSBk2fEubdY5KyT?= =?us-ascii?Q?gc7299lS07AnMhbzmhB9Pa0K7mH0XyU/g36dhQjmntqbzgXJstyiGFB4BkSN?= =?us-ascii?Q?xOcgI7eKN/dr4XK57wGOo9/WZnEP0bVU7pbSqFkls+OCuNLgYoWASIze3Jj8?= =?us-ascii?Q?YQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: h6x3aw245yH46KhHt9KsX+KpGUqDfeeWXwRoxciTJKy0WnBs3dyNr+hgTYDniZjdgQWoPANciXK++D9A0AfmRYztonpjlW4nhQ33FVn0YQWYc1/4eBA7oOwCu8S7betCq7xdkobRCkiQApcK+SWWrZAyE6VG5dod8UaxntuG5Xe5eV+fpAyAWwy5dBbcDYa9n50ithgDvYoXj/I8bA5l/xbjgUpdUSshSMwgrehupwNpezocnU1KJlXfYwsDRk4OL/7BuM1DLF4iy0AbOoGfCeRpNy6R+YUM1AYpyQZ4wcVNAhusLZTN0KF3zCdsfD6ucxUZFioViM1j3yk7nQPZmFQ922F/XP/aoI8CZdV0eYUpmavq/xgPz9UtsPygW4Z1JR50QT0yOZ5DzW9vHJJMbT5EOwW2/P2Lk4ZHmGahP3/lfjjUw2X0hUFNJpBkSrfA0/K5lyXVZoBeUBSoo6h7drjKR9pyErgUodatRcTPv7EslfUUfoAtehgozjYTiU7Ewu1lHWAHt6jDSFA7kVtmhLocHbBUHkdlJORlFtA7YMGZWdhUv5owfJ27LVjJC93aoPeJ4vBWrjh/lg66zAT+FQiK+EF8RgkA9KK6uDDg65M= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ec48e69-afb5-4fc4-68ba-08dd8aea12b9 X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2025 09:00:09.8571 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Sk++8BdQtLrQtQ5hYWYQO9mb3UPYpbi+1JYfFXppgsbdMbbk9Ra41GhB2k7kM6tRnEl6ixI2XZPE3Npp0l/b2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB7178 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-04_03,2025-04-30_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 adultscore=0 phishscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2504070000 definitions=main-2505040081 X-Proofpoint-GUID: BJ0FETulqHbdlsbZtl2uUWIVW3dtPNC6 X-Proofpoint-ORIG-GUID: BJ0FETulqHbdlsbZtl2uUWIVW3dtPNC6 X-Authority-Analysis: v=2.4 cv=PouTbxM3 c=1 sm=1 tr=0 ts=68172c9e cx=c_pps a=OOZaFjgC48PWsiFpTAqLcw==:117 a=OOZaFjgC48PWsiFpTAqLcw==:17 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=dt9VzEwgFbYA:10 a=GoEa3M9JfhUA:10 a=VwQbUJbxAAAA:8 a=yPCof4ZbAAAA:8 a=7Xr6i1Xs6TsDAXCDpIQA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTA0MDA4MCBTYWx0ZWRfX5ERaMfIla8ur zY4+zIJmL4d9wdBrdU5i8HOwc4pGgBji2+wZaOG8XZUi1HX/OEue31QOivi5xROChTC7TebQyTI HgRFXsn2D+suyxAYYbKx+PGVtSc/BlGokddGTSpUJ66hRBhwki2+x9WR3A14NV7LkNmeBHp9dR/ 7xMTLhFo8XJRncBRJsNP8asnqyUNZDJ4DRaa466MIw2IxR9sjVPoBov5Q0/PDtz2NPuK6ig+6wZ 5S8dfjETj8YJqzsD571my5eyDeNQ8+rmfifZ46oDxHCU1iDpDZJql2Wxk2dAAxi+Ka6tnE4vh2N ndPgN+0ztev+zs61IEYwMOw8/p+uj2rK//A+HQFVnDhMr0ylSwFQ4XnD4KHnRxI4zVbNR4K/W8y Yygz5kGmumm3VNBsiPYeEzffcSEaZ67Yo7IE2iUrORDOQeRL6w83Uss0T+pWcx4VYfIJsxV1 Content-Type: text/plain; charset="utf-8" For when large atomic writes (> 1x FS block) are supported, there will be various occasions when HW offload may not be possible. Such instances include: - unaligned extent mapping wrt write length - extent mappings which do not cover the full write, e.g. the write spans sparse or mixed-mapping extents - the write length is greater than HW offload can support - no hardware support at all In those cases, we need to fallback to the CoW-based atomic write mode. For this, report special code -ENOPROTOOPT to inform the caller that HW offload-based method is not possible. In addition to the occasions mentioned, if the write covers an unallocated range, we again judge that we need to rely on the CoW-based method when we would need to allocate anything more than 1x block. This is because if we allocate less blocks that is required for the write, then again HW offload-based method would not be possible. So we are taking a pessimistic approach to writes covering unallocated space. Reviewed-by: Darrick J. Wong [djwong: various cleanups] Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig Signed-off-by: John Garry --- fs/xfs/xfs_iomap.c | 62 ++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 60 insertions(+), 2 deletions(-) diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c index 166fba2ff1ef..ff05e6b1b0bb 100644 --- a/fs/xfs/xfs_iomap.c +++ b/fs/xfs/xfs_iomap.c @@ -798,6 +798,38 @@ imap_spans_range( return true; } =20 +static bool +xfs_bmap_hw_atomic_write_possible( + struct xfs_inode *ip, + struct xfs_bmbt_irec *imap, + xfs_fileoff_t offset_fsb, + xfs_fileoff_t end_fsb) +{ + struct xfs_mount *mp =3D ip->i_mount; + xfs_fsize_t len =3D XFS_FSB_TO_B(mp, end_fsb - offset_fsb); + + /* + * atomic writes are required to be naturally aligned for disk blocks, + * which ensures that we adhere to block layer rules that we won't + * straddle any boundary or violate write alignment requirement. + */ + if (!IS_ALIGNED(imap->br_startblock, imap->br_blockcount)) + return false; + + /* + * Spanning multiple extents would mean that multiple BIOs would be + * issued, and so would lose atomicity required for REQ_ATOMIC-based + * atomics. + */ + if (!imap_spans_range(imap, offset_fsb, end_fsb)) + return false; + + /* + * The ->iomap_begin caller should ensure this, but check anyway. + */ + return len <=3D xfs_inode_buftarg(ip)->bt_bdev_awu_max; +} + static int xfs_direct_write_iomap_begin( struct inode *inode, @@ -812,9 +844,11 @@ xfs_direct_write_iomap_begin( struct xfs_bmbt_irec imap, cmap; xfs_fileoff_t offset_fsb =3D XFS_B_TO_FSBT(mp, offset); xfs_fileoff_t end_fsb =3D xfs_iomap_end_fsb(mp, offset, length); + xfs_fileoff_t orig_end_fsb =3D end_fsb; int nimaps =3D 1, error =3D 0; bool shared =3D false; u16 iomap_flags =3D 0; + bool needs_alloc; unsigned int lockmode; u64 seq; =20 @@ -875,13 +909,37 @@ xfs_direct_write_iomap_begin( (flags & IOMAP_DIRECT) || IS_DAX(inode)); if (error) goto out_unlock; - if (shared) + if (shared) { + if ((flags & IOMAP_ATOMIC) && + !xfs_bmap_hw_atomic_write_possible(ip, &cmap, + offset_fsb, end_fsb)) { + error =3D -ENOPROTOOPT; + goto out_unlock; + } goto out_found_cow; + } end_fsb =3D imap.br_startoff + imap.br_blockcount; length =3D XFS_FSB_TO_B(mp, end_fsb) - offset; } =20 - if (imap_needs_alloc(inode, flags, &imap, nimaps)) + needs_alloc =3D imap_needs_alloc(inode, flags, &imap, nimaps); + + if (flags & IOMAP_ATOMIC) { + error =3D -ENOPROTOOPT; + /* + * If we allocate less than what is required for the write + * then we may end up with multiple extents, which means that + * REQ_ATOMIC-based cannot be used, so avoid this possibility. + */ + if (needs_alloc && orig_end_fsb - offset_fsb > 1) + goto out_unlock; + + if (!xfs_bmap_hw_atomic_write_possible(ip, &imap, offset_fsb, + orig_end_fsb)) + goto out_unlock; + } + + if (needs_alloc) goto allocate_blocks; =20 /* --=20 2.31.1 From nobody Fri Dec 19 16:07:40 2025 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35CD81993B2; Sun, 4 May 2025 09:00:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349229; cv=fail; b=uI+kDRZr+TlKL9qzyIj3f62jMHpuogRZbT0+80Ju5/UndonTOwX58TCTxeIv0x4jdk52+Lmbsw5wBNrIXHSlfKFh+aRPxV4ijsdBV0ItSULSWuLWm7fDgySe6Pw/v4xVI0Q5pD8ONogJom62kN8X3c9ZChLyb1HRSnl7jB6nClw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349229; c=relaxed/simple; bh=lESyKXmcD/WIInZy1ooaRbLsrQrEG0WmZvzyJ3JgkqU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=fAMnPoabOl14okQLMq3spnw+F5I3kB40zcY8SegyMciw5TILoW2cUNbXTphOtgRyY7hJqCsZzIYmDbjIP+e7LqHIvffG/75IyBocB51oKJ0lG+FFmMABiIkjxU3/TUqtJi27WpR5He7yPbSNhlqJdi0RjB/h15LdYJFWn97Sk2Y= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=KrOKf13x; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=jtMr7yYQ; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="KrOKf13x"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="jtMr7yYQ" Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54483pjF022462; Sun, 4 May 2025 09:00:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=ditZR8XzZpGzgHP6gzZd9TEojSztMv1kem5aHGLO5UM=; b= KrOKf13xYA61kRoTLErdOTR3kNw7Ooqsv4BhZ+A8NGEZfRYwtz9PU2Of8+gsvEkc /52hT5JO5d1au+gxRqq/u3D/O76+SXO5u2EQp/lNwSAN/1iddE+qWTDAGZB8szgZ CKwiAolX0xlH480saUidwTB5TEVZiBMmuC7TpsMsRirfogX05i7FuorOMvxe7qLe EisAfV+5DGJOkZG4Tw4tNDWI360YPwaEN4OMTXBAjU69OLjIWeyGb2QuuMGIbaVc 8McxPcP/0iuVb95g0gzuDQUGEdNtnP3h6o3cQRSJ9h+Sm+8G8urPrgI9a4rmnve/ aFhfO1455mqSodkvuGxG4Q== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 46e45cg24q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:15 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5444Nu7F035905; Sun, 4 May 2025 09:00:14 GMT Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazlp17012055.outbound.protection.outlook.com [40.93.20.55]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 46d9k7ghqy-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GITCzhQp6EKSmWozzEGKwYNYdWZgbIH28oPE8ZV6z4kEqei5+M1t4DABsK18AK3d3zB1p4gbASKLnI2Q7siKnYfh4x+W5m0ytrIQzHppB981VH/mK3UUKU+c20Xdui1DnjK6wAlE8SLrKFsaYwsdRsrKU1fdOlA0XPVcLN2VQ0xz96HKZp5/Ey3SkvHBiQPEtO98eatgdvJzv6TFnE5d9c/IgyaF040f9iP0IZ7rmti8zHwtOhcAwQFJxH5BD7A22PlP6jy5JmHuJRewsSAUPRiVXr5yaPcqzxXO3ASnM0o7mVwRoylhJqv5Z06LLzpRLnXW+goPBXuGp+6KWcK7oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ditZR8XzZpGzgHP6gzZd9TEojSztMv1kem5aHGLO5UM=; b=vUMDWcpX6+ZSp9yLHkFYAWqaIh5O7cf68A9v5xI6XUsQBYKJJGC6IZzj4/0rhgIo7rOmteEHZQJ8sdk065mpV4hXp6oviiIGQa5aRjfNqWe4R3RZbCbgMypZTNq52rwNGYA7DkGiEABYsbCFG9j1TB/Vg+lwSt5uQzc7ZgpwyIQvXW13SdIQDk7uRiuK98IChkEm+nEykEb5W2PQK8Grtlpa7/pBZHIyl80AYG57EpAvWk7heZ7mLJ9lcArrgrdGGsnVTo/IKVJnhDskS21rjaro/PKb4Cz/XGjb3eulL/LX2/QKEamYCWCn7U/HsFA+PTDVVYoFJ1cXABeRsHH54Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ditZR8XzZpGzgHP6gzZd9TEojSztMv1kem5aHGLO5UM=; b=jtMr7yYQyKSLuLxEAyT++3Vb1O+Lxq3ADVcQtAqnCquUW2aYYXealfzURydiNCk6NWTGU+4XS3ACLx1SI+iP0dwnFgFb9+X4QLZK3FzDQV8qIvPo9QOv1BmUVc/Emozbi3q/Lis2unrLBeyR46pGY++loNxh+NHh7nyI2C2bFCs= Received: from DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) by DS7PR10MB7178.namprd10.prod.outlook.com (2603:10b6:8:e1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.23; Sun, 4 May 2025 09:00:11 +0000 Received: from DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088]) by DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088%7]) with mapi id 15.20.8699.022; Sun, 4 May 2025 09:00:11 +0000 From: John Garry To: brauner@kernel.org, djwong@kernel.org, hch@lst.de, viro@zeniv.linux.org.uk, jack@suse.cz, cem@kernel.org Cc: linux-fsdevel@vger.kernel.org, dchinner@redhat.com, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, ojaswin@linux.ibm.com, ritesh.list@gmail.com, martin.petersen@oracle.com, linux-ext4@vger.kernel.org, linux-block@vger.kernel.org, catherine.hoang@oracle.com, linux-api@vger.kernel.org, John Garry Subject: [PATCH v11 12/16] xfs: commit CoW-based atomic writes atomically Date: Sun, 4 May 2025 08:59:19 +0000 Message-Id: <20250504085923.1895402-13-john.g.garry@oracle.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20250504085923.1895402-1-john.g.garry@oracle.com> References: <20250504085923.1895402-1-john.g.garry@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN2PR15CA0024.namprd15.prod.outlook.com (2603:10b6:208:1b4::37) To DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB4313:EE_|DS7PR10MB7178:EE_ X-MS-Office365-Filtering-Correlation-Id: ac2d866b-4f2a-4e3d-abdc-08dd8aea138a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?EFfMmxV3BFpVuBEVqEIJpGOYpDiYG7uWAObBR1SM4wSA5grUJ4KOvuRv1Csg?= =?us-ascii?Q?WA5Yw6jtPevyj+P5oCuN/SdlPOextL/ym/hDAK4Or5QSeoWxvPUlRfgnZ8TO?= =?us-ascii?Q?gNtOv2jXb0F4Sz7zC6zhh6eCR/F8I1+9Po2pXzgBmPX72asTgk+FiB8QfRt7?= =?us-ascii?Q?fj1P53DY+EHE+7l7S2QZ9zn6DZ8O35dpReN7zU/fq/GdBT7UrNjdpe78rNbO?= =?us-ascii?Q?ZH7kxWv9NkJ0vmZDif0jIeiesDfrzGPnks76YZtKvZRE+U2RUe/y4/mnSrx+?= =?us-ascii?Q?lwrmEYn4XF3I2RH9He9TgeIeMYZcMSR5WX1BwvmNjJ51ELCiMz1sYF5qFQmt?= =?us-ascii?Q?/YjkzsqaC2DrG6wo0OgffuSMF4NpTPMoVWBfuvt9Tt99BLgSnBqdT0Qk046m?= =?us-ascii?Q?MUYo7VZy0rhnPKRW10U2QWCdM19Jz7dEzb9fQk4H8NUsg1qOs8bdW544PWMb?= =?us-ascii?Q?rFHs6QUyfwLtQGBr9vX3HvRqZTtW7mPxhLZzwJD6apx32YW4poRQtBvn4vX2?= =?us-ascii?Q?LPiV82l6dBPFVObnkEczg/ru/qBH89k4hlxUUNDoklrUOVBJIAIYL/ixMmE0?= =?us-ascii?Q?qlHqcDAE5B2GhIM6VNgP5uz59Nruaf6JQIKBl3HMeQ/SdkPBeY3lck03okPe?= =?us-ascii?Q?cYx2wGN7xZKVgX9t644jmLBytcEMc8OCb3wJXHYT6gzdyId/uRO0h6UyYIGf?= =?us-ascii?Q?YpSsBaPkDFJ2PY92iI+Nxl1J81mNsU43liz5mRUXm+zG/D78mviTHh03skKo?= =?us-ascii?Q?wNvwBa2BxBiEqYpfM2CtHgF+IUNiccAFhAuj90t1h4ZGdm8vlOtDB3aGaumc?= =?us-ascii?Q?6Xi3q4QBu+mCBHFxoqU0e++Y9jLijlVCkmwbJ+Gf6/vIr64wMR81Xhynz5hS?= =?us-ascii?Q?sddhONBHuvSSsPq5jkGFyaPwYfDCb/S/7PP0JORWOva5nuV1GkDU1eR5uuRI?= =?us-ascii?Q?GXhRCf6hu6lVn3FS5+tgLJvfm4c3Fgtuw6057IlPo1M1Kom+81GpY9BvLwTR?= =?us-ascii?Q?IH5fXeaIZpkq+UNRzZLQg2NX0aa9MIR50Ydn4hAGPkW3x/+KKENGMkW+eOGM?= =?us-ascii?Q?XmFz3bxGs1FwKew9S2ljhoDDSekn5PzDlBQ7NGi8l0Sb1T/g1ObuinHJ73Gt?= =?us-ascii?Q?LMx5+FbOt2wnNjezCbbDUREZeD/jI26ZMiJm0qTdHCb0kV2pj7cIDirktUa/?= =?us-ascii?Q?9ZTVOGYlCcR7F7ZEhyUJ0v45PiUd6L9q6XJsCum/mG8IMrvzropmdIl8Bujh?= =?us-ascii?Q?7VOsOHPe+3VLuVM+f3SSMYWLEssuS7uejQb59RsAFbQ3k4pyHFzrgq+KbP84?= =?us-ascii?Q?b1Uj20yIBuePIUuiG1Kq72epkjSslGdhA1Ace1F/d7QBRMJNMqmRQKn6N+/e?= =?us-ascii?Q?5hxH8iEgZOO8viOvcIUrNUOPiMOKZwr33P2GysBnMflGbhcK0NcbK0MVakmu?= =?us-ascii?Q?0ez5ySj7dYU=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB4313.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?F/8jRSNPyv1aWzKKvDyKNx6O51jirgStIZ6Ktg5BtijYlON7j9l0UCahhGJd?= =?us-ascii?Q?TJmF1ZPNcbxCgqQV6etOYmbAhJZA6q3Mz9NWUJCoDOiL6A6FAza8LbpI4JZB?= =?us-ascii?Q?P40a5dZ4SWu7Ox9gD1tFrNcIrcTN7NdDhsthnOZJ/KJdryZOStqY1R5OVvcz?= =?us-ascii?Q?fTBgNffUCK7pBK2P/Efr2ne67b7IAU9atz7lDNKqaOkWSOqrk+vSBmxnjpkN?= =?us-ascii?Q?fxZaD0WZh8R1JZ++wMWSSsnRZkleBrAAfGQpJDQ0Inb1lFsJTfLInDcnPjek?= =?us-ascii?Q?gV5xr1PShslcdPXPg1ustcD+vE60/3nEY7XFCzZkdk51FpQui2g43DZOuSpF?= =?us-ascii?Q?c/FstHBCBrqZ5nbfDTaKG5ygU8h7dTF7quzgHGvlgmL8QMy3InKhyWSqENwE?= =?us-ascii?Q?syP7k3tXFiqIdTHDeaSoy/pEM5VxdFGIoyQf2KtpFrtIsQb6OqHhV+Fyaeev?= =?us-ascii?Q?n/1ylOBncp77i8Z1h6e+nhQGQICZHxQES/VHhUgjvHMImS3Iq0xwWYOMBRqp?= =?us-ascii?Q?kC6aCrdVuuPhpR/SNYa+zpyl6/xfy9SmlKi4AtC6B762n4S5cP40U3eU22KF?= =?us-ascii?Q?/k7axx309lKeMpghefy+0ZxJsmEoJWBDJbor1g23Fy+TXI1HGPXyl4lMqmMS?= =?us-ascii?Q?28hkGUJKasfjpdtLot7eYGT5amMt7d+WcshUJjjhX322/P/oQnMYypg/xjgF?= =?us-ascii?Q?nv4ks9NgLNVMlrXJTnwcTmE0tXyBgvsA0PrHsBhWea2XmyQ/2i2C1G8gXfm0?= =?us-ascii?Q?FOa3NnVD9QdNBJcnGe2TPY4hvS/SCspfEWL/BYDCaKTxwaNpJb23PVhtOun5?= =?us-ascii?Q?NlmBzi4kR9Y9J6t8o1UKW7s21EAecKC4FnxmZ8/Eh1KHzKlAtKlzZhPKLEpp?= =?us-ascii?Q?rWLQ5RC6ZGnpurJ8EawbtJsWqDZchq+DoPXgzW/45E5KpM3htusrKOk1azZh?= =?us-ascii?Q?Drq/tF9uW2HRlm9lYpMv9eL4vobksdXUbSjg91lDIwYAzJyqXUo/9ErSIx2L?= =?us-ascii?Q?3ko4V88p92lM2ayOsu1BfUhwhShyM7ppOEGsswzcupF75gFf3VvxkdrXHn08?= =?us-ascii?Q?ME20/ty5fQzBzJTUnZMBaMONusuxhUtrZdEqY87ob1JsV/3zBJzEQEKc+2ry?= =?us-ascii?Q?lJesGLulwhwQ79SHLtAO6JGwdXpAJmqMMKrYDMQbkYSSfXhfv91iVL3V2Ay/?= =?us-ascii?Q?GfMv1DvBZVjPH24THSX9/F49DPv17132SkMwCYxp4IK5QM0yTDM21z3LCw01?= =?us-ascii?Q?zr1Tz7NecQ001TiqWIIDMKboXzY2LxvpEusVIACPhT8tELYFhoWz+Yxn5nb0?= =?us-ascii?Q?74YD4xMzg9W2GTD64r/HaCD1vtbr3vqyXHY0s4WFam+zq8uVUuX7aeKAziNr?= =?us-ascii?Q?hf2WJkrzR/Mf9Do5or+WAQXliMYvGbwiwtLv9AopddtSSb+ZVinGdgBEOAw4?= =?us-ascii?Q?S3pjlIEUOTUY1gR9LOCO4AngwIFPZxtH+6RPYjWRgSAS4Bo/KdF8R+bLe9NL?= =?us-ascii?Q?SLwvTKSiqKPQgwtUOwQe3ef3yaXIRORko8GokNS8jYsMW2Sp4Vqed7/K/Ye5?= =?us-ascii?Q?S5QGsP/p/NKRIkqnNHW7ovogR+YMt8vR+S2VJ3AKeyf/b0O70xxAyVbibjJG?= =?us-ascii?Q?vA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: vrFAZYKiSKUE9szCsN5LHhAlHU+geBgFUIsfgCyA7kJc6DMvna8iU2qLm/iQQCkEKmn/ojGtZa95pFkE23tVVFlhLbb5pyowvKXAnhbelBuKwarWiHo543WPhfqXyKgEAda0GZXa3go3/lsGFoXuPlKUEbf4CojWz9zwlArxj3RQrKJee4giLr1cNUpSMDB1MaKGpcZ+DHG8PNgoJ+tvAGm91CDeAwAQtYiw4tVRfoKR8BJOkNDdjv4+8THkEhvmnwkLYk+9xm2dymzUTfYWe2dAUBv/ClCYYO2xgSv69zjO4HuOZBwDFJYl4lS9Ue4j0gTtfZ5u32cUalDDUu/V0iemF0Blzrdlks5n6YJ13qP2OkSQ9tXhkmB1QkEGqoj6ACJuWYh/Fc0Ux+qEoIX9etHZGc18mSDGI4HkvnVVQymTmE+cnmj8H3vmYETYNTrsJ1Idgq2V8SDrflHPEx4V4ZGrsRS4u7Zy1L+i8kQMukbV8OYIK+Bt9W8D/2b3Fq79yGrK5Nd9sAGNsoNdvGKcz6Us6RQKNaziusto79vyQfdg5mYeecVwqT6k9OZe+n/9ZkdPkv4IO8bZ49eyJfGHAbBn7QETXgz1f7ILZz7z0K0= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac2d866b-4f2a-4e3d-abdc-08dd8aea138a X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2025 09:00:11.2808 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YHK6NbRqtb2BHLQVrsYqwhPHw/UEBY4y6W1Dvkf3vyUw2Fa/viwkNbEUx9p+ngIfO7rCJkJHIaKcbTvtRz8YAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB7178 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-04_03,2025-04-30_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 adultscore=0 phishscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2504070000 definitions=main-2505040081 X-Proofpoint-ORIG-GUID: 6TE8HyAlYEJ_n6aqSwTvfi4cV5ygqbOC X-Proofpoint-GUID: 6TE8HyAlYEJ_n6aqSwTvfi4cV5ygqbOC X-Authority-Analysis: v=2.4 cv=IIwCChvG c=1 sm=1 tr=0 ts=68172c9f cx=c_pps a=OOZaFjgC48PWsiFpTAqLcw==:117 a=OOZaFjgC48PWsiFpTAqLcw==:17 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=dt9VzEwgFbYA:10 a=GoEa3M9JfhUA:10 a=VwQbUJbxAAAA:8 a=yPCof4ZbAAAA:8 a=psqDkX_6r_7HCtZpQ-8A:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTA0MDA4MSBTYWx0ZWRfX0mAPKJ9gtdd3 us8RXbt7FuiMdIn3XEq6Orhz6kGmBrQhoAdF4XRjgFaWnmU8mfKoPJ/3vfT8a3zyxksU0MyK93t WM1XzDSzCjs6uCFv6Qh7dBKDXG7XAsMaylYvmXnkzZ7dQwldEas1OrqFjqIu6w5ak8QqZSoqiaa Vag8oGS6IgmyF+jvSQhzzXec9P0cydB5Dz8CIEP/mpGp0OYatzV0/2WBwqXR69nh7LvfkqEnO6L SE193/SFJOubWp2iBOntfnK+GyhtnvgULTorxmvBcFPNxsHmIfV12r6yx6IFunGzKpE9EJ2o2vm jMCLYJiwECuA6R3+UmQ9c6NQBXgqtsr81TTup545TP0l91qKrF+qVyZS9dFf4E3+hqgGv427KkR OkshNjGisGoo1MCaR1uATucFnJ/C+9BYR7vLp2xGjLSS8NMxQPd7xs7n73Fo+9s/HBS9hiea Content-Type: text/plain; charset="utf-8" When completing a CoW-based write, each extent range mapping update is covered by a separate transaction. For a CoW-based atomic write, all mappings must be changed at once, so change to use a single transaction. Note that there is a limit on the amount of log intent items which can be fit into a single transaction, but this is being ignored for now since the count of items for a typical atomic write would be much less than is typically supported. A typical atomic write would be expected to be 64KB or less, which means only 16 possible extents unmaps, which is quite small. Reviewed-by: Darrick J. Wong [djwong: add tr_atomic_ioend] Reviewed-by: Christoph Hellwig Signed-off-by: Darrick J. Wong Signed-off-by: John Garry --- fs/xfs/libxfs/xfs_log_rlimit.c | 4 +++ fs/xfs/libxfs/xfs_trans_resv.c | 15 +++++++++ fs/xfs/libxfs/xfs_trans_resv.h | 1 + fs/xfs/xfs_file.c | 5 ++- fs/xfs/xfs_reflink.c | 56 ++++++++++++++++++++++++++++++++++ fs/xfs/xfs_reflink.h | 2 ++ 6 files changed, 82 insertions(+), 1 deletion(-) diff --git a/fs/xfs/libxfs/xfs_log_rlimit.c b/fs/xfs/libxfs/xfs_log_rlimit.c index d3bd6a86c8fe..34bba96d30ca 100644 --- a/fs/xfs/libxfs/xfs_log_rlimit.c +++ b/fs/xfs/libxfs/xfs_log_rlimit.c @@ -91,6 +91,7 @@ xfs_log_calc_trans_resv_for_minlogblocks( */ if (xfs_want_minlogsize_fixes(&mp->m_sb)) { xfs_trans_resv_calc(mp, resv); + resv->tr_atomic_ioend =3D M_RES(mp)->tr_atomic_ioend; return; } =20 @@ -107,6 +108,9 @@ xfs_log_calc_trans_resv_for_minlogblocks( =20 xfs_trans_resv_calc(mp, resv); =20 + /* Copy the dynamic transaction reservation types from the running fs */ + resv->tr_atomic_ioend =3D M_RES(mp)->tr_atomic_ioend; + if (xfs_has_reflink(mp)) { /* * In the early days of reflink, typical log operation counts diff --git a/fs/xfs/libxfs/xfs_trans_resv.c b/fs/xfs/libxfs/xfs_trans_resv.c index 580d00ae2857..a841432abf83 100644 --- a/fs/xfs/libxfs/xfs_trans_resv.c +++ b/fs/xfs/libxfs/xfs_trans_resv.c @@ -1284,6 +1284,15 @@ xfs_calc_namespace_reservations( resp->tr_mkdir.tr_logflags |=3D XFS_TRANS_PERM_LOG_RES; } =20 +STATIC void +xfs_calc_default_atomic_ioend_reservation( + struct xfs_mount *mp, + struct xfs_trans_resv *resp) +{ + /* Pick a default that will scale reasonably for the log size. */ + resp->tr_atomic_ioend =3D resp->tr_itruncate; +} + void xfs_trans_resv_calc( struct xfs_mount *mp, @@ -1378,4 +1387,10 @@ xfs_trans_resv_calc( resp->tr_itruncate.tr_logcount +=3D logcount_adj; resp->tr_write.tr_logcount +=3D logcount_adj; resp->tr_qm_dqalloc.tr_logcount +=3D logcount_adj; + + /* + * Now that we've finished computing the static reservations, we can + * compute the dynamic reservation for atomic writes. + */ + xfs_calc_default_atomic_ioend_reservation(mp, resp); } diff --git a/fs/xfs/libxfs/xfs_trans_resv.h b/fs/xfs/libxfs/xfs_trans_resv.h index d9d0032cbbc5..670045d417a6 100644 --- a/fs/xfs/libxfs/xfs_trans_resv.h +++ b/fs/xfs/libxfs/xfs_trans_resv.h @@ -48,6 +48,7 @@ struct xfs_trans_resv { struct xfs_trans_res tr_qm_dqalloc; /* allocate quota on disk */ struct xfs_trans_res tr_sb; /* modify superblock */ struct xfs_trans_res tr_fsyncts; /* update timestamps on fsync */ + struct xfs_trans_res tr_atomic_ioend; /* untorn write completion */ }; =20 /* shorthand way of accessing reservation structure */ diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c index e8acd6ca8f27..32883ec8ca2e 100644 --- a/fs/xfs/xfs_file.c +++ b/fs/xfs/xfs_file.c @@ -576,7 +576,10 @@ xfs_dio_write_end_io( nofs_flag =3D memalloc_nofs_save(); =20 if (flags & IOMAP_DIO_COW) { - error =3D xfs_reflink_end_cow(ip, offset, size); + if (iocb->ki_flags & IOCB_ATOMIC) + error =3D xfs_reflink_end_atomic_cow(ip, offset, size); + else + error =3D xfs_reflink_end_cow(ip, offset, size); if (error) goto out; } diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c index f5d338916098..218dee76768b 100644 --- a/fs/xfs/xfs_reflink.c +++ b/fs/xfs/xfs_reflink.c @@ -984,6 +984,62 @@ xfs_reflink_end_cow( return error; } =20 +/* + * Fully remap all of the file's data fork at once, which is the critical = part + * in achieving atomic behaviour. + * The regular CoW end path does not use function as to keep the block + * reservation per transaction as low as possible. + */ +int +xfs_reflink_end_atomic_cow( + struct xfs_inode *ip, + xfs_off_t offset, + xfs_off_t count) +{ + xfs_fileoff_t offset_fsb; + xfs_fileoff_t end_fsb; + int error =3D 0; + struct xfs_mount *mp =3D ip->i_mount; + struct xfs_trans *tp; + unsigned int resblks; + + trace_xfs_reflink_end_cow(ip, offset, count); + + offset_fsb =3D XFS_B_TO_FSBT(mp, offset); + end_fsb =3D XFS_B_TO_FSB(mp, offset + count); + + /* + * Each remapping operation could cause a btree split, so in the worst + * case that's one for each block. + */ + resblks =3D (end_fsb - offset_fsb) * + XFS_NEXTENTADD_SPACE_RES(mp, 1, XFS_DATA_FORK); + + error =3D xfs_trans_alloc(mp, &M_RES(mp)->tr_atomic_ioend, resblks, 0, + XFS_TRANS_RESERVE, &tp); + if (error) + return error; + + xfs_ilock(ip, XFS_ILOCK_EXCL); + xfs_trans_ijoin(tp, ip, 0); + + while (end_fsb > offset_fsb && !error) { + error =3D xfs_reflink_end_cow_extent_locked(tp, ip, &offset_fsb, + end_fsb); + } + if (error) { + trace_xfs_reflink_end_cow_error(ip, error, _RET_IP_); + goto out_cancel; + } + error =3D xfs_trans_commit(tp); + xfs_iunlock(ip, XFS_ILOCK_EXCL); + return error; +out_cancel: + xfs_trans_cancel(tp); + xfs_iunlock(ip, XFS_ILOCK_EXCL); + return error; +} + /* * Free all CoW staging blocks that are still referenced by the ondisk ref= count * metadata. The ondisk metadata does not track which inode created the diff --git a/fs/xfs/xfs_reflink.h b/fs/xfs/xfs_reflink.h index 379619f24247..412e9b6f2082 100644 --- a/fs/xfs/xfs_reflink.h +++ b/fs/xfs/xfs_reflink.h @@ -45,6 +45,8 @@ extern int xfs_reflink_cancel_cow_range(struct xfs_inode = *ip, xfs_off_t offset, xfs_off_t count, bool cancel_real); extern int xfs_reflink_end_cow(struct xfs_inode *ip, xfs_off_t offset, xfs_off_t count); +int xfs_reflink_end_atomic_cow(struct xfs_inode *ip, xfs_off_t offset, + xfs_off_t count); extern int xfs_reflink_recover_cow(struct xfs_mount *mp); extern loff_t xfs_reflink_remap_range(struct file *file_in, loff_t pos_in, struct file *file_out, loff_t pos_out, loff_t len, --=20 2.31.1 From nobody Fri Dec 19 16:07:40 2025 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B11671C863D; Sun, 4 May 2025 09:02:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349351; cv=fail; b=OPuI9/4r5g8Y/ncXWPUnuZ1DXfnR5p/PdDWnA4Hjwaq4728Wbu/UaoOPBLjCCF9FZOFIRgvBpumkU0WLM7CGgX059p6eKUiGZyGZBgA0Pj6Aca3OGP+H1JHHz9AoUa59DNB3YenYawLRQQohc7B4RXFAx7JaeNHvezLgRFkgc4o= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349351; c=relaxed/simple; bh=zin1cGnHDBDRrW3jNLQStqqddLgWyLLs2LbDahuY/MQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=C1TQ9bmGM/jvPghxwUF7lT2N7LhhBzvVUAv7B9yuko216eTM8zTPCE/dTV1MOQnpqiy5GmwGrhNaeYhITLf67nFRF8+LSxstgXZFTwjdmFR82L+CWCgoRgjA54FIV+VXszpQKGFnzUzZl6jZZ+Z7BRLgbaVeebEMSOg50/35Qf0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=drgmKAbC; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=D5vz43sR; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="drgmKAbC"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="D5vz43sR" Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5447anrf008269; Sun, 4 May 2025 09:00:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=srLclYblBb9JiBMt5Z335oUdMAMav4Fb0kt3AvrsdFQ=; b= drgmKAbCuicYkW5z2BGgarZBjcqSK7A/JqzINDvlihLXI+gbg5iwqjcOCaIg04Xp OHBRpyyDFqS6qumq33uSSZ9Sr1uz00D0ba7u2Xq3WasiSlBkUVohCFho71iOzR4P 4tWsC2RE2sHFtidOFr0myNScc62I7TlqBPOW3dEWjITjqdlqKMSDsvFZbOuMUf3K hKC0l1eKGK/TR2KtYwT4iXKqZ84o13Kv1sZJlic9s/QHIJR0yQq5gEsK8JSu/jPu DiM54T2q/DNHFMaITVF7vlz3swGJwKk4p5f8r0Eq0YKaahkizCDqcN+4sSfIxMmr kLvoMkHQ2hpB/5g5P6pNFg== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 46e40gr2x0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:17 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5445o3rj037649; Sun, 4 May 2025 09:00:16 GMT Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazlp17012052.outbound.protection.outlook.com [40.93.20.52]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 46d9k6gfq5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DtCpNANmVu5Y+CbsbNM1l8XHTXoFESL7r4RI1oT/kTeU1TVXfYZH1XCU7N+/W1lES+ACFEUXoWChw2pUTKRYomuCQYT2ipe5hDmYNfr0FC+QX4LiO0dedZa4z/8yZlI3fFmoIQEP+dNIB4k9GCWjngjoAGfmosx71omEss6hYbvUzLyZyhBUEF6JpLs8GYCYA4VrczKlehOv9uz5lvdZ1g3at1gxTAPqPNBEpmdOXfk0HL18geazHWaDVACzENZmFxVn+GuNEXPYJD+S9oOuXf2LT50wjEbkMgE5w0la2r6vGsr5KQzPL8nsoIWhUnRHUDU57hVI/bHRpwLU+NgwGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=srLclYblBb9JiBMt5Z335oUdMAMav4Fb0kt3AvrsdFQ=; b=xIyQrmfYnKzGkO5RQtUvq5fpaPTVcYw+lZautt9iBpwWqCdzH9uwmgeyBIwXgEJYmkMG0weFqG8NAARSlTFbbO6ObUdpxeLw9NZvT5l5rSJCjEmfrvCIRnC0N7b6xzJ0eOIRaR7O7fDbk3A7W5j3njgsarlaio3uxW1aoVhNuZG2NoWGdxip0mC4vBuG028/GQ/mUwZfDmb9lSfS2x0BSgfzyPhksGp0fnd2emiwzmLvnhs1O6+R7EBKgk/ULE8ISAzMqHdOdJecrYRyJHGQmkr0DEHREjuqhLTRE44WvQXUpnbCovHUWBtYQWq/a+3DJ1c7RIaBx/y6zITY7vjgDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=srLclYblBb9JiBMt5Z335oUdMAMav4Fb0kt3AvrsdFQ=; b=D5vz43sRwrgs6M7je406VE0a4Y/thUj9vqifcCpr49tTh0C87RrW6zK5nSA1ViAVTxVxFDeRGq2KAWyh2oPuoE4HkxkQOwfFfoJLZlHcn4D6pN7uiWy/oeFnHn5yV14S9f6ST3jdbshALq/OdxaYE6FHhwX+LCT9xW6CSJ+Fu24= Received: from DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) by DS7PR10MB7178.namprd10.prod.outlook.com (2603:10b6:8:e1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.23; Sun, 4 May 2025 09:00:13 +0000 Received: from DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088]) by DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088%7]) with mapi id 15.20.8699.022; Sun, 4 May 2025 09:00:12 +0000 From: John Garry To: brauner@kernel.org, djwong@kernel.org, hch@lst.de, viro@zeniv.linux.org.uk, jack@suse.cz, cem@kernel.org Cc: linux-fsdevel@vger.kernel.org, dchinner@redhat.com, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, ojaswin@linux.ibm.com, ritesh.list@gmail.com, martin.petersen@oracle.com, linux-ext4@vger.kernel.org, linux-block@vger.kernel.org, catherine.hoang@oracle.com, linux-api@vger.kernel.org, John Garry Subject: [PATCH v11 13/16] xfs: add xfs_file_dio_write_atomic() Date: Sun, 4 May 2025 08:59:20 +0000 Message-Id: <20250504085923.1895402-14-john.g.garry@oracle.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20250504085923.1895402-1-john.g.garry@oracle.com> References: <20250504085923.1895402-1-john.g.garry@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN2PR15CA0060.namprd15.prod.outlook.com (2603:10b6:208:237::29) To DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB4313:EE_|DS7PR10MB7178:EE_ X-MS-Office365-Filtering-Correlation-Id: c41d20f6-0af3-4092-194a-08dd8aea144a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?grvkqlILi1/pLmLtfQFSBQqHMeF2h9TQNZn991/l8IK3POi9PqhUCQCUW9rb?= =?us-ascii?Q?g2bGzRGdpQ/bn+6lWrAXHMWYy3Z5VOLlfnYtMkWQLwsWZ0N7jdSimHkTMdM2?= =?us-ascii?Q?FsARV7HSZSO7khooT0eRYh0Neyr3BCS1KXrY1k+W7mmRuCCVEJ1VAkO8w2ch?= =?us-ascii?Q?Jz1v3jQLzQILz3NrQqRy/SR0HgH6lpVpa6G4Iii98N9AlfFsB/xUIy/D3nDZ?= =?us-ascii?Q?LzufE/l7HNLd2MyldhRRje5w5Vz3Ye9rp8wxduVTuraex2I065bNiEDZwWV1?= =?us-ascii?Q?Xt5nZez5D186fZ2hDOLCzZBMMwM3Qe5/Wq2bPN2MG0GtB3G89vAa2lT2fRoz?= =?us-ascii?Q?Mr2SaqDjxVkdwFP+Q5DfE1CpudLkuCjCkIzOvvg29t3E51O5SOADVJl6lKsl?= =?us-ascii?Q?NwWCiOO+6EC33/HqqXxNHmomy9q1po7js7cVRrIQvgEubsoMRwva5Mh5baow?= =?us-ascii?Q?EPOKuhix4VOqtMDvzhVN/S58SxDDzOSWr5Ewe0FrhVuWY/ap8atuW/EUYsHY?= =?us-ascii?Q?9hrn6RjovL1yn8KbLYifvMt+CsXkZVNwwhQh4QRrm325Plodtcjs3m8KtxZ/?= =?us-ascii?Q?xeNJmv7mbSixsSV/Ns0Jz99abpToYELPp/LZoODNzNSb70i2G43Pp9Kc2QG/?= =?us-ascii?Q?JFVr19Hggj38ymR1XnkzfQRsGqLHoqPlPpfP14eLRIQohcPHxLvig+BU6BRb?= =?us-ascii?Q?vg6mGD+Z19k5/oWFFBVGq7U3MRxN0s05ZOearcHxyP0lAN0ezpgbi0ATVT9z?= =?us-ascii?Q?mhedjm8iG8N4CTthVA/vhNMdwNAWKUJ3sTYtS+Ge3pLD+O9qkQqHQrCNcCrb?= =?us-ascii?Q?RnrfbHWb8QMuTgJJZtjUoUtOxh6OWn32d8qxfwLOIwJi9nHkg9jO1FKRRgZn?= =?us-ascii?Q?jgxd1bArp3YaOw4a0p537fFjwmwDoR1STU2i+B3WRyysGbFXm7WGpLTw3/+g?= =?us-ascii?Q?/cxtEXWSVrS7doIfE2hL3tA/MBA3MjrGYyh/r745KPzc3m56acvsKuouIjoT?= =?us-ascii?Q?zRqXUUG+pvZ687l2mmT45i5p+jcgdR5k/67/Kky4Gf1eOsuy7niwH78ZMs4J?= =?us-ascii?Q?/aCDdKd2jaFBDKzqoWjqTnMEwZIeqJ8ZegtBOECkkYRQZNMlBe+HaAsq1O6s?= =?us-ascii?Q?CvabbThd//Q1J/ebrEmoAYL4w9DNhXO7n4F+KRjE/ihdRvFfB/tauGLMlft9?= =?us-ascii?Q?lGlRZZNxCC+N9UYsN/tlZ4bMEgPbCNY0oaGNaO+3f2nNCK1gj3vaSuJFOkvX?= =?us-ascii?Q?UJ4UaN89yWdek1qo6O49sPB/j8AgaPTGI3bxKgbmxg0CWQOLVCRyNMNZxG76?= =?us-ascii?Q?Y6tG549NkunYT7THaG2fHOEYsfLsW3eQtmKxxTpMTyRYpRr8h/gkwvxDY/nt?= =?us-ascii?Q?jVEL6wIb5NpVaZJZf1NHzfwR3H5FnFrSnX9Po8J1LmeQrnIKNw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB4313.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?s8KAPnXvOb/igOyuTjENCALGS18V04pgh/PMbbbA1OgsUsnokqg2KxLRFmjY?= =?us-ascii?Q?LGKPse5BO18cK6mdXgQn0Tl4c1dwfxQa87vw3rQ9WGINlTPOsN1QWSNqwYDZ?= =?us-ascii?Q?41J3lmVt7wap9hCCnkaFg6PJ2tWQc5tDHBrYdL3bDsPgDZW5kmbyGKoimcg1?= =?us-ascii?Q?xtyq+tuFnfJJtDgN+Die3VgXEEIc/NZKgXBXtKEgRbX68GLpGIEb4jufkCtd?= =?us-ascii?Q?3kbtzTijLIM/2g6WDwBeZIZkIihKdBxbWaJWnfta3SIZM/QjDJJeN3Mliyjo?= =?us-ascii?Q?Zwyz6KoESEQEBhhoQYzRpeZXKjtBFE4ejwDKwoZI4bM975WqTI58RcLPPgjT?= =?us-ascii?Q?6k82xl6ucGuZpm929MfSQWrHNB4372Y4qg0W5QDC5kpWgMM7L+OhncOaui8c?= =?us-ascii?Q?w4a82CiCcAihAlMvA9+JNIkND/44UxKXaf4gZMVhWRDIej4MYxJwCJl6yZcP?= =?us-ascii?Q?WVcjyA3JKnHCYfbZSdyMrxNz6JO8n5ynZktNYCFg+kW1Zi1imEBSz8knPvF2?= =?us-ascii?Q?ekjoreOa8jfZZ4KOTR9zVhD7RNugH5m9oagFV5n7AaQsHirtL0hOlRHFcqDq?= =?us-ascii?Q?bOzxuN6DLGeMND/q/MSY39CLsyrI0oVLRCyVDiujXtL05EMNaeDUGHbFv8oP?= =?us-ascii?Q?kRTY1zHczENaWZ7kc/HTT5CoZhHCN3yvH5Pgmevlzy/NQLzYGaTtCvsjwklT?= =?us-ascii?Q?XiylkRMVE5c3/u7ggRQ/0WAI/l2YNVOp1uIrohyA6Tn0/sDYswm/nvyQVKqX?= =?us-ascii?Q?r3evAIAzMmAZZivjD9FG0XbQAXolbBIodh6BvonyzmWgBOFQarwux3/jutDU?= =?us-ascii?Q?cWHWTNOpUhB9EtPjuTod2upC3S8SlWQnE6kvwWAR6EfOvGYyGxHbTelTvjkn?= =?us-ascii?Q?RiD0uD33hQxQAQ5RtdrmCLgoztyD0uA6wEFo4Aq069SuT02nzQcwQAsOuCrg?= =?us-ascii?Q?ns6xdovAmEtyMuJb6b6PobaW949YG9fQfKeDvhIIOebBlozZxyNCGkTuD1mF?= =?us-ascii?Q?FE8x0pwtwYVYyX2JEGYvVz2ZxV0L0MW9pWsG17ynSQbHBFvxvy5b2iSjxJ4r?= =?us-ascii?Q?Xmsq0dFovYIP4d3z8pRG+JyDd45dDtbh+Z5wvl9EXQuCpGuV3hdk1e7YzpPv?= =?us-ascii?Q?bWqEaJZ4gafFnw5uDLT91ePSIQl8wc85yHLIfUREeA6a8pJ3hg6fWVicZ6OG?= =?us-ascii?Q?F8sjr5Ho+KKB4S9kMp3DjqvbNBWplhoYna84eUtyE9sdC4nL+fgjydgwTbzG?= =?us-ascii?Q?lY0mQvV49+fMsqN4v5R/LLWnozv8w7DZo3t9Jq2kVO85mUbNHZffu4zxq/7P?= =?us-ascii?Q?p58LA+fqUS+FmSgwuZrQC8e/uMWXjAHQ5cmRt4u/czTUL3arC3rwbMe8kFF9?= =?us-ascii?Q?ZqWNH7oEuQmAX7ih3t628V7jl1jI1UrRjO1/dzuKVOY9A5UNOQiuUKW1anFP?= =?us-ascii?Q?wZbTEcf9iqmF93Naar6/mMcexCmWcnfhJjYQkUJaXp8IL6naZ4KWetpggQtz?= =?us-ascii?Q?c4zUQ+YorT4nLrKWGJHJ1miiMefDPwW7oNnPCtZ0GYaJ43NxnDihebJvKs3R?= =?us-ascii?Q?1anL9v8W5l/q7dVdW4nv4TZL0wQdtpsSTw6hK3q1KkdjgpzmwZtpECrhRtk6?= =?us-ascii?Q?AQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: FSN1LdFrPwlgtRqRzOXcfTnflzNV2VmRpm1JZOTE/uk1gPjRx3IW5//IjjxsbmMCXUemdYY0gBl6bxWFYjyQ8iSi3lp62+2zEs4cvJmyiYO+5tG2Opn/mRldHKAOjfnzb+nw7imIYSBsDqzOirtQU/TU9eifSnc8kL+hnc2CRizyEca+pUT/1nznNxDzheVVd7+JTjRMdt4I+MB/k93/r2dmlc6EhJrm3DI914Iuia7SHAwK7FkPB2e7f/oDA8ZWqpaHeqzxEdB53iAYKfm7ZsRk7DDviRJjv0UTdlwtotQEeVaEBBALl5wRBkBvjMO/CK19eU2StEusa9Me1x9sntZ8jUgZMLxpI1xnstIjA4OH32BQq5Ka5TW34TsfA4veRonZ3OddMYlB5nK3sHAo/R4ARfhhLkmyjdc/SK8kBf1jDrhn8QAgYeXEWu8HeZKH041TaU4owtJXzbWFCD+88k7w5uX1WRsUOS6uXGaKmYUuoS6nNBuVv50JbJ8TL2pheuu+KvD0XXL7iKjnR3XBGxg4S4jfFghfrvIu9nSF2aYPBgeNi7flxA9BdEWdrujtyxC0xfarnNBxXS7sf9ecVgHq3Prb/GTzmMLQLn/02kQ= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c41d20f6-0af3-4092-194a-08dd8aea144a X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2025 09:00:12.5103 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w1NU6YOqzhWTQdNJnLf2cLyzXjhlGWm5aZheEbq5/LJLoXU5T2vG8Bvu2FZ4ep4Y2WRqxCLSZFgGcRH3E0VxSw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB7178 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-04_03,2025-04-30_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 malwarescore=0 adultscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2504070000 definitions=main-2505040081 X-Authority-Analysis: v=2.4 cv=Y4H4sgeN c=1 sm=1 tr=0 ts=68172ca1 cx=c_pps a=XiAAW1AwiKB2Y8Wsi+sD2Q==:117 a=XiAAW1AwiKB2Y8Wsi+sD2Q==:17 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=dt9VzEwgFbYA:10 a=GoEa3M9JfhUA:10 a=VwQbUJbxAAAA:8 a=yPCof4ZbAAAA:8 a=Y8Big0Z5EXcV7lnze7oA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTA0MDA4MSBTYWx0ZWRfX2mpPNhU4mh4x SRladcEDcjVz5ScLKXE71ZlphDlLhnCvtRXuWYR81tHh/Afev30P9SqEO+uhSvpIq4tzoOIu990 acxx0ZGg6dX6m+EeWo/LSdgsBxu6JmirjjPNiiqJUFUxN+1ALzzS4rz6Va2LAlnFczLxT5cIb4H LrCTuMhthwM0Y/6Z/ULGD8iPSbk7vlGxczMX0Gmkm8KeIG8pQ5jFw+125OGLuXOHm6UrQygjhZk Uu57+NfwjCzPHEU6p+P5EfZvgzuGKnyF5UHuZPy22IC6PLPy/dtp3qCl2V5CezCeYD5iZ/71bqX Z0yvNIWassxMVaBoG0nRUNvsVWn+BnaOCY62ZyyHjvBmFGvGmJvZGzj3CAKqPzrGky1JT+5yTkm jtQDCd/2BT18Iqkdrt6to6e9VAW3XqGe0nCSJnAHZmpi/zCvQEYu5qMNdKnBDdJgmVttXfs/ X-Proofpoint-ORIG-GUID: Q8HTXDtxTWsw2fmHsBEGfLmXHypRAzfC X-Proofpoint-GUID: Q8HTXDtxTWsw2fmHsBEGfLmXHypRAzfC Content-Type: text/plain; charset="utf-8" Add xfs_file_dio_write_atomic() for dedicated handling of atomic writes. Now HW offload will not be required to support atomic writes and is an optional feature. CoW-based atomic writes will be supported with out-of-places write and atomic extent remapping. Either mode of operation may be used for an atomic write, depending on the circumstances. The preferred method is HW offload as it will be faster. If HW offload is not available then we always use the CoW-based method. If HW offload is available but not possible to use, then again we use the CoW-based method. If available, HW offload would not be possible for the write length exceeding the HW offload limit, the write spanning multiple extents, unaligned disk blocks, etc. Apart from the write exceeding the HW offload limit, other conditions for HW offload usage can only be detected in the iomap handling for the write. As such, we use a fallback method to issue the write if we detect in the ->iomap_begin() handler that HW offload is not possible. Special code -ENOPROTOOPT is returned from ->iomap_begin() to inform that HW offload is not possible. In other words, atomic writes are supported on any filesystem that can perform out of place write remapping atomically (i.e. reflink) up to some fairly large size. If the conditions are right (a single correctly aligned overwrite mapping) then the filesystem will use any available hardware support to avoid the filesystem metadata updates. Reviewed-by: Darrick J. Wong Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig Signed-off-by: John Garry --- fs/xfs/xfs_file.c | 68 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 68 insertions(+) diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c index 32883ec8ca2e..f4a66ff85748 100644 --- a/fs/xfs/xfs_file.c +++ b/fs/xfs/xfs_file.c @@ -728,6 +728,72 @@ xfs_file_dio_write_zoned( return ret; } =20 +/* + * Handle block atomic writes + * + * Two methods of atomic writes are supported: + * - REQ_ATOMIC-based, which would typically use some form of HW offload i= n the + * disk + * - COW-based, which uses a COW fork as a staging extent for data updates + * before atomically updating extent mappings for the range being written + * + */ +static noinline ssize_t +xfs_file_dio_write_atomic( + struct xfs_inode *ip, + struct kiocb *iocb, + struct iov_iter *from) +{ + unsigned int iolock =3D XFS_IOLOCK_SHARED; + ssize_t ret, ocount =3D iov_iter_count(from); + const struct iomap_ops *dops; + + /* + * HW offload should be faster, so try that first if it is already + * known that the write length is not too large. + */ + if (ocount > xfs_inode_buftarg(ip)->bt_bdev_awu_max) + dops =3D &xfs_atomic_write_cow_iomap_ops; + else + dops =3D &xfs_direct_write_iomap_ops; + +retry: + ret =3D xfs_ilock_iocb_for_write(iocb, &iolock); + if (ret) + return ret; + + ret =3D xfs_file_write_checks(iocb, from, &iolock, NULL); + if (ret) + goto out_unlock; + + /* Demote similar to xfs_file_dio_write_aligned() */ + if (iolock =3D=3D XFS_IOLOCK_EXCL) { + xfs_ilock_demote(ip, XFS_IOLOCK_EXCL); + iolock =3D XFS_IOLOCK_SHARED; + } + + trace_xfs_file_direct_write(iocb, from); + ret =3D iomap_dio_rw(iocb, from, dops, &xfs_dio_write_ops, + 0, NULL, 0); + + /* + * The retry mechanism is based on the ->iomap_begin method returning + * -ENOPROTOOPT, which would be when the REQ_ATOMIC-based write is not + * possible. The REQ_ATOMIC-based method typically not be possible if + * the write spans multiple extents or the disk blocks are misaligned. + */ + if (ret =3D=3D -ENOPROTOOPT && dops =3D=3D &xfs_direct_write_iomap_ops) { + xfs_iunlock(ip, iolock); + dops =3D &xfs_atomic_write_cow_iomap_ops; + goto retry; + } + +out_unlock: + if (iolock) + xfs_iunlock(ip, iolock); + return ret; +} + /* * Handle block unaligned direct I/O writes * @@ -843,6 +909,8 @@ xfs_file_dio_write( return xfs_file_dio_write_unaligned(ip, iocb, from); if (xfs_is_zoned_inode(ip)) return xfs_file_dio_write_zoned(ip, iocb, from); + if (iocb->ki_flags & IOCB_ATOMIC) + return xfs_file_dio_write_atomic(ip, iocb, from); return xfs_file_dio_write_aligned(ip, iocb, from, &xfs_direct_write_iomap_ops, &xfs_dio_write_ops, NULL); } --=20 2.31.1 From nobody Fri Dec 19 16:07:40 2025 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 224BE1DDC21; Sun, 4 May 2025 09:00:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349236; cv=fail; b=X4d12ZAhNbHqURyEO/iUpFexZJ89hHW0hvaR3fVdlPWtBfJ4Q4mwx55fbPDsB6226yhMUODc9o1r3e7bkWlF4Dc8z9fh8dPKshiY4rpugaOBNN6nJVsy80FJODM1u+xZBgiDPw8gsotBzUyz9/RxiZpDi1uCefXb4K4HjlzqYmU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349236; c=relaxed/simple; bh=/3eHRBqXmpR6yq1epYunkIuXKCmECvtb4laXLCiZWd4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=ULcokdLObVOgjzCp+qjBYcTWFv4fQT3VhkyWNCO09IM33cJka3WvupM9S7bHObteaBmUHqwhyXvScVHacX1c/S9e5ZUZoKv+0DDN1+VmR7H/ReYU8XRx9LQvZv5AKQsqaFLajmKuq+Q4+kxoGFcr4tBhem0paLX73hJkzwOO1hE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=Q5WT+imr; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=OlgWP5K6; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="Q5WT+imr"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="OlgWP5K6" Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54486VZJ013798; Sun, 4 May 2025 09:00:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=kuIG6thDLdvspmYKa5nJC+nv/4MZ8Ohf6Hauv447Apg=; b= Q5WT+imrHVDVyC/0HYRaTsvrq5M5oF6KE6FgME2cWj4bwVsblK2sZmhwBE6gjdVa YiX8gOJvBCO4G2D+mIZB60DB7DVXsnlhxloZNwMRIGJ2Eosi7Zxxzg8Sb56CNbss d55Yrf7b6Q9FEjaMfVgYgbZ6I7BUt8l18rOSv2QZyDeRUcU1c/2KiSc+1UyeH4GT Qd+kPY7N32lu9zZjnpZseayVbcUTZLordVlsKJfFjrTnSQ4y5M73lc1QhHfJFvL4 kx+djWFpmKLDbZS7wubyddTc0R5pSJU2h0pg/MFfupMqS0NloxpUqXkYc7ORgaSc SY9gN3YBQtQJL48Qd0OZcA== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 46e3jk03yq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:20 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5445T5ud025015; Sun, 4 May 2025 09:00:19 GMT Received: from sa9pr02cu001.outbound.protection.outlook.com (mail-southcentralusazlp17011026.outbound.protection.outlook.com [40.93.14.26]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 46d9kd0ejk-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=r66CZ6v1saaCx4RcM2HAgJ6ME8pfxTG1cJW1NsEca6bJrdcIULe7jRYH/o3nkstzWvq/E2i3K+Xgb7jqCgYpwiwxzUFRujMp7WBGaZEWwRGZ28ebB9QYO/6XG//dnQZ1fmgvlVeESOvfxfmxORbJaB0liSwFjKRapFEdOF4kCZyIBCgefUYSNt50HT4+MWWQMyY+fnBkpXWiZlGSEMCA6rAKv5KXwxRaw49KWq7xz2NuZjG8jsI9Y5izaDxfpO8moiayqdSnbP4RxRi9HnNN561f/+9UkJCSd+k2B02k4dul4oN5x2f18NoL7KZQotmCm6+TUX7mkFBBP3aA74b85w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kuIG6thDLdvspmYKa5nJC+nv/4MZ8Ohf6Hauv447Apg=; b=q5pJq8qtxVqB8yXd2Eg9wBdIAerKjHGV5Ug9tCYe7v/Wa5eD/7FNMrGaa7b3E0a+dTvMAW4YinRKu01HOrOULFp4zkPsaf6ExPVs3HTf6/bnVqcyLB9CTiOkstJPoLyzjl6YyhnJ1xoSUrMraDAVhv7uT9vrlPeBw1O760hXmbDwTRqgtiQBxMJXCH2yub9BqI9t7teyeSP/mpf2va+kH5MbBx7Vsd7Z4Zqdv90/4rZEx0PyB6azZYlcWl0WppHkSIQ/D40y6W3cK26VoEHCoqbJDDINVQYdCEbTyH5v+uk2RKlTpsm548Jd/M0oM2XyHqlRQAubrXsUKFZfabUFAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kuIG6thDLdvspmYKa5nJC+nv/4MZ8Ohf6Hauv447Apg=; b=OlgWP5K6zgruYTpOcxzY8xxiLW0vOMvr4kt50p7EoI3ZOdUTjxntKU2JXbcrO8Cqm11zrEzxE1gI7jsCbkorljUb6UkgNJ3DyFIn64Cs88muI/6Gv6pbFBIbmGmknceJb8+cDzz+YYkyJYRMseArSco6PoBvb5kKNugt/UrIRwA= Received: from DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) by DS7PR10MB7178.namprd10.prod.outlook.com (2603:10b6:8:e1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.23; Sun, 4 May 2025 09:00:13 +0000 Received: from DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088]) by DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088%7]) with mapi id 15.20.8699.022; Sun, 4 May 2025 09:00:13 +0000 From: John Garry To: brauner@kernel.org, djwong@kernel.org, hch@lst.de, viro@zeniv.linux.org.uk, jack@suse.cz, cem@kernel.org Cc: linux-fsdevel@vger.kernel.org, dchinner@redhat.com, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, ojaswin@linux.ibm.com, ritesh.list@gmail.com, martin.petersen@oracle.com, linux-ext4@vger.kernel.org, linux-block@vger.kernel.org, catherine.hoang@oracle.com, linux-api@vger.kernel.org, John Garry Subject: [PATCH v11 14/16] xfs: add xfs_calc_atomic_write_unit_max() Date: Sun, 4 May 2025 08:59:21 +0000 Message-Id: <20250504085923.1895402-15-john.g.garry@oracle.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20250504085923.1895402-1-john.g.garry@oracle.com> References: <20250504085923.1895402-1-john.g.garry@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BN9PR03CA0244.namprd03.prod.outlook.com (2603:10b6:408:ff::9) To DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB4313:EE_|DS7PR10MB7178:EE_ X-MS-Office365-Filtering-Correlation-Id: f5da1553-63e8-49c2-7b36-08dd8aea151a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?YYADH8eLnFcegFr5OBMUEr/NlEWMANRSjdRZpWQ4sg7EdafNkS9T6vUL424U?= =?us-ascii?Q?h95eBxdwewxJ4d7DA4Xghkz9u/vV1UFaou7Ol971KJRPnQ0//EUM+d5V/6fJ?= =?us-ascii?Q?phP9RyWWIgnaHuh3UfaQ5HSs10KD8EQAqNiWZiQ56aiV70VADWpwyvniphmr?= =?us-ascii?Q?Vf1LXXqmoJwZD3ZRDx4SmppNJDOozxbRV+mYnd+gAP/N7iQyzhoV8vRNbZmq?= =?us-ascii?Q?P31nWmXiNmzUFr6ayuwVLY3r2g2blrO/4eWgg3amXbWae+Kdi0MqA2yVzapF?= =?us-ascii?Q?TUJzsuLOF9D3OIDJ0YKuWDQXOlkn4bkrVTf5oBrxOcwrnd0wWs2slmma0IQj?= =?us-ascii?Q?M35mYXJQLq+PLVGuua2NAjJYJ4fa0+hLYcw6uDRi0t38IKlDtDXefI7egX3m?= =?us-ascii?Q?gwouywdK9dSuOfKmwe+OKGSEEctsGfu4plsIbS7mR1GKiBNvpjIuDM1XLDI7?= =?us-ascii?Q?YcaZ2uzuNxmxXuRJMyO7A06wtQr9TCjbufFGLyBSWD2xZNpCT5xFhk5xBfXB?= =?us-ascii?Q?jTn343j+hTZCjua4iwJub1l92Cobj4kKL+EgJdxO+ZslnFLm0forlcaBUteI?= =?us-ascii?Q?2Xy7Lr5FrpbJLbV9s2n/H7SFMmyTca5+tKKosAp2HZOUSgVer7qnloTxKL5f?= =?us-ascii?Q?Xw6HmIpI0BrYTcJV0hRyiy7UNKhfusVk8PjtmKZFDYUNb801tyBjQ/zKzYZA?= =?us-ascii?Q?Y7Ore5AtduPpbLMloJ8nndlGP/3ZB9BRTisbm+mE/3NETd08bPw5yaUM/tr2?= =?us-ascii?Q?hpmBQ5aO4BDI9wNXnJTH3VsmozxK5D9sAI4v0jrwGr03NzBb+uFEQiW2wKkR?= =?us-ascii?Q?5MUaJgL85Jj5OnCA+41OTAPaDpgU4r9SQQh1CAkfQryHcjHkUiKCBsc3yL53?= =?us-ascii?Q?CZXmu2maVmKK/LQkZfSQvcHX9Lo0CabPKlRKHx33y7Q+E+FKqCLJ5Zw2ysqq?= =?us-ascii?Q?HhdIQFMeUEfxeiJSg6iILot/w+RjqTGXzvh+8I68MBONfGBLaKKEfjNmziUY?= =?us-ascii?Q?BD9IzN/u8d3G7rG9wLJq7yJ+hUr93t2v0l44p6BN180G+4Mknkj3PY1+Z2t0?= =?us-ascii?Q?KA5aBdkNPMA889LOrOGd+nGhAapgLrR5pQgzPPHBu/630FpPIq59K6Tm0guC?= =?us-ascii?Q?JMFcrF/yPRp+s8wbJnKgCDghT/tbwmiGQzBo9SmkIFLq5ZyoozV+fQGS6nEl?= =?us-ascii?Q?b6f1yENq7/UXMtvcpbaRZFryMQzqgXQPcG3sUvPRnwfqXXzJ0/22PFL9b9si?= =?us-ascii?Q?cCTdcI3h/SvM5GAF/4xrSIBjQfSwbc+corcpxh9mKSUUyEToI1FbuV9MfUMy?= =?us-ascii?Q?+Qnh3IrGKmpZ8bhHMa6KqIckL8QUoPvSINK9To1cmxhBnBKIaYJpOrnI3HyJ?= =?us-ascii?Q?Lq+eGjYJmkMkVMI1YZktld1ePHIq/2KQBJ/ZVWZiCc4V+nJ5vkQIbnD23spi?= =?us-ascii?Q?Z8ZHjxv1AWA=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB4313.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YG20JzMTjj+tXjYtpp7cNJ46eHr0uROWVviH7vCbRgqQBwo+qyuG0A/xUTiv?= =?us-ascii?Q?VV6ftssxC5hZQoeEiUHUgZP0kK0iM3+/yDKIA1FqoDONvW3PaoCHfwXI6tox?= =?us-ascii?Q?LeLed5OIudMbJKUmXBaXCKfJp7L7bWOl9GexudIotDBqBkU8hFqIz5eFVtP2?= =?us-ascii?Q?IvqJ8bwrIKfBxheJcAXxSeO7RJxqdA4Dq8Wc8xAiHKcz2mDSlbRTbtF7gnhN?= =?us-ascii?Q?nLIdlNa4YRb5ENjemV9hoSq5UHBGsDi99M5MGiK3KmqB24pP2NdF+O2Tee3w?= =?us-ascii?Q?Pw3+DBoORn7qm8h4hbCOlLJuwd6uimwAPc6v2LYHpbiKYJmAar7OdUbEFg//?= =?us-ascii?Q?UA08xCEms7jIa8DQXjcD8VJ6NSAQ/xDghY1uOtpGt/8/9+ieMWDgFSqlN8TW?= =?us-ascii?Q?kHTNEW+ozCPAGw3WJ0YoGf87Xg4i2hJs2XYVjTb35k5UK2UF8k3RNHL7EAhu?= =?us-ascii?Q?D+CKjpylQFz+BoKaZEVZ2zz14nbuSgCCIJ+M0njES51BpHsjqMVIRmCbD6JQ?= =?us-ascii?Q?JFI8SMuUZZKh0ovhnoRvxZI3N6iUM0RJ+hyELXb9r6U5PDcnWubcYzzhUMCe?= =?us-ascii?Q?UDjb9gC5xVnHR4LcB/IFaOELZpS9Ly15KW+IkxVo8bj3oEquxboMNn2Xi7j7?= =?us-ascii?Q?KR15K3vXSMPWWM+sCJsmRtjTLg2cR4FtHy7Z2Jj/RTPMIlvQP+JJIH/xbDBt?= =?us-ascii?Q?9Xbcffxv7C7ljOt0SG9M2XsGtVwMX1NWjyl2n/oybBiqwRXKrFkCVHRgHIjF?= =?us-ascii?Q?NzCtEFNHzVvE4MeOxAxMlrfEagbtH0EwnBoWPhZXuVrS1dOBAu7XWobMhRlB?= =?us-ascii?Q?h+RdkDvnhyMQSfrgerTehq2fKxn1zqYRP8SyksZBrNd2q50wQw8725LjDW51?= =?us-ascii?Q?4rc9jT1GqKk1kOzk19Fd/p/YV2682hYfwK2kQSiSd8k2aHH1QouIQUbEh4+d?= =?us-ascii?Q?CMbD4AnmFG5UNAoCkFhCJmhRLZKY2TUfQjQxHHpsd/UwHb56RStH3FDLlpqa?= =?us-ascii?Q?VO9Xo5FsH+Tj/BhaYC0Rds2nu3sGpG3O6QJARTeM9OkfetmoDTUbAp29g1wA?= =?us-ascii?Q?yynj9vt5dy0WMtfu5IMILZO45rMnZgInH4nQInEMTedAu3k9y7UfKOSdADfI?= =?us-ascii?Q?UsYw9r/hOIITzTy9LQ+dGArTYiopXKr3xQWirD8Rvgfzjvsqsi6bU2bqClC4?= =?us-ascii?Q?jWMr9+k4s3F/uKCzZ+g8f1R2+qdQOcyJZ2Mdl6jMS+LwIVfaWTfhdLelHPlx?= =?us-ascii?Q?I9iT3XPByOnW4TsQ4QtbYSH+pqVbne1lP/5dB50zx88pPr6onOK8QcDlmIp3?= =?us-ascii?Q?YshkaJtXsEYpNnKP+InCAvwxZ0DlONpqRsM2cNwmTZViQOOYqMHQAbsO3Csb?= =?us-ascii?Q?ZtLL7XJPKRh4kW0ZvkK4RFj/zr+d8+FB5bnt3p0jwhc5nTPnV29yZT0f8rZO?= =?us-ascii?Q?KoX+j479IBOVE8nZUNFvKNaHo7uV4dLjs9Ay1MyVMxeOR4Ub6q3sBbPtO8g8?= =?us-ascii?Q?mcgx2B3ZpzvFxBlB7/zWuvbazzt0Zz2MrWCbX5tL+f9XxaCUTOU7F8Qoy87f?= =?us-ascii?Q?5HIRaHI3Fj/DaIdfayJP7Z9jPe2QBYnaL7VlolkzLg7ZcV3p9EnZC6e+JRjy?= =?us-ascii?Q?dQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: rAT8/w0r3RItXlKyKeetCDlxrOspMQOHCGSCOgTOvWSwDN6x8Ool8CH5VZAaN6pORIDCyEF3riKjbyEeJSQi7yDYHF0ilsL4uJ096lVAhy+NA4829pPkvpCI9kd+Jiv+3TVsFz6fiCQb0GdklIFE0Sgf8jHmrMXeGa1lMUGrdNVIdh4Nqb12If9CB6Im96/znjrvE89GU4skMNu5N8yc1tqpa8tnFnXIo7cI+8t4FUZXk66JY/0AcoQHGMiLJ84s0Ao3g16wE3A+V1FBa1Z0hrE+PhHyomSt4h9WaqGLulCNWapIOUdSP/v2llx0haJ9XEtGDfRhoCCmt5fHK8rLdIzMcPZbt7jatyA40ULVC2533LLGuMSzPbs1q0W/IaAenI28W5uQZkRalihGudp6Xm15KuAWm4d5OvDOgsJCTXCRmGFgeNuuC2YRLzCBQhv/SLPTQ6x2GVD0i55fnxh1wsbeYDaWBlToOqOsosq372Bq47o322MFmj5m57WY7UyEM1As1rdzkNjpgd9lBbSzB9EagTEYSXgiro6GESYY6J8Z+P0K5Cpi5o6hRWAnKDkneOvu8w+9r25ydQkbgYgj9/saCchOhKwvVMct6cartUo= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: f5da1553-63e8-49c2-7b36-08dd8aea151a X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2025 09:00:13.8512 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2HIt+R8Q/MMMkmsuqbpx8aFjfL681dw6KxlSFfbqLWubClfmV8QmxPzQ2v/0RqwpHsTG8iej3rGkqxIXFBF1iQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB7178 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-04_03,2025-04-30_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 phishscore=0 malwarescore=0 mlxlogscore=999 mlxscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2504070000 definitions=main-2505040081 X-Proofpoint-GUID: m4E93e1KQucv_TojbB-bzFY1JUyqMd2Z X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTA0MDA4MSBTYWx0ZWRfX3YXxoQ7SKlBp 4iq6zRJ2/iuH9B+JKCDN8/ZB4Q5V0EPHKj4jlOspUa/773qlYK4IardaQ3zIh9YGWwCyRZrBUJY xfc9RC8Tox70PMqzsY6yDisv/t1+9tzPI9xmJi/WMmlaXzvEHiVe9DfK0B7d5rE3N6RMC3ti6BF rfgBfajiLo4R4amv9WSoM61hG3OJ+5lHxsRlSAF2KAkCoW0ZyQtN/vZ6Lb/I1cj+bfERX6QeXia GX+nuEtT7BM6Q2PLjw5jJ+OJbVmA2Mn7u8KfmFVH4YkzbIaJ8Hgab1WgvbYZ3HYJ8KQnunNYxAX vfAJh3fJS2VPy6fa28HWorvLSX3JjiBXOPgofVRQM9b/rurzu75IEZoBNzoPf7wP9k7RYQjru7v 4UH9WnDBt7VC6OL3qoAr/rafBJgpsyg45tMdof+RMwvm8ZebbLdeNOOhdIPr13AH+jUzONwU X-Proofpoint-ORIG-GUID: m4E93e1KQucv_TojbB-bzFY1JUyqMd2Z X-Authority-Analysis: v=2.4 cv=IaeHWXqa c=1 sm=1 tr=0 ts=68172ca4 b=1 cx=c_pps a=zPCbziy225d3KhSqZt3L1A==:117 a=zPCbziy225d3KhSqZt3L1A==:17 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=dt9VzEwgFbYA:10 a=GoEa3M9JfhUA:10 a=VwQbUJbxAAAA:8 a=yPCof4ZbAAAA:8 a=PHD7Guh85veGlZlmIGYA:9 cc=ntf awl=host:13129 Content-Type: text/plain; charset="utf-8" Now that CoW-based atomic writes are supported, update the max size of an atomic write for the data device. The limit of a CoW-based atomic write will be the limit of the number of logitems which can fit into a single transaction. In addition, the max atomic write size needs to be aligned to the agsize. Limit the size of atomic writes to the greatest power-of-two factor of the agsize so that allocations for an atomic write will always be aligned compatibly with the alignment requirements of the storage. Function xfs_atomic_write_logitems() is added to find the limit the number of log items which can fit in a single transaction. Amend the max atomic write computation to create a new transaction reservation type, and compute the maximum size of an atomic write completion (in fsblocks) based on this new transaction reservation. Initially, tr_atomic_write is a clone of tr_itruncate, which provides a reasonable level of parallelism. In the next patch, we'll add a mount option so that sysadmins can configure their own limits. [djwong: use a new reservation type for atomic write ioends, refactor group limit calculations] Reviewed-by: Darrick J. Wong Signed-off-by: Darrick J. Wong [jpg: rounddown power-of-2 always] Reviewed-by: Christoph Hellwig Signed-off-by: John Garry --- fs/xfs/libxfs/xfs_trans_resv.c | 94 ++++++++++++++++++++++++++++++++++ fs/xfs/libxfs/xfs_trans_resv.h | 2 + fs/xfs/xfs_mount.c | 81 +++++++++++++++++++++++++++++ fs/xfs/xfs_mount.h | 6 +++ fs/xfs/xfs_reflink.c | 16 ++++++ fs/xfs/xfs_reflink.h | 2 + fs/xfs/xfs_trace.h | 60 ++++++++++++++++++++++ 7 files changed, 261 insertions(+) diff --git a/fs/xfs/libxfs/xfs_trans_resv.c b/fs/xfs/libxfs/xfs_trans_resv.c index a841432abf83..e73c09fbd24c 100644 --- a/fs/xfs/libxfs/xfs_trans_resv.c +++ b/fs/xfs/libxfs/xfs_trans_resv.c @@ -22,6 +22,12 @@ #include "xfs_rtbitmap.h" #include "xfs_attr_item.h" #include "xfs_log.h" +#include "xfs_defer.h" +#include "xfs_bmap_item.h" +#include "xfs_extfree_item.h" +#include "xfs_rmap_item.h" +#include "xfs_refcount_item.h" +#include "xfs_trace.h" =20 #define _ALLOC true #define _FREE false @@ -1394,3 +1400,91 @@ xfs_trans_resv_calc( */ xfs_calc_default_atomic_ioend_reservation(mp, resp); } + +/* + * Return the per-extent and fixed transaction reservation sizes needed to + * complete an atomic write. + */ +STATIC unsigned int +xfs_calc_atomic_write_ioend_geometry( + struct xfs_mount *mp, + unsigned int *step_size) +{ + const unsigned int efi =3D xfs_efi_log_space(1); + const unsigned int efd =3D xfs_efd_log_space(1); + const unsigned int rui =3D xfs_rui_log_space(1); + const unsigned int rud =3D xfs_rud_log_space(); + const unsigned int cui =3D xfs_cui_log_space(1); + const unsigned int cud =3D xfs_cud_log_space(); + const unsigned int bui =3D xfs_bui_log_space(1); + const unsigned int bud =3D xfs_bud_log_space(); + + /* + * Maximum overhead to complete an atomic write ioend in software: + * remove data fork extent + remove cow fork extent + map extent into + * data fork. + * + * tx0: Creates a BUI and a CUI and that's all it needs. + * + * tx1: Roll to finish the BUI. Need space for the BUD, an RUI, and + * enough space to relog the CUI (=3D=3D CUI + CUD). + * + * tx2: Roll again to finish the RUI. Need space for the RUD and space + * to relog the CUI. + * + * tx3: Roll again, need space for the CUD and possibly a new EFI. + * + * tx4: Roll again, need space for an EFD. + * + * If the extent referenced by the pair of BUI/CUI items is not the one + * being currently processed, then we need to reserve space to relog + * both items. + */ + const unsigned int tx0 =3D bui + cui; + const unsigned int tx1 =3D bud + rui + cui + cud; + const unsigned int tx2 =3D rud + cui + cud; + const unsigned int tx3 =3D cud + efi; + const unsigned int tx4 =3D efd; + const unsigned int relog =3D bui + bud + cui + cud; + + const unsigned int per_intent =3D max(max3(tx0, tx1, tx2), + max3(tx3, tx4, relog)); + + /* Overhead to finish one step of each intent item type */ + const unsigned int f1 =3D xfs_calc_finish_efi_reservation(mp, 1); + const unsigned int f2 =3D xfs_calc_finish_rui_reservation(mp, 1); + const unsigned int f3 =3D xfs_calc_finish_cui_reservation(mp, 1); + const unsigned int f4 =3D xfs_calc_finish_bui_reservation(mp, 1); + + /* We only finish one item per transaction in a chain */ + *step_size =3D max(f4, max3(f1, f2, f3)); + + return per_intent; +} + +/* + * Compute the maximum size (in fsblocks) of atomic writes that we can com= plete + * given the existing log reservations. + */ +xfs_extlen_t +xfs_calc_max_atomic_write_fsblocks( + struct xfs_mount *mp) +{ + const struct xfs_trans_res *resv =3D &M_RES(mp)->tr_atomic_ioend; + unsigned int per_intent =3D 0; + unsigned int step_size =3D 0; + unsigned int ret =3D 0; + + if (resv->tr_logres > 0) { + per_intent =3D xfs_calc_atomic_write_ioend_geometry(mp, + &step_size); + + if (resv->tr_logres >=3D step_size) + ret =3D (resv->tr_logres - step_size) / per_intent; + } + + trace_xfs_calc_max_atomic_write_fsblocks(mp, per_intent, step_size, + resv->tr_logres, ret); + + return ret; +} diff --git a/fs/xfs/libxfs/xfs_trans_resv.h b/fs/xfs/libxfs/xfs_trans_resv.h index 670045d417a6..a6d303b83688 100644 --- a/fs/xfs/libxfs/xfs_trans_resv.h +++ b/fs/xfs/libxfs/xfs_trans_resv.h @@ -121,4 +121,6 @@ unsigned int xfs_calc_itruncate_reservation_minlogsize(= struct xfs_mount *mp); unsigned int xfs_calc_write_reservation_minlogsize(struct xfs_mount *mp); unsigned int xfs_calc_qm_dqalloc_reservation_minlogsize(struct xfs_mount *= mp); =20 +xfs_extlen_t xfs_calc_max_atomic_write_fsblocks(struct xfs_mount *mp); + #endif /* __XFS_TRANS_RESV_H__ */ diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c index 00b53f479ece..9c40914afabd 100644 --- a/fs/xfs/xfs_mount.c +++ b/fs/xfs/xfs_mount.c @@ -666,6 +666,80 @@ xfs_agbtree_compute_maxlevels( mp->m_agbtree_maxlevels =3D max(levels, mp->m_refc_maxlevels); } =20 +/* Maximum atomic write IO size that the kernel allows. */ +static inline xfs_extlen_t xfs_calc_atomic_write_max(struct xfs_mount *mp) +{ + return rounddown_pow_of_two(XFS_B_TO_FSB(mp, MAX_RW_COUNT)); +} + +static inline unsigned int max_pow_of_two_factor(const unsigned int nr) +{ + return 1 << (ffs(nr) - 1); +} + +/* + * If the data device advertises atomic write support, limit the size of d= ata + * device atomic writes to the greatest power-of-two factor of the AG size= so + * that every atomic write unit aligns with the start of every AG. This is + * required so that the per-AG allocations for an atomic write will always= be + * aligned compatibly with the alignment requirements of the storage. + * + * If the data device doesn't advertise atomic writes, then there are no + * alignment restrictions and the largest out-of-place write we can do + * ourselves is the number of blocks that user files can allocate from any= AG. + */ +static inline xfs_extlen_t xfs_calc_perag_awu_max(struct xfs_mount *mp) +{ + if (mp->m_ddev_targp->bt_bdev_awu_min > 0) + return max_pow_of_two_factor(mp->m_sb.sb_agblocks); + return rounddown_pow_of_two(mp->m_ag_max_usable); +} + +/* + * Reflink on the realtime device requires rtgroups, and atomic writes req= uire + * reflink. + * + * If the realtime device advertises atomic write support, limit the size = of + * data device atomic writes to the greatest power-of-two factor of the rt= group + * size so that every atomic write unit aligns with the start of every rtg= roup. + * This is required so that the per-rtgroup allocations for an atomic write + * will always be aligned compatibly with the alignment requirements of the + * storage. + * + * If the rt device doesn't advertise atomic writes, then there are no + * alignment restrictions and the largest out-of-place write we can do + * ourselves is the number of blocks that user files can allocate from any + * rtgroup. + */ +static inline xfs_extlen_t xfs_calc_rtgroup_awu_max(struct xfs_mount *mp) +{ + struct xfs_groups *rgs =3D &mp->m_groups[XG_TYPE_RTG]; + + if (mp->m_rtdev_targp && mp->m_rtdev_targp->bt_bdev_awu_min > 0) + return max_pow_of_two_factor(rgs->blocks); + return rounddown_pow_of_two(rgs->blocks); +} + +/* Compute the maximum atomic write unit size for each section. */ +static inline void +xfs_calc_atomic_write_unit_max( + struct xfs_mount *mp) +{ + struct xfs_groups *ags =3D &mp->m_groups[XG_TYPE_AG]; + struct xfs_groups *rgs =3D &mp->m_groups[XG_TYPE_RTG]; + + const xfs_extlen_t max_write =3D xfs_calc_atomic_write_max(mp); + const xfs_extlen_t max_ioend =3D xfs_reflink_max_atomic_cow(mp); + const xfs_extlen_t max_agsize =3D xfs_calc_perag_awu_max(mp); + const xfs_extlen_t max_rgsize =3D xfs_calc_rtgroup_awu_max(mp); + + ags->awu_max =3D min3(max_write, max_ioend, max_agsize); + rgs->awu_max =3D min3(max_write, max_ioend, max_rgsize); + + trace_xfs_calc_atomic_write_unit_max(mp, max_write, max_ioend, + max_agsize, max_rgsize); +} + /* Compute maximum possible height for realtime btree types for this fs. */ static inline void xfs_rtbtree_compute_maxlevels( @@ -1082,6 +1156,13 @@ xfs_mountfs( xfs_zone_gc_start(mp); } =20 + /* + * Pre-calculate atomic write unit max. This involves computations + * derived from transaction reservations, so we must do this after the + * log is fully initialized. + */ + xfs_calc_atomic_write_unit_max(mp); + return 0; =20 out_agresv: diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h index e67bc3e91f98..e2abf31438e0 100644 --- a/fs/xfs/xfs_mount.h +++ b/fs/xfs/xfs_mount.h @@ -119,6 +119,12 @@ struct xfs_groups { * SMR hard drives. */ xfs_fsblock_t start_fsb; + + /* + * Maximum length of an atomic write for files stored in this + * collection of allocation groups, in fsblocks. + */ + xfs_extlen_t awu_max; }; =20 struct xfs_freecounter { diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c index 218dee76768b..ad3bcb76d805 100644 --- a/fs/xfs/xfs_reflink.c +++ b/fs/xfs/xfs_reflink.c @@ -1040,6 +1040,22 @@ xfs_reflink_end_atomic_cow( return error; } =20 +/* Compute the largest atomic write that we can complete through software.= */ +xfs_extlen_t +xfs_reflink_max_atomic_cow( + struct xfs_mount *mp) +{ + /* We cannot do any atomic writes without out of place writes. */ + if (!xfs_can_sw_atomic_write(mp)) + return 0; + + /* + * Atomic write limits must always be a power-of-2, according to + * generic_atomic_write_valid. + */ + return rounddown_pow_of_two(xfs_calc_max_atomic_write_fsblocks(mp)); +} + /* * Free all CoW staging blocks that are still referenced by the ondisk ref= count * metadata. The ondisk metadata does not track which inode created the diff --git a/fs/xfs/xfs_reflink.h b/fs/xfs/xfs_reflink.h index 412e9b6f2082..36cda724da89 100644 --- a/fs/xfs/xfs_reflink.h +++ b/fs/xfs/xfs_reflink.h @@ -68,4 +68,6 @@ extern int xfs_reflink_update_dest(struct xfs_inode *dest= , xfs_off_t newlen, =20 bool xfs_reflink_supports_rextsize(struct xfs_mount *mp, unsigned int rext= size); =20 +xfs_extlen_t xfs_reflink_max_atomic_cow(struct xfs_mount *mp); + #endif /* __XFS_REFLINK_H */ diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index 9554578c6da4..d5ae00f8e04c 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -170,6 +170,66 @@ DEFINE_ATTR_LIST_EVENT(xfs_attr_list_notfound); DEFINE_ATTR_LIST_EVENT(xfs_attr_leaf_list); DEFINE_ATTR_LIST_EVENT(xfs_attr_node_list); =20 +TRACE_EVENT(xfs_calc_atomic_write_unit_max, + TP_PROTO(struct xfs_mount *mp, unsigned int max_write, + unsigned int max_ioend, unsigned int max_agsize, + unsigned int max_rgsize), + TP_ARGS(mp, max_write, max_ioend, max_agsize, max_rgsize), + TP_STRUCT__entry( + __field(dev_t, dev) + __field(unsigned int, max_write) + __field(unsigned int, max_ioend) + __field(unsigned int, max_agsize) + __field(unsigned int, max_rgsize) + __field(unsigned int, data_awu_max) + __field(unsigned int, rt_awu_max) + ), + TP_fast_assign( + __entry->dev =3D mp->m_super->s_dev; + __entry->max_write =3D max_write; + __entry->max_ioend =3D max_ioend; + __entry->max_agsize =3D max_agsize; + __entry->max_rgsize =3D max_rgsize; + __entry->data_awu_max =3D mp->m_groups[XG_TYPE_AG].awu_max; + __entry->rt_awu_max =3D mp->m_groups[XG_TYPE_RTG].awu_max; + ), + TP_printk("dev %d:%d max_write %u max_ioend %u max_agsize %u max_rgsize %= u data_awu_max %u rt_awu_max %u", + MAJOR(__entry->dev), MINOR(__entry->dev), + __entry->max_write, + __entry->max_ioend, + __entry->max_agsize, + __entry->max_rgsize, + __entry->data_awu_max, + __entry->rt_awu_max) +); + +TRACE_EVENT(xfs_calc_max_atomic_write_fsblocks, + TP_PROTO(struct xfs_mount *mp, unsigned int per_intent, + unsigned int step_size, unsigned int logres, + unsigned int blockcount), + TP_ARGS(mp, per_intent, step_size, logres, blockcount), + TP_STRUCT__entry( + __field(dev_t, dev) + __field(unsigned int, per_intent) + __field(unsigned int, step_size) + __field(unsigned int, logres) + __field(unsigned int, blockcount) + ), + TP_fast_assign( + __entry->dev =3D mp->m_super->s_dev; + __entry->per_intent =3D per_intent; + __entry->step_size =3D step_size; + __entry->logres =3D logres; + __entry->blockcount =3D blockcount; + ), + TP_printk("dev %d:%d per_intent %u step_size %u logres %u blockcount %u", + MAJOR(__entry->dev), MINOR(__entry->dev), + __entry->per_intent, + __entry->step_size, + __entry->logres, + __entry->blockcount) +); + TRACE_EVENT(xlog_intent_recovery_failed, TP_PROTO(struct xfs_mount *mp, const struct xfs_defer_op_type *ops, int error), --=20 2.31.1 From nobody Fri Dec 19 16:07:40 2025 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B8CC1CB518; Sun, 4 May 2025 09:02:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349352; cv=fail; b=uO/I3sRT6aAEfdSPDx5579gabqLIHK545VdkTX+LOZLNjr2wNgOuWjUipJvLX90dyU9nzEbtLZ7PADOW6+RwLPTp153j5XBw1KHEXw7LJDROJQi14aibzQlqrUldII/sVxzRta9PSCNjuRhOBk5fJQk5nEv0S7IRuSMTpGb1nR4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349352; c=relaxed/simple; bh=e8Rx4wKUghn5UbLRBAKEFYhg4Sjn+njknH+/5eTBz8g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=vF9rQpyVWVzyOeatdK8SffqrgGM66tOb9jR/W1sMRX9eDn76ye0GNYZx0gXrFNX+r7hPbnHvJJ/5VlPvQTizzhFRI2YLJzOoChTjlNWZ/+1IE76BS+ISc3RnSYLmSBXMyzA485n6MwS/TZwKpHoDzYFG2GAhlD9tIIId0JWFEUo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=SkdHu+k2; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=juiCBOmv; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="SkdHu+k2"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="juiCBOmv" Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5448O3at031744; Sun, 4 May 2025 09:00:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=dh4Wq2DGZT38tbuOYyxQeOzVJZYDrAG4YDFkbHawV2U=; b= SkdHu+k2zf7uISxI579s8fUp+5A+/PZ2Z/9Dhk+GtZkQaKn7FVeI2mVLfD5CVn2N SONNf19i42GoICm+GHzQ/GzTCYAT4W+hn9OX7BhZxd5PLqEMHbvbSR1crFz7ohWe Tu5Om+/FmwFom4x1ZGWVI5jK2wKlYGyROcgy0ONzKNgXON3tPGWWuaRDKPR7W0cD C2gMQg4dPxGKHgK9/oXOS+Iu7yr3SWs2GPvJf7ThNWWTxylPoGe1ceKWoTx4WA4S GkTXVaSdvsu5yhqW6ria+uN7X6vIJ7Cp0CvqE4no5tlBNgmNIYKHuZRfalxhEa0n lWPi3BofVwUWbSDHbSeE8g== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 46e4nqr10x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:19 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5445T5uc025015; Sun, 4 May 2025 09:00:18 GMT Received: from sa9pr02cu001.outbound.protection.outlook.com (mail-southcentralusazlp17011026.outbound.protection.outlook.com [40.93.14.26]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 46d9kd0ejk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xnD+I4yXlEy6jYXxrJF5pKzLjwjOpNajTyWBokA3Lanl2pz0yGToC4k8mnBwzteeoExD6Jdjv2CGkNdx694g88JYizgtxgZBonXVZVQ8S3GST/Mg1B64bPZHbzj39vNF3Y8a4YOuHQ9CFQxslzMtFwrT80oPieeTtdqdNtg/eb5Gj7QmZSe7rxOQlgzEGzkkiFDpeCi751p6QQmYZ8fwc6sP0cf9NTqNIZUcWrUiV1wwHv/vHIfUOCIQZB/RKoLiRA64jL/ivYAzG7pdrx41V07HDdyhaIZ/VBSOvbkBFJiUzGKqHNnYPqrasj9HI6oeOsRGECNtJs7cMEYheGYgNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dh4Wq2DGZT38tbuOYyxQeOzVJZYDrAG4YDFkbHawV2U=; b=a0PHS9o6seykKTBoDAIxNobM8RIsBwOdlktJ5g+dO0RXVGzSOHTN1mJibugdBog5CfN3n+lM7Sq9S+78ZjNX6wd9AE13XC8t2tOyXnK8msZ2ALt6MDIcRZGw3uwjtFJYPo2Xwcq7W0QWVmefMrk/yZVcVO0ouyaE3N7kb3Yc/i2XSiN1gsou34p+S+BjpnRHV3UgfppuL4IedufEXLXTH3fBm96JD65kk0wJOUv9cawoCnPfDiWfSM7QDMw0P/Q4P/TTPABotpkc3vkZ5/0RCLfUcDYTESDYuoHAVy/7LCZrgfuzN4CbzCV7Wk/Jn2W1Lx1J3t/F7LOlcwu35bsDCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dh4Wq2DGZT38tbuOYyxQeOzVJZYDrAG4YDFkbHawV2U=; b=juiCBOmv4S9aM64Izj6wtBpHeTKUEd3AQH3B3SHDdUhAqx7RMNjcxEAp/PxUwG2oaaP/WWIQ0UGoYdISw5W+O36CFn01Sog1vkmjDVCU2PYo02XefhCx9xdTpltdyDxVNBnZUCYzaaVj4fKz+qDnvArafJicQo0pKTtvrekS9Sg= Received: from DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) by DS7PR10MB7178.namprd10.prod.outlook.com (2603:10b6:8:e1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.23; Sun, 4 May 2025 09:00:15 +0000 Received: from DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088]) by DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088%7]) with mapi id 15.20.8699.022; Sun, 4 May 2025 09:00:15 +0000 From: John Garry To: brauner@kernel.org, djwong@kernel.org, hch@lst.de, viro@zeniv.linux.org.uk, jack@suse.cz, cem@kernel.org Cc: linux-fsdevel@vger.kernel.org, dchinner@redhat.com, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, ojaswin@linux.ibm.com, ritesh.list@gmail.com, martin.petersen@oracle.com, linux-ext4@vger.kernel.org, linux-block@vger.kernel.org, catherine.hoang@oracle.com, linux-api@vger.kernel.org, John Garry Subject: [PATCH v11 15/16] xfs: update atomic write limits Date: Sun, 4 May 2025 08:59:22 +0000 Message-Id: <20250504085923.1895402-16-john.g.garry@oracle.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20250504085923.1895402-1-john.g.garry@oracle.com> References: <20250504085923.1895402-1-john.g.garry@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BN9PR03CA0261.namprd03.prod.outlook.com (2603:10b6:408:ff::26) To DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB4313:EE_|DS7PR10MB7178:EE_ X-MS-Office365-Filtering-Correlation-Id: 4845d63a-a3ef-4b02-915b-08dd8aea15ed X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?R+JkJv3vD7+EwAWaDtNe+tL06yLVK5qyBbx61XyZfubPUpHeW6bIsadP+JS+?= =?us-ascii?Q?RTGwr3V2U46Ex167P+M81QCVtlULHy9osf8MRqjI1KeMlRrM1qqZUOtRMtJm?= =?us-ascii?Q?WxhRrg3TNmXxAkUGt7to5M9zCZYJA0o6p1GCU4KDLmt1nIpzse24ftAonYDP?= =?us-ascii?Q?uIjh5a2tMn1+1OOgf5mOvkYciPmRoBFociUo3ExayRZkmczYuT78o6mIxr77?= =?us-ascii?Q?FDrPOoXGZjwA+//s7jc2baPB8+mLYbS5IWBgNHQQcuYnkXloij8GB+zmTtND?= =?us-ascii?Q?428dcVV3QnGAMP7TD4VZUwYJVU/Urta8vlrM4IJEfhqJOqzIoLc7dh0sIfOX?= =?us-ascii?Q?UBvejHuQZ+ey+Q03ozmu3h4Ae6rDGCGlKNRFLTxUTXZoG37imY/ltw1iW/KS?= =?us-ascii?Q?J552XLr2D/pg1wwv3GQko3VTSEW+q5d+MXxPAt6RhJdyKqBVkW/dAqx2RX4O?= =?us-ascii?Q?hxSrwxA2UP+vnL5LB0JLdlJaBcVkl1KdDv7JOFkpdK7WU3VNNdtKazQv/oG9?= =?us-ascii?Q?HEke/3levKm5oF059v/2lK0nBg3M9cWBr5DHcsjAbGxXcccyG/8uWOiZ+6y6?= =?us-ascii?Q?U87zx+USK4S857sdb1lwk+k8S0f8qWH4DUzeDILMXCT1OaYugR3MBaTaBeUv?= =?us-ascii?Q?GL106QiFIAGxFwOwY7OC3qxNIHomL68fwKzQtQSxxUBumi8QxmnpDCiIGBdM?= =?us-ascii?Q?Fy6FETLyoNtVlIN1wCWUZY04V1kbgKO2Bwx7Aec+fzIS30MnV0MTa7FNLae0?= =?us-ascii?Q?abNo+rhr4a/O24YvcnLaM0nKmd87JHiPR3EXUmD/67QoCoYialOxz2JVSorD?= =?us-ascii?Q?4p9C8uNNDARFSnKJzQh9LuE3W2+HlDF3509GdFUIps3zUm1eTfIFxayXD+Rr?= =?us-ascii?Q?S9regEt1Szk+gxobH8sw+TiukbXI+tG4eMFSNut1gheHUd6LVb5hkqQaFt+f?= =?us-ascii?Q?G/9MdFjNIlFExinpJswR/NjQZm2goT6jfzfQEqJD/1wyNZTI+UnxzliclbMQ?= =?us-ascii?Q?h19o2FM2PoVmVA2huxEDtG8iynEaQjRDSuKKwX7VAeMV9xZMnrgrXSsIwoLx?= =?us-ascii?Q?4NRrkHz6OR3RIUeyRsdP6wiwdPnwSjOFLxbAgXLc5Xbc24m9e3kjGQ2LeBuf?= =?us-ascii?Q?yMaSN8SAn7Knf1YbU1BunBkRTrHpbNLZugk5MLXh8xuD2VGpfqaK8UChsBu3?= =?us-ascii?Q?THwhQeEz/LgK9gKWIlOAduam9q1pxrEYpKR7g2QiSNPCvMERVuTnTHsNWcYI?= =?us-ascii?Q?5elUMe1DyADs9rMNCvc4U+/iX0b25wNWrb8J0GDfBAGJdxMNOfgLMj8nXu1f?= =?us-ascii?Q?R1m+yRthY01uloA19GGHfHWYUJb37ZesFSfrwtHXJ6Ge2TBoffQNlTyOQsyg?= =?us-ascii?Q?np0th68wjnIbwGbx0PeugaAEqRTS72Baf+EX1D35z921U0zSlg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB4313.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LpoFcqwCKCCR0An1+kLp2Pfi6ZGvvGH2Y8H7NhRE+OgfC7LEMc0Y7NLS5hm3?= =?us-ascii?Q?ejdyvjeXQwR9JCx5gzXmHuHZVGEXKQB3TcMgqbt3E6VASaFcyc2Kras3yink?= =?us-ascii?Q?u0FEFTMxPODEKWenDNifk0CRF79NDJysZkIcD41V5LzXQtTtecEOLu6SfQiB?= =?us-ascii?Q?tir6EbGGASW9VUNtGLaHs21yRqCZ7P/CDoui90h8xT4aGkHcstt/QEjvlpPJ?= =?us-ascii?Q?921JT+Wcupm6mSvnETaMNXB8q1B+/GK70zwyA28DzAh3HFiYpICkxzXGXyRJ?= =?us-ascii?Q?NGczwiANtrMJmijdo4uwEBZAZwyPAftTL+htuYppi+zlI0SnZ8dkXIASIPn3?= =?us-ascii?Q?Q8t0UfXc2LwVT6j/tYxNzEWyhZZBBYT4X1tVjNE+GmNBFVQ5EQU6pnaUZAHn?= =?us-ascii?Q?RTGr5ybasswKE3FbZUz+wTGUlBGz3QbAXNY0lQcCK7y5OzAVIplxUteOKtuF?= =?us-ascii?Q?ZGgJiUcw/Ih9cuMjcvJp3HquAbwPnBQbdoLxksuLg7XR/D55fRRcOwKIFWXq?= =?us-ascii?Q?XGFrW6AEEWM/YzD3J9XX/lC5sxA35u2tQ5is9zotbh+anbVNzP9chbRNHVfD?= =?us-ascii?Q?Oi6R5hXEdeBuAmNCxwBmjBJhcnEK3GvaF+wPOWWL1Ljdw9XkDZfZ6IvcolHs?= =?us-ascii?Q?I6tdRpVgGqlprbDEdyx8wBivpF76AKMAbjeKjl5/TPfpxLxDm6YmPLsuGjh7?= =?us-ascii?Q?ni4Yb/KM+sN7Q5D1gQQmrkZFxJNajmkm9itLxYs3oylZSYUCYwqM/f8YKBMf?= =?us-ascii?Q?qSb/QP3M8p5NLe/vD+uu0G0unoEzIftyTulJBBJba0YQeyiUIKpFjCXlg4Cs?= =?us-ascii?Q?kyakRRkQq9//+RBWfBpvFNDW4rjd4a1U2SM0zqBLwUI21yNYyMpA1/toRyAV?= =?us-ascii?Q?kIBsnyEFwe33sTmUuxEvJ102+HNtr8zyKb2rKKTHZfDBLM1dMlbsJGYFaD4b?= =?us-ascii?Q?OH7dQsd7F0KMVo48+i6AELukTvJ1dVnnnol4ydtT2JsK/HlN89gOATHn8QiS?= =?us-ascii?Q?+fepBWbA2KLHRlE3hJ6hQD99NRkIwBH+59OpLOjJaisHiXto73fIQn8cwrhG?= =?us-ascii?Q?VYfeFLVgZoQEMkVOB0D30ksg3c0GmgshgcyzkYe9riyPN03e74+LsAFWSmC6?= =?us-ascii?Q?1ERBPq1VrcWhHtMz6ggyrPLRrjcGXyybeRt6w/yxqunjMyGMD9EAAz5kiVMN?= =?us-ascii?Q?jvDiEWyh6eSptGchGP2g16Ln32/pG1i59rxR9bZ74SmQV6rrrI0Lt2Y8Xj2Q?= =?us-ascii?Q?hYRmN4gasdiTgi6ONXcArAcxpa8VPFDFCoe/72V9djzhZdZ27UFJhpKoG59V?= =?us-ascii?Q?Anb96dcH3ZoYlE3P6FSTK2fygbBnYdGUi4YaqdB6becFpgFFqPgl/3vTQV8x?= =?us-ascii?Q?kObl9FnOJbymHZbN2bY2FgZ/OiI0L+S51rzfiD7w/3F2lyNAmAQovb7z3hW9?= =?us-ascii?Q?MgpqIpa/LdeTegy/Lc5bwGd8O1yNlEVKwWNS4gHBSPqCxUeK0dUDtYP1fLq4?= =?us-ascii?Q?klT9ou0CpdN7nJnW3bCGHHX2DrW94ymUvuqXP0zRBSt8uEjyi6Lwk/Liwc43?= =?us-ascii?Q?yxY2c3Y4Nxf+ADch2MaA1/uajxd0+ZFLRf9SqQyY8TtwosHGqzpnz5WUGjht?= =?us-ascii?Q?hw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 5FXMFqVdznQQNJDh1gIW61xMcMokncuNXzAWZ0+Gjir/2YEVHIRYPMDwfhw1shZebM/gKP1Mgm7b2lP+3yrtxpHxG3COPl7fMdr8Fre6N8G6AuM+RmbjTZsvsTISBtl9fsD6jZPNdkUFJpaWFqee3/QNJvY4w5qJJD9Mx59sDhjEuJmJbwQG35EkX5z5vWbfN9Z4+RcMkrvCYU5nIJPCeP4Hg7rhcXsP/YR1A71O2lFR79xrsh+UOuZqSoZMKIEu0jm165yZu00K5Fdr4hxuvaxNNXr5BTmBPvknWRNsxCbCQYgBAZxQe9o67AG7vVwq+tW63H4A9f11ezVYFoyv/b6NQ0k5GSlGK7PW1Ozwlx5KRiuViwuUZMw4ACOuHxjmbbzkC3/R8mUCVnIjGMmKh6Kc8wbMB/iuOofyRZcIWlgm8mgjuBLD64SDgyoHXRX4UOSXjrNHBY2AdN8z9Pxd+B0bi7TbH+8+VU8q3+9bUKX0oNkyW5INHpQnmeTYQk9Tr/xwX9tVHwtL2G1l/OQ3ANEroPsPHSgAIgZYoKj7a/oc1e3pDLD7Do/A+JhhVn6vGZ3ri5CU0KQtQyw3CPgfwZTLurPxzohoHjyycqBL9XM= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4845d63a-a3ef-4b02-915b-08dd8aea15ed X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2025 09:00:15.2364 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zmM/KiLvHg7eHby7Z2q1g0xFZR2C8wsx54NByCoOkvK51bjv1Mnd9CtyX+tAym5RCTmmeQ9/E8PhMMm2++RSOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB7178 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-04_03,2025-04-30_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 phishscore=0 malwarescore=0 mlxlogscore=999 mlxscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2504070000 definitions=main-2505040081 X-Proofpoint-GUID: -Y9-8y6URCPA52GZ7Aku1hD_REMT4ipe X-Proofpoint-ORIG-GUID: -Y9-8y6URCPA52GZ7Aku1hD_REMT4ipe X-Authority-Analysis: v=2.4 cv=PouTbxM3 c=1 sm=1 tr=0 ts=68172ca4 b=1 cx=c_pps a=zPCbziy225d3KhSqZt3L1A==:117 a=zPCbziy225d3KhSqZt3L1A==:17 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=dt9VzEwgFbYA:10 a=GoEa3M9JfhUA:10 a=VwQbUJbxAAAA:8 a=yPCof4ZbAAAA:8 a=-okyUcW3L33xbzEWqc4A:9 cc=ntf awl=host:13129 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTA0MDA4MCBTYWx0ZWRfX2H58FG9TuxoE b+Zum7AN7v86PNnTv4h+T12lOkZWCIBWTocPifk4Hz/bkSlDXa/R6CMR1ChVf4rqb4rdNdqrADf RBNyNiWlR4MplxvbUPaAk5VZODl3jFCY+qXOAw8VK1AAxS8lcnNWx3GMv+ewx6oPvV+DMJ30cjf wIT4EYM+KCfZsu7hY1SAUwoCw1W1NI9LUtEJn9RnVqld3HhZSPr0R8I64eG9teiwunjLEirjwSg wb1EPynHuKoPqhz25lXpz7oP1PFffZEqe+qis45MaT5vQ6fubbNXk+YSIjdgbX1P+cAINQ1zEm2 7uMSgaj0oCkQU4Elg6jxDCpZePw/IM7HFTszTK5xZTfUl6n4YD57kWEAeTHqNKHzQHbKaC7+RTM K2zRu4uleAQvSfSw/vvXf7mBgMSZH8+bcp7YV8nfscqplH+YsPAINVy+cmZ6oQwdrFtY7VlF Content-Type: text/plain; charset="utf-8" Update the limits returned from xfs_get_atomic_write_{min, max, max_opt)(). No reflink support always means no CoW-based atomic writes. For updating xfs_get_atomic_write_min(), we support blocksize only and that depends on HW or reflink support. For updating xfs_get_atomic_write_max(), for no reflink, we are limited to blocksize but only if HW support. Otherwise we are limited to combined limit in mp->m_atomic_write_unit_max. For updating xfs_get_atomic_write_max_opt(), ultimately we are limited by the bdev atomic write limit. If xfs_get_atomic_write_max() does not report > 1x blocksize, then just continue to report 0 as before. Reviewed-by: Darrick J. Wong [djwong: update comments in the helper functions] Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig Signed-off-by: John Garry --- fs/xfs/xfs_file.c | 2 +- fs/xfs/xfs_iops.c | 52 +++++++++++++++++++++++++++++++++++++++++------ 2 files changed, 47 insertions(+), 7 deletions(-) diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c index f4a66ff85748..48254a72071b 100644 --- a/fs/xfs/xfs_file.c +++ b/fs/xfs/xfs_file.c @@ -1557,7 +1557,7 @@ xfs_file_open( if (xfs_is_shutdown(XFS_M(inode->i_sb))) return -EIO; file->f_mode |=3D FMODE_NOWAIT | FMODE_CAN_ODIRECT; - if (xfs_inode_can_hw_atomic_write(XFS_I(inode))) + if (xfs_get_atomic_write_min(XFS_I(inode)) > 0) file->f_mode |=3D FMODE_CAN_ATOMIC_WRITE; return generic_file_open(inode, file); } diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c index 77a0606e9dc9..8cddbb7c149b 100644 --- a/fs/xfs/xfs_iops.c +++ b/fs/xfs/xfs_iops.c @@ -605,27 +605,67 @@ unsigned int xfs_get_atomic_write_min( struct xfs_inode *ip) { - if (!xfs_inode_can_hw_atomic_write(ip)) - return 0; + struct xfs_mount *mp =3D ip->i_mount; + + /* + * If we can complete an atomic write via atomic out of place writes, + * then advertise a minimum size of one fsblock. Without this + * mechanism, we can only guarantee atomic writes up to a single LBA. + * + * If out of place writes are not available, we can guarantee an atomic + * write of exactly one single fsblock if the bdev will make that + * guarantee for us. + */ + if (xfs_inode_can_hw_atomic_write(ip) || xfs_can_sw_atomic_write(mp)) + return mp->m_sb.sb_blocksize; =20 - return ip->i_mount->m_sb.sb_blocksize; + return 0; } =20 unsigned int xfs_get_atomic_write_max( struct xfs_inode *ip) { - if (!xfs_inode_can_hw_atomic_write(ip)) + struct xfs_mount *mp =3D ip->i_mount; + + /* + * If out of place writes are not available, we can guarantee an atomic + * write of exactly one single fsblock if the bdev will make that + * guarantee for us. + */ + if (!xfs_can_sw_atomic_write(mp)) { + if (xfs_inode_can_hw_atomic_write(ip)) + return mp->m_sb.sb_blocksize; return 0; + } =20 - return ip->i_mount->m_sb.sb_blocksize; + /* + * If we can complete an atomic write via atomic out of place writes, + * then advertise a maximum size of whatever we can complete through + * that means. Hardware support is reported via max_opt, not here. + */ + if (XFS_IS_REALTIME_INODE(ip)) + return XFS_FSB_TO_B(mp, mp->m_groups[XG_TYPE_RTG].awu_max); + return XFS_FSB_TO_B(mp, mp->m_groups[XG_TYPE_AG].awu_max); } =20 unsigned int xfs_get_atomic_write_max_opt( struct xfs_inode *ip) { - return 0; + unsigned int awu_max =3D xfs_get_atomic_write_max(ip); + + /* if the max is 1x block, then just keep behaviour that opt is 0 */ + if (awu_max <=3D ip->i_mount->m_sb.sb_blocksize) + return 0; + + /* + * Advertise the maximum size of an atomic write that we can tell the + * block device to perform for us. In general the bdev limit will be + * less than our out of place write limit, but we don't want to exceed + * the awu_max. + */ + return min(awu_max, xfs_inode_buftarg(ip)->bt_bdev_awu_max); } =20 static void --=20 2.31.1 From nobody Fri Dec 19 16:07:40 2025 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41F921DB951; Sun, 4 May 2025 09:00:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349234; cv=fail; b=TilRatVCv3t5vChNAnNy93JaBG96In86J7NLTiHdtUIRSfhwnyIKiVzQ4SZdXp7Zip4SRAlEf0sDdjjTrBkJ3elb3Dl12xieAPoWP5gvU9Ia7TMctg6R5dLHbnjUWZd50OE33W7nK0XDQoMbBwzTdY8ROKdrGaQMI4zJdn6UrEE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746349234; c=relaxed/simple; bh=grD7ifJZSCzAsDbA6LAY+ymaIi6biQ4JtrUjxHisUfM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=EX0j/AQsqIn7uW3alw43uDbqgSRtFU/nfFXm6HJhXDa8y7bHklx6A2/0y+tvKX7qa48o6pErDmhpr8ztbQY2Ar00Fqba3dGfCo0ZKnJlMJH6evLoGvYNtj+vyGfmG9XthcoUltSzpFX2yuj6sPSR85G595cJlwrHGEaR2RurmUA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=YUriLf0N; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=HoK24fpD; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="YUriLf0N"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="HoK24fpD" Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5447MmsQ013216; Sun, 4 May 2025 09:00:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=JB+yRRLFDy8/oY8gCkDWw1Rql7iafCnpEv1JJwhIj0Q=; b= YUriLf0NG9dmuxSGXj/QYmo4tpkkYQy7Zr3Z0AIVdH11bY41Y8HOvciy9GmVq5CH MUszgcltZ6yS34e23fR1DmQbUMYy/wTjPgv6dQo90s0UfBex1OyVua+Xy5Bkm1kE nmfNZwHjuZ2FlN731KmBPAtM3So8VF7xcWUTIbo9vex1bnGkk2WT0T7aYawsUoGt R7kELOQ1K7XyYpXIGhDl97Z7zesqNMablckxIYKRz6evXAyj+WcJaLefWdEMEeX8 unlwCJEcKPbgDpYePlJCPyHyW8aQtinnpAb4oiPejRtbFSkK0riVt5QelLi+hYMm ZNkG7NyN/wPxja8gn0gK5Q== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 46e3smg2sn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:21 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5448iX5M036027; Sun, 4 May 2025 09:00:20 GMT Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazlp17012053.outbound.protection.outlook.com [40.93.20.53]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 46d9k7ghya-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 May 2025 09:00:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=C7lgwOgFRU2dk4d/nQs5f0Qa1W71UeiyZ3J6SUF5nN1fR5Uu1qPdH1ui85oH5auTjpVX46+FRKhfMEqLrh47tVHOKLy5MntvwXwuiR78DAOxT7A4DBdZVvaEs+xvPVgSY5U9E0otJzp63L7aOam+WjGt6Pt9Z29spgVacg45pwGX9vp0UWwds6HFxVJn6EE5Iw6jSRmkWKPOQWULxMrcdvWNo7LQ2YSZcq3nis1yFoV5toRuSZL7IHI7DqavM4i/1CRa2BP1FOXJMA3/K1z1Y+LpnZFcIRp6DrFYlo0Fqfdwc06pQDpvOhOQB//h6WvlAUd6+JVWDpizAkqbTfZ/sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JB+yRRLFDy8/oY8gCkDWw1Rql7iafCnpEv1JJwhIj0Q=; b=dpmHRg3GZ2mRhhqc7qDTYMlCnhZef40eaYAHiQwRdDq0LUkvXTlrIxFekwgFIfYhpp8t8i7LPbZsSv/ZJnQKKKi2xENOKIDAYRObU9JmH9qGSqTbOhPoRjTY/72hIdEMa1Mh4qb7MLmWqAut/vkpIj6fVmBcsv0qiGyZulNIF76sqVEOEuG9GmS/aK5VUwROqUzRgewk0DiwhCv37icPKFLjRPQIj/jZn28Sq7kq5aEajJNSREgTdZpEb6q1hSB+v29nSwdRcACRKrdeo3UDXkNA3DptmIb6Jj4N+uUvVW+N+jJ/5RrCSeyMGBF1V/d/blOsYi+SAP97K498NV0iag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JB+yRRLFDy8/oY8gCkDWw1Rql7iafCnpEv1JJwhIj0Q=; b=HoK24fpD/jEeIi2U5HQ7lC4TT3AbXZJ2iPLK8p2ULR/wjTZtofYNgM+woRmLMLql8EQsWusM2CLxX08WhQYD7AuNj/chrTJ30sr8tcZ8ojUp9HwhDfasP9THgvywETeX/9DLcST4/4uHPO7ltxNi8AyVPTiHaAriORk90emxVcY= Received: from DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) by PH8PR10MB6648.namprd10.prod.outlook.com (2603:10b6:510:220::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8678.31; Sun, 4 May 2025 09:00:17 +0000 Received: from DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088]) by DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088%7]) with mapi id 15.20.8699.022; Sun, 4 May 2025 09:00:17 +0000 From: John Garry To: brauner@kernel.org, djwong@kernel.org, hch@lst.de, viro@zeniv.linux.org.uk, jack@suse.cz, cem@kernel.org Cc: linux-fsdevel@vger.kernel.org, dchinner@redhat.com, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, ojaswin@linux.ibm.com, ritesh.list@gmail.com, martin.petersen@oracle.com, linux-ext4@vger.kernel.org, linux-block@vger.kernel.org, catherine.hoang@oracle.com, linux-api@vger.kernel.org, John Garry Subject: [PATCH v11 16/16] xfs: allow sysadmins to specify a maximum atomic write limit at mount time Date: Sun, 4 May 2025 08:59:23 +0000 Message-Id: <20250504085923.1895402-17-john.g.garry@oracle.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20250504085923.1895402-1-john.g.garry@oracle.com> References: <20250504085923.1895402-1-john.g.garry@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN2PR08CA0015.namprd08.prod.outlook.com (2603:10b6:208:239::20) To DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB4313:EE_|PH8PR10MB6648:EE_ X-MS-Office365-Filtering-Correlation-Id: 20fdf0c8-9622-4997-e834-08dd8aea16f7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ke9tehcHYdcvL6O/aPPfqIW0bnhVVYpVEcR0oH3+rMCYDv/uWjqL0Mwb4wBf?= =?us-ascii?Q?lxEcZ1pqec1sopTz0fOVBbesxw/UFGnmrVZPhJI9EnNLa/uqkCqjCTposrAv?= =?us-ascii?Q?ya8BQdZjI7ALtEZobsTBDSkbOE+glX6zZ10J4L+pB71ii4SD6rJCO/NfMjPI?= =?us-ascii?Q?3db+kkL1rzhH9b5U7LFY+gELdvVfo0zMl9hxMYnGZVaBSskb4QzhkMMtrJgH?= =?us-ascii?Q?Z+zQFrqd2yFyObPDdBmy6sO0tiukXO0WW5yCNdSU9PnTvB9Snql1rY+8OMZZ?= =?us-ascii?Q?JyT97iFkC4GFpAjn+3sxEb8n2A7kocSvSFkO817HwseVEtGLFGyTR6PPj+P5?= =?us-ascii?Q?t0F85Zvc/20pomhqwkN4mBfGhTSywzVsljZTqrABjrI0fbtx81UYHjpZOIKC?= =?us-ascii?Q?cLIjQoDrgYx4oHRgwjgWdLC/EGRUOj663aFQyRVmVxVN+1Q6srABcMAiBLs8?= =?us-ascii?Q?yNyvgrOi8LdbeM+Ce467+UlfA0MXSX723BF/1cWm2Qasdj7rXHhmaRS2CSCM?= =?us-ascii?Q?kQUJMJio8sbO4Cic4YWMl+qNGHOt8pnjTSPqHptYpDG9rojJI/u0XshSWxqG?= =?us-ascii?Q?HoSsGYpOXTLdd2OgxEz+AymtR0UHu5/rm4koMnmcgryzvba2pZh8HrvaLean?= =?us-ascii?Q?9ATfxp3OiobIF4j2s1Z0nuglaSFLiGgHfnRovKlKT+uTYVDNvzFd0Jj/Ft1s?= =?us-ascii?Q?HpMeStMPi6C4KsqCJiW6jroiJhRiuWj8aK0cKRDr2ydMA4/99X9KKb/03Fna?= =?us-ascii?Q?fzgNHrYxtZYVTzuzzmtMmCMfLXn49GTDNiIsh1K3p83hsP79XRLDGPwVOQEB?= =?us-ascii?Q?SHIOf/SPxIiuDGh/QwAfnBqIu5vmy3aTjN8b6AZgz+0qF8u/zzzch9NDT+Zd?= =?us-ascii?Q?UVtErb8S1GlnhXUmSXsYgfFOePEE16MC02D6YS8AFqZJftT8n1C3aPhODgPp?= =?us-ascii?Q?4TtTKSPgjis8Oe9ULSPqPubd5uTgwpYDXOWOkYxZ/nd6jk8jJX8rkTbjrGxt?= =?us-ascii?Q?KdXY7PVwDEkk7j8FTZHbH5XXj/qYw0qNoNeXZ3N/pJXb2TUEiXSou2wHI1OI?= =?us-ascii?Q?42UntBNW9K2CIpxFzKeJHRdqhw8lzqw2/RDfqkM3Sl61cyKWQucdblVxqugk?= =?us-ascii?Q?8e+xSTDo/K7e8i1ewP03urWUumBcddOqr49Ee6pRk3dFMB0VSkU7bw0zSdrR?= =?us-ascii?Q?yrXL7MMaS96PbhifRbO6eTaxa56f9QHkI6wUfxOxLiceukBJgM6wD9t/5THA?= =?us-ascii?Q?IeHwBfTMI1p2hBRMcfos31HMiTLP1s0zA/VKntuzZ+OdYF5Rzd9kU1NZt5ZJ?= =?us-ascii?Q?VDnI22MPtTNFYm8FJO2SMLc/thqatEk0VWK2SRXdU0q8PzlQLH7LFPtgIj2W?= =?us-ascii?Q?7VLvwq8uF6l5auS48s8RDxvE5yjarKS1+hEiSY0NGDV3/sLw4aRCWl0fESZs?= =?us-ascii?Q?fQ4H68I/vro=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB4313.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?d9rPZqd9BsWWYO38fZBOwzHx/TBRMCcLOaRKgyRSC8M4QuMRGuY3mmFBuHER?= =?us-ascii?Q?X7U0UpRrqA2Lq3WHjVC2Hbxhq2usJKvamyqAsfS8BhmJ2JMDUGrolrIY8PeL?= =?us-ascii?Q?zxgM6u65Byx5AKus8XtCy0JWLXDyYifKmBRgcQYm7PfWct+CaR4c54ACpFvG?= =?us-ascii?Q?eNpLF5P4NaDlS60grl1C3/JvQtPJFatI0Nuu7fAUCSOEywcBWhff1A/77+q0?= =?us-ascii?Q?UzwlXTV7gJ2FdbiGNkHO7XdwLSzBxSyB9FrS+1plLT8Kj72H8DFKgMxskKVo?= =?us-ascii?Q?SEQ9XNGAIc4yE5ELtg5Co1wGGdqjA3cY/MHWPz0QEsqQmLbEtQIRWvK9ayYG?= =?us-ascii?Q?cUPAKGC9AF34mcEo5KZwT04DyvJmJGDOuJgIXrVVfOBowiJQu+nFhDsVfAwQ?= =?us-ascii?Q?5cv0ldxytFZ5yJg9I480RRhNQfGuzRygjASHboEL+gemagu1NwPYYB7x6Sx5?= =?us-ascii?Q?n+f+W3lNeav7jHbEW1aDaNKLhbAHczQU7oAuFK1dW7qEjlUDJJWwuWDy68Qb?= =?us-ascii?Q?o58h5Em6dSNSk6x9cbnmY0rG5yOkIBxtqauSZDcDdTYWrMy+/dpxWT9vciM9?= =?us-ascii?Q?b784oPBSus7YKdu6X70FQeXtxTaBq7c6a3LTK7UbP1Z2Yq768umeOUp9AEVX?= =?us-ascii?Q?Ku+wO8ZNlW2OvAqaXm3Hu8g+nkdquFHgqh1OWdaqbYooXdF+e9AAxiYyB0J+?= =?us-ascii?Q?1IYsdoatnnLCn7aTKPil1siRMZdOfrR4HSUgvNFxkLSwnW+k1+9OfR57hHS8?= =?us-ascii?Q?qM/WQdOmtbWTodlbJU50Ag7GFAB4VuQu7xfogXpztEbgtfUodGBXYtA4oMgC?= =?us-ascii?Q?6KkRCZ9arVqSCUQ0TKy7puuO0CHXe86KoZpJ7fW1DbR1C4iC1qSGlD5M9DdT?= =?us-ascii?Q?q/RrFr3dYd51v6sH02scMFrw6c0BFtNn8uTeyW3be3qLzma9Aq+fN86AuAgU?= =?us-ascii?Q?NdLvMjrPCDHpR1Osnh1AzguywuQu5iF4kEEvgDNIOVyE87NYrkHElZvKEMvX?= =?us-ascii?Q?T66vyWhPFt61Y0vSAdmOLTb/ops1Z/5O9VMiHJViR8FJWj567JzPOkDuDV1J?= =?us-ascii?Q?imIajPS0wpimcB8G/JbDtN1upiP703q1q1741DzP2XPvXc2u5w//FApBkjtX?= =?us-ascii?Q?llVXsVfDZG2ZZ1azCZsrOSJLNa8NQTd8Ho/SeXyvI8HhZaeqMn0Rv9TBwWLo?= =?us-ascii?Q?zwVb+WbBPCoSjjaGD9PW3589VH8Wv5He0v+VTZrAr9jgRL9mfxTHvBBkgtQC?= =?us-ascii?Q?y18mYQpUFnoSbYi3jeK8xDuSrhNzdhP7Py8cNhOsfJoFfZBlRwfYgexG1NNM?= =?us-ascii?Q?o3MeZDy0rLKTMefTvDC5st7vFmi91KWt4yNAVpKtH6ubRP/z044utMN/DJtJ?= =?us-ascii?Q?ID6etJWcc4I9MPzFWpuksvmWR97t8Dcp9JoNQo+rOJqs6gdsKOPv3oFdjfF8?= =?us-ascii?Q?0ptPY5K40QOyCYf1qDzSih0YhQdZfV97ezqHw9dc6h0W3JPFOk1GDTF2Erbr?= =?us-ascii?Q?CZU3AmieaXaLVsdvNcsxEvovgFpIZ2xdxJHeD2tqVLm9RK9K8/vvnmMEmiAJ?= =?us-ascii?Q?uHsm0UE6UvRRRFbymX3aV7Ke7n6/se0z1Pnxje/Oz1+wx68VqA+HF04d9GdO?= =?us-ascii?Q?kw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: kihQRJLTvmxGjS/pdzYMJdds2JOOTgONAiF8HqdzmoTqT9LKWKeOZGOf25zosztSYEgXYUOADV1mqs0s7cUWIziUFdb5Xr1dx0v84kHj/zzDoRX2LwkSEhiX9AfcP8qweneRQSI/eHJR1lRxjbEgrgam/vHjCnxtrVpippy4wO6+owIBRCyNqry/h4S7F6cY3tEO3Yejb14gpVJs990PgsxfGU2X6GQk5XJFZ6wyOcrJiPmZ22vaTicFGUiNNRMS4MlZ4jVpwLWy3mbIN3uzTBpDjhKT2tTGi7Vto+u1ElEdZ2XPCFrhRT3Up7gP2P11/2FONp2vTb9QFGqqOHKms+CtTTo1s5pwj2jNmbb4D9PN6O9YdG9WuBeTF6CJiZAnEVkySHB5SW7322+54QmJYntGXHA8ftAKilwDN65N72CxE5B0sJGDHFm+GxbN6b7RaD2+DvcyIysPUByaEVNp9CLaHJSOzBRA/7dEf+R+ykTKVJnRWYJ/nlxEnlPB1nI1HjrQ8e/ziC7hSI6RW/T33JGjv8l9c+RzTgK3e8Irw1bGgCruUBUfB4PwT2SlwlWXxQsAIYp8nwTfzl6qm6tb+QeUIGeH1cwVJwpdi6unuIU= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20fdf0c8-9622-4997-e834-08dd8aea16f7 X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2025 09:00:16.9919 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iimnE/9M86qg1zXHAS9htBhsvUXk2VlFl88SONidPRYoOc2nwK7NBCdrUmvGrOsBC4VZ5+bQRMQT/7BPVo4WQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6648 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-04_03,2025-04-30_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 adultscore=0 phishscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2504070000 definitions=main-2505040081 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTA0MDA4MSBTYWx0ZWRfX2G6ry7DAxait jgeAkUSGCuthm/WuxbTMv9y9UmrdhFfgqHSlEyVDjMay50rJk7g486eb3qdyjOoi2lmTTswsiB4 SyaxeNHMxzwFI27bSgnx84hpllIGokp16giqF/Daom6oIDiFDN++GH9I3RXYqXnFz7sJyTYuP0Q XAUSzLl7AUHqbyIftqG6FF+2Jz06ivzaG4gsEYbOBknHEtfkNcMq1ecVo9MtyQz1OkOqSRd4w8B uQqgQr+zdO3mAtJdUY94w8+Pg3me8Or9VyEraD1DviR1oTDudhLsVpHcG1CnWMZoG86HmubnXVB y0Ls2hahjSRVYJUlG7GQai/s4S0N6Bn7bdKUD7QI9g0rD9S2wb3DYDKYq/iWkapZS+SqtXlyeP7 /JGRsv7CTgJsBW4SoBb7wAhnOWkU3NV8+Kb3+cbnklG4ypmaeOuEQCejZnbw+IggyNp8utJn X-Proofpoint-ORIG-GUID: ZgNLJoo9tdu3MbxjnLZ0bemPesfymgKC X-Proofpoint-GUID: ZgNLJoo9tdu3MbxjnLZ0bemPesfymgKC X-Authority-Analysis: v=2.4 cv=bNgWIO+Z c=1 sm=1 tr=0 ts=68172ca5 cx=c_pps a=OOZaFjgC48PWsiFpTAqLcw==:117 a=OOZaFjgC48PWsiFpTAqLcw==:17 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=dt9VzEwgFbYA:10 a=GoEa3M9JfhUA:10 a=VwQbUJbxAAAA:8 a=yPCof4ZbAAAA:8 a=vofBRnjZkZwxpctGmH8A:9 Content-Type: text/plain; charset="utf-8" From: "Darrick J. Wong" Introduce a mount option to allow sysadmins to specify the maximum size of an atomic write. If the filesystem can work with the supplied value, that becomes the new guaranteed maximum. The value mustn't be too big for the existing filesystem geometry (max write size, max AG/rtgroup size). We dynamically recompute the tr_atomic_write transaction reservation based on the given block size, check that the current log size isn't less than the new minimum log size constraints, and set a new maximum. The actual software atomic write max is still computed based off of tr_atomic_ioend the same way it has for the past few commits. Note also that xfs_calc_atomic_write_log_geometry is non-static because mkfs will need that. Signed-off-by: Darrick J. Wong Signed-off-by: John Garry --- Documentation/admin-guide/xfs.rst | 11 +++++ fs/xfs/libxfs/xfs_trans_resv.c | 69 ++++++++++++++++++++++++++ fs/xfs/libxfs/xfs_trans_resv.h | 4 ++ fs/xfs/xfs_mount.c | 80 ++++++++++++++++++++++++++++++- fs/xfs/xfs_mount.h | 6 +++ fs/xfs/xfs_super.c | 58 +++++++++++++++++++++- fs/xfs/xfs_trace.h | 33 +++++++++++++ 7 files changed, 259 insertions(+), 2 deletions(-) diff --git a/Documentation/admin-guide/xfs.rst b/Documentation/admin-guide/= xfs.rst index 5becb441c3cb..a18328a5fb93 100644 --- a/Documentation/admin-guide/xfs.rst +++ b/Documentation/admin-guide/xfs.rst @@ -151,6 +151,17 @@ When mounting an XFS filesystem, the following options= are accepted. optional, and the log section can be separate from the data section or contained within it. =20 + max_atomic_write=3Dvalue + Set the maximum size of an atomic write. The size may be + specified in bytes, in kilobytes with a "k" suffix, in megabytes + with a "m" suffix, or in gigabytes with a "g" suffix. The size + cannot be larger than the maximum write size, larger than the + size of any allocation group, or larger than the size of a + remapping operation that the log can complete atomically. + + The default value is to set the maximum I/O completion size + to allow each CPU to handle one at a time. + max_open_zones=3Dvalue Specify the max number of zones to keep open for writing on a zoned rt device. Many open zones aids file data separation diff --git a/fs/xfs/libxfs/xfs_trans_resv.c b/fs/xfs/libxfs/xfs_trans_resv.c index e73c09fbd24c..86a111d0f2fc 100644 --- a/fs/xfs/libxfs/xfs_trans_resv.c +++ b/fs/xfs/libxfs/xfs_trans_resv.c @@ -1488,3 +1488,72 @@ xfs_calc_max_atomic_write_fsblocks( =20 return ret; } + +/* + * Compute the log blocks and transaction reservation needed to complete an + * atomic write of a given number of blocks. Worst case, each block requi= res + * separate handling. A return value of 0 means something went wrong. + */ +xfs_extlen_t +xfs_calc_atomic_write_log_geometry( + struct xfs_mount *mp, + xfs_extlen_t blockcount, + unsigned int *new_logres) +{ + struct xfs_trans_res *curr_res =3D &M_RES(mp)->tr_atomic_ioend; + uint old_logres =3D curr_res->tr_logres; + unsigned int per_intent, step_size; + unsigned int logres; + xfs_extlen_t min_logblocks; + + ASSERT(blockcount > 0); + + xfs_calc_default_atomic_ioend_reservation(mp, M_RES(mp)); + + per_intent =3D xfs_calc_atomic_write_ioend_geometry(mp, &step_size); + + /* Check for overflows */ + if (check_mul_overflow(blockcount, per_intent, &logres) || + check_add_overflow(logres, step_size, &logres)) + return 0; + + curr_res->tr_logres =3D logres; + min_logblocks =3D xfs_log_calc_minimum_size(mp); + curr_res->tr_logres =3D old_logres; + + trace_xfs_calc_max_atomic_write_log_geometry(mp, per_intent, step_size, + blockcount, min_logblocks, logres); + + *new_logres =3D logres; + return min_logblocks; +} + +/* + * Compute the transaction reservation needed to complete an out of place + * atomic write of a given number of blocks. + */ +int +xfs_calc_atomic_write_reservation( + struct xfs_mount *mp, + xfs_extlen_t blockcount) +{ + unsigned int new_logres; + xfs_extlen_t min_logblocks; + + /* + * If the caller doesn't ask for a specific atomic write size, then + * use the defaults. + */ + if (blockcount =3D=3D 0) { + xfs_calc_default_atomic_ioend_reservation(mp, M_RES(mp)); + return 0; + } + + min_logblocks =3D xfs_calc_atomic_write_log_geometry(mp, blockcount, + &new_logres); + if (!min_logblocks || min_logblocks > mp->m_sb.sb_logblocks) + return -EINVAL; + + M_RES(mp)->tr_atomic_ioend.tr_logres =3D new_logres; + return 0; +} diff --git a/fs/xfs/libxfs/xfs_trans_resv.h b/fs/xfs/libxfs/xfs_trans_resv.h index a6d303b83688..336279e0fc61 100644 --- a/fs/xfs/libxfs/xfs_trans_resv.h +++ b/fs/xfs/libxfs/xfs_trans_resv.h @@ -122,5 +122,9 @@ unsigned int xfs_calc_write_reservation_minlogsize(stru= ct xfs_mount *mp); unsigned int xfs_calc_qm_dqalloc_reservation_minlogsize(struct xfs_mount *= mp); =20 xfs_extlen_t xfs_calc_max_atomic_write_fsblocks(struct xfs_mount *mp); +xfs_extlen_t xfs_calc_atomic_write_log_geometry(struct xfs_mount *mp, + xfs_extlen_t blockcount, unsigned int *new_logres); +int xfs_calc_atomic_write_reservation(struct xfs_mount *mp, + xfs_extlen_t blockcount); =20 #endif /* __XFS_TRANS_RESV_H__ */ diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c index 9c40914afabd..f639af557b4e 100644 --- a/fs/xfs/xfs_mount.c +++ b/fs/xfs/xfs_mount.c @@ -740,6 +740,82 @@ xfs_calc_atomic_write_unit_max( max_agsize, max_rgsize); } =20 +/* + * Try to set the atomic write maximum to a new value that we got from + * userspace via mount option. + */ +int +xfs_set_max_atomic_write_opt( + struct xfs_mount *mp, + unsigned long long new_max_bytes) +{ + const xfs_filblks_t new_max_fsbs =3D XFS_B_TO_FSBT(mp, new_max_bytes); + const xfs_extlen_t max_write =3D xfs_calc_atomic_write_max(mp); + const xfs_extlen_t max_group =3D + max(mp->m_groups[XG_TYPE_AG].blocks, + mp->m_groups[XG_TYPE_RTG].blocks); + const xfs_extlen_t max_group_write =3D + max(xfs_calc_perag_awu_max(mp), xfs_calc_rtgroup_awu_max(mp)); + int error; + + if (new_max_bytes =3D=3D 0) + goto set_limit; + + ASSERT(max_write <=3D U32_MAX); + + /* generic_atomic_write_valid enforces power of two length */ + if (!is_power_of_2(new_max_bytes)) { + xfs_warn(mp, + "max atomic write size of %llu bytes is not a power of 2", + new_max_bytes); + return -EINVAL; + } + + if (new_max_bytes & mp->m_blockmask) { + xfs_warn(mp, + "max atomic write size of %llu bytes not aligned with fsblock", + new_max_bytes); + return -EINVAL; + } + + if (new_max_fsbs > max_write) { + xfs_warn(mp, + "max atomic write size of %lluk cannot be larger than max write size %llu= k", + new_max_bytes >> 10, + XFS_FSB_TO_B(mp, max_write) >> 10); + return -EINVAL; + } + + if (new_max_fsbs > max_group) { + xfs_warn(mp, + "max atomic write size of %lluk cannot be larger than allocation group si= ze %lluk", + new_max_bytes >> 10, + XFS_FSB_TO_B(mp, max_group) >> 10); + return -EINVAL; + } + + if (new_max_fsbs > max_group_write) { + xfs_warn(mp, + "max atomic write size of %lluk cannot be larger than max allocation grou= p write size %lluk", + new_max_bytes >> 10, + XFS_FSB_TO_B(mp, max_group_write) >> 10); + return -EINVAL; + } + +set_limit: + error =3D xfs_calc_atomic_write_reservation(mp, new_max_fsbs); + if (error) { + xfs_warn(mp, + "cannot support completing atomic writes of %lluk", + new_max_bytes >> 10); + return error; + } + + xfs_calc_atomic_write_unit_max(mp); + mp->m_awu_max_bytes =3D new_max_bytes; + return 0; +} + /* Compute maximum possible height for realtime btree types for this fs. */ static inline void xfs_rtbtree_compute_maxlevels( @@ -1161,7 +1237,9 @@ xfs_mountfs( * derived from transaction reservations, so we must do this after the * log is fully initialized. */ - xfs_calc_atomic_write_unit_max(mp); + error =3D xfs_set_max_atomic_write_opt(mp, mp->m_awu_max_bytes); + if (error) + goto out_agresv; =20 return 0; =20 diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h index e2abf31438e0..5b5df70570c0 100644 --- a/fs/xfs/xfs_mount.h +++ b/fs/xfs/xfs_mount.h @@ -237,6 +237,9 @@ typedef struct xfs_mount { unsigned int m_max_open_zones; unsigned int m_zonegc_low_space; =20 + /* max_atomic_write mount option value */ + unsigned long long m_awu_max_bytes; + /* * Bitsets of per-fs metadata that have been checked and/or are sick. * Callers must hold m_sb_lock to access these two fields. @@ -804,4 +807,7 @@ static inline void xfs_mod_sb_delalloc(struct xfs_mount= *mp, int64_t delta) percpu_counter_add(&mp->m_delalloc_blks, delta); } =20 +int xfs_set_max_atomic_write_opt(struct xfs_mount *mp, + unsigned long long new_max_bytes); + #endif /* __XFS_MOUNT_H__ */ diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c index 04e361664710..c2c8d8aa487c 100644 --- a/fs/xfs/xfs_super.c +++ b/fs/xfs/xfs_super.c @@ -111,7 +111,7 @@ enum { Opt_prjquota, Opt_uquota, Opt_gquota, Opt_pquota, Opt_uqnoenforce, Opt_gqnoenforce, Opt_pqnoenforce, Opt_qnoenforce, Opt_discard, Opt_nodiscard, Opt_dax, Opt_dax_enum, Opt_max_open_zones, - Opt_lifetime, Opt_nolifetime, + Opt_lifetime, Opt_nolifetime, Opt_max_atomic_write, }; =20 static const struct fs_parameter_spec xfs_fs_parameters[] =3D { @@ -159,6 +159,7 @@ static const struct fs_parameter_spec xfs_fs_parameters= [] =3D { fsparam_u32("max_open_zones", Opt_max_open_zones), fsparam_flag("lifetime", Opt_lifetime), fsparam_flag("nolifetime", Opt_nolifetime), + fsparam_string("max_atomic_write", Opt_max_atomic_write), {} }; =20 @@ -241,6 +242,9 @@ xfs_fs_show_options( =20 if (mp->m_max_open_zones) seq_printf(m, ",max_open_zones=3D%u", mp->m_max_open_zones); + if (mp->m_awu_max_bytes) + seq_printf(m, ",max_atomic_write=3D%lluk", + mp->m_awu_max_bytes >> 10); =20 return 0; } @@ -1364,6 +1368,42 @@ suffix_kstrtoint( return ret; } =20 +static int +suffix_kstrtoull( + const char *s, + unsigned int base, + unsigned long long *res) +{ + int last, shift_left_factor =3D 0; + unsigned long long _res; + char *value; + int ret =3D 0; + + value =3D kstrdup(s, GFP_KERNEL); + if (!value) + return -ENOMEM; + + last =3D strlen(value) - 1; + if (value[last] =3D=3D 'K' || value[last] =3D=3D 'k') { + shift_left_factor =3D 10; + value[last] =3D '\0'; + } + if (value[last] =3D=3D 'M' || value[last] =3D=3D 'm') { + shift_left_factor =3D 20; + value[last] =3D '\0'; + } + if (value[last] =3D=3D 'G' || value[last] =3D=3D 'g') { + shift_left_factor =3D 30; + value[last] =3D '\0'; + } + + if (kstrtoull(value, base, &_res)) + ret =3D -EINVAL; + kfree(value); + *res =3D _res << shift_left_factor; + return ret; +} + static inline void xfs_fs_warn_deprecated( struct fs_context *fc, @@ -1548,6 +1588,14 @@ xfs_fs_parse_param( case Opt_nolifetime: parsing_mp->m_features |=3D XFS_FEAT_NOLIFETIME; return 0; + case Opt_max_atomic_write: + if (suffix_kstrtoull(param->string, 10, + &parsing_mp->m_awu_max_bytes)) { + xfs_warn(parsing_mp, + "max atomic write size must be positive integer"); + return -EINVAL; + } + return 0; default: xfs_warn(parsing_mp, "unknown mount option [%s].", param->key); return -EINVAL; @@ -2162,6 +2210,14 @@ xfs_fs_reconfigure( if (error) return error; =20 + /* Validate new max_atomic_write option before making other changes */ + if (mp->m_awu_max_bytes !=3D new_mp->m_awu_max_bytes) { + error =3D xfs_set_max_atomic_write_opt(mp, + new_mp->m_awu_max_bytes); + if (error) + return error; + } + /* inode32 -> inode64 */ if (xfs_has_small_inums(mp) && !xfs_has_small_inums(new_mp)) { mp->m_features &=3D ~XFS_FEAT_SMALL_INUMS; diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index d5ae00f8e04c..01d284a1c759 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -230,6 +230,39 @@ TRACE_EVENT(xfs_calc_max_atomic_write_fsblocks, __entry->blockcount) ); =20 +TRACE_EVENT(xfs_calc_max_atomic_write_log_geometry, + TP_PROTO(struct xfs_mount *mp, unsigned int per_intent, + unsigned int step_size, unsigned int blockcount, + unsigned int min_logblocks, unsigned int logres), + TP_ARGS(mp, per_intent, step_size, blockcount, min_logblocks, logres), + TP_STRUCT__entry( + __field(dev_t, dev) + __field(unsigned int, per_intent) + __field(unsigned int, step_size) + __field(unsigned int, blockcount) + __field(unsigned int, min_logblocks) + __field(unsigned int, cur_logblocks) + __field(unsigned int, logres) + ), + TP_fast_assign( + __entry->dev =3D mp->m_super->s_dev; + __entry->per_intent =3D per_intent; + __entry->step_size =3D step_size; + __entry->blockcount =3D blockcount; + __entry->min_logblocks =3D min_logblocks; + __entry->cur_logblocks =3D mp->m_sb.sb_logblocks; + __entry->logres =3D logres; + ), + TP_printk("dev %d:%d per_intent %u step_size %u blockcount %u min_logbloc= ks %u logblocks %u logres %u", + MAJOR(__entry->dev), MINOR(__entry->dev), + __entry->per_intent, + __entry->step_size, + __entry->blockcount, + __entry->min_logblocks, + __entry->cur_logblocks, + __entry->logres) +); + TRACE_EVENT(xlog_intent_recovery_failed, TP_PROTO(struct xfs_mount *mp, const struct xfs_defer_op_type *ops, int error), --=20 2.31.1