From nobody Wed Feb 11 23:32:21 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 389E4279355; Sat, 3 May 2025 15:11:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285106; cv=none; b=GmqrU1/GOlUs3mMwIy8njz94nPA2VQ4eKTDmsx1CnyP0+G/G+CsV1mo5K/Ic4fywJFmsobkwZbprmVvbtJih4EvrfGcWSCExeHwbAtT7uezDC7433I1ra7MXawZzc8mGtXHh9JhN+TnK+4yrIWwJDIAzqlUanWPr1sNaQYZiEn8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285106; c=relaxed/simple; bh=ijYwifvWJEjLfnj0SNILWg8XzNPfY641tVprLnJphLs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YKqIQnATMnclN+b2jTWRE0Q6opeJcfPqCUOdi9pwf9MPDecK+Yp9MX5st22e0NjvYaOHZzf9KQ5TOTkNSUSNx3v2Wwn7vgrMW/NrkcWMcqcHqGAMPcFRET01rfjNHPZEu6IlsfmqPYspNYAwpES7YDR+lbZ0gkjbffWXmXyduOk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iBl24mET; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iBl24mET" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CFBE5C4CEE7; Sat, 3 May 2025 15:11:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746285105; bh=ijYwifvWJEjLfnj0SNILWg8XzNPfY641tVprLnJphLs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=iBl24mETp2h9J8RUA9WYrY8Simxod++zw3TGB1pLSA2WkhRxHorZs5Pip43i83cLS 6AljzkUzK7fcUJr1Wfn+dEipl9tovo6vrORrAuvzvFIG0y8n7NLJhJ7c1MmiI1lqwc c/B0/YJxE++TLEOWVc3NGYJlEmSsa9k4uL5CXEcvBk0kpoLx7PZ4bvmfaDPkHfBClN zs4NdsFv50QlUCUYEsNDMdR+JMGM28AgaFnWfmdTvU7DdpywMRcIU53eeH8sSsmRiw dvYtkjkZNVz9eOLtZ1+/Fan2cJacdUQvhZ0IXQcGlYuY2ahAe+PqJrFWx4jcccOENN cJYG5NsFnnP9g== From: Jeff Layton Date: Sat, 03 May 2025 11:11:17 -0400 Subject: [PATCH v3 01/17] sunrpc: move the SVC_RQST_EVENT_*() macros to common header Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250503-nfsd-tracepoints-v3-1-d89f445969af@kernel.org> References: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> In-Reply-To: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> To: Chuck Lever , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , NeilBrown Cc: Sargun Dillon , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2813; i=jlayton@kernel.org; h=from:subject:message-id; bh=ijYwifvWJEjLfnj0SNILWg8XzNPfY641tVprLnJphLs=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBoFjIsRrOonPSBcO8TNbNTJUXww9VK/ySGJrDbk Nv3cJJTzvmJAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaBYyLAAKCRAADmhBGVaC FV2jEADCAXvNIFltlOPFv3bRAbA4Qks+xtDrCRK0cfdmecyHiyTZG3ci+Vf8ZMYGyfNXRKnAW96 0PnIfwLvNAnW+fS7fIzxUPZdZJ0ZTRj1+SP1McvQz5M59Vo6H6W53HY3NFhtkWmOksbGgQYu6HF Hq33H1vozLShQdxBE6tCyt2fk5mrLLiD2q3DEENbIxpRchYZ/ZzSeOQrk5nKgfyJKlso7CFt7Xf jTjK1o9F3kop32PgdfnuCiF+t9S+pcCyTn6E1C1nmVNDfgd0mssGNORGcDLose6fXU52Zrbzvkb +jalQU99gg0x3AleLi1e5zvT++aOu1kJwAlsv9E/LTun9hIqfyikRZtXciZkKTdXFFZrFIKtlfy fOIvYHj5zfToI0FlS0ul2DbMEBOGe9MkDdZbl5IYXtQ7WWF6v3sz0Tql19ci1usnNqRbRWMy0cc OJSJSy5ANVWBwObMekBQzsMhsCDIss5bllG6Az/6vwhdsrpU16vVBa2a062oDTyS/2vYtImPGXa +Cx6Qn/W+fX3zyH/oCibWMPuIBh1v7u2vEtv6tSVftUTLHmMSafFXbg84hZbaa0J50YsM/3yTAG 1HqLCsBSRjiQwiylQI1NXrzAhzixhloi/+cA1rJEVXt38HPxwB+h3B8bGzTYKOpU5/CSI8TkBAE pHi2/LJYpqa15Pg== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 We need this for some of the nfsd tracepoints, so move them to the common misc/sunrpc.h infrastructure. Signed-off-by: Jeff Layton --- include/trace/events/sunrpc.h | 23 ----------------------- include/trace/misc/sunrpc.h | 23 +++++++++++++++++++++++ 2 files changed, 23 insertions(+), 23 deletions(-) diff --git a/include/trace/events/sunrpc.h b/include/trace/events/sunrpc.h index 67db3f2953d5d64f2e8e455b218f7f6ecb7753ec..f945721e59e5eed5374bed9a2f7= 0e28b1d2db136 100644 --- a/include/trace/events/sunrpc.h +++ b/include/trace/events/sunrpc.h @@ -1716,29 +1716,6 @@ TRACE_DEFINE_ENUM(SVC_COMPLETE); { SVC_PENDING, "SVC_PENDING" }, \ { SVC_COMPLETE, "SVC_COMPLETE" }) =20 -#define SVC_RQST_ENDPOINT_FIELDS(r) \ - __sockaddr(server, (r)->rq_xprt->xpt_locallen) \ - __sockaddr(client, (r)->rq_xprt->xpt_remotelen) \ - __field(unsigned int, netns_ino) \ - __field(u32, xid) - -#define SVC_RQST_ENDPOINT_ASSIGNMENTS(r) \ - do { \ - struct svc_xprt *xprt =3D (r)->rq_xprt; \ - __assign_sockaddr(server, &xprt->xpt_local, \ - xprt->xpt_locallen); \ - __assign_sockaddr(client, &xprt->xpt_remote, \ - xprt->xpt_remotelen); \ - __entry->netns_ino =3D xprt->xpt_net->ns.inum; \ - __entry->xid =3D be32_to_cpu((r)->rq_xid); \ - } while (0) - -#define SVC_RQST_ENDPOINT_FORMAT \ - "xid=3D0x%08x server=3D%pISpc client=3D%pISpc" - -#define SVC_RQST_ENDPOINT_VARARGS \ - __entry->xid, __get_sockaddr(server), __get_sockaddr(client) - TRACE_EVENT_CONDITION(svc_authenticate, TP_PROTO( const struct svc_rqst *rqst, diff --git a/include/trace/misc/sunrpc.h b/include/trace/misc/sunrpc.h index 588557d07ea820116219cf8ac7b049976a7d89b1..c3c8feede26087bad9b4c8dd001= 9606ee9982259 100644 --- a/include/trace/misc/sunrpc.h +++ b/include/trace/misc/sunrpc.h @@ -15,4 +15,27 @@ #define SUNRPC_TRACE_TASK_SPECIFIER \ "task:" SUNRPC_TRACE_PID_SPECIFIER "@" SUNRPC_TRACE_CLID_SPECIFIER =20 +#define SVC_RQST_ENDPOINT_FIELDS(r) \ + __sockaddr(server, (r)->rq_xprt->xpt_locallen) \ + __sockaddr(client, (r)->rq_xprt->xpt_remotelen) \ + __field(unsigned int, netns_ino) \ + __field(u32, xid) + +#define SVC_RQST_ENDPOINT_ASSIGNMENTS(r) \ + do { \ + struct svc_xprt *xprt =3D (r)->rq_xprt; \ + __assign_sockaddr(server, &xprt->xpt_local, \ + xprt->xpt_locallen); \ + __assign_sockaddr(client, &xprt->xpt_remote, \ + xprt->xpt_remotelen); \ + __entry->netns_ino =3D xprt->xpt_net->ns.inum; \ + __entry->xid =3D be32_to_cpu((r)->rq_xid); \ + } while (0) + +#define SVC_RQST_ENDPOINT_FORMAT \ + "xid=3D0x%08x server=3D%pISpc client=3D%pISpc" + +#define SVC_RQST_ENDPOINT_VARARGS \ + __entry->xid, __get_sockaddr(server), __get_sockaddr(client) + #endif /* _TRACE_SUNRPC_BASE_H */ --=20 2.49.0 From nobody Wed Feb 11 23:32:21 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD3A72798E3; Sat, 3 May 2025 15:11:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285107; cv=none; b=W9c1midAAt90ShnI3Cg4I5GUyIv/yFJCmTf6xJ+cUR3VMVathwhd2B6DHLFk8otviX+tQjdKjhvHZxoLEtlkb++gD7XmYxUZiWmi1ohEZWeT2+K/B7UVHFEZi4xmVo7c2Vs/JQ73oVDTj6mAyh2MjmNIF4DNiYEAu5GGVUQQP1A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285107; c=relaxed/simple; bh=nWujkl8G3L8Ckh/Pl5UjtwHrwNM2VvWfPcxzyr8cBPg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YqyLkU1h1Aw3ssSDZBWtLamlCetoOkhqdvws48+UCNMUnNWogE7uKPPzH/oiI7sY31Zxvp8Io4lqDNtG986Z0yWeGJloz1RX/f6fvnLekgukpdqQdVtRzfx1JMop2Vyghe6+hiuqOS996XapyvA7n2IOCYbU5GDBPbMGq5FaX3I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ENy5x4h8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ENy5x4h8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DFA83C4CEF0; Sat, 3 May 2025 15:11:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746285106; bh=nWujkl8G3L8Ckh/Pl5UjtwHrwNM2VvWfPcxzyr8cBPg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=ENy5x4h8aMs8AWgYEWo4iEEQBHZL76wgNRFXeqKS42oBfOwVrwAFh0gRVnpvAVRmc tVD0tggJ8vBcBNr1Qu5SxvonGTTa5hECVQ75cDDCQodaSaE7Wc0ESiBvsr2JPwBNF1 lLg63Inv/g4VCfQbcnS+5qV8RZo1EykJXBCxQQ4jmV32FJS9yvffCQKCiA1ynK4Wdr OB0M5yFzeF9TWpj97Wp7INSOiLUeP+LgVE/3DCjZUaSxYQgPukgzJqyB0lpkS4SYGU Syc6LqHOEZnI8KRf6/2q3dSmtAnqnk0Oz9Flf0gpMi6S9do6D4Z68tkIQySj/h0fqS AMOli7m0QBaCg== From: Jeff Layton Date: Sat, 03 May 2025 11:11:18 -0400 Subject: [PATCH v3 02/17] nfsd: add a tracepoint for nfsd_setattr Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250503-nfsd-tracepoints-v3-2-d89f445969af@kernel.org> References: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> In-Reply-To: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> To: Chuck Lever , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , NeilBrown Cc: Sargun Dillon , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3984; i=jlayton@kernel.org; h=from:subject:message-id; bh=nWujkl8G3L8Ckh/Pl5UjtwHrwNM2VvWfPcxzyr8cBPg=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBoFjIssOmVnXmohHKhxQiNYOuGLHBcbjPQmIenM Hzc0RoPkCqJAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaBYyLAAKCRAADmhBGVaC FTn/D/9y41R3Z2zsf9QlMCz7qawM0an0n4zdUFUDmfg3SXicPTx45DViV4J+p08HCG6dPqs/Jf5 ITLV7m/bWKanWIzk6hD+P83t1j/BwvFq8528TLudTGdRzlqzx3IpyrJEX8xPm1QdMxjUFbMg5KD D3+LNmz+b4WLuOgMw2GZp1ngdjY9kqms44fCcSnrStIx6Ivr8LLJV6sat//H4zxvjb81g1lVXQ/ iw+JYhaVsxfbd9rrKozJVP2tVUcb5qXv30PeNlpnsHPeNPG0ka0jW6bx4xrACpowvd+l/hEvbqa IAOZ8hYpxfcgqsaRLYpkAiWzIz2/YKhDXokD2GfELCBqoedMTIiA83YhX6xG+2cexoPUEg7pYQW LLFLch6+3PxQf/77TIuFjEL7kkh3Rzy5P8MfDMxhDkVA9kC/GA9qPJI0Bdw8hfCJuhT/bcyyX4B cjDoNg6NPK+9R6R0hqqXBYhhyzPiGIpLQgLXeHRhXZjx49Vz5k7O9j1Tq4a8kRtYv80nVxudJtA fFJisbjmx7OGyZnOWAW1G6KS0a1u3KWVNvaWLJ9rapJYMcOmcCWzEmon1mfSOoBuPM9L/mtROZm TSENfVoPfCzbTbGYRxS3adorFd1+qwWaaFDDBFG62Lc093IBQR+EXKjHJVdDuGcD3cW7fET+/aa mRMELCsY10Row1A== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 Turn Sargun's internal kprobe based implementation of this into a normal static tracepoint. Also, remove the dprintk's that got added recently with the fix for zero-length ACLs. Cc: Sargun Dillon Signed-off-by: Jeff Layton --- fs/nfsd/trace.h | 35 +++++++++++++++++++++++++++++++++++ fs/nfsd/vfs.c | 2 ++ include/trace/misc/fs.h | 21 +++++++++++++++++++++ 3 files changed, 58 insertions(+) diff --git a/fs/nfsd/trace.h b/fs/nfsd/trace.h index 0d49fc064f7273f32c93732a993fd77bc0783f5d..c496fed58e2eed15458f35a158f= bfef39a972c55 100644 --- a/fs/nfsd/trace.h +++ b/fs/nfsd/trace.h @@ -11,6 +11,7 @@ #include #include #include +#include #include #include =20 @@ -2337,6 +2338,40 @@ DEFINE_EVENT(nfsd_copy_async_done_class, \ DEFINE_COPY_ASYNC_DONE_EVENT(done); DEFINE_COPY_ASYNC_DONE_EVENT(cancel); =20 +TRACE_EVENT(nfsd_setattr, + TP_PROTO(const struct svc_rqst *rqstp, const struct svc_fh *fhp, + const struct iattr *iap, const struct timespec64 *guardtime), + TP_ARGS(rqstp, fhp, iap, guardtime), + TP_STRUCT__entry( + SVC_RQST_ENDPOINT_FIELDS(rqstp) + __field(u32, fh_hash) + __field(s64, gtime_tv_sec) + __field(u32, gtime_tv_nsec) + __field(unsigned int, ia_valid) + __field(loff_t, ia_size) + __field(uid_t, ia_uid) + __field(gid_t, ia_gid) + __field(umode_t, ia_mode) + ), + TP_fast_assign(__entry->xid =3D be32_to_cpu(rqstp->rq_xid); + SVC_RQST_ENDPOINT_ASSIGNMENTS(rqstp); + __entry->fh_hash =3D knfsd_fh_hash(&fhp->fh_handle); + __entry->gtime_tv_sec =3D guardtime ? guardtime->tv_sec : 0; + __entry->gtime_tv_nsec =3D guardtime ? guardtime->tv_nsec : 0; + __entry->ia_valid =3D iap->ia_valid; + __entry->ia_size =3D iap->ia_size; + __entry->ia_uid =3D __kuid_val(iap->ia_uid); + __entry->ia_gid =3D __kgid_val(iap->ia_gid); + __entry->ia_mode =3D iap->ia_mode; + ), + TP_printk( + "xid=3D0x%08x fh_hash=3D0x%08x ia_valid=3D%s ia_size=3D%llu ia_mode=3D0%= o ia_uid=3D%u ia_gid=3D%u guard_time=3D%lld.%u", + __entry->xid, __entry->fh_hash, show_ia_valid_flags(__entry->ia_valid), + __entry->ia_size, __entry->ia_mode, __entry->ia_uid, __entry->ia_gid, + __entry->gtime_tv_sec, __entry->gtime_tv_nsec + ) +) + #endif /* _NFSD_TRACE_H */ =20 #undef TRACE_INCLUDE_PATH diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index a61ad0da5976f2653c715e635f090aa5fd0c641f..55476fe6d9adbd338d96a9dd8f7= 32638cd072a44 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c @@ -502,6 +502,8 @@ nfsd_setattr(struct svc_rqst *rqstp, struct svc_fh *fhp, int retries; =20 dprintk("nfsd_setattr pacl=3D%p valid=3D0x%x\n", attr->na_pacl, iap->ia_va= lid); + trace_nfsd_setattr(rqstp, fhp, iap, guardtime); + if (iap->ia_valid & ATTR_SIZE) { accmode |=3D NFSD_MAY_WRITE|NFSD_MAY_OWNER_OVERRIDE; ftype =3D S_IFREG; diff --git a/include/trace/misc/fs.h b/include/trace/misc/fs.h index 738b97f22f3651f2370830037a8f4bfdf9a42ad4..0406ebe2a80a499dfcadb7e63db= 4d9e4a84d4d64 100644 --- a/include/trace/misc/fs.h +++ b/include/trace/misc/fs.h @@ -120,3 +120,24 @@ { LOOKUP_BENEATH, "BENEATH" }, \ { LOOKUP_IN_ROOT, "IN_ROOT" }, \ { LOOKUP_CACHED, "CACHED" }) + +#define show_ia_valid_flags(flags) \ + __print_flags(flags, "|", \ + { ATTR_MODE, "MODE" }, \ + { ATTR_UID, "UID" }, \ + { ATTR_GID, "GID" }, \ + { ATTR_SIZE, "SIZE" }, \ + { ATTR_ATIME, "ATIME" }, \ + { ATTR_MTIME, "MTIME" }, \ + { ATTR_CTIME, "CTIME" }, \ + { ATTR_ATIME_SET, "ATIME_SET" }, \ + { ATTR_MTIME_SET, "MTIME_SET" }, \ + { ATTR_FORCE, "FORCE" }, \ + { ATTR_KILL_SUID, "KILL_SUID" }, \ + { ATTR_KILL_SGID, "KILL_SGID" }, \ + { ATTR_FILE, "FILE" }, \ + { ATTR_KILL_PRIV, "KILL_PRIV" }, \ + { ATTR_OPEN, "OPEN" }, \ + { ATTR_TIMES_SET, "TIMES_SET" }, \ + { ATTR_TOUCH, "TOUCH"}, \ + { ATTR_DELEG, "DELEG"}) --=20 2.49.0 From nobody Wed Feb 11 23:32:21 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E880B27A45F; Sat, 3 May 2025 15:11:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285108; cv=none; b=CoLXMs17C9rickPG0JF0ofosU/nXKkmk/gfV5iUJyTZlLfHP14n2QbG6ayg3f9bWKFPaQ9da6Gr9vUWze5eacNkhe4mo1o2QHboTYSJuLW9W+OUw7oCBdduDIOoB7eP9D84UJCRii/ghh20F3a7MWtNaCl5YbHb9tIqtMIHfoQo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285108; c=relaxed/simple; bh=xI3WTpyUPVUnn1x5XonAZorokqime/TlzydhgGCwrWI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SOwhQXuDd0+nQg1FyzBe77H7lnYjfJtOc1zwysnV/9rBH303sU3jAoXiZbw849liObJqI1GarKa6TyLJknHveoof09j1uEfLXZXm2VDwVB+4p9VVPrN1VnpYnNvi+itrZzqmY8ToaoD/ypK9Yv/HpCwq6l2j4EPgkRWbMA4S78w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mm9rAKmO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mm9rAKmO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF23DC4CEEB; Sat, 3 May 2025 15:11:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746285107; bh=xI3WTpyUPVUnn1x5XonAZorokqime/TlzydhgGCwrWI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=mm9rAKmOsTXp3eO/L+4FpkZcsBi9BUVl3qUJGmwVMrMBLqLQ4KwFyxEvdEcjU2hHm IrtyHmOrC9RWiMpLsyZ9JrJkysPNJoAPxyQ3S/pxnbqV34dRMl6CcLqHBIty62y383 ospPZJmy3kay1c5J7LNltreZoFPnBdm4zv/KToNjzZpOx+rQ78aVpojKDIKAPcUX+E FI8nPHp6Hclv202N/ijHlZfjoP7lnyQFC6UQgRcsuK37pymgJt+AfVhZ9EC2aUrkez 3eDx8zrplArbkMOM5KF5iHznDOQ19m0aejKpR6uENTEgrgn3BrTMaIIx0t16WJpIai YhKIQxA95XO1g== From: Jeff Layton Date: Sat, 03 May 2025 11:11:19 -0400 Subject: [PATCH v3 03/17] nfsd: add a tracepoint to nfsd_lookup_dentry Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250503-nfsd-tracepoints-v3-3-d89f445969af@kernel.org> References: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> In-Reply-To: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> To: Chuck Lever , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , NeilBrown Cc: Sargun Dillon , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1596; i=jlayton@kernel.org; h=from:subject:message-id; bh=xI3WTpyUPVUnn1x5XonAZorokqime/TlzydhgGCwrWI=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBoFjIseKdUdzZF6CkgmbrxIGGRykTl0eQsBCOdC RgjuC27Ma2JAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaBYyLAAKCRAADmhBGVaC FWTUD/9ASzvRqYzRZ7gzcdfNHCUIy4Yd7gJw22QCldun4WXzIPBxELE9cm5JN6v838f0+BoDFnf o7xqJR9yKXBKUouKNTXp4PaGQwmu+W/e/RfYYq1iFqlQEQo0v/+XElAwBGahclhGbnGhYVv7qYV 9l2pjcRLbRglQiUgC5HJZroRUZ0zhvbVE/s3eznXaoUBbGG1k4hnb5vZPjeKbEzSh9mlGcB2jjd ZBq0u0hDlHSNUr+eaSMEFoAs5Wd616hM/slOfbIoLYGHO/jPws4QMTWlwZ5rlP9tmvHPAb9b6ys ijqWyosAsbJQPIhgnl0FEBJmCS5IoUmSRp6W4VsRbz+ISCbV7Ck9eLpAO61fFJ+eQb2Vv77KeeG sSUEFLwWP4eBDf1nF4iray+tXcQzo+/9ZJMNvVUchSOS3p22TgOBF1XOp+g3/e4E/1rLQvXE+Vq rfCG0KAz2BwS055n5oE+DtZzReGqxNn0jsSTDpH0UZ1BDgZy5Ii1LNG/KkIcqDs1EUCQRZrJAvq zWCzdniJXQzNOIoj4gEATEcSZbjivxku7ArRTqTzorjbdxyrjQ67T5GvrLzg4YYiAwXqp1ZJbnq MGrtUpWassDGZm3yTjDRnUkoDt8qptoZnbwK+wo0s6boQIJ/ja0wLkP4ozYqXg0zqfg9O++Pzl6 ey3rpmPpEg4xBFg== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 ...and drop the dprintk. Signed-off-by: Jeff Layton --- fs/nfsd/trace.h | 19 +++++++++++++++++++ fs/nfsd/vfs.c | 2 +- 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/fs/nfsd/trace.h b/fs/nfsd/trace.h index c496fed58e2eed15458f35a158fbfef39a972c55..382849d7c321d6ded8213890c2e= 7075770aa716c 100644 --- a/fs/nfsd/trace.h +++ b/fs/nfsd/trace.h @@ -2372,6 +2372,25 @@ TRACE_EVENT(nfsd_setattr, ) ) =20 +TRACE_EVENT(nfsd_lookup_dentry, + TP_PROTO(struct svc_rqst *rqstp, + struct svc_fh *fhp, + const char *name, + unsigned int len), + TP_ARGS(rqstp, fhp, name, len), + TP_STRUCT__entry( + SVC_RQST_ENDPOINT_FIELDS(rqstp) + __field(u32, fh_hash) + __string_len(name, name, len) + ), + TP_fast_assign( + SVC_RQST_ENDPOINT_ASSIGNMENTS(rqstp); + __entry->fh_hash =3D knfsd_fh_hash(&fhp->fh_handle); + __assign_str(name); + ), + TP_printk("xid=3D0x%08x fh_hash=3D0x%08x name=3D%s", + __entry->xid, __entry->fh_hash, __get_str(name)) +); #endif /* _NFSD_TRACE_H */ =20 #undef TRACE_INCLUDE_PATH diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index 55476fe6d9adbd338d96a9dd8f732638cd072a44..276fbb572ead90fd07cde6922a6= 97e07148926de 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c @@ -246,7 +246,7 @@ nfsd_lookup_dentry(struct svc_rqst *rqstp, struct svc_f= h *fhp, struct dentry *dentry; int host_err; =20 - dprintk("nfsd: nfsd_lookup(fh %s, %.*s)\n", SVCFH_fmt(fhp), len,name); + trace_nfsd_lookup_dentry(rqstp, fhp, name, len); =20 dparent =3D fhp->fh_dentry; exp =3D exp_get(fhp->fh_export); --=20 2.49.0 From nobody Wed Feb 11 23:32:21 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7893227A933; Sat, 3 May 2025 15:11:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285109; cv=none; b=SJQ+norQCIkQnQl/80nVxG4vRCDjMjIKhd8N+EzZ0XoklMVIBOQoTDIuWRPwt0anBIMTTj4sndVqoHwGOQg45AkaGXFDjwbcFDQbTh0jnuMvpRPqiBUk4NFT6goTavUFCYhafvgxN+vwHx+iBfwKUWeVFRgtMQtMWkUTdhmON9g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285109; c=relaxed/simple; bh=uxFrc19C+PvwWMPxhNCI24ZWWHy6CbxGQF0jn16lEKI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oV2L5I7iu1EuJFkBYQR1Y43ztg/jbrjJBGBOc4jgw7TfdW9E+IKhDvimkRRB8a3paQgzmYza5D/GEd9OxEe6fCg3peVvJK4odJpYHJcg0PmhuE8Aq8GUrkssXd4js7+p+/KyArP9XbvhSlHMmqYi4gzxHGDbyHaranBF2EFC3YA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YmiMk4wL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YmiMk4wL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0AECEC4CEE9; Sat, 3 May 2025 15:11:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746285108; bh=uxFrc19C+PvwWMPxhNCI24ZWWHy6CbxGQF0jn16lEKI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=YmiMk4wLswV9JdAt40mwNSVSxqPO4xU+tiBGF90Xv96g+Il+Rk8it3EmxMgBcCh44 GkaddRYrr9RuaIWNXok4BrR8qc8yULBEyz1LNdSTfbs+08GBc0JxnRnlixQsO0Z5Zo 6kOxJGZ39Jq76sJTJEkVUJTkSQJtU2DLeASFUl86F46dHoPE5PcHOipyH+h9F6w746 jyM61twE3TQVdy84wqzpQRw9zbwt6EZYergjVfo2c1/212gO1HZDoINkDh8aSr4nE1 D9fubRf1r8a57R1yaazdvSY6N+z2AquJXGGpoqFq2Gk6OkbT2OoSPFxKn9P9+DjFad qp5z8TSYvwljQ== From: Jeff Layton Date: Sat, 03 May 2025 11:11:20 -0400 Subject: [PATCH v3 04/17] nfsd: add nfsd_vfs_create tracepoints Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250503-nfsd-tracepoints-v3-4-d89f445969af@kernel.org> References: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> In-Reply-To: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> To: Chuck Lever , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , NeilBrown Cc: Sargun Dillon , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2387; i=jlayton@kernel.org; h=from:subject:message-id; bh=uxFrc19C+PvwWMPxhNCI24ZWWHy6CbxGQF0jn16lEKI=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBoFjIs9SUr4mN37fEith1m3H949MBnrXkKIjl+x ygqvWrehvaJAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaBYyLAAKCRAADmhBGVaC FTAWD/9gc38q3nHVO/tITHdd1oJFANjTSsyIxdLW3YpU4XgOpc3lIqhlJ1PnzwD6pFrX6bKPpLQ 4HlE750VqByfIG+pWmtUfyBar0Wbi8YpGJPSVjrOWDzlDP4s84qwkfUfeT8jbZ+UYgipTfk3gwK OJ9xKKLqzy0vX0JJffMjMQXMYx+Y0uWf/gXl6R7OzolCeBX3QEWi5ljfF5qYGet1x5KxoKC/tl0 Q+jht9iAC7o2+OJA0JTayx7le4G2JIUpnsJf+x+3RqBmYqnGr26t3QAmZPuAY192zBeA6ALy4yo jw8AeteeZZEUwF01vAwA5r9qrnPAkWbAFQ2qujgn5vTtnohXgQHNnhFsGgU7gPK02H8GY4jwWbx d/7Zucrhg9Ub0FhTcVAcPlKylweLk4/7z+F6xqniq0s5bnyFxdslZmv6ru8pDyTw0sgfP4tCXEJ TgCurRdN5Y1CnQ3Z2DDBOZpsGMo8JFHrLtV0kL5XXNGTr3FPrMmpHjT2cq2A6USC4xsEZ9zPQOR VILjSy4Qaap1cPwYkrxypCRAh74DzJ+F99D5rrKGJ+IbWNArxWd694EFP6vH//d3qt67S3Vy1lQ RiYpL/5IwPT1awWOfzXtGtCL6BVUvVmNAsy9qaLlBjQNFnPMqH9sAgUNARrfQCM29yZSR2w5OiH KclC+hkPbWGmHZw== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 Signed-off-by: Jeff Layton --- fs/nfsd/nfs3proc.c | 3 +++ fs/nfsd/trace.h | 25 +++++++++++++++++++++++++ fs/nfsd/vfs.c | 2 ++ 3 files changed, 30 insertions(+) diff --git a/fs/nfsd/nfs3proc.c b/fs/nfsd/nfs3proc.c index 372bdcf5e07a5c835da240ecebb02e3576eb2ca6..5d2b081072e8c2e286c6815c34e= 5e58d4be15067 100644 --- a/fs/nfsd/nfs3proc.c +++ b/fs/nfsd/nfs3proc.c @@ -14,6 +14,7 @@ #include "xdr3.h" #include "vfs.h" #include "filecache.h" +#include "trace.h" =20 #define NFSDDBG_FACILITY NFSDDBG_PROC =20 @@ -266,6 +267,8 @@ nfsd3_create_file(struct svc_rqst *rqstp, struct svc_fh= *fhp, __be32 status; int host_err; =20 + trace_nfsd_vfs_create(rqstp, fhp, S_IFREG, argp->name, argp->len); + if (isdotent(argp->name, argp->len)) return nfserr_exist; if (!(iap->ia_valid & ATTR_MODE)) diff --git a/fs/nfsd/trace.h b/fs/nfsd/trace.h index 382849d7c321d6ded8213890c2e7075770aa716c..752d81629e04f805536295f00a1= 6721f57272fbe 100644 --- a/fs/nfsd/trace.h +++ b/fs/nfsd/trace.h @@ -2391,6 +2391,31 @@ TRACE_EVENT(nfsd_lookup_dentry, TP_printk("xid=3D0x%08x fh_hash=3D0x%08x name=3D%s", __entry->xid, __entry->fh_hash, __get_str(name)) ); + +TRACE_EVENT(nfsd_vfs_create, + TP_PROTO(struct svc_rqst *rqstp, + struct svc_fh *fhp, + umode_t type, + const char *name, + unsigned int len), + TP_ARGS(rqstp, fhp, type, name, len), + TP_STRUCT__entry( + SVC_RQST_ENDPOINT_FIELDS(rqstp) + __field(u32, fh_hash) + __field(umode_t, type) + __string_len(name, name, len) + ), + TP_fast_assign( + SVC_RQST_ENDPOINT_ASSIGNMENTS(rqstp); + __entry->fh_hash =3D knfsd_fh_hash(&fhp->fh_handle); + __entry->type =3D type; + __assign_str(name); + ), + TP_printk("xid=3D0x%08x fh_hash=3D0x%08x type=3D%s name=3D%s", + __entry->xid, __entry->fh_hash, + show_fs_file_type(__entry->type), __get_str(name)) +); + #endif /* _NFSD_TRACE_H */ =20 #undef TRACE_INCLUDE_PATH diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index 276fbb572ead90fd07cde6922a697e07148926de..888572727d332dafd3e520f4801= c4b0ca4e5c96c 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c @@ -1574,6 +1574,8 @@ nfsd_create(struct svc_rqst *rqstp, struct svc_fh *fh= p, __be32 err; int host_err; =20 + trace_nfsd_vfs_create(rqstp, fhp, type, fname, flen); + if (isdotent(fname, flen)) return nfserr_exist; =20 --=20 2.49.0 From nobody Wed Feb 11 23:32:21 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A12E927B501; Sat, 3 May 2025 15:11:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285110; cv=none; b=PWPm2yHkt1RGhP7kS3PGVJi/b9qc5Yg+tSvv/cjsxJxnKU3aWnLc1fM+q1rO35XxSxHyz27q8zxIaYFjPX8PORQ1yhTx+44QuQWRaLm8Svc7vRlygX/UE47+S7pg8du/oY1bqAMVpB66WXytpiZN/wfRRmyeYJfawzts/QC/CnE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285110; c=relaxed/simple; bh=Lbbt3z52A02Fxr9pcVeoYi/CCQmH+05FB4t+Qi7+fsQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PyTYDF5PUOzOkw6B4B/y03e+zOg38sNhGggg2hcDgGHjblRr7Cx5fKuoh2bgSgq5sKtGj1iGxDh98wxmM1fv5OcmQGfM1th62FUPXQgJeEA8KxEwHLF0jl30ITP4YnVek8jBmKXrz46lpb8ciFmbrIpblxEGUIE5F6LoHKKmxe4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Sq6ZCecb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Sq6ZCecb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1AF32C4CEEB; Sat, 3 May 2025 15:11:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746285109; bh=Lbbt3z52A02Fxr9pcVeoYi/CCQmH+05FB4t+Qi7+fsQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Sq6ZCecbY4OFCqOQSb6AakAGj95LWb2w937Uj8zZgeGSR0t/KtifZfB06zlEV7R2z qnA/X30ruxIKP1cHUOuPP4btyJhC1G2IQVInOQTLwh/VeGkFAic7/EwOiWsja6qsLB hAnhn9GPloKNhfoYmnyFI6Q0uryvUMOR932zgpaoP8Ikzaov1BpKxEaNVAB+enUJRw UXjgLowN7yhwel7PJ7Bw9inn6ByStZ+KEweTWUp243Mvc9BHpB2BptMhkgTPNOiYBm wlSq5HAoAlTv79XRqbFGYaC/zA/Mmk0+dvRvZgt+If972BTNgEU/WVMrsecUXnmaMB cAQC0bbgaepmw== From: Jeff Layton Date: Sat, 03 May 2025 11:11:21 -0400 Subject: [PATCH v3 05/17] nfsd: add tracepoint to nfsd_symlink Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250503-nfsd-tracepoints-v3-5-d89f445969af@kernel.org> References: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> In-Reply-To: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> To: Chuck Lever , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , NeilBrown Cc: Sargun Dillon , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1657; i=jlayton@kernel.org; h=from:subject:message-id; bh=Lbbt3z52A02Fxr9pcVeoYi/CCQmH+05FB4t+Qi7+fsQ=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBoFjItpO+fW7eNAkaUsHuP3FI9m6ZwDKL/AFyoL EwzyXNvM2eJAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaBYyLQAKCRAADmhBGVaC Ff+cEACmPw89L1i64cPzslAwz55+t2BitpjPc/qUDQy0EuSquoCVvA8zOi51ZnC/5E73WUveNar v6GRy14kJwoNHHYaA/sflJsDRHjCiir/0S26pbr1BbCBuinaBggZTd2Q72DHSMLY9zSa6igo7F3 wCkJdCWRuCKVm7rFd5KjYwbULb9v96mhBpx2ccLBl6SprWpUyu7SfQ+glCJW4/+Q+4QMFkmBuyZ EPfRW0sw38WFh8SI6a3ErmL1uScqv16jm2v5Uj/0tfAsBSD9W52rbwKB0c0cXbN5c5n75dxe1mO oi/bi+RQ9vKsefMn5Rysz0enWbqQ6ic2RgC55uVYl6oA+GnfAoIaQqf688km4jGixuFW5GH7SRD m0rSKE9p+2SamBxZ3rnN9/RC2xxjxx+qMrWB/3XLrbKeOmSzRNqvg2LUJVxvEmMcuf5dQjVPz8K 6BsqewfuV74vAsa1UzblNIDpgiRcGGM1fLF5FpetMc3bgR9VnDeMnBOMfYd8XYgBZqzzeI1igh1 4XQHiQWWvTxYb37ZJpwihDwo7niEZ9GV2ujRHmuaXhC5kKrGCJH5RtnAn/t3FBbWEypKR1DnCa9 z3YoBVIOJbQrADoGacUVmYfB5b+pr7e07j5dcQKkwV68q9dFRNzpLn1hWBWxi+QYoxVxBWfClAg DLErlA5tUO2gVGQ== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 Signed-off-by: Jeff Layton --- fs/nfsd/trace.h | 23 +++++++++++++++++++++++ fs/nfsd/vfs.c | 2 ++ 2 files changed, 25 insertions(+) diff --git a/fs/nfsd/trace.h b/fs/nfsd/trace.h index 752d81629e04f805536295f00a16721f57272fbe..9f604eb23f6304d11223733cee3= 8871a4c39001f 100644 --- a/fs/nfsd/trace.h +++ b/fs/nfsd/trace.h @@ -2416,6 +2416,29 @@ TRACE_EVENT(nfsd_vfs_create, show_fs_file_type(__entry->type), __get_str(name)) ); =20 +TRACE_EVENT(nfsd_vfs_symlink, + TP_PROTO(struct svc_rqst *rqstp, + struct svc_fh *fhp, + const char *name, + unsigned int namelen, + const char *tgt), + TP_ARGS(rqstp, fhp, name, namelen, tgt), + TP_STRUCT__entry( + SVC_RQST_ENDPOINT_FIELDS(rqstp) + __field(u32, fh_hash) + __string_len(name, name, namelen) + __string(tgt, tgt) + ), + TP_fast_assign( + SVC_RQST_ENDPOINT_ASSIGNMENTS(rqstp); + __entry->fh_hash =3D knfsd_fh_hash(&fhp->fh_handle); + __assign_str(name); + __assign_str(tgt); + ), + TP_printk("xid=3D0x%08x fh_hash=3D0x%08x name=3D%s target=3D%s", + __entry->xid, __entry->fh_hash, + __get_str(name), __get_str(tgt)) +); #endif /* _NFSD_TRACE_H */ =20 #undef TRACE_INCLUDE_PATH diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index 888572727d332dafd3e520f4801c4b0ca4e5c96c..44e9260410b2d9dc7e07b5af7a7= 4b63bd0175998 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c @@ -1676,6 +1676,8 @@ nfsd_symlink(struct svc_rqst *rqstp, struct svc_fh *f= hp, __be32 err, cerr; int host_err; =20 + trace_nfsd_vfs_symlink(rqstp, fhp, fname, flen, path); + err =3D nfserr_noent; if (!flen || path[0] =3D=3D '\0') goto out; --=20 2.49.0 From nobody Wed Feb 11 23:32:21 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 985D927B518; Sat, 3 May 2025 15:11:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285111; cv=none; b=VBPCLSKNUNOQ25Q/VKr9e3KNXhVtpyVWbWyEb29SMoJUuVWWUpVk6f4A30AKVNdMoW4vnrRBrWimQUSIvPjxhTtKkVX5G4s+j2PTd0YoG4aTP/uiVgq/b3o0Lx3F5sn0MxIUsbam+aYLjHeK+nd/blLFvTZPRclSKH923l2VwY0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285111; c=relaxed/simple; bh=A/Z+V7YuEZM2hHJlWez6oCBvrLrVohVfh5nLP7nLD2E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tcc4cRGXP2zW+FKBUCC78FZFgYN59vO823efgnCPZwK1jxj77wTSHTVU83PSQutbZzPOiR7Su6sRIjXEdXRjTHHbMMm0k+xDqZp/StyAdZZcHnBw8W5eO1VnegHvoxCDI0af8liH4WgFtCxZGcPc/BZyZGTNJFgqYIutQIki7TQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Rf1sQn6l; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Rf1sQn6l" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F4F9C4AF0C; Sat, 3 May 2025 15:11:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746285111; bh=A/Z+V7YuEZM2hHJlWez6oCBvrLrVohVfh5nLP7nLD2E=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Rf1sQn6lIo0oycsx7fh0DqSY+32+BhoFO2YHK+dkuHVdGmdEr22ZJ0tHwo7sn09Un kaB9O4KKW1D2Jf8GwcpNEMV1Uc5ewOesunCJcasPlRfOu/5rCVRP3Fu/aDrkUgoaRL i9kKiiEtUA/R3y031EVDsuQGq7XtorOmi8b4gKtpVye9I/WUr0PCPrlqGPDsGqtAtu hk7PAAEWEK9vxmj2wzWj5HoBOX+Vzlf4xi8R1dOAMucu5ernMfiFByLDvaFUXL171G T1cPB010KxFMr9JFV1o1sVTwf4VWZs3l4OU2FfxB3bta1Iu4TdnHnzDtm8oPB3w8G8 nHeoImRijNnaA== From: Jeff Layton Date: Sat, 03 May 2025 11:11:22 -0400 Subject: [PATCH v3 06/17] nfsd: add tracepoint to nfsd_link() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250503-nfsd-tracepoints-v3-6-d89f445969af@kernel.org> References: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> In-Reply-To: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> To: Chuck Lever , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , NeilBrown Cc: Sargun Dillon , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1734; i=jlayton@kernel.org; h=from:subject:message-id; bh=A/Z+V7YuEZM2hHJlWez6oCBvrLrVohVfh5nLP7nLD2E=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBoFjIt8Av+xa/bqYbWwsovu+UEFx12uHBt6FDZn 3qaSnJ8DmqJAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaBYyLQAKCRAADmhBGVaC FdlBD/4psFrxlmX2wFDPwQCCfsmiyEDoQ9sWdjM24QYaIes7xH6zoKEsj7itD2d8iw3nBP/KLT/ 3RGrzeCUEfL8+HOAINZDvmUh0glpeQw43Wu/0Yoi51xELJa9K1Tdk//X8qKEXcPbbFKIEEPVkRy jBNpWKzgk5GAqfI82dJFNvUKaj8VAP+B9kFugubHNdxeJQ3KEPgFvGwtaiOzan5IYsJzTl4hKgx XkRkRo+kq7oU8tSdGZh6Rnaq+1+1vlw/C1kg5Gpa6uJ9qAnYVm1/api9zaQKKUXBNQtiv8diypa 1wSM2i2y3BqdBGhVYey8gbVZiL6RvRJYXyCMMO8MpuiyQUOWeNAgA9Uwk4+VvULoNn9tc4y2/zY DceQQhH2ZLPh6UNBO7nSx3S038Wn+W28vUAX69/z+TGq9JdvMXAHmRo/OTrQE4/YZu8hwJ+n9UL akT9EEjg6gFQC8u1oyF1Gbh/gPxXXBaRwQxuw+jV9GWyXqejRliq79cKja8bvy38xIPfC2ELzn/ xLenY+RRF/Poyt30xf5emU8LqT7PP+FclAremA7E50vVkAnRk/qCH3CkgOgOQRLrOUhL3P5vQsL z8XaJjmdqRmqsTq5lKPZtg2UvP/+mANkCsoqLTTqzDtNB782fW78ssj/WJevLdV7twNy+4zLSQr pkSZW2Q4xfEHbVQ== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 Signed-off-by: Jeff Layton --- fs/nfsd/trace.h | 24 ++++++++++++++++++++++++ fs/nfsd/vfs.c | 2 ++ 2 files changed, 26 insertions(+) diff --git a/fs/nfsd/trace.h b/fs/nfsd/trace.h index 9f604eb23f6304d11223733cee38871a4c39001f..17c09d8a52041205ff4edd47fbd= 4d31135e97f85 100644 --- a/fs/nfsd/trace.h +++ b/fs/nfsd/trace.h @@ -2439,6 +2439,30 @@ TRACE_EVENT(nfsd_vfs_symlink, __entry->xid, __entry->fh_hash, __get_str(name), __get_str(tgt)) ); + +TRACE_EVENT(nfsd_vfs_link, + TP_PROTO(struct svc_rqst *rqstp, + struct svc_fh *sfhp, + struct svc_fh *tfhp, + const char *name, + unsigned int namelen), + TP_ARGS(rqstp, sfhp, tfhp, name, namelen), + TP_STRUCT__entry( + SVC_RQST_ENDPOINT_FIELDS(rqstp) + __field(u32, sfh_hash) + __field(u32, tfh_hash) + __string_len(name, name, namelen) + ), + TP_fast_assign( + SVC_RQST_ENDPOINT_ASSIGNMENTS(rqstp); + __entry->sfh_hash =3D knfsd_fh_hash(&sfhp->fh_handle); + __entry->tfh_hash =3D knfsd_fh_hash(&tfhp->fh_handle); + __assign_str(name); + ), + TP_printk("xid=3D0x%08x src_fh=3D0x%08x tgt_fh=3D0x%08x name=3D%s", + __entry->xid, __entry->sfh_hash, __entry->tfh_hash, + __get_str(name)) +); #endif /* _NFSD_TRACE_H */ =20 #undef TRACE_INCLUDE_PATH diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index 44e9260410b2d9dc7e07b5af7a74b63bd0175998..d949860d2aac998efb1b74218d0= 657a73a0d3fc6 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c @@ -1746,6 +1746,8 @@ nfsd_link(struct svc_rqst *rqstp, struct svc_fh *ffhp, __be32 err; int host_err; =20 + trace_nfsd_vfs_link(rqstp, ffhp, tfhp, name, len); + err =3D fh_verify(rqstp, ffhp, S_IFDIR, NFSD_MAY_CREATE); if (err) goto out; --=20 2.49.0 From nobody Wed Feb 11 23:32:21 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D3DB27BF7E; Sat, 3 May 2025 15:11:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285112; cv=none; b=mDONobpxQK8s2BXDwCHW7Zj5QHHBgUeQA72ZZ43YlB8HgDIlP63EkQhdQR8P2gSE0mJtwG1rDBeaxoM/70vV7bP6C8tSeD1SCA6Ez5YBfOyj17w1Daduj6SVblvUcLkPJm+kuSWJ4nVuA31sBgBTCl84UD4thg/ozvQYNOtS5kE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285112; c=relaxed/simple; bh=qDWqByR0drsyEO3uTrcoD6BDg3chsL7q6TLudUz9IEk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DeEzpzytoXhWgt5g28/+tKFPoNANnLBLvukxTiBcfQXgcnEmUqZ9+GyhJ/2YFZOikkX81W0Rnsxwo3CfmciIPLUR47fbA4X11Uuk6GFUegMLh9TiGY/c3dUNH16iZiu3pRylPVg5TBem2kOl91Kzqcs5FpNdsZ53Za8bfAFIYkc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FkzA6YY3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FkzA6YY3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3EDDCC4CEEE; Sat, 3 May 2025 15:11:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746285112; bh=qDWqByR0drsyEO3uTrcoD6BDg3chsL7q6TLudUz9IEk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=FkzA6YY3gN7Lwjf77+7WMkdN5lQ5Kj+bYgFBTYy8lrUZlC4IpazvwI9X6QXby1e5K abE/Ygks/f6j56CgIx+OSWaBnzMGIgcGg2392hlXR0N677f3lkad5Ox3uNa8k4ixdy YrdxcUcMx3A6SIZClc+5XDezMDdBxXkQe8+NBMmeb2naRAb4ClhQ/NvIlqW/17UV7Z 8StFI2smEj4U6ruGuejoKgRKMPo9sEdYsHlhqhBe0Iea7Me2wUdpSzuPJWV2MCbt8S rIg37QC1XCbnb54DRbGDIYOiK88fkyq94D7DNx98iKsbxnyMS5Z/0ZSqZ9TaWnYmqp BlvYgu7FprheA== From: Jeff Layton Date: Sat, 03 May 2025 11:11:23 -0400 Subject: [PATCH v3 07/17] nfsd: add tracepoints for unlink events Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250503-nfsd-tracepoints-v3-7-d89f445969af@kernel.org> References: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> In-Reply-To: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> To: Chuck Lever , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , NeilBrown Cc: Sargun Dillon , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1567; i=jlayton@kernel.org; h=from:subject:message-id; bh=qDWqByR0drsyEO3uTrcoD6BDg3chsL7q6TLudUz9IEk=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBoFjItvy7/AZW0YUPuu8/Eo8bF75gYN+Ixx4OIS AtY6g2mGnaJAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaBYyLQAKCRAADmhBGVaC FbhSD/0TdUHL+r+FuUDyURtRngFed3fgWSZiqnJUmkXU0CFrOGGmL+9BxJprmfxkIpnyaCYkOTd F70mgcw0rsNeRVdysK8pvyHJfRjyRtz2dgeAKgPs2l5SVQ/YfMDDmYXIuE/ueZ8fVOj2Gk9mAnO Qp+h5e3i3AgZAOQXFgXAKWXY3hZz+o0Lw45HXBtNerBc8+N0o6OMV/SDLsS136hBhA2JhbpQgmN nsMVZz96u5M8mcA5H8g14c6GGAwzbylMi01BdOV8u/FyNcOgophZbRYpivOemP/HxbRzg8f3T33 yvFBQbkF0pybbQCl7uiMTlS27bZI+EUce954rU9TCE/o+I0nl+Tc28y8sorOG+jaWVL0imofs/+ Ga6ljzbFgl7lM/0GkfyTayY2zJWBZIvErJh4WwBOuMoLc3/O7Fkhg0Rzv7yVyXNkw97nmhVg/Bm nKpDemhUW9ux5YseMNn38iZBQIIPT7ZDqVlgIDcPkvWQ2ikEE4pPvJ1xHgXfKywf7egUEz9wn0o OmAHOX9fovzfccys8a4wt5A/+rROrSdXjM+LbWVmr5TudzwvMhydzVbUh2JZkvX6CK3FsJt99fM G6ZhD8hMi8ZdecKwTgj8rf5Fm065ygWC3eG9p/bd9JTF0LFBXV/I5hisrrohUDRS6Kbqir0Uln7 oRQuCUN85SX+ryw== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 Signed-off-by: Jeff Layton --- fs/nfsd/trace.h | 21 +++++++++++++++++++++ fs/nfsd/vfs.c | 2 ++ 2 files changed, 23 insertions(+) diff --git a/fs/nfsd/trace.h b/fs/nfsd/trace.h index 17c09d8a52041205ff4edd47fbd4d31135e97f85..24e3c32d9db48bd8bf51eb41dda= 46b889dfa9e8d 100644 --- a/fs/nfsd/trace.h +++ b/fs/nfsd/trace.h @@ -2463,6 +2463,27 @@ TRACE_EVENT(nfsd_vfs_link, __entry->xid, __entry->sfh_hash, __entry->tfh_hash, __get_str(name)) ); + +TRACE_EVENT(nfsd_vfs_unlink, + TP_PROTO(struct svc_rqst *rqstp, + struct svc_fh *fhp, + const char *name, + unsigned int len), + TP_ARGS(rqstp, fhp, name, len), + TP_STRUCT__entry( + SVC_RQST_ENDPOINT_FIELDS(rqstp) + __field(u32, fh_hash) + __string_len(name, name, len) + ), + TP_fast_assign( + SVC_RQST_ENDPOINT_ASSIGNMENTS(rqstp); + __entry->fh_hash =3D knfsd_fh_hash(&fhp->fh_handle); + __assign_str(name); + ), + TP_printk("xid=3D0x%08x fh_hash=3D0x%08x name=3D%s", + __entry->xid, __entry->fh_hash, + __get_str(name)) +); #endif /* _NFSD_TRACE_H */ =20 #undef TRACE_INCLUDE_PATH diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index d949860d2aac998efb1b74218d0657a73a0d3fc6..bd19e5926ef198279e39ac9ef18= 73eab289cb4a0 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c @@ -2023,6 +2023,8 @@ nfsd_unlink(struct svc_rqst *rqstp, struct svc_fh *fh= p, int type, __be32 err; int host_err; =20 + trace_nfsd_vfs_unlink(rqstp, fhp, fname, flen); + err =3D nfserr_acces; if (!flen || isdotent(fname, flen)) goto out; --=20 2.49.0 From nobody Wed Feb 11 23:32:21 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47C7627C156; Sat, 3 May 2025 15:11:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285113; cv=none; b=id78diAUhOJt7hp2WtGLfh474onOEnFRYk1IT1Gd/KK+nmMsR9dPktx1CPf83QXN2qvDDt8Rq3REbUAj3t+8Qe+9VQKruFV1dWJN2xu72YrzP471pJCEitj2B4k/knqJsuF52gYy82+FIwl8+A9mmEcuXg1BtUIRYSssEZSFyaQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285113; c=relaxed/simple; bh=OiUW+mvHETW7R0EmP48dKkSegRZ9RvbZdCGlAp34BEU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=T9IrBBimsjXmBzmWbrZdhwwdP4weZ1UdBQWH3bDJLdg6sKEdWsrtOVU+qn7cUEpjdfKCAAhtsfvCqKPrlRFdUyL6ZZ2a9lFzK2KpZ94I0HLeF9wdw2XpckwHLXqhvpwwUlqCqjZSo5jOq2jjUEHTEAcxQvcGqvwobf7MtaA8f9Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QWXwgEFU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QWXwgEFU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F0F9C4CEE9; Sat, 3 May 2025 15:11:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746285113; bh=OiUW+mvHETW7R0EmP48dKkSegRZ9RvbZdCGlAp34BEU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=QWXwgEFUC5r8egLhXdNuLCaysIU412Kg5kXRmG2UxcidWMC8NSGcdJlPiOhxC982p l+JxB1JDJWqNP9jhgpnWAS/kgwL6/0iUyTuW+Bgnj5xN/DV7yhg1xHR2i0kaIvRZTa VaUMTfROSDlLfWTu3m9dbMfLdRXKf/MqZxFW776jriYo6xLV7kzXd9T5WhViuyToJ8 0MVunsFijVjsdG4SMNqSvbOcU0+BufNBD3zdvKbBt1QMq2I/n86I0PTcXNwWAWiJGy PKncv/3xvlI/UmoH9KqhXqY54D7e7p9EeaXICdR3TXmari5AYaqQaRdEzdvs5oXRQE HYIA2I422OKzQ== From: Jeff Layton Date: Sat, 03 May 2025 11:11:24 -0400 Subject: [PATCH v3 08/17] nfsd: add tracepoint to nfsd_rename Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250503-nfsd-tracepoints-v3-8-d89f445969af@kernel.org> References: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> In-Reply-To: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> To: Chuck Lever , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , NeilBrown Cc: Sargun Dillon , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1929; i=jlayton@kernel.org; h=from:subject:message-id; bh=OiUW+mvHETW7R0EmP48dKkSegRZ9RvbZdCGlAp34BEU=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBoFjItlox3v5dU2m84jXBVHW5L8OWZhiW0mp4qy iqesHpvXV+JAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaBYyLQAKCRAADmhBGVaC FXB6EACeoh+deRVDFYq/qM7rDVKUkYP/lruvNus2ELmqjDfIgoy9ukeWQDzxZb6VEGRgjzuU8Zr Aet6N3yoMO2jd+8Vc7GMpaSTu8one9v3nx8hL+WApMaQDohDms3ScrP8WbKyp/lmFX82X8xJqbh iyQI6bZPWD+R5SKeETOiGx+aTW81GIhZEJuJOxKlC1V3a4Es6HvzqeP1E2VdVJ2mMz6TFxDiKK9 F7NK0MGcRHiWunaWcslzUoJCkwTA8GgHlB0x/CRL9Dk/+R4lx7q31EjPjGsg1W92abRD97UoWO5 MP3iw+tRB2xxw7saQZf4tN+buKUeXu+WoOJs+bIme5EgAZcIzMGABdkvh0J9yIl4JpOlOgYezRE kQxukzthMMvlTunZJHwBEM+FXUahiP+gdaOc2acwnFN2znxqIr0/ILBxZGiFgw1NMTdNq6TCAHu +bKj8Z+c5A/3XhAO8lrxwr/y7uX3SUe67Mjj4/keP8Xjt0vxB0qflfzYiQvyN1vAgEDYAcE5UMh GGPxgOYtsHjbWVtc4Npf96tHAm+4zN1rU+d1ONM5uyblVGXSYUvwoiYasxOvZNaEUsiGirsRzMs plkDKod7tZqk9kEtoU5j/W7Qr+Yf79I6nAnaaLwSLDD6KxW2I5jr9CqvxpsoEn6TMEEuz8T6C91 uXIl9wkfAxEpVOQ== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 Signed-off-by: Jeff Layton --- fs/nfsd/trace.h | 28 ++++++++++++++++++++++++++++ fs/nfsd/vfs.c | 2 ++ 2 files changed, 30 insertions(+) diff --git a/fs/nfsd/trace.h b/fs/nfsd/trace.h index 24e3c32d9db48bd8bf51eb41dda46b889dfa9e8d..4e873ceca602098d2899c5ff2de= ee610ddb670a0 100644 --- a/fs/nfsd/trace.h +++ b/fs/nfsd/trace.h @@ -2484,6 +2484,34 @@ TRACE_EVENT(nfsd_vfs_unlink, __entry->xid, __entry->fh_hash, __get_str(name)) ); + +TRACE_EVENT(nfsd_vfs_rename, + TP_PROTO(struct svc_rqst *rqstp, + struct svc_fh *sfhp, + struct svc_fh *tfhp, + const char *name, + unsigned int namelen, + const char *tgt, + unsigned int tgtlen), + TP_ARGS(rqstp, sfhp, tfhp, name, namelen, tgt, tgtlen), + TP_STRUCT__entry( + SVC_RQST_ENDPOINT_FIELDS(rqstp) + __field(u32, sfh_hash) + __field(u32, tfh_hash) + __string_len(name, name, namelen) + __string_len(tgt, tgt, tgtlen) + ), + TP_fast_assign( + SVC_RQST_ENDPOINT_ASSIGNMENTS(rqstp); + __entry->sfh_hash =3D knfsd_fh_hash(&sfhp->fh_handle); + __entry->tfh_hash =3D knfsd_fh_hash(&tfhp->fh_handle); + __assign_str(name); + __assign_str(tgt); + ), + TP_printk("xid=3D0x%08x sfh_hash=3D0x%08x tfh_hash=3D0x%08x name=3D%s tar= get=3D%s", + __entry->xid, __entry->sfh_hash, __entry->tfh_hash, + __get_str(name), __get_str(tgt)) +); #endif /* _NFSD_TRACE_H */ =20 #undef TRACE_INCLUDE_PATH diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index bd19e5926ef198279e39ac9ef1873eab289cb4a0..9fd5f7d277b452e12a2d5854b9d= 3ff79418a8818 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c @@ -1865,6 +1865,8 @@ nfsd_rename(struct svc_rqst *rqstp, struct svc_fh *ff= hp, char *fname, int flen, int host_err; bool close_cached =3D false; =20 + trace_nfsd_vfs_rename(rqstp, ffhp, tfhp, fname, flen, tname, tlen); + err =3D fh_verify(rqstp, ffhp, S_IFDIR, NFSD_MAY_REMOVE); if (err) goto out; --=20 2.49.0 From nobody Wed Feb 11 23:32:21 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54D7827C860; Sat, 3 May 2025 15:11:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285114; cv=none; b=EyeoJXEfrwwmNJpdhHgXgabJjtThixWTrxXVDQBW7syH7bGueh7lhHfYcT0G5U6dMRECjWRcszlzdzZ5zQr007LfBJxpdlk1J6Uk8z1XxJTymIxyyI+UvXg+L+RscwKftwMfHvaKQFkpQEpnqaIHJFvtUThhQtp6tdfqisirxio= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285114; c=relaxed/simple; bh=EVp0KkwQWMT+7bdOoBwsBrqYsKukwQ0eGk8vamKl4jM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DXS0TbPrpcj3IU8xO9Lg8gxUGiLZiCOq6o38Uv1qjH5IJoTLTwEN9PCHgBFnOppxCAz4aOQAKI3yA72amPfv9TXS/Hy3OKya+IQ2Cn/Hhf2hBt35gPmIjF487Cd5fQaL4722gDek+9D5IL+NWNrzqwmXKOPrcf3VZHoSrD3+ftU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ih04J5dV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ih04J5dV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E269C4CEEE; Sat, 3 May 2025 15:11:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746285114; bh=EVp0KkwQWMT+7bdOoBwsBrqYsKukwQ0eGk8vamKl4jM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Ih04J5dVCHvUZYc9KClbdPJANIMMPH9XfztfrG+Jhax/aHqErXnMVXp+FkhlkUOPC /IaYEx3VGot6k8vZFc8vQyWb+/SexfjLufeq8gFYQWXUieWL48EdDS5JDyETAKZ8q9 W3DCv3JDuBm1PmwFvUWia5Xnc8cQ2kuoP+YYHm/Dj1/iKi9lG2S8zaIy+pibUaK2Wu p8Kd+9t2LZU5ofPkCFZJbe9lbjRjWl4PhKaReo0kFm1aaWAuT7oin7hDAIxJ7WvXLK hqWPx07rClwga+mA0SQ7nBTGeQM7pGB6R8zs7sX6hBGojFh1GAtLSv9iO0B9ilVoMx ZhxN5qlf8MTIQ== From: Jeff Layton Date: Sat, 03 May 2025 11:11:25 -0400 Subject: [PATCH v3 09/17] nfsd: add tracepoint to nfsd_readdir Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250503-nfsd-tracepoints-v3-9-d89f445969af@kernel.org> References: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> In-Reply-To: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> To: Chuck Lever , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , NeilBrown Cc: Sargun Dillon , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1606; i=jlayton@kernel.org; h=from:subject:message-id; bh=EVp0KkwQWMT+7bdOoBwsBrqYsKukwQ0eGk8vamKl4jM=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBoFjItJybWHLQWK/Wp4t5vjWjTXXvRltAXAa844 agl1LzTVCiJAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaBYyLQAKCRAADmhBGVaC FfL3D/9TIXMw1ySz1F/5kTXEXDMhVC/JZh/BlVrvhbcAqBqR7xpTQBz60F2zvkIK2/jn9gQKBEq pfXqVrPg9IJenOtYbuOLqRKgFCON7PoTyefZjjmPIwfTxy57nQkuZ/9svH8REFEYohx9Va4fUnM r8OSpjO2tafqKiMIZEPg0Lhz7C6plyHP9qpeEuXfrIPfk8x1ZddZiswybRKe3V6oNga53W7fgo2 w9pQy/UkVQ/qVIk4cBqzDjrhTsssWwB5XnBa2mm22GsBQllw++2pLQJgCOhuPQ+aUYvnk6l05+8 P9jAEAHgUapCEXfAGjqzZpcrqwGsV0MaYruPTTBNITSVNkTLQHETfnGsdHkvS7231BQrJ0hNEb1 lKKiVRsZqdUYm+dGUsTS5MLSC7b739bO/zyTsmaVhFv3lW65cHYtundSK/4h8z1FXHFehwj8u+4 +Mxc1QtIqo0lUVe4IU14Mzr6vmXcMy50Dsq5IFveL1lc36bSiwOjP4ImH6/YgCK+CVwh0pmxjIF D2vEO0rM32hVWT9CWzsUOH/zY/UoOOEmDyX3F3DtbbDeiB7fHEXcMFylmAVQQVH3djp8nXEcome Y40F49S1wGVInJwQOdKXPRNLMn4lkjDdaG+S0Tvg0Ha2tKvejRJ3XTeqjrxhCnhRLZh09c5yXhc sD4SZBRRbRhaXOg== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 Signed-off-by: Jeff Layton --- fs/nfsd/trace.h | 19 +++++++++++++++++++ fs/nfsd/vfs.c | 2 ++ 2 files changed, 21 insertions(+) diff --git a/fs/nfsd/trace.h b/fs/nfsd/trace.h index 4e873ceca602098d2899c5ff2deee610ddb670a0..6f73ecc6bbf09cc174a93ce1dce= 12edfff6f60b8 100644 --- a/fs/nfsd/trace.h +++ b/fs/nfsd/trace.h @@ -2512,6 +2512,25 @@ TRACE_EVENT(nfsd_vfs_rename, __entry->xid, __entry->sfh_hash, __entry->tfh_hash, __get_str(name), __get_str(tgt)) ); + +TRACE_EVENT(nfsd_vfs_readdir, + TP_PROTO(struct svc_rqst *rqstp, + struct svc_fh *fhp, + u64 offset), + TP_ARGS(rqstp, fhp, offset), + TP_STRUCT__entry( + SVC_RQST_ENDPOINT_FIELDS(rqstp) + __field(u32, fh_hash) + __field(u64, offset) + ), + TP_fast_assign( + SVC_RQST_ENDPOINT_ASSIGNMENTS(rqstp); + __entry->fh_hash =3D knfsd_fh_hash(&fhp->fh_handle); + __entry->offset =3D offset; + ), + TP_printk("xid=3D0x%08x fh_hash=3D0x%08x offset=3D0x%llx", + __entry->xid, __entry->fh_hash, __entry->offset) +); #endif /* _NFSD_TRACE_H */ =20 #undef TRACE_INCLUDE_PATH diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index 9fd5f7d277b452e12a2d5854b9d3ff79418a8818..ec07e5867912bf87497b935d26e= 3039364596864 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c @@ -2249,6 +2249,8 @@ nfsd_readdir(struct svc_rqst *rqstp, struct svc_fh *f= hp, loff_t *offsetp, loff_t offset =3D *offsetp; int may_flags =3D NFSD_MAY_READ; =20 + trace_nfsd_vfs_readdir(rqstp, fhp, *offsetp); + err =3D nfsd_open(rqstp, fhp, S_IFDIR, may_flags, &file); if (err) goto out; --=20 2.49.0 From nobody Wed Feb 11 23:32:21 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFC8327CB30; Sat, 3 May 2025 15:11:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285115; cv=none; b=j/UXaY7QOo/0Pr+LiAtttVWhdGe/a5+7LSUDbu6bjBZtuMNecTygK0kEQeXl1BvLD2KZMo3zfr0u6WoN/l+YgtirdtSB8p48W/cTHvHSSa0ObjnZrjuzw1UEAyZOIKVu5tSy18FlMhOcFv+kRbf0FImUnNcidFON3lOBlb2npeU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285115; c=relaxed/simple; bh=rXX/BKYshS2lmjJ8Wq8yvdgE+Sd2NYuaMpACqzgvbbc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lQlVODiA0r1RxX0HdL9ygUeIjmnKAGZIGH4UhUtEXA6256A047oRAQzqrtKrzih0GTvwaJEWy7yS+W7SAeq12pY6PR10O45lrKqBCkAXmhfjXSPk41rjHKNECywkme64+I38s/SgfUWWx2OmQbyzCZLBXWFQe3KQA4MSYH3mrXU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mBOGzoAl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mBOGzoAl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D933C4CEE9; Sat, 3 May 2025 15:11:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746285115; bh=rXX/BKYshS2lmjJ8Wq8yvdgE+Sd2NYuaMpACqzgvbbc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=mBOGzoAlTeRVpgwEJDINftCdVSl1bo+wZGoCxSZIcs9mE+V+sGPpMO22FmqC4MIx6 RXM75gtHWtdDDjh47oZBMD7s0nOKMOluLtTxFWI2KdN13oqEou7m3zt0QJ6TuUMEz4 laPQe/Ec+Mu+YE8G313l65VYSx25i5HJe+YJlssbnj0/Qd64iXdgTtxo2Ds+MiJGbR bwirs7Mmsst+ZjG179abnbp3UKnNweeBOvPApCvHkYkOEaW74cuQxO1EkvL6xKrRWW DfstDStszKXW6nQUCqLaBvBHL8MPu6RevOFqAGDKRNbU5yLpr6fjMSBbKSMk/+KIvx 7fGrYb/WEAuLA== From: Jeff Layton Date: Sat, 03 May 2025 11:11:26 -0400 Subject: [PATCH v3 10/17] nfsd: add tracepoint for getattr and statfs events Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250503-nfsd-tracepoints-v3-10-d89f445969af@kernel.org> References: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> In-Reply-To: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> To: Chuck Lever , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , NeilBrown Cc: Sargun Dillon , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3631; i=jlayton@kernel.org; h=from:subject:message-id; bh=rXX/BKYshS2lmjJ8Wq8yvdgE+Sd2NYuaMpACqzgvbbc=; b=kA0DAAgBAA5oQRlWghUByyZiAGgWMi7IU+NBaAEOigXwKWUW1PzOYdcty/4AnIsZ6GmVS7o9f 4kCMwQAAQgAHRYhBEvA17JEcbKhhOr10wAOaEEZVoIVBQJoFjIuAAoJEAAOaEEZVoIVljwP/1zF 9PakPkXqZiZEDllLnJP3ty3uA/NDkqMijYOw+G5HbI+vmXuGQKpRHqO+71JZJIfypyp1uwBNWzb yCmuKY33dVxPjT5xe/+H+ZlZGp0CqBf+5SNPfFyPXgQbbqHFcGxxHd8gUskV/2VJnlhsQCZuk54 onDIsYPU12uZmDJbLYmjaLWMk/VCF3vYouI6FDulxoFIHM4MxwzaP/DNcXHdk2GYAWh4GQyRFn3 HXDy4fq+wapEAUqBCQwAiZDUKrBeNOkQ4MC02h5We2w4Xha9AjoTtHTg+V54jWjsd7scmeGFPr5 h3noB9kij8EWPEEULyKl79+nYTI9AoOu6qmNhWAxNMrRjKIN7p37oUDgEqhJOom1ke8qrJrqF2Q p6VfW4wXryiSvrL2XOpGB9tv3xqS2H4n91P6AKy2OiuB7RL69w3s1Xa4EPbHg4HRm4Qt2fcI7WO mYt5FvnEco1cVW5YXzospi8As5TbySeYfZ6bBEQIXiNa6F7pMrjWqT7XXTAzTndlHLnW0xJNcl4 lRoga6zWs8wzR160BAAra76918qnrri7kBVUdwVViGrbJOyrihHjTwYwgojjfpR0P3tyOf7J0Oq q1/UzHsQKzdwhzaRhKGfoLT+6qrraPars11h4ih5woGfsZcsMw6+gE/vEM/Ank52YijD7joLpV6 YJRvy X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 There isn't a common helper for getattrs, so add these into the protocol-spefici helpers. Signed-off-by: Jeff Layton --- fs/nfsd/nfs3proc.c | 2 ++ fs/nfsd/nfs4proc.c | 2 ++ fs/nfsd/nfsproc.c | 3 +++ fs/nfsd/trace.h | 24 ++++++++++++++++++++++++ fs/nfsd/vfs.c | 2 ++ 5 files changed, 33 insertions(+) diff --git a/fs/nfsd/nfs3proc.c b/fs/nfsd/nfs3proc.c index 5d2b081072e8c2e286c6815c34e5e58d4be15067..c77e273e73a423c77047ff68126= 556ed36bc9c8e 100644 --- a/fs/nfsd/nfs3proc.c +++ b/fs/nfsd/nfs3proc.c @@ -70,6 +70,8 @@ nfsd3_proc_getattr(struct svc_rqst *rqstp) struct nfsd_fhandle *argp =3D rqstp->rq_argp; struct nfsd3_attrstat *resp =3D rqstp->rq_resp; =20 + trace_nfsd_vfs_getattr(rqstp, &argp->fh); + dprintk("nfsd: GETATTR(3) %s\n", SVCFH_fmt(&argp->fh)); =20 diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c index 6e4c9bd15a6c820806832db19682e32a3d86507e..15508d2f5209b92fc62afb43ba0= 3e72f195c2f77 100644 --- a/fs/nfsd/nfs4proc.c +++ b/fs/nfsd/nfs4proc.c @@ -923,6 +923,8 @@ nfsd4_getattr(struct svc_rqst *rqstp, struct nfsd4_comp= ound_state *cstate, struct nfsd4_getattr *getattr =3D &u->getattr; __be32 status; =20 + trace_nfsd_vfs_getattr(rqstp, &cstate->current_fh); + status =3D fh_verify(rqstp, &cstate->current_fh, 0, NFSD_MAY_NOP); if (status) return status; diff --git a/fs/nfsd/nfsproc.c b/fs/nfsd/nfsproc.c index 5d842671fe6fb36a24799de6991c0e21a883fb52..dd6ad6c87b55b3c830b81a7beda= 10d674dc0d09c 100644 --- a/fs/nfsd/nfsproc.c +++ b/fs/nfsd/nfsproc.c @@ -10,6 +10,7 @@ #include "cache.h" #include "xdr.h" #include "vfs.h" +#include "trace.h" =20 #define NFSDDBG_FACILITY NFSDDBG_PROC =20 @@ -54,6 +55,8 @@ nfsd_proc_getattr(struct svc_rqst *rqstp) struct nfsd_fhandle *argp =3D rqstp->rq_argp; struct nfsd_attrstat *resp =3D rqstp->rq_resp; =20 + trace_nfsd_vfs_getattr(rqstp, &argp->fh); + dprintk("nfsd: GETATTR %s\n", SVCFH_fmt(&argp->fh)); =20 fh_copy(&resp->fh, &argp->fh); diff --git a/fs/nfsd/trace.h b/fs/nfsd/trace.h index 6f73ecc6bbf09cc174a93ce1dce12edfff6f60b8..29b391c66ff0f0eaa0bb06b2ab9= 063a2b9831171 100644 --- a/fs/nfsd/trace.h +++ b/fs/nfsd/trace.h @@ -2531,6 +2531,30 @@ TRACE_EVENT(nfsd_vfs_readdir, TP_printk("xid=3D0x%08x fh_hash=3D0x%08x offset=3D0x%llx", __entry->xid, __entry->fh_hash, __entry->offset) ); + +DECLARE_EVENT_CLASS(nfsd_vfs_getattr_class, + TP_PROTO(struct svc_rqst *rqstp, + struct svc_fh *fhp), + TP_ARGS(rqstp, fhp), + TP_STRUCT__entry( + SVC_RQST_ENDPOINT_FIELDS(rqstp) + __field(u32, fh_hash) + ), + TP_fast_assign( + SVC_RQST_ENDPOINT_ASSIGNMENTS(rqstp); + __entry->fh_hash =3D knfsd_fh_hash(&fhp->fh_handle); + ), + TP_printk("xid=3D0x%08x fh_hash=3D0x%08x", + __entry->xid, __entry->fh_hash) +); + +#define DEFINE_NFSD_VFS_GETATTR_EVENT(__name) \ + DEFINE_EVENT(nfsd_vfs_getattr_class, __name, \ + TP_PROTO(struct svc_rqst *rqstp, struct svc_fh *fhp), \ + TP_ARGS(rqstp, fhp)) + +DEFINE_NFSD_VFS_GETATTR_EVENT(nfsd_vfs_getattr); +DEFINE_NFSD_VFS_GETATTR_EVENT(nfsd_vfs_statfs); #endif /* _NFSD_TRACE_H */ =20 #undef TRACE_INCLUDE_PATH diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index ec07e5867912bf87497b935d26e3039364596864..f5ba30cb4b9358552c8f537ac5c= 7e5b733f57ffa 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c @@ -2317,6 +2317,8 @@ nfsd_statfs(struct svc_rqst *rqstp, struct svc_fh *fh= p, struct kstatfs *stat, in { __be32 err; =20 + trace_nfsd_vfs_statfs(rqstp, fhp); + err =3D fh_verify(rqstp, fhp, 0, NFSD_MAY_NOP | access); if (!err) { struct path path =3D { --=20 2.49.0 From nobody Wed Feb 11 23:32:21 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D402927CCDB; Sat, 3 May 2025 15:11:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285116; cv=none; b=ICwdKFw8g/EDPTfNCDlbF/m2r08TtNQsXqNJEbNDDm1h31x4P1P4ALo1WthLUUOWPBRmEqbrzwB80p78mO32AV8TVO2SilQzAZEb2DyNACfOBz4pucsIpBwTE+xoS9YZv7HDF+/7O76R50iYhDksnSz003O4nkKCzacH+u+4mxc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285116; c=relaxed/simple; bh=puw/ksLPm4ioCKeRZH1T4nn8ZrUcLF8Shq+WG41gIHw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DoTD3khYXbKWG5SoLVBDcQBAW1gr4S8Z1uUjzKuE9CZfChE0r+ARcd7qTJy6ZfVHRXz8AV2yu17ILCje8n3W/tKbY1OhdmT4uWA5TBNggiAWUc+rJb41Ddg4RnN6ChluKjqGZklx82uhPjOU86fyx5UAv2ROietcF6WsKLImvnc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZHZKQcVb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZHZKQcVb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D813C4CEEE; Sat, 3 May 2025 15:11:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746285116; bh=puw/ksLPm4ioCKeRZH1T4nn8ZrUcLF8Shq+WG41gIHw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=ZHZKQcVbdX33YF+Qmh9nmewNSSOGFfX+OynuLWP3uO/3eNHeve0AOlPNtzIl+zzD3 dP28wAj6W1cFBx7IXWuNVYfiFSl6/IfiET29S50eCa4nMoMLDR4mfM4pQlvPJMQI07 xXrECr7AeBGPimY3gv5TJq6uUJo0iBPa1Cwbuu/v0OpZai+kFUJljyHvJ/VWVxZ9Mb 6+O1NB7wNwpUtbq3I+6uwIIYziE+lljSEn9KwH0g9S8FKbIFqZ/+PfRv0Y8O7aB5Cf 325AC8dsWxxbPKke+48X3PSSjhkkqqhQJjEy0mNMyK2kV7m1zltu5XVMFxHWhOqq8K jEzWw5/dTPhUg== From: Jeff Layton Date: Sat, 03 May 2025 11:11:27 -0400 Subject: [PATCH v3 11/17] nfsd: remove old v2/3 create path dprintks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250503-nfsd-tracepoints-v3-11-d89f445969af@kernel.org> References: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> In-Reply-To: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> To: Chuck Lever , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , NeilBrown Cc: Sargun Dillon , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2207; i=jlayton@kernel.org; h=from:subject:message-id; bh=puw/ksLPm4ioCKeRZH1T4nn8ZrUcLF8Shq+WG41gIHw=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBoFjIu5D1W6x2kgpjD1czjKtDtwkzETkZHVjmEv rfOK4Kpc6qJAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaBYyLgAKCRAADmhBGVaC FdBID/9pTUAtZ/4vowgsoszGoENsxOdKo0lzz9tyHMzWNznfRavn1G3Bhv88L61/QCVtumIS2Xa 4yudiDPGfANxvKd6xVWZsrzscD8IP4beiLVq0frM4vL7Jt29HtXQLnlhWMebjaQevJgG1JOes7/ Je9Xzl5gYSFLxqWHrMhsc/LT3G+tJUdNOFl0ZEK6Cw+dEJQZi9OTKDH+N5bDJ346/5nPoeAZov0 OFW2t2omdF90CNRAVLpon2nCEezONx0J7awYgW2sGAEI7dKL6ntIlhXxTzBRhBxuc3sgcJzGfHs KyRls8F+H9Cjg8VuSv5haCUMHWQo061bVCRjNZhH+o5QRg5HSbhk7TXrAdXPog353JIRn5XACzo 8g+SqGpUwdpb88CscYCSRQDIPe3l5EmI/FWIPZJ/0OH+wEnVWl8dsvIlPSBKDAhGza+CfgZlc/B jgNYYPfFS036/HVggIxmn7NI6g087DrY3PPnShD5zqEKJzoLC7Jh76C0yPUhI1pBHiQaLtnmv8L igFbNG/pPm9nvFVv7qmHWr5+Qgat+sIOpNr3c0PsDiQUrhT5xr3Ksh0+TK0aglCzjDixgC4zGo8 eygWJH5vNbec3FSlWffit1vwjJ2vLB9x6uJ+XF2gTh5Kzx2v/cixhmvV+KJTPSIVmwowDgrhkva Pd0Vd/nL45w6evg== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 Signed-off-by: Jeff Layton --- fs/nfsd/nfs3proc.c | 15 --------------- fs/nfsd/nfsproc.c | 5 ----- 2 files changed, 20 deletions(-) diff --git a/fs/nfsd/nfs3proc.c b/fs/nfsd/nfs3proc.c index c77e273e73a423c77047ff68126556ed36bc9c8e..215d60b5b5e0386942d28432e66= 069ee6f960e0d 100644 --- a/fs/nfsd/nfs3proc.c +++ b/fs/nfsd/nfs3proc.c @@ -385,11 +385,6 @@ nfsd3_proc_create(struct svc_rqst *rqstp) struct nfsd3_diropres *resp =3D rqstp->rq_resp; svc_fh *dirfhp, *newfhp; =20 - dprintk("nfsd: CREATE(3) %s %.*s\n", - SVCFH_fmt(&argp->fh), - argp->len, - argp->name); - dirfhp =3D fh_copy(&resp->dirfh, &argp->fh); newfhp =3D fh_init(&resp->fh, NFS3_FHSIZE); =20 @@ -410,11 +405,6 @@ nfsd3_proc_mkdir(struct svc_rqst *rqstp) .na_iattr =3D &argp->attrs, }; =20 - dprintk("nfsd: MKDIR(3) %s %.*s\n", - SVCFH_fmt(&argp->fh), - argp->len, - argp->name); - argp->attrs.ia_valid &=3D ~ATTR_SIZE; fh_copy(&resp->dirfh, &argp->fh); fh_init(&resp->fh, NFS3_FHSIZE); @@ -479,11 +469,6 @@ nfsd3_proc_mknod(struct svc_rqst *rqstp) int type; dev_t rdev =3D 0; =20 - dprintk("nfsd: MKNOD(3) %s %.*s\n", - SVCFH_fmt(&argp->fh), - argp->len, - argp->name); - fh_copy(&resp->dirfh, &argp->fh); fh_init(&resp->fh, NFS3_FHSIZE); =20 diff --git a/fs/nfsd/nfsproc.c b/fs/nfsd/nfsproc.c index dd6ad6c87b55b3c830b81a7beda10d674dc0d09c..5e93e17b94d4de0382f9038b460= 0938bb6a699c2 100644 --- a/fs/nfsd/nfsproc.c +++ b/fs/nfsd/nfsproc.c @@ -295,9 +295,6 @@ nfsd_proc_create(struct svc_rqst *rqstp) int hosterr; dev_t rdev =3D 0, wanted =3D new_decode_dev(attr->ia_size); =20 - dprintk("nfsd: CREATE %s %.*s\n", - SVCFH_fmt(dirfhp), argp->len, argp->name); - /* First verify the parent file handle */ resp->status =3D fh_verify(rqstp, dirfhp, S_IFDIR, NFSD_MAY_EXEC); if (resp->status !=3D nfs_ok) @@ -551,8 +548,6 @@ nfsd_proc_mkdir(struct svc_rqst *rqstp) .na_iattr =3D &argp->attrs, }; =20 - dprintk("nfsd: MKDIR %s %.*s\n", SVCFH_fmt(&argp->fh), argp->len, argp= ->name); - if (resp->fh.fh_dentry) { printk(KERN_WARNING "nfsd_proc_mkdir: response already verified??\n"); --=20 2.49.0 From nobody Wed Feb 11 23:32:21 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E969C27D763; Sat, 3 May 2025 15:11:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285118; cv=none; b=MmJJhzEtLDMLoIgSpBfjO/NPt89tQmSnjHUv7Ntxnayp5jPtOleoxQjOM/jdcPK0gwrsPwNEnYJRF/ZxbN8ko9mOT673l+husVE7VF3OoUr4Y5/oA6ICJQANTXNpkDTrL8FHCVr3c/o79ND01QtdJdcGqOvE+bYJzdHZEWHOUCA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285118; c=relaxed/simple; bh=9luchfh6AMC5aL2zTK4oqgHlT+RnVvkuNrxdfqwhWP4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nMzoVj7nRO5Zoqo8OZqEcC42X/MSWEB4t0kMcn570ueUQlpQd8Ti8QI/S+Xa2IJIi5m16cztReTkNjpKLqmI2jRqP9xtXgRHuBfj4aMEIESF0XvAGATohZS06xv4X8LdzoqyVyZp9SMYuaDoX2FKhS7i2Vd/2gC178U9OQ85138= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uJaUBmal; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uJaUBmal" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C7EBC4CEE9; Sat, 3 May 2025 15:11:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746285117; bh=9luchfh6AMC5aL2zTK4oqgHlT+RnVvkuNrxdfqwhWP4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=uJaUBmalFM2PKb+Kf0vey1PZLUxjORCbkjE23waINw7ml8BzGGp9xNBi1ca3vUc5i /B8eQpD5v5xkvi7QbZM5rxNkaQyiQ/l8WxE7lsJf2aOYkhbgF/Dp0Ny1l/j5QGdfIn /rqFDP8Rr3IEb9njvEyGLcHC+lHPCyvmDERE2KgPwF7oB2Jhd/9gAoLtGhWQAIbOUa mxYOY9fk01MoAOdAJcLe2Ss/O+l5i7eQ8My4vuBHwbP+BBErQOqXdWf2VMRFX3cMV3 ow0/3Lp0bVECAQTge/pgLvsFCQ8OH0LMll5Tz6iicjuCJ+9mDD/7Soygjm4DmIIUoH rlHrxsYAAizCQ== From: Jeff Layton Date: Sat, 03 May 2025 11:11:28 -0400 Subject: [PATCH v3 12/17] nfsd: remove old v2/3 SYMLINK dprintks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250503-nfsd-tracepoints-v3-12-d89f445969af@kernel.org> References: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> In-Reply-To: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> To: Chuck Lever , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , NeilBrown Cc: Sargun Dillon , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1304; i=jlayton@kernel.org; h=from:subject:message-id; bh=9luchfh6AMC5aL2zTK4oqgHlT+RnVvkuNrxdfqwhWP4=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBoFjIu0RpHqddncWGcrvfP0piHcAZuO5bKthk1L v0SIkTPCHOJAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaBYyLgAKCRAADmhBGVaC Fc4lD/9TtEeo9cxD1CvZ6IPzR9jQrksJD7/2uoaalyEhQnS8YRCrbY00YDA0Oak7lZOG0/wfasF zMwWarn49vIfuyvWSyQVd5P6vRw9Fa+djtgI/PHuLNlB7q0pBPGnGl8OesVtILRIupoesfd4Ikz bdso/EC+9LAf8pSTmlSoWo7LN1X+7ztm/eSwVy27t2bHePxMynsKTQV7DJpMADxqR9uewHdMLv4 8VxwUMS64FDvRt2lGLksL5CVnnCyFDpQX1YVL9evwKqhpTfQfZhf6xA45j9QKrul3buE8sJbQf8 OsIYFCZvv5qhRWKZGPWv1/nGCbFwRuAUxl+Djw7QIm7fZtF0W9LWvz+sZoH31VMoVvR0RHNE1Dw OY+itX34wtq4YnPNVmoJs6G82frTXB/m8p+ehvHfN/HSVuDhKsAMKjLKu0CeQKQkBtF7JiytrA/ nEd63tPfmplAOa+erkD4g3HieOA44Iip5UKzsTsZDg9Ya/S9ROcXq68JJnVraWOaiuOIpzKZ1Dq aRdgitYCftjaR/kR0YtxgDHMarqJB4a82yDysq/fxiBN20vklVEG/9thExwWfNWjOV8oxjOL8KK W0EHm6YHCzwBvutP69bv0I+kGyB5lu2SK4uG1M8tLKsM9RA0zz0Iqmw2eoLiAObB04xc7PGC2jA fNXfEPuC+wqO4JA== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 Signed-off-by: Jeff Layton --- fs/nfsd/nfs3proc.c | 5 ----- fs/nfsd/nfsproc.c | 4 ---- 2 files changed, 9 deletions(-) diff --git a/fs/nfsd/nfs3proc.c b/fs/nfsd/nfs3proc.c index 215d60b5b5e0386942d28432e66069ee6f960e0d..237bd102e4ce13b0461d27dd6f7= 2219ae3802082 100644 --- a/fs/nfsd/nfs3proc.c +++ b/fs/nfsd/nfs3proc.c @@ -440,11 +440,6 @@ nfsd3_proc_symlink(struct svc_rqst *rqstp) goto out; } =20 - dprintk("nfsd: SYMLINK(3) %s %.*s -> %.*s\n", - SVCFH_fmt(&argp->ffh), - argp->flen, argp->fname, - argp->tlen, argp->tname); - fh_copy(&resp->dirfh, &argp->ffh); fh_init(&resp->fh, NFS3_FHSIZE); resp->status =3D nfsd_symlink(rqstp, &resp->dirfh, argp->fname, diff --git a/fs/nfsd/nfsproc.c b/fs/nfsd/nfsproc.c index 5e93e17b94d4de0382f9038b4600938bb6a699c2..27c4022dd75c498cc46dc734d10= d7da3736b5079 100644 --- a/fs/nfsd/nfsproc.c +++ b/fs/nfsd/nfsproc.c @@ -519,10 +519,6 @@ nfsd_proc_symlink(struct svc_rqst *rqstp) goto out; } =20 - dprintk("nfsd: SYMLINK %s %.*s -> %.*s\n", - SVCFH_fmt(&argp->ffh), argp->flen, argp->fname, - argp->tlen, argp->tname); - fh_init(&newfh, NFS_FHSIZE); resp->status =3D nfsd_symlink(rqstp, &argp->ffh, argp->fname, argp->flen, argp->tname, &attrs, &newfh); --=20 2.49.0 From nobody Wed Feb 11 23:32:21 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01E7D27935B; Sat, 3 May 2025 15:11:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285119; cv=none; b=j8dgqrh9D7vMmEVjzWrtVQ5h9beYD8w+vTs3WxFi//Dxq654TMCGqvxt4mI+bjDbFnCbLPYy34Pf2ocTd1wfZWowCsySaCOkuUwoDn4x8Oq+3fJ41suH8/sPUoOu8qUxC+Jf3+DrByw0FBpXTGJOyVQpXT1kjXnXra7KRc7SM+s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285119; c=relaxed/simple; bh=iCMEo2AvD1zR/WR7Vnx1UYY/Nzx3edRlxO9pfqCg+WY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=D9Bdo6PKEKk0meouNV5sMDGnn5Sj5fOvc4U2z2VQi53fS2jpjYzUd4Hsrac//MhUsXlK/qbV4vqVYXb1zeUbqvrYWtb8Lq1tXZJ37OYn5aaAgDBnItoKnr6zcqKIVNuLMZYwU94B87sLcJlDv6g+7a1UQSsHEXqSad13HMlehvw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iT7yDgwg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iT7yDgwg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9BA3AC4CEEB; Sat, 3 May 2025 15:11:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746285118; bh=iCMEo2AvD1zR/WR7Vnx1UYY/Nzx3edRlxO9pfqCg+WY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=iT7yDgwgduU2x6x4ncJHKFf4eXWKyVBzYCTLq3bksLCtqW2aYIaXc0nRFXDXiQtJX 90dc0V87I/DVv5x93geGcYAGMDsBjHOHE2H3MzMqCznYGhgOranflcHu6VJb79yqIB sJFUqQjUpcd30E0M2rsN3UMvFzetLYNu4ruZqnUi5dYBiOoI39aWExm72yHk2VtFhI gAFwhevs1CZHpAAJBB2uer9GYBAC91+7VGmClQZA38csDLsyUBwyHzefutccfO7qym XZXBjN3EZgoNpO2CePhU0rLMVG4Vl59/pgbEfP7edS33TR8kATSDNAB1xm9x8QRknm jpL9kt7qAbfWg== From: Jeff Layton Date: Sat, 03 May 2025 11:11:29 -0400 Subject: [PATCH v3 13/17] nfsd: remove old LINK dprintks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250503-nfsd-tracepoints-v3-13-d89f445969af@kernel.org> References: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> In-Reply-To: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> To: Chuck Lever , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , NeilBrown Cc: Sargun Dillon , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1489; i=jlayton@kernel.org; h=from:subject:message-id; bh=iCMEo2AvD1zR/WR7Vnx1UYY/Nzx3edRlxO9pfqCg+WY=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBoFjIuONVwhgFBlHppnIr/FBLGFaca/kSclHZIt dVm5pkUYy6JAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaBYyLgAKCRAADmhBGVaC FcqxD/4j0Zd0ybJC7FgJdK12Jy1Lj4G0WdPj1nhtWMDxFgWRx6I8mplXo1i/gObQ9Eyssht9MP2 NLq8ZpUJ2Oz/OF9SgAenJfOH1AyHVHx60MQOX3ZFRlctdckc+bIfUo5o5qCdqSX22zpfTwYBWcc mTfcsMVUbws0do8+/EkSu4BGCX2wafZ0G/OVF41hay2qzgiM54XQlp5LU0N/BZTFFZvzQW4ko7D En9BcwzCUI78OaCju+DSDWMlmTbEdUZkxrviP7eSjAHjm4ASL39/quh+A/mWzkFDo25KRfKynWR u9lCIyzs8Wr0uOGgc/DqUml/a8TMP/aQI3aHHoyGDA04CCW7IJeOJOe9sIrNmikSRPnyitHHDXv +kNEuNX7wIFQ3lRdOpq8sNjTmAI+EhFT5IPN0rzc0FmsW0kPHJscuLOjszdlAq1iEqlRc/VuKTx FcTEZMVHYKMJ2sqLfO9hRxaVdtoLTmKUNiSLMXj7YmMNqex3OPGxzHfzMTJWLBL6+KLjYvY5ckF H52taNTQxZ86BFCXxiOJi3zy1hEyNMM4fpaq3R5GZZYCJwz8zdNo3MYZWSm1pXCDfsh7Rab3yEb nAr0qjLmZ/OfDPfsw7YF/9gVaGEQ1SNIC3Dpox8frUSdy/OA4pZ5hyKXGljgNgaGhvyscKfdm97 dNvjEGeF8UY6zsQ== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 Signed-off-by: Jeff Layton --- fs/nfsd/nfs3proc.c | 7 ------- fs/nfsd/nfsproc.c | 7 ------- 2 files changed, 14 deletions(-) diff --git a/fs/nfsd/nfs3proc.c b/fs/nfsd/nfs3proc.c index 237bd102e4ce13b0461d27dd6f72219ae3802082..7ed4932e82f330b4e382c0129ba= 8cff10f2d44e0 100644 --- a/fs/nfsd/nfs3proc.c +++ b/fs/nfsd/nfs3proc.c @@ -559,13 +559,6 @@ nfsd3_proc_link(struct svc_rqst *rqstp) struct nfsd3_linkargs *argp =3D rqstp->rq_argp; struct nfsd3_linkres *resp =3D rqstp->rq_resp; =20 - dprintk("nfsd: LINK(3) %s ->\n", - SVCFH_fmt(&argp->ffh)); - dprintk("nfsd: -> %s %.*s\n", - SVCFH_fmt(&argp->tfh), - argp->tlen, - argp->tname); - fh_copy(&resp->fh, &argp->ffh); fh_copy(&resp->tfh, &argp->tfh); resp->status =3D nfsd_link(rqstp, &resp->tfh, argp->tname, argp->tlen, diff --git a/fs/nfsd/nfsproc.c b/fs/nfsd/nfsproc.c index 27c4022dd75c498cc46dc734d10d7da3736b5079..449732bb64f85283d7f208087dc= 47d39df3f5e68 100644 --- a/fs/nfsd/nfsproc.c +++ b/fs/nfsd/nfsproc.c @@ -481,13 +481,6 @@ nfsd_proc_link(struct svc_rqst *rqstp) struct nfsd_linkargs *argp =3D rqstp->rq_argp; struct nfsd_stat *resp =3D rqstp->rq_resp; =20 - dprintk("nfsd: LINK %s ->\n", - SVCFH_fmt(&argp->ffh)); - dprintk("nfsd: %s %.*s\n", - SVCFH_fmt(&argp->tfh), - argp->tlen, - argp->tname); - resp->status =3D nfsd_link(rqstp, &argp->tfh, argp->tname, argp->tlen, &argp->ffh); fh_put(&argp->ffh); --=20 2.49.0 From nobody Wed Feb 11 23:32:21 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2A3E27D788; Sat, 3 May 2025 15:11:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285119; cv=none; b=fcNXCJ1YnqwDxlp15Clg9Df16EUK/TM8NwARIvKm5hZm1V8iQdzbeTA1sP1J6RCO/Eqoa+VZNePubrO41fwecsjV/kV486eDaTzvcIjbYxPsF5PkpFjY1QwiRdQspGzJKPEeeuvZX7M5+PSsfHzKwfbOR65GK1TD2HzfT2r/ktk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285119; c=relaxed/simple; bh=BMpTJCCODEIlgGU/6woI0of3j2GU2RwUH3lrQRd+v+8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=stKt6GYOim2tjd3S+t+vnGJLozRzgBx33VXovNcut/kjMSuDEjzM6216C1NDYGByAsXdy/iVFv9h2vBHwTt1jVXdRiwTI+bwfO8BtRSpzDq4JZrLmLGv84wfmQNFSADXXjnpDwjhI7nO+3Pn+u4+iSivJu/9x6FgPNlWV1kfPvo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iUg+D97a; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iUg+D97a" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AAD44C4CEE3; Sat, 3 May 2025 15:11:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746285119; bh=BMpTJCCODEIlgGU/6woI0of3j2GU2RwUH3lrQRd+v+8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=iUg+D97aWD53JORCvpE1EKhKdne9oJNZQaz8LCFB0z1hc9rcn1SkwWTbIwd448OSY J6TSIoR4+Oobhzm/5rA/8Mh1T0tomG3POQkd5xPJddXQhaB1rvHoGRyVjj7cjgBNLm gE4fFywA8zkHj93lCiklya2KlPFTFPri0JFeedp1bnIWekD8NdzuREBEnWOOAELkzC tR1lrpTBe0XvdGOHT97Ydps+4mRFspK+yguls8+Penm6q128W2eKQOfV+FRmFs+VIp ro1MOJ/xGLemfNXKoeqTE92m9AVSeCs/608WFZqtindIz3lksZ+JciPzY20S6ESDXw qyQxPiFO1GLPA== From: Jeff Layton Date: Sat, 03 May 2025 11:11:30 -0400 Subject: [PATCH v3 14/17] nfsd: remove REMOVE/RMDIR dprintks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250503-nfsd-tracepoints-v3-14-d89f445969af@kernel.org> References: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> In-Reply-To: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> To: Chuck Lever , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , NeilBrown Cc: Sargun Dillon , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2161; i=jlayton@kernel.org; h=from:subject:message-id; bh=BMpTJCCODEIlgGU/6woI0of3j2GU2RwUH3lrQRd+v+8=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBoFjIumvhTVZQ9ofLWGDmWBpKZq+rOTPhDlAIf1 8Tv+NwLi5SJAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaBYyLgAKCRAADmhBGVaC FUd4D/4qKLb/YE0TOKver9MLh/sjFv18oeBt9f4ioNqY6JLZEuJac9mLkqFct4yrp2p/LF1uHrW gNZiTrUvPIzEH5lY434PK+gcsQY8aDA1LDmPUMdQjU/OLOS8JsBsnZsXHgAM/NEvyX4PJ7ONIwj PZnJJc0UmKmvZ5SKAtF+pwrh+uzHq8YQ9nOLZXjA/y8vWZuW4NfhKfm8TlbDpif8zWKgNoy5sdO 06kSiEG7zGlKYn96jKhdU9zjYqs7U0O3M2Hh6m4gAwpnRVyYD9brWxJYZm4buUQkDKUBfkD1NSr 6hu1aUBs29pnTRWYXKD7R8cRVfedRCGk+l3THohqt1OpMNHlrED0INK4zbjkdYqwukPM10DTUnj BFfDl4CYeKz6fJ5yCaRu36J1kbJWCuMqR5IeggZRIfv6zwf1e8FeWX+HEkClVbIn6uvQmuEXXz/ VWcacWQHirfovLEbTm0uJvu/Qf2BSi4VLKHGbqwGETmq0tWv/d/b/s0y7axogOGDXdqW+3W3/ys vltSzgoJMmKsHg+uS+W3ZILvDF78KNDk5MaHmsK0foXcHl04T1vhn+xK2b/CWS37TiX22FUm9yE QSRc/G6Lu38TzK1yFoCI8vusiAWrchKNsrt3FOOll1cXwT5AOn/xNUppW2P2N89KnAX8nvxE0r4 ayn64HaGPHYww3g== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 Signed-off-by: Jeff Layton --- fs/nfsd/nfs3proc.c | 10 ---------- fs/nfsd/nfsproc.c | 5 ----- 2 files changed, 15 deletions(-) diff --git a/fs/nfsd/nfs3proc.c b/fs/nfsd/nfs3proc.c index 7ed4932e82f330b4e382c0129ba8cff10f2d44e0..fca65adc43d3b70323938ff8a59= 5ce7eb0a7ca57 100644 --- a/fs/nfsd/nfs3proc.c +++ b/fs/nfsd/nfs3proc.c @@ -496,11 +496,6 @@ nfsd3_proc_remove(struct svc_rqst *rqstp) struct nfsd3_diropargs *argp =3D rqstp->rq_argp; struct nfsd3_attrstat *resp =3D rqstp->rq_resp; =20 - dprintk("nfsd: REMOVE(3) %s %.*s\n", - SVCFH_fmt(&argp->fh), - argp->len, - argp->name); - /* Unlink. -S_IFDIR means file must not be a directory */ fh_copy(&resp->fh, &argp->fh); resp->status =3D nfsd_unlink(rqstp, &resp->fh, -S_IFDIR, @@ -518,11 +513,6 @@ nfsd3_proc_rmdir(struct svc_rqst *rqstp) struct nfsd3_diropargs *argp =3D rqstp->rq_argp; struct nfsd3_attrstat *resp =3D rqstp->rq_resp; =20 - dprintk("nfsd: RMDIR(3) %s %.*s\n", - SVCFH_fmt(&argp->fh), - argp->len, - argp->name); - fh_copy(&resp->fh, &argp->fh); resp->status =3D nfsd_unlink(rqstp, &resp->fh, S_IFDIR, argp->name, argp->len); diff --git a/fs/nfsd/nfsproc.c b/fs/nfsd/nfsproc.c index 449732bb64f85283d7f208087dc47d39df3f5e68..41011a7f19397a300c5c6b46887= 1a18b9f3fc210 100644 --- a/fs/nfsd/nfsproc.c +++ b/fs/nfsd/nfsproc.c @@ -445,9 +445,6 @@ nfsd_proc_remove(struct svc_rqst *rqstp) struct nfsd_diropargs *argp =3D rqstp->rq_argp; struct nfsd_stat *resp =3D rqstp->rq_resp; =20 - dprintk("nfsd: REMOVE %s %.*s\n", SVCFH_fmt(&argp->fh), - argp->len, argp->name); - /* Unlink. -SIFDIR means file must not be a directory */ resp->status =3D nfsd_unlink(rqstp, &argp->fh, -S_IFDIR, argp->name, argp->len); @@ -565,8 +562,6 @@ nfsd_proc_rmdir(struct svc_rqst *rqstp) struct nfsd_diropargs *argp =3D rqstp->rq_argp; struct nfsd_stat *resp =3D rqstp->rq_resp; =20 - dprintk("nfsd: RMDIR %s %.*s\n", SVCFH_fmt(&argp->fh), argp->len, argp= ->name); - resp->status =3D nfsd_unlink(rqstp, &argp->fh, S_IFDIR, argp->name, argp->len); fh_put(&argp->fh); --=20 2.49.0 From nobody Wed Feb 11 23:32:21 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18E3327D763; Sat, 3 May 2025 15:12:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285121; cv=none; b=KfyxEMskm+tgsHx3zJLNX9nxSWg5wdtj6fxhLHHMvqGM6DjLqsVX8xhUFd8PYFaMeQuA/gw4GoTZoMpjPfaEmuu1b9hVduP0rAFkB9YC/Xo6A+moafPfmjNNs9hJ8ADzWFrQFa3XYEDsiqS+XqTyMkRWD8C4SIMBVZppl1IpJEo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285121; c=relaxed/simple; bh=I5ksN16z2qMg7kLeB7FdmujQ+I2owXUThNiVGSp0OqU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bnG1op78o8IroJioZYr93LMWmwm5QbRruiIdBUje0QltLWEmbp2zyB6ayYI8xKPHXs3sNcwOoB/XbffjIvWwcu8yLcrxdSBnfHuShymX7PytK1fznI/MIsRtNDB6oWXvUfD8qw8ANuG8UQiDkyOWGmgJfukdCKCVHoDgN8Hsq/o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mCA0mZfG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mCA0mZfG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA283C4CEE7; Sat, 3 May 2025 15:11:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746285120; bh=I5ksN16z2qMg7kLeB7FdmujQ+I2owXUThNiVGSp0OqU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=mCA0mZfGUOjv3Vlr+ctxXOo42xZ/YQGihaJY+iidCpbWWAP4SySm5dtCEgY5RA7RA o++IuzNO0wt0XelVsxeiKrZnbMomnuo9yNNqF5HXzT646Lhn1q4J1e8e5QihKLUDch pZYPYGo72/Wnt32M9YyRxhDTVckwEQabr6qNpu8wFP+E5FGrjrqy5gXqgFxEPAL2aE Q8oyG2y1xs2mWRhRATMlb8y8735lDTVmZEif/Ie6rKAK57ymdjGcQmDIuQ+kkPF1l/ bKraofh+9BLTSnr08MBx6moWIZ2/+VvFln6GVfVvnfgRlQV7PSmuvW/suUEYMpPdsJ K/ezBUiKCtNig== From: Jeff Layton Date: Sat, 03 May 2025 11:11:31 -0400 Subject: [PATCH v3 15/17] nfsd: remove dprintks for v2/3 RENAME events Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250503-nfsd-tracepoints-v3-15-d89f445969af@kernel.org> References: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> In-Reply-To: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> To: Chuck Lever , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , NeilBrown Cc: Sargun Dillon , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1600; i=jlayton@kernel.org; h=from:subject:message-id; bh=I5ksN16z2qMg7kLeB7FdmujQ+I2owXUThNiVGSp0OqU=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBoFjIvcsygpD0fBNaSx3WTU3Hijv8bvcNsWVeIh wbCp77yl+KJAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaBYyLwAKCRAADmhBGVaC FVJxEACAdW3sk4+V/2/R+1+2AUNQlykOn47eli1o1z4Nfe7kTHfDDZy0mcYZ/VeNzynG7a/+yC0 DdUy74DykkigeJwF0Rxef03b9IXcEaPcTD+omsXsLPCOJ3xXF3gyr2ShaP6nAuHMblbAEvUfycj 2QStCNlMTZx03pY1ArDZgkeOL0SfDuEpM7a4N+uK8oPF3qKWYV0gtOwtHNamT3Z+MbCWqrErWg7 BQBiq5p3PJK+6+tqUpNZT/m/OKZ0pHrsOCzrftkM+FPdd7c/nQ9pmyh9tu6Xfpzf5O5HlcFjvY8 NM52lWVgK8mpY7tt1ed/BF+mUvUOL3hgyJzFc6ek5DXN19ai3Ay/5WBpLtDTk2TnXzf2wn+vpR4 wlOCwHRKnXr9faM/gWH9nLevd0KkXoKDHBs0KUwYQgAqTxqBCkinwv2J27UsZR7HF3qFa9m4Gmy +AJUHJ2xN8vKOOq1AQuJcPyQmF7Fkc7b2Y2MJO9KarhlTfti5F5bvIpWraM0WueyTYbrgo9a+Y5 XzO4zfT/qJAwF5BMEP7hDlwQ73bf6JOIKyFqp/KFwMLc1PXDL/bvQO54sfAWqb49huBiv/qnprg XFX4dskFFuTcRb4dti4J+KZcY1VtTpovDUVc4Mt36guchMRGOEy+i11zqdzFelDFQi/53w1tJ10 NZlsDheRqi1issQ== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 Signed-off-by: Jeff Layton --- fs/nfsd/nfs3proc.c | 9 --------- fs/nfsd/nfsproc.c | 5 ----- 2 files changed, 14 deletions(-) diff --git a/fs/nfsd/nfs3proc.c b/fs/nfsd/nfs3proc.c index fca65adc43d3b70323938ff8a595ce7eb0a7ca57..03cbd125b570ce10fb12f9192e0= fcd6622112c5f 100644 --- a/fs/nfsd/nfs3proc.c +++ b/fs/nfsd/nfs3proc.c @@ -526,15 +526,6 @@ nfsd3_proc_rename(struct svc_rqst *rqstp) struct nfsd3_renameargs *argp =3D rqstp->rq_argp; struct nfsd3_renameres *resp =3D rqstp->rq_resp; =20 - dprintk("nfsd: RENAME(3) %s %.*s ->\n", - SVCFH_fmt(&argp->ffh), - argp->flen, - argp->fname); - dprintk("nfsd: -> %s %.*s\n", - SVCFH_fmt(&argp->tfh), - argp->tlen, - argp->tname); - fh_copy(&resp->ffh, &argp->ffh); fh_copy(&resp->tfh, &argp->tfh); resp->status =3D nfsd_rename(rqstp, &resp->ffh, argp->fname, argp->flen, diff --git a/fs/nfsd/nfsproc.c b/fs/nfsd/nfsproc.c index 41011a7f19397a300c5c6b468871a18b9f3fc210..dc6e6bdf7aadf2213322f80844e= 144b833bb1355 100644 --- a/fs/nfsd/nfsproc.c +++ b/fs/nfsd/nfsproc.c @@ -459,11 +459,6 @@ nfsd_proc_rename(struct svc_rqst *rqstp) struct nfsd_renameargs *argp =3D rqstp->rq_argp; struct nfsd_stat *resp =3D rqstp->rq_resp; =20 - dprintk("nfsd: RENAME %s %.*s -> \n", - SVCFH_fmt(&argp->ffh), argp->flen, argp->fname); - dprintk("nfsd: -> %s %.*s\n", - SVCFH_fmt(&argp->tfh), argp->tlen, argp->tname); - resp->status =3D nfsd_rename(rqstp, &argp->ffh, argp->fname, argp->flen, &argp->tfh, argp->tname, argp->tlen); fh_put(&argp->ffh); --=20 2.49.0 From nobody Wed Feb 11 23:32:21 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D40F27E7D7; Sat, 3 May 2025 15:12:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285122; cv=none; b=iGgZ5Fcn2QPdUL4mfHU6Q29LFTzZxinSv1QqDccLgbIqHLkDIKEM12xkBzsds3QuCPfVxYtupVbKFzkMNz+HQWYutuA0Hq4az2N7Qn2GqRhaTdoQXcqmvr8iS07f3DOhLSgTBuSkBoZOZ4OCsZWTbHZYwhJ8GRHHT2GFX0tWJG0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285122; c=relaxed/simple; bh=he+9fVXNuOtw3MdmbZXzuvwAYwDCGWIEewWZiLXQ0gA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Gy216jeLd0DPviYBVQnNxTfw3pkDY8Ch4EE2mO2yxPfN/Z3ujvNdrz+ORVWQqjGKkfn85cwyXrf+vd9X2cZoqp5InWmY+O8ao25Vi5rhaPMr9dLbTGFCg8+W9QSRC0K+6MZywdxA4F+YzfiKPMQMb9p77yGv4YzBve00EOsHBok= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=n6x73rTR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="n6x73rTR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C97E2C4CEE3; Sat, 3 May 2025 15:12:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746285121; bh=he+9fVXNuOtw3MdmbZXzuvwAYwDCGWIEewWZiLXQ0gA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=n6x73rTRL0zR/UqTsGFEQyBdckxdhnnfAMEH47MQXpIXcAtEVP4NaBhGAwdaf/eaz ROoqcQ1kNtTVSOr9a6tXq8cSuW72PboM6WAYWAQf3MI0UNF75b0dTyKzBoK/a4YDII dc4ctQ4HuJAdVUWeR3bdv6vvIn+9VsX19FHM9bte+U5wAGrGylDGMEbuyeN+FP3TGu FstoMH4OgF5f1cq5HA8GiXxCzgXElsRO9f6KgikovVJQbtT8MMUhmU1Bb4488aNwco o48H+5ifouUkTc367pXJbR2s14j51asy8pgB10rqUAjHmy6zdf8I3s1sIi/xgkdy3g T/tJbJ3pmQx7w== From: Jeff Layton Date: Sat, 03 May 2025 11:11:32 -0400 Subject: [PATCH v3 16/17] nfsd: remove legacy READDIR dprintks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250503-nfsd-tracepoints-v3-16-d89f445969af@kernel.org> References: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> In-Reply-To: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> To: Chuck Lever , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , NeilBrown Cc: Sargun Dillon , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1618; i=jlayton@kernel.org; h=from:subject:message-id; bh=he+9fVXNuOtw3MdmbZXzuvwAYwDCGWIEewWZiLXQ0gA=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBoFjIvGURZhy/Sp+tZWUqnA56AEM2hCWOkdZVAZ dWsMGCoP3CJAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaBYyLwAKCRAADmhBGVaC FV+DEACFxqDbWiBoSgSmgDvVQekSR0gG2yJ9s1MKCQ+JXZMmsZIQruw0Lni8EkcvYhiuTHrj2QO F6DxVYmIl/3ZsPqi4Hdg0mHwpJWiFnVz/dWvl4KggQJsgLZkNuR0FX+KSr2qqYLHv1hH4pU6uJD JzWWdBTKutp8u038elqnhHnqcO0h+IkmZ+E6cB4lCQtslYFgxk4a8IxxXHkN6xWJZDgKhyI4GsV zt8HjkYynoRDPQfPl1eHS2mH/SKNz7rW9sXeldbsu+60qbhYmSo1IYN6Lu7059OBzXHzcLCmgnp AvxfaMmVX9EhBaoOZFs5NSf/5mkE7AenxbRj8ajTd4eCJ0poJAEd7rGOE+JmAq4Vp6d4+w7C3v1 pr8976Hz0KA4594YJlo46Tr7RwyKdzFbgHXzJImMD3sv0V3RECQVDeN+fUZbLVEa1kx40dujlhs Wj0zSPBxpC+dzS9brXHhriSkaPsC9AGCM5OsDAjdBs+tWSVfRpEItxTTdmDazUEeV2DfeV7j3wk X4xe+4BpXivDR9Tf0nnnozDXD33GxSk16iQSnUj2+6YpAjXE+vHhgZ+uQ5IsjWBDKc6NmOFkRIa gu1M6bJoQo+QsCwwVpPosNM1SJRb1zvm6lYdty+akhGyMWqA2HxVIGCelFO+YgEWzSk/Qjyh48c 4O//oV6G9HroYUw== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 Signed-off-by: Jeff Layton --- fs/nfsd/nfs3proc.c | 8 -------- fs/nfsd/nfsproc.c | 4 ---- 2 files changed, 12 deletions(-) diff --git a/fs/nfsd/nfs3proc.c b/fs/nfsd/nfs3proc.c index 03cbd125b570ce10fb12f9192e0fcd6622112c5f..5b0b5a00e13062a5e9387431aaf= 5d6a1adfea50f 100644 --- a/fs/nfsd/nfs3proc.c +++ b/fs/nfsd/nfs3proc.c @@ -578,10 +578,6 @@ nfsd3_proc_readdir(struct svc_rqst *rqstp) struct nfsd3_readdirres *resp =3D rqstp->rq_resp; loff_t offset; =20 - dprintk("nfsd: READDIR(3) %s %d bytes at %d\n", - SVCFH_fmt(&argp->fh), - argp->count, (u32) argp->cookie); - nfsd3_init_dirlist_pages(rqstp, resp, argp->count); =20 fh_copy(&resp->fh, &argp->fh); @@ -612,10 +608,6 @@ nfsd3_proc_readdirplus(struct svc_rqst *rqstp) struct nfsd3_readdirres *resp =3D rqstp->rq_resp; loff_t offset; =20 - dprintk("nfsd: READDIR+(3) %s %d bytes at %d\n", - SVCFH_fmt(&argp->fh), - argp->count, (u32) argp->cookie); - nfsd3_init_dirlist_pages(rqstp, resp, argp->count); =20 fh_copy(&resp->fh, &argp->fh); diff --git a/fs/nfsd/nfsproc.c b/fs/nfsd/nfsproc.c index dc6e6bdf7aadf2213322f80844e144b833bb1355..80f3c0c6c63d16c9324c92dca52= c8814d9429bb1 100644 --- a/fs/nfsd/nfsproc.c +++ b/fs/nfsd/nfsproc.c @@ -592,10 +592,6 @@ nfsd_proc_readdir(struct svc_rqst *rqstp) struct nfsd_readdirres *resp =3D rqstp->rq_resp; loff_t offset; =20 - dprintk("nfsd: READDIR %s %d bytes at %d\n", - SVCFH_fmt(&argp->fh), =09 - argp->count, argp->cookie); - nfsd_init_dirlist_pages(rqstp, resp, argp->count); =20 resp->common.err =3D nfs_ok; --=20 2.49.0 From nobody Wed Feb 11 23:32:21 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDF5227E7EF; Sat, 3 May 2025 15:12:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285122; cv=none; b=QY3wBxIGQxJ2y9em/jSC4RXs6zHIP0cbrvcxmzus0wbMwxq/v3n23IrCquJbnm3cyW9pCN0Xh9v8sr0efFALWnh3PX13+4FrD/nIR3EKELbndDDSyAsS2hxstTuO3rBGcZ0od4DyO1xaGZ/qst/OmbynNhsnCOjjsOco+WR/noY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746285122; c=relaxed/simple; bh=PHa//c4vqEnZ0+OPlLXjavzM0fk+wIBSvy6eTxGOhIk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mpMv31FkV8E3PNn1xBz5v7LK+h3mcK3FevDv5ziAL3ivK34DEITH1NpktaGz+uZOOC0/laSEYaaemRo2AYDff/ooK9HfYKvDHBtlVeTOGwu9nyG8a/TQ0r4t/m2NzIcqXJM6aFTWi8+LmrRh5HzUIH5fBuiyUhdELIoyzKBlNdY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=l2FlJqhU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="l2FlJqhU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D960EC4CEE7; Sat, 3 May 2025 15:12:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746285122; bh=PHa//c4vqEnZ0+OPlLXjavzM0fk+wIBSvy6eTxGOhIk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=l2FlJqhUmap0Jq0UgBLqJ+/k2eOsDHUsuuKJf+V2N86nNdzedMdRvCjhLf507wFvX Q74AmADkhNm8fH1xS2bKm3YI/tYxbENu4knl1aoUu/fwtVCCq32hHZKtievggaxqrY laGPdvkwPLPjNnkfPPDaLh6LNtpejcMNr6YH7Y7O25DgZQupQlqRKWikEsxhT9Y9us shEon/kmaxByxrih3AdJclbUhQp33Qiynjz6XnhipbgtkbSbOBqnNMl1UrdkK58Q5d dEiXxxR3CBa8wNyy5Xp8On7fxnzSPh2DNEhIvnkS5V8v6/eA2/Nj1IhK1ghIkHXJt1 Ozlobx4scvHrQ== From: Jeff Layton Date: Sat, 03 May 2025 11:11:33 -0400 Subject: [PATCH v3 17/17] nfsd: remove legacy dprintks from GETATTR and STATFS codepaths Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250503-nfsd-tracepoints-v3-17-d89f445969af@kernel.org> References: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> In-Reply-To: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> To: Chuck Lever , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , NeilBrown Cc: Sargun Dillon , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1906; i=jlayton@kernel.org; h=from:subject:message-id; bh=PHa//c4vqEnZ0+OPlLXjavzM0fk+wIBSvy6eTxGOhIk=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBoFjIvBSerR3sfNO6/8qndS+coEw4nuI1CJHP+P +ZZTaNGRYKJAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaBYyLwAKCRAADmhBGVaC FXzTD/9W6/gR0XuUz7aCZNM5NoEkHTWJG6zFs0keGZX7qPz3TWnyKb224sakNNez6sIR6e4E24g UKUdGZlR4+K5I0LcVm9+UAw0djO2wZkowdMG3U24WRw6ESNEz82gKggI9E6i/4By2QX0f8LVgPA REEOYlXIB+AIwFd6Gn77D/SazpQroSgwAy+p2FP0OiQLxzUPvkgJ/OaZ8CdgB1IayZVOIWKFRsU +C56PvgIYXBtiuLcWEK2M+EOlAc2F3jucrGtiyiqZbHzfrSU1DnGs2bqoma6Fyc7G+c5o0+ql5C uz0CZJoV9Rb6vRbvEJXmC6AX0fZZJXnmv7HrYD8aznLrgxJJFePkpQ3oj07c5/WZJT3NDBR0iLD ytKra3hWjb0Sbxm0cRjuLfgzZJj3BqFaBrVGKhGfwgbqptkiUS0vmULl4PtVNYnW5OAk9O5xS+8 VBW8Bujas4YitYxNwi5ssNd+JcGYPmR1HObKPENVpfm6wzXp3gi7WbSf2ficXW/KiSJ/ofFYaKq pog3aNhGcZwsEHFi7jKLN4oizfNG4FfD3lmnAODNK0gh/FpZXwOFl184iGvlAl+VUyk2nkhYVS4 l9ImNNxDmwRHlUMGajcBZLmbHKk4Byq+Ct50nPdYHGmMcA51g/nE8r3fEFs6ciRF8hDEC3ZbRFT s7iGID4HN24wiMQ== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 Signed-off-by: Jeff Layton --- fs/nfsd/nfs3proc.c | 6 ------ fs/nfsd/nfsproc.c | 4 ---- 2 files changed, 10 deletions(-) diff --git a/fs/nfsd/nfs3proc.c b/fs/nfsd/nfs3proc.c index 5b0b5a00e13062a5e9387431aaf5d6a1adfea50f..59b1987a1e16f5dad2efe627e8c= 81e654edc1413 100644 --- a/fs/nfsd/nfs3proc.c +++ b/fs/nfsd/nfs3proc.c @@ -72,9 +72,6 @@ nfsd3_proc_getattr(struct svc_rqst *rqstp) =20 trace_nfsd_vfs_getattr(rqstp, &argp->fh); =20 - dprintk("nfsd: GETATTR(3) %s\n", - SVCFH_fmt(&argp->fh)); - fh_copy(&resp->fh, &argp->fh); resp->status =3D fh_verify(rqstp, &resp->fh, 0, NFSD_MAY_NOP | NFSD_MAY_BYPASS_GSS_ON_ROOT); @@ -647,9 +644,6 @@ nfsd3_proc_fsstat(struct svc_rqst *rqstp) struct nfsd_fhandle *argp =3D rqstp->rq_argp; struct nfsd3_fsstatres *resp =3D rqstp->rq_resp; =20 - dprintk("nfsd: FSSTAT(3) %s\n", - SVCFH_fmt(&argp->fh)); - resp->status =3D nfsd_statfs(rqstp, &argp->fh, &resp->stats, 0); fh_put(&argp->fh); resp->status =3D nfsd3_map_status(resp->status); diff --git a/fs/nfsd/nfsproc.c b/fs/nfsd/nfsproc.c index 80f3c0c6c63d16c9324c92dca52c8814d9429bb1..1d1825cc3eda96b678dcb1fee62= fbe84a144c9e2 100644 --- a/fs/nfsd/nfsproc.c +++ b/fs/nfsd/nfsproc.c @@ -57,8 +57,6 @@ nfsd_proc_getattr(struct svc_rqst *rqstp) =20 trace_nfsd_vfs_getattr(rqstp, &argp->fh); =20 - dprintk("nfsd: GETATTR %s\n", SVCFH_fmt(&argp->fh)); - fh_copy(&resp->fh, &argp->fh); resp->status =3D fh_verify(rqstp, &resp->fh, 0, NFSD_MAY_NOP | NFSD_MAY_BYPASS_GSS_ON_ROOT); @@ -615,8 +613,6 @@ nfsd_proc_statfs(struct svc_rqst *rqstp) struct nfsd_fhandle *argp =3D rqstp->rq_argp; struct nfsd_statfsres *resp =3D rqstp->rq_resp; =20 - dprintk("nfsd: STATFS %s\n", SVCFH_fmt(&argp->fh)); - resp->status =3D nfsd_statfs(rqstp, &argp->fh, &resp->stats, NFSD_MAY_BYPASS_GSS_ON_ROOT); fh_put(&argp->fh); --=20 2.49.0