From nobody Tue Feb 10 12:42:17 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0BFF19D081; Fri, 2 May 2025 03:11:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746155516; cv=none; b=P9aGopzCYqjgaJCEBDcjuTX3ptUxhQ40FoAy+MgBCuqPhhloY+NlHVLwz4x/nH7X/dKlapgqKJ2uQQstsOfNQglnnkINc3KfDa22Ff1rJm9r4haSwviviMIXlxCK3a3DMHaf/JSOsPaekUtwkHvRfMZo7t03kHPnXshKG5SseBo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746155516; c=relaxed/simple; bh=eSdXXAWq3w74a3UU2Z1Mn1ZzWT2xvey6y+i6sE+p2ok=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=smMq7d5AA7/wuudR6V67MPeHj5Mf5BYMAFxgT8LkH4Z2MDeOKRUDX/YJUF3iwMZ6Lkc2u4mQ7UuL9uNJ1epqaeion1DJrVPHG1G3Pagn1U8udvy8BOyz/1i7txaMi5bgHkYTevkvHj555j4WqNyjUcB+Atw4Zk+MDbLEPkjv+9E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=pcAEwAbM; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="pcAEwAbM" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5421MwQV010097; Fri, 2 May 2025 03:11:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=0byjgR6j2kugxIdmOZ7/ARHI qoQHzdqvKztTBOr/W4Y=; b=pcAEwAbMNIDhORYGd8L8p7SwBoQNoa9/4eKGmkDL Nv1suexkaPJUeA5KFCYnTUqApj90T2ID6e46EbjW3WCqzxBhsmrC4VFuPbTlo1sB l3TIuMAEuQ51WfZ+NHAmIgEA8skm5O4J4KKeUOauDzimAwcClX7vG7tM+8p84JWs 6qqlHvjAIem7azPdG9lcewFNGxOXzSb8AMGsP4ljOBiZQoPLIc5bntLsKrZI/IAq Nh6vTEJ5zHz65XV1lbrPGpg/ZsAE4StUi9/1qwfTWH4hOzkFQyLS7BtNkm0p+ujF 2jZJnuYV9TQaCPdFfoLigZt4PlSkLL448LzVLKWaCLuDXg== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46b6u9y0bj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 02 May 2025 03:11:50 +0000 (GMT) Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA05.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 5423BnSk014278 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 2 May 2025 03:11:49 GMT Received: from hu-ptalari-hyd.qualcomm.com (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 1 May 2025 20:11:42 -0700 From: Praveen Talari To: Greg Kroah-Hartman , Jiri Slaby , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Viresh Kumar , Nishanth Menon , Stephen Boyd , "Rafael J. Wysocki" , Praveen Talari , , , , , CC: , , , , , , Subject: [PATCH v3 8/9] serial: qcom-geni: Enable PM runtime for serial driver Date: Fri, 2 May 2025 08:40:17 +0530 Message-ID: <20250502031018.1292-9-quic_ptalari@quicinc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250502031018.1292-1-quic_ptalari@quicinc.com> References: <20250502031018.1292-1-quic_ptalari@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: x6GQF1oLw-f44PIVycctP_CZCsWZUzPu X-Proofpoint-ORIG-GUID: x6GQF1oLw-f44PIVycctP_CZCsWZUzPu X-Authority-Analysis: v=2.4 cv=UZZRSLSN c=1 sm=1 tr=0 ts=681437f6 cx=c_pps a=JYp8KDb2vCoCEuGobkYCKw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=GEpy-HfZoHoA:10 a=dt9VzEwgFbYA:10 a=COk6AnOGAAAA:8 a=6AnO7isMBx9hvYDJyqkA:9 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTAyMDAyMSBTYWx0ZWRfX+0WlFGzEQUeJ kVCV9DInwda1wuwlr3RJQCkuw0D6WE86NubFspnoQ6aC28Mgj35pu3n6Gi/R2K9F7vu8tqq01B1 ru1ZuWB6vxO7YOpmRSwMPB8+96lUkfWK70mj24ytly3iBlpK26f53oCXxCrsR1glLYZJFm3YZ8J TuTcds/zuA+xxuX3Lnnxt+pcouyM5egz24n1erLwmBbo6AIbR5FveBeBiu4YDIikWUdzhjiN7+3 l3e37Io5deb+PIHDBHfPX3lNJf5bQveIJc15WjrOSubfmbj5HSyM3bbNBwTzSYLn7lunSwWRsfo OpetWNYPI/CSgc2Sbeg27RMjnb8DAqJs0xxFcVMguqZnrGw8XzZQsDk+Fvjq+PlmwPOMwlfAYYA 8uq6ShHQTHHWXRZ3836d5A3QPnS9F0KBEfHezkMjUzYGqS8QkbXSIdmBBg1aomHbjZltuFwU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-01_06,2025-04-24_02,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 mlxlogscore=999 spamscore=0 priorityscore=1501 impostorscore=0 mlxscore=0 malwarescore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2505020021 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add Power Management (PM) runtime support to Qualcomm GENI serial driver. Introduce necessary callbacks and updates to ensure seamless transitions between power states, enhancing overall power efficiency. Signed-off-by: Praveen Talari --- drivers/tty/serial/qcom_geni_serial.c | 33 +++++++++++++++++++++++---- 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qco= m_geni_serial.c index 60afee3884a6..9d698c354510 100644 --- a/drivers/tty/serial/qcom_geni_serial.c +++ b/drivers/tty/serial/qcom_geni_serial.c @@ -1686,10 +1686,10 @@ static void qcom_geni_serial_pm(struct uart_port *u= port, old_state =3D UART_PM_STATE_OFF; =20 if (new_state =3D=3D UART_PM_STATE_ON && old_state =3D=3D UART_PM_STATE_O= FF) - geni_serial_resources_on(uport); + pm_runtime_resume_and_get(uport->dev); else if (new_state =3D=3D UART_PM_STATE_OFF && old_state =3D=3D UART_PM_STATE_ON) - geni_serial_resources_off(uport); + pm_runtime_put_sync(uport->dev); =20 } =20 @@ -1827,9 +1827,11 @@ static int qcom_geni_serial_probe(struct platform_de= vice *pdev) return ret; } =20 + pm_runtime_enable(port->se.dev); + ret =3D uart_add_one_port(drv, uport); if (ret) - return ret; + goto error; =20 if (port->wakeup_irq > 0) { device_init_wakeup(&pdev->dev, true); @@ -1839,11 +1841,15 @@ static int qcom_geni_serial_probe(struct platform_d= evice *pdev) device_init_wakeup(&pdev->dev, false); ida_free(&port_ida, uport->line); uart_remove_one_port(drv, uport); - return ret; + goto error; } } =20 return 0; + +error: + pm_runtime_disable(port->se.dev); + return ret; } =20 static void qcom_geni_serial_remove(struct platform_device *pdev) @@ -1855,9 +1861,26 @@ static void qcom_geni_serial_remove(struct platform_= device *pdev) dev_pm_clear_wake_irq(&pdev->dev); device_init_wakeup(&pdev->dev, false); ida_free(&port_ida, uport->line); + pm_runtime_disable(port->se.dev); uart_remove_one_port(drv, &port->uport); } =20 +static int qcom_geni_serial_runtime_suspend(struct device *dev) +{ + struct qcom_geni_serial_port *port =3D dev_get_drvdata(dev); + struct uart_port *uport =3D &port->uport; + + return geni_serial_resources_off(uport); +}; + +static int qcom_geni_serial_runtime_resume(struct device *dev) +{ + struct qcom_geni_serial_port *port =3D dev_get_drvdata(dev); + struct uart_port *uport =3D &port->uport; + + return geni_serial_resources_on(uport); +}; + static int qcom_geni_serial_suspend(struct device *dev) { struct qcom_geni_serial_port *port =3D dev_get_drvdata(dev); @@ -1901,6 +1924,8 @@ static const struct qcom_geni_device_data qcom_geni_u= art_data =3D { }; =20 static const struct dev_pm_ops qcom_geni_serial_pm_ops =3D { + SET_RUNTIME_PM_OPS(qcom_geni_serial_runtime_suspend, + qcom_geni_serial_runtime_resume, NULL) SYSTEM_SLEEP_PM_OPS(qcom_geni_serial_suspend, qcom_geni_serial_resume) }; =20 --=20 2.17.1