From nobody Fri Dec 19 07:15:50 2025 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29E82244697 for ; Fri, 2 May 2025 08:59:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746176397; cv=none; b=WcwwUhb/93+SW6aL520Izs1CbpyQwUsMl8sdhVwUFzqPki7yxKtkwh9cbrGeRhTgviP8OkxIMraRur+ElskjCxWd2U9cvIcPCxZ/QejN1gOloQw4B/TZ6As79/IM8fM8Czw6Ia6BetJbKn3ro1uJltOauJr1PFCV7+r+08pvx8A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746176397; c=relaxed/simple; bh=GewjN5JZ5QEnNVyIalTXmzdJfxf0mZMpZbF1p7s74so=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ovs8NxmiV2cCq8ULH1mbp/Dj6ObKAOnwbYI2RwNusR/ehKMxrgZQJXv3VFYtZwkVHCqEAmaKoOYnt/hLnl5R/C4qYbPBO84Oj44NOHbko5rz+LcwFWy9lcSGyOz3NnL8IYmbO0gNgnD5aqZ7jCDR8D3ybL1XiL6HKMEPgAq0WZs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=REuEnF2V; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="REuEnF2V" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-39c1ef4ae3aso1029623f8f.1 for ; Fri, 02 May 2025 01:59:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1746176394; x=1746781194; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7VQVpAhnQOcCRYJ0IuR7EAkGj4zu20WsPxA2gwCBLx8=; b=REuEnF2VypvMkvCsuQvZLIVtpwEXX5V0zZeg/7JuTVidAnc88naKfiLWQ+Ie3zPwEt a23z7OBwn1bZLdwB5prwjpIE0xwJHsLSz+NriKN1niajVBNvK1Dnb4RB2cTuEfqyMYqd zXchpMNyTaipR0qwHaMFXQRrLvsiulEG8ytZ5gE5uRJFfuLmxqlUmjKid6o9QgPHDNwZ 91+1bjxFX40wqzw4XyRMHjy8R35osChnN0YJ2N1uPlOtf098gcc5SqOCR14bQ7X6Zses pOpu6gvbF0GM3Gvy305yloHcTsdYyqOHWlgdQoOV8NQjYe0WqWXPPc6lewoXS/R4dV83 GpMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746176394; x=1746781194; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7VQVpAhnQOcCRYJ0IuR7EAkGj4zu20WsPxA2gwCBLx8=; b=EIFqtVqmh1eHyY/nYzTJQR8B7lMXF2iXPzj8BE+UUUwP7ODdVb6UdVQgZwnrzrK3b9 P/pEE7j9DoQcz1tbN6BVFgXU/LPDPw6su1nxAd/oDKcvG/gh58w8obvPRqEmBAzLVkEj TE+0pGwtJV7XOVbcyJTgB0aXVCto7OEDJoS1Dys0HRXzXnbsVaeLpNQd197/pimmi0Mk o9A+mf2MBWGUrmDMpPcpI76PhqbdmYtJXXvwDEgQqZ1edBxx2sy/uV/Og9nogWi7JOG+ pG1z1e3YuBWhTBKEQy/Hnp3WsVuC7872n+aaF3rZGs2KsYfP0GSLgb7dFQdM1nk6GlSe IM1A== X-Forwarded-Encrypted: i=1; AJvYcCXtYHZ3zqVz0p/LrfBjEqT+/KIR7xWPdk2ySMsMjRxOxb0bww7nAgwcfJlPv7PYup0c9XEhkgy+9aopACQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxNiK5sdieyI3nZRTzjwJHvhy26dCDlKfMkhpHLIgyTJW9xz8Gl LE4DwfK10gg0iDcvXT+uRwOX+fIpV7HCSbWB0EMSFbuEjAXDZa/XUQDvRkgaoMw= X-Gm-Gg: ASbGncuhYaLqy3/fqf4do/fSoLLaRXozWbqwiCWesEz79r4XlTtdIXxFnRZG8nDsWD9 rxFaHoJLkWkRqlJEu+ZkOrPswkVHDmZfIk+TkUVNhqr9Ij6C5J/MhvdzUztnjhjF6WwThyFDxiH fM12np2i4tN6O8gygUREvw0MgpbDloVfxVMYQV8UAXgnnoeqURC2rPyR/zfBxazEgLKMvYsnJzB YS9dG6EetP0miOgPBs6+W1EbAwSIPkOdphSHqo3/bnvurHqOCiWMbPJm/H9BrCF2Pyu1TWJfFa2 8Dr5B/bUwFUQhbjjE3f097rk3T5ON6JaefU9iwhPadR9OQ== X-Google-Smtp-Source: AGHT+IHQBxxYw4TPkCVhivNKZQXWIM25Cnsq2fJIJFroZbvmM5OL56pj85WS8b3cNucOQHIYyCOoQw== X-Received: by 2002:a05:6000:40c9:b0:391:b93:c971 with SMTP id ffacd0b85a97d-3a094058683mr4162100f8f.20.1746176394370; Fri, 02 May 2025 01:59:54 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:f280:a08c:3f15:ae3e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a099b17017sm1552055f8f.92.2025.05.02.01.59.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 May 2025 01:59:53 -0700 (PDT) From: Bartosz Golaszewski Date: Fri, 02 May 2025 10:59:49 +0200 Subject: [PATCH v2 3/5] powerpc: 44x/gpio: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250502-gpiochip-set-rv-powerpc-v2-3-488e43e325bf@linaro.org> References: <20250502-gpiochip-set-rv-powerpc-v2-0-488e43e325bf@linaro.org> In-Reply-To: <20250502-gpiochip-set-rv-powerpc-v2-0-488e43e325bf@linaro.org> To: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Linus Walleij , Bartosz Golaszewski , Anatolij Gustschin Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1671; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=E7Ff3/1EcYz2Nw6QSP2p8LNuROZlM9cH/LUaLu34ItI=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoFImFaUc3gwNuye/ggncACVXaJIT/sGhSnQxG1 k8BocsYj+eJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaBSJhQAKCRARpy6gFHHX cuKeEAClIackuAKdOU+yl0nzsAvzc25o+JND+09tQcnbWh3AsifpuV7rlyzUrzurd+n71xUXbBh awXQhZPFM03p2pHjU8sSoe03IWWl/P/iUQFGfK3UFx/dFs6zbSSmvCrUQR43C2zLhN8WmBOwGpD vOa4MEAW+pXxdy/M2U8w2OQDBYIknSvZr8q+QNpm3v2aTlKJkXmxQ4s1m8HnsYd/KxgQ5lZ/ooB RgdkMP1NOrVNSASt0s+QJVYySccm/6xFXSgfhZPF4QN87mFgRnVxEW6ZMOzJ4SENiWPrKxLGmpz tQpB+JIWIs5aOa4fuWDe98rfWqUpHnxJ0jWKMmb1rdmjR8R4QYQq3ygwJXhP6HSxJs0om1niN4/ SrrDwUSyhNNIp4EicjN3o15Sj8wJ6pIbQ5oDNgSiiiQNq8kTSa6apDB9p/SbZPO1IYe7AgjPtUR Finp1+Ml4Xqh45uqDF/rpvHaIdjVuAorJXbcNbLRYJ6MW8cPj6se5CVDixKrvgYH+3oC8MDkxAQ wHyyy/EMl2ZtLXCot4mdnb8Da5Nn/0zXT8j0syLnFlsgoEASpOqTT1V2/RYp15J+Oc412XmMnrP 4qvzerCJIicUdBfX65VXU1iM2RR5zud6VbTmAbqQvm7x4RZyH497DL72cGrNKnipgTI3q1iTaxs RutDOCWUZ+MhTSQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Reviewed-by: Linus Walleij Reviewed-by: Christophe Leroy Signed-off-by: Bartosz Golaszewski --- arch/powerpc/platforms/44x/gpio.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/44x/gpio.c b/arch/powerpc/platforms/44x= /gpio.c index e5f2319e5cbe2..d540e261d85aa 100644 --- a/arch/powerpc/platforms/44x/gpio.c +++ b/arch/powerpc/platforms/44x/gpio.c @@ -75,8 +75,7 @@ __ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio= , int val) clrbits32(®s->or, GPIO_MASK(gpio)); } =20 -static void -ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val) +static int ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio, int va= l) { struct ppc4xx_gpio_chip *chip =3D gpiochip_get_data(gc); unsigned long flags; @@ -88,6 +87,8 @@ ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio, = int val) spin_unlock_irqrestore(&chip->lock, flags); =20 pr_debug("%s: gpio: %d val: %d\n", __func__, gpio, val); + + return 0; } =20 static int ppc4xx_gpio_dir_in(struct gpio_chip *gc, unsigned int gpio) @@ -179,7 +180,7 @@ static int __init ppc4xx_add_gpiochips(void) gc->direction_input =3D ppc4xx_gpio_dir_in; gc->direction_output =3D ppc4xx_gpio_dir_out; gc->get =3D ppc4xx_gpio_get; - gc->set =3D ppc4xx_gpio_set; + gc->set_rv =3D ppc4xx_gpio_set; =20 ret =3D of_mm_gpiochip_add_data(np, mm_gc, ppc4xx_gc); if (ret) --=20 2.45.2