From nobody Thu Dec 18 23:21:32 2025 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB9BB22D7BD for ; Fri, 2 May 2025 08:59:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746176396; cv=none; b=EqMpVfYv9bYLZ5513+osJzuPVt+7rcDdzeiutpc6mrw//y0Lu3pafGf4yfxm9C7zmoibYD3oltiPGJs1SjBM5WlgiXPu9U8Uy8O17JMa7T7fMAH1pYyltseo8Qg7nQMzkyXTB5VGy1JccFNpcD2AbW0TTn8XQ2V3Mhca/w6WkKs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746176396; c=relaxed/simple; bh=L7vO01waMbRPHY4cHTagsznknnmWs3Tw8o+y1YlXx0s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BeG3b1e+iqNw9cHRjXeiRMde/DI38eq1UXm8aXqTp8qeqoDCpcSrmAZdqFtFKJslhA6T67KqRYnftqZbJDiu0mzDbhyXEkTdJD8IH/W1KlVKZA42QxPipUvbn16fvA/TK9bV1yj4gEDZXGn3ajfIjJ6CVFIYLqVJFph5aPp1P4I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=u9byflc1; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="u9byflc1" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-39c1ef4acf2so1254315f8f.0 for ; Fri, 02 May 2025 01:59:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1746176393; x=1746781193; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+ctFdlWFJvdPBkAi1+fMGSkHP97NEJ9/Q0ezwvzkbus=; b=u9byflc11xgdqRwpcfjJ6WBP0Wbr1kDAw2d/FF1MlnZHQKO0s03B+02hjIU4HJRd0S +GTPZIfvcMu35DPMf89Cd2r7DXqZuBMa+AWRPKmnBKAXaR9j/uCLjhiBH6NvjueujpnG Yrl/HmvhAc0DIseGZqcYsVO7sYoLVa5j2ZvZwommfjuydUREyo8/8fw8zEM8nFpPlN1P TDRosZueAMXfRZUCLCMmT0f/1vv7rtBCyAnr+9t0daq+TW/sKSAvofll/98jo7MaoSAc bxWBgttzN89/LKZOrOt9JlaAPd0d6RGu03ErPVpNvPxSzqFtOz9sJrDakF8FZwBBfOWy SOTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746176393; x=1746781193; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+ctFdlWFJvdPBkAi1+fMGSkHP97NEJ9/Q0ezwvzkbus=; b=CzVxyJ0Ij39XAdtZYcN9z7X68LuCMgH51MSvjGgjwZunsR0ISguHBqbcSEIm+RUXgE IYOHzLyXnCZVAOVjnEjBLePdKcvyGK7Djt9Nx+rsQ8SpKkDYUB90XN5TR4lInrIUejcf NyEZCo6GVTb6yUTueRzNoORY6MNaKDCkTCSG8rC9ih8ufxxx+l6zn8FP3czsov7w9sR2 +ZmDijwt6IdKtKbzxlMf1uXpPRcL2WGxYjQu3Eu/LC0LFU3e3KBk1VqkuZati2gSenJp eWwyFMYdgNS8i7jnrrpW3ssVs/clw73b2NK3TQH6qpSQhGV+aIvBHl7L0Hy2v6/9uVKo vTIA== X-Forwarded-Encrypted: i=1; AJvYcCU5t+DoCOS4a7l8QPFOqij8nYzTdqyA2ZLZ1vmckGW2meoRGrNqH8J1+K73QdQc14sLgIeb8sqrbtOoY3U=@vger.kernel.org X-Gm-Message-State: AOJu0YzKrn5QkRW8P/5b7hKOsPgJ5mm1ZzZgAC/V8Qat6SEixfsZdlMv iICUUe+3htRQ6ATudKgqa4BkVUXCsE7sG7tZ6NGcYIO/ipD/ibvclDuIH3Y9Cp4= X-Gm-Gg: ASbGncsExMb+Uv2uAMgRJuUYAeevBQLGK924uQT/bxu3LtwYV+aG1DyYBn/VOTa2abj pxd2CLykDARaU2RgJUA4eRjjwFSR/29ZuFyUcS7cEqnawy1gNRt5hQPdlZWAQxJfc7yBK5//8A6 il2Sz5l8zGmc31T92pUfro3KGoV4/xP5sq6O4z1iKeTKdyBSCwEuAqW++SnFdfCB92el/YJnbt0 kvKmNTLArGIS35aretiPV5kVc54Wxv3nstau6piyPgGhAHnTP4H3oy9zsLS00sJf7ieWml40d08 8aygeH8FcRe6R2LDiTfzdiDrFXWm+F1ah7s= X-Google-Smtp-Source: AGHT+IEEQYczV66unx0kPiJW+nrPEeBzFXGbGRagIzFOWe+h/OKFXs1Aax+0KalaeWUyKNcJAnCWjA== X-Received: by 2002:a05:6000:1a8c:b0:3a0:8492:e493 with SMTP id ffacd0b85a97d-3a099ad2772mr1416698f8f.6.1746176392472; Fri, 02 May 2025 01:59:52 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:f280:a08c:3f15:ae3e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a099b17017sm1552055f8f.92.2025.05.02.01.59.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 May 2025 01:59:51 -0700 (PDT) From: Bartosz Golaszewski Date: Fri, 02 May 2025 10:59:47 +0200 Subject: [PATCH v2 1/5] powerpc: sysdev/gpio: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250502-gpiochip-set-rv-powerpc-v2-1-488e43e325bf@linaro.org> References: <20250502-gpiochip-set-rv-powerpc-v2-0-488e43e325bf@linaro.org> In-Reply-To: <20250502-gpiochip-set-rv-powerpc-v2-0-488e43e325bf@linaro.org> To: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Linus Walleij , Bartosz Golaszewski , Anatolij Gustschin Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1700; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=unub8yX667IH17idZRyuiKjEw23zeZPtyjlcM+1WGx8=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoFImEg2NIMAwbx3dl41TeaZx3sbL3vCBOIk0Gn +tM9lO2DySJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaBSJhAAKCRARpy6gFHHX clAnEADEb6k81gHxYU30oVcF3o5XKWH5s1upUtZc76+5BwdbhRCyIYBnQ/QP3vpRCFKdaOvmHG5 lVmTUY4I2EI68GzfZWu1nUzlGDpmHxrvFZUvrFJGy6L9vtcJARterMUF0V9Eye77Tp47QNN9Oyt AFchM5NCrOcqS2FGeBjEj+H5NBVMniaSOl1ANPLPGoUZgi0knV0q8VWAA9XIQagdBiVhePe4O9U pv0CSeY9toXhZBTawevU+L9OrVxsuraffDTIm5T8I/sdU808agYCxUb81VhEX4Xeg2VU2vbD19C wSb6b7QWwBxBbDm/9JDfM38Jdb3u5PqltOJuXIbFirTdrwuJbex9CoTrvSlLuyhVXLMDx7IriGL gmdX73bMQ1DyKDx4BPe6suEFXTUiVDG9xnv592SZHsYwZqi0TnXO2XpOHk56NMwcuIHi9DVhuQ5 wRqNyGjx5EzAwS+A9tdt8KtTokNSfTjOqYWJBZMnmbdX4wUIZd9uAuRzeCJQ3n5x5ukITNUHY83 +31cKS/MQfRt9UPk7n68YwazZrVqecoEevbiScE3zb4sbnKCZlGC+XEPG4rjMGBfbApTO8Z7Eoh kr54j18umaXDf6u0GTtw8EXpg1uFAgA1x5stvQMydbMTOdSOOXExCNO/HlvlkNjzyEGCnt/UgpA rr6ajzkeTTumccg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Reviewed-by: Linus Walleij Reviewed-by: Christophe Leroy Signed-off-by: Bartosz Golaszewski --- arch/powerpc/sysdev/cpm_common.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/sysdev/cpm_common.c b/arch/powerpc/sysdev/cpm_com= mon.c index 47db732981a8b..e22fc638dbc7c 100644 --- a/arch/powerpc/sysdev/cpm_common.c +++ b/arch/powerpc/sysdev/cpm_common.c @@ -138,7 +138,7 @@ static void __cpm2_gpio32_set(struct of_mm_gpio_chip *m= m_gc, u32 pin_mask, out_be32(&iop->dat, cpm2_gc->cpdata); } =20 -static void cpm2_gpio32_set(struct gpio_chip *gc, unsigned int gpio, int v= alue) +static int cpm2_gpio32_set(struct gpio_chip *gc, unsigned int gpio, int va= lue) { struct of_mm_gpio_chip *mm_gc =3D to_of_mm_gpio_chip(gc); struct cpm2_gpio32_chip *cpm2_gc =3D gpiochip_get_data(gc); @@ -150,6 +150,8 @@ static void cpm2_gpio32_set(struct gpio_chip *gc, unsig= ned int gpio, int value) __cpm2_gpio32_set(mm_gc, pin_mask, value); =20 spin_unlock_irqrestore(&cpm2_gc->lock, flags); + + return 0; } =20 static int cpm2_gpio32_dir_out(struct gpio_chip *gc, unsigned int gpio, in= t val) @@ -208,7 +210,7 @@ int cpm2_gpiochip_add32(struct device *dev) gc->direction_input =3D cpm2_gpio32_dir_in; gc->direction_output =3D cpm2_gpio32_dir_out; gc->get =3D cpm2_gpio32_get; - gc->set =3D cpm2_gpio32_set; + gc->set_rv =3D cpm2_gpio32_set; gc->parent =3D dev; gc->owner =3D THIS_MODULE; =20 --=20 2.45.2 From nobody Thu Dec 18 23:21:32 2025 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CB62244676 for ; Fri, 2 May 2025 08:59:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746176397; cv=none; b=pKHkGsPdrXH7u1Y5H2USsjRtXCJfouVftsYT59aNpk9nYYQhEi6PHqprSayozZcmp7W5YZ4BOlX1OGXKtJZPHUkgk72Rea9w8+X/zp97MgIzOaj6Xqyk+MQBBhUG5XuvrvplD2TuEvKIomGc5q+Alpr4IdkbMcAc3XrnqgcCGqY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746176397; c=relaxed/simple; bh=0rvyNRmAVs22sEiy/QOTFVu+897s6keqDCf6txYk6JI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YC0JDl9FSdxKm9/3+H/U0u1L7M3ynTlwFeQ5i8bcGQ2VZy1FjM8mjmFAda9l31tXsnVaTHR+OyTlcZJnPWwLHdmir9nZOl2GJYw0ErNKdPfeBh8XBbaF1RKrQsfXf4MjScH33BwoaO7AuU7I7vXj8kpCO9w2mtaaTgO1c8sV6Ls= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=PCFKe6fc; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="PCFKe6fc" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3912fdddf8fso1703338f8f.1 for ; Fri, 02 May 2025 01:59:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1746176393; x=1746781193; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EN+18LA857SctMCPq7PChnoB5bYuEFe9lArdedXnm4g=; b=PCFKe6fcmGYcvL0JzflxqYFd9SH4b7F06hG39DcUAmwgJWlnBozTdipnUPjmNMmvFw 4NJde2XmNVx0j8IGYaecNFWgGAL1WQJv0a6JOp6d4WDNfo2K5cc5UonwF35TkZh+ix/f Y0vE048ZWfjEpoE2NNYiqarUaM1YiEt2HoM3rWSG3r8IDsyfXI2aIQpgc431VthYKqBL aDm9JOqRNJouywOx6hkMTkwoNarjioTdBKnNolybDLLDNvFaHnFzH25Y7EJu62vwedYP 5z6UroZtehJreQkXHcpHfMTQnelNH41NomHh9q4lHOmGnPxkMXF9zkIrWwyPBb0iOiMR ImJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746176393; x=1746781193; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EN+18LA857SctMCPq7PChnoB5bYuEFe9lArdedXnm4g=; b=SDilmxBB8C9Ddkjewkur2Qylsj++3gp2b1uH3JLHacBHWrADg4jdEmcuMNnUKcH6K/ I2CKrIs777hEeK1+vgJv/nGHbGQcCJ9nTG0wKo5hwqszseo1wBaz6bhMMv+4mAZd2CIj VukT+rBB1bi9p6G+KcrUNOxj34NA3QzYHff15e0Ukj80xKgEW2Z3fv812vMsi5uK8xjm MNIfTl55rJ41mls/AuR1ghSct5aGcVxw3wVW92OrthOrSfPR89xOWppg07k94xyKaBjI rL562Zx9C2PXDZ/pOf9l3k6dVbTq5OrEmUvlp4FqrjyHxWaJzJGU4WAJDnSzMZnEEYi9 PCtQ== X-Forwarded-Encrypted: i=1; AJvYcCXol/wCo+H3rK2XPKFwnOuE12eZYXUDk0cP2sLxm/oqdo7fRncLu/WnKSQI1iZavIKEtZXgWzwgAb0IUlQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyI9RvcHfJd6S3ARNVakeXZT4JM70ZocfHHXMJfdU6F7zKbctPL UqmC54+cEXTMs1PTlQqyAfYCt7Q6mbnrPlvxIpZmGTgxGmYX/zxo1T9gmK1m7gk= X-Gm-Gg: ASbGncuZmTJt3XcH7j8A+N1NLRqvUIETNjlXwZemTPYmFaU0Gajv9L6UO+KZE7pSUuk VcSSZzk8+TIYZ9tul2nn+FVmpu7YeNgI0c3/LCzJ8uDEQZUWrVYOErDsY6ZLeevao0xZhwA5z4U 6lVfjdGSkEj3Ro9VPHg1kt8LSVJo6WWT0WEO/Et8ws8azmCzscW84vQQ6Lkrh5FOcrAMLjkZH9M aOzNhQscsTXS4j1stu3vChH5zLKycU27FHi4jfSqWw3n5g9f2Ux0W7Py1MprBowJOsFcle6Pqv5 4X6EyJFgtT3iFdcWV7HV7Ob5TYtoiDl9XxE= X-Google-Smtp-Source: AGHT+IHdDxSM/FWZRtGoOZpkx03AgkDUaEUG/u3se1MxfUPpvgHvDAXIO8mVc8mZr+ucaQ37xObY0A== X-Received: by 2002:a05:6000:4210:b0:3a0:8020:8aed with SMTP id ffacd0b85a97d-3a09846404dmr1749548f8f.21.1746176393327; Fri, 02 May 2025 01:59:53 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:f280:a08c:3f15:ae3e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a099b17017sm1552055f8f.92.2025.05.02.01.59.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 May 2025 01:59:52 -0700 (PDT) From: Bartosz Golaszewski Date: Fri, 02 May 2025 10:59:48 +0200 Subject: [PATCH v2 2/5] powerpc: 83xx/gpio: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250502-gpiochip-set-rv-powerpc-v2-2-488e43e325bf@linaro.org> References: <20250502-gpiochip-set-rv-powerpc-v2-0-488e43e325bf@linaro.org> In-Reply-To: <20250502-gpiochip-set-rv-powerpc-v2-0-488e43e325bf@linaro.org> To: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Linus Walleij , Bartosz Golaszewski , Anatolij Gustschin Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1879; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=N5uZ2gnFZdQj3L5KTNtg0bPlLnvDhqttnz7x8ZTZmpM=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoFImF1uingLTiEjC1c1U5yBJ6QKL/UetAJDwss 2MfnCf+vDuJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaBSJhQAKCRARpy6gFHHX chpaD/9ia9Dv5hQRbtr0XBXvr4ParzZnQUg3MfXxDNrXszqdEGfJSGKw7ZvkKLFOajdDIdiP21F +/oHoYCMeHqai/Kp0EB22ZbR64mqrJb5+FHSI2uD4cpAVDggq0ypV9agRCKnY+kLuo7k1RWF32+ TGXMRWRnzBsHLR/kYMPJEIFr2i6eCZbmIPSM9MpYmNJEZDAhljJRCPR2nC1MAmEqwLKBVOTOb/s R5l1OjrR9qkcE4K24qYfSI5/FD8ZMwvYF6EMz5jq9QdoNhwDTuiRmviA5wInU28fRNGpMJDHRGY Yf+k152e4dGm2edm9Q24ifx376enSdleBwyLbMXNo30+zTBDE58cuVqq95N0VruBoCfRXCs1wgI tR0VRALJdNnJaPtcNLT/Mo+8TJDEUIjg2Ok0MDlPe24Y2qA6AEpfAjTgs8YWY0VHsbDKxSfPQeb cjcP8Za1icbhGvpGdEHCZf9s2TWCU8eiwblsP/ggElw9wyxKIV4wwgLgphcmcXniWawlIlz4ehE Idwbmu8vIXSEuRuX0B2qXxPcejaNsg7jGA2i285fXa3api1N8J7QZS/pSVT3/AybJBRYqNLKCzO +BwMIxr4BUlUej+Kgchh8Qfu5MurvtggZLBy1KKI1EhoiMgoezZzWOfS1rvZDVDkJ7GUZZraHi/ wlE0XEJAUuwQByA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Reviewed-by: Linus Walleij Signed-off-by: Bartosz Golaszewski Reviewed-by: Christophe Leroy --- arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c b/arch/powerpc/= platforms/83xx/mcu_mpc8349emitx.c index 4d8fa9ed1a678..6e37dfc6c5c9e 100644 --- a/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c +++ b/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c @@ -92,10 +92,11 @@ static void mcu_power_off(void) mutex_unlock(&mcu->lock); } =20 -static void mcu_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val) +static int mcu_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val) { struct mcu *mcu =3D gpiochip_get_data(gc); u8 bit =3D 1 << (4 + gpio); + int ret; =20 mutex_lock(&mcu->lock); if (val) @@ -103,14 +104,16 @@ static void mcu_gpio_set(struct gpio_chip *gc, unsign= ed int gpio, int val) else mcu->reg_ctrl |=3D bit; =20 - i2c_smbus_write_byte_data(mcu->client, MCU_REG_CTRL, mcu->reg_ctrl); + ret =3D i2c_smbus_write_byte_data(mcu->client, MCU_REG_CTRL, + mcu->reg_ctrl); mutex_unlock(&mcu->lock); + + return ret; } =20 static int mcu_gpio_dir_out(struct gpio_chip *gc, unsigned int gpio, int v= al) { - mcu_gpio_set(gc, gpio, val); - return 0; + return mcu_gpio_set(gc, gpio, val); } =20 static int mcu_gpiochip_add(struct mcu *mcu) @@ -123,7 +126,7 @@ static int mcu_gpiochip_add(struct mcu *mcu) gc->can_sleep =3D 1; gc->ngpio =3D MCU_NUM_GPIO; gc->base =3D -1; - gc->set =3D mcu_gpio_set; + gc->set_rv =3D mcu_gpio_set; gc->direction_output =3D mcu_gpio_dir_out; gc->parent =3D dev; =20 --=20 2.45.2 From nobody Thu Dec 18 23:21:32 2025 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29E82244697 for ; Fri, 2 May 2025 08:59:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746176397; cv=none; b=WcwwUhb/93+SW6aL520Izs1CbpyQwUsMl8sdhVwUFzqPki7yxKtkwh9cbrGeRhTgviP8OkxIMraRur+ElskjCxWd2U9cvIcPCxZ/QejN1gOloQw4B/TZ6As79/IM8fM8Czw6Ia6BetJbKn3ro1uJltOauJr1PFCV7+r+08pvx8A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746176397; c=relaxed/simple; bh=GewjN5JZ5QEnNVyIalTXmzdJfxf0mZMpZbF1p7s74so=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ovs8NxmiV2cCq8ULH1mbp/Dj6ObKAOnwbYI2RwNusR/ehKMxrgZQJXv3VFYtZwkVHCqEAmaKoOYnt/hLnl5R/C4qYbPBO84Oj44NOHbko5rz+LcwFWy9lcSGyOz3NnL8IYmbO0gNgnD5aqZ7jCDR8D3ybL1XiL6HKMEPgAq0WZs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=REuEnF2V; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="REuEnF2V" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-39c1ef4ae3aso1029623f8f.1 for ; Fri, 02 May 2025 01:59:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1746176394; x=1746781194; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7VQVpAhnQOcCRYJ0IuR7EAkGj4zu20WsPxA2gwCBLx8=; b=REuEnF2VypvMkvCsuQvZLIVtpwEXX5V0zZeg/7JuTVidAnc88naKfiLWQ+Ie3zPwEt a23z7OBwn1bZLdwB5prwjpIE0xwJHsLSz+NriKN1niajVBNvK1Dnb4RB2cTuEfqyMYqd zXchpMNyTaipR0qwHaMFXQRrLvsiulEG8ytZ5gE5uRJFfuLmxqlUmjKid6o9QgPHDNwZ 91+1bjxFX40wqzw4XyRMHjy8R35osChnN0YJ2N1uPlOtf098gcc5SqOCR14bQ7X6Zses pOpu6gvbF0GM3Gvy305yloHcTsdYyqOHWlgdQoOV8NQjYe0WqWXPPc6lewoXS/R4dV83 GpMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746176394; x=1746781194; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7VQVpAhnQOcCRYJ0IuR7EAkGj4zu20WsPxA2gwCBLx8=; b=EIFqtVqmh1eHyY/nYzTJQR8B7lMXF2iXPzj8BE+UUUwP7ODdVb6UdVQgZwnrzrK3b9 P/pEE7j9DoQcz1tbN6BVFgXU/LPDPw6su1nxAd/oDKcvG/gh58w8obvPRqEmBAzLVkEj TE+0pGwtJV7XOVbcyJTgB0aXVCto7OEDJoS1Dys0HRXzXnbsVaeLpNQd197/pimmi0Mk o9A+mf2MBWGUrmDMpPcpI76PhqbdmYtJXXvwDEgQqZ1edBxx2sy/uV/Og9nogWi7JOG+ pG1z1e3YuBWhTBKEQy/Hnp3WsVuC7872n+aaF3rZGs2KsYfP0GSLgb7dFQdM1nk6GlSe IM1A== X-Forwarded-Encrypted: i=1; AJvYcCXtYHZ3zqVz0p/LrfBjEqT+/KIR7xWPdk2ySMsMjRxOxb0bww7nAgwcfJlPv7PYup0c9XEhkgy+9aopACQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxNiK5sdieyI3nZRTzjwJHvhy26dCDlKfMkhpHLIgyTJW9xz8Gl LE4DwfK10gg0iDcvXT+uRwOX+fIpV7HCSbWB0EMSFbuEjAXDZa/XUQDvRkgaoMw= X-Gm-Gg: ASbGncuhYaLqy3/fqf4do/fSoLLaRXozWbqwiCWesEz79r4XlTtdIXxFnRZG8nDsWD9 rxFaHoJLkWkRqlJEu+ZkOrPswkVHDmZfIk+TkUVNhqr9Ij6C5J/MhvdzUztnjhjF6WwThyFDxiH fM12np2i4tN6O8gygUREvw0MgpbDloVfxVMYQV8UAXgnnoeqURC2rPyR/zfBxazEgLKMvYsnJzB YS9dG6EetP0miOgPBs6+W1EbAwSIPkOdphSHqo3/bnvurHqOCiWMbPJm/H9BrCF2Pyu1TWJfFa2 8Dr5B/bUwFUQhbjjE3f097rk3T5ON6JaefU9iwhPadR9OQ== X-Google-Smtp-Source: AGHT+IHQBxxYw4TPkCVhivNKZQXWIM25Cnsq2fJIJFroZbvmM5OL56pj85WS8b3cNucOQHIYyCOoQw== X-Received: by 2002:a05:6000:40c9:b0:391:b93:c971 with SMTP id ffacd0b85a97d-3a094058683mr4162100f8f.20.1746176394370; Fri, 02 May 2025 01:59:54 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:f280:a08c:3f15:ae3e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a099b17017sm1552055f8f.92.2025.05.02.01.59.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 May 2025 01:59:53 -0700 (PDT) From: Bartosz Golaszewski Date: Fri, 02 May 2025 10:59:49 +0200 Subject: [PATCH v2 3/5] powerpc: 44x/gpio: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250502-gpiochip-set-rv-powerpc-v2-3-488e43e325bf@linaro.org> References: <20250502-gpiochip-set-rv-powerpc-v2-0-488e43e325bf@linaro.org> In-Reply-To: <20250502-gpiochip-set-rv-powerpc-v2-0-488e43e325bf@linaro.org> To: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Linus Walleij , Bartosz Golaszewski , Anatolij Gustschin Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1671; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=E7Ff3/1EcYz2Nw6QSP2p8LNuROZlM9cH/LUaLu34ItI=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoFImFaUc3gwNuye/ggncACVXaJIT/sGhSnQxG1 k8BocsYj+eJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaBSJhQAKCRARpy6gFHHX cuKeEAClIackuAKdOU+yl0nzsAvzc25o+JND+09tQcnbWh3AsifpuV7rlyzUrzurd+n71xUXbBh awXQhZPFM03p2pHjU8sSoe03IWWl/P/iUQFGfK3UFx/dFs6zbSSmvCrUQR43C2zLhN8WmBOwGpD vOa4MEAW+pXxdy/M2U8w2OQDBYIknSvZr8q+QNpm3v2aTlKJkXmxQ4s1m8HnsYd/KxgQ5lZ/ooB RgdkMP1NOrVNSASt0s+QJVYySccm/6xFXSgfhZPF4QN87mFgRnVxEW6ZMOzJ4SENiWPrKxLGmpz tQpB+JIWIs5aOa4fuWDe98rfWqUpHnxJ0jWKMmb1rdmjR8R4QYQq3ygwJXhP6HSxJs0om1niN4/ SrrDwUSyhNNIp4EicjN3o15Sj8wJ6pIbQ5oDNgSiiiQNq8kTSa6apDB9p/SbZPO1IYe7AgjPtUR Finp1+Ml4Xqh45uqDF/rpvHaIdjVuAorJXbcNbLRYJ6MW8cPj6se5CVDixKrvgYH+3oC8MDkxAQ wHyyy/EMl2ZtLXCot4mdnb8Da5Nn/0zXT8j0syLnFlsgoEASpOqTT1V2/RYp15J+Oc412XmMnrP 4qvzerCJIicUdBfX65VXU1iM2RR5zud6VbTmAbqQvm7x4RZyH497DL72cGrNKnipgTI3q1iTaxs RutDOCWUZ+MhTSQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Reviewed-by: Linus Walleij Reviewed-by: Christophe Leroy Signed-off-by: Bartosz Golaszewski --- arch/powerpc/platforms/44x/gpio.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/44x/gpio.c b/arch/powerpc/platforms/44x= /gpio.c index e5f2319e5cbe2..d540e261d85aa 100644 --- a/arch/powerpc/platforms/44x/gpio.c +++ b/arch/powerpc/platforms/44x/gpio.c @@ -75,8 +75,7 @@ __ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio= , int val) clrbits32(®s->or, GPIO_MASK(gpio)); } =20 -static void -ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val) +static int ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio, int va= l) { struct ppc4xx_gpio_chip *chip =3D gpiochip_get_data(gc); unsigned long flags; @@ -88,6 +87,8 @@ ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio, = int val) spin_unlock_irqrestore(&chip->lock, flags); =20 pr_debug("%s: gpio: %d val: %d\n", __func__, gpio, val); + + return 0; } =20 static int ppc4xx_gpio_dir_in(struct gpio_chip *gc, unsigned int gpio) @@ -179,7 +180,7 @@ static int __init ppc4xx_add_gpiochips(void) gc->direction_input =3D ppc4xx_gpio_dir_in; gc->direction_output =3D ppc4xx_gpio_dir_out; gc->get =3D ppc4xx_gpio_get; - gc->set =3D ppc4xx_gpio_set; + gc->set_rv =3D ppc4xx_gpio_set; =20 ret =3D of_mm_gpiochip_add_data(np, mm_gc, ppc4xx_gc); if (ret) --=20 2.45.2 From nobody Thu Dec 18 23:21:32 2025 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D79124501D for ; Fri, 2 May 2025 08:59:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746176398; cv=none; b=VIb1z07IsIsl6TS11DCDOBnU+b8X59jo6FL65ADeemQVxCTXt7RY/xXdKDBy791DqtJ0gFxWzIQF+kkfq7v9y4rlr2vFenD8Az6wGeowz3NdV0DNPYMrqaUS2M5HkxXRxG4hMC/sBycneRl2aQdxD9nuQJPJQY1/eBqSDxAO8eQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746176398; c=relaxed/simple; bh=WHc7wn2J/YaeLrZRN4cvkbwcAb9iM7CUvj9xdwuFIIk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aER5MqqYKj3Xvo9HvMixpZi+yNl8Yg5Y0CGhYuy7pfxE9trIUELj4j/qARC6p5TpsMuVH1dvOnTZcEgB68Xi5ITM5SY3nILfQ1S425QREaYKmbOk+pahb4yW1qQwAahMPP0nXqLFDDIi9GyiaXIR7W6jvkQmZNzyhvbKaSrKBXA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=m9y6ksaw; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="m9y6ksaw" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-39ee57c0b8cso1508531f8f.0 for ; Fri, 02 May 2025 01:59:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1746176395; x=1746781195; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=c6w8Ny2qh7Oi2mCqCFAeltSr0IHxTHSshWp0NZpEQtQ=; b=m9y6ksawFU1pi+PTc0vaDHGgZjsOJg1MeLpPC5LvqKoTi+oR+TXU+usP33xNoxWu5q 0Mm8ORZ8mfrx17BAq6CyHzDUCAur7z9L2mEWXAXGpyJHUHhfvdwHeI0F4xgzox4YmlGV iLJRU9MTVOruVmxRSXdOf0Ghd8/+Q24fmkqQ5jbv3Ux3vYARkaEkYPWtT2RLBqIV+8oZ ITaTkzlRZmbNW47uzIciMjGfgpaSozPEdxjwF65khDyY3kZeMm/VpJ8WDeBrdCeylxb8 gGXrh8mLSlVqCfWTo3ZPYDuEpHqD3ixHEZqqnrf7+k72FRBpW9STes15BB6XYh0s5lDo ZtFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746176395; x=1746781195; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c6w8Ny2qh7Oi2mCqCFAeltSr0IHxTHSshWp0NZpEQtQ=; b=Yhi5DHEtbhNS5INmS3JKNo3ln+DQpp+ltVAEvR4b/0fLGXtELhnjjqCjNo7DtRCNWc DwKMhmvNbeW0PDHApmzNvsLBtDmZdCZZDR2HfuOqHCTN7UKutZRN0QsY0ps5WBCnC7CD 9hbnWs03C5DMKf4eLyE/tLLRL2uKmEfcrpx7sYk+Mbjsrto/xJ0ZD5zH51Z7bctOZBgm iMZzIV16wKdpjJrvz/hVgHWADzAW9KncfP2xqoBJjxX5bhla2tyLNwfjApKyyFCnlgK9 tRbbIIFZcR/JsPAiiAc8rhrAD5xd5M6FGf4B5ds+Ivaa2JemfXphnjEwxf49359TvQnS XtVg== X-Forwarded-Encrypted: i=1; AJvYcCX14Gly9v3TrKrihJYPngSMxU9gNyLmJXRI0YQ2IcoN0/ckZ1LNHW7FFvmDQ75RK2OXSV9BdlbIW+6OkAQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yyligy93NOQubJLmrC22mueB1Z2Vkom5pJtKemJUbdq0NT6ayJi HzQMNuSf42FgY64YvaS0RMBy2V+qFlMxCP4OsY3175Y8Di/WX8Je1XXLBPm+CdQ= X-Gm-Gg: ASbGncuQs+42k1vraDTXVN/PDA//7JUlqAdrAQCetLS96E8lnxq7aXreO43DmNsc2a5 YjogMax3x+/YPTKlAb6/GfV2DYmW7yFW130xPNKqSu0ugeiGawxQjjB06ujDiwzPO3gGIl7GO2g 9Oe0PicxUSMGqrjiTnuhKwkrfNGtwtnEbX9odNBh+C95iQAqDMNC6dtrIAV2g5Kc5aMkJAQQn4C jFcVsZgSLyDiurfC/WB4ozTBcnOctlXv+wmFcq3rZ4GbBT++dH6KRjisivWNj4yErbqXPIFNAha DB5TJQHm0OZDwQt3+aVDl9DiuuAQwQ3xPbE= X-Google-Smtp-Source: AGHT+IGnuPzW0KsZuoafr0ut25yVUAE58QEXlIHKEBz/4ug3rf9GaFjAL3GjFqvtw7oASpIUZZCL/w== X-Received: by 2002:a05:6000:2ad:b0:3a0:7af3:be8f with SMTP id ffacd0b85a97d-3a099ad31cemr1489449f8f.5.1746176395349; Fri, 02 May 2025 01:59:55 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:f280:a08c:3f15:ae3e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a099b17017sm1552055f8f.92.2025.05.02.01.59.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 May 2025 01:59:54 -0700 (PDT) From: Bartosz Golaszewski Date: Fri, 02 May 2025 10:59:50 +0200 Subject: [PATCH v2 4/5] powerpc: 52xx/gpio: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250502-gpiochip-set-rv-powerpc-v2-4-488e43e325bf@linaro.org> References: <20250502-gpiochip-set-rv-powerpc-v2-0-488e43e325bf@linaro.org> In-Reply-To: <20250502-gpiochip-set-rv-powerpc-v2-0-488e43e325bf@linaro.org> To: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Linus Walleij , Bartosz Golaszewski , Anatolij Gustschin Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1743; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=NUv/Cv/Ma42p5cVqxLaXY/iK8aY4ZJdMZfYarvprRRM=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoFImFEUTAydQAnqUBWcSczhRxoDxw1FtPObvJO Cps9EWCTzaJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaBSJhQAKCRARpy6gFHHX ctNvEADegI0ahN7DjfRK70i+3mbHNjJm9hEqWx3KvwVKsoM5dD/Lkpn2urM861oMuobssDB/gcE DbA2cu+7NDPR0b+KaYiEU8JJ5BvmUpmTg09PVE/paQdwKat4HoV6icBYsyMHJI9ZZg9Vbo2EQav FoMnIzOGzWzbrqdUg6jyaaiQFMqhkbafZz1QVXvN2ZKuYbkwTLxLyq48nKWRTJUlsOTpmLY9kAv DCCAzdjB8yk8zEXXdAaEKLsoXZwjR6cwdBa54HDS6vPGP8iioKYpI0sOxcsxIAyX3woKy10zuGf tJuGP1S7Nw3/HmrBmtsVe1yTgdnQYY9te4AtsrBPo7A+Qe8FbkiUJcbbwG1qQc1sB0nO5kn5Cj2 9o/m/6lcqCxlfcVcTenPlKMlyIMMVbJ9j9qV/gDFhDxnKHZwY4rtTo/8C3TcgqxobElqQuEK65O BIcVEJUqyvLGwd3JPg21ifkC8tQ++TuyrXzYGTnjdwm5bMWWkyKpOiC0W762gmVviUqRHG1x9aA zYw9pfUPGHaAQLTeDArAu40iBit+zJBYbkA3kfchXECSfhyTBGacRZZrgbfq/M55mbahzq1kFtA 8gWJE/qAD8A2LLIlIugop7WeyKiehQIs2Ox+gKZA0/PxIaVU0RhyHAvi5AJDBvWuN7YMXvDSGik ecRAgo8SfaYFF9A== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Reviewed-by: Linus Walleij Reviewed-by: Christophe Leroy Signed-off-by: Bartosz Golaszewski --- arch/powerpc/platforms/52xx/mpc52xx_gpt.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/52xx/mpc52xx_gpt.c b/arch/powerpc/platf= orms/52xx/mpc52xx_gpt.c index 1ea591ec60833..c96af6b0eab42 100644 --- a/arch/powerpc/platforms/52xx/mpc52xx_gpt.c +++ b/arch/powerpc/platforms/52xx/mpc52xx_gpt.c @@ -280,7 +280,7 @@ static int mpc52xx_gpt_gpio_get(struct gpio_chip *gc, u= nsigned int gpio) return (in_be32(&gpt->regs->status) >> 8) & 1; } =20 -static void +static int mpc52xx_gpt_gpio_set(struct gpio_chip *gc, unsigned int gpio, int v) { struct mpc52xx_gpt_priv *gpt =3D gpiochip_get_data(gc); @@ -293,6 +293,8 @@ mpc52xx_gpt_gpio_set(struct gpio_chip *gc, unsigned int= gpio, int v) raw_spin_lock_irqsave(&gpt->lock, flags); clrsetbits_be32(&gpt->regs->mode, MPC52xx_GPT_MODE_GPIO_MASK, r); raw_spin_unlock_irqrestore(&gpt->lock, flags); + + return 0; } =20 static int mpc52xx_gpt_gpio_dir_in(struct gpio_chip *gc, unsigned int gpio) @@ -334,7 +336,7 @@ static void mpc52xx_gpt_gpio_setup(struct mpc52xx_gpt_p= riv *gpt) gpt->gc.direction_input =3D mpc52xx_gpt_gpio_dir_in; gpt->gc.direction_output =3D mpc52xx_gpt_gpio_dir_out; gpt->gc.get =3D mpc52xx_gpt_gpio_get; - gpt->gc.set =3D mpc52xx_gpt_gpio_set; + gpt->gc.set_rv =3D mpc52xx_gpt_gpio_set; gpt->gc.base =3D -1; gpt->gc.parent =3D gpt->dev; =20 --=20 2.45.2 From nobody Thu Dec 18 23:21:32 2025 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16138246779 for ; Fri, 2 May 2025 08:59:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746176399; cv=none; b=B0PDEzl4iAYukmTpEVDvZVqSCg5HLCzys5Asu8fn7ilijFvBrSUbzp+CNaUO29fCV/vwU4ahWWQL7L9yNLlQIgukmj7B8SAhnQ+sfgMMaqfQ4x6TH4hQN+M8AhuYR79/vE4sku9l+F6K8UCDBmvS6vMzKBEvpw/sr4tbeaTKMXQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746176399; c=relaxed/simple; bh=Egk/9E5ZxXweQ5hfkjs+LpwhSx/DNw0XG5a3yhVLRU8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fKcHehDcGydfR2Fe6HTJVnS8BcS0CmbklNSGfs6SsjAZuqATDg2C/PspqeEZ94dseah+jAxkIN3Z1tipgzCuYFLnJVGx4ynteX7s4lbW+/QcbEyT7TFCArcQhZzf2Dt/+QnL2kLTMKq/fEVaYA8l1UZVZSRB+GFzU331bnFgiCI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=z9ZuIjRZ; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="z9ZuIjRZ" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-391342fc0b5so919638f8f.3 for ; Fri, 02 May 2025 01:59:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1746176396; x=1746781196; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=uSI3W4dK/WwCbr7Lai4Hip7w1X1W5KMNJkBGonHTT7k=; b=z9ZuIjRZdtrqqXOjwFsvcZ2AcJnFgJN0jd3txiQeJkYa2fl8LlCs72DMSpODFLHQ2Y EQJThduEP6OVhifwmV0/ytl1MHQqYw7G160EYlWELGicuP8qISW2Ngwd5uRvhfKkdI6X eqUaJ7S+Lw3iuuev8YnVAQCTLUfnLR06AdhBuaOud6FIR8tPtD+g9Wp6sBCRqo5y2XGL VpWhX/2CO3pYhmP2abudGZrX+Q7NvfnnD2h+x2+QJT2KgtOXxJiqfhQ6BOxwxu83x8EU sLiklXxnPeXbmdDsYRS5kkqbtYl3LhLI1WhRmqAdCV94ogT5nhopCEj2oBwEfA3BNSRN Hm2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746176396; x=1746781196; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uSI3W4dK/WwCbr7Lai4Hip7w1X1W5KMNJkBGonHTT7k=; b=LSxFCc5c1qVILXUViLzUriAKAEf0/A1LmqWyE5ZaqIoxfpEvOOMmF8sY8VtYw/L7CH Cld2Vbmb0KGJX4oMaD7YEUX0bgKntsGSY1pGI7iWSHS/5VRA0r5TaAwMnS5erQjITU5c HMGJnijFaUhA9H2IfjTtxBPICQoJLZt2Qdw5jwoqhwbybK67H81uS6IDBJFWhAci3RAQ hEASz+Qjuo4BLgZhfYcZjGJnNN5gTv8xR1noFD4CnJ+IXve0vDRgnDcKj/hn0RReD1Qx +XSgp7EXLeYYKiq2XjP+CJ7S3D8FNxNXBGK8z3G27g1ejYda5sj7bWkCCRV2vnOIg/BD Onqg== X-Forwarded-Encrypted: i=1; AJvYcCWulo/Zgt8xxcKon3c69RekiTJk/JBbTy2gatb4hBjutFBvMsG8AzCEgL0isV6JGAHpbJYRb90EVyPBKGo=@vger.kernel.org X-Gm-Message-State: AOJu0Yya+HFuqeLWEsIFFHJc8iFkyJQberyFyMe5QYjx3AsbO7QfaZSX 1PQXAs0pF/uAmMc3zKKISBDGMrxsJTl/IXmh7yeQCP4ZANnNSFrrm8Y4BwCe4eQ= X-Gm-Gg: ASbGncvM7AqlnQcE7oQ4AYNxjRLhpDP+P5wy9lYosqYRa/jK/9WQqlOtZfO3f55fe0q ZHDyJp8S74isAyulczCOE9sB/yondVFHrHzmfxB0+LIEWbRr1IyxtkZRuThllNPG72Jd4LYNd+d Xs3JeXWksHUGYzhZskW2puMz5nN7jqhQabn5KGAX7OCjufu+yZvjBjSiiOeLjKEU+DyDqvhrLFH o1psUW7B/Vx6lW1Z98IqPX8W2S6505UYYPC6+/hfmHv86AmY0ycyj64iXAWYUhFHLCg3yKctXzB c3lk7UEzMafKJDWg0DehNfJ7fCLP4dHlkPs= X-Google-Smtp-Source: AGHT+IGiehs+dD7NKpB0E1UYkHMJciB0IWOavCbaCxYmeUmt6Jp8ux4E08zw+1Zf98nIRF7Zf+GcJw== X-Received: by 2002:a05:6000:40db:b0:39c:16a0:fef4 with SMTP id ffacd0b85a97d-3a099ad938amr1319909f8f.24.1746176396315; Fri, 02 May 2025 01:59:56 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:f280:a08c:3f15:ae3e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a099b17017sm1552055f8f.92.2025.05.02.01.59.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 May 2025 01:59:55 -0700 (PDT) From: Bartosz Golaszewski Date: Fri, 02 May 2025 10:59:51 +0200 Subject: [PATCH v2 5/5] powerpc: 8xx/gpio: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250502-gpiochip-set-rv-powerpc-v2-5-488e43e325bf@linaro.org> References: <20250502-gpiochip-set-rv-powerpc-v2-0-488e43e325bf@linaro.org> In-Reply-To: <20250502-gpiochip-set-rv-powerpc-v2-0-488e43e325bf@linaro.org> To: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Linus Walleij , Bartosz Golaszewski , Anatolij Gustschin Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2792; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=9v+4cP+N9Ekqaku8fyOt8CZXpH5ZitQiy924EVCXv2U=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoFImFV/zBpGNUkKObJQaO/c0oYX+Tv8vDmyzil Ug9qJCMkCaJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaBSJhQAKCRARpy6gFHHX cksyD/0X+tJgjUPnAxn6EKf2Z9j6fWFPc1+1uIKAzbRceI+1oKELBb+otB64CIoIihXVwVt+92J WeO19V0+Q29RtvslOqkQNdyaazX264hPpEVN8oz1ebZeYkL/64AqoDjaNARKDenLURsrj4U1/pU 0kWP1TXJbkSzEF7AqAb61kqeUAUwZYly/MdL5dmZ22GLohEG0hswU5X+AdQNTKkE8ttWrDLa6UB kXHTvmo2g5VKATg+9ctmhcZVjPTh6V50TbHJjz6gIfiMm8MZ7fgq1nwUnPn3AZ9DmgVWUBSTr+G +4w1oBrnlQmLS6+E39xkCSdXzDf4mIsZvk+/hPGjJLuDDRUsq8/J72Ccaf4QdcBEFpu/cRvKqs+ Yi7STBrE5AgPkb0Qi189KebD0770ZU3saX9T0465ZSptxEPKu6NQSEpNnQLkN0QtIXsdNwo+h0g dXwPYZFx8kfep4AaIUcQK7dyk1KxsYlXOX8LazI62jiefMNyZkSll17/le6ayiMq3T+XvP54Jjm CB18WGR6nLuckcRgDOrY5pEMBYi1OXrefhwoqGEP2fP0VRRNYKAwMeR08IBkQLSWiGoK+ac+KEY Zv9O1H0+iu013fq2RDlItUKlG11ZDRJEcxARbfWkfW86nInRiCQLl8ywo6Ao8toT9XekBZLcwKp IzoHr5MPIAiB0ig== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Reviewed-by: Linus Walleij Reviewed-by: Christophe Leroy Acked-by: Christophe Leroy # powerpc 8xx Signed-off-by: Bartosz Golaszewski --- arch/powerpc/platforms/8xx/cpm1.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/platforms/8xx/cpm1.c b/arch/powerpc/platforms/8xx= /cpm1.c index 1dc095ad48fcf..7462c221115cb 100644 --- a/arch/powerpc/platforms/8xx/cpm1.c +++ b/arch/powerpc/platforms/8xx/cpm1.c @@ -417,7 +417,7 @@ static void __cpm1_gpio16_set(struct cpm1_gpio16_chip *= cpm1_gc, u16 pin_mask, in out_be16(&iop->dat, cpm1_gc->cpdata); } =20 -static void cpm1_gpio16_set(struct gpio_chip *gc, unsigned int gpio, int v= alue) +static int cpm1_gpio16_set(struct gpio_chip *gc, unsigned int gpio, int va= lue) { struct cpm1_gpio16_chip *cpm1_gc =3D gpiochip_get_data(gc); unsigned long flags; @@ -428,6 +428,8 @@ static void cpm1_gpio16_set(struct gpio_chip *gc, unsig= ned int gpio, int value) __cpm1_gpio16_set(cpm1_gc, pin_mask, value); =20 spin_unlock_irqrestore(&cpm1_gc->lock, flags); + + return 0; } =20 static int cpm1_gpio16_to_irq(struct gpio_chip *gc, unsigned int gpio) @@ -497,7 +499,7 @@ int cpm1_gpiochip_add16(struct device *dev) gc->direction_input =3D cpm1_gpio16_dir_in; gc->direction_output =3D cpm1_gpio16_dir_out; gc->get =3D cpm1_gpio16_get; - gc->set =3D cpm1_gpio16_set; + gc->set_rv =3D cpm1_gpio16_set; gc->to_irq =3D cpm1_gpio16_to_irq; gc->parent =3D dev; gc->owner =3D THIS_MODULE; @@ -554,7 +556,7 @@ static void __cpm1_gpio32_set(struct cpm1_gpio32_chip *= cpm1_gc, u32 pin_mask, in out_be32(&iop->dat, cpm1_gc->cpdata); } =20 -static void cpm1_gpio32_set(struct gpio_chip *gc, unsigned int gpio, int v= alue) +static int cpm1_gpio32_set(struct gpio_chip *gc, unsigned int gpio, int va= lue) { struct cpm1_gpio32_chip *cpm1_gc =3D gpiochip_get_data(gc); unsigned long flags; @@ -565,6 +567,8 @@ static void cpm1_gpio32_set(struct gpio_chip *gc, unsig= ned int gpio, int value) __cpm1_gpio32_set(cpm1_gc, pin_mask, value); =20 spin_unlock_irqrestore(&cpm1_gc->lock, flags); + + return 0; } =20 static int cpm1_gpio32_dir_out(struct gpio_chip *gc, unsigned int gpio, in= t val) @@ -618,7 +622,7 @@ int cpm1_gpiochip_add32(struct device *dev) gc->direction_input =3D cpm1_gpio32_dir_in; gc->direction_output =3D cpm1_gpio32_dir_out; gc->get =3D cpm1_gpio32_get; - gc->set =3D cpm1_gpio32_set; + gc->set_rv =3D cpm1_gpio32_set; gc->parent =3D dev; gc->owner =3D THIS_MODULE; =20 --=20 2.45.2