From nobody Tue Feb 10 00:58:48 2026 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69DC2202990 for ; Thu, 1 May 2025 15:02:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746111734; cv=none; b=tDIFeegW2+74OZiZ3sqIx+8lUVxyp7h5lZe1/ASZGBXPwtaaFI24Qjd2WMDI0P5vEggA2fp7KQYF3brZbKfePSuQ4ODUHqBC3b0qmFogZWuHM/uwnvYLyhbSJqxPeRK5GMDCZxUh+b7nK85kZLh6IM3KB9c9Sdd5KKC2FvuNh4Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746111734; c=relaxed/simple; bh=wbJvTFF93vO4XDJ3t3HtJwaTtycPFJ1qGS1kFwex8VI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PmXfjm7NSwpPKW0WQwKaXvKdbrjgcPxU/oP8qv3MsPL7ylJn1O3BC6rg+biWsBu91JodXppA9s3GEqtIkLR6MPSBZj2Izrow4eupR0S2apt9lmQugN/Aogli3h+wOKw12Hm39GDyx3DqV+ZKhw7WeFVIWgoWCArw7fBEfDgUDO8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DL/WqiMp; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DL/WqiMp" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-3912622c9c0so15341f8f.3 for ; Thu, 01 May 2025 08:02:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746111730; x=1746716530; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=cjFuL+Hxvp62ckp62d4xwkNy5J2SbdNnB8mUiL94WtI=; b=DL/WqiMpmHmG7xwuQNyl0N8kugkWsyVp+aKJg4UF+UgSDjOf/e79DYP10ImXkq+KQ7 4ED+6e4dg3F63aBc5QagIBDHWOmzK2ZRR1/OzjBZOx2Kw3MUDNsJcHWpyrhQzqACQchV vCiKtmb/1719Y/ppSAGtwvlQIR8hgxxkdkouusE5KcMw7GP0itQ+mbWbkXg4KKp/k1x3 012+iiKrbgUmw84yexLY4bKRkHYY18+zinh9zinCmKorqedksjj2mE/8QdEzHpJhVcjj 0Wgcn7dLCGwPix7KTH8cycJMiU2Yq+WYJ5r4lFxrQTM+UD8QTZOB70chNaw0XZHv3JN0 HrZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746111730; x=1746716530; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cjFuL+Hxvp62ckp62d4xwkNy5J2SbdNnB8mUiL94WtI=; b=vi77p8ImZOwWXJf3KnvtYTDf7ynO8h3nDNPlEGOqhJfs+HVIV+XdPaJI4Cd/9dvGsU nKfqE4JyAIX/Fpq0uRd1EZl27zSGUfcy2hEaXHE8ZdjLi7k2tUwSQN3YDzqNvxh7sWpP AlfcWt9Zoz/XaD3fh/PNH+ZMm3ZuSHYRLd1R/mll4vd/dIWaPn/x/2RKToRjWIl+/P0F veFXMeWPL/SDravxs/OsMkbX2DY0MxnbvA4O5o7dgDlltm7LjJ6zUt3Od8aXLLyT4iqu YnMKNgGV7+LVNimNcqybj8vWqgWdGpTYTCdu9ICxJIH3uHvqJD3hw4yG0CinqhD7FPAJ xOVQ== X-Forwarded-Encrypted: i=1; AJvYcCX4ePPD/InoEaQOGzpsE7hDVit4ziC2TSvDVtiz7xjb1M6GfsnzorOP1aP/VqFJL6im7wrHX4CfBPKtkUA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5fagOm7A/Lpe5QIwv+0Y3WHV3SuG0i8anZ44WXbSl/N0s7GGi ZeL2WOEqBmmP4CpkmgMfQdKcHVAcK7rhCVnSEFOfXl+f4eofIf4YwxJC8LsjOcg= X-Gm-Gg: ASbGncufXo31jRtxjKEeb3U+Qp68hdgHcoycTL1DhScldh3EDPpRJgzbnqEmXtEuZmQ Ip6mEiVCOXnTMBat72yB3TtDRlNrTh2Khm9bqpTnlSMUND7a7JEv7KdpqmhFhPzGRRqjHVJVIAl MRNpPMw6GRRF6OW+0TI5xq7ob0rZZ9Lc3pEcQBpmh1F09YsZRf3q9jxVOdSAs1RetFa+MDKAsvE T+cDquqYA+A7AFxCFtstpmVv70wv22/5JLeaJa9axtAR0UZZP0AGbmTtbjyvl/xFbmBkYjmXC1w o7Gm3n7XzEl1E0plh4JZGTKsKENXoymVuMqxMHZESts30BfHIV9JClCN9SI= X-Google-Smtp-Source: AGHT+IHx8sWqPznlt7972Iuo2Aq29rBeEzunJHQrQZKTzx2L2RYiG2zZqFAc0QZBwI42PaKv7Rtz0A== X-Received: by 2002:a5d:47c5:0:b0:39c:12ce:697 with SMTP id ffacd0b85a97d-3a08ff740cdmr2119607f8f.7.1746111730466; Thu, 01 May 2025 08:02:10 -0700 (PDT) Received: from [192.168.1.28] ([178.197.207.88]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a095a4702csm1033190f8f.40.2025.05.01.08.02.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 May 2025 08:02:10 -0700 (PDT) From: Krzysztof Kozlowski Date: Thu, 01 May 2025 17:02:00 +0200 Subject: [PATCH v2 2/3] spi: cs42l43: Make handling missing spk-id GPIOs explicit Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250501-n-smatch-fixes-v2-2-d2ad9c1f2e67@linaro.org> References: <20250501-n-smatch-fixes-v2-0-d2ad9c1f2e67@linaro.org> In-Reply-To: <20250501-n-smatch-fixes-v2-0-d2ad9c1f2e67@linaro.org> To: Mark Brown , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , David Rhodes , Richard Fitzgerald Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1111; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=wbJvTFF93vO4XDJ3t3HtJwaTtycPFJ1qGS1kFwex8VI=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoE4zrtu7znQCsit8jnz6Ax+qO4kjdY1hQPTmwI OVVwvysS82JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaBOM6wAKCRDBN2bmhouD 147VD/972YtDAImuxcHPXe0MWIDPqszTwkbi59mXMxbvRK6obHdCyrpJkqfn024r4nmdDhOiPb9 4E1FN0hEFSk8JGbXFmIw22G8Bwq5S0k76HOEPL+b0sGuJi6v5uBoyCVhla5wYn7WGuoKF7wMfR5 3G/CPkg+jGFN/OiG3QKQ5KM8zlCxT0gAANfomMj388nuUHZSuVD0TuhI0yZS5hROJ8X1RuDeHqt /qAObojiLu5fNh/M4xgzFtwpyfd9mR95NFNuR3GYoUIomx4WH0bVbEYFEQuafiUhgf98GIi/yun KWucCUhMHpL+B5R5nnhr0lp+gG+9vtbSoNEH2FHo7Ge0+StqKh4wprKlXgVF7Cr7VV6aBZxm6Lr LFf5Xov+wZDaUzXgUpRXCYskqUSS4vnlGHlENlY4WU6Gx1pZA/INSKRbIko/wBrLQsnBgaJ8zQy ez7jNZlgzRl0LoeE2weS23vDqTEDAsxfRtaAxIky7g0tiIq6IAZmMHkoH58PdxPiG7tmyA0O0bw WdP11DStBXyynr8D7wkqgC9snxJkAFL9MuHjwxCdnJJlJhJfl6kOKHeAXSksD0tpm/QXvPH3cKY ExiuTU5tkPKjs2lVv1y8RyO4+fmuArAc2AVddNhlCmhSviquLZH4CBGjenXnX82f0vcLkiZLOSJ N3UJhd6BH8beTlQ== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B gpiod_get_array_optional() for spk-id GPIOs can return NULL, if they are missing, so do not pass the value to PTR_ERR but instead explicitly treat NULL as acceptable condition. The old code was correct, but misleading because PTR_ERR usually is used on errors. Reported by Smatch: drivers/spi/spi-cs42l43.c:241 cs42l43_get_speaker_id_gpios() warn: passin= g zero to 'PTR_ERR' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Charles Keepax --- drivers/spi/spi-cs42l43.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-cs42l43.c b/drivers/spi/spi-cs42l43.c index ceefc253c54904b51a12ff112988d1dfbeed39c1..b28a840b3b04b5a4cce15539188= bca02bf36716a 100644 --- a/drivers/spi/spi-cs42l43.c +++ b/drivers/spi/spi-cs42l43.c @@ -237,7 +237,9 @@ static int cs42l43_get_speaker_id_gpios(struct cs42l43_= spi *priv, int *result) int i, ret; =20 descs =3D gpiod_get_array_optional(priv->dev, "spk-id", GPIOD_IN); - if (IS_ERR_OR_NULL(descs)) + if (!descs) + return 0; + else if (IS_ERR(descs)) return PTR_ERR(descs); =20 spkid =3D 0; --=20 2.45.2