From nobody Tue Feb 10 04:02:38 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E485320125D for ; Thu, 1 May 2025 15:02:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746111733; cv=none; b=fOtaYOuDIBMUesWK3Q+sm4XExObFY2Vq3/BoL6RcwQt2iemAOf+JKV/U/HC5ZwADDwatx3sLvu/0kUoHEefrPQXMUc1rOimkYHOZ9JZi/RSm7q0dpkBijGYDk1GS2Jf8JRUhzKPFqFdj5qQFm2NIbSwR7VXeFfVdMPsMLW6MNmQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746111733; c=relaxed/simple; bh=4rkQ3Dw/vam/Vj+imyvV8Y9YuqnRhg19j57rXz0G09I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=snDjcfXSZrstxozOTpIJrthxuvfr0KhOfcRJcVn3H8TpFpEHyS2q5m+C1ht/kO257w26P2/uobNwrPGDJDNofOmshlOitYRZ6gJLIoIMplEzh+0x8jSq7xWCq1p0mX5jwtdy4rNVxrVHsfK6zlo/VcnUgudxUKwyvGYhyPqIJG4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bhQuQnuS; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bhQuQnuS" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-43e9ccaa1ebso1340535e9.1 for ; Thu, 01 May 2025 08:02:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746111729; x=1746716529; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+CQO3BwoDKAYLGKeUQMSLddVF7xiAI/qGk80JN0kw5s=; b=bhQuQnuSqYFE2XUWxRak+3tLVQ7hEzFTAMuDMVYSPSBszvJOexq/WKAjt6G7FLmIf6 hEW4RT7fTobFodsH93x5uILIjraALQZnD4cdK9v6GVXBGZa3RmjnwJGHDDzc4sn5XKYA xFPPx3SWRRXoOUWlVdSwD2ZlhNTRuTpYDUHz3FyU1iJQG5u7u3C2DPTqf92an0u1L2Z9 MSZ27hUosr3RdD7wYpJXJ5qmV7lq1Pqmcu52ZGleL0wU8Q4wLsQPx3Ihhtt5utf+yWLA JnX+4JCWMIoHy80S1X6z3MPMtK1i2v9dBS/bUD3edA7Vl8tqOCL1pjKHF4ppTyRZAfgh TNww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746111729; x=1746716529; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+CQO3BwoDKAYLGKeUQMSLddVF7xiAI/qGk80JN0kw5s=; b=xVFAGEYxVnIF8TeHpaS0SCkTyRnik7z5DYc8kQTVe+YcNg39x/ZLuzMp8GvyjM1TTX 6Y+x0b9iL4WAwzowmNSOQoIMm5sQH9FE/GEOvLU+fxof9p0WHVi0pXVQbg7kh8haV8HQ ylRCm5OBKb3E+LeFnfAHDsEei1P1TKguApWa3JU+cyVQWhgFapVSatl3qTrmDN74s/OG 0rIExiufq8WbDtV4n2aRZsfwHdkl0bk8PgIV9TZoI2zliZmx32hNvahOAwsewhl7xjmE zOgJByixWXLGS0VapHa5tExKsmP+rGQpKR+vA2RxFf+iOGgzEX66wQqyWGt89KoKnPNv V0Wg== X-Forwarded-Encrypted: i=1; AJvYcCUVnu2yr1XBnzVZECIZZqNq4SWKXRRKC81nOu9W/te7JS5ZjXb4NOcoTO+OghanIbDSu42AA1Cm1Vb6Zm4=@vger.kernel.org X-Gm-Message-State: AOJu0YzIMSIUB+ux7GDCHUm/Mb5xYQxd7FW2P47RTjh6HpaL22U3EyUw YEe4gKnKhayTrqPXfSLa94K7VT5rwhwO1Q3YBaYPs2+It37uCPGzmxkaCyZj8jI= X-Gm-Gg: ASbGncvuEYmwLwgy/PSoYufvcn11tRplJJmLLRL+lZo5h2ohCLtbzKkkANXsjS7XTIu yixfew02H65YLosDMs3/M5+yO4eM21c6BxTUAiWE3A6a0fATbwNlXYtJFO9qFKR4CaKdktpkpqm bvRGAiH4e7pRXwQsJYs9k99Ixbi3H5idQdIAriBrFZI587JHVRMnW+68dY/qO+b5WlRiwF53RwX dH/817Ck5wjJdOOyUs/nniyMeNLZk6iXMgbVFCPuPBQcevsriNokbPPchASAWtxQcHLwmavs66w VtGF67VLhTLsTgeC7yRTk9VXtPTJ1eB8X9Pk5d72UaKFeCBu90YmvdzA9ps= X-Google-Smtp-Source: AGHT+IE4vTsyhTKjuwrkxiEbVaqWLWprrAFI6LPkc5oJ6Tw5j0urpY7Zf4f4AAtn0dsslPS8UEL2JQ== X-Received: by 2002:a5d:59af:0:b0:391:3110:dff5 with SMTP id ffacd0b85a97d-3a09404c7a7mr791880f8f.5.1746111729092; Thu, 01 May 2025 08:02:09 -0700 (PDT) Received: from [192.168.1.28] ([178.197.207.88]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a095a4702csm1033190f8f.40.2025.05.01.08.02.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 May 2025 08:02:08 -0700 (PDT) From: Krzysztof Kozlowski Date: Thu, 01 May 2025 17:01:59 +0200 Subject: [PATCH v2 1/3] spi: atmel-quadspi: Fix printed error code during DMA setup Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250501-n-smatch-fixes-v2-1-d2ad9c1f2e67@linaro.org> References: <20250501-n-smatch-fixes-v2-0-d2ad9c1f2e67@linaro.org> In-Reply-To: <20250501-n-smatch-fixes-v2-0-d2ad9c1f2e67@linaro.org> To: Mark Brown , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , David Rhodes , Richard Fitzgerald Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1698; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=4rkQ3Dw/vam/Vj+imyvV8Y9YuqnRhg19j57rXz0G09I=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoE4zpE4sh6HCX0YHtu8ifWSZYIijtzq3yBuTF0 rzZi40A/NKJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaBOM6QAKCRDBN2bmhouD 17ByD/9kTC3n6CgO/RKnoXTfVLW/0Pek2pCNI0Uowbck7+kCs7+0VPQ42qPkHHI4T6iWorNe0Qu GhENCHnyqd3A2bm6kqChnDRxzS4e7Ahct2c31seIg2nLHs5HmusHPNwSC8HTnzrT/N3kFvotDsj V01lG8bCbJ8qh5PSHAqTJFHMUAVq5zdJ0mKvnMISjajAEMTVvNcNRcQAl0Q5wBllqaKNflYn47O h6f37rS32zOxHljsIuMOo99la3c72iTkFCLSOc6a1N6fRYxAPH2ze13O24+vDphIwPEndOLRFyT adnFoGHyzgqEFu8ULVxDCIPLR+ZHmPNZtvOaE0XsFluaUcGhTKqKtYhQcf586SsGBKqz5u2mRxg vO40HXN1p6lX+XZTB5bO43/DN9UcC0eXoz+bp1nlTiJIqN9vLh1fQ6zhPvZi9axRBc5Qma/RVeQ W5S0gjuVVVUiVB35Prck8VDSNAIn7RApJikZCESHlqVV2JIMgtrGPQLmq9MEcjdcOlOux3H5cQN Xr7swRKIyavFwNYjvAQtV+KfJwU38RDFDSPSa9XMSsYxRMd0CcJG6Ai+EL7oFi4PX5oT0yxnMM+ Z3GldcMCrtpxCa9IsLBZfEjp1k/MXtXtVVIS5RaUZ5j6M/50awIM3PLEocmTM9lwoKQAuEy2RAR EWKOBKuTGJOR/FQ== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B On dma_request_chan() failure driver NULL-ifies the 'rx_chan' and immediately uses it as PTR_ERR() so dev_err_probe() prints incorrect error code. Rework the code so proper error code will be printed and NULL-ifying of 'rx_chan' will happen in common error handling block (failure of DMA setup is not fatal for the driver and further code depends on 'rx_chan' being non-NULL for DMA operations). Reported by Smatch: drivers/spi/atmel-quadspi.c:1287 atmel_qspi_dma_init() warn: passing zero= to 'PTR_ERR' Signed-off-by: Krzysztof Kozlowski --- drivers/spi/atmel-quadspi.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c index 244ac010686298c58427fadc0ebfff5e62d18880..fc36751763887cc14bc71e2f398= a25e56e9c5e42 100644 --- a/drivers/spi/atmel-quadspi.c +++ b/drivers/spi/atmel-quadspi.c @@ -1287,9 +1287,9 @@ static int atmel_qspi_dma_init(struct spi_controller = *ctrl) =20 aq->rx_chan =3D dma_request_chan(&aq->pdev->dev, "rx"); if (IS_ERR(aq->rx_chan)) { - aq->rx_chan =3D NULL; - return dev_err_probe(&aq->pdev->dev, PTR_ERR(aq->rx_chan), - "RX DMA channel is not available\n"); + ret =3D dev_err_probe(&aq->pdev->dev, PTR_ERR(aq->rx_chan), + "RX DMA channel is not available\n"); + goto null_rx_chan; } =20 aq->tx_chan =3D dma_request_chan(&aq->pdev->dev, "tx"); @@ -1310,8 +1310,9 @@ static int atmel_qspi_dma_init(struct spi_controller = *ctrl) =20 release_rx_chan: dma_release_channel(aq->rx_chan); - aq->rx_chan =3D NULL; aq->tx_chan =3D NULL; +null_rx_chan: + aq->rx_chan =3D NULL; return ret; } =20 --=20 2.45.2