From nobody Sun Feb 8 20:17:42 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E485320125D for ; Thu, 1 May 2025 15:02:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746111733; cv=none; b=fOtaYOuDIBMUesWK3Q+sm4XExObFY2Vq3/BoL6RcwQt2iemAOf+JKV/U/HC5ZwADDwatx3sLvu/0kUoHEefrPQXMUc1rOimkYHOZ9JZi/RSm7q0dpkBijGYDk1GS2Jf8JRUhzKPFqFdj5qQFm2NIbSwR7VXeFfVdMPsMLW6MNmQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746111733; c=relaxed/simple; bh=4rkQ3Dw/vam/Vj+imyvV8Y9YuqnRhg19j57rXz0G09I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=snDjcfXSZrstxozOTpIJrthxuvfr0KhOfcRJcVn3H8TpFpEHyS2q5m+C1ht/kO257w26P2/uobNwrPGDJDNofOmshlOitYRZ6gJLIoIMplEzh+0x8jSq7xWCq1p0mX5jwtdy4rNVxrVHsfK6zlo/VcnUgudxUKwyvGYhyPqIJG4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bhQuQnuS; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bhQuQnuS" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-43e9ccaa1ebso1340535e9.1 for ; Thu, 01 May 2025 08:02:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746111729; x=1746716529; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+CQO3BwoDKAYLGKeUQMSLddVF7xiAI/qGk80JN0kw5s=; b=bhQuQnuSqYFE2XUWxRak+3tLVQ7hEzFTAMuDMVYSPSBszvJOexq/WKAjt6G7FLmIf6 hEW4RT7fTobFodsH93x5uILIjraALQZnD4cdK9v6GVXBGZa3RmjnwJGHDDzc4sn5XKYA xFPPx3SWRRXoOUWlVdSwD2ZlhNTRuTpYDUHz3FyU1iJQG5u7u3C2DPTqf92an0u1L2Z9 MSZ27hUosr3RdD7wYpJXJ5qmV7lq1Pqmcu52ZGleL0wU8Q4wLsQPx3Ihhtt5utf+yWLA JnX+4JCWMIoHy80S1X6z3MPMtK1i2v9dBS/bUD3edA7Vl8tqOCL1pjKHF4ppTyRZAfgh TNww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746111729; x=1746716529; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+CQO3BwoDKAYLGKeUQMSLddVF7xiAI/qGk80JN0kw5s=; b=xVFAGEYxVnIF8TeHpaS0SCkTyRnik7z5DYc8kQTVe+YcNg39x/ZLuzMp8GvyjM1TTX 6Y+x0b9iL4WAwzowmNSOQoIMm5sQH9FE/GEOvLU+fxof9p0WHVi0pXVQbg7kh8haV8HQ ylRCm5OBKb3E+LeFnfAHDsEei1P1TKguApWa3JU+cyVQWhgFapVSatl3qTrmDN74s/OG 0rIExiufq8WbDtV4n2aRZsfwHdkl0bk8PgIV9TZoI2zliZmx32hNvahOAwsewhl7xjmE zOgJByixWXLGS0VapHa5tExKsmP+rGQpKR+vA2RxFf+iOGgzEX66wQqyWGt89KoKnPNv V0Wg== X-Forwarded-Encrypted: i=1; AJvYcCUVnu2yr1XBnzVZECIZZqNq4SWKXRRKC81nOu9W/te7JS5ZjXb4NOcoTO+OghanIbDSu42AA1Cm1Vb6Zm4=@vger.kernel.org X-Gm-Message-State: AOJu0YzIMSIUB+ux7GDCHUm/Mb5xYQxd7FW2P47RTjh6HpaL22U3EyUw YEe4gKnKhayTrqPXfSLa94K7VT5rwhwO1Q3YBaYPs2+It37uCPGzmxkaCyZj8jI= X-Gm-Gg: ASbGncvuEYmwLwgy/PSoYufvcn11tRplJJmLLRL+lZo5h2ohCLtbzKkkANXsjS7XTIu yixfew02H65YLosDMs3/M5+yO4eM21c6BxTUAiWE3A6a0fATbwNlXYtJFO9qFKR4CaKdktpkpqm bvRGAiH4e7pRXwQsJYs9k99Ixbi3H5idQdIAriBrFZI587JHVRMnW+68dY/qO+b5WlRiwF53RwX dH/817Ck5wjJdOOyUs/nniyMeNLZk6iXMgbVFCPuPBQcevsriNokbPPchASAWtxQcHLwmavs66w VtGF67VLhTLsTgeC7yRTk9VXtPTJ1eB8X9Pk5d72UaKFeCBu90YmvdzA9ps= X-Google-Smtp-Source: AGHT+IE4vTsyhTKjuwrkxiEbVaqWLWprrAFI6LPkc5oJ6Tw5j0urpY7Zf4f4AAtn0dsslPS8UEL2JQ== X-Received: by 2002:a5d:59af:0:b0:391:3110:dff5 with SMTP id ffacd0b85a97d-3a09404c7a7mr791880f8f.5.1746111729092; Thu, 01 May 2025 08:02:09 -0700 (PDT) Received: from [192.168.1.28] ([178.197.207.88]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a095a4702csm1033190f8f.40.2025.05.01.08.02.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 May 2025 08:02:08 -0700 (PDT) From: Krzysztof Kozlowski Date: Thu, 01 May 2025 17:01:59 +0200 Subject: [PATCH v2 1/3] spi: atmel-quadspi: Fix printed error code during DMA setup Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250501-n-smatch-fixes-v2-1-d2ad9c1f2e67@linaro.org> References: <20250501-n-smatch-fixes-v2-0-d2ad9c1f2e67@linaro.org> In-Reply-To: <20250501-n-smatch-fixes-v2-0-d2ad9c1f2e67@linaro.org> To: Mark Brown , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , David Rhodes , Richard Fitzgerald Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1698; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=4rkQ3Dw/vam/Vj+imyvV8Y9YuqnRhg19j57rXz0G09I=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoE4zpE4sh6HCX0YHtu8ifWSZYIijtzq3yBuTF0 rzZi40A/NKJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaBOM6QAKCRDBN2bmhouD 17ByD/9kTC3n6CgO/RKnoXTfVLW/0Pek2pCNI0Uowbck7+kCs7+0VPQ42qPkHHI4T6iWorNe0Qu GhENCHnyqd3A2bm6kqChnDRxzS4e7Ahct2c31seIg2nLHs5HmusHPNwSC8HTnzrT/N3kFvotDsj V01lG8bCbJ8qh5PSHAqTJFHMUAVq5zdJ0mKvnMISjajAEMTVvNcNRcQAl0Q5wBllqaKNflYn47O h6f37rS32zOxHljsIuMOo99la3c72iTkFCLSOc6a1N6fRYxAPH2ze13O24+vDphIwPEndOLRFyT adnFoGHyzgqEFu8ULVxDCIPLR+ZHmPNZtvOaE0XsFluaUcGhTKqKtYhQcf586SsGBKqz5u2mRxg vO40HXN1p6lX+XZTB5bO43/DN9UcC0eXoz+bp1nlTiJIqN9vLh1fQ6zhPvZi9axRBc5Qma/RVeQ W5S0gjuVVVUiVB35Prck8VDSNAIn7RApJikZCESHlqVV2JIMgtrGPQLmq9MEcjdcOlOux3H5cQN Xr7swRKIyavFwNYjvAQtV+KfJwU38RDFDSPSa9XMSsYxRMd0CcJG6Ai+EL7oFi4PX5oT0yxnMM+ Z3GldcMCrtpxCa9IsLBZfEjp1k/MXtXtVVIS5RaUZ5j6M/50awIM3PLEocmTM9lwoKQAuEy2RAR EWKOBKuTGJOR/FQ== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B On dma_request_chan() failure driver NULL-ifies the 'rx_chan' and immediately uses it as PTR_ERR() so dev_err_probe() prints incorrect error code. Rework the code so proper error code will be printed and NULL-ifying of 'rx_chan' will happen in common error handling block (failure of DMA setup is not fatal for the driver and further code depends on 'rx_chan' being non-NULL for DMA operations). Reported by Smatch: drivers/spi/atmel-quadspi.c:1287 atmel_qspi_dma_init() warn: passing zero= to 'PTR_ERR' Signed-off-by: Krzysztof Kozlowski --- drivers/spi/atmel-quadspi.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c index 244ac010686298c58427fadc0ebfff5e62d18880..fc36751763887cc14bc71e2f398= a25e56e9c5e42 100644 --- a/drivers/spi/atmel-quadspi.c +++ b/drivers/spi/atmel-quadspi.c @@ -1287,9 +1287,9 @@ static int atmel_qspi_dma_init(struct spi_controller = *ctrl) =20 aq->rx_chan =3D dma_request_chan(&aq->pdev->dev, "rx"); if (IS_ERR(aq->rx_chan)) { - aq->rx_chan =3D NULL; - return dev_err_probe(&aq->pdev->dev, PTR_ERR(aq->rx_chan), - "RX DMA channel is not available\n"); + ret =3D dev_err_probe(&aq->pdev->dev, PTR_ERR(aq->rx_chan), + "RX DMA channel is not available\n"); + goto null_rx_chan; } =20 aq->tx_chan =3D dma_request_chan(&aq->pdev->dev, "tx"); @@ -1310,8 +1310,9 @@ static int atmel_qspi_dma_init(struct spi_controller = *ctrl) =20 release_rx_chan: dma_release_channel(aq->rx_chan); - aq->rx_chan =3D NULL; aq->tx_chan =3D NULL; +null_rx_chan: + aq->rx_chan =3D NULL; return ret; } =20 --=20 2.45.2 From nobody Sun Feb 8 20:17:42 2026 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69DC2202990 for ; Thu, 1 May 2025 15:02:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746111734; cv=none; b=tDIFeegW2+74OZiZ3sqIx+8lUVxyp7h5lZe1/ASZGBXPwtaaFI24Qjd2WMDI0P5vEggA2fp7KQYF3brZbKfePSuQ4ODUHqBC3b0qmFogZWuHM/uwnvYLyhbSJqxPeRK5GMDCZxUh+b7nK85kZLh6IM3KB9c9Sdd5KKC2FvuNh4Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746111734; c=relaxed/simple; bh=wbJvTFF93vO4XDJ3t3HtJwaTtycPFJ1qGS1kFwex8VI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PmXfjm7NSwpPKW0WQwKaXvKdbrjgcPxU/oP8qv3MsPL7ylJn1O3BC6rg+biWsBu91JodXppA9s3GEqtIkLR6MPSBZj2Izrow4eupR0S2apt9lmQugN/Aogli3h+wOKw12Hm39GDyx3DqV+ZKhw7WeFVIWgoWCArw7fBEfDgUDO8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DL/WqiMp; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DL/WqiMp" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-3912622c9c0so15341f8f.3 for ; Thu, 01 May 2025 08:02:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746111730; x=1746716530; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=cjFuL+Hxvp62ckp62d4xwkNy5J2SbdNnB8mUiL94WtI=; b=DL/WqiMpmHmG7xwuQNyl0N8kugkWsyVp+aKJg4UF+UgSDjOf/e79DYP10ImXkq+KQ7 4ED+6e4dg3F63aBc5QagIBDHWOmzK2ZRR1/OzjBZOx2Kw3MUDNsJcHWpyrhQzqACQchV vCiKtmb/1719Y/ppSAGtwvlQIR8hgxxkdkouusE5KcMw7GP0itQ+mbWbkXg4KKp/k1x3 012+iiKrbgUmw84yexLY4bKRkHYY18+zinh9zinCmKorqedksjj2mE/8QdEzHpJhVcjj 0Wgcn7dLCGwPix7KTH8cycJMiU2Yq+WYJ5r4lFxrQTM+UD8QTZOB70chNaw0XZHv3JN0 HrZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746111730; x=1746716530; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cjFuL+Hxvp62ckp62d4xwkNy5J2SbdNnB8mUiL94WtI=; b=vi77p8ImZOwWXJf3KnvtYTDf7ynO8h3nDNPlEGOqhJfs+HVIV+XdPaJI4Cd/9dvGsU nKfqE4JyAIX/Fpq0uRd1EZl27zSGUfcy2hEaXHE8ZdjLi7k2tUwSQN3YDzqNvxh7sWpP AlfcWt9Zoz/XaD3fh/PNH+ZMm3ZuSHYRLd1R/mll4vd/dIWaPn/x/2RKToRjWIl+/P0F veFXMeWPL/SDravxs/OsMkbX2DY0MxnbvA4O5o7dgDlltm7LjJ6zUt3Od8aXLLyT4iqu YnMKNgGV7+LVNimNcqybj8vWqgWdGpTYTCdu9ICxJIH3uHvqJD3hw4yG0CinqhD7FPAJ xOVQ== X-Forwarded-Encrypted: i=1; AJvYcCX4ePPD/InoEaQOGzpsE7hDVit4ziC2TSvDVtiz7xjb1M6GfsnzorOP1aP/VqFJL6im7wrHX4CfBPKtkUA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5fagOm7A/Lpe5QIwv+0Y3WHV3SuG0i8anZ44WXbSl/N0s7GGi ZeL2WOEqBmmP4CpkmgMfQdKcHVAcK7rhCVnSEFOfXl+f4eofIf4YwxJC8LsjOcg= X-Gm-Gg: ASbGncufXo31jRtxjKEeb3U+Qp68hdgHcoycTL1DhScldh3EDPpRJgzbnqEmXtEuZmQ Ip6mEiVCOXnTMBat72yB3TtDRlNrTh2Khm9bqpTnlSMUND7a7JEv7KdpqmhFhPzGRRqjHVJVIAl MRNpPMw6GRRF6OW+0TI5xq7ob0rZZ9Lc3pEcQBpmh1F09YsZRf3q9jxVOdSAs1RetFa+MDKAsvE T+cDquqYA+A7AFxCFtstpmVv70wv22/5JLeaJa9axtAR0UZZP0AGbmTtbjyvl/xFbmBkYjmXC1w o7Gm3n7XzEl1E0plh4JZGTKsKENXoymVuMqxMHZESts30BfHIV9JClCN9SI= X-Google-Smtp-Source: AGHT+IHx8sWqPznlt7972Iuo2Aq29rBeEzunJHQrQZKTzx2L2RYiG2zZqFAc0QZBwI42PaKv7Rtz0A== X-Received: by 2002:a5d:47c5:0:b0:39c:12ce:697 with SMTP id ffacd0b85a97d-3a08ff740cdmr2119607f8f.7.1746111730466; Thu, 01 May 2025 08:02:10 -0700 (PDT) Received: from [192.168.1.28] ([178.197.207.88]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a095a4702csm1033190f8f.40.2025.05.01.08.02.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 May 2025 08:02:10 -0700 (PDT) From: Krzysztof Kozlowski Date: Thu, 01 May 2025 17:02:00 +0200 Subject: [PATCH v2 2/3] spi: cs42l43: Make handling missing spk-id GPIOs explicit Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250501-n-smatch-fixes-v2-2-d2ad9c1f2e67@linaro.org> References: <20250501-n-smatch-fixes-v2-0-d2ad9c1f2e67@linaro.org> In-Reply-To: <20250501-n-smatch-fixes-v2-0-d2ad9c1f2e67@linaro.org> To: Mark Brown , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , David Rhodes , Richard Fitzgerald Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1111; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=wbJvTFF93vO4XDJ3t3HtJwaTtycPFJ1qGS1kFwex8VI=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoE4zrtu7znQCsit8jnz6Ax+qO4kjdY1hQPTmwI OVVwvysS82JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaBOM6wAKCRDBN2bmhouD 147VD/972YtDAImuxcHPXe0MWIDPqszTwkbi59mXMxbvRK6obHdCyrpJkqfn024r4nmdDhOiPb9 4E1FN0hEFSk8JGbXFmIw22G8Bwq5S0k76HOEPL+b0sGuJi6v5uBoyCVhla5wYn7WGuoKF7wMfR5 3G/CPkg+jGFN/OiG3QKQ5KM8zlCxT0gAANfomMj388nuUHZSuVD0TuhI0yZS5hROJ8X1RuDeHqt /qAObojiLu5fNh/M4xgzFtwpyfd9mR95NFNuR3GYoUIomx4WH0bVbEYFEQuafiUhgf98GIi/yun KWucCUhMHpL+B5R5nnhr0lp+gG+9vtbSoNEH2FHo7Ge0+StqKh4wprKlXgVF7Cr7VV6aBZxm6Lr LFf5Xov+wZDaUzXgUpRXCYskqUSS4vnlGHlENlY4WU6Gx1pZA/INSKRbIko/wBrLQsnBgaJ8zQy ez7jNZlgzRl0LoeE2weS23vDqTEDAsxfRtaAxIky7g0tiIq6IAZmMHkoH58PdxPiG7tmyA0O0bw WdP11DStBXyynr8D7wkqgC9snxJkAFL9MuHjwxCdnJJlJhJfl6kOKHeAXSksD0tpm/QXvPH3cKY ExiuTU5tkPKjs2lVv1y8RyO4+fmuArAc2AVddNhlCmhSviquLZH4CBGjenXnX82f0vcLkiZLOSJ N3UJhd6BH8beTlQ== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B gpiod_get_array_optional() for spk-id GPIOs can return NULL, if they are missing, so do not pass the value to PTR_ERR but instead explicitly treat NULL as acceptable condition. The old code was correct, but misleading because PTR_ERR usually is used on errors. Reported by Smatch: drivers/spi/spi-cs42l43.c:241 cs42l43_get_speaker_id_gpios() warn: passin= g zero to 'PTR_ERR' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Charles Keepax --- drivers/spi/spi-cs42l43.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-cs42l43.c b/drivers/spi/spi-cs42l43.c index ceefc253c54904b51a12ff112988d1dfbeed39c1..b28a840b3b04b5a4cce15539188= bca02bf36716a 100644 --- a/drivers/spi/spi-cs42l43.c +++ b/drivers/spi/spi-cs42l43.c @@ -237,7 +237,9 @@ static int cs42l43_get_speaker_id_gpios(struct cs42l43_= spi *priv, int *result) int i, ret; =20 descs =3D gpiod_get_array_optional(priv->dev, "spk-id", GPIOD_IN); - if (IS_ERR_OR_NULL(descs)) + if (!descs) + return 0; + else if (IS_ERR(descs)) return PTR_ERR(descs); =20 spkid =3D 0; --=20 2.45.2 From nobody Sun Feb 8 20:17:42 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D11D7202F67 for ; Thu, 1 May 2025 15:02:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746111735; cv=none; b=cUg+6ws77U3RP91cok/6hE+pZu0xWqnh5QTDdQsy4lTImLmv0kbiZUFdAwQ1SuCaEXWdrB4urMt/4dn0m6LlMe4mhjpSOg3Jmel1KrOop8Bv5ExIetX3xxB5ZnoCqOeJMMEXiGuIaxeRror9Hv4kzXCKInHBbu6MMmvP4B/NVIM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746111735; c=relaxed/simple; bh=B3v13NXCER5k3tKhwX7vqb0mye7ltzvO1U+oUASNdgU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bAAPETVn3VRriHaUusDpU3he5noJHQHcOZxhSg2aADaufhDisqcg6HsQF2McbwLOarFlEPY4e5qBIcRrDbXtTG76N2Fipw6ScmxiTQUhT+mGgT9SvhI4etW5USNr+mY5YCjh7CVqRIo/gpFuaFowOdmnr07Vn8JG9WQf+gZ0g7Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=cJZzoNfK; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cJZzoNfK" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43d4ff56136so1499795e9.3 for ; Thu, 01 May 2025 08:02:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746111732; x=1746716532; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=0Z1CSMjo4bwXac777IKPq+E/WNf0vRomoDLRk/F823M=; b=cJZzoNfKaFVs6Wa631fHAnHWOWAi9tKBcGDVbS7PCUwViKCuPJ6mw81yJWwjhxjP7I GzpLWXRPuurO5a9CKsGQVBD5gFO20r5wziwHOAMIhBjCTaGvvmxrRGskZn8NmFsAGRqb PiMBPpaePBnbC0n0wLuH1/Y8jUICHDOJPP9q+GclCkrq9GtV2yhg804ykRTJU9qpGzIr H86xd3uqLPjnQoNFc2TCH/3no813MUhZRClYrlVzUFcm7/Ntg1EBFwrzjFYzNfLTQ9eb nnlWJZEnPNmrAa7t9szWIB9Z1E+On8v9iuTZpSxcbge0NPSBYuWCzkUtLTiITUHjQgcH GTuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746111732; x=1746716532; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0Z1CSMjo4bwXac777IKPq+E/WNf0vRomoDLRk/F823M=; b=OC+AgpETu6bQjCCu4p69uPItM+/oH1IlFNIaFenhUD7RpSQnTN+XG4jYW26cfq4fpj xhL3SbXMghz8oAf8d9dVAUT1zGr8J16ozAyjenD4jmNahNIN/FzfAmyiF6S6Ax1o+kiW +o3H6tmG+VvjjYKCVMajC7eTtptYoZj7BIhGZ7Cj0C4VZY8V6FRvW0wmXn9QtXiJGbSp QU6eoGzogBfjxY6++Os2kLgA660lgxGgJqf84ucF0tXk1lPHXbbyM6to1815XNTIRq8d /v8q2zDMBOD3Fk8nuuGme7/9I3cMbGNHKnzx2oxRJbCyr7cX3v93QYlCEn0rhj8Wtn2J nl5A== X-Forwarded-Encrypted: i=1; AJvYcCXIHrP+nkMarlkBAsWiBrzaES4doFJrravgyzz8CDpV1GsFco+uy2LR2i0H9O4qo4sPT3mkMPwhjCKdL5Q=@vger.kernel.org X-Gm-Message-State: AOJu0YzGRYR8+qu0kIxGt8qnVVdXabLha203HDqP4naRxgmwIpdyepxu 7zZk44Suu+77VY0AyNBxJWJAXWILyhReojQYO2dCxd7I5ZcIdWJlmsChYadnIqg= X-Gm-Gg: ASbGnct9mKxcwtaF/AhNO6QsBVKMSWBmucWeKiyYyHQYTwsjny8A7/q+bqzPMUie2Cm XYxWIUYCqmgXqI9NQrmFGBMLaaf3a7/aOy2x8NFF5TvxEFPGzOmYoF/hmliMPnaG91e3Xhx0BRA JQ4iL8InwQGnYZD9pc7uilrdvsCoXxity+P6bVuQc/UHw/HP8prEFtMOf26oe6l9+IHsHn4mjbW 76NsUKdY2tDXZpbkfSxSRMdGp4poUh3359eyuOzWYvsjVUm6HIvAQrAFH0pDWCIOKLoNi3Bv5DL Ow+j7oAq+cZQyXcQplERjrbyYOB66ks39C6xXBygnRa6/8mLMJVO99F9AMw= X-Google-Smtp-Source: AGHT+IE0ENZdHGkQvgGoH2mnDKlJJ809LkSCtAMhmB4rpgM9Z08EWOHgpBqjUop6OrvJ3Ac5c98Akg== X-Received: by 2002:a05:6000:1846:b0:3a0:75ff:261f with SMTP id ffacd0b85a97d-3a094178fb0mr816964f8f.11.1746111731899; Thu, 01 May 2025 08:02:11 -0700 (PDT) Received: from [192.168.1.28] ([178.197.207.88]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a095a4702csm1033190f8f.40.2025.05.01.08.02.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 May 2025 08:02:11 -0700 (PDT) From: Krzysztof Kozlowski Date: Thu, 01 May 2025 17:02:01 +0200 Subject: [PATCH v2 3/3] spi: cadence-quadspi: Assume device could match via platform Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250501-n-smatch-fixes-v2-3-d2ad9c1f2e67@linaro.org> References: <20250501-n-smatch-fixes-v2-0-d2ad9c1f2e67@linaro.org> In-Reply-To: <20250501-n-smatch-fixes-v2-0-d2ad9c1f2e67@linaro.org> To: Mark Brown , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , David Rhodes , Richard Fitzgerald Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1483; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=B3v13NXCER5k3tKhwX7vqb0mye7ltzvO1U+oUASNdgU=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoE4zs9gNikiLaGr7Pqc78Xp2+VrLMMAjp88bwS hB6yBtxryWJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaBOM7AAKCRDBN2bmhouD 11VpD/wNiGdprHFBTqCt2CnLkmyOfWKabgzUmeNPQie00KzOgJVHUUjWU4fQaeI30mVt9rfpu10 llp9+NafbiQoqC/9fHr8ckF1T8bTk0UxAAmqyeIoxupKtWuT8SpFRVhzfWUWaxuAzgzji3dPDHK ljhiroQ5K9bYLCIjJ3DMJe2ajG458Q2H7Hj2Pgm0oyGZP6zVIA7fnv4p26E2xOIBkGaZWo57pFe bjmmIUqrklHrbwgPT9JjxthHgNtY9wYmOEietCJq06B9o3ATCvBI8OsvrP2VaachROYBHaEKiM8 9kifoZWrIGLKbeMbGnJwami0uAWC1TckkzhDv7mVsqLKfToy9rFkSof7/756aD555PbJ9WQ55WJ ctyJMPc/lNwv7/qwagVd5gAb0lMZ3MWpgS+ZwEW4JQADcjC/B2Qvl2z8S05COKdPgBV8VaX7Y8p UuPfvFDlcmfyuy9ehhlRV3iO/nErNWoZK3M5rfTS/3jBgM2xcLy3CkdJ6+r6Ec2DJBVGtKG65Tu Tg87N0s6R+JDC6j2EAjrHOK2giHvXT23YzVbekBecuiJUBmydauJwxTtDQmzpDRFbWz0cB9v+ti 5xN+x7ArX5Zwm4w2++0vpqUKE32Jr1CVH3vNQcABVwPWPvo6bd0gkioWh9nKgr83W+A39JkCwYD 09YLX6LPBaP50/g== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Driver has only of_device_id table, however it also has MODULE_ALIAS() for platform name, thus assume there is a configuration where this can be loaded outside of OF system. In such case of_device_get_match_data() will return NULL, which is already checked in one place of probe() function but not in the other, leading to Smatch warning: drivers/spi/spi-cadence-quadspi.c:1942 cqspi_probe() error: we previously= assumed 'ddata' could be null (see line 1885) Driver should be consistent, so assume device can be matched via platform bus and of_device_get_match_data() can indeed return NULL. This is also possible with malformed DTS on OF-platform: no unit address and device node name matching driver name. Signed-off-by: Krzysztof Kozlowski --- drivers/spi/spi-cadence-quadspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-qu= adspi.c index c90462783b3f9f05e477d337ab4187224992c0a0..fe0f122f07b0206e80cf89bd031= 106bf8051c789 100644 --- a/drivers/spi/spi-cadence-quadspi.c +++ b/drivers/spi/spi-cadence-quadspi.c @@ -1949,7 +1949,7 @@ static int cqspi_probe(struct platform_device *pdev) =20 host->num_chipselect =3D cqspi->num_chipselect; =20 - if (ddata->quirks & CQSPI_SUPPORT_DEVICE_RESET) + if (ddata && (ddata->quirks & CQSPI_SUPPORT_DEVICE_RESET)) cqspi_device_reset(cqspi); =20 if (cqspi->use_direct_mode) { --=20 2.45.2