From nobody Mon Feb 9 01:06:59 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 126331DDC07 for ; Thu, 1 May 2025 14:33:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746110017; cv=none; b=GSosMw5BlcsCstlGy33R09K3U2SZM+QaMaMnUeO5b+QS9XxGQCDEWgTwU2JxOGudXXOrfShBm3CUhkNK8u2Y2JDkLW5Afj5WlkrPHfeH4seLxlbk1qzKW9W+aLIqI8ycVyHprvxbzYtps2Le/gA0kj6HBJBo4Tej/cnDR4eOsrY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746110017; c=relaxed/simple; bh=KOjPiRvBuzTdyA9KgYekNongRZXa69bWcNpO3R6H1lo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aeISC3AkRacPuUnIsraoTnJQ/E5hB+LEH9dyPuesRUl4DXmxNr2ylKmwpuR5UiDipc3W6kKlldVjXu5VOjdadStURXZBdKBxQwiHRypXKiOi1Pn5cod/yJMZ5rlawFkyw7xbWVvV1sMdJ/qUd3yyvgMKNbAwMC+WhJrAqLfH6DU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GFb/OZ02; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GFb/OZ02" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-43f106a3591so1316745e9.3 for ; Thu, 01 May 2025 07:33:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746110014; x=1746714814; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CzBXO9nIkVYWaO7/44VWwwopE5puJwylSBUwTQi6BfE=; b=GFb/OZ02l/UIoOOxyNbiY9HLKXW6HKqM0fPKdsavzUFav4h+sxtGyPwfe+9j4+Wckj yyNrVKzv1oinw1Uw5oU6HRJYp3dOIYd0nbyM4EewITylUCSRwkNSAjY0CoBEAGC9LsAK bOj0AmvhlYS+sRL/0AYPyFu1hbODVV6f6RbfKj94UE1cqESlaSdKCBT005UdbRPrT+iS m/D1EM3OL6FC21v+cU3vK59rhEGg0rsD5fI9nAC+JMQAzWQoW/DKYEMXODmMbXMUCK+O dr8jGZww2Khc4DLbFoybhIlkJIN7WbFImvvV9mza1tOf9JEMl4vkGUXe34zioUy0aan+ bpvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746110014; x=1746714814; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CzBXO9nIkVYWaO7/44VWwwopE5puJwylSBUwTQi6BfE=; b=HEqe6hb9D12yGUrtEyoPJkv2BLzU9nBVPHUjISf7uPRL+kaVxKwtC3EsnwdTxUEl4e 11WZ9sYJrr3yqi7DOM/qNeLnZSvXmpbliGhA4xibirT7xo95g4YgPUXCe3Oq1yeYYi3A 3v3+03BCapORX8QqvuDf06IqQT093aoRk4qzkXrVfmJ/hA63QTJ3+ygUkEMLE1w3raYn nH24+CsoCOk99DauLmr30SINnLEi7rkA6ZJoUJHllKvKvEdAmo+saLl26Ylly9ZmcsOz ERACUjpu/30OglVVDxI5vYNMiN+nlRyQnkJq8W+6O0/GsucTLM0uWO2v7FID04G0o0Ep M8EQ== X-Gm-Message-State: AOJu0Yw2ZaGZrbphxVrN30Q69VDzsqHB46CK3q9oRKcOXBbn69DWxy+f maUUlRlthTQRLvgXu56KTOR6q9UM8ldhDn++K8qLXkAuXt04U6YCCGDRpCS0NaQ= X-Gm-Gg: ASbGnctnNeuW9P0Xsz+Ui2B9pE8/kEcFO3CzqEk5UQSpP4KM15msjsiTO0x67f92lYg 8/Bs1eQAFIYgvzxmJcOz2IF7aOkydIU8vDB1KTh62E7Ilqvz05pmko+PchsjyMVJXYM57OK0tQt LWfhr/KPjFV+Y+X+EGMClRiWFsziaMQDUq55f29kj5kZl58tjC7DuS7GcQr9g0dmAO8YXenx8XE vZFC7qap5VGDjwL0MmcxDIfIrm53ITPu9eOd4LZdRtTRwfsdGdRTEM5W5VCVBCwLLSv6Cd9p7KK u9LJNfezvBEK448BtbOfTZKAkBrBaWP+0ZERD8BSJpD028IloGwlk3aqqkA= X-Google-Smtp-Source: AGHT+IH4IUQwdThBuCbMlKrsSqNcIXMd+TpCdswbDg0ShHYdnxId4ranmqCz+wI042/WGegL+9TAZA== X-Received: by 2002:a05:6000:1846:b0:39c:30d8:a44 with SMTP id ffacd0b85a97d-3a08ff5c739mr2055285f8f.5.1746110014390; Thu, 01 May 2025 07:33:34 -0700 (PDT) Received: from [192.168.1.28] ([178.197.207.88]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a095a8ef66sm957636f8f.88.2025.05.01.07.33.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 May 2025 07:33:33 -0700 (PDT) From: Krzysztof Kozlowski Date: Thu, 01 May 2025 16:33:21 +0200 Subject: [PATCH v2 1/4] extcon: adc-jack: Fix wakeup source leaks on device unbind Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250501-device-wakeup-leak-extcon-v2-1-7af77802cbea@linaro.org> References: <20250501-device-wakeup-leak-extcon-v2-0-7af77802cbea@linaro.org> In-Reply-To: <20250501-device-wakeup-leak-extcon-v2-0-7af77802cbea@linaro.org> To: MyungJoo Ham , Chanwoo Choi , Hans de Goede , Chen-Yu Tsai Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=899; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=KOjPiRvBuzTdyA9KgYekNongRZXa69bWcNpO3R6H1lo=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoE4Y3ckCkZYT0KdcusB0kaLX7OrHflrHyVEb1O fAEfFOBBhOJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaBOGNwAKCRDBN2bmhouD 1wHHD/0Sa1jUTLuT8X7ZTK+300bPK2WqFlx/xQFBrV1IRLpJOek6Degsp5UeWgt5hSmuAv89njD ez9nfcsN4dSS0Tcwr8BHuolknSE+vJciIPggBmUdVIor9vvJNGxwFKB54qUlVxMgUcQ7TZN6Nwn uoJ3TjryXn9Y+zbt2FYqpDl4ngdkBoqWAL6Tm3nJC8znIRoc8z60/TF4gF236uluGzH29QKe4zR FaJU6eQQemMGpJ9YscVQWLoKldgDEp1sDmdPVHbo1/97Nafu3xt4zrgFaeoHMANLxPZZ2eiUusH h5QRE8qyY7wFwSdc3CHum1eqBMZYLbFBvyRaPTLsuzfsCzhvEJ8MmqDbXzqVuBok04zJpNK8Y2R Vs2ZoeqOb8PPm0R38LaZx/LGKDjBiUCuFcFJV57RWPt+Tfw6qQF2IDpmssoM73JAYSmRoHFf8r6 GJz5A7WEVdvxcOvYPfIiFzqR0Ha7T6iUlT6/R2frX/YqNqa9ynk3oy7v3FI89NIwlybWWGtqkf0 Da/Mqrhxb1larw86/tMUwMuBmwk0qUyPhz5EMVkMEVgRibYiLwZHQ7hp3uqg/QHLK5qTQJ1qmFR 7WBYDt2zeErvRnfCuOlBAT4gpgSI58tsEVmAnw/cGXjz4C7TRc8lkqmmBbvkBdC5S2W4j13tyaN PJH2GpeA6XuJVVQ== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Device can be unbound, so driver must also release memory for the wakeup source. Do not use devm interface, because it would change the order of cleanup. Acked-by: MyungJoo Ham Signed-off-by: Krzysztof Kozlowski --- drivers/extcon/extcon-adc-jack.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/extcon/extcon-adc-jack.c b/drivers/extcon/extcon-adc-j= ack.c index 46c40d85c2ac89599ffbe7b6d11b161b295d5564..557930394abd25771799733a221= 21d1f8e254918 100644 --- a/drivers/extcon/extcon-adc-jack.c +++ b/drivers/extcon/extcon-adc-jack.c @@ -164,6 +164,7 @@ static void adc_jack_remove(struct platform_device *pde= v) { struct adc_jack_data *data =3D platform_get_drvdata(pdev); =20 + device_init_wakeup(&pdev->dev, false); free_irq(data->irq, data); cancel_work_sync(&data->handler.work); } --=20 2.45.2 From nobody Mon Feb 9 01:06:59 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7177D1F12FC for ; Thu, 1 May 2025 14:33:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746110019; cv=none; b=AxxfAjKX5LoSbXpZrnCBMIVoSAdqXOautrFkd57YcJuoTAvn4xee6j3pkrjy7YcMu6elFHceRGiBBz9uTOsXpSo8EC2xaPrQvJGDJZChNHfteO6x8hMYTiSDE+OdHqpfRDQ3S6HPcQ9DhqxaLYXBZHonmc9a3gnLCiqZ8Tjh7Pg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746110019; c=relaxed/simple; bh=i/9JegHkYn3hf7UKBycAb6L/6+ZSLW212aokZlZbpAM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=b7TMnyP4Rhq/unGe1FBLYEr/gteXcRHYniTAhdajnbck+5GFBf4gJgvf5w3naQEXKexExTWrI7wSwzTCs2WpnvOlpy354craQqShO4Lf67onNJzNUOz7UBXzmVl1xk4eDY6hlOB//oraiG2Elm9IQZENbqyKMYTJta+SIhjQDdw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GfHIWhqp; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GfHIWhqp" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-43cfe99f2a7so1684955e9.2 for ; Thu, 01 May 2025 07:33:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746110016; x=1746714816; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=235YzEa2hhjg3MerjPvZinFHZ44M460Ui9/2wMQKQn4=; b=GfHIWhqpjBEmMJD7lm1OeWcrdg4JgAW4dWWbC5EwFEWS1NHkY9LQ9qU1QUCP+7v8Ig +/gQfFZhYGVsimYJZRyPGgil3ldlikSwXB68kklphGtXDj7BA0sO9ihG6v8mO3kCOD9B UFRQ3qd1A/83UICDRTAVHvZdWiynD9gVzgCym8lOdybBGwnaVppv5AV/GLh4JIpupbQX QeoQxL2w5OCLOt1VLMAwbZzX+ERF0zIjq4+wjuS9h8zHtwz+bMDhXmALYJ5fI1G0cNM+ 2UXR8zvM3pq41RWZarEuTW/bYObdRejBEXM8Ri44yow7aOMo8uBJvSkUEwKn5nj7WWVI xtgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746110016; x=1746714816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=235YzEa2hhjg3MerjPvZinFHZ44M460Ui9/2wMQKQn4=; b=s38P8HVw+OJH1DLy5IY4CC641SgZmRoZ9DL9AZZ+548PmWRNLTW464fsRYd+MNsO8+ O7wYtaiZkk9wSlPWvXlw7sdPdyM8CymnPAcqcYKGvTisINeIfqSJt4e+hDE7EhAWh9Ti eN10HfkgQ+TNWdTBc0nk7xcQTwXOqE+no45V1TnkcUNNayZHuuKNaleSgg4HpjqMsjzc WzwX802Wu6o5NC5lLmGY91lYKGRfsbCkEsujA6g4ELbBebtVa7VhWw951vceNGBsGsmu GPmAkW/o0uQwUk/VAio9V7HXFfa1WHDha/GuifDK6lYUN8mqvTV7DUmbf4o22m7i++Nk MU2Q== X-Gm-Message-State: AOJu0YwOVFAZDsKeyUy2BnblV+SiR9JGVU+3uKbb6hpDrHKMwoK4JoFX K0uzxvT73WUVVChsH5bKi1GLWaOtzV4qyhCVPg2ulaiBdlzcuBamseSNfst9Kr8= X-Gm-Gg: ASbGncuENipcqpqDlmKQqUboAY8d0UjISGKwHfvyQhjIPboYXt+qQMQCxE20TLWOXjl TMHKVrTQ6kPDdmddBnQaTyZKNerk+5d4Eibqh5ci6UfdpvSsvolX+XG0tmOGRK9RxGbH70uM4UT dndaPSEEIv5D17S5t7FrDNVlZEEs5Hn7Yoz9y2pGzmWAAPg0J8hH8RGck7i9Cnc/cEFYsEXGGwx 8XrE1JtSYxvkvQ9vlLqK2T+r0QA1cfYXWzOSIkCX0FbK8XHxw/f1KYJriIWS2VaYo8cnpTbmPMU XojPrknonwXahyZJUYw77/Be/+mG1wuhlS4gLxSRiaXnagjfQMRourWu7GU= X-Google-Smtp-Source: AGHT+IHM+H9W6H03/DSmUY0qzExdl+2h9JqhPuoEYvmYnQ1kcBLAjkYWDq/sTkuyzxoH0CkcdQ5N1w== X-Received: by 2002:a05:6000:18a2:b0:3a0:831c:ce4e with SMTP id ffacd0b85a97d-3a094178ed7mr696817f8f.12.1746110015720; Thu, 01 May 2025 07:33:35 -0700 (PDT) Received: from [192.168.1.28] ([178.197.207.88]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a095a8ef66sm957636f8f.88.2025.05.01.07.33.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 May 2025 07:33:35 -0700 (PDT) From: Krzysztof Kozlowski Date: Thu, 01 May 2025 16:33:22 +0200 Subject: [PATCH v2 2/4] extcon: axp288: Fix wakeup source leaks on device unbind Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250501-device-wakeup-leak-extcon-v2-2-7af77802cbea@linaro.org> References: <20250501-device-wakeup-leak-extcon-v2-0-7af77802cbea@linaro.org> In-Reply-To: <20250501-device-wakeup-leak-extcon-v2-0-7af77802cbea@linaro.org> To: MyungJoo Ham , Chanwoo Choi , Hans de Goede , Chen-Yu Tsai Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Dmitry Baryshkov , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=819; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=i/9JegHkYn3hf7UKBycAb6L/6+ZSLW212aokZlZbpAM=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoE4Y4qnk/g4XV7me9WouKqm9DXqHuXluUpQfFh 44yOz8PFqaJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaBOGOAAKCRDBN2bmhouD 1zSDD/4/C2bZx81xYPkD+nD8q8jsTtnM7Tz9rzBhA+VDWRdn9Nz1CTuSZ62C1J5w2Nhn7BFtuJY MWEUiigYZrgv/L7einC9teL35A4C4XbTGSeELk6gHyyJRC9t2U8RHQBaC3BS82BqcnwMm3nRzM/ hmUBj02FP14tUrpVAb0qfvmiVaml+SyH/zUxjyfC01psQ8JmDhm0hE4uTqH27Snj83Clrv+l0Fc ihC65YP7MzlIaV5d/wlo3L6DmxkH5uzVhXmX1tlLmArZ2Vdx8+Jgiemw8u8s13Zqz10UrQQzaa7 Osv4n2qPkxDiAHNKAb4Jw9iiqlxbw+eRYLjE/PMFXC4FO9iecc1z5GEKF8QN8ahBWfuK3z2gv5X 7zNEW8QhqzlT3dy6NRoB2L9rYVHzDM77MZ9md5FV5KGINOIFLPJynOAtzWzZR+Z4MeDigxWi3LG OGGcux4v0+fu4rCzttuNcw39dzsEsvLuBGq8AcmNhScv46ji6D9KTdwOFF3+gsYOQWDuRlyogEV a7/fCqr+/r2IyOYS5rLCcIXxTun/TZnvo67GMjnFxuGpf7PSOEOgCEvHyGKOOgUJMdC2bKaPwE2 qRF0mmfZXeaAtCesIeE+nhHFolQe9IlF0r1dOxO2EFG/7KVMhrvbiJ+fHWiJa8An9iLmUUQF7Zt goZGEmzDfYZrZaw== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Device can be unbound, so driver must also release memory for the wakeup source. Reviewed-by: Dmitry Baryshkov Signed-off-by: Krzysztof Kozlowski --- drivers/extcon/extcon-axp288.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c index d3bcbe839c095f126f0313a074681f1c900762c2..19856dddade62c5592701f8fd58= 42857ec24813a 100644 --- a/drivers/extcon/extcon-axp288.c +++ b/drivers/extcon/extcon-axp288.c @@ -470,7 +470,7 @@ static int axp288_extcon_probe(struct platform_device *= pdev) if (ret < 0) return ret; =20 - device_init_wakeup(dev, true); + devm_device_init_wakeup(dev); platform_set_drvdata(pdev, info); =20 return 0; --=20 2.45.2 From nobody Mon Feb 9 01:06:59 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87F831F4C92 for ; Thu, 1 May 2025 14:33:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746110020; cv=none; b=XSSqlNjIxHo3FGk7iJQEkxSvnLZf6ihDkPPO/W2zDNE73LvWfVz0sz+dvvnKDDBXG01RrOOc+sxxuyFoZA83HWrEX4XTk7sLpyz/bgxm8IaEWqy2rUiZz+diLuHROiSWfXeru+nwNUg84oP+3ZL1PgZF7swJ9JiOZ/R13+U+cHU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746110020; c=relaxed/simple; bh=RSvClL8Zug/P8IaPf0bu7goft33I+jFzMuQWhTt7CeQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OYyeeJU95NkgNZKtqRKxD5cFIrMIqo7bIsAJxMATmf/wNb5SwqXTNZkZ0RqkPaGmtBVbwDZVhGyZmsNde7IEKfxK6sVc56heullSXeWcUt8S6LPsyoblTUK+duEV4OsyttvkZ71nh1ajQrmgDl19P1G6eD4iXv7bRjcffM0MSzY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=QQCvsXqT; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QQCvsXqT" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43d16a01deaso1324115e9.2 for ; Thu, 01 May 2025 07:33:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746110017; x=1746714817; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=UPS5TTZ2Ma7zjGs6FuvJZ9IfhLucZzH25kCN+tl1ZQM=; b=QQCvsXqT4L33pGXFHL9j4xKoLyqQ6ThOUwcUQiqKq0hTA4/k2OvlZO3v7jVNPY8dWy L+iOczHKpCdKtsJlUm3T9YR0KovyPRac6KhdhyM3dZWBm7Tq/tAcXa7rGrRndLKx5YTK XxAK5xBF/OOFXGywR3lt4hOBuC5/1wpyGp8BuxKYnk0fnncsLJzPxJCgk7+pfESxnv7A 4oeskvaaCC2u5a7pfcdZdC5dX07m7kJStvHxwGQwVZCO2XYkiNbTKhWfr7hpIfy0/MSM yKsH9d2UvdYj87bLNuvz44jcZi3P5CdyiQ157PY6neDtVkKLmf+5Yxihpl6c7UgfmNJI uupA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746110017; x=1746714817; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UPS5TTZ2Ma7zjGs6FuvJZ9IfhLucZzH25kCN+tl1ZQM=; b=t5Kw9ms/iAIX55yu9kRhhtu5U9IpUxsaeKX/YxIIOFIP0Sz+8H63cGrSDfdZJu6d/D Rc8Oqh0buYCzu5GZ0Wui5NQti8lStuwQ87yRLjGLAjUugyewuRWhU0fjhLfJiFw5Zj4G foevudEceqxlPPtjthasQUTDga0uVn8bzK04LIKfcV5FSrTM4mmp3oYWhncVCZIgW/wp FGV9k3n3JiDBL4WER3m7WxAF8qF98olxzCeAr75ecU7JFXXtkXEkk6Inn80DnggDCTv9 k85jnJBaZGfYtehq6ezgsiNaOuEx68O9KHqY6RS63XakSgU4Ls1xwMVUTugprd+utoRT Jovw== X-Gm-Message-State: AOJu0Yz848yvnCJKFwGyaCPOGOwfCX2HWzWFBjtythdFWDpZaBpTQsz0 sEKxAtr8lREeY3ywjHpY47r/ntFSOGVbwi4UabpjS14D2oqAP0U6D0BJIWQ/zcI= X-Gm-Gg: ASbGncvap0EnHbl8t5tsPg124SxY1n2nmgyZ/QgkPE+rTZIO2uBWuPnchrx4NsulPcW 8lCwBwViDrqVwNMjtZxhKcXIyNK3mUKmzfuIYDvrL8bv1YEAnaSdemJYoDbUmDI7Hh12XbWC7tO xy2gB1IKOHeVDUqq5VDbMDCq2gYSDcEm5XJ7TWP1kVVjeLlSzjisKVLVK4/wvNB8L4xceFJ6P+Q HhvLDC2UX64GJOzmFpAJ0G66MXZJjTjp0EER+lkIziVgkOaTXZBENmS/RcQMAPkRXdrQMyO3MOn sI04uwK2ZJzgA+ZEPBCPkbXBcZ+gVvp70w5c+i/D2RgScf5v4V4S3R8mg0o= X-Google-Smtp-Source: AGHT+IHELHXEiTGWiEpmGPrkcyIBKwg9ONSuRuJUaTdgABkFi1hrlGa5toyIr/AaHb96Toujbn3Bww== X-Received: by 2002:a05:6000:43cc:10b0:3a0:65ac:2b46 with SMTP id ffacd0b85a97d-3a08ff351cbmr1415773f8f.0.1746110016886; Thu, 01 May 2025 07:33:36 -0700 (PDT) Received: from [192.168.1.28] ([178.197.207.88]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a095a8ef66sm957636f8f.88.2025.05.01.07.33.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 May 2025 07:33:36 -0700 (PDT) From: Krzysztof Kozlowski Date: Thu, 01 May 2025 16:33:23 +0200 Subject: [PATCH v2 3/4] extcon: fsa9480: Fix wakeup source leaks on device unbind Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250501-device-wakeup-leak-extcon-v2-3-7af77802cbea@linaro.org> References: <20250501-device-wakeup-leak-extcon-v2-0-7af77802cbea@linaro.org> In-Reply-To: <20250501-device-wakeup-leak-extcon-v2-0-7af77802cbea@linaro.org> To: MyungJoo Ham , Chanwoo Choi , Hans de Goede , Chen-Yu Tsai Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Dmitry Baryshkov , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=808; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=RSvClL8Zug/P8IaPf0bu7goft33I+jFzMuQWhTt7CeQ=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoE4Y5xiCTqFubQr8scqk2hhG8BLLucDvaBTylq n3xQH0r0LGJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaBOGOQAKCRDBN2bmhouD 15QOD/0e8dH/ke6LYzkD5ysGMX5eU0YRSaD0eWUfthbO6U87X9odFtkRDGZeNW/XGOnxrHOI16s hPqydHbLe+SiJSuK5cLUtyeVcAoSeKPYaOKiQX9xESno9VZ0/12mGWW9qURiJNGNxoDBs37t8F7 bsT21/ouYLJtZhF/uYKYR6HXU7cMZc98L5Mg2xNL0od4LdmwD9fokmXTjW6Ive5Tl6H0tXmLdqS jIMVjBejAEPkjA34C/NHyYVTuh6lGpEnuwa1Yp2i6tmVY9K5EthueQ+Zq8cd6KX4qi+GIy3UtyV bIEpiyH/2U5AvA2g8EDiBY1MjG6IIoQPqwQDPJs0DcqBUL3FOjG+UZa1IeNRALlwErEHubJYYA0 oSB/zYwH5MJc1PKJPE8DFzaTCm7OAIbc8dadN6a7bTqokVESmccGseLJ11Ur8yI+9AqkN827yzU Vf1SKDq3carYAztYVxVkZdeAMRLi5i5gTHE+XDieo4mY+hRcMiC3YYOyxrDF9zCRy09a0QHh/1X Ks+wdR2SqC1/vmAE6jPb2VTHC5rKhqdy4/CkxeCkDriQzjbpKHUPo3aCud/ZV9ek8IHtGMuaO8a MguPsqGAX4s3A6dIbi+NqJwho7qWvOVUQT9JAWcRQLCVlqugYXETlOCp/pLep3hSXmmQ8VpaxKy +xThYRXkWO7q/0Q== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Device can be unbound, so driver must also release memory for the wakeup source. Reviewed-by: Dmitry Baryshkov Signed-off-by: Krzysztof Kozlowski --- drivers/extcon/extcon-fsa9480.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-fsa9480.c b/drivers/extcon/extcon-fsa948= 0.c index b11b43171063d6dc14a5a4a7efb63e610397312c..a031eb0914a0b68aacb0f5f1f52= 2597ea286fa2b 100644 --- a/drivers/extcon/extcon-fsa9480.c +++ b/drivers/extcon/extcon-fsa9480.c @@ -317,7 +317,7 @@ static int fsa9480_probe(struct i2c_client *client) return ret; } =20 - device_init_wakeup(info->dev, true); + devm_device_init_wakeup(info->dev); fsa9480_detect_dev(info); =20 return 0; --=20 2.45.2 From nobody Mon Feb 9 01:06:59 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD0C820103A for ; Thu, 1 May 2025 14:33:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746110021; cv=none; b=Yx1YBKRKIzwEUJ2rKq9lh9uONvh6guIK0DvJuGUAbVm/nliWDxVVyr/13VRfIqAWAzBA4F9kyHdvf510p6pAbRgL6m8Kp7FJ4oZpjw8JmP4PNV3gIR+Z4BVJ9q1brLsVdjiX0AXeyjn9hZRO2cAI3tv29mMvLGhYFHKq2dLSLiU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746110021; c=relaxed/simple; bh=2aoVFkAjElaHENHtg8TjDWPYjXCiMNrGnaFnDbM6YaE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sg29px5VnshT0SPAshvrC0hAKHEARIdtA2iOT5cc7jeEML0d6pvS14OY136vS24G59Lvgj9w/pPg7QL+B2IA13jdHHbhtheZc6dwyWu5InPSNXtKwPLIp9dIsSoJQAWXxU74ju/+9u0NUXHsAeaYIB1kNWjsQph9In7OgZrWzaA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wuJk7iO0; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wuJk7iO0" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-43f106a3591so1316865e9.3 for ; Thu, 01 May 2025 07:33:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746110018; x=1746714818; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9+H5gIa6d4pyLO8MdBlU6oFyFMziUKLEhRLhfdswqn4=; b=wuJk7iO09rELbz3quIVEMJeq3Qhaw2EJlviOetFTUAOJEIb9aeEB2l15m9Gs/f8MyJ Y6TSflkBHr6Yt39WwyrTxcWjRUl3cmDspOZI1V/HV61sSI0+KZd3Jyi5loW1k7KI86zr 8UjO9hIJG27iCNI9j70hVeFySmYx4N6E2RNxVWa5vSuMBbjcHU+uxg+ck1abD2xf52t1 VrCHmabXLbE6LS7NUqP1y5xnuTmu5GRKbyg+zw7yKSq0aqd7L+krjKoeoWqY7SDP3v4n gFvd6Vx+HCv0PEoaRM8PMKYQ+ukPK2QV1OZ3awDAfx4p+Q9DvWiLPYlscxD3ski65kA9 zkZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746110018; x=1746714818; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9+H5gIa6d4pyLO8MdBlU6oFyFMziUKLEhRLhfdswqn4=; b=ZaENeJTjqpEf/FjLbmcPcEMWvOH9y3fllFHUkIGquD11QsMKvnQaXRRCkuvFYKtq0W PVcxDh/tCa+7db5+Ozd+ACU92o2kziRn9oi6aWeeb0JBLEVOBpjdRC+OWm2OsfwpbNgq dKGl8BzlWrrVmaqeuqXQTdqBuGZsKOd0jWJzKDvHhmqFj41x6p5yQbV2asqO5PerVq4h 3g06gXOPUjNN5I3d2RdI1vKkbsJd0WX/NXVZXHa8EETLz/J50qq7OYo6mXnl27i9gryQ B6a2XGV4L9J7v4jnG3teBev8+8vFAJ99mDv1kizp8pK6OR7FPEP7IS7x6bpFscFjaiqV yvsg== X-Gm-Message-State: AOJu0Yxv8KuRc6Hd1ENe6vBWcb3XqkSTLyi6czAtBFc10rfrP6jhFuzW LBTQpqMccpqK2rrbwiDNd9AU2AHJ7PsHolzEyPfUqN6wHnWzSnBShBlnKdeR1PM= X-Gm-Gg: ASbGncteoXWKvhE3DGNCM5OoCL+L5emRjTt/SGonH7EcTAU/3d+SGj/hodt/bwQ7dxm g6IMAQhaU/5v7xYeNIdwcHY2nr2hj7j/0XPR+vU9sffMgeaYhJWkxOpHxj96+hzv1iW7QgTVO6K wz86fzvSC8fFPnfJOhLy4f9S5473wFGJszXqljh00NV0QO73ZO0mZaL1APd+w+4S+3JHjRZGMmG +cGV84k9VccLuS6KiR5sarydWfeFNVjOqsm+DEKniJ5lt6PLVqvI6wpRklRmLwPho3Nl0TePHzG tcBEs96TQm0FDgN+3tKLVi23i5ji+Su73UYFosq2HMGJ6IHj7WY5TUxdaac= X-Google-Smtp-Source: AGHT+IEZATzbg/rgmI6bhSczj0axA9hwqI+q39PcQPM8+MaFD8mRfMUqEaGtuwQ93o0OYfWDkXaF/Q== X-Received: by 2002:a5d:6b0f:0:b0:3a0:9570:7233 with SMTP id ffacd0b85a97d-3a095707240mr350578f8f.11.1746110018004; Thu, 01 May 2025 07:33:38 -0700 (PDT) Received: from [192.168.1.28] ([178.197.207.88]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a095a8ef66sm957636f8f.88.2025.05.01.07.33.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 May 2025 07:33:37 -0700 (PDT) From: Krzysztof Kozlowski Date: Thu, 01 May 2025 16:33:24 +0200 Subject: [PATCH v2 4/4] extcon: qcom-spmi-misc: Fix wakeup source leaks on device unbind Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250501-device-wakeup-leak-extcon-v2-4-7af77802cbea@linaro.org> References: <20250501-device-wakeup-leak-extcon-v2-0-7af77802cbea@linaro.org> In-Reply-To: <20250501-device-wakeup-leak-extcon-v2-0-7af77802cbea@linaro.org> To: MyungJoo Ham , Chanwoo Choi , Hans de Goede , Chen-Yu Tsai Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Dmitry Baryshkov , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=911; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=2aoVFkAjElaHENHtg8TjDWPYjXCiMNrGnaFnDbM6YaE=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoE4Y6EdqQvi7iSbCPndmZkC+pXDb36V2KHvHE+ 0sRg5QFcouJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaBOGOgAKCRDBN2bmhouD 1yjAD/0XskD2vQXiEUBv5CQhPcKLav8KeOqqIn/LsWowRspN8Udl/FO1N5AtS632Irr4FM3A06N 0HvKqEi8uZ46yvCmr3lny3gjfH3dmUN+TuLsZulBilCBI4lyX3KMzfrvVntKcdM+HJa/HCMJzhz NOGmtILGMD4yfnH+CgFXf4zN8d1de8GgP5+YRUKUBJrjx50J30JoBMad4nGZwGA/XHW9D3DLIth RgMPveHYoVRRa9smq7xPQC8DuHKqF2hR9TaKvXm7THj4C3NSZtHKUDhSmD6url2RE5Z5j0dS5cm l+Z3kJ6WixTkR0x4qUsa+BGeuPlTMOpTvOBWc7bGsFRTv9V1aXgCL7cHO2MKWBI+vyjCDB3lD0q p3hI1YQflx0ExfD+HDxq3eBC/6zB5hRTg6X7fHZCyPNkN6PbH/Ty1yFmzkSH1bsjq8qWmeaYttq L4KXcbaOBC5DdhsBovHRsrOLvQeXV8aUgJLvKn1VlLXjX5m+yiVN1XzXAUXgs1TMcCXkKddnKHe GMIWRmbkyM7l9kFgz3bCk+1EiUboAYqPkl2o1uQsVlRo0Kt901qUoFOmH6/ZJR5vIwxwotVHpYm MyIwXMwK8bgcSQp9umrZf73h2QYaubFTAbhfaqLYAF9Serlp4NRrAJNChtPDST6pHfQgj4uuoBE FLcoTRp8853hTHA== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Device can be unbound, so driver must also release memory for the wakeup source. Reviewed-by: Dmitry Baryshkov Signed-off-by: Krzysztof Kozlowski --- drivers/extcon/extcon-qcom-spmi-misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-qcom-spmi-misc.c b/drivers/extcon/extcon= -qcom-spmi-misc.c index 53de581a393a35bb48f637ea73e910b4c8340ace..afaba5685c3dcdbdc750c1835ec= 4c696bcc64fc4 100644 --- a/drivers/extcon/extcon-qcom-spmi-misc.c +++ b/drivers/extcon/extcon-qcom-spmi-misc.c @@ -155,7 +155,7 @@ static int qcom_usb_extcon_probe(struct platform_device= *pdev) } =20 platform_set_drvdata(pdev, info); - device_init_wakeup(dev, 1); + devm_device_init_wakeup(dev); =20 /* Perform initial detection */ qcom_usb_extcon_detect_cable(&info->wq_detcable.work); --=20 2.45.2