From nobody Fri Dec 19 17:27:01 2025 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFC7E298413 for ; Wed, 30 Apr 2025 17:52:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746035542; cv=none; b=Ayp7WTDdg/POUGPEKarmUy7iH+OCVr2HXkheFvoX58TZKrjCzh8Nh7Uwmu8szNFKwUqDE6pxxmNz+i6+5FdO4J0NEFfj6dL/VoQQuwPjRwh0qOkirG5VHxskF3NOMMFMAkL9ssS02qukAUAr00LGKftpjL1wz5zJon7WPdFIet0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746035542; c=relaxed/simple; bh=HPHxz81OxLaecpnlL9lqndi4Kc/aGSQDxqv1zSPPuXY=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=AWH2sRtyIWqQ2JFI1/Or9oQiX6ekv213vYebZxM62oEVxr3d9R5oxtV7joil0KXi3JpiuOS8/ZVylCypLr35HNtRlXW93jM/mlAzJ+YQahCo+1wB38jO7jbeO2lsoUu0biCDMFqr3N+VFuR55zOSHzoqZJc7Wqnu0YMBGMBM/ts= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=nhD6CQlq; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="nhD6CQlq" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-3011bee1751so130324a91.1 for ; Wed, 30 Apr 2025 10:52:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1746035540; x=1746640340; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Qemr2dcVwpSLldCyiGlwsuB9xh9m4dXk1i2vOyXbcwI=; b=nhD6CQlq7qCiX3HaJmet/Xg0sgA6pHaYII/mROdhbll1aUZcZ70ZSrI8Xj4W4HnOSf A1Vfe91c+tyb/QDDqd4mz35HrgvQ0S6X06fi70M0uF8si5RTQeONGrnLJzepldmwCpFw LK09eG1qdDp1Z6M1vHx51iDjbFd7BgFFlV1TgwFPsJIgYromHhCptJzYB/V8UPv02jRs mLrJkT5WmAZRRsXRvN/zw3ofKIym/GdfBIdM4KRUtwZe0K5aU20Uz/Rqe8ZBMr1DdTdK V13YHxJ9GpQigke3i7RUBlU4zVIy+45mkbb3ziI4T+hdSgBgRYp5KquyV1fGgG5ZX1EP y8Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746035540; x=1746640340; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Qemr2dcVwpSLldCyiGlwsuB9xh9m4dXk1i2vOyXbcwI=; b=Xp1o49Kks7LHA9rDMHgU45qDVl2dO0LOIQtKdouet56s3WHKs4sDQFFs0Yu1nLw2Ou YQSCANxME6NthhtyCuYR5OiTmsVURng+RP0yIq3Z+ZEqOtuVV0oWLw6bCoIshlwG1NKl Kwp+N3OVOSGnKQe6Cxk9uIXL3d8l42bk6qVTEOPU2hUdZDXU4eL/h4exOktsxlfMgzll ALDd/D/C7mn7sKXBrMgTxGFMi+Gs3cd2nYuH/Ia0iMbRuYAdv8+uW9bnKAoFDbX/fQF4 S0GsLF5Lp6fNYOCiGZhaLXmIjw7OUQdpZGyXudm/HdLwSxcJV+Dm5xExtju5cjt24ONu +hkg== X-Forwarded-Encrypted: i=1; AJvYcCVJfuDtqxo1lC4AECugRTPqQlAxtWMWUzlsnlgJ0/OFiVXKPf67teRJ/Szq/AuHfDh6YOewNVxFU17lLcA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy50ftoj8GEE+EPlpzWg6fS45dcORRLmUDQNCpJdgEuA3ziZvvJ 6DpDUcTh2+lqJk5ieGGhAkDkUtZIFwXdc/gZ2WKbl8yOmUmTh+VNXnO5Dhnuc0nTozo6aoLrSPA Q7KIomQ== X-Google-Smtp-Source: AGHT+IGiwVp5/ypPQD3uAZdm6z54NsO/3JK1b7BY6DDnJgXJ1mAvzNplqKCb9spucs6B1RP5GSDw5x90hAhQ X-Received: from pjbsl12.prod.google.com ([2002:a17:90b:2e0c:b0:2fc:1158:9fe5]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2f05:b0:308:2b5b:d67f with SMTP id 98e67ed59e1d1-30a343e8575mr5995053a91.9.1746035539948; Wed, 30 Apr 2025 10:52:19 -0700 (PDT) Date: Wed, 30 Apr 2025 10:50:29 -0700 In-Reply-To: <20250430175036.184610-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250430175036.184610-1-irogers@google.com> X-Mailer: git-send-email 2.49.0.906.g1f30a19c02-goog Message-ID: <20250430175036.184610-42-irogers@google.com> Subject: [PATCH v2 41/47] perf diff: Silence -Wshorten-64-to-32 warnings From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , Yury Norov , Rasmus Villemoes , Thomas Gleixner , Darren Hart , Davidlohr Bueso , "=?UTF-8?q?Andr=C3=A9=20Almeida?=" , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Yicong Yang , Jonathan Cameron , Nathan Chancellor , Bill Wendling , Justin Stitt , Josh Poimboeuf , Al Viro , Kyle Meyer , Ben Gainey , Athira Rajeev , Kajol Jain , Aditya Gupta , Eder Zulian , Dapeng Mi , Kuan-Wei Chiu , He Zhe , Dirk Gouders , Brian Geffon , Ravi Bangoria , Howard Chu , Charlie Jenkins , Colin Ian King , Dominique Martinet , Jann Horn , Masahiro Yamada , Arnd Bergmann , Yang Jihong , Dmitry Vyukov , Andi Kleen , Graham Woodward , Ilkka Koskinen , Anshuman Khandual , Zhongqiu Han , Hao Ge , Tengda Wu , Gabriele Monaco , Chun-Tse Shao , Casey Chen , "Dr. David Alan Gilbert" , Li Huafei , "Steinar H. Gunderson" , Levi Yun , Weilin Wang , Thomas Falcon , Thomas Richter , Andrew Kreimer , "=?UTF-8?q?Krzysztof=20=C5=81opatowski?=" , Christophe Leroy , Jean-Philippe Romain , Junhao He , "Masami Hiramatsu (Google)" , Xu Yang , Steve Clevenger , Zixian Cai , Stephen Brennan , Yujie Liu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev Cc: Ian Rogers Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The clang warning -Wshorten-64-to-32 can be useful to catch inadvertent truncation. In some instances this truncation can lead to changing the sign of a result, for example, truncation to return an int to fit a sort routine. Silence the warning by making the implicit truncation explicit. Signed-off-by: Ian Rogers --- tools/perf/builtin-diff.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c index ae490d58af92..9c21ea8f242a 100644 --- a/tools/perf/builtin-diff.c +++ b/tools/perf/builtin-diff.c @@ -243,7 +243,7 @@ static int setup_compute(const struct option *opt, cons= t char *str, =20 option =3D strchr(str, ':'); if (option) { - unsigned len =3D option++ - str; + size_t len =3D option++ - str; =20 /* * The str data are not writeable, so we need @@ -1148,7 +1148,7 @@ static int check_file_brstack(void) d->session =3D perf_session__new(&d->data, &pdiff.tool); if (IS_ERR(d->session)) { pr_err("Failed to open %s\n", d->data.path); - return PTR_ERR(d->session); + return (int)PTR_ERR(d->session); } =20 has_br_stack =3D perf_header__has_feat(&d->session->header, @@ -1179,7 +1179,7 @@ static int __cmd_diff(void) data__for_each_file(i, d) { d->session =3D perf_session__new(&d->data, &pdiff.tool); if (IS_ERR(d->session)) { - ret =3D PTR_ERR(d->session); + ret =3D (int)PTR_ERR(d->session); pr_err("Failed to open %s\n", d->data.path); goto out_delete; } @@ -1492,10 +1492,10 @@ static int print_cycles_spark(char *bf, int size, u= nsigned long *svals, u64 n) =20 if (n > NUM_SPARKS) n =3D NUM_SPARKS; - if (all_zero(svals, n)) + if (all_zero(svals, (int)n)) return 0; =20 - printed =3D print_spark(bf, size, svals, n); + printed =3D print_spark(bf, size, svals, (int)n); printed +=3D scnprintf(bf + printed, size - printed, " "); return printed; } --=20 2.49.0.906.g1f30a19c02-goog