From nobody Sun Feb 8 18:27:25 2026 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F865265631; Wed, 30 Apr 2025 17:40:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746034855; cv=none; b=QbRsRU/awrKwbNeAVbzw1BxJTMAUf8A/XxoHxvKafv9EpJAMkgiym2HGQzq0nB/DNZJtjCRDvAw3Dr97w8tMkcz7Ki9vW8BgaddPE2cZOjYKyhd90MwDRrCuHnwueMzgt++6JvXbqaDeT3nh6UJRrHFUgIzROg/CiSdFJRteNuA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746034855; c=relaxed/simple; bh=L58F8VpFitdjXDwxdOokTqHXLMkWR+da1yRV9U90EiA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=C4Cu3ZRaSBGe/f/NUGVg/D/fjNH39PkqIseFuD4mGIc6bOEarqjVEIxAb7TstTUcArjLye9ewiosfimqItiB4gbXV3iz7q16l5HUdtH+hu+JumpMyyZmBfD841+GnXSUO4SHW0T1xzSLdXT1aQhWmrmw3IKfFhd+k6uGNXcUcUA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ICp+8Ner; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ICp+8Ner" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-39c1ef4acf2so44991f8f.0; Wed, 30 Apr 2025 10:40:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746034852; x=1746639652; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qr4YA8C6ubuzSecBPpkUyyaJOotpwzXLW4F+DAHusgI=; b=ICp+8NeruKNvjkRMNkFdtNO+sfeiy+rly43mM6jEcdBtXQzCmAU9SKqC9LrWSWaO3s Tr4dqsJxeESAZqCErGh6euj/OkD6gdq4xmcxxZGs9pME7Jo9YPfec/VjKCBBbE54Dx5r lyeSc1xJdRunTmXAA9wbUteqV3iJhawIV84lDlNMy//i+H9cYn4SBV1hBQ8f9/LcxmfP zeEq8hbh6CDrqYaiEeECgN/YJlsVovAUVFJ6mZj2rq0kiliwdWq8l4GQJAzmRfjGumZR uDi3M1CTBoyzG5CBTRks0aerP0TUTgzDTWY9mmjJzsLdZgt6uKmCGGuoUlAz1Cz+5A7w RQVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746034852; x=1746639652; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qr4YA8C6ubuzSecBPpkUyyaJOotpwzXLW4F+DAHusgI=; b=IP2njEFYcL0v/OcguqcJK/MZCFU+SPFYiJ9ycUj6389s9mqRoR9ApaKeu3wgaP2i9w mjgXO4XCbGCy+EKvpeJXtnNRSnaZMmrIl1zFDG6MUMCQ4vXvc0ToiTBDF/XAsrufbc2y ZNGfhhQPZBw7n1hnsTA1RGLJVM7j2Agx4LgkliyXMSs4MXbe/gLgVFToFuCyotsPVHEZ dlFsypYyu9qZ98shd2iwhEGp/aEwE9XbG8kFeE5mbbteM45IeiXJhCoR/UayvM34K/oh tkkMKNneMyKZMbA1szRPEbue03as2D1B/XILa/4+YsQCMEojfuNxjP4tTN5gJs26TsNq W4kA== X-Forwarded-Encrypted: i=1; AJvYcCWFkb4Z3h/ark54dZ7sg3AnItLupNmNVH4meAHBlVYeKVdQR70axN6cIVt00g4LPgpDMTYqmsnBK/E/rGgr@vger.kernel.org, AJvYcCXSMXFqY0DYrqYIq91m+BiNit/b1d/o9FSgrmARRy2dMXvzi4MGYm1c5T44UtM5OTCSd0DWpdmFOmPwSA==@vger.kernel.org, AJvYcCXrTeacTBHEIf/bN1Wc6/uHEy0BuaeOwE2X9FOBVMw6KarNiV7xBZw8F79Sa+5MsMYeOL9qc/YN@vger.kernel.org X-Gm-Message-State: AOJu0YyY3l/efd/rYiiYfx9227KXQLvGDF/O/r5o84fG2ZoFZvtfC9RQ OBBtXjHZlzDAwQMyLAEU+ZUzCi63Ms6d1tyb3CsyZfupgVytf2oz09i5xA== X-Gm-Gg: ASbGncufoKFwZH4y0A7o/DB9QWEIgcCq0kcx1iwB9kSLWnnVuE6hVD4n/HWNQu5qWRe TbC4VZgiueNIzi8gQVF09A+b4gCmIOOWbFXqnUWAlEGicS2ctTNFonhc3768eQDxr15c7467ru/ +NkPsplphKOLfE10ahNNk0KrG7BrgFTLeJGwuVkMNna/5UGMgv12ZGib/Wmx3AWh0N/PwD/8XAN la/vWCqE8WEaVLwOgmlWWBFQl28kOWIbI1EmbYCmTTAKKHawfI2lJCzCM5ppwUjPAK9KrEu9N3/ LLhxkb3Jy0MzNae5/Q+5Ub0QHmH+DoSAqEVEhYFn1Q== X-Google-Smtp-Source: AGHT+IEmNE/VR07OxMfSFdyBBqWX9svb/T4h8Nx5tRuJEG+krh3hgCM+/mR02ZKnCmExu4209d75gg== X-Received: by 2002:a05:6000:3107:b0:391:23de:b19a with SMTP id ffacd0b85a97d-3a08f7a2164mr3174512f8f.31.1746034851557; Wed, 30 Apr 2025 10:40:51 -0700 (PDT) Received: from qasdev.Home ([2a02:c7c:6696:8300:7d1e:a9b9:e7a2:cc4c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073ca5473sm17765934f8f.31.2025.04.30.10.40.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Apr 2025 10:40:51 -0700 (PDT) From: Qasim Ijaz To: ping.cheng@wacom.com, jason.gerecke@wacom.com, jikos@kernel.org, bentiss@kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Qasim Ijaz , stable@vger.kernel.org Subject: [PATCH 1/3] HID: wacom: fix memory leak on kobject creation failure Date: Wed, 30 Apr 2025 18:39:09 +0100 Message-Id: <20250430173911.84705-2-qasdev00@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250430173911.84705-1-qasdev00@gmail.com> References: <20250430173911.84705-1-qasdev00@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" During wacom_initialize_remotes() a fifo buffer is allocated with kfifo_alloc() and later a cleanup action is registered during devm_add_action_or_reset() to clean it up. However if the code fails to create a kobject and register it with sysfs the code simply returns -ENOMEM before the cleanup action is registered leading to a memory leak. Fix this by ensuring the fifo is freed when the kobject creation and registration process fails. Fixes: 83e6b40e2de6 ("HID: wacom: EKR: have the wacom resources dynamically= allocated") Cc: stable@vger.kernel.org Signed-off-by: Qasim Ijaz =20 --- drivers/hid/wacom_sys.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index eaf099b2efdb..ec5282bc69d6 100644 --- a/drivers/hid/wacom_sys.c +++ b/drivers/hid/wacom_sys.c @@ -2048,8 +2048,10 @@ static int wacom_initialize_remotes(struct wacom *wa= com) =20 remote->remote_dir =3D kobject_create_and_add("wacom_remote", &wacom->hdev->dev.kobj); - if (!remote->remote_dir) + if (!remote->remote_dir) { + kfifo_free(&remote->remote_fifo); return -ENOMEM; + } =20 error =3D sysfs_create_files(remote->remote_dir, remote_unpair_attrs); =20 --=20 2.39.5 From nobody Sun Feb 8 18:27:25 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2390266562; Wed, 30 Apr 2025 17:40:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746034856; cv=none; b=XRlD+8JhuLGrEurOzP+4yr0sPXUvvvBr43n55RE6r531OmglP+uy6Dfo2RlxfB5FAJ6bZSDQwmSCgFU3bqAa5gFUcGgLgrGeLCNzrrN/AlqRWGsmqChQ8mHWzND5+keHL3DS6/yyQQa8zbQH3FZLq1ivQfT7Nl3yc537guOZajc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746034856; c=relaxed/simple; bh=3QFh2R0eajSy4f3mjOSVV3c1SueO+JBSzWRBoEzVmAY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PXZrBhIenMlHYizWin7u8t+0M+waWUm7IozqESoFFPYETHg8gamFad8NhoYQVIS4K0/I0cvmGYNeIXVJ0ITLZuTlZPgXogNRIkbmhAEl2gi3Hfby/YJpP5vE7Tq1hLw9BqC1bEyBe+NnzryVHbAOfY364ch/yIwCp2N1JQCrUrw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YL9+tNCV; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YL9+tNCV" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-43cf58eea0fso393505e9.0; Wed, 30 Apr 2025 10:40:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746034853; x=1746639653; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MB95G5Dp+M7W1EFdGvxTXvDQf6oivitArJ2763PJPIo=; b=YL9+tNCVE4OvivAugwsiaeBbVC32KX5pgCFrQGNhKeSQWDUrh1Q4KAeBtOWz6jFtyS 5trFIJmC9swIQ3kF901K4eZtTlbNUO8OZmpS/q5W2RFSJxz3ApqsTkJxHhNAD2ZTg10A wk1BWDHDRCARg7IBebMN/gS6cT15DM3tpiLrsrvwI9qn+zvhBmp1RGZRnLnnzDmigG6/ zXZzoWGzPIyPEsI8jVP6AMIdWPVUOG4+EWtLetzMgf87d0an59Fdr/vT977sO+EST9Aq /Ju5JcsI5y4fCHREtJF1w8m0VPG70gP2jL3Kkgof3vVyd+BQN7UTdn4t2dTfVgrBoaAr ryfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746034853; x=1746639653; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MB95G5Dp+M7W1EFdGvxTXvDQf6oivitArJ2763PJPIo=; b=hShxdnox6aQk1BNeyilHE5Vkce3r0W2i5rJZzJFDkbe32hsFktKi9++hwz7eqKyANj rCIX2zs2wQZuwav7xDB63Zju/7XV+YeE+8c7aOqKpIrN/UAkS435JJpB9r1sZWV9fZ02 7fVRyHjaDZkCGkK40K/41fQAskXGQjt6oZdb8K3T1JbW6NzVvbK8/FYkxOv6eUaJNCQs XDEfpu8n9OZg8beNSFDrqqUGrTisKzzzPZVbR8SRRhGmi1eioLZMNZBq4nAnEy1ej+Eb BpOnY5zw7CyR+fGIo4obXoygORNIaGcr36ZfKA7HtCtwezNopWvpg+/YI4Y0QY+oTUDQ GlfA== X-Forwarded-Encrypted: i=1; AJvYcCW5EQoNYsKRJj91AgAHKF5WGHt+oNqWaDqgbdgT/er54Z9y2Hf4zrhBwAy1zWfT0RgjS9HCC/ke@vger.kernel.org, AJvYcCWHV9Y++MkC6Ofnny6oOJTWrNynWcUSjwpojO75oSCDbtlsMpeqEmWDJMuityRIRNetVB+WLvPnERPp+Q==@vger.kernel.org, AJvYcCXF19F2bKZ6IXfq0iiiBOW0dmW1zxRQUx01lIpRS2pJbv466FLVEBLCQVlS2i2cPaFFJX6h4CgTDFINylMx@vger.kernel.org X-Gm-Message-State: AOJu0YwD3hUW61xPh1Vf8GgsOW4+weWSaIjJgDbnxVCnvdyV+m13MHBI /j5sjsCsr3Gdrn4mBIQlfV+yq5jg/mpkSi+bjzIUIlkUfCvotXBv X-Gm-Gg: ASbGncvEyGjzown3d9oeNPR7YzZZdn35GojXYzOoMrmPfmTosW+f/BTBav05r7ri1eV IFtQ3TAkRAzk8ZMPSl+gDNZA5lvc/glK+jfek0aXUJ8IdtQrrDhk8gqvpnm5LRm+gJDLZupTE39 WWrAtYzBqhOKBs5mKTP71B5IzRiBZa9/BSE80NxlMtIm93AMjlj1mR+iWVFMzE0ZdnwhsTL8FpJ fxlJSJzi1JWIte69bsRZ66YSPf9NDA+iflPNc0FAXtgQelL/GMLhb/BX9J+6MNn4rbGwU/RnsQJ U/dv0poAR4IT3IwwsU+oD/Dec1iGJx/91fT0qCG8aQ== X-Google-Smtp-Source: AGHT+IHyjBLLr+7BEizALNKCtxGKGNNRezJGu94ArQYh3DZ4AGnIijBmL+QKVFiKJZZ+7jhYbG4AEw== X-Received: by 2002:a05:6000:430b:b0:391:3aaf:1d5d with SMTP id ffacd0b85a97d-3a08f7a2739mr3870486f8f.27.1746034853123; Wed, 30 Apr 2025 10:40:53 -0700 (PDT) Received: from qasdev.Home ([2a02:c7c:6696:8300:7d1e:a9b9:e7a2:cc4c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073ca5473sm17765934f8f.31.2025.04.30.10.40.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Apr 2025 10:40:52 -0700 (PDT) From: Qasim Ijaz To: ping.cheng@wacom.com, jason.gerecke@wacom.com, jikos@kernel.org, bentiss@kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Qasim Ijaz , stable@vger.kernel.org Subject: [PATCH 2/3] HID: wacom: fix memory leak on sysfs attribute creation failure Date: Wed, 30 Apr 2025 18:39:10 +0100 Message-Id: <20250430173911.84705-3-qasdev00@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250430173911.84705-1-qasdev00@gmail.com> References: <20250430173911.84705-1-qasdev00@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When sysfs_create_files() fails during wacom_initialize_remotes() the fifo buffer is not freed leading to a memory leak. Fix this by calling kfifo_free() before returning. Fixes: 83e6b40e2de6 ("HID: wacom: EKR: have the wacom resources dynamically= allocated") Cc: stable@vger.kernel.org Signed-off-by: Qasim Ijaz --- drivers/hid/wacom_sys.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index ec5282bc69d6..58cbd43a37e9 100644 --- a/drivers/hid/wacom_sys.c +++ b/drivers/hid/wacom_sys.c @@ -2058,6 +2058,7 @@ static int wacom_initialize_remotes(struct wacom *wac= om) if (error) { hid_err(wacom->hdev, "cannot create sysfs group err: %d\n", error); + kfifo_free(&remote->remote_fifo); return error; } =20 --=20 2.39.5 From nobody Sun Feb 8 18:27:25 2026 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CB9C2676FE; Wed, 30 Apr 2025 17:40:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746034858; cv=none; b=idUUolNU3UYfYRjibP8olr9c8g3sgkfsNOk0Pez7zRDg+mOVdjsxIC+j2RUuBayxAJVAxJOQvjAEVn4mft7M9zZDIxRBqLPA5FiqA0I7HOkVEfRNOjt0BBQM5qf2jcvX61nQ6FACEuS2yldBRUeNAklvkPZ5DBzHs1N2xLSauQs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746034858; c=relaxed/simple; bh=BaaX9y7sdqFsQ9vMxmaduWzH/LZeXD15OZLrYVs4NWk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=WT9UEFwnmwGtRXR4KP922HjfhO8sKEDG7F+qNL5kpNpqoosl8CuO1VMjKAa33dOuDzEFgdliS6aYkQRylkAxEYfsuIq25pMAc8Sde8KSdBBiGXQCJEQ14J6cnLHOjtG/Ss53lNoWpzVabaBc+/ZOJ4SmFmeBD9h1stLHQQ1corM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HCUwJAxA; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HCUwJAxA" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-39c14016868so56762f8f.1; Wed, 30 Apr 2025 10:40:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746034855; x=1746639655; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pcVsuF9nUCGZE3Db+V2hjbiOibndGT495jwZm7Ki9MI=; b=HCUwJAxAYNcMDsnROhcp+l0PjxE5X1ed+GRMR8WJVoFEyBm10e9zftpT7cgUtHAScu yr+vL43fjP+aMiRhp5cb498qg22cWA3v4yKb3WssufjqVNVsRDFz1Cfv7Iayq76SvMbW 3ihwOsqvPbWFQ5JpfwJ2ScRi3NHzlIJIGg3B0D4kRinU17Ew27r/7OqAokFg09kRsabv hXAlO5SGbvplVoeHiWNm9MmRiLsDoGevAcX5GGANh2hmAxHy0SUgTEIP1C3HKH94taL9 p+k2XtTieZIBe8aTgTIX/V0UXq00N00Dd1MwvEYy+D189uB+zk5lWR+dlymmI2jfcbnU AibA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746034855; x=1746639655; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pcVsuF9nUCGZE3Db+V2hjbiOibndGT495jwZm7Ki9MI=; b=GDAwJ0i4XljA4moIVZg7Pnn/0XaZ5szM1Xe01Inr7mtBEMALW1WAuLmjw65DZYEwxa rpIiv2g1AP3mcSYhUVqwnxiaK5gEF33DiLDNSjGQF1RIqQ0u+6MHQX6X2Fv0um7G52pj Gc/Gz5P38Z06TfEcH93CneNf8DJTk1p4Y578S46IU70WPyykdu/XJPmF0fvrKUA29H+m NjB50il4ilr/m46ICSeHealnSlINN5d0QrF4vUhS9l06/VXmO/LuSarHybpI8sBv4ZXi u/wXdwD648UybATWgm9vm/D5N2U66jTEwI2v9En678dD8NKrfQX3pkE0cTUzmIS+dg7u zl4w== X-Forwarded-Encrypted: i=1; AJvYcCU17PHeaS2yBxDLCSr4kifO/I5LLzhHa5M5FM/iDpNO/wfb/AbIsBxxpjFCJD8/Csesg45L9EQRCnSUNQ==@vger.kernel.org, AJvYcCVOC9tU8tgbzY2iDLOtLD68u776/QcKCLPpQE+bBvbRVyehJXA14Ht5JobhMENOoUdku/8nGxDS3HbBZ9pm@vger.kernel.org, AJvYcCWC+BFJnUXvG/mzN5nEDZ2SZuMSZXRgHY05asZIvrISKyxImeRdiBs3T8rNkgf4UOAZjAuTFg5W@vger.kernel.org X-Gm-Message-State: AOJu0YxZ031MGp+QiebnS3xXePa/1JJyu/UuoiUfb/G/6fWezbWMT+ra CbN22E9A6MBVy45Vwc1iqofIDyvZSPZ6KzNMAcU6PmSQ5+8v3vz4TYTc/A== X-Gm-Gg: ASbGncsJWcs80U33LXV8oOMeEE3GiD8FT117HiMhf7RD56AmrL8CztDAzOM7WzhMgeP LsL2+xwUECJROZCRsOXRTaZfJ6ljaejl8vtjlGhYUwIcmgqLS9419Ak+Ajj0mpEK+78Z65OfRcP JnQ1JNn+J3L5z7cL0HotvdQI+sbr98UL5UVFZrCP0HXXdpsnff5GczaDTBNiYhbwzJA4inYU1lN CSOSHUIvBhSheFY6aI1QHWLQ3prl2AeGUDkhvDDuDQIGD732z9TF2rkx4MLtyLg/2wdeDr5NLUh 1ebq/9u7nl+yuTcjp+JhADuY3QKnw9Jd2ZWQ6NISPA== X-Google-Smtp-Source: AGHT+IFq+T3yz8EYz9XMQlrpz/kFt3fq6FKTA6e9UmlyCTEfE5zJKIA3Un1ZJz2xbG0DfcSdEETVHw== X-Received: by 2002:a5d:5f4e:0:b0:39f:91:43fd with SMTP id ffacd0b85a97d-3a08f764d88mr3277762f8f.22.1746034854713; Wed, 30 Apr 2025 10:40:54 -0700 (PDT) Received: from qasdev.Home ([2a02:c7c:6696:8300:7d1e:a9b9:e7a2:cc4c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073ca5473sm17765934f8f.31.2025.04.30.10.40.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Apr 2025 10:40:54 -0700 (PDT) From: Qasim Ijaz To: ping.cheng@wacom.com, jason.gerecke@wacom.com, jikos@kernel.org, bentiss@kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Qasim Ijaz , stable@vger.kernel.org Subject: [PATCH 3/3] HID: wacom: fix kobject reference count leak Date: Wed, 30 Apr 2025 18:39:11 +0100 Message-Id: <20250430173911.84705-4-qasdev00@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250430173911.84705-1-qasdev00@gmail.com> References: <20250430173911.84705-1-qasdev00@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable When sysfs_create_files() fails in wacom_initialize_remotes() the error is returned and the cleanup action will not have been registered yet. As a result the kobject=E2=80=99s refcount is never dropped, so the kobject can never be freed leading to a reference leak. Fix this by calling kobject_put() before returning. Fixes: 83e6b40e2de6 ("HID: wacom: EKR: have the wacom resources dynamically= allocated") Cc: stable@vger.kernel.org Signed-off-by: Qasim Ijaz --- drivers/hid/wacom_sys.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index 58cbd43a37e9..1257131b1e34 100644 --- a/drivers/hid/wacom_sys.c +++ b/drivers/hid/wacom_sys.c @@ -2059,6 +2059,7 @@ static int wacom_initialize_remotes(struct wacom *wac= om) hid_err(wacom->hdev, "cannot create sysfs group err: %d\n", error); kfifo_free(&remote->remote_fifo); + kobject_put(remote->remote_dir); return error; } =20 --=20 2.39.5