From nobody Fri Sep 5 20:10:01 2025 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5686EBA27 for ; Wed, 30 Apr 2025 00:41:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745973717; cv=none; b=m0Nq4pmi4yrdJ60eEsfgtip/a38I6wqq0pIWRgsUUidN9dsRHFFcmTMqc4eCuy/35euuE/1RmXo/IGqqTlfN2OnRKT/EhFGB32mlluxK8STmdPkdEFBfAokI3JSxgMR/GsBpbcPf7it/U3fEUxRuJDggl0uXTksLN+obENHKwwE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745973717; c=relaxed/simple; bh=pLvxUdxndsr2wYkJQYg49ecez/cviTwRj3eN4nJwgxo=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=ts9Ts26dCuC641vPkebi5KUWYN4cswrZL/EzQ5PSRF2GijrNDQb3L4MneT0PjeoAHgMPKu3chRNW5ioEyD4a+71HzTIBDKSG7urJheNNQya5Gfue37cljS/PalbGq1RRy/j58Mgya7DVLXlmg/hnOeiauKQ4IQdePjXMkfU4xPQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=apNF28FV; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="apNF28FV" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-7369c5ed395so7516046b3a.0 for ; Tue, 29 Apr 2025 17:41:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1745973715; x=1746578515; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=VWjkucJuMaosxMcy1Z3rSUNsLtdDY3ZZywavpz7InSY=; b=apNF28FVbWdzH+0p7oT9pqhgVfytqVk4HeXo+6Pnia3EmomAcSMSbJQxSrx5jaqdv+ +9rgBfJ7WR8ZIb1AQIrdBZpSvJdoOtkLqFDnVB5bV6hzfAwZgIKVv8/2pSJiSiZ7O8ro aOOxHiF6fqhWoRE/7cGosma/CCpMzJuGDnNx7kYgLDxHMdteOMvJZP/U6mhPM6e9g58P 75/BKgxt+1kcfuxqKq+z9uOzONGN5f/ZMidHbVOGMhTnVnGPHEjJSLlRN9DiKcsZx84M WVra43nR9I9c4ShK8cQRuSXo708Z0UXlJWRWmYloVSAdwTMPf/tSHOLldBKRQrWtDlit lltQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745973715; x=1746578515; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VWjkucJuMaosxMcy1Z3rSUNsLtdDY3ZZywavpz7InSY=; b=PFbA8rPwxRG3cVoSnqq+sl47kqFSaUhK4Nfr0A6XI+4ErhS2CTBpZurKOMMRkWVWqt Li/BdWUbR7FWn5LmV+PDgDivQ0kbn5TeAdJD5ONsVdl9x+kL0Chi1DaFNoDQJMUPVd+T IV1uUykG6LpSRE9131pQFJSNYFZ2dF+NEd+hhAp16P7lrFxxNIXb7XTmQqVIRbOmC0Zs PeAvM4BffGcBtBGwgLWb9400fbJH5nJEnUDoRxo4ICyOP0Q3oIJOyFERTcIZ97fL457T 5GHtaEjxt3F30EwLqcLWB07IEO8dvwJEc5P2i464Zxp1Jk/4YErDuUMlG33SOJBLf6pA meFA== X-Forwarded-Encrypted: i=1; AJvYcCUv1a+S6g96nHJL+LSYpf8r6vEX9hyWo37UzCgLLynlLs8RCDLDIqYnq/s+Mjru4517bGtB8NVhH1lvg40=@vger.kernel.org X-Gm-Message-State: AOJu0YwnLKR7qYRxaDwTAvIE7fNkeJkF5TAnGr5xfVo5aEVxLgl6kXRb vEn63xEO4JqhINhednmjJBx2zjbGVuHPb3xD76BnMOUPgT3+2ljZBdlUp/OvmCNRMkDWj/KKuqL tczOLsg== X-Google-Smtp-Source: AGHT+IGBKZmj0xcnx3IB64TcbS0pb/r17lmOgH8lxAqqhmr49CDFUH1EBNpi6iyWZc1C2ZsKErjB7VbqxAQl X-Received: from pfbfn23.prod.google.com ([2002:a05:6a00:2fd7:b0:740:555:f7af]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:3924:b0:736:34a2:8a18 with SMTP id d2e1a72fcca58-7403a836556mr988402b3a.24.1745973715575; Tue, 29 Apr 2025 17:41:55 -0700 (PDT) Date: Tue, 29 Apr 2025 17:41:28 -0700 In-Reply-To: <20250430004128.474388-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250430004128.474388-1-irogers@google.com> X-Mailer: git-send-email 2.49.0.901.g37484f566f-goog Message-ID: <20250430004128.474388-7-irogers@google.com> Subject: [PATCH v2 6/6] perf test demangle-ocaml: Switch to using dso__demangle_sym From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , "=?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?=" , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , James Clark , Howard Chu , Jiapeng Chong , Ravi Bangoria , "Masami Hiramatsu (Google)" , Stephen Brennan , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, rust-for-linux@vger.kernel.org, llvm@lists.linux.dev, Daniel Xu , Ariel Ben-Yehuda Cc: Ian Rogers Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The use of the demangle-ocaml APIs means we don't detect if a different demangler is used before the OCaml one for the case that matters to perf. Signed-off-by: Ian Rogers --- tools/perf/tests/demangle-ocaml-test.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tools/perf/tests/demangle-ocaml-test.c b/tools/perf/tests/dema= ngle-ocaml-test.c index 90a4285e2ad5..612c788b7e0d 100644 --- a/tools/perf/tests/demangle-ocaml-test.c +++ b/tools/perf/tests/demangle-ocaml-test.c @@ -2,10 +2,9 @@ #include #include #include -#include "tests.h" -#include "session.h" #include "debug.h" -#include "demangle-ocaml.h" +#include "symbol.h" +#include "tests.h" =20 static int test__demangle_ocaml(struct test_suite *test __maybe_unused, in= t subtest __maybe_unused) { @@ -27,7 +26,7 @@ static int test__demangle_ocaml(struct test_suite *test _= _maybe_unused, int subt }; =20 for (i =3D 0; i < ARRAY_SIZE(test_cases); i++) { - buf =3D ocaml_demangle_sym(test_cases[i].mangled); + buf =3D dso__demangle_sym(/*dso=3D*/NULL, /*kmodule=3D*/0, test_cases[i]= .mangled); if ((buf =3D=3D NULL && test_cases[i].demangled !=3D NULL) || (buf !=3D NULL && test_cases[i].demangled =3D=3D NULL) || (buf !=3D NULL && strcmp(buf, test_cases[i].demangled))) { --=20 2.49.0.901.g37484f566f-goog