From nobody Tue Apr 7 01:03:54 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B1F736403F; Tue, 17 Mar 2026 09:32:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739944; cv=none; b=Qj8um18OSKj+CVJqOkIjQedesbGwpafa82DMiRuYgrfygH3mzth10iDG/8+WmGs/Ex2BaVYvQqYkiituvsoiCP1WCTwSHn/4IFLcvxrie7de43XYx/t9AIQA7Ri1MNUXfDNzhpgNW6oyxYAWpU5CFftF5RpImWNuAckSgtmXIJE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739944; c=relaxed/simple; bh=V5PTH40VekrkxYCqjZUI1t6FYotUriGKSPdl3yvDG+M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PNakDtxyu7d5oU5UnYzX8Y6cwQSzxXh7LaQ3e/D4ftvK+UAsOwDgHuZ3ucHQ/WLEdQrTgpJoBKBEOUIh3fswbAngtH1i7oRi1Fb36Scb5MwkJ90lLxp4nJFYAw9p+2IHzRTlJkFxEjYTPFeO5zh6cY21AE/+Gm66Qe3d05lzpXQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gZjoQOKL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gZjoQOKL" Received: by smtp.kernel.org (Postfix) with ESMTPS id 0C976C2BCB0; Tue, 17 Mar 2026 09:32:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773739944; bh=V5PTH40VekrkxYCqjZUI1t6FYotUriGKSPdl3yvDG+M=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=gZjoQOKLKgaRPaav8Z1PVRhw8k3yIOBIddGAJxrYiPpTcR989DbbdvoE2Fu0UWP6l 7vy6aRAOd4zr0H4VkKU8PklMEOByCImiv0r2l34s+BF9dnV7LzSBkR87jrTLodq571 INmKswbzJVO3Qnc3NxsRsxHAsdTunmHRfwoZmF2gwWHZCXVe4Rkxs3kjzZno4uStJL LgOyyr77N6s6YBPma6Gd5fbYUNyGi+3Nn5M02qo2k+DfOgOmKiLTy22DJFg5OM7PlX ZWhuwtvXnw4DTRqxvzMTFSu+vgkndkQstscksFuMoohpiaGLCOGSijdh2VnV2/y+dq zD48cFQLuQQzQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id F18B4F33829; Tue, 17 Mar 2026 09:32:23 +0000 (UTC) From: Michael Riesch via B4 Relay Date: Tue, 17 Mar 2026 10:32:20 +0100 Subject: [PATCH v2 2/9] media: dt-bindings: add rockchip rk3588 vicap Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250430-rk3588-vicap-v2-2-77de5ee9048e@collabora.com> References: <20250430-rk3588-vicap-v2-0-77de5ee9048e@collabora.com> In-Reply-To: <20250430-rk3588-vicap-v2-0-77de5ee9048e@collabora.com> To: Mehdi Djait , Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Kever Yang , Jagan Teki , =?utf-8?q?=D0=9A=D1=83=D0=B7=D0=BD=D0=B5=D1=86=D0=BE=D0=B2_=D0=9C=D0=B8=D1=85=D0=B0=D0=B8=D0=BB?= , Sebastian Reichel , Nicolas Dufresne , Collabora Kernel Team , Sakari Ailus Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Michael Riesch X-Mailer: b4 0.12.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773739942; l=6651; i=michael.riesch@collabora.com; s=20250410; h=from:subject:message-id; bh=PLP1i3Q3G/G8xseLo4+pMV9u9+xVQUl6byMHyUWuO4g=; b=AqS14d5aadM5bP6UR7gw9PFX4fEa2SMiTGSJoGH84HOsgFCJyDi3galru8oBMOouhvm3lKLKH Raox9YOVttcBvcz3F2xqU2truM5WXGQp6BOVmNFPY65prKVneInYJLE X-Developer-Key: i=michael.riesch@collabora.com; a=ed25519; pk=+MWX1fffLFZtTPG/I6XdYm/+OSvpRE8D9evQaWbiN04= X-Endpoint-Received: by B4 Relay for michael.riesch@collabora.com/20250410 with auth_id=371 X-Original-From: Michael Riesch Reply-To: michael.riesch@collabora.com From: Michael Riesch Add documentation for the Rockchip RK3588 Video Capture (VICAP) unit. To that end, make the existing rockchip,rk3568-vicap documentation more general and introduce variant specific constraints. Signed-off-by: Michael Riesch --- .../bindings/media/rockchip,rk3568-vicap.yaml | 191 +++++++++++++++++= +--- 1 file changed, 167 insertions(+), 24 deletions(-) diff --git a/Documentation/devicetree/bindings/media/rockchip,rk3568-vicap.= yaml b/Documentation/devicetree/bindings/media/rockchip,rk3568-vicap.yaml index 18cd0a5a5318..15a889ff8e52 100644 --- a/Documentation/devicetree/bindings/media/rockchip,rk3568-vicap.yaml +++ b/Documentation/devicetree/bindings/media/rockchip,rk3568-vicap.yaml @@ -15,9 +15,15 @@ description: the data from camera sensors, video decoders, or other companion ICs and transfers it into system main memory by AXI bus. =20 + The Rockchip RK3588 Video Capture (VICAP) is similar to its RK3568 + counterpart, but features six MIPI CSI-2 ports and additional connections + to the image signal processor (ISP) blocks. + properties: compatible: - const: rockchip,rk3568-vicap + enum: + - rockchip,rk3568-vicap + - rockchip,rk3588-vicap =20 reg: maxItems: 1 @@ -26,37 +32,23 @@ properties: maxItems: 1 =20 clocks: - items: - - description: ACLK - - description: HCLK - - description: DCLK - - description: ICLK + minItems: 4 + maxItems: 5 =20 clock-names: - items: - - const: aclk - - const: hclk - - const: dclk - - const: iclk + minItems: 4 + maxItems: 5 =20 iommus: maxItems: 1 =20 resets: - items: - - description: ARST - - description: HRST - - description: DRST - - description: PRST - - description: IRST + minItems: 5 + maxItems: 9 =20 reset-names: - items: - - const: arst - - const: hrst - - const: drst - - const: prst - - const: irst + minItems: 5 + maxItems: 9 =20 rockchip,grf: $ref: /schemas/types.yaml#/definitions/phandle @@ -67,8 +59,15 @@ properties: =20 ports: $ref: /schemas/graph.yaml#/properties/ports + additionalProperties: false =20 properties: + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + port@0: $ref: /schemas/graph.yaml#/$defs/port-base unevaluatedProperties: false @@ -100,13 +99,75 @@ properties: =20 port@1: $ref: /schemas/graph.yaml#/properties/port - description: Port connected to the MIPI CSI-2 receiver output. + description: Port connected to the MIPI CSI-2 receiver 0 output. + + properties: + endpoint: + $ref: video-interfaces.yaml# + unevaluatedProperties: false + + port@2: + $ref: /schemas/graph.yaml#/properties/port + description: Port connected to the MIPI CSI-2 receiver 1 output. + + properties: + endpoint: + $ref: video-interfaces.yaml# + unevaluatedProperties: false + + port@3: + $ref: /schemas/graph.yaml#/properties/port + description: Port connected to the MIPI CSI-2 receiver 2 output. + + properties: + endpoint: + $ref: video-interfaces.yaml# + unevaluatedProperties: false + + port@4: + $ref: /schemas/graph.yaml#/properties/port + description: Port connected to the MIPI CSI-2 receiver 3 output. + + properties: + endpoint: + $ref: video-interfaces.yaml# + unevaluatedProperties: false + + port@5: + $ref: /schemas/graph.yaml#/properties/port + description: Port connected to the MIPI CSI-2 receiver 4 output. + + properties: + endpoint: + $ref: video-interfaces.yaml# + unevaluatedProperties: false + + port@6: + $ref: /schemas/graph.yaml#/properties/port + description: Port connected to the MIPI CSI-2 receiver 5 output. =20 properties: endpoint: $ref: video-interfaces.yaml# unevaluatedProperties: false =20 + port@10: + $ref: /schemas/graph.yaml#/properties/port + description: Port connected to the ISP0 input. + + properties: + endpoint: + $ref: video-interfaces.yaml# + unevaluatedProperties: false + + port@11: + $ref: /schemas/graph.yaml#/properties/port + description: Port connected to the ISP1 input. + + properties: + endpoint: + $ref: video-interfaces.yaml# + unevaluatedProperties: false required: - compatible - reg @@ -114,6 +175,88 @@ required: - clocks - ports =20 +allOf: + - if: + properties: + compatible: + contains: + const: rockchip,rk3568-vicap + then: + properties: + clocks: + minItems: 4 + maxItems: 4 + + clock-names: + items: + - const: aclk + - const: hclk + - const: dclk + - const: iclk + + resets: + minItems: 5 + maxItems: 5 + + reset-names: + items: + - const: arst + - const: hrst + - const: drst + - const: prst + - const: irst + + ports: + properties: + port@2: false + + port@3: false + + port@4: false + + port@5: false + + port@6: false + + port@10: false + + port@11: false + + - if: + properties: + compatible: + contains: + const: rockchip,rk3588-vicap + then: + properties: + clocks: + minItems: 5 + maxItems: 5 + + clock-names: + items: + - const: aclk + - const: hclk + - const: dclk + - const: iclk0 + - const: iclk1 + + resets: + minItems: 9 + maxItems: 9 + + reset-names: + items: + - const: arst + - const: hrst + - const: drst + - const: irst0 + - const: irst1 + - const: irst2 + - const: irst3 + - const: irst4 + - const: irst5 + additionalProperties: false =20 examples: --=20 2.39.5