From nobody Sat Feb 7 15:40:19 2026 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF743231820; Tue, 29 Apr 2025 23:46:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745970385; cv=none; b=qqkjpSXyTjmzgRvuOgVyEbLrGDVfNKdZ1NJd0876rInq/4QzfbjObAhcrwEBEyhQzk31Z5ONDff5vzq/K5UeM3hZs4e4Jh/JHO3dCrJ2SlKaOE/ct7dg4fvehFMlrmf5wqofhvNUjGF9Ty1tRTjCatQ+gDqChZSOO6pbhPRXHhI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745970385; c=relaxed/simple; bh=5eneIEPCdB83u8+BEhtmTgT1YL8I248r9AioANb2tNc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=d2e3FE+rcz4HUe8FC1YCP5TErnULmbZQplWUlLHp6Qpt7uTmqP+8Xb7sdvrtaMvrGz5iqdzKBfwSZezHu+z4vXo2Sekez4TMhWH+h7kk5+s9zou/X5U2Mavs00ZWpWPwQU8PD06ZsEf7PcCI1IuK/zO3awCnuppKnlKKdCBSxKE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=bbJ1ts7q; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="bbJ1ts7q" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=C8ixYIeM5DXpPc0p7oUirQcwqBIWEQe7FnFZNeRD93w=; b=bbJ1ts7qbOFpLTg5 ZBDi8gVNHFuxFjONkQYcb0/Pnl+FECmTkjsTkm7LwBsvzdREmMkPIhpKa7YxWdA20CXJmlKzuTlBq q+Q1FMONfsAJ3/C02lkOBypyId62DEypw8KIJ8Tr2DdbbB17KJB2/xDuzhHzvVmU9QSqSmqYX6SJp o7wRxFkxQhKFOpPRsDPcUzFCIAQ/nL+QRsxFtQcBGjxfvOV2afBYMiJNjh15BPI57pxatsZaYKBM1 wY7E3VRN7OXiGPOVHaR1ejVgiL1Q5K+jAoqp19+2F5IFP9ZYFjzhQSdCnfSIRJ7nQju1IPGNh/zz4 axoCZFIBYMG9uWtLSg==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1u9ueP-000WFz-2E; Tue, 29 Apr 2025 23:46:09 +0000 From: linux@treblig.org To: arnaud.pouliquen@foss.st.com, andersson@kernel.org, mathieu.poirier@linaro.org Cc: corbet@lwn.net, linux-remoteproc@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH v3 1/3] rpmsg: core: Remove deadcode Date: Wed, 30 Apr 2025 00:45:57 +0100 Message-ID: <20250429234600.301083-2-linux@treblig.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250429234600.301083-1-linux@treblig.org> References: <20250429234600.301083-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" rpmsg_send_offchannel() and rpmsg_trysend_offchannel() have been unused since they were added in 2011's commit bcabbccabffe ("rpmsg: add virtio-based remote processor messaging bus") Remove them and associated docs. Signed-off-by: Dr. David Alan Gilbert Acked-by: Arnaud Pouliquen --- Documentation/staging/rpmsg.rst | 46 ------------------------ drivers/rpmsg/rpmsg_core.c | 63 --------------------------------- include/linux/rpmsg.h | 22 ------------ 3 files changed, 131 deletions(-) diff --git a/Documentation/staging/rpmsg.rst b/Documentation/staging/rpmsg.= rst index 3713adaa1608..40282cca86ca 100644 --- a/Documentation/staging/rpmsg.rst +++ b/Documentation/staging/rpmsg.rst @@ -110,31 +110,6 @@ or a timeout of 15 seconds elapses. When the latter ha= ppens, The function can only be called from a process context (for now). Returns 0 on success and an appropriate error value on failure. =20 -:: - - int rpmsg_send_offchannel(struct rpmsg_endpoint *ept, u32 src, u32 dst, - void *data, int len); - - -sends a message across to the remote processor, using the src and dst -addresses provided by the user. - -The caller should specify the endpoint, the data it wants to send, -its length (in bytes), and explicit source and destination addresses. -The message will then be sent to the remote processor to which the -endpoint's channel belongs, but the endpoint's src and channel dst -addresses will be ignored (and the user-provided addresses will -be used instead). - -In case there are no TX buffers available, the function will block until -one becomes available (i.e. until the remote processor consumes -a tx buffer and puts it back on virtio's used descriptor ring), -or a timeout of 15 seconds elapses. When the latter happens, --ERESTARTSYS is returned. - -The function can only be called from a process context (for now). -Returns 0 on success and an appropriate error value on failure. - :: =20 int rpmsg_trysend(struct rpmsg_endpoint *ept, void *data, int len); @@ -173,27 +148,6 @@ return -ENOMEM without waiting until one becomes avail= able. The function can only be called from a process context (for now). Returns 0 on success and an appropriate error value on failure. =20 -:: - - int rpmsg_trysend_offchannel(struct rpmsg_endpoint *ept, u32 src, u32 ds= t, - void *data, int len); - - -sends a message across to the remote processor, using source and -destination addresses provided by the user. - -The user should specify the channel, the data it wants to send, -its length (in bytes), and explicit source and destination addresses. -The message will then be sent to the remote processor to which the -channel belongs, but the channel's src and dst addresses will be -ignored (and the user-provided addresses will be used instead). - -In case there are no TX buffers available, the function will immediately -return -ENOMEM without waiting until one becomes available. - -The function can only be called from a process context (for now). -Returns 0 on success and an appropriate error value on failure. - :: =20 struct rpmsg_endpoint *rpmsg_create_ept(struct rpmsg_device *rpdev, diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c index 207b64c0a2fe..6ee36adcbdba 100644 --- a/drivers/rpmsg/rpmsg_core.c +++ b/drivers/rpmsg/rpmsg_core.c @@ -193,38 +193,6 @@ int rpmsg_sendto(struct rpmsg_endpoint *ept, void *dat= a, int len, u32 dst) } EXPORT_SYMBOL(rpmsg_sendto); =20 -/** - * rpmsg_send_offchannel() - send a message using explicit src/dst address= es - * @ept: the rpmsg endpoint - * @src: source address - * @dst: destination address - * @data: payload of message - * @len: length of payload - * - * This function sends @data of length @len to the remote @dst address, - * and uses @src as the source address. - * The message will be sent to the remote processor which the @ept - * endpoint belongs to. - * In case there are no TX buffers available, the function will block until - * one becomes available, or a timeout of 15 seconds elapses. When the lat= ter - * happens, -ERESTARTSYS is returned. - * - * Can only be called from process context (for now). - * - * Return: 0 on success and an appropriate error value on failure. - */ -int rpmsg_send_offchannel(struct rpmsg_endpoint *ept, u32 src, u32 dst, - void *data, int len) -{ - if (WARN_ON(!ept)) - return -EINVAL; - if (!ept->ops->send_offchannel) - return -ENXIO; - - return ept->ops->send_offchannel(ept, src, dst, data, len); -} -EXPORT_SYMBOL(rpmsg_send_offchannel); - /** * rpmsg_trysend() - send a message across to the remote processor * @ept: the rpmsg endpoint @@ -301,37 +269,6 @@ __poll_t rpmsg_poll(struct rpmsg_endpoint *ept, struct= file *filp, } EXPORT_SYMBOL(rpmsg_poll); =20 -/** - * rpmsg_trysend_offchannel() - send a message using explicit src/dst addr= esses - * @ept: the rpmsg endpoint - * @src: source address - * @dst: destination address - * @data: payload of message - * @len: length of payload - * - * This function sends @data of length @len to the remote @dst address, - * and uses @src as the source address. - * The message will be sent to the remote processor which the @ept - * endpoint belongs to. - * In case there are no TX buffers available, the function will immediately - * return -ENOMEM without waiting until one becomes available. - * - * Can only be called from process context (for now). - * - * Return: 0 on success and an appropriate error value on failure. - */ -int rpmsg_trysend_offchannel(struct rpmsg_endpoint *ept, u32 src, u32 dst, - void *data, int len) -{ - if (WARN_ON(!ept)) - return -EINVAL; - if (!ept->ops->trysend_offchannel) - return -ENXIO; - - return ept->ops->trysend_offchannel(ept, src, dst, data, len); -} -EXPORT_SYMBOL(rpmsg_trysend_offchannel); - /** * rpmsg_set_flow_control() - request remote to pause/resume transmission * @ept: the rpmsg endpoint diff --git a/include/linux/rpmsg.h b/include/linux/rpmsg.h index 90d8e4475f80..fb7ab9165645 100644 --- a/include/linux/rpmsg.h +++ b/include/linux/rpmsg.h @@ -184,13 +184,9 @@ struct rpmsg_endpoint *rpmsg_create_ept(struct rpmsg_d= evice *, =20 int rpmsg_send(struct rpmsg_endpoint *ept, void *data, int len); int rpmsg_sendto(struct rpmsg_endpoint *ept, void *data, int len, u32 dst); -int rpmsg_send_offchannel(struct rpmsg_endpoint *ept, u32 src, u32 dst, - void *data, int len); =20 int rpmsg_trysend(struct rpmsg_endpoint *ept, void *data, int len); int rpmsg_trysendto(struct rpmsg_endpoint *ept, void *data, int len, u32 d= st); -int rpmsg_trysend_offchannel(struct rpmsg_endpoint *ept, u32 src, u32 dst, - void *data, int len); =20 __poll_t rpmsg_poll(struct rpmsg_endpoint *ept, struct file *filp, poll_table *wait); @@ -271,15 +267,6 @@ static inline int rpmsg_sendto(struct rpmsg_endpoint *= ept, void *data, int len, =20 } =20 -static inline int rpmsg_send_offchannel(struct rpmsg_endpoint *ept, u32 sr= c, - u32 dst, void *data, int len) -{ - /* This shouldn't be possible */ - WARN_ON(1); - - return -ENXIO; -} - static inline int rpmsg_trysend(struct rpmsg_endpoint *ept, void *data, in= t len) { /* This shouldn't be possible */ @@ -297,15 +284,6 @@ static inline int rpmsg_trysendto(struct rpmsg_endpoin= t *ept, void *data, return -ENXIO; } =20 -static inline int rpmsg_trysend_offchannel(struct rpmsg_endpoint *ept, u32= src, - u32 dst, void *data, int len) -{ - /* This shouldn't be possible */ - WARN_ON(1); - - return -ENXIO; -} - static inline __poll_t rpmsg_poll(struct rpmsg_endpoint *ept, struct file *filp, poll_table *wait) { --=20 2.49.0 From nobody Sat Feb 7 15:40:19 2026 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05E0B28032F; Tue, 29 Apr 2025 23:46:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745970392; cv=none; b=JbqE0bgA53Au8mu8wN7OsLokIV69amhOTf5bxlaT8BYVK1S9/oOuGUlwvPRGQ3WBq77vvrUzYOw0pJUWFrgp2RGWM647vacbhADM2Pt/IAuzP8hZuPj6fOP6Wai3IB+WkXHqz0FBYv/QGG7sa85Rskw5s+d3XcIiRDRUuPrjla0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745970392; c=relaxed/simple; bh=jC9ESrquPWsK4+tw8ngYfnrS7aa/CAurRFMXmPtAc+I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=G3Q0cIOJnLe/jjoIIPEZ6iyqaALG5ozmEjavm1TDBtA15SMCvlfGC6+TN9ZVelsB54MgUN5EA212AsT2dEi/knRGYjnFnP1/00KyVshl0LWaPJ24Q/3CtRRRRpum7P9cLweBZ246sfoJLjN2ggtdh7JNvFx4IOcsW5JKHs1OjDI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=nENxa7Ng; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="nENxa7Ng" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=uRcjVbFq8T8/LjI+x083YOLHE0Mpv5g8CqVtzshi4Ds=; b=nENxa7NgF9VhOOqX t1+9fnOoIaZl14n9BOIWc2rF4O9Y1rPeQlciq8hHFu1+wMCwmLRPFMvRr+rpFLRokxU4ZoVYwAKcZ 0AnoqcK05Nmw82RHZXLbkREMRwx2Cz6Nuily4StuKsYlTHbhuEUql/Pep1YGwKudfSEaB8knO8GDW rZW0tOMTDGMnTOkCMEMigpjOeEfBNJHHIe2pNkQFjCWHdlOW96mvEM+zqaq2cLp21Y3p9FwHxh5OX gGYmW/PhtDKW/+TKNs7tWqUlvVXTufOdVL5LR0+mOmTy6TYGnlR4pwuZT4Yug0zsXcYzkgRazacyE f5U52f8GWAPeURXliQ==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1u9ueQ-000WFz-0b; Tue, 29 Apr 2025 23:46:10 +0000 From: linux@treblig.org To: arnaud.pouliquen@foss.st.com, andersson@kernel.org, mathieu.poirier@linaro.org Cc: corbet@lwn.net, linux-remoteproc@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH v3 2/3] rpmsg: virtio: Remove uncallable offchannel functions Date: Wed, 30 Apr 2025 00:45:58 +0100 Message-ID: <20250429234600.301083-3-linux@treblig.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250429234600.301083-1-linux@treblig.org> References: <20250429234600.301083-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" The virtio_rpmsg_send_offchannel() and virtio_rpmsg_trysend_offchannel() are wired up to the send_offchannel and trysend_offchannel members of rpmsg_endpoint_ops, the only dereference of those was by the unused, and now removed rpmsg_send_offchannel() and rpmsg_trysend_offchannel() functions. Remove them. Signed-off-by: Dr. David Alan Gilbert Acked-by: Arnaud Pouliquen --- drivers/rpmsg/virtio_rpmsg_bus.c | 24 +----------------------- 1 file changed, 1 insertion(+), 23 deletions(-) diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_= bus.c index 89d7a3b8c48b..4730b1c8b322 100644 --- a/drivers/rpmsg/virtio_rpmsg_bus.c +++ b/drivers/rpmsg/virtio_rpmsg_bus.c @@ -141,13 +141,9 @@ static void virtio_rpmsg_destroy_ept(struct rpmsg_endp= oint *ept); static int virtio_rpmsg_send(struct rpmsg_endpoint *ept, void *data, int l= en); static int virtio_rpmsg_sendto(struct rpmsg_endpoint *ept, void *data, int= len, u32 dst); -static int virtio_rpmsg_send_offchannel(struct rpmsg_endpoint *ept, u32 sr= c, - u32 dst, void *data, int len); static int virtio_rpmsg_trysend(struct rpmsg_endpoint *ept, void *data, in= t len); static int virtio_rpmsg_trysendto(struct rpmsg_endpoint *ept, void *data, int len, u32 dst); -static int virtio_rpmsg_trysend_offchannel(struct rpmsg_endpoint *ept, u32= src, - u32 dst, void *data, int len); static ssize_t virtio_rpmsg_get_mtu(struct rpmsg_endpoint *ept); static struct rpmsg_device *__rpmsg_create_channel(struct virtproc_info *v= rp, struct rpmsg_channel_info *chinfo); @@ -156,10 +152,8 @@ static const struct rpmsg_endpoint_ops virtio_endpoint= _ops =3D { .destroy_ept =3D virtio_rpmsg_destroy_ept, .send =3D virtio_rpmsg_send, .sendto =3D virtio_rpmsg_sendto, - .send_offchannel =3D virtio_rpmsg_send_offchannel, .trysend =3D virtio_rpmsg_trysend, .trysendto =3D virtio_rpmsg_trysendto, - .trysend_offchannel =3D virtio_rpmsg_trysend_offchannel, .get_mtu =3D virtio_rpmsg_get_mtu, }; =20 @@ -545,7 +539,7 @@ static void rpmsg_downref_sleepers(struct virtproc_info= *vrp) * the function will immediately fail, and -ENOMEM will be returned. * * Normally drivers shouldn't use this function directly; instead, drivers - * should use the appropriate rpmsg_{try}send{to, _offchannel} API + * should use the appropriate rpmsg_{try}send{to} API * (see include/linux/rpmsg.h). * * Return: 0 on success and an appropriate error value on failure. @@ -665,14 +659,6 @@ static int virtio_rpmsg_sendto(struct rpmsg_endpoint *= ept, void *data, int len, return rpmsg_send_offchannel_raw(rpdev, src, dst, data, len, true); } =20 -static int virtio_rpmsg_send_offchannel(struct rpmsg_endpoint *ept, u32 sr= c, - u32 dst, void *data, int len) -{ - struct rpmsg_device *rpdev =3D ept->rpdev; - - return rpmsg_send_offchannel_raw(rpdev, src, dst, data, len, true); -} - static int virtio_rpmsg_trysend(struct rpmsg_endpoint *ept, void *data, in= t len) { struct rpmsg_device *rpdev =3D ept->rpdev; @@ -690,14 +676,6 @@ static int virtio_rpmsg_trysendto(struct rpmsg_endpoin= t *ept, void *data, return rpmsg_send_offchannel_raw(rpdev, src, dst, data, len, false); } =20 -static int virtio_rpmsg_trysend_offchannel(struct rpmsg_endpoint *ept, u32= src, - u32 dst, void *data, int len) -{ - struct rpmsg_device *rpdev =3D ept->rpdev; - - return rpmsg_send_offchannel_raw(rpdev, src, dst, data, len, false); -} - static ssize_t virtio_rpmsg_get_mtu(struct rpmsg_endpoint *ept) { struct rpmsg_device *rpdev =3D ept->rpdev; --=20 2.49.0 From nobody Sat Feb 7 15:40:19 2026 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 721602222A3; Tue, 29 Apr 2025 23:46:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745970385; cv=none; b=EIIXt0BRKys5r76nqDR7s6/xOhAXB2NOnoKWfiLtcRJzEPKhtmfXLmxYGWVXdzg9Exclz7U/AQ11+NnDO27QgTCtty7624Z2meEuZ3dAW7pu8BTX4q/E2drsouzmVsp0N8Xj3uLVmCLGYb/WUHOXxZkYd2CtrNV2A21dxL+aRbk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745970385; c=relaxed/simple; bh=NGaIyrfLvZYm2Bbqj86f7XJVeWE52V6E339DRzSa20w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dMamOO3THuqS57cb3v/RfGgha+owjk7uYfqcwlH+9kpN3rB1P4SaS7U4A5Sj2uD3cZQ2N4jdIrboUJk9xSil5LcKFxmYmiK3Ovqcj/wTkox421TI9ayBdQA+Qpk1L0G4OGHzsk/k9R8Znkg1ueV8vYzVNGT5+KY0r2qumzmcovU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=jtfFETES; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="jtfFETES" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=SrpJl8aswLmDlKg/oEU55Eu7Y/A7GY9f/+w2KaZJniM=; b=jtfFETESGjVlJ+3P ztmtGff/8bCt5BaU0drQID5thdVjuAF/Y8r0L1WeeeBB5+h+0xiq8yeI9zAVKszMsmHF23Gy0r2IH sYcJV371+suYiJucgwfrAzf1ioqHIiGnCdd+KcLgkrv/hkKkxRHKcInwamBHB8IpCJiz/J5+jPpWr sZfaOlYPPCJaGjbiEVHHktkFxRnETaOsOvEIPDvFxD3nNjW7fvnrP/uPHfWlYQK/ipaObId7LXYBc J8yA77KRfYjRpuaWe3HH04O+Dk7BZIOo0kR11phwAsucDJZ/k87qCrokLBZLZ13j1I+Rn3iHs40/6 QgN+iczIc1EO++J9JQ==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1u9ueQ-000WFz-2H; Tue, 29 Apr 2025 23:46:10 +0000 From: linux@treblig.org To: arnaud.pouliquen@foss.st.com, andersson@kernel.org, mathieu.poirier@linaro.org Cc: corbet@lwn.net, linux-remoteproc@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH v3 3/3] rpmsg: Remove unused method pointers *send_offchannel Date: Wed, 30 Apr 2025 00:45:59 +0100 Message-ID: <20250429234600.301083-4-linux@treblig.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250429234600.301083-1-linux@treblig.org> References: <20250429234600.301083-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" After the previous patch, there are no implementers of the send_offchannel() and trysend_offchannel() methods. Remove them. Signed-off-by: Dr. David Alan Gilbert Acked-by: Arnaud Pouliquen --- drivers/rpmsg/rpmsg_internal.h | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/rpmsg/rpmsg_internal.h b/drivers/rpmsg/rpmsg_internal.h index 42c7007be1b5..397e4926bd02 100644 --- a/drivers/rpmsg/rpmsg_internal.h +++ b/drivers/rpmsg/rpmsg_internal.h @@ -50,10 +50,8 @@ struct rpmsg_device_ops { * @destroy_ept: see @rpmsg_destroy_ept(), required * @send: see @rpmsg_send(), required * @sendto: see @rpmsg_sendto(), optional - * @send_offchannel: see @rpmsg_send_offchannel(), optional * @trysend: see @rpmsg_trysend(), required * @trysendto: see @rpmsg_trysendto(), optional - * @trysend_offchannel: see @rpmsg_trysend_offchannel(), optional * @poll: see @rpmsg_poll(), optional * @set_flow_control: see @rpmsg_set_flow_control(), optional * @get_mtu: see @rpmsg_get_mtu(), optional @@ -67,13 +65,9 @@ struct rpmsg_endpoint_ops { =20 int (*send)(struct rpmsg_endpoint *ept, void *data, int len); int (*sendto)(struct rpmsg_endpoint *ept, void *data, int len, u32 dst); - int (*send_offchannel)(struct rpmsg_endpoint *ept, u32 src, u32 dst, - void *data, int len); =20 int (*trysend)(struct rpmsg_endpoint *ept, void *data, int len); int (*trysendto)(struct rpmsg_endpoint *ept, void *data, int len, u32 dst= ); - int (*trysend_offchannel)(struct rpmsg_endpoint *ept, u32 src, u32 dst, - void *data, int len); __poll_t (*poll)(struct rpmsg_endpoint *ept, struct file *filp, poll_table *wait); int (*set_flow_control)(struct rpmsg_endpoint *ept, bool pause, u32 dst); --=20 2.49.0