From nobody Sun Feb 8 23:35:23 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5966B26FA6E for ; Tue, 29 Apr 2025 21:48:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745963292; cv=none; b=Un3Zc51XS2e0n4E+rt14t7OP3IOjoU9k4srtp0Kg0CXwQY57V710P/zk/H1EJUdIH5WoeZm1/pvlQ7slovQMJX/PPxr/2hescpfM7cM4IGvJfTxH53ELVqgbpGS5dgp8YQj6nWcKR3l0leU9fiGCEVrOLZWmGTx0KYBVS9qvTuI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745963292; c=relaxed/simple; bh=nTqe0PDL/gL9YiXXxz5bNPPj0SodUqvokk2yftri5Rg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eUbNcn2bWatcPzOwP4VMUkG9Qhq6E7sueZ/O4HDSENsGm+aWZmDMHqlo5QbCecW7pfKwkU+riPMN1SdqA5T+Y/qSlthJsdSGIJsMdxfpv8/yPDt4YqWkQvGHwCC5IfTXqd7LYmchZMhtOZ3jA84jd0yVdf/hxf7j/ZkNXCzkOWw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=KC2pj+Jg; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KC2pj+Jg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745963290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yX5+ZjQPENf74ftxxnt80TaBhjIdXfKiwqjkj6Gc0n8=; b=KC2pj+JgIP9gT39Hp0sRCuoGeHNzIAgyswIUA7mIWLr9Pdp6/9x11Is/sdIeyXVFWaw4a3 gc1Y4Gy+7ERJOwvRXZXileeAp+veNcta7we5LG7J+S6qZrDYWrERPRCeIWUkzq8GvxBVtu X8UkT1pXSozpiv7+FR5KuDg/TSMhDfw= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-205-E6X-vOuOMyKkbN9YtiS_AA-1; Tue, 29 Apr 2025 17:48:05 -0400 X-MC-Unique: E6X-vOuOMyKkbN9YtiS_AA-1 X-Mimecast-MFC-AGG-ID: E6X-vOuOMyKkbN9YtiS_AA_1745963283 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 13BC61956087; Tue, 29 Apr 2025 21:48:03 +0000 (UTC) Received: from chopper.redhat.com (unknown [10.22.88.132]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C749919560A3; Tue, 29 Apr 2025 21:47:58 +0000 (UTC) From: Lyude Paul To: rust-for-linux@vger.kernel.org, Andreas Hindborg , linux-kernel@vger.kernel.org Cc: Boqun Feng , FUJITA Tomonori , Frederic Weisbecker , Thomas Gleixner , Anna-Maria Behnsen , John Stultz , Stephen Boyd , Miguel Ojeda , Alex Gaynor , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Alice Ryhl , Trevor Gross , Danilo Krummrich Subject: [PATCH v4 1/7] rust: hrtimer: Document the return value for HrTimerHandle::cancel() Date: Tue, 29 Apr 2025 17:44:37 -0400 Message-ID: <20250429214752.1637859-2-lyude@redhat.com> In-Reply-To: <20250429214752.1637859-1-lyude@redhat.com> References: <20250429214752.1637859-1-lyude@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 Content-Type: text/plain; charset="utf-8" Just a drive-by fix I noticed: we don't actually document what the return value from cancel() does, so do that. Signed-off-by: Lyude Paul --- V4: * Reword to "Returns `true` if the timer was running." Signed-off-by: Lyude Paul --- rust/kernel/time/hrtimer.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/rust/kernel/time/hrtimer.rs b/rust/kernel/time/hrtimer.rs index 27243eaaf8ed7..ef96c7e2c21ff 100644 --- a/rust/kernel/time/hrtimer.rs +++ b/rust/kernel/time/hrtimer.rs @@ -304,6 +304,8 @@ pub unsafe trait HrTimerHandle { /// Note that the timer might be started by a concurrent start operati= on. If /// so, the timer might not be in the **stopped** state when this func= tion /// returns. + /// + /// Returns `true` if the timer was running. fn cancel(&mut self) -> bool; } =20 --=20 2.48.1