From nobody Sun Dec 14 19:15:53 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB16E21ADC7; Tue, 29 Apr 2025 17:21:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745947290; cv=none; b=XSeCjD3aeaEFQAM82iZ+YO6Lvx9fCxVXkumSEgQjaIJaFdeZXuRKMLI4YSlnO+/q/KRnMjAL4DmPYB5PGifo4kQRM1xN1h1hmY8D5zNPmvGRRRTbPhgLxC8WEoDzPhoLcQlehOCBw+UF6xfHW+DA0bO9cvV4c5XsgDJfT4dzEZE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745947290; c=relaxed/simple; bh=jXYC4qe83QMGvpN4IuiBaOllJp2/Rn6mzBWJF/nv1hc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=emVuqTCYCId9bLr/CQwhSwi197C8PWnfQE4WO0AGq7yJuGtuNIN9xK81X01iozu9m0I1N6fPUtH0NlEJmcdnyCJRoYHU/0hmGfTWnTM3wQRmkutGQxOlvBNii1RiGBmV7W7S69c2qlZyNwvzx8WvDN+oao4PBFelrARDdQtV9Yc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=FNsYLFZZ; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="FNsYLFZZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1745947289; x=1777483289; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jXYC4qe83QMGvpN4IuiBaOllJp2/Rn6mzBWJF/nv1hc=; b=FNsYLFZZI27F8Dzbcl7Q3JHjtUcYEjs5oQc5dd0nayalysX46siQmfG5 TafjOKJ4lsxIfy6TAE6JwlzAnTMbecyEoC9zYeIHEU5WFNH8N/vNa9Zc7 J6XytXjNz1d4wVqYd50P/4cUtFx7ldm6MABev9yk7wokBJsYDa5wjK57T jenpz4HFz9preSXpzsQymnoVbPSKMxc6omSXOVQ+WNpEfU4H5Drlp30jU 0u8uDYMZpf2cMbavoybLC8Fad3rulbNWmdRiXNay2pLz0tqPpXLrIkpB9 xEDEBuiWBsDDZbljheNcQYC2o3ZtFvzy8TAGRxrXwHHMqf0Gd5hAFZINL A==; X-CSE-ConnectionGUID: eZVVA5r6RJyUTGo3p+vlRw== X-CSE-MsgGUID: 6teZHX2rQkyIaeenxXU42Q== X-IronPort-AV: E=McAfee;i="6700,10204,11418"; a="64996944" X-IronPort-AV: E=Sophos;i="6.15,249,1739865600"; d="scan'208";a="64996944" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2025 10:21:28 -0700 X-CSE-ConnectionGUID: zknYB+4jScW5iqrF3wMtuA== X-CSE-MsgGUID: uop2XdxpR66xI/cEmlvLyw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,249,1739865600"; d="scan'208";a="139073312" Received: from sschumil-mobl2.ger.corp.intel.com (HELO fdefranc-mobl3.intel.com) ([10.245.246.45]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2025 10:21:20 -0700 From: "Fabio M. De Francesco" To: "Rafael J . Wysocki" , Len Brown , Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , Mahesh J Salgaonkar , Oliver O'Halloran , Bjorn Helgaas , Tony Luck , Borislav Petkov , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org, linux-edac@vger.kernel.org Cc: "Fabio M. De Francesco" Subject: [PATCH 1/4 v2] ACPI: extlog: Trace CPER Non-standard Section Body Date: Tue, 29 Apr 2025 19:21:06 +0200 Message-ID: <20250429172109.3199192-2-fabio.m.de.francesco@linux.intel.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250429172109.3199192-1-fabio.m.de.francesco@linux.intel.com> References: <20250429172109.3199192-1-fabio.m.de.francesco@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ghes_do_proc() has a catch-all for unknown or unhandled CPER formats (UEFI v2.10 Appendix N 2.3), extlog_print() does not. This gap was noticed by a RAS test that injected CXL protocol errors which were notified to extlog_print() via the IOMCA (I/O Machine Check Architecture) mechanism. Bring parity to the extlog_print() path by including a similar log_non_standard_event(). Cc: Dan Williams Reviewed-by: Dan Williams Signed-off-by: Fabio M. De Francesco Reviewed-by: Jonathan Cameron --- drivers/acpi/acpi_extlog.c | 6 ++++++ drivers/ras/ras.c | 1 + 2 files changed, 7 insertions(+) diff --git a/drivers/acpi/acpi_extlog.c b/drivers/acpi/acpi_extlog.c index f7fb7205028d..caca6ccd6e99 100644 --- a/drivers/acpi/acpi_extlog.c +++ b/drivers/acpi/acpi_extlog.c @@ -182,6 +182,12 @@ static int extlog_print(struct notifier_block *nb, uns= igned long val, if (gdata->error_data_length >=3D sizeof(*mem)) trace_extlog_mem_event(mem, err_seq, fru_id, fru_text, (u8)gdata->error_severity); + } else { + void *err =3D acpi_hest_get_payload(gdata); + + log_non_standard_event(sec_type, fru_id, fru_text, + gdata->error_severity, err, + gdata->error_data_length); } } =20 diff --git a/drivers/ras/ras.c b/drivers/ras/ras.c index a6e4792a1b2e..ac0e132ccc3e 100644 --- a/drivers/ras/ras.c +++ b/drivers/ras/ras.c @@ -51,6 +51,7 @@ void log_non_standard_event(const guid_t *sec_type, const= guid_t *fru_id, { trace_non_standard_event(sec_type, fru_id, fru_text, sev, err, len); } +EXPORT_SYMBOL_GPL(log_non_standard_event); =20 void log_arm_hw_error(struct cper_sec_proc_arm *err) { --=20 2.48.1 From nobody Sun Dec 14 19:15:53 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 356AA242D94; Tue, 29 Apr 2025 17:21:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745947296; cv=none; b=VRSLXrIsHxbOYdhJf6onwNT53BmJAKnvjWCkiUdqMZ2/srowmHAln+qj/lOpJeGHedPIr1Si8CU/P3K9pAsBM5aMXL/eRVTG05yZvzRQPwZY5e+fxWwRZOWKNigYm5jGs09T5objI4J5+TsDKuoqZi6M0G7YpGQZ0V8yiTpFpw0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745947296; c=relaxed/simple; bh=JndCVKWeSSfdR7hNOtWoioyuGzEZye/l3ydjb6NIV+w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=upXc/WFwha/bd5yNqR9KfbHW0EhlJ3boYkqW/DgH1jgQyIwo3nyEqg1SWdZPRj5ZV3hO9FqHVec16cPUhWnl8mPDikn764UFCtyk7vySMwWADfDAeGNn6EeXg4Wuro145HwaVmvkh7oemwXgtl53cqly+xz7H5HL8fcaksGrgCA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=aTds4bb9; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="aTds4bb9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1745947295; x=1777483295; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=JndCVKWeSSfdR7hNOtWoioyuGzEZye/l3ydjb6NIV+w=; b=aTds4bb9MJPkoJVrVR9ueZIGvFQ4++ab1FyZMygGUeJTwtF9d3PRsja1 IiE+ExeLDy9gwM8PqTYVQn5VCYnOElZipm/d0oi/Dgi8ZhZoW6Lnpk2TE AzNY0iovsGhMmHRo8q9SSHUUfCEe+xMXJAPGqHzmyArP4/CxSYTxG/Ztg CKWJH+9VegxI55rVIf54zYH9W/7Aoe5tQA1Vdsk62XHnpBnpde3pK4f9l Lhptgur2XQdeaRi52a7p/Cb2/DrfzOdcXUR5d/JB4VFjMf2yxC49wEAMe 93AnKa1sNisPd9/eQSHxeG4QKpHRaspfG5zU0mh3hv0gH+vISVa/TYJDs g==; X-CSE-ConnectionGUID: niuJmg2FSlCwgoKmWI7QkA== X-CSE-MsgGUID: bvRp0fraQmu98zf8lplwGw== X-IronPort-AV: E=McAfee;i="6700,10204,11418"; a="64996955" X-IronPort-AV: E=Sophos;i="6.15,249,1739865600"; d="scan'208";a="64996955" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2025 10:21:34 -0700 X-CSE-ConnectionGUID: 54JYejUrSaOsO1SvURqzVA== X-CSE-MsgGUID: Cf41YLqzRbqOKAqfoN/PMQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,249,1739865600"; d="scan'208";a="139073320" Received: from sschumil-mobl2.ger.corp.intel.com (HELO fdefranc-mobl3.intel.com) ([10.245.246.45]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2025 10:21:28 -0700 From: "Fabio M. De Francesco" To: "Rafael J . Wysocki" , Len Brown , Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , Mahesh J Salgaonkar , Oliver O'Halloran , Bjorn Helgaas , Tony Luck , Borislav Petkov , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org, linux-edac@vger.kernel.org Cc: "Fabio M. De Francesco" Subject: [PATCH 2/4 v2] PCI/AER: Modify pci_print_aer() to take log level Date: Tue, 29 Apr 2025 19:21:07 +0200 Message-ID: <20250429172109.3199192-3-fabio.m.de.francesco@linux.intel.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250429172109.3199192-1-fabio.m.de.francesco@linux.intel.com> References: <20250429172109.3199192-1-fabio.m.de.francesco@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Modify pci_print_aer() to take a printk() log level in preparation of a patch that logs PCIe Components and Link errors from ELOG. Cc: Dan Williams Acked-by: Bjorn Helgaas Signed-off-by: Fabio M. De Francesco Reviewed-by: Jonathan Cameron --- drivers/cxl/core/pci.c | 2 +- drivers/pci/pcie/aer.c | 16 ++++++++-------- include/linux/aer.h | 4 ++-- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/cxl/core/pci.c b/drivers/cxl/core/pci.c index 3b80e9a76ba8..ad8d7939c2e1 100644 --- a/drivers/cxl/core/pci.c +++ b/drivers/cxl/core/pci.c @@ -885,7 +885,7 @@ static void cxl_handle_rdport_errors(struct cxl_dev_sta= te *cxlds) if (!cxl_rch_get_aer_severity(&aer_regs, &severity)) return; =20 - pci_print_aer(pdev, severity, &aer_regs); + pci_print_aer(KERN_ERR, pdev, severity, &aer_regs); =20 if (severity =3D=3D AER_CORRECTABLE) cxl_handle_rdport_cor_ras(cxlds, dport); diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index a1cf8c7ef628..d0ebf7c15afa 100644 --- a/drivers/pci/pcie/aer.c +++ b/drivers/pci/pcie/aer.c @@ -760,7 +760,7 @@ int cper_severity_to_aer(int cper_severity) EXPORT_SYMBOL_GPL(cper_severity_to_aer); #endif =20 -void pci_print_aer(struct pci_dev *dev, int aer_severity, +void pci_print_aer(char *level, struct pci_dev *dev, int aer_severity, struct aer_capability_regs *aer) { int layer, agent, tlp_header_valid =3D 0; @@ -785,14 +785,15 @@ void pci_print_aer(struct pci_dev *dev, int aer_sever= ity, info.mask =3D mask; info.first_error =3D PCI_ERR_CAP_FEP(aer->cap_control); =20 - pci_err(dev, "aer_status: 0x%08x, aer_mask: 0x%08x\n", status, mask); + pci_printk(level, dev, "aer_status: 0x%08x, aer_mask: 0x%08x\n", + status, mask); __aer_print_error(dev, &info); - pci_err(dev, "aer_layer=3D%s, aer_agent=3D%s\n", - aer_error_layer[layer], aer_agent_string[agent]); + pci_printk(level, dev, "aer_layer=3D%s, aer_agent=3D%s\n", + aer_error_layer[layer], aer_agent_string[agent]); =20 if (aer_severity !=3D AER_CORRECTABLE) - pci_err(dev, "aer_uncor_severity: 0x%08x\n", - aer->uncor_severity); + pci_printk(level, dev, "aer_uncor_severity: 0x%08x\n", + aer->uncor_severity); =20 if (tlp_header_valid) pcie_print_tlp_log(dev, &aer->header_log, dev_fmt(" ")); @@ -1146,8 +1147,7 @@ static void aer_recover_work_func(struct work_struct = *work) PCI_SLOT(entry.devfn), PCI_FUNC(entry.devfn)); continue; } - pci_print_aer(pdev, entry.severity, entry.regs); - + pci_print_aer(KERN_ERR, pdev, entry.severity, entry.regs); /* * Memory for aer_capability_regs(entry.regs) is being * allocated from the ghes_estatus_pool to protect it from diff --git a/include/linux/aer.h b/include/linux/aer.h index 02940be66324..45d0fb2e2e75 100644 --- a/include/linux/aer.h +++ b/include/linux/aer.h @@ -64,8 +64,8 @@ static inline int pci_aer_clear_nonfatal_status(struct pc= i_dev *dev) static inline int pcie_aer_is_native(struct pci_dev *dev) { return 0; } #endif =20 -void pci_print_aer(struct pci_dev *dev, int aer_severity, - struct aer_capability_regs *aer); +void pci_print_aer(char *level, struct pci_dev *dev, int aer_severity, + struct aer_capability_regs *aer); int cper_severity_to_aer(int cper_severity); void aer_recover_queue(int domain, unsigned int bus, unsigned int devfn, int severity, struct aer_capability_regs *aer_regs); --=20 2.48.1 From nobody Sun Dec 14 19:15:53 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1D1D2459EA; Tue, 29 Apr 2025 17:21:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745947302; cv=none; b=YpX4eoX4zgYTkGrlj9IRGgoC7d02BWBj4KdpgBbfWfTq1aw2QxTJZOdCvYk3Ynp5sPHawL5ovw4oYbxan5sBAmIDKF+QolxywI8rgDDMFGzlEVaJqIYtr635AImGrPckJOil8aVTLeM31cLhNb/KaAX5dbtHzprLKb7jtkcj6G0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745947302; c=relaxed/simple; bh=LHmTP7DiNiCJt6QTpTz14DavcISMhdx93wqkEkSqPf0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bz4kmhRo03weEUaKJKsYRRpbG20tVsGmEcFciipLicaoACt4ajJ/LvB4q4sFCirdDs6NxOjJLglpW+qsZxWl4WozKGqZ38NU/+AaTdtE+hP2bHBp736COnJ7x8E4z2WIDORNPUm/J8aNdjDAR21KT/V7ZoSv2GXhSoOnnUjUrR8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=bTkJol5B; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="bTkJol5B" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1745947301; x=1777483301; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=LHmTP7DiNiCJt6QTpTz14DavcISMhdx93wqkEkSqPf0=; b=bTkJol5Bb1z/nSX5bjqYwQSYBe9hEb7T0zviYdocX2pHrhShGqEx44xd wwfyB6qQAk4hn5K2sVMOegkvT8iRGOl1SKyLbufL1pAJgw9fprqZLCbch V1pTl5gdpJhTjbZ0oap4nbaQIJa8Obk2iWP1AjCUo2UAX7issQhGuNP4w zTBepBbEQrJgUV29ycBmmT5TJPn65RfIUKTumv21mO+nZfcFWMoWLa1aK yIYBKgI70rr2jCB7Vesp0ZdmPSw2DcJymNSKpNkd3fndoUX/XX91apEe1 IF6yC6v2HDjVIVgv/E02akPB0KEwvz4X8d8gbUap4Pk4Ta40TTUs4QQqJ Q==; X-CSE-ConnectionGUID: gRcCz7T+SUueAVXwWpSTjQ== X-CSE-MsgGUID: rA5fx+79SUqnatL+chzh8Q== X-IronPort-AV: E=McAfee;i="6700,10204,11418"; a="64996968" X-IronPort-AV: E=Sophos;i="6.15,249,1739865600"; d="scan'208";a="64996968" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2025 10:21:41 -0700 X-CSE-ConnectionGUID: 06FSbi8qTc6/uxnr0ds6vg== X-CSE-MsgGUID: clIxOUsESMOKDd1ykWNL5g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,249,1739865600"; d="scan'208";a="139073335" Received: from sschumil-mobl2.ger.corp.intel.com (HELO fdefranc-mobl3.intel.com) ([10.245.246.45]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2025 10:21:34 -0700 From: "Fabio M. De Francesco" To: "Rafael J . Wysocki" , Len Brown , Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , Mahesh J Salgaonkar , Oliver O'Halloran , Bjorn Helgaas , Tony Luck , Borislav Petkov , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org, linux-edac@vger.kernel.org Cc: "Fabio M. De Francesco" Subject: [PATCH 3/4 v2] ACPI: extlog: Trace CPER PCI Express Error Section Date: Tue, 29 Apr 2025 19:21:08 +0200 Message-ID: <20250429172109.3199192-4-fabio.m.de.francesco@linux.intel.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250429172109.3199192-1-fabio.m.de.francesco@linux.intel.com> References: <20250429172109.3199192-1-fabio.m.de.francesco@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" I/O Machine Check Arcitecture events may signal failing PCIe components or links. The AER event contains details on what was happening on the wire when the error was signaled. Trace the CPER PCIe Error section (UEFI v2.10, Appendix N.2.7) reported by the I/O MCA. Cc: Dan Williams Signed-off-by: Fabio M. De Francesco --- drivers/acpi/acpi_extlog.c | 30 ++++++++++++++++++++++++++++++ drivers/pci/pcie/aer.c | 2 +- include/linux/aer.h | 13 +++++++++++-- 3 files changed, 42 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/acpi_extlog.c b/drivers/acpi/acpi_extlog.c index caca6ccd6e99..7d7a813169f1 100644 --- a/drivers/acpi/acpi_extlog.c +++ b/drivers/acpi/acpi_extlog.c @@ -131,6 +131,32 @@ static int print_extlog_rcd(const char *pfx, return 1; } =20 +static void extlog_print_pcie(struct cper_sec_pcie *pcie_err, + int severity) +{ + struct aer_capability_regs *aer; + struct pci_dev *pdev; + unsigned int devfn; + unsigned int bus; + int aer_severity; + int domain; + + if (pcie_err->validation_bits & CPER_PCIE_VALID_DEVICE_ID && + pcie_err->validation_bits & CPER_PCIE_VALID_AER_INFO) { + aer_severity =3D cper_severity_to_aer(severity); + aer =3D (struct aer_capability_regs *)pcie_err->aer_info; + domain =3D pcie_err->device_id.segment; + bus =3D pcie_err->device_id.bus; + devfn =3D PCI_DEVFN(pcie_err->device_id.device, + pcie_err->device_id.function); + pdev =3D pci_get_domain_bus_and_slot(domain, bus, devfn); + if (!pdev) + return; + pci_print_aer(KERN_DEBUG, pdev, aer_severity, aer); + pci_dev_put(pdev); + } +} + static int extlog_print(struct notifier_block *nb, unsigned long val, void *data) { @@ -182,6 +208,10 @@ static int extlog_print(struct notifier_block *nb, uns= igned long val, if (gdata->error_data_length >=3D sizeof(*mem)) trace_extlog_mem_event(mem, err_seq, fru_id, fru_text, (u8)gdata->error_severity); + } else if (guid_equal(sec_type, &CPER_SEC_PCIE)) { + struct cper_sec_pcie *pcie_err =3D acpi_hest_get_payload(gdata); + + extlog_print_pcie(pcie_err, gdata->error_severity); } else { void *err =3D acpi_hest_get_payload(gdata); =20 diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index d0ebf7c15afa..627fcf434698 100644 --- a/drivers/pci/pcie/aer.c +++ b/drivers/pci/pcie/aer.c @@ -801,7 +801,7 @@ void pci_print_aer(char *level, struct pci_dev *dev, in= t aer_severity, trace_aer_event(dev_name(&dev->dev), (status & ~mask), aer_severity, tlp_header_valid, &aer->header_log); } -EXPORT_SYMBOL_NS_GPL(pci_print_aer, "CXL"); +EXPORT_SYMBOL_GPL(pci_print_aer); =20 /** * add_error_device - list device to be handled diff --git a/include/linux/aer.h b/include/linux/aer.h index 45d0fb2e2e75..737db92e6570 100644 --- a/include/linux/aer.h +++ b/include/linux/aer.h @@ -56,17 +56,26 @@ struct aer_capability_regs { #if defined(CONFIG_PCIEAER) int pci_aer_clear_nonfatal_status(struct pci_dev *dev); int pcie_aer_is_native(struct pci_dev *dev); +void pci_print_aer(char *level, struct pci_dev *dev, int aer_severity, + struct aer_capability_regs *aer); #else static inline int pci_aer_clear_nonfatal_status(struct pci_dev *dev) { return -EINVAL; } static inline int pcie_aer_is_native(struct pci_dev *dev) { return 0; } +static inline void pci_print_aer(char *level, struct pci_dev *dev, + int aer_severity, + struct aer_capability_regs *aer) +{ } #endif =20 -void pci_print_aer(char *level, struct pci_dev *dev, int aer_severity, - struct aer_capability_regs *aer); +#if defined(CONFIG_ACPI_APEI_PCIEAER) int cper_severity_to_aer(int cper_severity); +#else +static inline int cper_severity_to_aer(int cper_severity) { return 0; } +#endif + void aer_recover_queue(int domain, unsigned int bus, unsigned int devfn, int severity, struct aer_capability_regs *aer_regs); #endif //_AER_H_ --=20 2.48.1 From nobody Sun Dec 14 19:15:53 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 649D5254868; Tue, 29 Apr 2025 17:21:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745947308; cv=none; b=CGy0bJn1o+Q4qmeC6ZdACf4Fz1z4yQXTO03JffArE/7nnUiSjcoX6EhQsjRCxvpTzoaToIi/blHSs67xu90I91096/dBnfOi2pCs//ZwriQ7GirdOE5rX+2FErwZCEbEiDTZQkBnq3hNG3X6mmrkNkD45rmCJJ2qqJJp3qEcX5I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745947308; c=relaxed/simple; bh=6NBgym4/EikYuDm0nWfg1osxoAlXmaBFRDdG5Co6GDM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=p9oUqUvfYwxhWkARlbp75KMIy+UdA+3US94n3o7HhS0fbLhqG6Vrqb9Sa+5651bKrE6/4zMCwmH0Ff0WcYGZOabE2vYMWVeq823jA3FV7ubwiveF+EVKffzqDZ7vXW4FaAfB5TkfP9QmVScYIF72HtfkjsBblHBFXkECdBX4pOY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=X6DrCkAI; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="X6DrCkAI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1745947307; x=1777483307; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=6NBgym4/EikYuDm0nWfg1osxoAlXmaBFRDdG5Co6GDM=; b=X6DrCkAI6FRs80hJngKR+j/ENZns/hr6/P7KQj0Pf6Onf56gKXC/slqf 9FpGFONuz2Wg2l4ItVOkYBbW1R+bD3h2Dop4aFhoMCDF8mkX+DQr4aCQd TjOk0fCADTRZ9VAKvYO1Ql2mh5esg1mlQcYN/dkhH/EbH/zEdU7V0cJLu LabHCDXtKo4lMJzsmAhJW+IykznxKJEFMtNUrFanJKYlCYHp0vanjbbCs W1Xtk6JaJOaU5+yDmrEBwmyKW8FZ57iOgbGBBvf2MUIBz59H2I4wdKcPs GEHjZRh620Zxo//yPwIUVimRN1v8m1xYRnQEOh/x/dafd7PDJoY7YR8SH w==; X-CSE-ConnectionGUID: w/Nk0KgpQ7+k7mvos6rDUQ== X-CSE-MsgGUID: SEWzg9z6QW6e0C8qye9jcA== X-IronPort-AV: E=McAfee;i="6700,10204,11418"; a="64996984" X-IronPort-AV: E=Sophos;i="6.15,249,1739865600"; d="scan'208";a="64996984" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2025 10:21:46 -0700 X-CSE-ConnectionGUID: RUWqMx43T460pY1p/OsbGQ== X-CSE-MsgGUID: XEHwzn+VQVSbGGyfW1jiqw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,249,1739865600"; d="scan'208";a="139073357" Received: from sschumil-mobl2.ger.corp.intel.com (HELO fdefranc-mobl3.intel.com) ([10.245.246.45]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2025 10:21:41 -0700 From: "Fabio M. De Francesco" To: "Rafael J . Wysocki" , Len Brown , Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , Mahesh J Salgaonkar , Oliver O'Halloran , Bjorn Helgaas , Tony Luck , Borislav Petkov , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org, linux-edac@vger.kernel.org Cc: "Fabio M. De Francesco" Subject: [PATCH 4/4 v2] ACPI: extlog: Trace CPER CXL Protocol Errors Date: Tue, 29 Apr 2025 19:21:09 +0200 Message-ID: <20250429172109.3199192-5-fabio.m.de.francesco@linux.intel.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250429172109.3199192-1-fabio.m.de.francesco@linux.intel.com> References: <20250429172109.3199192-1-fabio.m.de.francesco@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When Firmware First is enabled, BIOS handles errors first and then it makes them available to the kernel via the Common Platform Error Record (CPER) sections (UEFI 2.10 Appendix N). Linux parses the CPER sections via one of two similar paths, either ELOG or GHES. Currently, ELOG and GHES show some inconsistencies in how they report to userspace via trace events. Therfore make the two mentioned paths act similarly by tracing the CPER CXL Protocol Error Section (UEFI v2.10, Appendix N.2.13) signaled by the I/O Machine Check Architecture and reported by BIOS in FW-First. Cc: Dan Williams Signed-off-by: Fabio M. De Francesco --- drivers/acpi/acpi_extlog.c | 60 ++++++++++++++++++++++++++++++++++++++ drivers/cxl/core/ras.c | 6 ++++ include/cxl/event.h | 2 ++ 3 files changed, 68 insertions(+) diff --git a/drivers/acpi/acpi_extlog.c b/drivers/acpi/acpi_extlog.c index 7d7a813169f1..8f2ff3505d47 100644 --- a/drivers/acpi/acpi_extlog.c +++ b/drivers/acpi/acpi_extlog.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -157,6 +158,60 @@ static void extlog_print_pcie(struct cper_sec_pcie *pc= ie_err, } } =20 +static void +extlog_cxl_cper_handle_prot_err(struct cxl_cper_sec_prot_err *prot_err, + int severity) +{ +#ifdef CONFIG_ACPI_APEI_PCIEAER + struct cxl_cper_prot_err_work_data wd; + u8 *dvsec_start, *cap_start; + + if (!(prot_err->valid_bits & PROT_ERR_VALID_AGENT_ADDRESS)) { + pr_err_ratelimited("CXL CPER invalid agent type\n"); + return; + } + + if (!(prot_err->valid_bits & PROT_ERR_VALID_ERROR_LOG)) { + pr_err_ratelimited("CXL CPER invalid protocol error log\n"); + return; + } + + if (prot_err->err_len !=3D sizeof(struct cxl_ras_capability_regs)) { + pr_err_ratelimited("CXL CPER invalid RAS Cap size (%u)\n", + prot_err->err_len); + return; + } + + if (!(prot_err->valid_bits & PROT_ERR_VALID_SERIAL_NUMBER)) + pr_warn(FW_WARN "CXL CPER no device serial number\n"); + + switch (prot_err->agent_type) { + case RCD: + case DEVICE: + case LD: + case FMLD: + case RP: + case DSP: + case USP: + memcpy(&wd.prot_err, prot_err, sizeof(wd.prot_err)); + + dvsec_start =3D (u8 *)(prot_err + 1); + cap_start =3D dvsec_start + prot_err->dvsec_len; + + memcpy(&wd.ras_cap, cap_start, sizeof(wd.ras_cap)); + wd.severity =3D cper_severity_to_aer(severity); + break; + default: + pr_err_ratelimited("CXL CPER invalid agent type: %d\n", + prot_err->agent_type); + return; + } + + cxl_cper_ras_handle_prot_err(&wd); + +#endif +} + static int extlog_print(struct notifier_block *nb, unsigned long val, void *data) { @@ -208,6 +263,10 @@ static int extlog_print(struct notifier_block *nb, uns= igned long val, if (gdata->error_data_length >=3D sizeof(*mem)) trace_extlog_mem_event(mem, err_seq, fru_id, fru_text, (u8)gdata->error_severity); + } else if (guid_equal(sec_type, &CPER_SEC_CXL_PROT_ERR)) { + struct cxl_cper_sec_prot_err *prot_err =3D acpi_hest_get_payload(gdata); + + extlog_cxl_cper_handle_prot_err(prot_err, gdata->error_severity); } else if (guid_equal(sec_type, &CPER_SEC_PCIE)) { struct cper_sec_pcie *pcie_err =3D acpi_hest_get_payload(gdata); =20 @@ -375,3 +434,4 @@ module_exit(extlog_exit); MODULE_AUTHOR("Chen, Gong "); MODULE_DESCRIPTION("Extended MCA Error Log Driver"); MODULE_LICENSE("GPL"); +MODULE_IMPORT_NS("CXL"); diff --git a/drivers/cxl/core/ras.c b/drivers/cxl/core/ras.c index 485a831695c7..56db290c88d3 100644 --- a/drivers/cxl/core/ras.c +++ b/drivers/cxl/core/ras.c @@ -98,6 +98,12 @@ static void cxl_cper_handle_prot_err(struct cxl_cper_pro= t_err_work_data *data) cxl_cper_trace_uncorr_prot_err(pdev, data->ras_cap); } =20 +void cxl_cper_ras_handle_prot_err(struct cxl_cper_prot_err_work_data *wd) +{ + cxl_cper_handle_prot_err(wd); +} +EXPORT_SYMBOL_NS_GPL(cxl_cper_ras_handle_prot_err, "CXL"); + static void cxl_cper_prot_err_work_fn(struct work_struct *work) { struct cxl_cper_prot_err_work_data wd; diff --git a/include/cxl/event.h b/include/cxl/event.h index f9ae1796da85..aef906e26033 100644 --- a/include/cxl/event.h +++ b/include/cxl/event.h @@ -285,4 +285,6 @@ static inline int cxl_cper_prot_err_kfifo_get(struct cx= l_cper_prot_err_work_data } #endif =20 +void cxl_cper_ras_handle_prot_err(struct cxl_cper_prot_err_work_data *wd); + #endif /* _LINUX_CXL_EVENT_H */ --=20 2.48.1