From nobody Mon Feb 9 11:36:20 2026 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81D3D2C17A8 for ; Tue, 29 Apr 2025 13:08:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745932086; cv=none; b=f1uUOTz+J/3mHOSEba2Tk2xUOiEEquCn3skcLTt204838ySuSXny3dBjZVkc23BZcA+rFgjU50uaABC3Afsyj5ZmMaWtzZNkasAo0+wKmMrdQMldqdLXNCEt2vM9CPxbn1GSkSjRr6WNzbmEMP1sc0pmtioEBOHqiGNT650uYb8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745932086; c=relaxed/simple; bh=y4T5PnGAIez+vg5VEqW5Do2Zya034gQDjDWVIv6UQvU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=M98Msh4ws6RF9et1D9qDQdgzy1EqKQyIu7R/kehDI2MLC+xDsnkSxrVemaW6g21WBgnXuxuWTsFGjcJ6wGqaHZKsiHMUsUmXqoERmeQG0/4y7MdPS8SPR7I+IONthrgoOD390Xoto8oa+8s5uDaU9vcWjMIWAnOIRcWb/CkGIqE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=CbDyTsn2; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="CbDyTsn2" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-39ee5a5bb66so3889697f8f.3 for ; Tue, 29 Apr 2025 06:08:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1745932083; x=1746536883; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=71H8UUaO7QsImpqjQAG98uxMQXL09n1x9j2TkZ5PRUE=; b=CbDyTsn2pI7HVkt+hdyGQrio2xwLj+c2c13ICwFIsV4lL4h0UcapVPNj71OAeXhSB+ I4CikAkmP5l/6bFXIy6uLMlH9nBzPwDMLc6uzGN3uVwCpD956Xpp6PH/V+kGg0x63YJe AUQvBSOk5md69UfaUlA6BYX/ty4MyQ4zfDm9mjoNuBXghot4U2FyJ+dJNGEIIoFL0sz5 S1dol0m62h3qG60efkLpEgWhgrFhALDFVbs7id3eF520FO0W6l45tjwRUw6ByALw5QJ+ 7oLv7bQkP48g7YGdtXOCu/KjQv8jkmkVr8Zn5A4yB1e4ZOiBEKsflZUnRVr3rKqhgiPF 93Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745932083; x=1746536883; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=71H8UUaO7QsImpqjQAG98uxMQXL09n1x9j2TkZ5PRUE=; b=cgUQuhHgVJl0rEBkc56fjLeUjtlVOVgjCf8ZpvPEWosL9bECTbHQpeykPm5qzJ/Toh 16EqjR3pxl1OOElv1M4ibjP2xwYGCuAxeLfrsCPM+QfpkWqJQutECFdwN3NUs6mae8+8 4OKCnMSwbxEtDmUA9Wjr4IBhKZdXXDE4D9fn8YyuLpnmR0zmWBW2pArfy/JqARGZzFjA tgISRc09mzWFMWQghpXdXSvPuQdzDf5x7xEL+annTn3BvQShfxoa0BtjD6P0d8aRTVPS 5SZUhG1OJk4Hkrbgny8LBP42PKONVAQeEw5v4oc6Otk5Tob/3MZHJcVKDhJS55P05dWe O06w== X-Forwarded-Encrypted: i=1; AJvYcCU8df2Q5M663i+x2t0546UBKtvODn0yACcLtAsboPrM3f2Qqp9QDAnbC4xHbgA5bTPuu3tkhefkxvUWJro=@vger.kernel.org X-Gm-Message-State: AOJu0YweYXNYT0GMKyQtJzpGtM6kwQC+Nb9vCZexROsdRwdpg9BCrjuk EW9fw0Wc4fHvqPl0dln/8OWXFGjZFQvV0MjpJ0dAMjNSY7cTfI5GI9ib3yJgTTU= X-Gm-Gg: ASbGncv/EP6JAoz/jO6/zz/NjhohMTAqNOJiCmY8rElCbekBhYq0NLhOarzT0+ohfwa mHKnTAC6eNMPgTrpjy++kZnwJ5bpWWM0cmYOR9Dj6pz6YTq2HPLJWIdyrME4YV3r8en9LOW97u6 9jLPd1JLvn1KQp0bsVHqyD5nd0Lxd/hFVhWk2mEexj/NC+vnqERorPyH0KFuUSwdJd1UtWp6JjI /X50cGFNyWdix/5d4p3cvnROMCFb4s8J1ERwFfYYpsChFLLpba4fdX4+PLmI+aebul2K2niRzLF ki5WtfSV118GB0qXZbYlgQjfXJzAWzgJvM0CyR4dSI7qBwhUBzBk/wn/r845L/UWV42bKqBCQGI eI32r8R0qD3+U X-Google-Smtp-Source: AGHT+IHO1ZeiV/iQuKvbx3T1ivuh9m/Sgh9wluBgAayek2avyKi8im+bEMquo5wovrimdlQD3PC0ig== X-Received: by 2002:a05:6000:2211:b0:39e:cbd2:986e with SMTP id ffacd0b85a97d-3a08ad28663mr2229582f8f.5.1745932082646; Tue, 29 Apr 2025 06:08:02 -0700 (PDT) Received: from [192.168.0.2] (host-87-8-31-78.retail.telecomitalia.it. [87.8.31.78]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-440a5310ad2sm155550565e9.21.2025.04.29.06.08.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Apr 2025 06:08:02 -0700 (PDT) From: Angelo Dureghello X-Google-Original-From: Angelo Dureghello Date: Tue, 29 Apr 2025 15:06:45 +0200 Subject: [PATCH 1/5] Documentation: ABI: IIO: add calibphase_delay documentation Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250429-wip-bl-ad7606-calibration-v1-1-eb4d4821b172@baylibre.com> References: <20250429-wip-bl-ad7606-calibration-v1-0-eb4d4821b172@baylibre.com> In-Reply-To: <20250429-wip-bl-ad7606-calibration-v1-0-eb4d4821b172@baylibre.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Hennerich , devicetree@vger.kernel.org, Angelo Dureghello X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1707; i=adureghello@baylibre.com; h=from:subject:message-id; bh=hjukJMP68wQDxrn4mu67NwCMge4a4swyLMg0ZA9HBaE=; b=owGbwMvMwCXGf3bn1e/btlsznlZLYsgQOPf8V6HIoj8yf61M6qJP1LE8+9yZedbpRuEWGYslV Q8eOvzh6ShlYRDjYpAVU2SpS4wwCb0dKqW8gHE2zBxWJpAhDFycAjCRLX2MDJtF9xz1qt7xgf/C Lim9GMvWN0eCndS/Oay9OrU14812rXiG/zX9U6+vXqYgZ5l41OB6lMXHnSorNKb9Xdu0tDjVpcS rhhkA X-Developer-Key: i=adureghello@baylibre.com; a=openpgp; fpr=703CDFAD8B573EB00850E38366D1CB9419AF3953 From: Angelo Dureghello Add new IIO calibphase_delay documentation. The delay suffix is added to specify that the phase, generally in radiants, is for this case (needed from ad7606) in nanoseconds. Signed-off-by: Angelo Dureghello --- Documentation/ABI/testing/sysfs-bus-iio | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/te= sting/sysfs-bus-iio index 33c09c4ac60a4feec82308461643134f5ba84b66..f233190d48a34882b7fed2d9611= 41cc6bec3ddb2 100644 --- a/Documentation/ABI/testing/sysfs-bus-iio +++ b/Documentation/ABI/testing/sysfs-bus-iio @@ -559,6 +559,26 @@ Description: - a small discrete set of values like "0 2 4 6 8" - a range specified as "[min step max]" =20 +What: /sys/bus/iio/devices/iio:deviceX/in_voltageY_calibphase_delay +KernelVersion: 6.16 +Contact: linux-iio@vger.kernel.org +Description: + Hardware applied calbiration phase (assumed to fix errors that are + introduced from external filters). + For the ad7606 ADC series, this value is intended as a time delay, + as an integer plus nanoseconds. + +What: /sys/bus/iio/devices/iio:deviceX/in_voltageY_calibphase_delay_avail= able +KernelVersion: 6.16 +Contact: linux-iio@vger.kernel.org +Description: + Available values of calibphase_delay. Maybe expressed as: + + - a range specified as "[min step max]" + + If shared across all channels, _calibphase_delay_available + is used. + What: /sys/bus/iio/devices/iio:deviceX/in_accel_x_calibscale What: /sys/bus/iio/devices/iio:deviceX/in_accel_y_calibscale What: /sys/bus/iio/devices/iio:deviceX/in_accel_z_calibscale --=20 2.49.0 From nobody Mon Feb 9 11:36:20 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 112E52D3218 for ; Tue, 29 Apr 2025 13:08:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745932088; cv=none; b=F7eqGWC1Vk5ekajCuyk71UWb19iErQVX4/1TOnnMxZvKNqEbMImArVy5QtInRzH1++qgqOibhzdZ528OyXStR8SWM7xVBrd2v4mgNGBAq/ReUimjhJl1zpnQcVmeFMNXA3I4PRIv5ZyE0fIKRJm0G2/hVa27w67YwSTAeMf3hoE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745932088; c=relaxed/simple; bh=KNFLAKlea6yeUy4lbi1j+QrNXSerWfYkhf4kLna3TIs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Mb6ruSCjA8l/A6Oa93abncgvme74U7iFbwygDCIjegmKNqZ5FdHKb+mV4gtgpn7HA41DYJKA+YAz5HkzKeH1tw2qk5tEtJjMzPiSqMToJd1rfTNii/jC2AXrY3w0q0oszEpspGkM8cYJ6P1KDNRgvHy5iwGmBZe6GKTNhaF7Fww= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=PQDp8Xl1; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="PQDp8Xl1" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-43cf257158fso34400735e9.2 for ; Tue, 29 Apr 2025 06:08:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1745932084; x=1746536884; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=FHBtxryzQthLhYJZlS/DuviCEeYbLy5mezGC/ZEnYPQ=; b=PQDp8Xl1Ug1Rc5NqVnQLU4NuBS/xO69Rda2VG9vRMpM1ANx5fHf7S1vkcqSgFeG2cd ICGK5ujGGc5PEfzix0QVjTP9QDsgGgjuucvyEhDIJUZpYrC1DKuN4nLsmTa+kbTxBPF8 qP08yEK34zQuE5pFduyJghZSz3vS5B1n+vxFMNj17+zov0rioYvVFgTXLQObjkUettMU 0KPexMET7fgjG5zQ5rumqrK9HH8Up3UUKGNMhsxJ3Oqlbk15eeFidIS8etKdKFoDukOw qOURUg+NiigA4HbZSMc7grNhvvlBjGpBdk4D7by8GZ8NZl4Q3LIF9RjrbiHM0LBnYafD qtHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745932084; x=1746536884; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FHBtxryzQthLhYJZlS/DuviCEeYbLy5mezGC/ZEnYPQ=; b=BxAWhJpYqUUJPG6ZFUC7WwbOIPu38PxzyYEFc7RySHLzbuIVnO8fWJngGhYRw9S4hs yK3hDSSGGUVwxe2avIbDA7+cyXLP+unHRyDqOwosB+4OCluQH7U3P+mObzgP9Foh4eur tWHgiWbveoGK110HVi7QuTwMOok5KHsL5xRwM+skRaKJOl/jRfJOoCv3a78AKEh8UHRG ypxksKU4kPiz9YQqAPGeBm2mcyORjlPDMx/UfuqQ1MCdkNHJYO/1Ya031cymR8h4Xxcb 5geaY7mu2sGVSoqbA61vOS6+Vm9PwOK34QUSnFM6TW2Tj04w7roJ/he2vh+KUBHM8snU p1HA== X-Forwarded-Encrypted: i=1; AJvYcCXnnxdpwd2H4fxlLLteFR+wPxPu3shtGP0wAM2vjmmM8AmMoA8xmRXVxRmOEVtwsjmE6ibShUGTVwiFCww=@vger.kernel.org X-Gm-Message-State: AOJu0YxRJnhVsyZG9jRyCHWxhUDM2XRKoKgQ3j1nirfWTIbQmfxpz/5p hspX7SFl3nBMuaS7dWuYO1BS+GM6CDIYdrrf+BjlGBsx+c+6WVjHHfq+PufzXZU= X-Gm-Gg: ASbGnctVP0/3HNduz5fg/RYICK2d6TFOfggXTeEZetZznBTuFqWXecd2unlAVfBTHXI ZPCWXMrB2c3UCvjdkp1JLQcOqC9w7D96IiLPXppb0QQID3dIbcYDOnjoQj4ESy2SZSSQF2T6R1v ggyXpHjnWsVomIrNRIK7pyjsN0T7m/mxyOkEEWYMVXIN7Gf2zbjQSL1MGjx2XsqYp+Vb4aPgDNM Fo0k1tZ9DFJuFyDqEgPP4VcDvF1370KGAl7ZswCsklQnBh9AeTCXGO8uh6NfzYiHc8QRyQY67vZ BEOAUITxfKjG2UP9KrDAkhm4ETClEsGbLdJyQ1qAirb1XznGjVLd1wD0v+NSmDRJ2NeHroJUdBB Uq+zZpMbRNCWf X-Google-Smtp-Source: AGHT+IHQ8+f48r3Q37DChmVguLuyyYvsJkQYYpRTlbsCTmcMzwkKag6RYXH+xnfFhLDPYFiSihn10A== X-Received: by 2002:a05:600c:34c8:b0:43d:db5:7b1a with SMTP id 5b1f17b1804b1-440ab7b8cbdmr123641025e9.12.1745932084214; Tue, 29 Apr 2025 06:08:04 -0700 (PDT) Received: from [192.168.0.2] (host-87-8-31-78.retail.telecomitalia.it. [87.8.31.78]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-440a5310ad2sm155550565e9.21.2025.04.29.06.08.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Apr 2025 06:08:03 -0700 (PDT) From: Angelo Dureghello X-Google-Original-From: Angelo Dureghello Date: Tue, 29 Apr 2025 15:06:46 +0200 Subject: [PATCH 2/5] iio: core: add ADC phase calibration definition Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250429-wip-bl-ad7606-calibration-v1-2-eb4d4821b172@baylibre.com> References: <20250429-wip-bl-ad7606-calibration-v1-0-eb4d4821b172@baylibre.com> In-Reply-To: <20250429-wip-bl-ad7606-calibration-v1-0-eb4d4821b172@baylibre.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Hennerich , devicetree@vger.kernel.org, Angelo Dureghello X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1311; i=adureghello@baylibre.com; h=from:subject:message-id; bh=wgg3iYunJuQ48BT265dZ+c9r7K85M1f9m3M1YHmwGb4=; b=owGbwMvMwCXGf3bn1e/btlsznlZLYsgQOPfilr7n/iXPa7O/lzHken894Lc3ouOulEhba2CZ/ arquaW5HaUsDGJcDLJiiix1iREmobdDpZQXMM6GmcPKBDKEgYtTACaS187w34dT8OmsxJlFWWuS 2iZ9Xtw842hgpuHBGgfxnfMDt6kc+8PIcLF4W0m6cO1r0d9/H8q9uWXwTb62T/SWxXG3l5oBk5S TuAA= X-Developer-Key: i=adureghello@baylibre.com; a=openpgp; fpr=703CDFAD8B573EB00850E38366D1CB9419AF3953 From: Angelo Dureghello ADCs as ad7606 implement phase calibration. Add such definition, needed for ad7606. Signed-off-by: Angelo Dureghello --- drivers/iio/industrialio-core.c | 1 + include/linux/iio/types.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-cor= e.c index 178e99b111debc59a247fcc3a6037e429db3bebf..73ef9347d96b39c49e8a8315764= 82071a95b5a41 100644 --- a/drivers/iio/industrialio-core.c +++ b/drivers/iio/industrialio-core.c @@ -188,6 +188,7 @@ static const char * const iio_chan_info_postfix[] =3D { [IIO_CHAN_INFO_CALIBAMBIENT] =3D "calibambient", [IIO_CHAN_INFO_ZEROPOINT] =3D "zeropoint", [IIO_CHAN_INFO_TROUGH] =3D "trough_raw", + [IIO_CHAN_INFO_CALIBPHASE_DELAY] =3D "calibphase_delay", }; /** * iio_device_id() - query the unique ID for the device diff --git a/include/linux/iio/types.h b/include/linux/iio/types.h index d89982c98368cf72c0fc30fa66ab001e48af4e8b..f341233613633830745e1899870= 377439e50d7f6 100644 --- a/include/linux/iio/types.h +++ b/include/linux/iio/types.h @@ -69,6 +69,7 @@ enum iio_chan_info_enum { IIO_CHAN_INFO_CALIBAMBIENT, IIO_CHAN_INFO_ZEROPOINT, IIO_CHAN_INFO_TROUGH, + IIO_CHAN_INFO_CALIBPHASE_DELAY, }; =20 #endif /* _IIO_TYPES_H_ */ --=20 2.49.0 From nobody Mon Feb 9 11:36:20 2026 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADF672D3A68 for ; Tue, 29 Apr 2025 13:08:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745932090; cv=none; b=L+qc7vrQ5VJnBt4W/WVjWZTBghnub6mA1nMScQtA+nAIUsBPsJZ3t1HfICGV4wRJJup7t0FZfoThi0UbuII3rbAC+h/sXMqAqDVVc0hv/mGFqawgukBkdpYVo7JRrO/nRtLHfihq4bE5DYohgkS+CWi4Nl0WiE5IWZQXs6zWoyk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745932090; c=relaxed/simple; bh=dMMXbPk/Hq/FX9WY7l+LEsB/nW8zuvdbt6eejkvbA1o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UFKl8h3lGfKqYAwCZ8TQrSS/soZzW7Q6P1EBTB/gDtm1P6n5kqU9pu1U00n6tmU+b44d95Fzi+ko56oyc3SYqc++XiGN5tSN3DiYgmxEIjaJVRIKXLKFITRNzPe7+yYTtuV5kDTW2wD0/HxMtsgk0jyTw8u2f0pyndTwjCIUewk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=PwqnmTnY; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="PwqnmTnY" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4394a823036so58868555e9.0 for ; Tue, 29 Apr 2025 06:08:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1745932086; x=1746536886; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=k3hbPy+6S/vUkcY3xyn0qHp6go2W/iLOvnFGZ2qM7pk=; b=PwqnmTnYR9/7viz+cZV+BQE31bWSK07kz74Fi0PJ7d3+Bc/B2kjm5Kw+ETA88/b35O tnkAiEoYJXQmNh1DYZaH0mRMtMHYPToU/5TXyR2dMrLaniB08L2Wz1jF8S8onnnjiEiD NOttehZONRg930Tc1HW+XdZ7dkdBuxmXBJyrngdyl2ag32PCeVQwv8ZTgcnFxZsfLnFP q/aYZvmmlwHrrAjAwHVyW1pn4A15A148krY+F5iLxvgVSsnaMDFRrjKhHJZrJOEeiz44 KSqxvYVtOmcaVAY5MT8hgKeaOCb+ssALHjQXHABQRgQRlJles6lm/XKsjK4qAFatdgUa uQOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745932086; x=1746536886; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k3hbPy+6S/vUkcY3xyn0qHp6go2W/iLOvnFGZ2qM7pk=; b=AQ6PDewYM+FAwetfLxpA2C0UCav71Ph/MHuK116xHYQawYB8Jn9kGbKPYOSNIVdW5/ t56s2Dzr0XJXvEKcAQYqkkUE7zV7WfwHHerkWIZH8bxFGfz0y2hEDZtg3/QCBxJRE52B TN4SRgcjhBYe2Q5n9B+SCEVNzuCQucA0QQsaUgWYQo0kGbS2bvVLuzAANYUOIAgsi40a WYqKwakDOpzHCV5QkRnqAMM6Hng0VbWZbU8NgZNIxCJDk75AohAo2PnlcrY5D7qquc5E 5aSvod0sGq4KXnDs2bdAe46Pt5dzxV4OoaP2Tc9hPisg2fVkG4gW48o4wfNArCA9xPvk nfag== X-Forwarded-Encrypted: i=1; AJvYcCXfMTEjPsktoU2dkoTLm/8TKaBek3M2LxQ+EJ8MM7GjGfQCmFCOJddP9nf+zA0rx/wV4f+sEtB6XzO+mwY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2dTWyQEfv70x/bxxql2Td7QpXOlFFwtzsnwG8K/XU2gaSMxrY thQzw32mrGScbZ+B/X+3ogxD+35BFIU4PWgA024S5fY9HO2KKHIItb2iOrULrdE= X-Gm-Gg: ASbGncvDLW+uNu0T+/vTFeWXK2+iKZjXaqLWfYYWOGw7HFIzmI4JtNMCBzY/N0qYcXL oYF+rgVvqfJ7yULLXExJZ5bC/NIikApsv78RXJvjQPyih8Dcz37ipWtMauNSZ6r2CfYUlVSq2KV 85epfPwcK5OwGgLEHadJvZhLw06E0EaKBT88jsk6Ch2NGvT4WuXQR3gVNgHuX/3rsbck+xWeTPI bqyuWxQFy5Wdsw2yUEz2WG1ZL9u6+xEPO6V91ETGFsIw9rCK6RSpl3OJ5UUlwtJy+WM5fERaHOq Rz8Z/y6WyLRRNucs1FW929BivZ65mGQFUeSk9rb37bPEGyiutpHFyGWC8O+BqCcrBdXUx91P2P3 QHw+Z/m0P9QzH X-Google-Smtp-Source: AGHT+IHfszf3HIWyRmq7nLOXxB3rcayqSzw/ilkJ4uh8tcAyzsRYcLkmYtE1YR/xACtyoWIxprWLyA== X-Received: by 2002:a05:600c:a44:b0:43d:1824:aadc with SMTP id 5b1f17b1804b1-441ad4fee66mr21405945e9.29.1745932085692; Tue, 29 Apr 2025 06:08:05 -0700 (PDT) Received: from [192.168.0.2] (host-87-8-31-78.retail.telecomitalia.it. [87.8.31.78]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-440a5310ad2sm155550565e9.21.2025.04.29.06.08.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Apr 2025 06:08:05 -0700 (PDT) From: Angelo Dureghello X-Google-Original-From: Angelo Dureghello Date: Tue, 29 Apr 2025 15:06:47 +0200 Subject: [PATCH 3/5] iio: adc: ad7606: add offset and phase calibration support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250429-wip-bl-ad7606-calibration-v1-3-eb4d4821b172@baylibre.com> References: <20250429-wip-bl-ad7606-calibration-v1-0-eb4d4821b172@baylibre.com> In-Reply-To: <20250429-wip-bl-ad7606-calibration-v1-0-eb4d4821b172@baylibre.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Hennerich , devicetree@vger.kernel.org, Angelo Dureghello X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=9380; i=adureghello@baylibre.com; h=from:subject:message-id; bh=cXG/R3iK8ET2AJqQpTOCo9ElRAQZ22TPBNWduqK/wxU=; b=owGbwMvMwCXGf3bn1e/btlsznlZLYsgQOPeinElJZJ516sxcvpSdNjJ7c40EVa/3HOy8J7Jlr vlzd5OOjlIWBjEuBlkxRZa6xAiT0NuhUsoLGGfDzGFlAhnCwMUpABM5fpyR4ZzM2nUhizrXq6/I b66UYdm+dNZ2vS6vw/6uP0v2rOHJ/8/w32WqVMfs2Mg7+438fOznL/9nqHvpH6fk1Ec7A3auMzg exQMA X-Developer-Key: i=adureghello@baylibre.com; a=openpgp; fpr=703CDFAD8B573EB00850E38366D1CB9419AF3953 From: Angelo Dureghello Add support for offset and phase calibration, only for devices that support software mode, that are: ad7606b ad7606c-16 ad7606c-18 Signed-off-by: Angelo Dureghello --- drivers/iio/adc/ad7606.c | 160 +++++++++++++++++++++++++++++++++++++++++++= ++++ drivers/iio/adc/ad7606.h | 9 +++ 2 files changed, 169 insertions(+) diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c index ad5e6b5e1d5d2edc7f8ac7ed9a8a4e6e43827b85..ec063dd4a67eb94610c41c473e2= d8040c91974cf 100644 --- a/drivers/iio/adc/ad7606.c +++ b/drivers/iio/adc/ad7606.c @@ -95,6 +95,22 @@ static const unsigned int ad7616_oversampling_avail[8] = =3D { 1, 2, 4, 8, 16, 32, 64, 128, }; =20 +static const int ad7606_calib_offset_avail[3] =3D { + -128, 1, 127, +}; + +static const int ad7606c_18bit_calib_offset_avail[3] =3D { + -512, 4, 511, +}; + +static const int ad7606b_calib_phase_avail[][2] =3D { + { 0, 0 }, { 0, 1250 }, { 0, 318750 }, +}; + +static const int ad7606c_calib_phase_avail[][2] =3D { + { 0, 0 }, { 0, 1000 }, { 0, 255000 }, +}; + static int ad7606c_18bit_chan_scale_setup(struct iio_dev *indio_dev, struct iio_chan_spec *chan); static int ad7606c_16bit_chan_scale_setup(struct iio_dev *indio_dev, @@ -164,6 +180,8 @@ const struct ad7606_chip_info ad7606b_info =3D { .scale_setup_cb =3D ad7606_16bit_chan_scale_setup, .sw_setup_cb =3D ad7606b_sw_mode_setup, .offload_storagebits =3D 32, + .calib_offset_avail =3D ad7606_calib_offset_avail, + .calib_phase_avail =3D ad7606b_calib_phase_avail, }; EXPORT_SYMBOL_NS_GPL(ad7606b_info, "IIO_AD7606"); =20 @@ -177,6 +195,8 @@ const struct ad7606_chip_info ad7606c_16_info =3D { .scale_setup_cb =3D ad7606c_16bit_chan_scale_setup, .sw_setup_cb =3D ad7606b_sw_mode_setup, .offload_storagebits =3D 32, + .calib_offset_avail =3D ad7606_calib_offset_avail, + .calib_phase_avail =3D ad7606c_calib_phase_avail, }; EXPORT_SYMBOL_NS_GPL(ad7606c_16_info, "IIO_AD7606"); =20 @@ -226,6 +246,8 @@ const struct ad7606_chip_info ad7606c_18_info =3D { .scale_setup_cb =3D ad7606c_18bit_chan_scale_setup, .sw_setup_cb =3D ad7606b_sw_mode_setup, .offload_storagebits =3D 32, + .calib_offset_avail =3D ad7606c_18bit_calib_offset_avail, + .calib_phase_avail =3D ad7606c_calib_phase_avail, }; EXPORT_SYMBOL_NS_GPL(ad7606c_18_info, "IIO_AD7606"); =20 @@ -683,6 +705,40 @@ static int ad7606_scan_direct(struct iio_dev *indio_de= v, unsigned int ch, return ret; } =20 +static int ad7606_get_calib_offset(struct ad7606_state *st, int ch, int *v= al) +{ + int ret; + + ret =3D st->bops->reg_read(st, AD7606_CALIB_OFFSET(ch)); + if (ret < 0) + return ret; + + *val =3D st->chip_info->calib_offset_avail[0] + + ret * st->chip_info->calib_offset_avail[1]; + + return 0; +} + +static int ad7606_get_calib_phase(struct ad7606_state *st, int ch, int *va= l, + int *val2) +{ + int ret; + + ret =3D st->bops->reg_read(st, AD7606_CALIB_PHASE(ch)); + if (ret < 0) + return ret; + + *val =3D 0; + + /* + * ad7606b: phase delay from 0 to 318.75 =CE=BCs in steps of 1.25 =CE=BCs. + * ad7606c-16/18: phase delay from 0 =C2=B5s to 255 =C2=B5s in steps of 1= =C2=B5s. + */ + *val2 =3D ret * st->chip_info->calib_phase_avail[1][1]; + + return 0; +} + static int ad7606_read_raw(struct iio_dev *indio_dev, struct iio_chan_spec const *chan, int *val, @@ -717,6 +773,22 @@ static int ad7606_read_raw(struct iio_dev *indio_dev, pwm_get_state(st->cnvst_pwm, &cnvst_pwm_state); *val =3D DIV_ROUND_CLOSEST_ULL(NSEC_PER_SEC, cnvst_pwm_state.period); return IIO_VAL_INT; + case IIO_CHAN_INFO_CALIBBIAS: + if (!iio_device_claim_direct(indio_dev)) + return -EBUSY; + ret =3D ad7606_get_calib_offset(st, chan->scan_index, val); + iio_device_release_direct(indio_dev); + if (ret) + return ret; + return IIO_VAL_INT; + case IIO_CHAN_INFO_CALIBPHASE_DELAY: + if (!iio_device_claim_direct(indio_dev)) + return -EBUSY; + ret =3D ad7606_get_calib_phase(st, chan->scan_index, val, val2); + iio_device_release_direct(indio_dev); + if (ret) + return ret; + return IIO_VAL_INT_PLUS_NANO; } return -EINVAL; } @@ -767,6 +839,64 @@ static int ad7606_write_os_hw(struct iio_dev *indio_de= v, int val) return 0; } =20 +static int ad7606_set_calib_offset(struct ad7606_state *st, int ch, int va= l) +{ + int start_val, step_val, stop_val; + + start_val =3D st->chip_info->calib_offset_avail[0]; + step_val =3D st->chip_info->calib_offset_avail[1]; + stop_val =3D st->chip_info->calib_offset_avail[2]; + + if (val < start_val || val > stop_val) + return -EINVAL; + + val +=3D start_val; + val /=3D step_val; + + return st->bops->reg_write(st, AD7606_CALIB_OFFSET(ch), val); +} + +static int ad7606_set_calib_phase(struct ad7606_state *st, int ch, int val, + int val2) +{ + int wreg, start_ns, step_ns, stop_ns; + + if (val !=3D 0) + return -EINVAL; + + start_ns =3D st->chip_info->calib_phase_avail[0][1]; + step_ns =3D st->chip_info->calib_phase_avail[1][1]; + stop_ns =3D st->chip_info->calib_phase_avail[2][1]; + + /* + * ad7606b: phase dielay from 0 to 318.75 =CE=BCs in steps of 1.25 =CE=BC= s. + * ad7606c-16/18: phase delay from 0 =C2=B5s to 255 =C2=B5s in steps of 1= =C2=B5s. + */ + if (val2 < start_ns || val2 > stop_ns) + return -EINVAL; + + wreg =3D val2 / step_ns; + + return st->bops->reg_write(st, AD7606_CALIB_PHASE(ch), wreg); +} + +static int ad7606_write_raw_get_fmt(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, long info) +{ + switch (info) { + case IIO_CHAN_INFO_SCALE: + return IIO_VAL_INT_PLUS_MICRO; + case IIO_CHAN_INFO_SAMP_FREQ: + case IIO_CHAN_INFO_OVERSAMPLING_RATIO: + case IIO_CHAN_INFO_CALIBBIAS: + return IIO_VAL_INT; + case IIO_CHAN_INFO_CALIBPHASE_DELAY: + return IIO_VAL_INT_PLUS_NANO; + default: + return -EINVAL; + } +} + static int ad7606_write_raw(struct iio_dev *indio_dev, struct iio_chan_spec const *chan, int val, @@ -820,6 +950,18 @@ static int ad7606_write_raw(struct iio_dev *indio_dev, if (val < 0 && val2 !=3D 0) return -EINVAL; return ad7606_set_sampling_freq(st, val); + case IIO_CHAN_INFO_CALIBBIAS: + if (!iio_device_claim_direct(indio_dev)) + return -EBUSY; + ret =3D ad7606_set_calib_offset(st, chan->scan_index, val); + iio_device_release_direct(indio_dev); + return ret; + case IIO_CHAN_INFO_CALIBPHASE_DELAY: + if (!iio_device_claim_direct(indio_dev)) + return -EBUSY; + ret =3D ad7606_set_calib_phase(st, chan->scan_index, val, val2); + iio_device_release_direct(indio_dev); + return ret; default: return -EINVAL; } @@ -998,6 +1140,14 @@ static int ad7606_read_avail(struct iio_dev *indio_de= v, *type =3D IIO_VAL_INT_PLUS_MICRO; =20 return IIO_AVAIL_LIST; + case IIO_CHAN_INFO_CALIBBIAS: + *vals =3D st->chip_info->calib_offset_avail; + *type =3D IIO_VAL_INT; + return IIO_AVAIL_RANGE; + case IIO_CHAN_INFO_CALIBPHASE_DELAY: + *vals =3D (const int *)st->chip_info->calib_phase_avail; + *type =3D IIO_VAL_INT_PLUS_NANO; + return IIO_AVAIL_RANGE; } return -EINVAL; } @@ -1060,6 +1210,7 @@ static const struct iio_info ad7606_info_sw_mode =3D { .read_raw =3D &ad7606_read_raw, .write_raw =3D &ad7606_write_raw, .read_avail =3D &ad7606_read_avail, + .write_raw_get_fmt =3D ad7606_write_raw_get_fmt, .debugfs_reg_access =3D &ad7606_reg_access, .validate_trigger =3D &ad7606_validate_trigger, .update_scan_mode =3D &ad7606_update_scan_mode, @@ -1252,6 +1403,15 @@ static int ad7606_probe_channels(struct iio_dev *ind= io_dev) chan->info_mask_separate_available |=3D BIT(IIO_CHAN_INFO_SCALE); =20 + if (st->chip_info->calib_offset_avail) { + chan->info_mask_separate |=3D + BIT(IIO_CHAN_INFO_CALIBBIAS) | + BIT(IIO_CHAN_INFO_CALIBPHASE_DELAY); + chan->info_mask_separate_available |=3D + BIT(IIO_CHAN_INFO_CALIBBIAS) | + BIT(IIO_CHAN_INFO_CALIBPHASE_DELAY); + } + /* * All chips with software mode support oversampling, * so we skip the oversampling_available check. And the diff --git a/drivers/iio/adc/ad7606.h b/drivers/iio/adc/ad7606.h index 89d49551eaf515bab9706c12bff056dfcb707b67..4c39de36154ffb80dfbb01bb4f8= 12826bdc55967 100644 --- a/drivers/iio/adc/ad7606.h +++ b/drivers/iio/adc/ad7606.h @@ -40,6 +40,11 @@ #define AD7606_RANGE_CH_ADDR(ch) (0x03 + ((ch) >> 1)) #define AD7606_OS_MODE 0x08 =20 +#define AD7606_CALIB_GAIN(ch) (0x09 + (ch)) +#define AD7606_CALIB_GAIN_MASK GENMASK(5, 0) +#define AD7606_CALIB_OFFSET(ch) (0x11 + (ch)) +#define AD7606_CALIB_PHASE(ch) (0x19 + (ch)) + struct ad7606_state; =20 typedef int (*ad7606_scale_setup_cb_t)(struct iio_dev *indio_dev, @@ -61,6 +66,8 @@ typedef int (*ad7606_sw_setup_cb_t)(struct iio_dev *indio= _dev); * @init_delay_ms: required delay in milliseconds for initialization * after a restart * @offload_storagebits: storage bits used by the offload hw implementation + * @calib_offset_avail: pointer to offset calibration range/limits array + * @calib_phase_avail: pointer to phase calibration range/limits array */ struct ad7606_chip_info { unsigned int max_samplerate; @@ -74,6 +81,8 @@ struct ad7606_chip_info { bool os_req_reset; unsigned long init_delay_ms; u8 offload_storagebits; + const int *calib_offset_avail; + const int (*calib_phase_avail)[2]; }; =20 /** --=20 2.49.0 From nobody Mon Feb 9 11:36:20 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70D672D3A98 for ; Tue, 29 Apr 2025 13:08:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745932092; cv=none; b=MU8umXH1BD4/QvZN3HM4uMYUmpT+5aEvg9VEQ1uPyivXUor3bqTHKJ6a98UtcstklyX29ltXn8l7pQfrVg097hkL3xzG2oTurNW85aBsD99AS+JnLQPPJbnNvHMa/153NjUd9VDBdspOrcCxjwnO12+Bz+CPQWqudLNMn33yKCA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745932092; c=relaxed/simple; bh=HBmxpZciOAW/VYfHssuC6jJRRkEjnj8J3A1g2SBS07g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=I7ueWU5igfe3EzLv7OPAMRlgfFUtxhEJO+2kJcrsA/yuMZjJwNaD8x3RyRDttoXvyuuctRLLqWAs7/9xbKaZNbsflV3k/SnyYxYFBGwkQqk/bJU8YMBkGkA33QVNlipLj6CXVx5SX3PEwxdrJUifx9Z8VZO0T4hsq1fAGXU+ow0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Obg+DasV; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Obg+DasV" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-43ed8d32a95so53660635e9.3 for ; Tue, 29 Apr 2025 06:08:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1745932087; x=1746536887; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Y8R6FT1oxQXzrDZcdreVJobT+CqIzoRZsPEzY7WO80w=; b=Obg+DasVn7dqcAbo7mWqRV66QzFxEalFH5Ncf6S2M6NG3lqlC+KgTes17Q9L2X648v z7bjLtzl8M5JUyAvRGXROezFXS4ny1K4uSZ6o2ZgKs/QUVh0qnKR13q4Z6qWEBtIqp7X dI9tikUt+psg4vmJ1DmWckq/EKF5EFUfulwkBta6dfp7Y3A9n4bQFB+azjteOSgcltwJ hSSf7zTa9ASsys3+0DIfQo1GzQtkquFwiR1iNPjJ3PWKK6uYTkHMpQgMe/11XMTQxqGf 72JP7A3+R6BR3D33NX4BdEQ6jJ1Us+RM6JYQXOm63MBBrtGAE0sVQU3ab6RikyXOmrM4 MCGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745932087; x=1746536887; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y8R6FT1oxQXzrDZcdreVJobT+CqIzoRZsPEzY7WO80w=; b=AcAwBXut96wv9izzDAjNERtERBPhQ7UnslxxdZhe4Ot2kIYFu3eJFpecsDFY+wtgDC ST16/T+RJm9Zardv0nF6CACuPidH1koLlxHPUeWw1kIkeK2ddQpCp1MJf8KxEMUho1an s97aDEIMZdIfCo0Q/jM0Y8oaC1il8TVlW4r3HahBNUHhu1w2Ul9C9bKwW0MoLUA9SF8j wMwdRM+jYBv7C/LEgsqIwQa0rT6J2CgD5Aoz/3/FjxZu6f9GBjIE8qdZTk536nOjtM0v VgbpDY4bvE+2eqTMxFSTTN2ucD3hUhvNer0V4Qqs+d92JI+rdGgPdBww8oaeeByW0Vhd dYew== X-Forwarded-Encrypted: i=1; AJvYcCW74esf7m3L52TEVfyiqMDs77S5wCR2j570yqAonnGYSDxGokkXbKHByoPR7SZ1+orxMHQPovAB2bv8pj0=@vger.kernel.org X-Gm-Message-State: AOJu0YylA5rrIB9Tf+DwnUHLCEkz2yEoe9jbCbMmkeZB3cW4TzX1bYrQ dg3auk7n9IgSGg3mgiKiFgsMZJZodX2xFMHZTkppnl8d+T9poD4ioqm0I+81iDM= X-Gm-Gg: ASbGnct1LlwhBSuALIBwY5LEh/ySq/mlaWOQS3jQGaTHZon35UVRQjm8KO8sxRfguej uGK1vj6sEUv8uD0mknqryEhz5opq7kHMLP0lpIlXLcaha8fUHhgpAZjm34UagyxZsiHLs8r/dV/ Rr8UPmUiCLfca+bcWYDcppzwGa/HXkSgdcStL6biHQ4jRfCbv6LIqdGYQbnXW9h3ns9/M1bVXqR JIPZu89oc61/TEF/dyGM1GdLaMrnfRoO+eedihGr1+8HtdvjEjvWgD4+PCCfJVRU/uFqBpFvfN6 gPsH2dci4u//aViajJGyBzd0TxAby+DAhh+yUjSTtlUosBAVBNrvbqVaeiey8/FO/X2yncmczSy +2tecZgkOYF2x X-Google-Smtp-Source: AGHT+IEtku98x9HGlishYck3lT1JS2udDr9PjtAJq4TGkcmL0aByUaNhPb4M+Ekj7jdhcNEmDmJnHQ== X-Received: by 2002:a05:600c:1c18:b0:43c:fe90:1282 with SMTP id 5b1f17b1804b1-441ac8ce1abmr29753305e9.7.1745932087329; Tue, 29 Apr 2025 06:08:07 -0700 (PDT) Received: from [192.168.0.2] (host-87-8-31-78.retail.telecomitalia.it. [87.8.31.78]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-440a5310ad2sm155550565e9.21.2025.04.29.06.08.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Apr 2025 06:08:06 -0700 (PDT) From: Angelo Dureghello X-Google-Original-From: Angelo Dureghello Date: Tue, 29 Apr 2025 15:06:48 +0200 Subject: [PATCH 4/5] dt-bindings: iio: adc: adi,ad7606: add gain calibration support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250429-wip-bl-ad7606-calibration-v1-4-eb4d4821b172@baylibre.com> References: <20250429-wip-bl-ad7606-calibration-v1-0-eb4d4821b172@baylibre.com> In-Reply-To: <20250429-wip-bl-ad7606-calibration-v1-0-eb4d4821b172@baylibre.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Hennerich , devicetree@vger.kernel.org, Angelo Dureghello X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1615; i=adureghello@baylibre.com; h=from:subject:message-id; bh=WQzJ5n70BF+PZdPHAwkyXb1KZDyvBmnjpW4OFJADjjo=; b=owGbwMvMwCXGf3bn1e/btlsznlZLYsgQOPdC6XZ99AvRBzWTawPnyAmp9XfMuLXro3mYWOYFx epTxc97O0pZGMS4GGTFFFnqEiNMQm+HSikvYJwNM4eVCWQIAxenAEzEXISR4ZTcf/Zr4tfe3LyV WJBwTV/u0MTt+59NPpUXu3zjK087iUsM/xOrK6MVw+YrPf0ernbn5pld1YbOioeelQiXXOX5Vnx 8Jj8A X-Developer-Key: i=adureghello@baylibre.com; a=openpgp; fpr=703CDFAD8B573EB00850E38366D1CB9419AF3953 From: Angelo Dureghello Add gain calibration support by a per-channel resistor value. Signed-off-by: Angelo Dureghello Acked-by: Conor Dooley --- Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml | 14 +++++++++++= +++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml b/Do= cumentation/devicetree/bindings/iio/adc/adi,ad7606.yaml index 29f12d650442b8ff2eb455306ce59a0e87867ddd..df30545fb52c89a814257443183= 303775a06a7f2 100644 --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml @@ -204,6 +204,15 @@ patternProperties: considered a bipolar differential channel. Otherwise it is bipol= ar single-ended. =20 + adi,rfilter-ohms: + description: + For ADCs that supports gain calibration, this property must be s= et to + the value of the external RFilter resistor. Proper gain error + correction is applied based on this value. + default: 0 + minimum: 0 + maximum: 65536 + required: - reg - bipolar @@ -271,6 +280,10 @@ allOf: then: properties: adi,sw-mode: false + patternProperties: + "^channel@[0-9a-f]+$": + properties: + adi,rfilter-ohms: false else: properties: pwms: @@ -398,6 +411,7 @@ examples: reg =3D <8>; diff-channels =3D <8 8>; bipolar; + adi,rfilter-ohms =3D <2048>; }; =20 }; --=20 2.49.0 From nobody Mon Feb 9 11:36:20 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EC802D8683 for ; Tue, 29 Apr 2025 13:08:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745932095; cv=none; b=buYXu/Otg79uR+DDe+xve7LyfNS3Gzl703HlM1W74YWHW5em0DxbG93Pe/nNDS0E8CKMAsY18fKgGbUL+ZU6emxA7R1OBrrjdrIu03hpLkWLcqLdClKvKj8fax+dF+mYlolnLImJlFFvnCAMf82HvUeVG2lTnIyIcSFEycgsR2U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745932095; c=relaxed/simple; bh=iiNkKp9S/Y/GaVGbTXmn8udDFVG9/+jXerMR9s94M28=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Yp/gMrS81fcnRbsuBCkGHqvPuMiIeKeBB+3fptDBi0MabXYsJfEtymt61KOqmKlXpsAQF4rhW/Z/iK6Q1Ngo6n5wAjAfEL7VLHCcrG3NoCIbRwK9nqfDKkmlHIdrN27VagMpT2/IqQK4Evt4R095C6/5Yhit7cZ1LcILmQXG83k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=3VoP9fuS; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="3VoP9fuS" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-440685d6afcso57009035e9.0 for ; Tue, 29 Apr 2025 06:08:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1745932092; x=1746536892; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/mRBcsoz7zVCX+58NW+x3y1+k7FsR0LZXKG0O71RrzY=; b=3VoP9fuShT899l0srM5pA0TVD4NcfkDH6bfyZzGiLDLEAX5dvvt1h/wlVg20jbHHKn DVJeNiB2WX4xQ6SK6nH4yXOaL1ydxjlAc3QUu+QT+kNIMonOcBGQYvDqEp5KZ+y46l/f W/wKBzzFlG0f02poedz+eWphZx4/9jZctFdIhkZYjjunhtEc9ylfeafN+NonqqjfjZE6 Q/wEa0N2MVw81Cif/8NOzmMlqWyQ/biPCuemG11Gya93wYS8ungZRt1+MpQieW7J1mCu ilqwYsfaffQ2p/RYJJId2O1/jxcHvQmm/OzYB0w6YdX8n2uc3SHkG5gO0KM6IpYCehko 0Uog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745932092; x=1746536892; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/mRBcsoz7zVCX+58NW+x3y1+k7FsR0LZXKG0O71RrzY=; b=OL7bqpx1JGD6KmroLOeoK5zx2geH5qmp7bOvDveCz8B/ImlIdjg2goMqN1XZJR7M4c 6OVqAc90DnF6H8lUpSodgCO3NeZrTS7OvPi/8/hLGHEcfq3q0M+MS6mzTEDDpVkTJNpM D6UTaezgpVN+3mhfVVLJ9aKgpKv+KQ8jOL2rLJX6By3VyucpavBGr46Y91AGmiOBUzJ/ TxeilmupIrzRJP3gQTM8hWcbYjzOjBAAtqzf66tfznbBrveC+E19DzaV0PeqOou9ibXU psfDdr1qf8V3+OC/+Zw8iOX5qOc3gkluMiwuTb1cxvGwm7Mugs5xPent6kr5v0mARBUw taTw== X-Forwarded-Encrypted: i=1; AJvYcCWb2qdTKipzuL2vFhsikIqqOEWM6EWmiiVTxePTHhAm2iIYes9VVtijDtnJGDEN7qDIIe/DoONUS4lYT2E=@vger.kernel.org X-Gm-Message-State: AOJu0Yws8nlSZiFAFG1me9VoIm3Jagsvx2Ps9W1JQ13T1Z+Fi6JnlEiX 5xYWmTQR8nHgisnTW0epvBtrcUI7ZiF8LKtUN9UuTYSVDUz09MBzvjz8hUJK03I= X-Gm-Gg: ASbGnct/5q8zVQRqpJWQ62fhUXQjsIHdkn28VgvvHxnbEJyBirGOgcszazzjYxsGEYO d1rqZ1YB8dfjUEkrFUN7vttwnHdJm33TYt0B85MXRZBVc1777/MIEyaGFVkUAclCqR6kYgeKe56 aVnR2PnGx2sIz+lQWwOTypUS8oBUY6JmmflvMW49UcdFMtUgCoGqpsW95J9yRRr+QMjn0m9q5Dw 5UXjywfK9m7NmSypHfWYVt2O7VdyCDw3K7LdjYfwSLI7TZcJDVQgUn4hDynt9ajucQLuhvMh7bo xyCNx6npUbm8bYTTlxC2wlXCp4k98pDAl3+DyMJtbzbtSaww/uqeV77803hXzqkE79Md8RSNIky gDwHV0YFbbunNvnJVzpguWGE= X-Google-Smtp-Source: AGHT+IEOoLuBrvZmbUCEFOkGWsAm7+TMD7TUmhgzsQn5/1mS3vwzu2XpWTo3TgZr443jUbgiGRgwrA== X-Received: by 2002:a05:600c:4693:b0:43c:f969:13c0 with SMTP id 5b1f17b1804b1-440ab872201mr106757355e9.29.1745932088812; Tue, 29 Apr 2025 06:08:08 -0700 (PDT) Received: from [192.168.0.2] (host-87-8-31-78.retail.telecomitalia.it. [87.8.31.78]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-440a5310ad2sm155550565e9.21.2025.04.29.06.08.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Apr 2025 06:08:08 -0700 (PDT) From: Angelo Dureghello X-Google-Original-From: Angelo Dureghello Date: Tue, 29 Apr 2025 15:06:49 +0200 Subject: [PATCH 5/5] iio: adc: ad7606: add gain calibration support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250429-wip-bl-ad7606-calibration-v1-5-eb4d4821b172@baylibre.com> References: <20250429-wip-bl-ad7606-calibration-v1-0-eb4d4821b172@baylibre.com> In-Reply-To: <20250429-wip-bl-ad7606-calibration-v1-0-eb4d4821b172@baylibre.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Hennerich , devicetree@vger.kernel.org, Angelo Dureghello X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=5506; i=adureghello@baylibre.com; h=from:subject:message-id; bh=Ko8yd7lWpMt5mc22SXoTKQ7xTbqRtaJANaR0a/D+dnY=; b=owGbwMvMwCXGf3bn1e/btlsznlZLYsgQOPfi53zWBe+mrP+1509t2SdZabdefjUPH0/B07P4v dRd63yedpSyMIhxMciKKbLUJUaYhN4OlVJewDgbZg4rE8gQBi5OAZhI+mtGhp0L5puxSWWG+q24 NvvZTAWenueWkpNd7ttOfvw7f4mk1j1GhknR4a/33ZsnnPGF59cWUWMfwYRrb9ekpM+WlHN9oJ7 Lww4A X-Developer-Key: i=adureghello@baylibre.com; a=openpgp; fpr=703CDFAD8B573EB00850E38366D1CB9419AF3953 From: Angelo Dureghello Add gain calibration support, using resistor values set on devicetree, values to be set accordingly with ADC external RFilter, as explained in the ad7606c-16 datasheet, rev0, page 37. Usage example in the fdt yaml documentation. Signed-off-by: Angelo Dureghello --- drivers/iio/adc/ad7606.c | 53 ++++++++++++++++++++++++++++++++++++++++++++= ++++ drivers/iio/adc/ad7606.h | 4 ++++ 2 files changed, 57 insertions(+) diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c index ec063dd4a67eb94610c41c473e2d8040c91974cf..1ebc7080d3d153a2ba02bc5c126= ef9957dc782ab 100644 --- a/drivers/iio/adc/ad7606.c +++ b/drivers/iio/adc/ad7606.c @@ -33,6 +33,10 @@ =20 #include "ad7606.h" =20 +#define AD7606_CALIB_GAIN_MIN 0 +#define AD7606_CALIB_GAIN_STEP 1024 +#define AD7606_CALIB_GAIN_MAX 65536 + /* * Scales are computed as 5000/32768 and 10000/32768 respectively, * so that when applied to the raw values they provide mV values. @@ -125,6 +129,8 @@ static int ad7609_chan_scale_setup(struct iio_dev *indi= o_dev, struct iio_chan_spec *chan); static int ad7616_sw_mode_setup(struct iio_dev *indio_dev); static int ad7606b_sw_mode_setup(struct iio_dev *indio_dev); +static int ad7606_chan_calib_gain_setup(struct iio_dev *indio_dev, + struct iio_chan_spec *chan); =20 const struct ad7606_chip_info ad7605_4_info =3D { .max_samplerate =3D 300 * KILO, @@ -180,6 +186,7 @@ const struct ad7606_chip_info ad7606b_info =3D { .scale_setup_cb =3D ad7606_16bit_chan_scale_setup, .sw_setup_cb =3D ad7606b_sw_mode_setup, .offload_storagebits =3D 32, + .calib_gain_setup_cb =3D ad7606_chan_calib_gain_setup, .calib_offset_avail =3D ad7606_calib_offset_avail, .calib_phase_avail =3D ad7606b_calib_phase_avail, }; @@ -195,6 +202,7 @@ const struct ad7606_chip_info ad7606c_16_info =3D { .scale_setup_cb =3D ad7606c_16bit_chan_scale_setup, .sw_setup_cb =3D ad7606b_sw_mode_setup, .offload_storagebits =3D 32, + .calib_gain_setup_cb =3D ad7606_chan_calib_gain_setup, .calib_offset_avail =3D ad7606_calib_offset_avail, .calib_phase_avail =3D ad7606c_calib_phase_avail, }; @@ -246,6 +254,7 @@ const struct ad7606_chip_info ad7606c_18_info =3D { .scale_setup_cb =3D ad7606c_18bit_chan_scale_setup, .sw_setup_cb =3D ad7606b_sw_mode_setup, .offload_storagebits =3D 32, + .calib_gain_setup_cb =3D ad7606_chan_calib_gain_setup, .calib_offset_avail =3D ad7606c_18bit_calib_offset_avail, .calib_phase_avail =3D ad7606c_calib_phase_avail, }; @@ -357,6 +366,46 @@ static int ad7606_get_chan_config(struct iio_dev *indi= o_dev, int ch, return 0; } =20 +static int ad7606_chan_calib_gain_setup(struct iio_dev *indio_dev, + struct iio_chan_spec *chan) +{ + struct ad7606_state *st =3D iio_priv(indio_dev); + unsigned int num_channels =3D st->chip_info->num_adc_channels; + struct device *dev =3D st->dev; + int ret; + + device_for_each_child_node_scoped(dev, child) { + int reg, r_gain; + + ret =3D fwnode_property_read_u32(child, "reg", ®); + if (ret) + return ret; + + /* channel number (here) is from 1 to num_channels */ + if (reg < 1 || reg > num_channels) { + dev_warn(dev, "invalid ch number (ignoring): %d\n", reg); + continue; + } + + ret =3D fwnode_property_read_u32(child, "adi,rfilter-ohms", + &r_gain); + if (ret) + return ret; + + if (r_gain < AD7606_CALIB_GAIN_MIN || + r_gain > AD7606_CALIB_GAIN_MAX) + return -EINVAL; + + /* Chan reg is 1-based index. */ + ret =3D st->bops->reg_write(st, AD7606_CALIB_GAIN(reg - 1), + r_gain / AD7606_CALIB_GAIN_STEP); + if (ret) + return ret; + } + + return 0; +} + static int ad7606c_18bit_chan_scale_setup(struct iio_dev *indio_dev, struct iio_chan_spec *chan) { @@ -1410,6 +1459,10 @@ static int ad7606_probe_channels(struct iio_dev *ind= io_dev) chan->info_mask_separate_available |=3D BIT(IIO_CHAN_INFO_CALIBBIAS) | BIT(IIO_CHAN_INFO_CALIBPHASE_DELAY); + ret =3D st->chip_info->calib_gain_setup_cb( + indio_dev, chan); + if (ret) + return ret; } =20 /* diff --git a/drivers/iio/adc/ad7606.h b/drivers/iio/adc/ad7606.h index 4c39de36154ffb80dfbb01bb4f812826bdc55967..e9a59d2afafd43e66137599dbd8= 220cd6b641e61 100644 --- a/drivers/iio/adc/ad7606.h +++ b/drivers/iio/adc/ad7606.h @@ -50,6 +50,8 @@ struct ad7606_state; typedef int (*ad7606_scale_setup_cb_t)(struct iio_dev *indio_dev, struct iio_chan_spec *chan); typedef int (*ad7606_sw_setup_cb_t)(struct iio_dev *indio_dev); +typedef int (*ad7606_calib_gain_setup_cb_t)(struct iio_dev *indio_dev, + struct iio_chan_spec *chan); =20 /** * struct ad7606_chip_info - chip specific information @@ -66,6 +68,7 @@ typedef int (*ad7606_sw_setup_cb_t)(struct iio_dev *indio= _dev); * @init_delay_ms: required delay in milliseconds for initialization * after a restart * @offload_storagebits: storage bits used by the offload hw implementation + * @calib_gain_setup_cb: callback to setup of gain calibration for each ch= annel * @calib_offset_avail: pointer to offset calibration range/limits array * @calib_phase_avail: pointer to phase calibration range/limits array */ @@ -81,6 +84,7 @@ struct ad7606_chip_info { bool os_req_reset; unsigned long init_delay_ms; u8 offload_storagebits; + ad7606_calib_gain_setup_cb_t calib_gain_setup_cb; const int *calib_offset_avail; const int (*calib_phase_avail)[2]; }; --=20 2.49.0