From nobody Sun Feb 8 13:39:27 2026 Received: from mail-qv1-f99.google.com (mail-qv1-f99.google.com [209.85.219.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A682277007 for ; Tue, 29 Apr 2025 22:41:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.99 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745966474; cv=none; b=i6NIgmDHIjkgg9i140XDWRkwXGndfrMiCpDymaDKotsY3nDgln0JD1Gv29zlVM3FFhgJWJpSbuVHC/DoSntKfGdWrhdrWD72cb73DLZCbtkSoXnLpCNC60sKJZli2v4ifAMU9KZLmBHH3LFZlkUylhhTEZw0h1PC+FsfoHITeVs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745966474; c=relaxed/simple; bh=EVZKMNvHicJPbJJ+yeVyQMnNcU1DnEd0UGXD+q/p5UI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Z3WIbC4ncnRrzBgI6qbVgRvmE6JNKEC2IVbqeXT8wbgacU4TORDOQ5CiHvZFCPSt/+LpmR6iwOJ8spbXbbkoY84rb/CLh8K6wWzQEYnUdShXCwVnyCIidF8YqzNwk2SOm+pcCe+lTRm2f3lSGQVZwzShuZQpDXasM68Iw9/4rm4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=PzLQSNvr; arc=none smtp.client-ip=209.85.219.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="PzLQSNvr" Received: by mail-qv1-f99.google.com with SMTP id 6a1803df08f44-6ecfc7ed0c1so62614566d6.3 for ; Tue, 29 Apr 2025 15:41:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1745966470; x=1746571270; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XJN4BA+fMMi5a/WeaDyJHm35TLpFGbEwKhPCZI9p8q0=; b=PzLQSNvrms3oriDMKBvT8UI5L6FTGu4HZox3IJEvB0VnL/ZelQ9UgkJToKvSu8EDLM K9x/LxmK7GQCyUa4OU60wejXudtb37yV5YOwRUkggvzrviDF9u06g961+RzoeYzvfY4M uo+dLRT2ZUOGA+lvVCahPXWhb2uOc94s0UL1sFY29JL8VS1pcE0LkkHDXMcf5PdJuxK1 ZYfrQKvQTYhn0wQBCXVbYiBJWomn1nYnvaEksxqESTtH5jgFqQeCKb1nVjwTCNPe5T7U gEQmdruv8y2ZFAi/7D81p6zlp1qwQU7YJQxs2abHZSwV/bdwTDVZTd9HlbVP238cMzEU 4kSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745966470; x=1746571270; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XJN4BA+fMMi5a/WeaDyJHm35TLpFGbEwKhPCZI9p8q0=; b=WtYXysn2WLhFgDX7iu6lEGhl17IiAesHlVEUA7bFzYzElCBuhL3EOOzA94vfy1QhCm T87UsGqeCgY9LJhfnk1Y3rIMItXF42vDfmbutlxfdwsf5DfIB4jYCcrFDdGFfvYFkNZY f8N6H1zv0XcIM0Rp2SxEUgfrLgIaXEzNV3UIv4mYd0FelLB38EiaaqttxkcA0mQpDIcA sW0eC0BK1m1V9geWSkWNT1l9KtvlkK6WYSxfbLsZe6OxRRBPuAIjrSQV3y39IL3EFI/a igT20sNxjQw1E4n/GsfYqkWGqdvuCNEoJMuih5D7LA2SOYSUzLGLi1Gp9hF42ICgte2m ITMw== X-Forwarded-Encrypted: i=1; AJvYcCUlpAfRSm8TBLyPrdL8bnlFMfVb9ydWgfAC4Y/6VGNSA/pT0/kRntgcO/K4aj5v8U5ViCDV/DWmu/mekDU=@vger.kernel.org X-Gm-Message-State: AOJu0YzJZGBdJGk59NahvGqY5ARx9kVUhi872EnQ5qUQo+XNA+9z3EVP elZEGpA4gBRCKFtyvTrF3jzRvNvSNDMlkiNN0rWhmzc1R5muDlMeKznonJjQu80dvB2huRbnbW2 aQ9ECsxldzGgeOtiEnVx3R8LYx0Sm+mAv2b0AHcDJI2YWvFYv X-Gm-Gg: ASbGncur2YyITevI6Ykn22cpzYyoC0LobxJunFylUzrYd2CVys6W8UZTffMiiJEDdKx fMbCY57h1PzdeG9dR2uDuDK8O80vpgKISTdqv6Si4emrEt8ajyY3+59rtVqyIsEQYpYHskWNvLt bTEDivfln072QgkSAARlwpDfRz9jKBuoCwFGl0roenke8xmHi6zGPB5NqMeUYyfuP2IdG+2KW73 WDaq7ekdoBk1YAVLu4/s6Fls+Ix85WMrw/rNgkwJKLwkQbDnz+DdpCmqOtI/8+Vo6Umg/FqTSSL iVqvzTVxJQVD0PwxY8cxwDWvcSxPvCs= X-Google-Smtp-Source: AGHT+IHx5pKBNfEP8GO2QbCkLxtckJoqsomQ7OcV39RPZuItnaXv8KVoALbXjsU0BbOjgfoJVSlyWwOn84oC X-Received: by 2002:a05:6214:488:b0:6f4:cbcf:5cea with SMTP id 6a1803df08f44-6f4fcf6e44fmr18344266d6.44.1745966469654; Tue, 29 Apr 2025 15:41:09 -0700 (PDT) Received: from c7-smtp-2023.dev.purestorage.com ([2620:125:9017:12:36:3:5:0]) by smtp-relay.gmail.com with ESMTPS id 6a1803df08f44-6f4fe6a84fesm96856d6.4.2025.04.29.15.41.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Apr 2025 15:41:09 -0700 (PDT) X-Relaying-Domain: purestorage.com Received: from dev-ushankar.dev.purestorage.com (dev-ushankar.dev.purestorage.com [10.7.70.36]) by c7-smtp-2023.dev.purestorage.com (Postfix) with ESMTP id F374A340304; Tue, 29 Apr 2025 16:41:08 -0600 (MDT) Received: by dev-ushankar.dev.purestorage.com (Postfix, from userid 1557716368) id E3E55E404E6; Tue, 29 Apr 2025 16:41:08 -0600 (MDT) From: Uday Shankar Date: Tue, 29 Apr 2025 16:41:03 -0600 Subject: [PATCH v2 1/3] selftests: ublk: kublk: build with -Werror iff WERROR!=0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250429-ublk_selftests-v2-1-e970b6d9e4f4@purestorage.com> References: <20250429-ublk_selftests-v2-0-e970b6d9e4f4@purestorage.com> In-Reply-To: <20250429-ublk_selftests-v2-0-e970b6d9e4f4@purestorage.com> To: Ming Lei , Shuah Khan Cc: linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Uday Shankar X-Mailer: b4 0.14.2 Compiler warnings can catch bugs at compile time; thus, heeding them is usually a good idea. Turn warnings into errors by default for the kublk build so that anyone making changes is forced to heed them. Compiler warnings can also sometimes produce annoying false positives, so provide a flag WERROR that the developer can use as follows to have the build and selftests run go through even if there are warnings: make WERROR=3D0 TARGETS=3Dublk kselftest Signed-off-by: Uday Shankar Reviewed-by: Ming Lei --- tools/testing/selftests/ublk/Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/testing/selftests/ublk/Makefile b/tools/testing/selftest= s/ublk/Makefile index ec4624a283bce2ebeed80509be6573c1b7a3623d..529ab98a2633a2278bc0df8b265= 00905d60d2bec 100644 --- a/tools/testing/selftests/ublk/Makefile +++ b/tools/testing/selftests/ublk/Makefile @@ -1,6 +1,10 @@ # SPDX-License-Identifier: GPL-2.0 =20 CFLAGS +=3D -O3 -Wl,-no-as-needed -Wall -I $(top_srcdir) +ifneq ($(WERROR),0) + CFLAGS +=3D -Werror +endif + LDLIBS +=3D -lpthread -lm -luring =20 TEST_PROGS :=3D test_generic_01.sh --=20 2.34.1 From nobody Sun Feb 8 13:39:27 2026 Received: from mail-pl1-f228.google.com (mail-pl1-f228.google.com [209.85.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 970592777E4 for ; Tue, 29 Apr 2025 22:41:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.228 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745966473; cv=none; b=PAxJMSwX+uswN6ioQpstp0nB2wzhSEaETsSfLGRX8V1bBqjIAySN3H65+ZjgTGaknfbwKFo5HsStQXSEV+S+2OZLlNzNA6DJU2fcuf3Fek4Zyl8bl9Qk13b2A25b4HzAY/CbuRGJVHY4KkYGcDJ/dZw6USK6j6lRMKOV7zh1mDc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745966473; c=relaxed/simple; bh=yLjCvoCe6VXMT5MsUjHgKpFFAFBbBtQRcr91r8jHk+A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QvrRdKhINQX+6Xwiix7gZ5qKgzs7rYMo3Sch+kJXcVcB+uvupr+vUOhGqtB6yvTZoDwmnheeliSYkTh5yvVwEMyhNo2qherlAqy+KOMlwHG/IoRBgomyoW33w6gATauMTDP0MPSsDSnQMapdeMUcEeUsEYIAtwNBhQ9pwclQn4Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=LwqKwcsW; arc=none smtp.client-ip=209.85.214.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="LwqKwcsW" Received: by mail-pl1-f228.google.com with SMTP id d9443c01a7336-2241053582dso99247165ad.1 for ; Tue, 29 Apr 2025 15:41:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1745966470; x=1746571270; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=FFNtS618ufyKJDtfH/r/PyGi4nE5aM2nCuyHf6tRb3Y=; b=LwqKwcsWiHCt0Ma4fVElW3asrerOszOKpN0s0hzAvtiMJPqCAoFGGvNNRgXDX9Cf7S ZYYWkvnueOR5YH6AXoBwp0ywutmIfIL3iSN8+Teu8N6RDD3EWiY3Ct8gx7dVdnZEMVZp Wf6c1/JNeztMCGffl7q1cMvUUBiLKdMGDg2aJdDNpqlYr/67Xsi0VqjgqIHeWotNTtgp dj5oVroce5AkxbB4/g0K13X/nGEXXOANwqaGmtE2vylF3hHmcWvBK0NlKV+kX61Nq66m b5dMFMF8yeUIP5we4+t9qiZA/D1ApZ/o/DQD564ytiq/CECJq+z9Nx4m7LeFo5bVfUZI EjvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745966470; x=1746571270; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FFNtS618ufyKJDtfH/r/PyGi4nE5aM2nCuyHf6tRb3Y=; b=NUN7L6VNVRcjgo7is/fv+1iqBgpt6xtOua9/saA/lj82pyhe9xRvx0BajLZtKwJo5G wdIB7ctGBEbXyDYox1bkpv5Df6v+l/eNTYkR0qBZ7ZlS2HaXVHiQUj7bPZxwvholwRVc s32FqsWNDoDHbMUJwsNO9+J5KMO3p+QI7mtXpEUOSnJklYef+sC/O+IdQqixiQiow/Rz nfhHGzKikJM8MRyM2PesshDKOf9tcnuse2k+W2cynqCMxqHTdmKVkXfz2vpjEbNpaH3C NvA4Wryfj93T3PrxgOJIN8tqMp4SGHGQoiCB61VcNnnOUwmIofACKJdJUA1S1GcY+Cfq bpHQ== X-Forwarded-Encrypted: i=1; AJvYcCUrlpS1YnIuvhyw/XZ9icdPkLgmrfIbJ1fuNzdBYaTrJL4hAKgEYYWIPoQ/65LI8RpuIwfqv3RQjo2y03w=@vger.kernel.org X-Gm-Message-State: AOJu0Yx05RrkTV0V3W/oKl3tCU068aq5WjhFHW9hkKh0ggthuWOB0GGA QymDqaZt1fQnW8btOLVOQTujoTc0NaxC80Ier0NjeRdzEezu2xEPmK+NIATzyVtMi7hYTVmbU2u uq2Y5xyXK5bW+YX9bxv6aLy+V8K9cU0F6AO1WRUpK8Rs9LZ1/ X-Gm-Gg: ASbGncv5vbG6spn6hhm+1NnmwYuygCsBn+3NL0ub5cV4NjITPLa6lESghnSjp+uyXog SQIPHMDXcyvCE3Ppyw4u+j7a6XW9bKAbQKTpXRr7WuE0yWMrqmrDfLTYDlTcPj6C8gcj1ZvD4BE 1jXikCXRBg2wCC1ME7y/yv0jG64/ZecTD6z14oBPH7qOhTj2TK9+drL8b67mZS7/SmkKtlCAeRm rwtn8pFpqr3PgBS34+R7m/DkzPRCsWfkFLCB6npGkxxenHxf7fnatKTfKOMQRw961cddhdlbsT3 vMr2oLbebU14McMbMyd1SeMMr0tn+u4= X-Google-Smtp-Source: AGHT+IGBZ7D6TEnAUN4d7huIcnUzTzs2CYiqo4tm38ieihvVaysSOYFpmF+9wSpzUkmmpxVwAfixH06NtvV6 X-Received: by 2002:a17:903:3c66:b0:21f:1202:f2f5 with SMTP id d9443c01a7336-22df57638e7mr2895685ad.8.1745966469787; Tue, 29 Apr 2025 15:41:09 -0700 (PDT) Received: from c7-smtp-2023.dev.purestorage.com ([2620:125:9017:12:36:3:5:0]) by smtp-relay.gmail.com with ESMTPS id 41be03b00d2f7-b15f7ec226dsm809653a12.1.2025.04.29.15.41.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Apr 2025 15:41:09 -0700 (PDT) X-Relaying-Domain: purestorage.com Received: from dev-ushankar.dev.purestorage.com (dev-ushankar.dev.purestorage.com [IPv6:2620:125:9007:640:7:70:36:0]) by c7-smtp-2023.dev.purestorage.com (Postfix) with ESMTP id 0055634034F; Tue, 29 Apr 2025 16:41:08 -0600 (MDT) Received: by dev-ushankar.dev.purestorage.com (Postfix, from userid 1557716368) id E501DE40EC9; Tue, 29 Apr 2025 16:41:08 -0600 (MDT) From: Uday Shankar Date: Tue, 29 Apr 2025 16:41:04 -0600 Subject: [PATCH v2 2/3] selftests: ublk: make test_generic_06 silent on success Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250429-ublk_selftests-v2-2-e970b6d9e4f4@purestorage.com> References: <20250429-ublk_selftests-v2-0-e970b6d9e4f4@purestorage.com> In-Reply-To: <20250429-ublk_selftests-v2-0-e970b6d9e4f4@purestorage.com> To: Ming Lei , Shuah Khan Cc: linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Uday Shankar X-Mailer: b4 0.14.2 Convention dictates that tests should not log anything on success. Make test_generic_06 follow this convention. Signed-off-by: Uday Shankar Reviewed-by: Ming Lei --- tools/testing/selftests/ublk/test_generic_06.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/ublk/test_generic_06.sh b/tools/testin= g/selftests/ublk/test_generic_06.sh index b67230c42c847c71b0bbe82ad9de1a737ea3cb75..fd42062b7b76b0b3dfae95a39ab= a6ae28facc185 100755 --- a/tools/testing/selftests/ublk/test_generic_06.sh +++ b/tools/testing/selftests/ublk/test_generic_06.sh @@ -17,7 +17,7 @@ STARTTIME=3D${SECONDS} dd if=3D/dev/urandom of=3D/dev/ublkb${dev_id} oflag=3Ddirect bs=3D4k count= =3D1 status=3Dnone > /dev/null 2>&1 & dd_pid=3D$! =20 -__ublk_kill_daemon ${dev_id} "DEAD" +__ublk_kill_daemon ${dev_id} "DEAD" >/dev/null =20 wait $dd_pid dd_exitcode=3D$? --=20 2.34.1 From nobody Sun Feb 8 13:39:27 2026 Received: from mail-yw1-f225.google.com (mail-yw1-f225.google.com [209.85.128.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C1CB276049 for ; Tue, 29 Apr 2025 22:41:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.225 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745966474; cv=none; b=IqB3LyIPgvTKSnPB0lUY+Tp9gZX+5ybbIZU9n8b/ZMAK+WkD1DAZxri1dZUpsqFYbPWwEzIhM0rAtvRQRWEf/AfTPvJHuHT3X/zO8xUu/ai5QZfuD+TRZIkX1oPewHyfPSQ7GoZEyZcTx9R+KFgsYkpFi9O3ztJ0MowD1IAnxZA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745966474; c=relaxed/simple; bh=ObuAsSl4WZHTMvFnPb6US5OeBMXHiIWBUHv3E4P+6ZE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SYE79cKVs57likwHYPt4YmBRpN+QWmvnNO/AF59wdvrAKPEmrq1UWiIVLoGroGXMKKof49YIBlriHadKZtUmJdOnd7ZJL37HecdzvFhAXV7uJU0FVE+W8EhRYazmjWNkeRyZx4E8pmrks9UmI3xuIkaSvq7o0dVj7Vdlo4b/UYw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=N2NuSz6v; arc=none smtp.client-ip=209.85.128.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="N2NuSz6v" Received: by mail-yw1-f225.google.com with SMTP id 00721157ae682-6ff1e375a47so69538687b3.1 for ; Tue, 29 Apr 2025 15:41:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1745966470; x=1746571270; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=J5UBAAEMQRo7Cyw0R0b1FnwG+WPDkBuKLP1lc95VWmM=; b=N2NuSz6vDYXkot94vhK1O3n+L19mDGc0v7HKxKKWZrTpg/tAdQZnbIzn8RV1CxA24j WuQ6cbeKk0ROUFBxL3JyD6qARmTZ5n5DcZbHIaq3kdiM8JVNfrHafuRjWfgEVMG088Jz NYgaTEOCnMpqyP4znQz3lIuSKWglDu0N9pfM8cGvFLPihrQHknyYDma2INDwUHuMVUiX DYbNQ6TYvVrE9B+diMnlYYawe35uEKsPwryApNOwjoHBJsi+hui8XlbmuZ/t9Gwnne71 xsOV+dirjfnykUK1Mt0Cwhf3skdEleiAEKyd3mQFbns3Sj9FinWd2WRoi2nRHwduZECB 65hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745966470; x=1746571270; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J5UBAAEMQRo7Cyw0R0b1FnwG+WPDkBuKLP1lc95VWmM=; b=U8AWKkZ/Lda78/oFyCtK+3qYOPKZ1RD2ffAwkWmFMgE597jp8JI4ooXEw32oSGcRXN jG0HJ7wB2emjUb4QehriBIcSB/2sAnk6tJ76HJElX1kBRfyvdTfHrI0JjZBeexokSkcl 8Uxaifp68RQBW3ka44Unh+NObjtsO1vGdaH3/Ucu2wxFKWF9yl4Zpb6LEOcEIRQuXTb7 zKsMYWRIIs5sKwERicnwwLU4VIaKyu8CaAxlneRr3Guu7/1Gyn9zKBCw4lg9cv+/A3nv emmBw0TadXLLACmGVji5OhjDzc5dDNV/f2wXeP6375m5l8yVxczSaqORYtDlDvNe0xE8 L0/g== X-Forwarded-Encrypted: i=1; AJvYcCWuyeIUWmuxx/rAfTzqoWH3ch9MpWKNjZMhVRk9mGNhMqPYKFWm2n0k6eWUR9ssHWT44QDmRrIt76yY8ks=@vger.kernel.org X-Gm-Message-State: AOJu0Ywta0O13Cw3RrmeS0OdecYQpDP4NK1dxTBKRvidOik2N7vEr3ga 03dl1S9VvR+CrBz74kVEZuL+HxyVKDgH972ESpmr6zGbBjt1ZPby+GksMcBbCHS9Hr+0sHB2JcR k72+H0daBq3erp+NqWaGKslrYJUMV2g2m X-Gm-Gg: ASbGncucSufokolJe+BsvZ9Zxh1omOE3C+wu2KmGweYR7zRmmyS4Gqh55mBxWnJU1B7 v4dpRXad0YK7dL79lDvmGLaCiW+Tu+u+OImo4T/yv36aqODcGYWIGnnqpifFGGuV7pwIBp03E4x 0NQ5kfQo3e2k3mHOUgCSyYoXnw5o/8upvU2GbfYJym203BphLdsD3IIa9KejjpRE3Ub2G5YR3ji OuOM+QnhBbMJuteK6/M3fIeoNmJF6RJ+9HeC3cYKMsW4LwQ5fxd1D2ClMdsJ7g948r8LjnDEZYs WjugeVqOVqzih5Rj33ZAGNBtpA12ecIvsniL4wUfH5xAcg== X-Google-Smtp-Source: AGHT+IF0yMWC+jrX3o7QqODqh/qL4kwwrsmmLtw5gv1rlU/mBGIQgXBbEeZPRzdVsm0dUCh6BJkRhAghKdmH X-Received: by 2002:a05:690c:6c0c:b0:708:a686:7f04 with SMTP id 00721157ae682-708ad5c00d5mr9177577b3.2.1745966470249; Tue, 29 Apr 2025 15:41:10 -0700 (PDT) Received: from c7-smtp-2023.dev.purestorage.com ([208.88.159.128]) by smtp-relay.gmail.com with ESMTPS id 00721157ae682-708ae0694a5sm75197b3.40.2025.04.29.15.41.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Apr 2025 15:41:10 -0700 (PDT) X-Relaying-Domain: purestorage.com Received: from dev-ushankar.dev.purestorage.com (dev-ushankar.dev.purestorage.com [IPv6:2620:125:9007:640:7:70:36:0]) by c7-smtp-2023.dev.purestorage.com (Postfix) with ESMTP id 030583403AE; Tue, 29 Apr 2025 16:41:09 -0600 (MDT) Received: by dev-ushankar.dev.purestorage.com (Postfix, from userid 1557716368) id EAB40E40ED5; Tue, 29 Apr 2025 16:41:08 -0600 (MDT) From: Uday Shankar Date: Tue, 29 Apr 2025 16:41:05 -0600 Subject: [PATCH v2 3/3] selftests: ublk: kublk: fix include path Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250429-ublk_selftests-v2-3-e970b6d9e4f4@purestorage.com> References: <20250429-ublk_selftests-v2-0-e970b6d9e4f4@purestorage.com> In-Reply-To: <20250429-ublk_selftests-v2-0-e970b6d9e4f4@purestorage.com> To: Ming Lei , Shuah Khan Cc: linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Uday Shankar , Caleb Sander Mateos X-Mailer: b4 0.14.2 Building kublk currently fails (with a "could not find linux/ublk_cmd.h" error message) if kernel headers are not installed in a system-global location (i.e. somewhere in the compiler's default include search path). This failure is unnecessary, as make kselftest installs kernel headers in the build tree - kublk's build just isn't looking for them properly. There is an include path in kublk's CFLAGS which is probably intended to find the kernel headers installed in the build tree; fix it so that it can actually find them. This introduces some macro redefinition issues between glibc-provided headers and kernel headers; fix those by eliminating one include in kublk. Signed-off-by: Uday Shankar Reviewed-by: Caleb Sander Mateos Reviewed-by: Ming Lei --- tools/testing/selftests/ublk/Makefile | 2 +- tools/testing/selftests/ublk/kublk.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/testing/selftests/ublk/Makefile b/tools/testing/selftest= s/ublk/Makefile index 529ab98a2633a2278bc0df8b26500905d60d2bec..aaf011520040d3e96912c876bf7= 4e488e774e473 100644 --- a/tools/testing/selftests/ublk/Makefile +++ b/tools/testing/selftests/ublk/Makefile @@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 =20 -CFLAGS +=3D -O3 -Wl,-no-as-needed -Wall -I $(top_srcdir) +CFLAGS +=3D -O3 -Wl,-no-as-needed -Wall -I $(top_srcdir)/usr/include ifneq ($(WERROR),0) CFLAGS +=3D -Werror endif diff --git a/tools/testing/selftests/ublk/kublk.h b/tools/testing/selftests= /ublk/kublk.h index 918db5cd633fc1041e1e0805142f00e7e4f28bf7..4b943e57a890e5f14fa11dd19d6= 7c4c8684c4417 100644 --- a/tools/testing/selftests/ublk/kublk.h +++ b/tools/testing/selftests/ublk/kublk.h @@ -19,7 +19,6 @@ #include #include #include -#include #include #include #include --=20 2.34.1