From nobody Mon Feb 9 00:54:33 2026 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EA6E20E323 for ; Mon, 28 Apr 2025 21:34:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745876069; cv=none; b=ZNOlJ8jIDjrEmtsKaxeecUBseRy1aa7WPUszWuxAwSrDBzkwoJeeaTzJ/12NHfkbIG59P1J2I+yfzLZ89bgJP/1QWDwDrM0+w+Ctnz3bBpKACXSKIl1hVfDsN90QfM/M0ke11YT1vn1FfStO4sX/mevvA0GFl9cr1b8ajjdx3Ww= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745876069; c=relaxed/simple; bh=V40jgn89oCqUj2APh4IzT55mkyQEVKPYbZ7P8iJSJCA=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=T17gQmrvml4lQgR6HvTS3vI9eG68BHKy31H53C68G5oz0l9XDStpgsq45HZjdkFZHynZ7B5ehkgLN6s0RUOfJYdXh2k+hb5ZbnjGxJ+ZTOpWOI1InFYVLtoPlP/1hZLhynidIqnt4dvB1goeF0NhQGTCCGii8pceeh9qKwQUPG4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=EOmuHLiX; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="EOmuHLiX" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-30364fc706fso4238940a91.3 for ; Mon, 28 Apr 2025 14:34:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1745876067; x=1746480867; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=xuESyA5cUoWs5jJqB9j/HDlv/ORhTzd9f0YGR++Z5O8=; b=EOmuHLiXyOf9f64AcXuZd4ygYCP3tiD8Uoi12dAox0UBmpa7MGe2FqQkoSdcoHXrXf 2r88IEzI3JwWSyJxUUmlMHJ4nI8wrf0CFsCBwj0iOkMHyApAkhOfBvaAjiQW7alJIeBR n7a14YEqHfJqHm1wQ/D0/4xOJd+f+XOEjDzxdno1JhhQ1m7vZnou6m4mmRYtwcs6wc3V hH0jy8goTL99lth+bWyfsibykAylTSS+wdjCnbeETasx6VBsqZV+Yejf6v1TryIdgvcm kolhWy/duS/H+J1dDbWxF8ioRBXK3kAzOR3F/rFczChqKBblJHKG5WM7z+Bt+4WSKqRo Xyow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745876067; x=1746480867; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xuESyA5cUoWs5jJqB9j/HDlv/ORhTzd9f0YGR++Z5O8=; b=pKyOmMNHIcIT93iRBusQUEYbGr0nrpXXcdWRyg+o8ruzgOMKa2OVgBKi7JNeqeKUa3 wfT8W0GGgLkwBLNRAIiXmlu73EK6DDB5AE/KrBzT7bpgSv13iDFGW8Cf7IP3xPgha6D3 FdljbG4FmrNk5gs4qUNQHl2TZPmz2EPGFiedPPPuYw4z6VDvku0Jc1C2YJYKcRXCDYtR 0wvE++BgfNXYRmozaTOolKlAy7aPFGI+SYO1p1Co1ifQk+IAxIFSmhfKDtbBSahDhkhL U6iDtzvwl8AfaS7DJg1MQGtplK8QAgS71rDk9oFEmPmW1/a6XkEVhjrXrqFcVZE51vfI i81A== X-Forwarded-Encrypted: i=1; AJvYcCWP8KidAQZTjc/XsbNcSxke+NXc131Gmp4ikrM1IsSxxSDjPMEthq4kHTNbIR470ycABz1/2+1jeRranLw=@vger.kernel.org X-Gm-Message-State: AOJu0YwN9Yidi1ch6X1cBrPgvZnj0tl8TYPv4QKNRVA/3UeC/Qg9NJ/0 m2U8H5Z1SENRJM59dolcRZcNoO1KfChJup0QforslLwMVKUZzu6QOI98Bp20FyrkGHqN/L6f08y kdWCwEg== X-Google-Smtp-Source: AGHT+IFQ1/vv1A5xPiEdUGqODpwKWqIzLynqCqdF6Urj40CzB1mXE9SuSSMssTrB3nCrHwtPn4/85q2/eLLC X-Received: from pjd16.prod.google.com ([2002:a17:90b:54d0:b0:2ea:5084:5297]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:5403:b0:2f9:c139:b61f with SMTP id 98e67ed59e1d1-30a220c4f94mr1392825a91.14.1745876067485; Mon, 28 Apr 2025 14:34:27 -0700 (PDT) Date: Mon, 28 Apr 2025 14:34:07 -0700 In-Reply-To: <20250428213409.1417584-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250428213409.1417584-1-irogers@google.com> X-Mailer: git-send-email 2.49.0.901.g37484f566f-goog Message-ID: <20250428213409.1417584-9-irogers@google.com> Subject: [PATCH v3 8/9] perf jitdump: Directly mark the jitdump DSO From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Athira Rajeev , Kajol Jain , Li Huafei , "Steinar H. Gunderson" , James Clark , Stephen Brennan , Andi Kleen , Dmitry Vyukov , Zhongqiu Han , Yicong Yang , "=?UTF-8?q?Krzysztof=20=C5=81opatowski?=" , "Dr. David Alan Gilbert" , Zixian Cai , Steve Clevenger , Thomas Falcon , Martin Liska , "=?UTF-8?q?Martin=20Li=C5=A1ka?=" , Song Liu , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The DSO being generated was being accessed through a thread's maps, this is unnecessary as the dso can just be directly found. This avoids problems with passing a NULL evsel which may be inspected to determine properties of a callchain when using the buildid DSO marking code. Signed-off-by: Ian Rogers --- tools/perf/util/jitdump.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/jitdump.c b/tools/perf/util/jitdump.c index 624964f01b5f..b062b1f234b6 100644 --- a/tools/perf/util/jitdump.c +++ b/tools/perf/util/jitdump.c @@ -14,9 +14,9 @@ #include #include =20 -#include "build-id.h" #include "event.h" #include "debug.h" +#include "dso.h" #include "evlist.h" #include "namespaces.h" #include "symbol.h" @@ -531,9 +531,22 @@ static int jit_repipe_code_load(struct jit_buf_desc *j= d, union jr_entry *jr) /* * mark dso as use to generate buildid in the header */ - if (!ret) - build_id__mark_dso_hit(tool, event, &sample, NULL, jd->machine); - + if (!ret) { + struct dso_id dso_id =3D { + { + .maj =3D event->mmap2.maj, + .min =3D event->mmap2.min, + .ino =3D event->mmap2.ino, + .ino_generation =3D event->mmap2.ino_generation, + }, + .mmap2_valid =3D true, + .mmap2_ino_generation_valid =3D true, + }; + struct dso *dso =3D machine__findnew_dso_id(jd->machine, filename, &dso_= id); + + if (dso) + dso__set_hit(dso); + } out: perf_sample__exit(&sample); free(event); --=20 2.49.0.901.g37484f566f-goog