From nobody Fri Dec 19 21:49:59 2025 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.5]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B57F327978F; Mon, 28 Apr 2025 17:11:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745860312; cv=none; b=XYOBWq1kxdB/T7PnGqywc1jhNRwOJvD9y3g4A0G/Qt4Nz+gdgWwW7hY4vSsskgIq1RTD0ewD7t5d6clSCNmS8n/k+2F4B3rze1/7FdHEYB/ut572TFc776bQ/gFXo4+xa13LaL+kcp88r6+va4JUtkU4eAy1ApiexYWicwUd1l4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745860312; c=relaxed/simple; bh=ClPZna7i5122Wr09xYbtgoqUCmhyRpCbBMozYYurono=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=YgTQZc6n5gEnHIzBnhfupnjmou1/FoLcvkLgW+DpMHNWdXoGAnlVNpBDRgs4fb8Cxz8IYUxxMUai/yx49csx8mtu4ikPc5Y4XhqYlRk1QP6cr/D33sjnvLOSlb4d2xPmDBc+aw3dCgVUjmL3hFuTlz/Cdv8s0DDepS9wmt+ppvQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=qRfgSULg; arc=none smtp.client-ip=220.197.31.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="qRfgSULg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=0l6Sm MR9BzhKNVS+UMt/7W8m+RHOtktucSCIuVkRrGU=; b=qRfgSULgVssfAF7kJPd3D ZITouP3cQhBbn3eqhGgRdFYM5bm5XaUukMRrFff/uQG9xJp1Tm+cds+Kfx5WLjKD pPKV/XgRT0fygzyGa8iPpGf5tvYO2K5gOLfMw1Zoh80F7HIpXRQc3856SNPlb14Q 6SOR/Qrzwg/25gNgXBEtDY= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g1-1 (Coremail) with SMTP id _____wCH4haitg9otPCfDA--.1694S5; Tue, 29 Apr 2025 01:11:01 +0800 (CST) From: Hans Zhang <18255117159@163.com> To: lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com, jingoohan1@gmail.com, manivannan.sadhasivam@linaro.org Cc: cassel@kernel.org, robh@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Hans Zhang <18255117159@163.com> Subject: [PATCH 3/3] PCI: cadence: Simplify j721e link status check Date: Tue, 29 Apr 2025 01:10:27 +0800 Message-Id: <20250428171027.13237-4-18255117159@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250428171027.13237-1-18255117159@163.com> References: <20250428171027.13237-1-18255117159@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wCH4haitg9otPCfDA--.1694S5 X-Coremail-Antispam: 1Uf129KBjvdXoWruryDKrWxAr1kJF15ZFW5ZFb_yoWDArc_ZF 1rZF4IyFsrurZIkFy2yF4ayFyrAayIva12ga93tF15AFyxJr4UCF1UZrWDWa4xua15AFn8 Aw1qqFn8AryjyjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUjoUq5UUUUU== X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/1tbiWwM9o2gPr6StOAAAs- Content-Type: text/plain; charset="utf-8" Replace explicit if-else condition with direct return statement in j721e_pcie_link_up(). This reduces code verbosity while maintaining the same logic for detecting PCIe link completion. Signed-off-by: Hans Zhang <18255117159@163.com> --- drivers/pci/controller/cadence/pci-j721e.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/contr= oller/cadence/pci-j721e.c index ef1cfdae33bb..bea1944a7eb2 100644 --- a/drivers/pci/controller/cadence/pci-j721e.c +++ b/drivers/pci/controller/cadence/pci-j721e.c @@ -153,11 +153,7 @@ static bool j721e_pcie_link_up(struct cdns_pcie *cdns_= pcie) u32 reg; =20 reg =3D j721e_pcie_user_readl(pcie, J721E_PCIE_USER_LINKSTATUS); - reg &=3D LINK_STATUS; - if (reg =3D=3D LINK_UP_DL_COMPLETED) - return true; - - return false; + return (reg & LINK_STATUS) =3D=3D LINK_UP_DL_COMPLETED; } =20 static const struct cdns_pcie_ops j721e_pcie_ops =3D { --=20 2.25.1