From nobody Fri Dec 19 17:36:03 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E043F26B2D6; Mon, 28 Apr 2025 14:02:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745848922; cv=none; b=Zy0WDxYahfXUwNULOtnbp/DoAPhDYafMJnzWa/TrUnkaMBq3PQF/KkKfrwZ17PPFBOemH22Gycn7y55+X/f0LFu0/e1DGQAYTEkgRQWnfQDf5xkqf9XxNmBwaCGRvLxHJ/vz6FMpw9NbpWM1Qrg5+nqdrUK32NCxMjlGKJhuiW4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745848922; c=relaxed/simple; bh=RMj0v7yzxGxIBf2g3qGoGs/WIjraPNY4gUN8Pz9vsVA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DFFcnTX7lHU17YZ9vkcnLKLm6n6thv58E+cNtTu93RXx+5GbOgsCnv2lEdEqi2fCY/4TB/SlrirhDvicEyWGvqBScQ79TEm0/S10KqLJs8QhaQXgTbWYNedGr0z4Z1kULAe/qwU/rKmPkNrhxa6qDzQcXb7W4JCfv9fuTu5LNlY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kKb1YK+z; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kKb1YK+z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 953B4C4CEEA; Mon, 28 Apr 2025 14:01:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745848921; bh=RMj0v7yzxGxIBf2g3qGoGs/WIjraPNY4gUN8Pz9vsVA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kKb1YK+zGe3UVTuzXgx/Y1C8eOIi8UVajcPkDn2bY36hCZliMXhZngY1WL8J68CdG dLB7n48KVFoWNBEUx6S65ssy+VPu5tYMp4YW6sZgh8oc/PHRtX7pIzOMhbxv3Xs0ov B/w3W0+TRRPGZP1rBSXXWfWTR8PP6QxD3yAyklJy9r1QmxTJMI5hGJTJOUDsuu/JAg Ulml5aQFOeH2rh5iRxiygBBstaVm0WGMjHr6V0UInTUu6rLN/2gKxFiv3qX8w5qyyw s7CiE4+F5OVPp+wstQEDdb0GNj622hy7sSotyz//W7xwWxD5DTECDJLe7np7SQnUCu tP/7RThTYMyhw== From: Danilo Krummrich To: gregkh@linuxfoundation.org, rafael@kernel.org, bhelgaas@google.com, kwilczynski@kernel.org, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, bskeggs@nvidia.com, acurrid@nvidia.com, joelagnelf@nvidia.com, ttabi@nvidia.com, acourbot@nvidia.com, ojeda@kernel.org, alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu Cc: linux-pci@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Danilo Krummrich Subject: [PATCH v2 3/3] samples: rust: pci: take advantage of Devres::access_with() Date: Mon, 28 Apr 2025 16:00:29 +0200 Message-ID: <20250428140137.468709-4-dakr@kernel.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250428140137.468709-1-dakr@kernel.org> References: <20250428140137.468709-1-dakr@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" For the I/O operations executed from the probe() method, take advantage of Devres::access_with(), avoiding the atomic check and RCU read lock required otherwise entirely. Signed-off-by: Danilo Krummrich --- samples/rust/rust_driver_pci.rs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/samples/rust/rust_driver_pci.rs b/samples/rust/rust_driver_pci= .rs index 9ce3a7323a16..15147e4401b2 100644 --- a/samples/rust/rust_driver_pci.rs +++ b/samples/rust/rust_driver_pci.rs @@ -83,12 +83,12 @@ fn probe(pdev: &pci::Device, info: &Self::IdInfo)= -> Result GFP_KERNEL, )?; =20 - let res =3D drvdata - .bar - .try_access_with(|b| Self::testdev(info, b)) - .ok_or(ENXIO)??; - - dev_info!(pdev.as_ref(), "pci-testdev data-match count: {}\n", res= ); + let bar =3D drvdata.bar.access(pdev.as_ref())?; + dev_info!( + pdev.as_ref(), + "pci-testdev data-match count: {}\n", + Self::testdev(info, bar)? + ); =20 Ok(drvdata.into()) } --=20 2.49.0