From nobody Mon Feb 9 00:38:55 2026 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.5]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 44CE3269D13; Mon, 28 Apr 2025 12:42:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745844182; cv=none; b=Yuhg1j9UjAko2Wp6h/d515VUMsgoiAqU8AH0tYx5C5XGDhWj3aZyQYDLuP3h8fZB6qRuIpZOyMFiQ85/B79P4FbowpsHUFI9K8LEY7wtBYJdEUSUNrKTJgokZ0IJBlIkbAcfttzM9tajmnpME8ul4LI+YOnBlROsvgUcu9g5Gp8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745844182; c=relaxed/simple; bh=yDz9n3TWyahGCVi9xPiIqDZuE2MgYN7oXN7oGplbqgU=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=A/YYDY5Cb0Upl0mSNzNbsQ2+SpX8VeDUqjHeJDu8ktILbOwERqUrttb7vBLV7HtN/kB8Bc+Wzjrqc/W3QHYPczj6+dOlIXrSX9LcB7Oz0z34IbHyZNozETB1gVHmEi7Onn9vWXRdgJCYxBpMCderm6Gqvwfe1wv5x5sllgyoWrE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=jDzVAhjF; arc=none smtp.client-ip=117.135.210.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="jDzVAhjF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=GoBfJ MIbIlI6zPaXaf2aHXumRMjBzcYSuUOqst3TWOg=; b=jDzVAhjF51fqsqiXmrycZ hvIRsk4TZcLWzi1JRxs7dm5odb8tcZp29PgxXZhPMjaXqcZab8RHNJh/3VOcHa8X OwVr4wVFeRuTY2SOw3aSfC4lOirDDH6zjI6FI08Bn5AlvcOXO8SLPULP0ixVwiIX dUPmjNLdy38Y/qDB4yzB3w= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g0-3 (Coremail) with SMTP id _____wDXClu3dw9oiuSODA--.26989S2; Mon, 28 Apr 2025 20:42:32 +0800 (CST) From: Hans Zhang <18255117159@163.com> To: lpieralisi@kernel.org, bhelgaas@google.com, jingoohan1@gmail.com, manivannan.sadhasivam@linaro.org, kw@linux.com Cc: robh@kernel.org, thomas.richard@bootlin.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Hans Zhang <18255117159@163.com>, Niklas Cassel Subject: [PATCH v2] PCI: dwc: ep: Use FIELD_GET() Date: Mon, 28 Apr 2025 20:42:30 +0800 Message-Id: <20250428124230.112648-1-18255117159@163.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wDXClu3dw9oiuSODA--.26989S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7Ar48Jryxur4DuF47GFyDWrg_yoW8uF18p3 W8Can0kF1UJF45X3ykua93ZFn8GanxG3y8Aa93GrsIvF9Fvry0q3yqyF95K34xJF40vF45 C3W7tw13WFsxA3JanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0pimLvtUUUUU= X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/1tbiOhg9o2gO9M4mjgABsJ Content-Type: text/plain; charset="utf-8" Use FIELD_GET() to remove dependences on the field position, i.e., the shift value. No functional change intended. Signed-off-by: Hans Zhang <18255117159@163.com> Reviewed-by: Niklas Cassel --- Changes for v2: - The patch commit message were modified. --- drivers/pci/controller/dwc/pcie-designware-ep.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/= controller/dwc/pcie-designware-ep.c index 1a0bf9341542..f3daf46b5e63 100644 --- a/drivers/pci/controller/dwc/pcie-designware-ep.c +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c @@ -256,11 +256,11 @@ static unsigned int dw_pcie_ep_get_rebar_offset(struc= t dw_pcie *pci, return offset; =20 reg =3D dw_pcie_readl_dbi(pci, offset + PCI_REBAR_CTRL); - nbars =3D (reg & PCI_REBAR_CTRL_NBAR_MASK) >> PCI_REBAR_CTRL_NBAR_SHIFT; + nbars =3D FIELD_GET(PCI_REBAR_CTRL_NBAR_MASK, reg); =20 for (i =3D 0; i < nbars; i++, offset +=3D PCI_REBAR_CTRL) { reg =3D dw_pcie_readl_dbi(pci, offset + PCI_REBAR_CTRL); - bar_index =3D reg & PCI_REBAR_CTRL_BAR_IDX; + bar_index =3D FIELD_GET(PCI_REBAR_CTRL_BAR_IDX, reg); if (bar_index =3D=3D bar) return offset; } @@ -875,8 +875,7 @@ static void dw_pcie_ep_init_non_sticky_registers(struct= dw_pcie *pci) =20 if (offset) { reg =3D dw_pcie_readl_dbi(pci, offset + PCI_REBAR_CTRL); - nbars =3D (reg & PCI_REBAR_CTRL_NBAR_MASK) >> - PCI_REBAR_CTRL_NBAR_SHIFT; + nbars =3D FIELD_GET(PCI_REBAR_CTRL_NBAR_MASK, reg); =20 /* * PCIe r6.0, sec 7.8.6.2 require us to support at least one @@ -897,7 +896,7 @@ static void dw_pcie_ep_init_non_sticky_registers(struct= dw_pcie *pci) * is why RESBAR_CAP_REG is written here. */ val =3D dw_pcie_readl_dbi(pci, offset + PCI_REBAR_CTRL); - bar =3D val & PCI_REBAR_CTRL_BAR_IDX; + bar =3D FIELD_GET(PCI_REBAR_CTRL_BAR_IDX, val); if (ep->epf_bar[bar]) pci_epc_bar_size_to_rebar_cap(ep->epf_bar[bar]->size, &val); else base-commit: b4432656b36e5cc1d50a1f2dc15357543add530e --=20 2.25.1