From nobody Thu Dec 18 23:03:36 2025 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B6B01A072A; Mon, 28 Apr 2025 06:54:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745823282; cv=none; b=FS8KoSdeKP+elPEIccmJohcbWvB000dq4nas/MltnEhnN2BxLVfCfl9GwHkXtptTDaXDkwRgcmzanspmfUvEFxVLHcFYQe611jPgq7GNLkJVYGdHdlwRv/nhOrSkcW9BuIE9lldD3P9MQbkOeX761XY0tUGhYIe96W5jWyP0qBA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745823282; c=relaxed/simple; bh=DHhoS4rQcVy/Z7btxiMLFULAi3/lghSJihGrVJBvccY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hntTW1PWvyxf80203L2QGwI4OURjtEMHFnjkqusRpkf34ymrNiJeueXcpaMxLzxlx8YC7z/eA2bKp57BV2dVFFWGLZHXzXbGJKpMfWQweNT7t08UfwQFVzy/5iLpIC3ggwe+4RWkUZv6vxxZ2DDmrzlNpwabY6NjOCZDiCTFa/M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VvXS+pjT; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VvXS+pjT" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-30eef9ce7feso46223201fa.0; Sun, 27 Apr 2025 23:54:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745823278; x=1746428078; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=FIgv3LP87OoHzk5Dyiq6/wSMsFHxvx99TVeE0pWiL0k=; b=VvXS+pjT8UIrGUk6J58Ji87ZXwbwPMRvU9x+JPYRM7k61DEDMOz/cLxtap+8tfH53q TBZvXN3tohGMbsCESxPTO1AAMNTi5dlBoPN8IHiqzZr+VZd+PTTzedcCXqbi+G6kYL73 hlZBd3sV0ytxHi5Z24SDFQSj5UPBoFL+7OtZoN6Fn7pj9o11rapNqPcIoN1cA/WzOV4q lRtlecUus0UpwpfSunNIEYMKBdhWVww/mdMDvHAY0+hGNvecyRRwxgr5O5LLYCxzT88o h/71LCRlbmkaBgWcDrqll97F6YvXn8cSWnGLIl8YJqyuTGRO1lYrHzhKO1zJg+82nn5H QToA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745823278; x=1746428078; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FIgv3LP87OoHzk5Dyiq6/wSMsFHxvx99TVeE0pWiL0k=; b=UXLGBE4t1rONClhbGRCGWEFyaqFWo7B2CZWNMV/drGUr0WQAuB3W5QOZz2KjSYGP4G mKwmoxvjJ7PmQy8OS/za5Ffpvjs+6n5A/0VtpUe5A09cpJnNUHriHglTml8bqQDIYdoQ 1c4YcNYtHkHmch73TZFfC8LyrZasl69o9l3cnUA63krZ6qY9TkyFxw68KH6Jf/jjF3Et N71ZAxBR7G4x8u7WETwJgUueRqO0Be9E9B06HHB66igYX50koS20cpLaIH8ZyE+CzurP MT6KCJmzP86kEStfuzdBxAPwVoGSXs0gXvSRKN7jkJGfAwASWOuei+Lmnn8ofJDoRawF Fqgg== X-Forwarded-Encrypted: i=1; AJvYcCUkOMqDyqFnyXrJQ89jgPO7Gj4Yvnx6tO4Bnyjfl4HOn+DKNPa9pAR38HDLWc9cxjEyBSdzdaaXEI3q@vger.kernel.org, AJvYcCUqWfUv1fgcMOHk8B1+rdiA0U0nbXjJEAPD90S/7muPiQmAPH5W5wuRWZS51ff1eLHrGZdiE3sP7F+esjBH@vger.kernel.org, AJvYcCX77ONdNn6Iz8kkPBnJygFVTSpA/2AYv3gk/bTNc5ZTTJfSmVVK0c7iBgLAJWRyR9J15GjQDrHG58J8@vger.kernel.org X-Gm-Message-State: AOJu0YwTKj2Pc10/0bDZ9RDahktBsEnzD8VIlv5W30u5xV+hcG2tR0HS G0reD1fy2YdkwO+jf3vb8l4CN1qWAa2T/tUDWXYRbZx7QojuJlQo X-Gm-Gg: ASbGncv+zHo6CWbbYroUaxerQIBSi/vrE1/T/s0UL3w17eELWmNqv0JXWgI/0QLS7Fm ELGc7CJPyf0DpUsUWqoPwn7bKzItwqCkxAf6lCSngKuJJYioN7IJZab4AAxZW/ix7S6VdDnWDfg r5Qh8BBz5mw2tliW3vES2KzJ9dW+7FNmRimv9M0HeO8FKVbJswrftuPbyYhVIRiZ4bPWxx7NyHs gtxYHwWtY+8pxZpDDnPx4DuSnIRcZ7Bw5PrX1RByOeLkwttX/wvxlFf5+KSU0kYxqMkGUJu1Daq 92AfoRYQIFdrkEvhKeaL0mGVu7PGC/Q1EW6knfCxl2xjqe4RR2w8X05KXoskWWSQWv75VJTv2wg dzfs2T4Fu X-Google-Smtp-Source: AGHT+IEfMfPPhSPz9W6Oc4iaQTp8MCWjKujv1n5NrZUuHBGTjMwJZmgyo1SV2U05xahQdtwOpdGN3g== X-Received: by 2002:a05:651c:2222:b0:30d:626e:d004 with SMTP id 38308e7fff4ca-319dc41c1a8mr20802381fa.20.1745823277928; Sun, 27 Apr 2025 23:54:37 -0700 (PDT) Received: from [192.168.1.11] (83-233-6-197.cust.bredband2.com. [83.233.6.197]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-317cf659c4fsm20017871fa.21.2025.04.27.23.54.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Apr 2025 23:54:37 -0700 (PDT) From: Marcus Folkesson Date: Mon, 28 Apr 2025 08:54:11 +0200 Subject: [PATCH v2 1/3] iio: adc: mcp3911: fix device dependent mappings for conversion result registers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250428-mcp3911-fixes-v2-1-406e39330c3d@gmail.com> References: <20250428-mcp3911-fixes-v2-0-406e39330c3d@gmail.com> In-Reply-To: <20250428-mcp3911-fixes-v2-0-406e39330c3d@gmail.com> To: Kent Gustavsson , Jonathan Cameron , Lars-Peter Clausen , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Kent Gustavsson , devicetree@vger.kernel.org, Marcus Folkesson , Lukas Rauber X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=5432; i=marcus.folkesson@gmail.com; h=from:subject:message-id; bh=DHhoS4rQcVy/Z7btxiMLFULAi3/lghSJihGrVJBvccY=; b=kA0DAAgBiIBOb1ldUjIByyZiAGgPJhygaIBqyVMFzlR1EMB2ZGh0EA1YDhnrBvEvC3yrCaDF/ okCMwQAAQgAHRYhBAVRoui2bLVNZMEsZYiATm9ZXVIyBQJoDyYcAAoJEIiATm9ZXVIyVREQALvx /GhgUbD6S7J6aD4ENqcH49E6kB7JPIuEL3q1RfHX/esNtJdvH2uFwQo0S4eKVP7DorP7CFgsfoC FyJcq2lCZlBFjvbjb3h/XhIbdcsAsZDhHUk4l84tLZQedltzHS2ESFZz3vBVabOxTCa4cx0HX09 cwzqocgOKYbxg/IFt8GWHUKjaajp8cMq7BB0oyGpKIRhaXmYV7tYPvQSEs57N4+IvypIjsLZoKF 3Mp6ut4HK5ab43iFf4TzenTt7ECoH5Ehw8l1ThUwUeK8sAhruny4MKruxgP32NMS3jZArzqLy1D bJvO9t0FrKDW3xEhqXBEyw8+c4QN6HQKGJjNPILXIgIbp9n/ZYuLOksQI3+2zo4OhU5Y9gnbniJ xLkmKND9HrPtVNcnD21BEhF8EaCr3bB4U7IBQolfnuRk5NoHtuOSxncLmBWygiauJcDpFMdVuIG 75cGt0t52nyXjSvdC5K9Y52N0+SMqbDCCza1+Vu2yrfjtefOZI90ewlqGCZep2zaCOW1kZYjSGP tAQDOaRfv8jj4MjF38yBlbByhHcyCVwC/IWSQJphBYofyzOLyLyXoEk3AR2Wwv1z7lwwOy+Hu9m K+dHP6KvpXrgC4oTlhoObglm3O6zGwvifG4+0pH4jeE+bvQhfw1T+qceI60JRrYi2ohNCMhnM7E sxGE8 X-Developer-Key: i=marcus.folkesson@gmail.com; a=openpgp; fpr=AB91D46C7E0F6E6FB2AB640EC0FE25D598F6C127 The conversion result registers differs between devices. Make sure the mapping is correct by using a device dependent .get_raw() callback function. Fixes: 732ad34260d3 ("iio: adc: mcp3911: add support for the whole MCP39xx = family") Co-developed-by: Lukas Rauber Signed-off-by: Lukas Rauber Signed-off-by: Marcus Folkesson Reviewed-by: Andy Shevchenko --- drivers/iio/adc/mcp3911.c | 39 ++++++++++++++++++++++++++++++++++----- 1 file changed, 34 insertions(+), 5 deletions(-) diff --git a/drivers/iio/adc/mcp3911.c b/drivers/iio/adc/mcp3911.c index 6748b44d568db68120172a950bbfffb6adc7cfa3..60a19c35807ab783505e817898a= 2405bd8beae34 100644 --- a/drivers/iio/adc/mcp3911.c +++ b/drivers/iio/adc/mcp3911.c @@ -6,7 +6,7 @@ * Copyright (C) 2018 Kent Gustavsson */ #include -#include +#include #include #include #include @@ -79,6 +79,8 @@ #define MCP3910_CONFIG1_CLKEXT BIT(6) #define MCP3910_CONFIG1_VREFEXT BIT(7) =20 +#define MCP3910_CHANNEL(ch) (MCP3911_REG_CHANNEL0 + (ch)) + #define MCP3910_REG_OFFCAL_CH0 0x0f #define MCP3910_OFFCAL(ch) (MCP3910_REG_OFFCAL_CH0 + (ch) * 6) =20 @@ -110,6 +112,7 @@ struct mcp3911_chip_info { int (*get_offset)(struct mcp3911 *adc, int channel, int *val); int (*set_offset)(struct mcp3911 *adc, int channel, int val); int (*set_scale)(struct mcp3911 *adc, int channel, u32 val); + int (*get_raw)(struct mcp3911 *adc, int channel, int *val); }; =20 struct mcp3911 { @@ -170,6 +173,18 @@ static int mcp3911_update(struct mcp3911 *adc, u8 reg,= u32 mask, u32 val, u8 len return mcp3911_write(adc, reg, val, len); } =20 +static int mcp3911_read_s24(struct mcp3911 *const adc, u8 const reg, s32 *= const val) +{ + u32 uval; + int const ret =3D mcp3911_read(adc, reg, &uval, 3); + + if (ret) + return ret; + + *val =3D sign_extend32(uval, 23); + return ret; +} + static int mcp3910_enable_offset(struct mcp3911 *adc, bool enable) { unsigned int mask =3D MCP3910_CONFIG0_EN_OFFCAL; @@ -194,6 +209,11 @@ static int mcp3910_set_offset(struct mcp3911 *adc, int= channel, int val) return adc->chip->enable_offset(adc, 1); } =20 +static int mcp3910_get_raw(struct mcp3911 *adc, int channel, s32 *val) +{ + return mcp3911_read_s24(adc, MCP3910_CHANNEL(channel), val); +} + static int mcp3911_enable_offset(struct mcp3911 *adc, bool enable) { unsigned int mask =3D MCP3911_STATUSCOM_EN_OFFCAL; @@ -218,6 +238,11 @@ static int mcp3911_set_offset(struct mcp3911 *adc, int= channel, int val) return adc->chip->enable_offset(adc, 1); } =20 +static int mcp3911_get_raw(struct mcp3911 *adc, int channel, s32 *val) +{ + return mcp3911_read_s24(adc, MCP3911_CHANNEL(channel), val); +} + static int mcp3910_get_osr(struct mcp3911 *adc, u32 *val) { int ret; @@ -321,12 +346,9 @@ static int mcp3911_read_raw(struct iio_dev *indio_dev, guard(mutex)(&adc->lock); switch (mask) { case IIO_CHAN_INFO_RAW: - ret =3D mcp3911_read(adc, - MCP3911_CHANNEL(channel->channel), val, 3); + ret =3D adc->chip->get_raw(adc, channel->channel, val); if (ret) return ret; - - *val =3D sign_extend32(*val, 23); return IIO_VAL_INT; case IIO_CHAN_INFO_OFFSET: ret =3D adc->chip->get_offset(adc, channel->channel, val); @@ -799,6 +821,7 @@ static const struct mcp3911_chip_info mcp3911_chip_info= [] =3D { .get_offset =3D mcp3910_get_offset, .set_offset =3D mcp3910_set_offset, .set_scale =3D mcp3910_set_scale, + .get_raw =3D mcp3910_get_raw, }, [MCP3911] =3D { .channels =3D mcp3911_channels, @@ -810,6 +833,7 @@ static const struct mcp3911_chip_info mcp3911_chip_info= [] =3D { .get_offset =3D mcp3911_get_offset, .set_offset =3D mcp3911_set_offset, .set_scale =3D mcp3911_set_scale, + .get_raw =3D mcp3911_get_raw, }, [MCP3912] =3D { .channels =3D mcp3912_channels, @@ -821,6 +845,7 @@ static const struct mcp3911_chip_info mcp3911_chip_info= [] =3D { .get_offset =3D mcp3910_get_offset, .set_offset =3D mcp3910_set_offset, .set_scale =3D mcp3910_set_scale, + .get_raw =3D mcp3910_get_raw, }, [MCP3913] =3D { .channels =3D mcp3913_channels, @@ -832,6 +857,7 @@ static const struct mcp3911_chip_info mcp3911_chip_info= [] =3D { .get_offset =3D mcp3910_get_offset, .set_offset =3D mcp3910_set_offset, .set_scale =3D mcp3910_set_scale, + .get_raw =3D mcp3910_get_raw, }, [MCP3914] =3D { .channels =3D mcp3914_channels, @@ -843,6 +869,7 @@ static const struct mcp3911_chip_info mcp3911_chip_info= [] =3D { .get_offset =3D mcp3910_get_offset, .set_offset =3D mcp3910_set_offset, .set_scale =3D mcp3910_set_scale, + .get_raw =3D mcp3910_get_raw, }, [MCP3918] =3D { .channels =3D mcp3918_channels, @@ -854,6 +881,7 @@ static const struct mcp3911_chip_info mcp3911_chip_info= [] =3D { .get_offset =3D mcp3910_get_offset, .set_offset =3D mcp3910_set_offset, .set_scale =3D mcp3910_set_scale, + .get_raw =3D mcp3910_get_raw, }, [MCP3919] =3D { .channels =3D mcp3919_channels, @@ -865,6 +893,7 @@ static const struct mcp3911_chip_info mcp3911_chip_info= [] =3D { .get_offset =3D mcp3910_get_offset, .set_offset =3D mcp3910_set_offset, .set_scale =3D mcp3910_set_scale, + .get_raw =3D mcp3910_get_raw, }, }; static const struct of_device_id mcp3911_dt_ids[] =3D { --=20 2.49.0 From nobody Thu Dec 18 23:03:36 2025 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 208231D5174; Mon, 28 Apr 2025 06:54:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745823282; cv=none; b=QP1/2j2YkKHG2ROxrwMJ0LBICpuCx5XwCvrvO9MD+i+aAuTgRuGavVFrQtNd0DvOh9KliH4JZvsTVp2kjHTK0WtJmQaqx/sKpvGls/WdBbCmDoX+QIBye4Uz3/3ETUiiJj+dwfGIp26clou/Ddz0JRGsGA1HKsVnoxGjSpra48Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745823282; c=relaxed/simple; bh=o9rko7Mal2eB/MUZ2Oa01bIuz8dWUsyCQuiKuHvbZLk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bGVLI++0kLstWaBzk0KIN3kfrs5M/8RhWn9hYAh0axQvwTlICTKg1m8DdOjGoNnXLvj+QDhulpe7uUSudxbmRm3uhSqxtjeVBr/f8lBXVyQH8RUetv5oXpoBoo2R9nH67u/UC6iDc6puZYrgnaQ3ObkekUIf4Oim74r1+3ko5OM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nbKDWS+j; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nbKDWS+j" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-30db1bd3bebso46544341fa.2; Sun, 27 Apr 2025 23:54:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745823279; x=1746428079; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7FTG6YAFpavOo57Q/QlOcqWA0covw0d5GqnQeh6CN/o=; b=nbKDWS+jumqe4YnmjLcxup+mx5xOlOkov5J99jtISNiO1ByS7/vMzAYYzNojcY5N5D zCtp6tBieW3kglmMW9s+K9mX4sqZcPE4ABaJ+624FWr2Z/sm2iJS7I7wk5z95KcV+/SZ obISwMmzadxZhbE30GNewi5tCI1cfyNbNhyXsOPw+UIYejoLTudr2qqixb3bFR/8iXmg 6l96dp6RO7nQF2HnIriwydhAUEoRPT0VCbMIaJ8iv1myk61kM1T2sSr+//SrNZ89TXTM 0pZ9YfeMypBThacMLzTUe3QZo+9Ugr2rZntXi3p78cY+Xe0kvlR6KDBxkXfM6WYTo/Y2 fMAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745823279; x=1746428079; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7FTG6YAFpavOo57Q/QlOcqWA0covw0d5GqnQeh6CN/o=; b=Ak4jUeTuMu3nP4C4fXzGB6zcHIIuFt7BeLn2KnIHcokHTobEPVKMmBEYEH3LnTqNHf HkHlX5zLL3f6HONTLSbepGJeJ9xXT4eJXmVdeZd2LwzE2Qs8/xxiUR68AQb88ElxNvLO sjxlE10/11LLOozctYq2YZOZiaF9heJT8bxqn7CDeAUoGzWrH2czYbitjgUUlTwN92t0 wMhQ+8mAbfsVFQ4QWuCdMQ+ZlVrLm4wksBFsIsMZIO9rI3MjSYHVxmS2Id86XUYq16NR hahiIQqyNdXYR21lvdsw5574BSZUIP2bZYZnFD65nPvj7VupC9rT0KRpVr07oR63sdyV j6RQ== X-Forwarded-Encrypted: i=1; AJvYcCUXD7l6/4n9owNKvMEG+zrHpUz2YVQPVaIin9qCe02SJF5JAQSd0+ffLWsGFi8ToVGdWrQFJBqkSOzA@vger.kernel.org, AJvYcCXHZl/B0AD0XSRnUcJEMisxrdrIw/Tfb7oL9Ta749fFY2vfTmmshAXJpCeniqCYloC8HLPFpp4v5Eye@vger.kernel.org, AJvYcCXvwvzrFEK8nJ3B/6KGvfUA75DL9ZahbbLD1BgtxFwGgaN/mOezmk8+ezIU4GkyCJW7CWJL3wWLj34deKAr@vger.kernel.org X-Gm-Message-State: AOJu0YxkZsoLWeS/i1au3hrnVyBxd3YJMc4QKfphymcfTeFFZjAgbb+y 1RJLgf96ZKF5LcEacvShKBYDoYM8Iqulu+TLSRoHs6EKhvqeHh08 X-Gm-Gg: ASbGnctnZhoxGixuTJYXZmt4UhBt5BMf0ulvrYIxhjdGZ2kz6NzzP30UhIWelM+zFMF 5eR4inyMFrUQd3UCsjwueyVVhinPtBjjdjnIbNCJ4CHTmnFrtDHFoqF54uOFjSwf8xHlFUWHzV5 D5RXNaMONSnzJCjb32BY99KiM+G5ZxI0569JnlNZDwgYnz70lSX38MrwXthuJUvXFq2x+2eZkB3 uFIwReINt2mHl2H4k+TRUNMmDggz4T7CL8HMieAKAj27Nv7PMTFe8SpfzrJSSJTYdB0q7mIYD4r n7DXY/AxKyisRk5Jf1FdsBC3XicItOiHmEbYlkV/g2udgT/LFX193Cj9+uWHW/fSoT5E6MG2h6Y q5E5zB2Om2kQjG3NpygQ= X-Google-Smtp-Source: AGHT+IGFHQ953XlFUNcdWeX3LFF7ZinSerC0mh6VkIwkXLw1YYkrlJKuT6eHgUezwJV415R2Utt+wg== X-Received: by 2002:a2e:bc15:0:b0:30d:e104:a942 with SMTP id 38308e7fff4ca-319dd798a4cmr23585521fa.38.1745823279202; Sun, 27 Apr 2025 23:54:39 -0700 (PDT) Received: from [192.168.1.11] (83-233-6-197.cust.bredband2.com. [83.233.6.197]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-317cf659c4fsm20017871fa.21.2025.04.27.23.54.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Apr 2025 23:54:38 -0700 (PDT) From: Marcus Folkesson Date: Mon, 28 Apr 2025 08:54:12 +0200 Subject: [PATCH v2 2/3] dt-bindings: iio: adc: mcp3911: add reset-gpios Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250428-mcp3911-fixes-v2-2-406e39330c3d@gmail.com> References: <20250428-mcp3911-fixes-v2-0-406e39330c3d@gmail.com> In-Reply-To: <20250428-mcp3911-fixes-v2-0-406e39330c3d@gmail.com> To: Kent Gustavsson , Jonathan Cameron , Lars-Peter Clausen , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Kent Gustavsson , devicetree@vger.kernel.org, Marcus Folkesson , Lukas Rauber X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1540; i=marcus.folkesson@gmail.com; h=from:subject:message-id; bh=o9rko7Mal2eB/MUZ2Oa01bIuz8dWUsyCQuiKuHvbZLk=; b=owEBbQKS/ZANAwAIAYiATm9ZXVIyAcsmYgBoDyYh/Ug1dMfpEZK40qCZjPJlTVboll+EyXs+X qxZDRw+VSGJAjMEAAEIAB0WIQQFUaLotmy1TWTBLGWIgE5vWV1SMgUCaA8mIQAKCRCIgE5vWV1S MlH8EACKc1bBvasZIEvdmceQ7TMNQ+L/Nl1b+T2S6mnWxeEW0n8FDZpt2v2MrbdHYs17en/Baba Q03tW+qlP/1VVmNZH8oCWbiNwUVv0/DFLQA+aUkkZ9/5Tjmg+ZWwG7scaVC7IREYT19D0vUMGIS BkrRz3CjQ3FVURxBYJIcIMhLhw5RqX7DftsOZS+clF9ufUYfoRXA0us78T/a+LSvyxbx17Px3F/ nTqttu926yHDooVWEH74U74FuZywiOWHUk7XBX2vqWt2X+g8XDyYN8/ySwLXDm1iuC4Peu+3HD1 IUWUVb9hqwCbFaMNPUz9FucJmhV1KnZal+63MD8efUpF8J5z6DJhJmG1llJfrByMAflWH2zZBFJ Ep323Kp7V2rOfE7yKddsaNpMSkzUa9hKKFfGFHXVds549ARK7p4Fy6nv2kyodfHzs9W507TrOYg ZTnJIm7FdfzzCm6ePX4a9C139kcFbWrRpOxfCnIT/UBTy3xqjqZUPvyjc0Iuck+0dcVELdk/HzN YiEoSuv4s5qlkbMpq8pcnsLUR7jJ2Au6vVKlEGFs4im/I2LFo9dX8ht+fuX3G7SOROtSqPcmuxO mZMnFiGR4z2UGDXC29C479qbhYVzwbVTUdU0H9MOlaR64D3ZiBcxacNmvZjbSeSkYZ3rMuAgs5b z/VCTjOvamtQ59w== X-Developer-Key: i=marcus.folkesson@gmail.com; a=openpgp; fpr=AB91D46C7E0F6E6FB2AB640EC0FE25D598F6C127 The MCP391X family provides an active low reset signal that is still not described in the bindings. Add reset-gpios to the bindings and the example. Co-developed-by: Lukas Rauber Signed-off-by: Lukas Rauber Signed-off-by: Marcus Folkesson Acked-by: Conor Dooley --- Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.ya= ml b/Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml index 06951ec5f5da381a9bb942d0ac7416128eebd3bc..3a69ec60edb915ae16312b94fdd= d32f5c87f37a7 100644 --- a/Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml +++ b/Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml @@ -32,6 +32,9 @@ properties: spi-max-frequency: maximum: 20000000 =20 + reset-gpios: + maxItems: 1 + clocks: description: | Phandle and clock identifier for external sampling clock. @@ -71,6 +74,7 @@ unevaluatedProperties: false =20 examples: - | + #include spi { #address-cells =3D <1>; #size-cells =3D <0>; @@ -80,6 +84,7 @@ examples: reg =3D <0>; interrupt-parent =3D <&gpio5>; interrupts =3D <15 2>; + reset-gpios =3D <&gpio1 10 GPIO_ACTIVE_LOW>; spi-max-frequency =3D <20000000>; microchip,device-addr =3D <0>; vref-supply =3D <&vref_reg>; --=20 2.49.0 From nobody Thu Dec 18 23:03:36 2025 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E73C1DC98C; Mon, 28 Apr 2025 06:54:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745823285; cv=none; b=amPCYvmk7pkQxnth4RWaCvyyw62SYC0tJY5zvz7V8NXQ2wv2IwOLSxhVa8JWQPuzeEaCPPDMoeU2Mtk9zg3RhyppoaNQ+/hoJv/tep5cdub9rMlXLiWEoq/Kc98yL5Xt7K16ORdQWQdbxLInwKwiDwZJ1DpUAYo0CuKH+4W2zlk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745823285; c=relaxed/simple; bh=u2Q7slitq+/N2Lvmg494PEDFHCL/9E1dcqL+EcBsqT8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eQnTlpELluDsJfTbVvq16YaahJrlrDKSyghsWm+wmVbUNsgjOyisAeqTHm8h4dHuRBG40IwlzXeIv1zU1ljI1GvyfjXs840tk6R28lA4g3/Rys91aRW+11u2vm6yyNNnbnIhQQuKsVPmdxyrztoNxb1qjevxZSgPxXb5Gs5jwTg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cM6pBg3p; arc=none smtp.client-ip=209.85.208.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cM6pBg3p" Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-30effbfaf4aso43925891fa.3; Sun, 27 Apr 2025 23:54:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745823281; x=1746428081; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wgqpIKZdigmmEv2sXkTySvXZs+Z5CJRaLrF79iotyYE=; b=cM6pBg3pyz2fkwW1B9qNBo36hd/c8tfseF9e9MNgMpcAcI/7zf67C7y1e3+99FSa8f qb8KwwbotxJbZ1TQ/Bniok9uFMf6meei3APQ2CHF1tfaCxwbtoBP+R33s4zd33wU47GL 05F8uO2xqUXgGV9mt+OgIxR6zBRhZbMrD/+ai0A75gh9Yh3NpNsKucSeL7POikoSeCPj fKA5AdEeUupuDqCF2Urk/xV1cy/RYDlLTC/ho31OVsUa1XoZHsmB3cdIN1eNC3+KKW9q HPBNakyf3bb41BjX4M/8IokcSeV+lz4af6mWeAydh9cmX7tAdWTsrdpTLG9Rtgi37jNc At4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745823281; x=1746428081; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wgqpIKZdigmmEv2sXkTySvXZs+Z5CJRaLrF79iotyYE=; b=p+Tjdd2wKTGVCNfQ4aMzvrgNjPVcJ35rTGarXhxLV6qkVhCIZNFZm+/DLKT19aV28o O6YJpmmS779IEz7itNaELZ009dpfls9P7tpv29rFKKb6gf31DyYd06zdJwtYuxVu2EiK 5Wh9gaa4W5Gq/tS6grHo8ggPRvRB7r6pVGmQOCo6VyYNzmPwXTgj3xaDrs6SJN6M5WnW 9jewr20HgbJzWUZnNzn7R9K4MUGteKyajZn+Ifmf/cPb3VREZW7y3UVGdnGRpamjA8Bx hjIdtS42irRmj3heYMElQixyVsASDpgrPaNFV1hfob9bM8IWZvv1fz+VGjdOsA3AmM60 bvcQ== X-Forwarded-Encrypted: i=1; AJvYcCU1xI+9ud0uUxP4IFFgRHP3dw1Lh0h1Pdv5LXylq2K719ZbjTe/oP6rZ7/7q+fXq9vqXRcrnIytQf+Y@vger.kernel.org, AJvYcCUrFDESPTcbyr28rfiEYwJ/MX385LdUn8D4C2DOz3VBOo4doWWDxyajti2yUWFAfkWKgHztdFw4f9lLmo/0@vger.kernel.org, AJvYcCWmrvwJKRG3X3yXKO0yUXEZq/sL+oh/KfHlRGUbv1gtLSKZh421oHrUYZWTQNVj/g84GlprxX4IBV9K@vger.kernel.org X-Gm-Message-State: AOJu0YyPPJjoUt5TT4dAkECwYwIKkFZ0XCtzi7gR/VLsq72/6gw0RoJJ 5+xfqe7PNO11pTXdo+AZbXf+xkDt7R9XD/hIgN4kDGVXTdSf5a5Q X-Gm-Gg: ASbGncuVhMnVQNcLIQtjXcXyyFWOX4Gf/3UWH71IlwHZXf/6mh3bYmxsETmE952m3+7 CB2LfS9L9dxTVsSV100iJd5zkGrptkpEuZ3VTjs6WQ7LrtEEMCnQiJ8Y7TVDNIAQ2xxyun6DZ1/ sFmNt9ckiH8wFBj4q9H3xlHZqGN7S6d9kRj6k1AMIvbz2WGFB0IiKoqa3zjm5hSrb/gQAvsVUun C2Dx+S5E78W+iimeRkLYmoP7yYjyKOq4nZ4XbaXBuZx+i9l1mWUePkva14KJratyPNCvvD/DT04 xXKbuSAJFFpdMTNkwbwyWpfGItDRi2FI2dMq8oF50wrkxzC/8TLST/feZXwW+5rmLlUxr80Fkt9 77nkG16F1 X-Google-Smtp-Source: AGHT+IH+QuEx6mmrvX51OEDYksus65i+tkS/nwfzzAneQbU6Kv86KMA21Ps60h9lrOyYuIfRtpPN4g== X-Received: by 2002:a05:651c:12c2:b0:30b:cceb:1e71 with SMTP id 38308e7fff4ca-319dc01f73bmr26345131fa.9.1745823280518; Sun, 27 Apr 2025 23:54:40 -0700 (PDT) Received: from [192.168.1.11] (83-233-6-197.cust.bredband2.com. [83.233.6.197]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-317cf659c4fsm20017871fa.21.2025.04.27.23.54.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Apr 2025 23:54:39 -0700 (PDT) From: Marcus Folkesson Date: Mon, 28 Apr 2025 08:54:13 +0200 Subject: [PATCH v2 3/3] iio: adc: mcp3911: add reset management Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250428-mcp3911-fixes-v2-3-406e39330c3d@gmail.com> References: <20250428-mcp3911-fixes-v2-0-406e39330c3d@gmail.com> In-Reply-To: <20250428-mcp3911-fixes-v2-0-406e39330c3d@gmail.com> To: Kent Gustavsson , Jonathan Cameron , Lars-Peter Clausen , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Kent Gustavsson , devicetree@vger.kernel.org, Marcus Folkesson , Lukas Rauber X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1896; i=marcus.folkesson@gmail.com; h=from:subject:message-id; bh=u2Q7slitq+/N2Lvmg494PEDFHCL/9E1dcqL+EcBsqT8=; b=owEBbQKS/ZANAwAIAYiATm9ZXVIyAcsmYgBoDyYmum5EcMkLk18UjuRwDQQJhuTXfITLzj9KM DQ24UaZWWyJAjMEAAEIAB0WIQQFUaLotmy1TWTBLGWIgE5vWV1SMgUCaA8mJgAKCRCIgE5vWV1S Mm0VEADak9LhtqOqiYhNz7+LKiDRXg6ezmtu0+7GxUC6L1Ijqj0OTWOYvq8m1KIeocUE0zAObWg u55hLohTELP5MykOvlTLq089FxrS1F4Z93zPfNzQkUFVdIS5dEFni50u0LCfjON5lH/9ohvJzIV GxXcCYjH8iXSVu8BzkEecEsxRCl/NBYkC2aBEYEKAor23/vPBewBOSiigGYvcO/NiA+N9qX0+q/ 425b+tGYn67DIH14rQOEBF7G6d4ENO4g0hHZMKrz3K5qCdKko12+XJ9GNOWJduCRIVa/Oyp5lCQ GRpEmYFaOjf1aIFqDeeCWljBJNka5I9s/eTl4CWUna8jsABJPwsPSaXO8Hvu7ib7BuyLqOUer0/ sXJbdVpW0d09E+NGHjP0Ob4Jmt08BbMg43yiTQ3NgLJtZvDi4szl+BFRYPig+SVMRzsSXnjOg+g 6BL41hxxyJlKv0w73APj1NooYVUrc6ekVVpgOYzVK6c7jQAjPWHXO0WK8Uss4SMId2YMzJ0NAN7 xOCT2rV/T8qUKKXQMhuPBTFCm4QRHNMZwX9eBIL6o0pWVDFIpY0iEJTmo0W9cn0Vz43Os0h2qD2 mLtnanGq9Ojg+2KilGb4gjAfYqkbbSE0pRP4rU3pyoyP9ShNQfCrRCzv3HjHxXGS2BTUjOxdKFQ vzg8Lf3fVc7l7jQ== X-Developer-Key: i=marcus.folkesson@gmail.com; a=openpgp; fpr=AB91D46C7E0F6E6FB2AB640EC0FE25D598F6C127 Add support for optional HW reset. If specified, a reset will be asserted during driver probe. Co-developed-by: Lukas Rauber Signed-off-by: Lukas Rauber Signed-off-by: Marcus Folkesson Reviewed-by: Andy Shevchenko --- drivers/iio/adc/mcp3911.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/drivers/iio/adc/mcp3911.c b/drivers/iio/adc/mcp3911.c index 60a19c35807ab783505e817898a2405bd8beae34..76b13a73543493c4c5d446dc47f= 8bf1f9d02af39 100644 --- a/drivers/iio/adc/mcp3911.c +++ b/drivers/iio/adc/mcp3911.c @@ -10,7 +10,9 @@ #include #include #include +#include #include +#include #include #include #include @@ -706,6 +708,7 @@ static const struct iio_trigger_ops mcp3911_trigger_ops= =3D { static int mcp3911_probe(struct spi_device *spi) { struct device *dev =3D &spi->dev; + struct gpio_desc *gpio_reset; struct iio_dev *indio_dev; struct mcp3911 *adc; bool external_vref; @@ -750,6 +753,22 @@ static int mcp3911_probe(struct spi_device *spi) } dev_dbg(dev, "use device address %i\n", adc->dev_addr); =20 + gpio_reset =3D devm_gpiod_get_optional(&spi->dev, "reset", GPIOD_OUT_HIGH= ); + if (IS_ERR(gpio_reset)) + return dev_err_probe(dev, PTR_ERR(gpio_reset), + "Cannot get reset GPIO\n"); + + if (gpio_reset) { + gpiod_set_value_cansleep(gpio_reset, 0); + + /* + * Settling time after Hard Reset Mode (determined experimentally): + * 330 micro-seconds are too few; 470 micro-seconds are sufficient. + * Just in case, we add some safety factor... + */ + fsleep(600); + } + ret =3D adc->chip->config(adc, external_vref); if (ret) return ret; --=20 2.49.0