From nobody Sun Feb 8 05:43:05 2026 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11012040.outbound.protection.outlook.com [52.101.66.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9D0926136C; Mon, 28 Apr 2025 10:05:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.40 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745834715; cv=fail; b=su2Fb0NjkMAtJ2IRAqkX4oZhw429yv88bMskKMIhIVwAK/WqBFeWQ7uqUsUwSSfdLcQo9CUo3pP39bj3yUOTMwdEdIOKDj5zzE/pnfBfow4Ldemb8+nqt3ENdRlnG6YtCc+4hYQbKeAv2/P9tY2uj4BvIWAiMdSXRUqv/Z6/6oU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745834715; c=relaxed/simple; bh=R+E0blCnr84VOgWVUzaNmlI5G0tHD3+mnj0wlyBAGLc=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=INdcPlnDdJSgNNBTLU1tYs4lJtYtYMQtKlo1kMH7jvqAlx61SQG2Jzhga76CJWGO5/FdKKMX9p0YM7deH3+V0d13ernWM4AC7Ur5e9K3RKJq83OMN5PGmjXONhIOoAwio8C+fxZOpzrHQViNNuQWquwHjtMJyPv8PSLhpaqm97g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=lyQfjFbR; arc=fail smtp.client-ip=52.101.66.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="lyQfjFbR" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SRhQSzgrzgKK+Xx6ZZJCNC2a5oUWY3M6eqi7leFLRAhqDOTFxtMSZrxY0oxVycAw2NcHarNOArT2GUe1E/Tr0iVbmIIisnlOpcUFat2A3988D1Z1TRkdzPhrZ++rV08jwrZJ6u1J7HsjFQxxkZ7N2PB85tz7IFLBDlSIMQYtgWrxIY7c7a7kzjanqvV9XIUJxy1xVCQlHoatJsiyafnPCbk7VJ5eK3q/Gof/q8c3NAVlpUgZndwQRdqBfWLJCY6MTyeBiLE4QAr/KuhLspm3OnGJ4w+zB50y/B09/ei8oNKTSRO2OyOlyZwYXqNv3Cd4CIc+FU1zwe2nCjb+gCl6KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rkoc45T7BYUh7B6StD6VS++pbiV1SAITGBvZZWupjxI=; b=mVrYHVDV9IrEhIJnJEE7YG/ukCUn+fsSQKTWaxMwysXGCrRZ5cj3qfKjNZTOsloci0D8j+eXGRJUPsEDduTAX3rbf+8sZn9GtWv5YH4Y81aUkCbQxzg22884fR026GBhtuuGj9Iizd7c+YllP6c+YsdmkzBk2odUDI5KwuD/MZ58zv6USVvudh5IOvfaRwnEpwNMSv3GsfZp7CKazZF8Rhyc1pVQ+Go1YfACHYdYsSVPRkACb39+OEqBYq8tkHdI5/o+4uQhUHtjfF06KOTmeJo7mestVDwXV7z3gLmzI2v0TbohIabDwLHh2e1qO8yofJfNE260cuM6jkBhm3EPbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rkoc45T7BYUh7B6StD6VS++pbiV1SAITGBvZZWupjxI=; b=lyQfjFbRFnFwe1O1Lket4XULu6/E7s7UFu3l0dhhY61a3r2zoHTlCi99goDfCwJzgmWylSYB2YUcEWJFa7iQm6IGos8HhFAlhcDPwBkOKa7YWJvKOwUqHvynVCP2f3GfD8O6C6nWAIJiIjIiCVSMpmRAOwXpVdScnB4T3/S8IlgUwO6Iyk/arq2kZcUNgiRt5+Zw7hktrJH90rx8OsRtxsjmdAyIydiukEaVPvmSX5EuCBU8aQbvsbH6qI3pUTV1S8zVJ6802znI1w6gb8MH8r41dS7szYK/jOHr6MNnsrBjuMzloEc/zBVk/juaMJKy5tbZrc7O466mEXwZwBqL0w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DU0PR04MB9496.eurprd04.prod.outlook.com (2603:10a6:10:32d::19) by PAWPR04MB9862.eurprd04.prod.outlook.com (2603:10a6:102:391::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8678.33; Mon, 28 Apr 2025 10:05:05 +0000 Received: from DU0PR04MB9496.eurprd04.prod.outlook.com ([fe80::4fa3:7420:14ed:5334]) by DU0PR04MB9496.eurprd04.prod.outlook.com ([fe80::4fa3:7420:14ed:5334%5]) with mapi id 15.20.8678.027; Mon, 28 Apr 2025 10:05:05 +0000 From: Haibo Chen Date: Mon, 28 Apr 2025 18:06:43 +0800 Subject: [PATCH v3 1/5] spi: spi-nxp-fspi: remove the goto in probe Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250428-flexspipatch-v3-1-61d5e8f591bc@nxp.com> References: <20250428-flexspipatch-v3-0-61d5e8f591bc@nxp.com> In-Reply-To: <20250428-flexspipatch-v3-0-61d5e8f591bc@nxp.com> To: Haibo Chen , Han Xu , Yogesh Gaur , Mark Brown Cc: linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1745834827; l=4520; i=haibo.chen@nxp.com; s=20250421; h=from:subject:message-id; bh=R+E0blCnr84VOgWVUzaNmlI5G0tHD3+mnj0wlyBAGLc=; b=Dt/5jF6GbjUYTxhe602jhSPIWg2Wr89MFJA+LAzqsz/nCdvGZe4Yx+hQYhWUNxgCHp1MyfKje kHlS7g44l2rD3CDUmoe5EuVRKqbN6woxJZHsSijCkSi6lNRojtGDICU X-Developer-Key: i=haibo.chen@nxp.com; a=ed25519; pk=HR9LLTuVOg3BUNeAf4/FNOIkMaZvuwVJdNrGpvKDKaI= X-ClientProxiedBy: MA0PR01CA0011.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:80::9) To DU0PR04MB9496.eurprd04.prod.outlook.com (2603:10a6:10:32d::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9496:EE_|PAWPR04MB9862:EE_ X-MS-Office365-Filtering-Correlation-Id: b8194e40-7f6e-4ca3-4865-08dd863c25d7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RUNndGVUUVpBYk9XUUxiaWhCR2tmcTd5b0srR0NzYkNIVWFheW43bHd1NGxX?= =?utf-8?B?YzZoS0VSa0xRSmI3VnZkYWR2dmxBWXYveG5jaG1uZUxNRGhkcXB5c1VjMVlu?= =?utf-8?B?YVgrcVQrS3R3dFI2VHUxUUN3ZUxGVDMxcithQzY5cFhQK1RaRmdGYmsweUt2?= =?utf-8?B?SUlOWEV0V3BiVGJNSG1lTU1GWDVFaDZHdTh4bjE1TUM0NnZiMEQ4ZkppTExT?= =?utf-8?B?RTlhem5YdkdGd0FxR2ZHNEx4L1AxV004akRYV1FJV2RIcFNwQ01XRmJmN0hK?= =?utf-8?B?c2FuNFJ3WEtHMDNmQ3ROWVVCTDdKd3QrUFhCWSs1K1JFK0pyQ3daalFyRUk4?= =?utf-8?B?dFEwRUk0ZEY4SE5Vek5PWEpEekh4TzRGUWRjYmpOc1NVUEpzcWtFVHdmcTFs?= =?utf-8?B?Q0tJS2w4NWFnQzlaajk5bGdZSkMwRW04cU9NWnBBaWVZbndrOVJSaXZUZWZu?= =?utf-8?B?ZmhrQjFnQm03bGF3ZjlEWjlCM3ByWkJCZW9VN1VXbngwNWk2UGMyRGU3L3E4?= =?utf-8?B?aXJVQ1pZOGM0aXk5SG4wcVRjc3Y1K2loSWJQZncxVUw5S093UEgxT3Z2RjNt?= =?utf-8?B?eXFXZVlZSm9iSGl6ZXNFNG5TOFFSN2ZOYjR2VkxZYVdsdDMxeGhtamVTa3ZW?= =?utf-8?B?bXVlVE5yQVVmZmtwUVMxYXF6UUlLNVMxSER4eU5xMlZXeml5TXIxN3NHbDBL?= =?utf-8?B?Z2ZaaXUvUU1GdTNxek9nckpQVXlMZksvK3NvMHdSdWlmK0NrR2RkblZNL1dC?= =?utf-8?B?L1VMWUE4UXBLMjRSWmJQLzJjQ2h0aFl2NW5uditnOGhCb055ZHlncDY4NGtw?= =?utf-8?B?UzF1T3NFcXE3SVNxTGhaNEo3dDZVZHZuakV4bVFCVWtZUnVhRzN3ZkVpeGZj?= =?utf-8?B?MUQzelYrWHJKMUlVeUtkTTcxVGJhQ1BpTGVsdmRneENIdFZEcEpDd2ZEdG1n?= =?utf-8?B?R292T0F2ZkcrY0NMN1BBVFdYQ1BOYjlHRlJERGc0M01tTUcrL2I4aitOa1Aw?= =?utf-8?B?TkNCcTEyQmxlMGlIU0NLOE9VMkp5eVNpMW16NndmZlp1YVZEZ0FVaDBsVWlC?= =?utf-8?B?S0swUVVSczhiZTUwT2F6UXpNdk9UVlF0OHRZRFpTMnpIU3BCb0dkbWRvdTJt?= =?utf-8?B?Sy9IVjl3ZkZLN04zeXBqTkJQTGliMWJpbUNXY3d0ai9mL1VwdERSTlh5RDNu?= =?utf-8?B?Rk5PUWhyam5CL25zMXN3cnBFQUh4VkpSQjl3Y2dkQno5aW5CWTNCa1UzTlVq?= =?utf-8?B?ZUNYc1kxQlBCWkdSdi9icW55aVl1RFBwd3VMQzBGdmU2NjhacHdPdlZXMUQ1?= =?utf-8?B?L1dXaklQbzJvOFIyYksyRXBjSUpsMXMxaUxMbGNpVE0rc3NucDdRU1RDcE1Q?= =?utf-8?B?VlB3ZXdtK2lDN2dqRElYeHZCZWR1QllZZm1RNzJWYzFudThSM3lUdmVIRjZr?= =?utf-8?B?dUhNaWtrZWdqSTNYVG5YaDl5WGMrNVBBMDB4eVhtbFFzMHZGYzdTcmVtdlIw?= =?utf-8?B?WWZRdi9HYTZXZnQveUFuR01iU0dwbHFYTDBrT2R4Slg4dG9jMnhmU211c2Fy?= =?utf-8?B?ZllJQS9UbjVROFQxVFo1emdySWZNUTRSZmlTZXY1V0djZWVVOHAwWlU3bEt0?= =?utf-8?B?c25GR0N0MWp2TTY5bWlNZVUxcUI2aFdOUTN0YUIyNFJjaG51UnRxamZ1eWlO?= =?utf-8?B?cHpuZUExZCtjVFVmWnJkS0JuVWZpTFN2MDV4NnptK3k4dWFWR09adjdSZHho?= =?utf-8?B?OWxFMVNNOVFnK3luVXdBcTRPWW5IdHhPekQrN3dDakdhc3JLcCtMMkNpNDlw?= =?utf-8?B?QU1lQWxaNFdaeFZWdWUrWElvY1NqUEVnM3lTK0MxZ2UxNWxHMVpYeHJaa3lP?= =?utf-8?B?bW5zRUxkdllYVWVCWEdJZkZkcXpqdVRZRzBFMGZpSmlDL3NRZnF5U3JUakIv?= =?utf-8?B?WDAwK2wvd21ueStGOW93WGhNc0M5NFB6Z2Vsc1JqL0tIVTN0M3dkUk1KNis5?= =?utf-8?B?Z3pVL3dFSXFnPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9496.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkVLbHdRSTQrOUs1RkhZODRYU0tZV05BV205azltSmV0WnZSOVBwaTRld096?= =?utf-8?B?T2hOZEcyOVpwQ3pCUHZLUk1iSFJYSG5vcW1ZSWludWdqK0FPMDB1MENyWWp1?= =?utf-8?B?cVJ0SEgvbE9FcFFTS2JBKzVhS1hDc1FLRURDQ1B1YUF2M1J1RFhyOURDcUlm?= =?utf-8?B?UElnbDRKc3Zacyt3ZjkwMHNybzNQcW9renVoaFRVdmYveEpucENXT0hRd2JY?= =?utf-8?B?ZytMcnhENE41dytTTFBNRW5iSFNCZEhNSllpYmlXK0kyR2hpaU1kajZqMHln?= =?utf-8?B?eXk4dTQyM2FVTUl1TVYxVzd2MitBdG9BaGU1VXhmTEg4SzVnTGQ0YjY4YTdZ?= =?utf-8?B?b3VFVjdaYW9LYmVtcjJaUHB6c0oveDJlNlhWdzhIU0xsNWQ4UGdhZklqcFhj?= =?utf-8?B?UXExQ3gwTnB3YjgvaUw5ampwelZUYktBSW83Ukc5Tm85QTVGY3lTeVcyTXJ2?= =?utf-8?B?MXF1RVEwUTN0d2cyVFhwY1hNWGlIU0V4NTFuUm53UkYxRzJ2Mjl6ZmIvaTN4?= =?utf-8?B?bGhUU2htRk5DYlpOeHFQTWx1UG5kc0VMOGdFcUVIaUEvM3dPQXpycVNQcU1k?= =?utf-8?B?ZHhiSzVhdVFLUVNWdkNxWnRLRnVmUHM2VmtoalhjM1RQTXFIN1laZ2V1cGtB?= =?utf-8?B?VS9GUFJOdWdsd2N2VGdKVHhtYU9SS3k2VmlPc3JXcXRQTlpSVmRNOWkvU2tW?= =?utf-8?B?S1FVS3Z6L21oVG4vQkVyZFY1NVZOc2xURnRGeUpuemJrMWU1U1l3QjB6Q1pk?= =?utf-8?B?VUtBMjVDMVRjYThaTG5rRGh4RmhWbG95d2dVR3U4bW5HQ0xzbXFNSll4Sm50?= =?utf-8?B?bk5rK0ZuS041UFI0dCtacHpwbFJMa0xZSTN4Tkhpb2Q5SEh5VzBaS28zbmhW?= =?utf-8?B?WUJocldBVWV5NDZTcENWOVlxNlJ3MFRia3IzVkhXWWM5OHFDUlBhNEVpOEpy?= =?utf-8?B?Q2RseXFjUno2dng4UHFobkdGV2NCSjI3T21pY1lYOFlyWSs0bENDUjY4MGZh?= =?utf-8?B?ZHBPS09mS0hKREN5WlJUQy9iWHd5cGdrbUt2a2trTG9zaE9NMTcvcGh6UGxx?= =?utf-8?B?bWFUOU4rbEdyMlo0ZnBIb2pTYkJNT2pRZTBaak5oUGhnejIzSStzT1I5bDVj?= =?utf-8?B?T0tDVjlIeFNRbWtRSncwSEJEZ1pLUytNVHdtZ1F3SGtWcitoK3lMRnNoNlFE?= =?utf-8?B?NXkxcDB5anJ0dEl5TDkrNUkwUGJXQm1Ea3JJSWcwUjNUVmg0V1VkMkkyQ1Z4?= =?utf-8?B?WUJsZ2d4YkpUNmx2WExLWFNPdkZRaHY2NkhzY1BaZHZaR2lYMnlCa3I0WkNk?= =?utf-8?B?cDMxNGpNZWtEa1FidllqZlF5UnkwTVJKa3FtMVd4elJvTWhwSHh4TzhuaHpl?= =?utf-8?B?TUEyeFE5VlVZZk5hbjdPVUxpZ2M2UjNHcC9vZTdZZDUyMTEvMlRMRm44VkJz?= =?utf-8?B?Q3M4ZEM2ZDJ3MURNTklZcUZaamN5eWRjek5BbmVxMGhLZXBwVGMvMUpjUlZO?= =?utf-8?B?N1pBZGRFYnNMUjZVS3M5TUhQYmVyZFpLc0QzdTVVdW5MWjh0V0plSCt6bkNT?= =?utf-8?B?bVpFSTlkWUhHVG9McHYvZEtKSTQ1OTNQVEU1dlRIdHAyNGIxeWtRSzE1cC9q?= =?utf-8?B?bVBzcG1vWnJyR1c4U051RWVqbzBTS0o1OXhtV0tYckpOeGIvblFzTjVGc015?= =?utf-8?B?OVBuenV6UFFhRjJvODBTejZnVUpPdjdjYVJHQzVlS05WWG1GSG5RWnpncUxj?= =?utf-8?B?bTBuL0t3cWdsQ3FXYUJ0K2VHSE1vMzkySkNZUWtIZ1o2b1ZOOWF2djh3SEFk?= =?utf-8?B?VjY2dUZHTWZ0NWVjMm0yWWFFanJaTE5PdUxJUmkwZ1JCeVJ2NERmMnkrenlx?= =?utf-8?B?Qi9RL2VXMkZINDJ5Sk9XNWc2Rzd6K09iSkZpSUZsZEpEWnJienA4aHpZQzd3?= =?utf-8?B?QW9kT3h3V2NvS2FVN0QyRVZ5TWQwak8wNThoa2lxbnh5RDBYaUgvQlI2Nnhn?= =?utf-8?B?NFEyazJUd3FsR0c4YWtuRmpwWVFDSm1RV01ucXovcUhTYVlOVUFNbGQ1dk56?= =?utf-8?B?T1NCQ1NQaTJoQ0QvcWNSTjRlVFByVHdEQk41ZmhCNlRkODM1cUN5dEgvTnhp?= =?utf-8?Q?Wnc/e/WHoePqH+JEwXHNAjDGv?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8194e40-7f6e-4ca3-4865-08dd863c25d7 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9496.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2025 10:05:05.0487 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5yuvX8kZMZNgUSLhZUs47ZYFXayCmtBk7stncaWRObR9oYJD924Q4vBdIykTXp8EMLaAYv0nQRVRuXvMLeL9sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB9862 Remove all the goto in probe to simplify the driver. Signed-off-by: Haibo Chen --- drivers/spi/spi-nxp-fspi.c | 87 ++++++++++++++----------------------------= ---- 1 file changed, 27 insertions(+), 60 deletions(-) diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c index bad6b30bab0ecb90d0aaf603b6de5bc834d19de6..00da184be88a026bf562c9808e1= 8e2335a0959e9 100644 --- a/drivers/spi/spi-nxp-fspi.c +++ b/drivers/spi/spi-nxp-fspi.c @@ -1161,10 +1161,10 @@ static int nxp_fspi_probe(struct platform_device *p= dev) struct device_node *np =3D dev->of_node; struct resource *res; struct nxp_fspi *f; - int ret; + int ret, irq; u32 reg; =20 - ctlr =3D spi_alloc_host(&pdev->dev, sizeof(*f)); + ctlr =3D devm_spi_alloc_host(&pdev->dev, sizeof(*f)); if (!ctlr) return -ENOMEM; =20 @@ -1174,10 +1174,8 @@ static int nxp_fspi_probe(struct platform_device *pd= ev) f =3D spi_controller_get_devdata(ctlr); f->dev =3D dev; f->devtype_data =3D (struct nxp_fspi_devtype_data *)device_get_match_data= (dev); - if (!f->devtype_data) { - ret =3D -ENODEV; - goto err_put_ctrl; - } + if (!f->devtype_data) + return -ENODEV; =20 platform_set_drvdata(pdev, f); =20 @@ -1186,11 +1184,8 @@ static int nxp_fspi_probe(struct platform_device *pd= ev) f->iobase =3D devm_platform_ioremap_resource(pdev, 0); else f->iobase =3D devm_platform_ioremap_resource_byname(pdev, "fspi_base"); - - if (IS_ERR(f->iobase)) { - ret =3D PTR_ERR(f->iobase); - goto err_put_ctrl; - } + if (IS_ERR(f->iobase)) + return PTR_ERR(f->iobase); =20 /* find the resources - controller memory mapped space */ if (is_acpi_node(dev_fwnode(f->dev))) @@ -1198,11 +1193,8 @@ static int nxp_fspi_probe(struct platform_device *pd= ev) else res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "fspi_mmap"); - - if (!res) { - ret =3D -ENODEV; - goto err_put_ctrl; - } + if (!res) + return -ENODEV; =20 /* assign memory mapped starting address and mapped size. */ f->memmap_phy =3D res->start; @@ -1211,69 +1203,46 @@ static int nxp_fspi_probe(struct platform_device *p= dev) /* find the clocks */ if (dev_of_node(&pdev->dev)) { f->clk_en =3D devm_clk_get(dev, "fspi_en"); - if (IS_ERR(f->clk_en)) { - ret =3D PTR_ERR(f->clk_en); - goto err_put_ctrl; - } + if (IS_ERR(f->clk_en)) + return PTR_ERR(f->clk_en); =20 f->clk =3D devm_clk_get(dev, "fspi"); - if (IS_ERR(f->clk)) { - ret =3D PTR_ERR(f->clk); - goto err_put_ctrl; - } - - ret =3D nxp_fspi_clk_prep_enable(f); - if (ret) { - dev_err(dev, "can not enable the clock\n"); - goto err_put_ctrl; - } + if (IS_ERR(f->clk)) + return PTR_ERR(f->clk); } =20 + /* find the irq */ + irq =3D platform_get_irq(pdev, 0); + if (irq < 0) + return dev_err_probe(dev, irq, "Failed to get irq source"); + + ret =3D nxp_fspi_clk_prep_enable(f); + if (ret) + return dev_err_probe(dev, ret, "Can't enable the clock\n"); + /* Clear potential interrupts */ reg =3D fspi_readl(f, f->iobase + FSPI_INTR); if (reg) fspi_writel(f, reg, f->iobase + FSPI_INTR); =20 - /* find the irq */ - ret =3D platform_get_irq(pdev, 0); - if (ret < 0) - goto err_disable_clk; + nxp_fspi_default_setup(f); =20 - ret =3D devm_request_irq(dev, ret, + ret =3D devm_request_irq(dev, irq, nxp_fspi_irq_handler, 0, pdev->name, f); if (ret) { - dev_err(dev, "failed to request irq: %d\n", ret); - goto err_disable_clk; + nxp_fspi_clk_disable_unprep(f); + return dev_err_probe(dev, ret, "Failed to request irq\n"); } =20 - mutex_init(&f->lock); + devm_mutex_init(dev, &f->lock); =20 ctlr->bus_num =3D -1; ctlr->num_chipselect =3D NXP_FSPI_MAX_CHIPSELECT; ctlr->mem_ops =3D &nxp_fspi_mem_ops; ctlr->mem_caps =3D &nxp_fspi_mem_caps; - - nxp_fspi_default_setup(f); - ctlr->dev.of_node =3D np; =20 - ret =3D devm_spi_register_controller(&pdev->dev, ctlr); - if (ret) - goto err_destroy_mutex; - - return 0; - -err_destroy_mutex: - mutex_destroy(&f->lock); - -err_disable_clk: - nxp_fspi_clk_disable_unprep(f); - -err_put_ctrl: - spi_controller_put(ctlr); - - dev_err(dev, "NXP FSPI probe failed\n"); - return ret; + return devm_spi_register_controller(&pdev->dev, ctlr); } =20 static void nxp_fspi_remove(struct platform_device *pdev) @@ -1285,8 +1254,6 @@ static void nxp_fspi_remove(struct platform_device *p= dev) =20 nxp_fspi_clk_disable_unprep(f); =20 - mutex_destroy(&f->lock); - if (f->ahb_addr) iounmap(f->ahb_addr); } --=20 2.34.1 From nobody Sun Feb 8 05:43:05 2026 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11012040.outbound.protection.outlook.com [52.101.66.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35BAB25F996; Mon, 28 Apr 2025 10:05:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.40 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745834713; cv=fail; b=bh7HPiacELGHB0EylWJoeboraeVRXUX6meBNYfXRcQ4lUpxrahBNjR+oYE29hqLW7wF46fFPUQZMiKjULm9mM0BCGvJ5qeeJA18nUx+qSAj5JmmLV3fD0gGJ+Zc7cjq7ta4AcQJSyMIAy3+6azN4kO6rB5Kw9AVy5DuXMPis+wg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745834713; c=relaxed/simple; bh=EHGi95nTlhRjlYTPcmNSAMw5IUnu/bcxt4hNUpvsWzM=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=Gm4fIi5pvHnb+K9r6jjHOFsLnWHbYe6DRqc4Ar/8BfQhpcV3ZqA8DBciFsjH38oQtinQOPgOkw00RZ2ZQ4oqUb+bXiot5kl9rGE8QSllBPpxWo6ExsCI6ru4ffT3awmEEZad36J6aAJWV8PaUMjXGCf0leKARrG8B41SDXQMPrY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=YbWWHP0h; arc=fail smtp.client-ip=52.101.66.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="YbWWHP0h" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kiQxbB+o5fEQyXIid6A2kExeK4EfDrOXcxoXVVh+B3Mk6x778FNCpoU1+WZDkggTNMiSb4nSrtGoiGnvjqzhTP2WsdwXfUepZnpQ1zPrMic3T/aE/WtmPCQ7//X+HoRy+nfZ3+h2EufA3HcGKj93z6ZA6zWNly0U60d7kzgKhROdslHic34x6AIn5EWlL5Ej6kjbk6Bx5FVxsuQiprIIlOobuIgczaDqvMBjebw26bup1MdhXkyUV7xijprHRvhg0FKmBzJ1D1MKIjQzEpM1Q11GzHiGaBshjg79ZWDJPZesv2ZX5hqE5O75Gk/1CWUBzO9bSsou7qOEzBffzLbH1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xk5U3cUoUE0U+f3XcRp5iwBviiPiPHmZexOFQhIIl6w=; b=Z0IMX2U8Rw+h0SAq81AtDOItMWk5VUg5MfoRJDQkuiiDhYxDfYZ9rH914pJ6DRqby9h0ao6Kb6O4WF9b74noh7aHZlfWGCRwCHBZTHogv+UXAXtzpn0usp6gBctvZe7u71T3ux9iqhoPg/y/G3koPxl2d/Sp0/jQp0OWLXAWWIGBUBbdcxy8FHhVbf/RIuWjDju5+HTsNzDanHtOxcb0sv/PU+xbYaHSptXLEQOmNE/qI2sdEMtLdTPxA1ToJPxGtZMHMROF5AcmSweQzQzpHSfzPEYJ00VlXYSmmMU2CCfoo72/nc+0N45CfOMqOwAGfKN0NQHdAebr1KECmlpSPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xk5U3cUoUE0U+f3XcRp5iwBviiPiPHmZexOFQhIIl6w=; b=YbWWHP0hVhEzjjLi5AmlhgEpmUIhFn86WfspP4yX0u2q1yJ4cC+I7sdCj56TPt1GP4Z2pa+D+7mOt43bqmJbOjG8+k89aY0XHgoi5QdajOeHnomPO0tUgrCsVOM08m4A9l9eRE1KL4/MYX1fUwKIG0qIcqRgvkOVzPz4uOX2Xo7aradK7huPtkmhw68zk/sbBUAWuGgFwfZOUCIoHj+b9GQBcBno9bNUy2ZdrnlICu0EquljTYcUY0MmsVerztDAtZevivNUjXtNa77nc2E0P6d38L1xatPiG6e0jEyUwK3DAVg/YNCRBCV+VZPh8TILGUPEQx4L7muH5Dir/uPdgw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DU0PR04MB9496.eurprd04.prod.outlook.com (2603:10a6:10:32d::19) by PAWPR04MB9862.eurprd04.prod.outlook.com (2603:10a6:102:391::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8678.33; Mon, 28 Apr 2025 10:05:08 +0000 Received: from DU0PR04MB9496.eurprd04.prod.outlook.com ([fe80::4fa3:7420:14ed:5334]) by DU0PR04MB9496.eurprd04.prod.outlook.com ([fe80::4fa3:7420:14ed:5334%5]) with mapi id 15.20.8678.027; Mon, 28 Apr 2025 10:05:08 +0000 From: Haibo Chen Date: Mon, 28 Apr 2025 18:06:44 +0800 Subject: [PATCH v3 2/5] spi: spi-nxp-fspi: enable runtime pm for fspi Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250428-flexspipatch-v3-2-61d5e8f591bc@nxp.com> References: <20250428-flexspipatch-v3-0-61d5e8f591bc@nxp.com> In-Reply-To: <20250428-flexspipatch-v3-0-61d5e8f591bc@nxp.com> To: Haibo Chen , Han Xu , Yogesh Gaur , Mark Brown Cc: linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1745834827; l=5964; i=haibo.chen@nxp.com; s=20250421; h=from:subject:message-id; bh=EHGi95nTlhRjlYTPcmNSAMw5IUnu/bcxt4hNUpvsWzM=; b=2pD/NN5i0GmoG7Qt0ascRpOI89qKmY15/OI8CGLemTOLUUcdypNyPH4WcAeM0qN3RSEoRV6cP KvA4P5k/VJxAWDCp3G51djKW0BVpzMsttGTLLlhh+J0q639jaL67clb X-Developer-Key: i=haibo.chen@nxp.com; a=ed25519; pk=HR9LLTuVOg3BUNeAf4/FNOIkMaZvuwVJdNrGpvKDKaI= X-ClientProxiedBy: MA0PR01CA0011.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:80::9) To DU0PR04MB9496.eurprd04.prod.outlook.com (2603:10a6:10:32d::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9496:EE_|PAWPR04MB9862:EE_ X-MS-Office365-Filtering-Correlation-Id: 2ae302d8-5c99-4089-3a1c-08dd863c27ba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bWZpenJIVWU5bWpmY0JycjJUREZIV09JU1dIT1FSZnBteGE2UGpJY1pPdmJj?= =?utf-8?B?ZVQ2TVp4emFVZGNDSGJPU1FZaG1hMlp1bk56TzBWNHFGb1JvN0tPcEwva2pt?= =?utf-8?B?VTF2QzZTV2dmZ0JmVDF5bUtYOWpGTGxqNzdiSVNkWm14d2ZwM3ZZcHM2NWs4?= =?utf-8?B?dkZrUzNKd1VWWXJiRlVJc1RtbWRzSE1PWmVtc2FJSGRXUWtKOStXR25kQUxz?= =?utf-8?B?TFMxbEkzbjhyUEpVRk9rZFNYZm93Q0hoQUlmOHIrdGVZR2VIbGVUZnVxVllm?= =?utf-8?B?dE9ZWExXZTJmd3o0dTU3VGFnM254ZkJhaEJiSlEvYVU3eXFsdXpkbGI5Zlhh?= =?utf-8?B?RzFqYVlscnI0b2w4cE9wMVV1SjJ1NmhxbzJnM3NVamxHcXViOXh6ZGgvSXkv?= =?utf-8?B?RzI1Zk9wd1FYeHlnamNIZ0pNQmNJVGwzN1pRUHFva0xwdmRFVHlTcGRhakla?= =?utf-8?B?SUxmblVZN1BydEptaFZqOWVrSnJmMWx6bVdieDBVR2k0bXRKZ1piNDh6ckYr?= =?utf-8?B?R0lWRmpzeEUyQmorS2NKTG50b3QrVVIzNWNKLy9ZMkdUM0FXd2FNTldrZ3Ry?= =?utf-8?B?WEszVDdaL3pYWlRvcUh3RC9VendYUWE4MXp6MnFjUmoxUWMwTitnQ3JjQ281?= =?utf-8?B?YXpNUHhJalVQdkdlQU5xbHNiMU4yZ1o2d0xUeHRHcmxDV0h5TWNwdkVKZzZk?= =?utf-8?B?RG0vOUFyeDN0Y1ltZkFZbld1ZllVc0JPbGJLbXpkL2tLT21DMW81Q0pzeFUx?= =?utf-8?B?dzdzOXFwd1VYTUFoTDRZcmxVbHkrekJtWU1qS1JxaFQ1RzF1R05XajNrd09n?= =?utf-8?B?ZzJNWUM5c0xDT2d3bHJlNEdaVlVqNTErYmt2cXNzQzZiRkF3bWRIdGsxT1ZI?= =?utf-8?B?RURSOGJibjVZMitSN1d5eVIwbnFiMzRSUkJtdU1yd0FwNU9IMjhvM0NWOEFj?= =?utf-8?B?RmtSZzU0cndtVU5oOUl4a1dPNEVHd1VJOGd6dHJ5L1NKeWhjNEl3Snc2b1Y1?= =?utf-8?B?b2ZxcVZwOEFQRmZob3hxcW84STJkVno0cTVuYzNxcXZDS1pTQVN6K2k3MFkw?= =?utf-8?B?eThPNC9xbHM4UTZQYzJqVXVCU1VDRXdyTXVCTE5XVGdFb2ZlNklGOW40NFBN?= =?utf-8?B?MUdSaUsrZG1IdmN5Wk1wZmV1S1ZuY1JHVmgrWWFFbmVLYTl1enFheVMzWmEr?= =?utf-8?B?VXlMcGlUSHJ6Sk5zZ3FnK2prd3BNb1p0YSswWWJOR2NFWm1jVlU4LzlyQVJ6?= =?utf-8?B?TW54RmRoSVNoQ1QxTWVtaHFsdERiR3JMdFZZY3ZxMXFQb3JDMWxpZEV2ODU2?= =?utf-8?B?ODlMR1ErSzJaLzN5SHlITG5pSTJUd0pVNW1SNmpYZTBIMEhsY3NWUkplVVpX?= =?utf-8?B?YURLSGNwSGthcnI4TExZUEU5cjkwRmN4R3hVR2RxSlh0djMxWlpMMzl5bkxm?= =?utf-8?B?Q0RMR3N5SmhBMEhvNm1WWlRoanZzcjRMWGdsZExqYjZ4NE1VNi9WaU5GZ3Yr?= =?utf-8?B?dUx5R0lRdUFyY3FGRDFjczU0dDVaQ0xwNEV2L1A2TWErT0tXd1Y2dEtmRlpq?= =?utf-8?B?ZWxNSFdlNVdIQ2pnODdCdVYxWmJ1eGh6WGlOVHEyeUZmSnd0YzlIN2t6cVVI?= =?utf-8?B?STVmR0g1b0NzN0kycC9pMUNOdUw5NkF6T1NiQ1h6Vi95TGx2Nml3NUtjZmVo?= =?utf-8?B?TTZjeW1JR2RnUEljYUhCREk5NUhWOVhNenJxY2NZbk83QU1qSVB4ZmxlTGpG?= =?utf-8?B?V0NiU3A3NXlXdC9PNWNSUDR1R3lqVWVlcXRHRmF0T0FZTHVLYVlwRkl6eW1B?= =?utf-8?B?aXovdVdhOEdSNnYxM0cva21teGkwdW1NOTlnWVBiLy9DOWJWZjlTVE15bmpq?= =?utf-8?B?ZFBTZmxadHU0RUJaYVAzQm0xckxVUkNCZGVtaUdyRmo4NWl2SXBITm5BdEN2?= =?utf-8?B?d3lHL3VNVDN3WHdkU3ExWmVSZHptNDZIdVRRczZOcjhZWEVqUEV1WXNJbXd0?= =?utf-8?B?TTlxeDhlUnV3PT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9496.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bDVHME5WYmw3R0NZMG5aQVZXWGZHOGRsYllCZGFYdWdPOWptZGV4MlplRERh?= =?utf-8?B?M1k1QzRQR3JjMGRPWi9BUVpUSVpjdUJtK3UrdGpLZCthbVFoYVdHYlBnMEox?= =?utf-8?B?eFNUNkZHVU1DY0N2Mk1MUTIwU2RLdnJoZ09ObDU5WEpCWUtLbXp0L005Rm9y?= =?utf-8?B?YzNhaHJ1MWE1QWN4YVQzem5YZHFxWDVyV0d2NFVQbStJVFpJMmhxMlpPWERo?= =?utf-8?B?aHhqa0hHM2NqdHhlb24rRnNXQmVKbEFubDVvTW9mdjloQWl5RFVaMmoyczQy?= =?utf-8?B?RjRyMUFjREFFeFVWcitNaDJEVk00cmhNNE1LVXVCVWxtM3hoSlBySHQvUUk2?= =?utf-8?B?eDU2dkhkT1lXK1Z3ZG45M3ZBQW5qajhlVXM2Vmx5dzFlalRtU1BMaTErTE8z?= =?utf-8?B?cHJjT2FuYnBvZTV5N2dPeCtwalYxdm9ZUlA0T3M1eXRBT1pLKzFKRHZaQ3J2?= =?utf-8?B?N0RlaDluK1RsQm1ESWx6aVA5b0laZzJUeGM2cDluVWtzd2p6N05NemVPWjFx?= =?utf-8?B?R0dUQmdMenZUVUhnWUdDUGNzb3FLUVlGVVN3VmR5bnNLSkU3NHNwNzBFaUE3?= =?utf-8?B?bUc0NWxHUE91UVM1Mjh1TzNGWmtmcGpMT2tKZmpOWHBxUVB2OHFGS1BKTTFh?= =?utf-8?B?cmJMQ2pQWXNEZmd4T2hqS0ZkSEtQZXU3Sm9IcVpnWmV1ZHZ1TE5MbE1OVWtD?= =?utf-8?B?UlUza2tGMHhMQk9tWGR6TGNsd1p2djU5MHFiK3hveXltcVVQZ3NkUXk2SmNG?= =?utf-8?B?SFhOcnBMcVcwVGlkdVU5V0YwYXFEWjcxVUY5cklHdXFHVmV1ZXpUM1BQMktr?= =?utf-8?B?aDE3MXZZRnB4dHNGcmRmM1UxRUFweW40aWY0VXliMG9lc01YZmFUNis3YWxF?= =?utf-8?B?QURLR3RYY3Q1V0xLWXlRSStCUk9lckF0WGI5bFlFUkZaM1BBRGtjZnlHT1dU?= =?utf-8?B?dUVxc05KTFd3cUE0YlZxWEF4RDRRdTAwRk4vRnlJbWFVeHhsM3pHWmZna2pa?= =?utf-8?B?WjFJS0Y5MGJWT2F0Lyt5V210Z0crbS9Kb01xT21XbUdQa3o0NmZHaXd4SFVI?= =?utf-8?B?TE4yUjdJc3RpUVZOVDlCVzd1d3piQllmSE0zcDltV3VaeTFLMzkydzFpMEJW?= =?utf-8?B?K2xEYkNSbjNOck9wSzFrTmxLR2pNUllxUkJYMDYyQ2x6bzNvdko4SFJUZ29J?= =?utf-8?B?dmlaYkpSaTFuYk5PU28vRmRTOC9GbFE3K080WGh3eW9LWEY0YmdFMWRDRHR0?= =?utf-8?B?L1lFaVZVZ1NHVGJSWUNDYXVHalhaOHF6NlJLakVjT01hQy9RdWdIbzZCcWFD?= =?utf-8?B?Rnh6blJ1NWRXR2FvYmt4cGZQN3lsRTZSWU0veUhLQmVJOXZ6WUw3MXdZMlZV?= =?utf-8?B?REpKU1Z1cmVORU4vSnozWU0vTVpwSkRxRDNSRFZ1clVMeDI5dW9EemkvTGpl?= =?utf-8?B?bFZZeldqMVYreWdJdWY1TE1yWS9rcTBKZW5tN05iSERoTWNYQUpOeC84OVgy?= =?utf-8?B?NE9SdlRjdDJDZzE2ZXFwTm5ZTlVYSXZJYWxvRDZSYS9maU1RVm5oOWt1dEZS?= =?utf-8?B?Y3FuOVBKcGFxZFdUTEZWM0RPN3dEWVhLSzRlUDB4S3poZjQ4Q2s3WUlxV29a?= =?utf-8?B?Wm1NV29mUDJscXlGWlV0ZlpiblBaVnVXYW5QMlBRaVQ1VHlUaE5XRDJYMGtl?= =?utf-8?B?QmY2Y2RZdGVRMXhucEhUWXpVQlVrY2NmUjFxZXZGR3FZS29XdjB3MFJSdVda?= =?utf-8?B?RTFEZ2hZdm8wSk83czJvQ2djOFVzSDFOSVoxZDFreG0zOU00WmUwaEM2VU5x?= =?utf-8?B?SGZpeUVaVGo3MzlzeVdkZjlSSXVlVkJCR1RFTzBvaE42bW1hVFJ6TENUMTVD?= =?utf-8?B?Y0YyMnJENWx1bDFOcjhKTkovTWtmN1VFRnRlcHQ3emxhdUpoamlnWUIzVWFW?= =?utf-8?B?UWtSeTZKV1BDeDMyVDVYLzluSzlMeGZLd1RXUmkzUjI3Qm44dkQvb0hCajlV?= =?utf-8?B?VlI0cmxrSzU1QW02SEpGam9zQXBreUZqaDRlNG9jNk5xalRSNUlNWDk1QmRu?= =?utf-8?B?VzdBK0NrY2pzbjdrTlpFbGVVQ3NuWXpDL3hsdlBPV245Tjd5UUJaakFVenpl?= =?utf-8?Q?++QHGCypXI8LmV7mvpmQXR2Oh?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ae302d8-5c99-4089-3a1c-08dd863c27ba X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9496.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2025 10:05:08.1671 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ojwgNYDPm9on6awbVM59bTvd8xO70MVrFr4hCFUXMsax+DxdKh6KXQt4jfZYR8Z24h7ProB/nqetEz2h+pG9Dw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB9862 Enable the runtime PM in fspi driver. Also for system PM, On some board like i.MX8ULP-EVK board, after system suspend, IOMUX module will lost power, so all the pinctrl setting will lost when system resume back, need driver to save/restore the pinctrl setting. Signed-off-by: Han Xu Signed-off-by: Haibo Chen --- drivers/spi/spi-nxp-fspi.c | 93 +++++++++++++++++++++++++++++++++++++-----= ---- 1 file changed, 76 insertions(+), 17 deletions(-) diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c index 00da184be88a026bf562c9808e18e2335a0959e9..f7c3330a19009223cbffae8673d= 264246418e561 100644 --- a/drivers/spi/spi-nxp-fspi.c +++ b/drivers/spi/spi-nxp-fspi.c @@ -48,6 +48,8 @@ #include #include #include +#include +#include #include #include #include @@ -57,6 +59,9 @@ #include #include =20 +/* runtime pm timeout */ +#define FSPI_RPM_TIMEOUT 50 /* 50ms */ + /* Registers used by the driver */ #define FSPI_MCR0 0x00 #define FSPI_MCR0_AHB_TIMEOUT(x) ((x) << 24) @@ -394,6 +399,8 @@ struct nxp_fspi { struct mutex lock; struct pm_qos_request pm_qos_req; int selected; +#define FSPI_NEED_INIT (1 << 0) + int flags; }; =20 static inline int needs_ip_only(struct nxp_fspi *f) @@ -927,6 +934,13 @@ static int nxp_fspi_exec_op(struct spi_mem *mem, const= struct spi_mem_op *op) =20 mutex_lock(&f->lock); =20 + err =3D pm_runtime_get_sync(f->dev); + if (err < 0) { + mutex_unlock(&f->lock); + dev_err(f->dev, "Failed to enable clock %d\n", __LINE__); + return err; + } + /* Wait for controller being ready. */ err =3D fspi_readl_poll_tout(f, f->iobase + FSPI_STS0, FSPI_STS0_ARB_IDLE, 1, POLL_TOUT, true); @@ -955,8 +969,10 @@ static int nxp_fspi_exec_op(struct spi_mem *mem, const= struct spi_mem_op *op) /* Invalidate the data in the AHB buffer. */ nxp_fspi_invalid(f); =20 - mutex_unlock(&f->lock); + pm_runtime_mark_last_busy(f->dev); + pm_runtime_put_autosuspend(f->dev); =20 + mutex_unlock(&f->lock); return err; } =20 @@ -1216,9 +1232,14 @@ static int nxp_fspi_probe(struct platform_device *pd= ev) if (irq < 0) return dev_err_probe(dev, irq, "Failed to get irq source"); =20 - ret =3D nxp_fspi_clk_prep_enable(f); - if (ret) - return dev_err_probe(dev, ret, "Can't enable the clock\n"); + pm_runtime_enable(dev); + pm_runtime_set_autosuspend_delay(dev, FSPI_RPM_TIMEOUT); + pm_runtime_use_autosuspend(dev); + + /* enable clock */ + ret =3D pm_runtime_get_sync(f->dev); + if (ret < 0) + return dev_err_probe(dev, ret, "Failed to enable clock"); =20 /* Clear potential interrupts */ reg =3D fspi_readl(f, f->iobase + FSPI_INTR); @@ -1227,12 +1248,14 @@ static int nxp_fspi_probe(struct platform_device *p= dev) =20 nxp_fspi_default_setup(f); =20 + ret =3D pm_runtime_put_sync(dev); + if (ret < 0) + return dev_err_probe(dev, ret, "Failed to disable clock"); + ret =3D devm_request_irq(dev, irq, nxp_fspi_irq_handler, 0, pdev->name, f); - if (ret) { - nxp_fspi_clk_disable_unprep(f); + if (ret) return dev_err_probe(dev, ret, "Failed to request irq\n"); - } =20 devm_mutex_init(dev, &f->lock); =20 @@ -1249,29 +1272,70 @@ static void nxp_fspi_remove(struct platform_device = *pdev) { struct nxp_fspi *f =3D platform_get_drvdata(pdev); =20 + /* enable clock first since there is reigster access */ + pm_runtime_get_sync(f->dev); + /* disable the hardware */ fspi_writel(f, FSPI_MCR0_MDIS, f->iobase + FSPI_MCR0); =20 + pm_runtime_disable(f->dev); + pm_runtime_put_noidle(f->dev); nxp_fspi_clk_disable_unprep(f); =20 if (f->ahb_addr) iounmap(f->ahb_addr); } =20 -static int nxp_fspi_suspend(struct device *dev) +static int nxp_fspi_runtime_suspend(struct device *dev) { + struct nxp_fspi *f =3D dev_get_drvdata(dev); + + nxp_fspi_clk_disable_unprep(f); + return 0; } =20 -static int nxp_fspi_resume(struct device *dev) +static int nxp_fspi_runtime_resume(struct device *dev) { struct nxp_fspi *f =3D dev_get_drvdata(dev); + int ret; =20 - nxp_fspi_default_setup(f); + ret =3D nxp_fspi_clk_prep_enable(f); + if (ret) + return ret; =20 - return 0; + if (f->flags & FSPI_NEED_INIT) { + nxp_fspi_default_setup(f); + ret =3D pinctrl_pm_select_default_state(dev); + if (ret) + dev_err(dev, "select flexspi default pinctrl failed!\n"); + f->flags &=3D ~FSPI_NEED_INIT; + } + + return ret; } =20 +static int nxp_fspi_suspend(struct device *dev) +{ + struct nxp_fspi *f =3D dev_get_drvdata(dev); + int ret; + + ret =3D pinctrl_pm_select_sleep_state(dev); + if (ret) { + dev_err(dev, "select flexspi sleep pinctrl failed!\n"); + return ret; + } + + f->flags |=3D FSPI_NEED_INIT; + + return pm_runtime_force_suspend(dev); +} + +static const struct dev_pm_ops nxp_fspi_pm_ops =3D { + RUNTIME_PM_OPS(nxp_fspi_runtime_suspend, nxp_fspi_runtime_resume, NULL) + SYSTEM_SLEEP_PM_OPS(nxp_fspi_suspend, pm_runtime_force_resume) +}; + static const struct of_device_id nxp_fspi_dt_ids[] =3D { { .compatible =3D "nxp,lx2160a-fspi", .data =3D (void *)&lx2160a_data, }, { .compatible =3D "nxp,imx8mm-fspi", .data =3D (void *)&imx8mm_data, }, @@ -1291,17 +1355,12 @@ static const struct acpi_device_id nxp_fspi_acpi_id= s[] =3D { MODULE_DEVICE_TABLE(acpi, nxp_fspi_acpi_ids); #endif =20 -static const struct dev_pm_ops nxp_fspi_pm_ops =3D { - .suspend =3D nxp_fspi_suspend, - .resume =3D nxp_fspi_resume, -}; - static struct platform_driver nxp_fspi_driver =3D { .driver =3D { .name =3D "nxp-fspi", .of_match_table =3D nxp_fspi_dt_ids, .acpi_match_table =3D ACPI_PTR(nxp_fspi_acpi_ids), - .pm =3D &nxp_fspi_pm_ops, + .pm =3D pm_ptr(&nxp_fspi_pm_ops), }, .probe =3D nxp_fspi_probe, .remove =3D nxp_fspi_remove, --=20 2.34.1 From nobody Sun Feb 8 05:43:05 2026 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11012040.outbound.protection.outlook.com [52.101.66.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F192125EFBE; Mon, 28 Apr 2025 10:05:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.40 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745834717; cv=fail; b=grFKUYOB5G0zfnNXDe6dx1mxrFnJ8wP08edT7iLnYqQPzimtXOAt7MJl712H7ncExMd6QMEDzXcsRbVEzlQ8uGo0bnPgSygl8jKAWdZmYnWrJy/T3V+rseAb3X1/3mKDDqsdWuwP6jZObZuK4rt2dhJlk/Lia8FmMb6i7KCH0Zg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745834717; c=relaxed/simple; bh=CN+YvT1LOIFdu7oACjSJfBPlYtPs88ub8EThrxI2rY8=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=QvtKjdCN8fr087Z534nRIPqYg4HpVF0wj5IBzsrc6jggf7lc4IgAikK261NDKvO76/p2GTHMhVah2nsXW2vrABUNPgPe0KSHZJOzASQnGBttaXFxrn3bkKZhooZQoWU160KDcsQ6pKTwNVFeJWuPBV4SYoUP4Iw3q0dO3E3lJy8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=H9I/33Zp; arc=fail smtp.client-ip=52.101.66.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="H9I/33Zp" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=alGxzVUSRMvbhy5zyEPlxx/OtJ+JfXW/qbPMmG7MUamWUjgS3WpoDRauVTHdzi+xJfe+eU4nbj11GFaN8ZsqzKn+k8cRMOGvkv3zaoGTftfStfQRv9t3l7lCE1+SO+qvccHoEJJtTVHI2/sIlAqm8jUgf1/hUK2Nfs8fq+Xk6FZ67jd9/XsVV3qSBQlnJ3qp26bQ1PHxHMrfIXCGl1XT96GBA4krXBWWFnnHm87OaUKUEE1YdB3tmEaRz3IP7QiumWWBkw8A8jk2UQST1ajEf0wMLX0BzTVRMzRhC0O3hwrmwjiArq0gsX4qkw5G449zkcJ60siB2nEg95lomtfWQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ma2Dc0LGQbYESGDWyjvQ3toRVmZFop6aP7od7bD2Ipw=; b=DTysF1KAmu75tGPTHatBtSweE7ZC5h+cxJFkLBFBp0C5jhcI4ldBeVujCtD6cjXVN8FBg3KnMiVGdcr7RTgmn8NfGbemQ7cMU5MmuCR0xUhoYwpvwsk0dycSQBYq/0b7wHfvL0DBYf1XsyRf8jMqQPjYyfREQoMld3/hHH9Vxx4jwmEPdYwELvs9OSlD5b1P7cPF8JcbILrfE8cL6J7gxmYQJDaRg5JjyZX1+egamX7YmSOWd8UyRBdat/VELlXz5xT6pFIuAncYDrS990kg11NVolhdhHJEFBMUtTq2ln0ZyWC8iC81KN4kP5V9Lwp0GjVupWmMayGtXhjljIrX5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ma2Dc0LGQbYESGDWyjvQ3toRVmZFop6aP7od7bD2Ipw=; b=H9I/33ZpXNJhS3tBydOG17DZEUbITR1kRkYnL4NvgZAxv3LlxHPpVbr+ieJqGGLVXkDtlk3skRYv8ZhIhCyxhyTPuDo8tL/kOGJ6xZIXb0UocunwPzvpWd9+NDb/Kefx5+4Beka2eCkgcXSDlIfZv51q7O7+Fu60FtBdXlVBIiofQ++LgudlksbIxY1wfxqvizAOduH+Ay2hTUMGdx3MlZkaBdig48Y/mW7q0Hghvak+p1W7TP8xlb9YRQgr1KnIxKcxvbA4zWmT2CrWB53rPmDTeJbyg0qCjvd1vYfYSDabVVPAEOY9kCK8Fn/ZScEVgBT0L4ocW2JVQRfZMDagqA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DU0PR04MB9496.eurprd04.prod.outlook.com (2603:10a6:10:32d::19) by PAWPR04MB9862.eurprd04.prod.outlook.com (2603:10a6:102:391::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8678.33; Mon, 28 Apr 2025 10:05:11 +0000 Received: from DU0PR04MB9496.eurprd04.prod.outlook.com ([fe80::4fa3:7420:14ed:5334]) by DU0PR04MB9496.eurprd04.prod.outlook.com ([fe80::4fa3:7420:14ed:5334%5]) with mapi id 15.20.8678.027; Mon, 28 Apr 2025 10:05:11 +0000 From: Haibo Chen Date: Mon, 28 Apr 2025 18:06:45 +0800 Subject: [PATCH v3 3/5] spi: spi-nxp-fspi: use guard(mutex) to simplify the code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250428-flexspipatch-v3-3-61d5e8f591bc@nxp.com> References: <20250428-flexspipatch-v3-0-61d5e8f591bc@nxp.com> In-Reply-To: <20250428-flexspipatch-v3-0-61d5e8f591bc@nxp.com> To: Haibo Chen , Han Xu , Yogesh Gaur , Mark Brown Cc: linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1745834827; l=1084; i=haibo.chen@nxp.com; s=20250421; h=from:subject:message-id; bh=CN+YvT1LOIFdu7oACjSJfBPlYtPs88ub8EThrxI2rY8=; b=8XF63ETjHThXSPIpenKYUzmaXaLQCa61ECkw9DZU6KT9IOzezMN3RyravuSxIxc+Ld8tHE99O M+yWWEzXmTXBaQkWy0dP+YdAi4qWvuE6lRjfaEU+M3/gp3Ld5EPlS3X X-Developer-Key: i=haibo.chen@nxp.com; a=ed25519; pk=HR9LLTuVOg3BUNeAf4/FNOIkMaZvuwVJdNrGpvKDKaI= X-ClientProxiedBy: MA0PR01CA0011.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:80::9) To DU0PR04MB9496.eurprd04.prod.outlook.com (2603:10a6:10:32d::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9496:EE_|PAWPR04MB9862:EE_ X-MS-Office365-Filtering-Correlation-Id: 7134651b-7350-4682-c89e-08dd863c2990 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?YVRPcVJ1V3hrR1lnUEwxQ0cxZVdtM0RjcjlucEVIS0tlQnRZMjE1ZUZNQ1k0?= =?utf-8?B?aUxPNHBoY0xBVVVpTGNXUHR2WUdCRHh0K3J1SEQ2S2xlUG13ZUxIb0kzSTJw?= =?utf-8?B?UGRCS0VwcVdaQ2tnMDZiUkUvZk5hWEozblpLbnlSM20wc0cweEZKOW1XUndi?= =?utf-8?B?RTJidzI3Z3pkVzVGVUI2aE5uZld3Zmt0YUdvT0U2ckV0cUMwY1JZUlozWWJh?= =?utf-8?B?elhwcFh3UmlBQjRUNEpWTHZ2bXQrUXcxMG00UHQ1SktHKzhlYStNQXFnYjlV?= =?utf-8?B?d29TSXpFQXMwNVA4OEFaNDFOL0dUQW1mRmpIamtpUnpicGo5Z3c0d0NVTlVB?= =?utf-8?B?NlplTmhVK1NsRjhaZzN5a212ZWxSaDdxcWtYR082YWtvU1dNd1BkMk4reldW?= =?utf-8?B?bUoxNkNKclJNcU5xdDA4MTdZUDRUOTNYUnJVSzRPNmw3aDRtaThVd0w3OFVE?= =?utf-8?B?UHIrdlUxWVFNWkJiNjgwU0pia3BtQU96QVhJSmVRTWpwZk1nUTZFRUdPSVFl?= =?utf-8?B?R0QyeTM4czlsdjF0UmZ4WWZ5R0RKZHJXRU1kYUFncFNqSTRaUmJnQTkyTEhi?= =?utf-8?B?NWVmN2JSSEQxcDZaOVIzUVJGamRjN2lDS0g3MGtJRjh6N0lTZWpEOGRkZjhn?= =?utf-8?B?Mkt0bVVZQlg4cHQ3djE4Slg3QUV0bzluVmlkVENsNjM4QlNtMGlET0pzM1lF?= =?utf-8?B?SkdRa0NvdjVrOC9FQTRVREdRbkJ3U3Y0UTRBbzB4WXp2cUVYYzl3WVZoL3BZ?= =?utf-8?B?VSs5T3VZSUJPWk1jNXhESlpsTkhyZUl1VDZmMmI1TEwxVjdBRFprYjFBNGlI?= =?utf-8?B?bXIvOXBRS2U3OU9Ec2VjTUZCeEtqeU1qOTdQRVFGTmJGQUgzazByQmVuOFJZ?= =?utf-8?B?S1l6VVdoTWtFeEV2NGdRN09pMW1xMUNLUWpZOS9yck5wMjZTMWlsQWRWNnJ6?= =?utf-8?B?Q2p3TXdlUlVhUjRkelBpZks5c2MzYmUrUVJKOUNJSERQRnFwZTVDYmh6YlRR?= =?utf-8?B?K0RldlA2OTVSSmZFZDVXVTIvL1BZSGdMN3VrYmlraWkwaXQxWEw3a3VGYmNT?= =?utf-8?B?cGJseTg0WDZBMVltSTdQb2c1V0cxOG1idlFNM0dNZDZmNkRzZXlpNXFnR3FK?= =?utf-8?B?SWJCTHVaZWkvUmVNbXEzZ2phK0VqYWRUMFdhcjdqcGJ0TnAwOWpMQlEvQysy?= =?utf-8?B?aThVWDVudGVUTUNQM2ptTmc5VHFxckdRb0lmZmRSTkZDSHh1TW9UcU9JeHJC?= =?utf-8?B?bmE2ME5HOC9jL0RqRjV5SlU5clZydkZPOEo3bUZRbHNadFVGM3MxWWs4bXpk?= =?utf-8?B?dlBQekNKRi9QTWZyaDc4VFBQSnRWRGF5NkpscmZ5K0FwcytKUStPS2thci9N?= =?utf-8?B?ekp1Z292RWlrNnBaN3JnYWN0b2RoQ2FNMUVXMlhENEs4K3N4ZmlPN2xJWXVJ?= =?utf-8?B?aml4M1UwZlB6NDJiU0J2NXVRcHZRck5aL0o5RnlXV0lZN3M4YXh6cEJvUGQ3?= =?utf-8?B?NmlLQVhxSXFlL2FJWUh4VW9BK0JjcUhGWkJmOXRNWGVpSnlLc2FoaGwxalM5?= =?utf-8?B?UUZpQy82Q2ViUkNjSjZRWC9JLzg4eTIyNm1ZZzdITi81QlErdXhBNExQaGox?= =?utf-8?B?Yk8zQXY3S1laWEhwbytTS0FlRmxyRmJScVlnUmFSTU1jUFhiK1grVi9qbm81?= =?utf-8?B?VFJTajlFalZHOXByaHgxVG1hOHZlMmlpQ1VreU04VnZISWpMNjd3QnB0QXZG?= =?utf-8?B?TEM4M2kzRytMQjkzclFqd2xlbzJicDliWVJxNERSVzFJVk1JeUdhanovVlJ5?= =?utf-8?B?OGRhRnhsWXFTL3pnRG1aNGtVVmlHRU9DU2cwd2JnUitzdDJyc3ZPQmIwcTFi?= =?utf-8?B?Wmk4NER2MnFhOXgxam1IVUZCbXhHeDl5N0xVbGNXbXd2dGQ2ZktNM1hGRzRY?= =?utf-8?B?ZklvbzFZUmJBK2pMQWMvaXVRMmRLZHhOYW5HdFBkb3FIYzJzaUp6Si94emRy?= =?utf-8?B?Zm5RalR3Y0VnPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9496.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MEFZdG9MQzR2YWl5bmJWYmJMRGY0RUFkcFVlTlpaTGZzcmxETjNwcnRZQTZJ?= =?utf-8?B?KzlxN3MvbC81dVovR0J5MWVWRTF5VzVTR1pkUFdiZ2hqZWFleXY5S0tJelJy?= =?utf-8?B?LzVFNktSS1VPWFFTZCtpYUlvRUN1ZHRlamVidHU4SHh4K1ovMURZWDRSeUpq?= =?utf-8?B?OUZiQ3NiUldVQ1RHOVAxMHl4OFA4cUhnMVl4UUsrcmtneXlnZmtlQmxIczNh?= =?utf-8?B?Y3VJRHpwbU9rdngzbnF5N1FLZThDUjFJeWJTSGs2N0ZuejdCdG1QcmJJSEJw?= =?utf-8?B?Q2IvZmRLNmRXTGczaTQzb3l1STRIVUppVGNmTXNING1rQmh1OUlYZGpxSXJu?= =?utf-8?B?dzFUUGg4cmo3WUNMeUxYb2J3d3cya0JqN3lDTk80NHRTWEwyQlVOcytZdVN1?= =?utf-8?B?cUhpQU5FUzZhaStQdXJrNHlsNDV2TzVrVGZmUDdsL0EvM0pYOVcwMWp3S2RL?= =?utf-8?B?OHFndHViOTNCRzZNQjBuU0ZXR2pkejlXaWx0TkFQaGpzMHVWNThTTVhIbjNU?= =?utf-8?B?YW1Qa2tKTC9GdXlwelpGVWRvQTJxK1NJZ3VpV3EyY1Z6c1hLbUZ3RGxZb2s4?= =?utf-8?B?dVQ4eUUzMDNCejZkTzUzSEVwRmt6NU52QVNaZm45Y3RJUjFlZ2RnS3NDN2tt?= =?utf-8?B?RmRjTXNhQi8ybmRPS0tMakNXMkVEdHRIWmtxL2VmVktyQWgvaWowd25BRjNP?= =?utf-8?B?ZTA3THlFT0VWQnFSZkNrZ2lxMXJ3ZCtVb0JRWGFHcHo2SzBtV3hsTGFWamNC?= =?utf-8?B?WjNJTHpBb0dQSy82eWROTFd5eWorM1B1T0haU0taNmZMcmNGT250Y043QVo2?= =?utf-8?B?Q2QzSkpkRDIzNjU4OWRZZTV5bkJ0TXhvWnlLRGw4cWwzbWY0REkyb0xUMjNn?= =?utf-8?B?UzdXQ0R1YzUvRWkrVUtRdDdDdkRyRVRTZ3YwN0ZYQkc4ZlMwN3ljUmgyOVNZ?= =?utf-8?B?SkJUTzhtbFlPamRock9MRkxhcllLbDRKOFBwR0V4eUIyMlg0S0NLR05NR3d6?= =?utf-8?B?bnpyTU5wRUtyb1ZFVWpMcDBad0pmOUs5WDNvejc3SG9DL1E3T3N6dHR5RzFZ?= =?utf-8?B?MjQ3ZHRXM2sxWUs3WnRGeVpQZ01hYVdnYzdmUzJRL2RTalhFaEczVW5BOXYz?= =?utf-8?B?ZFdDVVZhbmhrcm1tMkphK2hHbUdwYndvcUQ4ZjV2S05rdTMwa1RFQUxNdWtD?= =?utf-8?B?MjIzbjR5SjA5MHRVc20vTDA4dGNvVkJtL1Naa3I4dWN4M2pjVklLclV5N1Ir?= =?utf-8?B?cEJBbzc0M0JzRnRhREQ0bnUyRTVLRHJvM0JUUmtoS3VZdkdaYko5SzJScW5t?= =?utf-8?B?elFCcmZvSnhkeldjeERZWHBSZDlrZUVRN2F6UE1haDJFZGhzaEN3TG8zaUh2?= =?utf-8?B?QkZMVnVsaXZwYWE1SU95OThrdzBMeTZEOGRxWHZBaTNCVGg5dGZacXRMZWo3?= =?utf-8?B?L3M3ckxGSkM1UHBhNVpLVTNjaEE0dGtxUzVlMjluTnNCTzVXL2QzRzkvT3pH?= =?utf-8?B?OUF1U08wbU4vUElMMkNSN0ZUNXFVWGE2aSswanVkVWIzaDlyTzFHQkRiRkZ4?= =?utf-8?B?YTI4Sm5DdERqSW8zbmgvQmlMcE80SnkxbmFmVGlHVkovYlNCTGd5TFpkK3M2?= =?utf-8?B?NUtGM2tLSHl5ZkRvbTdFME9zL084NFl6RjU0Uys4dHhBdEYvbDFmY1VmbHFy?= =?utf-8?B?M3lWb2J4TnR0QWFWY0hGcWpmUHRmR3RPVjNQMFNnV0cyU2U1UHpmNEg5eFl0?= =?utf-8?B?MnVPNVdDcno5RkxSRHdMMFRma0dwWWZ1WHM0ZU03aGlNV1ZVcjU4bm0zeE55?= =?utf-8?B?dTF4Zm9jUzFva0g0VWluZDI2SG0xbEZ1b1A0S3h1RVR2NnJqWm9ubXJqbGNF?= =?utf-8?B?bXVFVWxKdDFwN0FiTUFQc1dpekR2RDUzR20wUFlnQVh6MnlBbEQwdGZBYlg4?= =?utf-8?B?R1RrNXhiM0UyUHRhQllQYkVjTjZxUFdUWnNKMldkbmx0S3Jpb2FTb0RFbEhL?= =?utf-8?B?aFZGdndIVmZsdC94N2dRNjZXeGgreFMyTENKN0s0ZTFsVklsUnpyV01pRVdn?= =?utf-8?B?VFpxS2s3bXFqeTRUVVV0SHNySkx2RmFSdjRQWVBlSVRrVWl6dUNUbFlxYzZk?= =?utf-8?Q?6M046aTF9ZYwaJ9zoXmL2zK4K?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7134651b-7350-4682-c89e-08dd863c2990 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9496.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2025 10:05:11.3493 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Pxs7pRAi5Gwao3u3NUzJ9han3muHjFScTHba5EW9FMuWo7WaYiw9oLKcGcNrKzK6beulgYj3YpzrPs32sATZcQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB9862 Use guard(mutex) to simplify the code logic. Signed-off-by: Haibo Chen --- drivers/spi/spi-nxp-fspi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c index f7c3330a19009223cbffae8673d264246418e561..ca0b51a254c15f45a9e91907900= d94d77f1d5dff 100644 --- a/drivers/spi/spi-nxp-fspi.c +++ b/drivers/spi/spi-nxp-fspi.c @@ -932,11 +932,10 @@ static int nxp_fspi_exec_op(struct spi_mem *mem, cons= t struct spi_mem_op *op) struct nxp_fspi *f =3D spi_controller_get_devdata(mem->spi->controller); int err =3D 0; =20 - mutex_lock(&f->lock); + guard(mutex)(&f->lock); =20 err =3D pm_runtime_get_sync(f->dev); if (err < 0) { - mutex_unlock(&f->lock); dev_err(f->dev, "Failed to enable clock %d\n", __LINE__); return err; } @@ -972,7 +971,6 @@ static int nxp_fspi_exec_op(struct spi_mem *mem, const = struct spi_mem_op *op) pm_runtime_mark_last_busy(f->dev); pm_runtime_put_autosuspend(f->dev); =20 - mutex_unlock(&f->lock); return err; } =20 --=20 2.34.1 From nobody Sun Feb 8 05:43:05 2026 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11012040.outbound.protection.outlook.com [52.101.66.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 180F62627F9; Mon, 28 Apr 2025 10:05:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.40 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745834719; cv=fail; b=BM6y6ddCXXS5B/SWcOfi3++lYYaoKHOrGZDFKMDU5n/ocGv0qMV6vrVim8uIAMQNzfUSCiBu5+b+AiKRzCXLpcc0kMIerYEiqXb+YI1ePqX16u+UhXZj0XkPjqjrWgMftYYvn+4AqMhCft62LL8ps45wA29oP/IvbiY36dDcgzI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745834719; c=relaxed/simple; bh=krpq9nhBfLy4zLPhr+UXTcOoYRwPWSk58aZ25kSzJU4=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=TrsK/YUNGzth2xwf3U5yPoxLtvqcirwepji8nfXpEh6hbXLYCWXP6IvaXUzDtFsXRBCZoxFQfH1C6joP4SIONh8tP1w5VoMX38ccrY2Fgqlf7Y6g5+fyAKiYWxZIFHsX/hjR3dx8i3u0qwrNjK9x4e5EN3Xt7UjuQ6MF2+sRTJI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=FjmBLcAI; arc=fail smtp.client-ip=52.101.66.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="FjmBLcAI" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jymGuuV9PI2vv+XiWJMx9w8CdtStvhOi+rYhdQj+/DYfHW4rIPtjQ5YtzAz2vLo333GYBM4Km1Wk1AZWAUgKkGqGCg5m4htzajDxkxQA8GDeaLFRz4f9dGSM9w58ecBmbfdoR5ztXTF7BoofhzFdL0+JQ/7p2bi50tFQek3HwjhiJdC9mlZKm69PqeIx2amG9zRxtyImiBaGaLdzSWmOgP212wwpLwwyjVSSlphTb44QvA4il3O+z+ra/XTAff5NRzQBLj+xbXTzXXCBik2fR9H0BkO6wyBACHKhqKKUXBExlNbBkbXywErHzM6nlN+3f3dEX8WWuGePxG5NsZPrqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2FR9ammIYrrwyCJlXxuYqT6sm/P/vU4f/u5CjUy3df8=; b=G/8/Ut235GDXea1My+fTQfCsAvz3I36abJu2E7wLiVKQo7npRNh6aJUbivt0TOvLdxPyEW2tGfxNwF1NV5mkHX+Kyu9CSfomO3eTWGv4JNnKcQANvjDUkuSuwcrVGQR9xj6usSSa/fU8wVnyRhH+oiQECF3zVc38NUF9ZFBQaSMF6rLHNDNHdp7ZdO5mpp0d1zZpH/pigF7qCTjnhWSShF50jnAj8kB4VpjqhP8E+UAzgB9nHgRsc+Wg7nqSxVrQiER0YWVkGm/6S4/KAdMlpqkDn1Sxiqm9W3McDdYbXype8eoDnrmZZS+rujR1HpzuXh2/ffRr71etSRbzz6ktxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2FR9ammIYrrwyCJlXxuYqT6sm/P/vU4f/u5CjUy3df8=; b=FjmBLcAIaCHG1Jc6qne+Hl1ebQTbBer2VYsyoV0OUOvsy1d7foSAhwzADmA8+pY5wZIf71Sc6e9+JNet5ft55viM3dgulSmF7fZiD8vrD025/M6ZG4LfE6acX7gpHBDT++K7yX5YhC++EIOckfg/wsaQxkeFS/g5Idi+e7ev1newNiCCFwV+RKj7wwZyICoDIRt/EeX1sL7u4zPtG5COTV0CTuXkAIG+HJktvhGQQZtgubvX+/RHp+zcWaVOxKtqgRZbjRqi5oBwVfPiiXgCnheS6qidIce5eOuSTjenqmlBzEJzzpsUCMoCjPWEvUV//gykBlMvpRfVfbAjvMjhfw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DU0PR04MB9496.eurprd04.prod.outlook.com (2603:10a6:10:32d::19) by PAWPR04MB9862.eurprd04.prod.outlook.com (2603:10a6:102:391::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8678.33; Mon, 28 Apr 2025 10:05:14 +0000 Received: from DU0PR04MB9496.eurprd04.prod.outlook.com ([fe80::4fa3:7420:14ed:5334]) by DU0PR04MB9496.eurprd04.prod.outlook.com ([fe80::4fa3:7420:14ed:5334%5]) with mapi id 15.20.8678.027; Mon, 28 Apr 2025 10:05:14 +0000 From: Haibo Chen Date: Mon, 28 Apr 2025 18:06:46 +0800 Subject: [PATCH v3 4/5] spi: spi-nxp-fspi: remove the unchecked return value for nxp_fspi_clk_disable_unprep Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250428-flexspipatch-v3-4-61d5e8f591bc@nxp.com> References: <20250428-flexspipatch-v3-0-61d5e8f591bc@nxp.com> In-Reply-To: <20250428-flexspipatch-v3-0-61d5e8f591bc@nxp.com> To: Haibo Chen , Han Xu , Yogesh Gaur , Mark Brown Cc: linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1745834827; l=966; i=haibo.chen@nxp.com; s=20250421; h=from:subject:message-id; bh=krpq9nhBfLy4zLPhr+UXTcOoYRwPWSk58aZ25kSzJU4=; b=BMS1sYs/om34v1q537xQSzogKrQAWdMdLtaFp1/hQSeJtgPYMaZUXXbBKObC2zN3XIRBe02Zi 9xzd1OMlnBCAmQzUzum76VZ7y4grNYBZHPhwJNfAz6Q0rB6f6Dy8eWj X-Developer-Key: i=haibo.chen@nxp.com; a=ed25519; pk=HR9LLTuVOg3BUNeAf4/FNOIkMaZvuwVJdNrGpvKDKaI= X-ClientProxiedBy: MA0PR01CA0011.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:80::9) To DU0PR04MB9496.eurprd04.prod.outlook.com (2603:10a6:10:32d::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9496:EE_|PAWPR04MB9862:EE_ X-MS-Office365-Filtering-Correlation-Id: 24761bdb-ca6a-4963-ad24-08dd863c2b5e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cXY0Y042TFlVOW5iWGhiOFd6U0JEVjh2b1NRc1B4bTR1ZVZhSG1DT0dSYmFH?= =?utf-8?B?SkJWemN1OHRUSE1rZWdsMk5EQ0kyMzRqSk02RTdEd2dUVjBMQ2wveGppYzFC?= =?utf-8?B?dVNLdzNVb3cyWXgvU1JyR0NGT21BY2FucVZ0dS9SRVI2RXB5cTcxRmNGRTVj?= =?utf-8?B?RUp1M3pPaEk5VEJpTUwxbnlLY1JBSHk0eEtsL3BKWVNacG5OdkQ2My81bzFG?= =?utf-8?B?enhRSEhTYkdJaWNlcEhBbG9UY0tHTENMYlVJWUk0dDk3a0FPQklNd05XelZl?= =?utf-8?B?V09jQVQ5SytqazY1UDh6R3YwU21Yait5VDIwZ2tYbzFoaTdoU0VHd0w4TmNo?= =?utf-8?B?LzJsOEVVRVp5d2hDMFZzOEI0bHI4YndQSVMxRGVSMFpJNVYrQ0preVVyd21k?= =?utf-8?B?MElVRkRvVTZPeTRlNGFXczh0VDU1R3p5VDQ5bUo5R0hlcHVERHZMeW83R3JS?= =?utf-8?B?SnJuUXNIV0JJbFhORzQ5OE1NQ0Q4b2Y1SFJhWGx0Q1k2RjVuZE1IZFZvTkdv?= =?utf-8?B?Wkd2VEZRWCt4R2NEeDVlYy9oWncxaU8wYWxJOStRQmsyVEkraTJra0dUM3dk?= =?utf-8?B?Z2Rhc1NTV0tZUmRjRzl0RFo3RFVKNTRxRUhpelFDYXRLOTNRbXhQNlVHU1pB?= =?utf-8?B?OEZtZUVGbHhBOWRMaTRZaCthOVJwYm9WaldMRDlzWUYvd096U3JuSUFSaUdq?= =?utf-8?B?OUNERjI5eExESjlSc2pPdjJuNWNmanRmbEtHNm5MZTY2eUhtWVkrbzdUdXlW?= =?utf-8?B?ZUs0d3EwdlhWVml0Q2U1b2VqRWZYVkk5R3FhUW52SjlDVlY0VW1HbXovRWZY?= =?utf-8?B?OXhwMTcvRWtJSFNoTFE2amtQa0cxdzEwb3dWZlZBc2FweE0yenl2VGc0MElO?= =?utf-8?B?emF0MEE3SHpsWCs2aXppVk9XY1ZlV3hTZ25BK3Q1Y1FLQjVKbTRTV2toQlBv?= =?utf-8?B?VWkrNHUweUZLWXdnSENDaHRoWUJtMmpuUnl1cWptajNlaCszMXFNWkxZUENx?= =?utf-8?B?ZityWHVUUjhQRUpUcFljMmEzdnB2VWJkR0xCZTZXVkZxdGV5YWFpVFVvd1Rq?= =?utf-8?B?RktaVUhiTVh0eXNmZU1NNDhveTAyL0toT3YyRCt2UmtLTVpTZ3NBcEJVcTMz?= =?utf-8?B?YWZOMSs2cWF5aStlcHVIclN6WTZLaUNHUWFCMUVzbDYrTGptZnRLdXk1WEdj?= =?utf-8?B?blhaYUxaZTdaRGFydW5VYmN6aloxeU9oWituZzFRSEZFVzlDcUZubWIyZnE5?= =?utf-8?B?a3Q2T3YzUXRPSFl2b1RYTThPTVg5VEFVV01CZ2ltRkZHa0RrcFVPUDBKRU84?= =?utf-8?B?NENDUEJKaGRXZU5sUXRlNDRsYzh0bmNXNk1CdjBFeFRReGpMOGdKeHlncEh5?= =?utf-8?B?UExvOW9xTDFnRGlrdzVUVUZORUVrallldGNTWVFla0U5b0hBT3g2MlllYzMz?= =?utf-8?B?ajB0S3BSRzJWL1hpVVNWNjBHNEF0Q1k1dFBwenZWTjRDL0dzYXpKTmNYTDZp?= =?utf-8?B?SWY2NTJHNWFRRnB1UXdGaHhMV01CdkxMUzdydTZ4VGxCV3NZaUhGUS9kZWNM?= =?utf-8?B?QXVnMW1oNDNlTzl3eXF1V1F6Ylg0UTJGMDg2WU0yaVczSFNKUGdRVnBjWi9h?= =?utf-8?B?OVNoU2ltS0FXMEZ1cXhrQzgzQ1ZLT2g0V2oybHNZS3FPOXR6QzBIQldoVm5M?= =?utf-8?B?ajlGdnJlU0FpZldpL3VwMDlINFJkc0RCZCtuNTAydkEyVDdqckZPdU9hUTJ5?= =?utf-8?B?WmhTVmtxSjFLUE50VlJrQ2VQVlJhK3BzYmc0SXROYnNzM2VPbGhvZm01YXVn?= =?utf-8?B?aXZZZVVlQ3I4V0lXdGRxc1Yyb29OdkMwUXBmN2h5VFMzNGlJOXhuandiL0xR?= =?utf-8?B?NWtVVnNkcCtyUFVBY0t1eFBtdWRQK2dQNjN3Z2tQOFE2T0JlWFdmcWVGZ1kx?= =?utf-8?B?M0I2bmdTR1ZMZm10NHJ2eHZMQTVpRVpGQ1pHc1p2RVlJbTlmL3NJV3p1SEtq?= =?utf-8?B?cm5WaTVJYXJBPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9496.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cTlWcUNFV2tqUUhMRzh2aXhaOG5ib0diYUJRR0RVcG5xWkZGN1ZqOTFoWGJp?= =?utf-8?B?ZWRGWG9lcmc4Y1I0cHJLdW9SaWZwU1RJYXNPVzc2dlVWUzJEV29iWlVJTk0r?= =?utf-8?B?L1BuV1VoQThzdHFDUnBlbWplVERKaDljbExXay9sRUdiYjJSZmZPbXQxUko4?= =?utf-8?B?emdpdUZ0VHhIWlpzdndKWjlaMUNiMmJFRHpjSE50VUEzcDRXVExOZWlqQ1Y2?= =?utf-8?B?ZnpVSXpzWjY3YnVpeGdvZjhqRWxqRDlHaXUwNG55eGZubHN6WFJRZVljNzZl?= =?utf-8?B?TVhMTXdBWkJ4eUtpWkVsNS82dnFBbVorTVdWenlYN0hrMEZTc05TL05PdU5B?= =?utf-8?B?QkI3OG05M1Z4VFcrSW1CN3dQajdUVmEwUlp6QkdncDBMSHJIcmdrY3ZFK2Jl?= =?utf-8?B?dlN4WWYyOGxRcWljMGtJOWltTGk0c3BmMmtFS3dFZTB0ZHdoNWNnQ1RUcXE0?= =?utf-8?B?N2pScmlGbVFnaHB5d0dQTjRIM0IxbTRGUWN0elE3L0hBK010MjdLQ25lWWgz?= =?utf-8?B?UHZNanpLL2NWamRpNDE3N3l6V1kxVC9OTVNZNFhBcC9RcDVTbllVSmpnRTlB?= =?utf-8?B?YnQwdWd5eGhlR3R0ZUptYnFGVEVKOGJIeUZpRlQ4VkwxUDFEZWQxWXBmWE4y?= =?utf-8?B?M3JER2FtMVorOWc3RGRRWUloYzRGMkhZSFV1UnQ0ME1SUWJMSWIyb2ZkWWQy?= =?utf-8?B?TXdLSU9qQVdQbXFqSnZROGdpbWx1Q0t4TEtTZXJ2YU1aeVlaVmZrSm5TczdY?= =?utf-8?B?ZTRyUDVsU3ZiUzd3aVZsWWs3Y0Y4OW1SRmhta1hHWnptdHV6T3FUU2hrZ3pp?= =?utf-8?B?OEJHeE9iZTN1YVYvOU02c0NZUXRzd1E5VzVsTFRIaFdqWVZFY3JWRXpqTWZK?= =?utf-8?B?eXFEUlBkZlZFT0tCMzlwdlRVOE5GeHdvV3U4T1lDRTliNk1QM2I1L3ZUbFdL?= =?utf-8?B?UXBxMEVldTlkWENxV1ZiOEx6MWc5bnU2UFhKWXIzTkFDMjBnbnoxdktsYlZZ?= =?utf-8?B?YlNzd3d6eDJTVUN5TUxNZHR1ZmJFOWhSLzNtbHBWVnNTK20xQTZ2Mm52bjNi?= =?utf-8?B?TGtBYi9KVVVqWUJlTEtnb01oL2FpZ0V4bnpEd3d4dUJiSDNUZmY5aXF3QWVB?= =?utf-8?B?M0JieGhGYlV5aURQcGJ1TW5uRyt1dyt6blE4TkR6cVYzV2dYZW5DcE9aMFZW?= =?utf-8?B?TXdkTXNiL2tLNkVzNk9UTm8zWVE2RnNVcVNIT3F5dVFoYlRUQzZvUzdoQUpR?= =?utf-8?B?dk52Yk1pN2dhd1BHdlpaMzlmS0xQemJYV1JLaTA2bjRsZVd0ZkUrbWZXVzhJ?= =?utf-8?B?Zy9mWUlXUTVvbkdSQ3dxUEVXQmd5UElubllKTCtReHpjLzMrWDJKcytPWGpO?= =?utf-8?B?bFcxeUx1ODB2VURDdVJtSnJubzlSQ3YxWEJub3FoN21SbnB6ckV1TU5MelJy?= =?utf-8?B?dXlaSW80MGpXdFA1UmZQZm1vQjBLZ2E4RmRPdDJCcUY1UkU3VTFrSkNERFJQ?= =?utf-8?B?MW5uaG5lZXBDdzcrYVVHR2VEZktEN1cwRkVubS92ZkQ5RUtjME1DNFRyQUJX?= =?utf-8?B?aXBDN1hERFd5RXVDb1RuVXpta2hJd21sZzdnNjNad2JsKzVaYlNpVDZpYm5o?= =?utf-8?B?eGtFcFdyUENlQzZwVHF1a3RXanlDS3BOcGZzRVpjOG1BdFAzY25RenJvMThT?= =?utf-8?B?SUhFTEhiZER4bU1QZzVwZjFjNERrcmZtYUF5Y1pGeE1WUDdjWThvWllpV2Ey?= =?utf-8?B?NTZFSmJYQ1R2T1YzdnBDMGQyTkN4TWpJazk3L3VTVU9qUHp2THRlWXU1aUtp?= =?utf-8?B?eWNRM0d0UnFZclM2UVBvOHdYYlpSYzJqaFhBQVJyaCtqb1RhaG5LMTlqMWtH?= =?utf-8?B?TFJCMWxqZUFyL1dvYlNPVTZBTGhQeWlsZFAweFJGQTc1eWRkNUl6U2UvZkI0?= =?utf-8?B?TW1CeldMNWcrVzhRbGoxdnROT1JsUEVWTXV1YXlHOUxYTXJJTGMvUk5RMzVT?= =?utf-8?B?bi80Z080T1R2UGdpU2ZCUmQzSk81OUNrNUdLOXF0Z2xGWFBtQzh2OHRxYXFq?= =?utf-8?B?U0FrdkFwU3Rrcm9UR3dpTElRNXJXYUMvcVd2eWFITFN5aWFsQk5hczhnckll?= =?utf-8?Q?w08v5mx1961UDcv1i2JsLWcjv?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24761bdb-ca6a-4963-ad24-08dd863c2b5e X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9496.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2025 10:05:14.3921 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qID5QG3vR40RpjJDUw619pH+XFAAaC/d4xjXL3YHxi3fyoIxfpNcpQD6MPOUuCgamHek2bcIfb/t7jnkcZijpw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB9862 For nxp_fspi_clk_disable_unprep(), no caller check the return value, so remove the unchecked return value. Signed-off-by: Haibo Chen --- drivers/spi/spi-nxp-fspi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c index ca0b51a254c15f45a9e91907900d94d77f1d5dff..0ea04e77a968b9c8dbd73a76984= 022a8f9e9b178 100644 --- a/drivers/spi/spi-nxp-fspi.c +++ b/drivers/spi/spi-nxp-fspi.c @@ -634,15 +634,15 @@ static int nxp_fspi_clk_prep_enable(struct nxp_fspi *= f) return 0; } =20 -static int nxp_fspi_clk_disable_unprep(struct nxp_fspi *f) +static void nxp_fspi_clk_disable_unprep(struct nxp_fspi *f) { if (is_acpi_node(dev_fwnode(f->dev))) - return 0; + return; =20 clk_disable_unprepare(f->clk); clk_disable_unprepare(f->clk_en); =20 - return 0; + return; } =20 static void nxp_fspi_dll_calibration(struct nxp_fspi *f) --=20 2.34.1 From nobody Sun Feb 8 05:43:05 2026 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11012031.outbound.protection.outlook.com [52.101.66.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7997262FF9; Mon, 28 Apr 2025 10:05:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.31 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745834724; cv=fail; b=P1I06rN/m6wvICgFq3iGhsGSA386BrFtJaxhfFpcl8HBPKXqhLvB2jfqHwurwJdeWR+3l2VRMK/IP5GHHYhJH8yc4TLVsU2kNY45lsc5B2vTgLK8E47D5/suMuOAMwLyYI9o13KQcmpDFM5HppuYNepBLNzjqzZA4lXuWHvcL5w= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745834724; c=relaxed/simple; bh=irZFSSYx/TvKG4jJ6voT+6bplOW3bJqw8kZoUAKk26Y=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=UJCusW9MDgIQ2dtewE32cewHXKkWFR7xQk3nst+ZWTftsfnlNZHfbLmWeAx0FyHBbdAyMIlLX956tUEPinEdMnqrSf+kbtIRWAaBPTW5nbjcX0riY544EC3KleH4XegFjQlMbrrZf5eeeLLCWP02tkbIFctGgH+kyM9YuLr+sMw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=nqc1ZUOI; arc=fail smtp.client-ip=52.101.66.31 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="nqc1ZUOI" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ShAnvj1h4g5X01cPOaRd9zbRoIEo96dM+Jn4OrZXtf3gvO7H3AVfLkWZxCyOXNJ/4dbSykBdWbA5ZmWVigdFg6aSKaCHchCtdy7d3E2wjevxSXrZWx2WdaYi7LnSAb/kyPhtqlu2OjcaHyQ9/wwd7lDEcQSjxg/hP98css+jCRwnyHaf+PZxzVTgkDIBxcrgrg+SaG7MAfBAp91v8/CGVoYifFUXGiBs4Od81BrJjQYXGrq0PSQwVLkvt40TO4xWiqsy1T+ox+wK+ke7IzaA47bW6ixjrKIRQFNz4DFAS36f8bi3vIIJlNERmrkRJOcXsYdVHuMGq2JEXSdZiSTd4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RFMmYH8Qt8INTnib5oq7NC8c1iRdxUfjfS25apuO0w8=; b=uFLOMFTuXbXZw/2aOP85r2x5IWYDjjdhGWQ6xy7rfk21BoGpzk7zs1g82AYZVKM1vyhipzdIWpxRGwiUFstw9vJqLc7x7ycMBuIiNyZ1yyj7tl4zpe1YLWaDMTCzYVV1lEtLqQMKHvSqrSqVy/KFV+u37SetERCgQdRMUBF8lgpifVcnRyQNl0dIic+dwWgXSWJ6F41t4aurVnLaO+zKKX+XWpcHit7AhGEtjIeyMA1yB57/i2wbRxzIUdMTk38hV7F+GodQxNpl+OJXOitgik8nHVH08m9b/OTa6co+TRVvM/oDDv6FqcuIT1ecil6Q5JoZMgJW2CWZnkd+CaGp/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RFMmYH8Qt8INTnib5oq7NC8c1iRdxUfjfS25apuO0w8=; b=nqc1ZUOIfdItEG0daxAYcPt+D5U/gvCxc6lau/Ix+ydifdLdXta26o6Zdg/vju3GhSaPb11GphbbEyA0U11xQFWi02BMxeXyLHX0mjZh7AtbXVUb2UzU7BFatXrQkfF2gIdRf/j1f1dVNysaWy4s1/vtoIKrciYNR10vm8+wOc5+sCE1u3Sa3hX26GA4S5jOLCQ2T0icdp4l4qFzn3gb2ggRY2AAYtYeNSpFtleHVuLzmwiEJnwWJF4V/gECmf/Wx8NVWt5ZQrNOrJdV76lmqjqoYjsr72KpCeEf4wiKzCOC1Cri4a1XlMVvIExgVgF5qW7CFixcI+FcmSdN25sdAw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DU0PR04MB9496.eurprd04.prod.outlook.com (2603:10a6:10:32d::19) by PAWPR04MB9862.eurprd04.prod.outlook.com (2603:10a6:102:391::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8678.33; Mon, 28 Apr 2025 10:05:17 +0000 Received: from DU0PR04MB9496.eurprd04.prod.outlook.com ([fe80::4fa3:7420:14ed:5334]) by DU0PR04MB9496.eurprd04.prod.outlook.com ([fe80::4fa3:7420:14ed:5334%5]) with mapi id 15.20.8678.027; Mon, 28 Apr 2025 10:05:17 +0000 From: Haibo Chen Date: Mon, 28 Apr 2025 18:06:47 +0800 Subject: [PATCH v3 5/5] spi: nxp-fspi: use devm instead of remove for driver detach Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250428-flexspipatch-v3-5-61d5e8f591bc@nxp.com> References: <20250428-flexspipatch-v3-0-61d5e8f591bc@nxp.com> In-Reply-To: <20250428-flexspipatch-v3-0-61d5e8f591bc@nxp.com> To: Haibo Chen , Han Xu , Yogesh Gaur , Mark Brown Cc: linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1745834827; l=2590; i=haibo.chen@nxp.com; s=20250421; h=from:subject:message-id; bh=7KgkJglDrufn/lmGSDkrryOQqmavlyoLMs7rvN6cm1I=; b=tJtlkLjONGR2jTwr/28TP8D1iNOIplaJLQzdzAeFnNSfPih3ZoHO9vtZOgI+yIxhsZSIj3JvZ kwc/OEMw+bcAUM5Oqqcq73d+K1WrQxNCfz7wANEcEfLDcVjifo2v3i+ X-Developer-Key: i=haibo.chen@nxp.com; a=ed25519; pk=HR9LLTuVOg3BUNeAf4/FNOIkMaZvuwVJdNrGpvKDKaI= X-ClientProxiedBy: MA0PR01CA0011.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:80::9) To DU0PR04MB9496.eurprd04.prod.outlook.com (2603:10a6:10:32d::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9496:EE_|PAWPR04MB9862:EE_ X-MS-Office365-Filtering-Correlation-Id: 0a9ad8b5-8861-4bb7-685e-08dd863c2d60 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dXY3ekc5eFVGeXRtc2h4Q3ZTbjBXcllQSHdIK08vQUt4YjRDNk5XN0I1aHAr?= =?utf-8?B?dlNDdnBiZVNYQ0x0RnpsZ2s5WFRsbnpXTVZvaG9JZFQ2Y3VQbUw5QWxnN0pQ?= =?utf-8?B?WjJreC9MZnJIMlJuRTJlcERObE9lUUtGZElnZmZoR3ZhaVlRVmdPeThCT00y?= =?utf-8?B?cDQxd3picldteEU3Yy92MTNoLzhnVC9BTVNKSm1oWnZKUnMyR2JBTlhHSWx3?= =?utf-8?B?OXhCYzdIQ0VmSWZ6L1BHODFyQUtCcHZDOG9URjFEWlBZdGFnbUJTWjF5L2R2?= =?utf-8?B?WWM4RmpVYjJFOWxTcmplNTArcjYzVVJ0WmdjM3FkOFVVemI4YTRGOGxkMUV2?= =?utf-8?B?bGp5TDNMRHN3aWlyRktpTXRZMm96aU1MeTQ1aGluOEphZWl2QXJYenk2RUtn?= =?utf-8?B?SVg4bkNWVC9ySUVlTmJEbjRNMzFpTzY1SGNXTk5teUsxWHF6MEgrVnBPeU8v?= =?utf-8?B?Ym9PYU1Gd1p1WXB2S1Z1N1h4MTRlSUk4NGd4dFc5Ti9Vak0wVDEwNVYwUjdE?= =?utf-8?B?bHg3QytqU1RjRnMxRnJEWW0rZEZpVy92SEczV3NrcmVxQzhuL0ozUnlXNFBU?= =?utf-8?B?cWM3Mm5aNzNaK2RVbnBMNGs1aUJ1aG9YSGtaS21CcWlRVmNlcEZ4M0RsSlJP?= =?utf-8?B?NVcvL3lYZ2piVWt2Q0dDTERRbksyY3FtdXQ1SmJZOWZsT3JhSGJ1NnFyV3Uy?= =?utf-8?B?QzRpbktKS0JCVlFTeXR3bDB3dnRpQUdFbU91eXBhckZCdWdOSXVpaW5XcTIv?= =?utf-8?B?RXFDUGRYcElDUjVIZWFNbDAyd2gvTnYxWTVKUDZUc1NCSUZqTUozRlo1eGZy?= =?utf-8?B?V09ZT3BKaGsxdFZ5OG1qWFJoZHdCcGgzR2dNOEZFa1hhWlF3TFJMTlpCZjRO?= =?utf-8?B?SEUyZ215cHI1aFAzSXNxODNQSjBWM0NldHJkTjFrQlBFTUhudHlXd0U2aXlK?= =?utf-8?B?WVhObUwzcExSbkZiOGkvM0RIcG9HNHAvMG1aYVRtMGMzTkk5RWRiRW91QU9E?= =?utf-8?B?S2JIQXJrQWk5TndBc29MQlhZS050a1lMaEVRYm1BOXNDQ2ZjVkpzRXRRWmw1?= =?utf-8?B?cU5TNnEvejNadlFoVitzWFk2T1dkbVlDTjZCdEI4Ui9ENFpmQTV1R3ZJVFI2?= =?utf-8?B?bmFWZkEwUUhvbU5WRmZLMkZVT1cxNWh4ZjdHMDVSTlNocENoamthTTBRQ2xj?= =?utf-8?B?d1ZGVjdCYWdMV3p2bndNcDMwMWlpUjNrV0VMd2t2RU5yWVM3Ly9CWTEraHVU?= =?utf-8?B?aFI5VnNmcHJMQ2ZCT1VrU1BITHROYjVIWDcrN1BQeEdZcVJUTE9BZSt2ZmZv?= =?utf-8?B?NU41enY2QnBSRmxseGh0cWpYMTRxVTlHZlJqTWlIOEkxQnpObUJZZ1RQM2h2?= =?utf-8?B?a0V4L1BlRUplVTZlMWl2d3plRXRFVjB2ZEE0TDJSNUpWaGVrUEhKbkpHVnU3?= =?utf-8?B?UlVobDhqOGlTNXlyN3N0UlhCL2Z5Z3hieFkrSWZjcWk5UE0vWDRESktReUlT?= =?utf-8?B?V3pNcTdJWE9FbmhadkpGRHVWOXVDNkVMUEZ4dlZRUURYU09WUVlCZzk5bmw5?= =?utf-8?B?bE8yTHNjVFRWS0FOTTJtb3Zta2l5TzFsS3dqWnZNMG1mQjdOdmNxaUlDSEJm?= =?utf-8?B?ZWxQMkdvc21MeW0wOUdROUZsa0RhQXZNWmdOVUVrWlA3d1l2QTlPWGgycEF1?= =?utf-8?B?UUVWNmdkNDRSYVEvVWdtR3p2VkVPSkdHVmJ0Vk5tRTRmRVdTVm9ERGErbVR3?= =?utf-8?B?R0dVTjZiTDdwalFzbjM4MDBLMm1GMFZub1BNT3lDQ29FRWNrOU5tUUh4aUpw?= =?utf-8?B?M3M2RU4rTjdWWk9ick1US3dBaWZUREVWc2hOUUJPajNENWpEVFAwU21PRlh5?= =?utf-8?B?eEpxbmhzWjBLQzhrTEZxNWdjaEhNT2xFL0ZhT3JUOWNVMVY2NVZOdlVxQUoy?= =?utf-8?B?Q0JmdUp2RVQ5c3p5d2kyUmplcXJBY09vcVA3MkFIMk5lODZUZUFKZ3lFZ0pp?= =?utf-8?B?VFNlbGF1WkJBPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9496.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aFFLMGRjenpvYnZKcEt5cDdoUXpzWUlPNlFiUkFJT1FHeWZ0YXkrMFgxNWI1?= =?utf-8?B?T1Y1bXZjMHdsTGNsY2NUTXNzVFMxa0Vsc0RyWG94eFBJMGNnazZUZ09PUDFK?= =?utf-8?B?eDdmWThxRThwcjJtK09RREYzTFV6aUg3bk1IVS96RnIxYVowcitpUGhmR1p2?= =?utf-8?B?OTR4V1g5UUhKdHp1MG5oY3ZXN3NXLy81UE9idzZoUS96aGIxMWI3TnQzZSsr?= =?utf-8?B?clg3Z1JRMHJJK0l2dFdjN2hQK3kvemtmT2M3ZVFIVjlNOTQveW85b0JZbXpY?= =?utf-8?B?cWo2ZnFFd1hYcVo5MUlnZzJyc1pzYVRaTi9kbzYvK2p4SmI5RndScytxV0U2?= =?utf-8?B?SlFIZVBDOTl0bEk0T0lVVStya1NtWmVmRElTeFVsNHFVS2NNRVBsNjR3QVln?= =?utf-8?B?V042QjYyRUJXb3FFQUtOa1l1NEJLbUJ1cCtDUi81M2l0VWgzUWg1b2RDbURy?= =?utf-8?B?ZTVVdFJ6Z3hidjBKZmtaQk9RTWU5UjV6QmFsSEdyNm9PWTBneWNueHg5bmpl?= =?utf-8?B?ZEtvd0hjLzd2WmYrR2NHdmg2cjBrY3hMa1Y5SnJienhFQlpiN3Uxa3RKZ2J5?= =?utf-8?B?N0tSUzZWYnA2dzFkM2JRUHJ0eWNOR2xQUHRacTlrK0ZYdnkvRU15NkJEZWw3?= =?utf-8?B?bzN6Z2trVERxRTZ5ZHhBMW1YZHJFb3hLb256dEpWeFhOWWJKUEhsSUdmcncx?= =?utf-8?B?clhRT2FVRUdIR1ppTVliQUl3V2xjZUxUb1lOWjM4VE8yTWc2aGhNZXN2R2Jn?= =?utf-8?B?MnlDd01oYVlNVzhyVzBwTFNqKzl6UnB4WDUwbnJMRTQ1MkJNSitTRExkRFpn?= =?utf-8?B?M0p4cEFNcC94aEZPRkY1amY0NS9FUmU0aCtyL2xEZGdYdkhBbEtpcnNYazA2?= =?utf-8?B?ekxpK3pWWCt4aFlQVW40bzNzeHU4dno0aVhHZ2l4dEdxcTlGYlQyZElFL3E3?= =?utf-8?B?RnhZNkFpQUE3bGlkQnhuU21rOU1odFR3dHg5U0NXRGE2c0ZGSWhRWktZdjBK?= =?utf-8?B?bEJ4R3NqVzd0WFRjSVBzSEFPa0gzdUhIZjRxbkVVTG9Gd08vd0RZZU9EdGJ4?= =?utf-8?B?bkZFNlcreVltdlNLc0p4NTFXaDF2Qy9wLzBPNHJSN2U5S0ZQelROWThoTlBT?= =?utf-8?B?cGJpRWtjMDdZbCtqRUZPd1dCUkc3akdsU2FJU2NmM2RHRkE3bG0yaE4vRm5l?= =?utf-8?B?aGUzRit1NVFyNG9RZmsraWpmajRiS25uMUthbm1kdFRJRC9sMjRNNzAvby9s?= =?utf-8?B?VkxCeDYyQUxFb0xBUURQb2JnVnFSeXFkc09xRTZEQjMyMjgrdTBJNEtpSFRu?= =?utf-8?B?RU56cUcrcllBNk9sYVdPTHRSZ2FTcXVoM1NHZ2N6NXNtZ1N0Y1VmcUdSQUxK?= =?utf-8?B?c1EzK2gwRFpvbEhnK2VmVVk3TjRPd05JL1VwaG9DWmFDaHh3SmZBMm0vcVlY?= =?utf-8?B?dXYyUUVycTAySzMyMVlHTVRvNzVRTzg5TVI5VFdGMEo5OG9PUnRUbkNRZnFD?= =?utf-8?B?VGNxNlpCbWlhWDY0OW0vR2N5NzYyK1VEcDhLSGRmSDhlV2s2K0R5c1hzLzNm?= =?utf-8?B?eHh0R1R0SUtiMUNXbDYrR291UDd1RUVuYW9QdGxzcXRpaHMvaStLQmhFWmty?= =?utf-8?B?WjRCdEVpeFR2ZUlxL25HeDZXRlAyY2xKM1dFOUtoU2pFWnVlcGZxYjY4T3ha?= =?utf-8?B?RWRjc2ZQM0pUem5mOTd5Rlc3NFhCS0o4VWpCdndzSVg3RlJqTHQrRk5mNkQz?= =?utf-8?B?VnZLcnJFVG5OWWhha25PQXRid2JyMmUxSStqMzB1ZGtZT0hRdnlheXRNSjJR?= =?utf-8?B?RDVXdWVadGVsY3pTN212ZlQwNmhMOUdLSXQ0d1FwcXRxZUJCZzB2Yk4xc1Y1?= =?utf-8?B?ZTVjazlRaTVJSTMxRkFjd2JuRkZoMmwyaW8xMklYZEpsT1VzR3BXcHp3dFVC?= =?utf-8?B?RHVKS1VyMkdsYlBiYlQ5cC9rd1NJTHhIZHo2QTBGMTJxTUtaczkwTUU4eVpF?= =?utf-8?B?N3JSeHZtLy9LdWpjZUN2Ti9Uc3dHOFRhM0Z3ZURoN2Jxbm9vSjl2YVltdkdl?= =?utf-8?B?anp1SlpnZXhZdmM1Y1Q1V3N6ZVJwUlVWcnlEZFNnNVpTdWkvSXBrZ2d5Z0dW?= =?utf-8?Q?El2OieGeVLmpyMVFANZEm2VDY?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a9ad8b5-8861-4bb7-685e-08dd863c2d60 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9496.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2025 10:05:17.5379 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lQRwylI6uFGZxnp4Ahah20/iqlbOqHCCs8ncQc4BrBVLFN6Ocul5ZQT9a0TtVvGygiXgjqDY/FAcZsLjo3eOkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB9862 From: Han Xu fspi driver use devm APIs to manage clk/irq/resources and register the spi controller, but the legacy remove function will be called first during device detach and trigger kernel panic. Drop the remove function and use devm_add_action_or_reset() for driver cleanup to ensure the release sequence. Signed-off-by: Han Xu Signed-off-by: Haibo Chen --- drivers/spi/spi-nxp-fspi.c | 41 ++++++++++++++++++++++------------------- 1 file changed, 22 insertions(+), 19 deletions(-) diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c index 0ea04e77a968b9c8dbd73a76984022a8f9e9b178..e63c77e418231cd0698ffb73eee= ebfbe63cc3065 100644 --- a/drivers/spi/spi-nxp-fspi.c +++ b/drivers/spi/spi-nxp-fspi.c @@ -1168,6 +1168,24 @@ static const struct spi_controller_mem_caps nxp_fspi= _mem_caps =3D { .per_op_freq =3D true, }; =20 +static void nxp_fspi_cleanup(void *data) +{ + struct nxp_fspi *f =3D data; + + /* enable clock first since there is register access */ + pm_runtime_get_sync(f->dev); + + /* disable the hardware */ + fspi_writel(f, FSPI_MCR0_MDIS, f->iobase + FSPI_MCR0); + + pm_runtime_disable(f->dev); + pm_runtime_put_noidle(f->dev); + nxp_fspi_clk_disable_unprep(f); + + if (f->ahb_addr) + iounmap(f->ahb_addr); +} + static int nxp_fspi_probe(struct platform_device *pdev) { struct spi_controller *ctlr; @@ -1263,25 +1281,11 @@ static int nxp_fspi_probe(struct platform_device *p= dev) ctlr->mem_caps =3D &nxp_fspi_mem_caps; ctlr->dev.of_node =3D np; =20 - return devm_spi_register_controller(&pdev->dev, ctlr); -} - -static void nxp_fspi_remove(struct platform_device *pdev) -{ - struct nxp_fspi *f =3D platform_get_drvdata(pdev); - - /* enable clock first since there is reigster access */ - pm_runtime_get_sync(f->dev); - - /* disable the hardware */ - fspi_writel(f, FSPI_MCR0_MDIS, f->iobase + FSPI_MCR0); - - pm_runtime_disable(f->dev); - pm_runtime_put_noidle(f->dev); - nxp_fspi_clk_disable_unprep(f); + ret =3D devm_add_action_or_reset(dev, nxp_fspi_cleanup, f); + if (ret) + return dev_err_probe(dev, ret, "Failed to register nxp_fspi_cleanup\n"); =20 - if (f->ahb_addr) - iounmap(f->ahb_addr); + return devm_spi_register_controller(&pdev->dev, ctlr); } =20 static int nxp_fspi_runtime_suspend(struct device *dev) @@ -1361,7 +1365,6 @@ static struct platform_driver nxp_fspi_driver =3D { .pm =3D pm_ptr(&nxp_fspi_pm_ops), }, .probe =3D nxp_fspi_probe, - .remove =3D nxp_fspi_remove, }; module_platform_driver(nxp_fspi_driver); =20 --=20 2.34.1