From nobody Fri Dec 19 17:36:13 2025 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BDF3199920 for ; Mon, 28 Apr 2025 10:07:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745834832; cv=none; b=ncQqHOuIsKTlN7E4IFVgNDwvB7gTJVGHSINrYhW99BucZwKd79l3E++Z4Ca9lQzEzgWXV2cv6zlQFMsVpRtdFmkIHE9t+lDOGJancxrURxvaCRTGy8E0o3W3sDgU5lnteTR/ghX1NmEqtCag6slLidbVw8wPMf+V9B1JFrzNiFY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745834832; c=relaxed/simple; bh=YRE1k1adoOCNyd6S0WHYWILGjmtkWL6YcPiVGQgrvZE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MbYADW/NnGQVUd5SRBJXp+L3WCfqa59pVKdeZkx7P2z+kqeR5tN7IiO1E8ex3GnOa/tGP1ushlHR3Qm9kwwYcYR00QHnHz0glDSZv/yA1nTXrMiyFcj/GXplACU84FPPYqIFXAt6/XEKiGWN1dHiK3shuNO7i4o2LyArpR+jWaE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=iVkPT6Td; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="iVkPT6Td" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-39c1efc457bso3210212f8f.2 for ; Mon, 28 Apr 2025 03:07:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1745834828; x=1746439628; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=TCKZsecEX6Ld2qZsGyGZSuc7vOgiiSySXxmlfVWnYVQ=; b=iVkPT6Td5PRbKwDPTVYJi9dw0Gc10SSNeoWivzjaJL29Uz49eG3aGP9pOhPnKGrlyz +yf1cDir7/4nAlwGZhkXjH5FwjvyWlm9HZ/jlhqB4r0WULzqz32N3DfPOe0WL1W/Ef7a FTWFe07Nx6VQvONLDyVyhCbNWYzTT0ees0nfezi5Hyj4n/QdDu+k3vXZyRILwQvtKdNS 6k9eaQsr5xPfUH+UIOtxwriRlA3/IttLxo90vhVuJI2RMfahQnx8AXY0/C9xZkvvtbnH GWEdgKAL42WWrKFrDLmimkUKkImuKuG+3cs6l8Gki1r7GZf3aQ5uUiQErTl0dZjZcPsY 0Urw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745834828; x=1746439628; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TCKZsecEX6Ld2qZsGyGZSuc7vOgiiSySXxmlfVWnYVQ=; b=jMD67fjD9e9XIVE7YyM3wMuQ858H8onqxADmUIMfmzMAWhvMx532m7091USAfnnxpB 6cIfx4a7eN9FmXbs8vTbik1iStP02ODnngCqC9FtDpMyHgVGxI4umaQ9C11WcBSKJpwA fI1ibIPpJs/mpsGGt0Y3fXsVWTY1D5pmw9IlUYLZWnf1Vd1EtV4pE8XCCPlfumNg8TJd PG1yaWD+P/XdoTzGQOzkXksBARqBXttFm43BPjBPjwxM8nE/feJ86FLE5ZmwDRPgCz90 VvnKMIcfXmueN0vzSu1fJdv782QlCCmu1/Dej6U/JnGaB3cWdw4ji29ygvpKcYfHsTdH 7qJQ== X-Forwarded-Encrypted: i=1; AJvYcCUTQ01xkphwnjOwLU9/oO6RERHtFUKjI1FIebKNN0vCWwz/JZOSqLvmoqFRj2IZaDZMOWFxmqoxWwHOrYQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwsmtjHKPCwQxPZ2HPHYkTg0OJE+I/wUhQ3cz22Jf+lzDoXXEFq YfhaKGYq6DyJG6t6bIPxFMY932cYlvDDt5kRcFGKOlEAMyYLWXALOucyu17FvaxovL3Dmw+Z1Vc cADU= X-Gm-Gg: ASbGncsFRQCwUK/OOVBAf113wIHB2RYTtrNhStnJBpjLYPNgy9BzQaF4bjFcZccqUpk ocr/PMG6F2TopdbSR4558ZRD3xcrIaqXE1s4yo9xCUuVc/kPCW0Bz/Ojvg2+6EajpK3dlLE6E+I MwoEhvNUD95aDFQt83jj4j7GCUMMbWr6pghJat8JA6IVcKGMujaPQ6WZO8kKTWIKDcUkL1G3ggi wWDEpiv/OoH9JsB/Rm7ZQLFCMV7Tjxt45XXbYyOjMe+koYJVZg0mj2OjTsXLmqrZV1tExXhE5S6 TqIFU2kytVi1XDb3LmhXNKH6dNStjTZcVmldIW07nej1FUvgPzaTnZC6py9pAQez6OeIf20uqJd kEyil X-Google-Smtp-Source: AGHT+IExS4NUA31fzSOzXsYxBs7XcMFI7Fz4FM0MrAeJpEq6AepdH4YfqTLeZCcONOMt1wdwq62FtA== X-Received: by 2002:a5d:5f44:0:b0:39a:ca0c:fb0c with SMTP id ffacd0b85a97d-3a07aa7594amr5828489f8f.28.1745834827701; Mon, 28 Apr 2025 03:07:07 -0700 (PDT) Received: from [192.168.5.157] (88-127-185-231.subs.proxad.net. [88.127.185.231]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-3a073e5cb16sm10575403f8f.84.2025.04.28.03.07.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 03:07:07 -0700 (PDT) From: Alexandre Mergnat Date: Mon, 28 Apr 2025 12:06:47 +0200 Subject: [PATCH v4 1/5] rtc: Make rtc_time64_to_tm() support dates before 1970 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250428-enable-rtc-v4-1-2b2f7e3f9349@baylibre.com> References: <20250428-enable-rtc-v4-0-2b2f7e3f9349@baylibre.com> In-Reply-To: <20250428-enable-rtc-v4-0-2b2f7e3f9349@baylibre.com> To: Alexandre Belloni , Baolin Wang Cc: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandre Mergnat X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2338; i=amergnat@baylibre.com; h=from:subject:message-id; bh=YRE1k1adoOCNyd6S0WHYWILGjmtkWL6YcPiVGQgrvZE=; b=owEBbQKS/ZANAwAKAStGSZ1+MdRFAcsmYgBoD1NJnK4sd1o97pVIQoyWmnc8KDC1fQcBvfY289Cj q2Wr/GaJAjMEAAEKAB0WIQQjG17X8+qqcA5g/osrRkmdfjHURQUCaA9TSQAKCRArRkmdfjHURQngEA CRuk8bNa84SlGxUONMkt8pA0Ql57oaN3Jd7x4XxbAG+Mgk78AoJsR4P7n7ehv2x0/rxAXOS2p1+ero El+TVKvnM69JM7FPZQqWTIx4VoY2N0SA4/CyNWIWNYny8VG/uti5Xom1grolZdipBSQkqJOhrpB7Gd bxpx+nEXe+NZqONwPZNxIWLzuTE707HZWe17zKxHkYJWRFKa9TxsYy9LJZNCNSR97uC9OUfjRMOJG3 KICwvWKTBxxHQIW6OFJUADjovqPNpUj0NYiaywMPTVquBEhHYQe7mtW5TjjhbRJcv+ZzlG8lfC7z1N uGWmiFI6EQ4ZCPY7AGk2Uk9vObjlLrkVe4mYrn0EFlHkbBFqXlurxlxqJrVojJVfleWxAn6qSl/Lvw 1k1odtDBgJO1r4snygC8Q+QdRfME9BVCXxNujRcc9OFLgAPwl9pTQbOVs3CwTodsnQamw+q+zkuKKe XL+j5v9WNzXiTRF8N484k+y9VdRMdEGsVuv5CvSvt668HfQN33Pqv1ClrRj2ginUVuHKa4pJ4L/xpB Cq+j60n6bbiwrFfP6i/O0AjYgYv8vR57ES0lDr1yPRSBvJ60PJdrQICuEOuzjGB2mxQXcamK/ciCOu n9CtSHgGf9WuxbBWE4C/e8Vo8IWlTKI/v6JipCCP8EL41qducKPHz8DMDHDA== X-Developer-Key: i=amergnat@baylibre.com; a=openpgp; fpr=231B5ED7F3EAAA700E60FE8B2B46499D7E31D445 Conversion of dates before 1970 is still relevant today because these dates are reused on some hardwares to store dates bigger than the maximal date that is representable in the device's native format. This prominently and very soon affects the hardware covered by the rtc-mt6397 driver that can only natively store dates in the interval 1900-01-01 up to 2027-12-31. So to store the date 2028-01-01 00:00:00 to such a device, rtc_time64_to_tm() must do the right thing for time=3D-2208988800. Signed-off-by: Alexandre Mergnat Reviewed-by: Uwe Kleine-K=C3=B6nig --- drivers/rtc/lib.c | 24 +++++++++++++++++++----- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/lib.c b/drivers/rtc/lib.c index fe361652727a3f8cb116c78b5aeea74eb90080b5..13b5b1f2046510d1a552473c441= b89e23faa6793 100644 --- a/drivers/rtc/lib.c +++ b/drivers/rtc/lib.c @@ -46,24 +46,38 @@ EXPORT_SYMBOL(rtc_year_days); * rtc_time64_to_tm - converts time64_t to rtc_time. * * @time: The number of seconds since 01-01-1970 00:00:00. - * (Must be positive.) + * Works for values since at least 1900 * @tm: Pointer to the struct rtc_time. */ void rtc_time64_to_tm(time64_t time, struct rtc_time *tm) { - unsigned int secs; - int days; + int days, secs; =20 u64 u64tmp; u32 u32tmp, udays, century, day_of_century, year_of_century, year, day_of_year, month, day; bool is_Jan_or_Feb, is_leap_year; =20 - /* time must be positive */ + /* + * Get days and seconds while preserving the sign to + * handle negative time values (dates before 1970-01-01) + */ days =3D div_s64_rem(time, 86400, &secs); =20 + /* + * We need 0 <=3D secs < 86400 which isn't given for negative + * values of time. Fixup accordingly. + */ + if (secs < 0) { + days -=3D 1; + secs +=3D 86400; + } + /* day of the week, 1970-01-01 was a Thursday */ tm->tm_wday =3D (days + 4) % 7; + /* Ensure tm_wday is always positive */ + if (tm->tm_wday < 0) + tm->tm_wday +=3D 7; =20 /* * The following algorithm is, basically, Proposition 6.3 of Neri @@ -93,7 +107,7 @@ void rtc_time64_to_tm(time64_t time, struct rtc_time *tm) * thus, is slightly different from [1]. */ =20 - udays =3D ((u32) days) + 719468; + udays =3D days + 719468; =20 u32tmp =3D 4 * udays + 3; century =3D u32tmp / 146097; --=20 2.25.1 From nobody Fri Dec 19 17:36:13 2025 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A19525E81D for ; Mon, 28 Apr 2025 10:07:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745834833; cv=none; b=NWGI2UiMiopssCTYKdWTWsDTElHmPu6srmVjgn3nhyNrrdAH4nQ8T+CTcTlrE2oUuOje45SQCfZba/RN4BUxGdlHxbfwQrD0EjgyP2F+XhKq2nxLwEN0Lc+sisj3QftJK3v5WAr1VoSVfnxhC6vIws16IjEtrhhVSbkTThj3lWk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745834833; c=relaxed/simple; bh=kCR/f/rjPnwUXRQOW/h63GEtmBoqR51fZF3et6OR15I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BICNk4zy/xvTnSOC5I4RsdbSh4Z+YSLRcYte0P64FsQAnpCiMUEei0Wd2WptEXCZFWd/5ZbxPH+PKF5KpcS/jLBLGdazxp9RMmzus7n/11yzQYvjni5KAjfwG/t/nc2dCEq+3GZLv7mXtJZOKH7bcX5NAJIo9vht3YnU8LBHzQg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=F3Xsy3JA; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="F3Xsy3JA" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-43ea40a6e98so43512215e9.1 for ; Mon, 28 Apr 2025 03:07:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1745834828; x=1746439628; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=VPm9JKBRkOxrlAiqDIHgvy9NYYBLQuJeIj/qvWByjM4=; b=F3Xsy3JAHFDE/9M6QsFovqkHVdl+xwj5fTWuhbMkYwZl58T2rKiELPp1ADezrcI+Ip W9y7RXmq0VBQiTY64sNChR071wO3ZFPiEN9Jp34o4OLb1ZF52DALNvfFVJPdwVcy+GjR FkphHlAyJ/Om1ox3VY39VCgmB6D/o4dw3faAQUgp+kOn7Z/f7jLrJpOhIqDcDkmxUC7e Wv0ntDufcHj0AGkoCLb5odooIyeHVeaKd/tMNckGEroUvabaPnvD+VrDM4VAn2AX01qh G2sUsyflGB2FyOTfM+iIlB5BRSuV65zXtldtPdTgSqNnwkCVj29R4RrzWqYbcb4kbGlC GKEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745834828; x=1746439628; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VPm9JKBRkOxrlAiqDIHgvy9NYYBLQuJeIj/qvWByjM4=; b=gc2ZE3f3mkD3UFp5o78xIvuO0aqeO2GM3r5kOknb8FXm6QbBbbjzfmjq8QtqTgD30Z bTwGQouqa2KeyDorhtnYgWe4hQ1Jh6nGP8hcpMY25/5n4GdvtJhOIT4LRhz40o5iF4BI EHnJnGVIjlrb/08Eb7/LMWJLTp3E7yT5Of7A26XN0ZXCRjAMJCmUC+o0FGsc/GPxds0Q pobtuS8lzN7dKzaPeCagdLBRWB8KFwhPdqc32zAHMl+g6V0jM/3DtsxmpV+3nI5WWxS/ XEVYW08RPia+bEKPpvB1HfkFn7OG7YfiqDV1HJcBNqrM8kuG2waBPGH45jXwd4Y/d8EC Zw/g== X-Forwarded-Encrypted: i=1; AJvYcCVF2Q1/JSMOqDXep62Bg4yeRah9bWJE6yS5qKIM23CgAvk5DD4PnhaR8rDFwViogUOTVPebcFgE4269XYE=@vger.kernel.org X-Gm-Message-State: AOJu0YwHKwiWGCXNf18+Xo2Cb2JTDzKt2ufL8W5qcEoNBrDpkXHDWhLV FR8g47JZmNoqKOAzNlfxa4mj6DkyH89jRGS8WjgHSHKra/M8S7umybpGmZodl9uVRCLhKRJ8LNs fzY4= X-Gm-Gg: ASbGnctLxEOOjhO37svWoXmA3RQoorlbyCpoLTpXkt0rYd76ySXCby9fNKPVBcUoeIU pJxAjzaW2NRpYcmibvqeyxytCn9/yyt4ib8fqJsmAOk3NbrFemK4rSQJhNnQfZY02BAnhZKmPrK mlIM7Np37rL/pqUDjqTIOHhIFTZN0MCFYpW9f1VchWXKyfpS45OXCpqfSGpmxRNH5cgdXTe3Q6E iwUJzVho/E/AmSORNihr2VKBJv9fq3BNi1HBIE5ycd9trxf7SOyJ3RndJ+JKTI5akpKtWxWbGPM imnpP1z/w/5DKmjGmwNXIPCkr7pyh5gkQCWQwpRqgDNemNzSJb0wb+v4ZEiImKcLkMofsGK3r7x vB+kK X-Google-Smtp-Source: AGHT+IHZP8kaNVF7TSsO8U5BUc7+b5K2q/Hkk8BjGxZa1xV+z2eXuos6kDphq92/vDTZ6jNhOU/krw== X-Received: by 2002:a05:6000:40ce:b0:39a:c80b:8283 with SMTP id ffacd0b85a97d-3a074e37a25mr9383171f8f.31.1745834828511; Mon, 28 Apr 2025 03:07:08 -0700 (PDT) Received: from [192.168.5.157] (88-127-185-231.subs.proxad.net. [88.127.185.231]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-3a073e5cb16sm10575403f8f.84.2025.04.28.03.07.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 03:07:08 -0700 (PDT) From: Alexandre Mergnat Date: Mon, 28 Apr 2025 12:06:48 +0200 Subject: [PATCH v4 2/5] rtc: Fix offset calculation for .start_secs < 0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250428-enable-rtc-v4-2-2b2f7e3f9349@baylibre.com> References: <20250428-enable-rtc-v4-0-2b2f7e3f9349@baylibre.com> In-Reply-To: <20250428-enable-rtc-v4-0-2b2f7e3f9349@baylibre.com> To: Alexandre Belloni , Baolin Wang Cc: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandre Mergnat X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1438; i=amergnat@baylibre.com; h=from:subject:message-id; bh=kCR/f/rjPnwUXRQOW/h63GEtmBoqR51fZF3et6OR15I=; b=owEBbQKS/ZANAwAKAStGSZ1+MdRFAcsmYgBoD1NJ4dKIwfT8PC10ae4KNPiR9XhLCOKtZ8Q65cCS Hq7l0BCJAjMEAAEKAB0WIQQjG17X8+qqcA5g/osrRkmdfjHURQUCaA9TSQAKCRArRkmdfjHURTPID/ 9smRKUXUNm4htKO++yqvQ8esFin2+J/JciDzLEgSBnf6whPb5fXA6a1FYvw8YpgRf+UaL169HAgwfz jxJaUq2Skp7+/4jjQJ3bo5rPYHZ8f4OJKUDswZkkFi8GZn2cD6vF4J1NQhvAA3M22AAOA8aqfTt6Rm L4Oqvfj7wvpi8K+VmtUwlGHWVVskDdkmrc1JcXP4XEgJfFMDWXY+3rztTtQVJ4y4gZTPtht9xaHzt0 jLcyVWXddxKzTwx2vvsFAsAbg/1TlGbPDoq1uiU8rHV+BKyyLmf0xMfMVTlKEokcIvtWb31Anr3A9+ Rejuu3pPoySXCPOBGzD5Mu9HCuuEK0vLTNmVGzpE7xfMCuaecrLu1sS7Izjr8KHdeTM3dIdks6daDg rVh+vGxTesh3iafop+g8rwlJP4ymeLRlHe3zhiYuZIXwEPlF0hSSyN3NcRerMAPf/ozl1fL9jShgCX iHAlU1a6tWAya7slhYZzfDKSC1eMCs26DQmlvh5vRYwtrBtaMD/krOmYYSt5kxZaK8VpFds9snTjqt Xk/G64Zgii4yF/x9HiERakufKwcprRw8x3GvzQLzxp54LfvTP6KokDcKA+A9YdMDpKSuqalJCtp9N9 uJ2pgvjf6byJeBK5vYL2kEMSy5szeK54qZ3Dj0VoPomM9JPFakaMBO++133Q== X-Developer-Key: i=amergnat@baylibre.com; a=openpgp; fpr=231B5ED7F3EAAA700E60FE8B2B46499D7E31D445 The comparison rtc->start_secs > rtc->range_max has a signed left-hand side and an unsigned right-hand side. So the comparison might become true for negative start_secs which is interpreted as a (possibly very large) positive value. As a negative value can never be bigger than an unsigned value the correct representation of the (mathematical) comparison rtc->start_secs > rtc->range_max in C is: rtc->start_secs >=3D 0 && rtc->start_secs > rtc->range_max Use that to fix the offset calculation currently used in the rtc-mt6397 driver. Fixes: 989515647e783 ("rtc: Add one offset seconds to expand RTC range") Signed-off-by: Alexandre Mergnat Reviewed-by: Uwe Kleine-K=C3=B6nig --- drivers/rtc/class.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/class.c b/drivers/rtc/class.c index e31fa0ad127e9545afac745a621d4ccbcd5fca28..a0afdeaac270f026734be8785e8= ed7e1272b2348 100644 --- a/drivers/rtc/class.c +++ b/drivers/rtc/class.c @@ -327,7 +327,7 @@ static void rtc_device_get_offset(struct rtc_device *rt= c) * * Otherwise the offset seconds should be 0. */ - if (rtc->start_secs > rtc->range_max || + if ((rtc->start_secs >=3D 0 && rtc->start_secs > rtc->range_max) || rtc->start_secs + range_secs - 1 < rtc->range_min) rtc->offset_secs =3D rtc->start_secs - rtc->range_min; else if (rtc->start_secs > rtc->range_min) --=20 2.25.1 From nobody Fri Dec 19 17:36:13 2025 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 064C225EFBE for ; Mon, 28 Apr 2025 10:07:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745834833; cv=none; b=EEQJFeFNrDvZJ64/KS14DXhitf8FZuYt1Oq4ELFRI9AYfo83WB/FkcBuRPLFsXI+510ugrq2enjfzHlmd7mFfO77BxNKCD/UpBzDPBYaBIcmn9c5BRnPS6BJkiChev4sx+x7as9eHpUgxgEzhvw7vJy66Uh3jjlf55sweay++qE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745834833; c=relaxed/simple; bh=ayUhcmHaTDDwhww81m9WU4TmIhIrxin8sNOxt58dFLw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qXbWuoePm7l6CGSyitOafFxB9jzbrmN6kJPnmsie4H5l8wipOi1Pu9XWxII0Ma576DPu67/NoTgJ0UY6B6BraBnsvj3v+WihtI9DIM2MTNi8oOk5jKdxzSlBKFrhTSOeXu+Pvu1zaQChTfHJS2jdfffZUsTnK6Hoi8WehsNmS+Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=r6g4TNBK; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="r6g4TNBK" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-39ac56756f6so4604822f8f.2 for ; Mon, 28 Apr 2025 03:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1745834829; x=1746439629; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=KlC4XgX6YMsadyvDt4P+GyPh7t4sW7KE0IQlVTJhz+U=; b=r6g4TNBKISFuKB0wf+yWGoZIEMg/VJEC4rv+Tl7+SZU7dLA4wto7KrfinHzBCfsqL7 QBK+bOS3U+3TeQu/TfKZA8yv1LnbrwL2IUKjiRzqpx2xVdtUJJYzls6wt/KerNaytGf0 RNFGp1miAWZCxuA6VtlMgGKmgBZ5GYPhCe038w7XhS/OTRxsIXCvpB6L0SNj6Zosw3Fn e4ABFOiiWYuiQott23AceOV3zij7XMrW5ZThQoxJunbtTAFZTS7klLBr29/+FjYa55Yk /xS5bYniZPFrSrUqvrbVMlzkCZ3XvzE4rX/KG9pcBah4uAauKHuuXRe/WFCxM6JUXpjk l7Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745834829; x=1746439629; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KlC4XgX6YMsadyvDt4P+GyPh7t4sW7KE0IQlVTJhz+U=; b=N4UYt5iiwu5cIHAY4SJVHZxkSrL8Z/tkph3MC3i9UIwy5RFe5QVdxyVyGfx/7a0gAt kyoHNjMOR+roDCV19w8BT7o3ggC9jyLjPrRW4YUFxNq5KISg5Ef+rCPQRd6zMr4J2QYN r1TddX6OTCMy3qgrA8AUN20nEJE70fs5NE+RWkfFIC30YlbzB1BJpk7kbF97WAUgax9o xOlfHsVLSJ3gSvPfplHMfxmbCxFWgHKQjNmpSh3JrozYweJT53oqb4g8g05KuycwS7jZ ZuIFv23QTnbHBNcgpNseF66DYI2HFLRorgzZNygB3KICXbD3dxJTIITY3xiarcvsTu/i 5R7A== X-Forwarded-Encrypted: i=1; AJvYcCVI56/FRDwgABxql8vC0ix7/S3J3zh1SAHHvGRT6QPcAqZCvYMwI4eQOfkbNjflXGKSTfHwU6eyk35jdBI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5Cm27s0X/euwTIE57yMxRBihooCv1YT7QtJZQtP/G/mIxwIjP bji3c/YjGHdZL04P3RavtI3iIkRkwcNtBo6uJC8hjy93KsPaBeRS9XxFdAYKCrY= X-Gm-Gg: ASbGnctJjTGtl8PiwE0y/QJ+Bjgu6xj0xqzkOn2W7bR3T7e3SDV6RwaLR/XoGAPrYyy gcVkRJGhEIg0dkQG5cq8Af2EzsMbB95LPO3fmX1ocMKYuwda1J7Ff8G+t/iKLuPBPumLXQ0fRZK 8M4OYEo2ASo8vJIWa41OTn7mQVyRu46hWkUVEYuzFYUCrvksw2ceU6/IFLltsCKlUvN6/esPPeL C2vVXATen9Mr6ENRnHWMmi6UkfuscjbcuXpI4+GvAQ1oWQCC5qv2NynjpEAJAsWJXHpaO8wb6B5 rm15FIDPnhVSQIhC0mmiyPjOwms1ntSJWZ1CwiETObQBo2YC/iAFqWPvGkswQh9cjAfiafiYamR 03l/o X-Google-Smtp-Source: AGHT+IEAqGRdEGoeVuHDiyinbhr2Ppalj3tD+HoFJFni3oTADsmywqY2MxcacwtDa7VxS8Ejbb0H+Q== X-Received: by 2002:a5d:5f4c:0:b0:39c:1429:fa57 with SMTP id ffacd0b85a97d-3a07aa5fe21mr5640555f8f.3.1745834829374; Mon, 28 Apr 2025 03:07:09 -0700 (PDT) Received: from [192.168.5.157] (88-127-185-231.subs.proxad.net. [88.127.185.231]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-3a073e5cb16sm10575403f8f.84.2025.04.28.03.07.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 03:07:08 -0700 (PDT) From: amergnat@baylibre.com Date: Mon, 28 Apr 2025 12:06:49 +0200 Subject: [PATCH v4 3/5] rtc: test: Emit the seconds-since-1970 value instead of days-since-1970 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250428-enable-rtc-v4-3-2b2f7e3f9349@baylibre.com> References: <20250428-enable-rtc-v4-0-2b2f7e3f9349@baylibre.com> In-Reply-To: <20250428-enable-rtc-v4-0-2b2f7e3f9349@baylibre.com> To: Alexandre Belloni , Baolin Wang Cc: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandre Mergnat X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1478; i=amergnat@baylibre.com; h=from:subject:message-id; bh=YkRXXHd+aLLdgJUBqxRycYFTuIReFwljKIM7TbkJxdM=; b=owEBbQKS/ZANAwAKAStGSZ1+MdRFAcsmYgBoD1NJQNZkwy20BxUQyLS1XhyX4zVIefYo6C5zJ66y IdoAB5eJAjMEAAEKAB0WIQQjG17X8+qqcA5g/osrRkmdfjHURQUCaA9TSQAKCRArRkmdfjHURcrREA CizUV7K5+sddTMzndN6oNrzfe0G8JvQ8gixpWC676Ps8MBabxC0qCb0e37JkHzuaYoUyq4Z3MAhMq5 dyTTYR1Y7bITGITz5K8d2Bbtxme8UNCaZ4vMUS+FMvTBHfjp2GYh0i9VqCeYru+d+BCU5pBEuJaC2y CYPDvruoIQBQnHMp8x9D2UYvcutq2OHCmQv6V+EkuamRERiwB2F9ragXvJmkqBsZBoXHpASJ0fmQ1c b4arU0GDk019su7VQpl7uOion9JZx6vAZkHrufQz+70HgqoyDDJQ5vg6f8ly04PrFuurBGsBsENby0 Cfb9NUWm2zG+KuFN7Ik4sWuPlg/6wFWA2eoimU2zaZ8ppxgW/yY/k6WGeEgtKN6oLRuL/1kEWAJ9u1 eC/HNiCLpFviwSRCX3p7dT+1TbiV0ZDUcg3ruj+wZ4eRPtZ0JXPARSpkz2ANJTmh8qUlg5u1cwqRxM L013WSh1xVI9KQY7LAIh+hvnRGdFEJK1ATQwNE4hhPbk4pR0rTmVHWM/lGFezV5F1YRFKH7GEEse0i vp17stqKoS2NjHh9luc9T2QSZAZNWT2hHxRc1A2a44BNMZnuJzuDlnRzNwsguQJBbZ5tG+s8cTTpQB yiadTRJSSipdA4Nftngv4dkWicgvVkETGKgOXe1FLPYXL2BjXahVOc25duxA== X-Developer-Key: i=amergnat@baylibre.com; a=openpgp; fpr=231B5ED7F3EAAA700E60FE8B2B46499D7E31D445 From: Uwe Kleine-K=C3=B6nig This is easier to handle because you can just consult date(1) to convert between a seconds-since-1970 value and a date string: $ date --utc -d @3661 Thu Jan 1 01:01:01 AM UTC 1970 $ date -d "Jan 1 12:00:00 AM UTC 1900" +%s -2208988800 The intended side effect is that this prepares the test for dates before 1970. The division of a negative value by 86400 doesn't result in the desired days-since-1970 value as e.g. secs=3D-82739 should map to days=3D-1. Signed-off-by: Uwe Kleine-K=C3=B6nig Signed-off-by: Alexandre Mergnat --- drivers/rtc/lib_test.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/rtc/lib_test.c b/drivers/rtc/lib_test.c index c30c759662e39b48e6fedd37073b656e0de1336b..c0faddc04c9bbcd421cbdc030c4= a073056c6a9a6 100644 --- a/drivers/rtc/lib_test.c +++ b/drivers/rtc/lib_test.c @@ -46,16 +46,13 @@ static void rtc_time64_to_tm_test_date_range(struct kun= it *test, int years) =20 struct rtc_time result; time64_t secs; - s64 days; =20 for (secs =3D 0; secs <=3D total_secs; secs +=3D 86400) { =20 rtc_time64_to_tm(secs, &result); =20 - days =3D div_s64(secs, 86400); - #define FAIL_MSG "%d/%02d/%02d (%2d) : %lld", \ - year, month, mday, yday, days + year, month, mday, yday, secs =20 KUNIT_ASSERT_EQ_MSG(test, year - 1900, result.tm_year, FAIL_MSG); KUNIT_ASSERT_EQ_MSG(test, month - 1, result.tm_mon, FAIL_MSG); --=20 2.25.1 From nobody Fri Dec 19 17:36:13 2025 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCF7625F978 for ; Mon, 28 Apr 2025 10:07:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745834834; cv=none; b=TPZWeEkbbpDvKzxaJnqS6T0h/vwNfNhWYDxYm8vFly7A7h/kxRn/TB3fqrq+0i8OlmBP+b0eqmu6TSQ86kcBTVff2pn75deBr3Zg21jU+oIbb5QmOBM8WRgrNCms33j1CJTmaqJ0nc+NUWZJyVt254gUvDCHLnF4+ymDV610SKg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745834834; c=relaxed/simple; bh=5BXD6w9a8/MMslajqLpys8wbsQV7bV7CuK0Yj8/oSpU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EEHWtl/dY82VJ+XkbFnLiXMGhbW/fb8hyUWdZhp0ev1tKN0r13QkJ63lNRCcCLbBDMuFmXPYo1ur2JolRGN/ZS97a0e/lw34JzrD/aW0xOE2owgtzkLi0K1uOzNkSIodXg4b50Nzq3CEfyoGMledvDuvzGqbE1iPU5RX1+dnZOI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=kYN4kj7y; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="kYN4kj7y" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3912fdddf8fso3588465f8f.1 for ; Mon, 28 Apr 2025 03:07:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1745834830; x=1746439630; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=cF2oeErd2f8CMpAQYPghRdhYfeau0GOqbG/tEe7jF1E=; b=kYN4kj7yQ8sDx58ANKKu/BoWRkE1r5Fsqikeg6zf/BBWPwdf1XNaE9/TGRKIcdUHw4 ecz61iuVD4hk1xu19v5DcyjeVJ1dtsOO0ICLlTadkFqgjepuDVAlGj1sC8Y0Bo7QWEPV ZPbyXiComBHYSyvsXxU9dVG9o9hEkNcIKew7f8I18aWpFjuFQcl0daOupBUM7rQEiWIN eDPbtim0w9PrG2OqDVXZmfRWHhvGstrkIsZ7qoZAWj3i8Dnal4NhO4kenpzKFiZtcCxn QRVT6pbI+JM7W2Jy15a52Prm6LRBV60wLTE+AI/pjhWhZThBev5Pya9LjUIQqWWvp9d/ 7KaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745834830; x=1746439630; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cF2oeErd2f8CMpAQYPghRdhYfeau0GOqbG/tEe7jF1E=; b=Su2mg4EsrDohB+voP7F1fO89aHxA5lLRA4IgSA6+RClIGVVaRHds//Jtl/pBg46Ugk Cixq+tf/EDyWa80XMl+yzwWg6uKq76BOi/08XzANbeo9UHjNIqPM/8Ft8X3MBuuYUC4e oYXEMfd9G5B5EfmvRpfujUSw2dzwAd+1PbH2Lw4Urbz56c7iaZ7UF4hdliQdCDaXn7iB 5/xg4KKA1EKlFdBtlIVOZxVrHmpKgjgWUszbsX+MvaHtBAigxBDMeNJceMP+tXmI5wVD zuCwDcwxtF1mKakr61ZdI7+Wj7G6xMZsgfXMEeIh+ZMA/wVHkYgXdpJuB8jr4rb2TSxE 5xog== X-Forwarded-Encrypted: i=1; AJvYcCWNN2A9CfX2Al64kSvAepNx81DfdYD72iyjUDKtCLuIKa6QXcHiSVMuV2kohpQxMgtSi8aJKolarFTvWyE=@vger.kernel.org X-Gm-Message-State: AOJu0Yw85WsSkr4uCOhr5Fb53MWxY5Xs+Rl6nHEDX9z/ZwWecsScZYu/ Zc7fNlaJZRz++ADj0CONRxXfzlMfemIInzhWVk39+BsQbVI/ctboow88GZXhytZtHnQmENA5+bo QYMQ= X-Gm-Gg: ASbGncvXpRchJjA92pAo1hXwUfvBqLW5I/nM/66psAdk/qHhmZpZcPisypdB7CPmUds kW1cE1x0+SwcDK6X4R/pM8oZkt7C3LkenkFjHbuEw7aIi6ap99L7gmkGz0q8v8++sKL/gUZ/rfs cdIJfo0Wyoa+zovB1w+K7lIwNb2PG08Zq2bcD6ijocSFDW/yg5NDEgcfiXYwYNRO+oXfP+vmXKk 9aQ7/vb+nBJT6/q0KzE4/HTveYhhBCKS83wrJ2Q5efXrtDNKfLXzN71p8bgK2N5u4gLBAKL0eSt 6f5AQK7H1+NvhheDpr1MOpvGKn+7J1RZ7b4LfxCS6GAXFlxEBKp3D6kQ7CO0RDBbLARkwRUmbUE Ov26R X-Google-Smtp-Source: AGHT+IH4Pj+mbE1WOAoufjlp8rWav5+yAYMa+Zf5i/KTiT7A5shkzDX+Sqj9DrcK4mLxd/CD7GoucA== X-Received: by 2002:a05:6000:1aca:b0:38f:4ffd:c757 with SMTP id ffacd0b85a97d-3a074cdb983mr8433308f8f.2.1745834830173; Mon, 28 Apr 2025 03:07:10 -0700 (PDT) Received: from [192.168.5.157] (88-127-185-231.subs.proxad.net. [88.127.185.231]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-3a073e5cb16sm10575403f8f.84.2025.04.28.03.07.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 03:07:09 -0700 (PDT) From: amergnat@baylibre.com Date: Mon, 28 Apr 2025 12:06:50 +0200 Subject: [PATCH v4 4/5] rtc: test: Also test time and wday outcome of rtc_time64_to_tm() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250428-enable-rtc-v4-4-2b2f7e3f9349@baylibre.com> References: <20250428-enable-rtc-v4-0-2b2f7e3f9349@baylibre.com> In-Reply-To: <20250428-enable-rtc-v4-0-2b2f7e3f9349@baylibre.com> To: Alexandre Belloni , Baolin Wang Cc: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandre Mergnat X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2347; i=amergnat@baylibre.com; h=from:subject:message-id; bh=UnAXFwAglulxq3VvT2LxxQ07u2U9oUPKSME/LEhdx+s=; b=owEBbQKS/ZANAwAKAStGSZ1+MdRFAcsmYgBoD1NKksIrx47qFXyIWVXw5aRilveyh1MSO+R8dQfi BrMmvQCJAjMEAAEKAB0WIQQjG17X8+qqcA5g/osrRkmdfjHURQUCaA9TSgAKCRArRkmdfjHURRRwD/ wKtNV3PpRHNxJhebj7jlb7eL+IGMmi1dGKIooOz9VS+K8GN+zM9bEJpER2HIB2OM9TglIGTazdVeN2 6BEWLGbYds3KyCpZF1xDJpQejyTyDtcqqCvEhQlU0r299y697Jro2c2iyox13rRQPVNv+svKkZle8g S9JnMo9j0db9MuqysB75Ad8D0gdeKVH8gMxTPmUywro7RGvP1+RDsjSs8VjffB0MkRIAxU8D0Sxnbe 1dmI8YXIujhDA3U2fEd1p5jjwPr+8c6sbiIT3bwlYHw9PblpgAzLgGGggUkVL5/6YsKftbJLAT7EDS hrBlm4ZtLLgCNnmN+PxanXNZjUixIK7C+1MzpyW2eA/6jBugk3s5vl88tnSBKjPz2+R+f10X09wKoo bLxz8ZeUipNIREDzhGnnZ77lqK8V0ouSRQXAWTq90CEiO1j0scUoXXZjHSOcKSZAXR226bi+Q/6XiH Pn0KSZmvR7g5HKVNwcWmZiQAwvkeA3LtnXjo+cjqhjpY2Lt6pALe6ClrRSst6oTRz/IhJidM+zfz20 xBaa79xWeW/z24TvHdIN6c/PtQrULj4kTu9TfxHliCvBm5UD4in7lfMDjysBAWIO4hmUGSYFAbBrqL K0EOKOkjZmowe8/0wwyVthSD3SAaCrdpjTWYfIxm44YOEyNqUoah4Fzu6Dyw== X-Developer-Key: i=amergnat@baylibre.com; a=openpgp; fpr=231B5ED7F3EAAA700E60FE8B2B46499D7E31D445 From: Uwe Kleine-K=C3=B6nig To cover calculation of the time and wday in the rtc kunit test also check tm_hour, tm_min, tm_sec and tm_wday of the rtc_time calculated by rtc_time64_to_tm(). There are no surprises, the two tests making use of rtc_time64_to_tm_test_date_range() continue to succeed. Signed-off-by: Uwe Kleine-K=C3=B6nig Signed-off-by: Alexandre Mergnat --- drivers/rtc/lib_test.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/lib_test.c b/drivers/rtc/lib_test.c index c0faddc04c9bbcd421cbdc030c4a073056c6a9a6..b1ac0701d42e5562b8eae5b1910= 12c8b56a06902 100644 --- a/drivers/rtc/lib_test.c +++ b/drivers/rtc/lib_test.c @@ -6,8 +6,10 @@ /* * Advance a date by one day. */ -static void advance_date(int *year, int *month, int *mday, int *yday) +static void advance_date(int *year, int *month, int *mday, int *yday, int = *wday) { + *wday =3D (*wday + 1) % 7; + if (*mday !=3D rtc_month_days(*month - 1, *year)) { ++*mday; ++*yday; @@ -43,23 +45,29 @@ static void rtc_time64_to_tm_test_date_range(struct kun= it *test, int years) int month =3D 1; int mday =3D 1; int yday =3D 1; + int wday =3D 4; /* Jan 1st 1970 was a Thursday */ =20 struct rtc_time result; time64_t secs; + const time64_t sec_offset =3D ((1 * 60) + 2) * 60 + 3; =20 for (secs =3D 0; secs <=3D total_secs; secs +=3D 86400) { =20 - rtc_time64_to_tm(secs, &result); + rtc_time64_to_tm(secs + sec_offset, &result); =20 - #define FAIL_MSG "%d/%02d/%02d (%2d) : %lld", \ - year, month, mday, yday, secs + #define FAIL_MSG "%d/%02d/%02d (%2d, %d) : %lld", \ + year, month, mday, yday, wday, secs + sec_offset =20 KUNIT_ASSERT_EQ_MSG(test, year - 1900, result.tm_year, FAIL_MSG); KUNIT_ASSERT_EQ_MSG(test, month - 1, result.tm_mon, FAIL_MSG); KUNIT_ASSERT_EQ_MSG(test, mday, result.tm_mday, FAIL_MSG); KUNIT_ASSERT_EQ_MSG(test, yday, result.tm_yday, FAIL_MSG); + KUNIT_ASSERT_EQ_MSG(test, 1, result.tm_hour, FAIL_MSG); + KUNIT_ASSERT_EQ_MSG(test, 2, result.tm_min, FAIL_MSG); + KUNIT_ASSERT_EQ_MSG(test, 3, result.tm_sec, FAIL_MSG); + KUNIT_ASSERT_EQ_MSG(test, wday, result.tm_wday, FAIL_MSG); =20 - advance_date(&year, &month, &mday, &yday); + advance_date(&year, &month, &mday, &yday, &wday); } } =20 --=20 2.25.1 From nobody Fri Dec 19 17:36:13 2025 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E418925FA10 for ; Mon, 28 Apr 2025 10:07:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745834834; cv=none; b=PNKJp3hBq1LVfId6aWHSzWyaAJ8kZvR0lYC2GOzRNPiTOJGqlL3r4QJrfpHsbt5rZonN7W8QboE4NkKtLHDfw2j+OclglfFjs7pHUni8kAChlnKFqmKJbHDzoHN3SqkDeB3UOk0sD2Cw9j/6W2rWqx+EwmngU0sG5gSz8OvEeSQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745834834; c=relaxed/simple; bh=7uZeWPhtvmKt3yd3O8AZQ3pbDjAfEgQirGkkFlgXXu8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XyZSCV27HR1+aYpMvaCNJS9eLTL+BWuzdHnlDdkCqfSURGPKV49n16evfiDMNztwxew9fCSW+oflvZYTAVef38I/P4iVCgF/oKufYIx9iiWNh7Df1II4uWdODiliSe9CrLVLFqE8TEDOlexAGki/ZGvYw6zyG10a95N5/m051Nw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=M2hGM1zF; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="M2hGM1zF" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-43edecbfb46so29282405e9.0 for ; Mon, 28 Apr 2025 03:07:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1745834831; x=1746439631; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=E2hK+VsNCueKzRhMql1tQgaE2/N2rrh2mNXHk22OL+U=; b=M2hGM1zF5L0d6tfk1pH9YoiiXm7SSaxvEwwrfUEQfoGAppd4Qr0tqC8g57tnuvB7Vk M+KyKULXatrQAIXHnY+mjzI4f/7VzhaQiRj+cHfrTnuFM3IgSSjaLidfIDmpK4YzhtFA dMX3Wp2VkZOi048Kh4FH6C0PWB9HgupKteVX0Y1Av42OIdqwNLRi6dDJlpqRYFPNJw5x pMeJF9IGt4Gakiuv2J3iEsQwPcKcjCx24/Hf2mkDrQli6TMhN/Go/w2YvEqB75518uLc 01Y1x2Kfcmq6+Ikhd8efErHKm61oyrSwJ9Obl2m37f5gRMJ2Tm6bD+LSl5vXEQoEgoob HguA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745834831; x=1746439631; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E2hK+VsNCueKzRhMql1tQgaE2/N2rrh2mNXHk22OL+U=; b=nr8EKz50M5zEXiN3xKf5L1isNKtB7BIKwcP5hnBftcteZfMQWgYMqNjHBhIZwtbitI kguxi0xBksNU8oN6Dg/EGMzfD8KKhUoBwnC3+kPf524v1EdQ6//Sn7ylcrGmzFVQWxNo JEct/U0WX69We1y9WttOW7iq65dcYs22oM7TY1G7aI7PtNTRWxdRcftb6D59gau7E5jc 4Zn3W/RLHU6HvxeHguu+YvUJVxfKvGPC+7pvTYDdSMR6mm6Oqdazii3Z/C7PxHtTP6qK 2Qo/8Hmyaz6BjN/kPungpzmIdowojl3u2qe1cuRfCf7kx2VanMOOShctcH5pFcYAyKKW f5hQ== X-Forwarded-Encrypted: i=1; AJvYcCXMSO6UTKfR/IS8C8qyrhxfzp4XaBAMvXMzT4wgv3cAK8lxz6QQAjRS0odLvZA5RTXCrLKUCDOE1k2Pnrs=@vger.kernel.org X-Gm-Message-State: AOJu0YzhFv3BUah/SqWynF52VG49VlQYcPdzsJcsl2WDkfFthaPlQc9j UyIuUBNkod+67NgoPMGq5LyaX/9RQoO+grnE5Xexdd22JWkqRgKwqWxu1kEv6hw= X-Gm-Gg: ASbGncsZzSoXcivD0P3agUR8wx8pTQjXhMKVfdJhFI36X9ykDdSzJp/Zc4BYSD1dRHT LxBHg97Degxv91qI0RqccFqqt9RsAZ6ZTLouhqZOdh3aRB+J8wkvVS/SABsoc44pa9F6pKpLMeA vX/IO7Ed/XVGp+3/dFif2Bfo95PpLUETpuaCy+I51ebQC8hsP3dup2I3E/edbMlcpN/rw6wq7pa N8xeSztkzP7uMz2ISe7oCuwpa+5orPvODBxUEQFSamjwvNgvV03o020qTXKWAqnlkrY2NAI651J amZVMH5n0EHHIAIvDYhHx4WRTrLNUSpNnMCBD2glbpbWtQ+BVCfIEOV6J/hwHbeR24K5KPuLzAm 0mtsW X-Google-Smtp-Source: AGHT+IFRuxRIEVZZj31DvUBWrxkoov2qi7tMN4aU3Qd0yVZ6ftykojF/M4OsxkOlSbx29z0zaBH7Bw== X-Received: by 2002:adf:f989:0:b0:39c:2678:302b with SMTP id ffacd0b85a97d-3a07ab9be39mr5424818f8f.45.1745834831111; Mon, 28 Apr 2025 03:07:11 -0700 (PDT) Received: from [192.168.5.157] (88-127-185-231.subs.proxad.net. [88.127.185.231]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-3a073e5cb16sm10575403f8f.84.2025.04.28.03.07.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 03:07:10 -0700 (PDT) From: amergnat@baylibre.com Date: Mon, 28 Apr 2025 12:06:51 +0200 Subject: [PATCH v4 5/5] rtc: test: Test date conversion for dates starting in 1900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250428-enable-rtc-v4-5-2b2f7e3f9349@baylibre.com> References: <20250428-enable-rtc-v4-0-2b2f7e3f9349@baylibre.com> In-Reply-To: <20250428-enable-rtc-v4-0-2b2f7e3f9349@baylibre.com> To: Alexandre Belloni , Baolin Wang Cc: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandre Mergnat X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2299; i=amergnat@baylibre.com; h=from:subject:message-id; bh=xK50ZlflFxjaQB8WcqAUgAFjtJg9QpcfS53C50dYoe8=; b=owEBbQKS/ZANAwAKAStGSZ1+MdRFAcsmYgBoD1NKryymyzHMppRuPdvg3SRPRoGC0q54b/rX+1Sx QRelbuCJAjMEAAEKAB0WIQQjG17X8+qqcA5g/osrRkmdfjHURQUCaA9TSgAKCRArRkmdfjHURXHkD/ 9DicZ/dEoU5A72UnzRYONqLjcZMFJvGB7tSqWy8/DR/RvuYt7nXCFxDdrKBrbU+UOgsEw76ozLgmGe DPgbN136iHwXYRFEJQ1+Qx9wKg5UKWcl3JG0XWkMvseOavAzaU+temFE3iCLEwSmjFXmCNis2Blm34 OvnPQ8CDofHRWH3KtO7KxlPqaFrwYDTKE/5PT56EIdO71GHz+/nTnu4FUNVzZZPwERqm+YQgqr1uT+ nrbBHs1Vq+MSNTbahpBm3HkRufBhsJKKKPAU5KRbg4OPD6cX8jss9ghGuAa/MWU+5N96j5LsFl1Tgu QmXPW+bEHNMcCKJ25Ysltr82lX2AhF/W14aonBBGLP71G5WnQZj8RKYTNQN5vgeOfcsrevqI6KGW+V GHiWVH2DVfDWGKMod8X+PG3mrFJdEgOpIzQvXeb0xyR0VfJPDL3nLnpWI0pc7om5DFPOi7+CRD6ot5 klbeHhSW5XNaTaNxpSoN1kHnV0fA8giVtrzQpTwASpI/tTvy7rByzm5Eod2Hr+6C/Yll6w0BCZ+xjc p01TXYRdCySZTSCuuStlU77oxnJNYfHaqABtwb9NcnmPkRr9mZEp0bWLSXbwdpQa9TnDW2gNznlB/K pUz2PUlMRvDrP4dJ+4o5RvQBTn4Xo7mFW5a63AbxHjAyG/8pu7RqJ9Yrrq8Q== X-Developer-Key: i=amergnat@baylibre.com; a=openpgp; fpr=231B5ED7F3EAAA700E60FE8B2B46499D7E31D445 From: Uwe Kleine-K=C3=B6nig While the RTC framework intends to only handle dates after 1970 for consumers, time conversion must also work for earlier dates to cover e.g. storing dates beyond an RTC's range_max. This is most relevant for the rtc-mt6397 driver that has range_min =3D RTC_TIMESTAMP_BEGIN_1900; range_max =3D mktime64(2027, 12, 31, 23, 59, 59); and so needs working support for timestamps in 1900 starting in less than three years. So shift the tested interval of timestamps to also cover years 1900 to 1970. Signed-off-by: Uwe Kleine-K=C3=B6nig Signed-off-by: Alexandre Mergnat --- drivers/rtc/lib_test.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/lib_test.c b/drivers/rtc/lib_test.c index b1ac0701d42e5562b8eae5b191012c8b56a06902..0eebad1fe2a0983c0009626dac5= 26fa07d27f6b6 100644 --- a/drivers/rtc/lib_test.c +++ b/drivers/rtc/lib_test.c @@ -41,15 +41,15 @@ static void rtc_time64_to_tm_test_date_range(struct kun= it *test, int years) */ time64_t total_secs =3D ((time64_t)years) / 400 * 146097 * 86400; =20 - int year =3D 1970; + int year =3D 1900; int month =3D 1; int mday =3D 1; int yday =3D 1; - int wday =3D 4; /* Jan 1st 1970 was a Thursday */ + int wday =3D 1; /* Jan 1st 1900 was a Monday */ =20 struct rtc_time result; time64_t secs; - const time64_t sec_offset =3D ((1 * 60) + 2) * 60 + 3; + const time64_t sec_offset =3D RTC_TIMESTAMP_BEGIN_1900 + ((1 * 60) + 2) *= 60 + 3; =20 for (secs =3D 0; secs <=3D total_secs; secs +=3D 86400) { =20 @@ -72,7 +72,7 @@ static void rtc_time64_to_tm_test_date_range(struct kunit= *test, int years) } =20 /* - * Checks every day in a 160000 years interval starting on 1970-01-01 + * Checks every day in a 160000 years interval starting on 1900-01-01 * against the expected result. */ static void rtc_time64_to_tm_test_date_range_160000(struct kunit *test) @@ -81,7 +81,7 @@ static void rtc_time64_to_tm_test_date_range_160000(struc= t kunit *test) } =20 /* - * Checks every day in a 1000 years interval starting on 1970-01-01 + * Checks every day in a 1000 years interval starting on 1900-01-01 * against the expected result. */ static void rtc_time64_to_tm_test_date_range_1000(struct kunit *test) --=20 2.25.1