From nobody Wed Dec 17 07:29:06 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23ABD263F47; Mon, 28 Apr 2025 11:37:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745840247; cv=none; b=Cfjr0vRXKqnEFRNCGUBDDUw0Rao0JVRqViUGe1nVcdnBoAbVtF8KahS59spPbnGB2rj4pTJ0cZUJTJWqcx3Hv0BoaUyhEVkzbGMzZ+4QQ8CVwPVKi0JJg+msFYkCcAhn+5fj/g6XmGMPaBsI9Q5fl1JaR7zi7fBb3Ua5u2Duke8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745840247; c=relaxed/simple; bh=/2Bzh5lhcnvg/ARciMdmCSEVawv11h2WJiL6HlFN56k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GDCS7TGcToB6NU7NAsWG1sY+ACdwEucr6PC3R7AQd2B7sUGPoTBHRGnjvpMvF/4iDwKhK0/p9AImUEahigaOKSgHPWM13Eha/8+Dr+JaLZDviOxeV/ojMxYJ69N0+WxggVT8bAhduapGuUI22L/KO5Q5yf2xVnFEGAISCwRDcgI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ut1RM4OY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ut1RM4OY" Received: by smtp.kernel.org (Postfix) with ESMTPS id BAE8BC4CEEF; Mon, 28 Apr 2025 11:37:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745840246; bh=/2Bzh5lhcnvg/ARciMdmCSEVawv11h2WJiL6HlFN56k=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=ut1RM4OYJwAb0lOE4fsR6dXNvOkD0gyRqzMa9QkMuSbu8vfVQ4DtEBICLU+FMhnI3 uWUaEWt+5+QVrpq25WGMnZHMncTKRVZLJ/gA0QNTRL9hhrIKvTiUPT22TTHZdMYRl7 i6ty5lBg2ednIZgdVIhY7JTIGRTrYzwDVY7LFLaobi5eAI8WReZK31Iy3N9S81JXs0 Ielv4E60WM1A8+tkus3Wc5z7Q1YLLTigInhklsFWSmo+lOKnFkYHfHTU2P8Stsfi1p lNKOWdUc8wFdBjoFfMx91vVgTe47gicTl2+JhPCRqPD+wkpRWjinRdslC+0/dYIYH9 Du1i4Vzkw8M+Q== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFB4AC3ABA3; Mon, 28 Apr 2025 11:37:26 +0000 (UTC) From: Janne Grunau via B4 Relay Date: Mon, 28 Apr 2025 13:37:15 +0200 Subject: [PATCH v2 3/4] drm: adp: Enable vblank interrupts in crtc's .atomic_enable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250428-drm_adp_fixes-v2-3-912e081e55d8@jannau.net> References: <20250428-drm_adp_fixes-v2-0-912e081e55d8@jannau.net> In-Reply-To: <20250428-drm_adp_fixes-v2-0-912e081e55d8@jannau.net> To: Sasha Finkelstein , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Neal Gompa , Alyssa Rosenzweig , Dmitry Baryshkov , Janne Grunau Cc: dri-devel@lists.freedesktop.org, asahi@lists.linux.dev, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1493; i=j@jannau.net; s=yk2024; h=from:subject:message-id; bh=5JgvZ4gbao9P8lotrmf2Fkpjg9Gx/quiG4P1r9wf9J0=; b=owGbwMvMwCW2UNrmdq9+ahrjabUkhgz+jFK9wyy+9auiUv/bSb+7MD//jurKe06vuaTmbfYJb JQofNnfUcrCIMbFICumyJKk/bKDYXWNYkztgzCYOaxMIEMYuDgFYCI3YxgZrmrPTfVPjhEydLJV s3l15pq81CWrL1o/5n1b67D7/PRnrIwMp16fcPYt4eU00/i/iX8ty6cFCydumbHYzuW5yS3WXCU dTgA= X-Developer-Key: i=j@jannau.net; a=openpgp; fpr=8B336A6BE4E5695E89B8532B81E806F586338419 X-Endpoint-Received: by B4 Relay for j@jannau.net/yk2024 with auth_id=264 X-Original-From: Janne Grunau Reply-To: j@jannau.net From: Janne Grunau Calling drm_crtc_vblank_on() drm_crtc_helper_funcs' atomic_enable is expected to enable vblank interrupts. It may have been avoided here to due to drm_crtc_vblank_get()'s error behavior after drm_crtc_vblank_reset(). With that fixed in the preceding change the driver can call drm_crtc_vblank_on() from adp_crtc_atomic_enable(). Reviewed-by: Alyssa Rosenzweig Signed-off-by: Janne Grunau --- drivers/gpu/drm/adp/adp_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/adp/adp_drv.c b/drivers/gpu/drm/adp/adp_drv.c index bdf27ee742ea01759b5d571a21b527687ffcada7..50d26c73301c02e4a2f22b776ad= 8d8e9407565c9 100644 --- a/drivers/gpu/drm/adp/adp_drv.c +++ b/drivers/gpu/drm/adp/adp_drv.c @@ -288,6 +288,7 @@ static void adp_crtc_atomic_enable(struct drm_crtc *crt= c, writel(BIT(0), adp->be + ADBE_BLEND_EN3); writel(BIT(0), adp->be + ADBE_BLEND_BYPASS); writel(BIT(0), adp->be + ADBE_BLEND_EN4); + drm_crtc_vblank_on(crtc); } =20 static void adp_crtc_atomic_disable(struct drm_crtc *crtc, @@ -519,8 +520,7 @@ static int adp_drm_bind(struct device *dev) struct adp_drv_private *adp =3D to_adp(drm); int err; =20 - adp_disable_vblank(adp); - writel(ADP_CTRL_FIFO_ON | ADP_CTRL_VBLANK_ON, adp->fe + ADP_CTRL); + writel(ADP_CTRL_FIFO_ON, adp->fe + ADP_CTRL); =20 adp->next_bridge =3D drmm_of_get_bridge(&adp->drm, dev->of_node, 0, 0); if (IS_ERR(adp->next_bridge)) { --=20 2.49.0