From nobody Wed Dec 17 07:29:10 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23C7826562B; Mon, 28 Apr 2025 11:37:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745840247; cv=none; b=ksJlLbwhgFKIx+TTGl5YHV4gLmKxveIdBO+8wlBEAWlpBIrYS0fDSc8Xcz4VOc93fDOgrL1ROujLldzduQ3qUy0OP5GMBMKxAgnb9wP7y78aVqj467XJaFhdh7b/mh7oKs6JgkI5DAse763vcAbQi7mk/tM1Jed7YiTkq5VjJzk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745840247; c=relaxed/simple; bh=gyUkxENbv630uKtE7gXJdti1lLZFSd7n0i3pDBTmb98=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CqWFkJxx5DqVUw4aJQo9jTi84n/8XKH5ZxKW6tuLjZ8RUWgFzXDn6+YCUzXnBFoPRLmGlhTEY2bwptDGaaCetaQsRYiepube++djSJfS2H/IcbGCF7uh0qN9IeqO0rUkFYXHaPA1fYqGjxjS9ANf08CVaeO4KeCWtwR9uWmrtJY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dlVJpDNd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dlVJpDNd" Received: by smtp.kernel.org (Postfix) with ESMTPS id A730EC4CEEE; Mon, 28 Apr 2025 11:37:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745840246; bh=gyUkxENbv630uKtE7gXJdti1lLZFSd7n0i3pDBTmb98=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=dlVJpDNdEeAgYv7gJdvWiHmZr3YOOrXJXD+75VY6CYD6s8DcMT4xYOd1NYRQX1dHT FWb0lCKUkPRIUbRjVZbXBQjZtUt+NqgdedsiXLQQJqvHYzyBZJ52pndTBgiUCzPUXg x+5yVjnAVP190gY0IViKrzpo4WwlpTrsl23ewVcrA/vOv9DqujN58bUrrni3lNFzVO ut6TpPsj2KLIA2agvyd1CngRupi1//F6yys6ya0mRM0V+GAcF1PUuTs7MHKqpZ3ZvE wfqdtK5J0sTgz9nHlYTNdrI1QETOyoUN7lvJyo3lRftRrzml/USTlgJEnMZpq0TJMJ t+bGvKyOpPYMQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 937D4C3ABA4; Mon, 28 Apr 2025 11:37:26 +0000 (UTC) From: Janne Grunau via B4 Relay Date: Mon, 28 Apr 2025 13:37:13 +0200 Subject: [PATCH v2 1/4] drm: adp: Use spin_lock_irqsave for drm device event_lock Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250428-drm_adp_fixes-v2-1-912e081e55d8@jannau.net> References: <20250428-drm_adp_fixes-v2-0-912e081e55d8@jannau.net> In-Reply-To: <20250428-drm_adp_fixes-v2-0-912e081e55d8@jannau.net> To: Sasha Finkelstein , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Neal Gompa , Alyssa Rosenzweig , Dmitry Baryshkov , Janne Grunau Cc: dri-devel@lists.freedesktop.org, asahi@lists.linux.dev, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1587; i=j@jannau.net; s=yk2024; h=from:subject:message-id; bh=f9CWUT6BHio9yznivZy0rXZk6w93Ok71Ww97RIoMSA0=; b=owGbwMvMwCW2UNrmdq9+ahrjabUkhgz+jBKf1WUvsgS3G96a4Dr19KNNkSLcNuwLY056+2/re OLwe5lWRykLgxgXg6yYIkuS9ssOhtU1ijG1D8Jg5rAygQxh4OIUgIkkOjIytG9MuGCsvi6n+Rnj wSX77bdYVN7dUS1Rvrzn3bmljV5lGxj+52UX7A5N1wrZ4j3p9cWrB7dY9aV1da5pT3v6p9ZU82Y eAwA= X-Developer-Key: i=j@jannau.net; a=openpgp; fpr=8B336A6BE4E5695E89B8532B81E806F586338419 X-Endpoint-Received: by B4 Relay for j@jannau.net/yk2024 with auth_id=264 X-Original-From: Janne Grunau Reply-To: j@jannau.net From: Janne Grunau The lock is used in the interrupt handler so use spin_lock_irqsave to disable interrupts and avoid deadlocks with the irq handler. Fixes: 332122eba628 ("drm: adp: Add Apple Display Pipe driver") Reviewed-by: Alyssa Rosenzweig Signed-off-by: Janne Grunau --- drivers/gpu/drm/adp/adp_drv.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/adp/adp_drv.c b/drivers/gpu/drm/adp/adp_drv.c index c98c647f981d5383149647126762a5cdec8f4e4b..157298a8ff42b95275411dd4a7a= 0c70780fd86fd 100644 --- a/drivers/gpu/drm/adp/adp_drv.c +++ b/drivers/gpu/drm/adp/adp_drv.c @@ -310,6 +310,7 @@ static void adp_crtc_atomic_flush(struct drm_crtc *crtc, struct drm_atomic_state *state) { u32 frame_num =3D 1; + unsigned long flags; struct adp_drv_private *adp =3D crtc_to_adp(crtc); struct drm_crtc_state *new_state =3D drm_atomic_get_new_crtc_state(state,= crtc); u64 new_size =3D ALIGN(new_state->mode.hdisplay * @@ -330,13 +331,13 @@ static void adp_crtc_atomic_flush(struct drm_crtc *cr= tc, } writel(ADBE_FIFO_SYNC | frame_num, adp->be + ADBE_FIFO); //FIXME: use adbe flush interrupt - spin_lock_irq(&crtc->dev->event_lock); + spin_lock_irqsave(&crtc->dev->event_lock, flags); if (crtc->state->event) { drm_crtc_vblank_get(crtc); adp->event =3D crtc->state->event; } crtc->state->event =3D NULL; - spin_unlock_irq(&crtc->dev->event_lock); + spin_unlock_irqrestore(&crtc->dev->event_lock, flags); } =20 static const struct drm_crtc_funcs adp_crtc_funcs =3D { --=20 2.49.0