From nobody Mon Feb 9 21:37:04 2026 Received: from lelvem-ot02.ext.ti.com (lelvem-ot02.ext.ti.com [198.47.23.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF28223E32D; Fri, 25 Apr 2025 10:42:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.23.235 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745577736; cv=none; b=m0+Vj1FC3/kfbAi0m8XvBLed2tezBQQnasmrHEHFRpccwNmT4rxuzX1lEDHXQlM6PBRjXjElLqw/FQicGomFEvn2vQtmcKcDVpPLGHNdU0uwlvJdrveN3y92w5P+qJRzb4M/osNn92k8bqEm3splC2VQ3pJeNOVZjXep5M60WNM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745577736; c=relaxed/simple; bh=83JyrDvI8QSAGDSfp4i2fiAqLaUNVHpr0uCjhS6ezAA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=goYwxZ5Uc88+fFD3cDHjBB76vaWt77toA1M3Pj8WQzviMD7kF4xpWdz6FJ29CIngJx4doN3ynNxCTUrmWcgGKwSTpznIr2DEX45meJT4YYNb0plbHVQr+k8eBpfEssBM11DU7lxp1d7A+WyAgdRo7GXfAvbO29sslTqaaZ/0r9A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=gRh1hQu+; arc=none smtp.client-ip=198.47.23.235 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="gRh1hQu+" Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelvem-ot02.ext.ti.com (8.15.2/8.15.2) with ESMTPS id 53PAg7qu2910825 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Apr 2025 05:42:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1745577727; bh=bc4hX0Yy7ejCfzRTrUrQmKEcMoN0mDXW5hQsAa9n/3k=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=gRh1hQu+kbCrwmml52imwQJoCIkld05apnyfc4wEvCVq28yWhDkAD047/zgTKPFQ7 EczX/dUJGL4e8GovOu7LwEdbgAjJyZ6hxnyKWVcO6GvQRLijOzwaU0ZgdseU6mpN/l rvl0iojeXAfIGHPncKPciYvJs/lnOy2YHBJwTGzs= Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 53PAg7rg129296 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 25 Apr 2025 05:42:07 -0500 Received: from DFLE101.ent.ti.com (10.64.6.22) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Fri, 25 Apr 2025 05:42:06 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Fri, 25 Apr 2025 05:42:06 -0500 Received: from uda0510294.dhcp.ti.com (uda0510294.dhcp.ti.com [172.24.227.151]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 53PAfaZS038329; Fri, 25 Apr 2025 05:42:03 -0500 From: Beleswar Padhi To: , CC: , , , , , , , , , , Subject: [PATCH v11 07/35] remoteproc: k3-r5: Use k3_r5_rproc_mem_data structure for memory info Date: Fri, 25 Apr 2025 16:11:07 +0530 Message-ID: <20250425104135.830255-8-b-padhi@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250425104135.830255-1-b-padhi@ti.com> References: <20250425104135.830255-1-b-padhi@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea Content-Type: text/plain; charset="utf-8" The ti_k3_r5_remoteproc.c driver previously hardcoded device memory region addresses and names. Change this to use the k3_r5_rproc_mem_data structure to store memory information. This aligns with K3 DSP and M4 drivers, and can be refactored out later. Signed-off-by: Beleswar Padhi Reviewed-by: Andrew Davis Tested-by: Judith Mendez --- v11: Changelog: 1. Carried T/B tag. Link to v10: https://lore.kernel.org/all/20250417182001.3903905-8-b-padhi@ti.com/ v10: Changelog: 1. Collected R/B from v9 version of this patch. Link to v9: https://lore.kernel.org/all/20250317120622.1746415-4-b-padhi@ti.com/ drivers/remoteproc/ti_k3_r5_remoteproc.c | 65 ++++++++++++++++++++---- 1 file changed, 56 insertions(+), 9 deletions(-) diff --git a/drivers/remoteproc/ti_k3_r5_remoteproc.c b/drivers/remoteproc/= ti_k3_r5_remoteproc.c index 5a460cfdfb4c4..e2dd5c38a0668 100644 --- a/drivers/remoteproc/ti_k3_r5_remoteproc.c +++ b/drivers/remoteproc/ti_k3_r5_remoteproc.c @@ -84,18 +84,44 @@ enum cluster_mode { CLUSTER_MODE_SINGLECORE }; =20 +/** + * struct k3_r5_mem_data - memory definitions for a R5 + * @name: name for this memory entry + * @dev_addr: device address for the memory entry + */ +struct k3_r5_mem_data { + const char *name; + const u32 dev_addr; +}; + +/** + * struct k3_r5_dev_data - device data structure for a R5 + * @mems: pointer to memory definitions for a R5 + * @num_mems: number of memory regions in @mems + * @boot_align_addr: boot vector address alignment granularity + * @uses_lreset: flag to denote the need for local reset management + */ +struct k3_r5_dev_data { + const struct k3_r5_mem_data *mems; + u32 num_mems; + u32 boot_align_addr; + bool uses_lreset; +}; + /** * struct k3_r5_soc_data - match data to handle SoC variations * @tcm_is_double: flag to denote the larger unified TCMs in certain modes * @tcm_ecc_autoinit: flag to denote the auto-initialization of TCMs for E= CC * @single_cpu_mode: flag to denote if SoC/IP supports Single-CPU mode * @is_single_core: flag to denote if SoC/IP has only single core R5 + * @core_data: pointer to R5-core-specific device data */ struct k3_r5_soc_data { bool tcm_is_double; bool tcm_ecc_autoinit; bool single_cpu_mode; bool is_single_core; + const struct k3_r5_dev_data *core_data; }; =20 /** @@ -151,6 +177,7 @@ struct k3_r5_core { * @rmem: reserved memory regions data * @num_rmems: number of reserved memory regions * @reset: reset control handle + * @data: pointer to R5-core-specific device data * @tsp: TI-SCI processor control handle * @ti_sci: TI-SCI handle * @ti_sci_id: TI-SCI device identifier @@ -166,6 +193,7 @@ struct k3_r5_rproc { struct k3_r5_mem *rmem; int num_rmems; struct reset_control *reset; + const struct k3_r5_dev_data *data; struct ti_sci_proc *tsp; const struct ti_sci_handle *ti_sci; u32 ti_sci_id; @@ -1235,31 +1263,32 @@ static int k3_r5_rproc_configure_mode(struct k3_r5_= rproc *kproc) static int k3_r5_core_of_get_internal_memories(struct platform_device *pde= v, struct k3_r5_rproc *kproc) { - static const char * const mem_names[] =3D {"atcm", "btcm"}; + const struct k3_r5_dev_data *data =3D kproc->data; struct device *dev =3D &pdev->dev; struct k3_r5_core *core =3D kproc->priv; struct resource *res; int num_mems; int i; =20 - num_mems =3D ARRAY_SIZE(mem_names); - kproc->mem =3D devm_kcalloc(dev, num_mems, sizeof(*kproc->mem), GFP_KERNE= L); + num_mems =3D kproc->data->num_mems; + kproc->mem =3D devm_kcalloc(kproc->dev, num_mems, sizeof(*kproc->mem), + GFP_KERNEL); if (!kproc->mem) return -ENOMEM; =20 for (i =3D 0; i < num_mems; i++) { res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, - mem_names[i]); + data->mems[i].name); if (!res) { dev_err(dev, "found no memory resource for %s\n", - mem_names[i]); + data->mems[i].name); return -EINVAL; } if (!devm_request_mem_region(dev, res->start, resource_size(res), dev_name(dev))) { dev_err(dev, "could not request %s region for resource\n", - mem_names[i]); + data->mems[i].name); return -EBUSY; } =20 @@ -1273,7 +1302,8 @@ static int k3_r5_core_of_get_internal_memories(struct= platform_device *pdev, kproc->mem[i].cpu_addr =3D devm_ioremap_wc(dev, res->start, resource_size(res)); if (!kproc->mem[i].cpu_addr) { - dev_err(dev, "failed to map %s memory\n", mem_names[i]); + dev_err(dev, "failed to map %s memory\n", + data->mems[i].name); return -ENOMEM; } kproc->mem[i].bus_addr =3D res->start; @@ -1286,7 +1316,7 @@ static int k3_r5_core_of_get_internal_memories(struct= platform_device *pdev, * addresses 0 and 0x41010000 (same as the bus address on AM65x * SoCs) based on loczrama setting */ - if (!strcmp(mem_names[i], "atcm")) { + if (!strcmp(data->mems[i].name, "atcm")) { kproc->mem[i].dev_addr =3D core->loczrama ? 0 : K3_R5_TCM_DEV_ADDR; } else { @@ -1296,7 +1326,7 @@ static int k3_r5_core_of_get_internal_memories(struct= platform_device *pdev, kproc->mem[i].size =3D resource_size(res); =20 dev_dbg(dev, "memory %5s: bus addr %pa size 0x%zx va %pK da 0x%x\n", - mem_names[i], &kproc->mem[i].bus_addr, + data->mems[i].name, &kproc->mem[i].bus_addr, kproc->mem[i].size, kproc->mem[i].cpu_addr, kproc->mem[i].dev_addr); } @@ -1408,6 +1438,7 @@ static int k3_r5_cluster_rproc_init(struct platform_d= evice *pdev) kproc->priv =3D core; kproc->dev =3D cdev; kproc->rproc =3D rproc; + kproc->data =3D cluster->soc_data->core_data; core->kproc =3D kproc; =20 kproc->ti_sci =3D devm_ti_sci_get_by_phandle(cdev, "ti,sci"); @@ -1772,11 +1803,24 @@ static int k3_r5_probe(struct platform_device *pdev) return 0; } =20 +static const struct k3_r5_mem_data r5_mems[] =3D { + { .name =3D "atcm", .dev_addr =3D 0x0 }, + { .name =3D "btcm", .dev_addr =3D K3_R5_TCM_DEV_ADDR }, +}; + +static const struct k3_r5_dev_data r5_data =3D { + .mems =3D r5_mems, + .num_mems =3D ARRAY_SIZE(r5_mems), + .boot_align_addr =3D 0, + .uses_lreset =3D true, +}; + static const struct k3_r5_soc_data am65_j721e_soc_data =3D { .tcm_is_double =3D false, .tcm_ecc_autoinit =3D false, .single_cpu_mode =3D false, .is_single_core =3D false, + .core_data =3D &r5_data, }; =20 static const struct k3_r5_soc_data j7200_j721s2_soc_data =3D { @@ -1784,6 +1828,7 @@ static const struct k3_r5_soc_data j7200_j721s2_soc_d= ata =3D { .tcm_ecc_autoinit =3D true, .single_cpu_mode =3D false, .is_single_core =3D false, + .core_data =3D &r5_data, }; =20 static const struct k3_r5_soc_data am64_soc_data =3D { @@ -1791,6 +1836,7 @@ static const struct k3_r5_soc_data am64_soc_data =3D { .tcm_ecc_autoinit =3D true, .single_cpu_mode =3D true, .is_single_core =3D false, + .core_data =3D &r5_data, }; =20 static const struct k3_r5_soc_data am62_soc_data =3D { @@ -1798,6 +1844,7 @@ static const struct k3_r5_soc_data am62_soc_data =3D { .tcm_ecc_autoinit =3D true, .single_cpu_mode =3D false, .is_single_core =3D true, + .core_data =3D &r5_data, }; =20 static const struct of_device_id k3_r5_of_match[] =3D { --=20 2.34.1