From nobody Fri Dec 19 06:18:34 2025 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F075B2749E1 for ; Fri, 25 Apr 2025 15:18:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745594329; cv=none; b=chEYn4OckLS5RZM2tba2UTjbQt+GVDz16sdRhN1t3xN7ATmotI3esGJkskbYSyyAKP9JPB+IllzjB3KzqePmHfSgPklVlO3hyAiCDiTNy/WK/Y3/am78WZCeu63nddVFqd2OUM/+bd75P/CSNBv6Wp+TXfwKHHE4okU/iD9ao4E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745594329; c=relaxed/simple; bh=GvHZb4LgvZavNrWnrHHNVHTVupagN/UULTDDQRYT6M0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=O4rqtWpWtlwb9Y0Z2pgERipi9e0CsZTTXHEj8bQTrQzYLOi/IH8o1PFJa7A18XU8+HNq9nu6OFBB8KLcTBpBo1AU1yVfCnhEHP5HGa+TSWQ0t9q52ErGkKPgS/WMB7Ev91FVG2682A3gEQmdI04XRT5Op99BlCGEtdcAfQREWkk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=thaumatec.com; spf=pass smtp.mailfrom=thaumatec.com; dkim=pass (2048-bit key) header.d=thaumatec-com.20230601.gappssmtp.com header.i=@thaumatec-com.20230601.gappssmtp.com header.b=mND5F44k; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=thaumatec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=thaumatec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=thaumatec-com.20230601.gappssmtp.com header.i=@thaumatec-com.20230601.gappssmtp.com header.b="mND5F44k" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5e5e63162a0so3560971a12.3 for ; Fri, 25 Apr 2025 08:18:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thaumatec-com.20230601.gappssmtp.com; s=20230601; t=1745594326; x=1746199126; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+M5rdkwGZu/VDL8llLe2S9tCSCM0PahPEImRhTBfwfY=; b=mND5F44k0QwjtBBmXX5EcdauDd8m0T9azY1HnqsaCbDhWTQEaaWXzMH1j9Uhdr9M9b pl2/Z2QCgDdJVPkVsBQfy4PulI8tkqnYDQQS0WCKpoF8uYx9luHpqRYpdAUAsbLFRXiw WyGsqQYAKyR2JDgWzWQK61rDJCDUKgwgMFF/giJLmVhI7gb67juI5Z6d3txSq0vAb78g L/Ddq8SkQz5NwQxIXCVnVRcSiJE67HWwda4wGtywAmqtVTEm/nSmUthbCXj/8ETT0mX+ 8vyyce3DVasTIlJrgG5SAlnh9id6rggo+LciH3MkDkRKT8+swkYtw8oFi1ALjLfmosAT xhsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745594326; x=1746199126; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+M5rdkwGZu/VDL8llLe2S9tCSCM0PahPEImRhTBfwfY=; b=FQpWu+HXsDuNELCb80wZYVKHJUOK8kyat8abLIsT2+rnoPuFbHl/VHncEaoMIBHJG7 Z0/X7QuaQyaXX1AgZwOffid0d60rL6pfqn9d1z2ZOFWi1VYOMAtQk+Y3eCr7WVKiR66p mcyvVErzF7pksQO77hKvTdBEKvFSERIEp3t09v+4K8mqXNSZnovoD5QOoEAwrVMVyKP9 +M2kj73Ooy/NNSe+b+k56L3tRrkTnlD6IpEzJSOzUITZbXsJHQIKLHG0khVVpNTOgYuj eZ++LSJeWBduSb0h6zyYI5Ph5slqVWOYuG/hp6vfdUsO2/csXIDX0s0/9L3O2D99xSpe 4tdA== X-Forwarded-Encrypted: i=1; AJvYcCXhXx7/xUPvk6ksA7WielEIgnniAlUEP1KA3g0Wmoo5J0V8HMaxIQp12O0DnWDYVkmYnym2KECteUSOk6A=@vger.kernel.org X-Gm-Message-State: AOJu0YwfjAoBt4TJqvv7mauRfU7y/+TGQ7UadtHklPcxqk7FhpJewvaY bkr9KcigvQbzkz5kkHzKXl+Scd4eh+frneOtcS1mNiznXPv8mVPIQ5kiWU6KAGc= X-Gm-Gg: ASbGnct3S2TX+52vD/rskGB6OBkNhsfE9R+3ODRtI+AnGBVdReQtYtGNLDR+jnPVC1Y 04ptiilCLrNz3Q5cH1pQfrcydX3L3OKFSElwsePam5rrEfJvwUCF8etzjg6kWb/OrzgmxCe+6Ud Tf5m2qT9AT7DRZM0l5W91zxWZ2kqtBz5s7+gQtFWwZBacR6kIZ3sihMUNNlfnESt+KX/BWDEpzZ dp81YEux2UaaZvtSDB4/Tp0wmf0cmSwZwfG/Swx6FR4alwDQzoXMuozkTafm87J0UIXhd4wDcxM cPjAiTWGTln8yE4xi7TwOotvr4XiPmINLmGZnxGxH9VGD9KoV3DVUSSEF21faxTuXwqK X-Google-Smtp-Source: AGHT+IHaoG8RjUwrvQSyvJG6aKSZajj5vFrhmm1pCthBlIn1lk/zpPP3YRLIRhFmyc6BfcY/0PDTEA== X-Received: by 2002:a17:907:1c08:b0:ac2:9ac:a062 with SMTP id a640c23a62f3a-ace73a45d0dmr248025266b.23.1745594326097; Fri, 25 Apr 2025 08:18:46 -0700 (PDT) Received: from [127.0.1.1] ([185.164.142.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ace6e59649fsm151099766b.85.2025.04.25.08.18.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 08:18:45 -0700 (PDT) From: Lukasz Czechowski Date: Fri, 25 Apr 2025 17:18:06 +0200 Subject: [PATCH v2 1/5] usb: misc: onboard_usb_dev: fix support for Cypress HX3 hubs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250425-onboard_usb_dev-v2-1-4a76a474a010@thaumatec.com> References: <20250425-onboard_usb_dev-v2-0-4a76a474a010@thaumatec.com> In-Reply-To: <20250425-onboard_usb_dev-v2-0-4a76a474a010@thaumatec.com> To: Matthias Kaehlcke , Greg Kroah-Hartman , Benjamin Bara , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Klaus Goger Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Lukasz Czechowski , stable@vger.kernel.org X-Mailer: b4 0.14.2 The Cypress HX3 USB3.0 hubs use different PID values depending on the product variant. The comment in compatibles table is misleading, as the currently used PIDs (0x6504 and 0x6506 for USB 3.0 and USB 2.0, respectively) are defaults for the CYUSB331x, while CYUSB330x and CYUSB332x variants use different values. Based on the datasheet [1], update the compatible usb devices table to handle different types of the hub. The change also includes vendor mode PIDs, which are used by the hub in I2C Master boot mode, if connected EEPROM contains invalid signature or is blank. This allows to correctly boot the hub even if the EEPROM will have broken content. Number of vcc supplies and timing requirements are the same for all HX variants, so the platform driver's match table does not have to be extended. [1] https://www.infineon.com/dgdl/Infineon-HX3_USB_3_0_Hub_Consumer_Industr= ial-DataSheet-v22_00-EN.pdf?fileId=3D8ac78c8c7d0d8da4017d0ecb53f644b8 Table 9. PID Values Fixes: b43cd82a1a40 ("usb: misc: onboard-hub: add support for Cypress HX3 U= SB 3.0 family") Cc: stable@vger.kernel.org Signed-off-by: Lukasz Czechowski Reviewed-by: Heiko Stuebner --- drivers/usb/misc/onboard_usb_dev.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/usb/misc/onboard_usb_dev.c b/drivers/usb/misc/onboard_= usb_dev.c index 75ac3c6aa92d0d925bb9488d1e6295548446bf98..f5372dfa241a9cee09fea95fd14= b72727a149b2e 100644 --- a/drivers/usb/misc/onboard_usb_dev.c +++ b/drivers/usb/misc/onboard_usb_dev.c @@ -569,8 +569,14 @@ static void onboard_dev_usbdev_disconnect(struct usb_d= evice *udev) } =20 static const struct usb_device_id onboard_dev_id_table[] =3D { - { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6504) }, /* CYUSB33{0,1,2}x/CYUSB230x 3= .0 HUB */ - { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6506) }, /* CYUSB33{0,1,2}x/CYUSB230x 2= .0 HUB */ + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6500) }, /* CYUSB330x 3.0 HUB */ + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6502) }, /* CYUSB330x 2.0 HUB */ + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6503) }, /* CYUSB33{0,1}x 2.0 HUB, Vend= or Mode */ + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6504) }, /* CYUSB331x 3.0 HUB */ + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6506) }, /* CYUSB331x 2.0 HUB */ + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6507) }, /* CYUSB332x 2.0 HUB, Vendor M= ode */ + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6508) }, /* CYUSB332x 3.0 HUB */ + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x650a) }, /* CYUSB332x 2.0 HUB */ { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6570) }, /* CY7C6563x 2.0 HUB */ { USB_DEVICE(VENDOR_ID_GENESYS, 0x0608) }, /* Genesys Logic GL850G USB 2.= 0 HUB */ { USB_DEVICE(VENDOR_ID_GENESYS, 0x0610) }, /* Genesys Logic GL852G USB 2.= 0 HUB */ --=20 2.43.0 From nobody Fri Dec 19 06:18:34 2025 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBFCD25D907 for ; Fri, 25 Apr 2025 15:18:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745594330; cv=none; b=WckRr5BarDwm4WWb3IJUXNiLqkmhzXL0XrXJSaJz5SvZvINsv/62yT3czwAQzIoVS2TnpA4Rc8qIvcmkeLAAV8lOkEgsBIlsFsibkg+JjvoBmpesq1T8HofDwP5pW2bh/p5Mbpc3HcBBZcIXFKtpPveUivXZ1o7vHQBk6cuCcu0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745594330; c=relaxed/simple; bh=wDYHCLa5R2Lm8PFv1HaWiPbvSjf5XzEvOyMvWi1H6CY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cNSH4CpTKMfJCUumMErUv5weEYgo7lBikzGi5gPYPK8Cka6xUS2yc40OCG+wvISDxKEbymV+hPdW+JcOZKfISt7rdhbQyhjCUuCl8pBNtXjCPurOtqoHjn8Z8d8uX7qRVB5Dtuda8qJhe9fMmyGVubc8d5IqQGdRMu0G/lk4+fk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=thaumatec.com; spf=pass smtp.mailfrom=thaumatec.com; dkim=pass (2048-bit key) header.d=thaumatec-com.20230601.gappssmtp.com header.i=@thaumatec-com.20230601.gappssmtp.com header.b=ZHwq+GeP; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=thaumatec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=thaumatec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=thaumatec-com.20230601.gappssmtp.com header.i=@thaumatec-com.20230601.gappssmtp.com header.b="ZHwq+GeP" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-ac7bd86f637so678580466b.1 for ; Fri, 25 Apr 2025 08:18:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thaumatec-com.20230601.gappssmtp.com; s=20230601; t=1745594327; x=1746199127; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PGhABSDncyCkqMF1m9WG+uwjNnjeaT93SjRTLfv5Zno=; b=ZHwq+GePs+RKCQobQ9swTjG3tVZNiCPZNr0zGEbFHlxgRETxYR4W62+5S9Qsjuj1xg KNY1+TXArniXt/OBtRxLicDD2HoiXwbDS/lZHycrwnCpsa1YLnd3TQ8z4nBLFUvXk1mB K59QofHgU9nipZfx5dAY4eqcdoLepMk5Dkze2em4PnmpjAPyiqRB1UTMKgvFcEl9/zeK hEwqBb1SnpN3dFcQ1gRUZMQ3rrStUu9hrXjoSn7mq4++GE8gIHuCNTHEJnf0thS5gsk4 oYbDFRx9Vs0a51dES32e1sVlTII1Z/DrpRmoxOO0wsnRVVwhNhCgvOBRW5LJKejjVLU0 4K/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745594327; x=1746199127; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PGhABSDncyCkqMF1m9WG+uwjNnjeaT93SjRTLfv5Zno=; b=G/1lm/8RKO3RmCzQqLUd+CWL/d/aTQcOqGBqxLvlHr+7Lu67gMvbgEKK6TAVJH7rvd 24aEg3yJ/QkSceDm7Q9/RZ5VZeOyQjsp0/KPaPiq7ZRMfaNqYOJb1CiUekFYbLO8poAo OYP/nEkAPUFfOtnyRytKeotZbo4mFMtlEpUmezVGvUoG6LU1AXp01nUUXeuxzmaWP6wL AWdSq4z9EBgFMchKOn1Ft/Yq1d7Vf3kzHHY+D+wtRWICpZrCLsw780kdJnB4XrvsNxIM 4e5AxAd3MsjBVBUJnQIcb4QfHfL9bfuKEaXOS28c9f0Ni7YK7lo7yqzPMzYB4cZn8qfh CaZA== X-Forwarded-Encrypted: i=1; AJvYcCXtiwMbj6gb/gI7u5QxcdNeZIF6D+Y6OlNWuiM6N7iHhiierQ1IfMXCihI3bQVY1SoD2Cma+D/IvnzoVQM=@vger.kernel.org X-Gm-Message-State: AOJu0Yxr02aqN14h4ppoUvkEFRlY7wflt3DjcPE+OxSe+oQu/0OMZsoq KvXf3GAKB3gyTCTnWwv5TZVHSkI1cmMWhSPaumQveoBI8M2MImlrr7Yi2gWodBU= X-Gm-Gg: ASbGncvOSj9RgGI3rsnx+9mUzmGLNprT2Z3g7DWZwjwaBYVRQY8OvI6TdHzWbIxLBDM 7Wr/VPmEJNyeGNZrqyFBmecMg+IPmIPGAeWrC5vWBNj7eszPnm/vlqBrVJEDuhdGpZCLWnMYeN0 I/KbHY9kIztajH9/3xJP7pQY/xdwP3wC6Mndhq5IVu/1vAz+kFogweBIRvGGCcPKP9a9FBrQRZl w66pVX/LhaFofe+4edK9WYiP0P5rppNHcVPvs9GHKrLpmUHYuPeVnRekV+ZaHW4fRVUzfy13dIK mnVPMAYmUQWx0PN1NrR5HW/AEz0zb/Zl+IIcMcFFG0CCapU9/TcxP4noPRmgQ7HU+hY/ X-Google-Smtp-Source: AGHT+IHtzafs1U3OlDFbdl1EHKhqDpSLv5FVfv0SchkozUHNmBnUPWs9GEdrQlZ8/5oMkLAgq6/HDw== X-Received: by 2002:a17:907:72d0:b0:ac7:e4b5:4827 with SMTP id a640c23a62f3a-ace5a484e6dmr564732266b.28.1745594327250; Fri, 25 Apr 2025 08:18:47 -0700 (PDT) Received: from [127.0.1.1] ([185.164.142.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ace6e59649fsm151099766b.85.2025.04.25.08.18.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 08:18:46 -0700 (PDT) From: Lukasz Czechowski Date: Fri, 25 Apr 2025 17:18:07 +0200 Subject: [PATCH v2 2/5] dt-bindings: usb: cypress,hx3: Add support for all variants Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250425-onboard_usb_dev-v2-2-4a76a474a010@thaumatec.com> References: <20250425-onboard_usb_dev-v2-0-4a76a474a010@thaumatec.com> In-Reply-To: <20250425-onboard_usb_dev-v2-0-4a76a474a010@thaumatec.com> To: Matthias Kaehlcke , Greg Kroah-Hartman , Benjamin Bara , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Klaus Goger Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Lukasz Czechowski , stable@vger.kernel.org X-Mailer: b4 0.14.2 The Cypress HX3 hubs use different default PID value depending on the variant. Update compatibles list. Becasuse all hub variants use the same driver data, allow the dt node to have two compatibles: leftmost which matches the HW exactly, and the second one as fallback. Fixes: 1eca51f58a10 ("dt-bindings: usb: Add binding for Cypress HX3 USB 3.0= family") Cc: stable@vger.kernel.org # 6.6 Cc: stable@vger.kernel.org # Backport of the patch ("dt-bindings: usb: usb-= device: relax compatible pattern to a contains") from list: https://lore.ke= rnel.org/linux-usb/20250418-dt-binding-usb-device-compatibles-v2-1-b3029f14= e800@cherry.de/ Cc: stable@vger.kernel.org # Backport of the patch in this series fixing pr= oduct ID in onboard_dev_id_table in drivers/usb/misc/onboard_usb_dev.c driv= er Signed-off-by: Lukasz Czechowski Reviewed-by: Rob Herring (Arm) --- .../devicetree/bindings/usb/cypress,hx3.yaml | 19 +++++++++++++++= +--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/cypress,hx3.yaml b/Docum= entation/devicetree/bindings/usb/cypress,hx3.yaml index 1033b7a4b8f953424cc3d31d561992c17f3594b2..d6eac1213228d2acb50ebc959d1= ff15134c5a91c 100644 --- a/Documentation/devicetree/bindings/usb/cypress,hx3.yaml +++ b/Documentation/devicetree/bindings/usb/cypress,hx3.yaml @@ -14,9 +14,22 @@ allOf: =20 properties: compatible: - enum: - - usb4b4,6504 - - usb4b4,6506 + oneOf: + - enum: + - usb4b4,6504 + - usb4b4,6506 + - items: + - enum: + - usb4b4,6500 + - usb4b4,6508 + - const: usb4b4,6504 + - items: + - enum: + - usb4b4,6502 + - usb4b4,6503 + - usb4b4,6507 + - usb4b4,650a + - const: usb4b4,6506 =20 reg: true =20 --=20 2.43.0 From nobody Fri Dec 19 06:18:34 2025 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E2852820DA for ; Fri, 25 Apr 2025 15:18:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745594332; cv=none; b=KdZpv3h2BIfNQrO0szo1GrHPVdZkRmfzJzUHb6pCRJ6LWIuezW3+Dy2MYghLjNFNLZbYq9g1kkushBnRdzv6QRZ66pl7MPupcVoXb8MMf2dAJlZBNLIqHb3fMtJ91JplA5KXXGVjein8wjW0rvEQ9JC/W2Ux2GdviSk/p7JVDnk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745594332; c=relaxed/simple; bh=OraUiKfm1Dyuf5j7XdekXggByDjVCkBh3H2EGp18ffI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=h/0DZ2gbyEyOQatg01GxwmEle6Pi9vX+7VE/XGw+W23ow9WsrO7wpwgJwvEcgZa902locYAdiPmLWk4hrxtlSynLzxGy2h21t3Ip/D+sn9KbeHUVMzwi19K2KXRRjfdN8V3Bp/6iJHB5Ws6ndUIR45N2O/kyiFPdgTEFr88GtkM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=thaumatec.com; spf=pass smtp.mailfrom=thaumatec.com; dkim=pass (2048-bit key) header.d=thaumatec-com.20230601.gappssmtp.com header.i=@thaumatec-com.20230601.gappssmtp.com header.b=sQWUlTDm; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=thaumatec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=thaumatec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=thaumatec-com.20230601.gappssmtp.com header.i=@thaumatec-com.20230601.gappssmtp.com header.b="sQWUlTDm" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-ac34257295dso394109566b.2 for ; Fri, 25 Apr 2025 08:18:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thaumatec-com.20230601.gappssmtp.com; s=20230601; t=1745594328; x=1746199128; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3NqGpeCgEQAUcPs6hxmWuzzpxKmr/yNO0w1y1ZqO3+o=; b=sQWUlTDmlF9kKrpIOx2QFPry03qIbhgA1GzI4Mq8Vt8juEe8Pryqngtr0hc5SMEpiA QqEKmwgYjNmLWatq8Hquxw+tJ3OSrMJV8PSD2e6TlkVtXvquv4u+k3J2kT+tqsi5Pb9/ YlCJvNjxSYvZJABQYl7GYAtKQJzGOM3iQmKi+c9Gdp/JzjD0+1O+cXOfKOMWZiP529jC g/DDqh9CXMtWOxmYtdWNG99k+WjO3TdcgvfNztchA4xluN4rS1ITI55IIJPfInglxcma DZo7f9zRMohQClSlYRjpfUkqHUnnQRvOLy8F64lUsPSNRgH7JsrDlA2sVaT+KQ5qbm2S TN1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745594328; x=1746199128; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3NqGpeCgEQAUcPs6hxmWuzzpxKmr/yNO0w1y1ZqO3+o=; b=FNF5GgQ6eRVPg2X46fjFy6UsOHkVQZX/nV589m5JKn5HgsDObO+mncX8fE/eK4LhVW SVwsFjCDEK1gO8/jwTDY4ykqsdWYYOyQnVJV4CfMJE26Iil6LOjdMBrHJF++Zu3Zjbay 82Nibm0evKlx0GHSDIM1NLweMsdHmKG6GaLmWHXgaipW0FEm0mFJxbenaGpz7PDUQmYR f5s419sYtEkWZch6Gh/1uYqicZTPIza0HtkAclpn3nG/ttwoRAyUS0RDrHRfNB9Umudx hmzS31uvoJBgDWHOD0DqHVm/rVucYw+gUIrdxuPTr6xA9H5y7bFCZm1z/cThj2TW45bu BTiA== X-Forwarded-Encrypted: i=1; AJvYcCW7E5PVWJaD0sbiNhjSQ7djA0i7PqQl29m2GeHeyLOl/f3O4WrPtPzwrsLovrm/jVzOGGltz5UmPrfG+Bc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9xFPwAMtOABUADO7so0f9BMjfDpPuGh49gh6VoG0NDrtSWJHk Q6T9IdB/VRETZVYLOfnRlPc0RlaAzTkFQ9BkRQ1yNAnlD/3ICPk8nWZN1zLpn18= X-Gm-Gg: ASbGncvJ2UuNGeleHy0gHi9R9f0Ri6K1Bhz8l+QEglf0n5srveh5lgWwnmRxKC1N+hM M1J9N0eZU2n1B1bx6Yf8BfFd2N3D8KXlg/KKaQGHwKQqKDAzn/h/2RKL05uPxAWyYbIJJJ4p/om uMpNyMrWQOlc0tXKVGb7kB5Mr2Sj3OZ1AIODeNKGW8SwsiIwCrOYjOfK0n98FdNGaR70QbBUUi9 ZpzaUU4vr19v0sA2fWzXR/pQ7M6vEFeIMLaKGkNPRyLX+ZxoNzQbmbCfwyPrZV4x+ysZBQ6zZtg SUGYKdsSe1qDPX5BxC0ZObwJ5LATtY3tZz3eDhbPMJXPs/Xc8Kz0EMUw5g== X-Google-Smtp-Source: AGHT+IEUamcP+7odYOOdpoBpwq4Ga4sU/sBxRb/GHkSRX9M2Uw0bvZNoH1NBuPxH9S4vCQHnw3MNhg== X-Received: by 2002:a17:907:72cf:b0:ac7:150e:8013 with SMTP id a640c23a62f3a-ace710a20a1mr291795166b.15.1745594328214; Fri, 25 Apr 2025 08:18:48 -0700 (PDT) Received: from [127.0.1.1] ([185.164.142.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ace6e59649fsm151099766b.85.2025.04.25.08.18.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 08:18:48 -0700 (PDT) From: Lukasz Czechowski Date: Fri, 25 Apr 2025 17:18:08 +0200 Subject: [PATCH v2 3/5] arm64: dts: rockchip: fix internal USB hub instability on RK3399 Puma Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250425-onboard_usb_dev-v2-3-4a76a474a010@thaumatec.com> References: <20250425-onboard_usb_dev-v2-0-4a76a474a010@thaumatec.com> In-Reply-To: <20250425-onboard_usb_dev-v2-0-4a76a474a010@thaumatec.com> To: Matthias Kaehlcke , Greg Kroah-Hartman , Benjamin Bara , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Klaus Goger Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Lukasz Czechowski , stable@vger.kernel.org X-Mailer: b4 0.14.2 Currently, the onboard Cypress CYUSB3304 USB hub is not defined in the device tree, and hub reset pin is provided as vcc5v0_host regulator to usb phy. This causes instability issues, as a result of improper reset duration. The fixed regulator device requests the GPIO during probe in its inactive state (except if regulator-boot-on property is set, in which case it is requested in the active state). Considering gpio is GPIO_ACTIVE_LOW for Puma, it means it=E2=80=99s driving it high. Then the regulator gets enabled (because regulator-always-on property), which drives it to its active state, meaning driving it low. The Cypress CYUSB3304 USB hub actually requires the reset to be asserted for at least 5 ms, which we cannot guarantee right now since there's no delay in the current config, meaning the hub may sometimes work or not. We could add delay as offered by fixed-regulator but let's rather fix this by using the proper way to model onboard USB hubs. Define hub_2_0 and hub_3_0 nodes, as the onboard Cypress hub consist of two 'logical' hubs, for USB2.0 and USB3.0. Use the 'reset-gpios' property of hub to assign reset pin instead of using regulator. Rename the vcc5v0_host regulator to cy3304_reset to be more meaningful. Pin is configured to output-high by default, which sets the hub in reset state during pin controller initialization. This allows to avoid double enumeration of devices in case the bootloader has setup the USB hub before the kernel. The vdd-supply and vdd2-supply properties in hub nodes are added to provide correct dt-bindings, although power supplies are always enabled based on HW design. Fixes: 2c66fc34e945 ("arm64: dts: rockchip: add RK3399-Q7 (Puma) SoM") Cc: stable@vger.kernel.org # 6.6 Cc: stable@vger.kernel.org # Backport of the patch in this series fixing pr= oduct ID in onboard_dev_id_table in drivers/usb/misc/onboard_usb_dev.c driv= er Signed-off-by: Lukasz Czechowski --- arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi | 40 +++++++++++++++++------= ---- 1 file changed, 26 insertions(+), 14 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi b/arch/arm64/boo= t/dts/rockchip/rk3399-puma.dtsi index 995b30a7aae01a0326e9f80d6be930f227968539..dd5a9bca26d1d221607e7307168= 5d5774330d760 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi @@ -60,16 +60,6 @@ vcc3v3_sys: regulator-vcc3v3-sys { vin-supply =3D <&vcc5v0_sys>; }; =20 - vcc5v0_host: regulator-vcc5v0-host { - compatible =3D "regulator-fixed"; - gpio =3D <&gpio4 RK_PA3 GPIO_ACTIVE_LOW>; - pinctrl-names =3D "default"; - pinctrl-0 =3D <&vcc5v0_host_en>; - regulator-name =3D "vcc5v0_host"; - regulator-always-on; - vin-supply =3D <&vcc5v0_sys>; - }; - vcc5v0_sys: regulator-vcc5v0-sys { compatible =3D "regulator-fixed"; regulator-name =3D "vcc5v0_sys"; @@ -521,10 +511,10 @@ pmic_int_l: pmic-int-l { }; }; =20 - usb2 { - vcc5v0_host_en: vcc5v0-host-en { + usb { + cy3304_reset: cy3304-reset { rockchip,pins =3D - <4 RK_PA3 RK_FUNC_GPIO &pcfg_pull_none>; + <4 RK_PA3 RK_FUNC_GPIO &pcfg_output_high>; }; }; =20 @@ -591,7 +581,6 @@ u2phy1_otg: otg-port { }; =20 u2phy1_host: host-port { - phy-supply =3D <&vcc5v0_host>; status =3D "okay"; }; }; @@ -603,6 +592,29 @@ &usbdrd3_1 { &usbdrd_dwc3_1 { status =3D "okay"; dr_mode =3D "host"; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&cy3304_reset>; + #address-cells =3D <1>; + #size-cells =3D <0>; + + hub_2_0: hub@1 { + compatible =3D "usb4b4,6502", "usb4b4,6506"; + reg =3D <1>; + peer-hub =3D <&hub_3_0>; + reset-gpios =3D <&gpio4 RK_PA3 GPIO_ACTIVE_HIGH>; + vdd-supply =3D <&vcc1v2_phy>; + vdd2-supply =3D <&vcc3v3_sys>; + + }; + + hub_3_0: hub@2 { + compatible =3D "usb4b4,6500", "usb4b4,6504"; + reg =3D <2>; + peer-hub =3D <&hub_2_0>; + reset-gpios =3D <&gpio4 RK_PA3 GPIO_ACTIVE_HIGH>; + vdd-supply =3D <&vcc1v2_phy>; + vdd2-supply =3D <&vcc3v3_sys>; + }; }; =20 &usb_host1_ehci { --=20 2.43.0 From nobody Fri Dec 19 06:18:34 2025 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5181128A1CF for ; Fri, 25 Apr 2025 15:18:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745594333; cv=none; b=jPzjNV5pEifY3pp+kQAYzys7QQLbxBoItFXt3tORDtTSG8u1eCVC37pDUZrpPWqKtfKNJysZbm1lUDlZL8w5E8HQglXupKDUeO3A+V+VkU/JzZkhWko0CTccXignZM9Wzit4rD6rm0R4CM+9T5eOqW6qS7KPNSxtkmMWF91UC3U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745594333; c=relaxed/simple; bh=+VP43HO49IhC31BTb9rVuWFjBWT9hUxO1g+j9KnNrtI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YZkIGkp5nE1yCXxwgEXp2x24q+dpWMKu75Bh8PbW2G+hmhk5r7dOEezkcwaFl1o7QlOQGLnqiMYVXXXAO01/CQ5GCh3yKxlRlIr1kgwxRU12z+215q1wetUUXyTg20dy/s61ZR4n0h4V0etbv78QJAEJcdLuvB2bwRFI8eAzyck= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=thaumatec.com; spf=pass smtp.mailfrom=thaumatec.com; dkim=pass (2048-bit key) header.d=thaumatec-com.20230601.gappssmtp.com header.i=@thaumatec-com.20230601.gappssmtp.com header.b=zKYjGXSV; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=thaumatec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=thaumatec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=thaumatec-com.20230601.gappssmtp.com header.i=@thaumatec-com.20230601.gappssmtp.com header.b="zKYjGXSV" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5e5deb6482cso6170684a12.1 for ; Fri, 25 Apr 2025 08:18:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thaumatec-com.20230601.gappssmtp.com; s=20230601; t=1745594329; x=1746199129; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ow+UI0NPOq4F4k1XRdbs16ucXtgoo6yarOk2Eu1UB88=; b=zKYjGXSVsI2NLbQn1nXn3wmdAQwYoEMSMNGAkxao3Ju/Fd4xi26KP7KLhRP1WIqjiP Rs7J8UiQ2rC7Sm79meapRNs6ayVZqgaeiHf0mHH058ykIQcvbhEuAHeImZUYiitX3pLm x4xShFbUWr2lGFq2fGaJTIalVxMxmHTHHy3EW+I/bID6gUOC9VOfYFnkTjqBIxrU6JVl xs9Y1XnJatZg3rT2QwieWHkIGriHSOgeQg+IgjND91hrnuaCUyet0V5OyZORxTMBv/sd 0AkyDTk18BADictzlragABu8ckNJQjW+fkFYrzj0Mc9zJrPwsj2nuXnqymq0THY9nCBp 4FeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745594329; x=1746199129; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ow+UI0NPOq4F4k1XRdbs16ucXtgoo6yarOk2Eu1UB88=; b=TWD4fCA0ks9MxmRv5cI6LDEGf9/TYtG1CXnDRhy7mjgacm5evvTcL/RGikqWo5/Bmp 8y9KnhkxKW6NrjTohNTS+D0cVY5KKrNh2SRe9p0p4DoSgk38b5Fr3z3Y2aIa6dlPbaF1 tImFfSO+BciKIlMI66naaWzHvK1Q+VB3FeSYYd/DibCJpMAwaKvku1c5yo/j6xEvdqHo 7977rJ890jqfQN/SDx4C/CNGxr9gbaaEl3Uss7otHbE0QDADNMZjCgVfMmY/vNAeEyrC SpuKwSRuS4OPhOh9cKmf/BZwdEdzKt6R6KEJoFS0zWSBQlepcV2KvQBiWVxgzZk82ZUI isDQ== X-Forwarded-Encrypted: i=1; AJvYcCUkuOs7hZlwk/UeyQoGH39gUZkb9iZDOQstlYoac34u5QPrlkO2h6N7xPoujOqDa3Mxe9h+tDsP4IUvuLc=@vger.kernel.org X-Gm-Message-State: AOJu0YwfYwTrKXuNNaORzBMp2VZKYNE8WEVSyeFUFVpMJXcGOHAIF3mI B4fW6pmWBMTj4tAvvU50AOOd/O6l54v1qpjKSunwFHweebxl5KiqKXGjanK/MTE= X-Gm-Gg: ASbGncvO9P9MvAvflUjgyAAtaSEDTsuAAvpotX3KZxTn4olfzmPHsbhwRHDfM8MJ8mf nEhuUuWOPPLKa9crIneqYrglatpKxFUn9VWoKW/w9NT6oxyDiEVZFjn42zdTYqD8Bsb3D/rN8TX UIL62gZybvEcnAHXLkm+JjraPgKoaHHr5nRYhwLK4Ns6R2ytNxCfzaFUMGCvECC0yqzSlLNbh52 IsrbzbKSYNhyF3Wx/QlZa4U84gk4IZK6h26+Y2OHxoFGiyBaqES4lhqoOBMN2WyBN9hqzhH6/Gp k4NXKBR6i++lRVi9KQfVfWT6o8X5w9AgWT4bb/7TmfzUrtil6XMCZLrgLQ== X-Google-Smtp-Source: AGHT+IHLD6XdK+4P1TnWS4a50TCqQBANW7xBQ8lr6hgbyOsYBCK2P26JRQZuJdTwivbVOS6RTnoM6A== X-Received: by 2002:a17:907:3f0d:b0:ac8:1bbe:1a5b with SMTP id a640c23a62f3a-ace5a27b983mr482588066b.9.1745594329437; Fri, 25 Apr 2025 08:18:49 -0700 (PDT) Received: from [127.0.1.1] ([185.164.142.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ace6e59649fsm151099766b.85.2025.04.25.08.18.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 08:18:48 -0700 (PDT) From: Lukasz Czechowski Date: Fri, 25 Apr 2025 17:18:09 +0200 Subject: [PATCH v2 4/5] arm64: dts: rockchip: disable unrouted USB controllers and PHY on RK3399 Puma Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250425-onboard_usb_dev-v2-4-4a76a474a010@thaumatec.com> References: <20250425-onboard_usb_dev-v2-0-4a76a474a010@thaumatec.com> In-Reply-To: <20250425-onboard_usb_dev-v2-0-4a76a474a010@thaumatec.com> To: Matthias Kaehlcke , Greg Kroah-Hartman , Benjamin Bara , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Klaus Goger Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Lukasz Czechowski , Quentin Schulz X-Mailer: b4 0.14.2 From: Quentin Schulz The u2phy1_host port is the part of the USB PHY1 (namely the HOST1_DP/DM lanes) which routes directly to the USB2.0 HOST controller[1]. The other lanes of the PHY are routed to the USB3.0 OTG controller (dwc3), which we do use. The HOST1_DP/DM lanes aren't routed on RK3399 Puma so let's simply disable the USB2.0 controllers and associated part in USB2.0 PHY. No intended functional change. [1] https://rockchip.fr/Rockchip%20RK3399%20TRM%20V1.3%20Part2.pdf Chapter 2 USB2.0 PHY Fixes: 2c66fc34e945 ("arm64: dts: rockchip: add RK3399-Q7 (Puma) SoM") Signed-off-by: Quentin Schulz Signed-off-by: Lukasz Czechowski --- arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi b/arch/arm64/boo= t/dts/rockchip/rk3399-puma.dtsi index dd5a9bca26d1d221607e73071685d5774330d760..5c1162e2f34f9c9786da1f774df= fa71adda23dbc 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi @@ -579,10 +579,6 @@ &u2phy1 { u2phy1_otg: otg-port { status =3D "okay"; }; - - u2phy1_host: host-port { - status =3D "okay"; - }; }; =20 &usbdrd3_1 { @@ -616,11 +612,3 @@ hub_3_0: hub@2 { vdd2-supply =3D <&vcc3v3_sys>; }; }; - -&usb_host1_ehci { - status =3D "okay"; -}; - -&usb_host1_ohci { - status =3D "okay"; -}; --=20 2.43.0 From nobody Fri Dec 19 06:18:34 2025 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92B6128C5B9 for ; Fri, 25 Apr 2025 15:18:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745594334; cv=none; b=C+5Ju3YcM3WXJ1pusoZ0UXxR1DWhNAuVCZE6XyPUNM945BKXNIt5SdBHyX8jYKmJxGWGddOqCZPai3UHBvLS1AEmzONwSx7JkAYQJ1aZkoXPHcm3saIY/FNw/DcmVSAAIHppaIFLhbllLYrJ1zbGn92x0dbkWgZ0WRM2JD/DUUE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745594334; c=relaxed/simple; bh=+ce7+BTY4yeMzFbT6Akdy3KIL7k7OJDthEDgS6+rbEo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=owBiGQ4iLYI56FZ9cz8bsmMAt8xMYYxaL6ALhzXerRosMj3E+Smu6W88/ps1ZJs2YBcxt0TNv/d8rAV1JLbHo4oeqOG7jbKt9crmpfLq3qzArwq3QmYp7ldfdWXPy+43Kov5aRRV2FR3yRTMerAo5uvP27IGlO8eTrLoFzA0IQk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=thaumatec.com; spf=pass smtp.mailfrom=thaumatec.com; dkim=pass (2048-bit key) header.d=thaumatec-com.20230601.gappssmtp.com header.i=@thaumatec-com.20230601.gappssmtp.com header.b=lchmvhlw; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=thaumatec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=thaumatec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=thaumatec-com.20230601.gappssmtp.com header.i=@thaumatec-com.20230601.gappssmtp.com header.b="lchmvhlw" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5f62d3ed994so4259567a12.2 for ; Fri, 25 Apr 2025 08:18:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thaumatec-com.20230601.gappssmtp.com; s=20230601; t=1745594331; x=1746199131; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/OY31xp7Dll9vOIEOmAuyrG07iLGmNS/7kqtV/vhc5Y=; b=lchmvhlwO7bwGEgJBEgpZN/k4rav9vWLKDzd+soZMVH+Yz3KfIo4voaxR25W32u43K rWQ5Qs02bGwHRiGaSDpgKypd3HAQD3SVE4p+2ldw+nzx7CuWKxNvH+egV3h1Qyfd9+7Z Zvc32z+V3CaWVZ+9PMmgvZpzrFGeeHEuQqd6/IS7aN3cUyrxw/x0v3VH9urYRffqjTpX aZNTBP37pm2zShOoqvvJqbLMfKMGTrxMw6p1sYWqv21lmAdA3EIkRgXP5U3OFHDcmPbx L6q8YAwwSWf1JO05tPiiYeWQH+uLQVXfnpnHdYkbT6OSY+sFBUk6Cf2dSLhaXVuHCAvb 4hmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745594331; x=1746199131; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/OY31xp7Dll9vOIEOmAuyrG07iLGmNS/7kqtV/vhc5Y=; b=gEVwzZKO1ePEcDaqIecMNOBj+xdRcRwUFSnQJFq29yh/Ps5tkN7pVgzJnUrrIxbfDI R7/G0KSCOPA0qsANnCK0gO/nlRXmbxA2iVf8r+1nowzIS+Shbv71ZKEero5fXyHxd52g Mey/GzcTDytwi/zdrMEXqfaOc8C8noPP9txespc8phgAdRmjsMLCfu4Kw6xg2um6EkrX LO4e0GYibYmy+HbZWF55vCDgSJmUaQ7kXiJZUnq2kG2Mt994qXEKj+EVIMMiOyc/o3e4 c3Q03zItWASPraGogGkKwmQVO/sPo/Qbbbe0kxQ1YfQQxFZiQOAuzCRyBaSr2/3EsaYC P5LA== X-Forwarded-Encrypted: i=1; AJvYcCUyPnFwJh+GDNwh+oAviDSkVK4a1rWdoJG72Fi5bItI28uYh3qCN4HGwNj0y3wYasoThR/tajYRZ32XDYc=@vger.kernel.org X-Gm-Message-State: AOJu0YwG4xYMwituGtMHQyEQhyg5umDEhI9VLV/ZBsAgKi1DYqrGPDlv kUzNDlrojo9HRSRGuKOaOBcC/nDEv/k/TIqtvU4uAaFtGYPybMq9raKgvyZLpNc= X-Gm-Gg: ASbGncs5C32aKu0t5AEGl7igHuuc25QAhctraenioD6sN/yDmw2tdXKUH3/KfUVgEEi 5Rl0ljyxGMMndBaN8Xkh/m3Ehlb582wcFRK1Cd9k2EA/OpY6TNLM/D/zcRCb2XiOtrcxV3M0osc PbQdg3h7VD0lmHFLmSBcAJJIz8Khw0CDyBcsePGu7uZRu9SF3pXzlfJ2oPnsogMZ3DspAAcn7JW xXraJpmKJrFEvry/zubEix2wikQgYo1cJNsksLBupy88dqZDkl8kULoz5Qesbpw5Kg8JN1gusQw BOb4uI2wcy2u/flwZQKRf0x5+1R3FOqgmP9WiuFY5iC7yEXH3OuUYkjo/A== X-Google-Smtp-Source: AGHT+IF/D7KC9l8++rWqiUEiNq3eyx2s0Qq/rmeB9HU9Sb4W5K3CdWLHL8yd44YFf3+hogCSyIirhg== X-Received: by 2002:a17:907:2dab:b0:acb:bbc4:3344 with SMTP id a640c23a62f3a-ace71098d8dmr246518666b.22.1745594330687; Fri, 25 Apr 2025 08:18:50 -0700 (PDT) Received: from [127.0.1.1] ([185.164.142.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ace6e59649fsm151099766b.85.2025.04.25.08.18.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 08:18:50 -0700 (PDT) From: Lukasz Czechowski Date: Fri, 25 Apr 2025 17:18:10 +0200 Subject: [PATCH v2 5/5] arm64: dts: rockchip: disable unrouted USB controllers and PHY on RK3399 Puma with Haikou Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250425-onboard_usb_dev-v2-5-4a76a474a010@thaumatec.com> References: <20250425-onboard_usb_dev-v2-0-4a76a474a010@thaumatec.com> In-Reply-To: <20250425-onboard_usb_dev-v2-0-4a76a474a010@thaumatec.com> To: Matthias Kaehlcke , Greg Kroah-Hartman , Benjamin Bara , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Klaus Goger Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Lukasz Czechowski , Quentin Schulz X-Mailer: b4 0.14.2 From: Quentin Schulz The u2phy0_host port is the part of the USB PHY0 (namely the HOST0_DP/DM lanes) which routes directly to the USB2.0 HOST controller[1]. The other lanes of the PHY are routed to the USB3.0 OTG controller (dwc3), which we do use. The HOST0_DP/DM lanes aren't routed on RK3399 Puma so let's simply disable the USB2.0 controllers. USB3 OTG has been known to be unstable on RK3399 Puma Haikou for a while, one of the recurring issues being that only USB2 is detected and not USB3 in host mode. Reading the justification above and seeing that we are keeping u2phy0_host in the Haikou carrierboard DTS probably may have bothered you since it should be changed to u2phy0_otg. The issue is that if it's switched to that, USB OTG on Haikou is entirely broken. I have checked the routing in the Gerber file, the lanes are going to the expected ball pins (that is, NOT HOST0_DP/DM). u2phy0_host is for sure the wrong part of the PHY to use, but it's the only one that works at the moment for that board so keep it until we figure out what exactly is broken. No intended functional change. [1] https://rockchip.fr/Rockchip%20RK3399%20TRM%20V1.3%20Part2.pdf Chapter 2 USB2.0 PHY Fixes: 2c66fc34e945 ("arm64: dts: rockchip: add RK3399-Q7 (Puma) SoM") Signed-off-by: Quentin Schulz Signed-off-by: Lukasz Czechowski --- arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts | 8 -------- 1 file changed, 8 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts b/arch/arm= 64/boot/dts/rockchip/rk3399-puma-haikou.dts index 947bbd62a6b09ce55320d0889ee8cf50ca59dfd4..93cefacc7a01ec8f9716de82807= 7b3395a5e7696 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts @@ -292,14 +292,6 @@ &uart2 { status =3D "okay"; }; =20 -&usb_host0_ehci { - status =3D "okay"; -}; - -&usb_host0_ohci { - status =3D "okay"; -}; - &vopb { status =3D "okay"; }; --=20 2.43.0